blob: e5fe9e9ae5e445fce01d15ad61bc8222e5ae2e58 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070046using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090047using testing::internal::CaptureStderr;
48using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070049
50namespace android {
51namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070052namespace {
53
54const char kExpectedDepFileContents[] =
55R"(place/for/output/p/IFoo.java : \
56 p/IFoo.aidl
57
58p/IFoo.aidl :
59)";
60
Dan Willemsen93298ee2016-11-10 23:55:55 -080061const char kExpectedNinjaDepFileContents[] =
62R"(place/for/output/p/IFoo.java : \
63 p/IFoo.aidl
64)";
65
Jiyong Parkdf202122019-09-30 20:48:35 +090066const char kExpectedParcelableDeclarationDepFileContents[] =
67 R"( : \
68 p/Foo.aidl
69
70p/Foo.aidl :
71)";
72
73const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080074 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070075 p/Foo.aidl
76
77p/Foo.aidl :
78)";
79
Jooyung Hand2fa0232020-10-19 02:51:41 +090080const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081 R"(/*
82 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090083 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080084@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090085public class Rect implements android.os.Parcelable
86{
87 // Comment
88
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080089 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090090 public int x = 5;
91
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080092 @android.annotation.Hide
93 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000094 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090095
96 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090097
98 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090099 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
100 @Override
101 public Rect createFromParcel(android.os.Parcel _aidl_source) {
102 Rect _aidl_out = new Rect();
103 _aidl_out.readFromParcel(_aidl_source);
104 return _aidl_out;
105 }
106 @Override
107 public Rect[] newArray(int _aidl_size) {
108 return new Rect[_aidl_size];
109 }
110 };
111 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
112 {
113 int _aidl_start_pos = _aidl_parcel.dataPosition();
114 _aidl_parcel.writeInt(0);
115 _aidl_parcel.writeInt(x);
116 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900117 if ((fd!=null)) {
118 _aidl_parcel.writeInt(1);
119 fd.writeToParcel(_aidl_parcel, 0);
120 }
121 else {
122 _aidl_parcel.writeInt(0);
123 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900124 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900125 int _aidl_end_pos = _aidl_parcel.dataPosition();
126 _aidl_parcel.setDataPosition(_aidl_start_pos);
127 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
128 _aidl_parcel.setDataPosition(_aidl_end_pos);
129 }
130 public final void readFromParcel(android.os.Parcel _aidl_parcel)
131 {
132 int _aidl_start_pos = _aidl_parcel.dataPosition();
133 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900134 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900135 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900136 x = _aidl_parcel.readInt();
137 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
138 y = _aidl_parcel.readInt();
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900140 if ((0!=_aidl_parcel.readInt())) {
141 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
142 }
143 else {
144 fd = null;
145 }
146 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900147 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900148 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900149 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900150 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
151 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
152 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900153 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
154 }
155 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900156 @Override
157 public int describeContents() {
158 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900159 _mask |= describeContents(fd);
160 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900161 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900162 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900163 private int describeContents(Object _v) {
164 if (_v == null) return 0;
165 if (_v instanceof java.util.Collection) {
166 int _mask = 0;
167 for (Object o : (java.util.Collection) _v) {
168 _mask |= describeContents(o);
169 }
170 return _mask;
171 }
172 if (_v instanceof android.os.Parcelable) {
173 return ((android.os.Parcelable) _v).describeContents();
174 }
175 return 0;
176 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900177}
178)";
179
Devin Moore2f2077a2020-08-28 11:27:53 -0700180// clang-format off
181const char kExpectedCppHeaderOutput[] =
182 R"(#pragma once
183
184#include <binder/IBinder.h>
185#include <binder/IInterface.h>
186#include <binder/Status.h>
187#include <optional>
188#include <utils/String16.h>
189#include <utils/StrongPointer.h>
190#include <vector>
191
192class IFoo : public ::android::IInterface {
193public:
194 DECLARE_META_INTERFACE(Foo)
195 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
196}; // class IFoo
197class IFooDefault : public IFoo {
198public:
199 ::android::IBinder* onAsBinder() override {
200 return nullptr;
201 }
202 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
203 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
204 }
205}; // class IFooDefault
206)";
207// clang-format on
208
Christopher Wileyf8136192016-04-12 14:19:35 -0700209} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700210
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700212 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900213 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
214 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700215 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700216 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900217 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700218 args.emplace_back("aidl");
219 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700220 for (const string& s : additional_arguments) {
221 args.emplace_back(s);
222 }
223 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900224 args.emplace_back("--preprocessed=" + f);
225 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700226 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900227 args.emplace_back("--include=" + i);
228 }
229 args.emplace_back(path);
230 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900231 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900232 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700233 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900234 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900235
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700236 if (error != nullptr) {
237 *error = actual_error;
238 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900239
240 if (actual_error != AidlError::OK) {
241 return nullptr;
242 }
243
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900244 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900245 EXPECT_EQ(1ul, defined_types.size());
246
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900247 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700248 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700249
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 Options::Language GetLanguage() { return GetParam(); }
251
Christopher Wiley0522cd52015-10-28 15:39:44 -0700252 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800253 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900254 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900255 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700256};
257
Devin Moore7b8d5c92020-03-17 14:14:08 -0700258// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
259// tests with each of the supported languages as a parameter.
260INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
261 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700262 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700263 [](const testing::TestParamInfo<Options::Language>& info) {
264 return Options::LanguageToString(info.param);
265 });
266
267TEST_P(AidlTest, AcceptMissingPackage) {
268 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700269}
270
Devin Moore7b8d5c92020-03-17 14:14:08 -0700271TEST_P(AidlTest, EndsInSingleLineComment) {
272 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700273}
274
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000275TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
276 const string expected_stderr =
277 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
278 const std::string file_contents = "package a; interface IBar {}";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
282}
283
284TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
285 const string expected_stderr =
286 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
287 const std::string file_contents = "package a; interface Bar {}";
288 CaptureStderr();
289 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
290 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
291}
292
293TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
294 const string expected_stderr =
295 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
296 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
297 CaptureStderr();
298 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
299 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
300}
301
302TEST_P(AidlTest, EnumRequiresCorrectPath) {
303 const string expected_stderr =
304 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
305 const std::string file_contents = "package a; enum Bar { A, }";
306 CaptureStderr();
307 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
308 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900312 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700313 io_delegate_.SetFileContents("bar/IBar.aidl",
314 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string path = "foo/IFoo.aidl";
316 const string contents =
317 "package foo;\n"
318 "import bar.IBar;\n"
319 "interface IFoo { void f(in IBar[] input); }";
320 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700324}
325
Devin Moore7b8d5c92020-03-17 14:14:08 -0700326TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900329}
Devin Moore097a3ab2020-03-11 16:08:44 -0700330
Jiyong Park40782d02020-07-24 19:17:43 +0900331TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700332 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
333 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900334 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
335 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900339}
340
Jiyong Park40782d02020-07-24 19:17:43 +0900341TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
343 const string expected_stderr =
344 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700345 CaptureStderr();
346 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900348}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700349
Jiyong Park40782d02020-07-24 19:17:43 +0900350TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900352 const string expected_stderr =
353 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700357}
358
Devin Moore7b8d5c92020-03-17 14:14:08 -0700359TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700360 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
361 const string expected_stderr =
362 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700369 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
370 const string expected_stderr =
371 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800375}
376
Devin Moore2f2077a2020-08-28 11:27:53 -0700377TEST_P(AidlTest, AcceptNullableList) {
378 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
379 const string expected_stderr = "";
380 CaptureStderr();
381 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 const string method = "package a; interface IFoo { void f(int a, int a); }";
387 const string expected_stderr =
388 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
389 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700392}
393
Jeongik Cha13066da2020-08-06 15:43:19 +0900394TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
395 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900396 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
426 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700427 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
430 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800431}
432
Devin Moore7b8d5c92020-03-17 14:14:08 -0700433TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700434 AidlError error;
435 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
436 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800437 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900438 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700439 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
442 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800443}
444
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700446 AidlError error;
447 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
448 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000449 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900450 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900451 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Devin Moore7b8d5c92020-03-17 14:14:08 -0700458TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700461 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000462 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900463 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700464 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700465 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000466 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
468 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800469}
470
Jiyong Park40782d02020-07-24 19:17:43 +0900471TEST_P(AidlTest, ParsesNonNullableAnnotation) {
472 auto parse_result =
473 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
474 ASSERT_NE(nullptr, parse_result);
475 const AidlInterface* interface = parse_result->AsInterface();
476 ASSERT_NE(nullptr, interface);
477 ASSERT_FALSE(interface->GetMethods().empty());
478 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
479}
480
Devin Moore7b8d5c92020-03-17 14:14:08 -0700481TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900482 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
483 typenames_, GetLanguage());
484 ASSERT_NE(nullptr, parse_result);
485 const AidlInterface* interface = parse_result->AsInterface();
486 ASSERT_NE(nullptr, interface);
487 ASSERT_FALSE(interface->GetMethods().empty());
488 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
489}
490
491TEST_P(AidlTest, ParsesNonUtf8Annotations) {
492 auto parse_result =
493 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
494 ASSERT_NE(nullptr, parse_result);
495 const AidlInterface* interface = parse_result->AsInterface();
496 ASSERT_NE(nullptr, interface);
497 ASSERT_FALSE(interface->GetMethods().empty());
498 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800499}
500
Devin Moore7b8d5c92020-03-17 14:14:08 -0700501TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900502 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
503 typenames_, GetLanguage());
504 ASSERT_NE(nullptr, parse_result);
505 const AidlInterface* interface = parse_result->AsInterface();
506 ASSERT_NE(nullptr, interface);
507 ASSERT_FALSE(interface->GetMethods().empty());
508 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800509}
510
Devin Moore7b8d5c92020-03-17 14:14:08 -0700511TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700513 const string expected_stderr =
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
515 "\"vintf\"'\n"
516 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
517 "--structured\n";
518 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700520 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700523}
524
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700526 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700527 const string expected_stderr =
528 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
529 "--structured\n";
530 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700531 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700532 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700535}
536
Devin Moore7b8d5c92020-03-17 14:14:08 -0700537TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700538 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700539 const string expected_stderr =
540 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
541 "\"vintf\"'\n";
542 CaptureStderr();
543 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700544 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700547}
548
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700550 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700551 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
552 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700553 ASSERT_EQ(AidlError::OK, error);
554 ASSERT_NE(nullptr, parse_result);
555 const AidlInterface* interface = parse_result->AsInterface();
556 ASSERT_NE(nullptr, interface);
557 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700558}
559
Jeongik Cha64783ed2019-06-07 18:30:54 +0900560TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
561 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900562 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
563 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700565 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900566 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900567 "a/Foo.aidl",
568 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569
570 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700572 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900573 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700574 "Parcelable must be defined in AIDL directly.\n";
575 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900576 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700578
579 CaptureStderr();
580 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900582}
583
Jooyung Han1cbc4962020-10-25 10:07:15 +0900584TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
585 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
586 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
587 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900588 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
589
590 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900591 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900592 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
593
594 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900595 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900596 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
597
Jooyung Han1cbc4962020-10-25 10:07:15 +0900598 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900599 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
600}
601
Jooyung Han1cbc4962020-10-25 10:07:15 +0900602TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
603 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
604 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
605 CaptureStderr();
606 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
607 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 EXPECT_EQ("", GetCapturedStderr());
609
610 const string expected_to_string_method = R"--(
611 @Override
612 public String toString() {
613 switch (_tag) {
614 case a: return "a.Foo.a(" + (getA()) + ")";
615 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
616 }
617 throw new IllegalStateException("unknown field: " + _tag);
618 }
619)--";
620
621 string java_out;
622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
623 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
624}
625
Jiyong Park9aa3d042020-12-04 23:30:02 +0900626TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
627 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
628 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
629 CaptureStderr();
630 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
631 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 EXPECT_EQ("", GetCapturedStderr());
633
634 const std::string expected = R"--(
635 @Override
636 public boolean equals(Object other) {
637 if (this == other) return true;
638 if (other == null) return false;
639 if (!(other instanceof Foo)) return false;
640 Foo that = (Foo)other;
641 if (!java.util.Objects.deepEquals(a, that.a)) return false;
642 if (!java.util.Objects.deepEquals(b, that.b)) return false;
643 return true;
644 }
645
646 @Override
647 public int hashCode() {
648 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
649 }
650)--";
651
652 string java_out;
653 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
654 EXPECT_THAT(java_out, testing::HasSubstr(expected));
655}
656
657TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
658 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
659 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
660 CaptureStderr();
661 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
662 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
663 EXPECT_EQ("", GetCapturedStderr());
664
665 const std::string expected = R"--(
666 @Override
667 public boolean equals(Object other) {
668 if (this == other) return true;
669 if (other == null) return false;
670 if (!(other instanceof Foo)) return false;
671 Foo that = (Foo)other;
672 if (_tag != that._tag) return false;
673 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
674 return true;
675 }
676
677 @Override
678 public int hashCode() {
679 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
680 }
681)--";
682
683 string java_out;
684 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
685 EXPECT_THAT(java_out, testing::HasSubstr(expected));
686}
687
Jooyung Han90345002020-10-23 15:28:53 +0900688TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900689 {
Jooyung Han90345002020-10-23 15:28:53 +0900690 io_delegate_.SetFileContents("a/Foo.aidl",
691 "package a; @JavaDerive(blah=true) parcelable Foo{}");
692 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
693 CaptureStderr();
694 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
695 const std::string expected_stderr =
696 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
697 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
698 }
699
700 {
701 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
703 CaptureStderr();
704 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
705 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900706 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000707 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
708 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
710 }
711
712 {
Jooyung Han90345002020-10-23 15:28:53 +0900713 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900714 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
715 CaptureStderr();
716 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
717 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900718 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900719 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
720 EXPECT_EQ(expected_stderr, GetCapturedStderr());
721 }
722}
723
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900724TEST_P(AidlTest, ParseDescriptorAnnotation) {
725 AidlError error;
726 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
727 typenames_, GetLanguage(), &error, {"--structured"});
728 ASSERT_EQ(AidlError::OK, error);
729 ASSERT_NE(nullptr, parse_result);
730 const AidlInterface* interface = parse_result->AsInterface();
731 ASSERT_NE(nullptr, interface);
732 ASSERT_EQ("IBar", interface->GetDescriptor());
733}
734
Jiyong Park40782d02020-07-24 19:17:43 +0900735TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700736 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700737 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900738}
739
740TEST_P(AidlTest, AcceptsOnewayInterface) {
741 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700742 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700743}
Christopher Wileyef140932015-11-03 09:29:19 -0800744
Devin Moore7b8d5c92020-03-17 14:14:08 -0700745TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700746 const string oneway_method =
747 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700748 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100749}
750
Steven Moreland65297cc2020-04-20 20:17:36 -0700751TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
752 const string oneway_method =
753 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
754 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
755 ASSERT_NE(nullptr, defined);
756 const AidlInterface* iface = defined->AsInterface();
757 ASSERT_NE(nullptr, iface);
758
759 const auto& methods = iface->GetMethods();
760 ASSERT_EQ(1u, methods.size());
761 const auto& method = methods[0];
762 const AidlTypeSpecifier& ret_type = method->GetType();
763
764 // TODO(b/151102494): these annotations should be on the method
765 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
766 ASSERT_TRUE(ret_type.IsHide());
767}
768
Devin Moore7b8d5c92020-03-17 14:14:08 -0700769TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100770 string foo_interface =
771 "package a; /* foo */ interface IFoo {"
772 " /* i */ int i();"
773 " /* j */ @nullable String j();"
774 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
775
Devin Moore7b8d5c92020-03-17 14:14:08 -0700776 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100777 EXPECT_NE(nullptr, parse_result);
778 EXPECT_EQ("/* foo */", parse_result->GetComments());
779
780 const AidlInterface* interface = parse_result->AsInterface();
781 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
782 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
783 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
784}
785
Jooyung Han1a551d32020-10-05 15:37:26 +0900786TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
787 io_delegate_.SetFileContents("p/cpp_header.aidl",
788 R"(package p;
789 parcelable cpp_header cpp_header "bar/header";)");
790 import_paths_.emplace("");
791 const string input_path = "p/IFoo.aidl";
792 const string input = R"(package p;
793 import p.cpp_header;
794 interface IFoo {
795 // get bar
796 cpp_header get();
797 })";
798
799 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
800 EXPECT_NE(nullptr, parse_result);
801 const AidlInterface* interface = parse_result->AsInterface();
802 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
803}
804
Christopher Wileyef140932015-11-03 09:29:19 -0800805TEST_F(AidlTest, ParsesPreprocessedFile) {
806 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
807 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700808 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900809 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700810 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
811 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800812}
813
814TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
815 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
816 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900817
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700818 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900819 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700820 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
821 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800822}
823
Devin Moore7b8d5c92020-03-17 14:14:08 -0700824TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800825 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
826 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
827 "interface IBar {}");
828 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900829 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900830 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700831 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800832 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900833
Christopher Wiley41544372015-11-03 14:52:29 -0800834 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700835 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
836 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800837 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700838 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900839 ambiguous_type.Resolve(typenames_);
840 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800841}
842
Jiyong Park8f6ec462020-01-19 20:52:47 +0900843// Special case of PreferImportToPreprocessed. Imported type should be preferred
844// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700845TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900846 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
847 io_delegate_.SetFileContents("one/IBar.aidl",
848 "package one; "
849 "interface IBar {}");
850 preprocessed_files_.push_back("preprocessed");
851 import_paths_.emplace("");
852 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700853 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900854 EXPECT_NE(nullptr, parse_result);
855
856 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700857 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
858 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900859 // But if we request just "IBar" we should get our imported one.
860 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
861 ambiguous_type.Resolve(typenames_);
862 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
863}
864
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800865TEST_F(AidlTest, WritePreprocessedFile) {
866 io_delegate_.SetFileContents("p/Outer.aidl",
867 "package p; parcelable Outer.Inner;");
868 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
869 "interface IBar {}");
870
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900871 vector<string> args {
872 "aidl",
873 "--preprocess",
874 "preprocessed",
875 "p/Outer.aidl",
876 "one/IBar.aidl"};
877 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800878 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
879
880 string output;
881 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
882 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
883}
884
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900885TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100886 io_delegate_.SetFileContents(
887 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800888 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100889 "parcelable Rect {\n"
890 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800891 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100892 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800893 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100894 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100895 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
896 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100897 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900898 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900899 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100900 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900901
902 vector<string> args{"aidl", "Rect.aidl"};
903 Options options = Options::From(args);
904 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
905
906 string output;
907 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900908 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900909}
910
Devin Moore2f2077a2020-08-28 11:27:53 -0700911TEST_F(AidlTest, CppHeaderIncludes) {
912 io_delegate_.SetFileContents("IFoo.aidl",
913 "interface IFoo {\n"
914 " @nullable List<String> foo();\n"
915 "}");
916
917 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
918 Options options = Options::From(args);
919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
920 std::vector<std::string> empty;
921 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
922 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
923 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
924
925 // Make sure the optional and String16.h includes are added
926 string output;
927 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
928 EXPECT_EQ(kExpectedCppHeaderOutput, output);
929}
930
Devin Moore7b8d5c92020-03-17 14:14:08 -0700931TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800933 io_delegate_.SetFileContents("p/Outer.aidl",
934 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900935 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
937 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
938 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800941}
942
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800944 io_delegate_.SetFileContents("preprocessed",
945 "parcelable p.Outer.Inner;");
946 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900947 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700948 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800949 // TODO(wiley): This should actually return nullptr because we require
950 // the outer class name. However, for legacy reasons,
951 // this behavior must be maintained. b/17415692
952 EXPECT_NE(nullptr, parse_result);
953}
954
Christopher Wiley632801d2015-11-05 14:15:49 -0800955TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 const string expected_foo_stderr =
957 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
958 "Declared parcelables should be in their own file and/or cannot be used with --structured "
959 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700960 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
961
Christopher Wiley632801d2015-11-05 14:15:49 -0800962 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700963 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900965 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900967
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900969 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900971 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700973
Devin Moore097a3ab2020-03-11 16:08:44 -0700974 const string expected_bar_stderr =
975 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
976 "Declared parcelables should be in their own file and/or cannot be used with --structured "
977 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700978 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
979
Jiyong Parkda8c6932019-08-12 19:56:08 +0900980 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700981 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900983 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700984 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700985 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700986 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700987 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800989}
990
Devin Moore7b8d5c92020-03-17 14:14:08 -0700991TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700992 const string expected_stderr =
993 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
994 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700995 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
996 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700997 AidlError error;
998 CaptureStderr();
999 EXPECT_EQ(
1000 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001001 Parse("p/IFoo.aidl",
1002 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001003 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001009 AidlError error;
1010 const string expected_stderr =
1011 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1012 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1014 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001015 interface IFoo {
1016 const String DUPLICATED = "d";
1017 const int DUPLICATED = 1;
1018 }
1019 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001020 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1022 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001023}
1024
Steven Morelande689da22020-11-10 02:06:30 +00001025TEST_P(AidlTest, FailOnTooBigConstant) {
1026 AidlError error;
1027 const string expected_stderr =
1028 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1029 CaptureStderr();
1030 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1031 R"(package p;
1032 interface IFoo {
1033 const byte type2small = 256;
1034 }
1035 )",
1036 typenames_, GetLanguage(), &error));
1037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1038 EXPECT_EQ(AidlError::BAD_TYPE, error);
1039}
1040
Jooyung Han30f64ad2020-12-15 08:16:31 +09001041TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1042 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1043 CaptureStderr();
1044 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1045 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1046 EXPECT_EQ("", GetCapturedStderr());
1047 string code;
1048 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1049 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1050}
1051
Jooyung Han71a1b582020-12-25 23:58:41 +09001052TEST_F(AidlTest, ConstantValueCast) {
1053 using Ptr = unique_ptr<AidlConstantValue>;
1054 const AidlLocation& loc = AIDL_LOCATION_HERE;
1055
1056 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->Cast<char>());
1057 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->Cast<string>());
1058 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0"))->Cast<float>());
1059 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->Cast<bool>());
1060
1061 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1062 Ptr(AidlConstantValue::Integral(loc, "1")));
1063 EXPECT_EQ(2, one_plus_one.Cast<int32_t>());
1064
1065 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1066 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1067 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1068 vector<string> expected{"hello", "world"};
1069 EXPECT_EQ(expected,
1070 Ptr(AidlConstantValue::Array(loc, std::move(values)))->Cast<vector<string>>());
1071}
1072
Devin Moore7b8d5c92020-03-17 14:14:08 -07001073TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001074 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001075 const string expected_stderr =
1076 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001077 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001078 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1079 R"(package p;
1080 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001081 parcelable IBar {}
1082 parcelable StructuredParcelable {}
1083 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001084 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001085 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001086 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001087 // Parse success is important for clear error handling even if the cases aren't
1088 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001089 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001090}
1091
Devin Moore7b8d5c92020-03-17 14:14:08 -07001092TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001093 AidlError error;
1094 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1095 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001096 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001097 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1098 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001099}
1100
Steven Morelandf9e922f2020-07-08 21:15:27 +00001101TEST_P(AidlTest, FailOnEmptyListWithComma) {
1102 AidlError error;
1103 const string expected_stderr =
1104 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1105 CaptureStderr();
1106 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1107 typenames_, GetLanguage(), &error));
1108 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1109 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1110}
1111
Devin Moore7b8d5c92020-03-17 14:14:08 -07001112TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001113 AidlError error;
1114 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001115 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001116 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001117 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1118 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001119 interface IFoo {
1120 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1121 }
1122 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001123 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001124 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1125 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001126}
1127
Jiyong Park18132182020-06-08 20:24:40 +09001128TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1129 AidlError error;
1130 const string expected_stderr =
1131 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1132 "cpp_header (which can also be used as an identifier)\n";
1133 CaptureStderr();
1134 // Notice the trailing dot(.) in the name, which isn't a correct name
1135 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1136 GetLanguage(), &error));
1137 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1138 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1139}
1140
1141TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1142 AidlError error;
1143 const string expected_stderr =
1144 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1145 "cpp_header (which can also be used as an identifier)\n";
1146 CaptureStderr();
1147 // Notice the trailing dot(.) in the package name
1148 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1149 GetLanguage(), &error));
1150 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1151 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1152}
1153
Devin Moore7b8d5c92020-03-17 14:14:08 -07001154TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001155 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001156 auto parse_result = Parse("p/IFoo.aidl",
1157 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001158 interface IFoo {
1159 const int POSITIVE_HEX_VALUE = 0xf5;
1160 }
1161 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001162 typenames_, GetLanguage(), &error);
1163 EXPECT_NE(nullptr, parse_result);
1164 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001165 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001166 const auto& cpp_constants = interface->GetConstantDeclarations();
1167 EXPECT_EQ((size_t)1, cpp_constants.size());
1168 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001169 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001170 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001171}
1172
Devin Moore7b8d5c92020-03-17 14:14:08 -07001173TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001174 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001175 auto parse_result = Parse("p/IFoo.aidl",
1176 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001177 interface IFoo {
1178 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1179 }
1180 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001181 typenames_, GetLanguage(), &error);
1182 ASSERT_NE(nullptr, parse_result);
1183 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001184 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001185 const auto& cpp_constants = interface->GetConstantDeclarations();
1186 EXPECT_EQ((size_t)1, cpp_constants.size());
1187 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001188 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001189 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001190}
1191
Devin Moore7b8d5c92020-03-17 14:14:08 -07001192TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001193 io_delegate_.SetFileContents(
1194 "p/Outer.aidl",
1195 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001196 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001197 const string input_path = "p/IFoo.aidl";
1198 const string input = "package p; import p.Outer; interface IFoo"
1199 " { Outer.Inner get(); }";
1200
Devin Moore7b8d5c92020-03-17 14:14:08 -07001201 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1202 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001203
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001204 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001205 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001206 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1207 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001208}
1209
Devin Moore7b8d5c92020-03-17 14:14:08 -07001210TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001211 io_delegate_.SetFileContents(
1212 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001213 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001214 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001215 const string input_path = "p/IFoo.aidl";
1216 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001217 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1218 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001219 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001220 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1221 native_type.Resolve(typenames_);
1222
1223 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1224 // C++ understands C++ specific stuff
1225 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1226 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001227 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001228 EXPECT_EQ(1u, headers.size());
1229 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001230}
1231
Christopher Wileyf8136192016-04-12 14:19:35 -07001232TEST_F(AidlTest, WritesCorrectDependencyFile) {
1233 // While the in tree build system always gives us an output file name,
1234 // other android tools take advantage of our ability to infer the intended
1235 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001236 vector<string> args = {
1237 "aidl",
1238 "-d dep/file/path",
1239 "-o place/for/output",
1240 "p/IFoo.aidl"};
1241 Options options = Options::From(args);
1242 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001243 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001244 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001245 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001246 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1247}
1248
Dan Willemsen93298ee2016-11-10 23:55:55 -08001249TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1250 // While the in tree build system always gives us an output file name,
1251 // other android tools take advantage of our ability to infer the intended
1252 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001253 vector<string> args = {
1254 "aidl",
1255 "-d dep/file/path",
1256 "--ninja",
1257 "-o place/for/output",
1258 "p/IFoo.aidl"};
1259 Options options = Options::From(args);
1260 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001261 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001262 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001263 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001264 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1265}
1266
Jiyong Parkdf202122019-09-30 20:48:35 +09001267TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001268 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1269 // this by calling aidl with every .aidl file it finds, then parsing the
1270 // generated dependency files. Those that reference .java output files are
1271 // for interfaces and those that do not are parcelables. However, for both
1272 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001273 vector<string> args = {
1274 "aidl",
1275 "-o place/for/output",
1276 "-d dep/file/path",
1277 "p/Foo.aidl"};
1278 Options options = Options::From(args);
1279 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001280 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001281 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001282 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001283 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1284}
1285
1286TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1287 vector<string> args = {
1288 "aidl",
1289 "--structured",
1290 "-o place/for/output",
1291 "-d dep/file/path",
1292 "p/Foo.aidl"};
1293 Options options = Options::From(args);
1294 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1295 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1296 string actual_dep_file_contents;
1297 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1298 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001299}
1300
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001301TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1302 vector<string> args = {
1303 "aidl",
1304 "--lang=java",
1305 "-o place/for/output",
1306 "p/Foo.aidl"};
1307 Options options = Options::From(args);
1308 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1309 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1310 string output_file_contents;
1311 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1312}
1313
Devin Moore21b26772020-08-26 16:37:56 -07001314TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001315 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001316 const string list_array_parcelable =
1317 "package a; parcelable Foo {\n"
1318 " List[] lists; }";
1319 CaptureStderr();
1320 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1321 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1322}
1323
Jiyong Parkf8d53612020-05-04 14:06:13 +09001324TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1325 AidlError error;
1326 string expected_stderr =
1327 "ERROR: a/IFoo.aidl:2.7-11: "
1328 "Encountered an untyped List or Map. The use of untyped List/Map is "
1329 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1330 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1331 if (GetLanguage() != Options::Language::JAVA) {
1332 expected_stderr =
1333 "ERROR: a/IFoo.aidl:2.1-7: "
1334 "Currently, only the Java backend supports non-generic List.\n";
1335 }
1336
1337 const string primitive_interface =
1338 "package a; interface IFoo {\n"
1339 " List foo(); }";
1340 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001341 AidlTypenames tn1;
1342 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001343 {"--structured"}));
1344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001345
1346 string primitive_parcelable =
1347 "package a; parcelable IFoo {\n"
1348 " List foo;}";
1349 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001350 AidlTypenames tn2;
1351 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001352 {"--structured"}));
1353 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1354}
1355
Jeongik Cha225519b2020-08-29 01:55:32 +09001356TEST_P(AidlTest, ExtensionTest) {
1357 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001358 string extendable_parcelable =
1359 "package a; parcelable Data {\n"
1360 " ParcelableHolder extension;\n"
1361 " ParcelableHolder extension2;\n"
1362 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001363 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001364 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1365 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001366 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001367 "yet.\n",
1368 GetCapturedStderr());
1369 } else {
1370 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1371 EXPECT_EQ("", GetCapturedStderr());
1372 }
1373}
1374TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1375 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001376 string parcelableholder_return_interface =
1377 "package a; interface IFoo {\n"
1378 " ParcelableHolder foo();\n"
1379 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001380 EXPECT_EQ(nullptr,
1381 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001382
Jeongik Cha8f02a532020-10-14 00:16:28 +09001383 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001384 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001385 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001386 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001387 "yet.\n",
1388 GetCapturedStderr());
1389 return;
1390 }
1391 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1392 GetCapturedStderr());
1393}
1394
1395TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1396 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001397 string extendable_parcelable_arg_interface =
1398 "package a; interface IFoo {\n"
1399 " void foo(in ParcelableHolder ph);\n"
1400 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001401 EXPECT_EQ(nullptr,
1402 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1403
Jeongik Cha8f02a532020-10-14 00:16:28 +09001404 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001405 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001406 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001407 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001408 "yet.\n",
1409 GetCapturedStderr());
1410 return;
1411 }
1412 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1413 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001414}
1415
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001416TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1417 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1418 Options options =
1419 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1420 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1421 CaptureStderr();
1422 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1423 if (GetLanguage() == Options::Language::RUST) {
1424 EXPECT_EQ(
1425 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1426 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1427 "yet.\n",
1428 GetCapturedStderr());
1429 return;
1430 }
1431 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1432}
1433
Jooyung Han3f347ca2020-12-01 12:41:50 +09001434TEST_P(AidlTest, ParcelablesWithConstants) {
1435 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1436 Options options =
1437 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1438 CaptureStderr();
1439 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1440 EXPECT_EQ("", GetCapturedStderr());
1441}
1442
1443TEST_P(AidlTest, UnionWithConstants) {
1444 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1445 Options options =
1446 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1447 CaptureStderr();
1448 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1449 EXPECT_EQ("", GetCapturedStderr());
1450}
1451
Jiyong Park02da7422018-07-16 16:00:26 +09001452TEST_F(AidlTest, ApiDump) {
1453 io_delegate_.SetFileContents(
1454 "foo/bar/IFoo.aidl",
1455 "package foo.bar;\n"
1456 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001457 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001458 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001459 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001460 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1461 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1462 " IFoo foo3(IFoo foo);\n"
1463 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001464 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001465 " const int A = 1;\n"
1466 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001467 "}\n");
1468 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1469 "package foo.bar;\n"
1470 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001471 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001472 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001473 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001474 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001475 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001476 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001477 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001478 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001479 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001480 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001481 "}\n");
1482 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001483 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1484 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001485 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001486 bool result = dump_api(options, io_delegate_);
1487 ASSERT_TRUE(result);
1488 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001489 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001490 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001491/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001492interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001493 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001494 int foo(out int[] a, String b, boolean c, inout List<String> d);
1495 int foo2(@utf8InCpp String x, inout List<String> y);
1496 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1497 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001498 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001499 const int A = 1;
1500 const String STR = "Hello";
1501}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001502)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001503
Jiyong Parke59c3682018-09-11 23:10:25 +09001504 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001505 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001506/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001507parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001508 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001509 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001510 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001511 int y;
1512 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001513 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001514 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001515}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001516)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001517}
1518
Jiyong Parked65bf42018-08-28 15:43:27 +09001519TEST_F(AidlTest, ApiDumpWithManualIds) {
1520 io_delegate_.SetFileContents(
1521 "foo/bar/IFoo.aidl",
1522 "package foo.bar;\n"
1523 "interface IFoo {\n"
1524 " int foo() = 1;\n"
1525 " int bar() = 2;\n"
1526 " int baz() = 10;\n"
1527 "}\n");
1528
Jiyong Parke59c3682018-09-11 23:10:25 +09001529 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001530 Options options = Options::From(args);
1531 bool result = dump_api(options, io_delegate_);
1532 ASSERT_TRUE(result);
1533 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001534 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001535 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001536interface IFoo {
1537 int foo() = 1;
1538 int bar() = 2;
1539 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001540}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001541)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001542}
1543
1544TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001545 const string expected_stderr =
1546 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1547 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001548 io_delegate_.SetFileContents(
1549 "foo/bar/IFoo.aidl",
1550 "package foo.bar;\n"
1551 "interface IFoo {\n"
1552 " int foo() = 1;\n"
1553 " int bar();\n"
1554 " int baz() = 10;\n"
1555 "}\n");
1556
Jiyong Parke59c3682018-09-11 23:10:25 +09001557 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001558 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001559 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001560 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001561 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001562}
1563
Jooyung Han965e31d2020-11-27 12:30:16 +09001564TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1565 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1566 "package foo.bar;\n"
1567 "interface IFoo {\n"
1568 " @utf8InCpp String foo();\n"
1569 " const @utf8InCpp String bar = \"bar\";\n"
1570 "}\n");
1571
1572 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1573 Options options = Options::From(args);
1574 CaptureStderr();
1575 EXPECT_TRUE(dump_api(options, io_delegate_));
1576 EXPECT_EQ("", GetCapturedStderr());
1577 string actual;
1578 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001579 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1580interface IFoo {
1581 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001582 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001583}
1584)"),
1585 actual);
1586}
1587
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001588TEST_F(AidlTest, ApiDumpWithEnums) {
1589 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1590 "package foo.bar;\n"
1591 "enum Enum {\n"
1592 " FOO,\n"
1593 " BAR = FOO + 1,\n"
1594 "}\n");
1595
1596 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1597 Options options = Options::From(args);
1598 CaptureStderr();
1599 EXPECT_TRUE(dump_api(options, io_delegate_));
1600 EXPECT_EQ("", GetCapturedStderr());
1601 string actual;
1602 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1603 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1604 "enum Enum {\n"
1605 " FOO = 0,\n"
1606 " BAR = 1,\n"
1607 "}\n"),
1608 actual);
1609}
1610
1611TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1612 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1613 "package foo.bar;\n"
1614 "enum Enum {\n"
1615 " FOO,\n"
1616 "}\n");
1617 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1618 "package foo.bar;\n"
1619 "import foo.bar.Enum;\n"
1620 "parcelable Foo {\n"
1621 " Enum e = Enum.FOO;\n"
1622 "}\n");
1623
1624 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1625 Options options = Options::From(args);
1626 CaptureStderr();
1627 EXPECT_TRUE(dump_api(options, io_delegate_));
1628 EXPECT_EQ("", GetCapturedStderr());
1629 string actual;
1630 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1631 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1632 "parcelable Foo {\n"
1633 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1634 "}\n"),
1635 actual);
1636}
1637
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001638TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001639 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001640 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1641 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001642 const string expected_map_stderr =
1643 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001644 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1645 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001646 "package p; interface IFoo {"
1647 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001648 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001649 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001650 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001651
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001652 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001653 "package p; interface IFoo {"
1654 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001656 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001657 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001658}
1659
Jeongik Chae48d9942020-01-02 17:39:00 +09001660TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001661 const string expected_stderr =
1662 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001663 Options options = Options::From("aidl -I p p/IFoo.aidl");
1664 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1665
1666 io_delegate_.SetFileContents("p/IFoo.aidl",
1667 "package p; interface IFoo {"
1668 "Map<String, Bar> foo();}");
1669 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1670
1671 io_delegate_.SetFileContents("p/IFoo.aidl",
1672 "package p; interface IFoo {"
1673 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001674 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001675 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001676 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001677
1678 io_delegate_.SetFileContents("p/IFoo.aidl",
1679 "package p; interface IFoo {"
1680 "Map<String, String> foo();}");
1681 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1682
1683 io_delegate_.SetFileContents("p/IFoo.aidl",
1684 "package p; interface IFoo {"
1685 "Map<String, ParcelFileDescriptor> foo();}");
1686 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1687}
1688
Jeongik Chadf76dc72019-11-28 00:08:47 +09001689TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001690 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001691 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1692 io_delegate_.SetFileContents(options.InputFiles().front(),
1693 "package p; interface IFoo {"
1694 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001695 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001696 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001697 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001698}
1699
1700TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1701 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1702 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001703 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001704 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001705 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1706 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001707
1708 Options options = Options::From("aidl -I p p/IFoo.aidl");
1709 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1710 io_delegate_.SetFileContents("p/IFoo.aidl",
1711 "package p; interface IFoo {"
1712 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001713 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001714 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001715 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001716 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001717 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001718 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001719 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1720 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001721 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1722 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1723 io_delegate_.SetFileContents("p/IFoo.aidl",
1724 "package p; interface IFoo {"
1725 "Bar<String, ParcelFileDescriptor> foo();}");
1726 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001727
1728 io_delegate_.SetFileContents("p/IFoo.aidl",
1729 "package p; interface IFoo {"
1730 "Bar<int, long> foo();}");
1731
1732 io_delegate_.SetFileContents("p/IFoo.aidl",
1733 "package p; interface IFoo {"
1734 "Bar<int[], long[]> foo();}");
1735
1736 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001737}
1738
Jeongik Cha0e426012019-07-29 15:57:02 +09001739TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1740 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001741 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1742 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001743 for (const auto& rawOption : rawOptions) {
1744 string expected_stderr =
1745 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001746 Options options = Options::From(rawOption);
1747 io_delegate_.SetFileContents(options.InputFiles().front(),
1748 "package foo.bar;\n"
1749 "interface IFoo1 { int foo(); }\n"
1750 "interface IFoo2 { int foo(); }\n"
1751 "parcelable Data1 { int a; int b;}\n"
1752 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001753 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001754 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001755 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001756
Jeongik Cha0e426012019-07-29 15:57:02 +09001757 io_delegate_.SetFileContents(options.InputFiles().front(),
1758 "package foo.bar;\n"
1759 "interface IFoo1 { int foo(); }\n"
1760 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001761 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001762 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001763 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001764
Devin Moore5de18ed2020-04-02 13:52:29 -07001765 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001766 io_delegate_.SetFileContents(options.InputFiles().front(),
1767 "package foo.bar;\n"
1768 "parcelable Data1 { int a; int b;}\n"
1769 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001770 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001771 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001773 }
1774}
1775
Devin Moorebdba2a82020-03-31 15:19:02 -07001776TEST_P(AidlTest, FailParseOnEmptyFile) {
1777 const string contents = "";
1778 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1779 CaptureStderr();
1780 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1781 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1782}
1783
Jiyong Parkb034bf02018-07-30 17:44:33 +09001784TEST_F(AidlTest, MultipleInputFiles) {
1785 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001786 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001787
1788 io_delegate_.SetFileContents(options.InputFiles().at(0),
1789 "package foo.bar;\n"
1790 "import foo.bar.Data;\n"
1791 "interface IFoo { Data getData(); }\n");
1792
1793 io_delegate_.SetFileContents(options.InputFiles().at(1),
1794 "package foo.bar;\n"
1795 "import foo.bar.IFoo;\n"
1796 "parcelable Data { IFoo foo; }\n");
1797
1798 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1799
1800 string content;
1801 for (const auto file : {
1802 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1803 content.clear();
1804 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1805 EXPECT_FALSE(content.empty());
1806 }
1807}
1808
1809TEST_F(AidlTest, MultipleInputFilesCpp) {
1810 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001811 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001812
1813 io_delegate_.SetFileContents(options.InputFiles().at(0),
1814 "package foo.bar;\n"
1815 "import foo.bar.Data;\n"
1816 "interface IFoo { Data getData(); }\n");
1817
1818 io_delegate_.SetFileContents(options.InputFiles().at(1),
1819 "package foo.bar;\n"
1820 "import foo.bar.IFoo;\n"
1821 "parcelable Data { IFoo foo; }\n");
1822
1823 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1824
1825 string content;
1826 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001827 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001828 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1829 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1830 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1831 content.clear();
1832 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1833 EXPECT_FALSE(content.empty());
1834 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001835}
1836
Andrei Homescub62afd92020-05-11 19:24:59 -07001837TEST_F(AidlTest, MultipleInputFilesRust) {
1838 Options options =
1839 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1840
1841 io_delegate_.SetFileContents(options.InputFiles().at(0),
1842 "package foo.bar;\n"
1843 "import foo.bar.Data;\n"
1844 "interface IFoo { Data getData(); }\n");
1845
1846 io_delegate_.SetFileContents(options.InputFiles().at(1),
1847 "package foo.bar;\n"
1848 "import foo.bar.IFoo;\n"
1849 "parcelable Data { IFoo foo; }\n");
1850
1851 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1852
1853 string content;
1854 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1855 content.clear();
1856 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1857 EXPECT_FALSE(content.empty());
1858 }
1859}
1860
Devin Moore097a3ab2020-03-11 16:08:44 -07001861TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1862 const string expected_stderr =
1863 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001864 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1865 // int getInterfaceVersion() is one of the meta transactions
1866 io_delegate_.SetFileContents(options.InputFiles().front(),
1867 "package p; interface IFoo {"
1868 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001869 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001870 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001871 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1872}
Jiyong Park309668e2018-07-28 16:55:44 +09001873
Devin Moore097a3ab2020-03-11 16:08:44 -07001874TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1875 // boolean getInterfaceVersion() is not a meta transaction, but should be
1876 // prevented because return type is not part of a method signature
1877 const string expected_stderr =
1878 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1879 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001880 io_delegate_.SetFileContents(options.InputFiles().front(),
1881 "package p; interface IFoo {"
1882 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001883 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001884 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001885 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1886}
Jiyong Park309668e2018-07-28 16:55:44 +09001887
Devin Moore097a3ab2020-03-11 16:08:44 -07001888TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001889 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001890 const string expected_stderr =
1891 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1892 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001893 io_delegate_.SetFileContents(options.InputFiles().front(),
1894 "package p; interface IFoo {"
1895 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001896 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001897 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001898 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001899
1900 // this is not a meta interface method as it differs type arguments
1901 io_delegate_.SetFileContents(options.InputFiles().front(),
1902 "package p; interface IFoo {"
1903 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001904 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001905}
1906
Daniel Norman85aed542019-08-21 12:01:14 -07001907TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001908 Options options = Options::From("aidl --checkapi old new");
1909 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1910 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1911 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1912 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1913
1914 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1915}
1916
Jiyong Park3656c3c2018-08-01 20:02:01 +09001917TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001918 Options options = Options::From("aidl --checkapi old new");
1919 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1920 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001921
1922 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1923}
1924
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001925TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1926 Options options = Options::From("aidl --checkapi old new");
1927 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1928 const string enum_definition = "package p; enum Enum { FOO }";
1929 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1930 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1931 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1932 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1933
1934 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1935}
1936
Daniel Norman85aed542019-08-21 12:01:14 -07001937class AidlTestCompatibleChanges : public AidlTest {
1938 protected:
1939 Options options_ = Options::From("aidl --checkapi old new");
1940};
1941
1942TEST_F(AidlTestCompatibleChanges, NewType) {
1943 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1944 "package p;"
1945 "interface IFoo {"
1946 " void foo(int a);"
1947 "}");
1948 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1949 "package p;"
1950 "interface IFoo {"
1951 " void foo(int a);"
1952 "}");
1953 io_delegate_.SetFileContents("new/p/IBar.aidl",
1954 "package p;"
1955 "interface IBar {"
1956 " void bar();"
1957 "}");
1958 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1959}
1960
1961TEST_F(AidlTestCompatibleChanges, NewMethod) {
1962 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1963 "package p;"
1964 "interface IFoo {"
1965 " void foo(int a);"
1966 "}");
1967 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1968 "package p;"
1969 "interface IFoo {"
1970 " void foo(int a);"
1971 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001972 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001973 "}");
1974 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1975}
1976
1977TEST_F(AidlTestCompatibleChanges, NewField) {
1978 io_delegate_.SetFileContents("old/p/Data.aidl",
1979 "package p;"
1980 "parcelable Data {"
1981 " int foo;"
1982 "}");
1983 io_delegate_.SetFileContents("new/p/Data.aidl",
1984 "package p;"
1985 "parcelable Data {"
1986 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001987 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001988 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001989 "}");
1990 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1991}
1992
1993TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1994 io_delegate_.SetFileContents("old/p/Enum.aidl",
1995 "package p;"
1996 "enum Enum {"
1997 " FOO = 1,"
1998 "}");
1999 io_delegate_.SetFileContents("new/p/Enum.aidl",
2000 "package p;"
2001 "enum Enum {"
2002 " FOO = 1,"
2003 " BAR = 2,"
2004 "}");
2005 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2006}
2007
2008TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2009 io_delegate_.SetFileContents("old/p/Enum.aidl",
2010 "package p;"
2011 "enum Enum {"
2012 " FOO = 1,"
2013 " BAR = 2,"
2014 "}");
2015 io_delegate_.SetFileContents("new/p/Enum.aidl",
2016 "package p;"
2017 "enum Enum {"
2018 " BAR = 2,"
2019 " FOO = 1,"
2020 "}");
2021 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2022}
2023
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002024TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2025 io_delegate_.SetFileContents("old/p/Union.aidl",
2026 "package p;"
2027 "union Union {"
2028 " String foo;"
2029 "}");
2030 io_delegate_.SetFileContents("new/p/Union.aidl",
2031 "package p;"
2032 "union Union {"
2033 " String foo;"
2034 " int num;"
2035 "}");
2036 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2037}
2038
Daniel Norman85aed542019-08-21 12:01:14 -07002039TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002040 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2041 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002042 "interface IFoo {"
2043 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002044 "}");
2045 io_delegate_.SetFileContents("old/p/Data.aidl",
2046 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002047 "parcelable Data {"
2048 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002049 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002050 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2051 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002052 "interface IFoo {"
2053 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002054 "}");
2055 io_delegate_.SetFileContents("new/p/Data.aidl",
2056 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002057 "parcelable Data {"
2058 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002059 "}");
2060 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2061 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002062 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002063 " void foo(int a);"
2064 "}");
2065 io_delegate_.SetFileContents("new/q/Data.aidl",
2066 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002067 "parcelable Data {"
2068 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002069 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002070 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2071}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002072
Daniel Norman85aed542019-08-21 12:01:14 -07002073TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2074 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2075 "package p;"
2076 "interface IFoo {"
2077 " void foo(int a);"
2078 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002079 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2080 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002081 "interface IFoo {"
2082 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002083 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002084 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2085}
Jiyong Parke59c3682018-09-11 23:10:25 +09002086
Daniel Norman85aed542019-08-21 12:01:14 -07002087TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002088 io_delegate_.SetFileContents("old/p/I.aidl",
2089 "package p; interface I {"
2090 "const int A = 1; }");
2091 io_delegate_.SetFileContents("new/p/I.aidl",
2092 "package p ; interface I {"
2093 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002094 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2095}
Jiyong Parka428d212018-08-29 22:26:30 +09002096
Daniel Norman85aed542019-08-21 12:01:14 -07002097TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002098 io_delegate_.SetFileContents("old/p/I.aidl",
2099 "package p; interface I {"
2100 "const int A = 1; const int B = 2;}");
2101 io_delegate_.SetFileContents("new/p/I.aidl",
2102 "package p ; interface I {"
2103 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002104 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002105}
2106
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002107TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2108 io_delegate_.SetFileContents("old/p/Foo.aidl",
2109 "package p;"
2110 "@JavaPassthrough(annotation=\"Alice\")"
2111 "@JavaPassthrough(annotation=\"Bob\")"
2112 "parcelable Foo {}");
2113 io_delegate_.SetFileContents("new/p/Foo.aidl",
2114 "package p;"
2115 "@JavaPassthrough(annotation=\"Bob\")"
2116 "@JavaPassthrough(annotation=\"Alice\")"
2117 "parcelable Foo {}");
2118 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2119}
2120
Jooyung Han00073272020-11-27 14:20:20 +09002121TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2122 io_delegate_.SetFileContents("old/p/Foo.aidl",
2123 "package p;"
2124 "parcelable Foo {}");
2125 io_delegate_.SetFileContents("new/p/Foo.aidl",
2126 "package p;"
2127 "@JavaPassthrough(annotation=\"@Deprecated\")"
2128 "parcelable Foo {}");
2129 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2130}
2131
Jooyung Han636fd2f2020-10-22 11:33:45 +09002132TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2133 io_delegate_.SetFileContents("old/p/Data.aidl",
2134 "package p;"
2135 "parcelable Data {"
2136 " int num;"
2137 "}");
2138 io_delegate_.SetFileContents(
2139 "new/p/Data.aidl",
2140 "package p;"
2141 "parcelable Data {"
2142 " int num;"
2143 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2144 "}");
2145 io_delegate_.SetFileContents("new/p/Enum.aidl",
2146 "package p;"
2147 "enum Enum {"
2148 " FOO = 0,"
2149 " BAR = 1,"
2150 "}");
2151 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2152}
2153
Daniel Norman85aed542019-08-21 12:01:14 -07002154class AidlTestIncompatibleChanges : public AidlTest {
2155 protected:
2156 Options options_ = Options::From("aidl --checkapi old new");
2157};
2158
2159TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002160 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002161 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2162 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002163 "interface IFoo {"
2164 " void foo(in String[] str);"
2165 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002166 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002167 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002168 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002169 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002170}
2171
2172TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002173 const string expected_stderr =
2174 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002175 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2176 "package p;"
2177 "interface IFoo {"
2178 " void foo(in String[] str);"
2179 " void bar(@utf8InCpp String str);"
2180 "}");
2181 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2182 "package p;"
2183 "interface IFoo {"
2184 " void foo(in String[] str);"
2185 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002186 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002187 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002188 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002189}
2190
Jiyong Parkf8d53612020-05-04 14:06:13 +09002191TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2192 const string expected_stderr =
2193 "ERROR: new/p/IFoo.aidl:1.61-65: "
2194 "Encountered an untyped List or Map. The use of untyped List/Map is "
2195 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2196 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2197 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2198 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2199 "package p;"
2200 "interface IFoo {"
2201 " void foo(in String[] str);"
2202 "}");
2203 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2204 "package p;"
2205 "interface IFoo {"
2206 " void foo(in String[] str);"
2207 " void bar(in List arg);"
2208 "}");
2209 CaptureStderr();
2210 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2212}
2213
2214TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2215 const string expected_stderr =
2216 "ERROR: new/p/Data.aidl:1.54-59: "
2217 "Encountered an untyped List or Map. The use of untyped List/Map is "
2218 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2219 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2220 "ERROR: new/p/Data.aidl: Failed to read.\n";
2221 io_delegate_.SetFileContents("old/p/Data.aidl",
2222 "package p;"
2223 "parcelable Data {"
2224 " int foo;"
2225 "}");
2226 io_delegate_.SetFileContents("new/p/Data.aidl",
2227 "package p;"
2228 "parcelable Data {"
2229 " int foo;"
2230 " @nullable List list;"
2231 "}");
2232 CaptureStderr();
2233 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2234 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2235}
2236
Daniel Norman85aed542019-08-21 12:01:14 -07002237TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002238 const string expected_stderr =
2239 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002240 io_delegate_.SetFileContents("old/p/Data.aidl",
2241 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002242 "parcelable Data {"
2243 " int foo;"
2244 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002245 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002246 io_delegate_.SetFileContents("new/p/Data.aidl",
2247 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002248 "parcelable Data {"
2249 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002250 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002251 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002252 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002253 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002254}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002255
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002256TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2257 const string expected_stderr =
2258 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2259 "backends. Please either provide a default value for this field or mark the field as "
2260 "@nullable. This value or a null value will be used automatically when an old version of "
2261 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2262 "order to make sure your code continues to be backwards compatible, make sure the default or "
2263 "null value does not cause a semantic change to this parcelable.\n";
2264 io_delegate_.SetFileContents("old/p/Data.aidl",
2265 "package p;"
2266 "parcelable Data {"
2267 " int num;"
2268 "}");
2269 io_delegate_.SetFileContents("new/p/Data.aidl",
2270 "package p;"
2271 "parcelable Data {"
2272 " int num;"
2273 " String str;"
2274 "}");
2275 CaptureStderr();
2276 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2277 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2278}
2279
Jooyung Han636fd2f2020-10-22 11:33:45 +09002280TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2281 const string expected_stderr =
2282 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2283 "Please make sure 'Enum' has '0' as a valid value.\n";
2284 io_delegate_.SetFileContents("old/p/Data.aidl",
2285 "package p;"
2286 "parcelable Data {"
2287 " int num;"
2288 "}");
2289 io_delegate_.SetFileContents("new/p/Data.aidl",
2290 "package p;"
2291 "parcelable Data {"
2292 " int num;"
2293 " p.Enum e;"
2294 "}");
2295 io_delegate_.SetFileContents("new/p/Enum.aidl",
2296 "package p;"
2297 "enum Enum {"
2298 " FOO = 1,"
2299 " BAR = 2,"
2300 "}");
2301 CaptureStderr();
2302 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2304}
2305
Daniel Norman85aed542019-08-21 12:01:14 -07002306TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002307 const string expected_stderr =
2308 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002309 io_delegate_.SetFileContents("old/p/Enum.aidl",
2310 "package p;"
2311 "enum Enum {"
2312 " FOO = 1,"
2313 " BAR = 2,"
2314 "}");
2315 io_delegate_.SetFileContents("new/p/Enum.aidl",
2316 "package p;"
2317 "enum Enum {"
2318 " BAR = 2,"
2319 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002320 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002321 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002323}
2324
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002325TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2326 const string expected_stderr =
2327 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2328 io_delegate_.SetFileContents("old/p/Union.aidl",
2329 "package p;"
2330 "union Union {"
2331 " String str;"
2332 " int num;"
2333 "}");
2334 io_delegate_.SetFileContents("new/p/Union.aidl",
2335 "package p;"
2336 "union Union {"
2337 " String str;"
2338 "}");
2339 CaptureStderr();
2340 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2342}
2343
Daniel Norman85aed542019-08-21 12:01:14 -07002344TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002345 const string expected_stderr =
2346 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002347 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2348 "package p;"
2349 "interface IFoo {"
2350 " void foo(in String[] str);"
2351 " void bar(@utf8InCpp String str);"
2352 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002353 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2354 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002355 "interface IFoo {"
2356 " void foo(in String[] str);"
2357 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002358 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002360 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002361 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002362}
2363
Daniel Norman85aed542019-08-21 12:01:14 -07002364TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002365 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002366 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2367 "package p;"
2368 "interface IFoo {"
2369 " void foo(in String[] str);"
2370 " void bar(@utf8InCpp String str);"
2371 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002372 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2373 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002374 "interface IFoo2 {"
2375 " void foo(in String[] str);"
2376 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002377 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002378 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002379 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002381}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002382
Daniel Norman85aed542019-08-21 12:01:14 -07002383TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002384 const string expected_stderr =
2385 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002386 io_delegate_.SetFileContents("old/p/Enum.aidl",
2387 "package p;"
2388 "enum Enum {"
2389 " FOO = 1,"
2390 " BAR = 2,"
2391 "}");
2392 io_delegate_.SetFileContents("new/p/Enum.aidl",
2393 "package p;"
2394 "enum Enum {"
2395 " FOO = 3,"
2396 " BAR = 2,"
2397 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002398 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002399 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002401}
2402
2403TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002404 const string expected_stderr =
2405 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2406 "from 0 to 1.\n"
2407 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2408 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002409 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2410 "package p;"
2411 "interface IFoo {"
2412 " void foo(in String[] str);"
2413 " void bar(@utf8InCpp String str);"
2414 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002415 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2416 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002417 "interface IFoo {"
2418 " void bar(@utf8InCpp String str);"
2419 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002420 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002421 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002422 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002424}
2425
2426TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002427 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002428 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2429 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002430 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002431 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002432 "parcelable Data {"
2433 " int foo;"
2434 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002435 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002436 io_delegate_.SetFileContents("new/p/Data.aidl",
2437 "package p;"
2438 "parcelable Data {"
2439 " int bar;"
2440 " int foo;"
2441 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002442 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002443 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002444 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002445}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002446
Daniel Norman85aed542019-08-21 12:01:14 -07002447TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002448 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002449 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002450 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002451 "interface IFoo {"
2452 " void foo(in String[] str);"
2453 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002454 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002455 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2456 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002457 "interface IFoo {"
2458 " void foo(out String[] str);"
2459 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002460 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002461 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002462 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002463 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002464}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002465
Daniel Norman85aed542019-08-21 12:01:14 -07002466TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002467 const string expected_stderr =
2468 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002469 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2470 "package p;"
2471 "interface IFoo {"
2472 " void foo(in String[] str);"
2473 " void bar(@utf8InCpp String str);"
2474 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002475 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2476 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002477 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002478 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002479 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002480 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002481 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002482 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002483 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002484}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002485
Daniel Norman85aed542019-08-21 12:01:14 -07002486TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002487 const string expected_stderr =
2488 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002489 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2490 "package p;"
2491 "interface IFoo {"
2492 " void foo(in String[] str);"
2493 " void bar(@utf8InCpp String str);"
2494 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002495 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2496 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002497 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002498 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002499 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002500 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002501 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002502 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002504}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002505
Jooyung Han60b2fde2020-10-29 15:12:40 +09002506TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2507 const string expected_stderr =
2508 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2509 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2510 io_delegate_.SetFileContents("old/p/Foo.aidl",
2511 "package p;"
2512 "@Backing(type=\"byte\")"
2513 "enum Foo {"
2514 " FOO, BAR,"
2515 "}");
2516 io_delegate_.SetFileContents("new/p/Foo.aidl",
2517 "package p;"
2518 "@Backing(type=\"long\")"
2519 "enum Foo {"
2520 " FOO, BAR,"
2521 "}");
2522 CaptureStderr();
2523 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2524 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2525}
2526
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002527TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2528 const string expected_stderr =
2529 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2530 "to @JavaPassthrough(annotation=\"Bob\")\n";
2531 io_delegate_.SetFileContents("old/p/Foo.aidl",
2532 "package p;"
2533 "@JavaPassthrough(annotation=\"Alice\")"
2534 "parcelable Foo {}");
2535 io_delegate_.SetFileContents("new/p/Foo.aidl",
2536 "package p;"
2537 "@JavaPassthrough(annotation=\"Bob\")"
2538 "parcelable Foo {}");
2539
2540 CaptureStderr();
2541 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2542 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2543}
2544
Devin Mooredb7ac512020-08-07 11:17:36 -07002545TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2546 const string expected_stderr =
2547 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2548 io_delegate_.SetFileContents("old/p/Foo.aidl",
2549 "package p;"
2550 "parcelable Foo {"
2551 " int A;"
2552 "}");
2553 io_delegate_.SetFileContents("new/p/Foo.aidl",
2554 "package p;"
2555 "@JavaOnlyStableParcelable parcelable Foo {"
2556 " int A;"
2557 "}");
2558 CaptureStderr();
2559 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2560 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2561}
2562
2563TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2564 const string expected_stderr =
2565 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2566 io_delegate_.SetFileContents("old/p/Foo.aidl",
2567 "package p;"
2568 "@JavaOnlyStableParcelable parcelable Foo {"
2569 " int A;"
2570 "}");
2571 io_delegate_.SetFileContents("new/p/Foo.aidl",
2572 "package p;"
2573 "parcelable Foo {"
2574 " int A;"
2575 "}");
2576 CaptureStderr();
2577 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2578 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2579}
2580
Daniel Norman85aed542019-08-21 12:01:14 -07002581TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002582 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002583 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2584 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002585 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002586 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002587 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002588 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002589}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002590
Daniel Norman85aed542019-08-21 12:01:14 -07002591TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002592 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002593 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2594 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002595 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002596 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002597 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002598}
Jiyong Parka428d212018-08-29 22:26:30 +09002599
Daniel Norman85aed542019-08-21 12:01:14 -07002600TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002601 const string expected_stderr =
2602 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002603 io_delegate_.SetFileContents("old/p/I.aidl",
2604 "package p; interface I {"
2605 "const int A = 1; const int B = 2;}");
2606 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002607 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002608 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002609 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002610}
Jiyong Parka428d212018-08-29 22:26:30 +09002611
Daniel Norman85aed542019-08-21 12:01:14 -07002612TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002613 const string expected_stderr =
2614 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002615 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2616 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002617 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002618 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002619 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002620}
2621
Devin Moorec7e47a32020-08-07 10:55:25 -07002622TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2623 const string expected_stderr =
2624 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2625 "This is an incompatible change for FixedSize types.\n";
2626 io_delegate_.SetFileContents("old/p/Foo.aidl",
2627 "package p; @FixedSize parcelable Foo { int A = 1; }");
2628 io_delegate_.SetFileContents("new/p/Foo.aidl",
2629 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2630 CaptureStderr();
2631 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2632 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2633}
2634
2635TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2636 const string expected_stderr =
2637 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2638 io_delegate_.SetFileContents("old/p/Foo.aidl",
2639 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2640 io_delegate_.SetFileContents("new/p/Foo.aidl",
2641 "package p; @FixedSize parcelable Foo { int A = 1; }");
2642 CaptureStderr();
2643 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2644 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2645}
2646
2647TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2648 const string expected_stderr =
2649 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2650 "a.\n"
2651 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2652 "b.\n"
2653 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2654 "c.\n"
2655 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2656 "d.\n"
2657 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2658 "e.\n"
2659 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2660 "f.\n";
2661
2662 io_delegate_.SetFileContents("Foo.aidl",
2663 "@FixedSize parcelable Foo { "
2664 " int[] a;"
2665 " Bar b;"
2666 " String c;"
2667 " ParcelFileDescriptor d;"
2668 " IBinder e;"
2669 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002670 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002671 "}");
2672 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2673 Options options =
2674 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2675
2676 CaptureStderr();
2677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2678 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2679}
2680
2681TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2682 const string expected_stderr = "";
2683
2684 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2685 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2686 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2687 Options options =
2688 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2689
2690 CaptureStderr();
2691 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2692 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2693}
2694
Jiyong Park8c380532018-08-30 14:55:26 +09002695TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002696 const string expected_stderr =
2697 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2698 "dir1/q/IBar.aidl\n"
2699 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002700 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002701 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2702 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2703 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2704 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2705
Devin Moore097a3ab2020-03-11 16:08:44 -07002706 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002707 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002708 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002709}
2710
Jiyong Parked65bf42018-08-28 15:43:27 +09002711TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002712 const string expected_stderr =
2713 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2714 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002715 Options options = Options::From("aidl --checkapi old new");
2716 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2717 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002718
2719 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2720
Jiyong Parke59c3682018-09-11 23:10:25 +09002721 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002722 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002723 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002724 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002725}
2726
Jiyong Parke05195e2018-10-08 18:24:23 +09002727TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2728 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2729 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002730 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002731
2732 // use without import
2733 io_delegate_.SetFileContents("p/IFoo.aidl",
2734 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2735 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2736 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002737 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002738
Devin Moore7b8d5c92020-03-17 14:14:08 -07002739 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002740 io_delegate_.SetFileContents(
2741 "p/IFoo.aidl",
2742 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2743 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2744 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002745 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002746
2747 // use with import (as before)
2748 io_delegate_.SetFileContents("p/IFoo.aidl",
2749 "package p;"
2750 "import android.os.ParcelFileDescriptor;"
2751 "interface IFoo{"
2752 " void foo(in ParcelFileDescriptor fd);"
2753 "}");
2754 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2755 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002756 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002757}
Jiyong Parked65bf42018-08-28 15:43:27 +09002758
Jiyong Park3633b722019-04-11 15:38:26 +09002759TEST_F(AidlTest, ManualIds) {
2760 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2761 io_delegate_.SetFileContents("IFoo.aidl",
2762 "interface IFoo {\n"
2763 " void foo() = 0;\n"
2764 " void bar() = 1;\n"
2765 "}");
2766 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2767}
2768
2769TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2770 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2771 io_delegate_.SetFileContents("IFoo.aidl",
2772 "interface IFoo {\n"
2773 " void foo() = 0;\n"
2774 " void bar() = 1;\n"
2775 "}");
2776 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2777}
2778
2779TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002780 const string expected_stderr =
2781 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002782 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2783 io_delegate_.SetFileContents("IFoo.aidl",
2784 "interface IFoo {\n"
2785 " void foo() = 3;\n"
2786 " void bar() = 3;\n"
2787 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002788 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002789 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002790 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002791}
2792
2793TEST_F(AidlTest, FailOnOutOfRangeIds) {
2794 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002795 const string expected_stderr =
2796 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2797 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002798 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2799 io_delegate_.SetFileContents("IFoo.aidl",
2800 "interface IFoo {\n"
2801 " void foo() = 3;\n"
2802 " void bar() = 16777115;\n"
2803 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002804 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002805 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002806 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002807}
2808
2809TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002810 const string expected_stderr =
2811 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002812 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2813 io_delegate_.SetFileContents("IFoo.aidl",
2814 "interface IFoo {\n"
2815 " void foo() = 3;\n"
2816 " void bar();\n"
2817 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002818 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002819 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002821}
2822
Jiyong Parkc6816252019-07-08 08:12:28 +09002823TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2824 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2825 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2826 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2827 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2828}
2829
2830TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002831 const string expected_stderr =
2832 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2833 "dir/IBar.aidl\n"
2834 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002835 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002836
Jiyong Parkc6816252019-07-08 08:12:28 +09002837 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2838 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2839 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2840 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002841 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002842 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002843 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002844}
2845
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002846TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2847 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2848 "package a.b;\n"
2849 "import a.b.IBar;\n"
2850 "import a.b.IQux;\n"
2851 "interface IFoo { IQux foo(); }\n");
2852 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2853 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2854
2855 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2856 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2857
2858 string output;
2859 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2860 // IBar was imported but wasn't used. include is not expected.
2861 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2862 // IBar was imported and used. include is expected.
2863 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2864}
2865
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002866TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002867 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002868 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002869 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2870 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002871 interface IFoo {
2872 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002873 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002874 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002875 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002876 // JavaPassthrough should work with other types as well (e.g. enum)
2877 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2878 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2879 @JavaPassthrough(annotation="@com.android.AliceTwo")
2880 @Backing(type="byte")
2881 enum MyEnum {
2882 a, b, c
2883 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002884
Jooyung Han4cde01d2020-10-13 11:10:47 +09002885 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002886 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2887
2888 string java_out;
2889 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002890 // type-decl-level annotations with newline at the end
2891 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2892 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2893 // member-decl-level annotations with newline at the end
2894 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2895 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2896 // inline annotations with space at the end
2897 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002898
Jooyung Han4cde01d2020-10-13 11:10:47 +09002899 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2900 // type-decl-level annotations with newline at the end
2901 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2902 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2903
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002904 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002905 Options cpp_options =
2906 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002907 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2908
Jooyung Han4cde01d2020-10-13 11:10:47 +09002909 Options ndk_options =
2910 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002911 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002912
Jooyung Han4cde01d2020-10-13 11:10:47 +09002913 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002914 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002915}
2916
Andrei Homescue61feb52020-08-18 15:44:24 -07002917TEST_F(AidlTest, ParseRustDerive) {
2918 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2919 @RustDerive(Clone=true, Copy=false)
2920 parcelable Foo {
2921 int a;
2922 })");
2923
2924 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2925 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2926
2927 string rust_out;
2928 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2929 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2930
2931 // Other backends shouldn't be bothered
2932 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2933 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2934
2935 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2936 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2937
2938 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2939 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2940}
2941
Jiyong Park56f73d72019-06-11 12:20:28 +09002942class AidlOutputPathTest : public AidlTest {
2943 protected:
2944 void SetUp() override {
2945 AidlTest::SetUp();
2946 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2947 }
2948
2949 void Test(const Options& options, const std::string expected_output_path) {
2950 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2951 // check the existence
2952 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2953 }
2954};
2955
2956TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2957 // <out_dir> / <package_name> / <type_name>.java
2958 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2959}
2960
2961TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2962 // when output file is explicitly set, it is always respected. -o option is
2963 // ignored.
2964 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2965}
2966
2967TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2968 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2969}
2970
2971TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2972 // output is the same as the input file except for the suffix
2973 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2974}
2975
Devin Moore7b8d5c92020-03-17 14:14:08 -07002976TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002977 AidlError error;
2978 const string expected_stderr =
2979 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2980 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002981 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2982 R"(package p;
2983 interface IFoo {
2984 const int int32_max_oob = 2147483650;
2985 }
2986 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002987 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002988 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2989 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002990}
2991
Devin Moore7b8d5c92020-03-17 14:14:08 -07002992TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 AidlError error;
2994 const string expected_stderr =
2995 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2996 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002997 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2998 R"(package p;
2999 interface IFoo {
3000 const int int32_min_oob = -2147483650;
3001 }
3002 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003003 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3005 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003006}
3007
Devin Moore7b8d5c92020-03-17 14:14:08 -07003008TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 AidlError error;
3010 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003011 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003012 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3014 R"(package p;
3015 interface IFoo {
3016 const long int64_max_oob = 21474836509999999999999999;
3017 }
3018 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003019 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3021 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003022}
3023
Devin Moore7b8d5c92020-03-17 14:14:08 -07003024TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003025 AidlError error;
3026 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003027 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003028 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003029 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3030 R"(package p;
3031 interface IFoo {
3032 const long int64_min_oob = -21474836509999999999999999;
3033 }
3034 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003035 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3037 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003038}
3039
Devin Moore7b8d5c92020-03-17 14:14:08 -07003040TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003041 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003042 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003043 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003044 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3045 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003046 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3047 R"(package p;
3048 @Backing(type="byte")
3049 enum TestEnum {
3050 FOO = 127,
3051 BAR,
3052 }
3053 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003054 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003056 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003057}
3058
Devin Mooredecaf292020-04-30 09:16:40 -07003059TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3060 AidlError error;
3061 const string expected_stderr =
3062 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003063 "be one of: type\n";
3064 CaptureStderr();
3065 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3066 R"(package p;
3067 @Backing(foo="byte")
3068 enum TestEnum {
3069 FOO = 1,
3070 BAR,
3071 }
3072 )",
3073 typenames_, GetLanguage(), &error));
3074 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3075 EXPECT_EQ(AidlError::BAD_TYPE, error);
3076}
3077
Jooyung Han5721a232020-12-24 04:34:55 +09003078TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3079 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3080 CaptureStderr();
3081 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3082 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3083}
3084
Jooyung Han66813932020-10-23 13:24:44 +09003085TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003086 io_delegate_.SetFileContents("Foo.aidl",
3087 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3088 "Map<String, Baz> d; Bar[] e; }");
3089 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3090 io_delegate_.SetFileContents("Baz.aidl",
3091 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003092 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3093 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3094}
3095
Jooyung Han66813932020-10-23 13:24:44 +09003096TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003097 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003098 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003099 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003100 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3101 "named 'bar'.\n";
3102 CaptureStderr();
3103 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3104 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3105 EXPECT_EQ(expected_error, GetCapturedStderr());
3106}
3107
3108TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3109 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3110 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3111 string expected_error =
3112 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003113 "named 'bar'.\n";
3114 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003115 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3116 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003117 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003118}
3119
Jooyung Han66813932020-10-23 13:24:44 +09003120TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003121 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003122 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3123 string expected_error =
3124 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3125 "only be an in parameter.\n";
3126 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003127 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3128 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003129 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003130}
3131
Jooyung Han66813932020-10-23 13:24:44 +09003132TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003133 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003134 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3135 string expected_error =
3136 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3137 "only be an in parameter.\n";
3138 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003139 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3140 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003141 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003142}
3143
Jooyung Han66813932020-10-23 13:24:44 +09003144TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003145 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003146 Options options = Options::From("aidl --lang=java Foo.aidl");
3147 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003148 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3149 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003150 CaptureStderr();
3151 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3153}
Devin Moore53fc99c2020-08-12 08:07:52 -07003154
Jooyung Han1f14ab32020-10-14 13:48:29 +09003155const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3156
3157#include <a/ByteEnum.h>
3158#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003159#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003160#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003161#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003162#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003163#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003164#include <locale>
3165#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003166#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003167#include <utility>
3168#include <variant>
3169#include <vector>
3170
Jooyung Handf39e192020-11-23 15:59:46 +09003171#ifndef __BIONIC__
3172#define __assert2(a,b,c,d) ((void)0)
3173#endif
3174
Jooyung Han1f14ab32020-10-14 13:48:29 +09003175namespace a {
3176
3177class Foo : public ::android::Parcelable {
3178public:
Jooyung Han97945de2020-10-15 16:41:38 +09003179 inline bool operator!=(const Foo& rhs) const {
3180 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003181 }
Jooyung Han97945de2020-10-15 16:41:38 +09003182 inline bool operator<(const Foo& rhs) const {
3183 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184 }
Jooyung Han97945de2020-10-15 16:41:38 +09003185 inline bool operator<=(const Foo& rhs) const {
3186 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187 }
Jooyung Han97945de2020-10-15 16:41:38 +09003188 inline bool operator==(const Foo& rhs) const {
3189 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003190 }
Jooyung Han97945de2020-10-15 16:41:38 +09003191 inline bool operator>(const Foo& rhs) const {
3192 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003193 }
Jooyung Han97945de2020-10-15 16:41:38 +09003194 inline bool operator>=(const Foo& rhs) const {
3195 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003196 }
Jooyung Han97945de2020-10-15 16:41:38 +09003197
Jooyung Han1f14ab32020-10-14 13:48:29 +09003198 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003199 ns = 0, // int[] ns;
3200 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003201 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003202 };
Jooyung Han97945de2020-10-15 16:41:38 +09003203
Jooyung Han1f14ab32020-10-14 13:48:29 +09003204 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003205 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003206
3207 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003208 Foo(const Foo&) = default;
3209 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003210 Foo& operator=(const Foo&) = default;
3211 Foo& operator=(Foo&&) = default;
3212
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003213 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3214 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003215 constexpr Foo(_Tp&& _arg)
3216 : _value(std::forward<_Tp>(_arg)) {}
3217
3218 template <typename... _Tp>
3219 constexpr explicit Foo(_Tp&&... _args)
3220 : _value(std::forward<_Tp>(_args)...) {}
3221
3222 template <Tag _tag, typename... _Tp>
3223 static Foo make(_Tp&&... _args) {
3224 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003225 }
Jooyung Han97945de2020-10-15 16:41:38 +09003226
3227 template <Tag _tag, typename _Tp, typename... _Up>
3228 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3229 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003230 }
3231
3232 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003233 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003234 }
3235
Jooyung Han97945de2020-10-15 16:41:38 +09003236 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003237 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003238 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003239 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003240 }
3241
Jooyung Han97945de2020-10-15 16:41:38 +09003242 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003243 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003244 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003245 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003246 }
3247
Jooyung Han97945de2020-10-15 16:41:38 +09003248 template <Tag _tag, typename... _Tp>
3249 void set(_Tp&&... _args) {
3250 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003251 }
3252
3253 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3254 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3255 static const std::string& getParcelableDescriptor() {
3256 static const std::string DESCIPTOR = "a.Foo";
3257 return DESCIPTOR;
3258 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003259 template <typename _T> class _has_toString {
3260 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3261 template <typename _U> static std::false_type __has_toString(...);
3262 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3263 };
3264 template <typename _T> inline static std::string _call_toString(const _T& t) {
3265 if constexpr (_has_toString<_T>::value) return t.toString();
3266 return "{no toString() implemented}";
3267 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003268 inline std::string toString() const {
3269 std::ostringstream os;
3270 os << "Foo{";
3271 switch (getTag()) {
3272 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3273 case e: os << "e: " << a::toString(get<e>()); break;
3274 case pfd: os << "pfd: " << ""; break;
3275 }
3276 os << "}";
3277 return os.str();
3278 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003279private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003280 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003281}; // class Foo
3282
3283} // namespace a
3284)";
3285
3286const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3287
3288namespace a {
3289
3290::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3291 ::android::status_t _aidl_ret_status;
3292 int32_t _aidl_tag;
3293 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3294 switch (_aidl_tag) {
3295 case ns: {
3296 ::std::vector<int32_t> _aidl_value;
3297 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003298 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3299 set<ns>(_aidl_value);
3300 } else {
3301 // NOLINTNEXTLINE(performance-move-const-arg)
3302 set<ns>(std::move(_aidl_value));
3303 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003304 return ::android::OK; }
3305 case e: {
3306 ::a::ByteEnum _aidl_value;
3307 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003308 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3309 set<e>(_aidl_value);
3310 } else {
3311 // NOLINTNEXTLINE(performance-move-const-arg)
3312 set<e>(std::move(_aidl_value));
3313 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003314 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003315 case pfd: {
3316 ::android::os::ParcelFileDescriptor _aidl_value;
3317 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003318 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3319 set<pfd>(_aidl_value);
3320 } else {
3321 // NOLINTNEXTLINE(performance-move-const-arg)
3322 set<pfd>(std::move(_aidl_value));
3323 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003324 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003325 }
3326 return ::android::BAD_VALUE;
3327}
3328
3329::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3330 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3331 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3332 switch (getTag()) {
3333 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3334 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003335 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003336 }
Jooyung Handf39e192020-11-23 15:59:46 +09003337 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003338}
3339
3340} // namespace a
3341)";
3342
Jooyung Han6beac042020-10-17 21:59:43 +09003343const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3344#include <android/binder_interface_utils.h>
3345#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003346#include <codecvt>
3347#include <locale>
3348#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003349
Jooyung Handf39e192020-11-23 15:59:46 +09003350#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003351#include <type_traits>
3352#include <utility>
3353#include <variant>
3354#include <cstdint>
3355#include <memory>
3356#include <optional>
3357#include <string>
3358#include <vector>
3359#ifdef BINDER_STABILITY_SUPPORT
3360#include <android/binder_stability.h>
3361#endif // BINDER_STABILITY_SUPPORT
3362#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003363
3364#ifndef __BIONIC__
3365#define __assert2(a,b,c,d) ((void)0)
3366#endif
3367
Jooyung Han6beac042020-10-17 21:59:43 +09003368namespace aidl {
3369namespace a {
3370class Foo {
3371public:
3372 typedef std::false_type fixed_size;
3373 static const char* descriptor;
3374
3375 enum Tag : int32_t {
3376 ns = 0, // int[] ns;
3377 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003378 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003379 };
3380
3381 template<typename _Tp>
3382 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3383
3384 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3385 Foo(const Foo&) = default;
3386 Foo(Foo&&) = default;
3387 Foo& operator=(const Foo&) = default;
3388 Foo& operator=(Foo&&) = default;
3389
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003390 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3391 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003392 constexpr Foo(_Tp&& _arg)
3393 : _value(std::forward<_Tp>(_arg)) {}
3394
3395 template <typename... _Tp>
3396 constexpr explicit Foo(_Tp&&... _args)
3397 : _value(std::forward<_Tp>(_args)...) {}
3398
3399 template <Tag _tag, typename... _Tp>
3400 static Foo make(_Tp&&... _args) {
3401 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3402 }
3403
3404 template <Tag _tag, typename _Tp, typename... _Up>
3405 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3406 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3407 }
3408
3409 Tag getTag() const {
3410 return static_cast<Tag>(_value.index());
3411 }
3412
3413 template <Tag _tag>
3414 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003415 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003416 return std::get<_tag>(_value);
3417 }
3418
3419 template <Tag _tag>
3420 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003421 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003422 return std::get<_tag>(_value);
3423 }
3424
3425 template <Tag _tag, typename... _Tp>
3426 void set(_Tp&&... _args) {
3427 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3428 }
3429
3430 binder_status_t readFromParcel(const AParcel* _parcel);
3431 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003432
3433 inline bool operator!=(const Foo& rhs) const {
3434 return _value != rhs._value;
3435 }
3436 inline bool operator<(const Foo& rhs) const {
3437 return _value < rhs._value;
3438 }
3439 inline bool operator<=(const Foo& rhs) const {
3440 return _value <= rhs._value;
3441 }
3442 inline bool operator==(const Foo& rhs) const {
3443 return _value == rhs._value;
3444 }
3445 inline bool operator>(const Foo& rhs) const {
3446 return _value > rhs._value;
3447 }
3448 inline bool operator>=(const Foo& rhs) const {
3449 return _value >= rhs._value;
3450 }
3451
Jooyung Han6beac042020-10-17 21:59:43 +09003452 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003453 template <typename _T> class _has_toString {
3454 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3455 template <typename _U> static std::false_type __has_toString(...);
3456 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3457 };
3458 template <typename _T> inline static std::string _call_toString(const _T& t) {
3459 if constexpr (_has_toString<_T>::value) return t.toString();
3460 return "{no toString() implemented}";
3461 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003462 inline std::string toString() const {
3463 std::ostringstream os;
3464 os << "Foo{";
3465 switch (getTag()) {
3466 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3467 case e: os << "e: " << a::toString(get<e>()); break;
3468 case pfd: os << "pfd: " << ""; break;
3469 }
3470 os << "}";
3471 return os.str();
3472 }
Jooyung Han6beac042020-10-17 21:59:43 +09003473private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003474 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003475};
3476} // namespace a
3477} // namespace aidl
3478)";
3479
3480const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3481
3482#include <android/binder_parcel_utils.h>
3483
3484namespace aidl {
3485namespace a {
3486const char* Foo::descriptor = "a.Foo";
3487
3488binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3489 binder_status_t _aidl_ret_status;
3490 int32_t _aidl_tag;
3491 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3492 switch (_aidl_tag) {
3493 case ns: {
3494 std::vector<int32_t> _aidl_value;
3495 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003496 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3497 set<ns>(_aidl_value);
3498 } else {
3499 // NOLINTNEXTLINE(performance-move-const-arg)
3500 set<ns>(std::move(_aidl_value));
3501 }
Jooyung Han6beac042020-10-17 21:59:43 +09003502 return STATUS_OK; }
3503 case e: {
3504 ::aidl::a::ByteEnum _aidl_value;
3505 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003506 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3507 set<e>(_aidl_value);
3508 } else {
3509 // NOLINTNEXTLINE(performance-move-const-arg)
3510 set<e>(std::move(_aidl_value));
3511 }
Jooyung Han6beac042020-10-17 21:59:43 +09003512 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003513 case pfd: {
3514 ::ndk::ScopedFileDescriptor _aidl_value;
3515 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003516 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3517 set<pfd>(_aidl_value);
3518 } else {
3519 // NOLINTNEXTLINE(performance-move-const-arg)
3520 set<pfd>(std::move(_aidl_value));
3521 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003522 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003523 }
3524 return STATUS_BAD_VALUE;
3525}
3526binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3527 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3528 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3529 switch (getTag()) {
3530 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3531 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003532 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003533 }
Jooyung Handf39e192020-11-23 15:59:46 +09003534 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003535}
3536
3537} // namespace a
3538} // namespace aidl
3539)";
3540
Jooyung Han1f14ab32020-10-14 13:48:29 +09003541const char kUnionExampleExpectedOutputJava[] = R"(/*
3542 * This file is auto-generated. DO NOT MODIFY.
3543 */
3544package a;
3545
3546
3547public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003548 // tags for union fields
3549 public final static int ns = 0; // int[] ns;
3550 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003551 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003552
3553 private int _tag;
3554 private Object _value;
3555
3556 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003557 int[] _value = {42};
3558 this._tag = ns;
3559 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003560 }
Jooyung Han97945de2020-10-15 16:41:38 +09003561
Jooyung Han1f14ab32020-10-14 13:48:29 +09003562 private Foo(android.os.Parcel _aidl_parcel) {
3563 readFromParcel(_aidl_parcel);
3564 }
Jooyung Han97945de2020-10-15 16:41:38 +09003565
Jooyung Hance62f932020-10-25 10:21:49 +09003566 private Foo(int _tag, Object _value) {
3567 this._tag = _tag;
3568 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003569 }
3570
3571 public int getTag() {
3572 return _tag;
3573 }
3574
Jooyung Han97945de2020-10-15 16:41:38 +09003575 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003576
3577 public static Foo ns(int[] _value) {
3578 return new Foo(ns, _value);
3579 }
Jooyung Han97945de2020-10-15 16:41:38 +09003580
Jooyung Han1f14ab32020-10-14 13:48:29 +09003581 public int[] getNs() {
3582 _assertTag(ns);
3583 return (int[]) _value;
3584 }
Jooyung Han97945de2020-10-15 16:41:38 +09003585
Jooyung Han1f14ab32020-10-14 13:48:29 +09003586 public void setNs(int[] _value) {
3587 _set(ns, _value);
3588 }
3589
Jooyung Han97945de2020-10-15 16:41:38 +09003590 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003591
3592 public static Foo e(byte _value) {
3593 return new Foo(e, _value);
3594 }
Jooyung Han97945de2020-10-15 16:41:38 +09003595
Jooyung Han1f14ab32020-10-14 13:48:29 +09003596 public byte getE() {
3597 _assertTag(e);
3598 return (byte) _value;
3599 }
Jooyung Han97945de2020-10-15 16:41:38 +09003600
Jooyung Han1f14ab32020-10-14 13:48:29 +09003601 public void setE(byte _value) {
3602 _set(e, _value);
3603 }
3604
Jooyung Hand2fa0232020-10-19 02:51:41 +09003605 // ParcelFileDescriptor pfd;
3606
3607 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3608 return new Foo(pfd, _value);
3609 }
3610
3611 public android.os.ParcelFileDescriptor getPfd() {
3612 _assertTag(pfd);
3613 return (android.os.ParcelFileDescriptor) _value;
3614 }
3615
3616 public void setPfd(android.os.ParcelFileDescriptor _value) {
3617 _set(pfd, _value);
3618 }
3619
Jooyung Han1f14ab32020-10-14 13:48:29 +09003620 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3621 @Override
3622 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003623 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003624 }
3625 @Override
3626 public Foo[] newArray(int _aidl_size) {
3627 return new Foo[_aidl_size];
3628 }
3629 };
Jooyung Han97945de2020-10-15 16:41:38 +09003630
Jooyung Han1f14ab32020-10-14 13:48:29 +09003631 @Override
3632 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3633 _aidl_parcel.writeInt(_tag);
3634 switch (_tag) {
3635 case ns:
3636 _aidl_parcel.writeIntArray(getNs());
3637 break;
3638 case e:
3639 _aidl_parcel.writeByte(getE());
3640 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003641 case pfd:
3642 if ((getPfd()!=null)) {
3643 _aidl_parcel.writeInt(1);
3644 getPfd().writeToParcel(_aidl_parcel, 0);
3645 }
3646 else {
3647 _aidl_parcel.writeInt(0);
3648 }
3649 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003650 }
3651 }
Jooyung Han97945de2020-10-15 16:41:38 +09003652
Jooyung Han1f14ab32020-10-14 13:48:29 +09003653 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3654 int _aidl_tag;
3655 _aidl_tag = _aidl_parcel.readInt();
3656 switch (_aidl_tag) {
3657 case ns: {
3658 int[] _aidl_value;
3659 _aidl_value = _aidl_parcel.createIntArray();
3660 _set(_aidl_tag, _aidl_value);
3661 return; }
3662 case e: {
3663 byte _aidl_value;
3664 _aidl_value = _aidl_parcel.readByte();
3665 _set(_aidl_tag, _aidl_value);
3666 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003667 case pfd: {
3668 android.os.ParcelFileDescriptor _aidl_value;
3669 if ((0!=_aidl_parcel.readInt())) {
3670 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3671 }
3672 else {
3673 _aidl_value = null;
3674 }
3675 _set(_aidl_tag, _aidl_value);
3676 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003677 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003678 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003679 }
Jooyung Han97945de2020-10-15 16:41:38 +09003680
Jooyung Han1f14ab32020-10-14 13:48:29 +09003681 @Override
3682 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003683 int _mask = 0;
3684 switch (getTag()) {
3685 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003686 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003687 break;
3688 }
3689 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003690 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003691 private int describeContents(Object _v) {
3692 if (_v == null) return 0;
3693 if (_v instanceof android.os.Parcelable) {
3694 return ((android.os.Parcelable) _v).describeContents();
3695 }
3696 return 0;
3697 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003698
3699 private void _assertTag(int tag) {
3700 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003701 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003702 }
3703 }
Jooyung Han97945de2020-10-15 16:41:38 +09003704
Jooyung Han1f14ab32020-10-14 13:48:29 +09003705 private String _tagString(int _tag) {
3706 switch (_tag) {
3707 case ns: return "ns";
3708 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003709 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003710 }
3711 throw new IllegalStateException("unknown field: " + _tag);
3712 }
Jooyung Han97945de2020-10-15 16:41:38 +09003713
Jooyung Hance62f932020-10-25 10:21:49 +09003714 private void _set(int _tag, Object _value) {
3715 this._tag = _tag;
3716 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003717 }
3718}
3719)";
3720
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003721const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3722pub enum Foo {
3723 Ns(Vec<i32>),
3724 E(crate::mangled::_1_a_8_ByteEnum),
3725 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3726}
3727pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3728impl Default for Foo {
3729 fn default() -> Self {
3730 Self::Ns(vec!{42})
3731 }
3732}
3733impl binder::parcel::Serialize for Foo {
3734 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3735 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3736 }
3737}
3738impl binder::parcel::SerializeArray for Foo {}
3739impl binder::parcel::SerializeOption for Foo {
3740 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3741 let this = if let Some(this) = this {
3742 parcel.write(&1i32)?;
3743 this
3744 } else {
3745 return parcel.write(&0i32);
3746 };
3747 match this {
3748 Self::Ns(v) => {
3749 parcel.write(&0i32)?;
3750 parcel.write(v)
3751 }
3752 Self::E(v) => {
3753 parcel.write(&1i32)?;
3754 parcel.write(v)
3755 }
3756 Self::Pfd(v) => {
3757 parcel.write(&2i32)?;
3758 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3759 parcel.write(__field_ref)
3760 }
3761 }
3762 }
3763}
3764impl binder::parcel::Deserialize for Foo {
3765 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3766 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3767 .transpose()
3768 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3769 }
3770}
3771impl binder::parcel::DeserializeArray for Foo {}
3772impl binder::parcel::DeserializeOption for Foo {
3773 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3774 let status: i32 = parcel.read()?;
3775 if status == 0 { return Ok(None); }
3776 let tag: i32 = parcel.read()?;
3777 match tag {
3778 0 => {
3779 let value: Vec<i32> = parcel.read()?;
3780 Ok(Some(Self::Ns(value)))
3781 }
3782 1 => {
3783 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3784 Ok(Some(Self::E(value)))
3785 }
3786 2 => {
3787 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3788 Ok(Some(Self::Pfd(value)))
3789 }
3790 _ => {
3791 Err(binder::StatusCode::BAD_VALUE)
3792 }
3793 }
3794 }
3795}
3796)";
3797
Jooyung Han97945de2020-10-15 16:41:38 +09003798struct AidlUnionTest : ::testing::Test {
3799 void SetUp() override {
3800 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003801package a;
3802import a.ByteEnum;
3803union Foo {
3804 int[] ns = {42};
3805 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003806 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003807}
3808)");
Jooyung Han97945de2020-10-15 16:41:38 +09003809 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003810package a;
3811@Backing(type="byte")
3812enum ByteEnum {
3813 a, b, c
3814}
3815)");
Jooyung Han97945de2020-10-15 16:41:38 +09003816 }
3817 FakeIoDelegate io_delegate_;
3818 void Compile(string lang) {
3819 string command = "aidl --structured -I. -o out --lang=" + lang;
3820 if (lang == "cpp" || lang == "ndk") {
3821 command += " -h out";
3822 }
3823 command += " a/Foo.aidl";
3824 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003825 CaptureStderr();
3826 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3827 auto err = GetCapturedStderr();
3828 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003829 }
3830 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3831 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003832 string actual;
3833 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3834 EXPECT_EQ(expected, actual);
3835 }
Jooyung Han97945de2020-10-15 16:41:38 +09003836 }
3837};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003838
Jooyung Han97945de2020-10-15 16:41:38 +09003839TEST_F(AidlUnionTest, Example_Cpp) {
3840 Compile("cpp");
3841 EXPECT_COMPILE_OUTPUTS(
3842 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3843 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3844}
3845
Jooyung Han6beac042020-10-17 21:59:43 +09003846TEST_F(AidlUnionTest, Example_Ndk) {
3847 Compile("ndk");
3848 EXPECT_COMPILE_OUTPUTS(
3849 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3850 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3851}
3852
Jooyung Han97945de2020-10-15 16:41:38 +09003853TEST_F(AidlUnionTest, Example_Java) {
3854 Compile("java");
3855 EXPECT_COMPILE_OUTPUTS(
3856 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003857}
3858
3859TEST_F(AidlUnionTest, Example_Rust) {
3860 Compile("rust");
3861 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003862}
3863
Jooyung Hanfe89f122020-10-14 03:49:18 +09003864TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3865 const string method = "package a; union Foo {}";
3866 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3867 CaptureStderr();
3868 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3869 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3870}
3871
3872TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3873 const string method = "package a; union Foo { ParcelableHolder x; }";
3874 const string expected_stderr =
3875 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3876 CaptureStderr();
3877 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3878 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3879}
3880
Jooyung Han53fb4242020-12-17 16:03:49 +09003881TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3882 import_paths_.insert(".");
3883 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3884 const string expected_err = "The union's first member should have a useful default value.";
3885 CaptureStderr();
3886 EXPECT_EQ(nullptr,
3887 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3888 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3889}
3890
Devin Moore53fc99c2020-08-12 08:07:52 -07003891TEST_P(AidlTest, GenericStructuredParcelable) {
3892 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3893 Options options =
3894 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3895 const string expected_stderr = "";
3896 CaptureStderr();
3897 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3898 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3899}
3900
Jooyung Han3f347ca2020-12-01 12:41:50 +09003901TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3902 io_delegate_.SetFileContents("Foo.aidl",
3903 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3904 Options options =
3905 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3906 " -o out -h out");
3907 const string expected_stderr = "";
3908 CaptureStderr();
3909 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3910 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3911
3912 string code;
3913 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3914 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3915const ::android::String16& Foo<T,U>::s() {
3916 static const ::android::String16 value(::android::String16(""));
3917 return value;
3918})--"));
3919}
3920
3921TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3922 io_delegate_.SetFileContents("Foo.aidl",
3923 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3924 Options options =
3925 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3926 " -o out -h out");
3927 const string expected_stderr = "";
3928 CaptureStderr();
3929 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3930 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3931
3932 string code;
3933 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3934 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3935const char* Foo<T, U>::s = "";
3936)--"));
3937}
3938
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003939TEST_F(AidlTest, NestedTypeArgs) {
3940 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003941 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3942
3943 io_delegate_.SetFileContents("a/Foo.aidl",
3944 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3945 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003946 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3947 const string expected_stderr = "";
3948 CaptureStderr();
3949 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3950 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3951
3952 string code;
3953 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003954 EXPECT_THAT(code,
3955 testing::HasSubstr(
3956 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3957}
3958
3959TEST_F(AidlTest, DoubleArrayError) {
3960 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3961
3962 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3963 const string expected_stderr =
3964 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3965 CaptureStderr();
3966 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3967 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3968}
3969
3970TEST_F(AidlTest, DoubleGenericError) {
3971 io_delegate_.SetFileContents("a/Bar.aidl",
3972 "package a; parcelable Bar { List<String><String> a; }");
3973
3974 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3975 const string expected_stderr =
3976 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3977 CaptureStderr();
3978 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3979 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3980}
3981
3982TEST_F(AidlTest, ArrayBeforeGenericError) {
3983 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3984
3985 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3986 const string expected_stderr =
3987 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3988 CaptureStderr();
3989 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003991}
3992
Jooyung Han14004ed2020-10-16 03:49:57 +09003993struct GenericAidlTest : ::testing::Test {
3994 FakeIoDelegate io_delegate_;
3995 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003996 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003997 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3998 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3999 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4000
4001 Options options = Options::From(cmd);
4002 CaptureStderr();
4003 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4004 EXPECT_EQ("", GetCapturedStderr());
4005 }
4006};
4007
4008TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4009 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4010 string code;
4011 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4012 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4013 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4014 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4015}
4016
4017TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4018 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4019 string code;
4020 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4021 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4022 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4023 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4024}
4025
Devin Moore53fc99c2020-08-12 08:07:52 -07004026TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4027 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
4028 Options options =
4029 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4030 const string expected_stderr =
4031 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4032 CaptureStderr();
4033 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4034 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4035}
4036
4037TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4038 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
4039 Options options =
4040 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4041 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4042 CaptureStderr();
4043 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4044 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4045}
4046
Jooyung Han7a308842020-10-27 19:06:49 +09004047TEST_P(AidlTest, LongCommentWithinConstExpression) {
4048 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
4049 Options options =
4050 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4051 CaptureStderr();
4052 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4053 EXPECT_EQ("", GetCapturedStderr());
4054}
4055
Jeongik Chaef44e622020-10-23 16:00:52 +09004056TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4057 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4058 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4059 std::string expectedErr =
4060 "ERROR: a/Foo.aidl:1.28-30: "
4061 "Encountered an untyped List or Map. The use of untyped List/Map is "
4062 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4063 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4064 "ERROR: a/Foo.aidl:1.35-37: "
4065 "Encountered an untyped List or Map. The use of untyped List/Map is "
4066 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4067 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4068 CaptureStderr();
4069 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4070 EXPECT_EQ(expectedErr, GetCapturedStderr());
4071}
4072
4073TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004074 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4075 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004076 std::string expectedErr =
4077 "ERROR: a/Foo.aidl:1.33-35: "
4078 "Encountered an untyped List or Map. The use of untyped List/Map is "
4079 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4080 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4081 "ERROR: a/Foo.aidl:1.40-42: "
4082 "Encountered an untyped List or Map. The use of untyped List/Map is "
4083 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4084 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004085 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004086 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4087 EXPECT_EQ(expectedErr, GetCapturedStderr());
4088}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004089
Jeongik Chaef44e622020-10-23 16:00:52 +09004090TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4091 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4092 io_delegate_.SetFileContents(
4093 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4094 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4095 std::string expectedErr =
4096 "ERROR: a/Foo.aidl:1.52-54: "
4097 "Encountered an untyped List or Map. The use of untyped List/Map is "
4098 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4099 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4100 "ERROR: a/Foo.aidl:1.64-66: "
4101 "Encountered an untyped List or Map. The use of untyped List/Map is "
4102 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4103 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4104 CaptureStderr();
4105 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4106 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004107}
4108
Jooyung Han690f5842020-12-04 13:02:04 +09004109TEST_F(AidlTest, EnumWithDefaults_Java) {
4110 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4111 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4112package p;
4113import p.Enum;
4114parcelable Foo {
4115 Enum e = Enum.BAR;
4116})");
4117 CaptureStderr();
4118 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4119 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4120 auto err = GetCapturedStderr();
4121 EXPECT_EQ("", err);
4122
4123 string code;
4124 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004125 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004126}
4127
4128TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4129 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4130 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4131package p;
4132import p.Enum;
4133parcelable Foo {
4134 Enum e = Enum.BAR;
4135})");
4136 CaptureStderr();
4137 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4138 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4139 auto err = GetCapturedStderr();
4140 EXPECT_EQ("", err);
4141
4142 string code;
4143 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4144 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4145}
4146
4147TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4148 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4149 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4150package p;
4151import p.Enum;
4152parcelable Foo {
4153 Enum e = Enum.BAR;
4154})");
4155 CaptureStderr();
4156 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4157 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4158 auto err = GetCapturedStderr();
4159 EXPECT_EQ("", err);
4160
4161 string code;
4162 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4163 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4164}
4165
4166TEST_F(AidlTest, EnumWithDefaults_Rust) {
4167 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4168 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4169package p;
4170import p.Enum;
4171parcelable Foo {
4172 int n = 42;
4173 Enum e = Enum.BAR;
4174})");
4175 CaptureStderr();
4176 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4177 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4178 auto err = GetCapturedStderr();
4179 EXPECT_EQ("", err);
4180
4181 string code;
4182 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4183 EXPECT_THAT(code, testing::HasSubstr(R"(
4184 fn default() -> Self {
4185 Self {
4186 n: 42,
4187 e: crate::mangled::_1_p_4_Enum::BAR,
4188 }
4189 })"));
4190}
4191
4192TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4193 import_paths_.insert("a");
4194 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4195 CaptureStderr();
4196 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4197package p;
4198import p.Enum;
4199parcelable Foo {
4200 int e = Enum.FOO | Enum.BAR;
4201})",
4202 typenames_, GetLanguage());
4203 auto err = GetCapturedStderr();
4204 EXPECT_EQ("", err);
4205 EXPECT_TRUE(type);
4206 const auto& fields = type->AsStructuredParcelable()->GetFields();
4207 EXPECT_EQ("int e = 3", fields[0]->ToString());
4208}
4209
4210TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4211 CaptureStderr();
4212 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4213@Backing(type="int")
4214enum Foo {
4215 STANDARD_SHIFT = 16,
4216 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4217 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4218}
4219)",
4220 typenames_, GetLanguage());
4221 auto err = GetCapturedStderr();
4222 EXPECT_EQ("", err);
4223 EXPECT_TRUE(type);
4224 const auto& enum_type = type->AsEnumDeclaration();
4225 string code;
4226 enum_type->Dump(CodeWriter::ForString(&code).get());
4227 EXPECT_EQ(R"--(@Backing(type="int")
4228enum Foo {
4229 STANDARD_SHIFT = 16,
4230 STANDARD_BT709 = 65536,
4231 STANDARD_BT601_625 = 131072,
4232}
4233)--",
4234 code);
4235}
4236
4237TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4238 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4239 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4240package p;
4241import p.Enum;
4242parcelable Foo {
4243 Enum e = Enum.FOO | Enum.BAR;
4244})");
4245 CaptureStderr();
4246 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4247 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4248 auto err = GetCapturedStderr();
4249 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4250 err);
4251}
4252
4253TEST_P(AidlTest, DefaultWithEmptyArray) {
4254 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4255 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4256 CaptureStderr();
4257 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4258 " -o out -h out a/p/Foo.aidl");
4259 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4260 auto err = GetCapturedStderr();
4261 EXPECT_EQ("", err);
4262}
4263
4264TEST_P(AidlTest, RejectRefsInAnnotation) {
4265 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4266 "package p; interface IFoo {\n"
4267 " const String ANNOTATION = \"@Annotation\";\n"
4268 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4269 "}");
4270 CaptureStderr();
4271 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4272 " -o out -h out a/p/IFoo.aidl");
4273 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4274 auto err = GetCapturedStderr();
4275 EXPECT_EQ(
4276 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4277 "ANNOTATION.\n",
4278 err);
4279}
4280
4281TEST_F(AidlTest, DefaultWithEnumValues) {
4282 io_delegate_.SetFileContents(
4283 "a/p/Foo.aidl",
4284 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4285 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4286 CaptureStderr();
4287 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4288 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4289 auto err = GetCapturedStderr();
4290 EXPECT_EQ("", err);
4291 string code;
4292 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4293 EXPECT_THAT(
4294 code, testing::HasSubstr(
4295 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4296}
4297
Jooyung Han14259392020-12-07 10:00:08 +09004298TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4299 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4300 CaptureStderr();
4301 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4302 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4303 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004304 EXPECT_EQ(
4305 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4306 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4307 err);
Jooyung Han14259392020-12-07 10:00:08 +09004308}
4309
4310TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4311 io_delegate_.SetFileContents("a/p/Foo.aidl",
4312 "package p; parcelable Foo { const int A = A + 1; }");
4313 CaptureStderr();
4314 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4315 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4316 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004317 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4318}
4319
4320TEST_F(AidlTest, RecursiveReferences) {
4321 io_delegate_.SetFileContents("a/p/Foo.aidl",
4322 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4323 io_delegate_.SetFileContents("a/p/Bar.aidl",
4324 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4325 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4326 CaptureStderr();
4327 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4328 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4329 EXPECT_EQ("", GetCapturedStderr());
4330}
4331
4332TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4333 string contents = R"(
4334import android.os.IBinder;
4335import android.os.IInterface;
4336interface IFoo {}
4337 )";
4338 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004339}
4340
Jooyung Han888c5bc2020-12-22 17:28:47 +09004341TEST_P(AidlTest, WarningInterfaceName) {
4342 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4343 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4344 " -Weverything -o out -h out p/Foo.aidl");
4345 CaptureStderr();
4346 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han3557e482020-12-24 05:11:15 +09004347 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004348 GetCapturedStderr());
4349}
4350
4351TEST_P(AidlTest, ErrorInterfaceName) {
4352 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4353 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4354 " -Weverything -Werror -o out -h out p/Foo.aidl");
4355 CaptureStderr();
4356 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han3557e482020-12-24 05:11:15 +09004357 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004358 GetCapturedStderr());
4359}
4360
Jooyung Hanfd3be322020-12-13 09:11:06 +09004361struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004362 string kind;
4363 string literal;
4364};
4365
Jooyung Hanfd3be322020-12-13 09:11:06 +09004366const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004367 {"primitive", "int"}, {"String", "String"},
4368 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4369 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4370 {"union", "a.Union"}, {"interface", "a.IBar"},
4371};
4372
4373const std::map<std::string, std::string> kListSupportExpectations = {
4374 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4375 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4376 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4377 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4378 {"cpp_String", ""},
4379 {"java_String", ""},
4380 {"ndk_String", ""},
4381 {"rust_String", ""},
4382 {"cpp_IBinder", ""},
4383 {"java_IBinder", ""},
4384 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4385 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004386 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004387 {"java_ParcelFileDescriptor", ""},
4388 {"ndk_ParcelFileDescriptor", ""},
4389 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004390 {"cpp_interface", "List<a.IBar> is not supported."},
4391 {"java_interface", "List<a.IBar> is not supported."},
4392 {"ndk_interface", "List<a.IBar> is not supported."},
4393 {"rust_interface", "List<a.IBar> is not supported."},
4394 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004395 {"java_parcelable", ""},
4396 {"ndk_parcelable", ""},
4397 {"rust_parcelable", ""},
4398 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4399 {"java_enum", "A generic type cannot have any primitive type parameters."},
4400 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4401 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004402 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004403 {"java_union", ""},
4404 {"ndk_union", ""},
4405 {"rust_union", ""},
4406};
4407
Jooyung Hand236e552020-12-13 09:21:27 +09004408const std::map<std::string, std::string> kArraySupportExpectations = {
4409 {"cpp_primitive", ""},
4410 {"java_primitive", ""},
4411 {"ndk_primitive", ""},
4412 {"rust_primitive", ""},
4413 {"cpp_String", ""},
4414 {"java_String", ""},
4415 {"ndk_String", ""},
4416 {"rust_String", ""},
4417 {"cpp_IBinder", ""},
4418 {"java_IBinder", ""},
4419 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4420 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4421 {"cpp_ParcelFileDescriptor", ""},
4422 {"java_ParcelFileDescriptor", ""},
4423 {"ndk_ParcelFileDescriptor", ""},
4424 {"rust_ParcelFileDescriptor", ""},
4425 {"cpp_interface", "Binder type cannot be an array"},
4426 {"java_interface", "Binder type cannot be an array"},
4427 {"ndk_interface", "Binder type cannot be an array"},
4428 {"rust_interface", "Binder type cannot be an array"},
4429 {"cpp_parcelable", ""},
4430 {"java_parcelable", ""},
4431 {"ndk_parcelable", ""},
4432 {"rust_parcelable", ""},
4433 {"cpp_enum", ""},
4434 {"java_enum", ""},
4435 {"ndk_enum", ""},
4436 {"rust_enum", ""},
4437 {"cpp_union", ""},
4438 {"java_union", ""},
4439 {"ndk_union", ""},
4440 {"rust_union", ""},
4441};
4442
Jooyung Hanfd3be322020-12-13 09:11:06 +09004443class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004444 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004445 void Run(const std::string& generic_type_decl,
4446 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004447 const auto& param = GetParam();
4448 const auto& lang = Options::LanguageToString(std::get<0>(param));
4449 const auto& kind = std::get<1>(param).kind;
4450
4451 FakeIoDelegate io;
4452 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4453 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4454 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004455 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4456 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004457
4458 const auto options =
4459 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4460 CaptureStderr();
4461 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004462 auto it = expectations.find(lang + "_" + kind);
4463 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004464 const string err = GetCapturedStderr();
4465 if (it->second.empty()) {
4466 EXPECT_EQ("", err);
4467 } else {
4468 EXPECT_THAT(err, testing::HasSubstr(it->second));
4469 }
4470 }
4471};
4472
4473INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004474 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004475 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4476 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004477 testing::ValuesIn(kTypeParams)),
4478 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004479 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4480 std::get<1>(info.param).kind;
4481 });
4482
Jooyung Hanfd3be322020-12-13 09:11:06 +09004483TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4484 Run("List<{}>", kListSupportExpectations);
4485}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004486
Jooyung Hand236e552020-12-13 09:21:27 +09004487TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4488 Run("{}[]", kArraySupportExpectations);
4489}
4490
Christopher Wiley90be4e32015-10-20 14:55:25 -07004491} // namespace aidl
4492} // namespace android