blob: 091c7ee4b09864f27a3e48fbdde664cbfbf0cdd4 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Jooyung Hand2fa0232020-10-19 02:51:41 +090081const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 R"(/*
83 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080085@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090086public class Rect implements android.os.Parcelable
87{
88 // Comment
89
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080090 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090091 public int x = 5;
92
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080093 @android.annotation.Hide
94 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000095 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090096
97 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090098
99 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900100 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
101 @Override
102 public Rect createFromParcel(android.os.Parcel _aidl_source) {
103 Rect _aidl_out = new Rect();
104 _aidl_out.readFromParcel(_aidl_source);
105 return _aidl_out;
106 }
107 @Override
108 public Rect[] newArray(int _aidl_size) {
109 return new Rect[_aidl_size];
110 }
111 };
112 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
113 {
114 int _aidl_start_pos = _aidl_parcel.dataPosition();
115 _aidl_parcel.writeInt(0);
116 _aidl_parcel.writeInt(x);
117 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900118 if ((fd!=null)) {
119 _aidl_parcel.writeInt(1);
120 fd.writeToParcel(_aidl_parcel, 0);
121 }
122 else {
123 _aidl_parcel.writeInt(0);
124 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900125 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900126 int _aidl_end_pos = _aidl_parcel.dataPosition();
127 _aidl_parcel.setDataPosition(_aidl_start_pos);
128 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
129 _aidl_parcel.setDataPosition(_aidl_end_pos);
130 }
131 public final void readFromParcel(android.os.Parcel _aidl_parcel)
132 {
133 int _aidl_start_pos = _aidl_parcel.dataPosition();
134 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900136 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900137 x = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
139 y = _aidl_parcel.readInt();
140 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900141 if ((0!=_aidl_parcel.readInt())) {
142 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
143 }
144 else {
145 fd = null;
146 }
147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900148 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900149 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900150 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900151 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
152 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
153 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900154 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
155 }
156 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900157 @Override
158 public int describeContents() {
159 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900160 _mask |= describeContents(fd);
161 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900162 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900163 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900164 private int describeContents(Object _v) {
165 if (_v == null) return 0;
166 if (_v instanceof java.util.Collection) {
167 int _mask = 0;
168 for (Object o : (java.util.Collection) _v) {
169 _mask |= describeContents(o);
170 }
171 return _mask;
172 }
173 if (_v instanceof android.os.Parcelable) {
174 return ((android.os.Parcelable) _v).describeContents();
175 }
176 return 0;
177 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900178}
179)";
180
Devin Moore2f2077a2020-08-28 11:27:53 -0700181// clang-format off
182const char kExpectedCppHeaderOutput[] =
183 R"(#pragma once
184
185#include <binder/IBinder.h>
186#include <binder/IInterface.h>
187#include <binder/Status.h>
188#include <optional>
189#include <utils/String16.h>
190#include <utils/StrongPointer.h>
191#include <vector>
192
193class IFoo : public ::android::IInterface {
194public:
195 DECLARE_META_INTERFACE(Foo)
196 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
197}; // class IFoo
198class IFooDefault : public IFoo {
199public:
200 ::android::IBinder* onAsBinder() override {
201 return nullptr;
202 }
203 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
204 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
205 }
206}; // class IFooDefault
207)";
208// clang-format on
209
Christopher Wileyf8136192016-04-12 14:19:35 -0700210} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700213 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900214 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
215 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700216 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700217 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900218 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 args.emplace_back("aidl");
220 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700221 for (const string& s : additional_arguments) {
222 args.emplace_back(s);
223 }
224 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900225 args.emplace_back("--preprocessed=" + f);
226 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700227 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900228 args.emplace_back("--include=" + i);
229 }
230 args.emplace_back(path);
231 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900232 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900233 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700234 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900235 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900236
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700237 if (error != nullptr) {
238 *error = actual_error;
239 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900240
241 if (actual_error != AidlError::OK) {
242 return nullptr;
243 }
244
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900245 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900246 EXPECT_EQ(1ul, defined_types.size());
247
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900248 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700249 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700250
Devin Moore7b8d5c92020-03-17 14:14:08 -0700251 Options::Language GetLanguage() { return GetParam(); }
252
Christopher Wiley0522cd52015-10-28 15:39:44 -0700253 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800254 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900255 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900256 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700257};
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
260// tests with each of the supported languages as a parameter.
261INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
262 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700263 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 [](const testing::TestParamInfo<Options::Language>& info) {
265 return Options::LanguageToString(info.param);
266 });
267
268TEST_P(AidlTest, AcceptMissingPackage) {
269 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700270}
271
Devin Moore7b8d5c92020-03-17 14:14:08 -0700272TEST_P(AidlTest, EndsInSingleLineComment) {
273 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700274}
275
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000276TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
277 const string expected_stderr =
278 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
279 const std::string file_contents = "package a; interface IBar {}";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
283}
284
285TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
286 const string expected_stderr =
287 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
288 const std::string file_contents = "package a; interface Bar {}";
289 CaptureStderr();
290 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
291 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
292}
293
294TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
295 const string expected_stderr =
296 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
297 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
298 CaptureStderr();
299 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
300 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
301}
302
303TEST_P(AidlTest, EnumRequiresCorrectPath) {
304 const string expected_stderr =
305 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
306 const std::string file_contents = "package a; enum Bar { A, }";
307 CaptureStderr();
308 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
309 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
310}
311
Devin Moore7b8d5c92020-03-17 14:14:08 -0700312TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900313 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700314 io_delegate_.SetFileContents("bar/IBar.aidl",
315 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700316 const string path = "foo/IFoo.aidl";
317 const string contents =
318 "package foo;\n"
319 "import bar.IBar;\n"
320 "interface IFoo { void f(in IBar[] input); }";
321 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700323 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700325}
326
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700328 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700329 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900330}
Devin Moore097a3ab2020-03-11 16:08:44 -0700331
Jiyong Park40782d02020-07-24 19:17:43 +0900332TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700333 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
334 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900335 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
336 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700339 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900340}
341
Jiyong Park40782d02020-07-24 19:17:43 +0900342TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700343 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
344 const string expected_stderr =
345 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346 CaptureStderr();
347 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
348 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900349}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350
Jiyong Park40782d02020-07-24 19:17:43 +0900351TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700352 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900353 const string expected_stderr =
354 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
362 const string expected_stderr =
363 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
364 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700365 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700366 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
371 const string expected_stderr =
372 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
373 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700374 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800376}
377
Devin Moore2f2077a2020-08-28 11:27:53 -0700378TEST_P(AidlTest, AcceptNullableList) {
379 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
380 const string expected_stderr = "";
381 CaptureStderr();
382 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
383 EXPECT_EQ(expected_stderr, GetCapturedStderr());
384}
385
Devin Moore7b8d5c92020-03-17 14:14:08 -0700386TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700387 const string method = "package a; interface IFoo { void f(int a, int a); }";
388 const string expected_stderr =
389 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
390 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700393}
394
Jeongik Cha13066da2020-08-06 15:43:19 +0900395TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
396 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900397 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900398 CaptureStderr();
399 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
401}
402
Jooyung Hand902a972020-10-23 17:32:44 +0900403TEST_P(AidlTest, RejectsRepeatedAnnotations) {
404 const string method = R"(@Hide @Hide parcelable Foo {})";
405 const string expected_stderr =
406 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
407 "Foo.aidl:1.1-6\n";
408 CaptureStderr();
409 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
411}
412
Devin Moore7b8d5c92020-03-17 14:14:08 -0700413TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700414 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
415 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
416 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700418 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100419}
420
Devin Moore7b8d5c92020-03-17 14:14:08 -0700421TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700422 AidlError error;
423 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700424 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700425 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900426 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700427 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800428}
429
Devin Moore7b8d5c92020-03-17 14:14:08 -0700430TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700431 AidlError error;
432 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700433 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700434 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900435 EXPECT_THAT(GetCapturedStderr(),
436 HasSubstr("'JavaOnlyStableParcelable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700437 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800438}
439
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700441 AidlError error;
442 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700443 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000444 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900445 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700446 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800447}
448
Devin Moore7b8d5c92020-03-17 14:14:08 -0700449TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700450 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000451 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900454 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Jiyong Park40782d02020-07-24 19:17:43 +0900458TEST_P(AidlTest, ParsesNonNullableAnnotation) {
459 auto parse_result =
460 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
461 ASSERT_NE(nullptr, parse_result);
462 const AidlInterface* interface = parse_result->AsInterface();
463 ASSERT_NE(nullptr, interface);
464 ASSERT_FALSE(interface->GetMethods().empty());
465 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
466}
467
Devin Moore7b8d5c92020-03-17 14:14:08 -0700468TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900469 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
470 typenames_, GetLanguage());
471 ASSERT_NE(nullptr, parse_result);
472 const AidlInterface* interface = parse_result->AsInterface();
473 ASSERT_NE(nullptr, interface);
474 ASSERT_FALSE(interface->GetMethods().empty());
475 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
476}
477
478TEST_P(AidlTest, ParsesNonUtf8Annotations) {
479 auto parse_result =
480 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
481 ASSERT_NE(nullptr, parse_result);
482 const AidlInterface* interface = parse_result->AsInterface();
483 ASSERT_NE(nullptr, interface);
484 ASSERT_FALSE(interface->GetMethods().empty());
485 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800486}
487
Devin Moore7b8d5c92020-03-17 14:14:08 -0700488TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900489 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
490 typenames_, GetLanguage());
491 ASSERT_NE(nullptr, parse_result);
492 const AidlInterface* interface = parse_result->AsInterface();
493 ASSERT_NE(nullptr, interface);
494 ASSERT_FALSE(interface->GetMethods().empty());
495 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800496}
497
Devin Moore7b8d5c92020-03-17 14:14:08 -0700498TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700499 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700500 const string expected_stderr =
501 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
502 "\"vintf\"'\n"
503 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
504 "--structured\n";
505 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700506 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700507 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700509 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510}
511
Devin Moore7b8d5c92020-03-17 14:14:08 -0700512TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700513 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700514 const string expected_stderr =
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
528 "\"vintf\"'\n";
529 CaptureStderr();
530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700538 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
539 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700540 ASSERT_EQ(AidlError::OK, error);
541 ASSERT_NE(nullptr, parse_result);
542 const AidlInterface* interface = parse_result->AsInterface();
543 ASSERT_NE(nullptr, interface);
544 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545}
546
Jeongik Cha64783ed2019-06-07 18:30:54 +0900547TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
548 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900549 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
550 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900551 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700552 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900553 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900554 "a/Foo.aidl",
555 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900556
557 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900558 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700559 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900560 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700561 "Parcelable must be defined in AIDL directly.\n";
562 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900563 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700564 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700565
566 CaptureStderr();
567 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
568 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569}
570
Jooyung Han1cbc4962020-10-25 10:07:15 +0900571TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
572 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
573 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
574 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900575 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
576
577 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900578 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900579 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
580
581 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900582 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900583 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
584
Jooyung Han1cbc4962020-10-25 10:07:15 +0900585 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
587}
588
Jooyung Han1cbc4962020-10-25 10:07:15 +0900589TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
590 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
591 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
592 CaptureStderr();
593 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
594 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
595 EXPECT_EQ("", GetCapturedStderr());
596
597 const string expected_to_string_method = R"--(
598 @Override
599 public String toString() {
600 switch (_tag) {
601 case a: return "a.Foo.a(" + (getA()) + ")";
602 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
603 }
604 throw new IllegalStateException("unknown field: " + _tag);
605 }
606)--";
607
608 string java_out;
609 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
610 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
611}
612
Jiyong Park9aa3d042020-12-04 23:30:02 +0900613TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
614 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
615 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
616 CaptureStderr();
617 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
618 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
619 EXPECT_EQ("", GetCapturedStderr());
620
621 const std::string expected = R"--(
622 @Override
623 public boolean equals(Object other) {
624 if (this == other) return true;
625 if (other == null) return false;
626 if (!(other instanceof Foo)) return false;
627 Foo that = (Foo)other;
628 if (!java.util.Objects.deepEquals(a, that.a)) return false;
629 if (!java.util.Objects.deepEquals(b, that.b)) return false;
630 return true;
631 }
632
633 @Override
634 public int hashCode() {
635 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
636 }
637)--";
638
639 string java_out;
640 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
641 EXPECT_THAT(java_out, testing::HasSubstr(expected));
642}
643
644TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
645 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
646 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
647 CaptureStderr();
648 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
649 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
650 EXPECT_EQ("", GetCapturedStderr());
651
652 const std::string expected = R"--(
653 @Override
654 public boolean equals(Object other) {
655 if (this == other) return true;
656 if (other == null) return false;
657 if (!(other instanceof Foo)) return false;
658 Foo that = (Foo)other;
659 if (_tag != that._tag) return false;
660 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
661 return true;
662 }
663
664 @Override
665 public int hashCode() {
666 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
667 }
668)--";
669
670 string java_out;
671 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
672 EXPECT_THAT(java_out, testing::HasSubstr(expected));
673}
674
Jooyung Han90345002020-10-23 15:28:53 +0900675TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900676 {
Jooyung Han90345002020-10-23 15:28:53 +0900677 io_delegate_.SetFileContents("a/Foo.aidl",
678 "package a; @JavaDerive(blah=true) parcelable Foo{}");
679 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
680 CaptureStderr();
681 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
682 const std::string expected_stderr =
683 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900684 EXPECT_THAT(GetCapturedStderr(),
685 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900686 }
687
688 {
689 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900690 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
691 CaptureStderr();
692 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900693 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation"));
Jiyong Park43113fb2020-07-20 16:26:19 +0900694 }
695
696 {
Jooyung Han90345002020-10-23 15:28:53 +0900697 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900698 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
699 CaptureStderr();
700 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900701 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation"));
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 }
703}
704
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900705TEST_P(AidlTest, ParseDescriptorAnnotation) {
706 AidlError error;
707 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
708 typenames_, GetLanguage(), &error, {"--structured"});
709 ASSERT_EQ(AidlError::OK, error);
710 ASSERT_NE(nullptr, parse_result);
711 const AidlInterface* interface = parse_result->AsInterface();
712 ASSERT_NE(nullptr, interface);
713 ASSERT_EQ("IBar", interface->GetDescriptor());
714}
715
Jiyong Park40782d02020-07-24 19:17:43 +0900716TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700717 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700718 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900719}
720
721TEST_P(AidlTest, AcceptsOnewayInterface) {
722 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700723 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700724}
Christopher Wileyef140932015-11-03 09:29:19 -0800725
Devin Moore7b8d5c92020-03-17 14:14:08 -0700726TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700727 const string oneway_method =
728 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700729 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100730}
731
Steven Moreland65297cc2020-04-20 20:17:36 -0700732TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
733 const string oneway_method =
734 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
735 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
736 ASSERT_NE(nullptr, defined);
737 const AidlInterface* iface = defined->AsInterface();
738 ASSERT_NE(nullptr, iface);
739
740 const auto& methods = iface->GetMethods();
741 ASSERT_EQ(1u, methods.size());
742 const auto& method = methods[0];
743 const AidlTypeSpecifier& ret_type = method->GetType();
744
745 // TODO(b/151102494): these annotations should be on the method
746 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
747 ASSERT_TRUE(ret_type.IsHide());
748}
749
Devin Moore7b8d5c92020-03-17 14:14:08 -0700750TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100751 string foo_interface =
752 "package a; /* foo */ interface IFoo {"
753 " /* i */ int i();"
754 " /* j */ @nullable String j();"
755 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
756
Devin Moore7b8d5c92020-03-17 14:14:08 -0700757 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100758 EXPECT_NE(nullptr, parse_result);
759 EXPECT_EQ("/* foo */", parse_result->GetComments());
760
761 const AidlInterface* interface = parse_result->AsInterface();
762 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
763 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
764 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
765}
766
Jooyung Han1a551d32020-10-05 15:37:26 +0900767TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
768 io_delegate_.SetFileContents("p/cpp_header.aidl",
769 R"(package p;
770 parcelable cpp_header cpp_header "bar/header";)");
771 import_paths_.emplace("");
772 const string input_path = "p/IFoo.aidl";
773 const string input = R"(package p;
774 import p.cpp_header;
775 interface IFoo {
776 // get bar
777 cpp_header get();
778 })";
779
780 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
781 EXPECT_NE(nullptr, parse_result);
782 const AidlInterface* interface = parse_result->AsInterface();
783 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
784}
785
Christopher Wileyef140932015-11-03 09:29:19 -0800786TEST_F(AidlTest, ParsesPreprocessedFile) {
787 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
788 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700789 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900790 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800793}
794
795TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
796 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
797 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900798
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700799 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900800 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700801 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
802 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800803}
804
Devin Moore7b8d5c92020-03-17 14:14:08 -0700805TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800806 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
807 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
808 "interface IBar {}");
809 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900810 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900811 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700812 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800813 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900814
Christopher Wiley41544372015-11-03 14:52:29 -0800815 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700816 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
817 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800818 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700819 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900820 ambiguous_type.Resolve(typenames_);
821 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800822}
823
Jiyong Park8f6ec462020-01-19 20:52:47 +0900824// Special case of PreferImportToPreprocessed. Imported type should be preferred
825// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700826TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900827 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
828 io_delegate_.SetFileContents("one/IBar.aidl",
829 "package one; "
830 "interface IBar {}");
831 preprocessed_files_.push_back("preprocessed");
832 import_paths_.emplace("");
833 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700834 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900835 EXPECT_NE(nullptr, parse_result);
836
837 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700838 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
839 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900840 // But if we request just "IBar" we should get our imported one.
841 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
842 ambiguous_type.Resolve(typenames_);
843 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
844}
845
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800846TEST_F(AidlTest, WritePreprocessedFile) {
847 io_delegate_.SetFileContents("p/Outer.aidl",
848 "package p; parcelable Outer.Inner;");
849 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
850 "interface IBar {}");
851
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900852 vector<string> args {
853 "aidl",
854 "--preprocess",
855 "preprocessed",
856 "p/Outer.aidl",
857 "one/IBar.aidl"};
858 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800859 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
860
861 string output;
862 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
863 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
864}
865
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900866TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100867 io_delegate_.SetFileContents(
868 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800869 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100870 "parcelable Rect {\n"
871 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800872 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100873 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800874 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100875 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100876 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
877 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100878 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900879 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900880 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100881 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900882
883 vector<string> args{"aidl", "Rect.aidl"};
884 Options options = Options::From(args);
885 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
886
887 string output;
888 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900889 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900890}
891
Devin Moore2f2077a2020-08-28 11:27:53 -0700892TEST_F(AidlTest, CppHeaderIncludes) {
893 io_delegate_.SetFileContents("IFoo.aidl",
894 "interface IFoo {\n"
895 " @nullable List<String> foo();\n"
896 "}");
897
898 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
899 Options options = Options::From(args);
900 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
901 std::vector<std::string> empty;
902 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
903 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
904 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
905
906 // Make sure the optional and String16.h includes are added
907 string output;
908 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
909 EXPECT_EQ(kExpectedCppHeaderOutput, output);
910}
911
Devin Moore7b8d5c92020-03-17 14:14:08 -0700912TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700913 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800914 io_delegate_.SetFileContents("p/Outer.aidl",
915 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900916 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 CaptureStderr();
918 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
919 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700920 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800922}
923
Devin Moore7b8d5c92020-03-17 14:14:08 -0700924TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800925 io_delegate_.SetFileContents("preprocessed",
926 "parcelable p.Outer.Inner;");
927 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900928 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700929 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800930 // TODO(wiley): This should actually return nullptr because we require
931 // the outer class name. However, for legacy reasons,
932 // this behavior must be maintained. b/17415692
933 EXPECT_NE(nullptr, parse_result);
934}
935
Christopher Wiley632801d2015-11-05 14:15:49 -0800936TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700937 const string expected_foo_stderr =
938 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
939 "Declared parcelables should be in their own file and/or cannot be used with --structured "
940 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700941 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
942
Christopher Wiley632801d2015-11-05 14:15:49 -0800943 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700944 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700945 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900946 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700947 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900948
Steven Morelande2c64b42018-09-18 15:06:37 -0700949 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900950 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900952 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700954
Devin Moore097a3ab2020-03-11 16:08:44 -0700955 const string expected_bar_stderr =
956 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
957 "Declared parcelables should be in their own file and/or cannot be used with --structured "
958 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700959 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
960
Jiyong Parkda8c6932019-08-12 19:56:08 +0900961 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700962 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900964 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700965 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700966 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700967 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800970}
971
Devin Moore7b8d5c92020-03-17 14:14:08 -0700972TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700973 const string expected_stderr =
974 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
975 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700976 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
977 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 AidlError error;
979 CaptureStderr();
980 EXPECT_EQ(
981 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700982 Parse("p/IFoo.aidl",
983 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700984 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
986 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700987}
988
Devin Moore7b8d5c92020-03-17 14:14:08 -0700989TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700990 AidlError error;
991 const string expected_stderr =
992 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
993 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900994 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
995 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700996 interface IFoo {
997 const String DUPLICATED = "d";
998 const int DUPLICATED = 1;
999 }
1000 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001004}
1005
Steven Morelande689da22020-11-10 02:06:30 +00001006TEST_P(AidlTest, FailOnTooBigConstant) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1010 CaptureStderr();
1011 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1012 R"(package p;
1013 interface IFoo {
1014 const byte type2small = 256;
1015 }
1016 )",
1017 typenames_, GetLanguage(), &error));
1018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1019 EXPECT_EQ(AidlError::BAD_TYPE, error);
1020}
1021
Jooyung Han30f64ad2020-12-15 08:16:31 +09001022TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1023 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1024 CaptureStderr();
1025 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1026 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1027 EXPECT_EQ("", GetCapturedStderr());
1028 string code;
1029 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1030 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1031}
1032
Jooyung Han535c5e82020-12-29 15:16:59 +09001033TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001034 using Ptr = unique_ptr<AidlConstantValue>;
1035 const AidlLocation& loc = AIDL_LOCATION_HERE;
1036
Jooyung Han535c5e82020-12-29 15:16:59 +09001037 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1038 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1039 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1040 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001041
1042 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1043 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001044 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001045
1046 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1047 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1048 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1049 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001050 EXPECT_EQ(
1051 expected,
1052 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001053}
1054
Devin Moore7b8d5c92020-03-17 14:14:08 -07001055TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001056 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001057 const string expected_stderr =
1058 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001059 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001060 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1061 R"(package p;
1062 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001063 parcelable IBar {}
1064 parcelable StructuredParcelable {}
1065 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001066 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001067 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001068 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001069 // Parse success is important for clear error handling even if the cases aren't
1070 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001071 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001072}
1073
Devin Moore7b8d5c92020-03-17 14:14:08 -07001074TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001075 AidlError error;
1076 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1077 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001078 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001079 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1080 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001081}
1082
Steven Morelandf9e922f2020-07-08 21:15:27 +00001083TEST_P(AidlTest, FailOnEmptyListWithComma) {
1084 AidlError error;
1085 const string expected_stderr =
1086 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1087 CaptureStderr();
1088 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1089 typenames_, GetLanguage(), &error));
1090 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1091 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1092}
1093
Devin Moore7b8d5c92020-03-17 14:14:08 -07001094TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001095 AidlError error;
1096 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001097 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001098 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001099 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1100 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001101 interface IFoo {
1102 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1103 }
1104 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001105 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001106 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1107 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001108}
1109
Jiyong Park18132182020-06-08 20:24:40 +09001110TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1111 AidlError error;
1112 const string expected_stderr =
1113 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1114 "cpp_header (which can also be used as an identifier)\n";
1115 CaptureStderr();
1116 // Notice the trailing dot(.) in the name, which isn't a correct name
1117 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1118 GetLanguage(), &error));
1119 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1120 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1121}
1122
1123TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1124 AidlError error;
1125 const string expected_stderr =
1126 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1127 "cpp_header (which can also be used as an identifier)\n";
1128 CaptureStderr();
1129 // Notice the trailing dot(.) in the package name
1130 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1131 GetLanguage(), &error));
1132 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1133 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1134}
1135
Devin Moore7b8d5c92020-03-17 14:14:08 -07001136TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001137 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001138 auto parse_result = Parse("p/IFoo.aidl",
1139 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001140 interface IFoo {
1141 const int POSITIVE_HEX_VALUE = 0xf5;
1142 }
1143 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001144 typenames_, GetLanguage(), &error);
1145 EXPECT_NE(nullptr, parse_result);
1146 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001147 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001148 const auto& cpp_constants = interface->GetConstantDeclarations();
1149 EXPECT_EQ((size_t)1, cpp_constants.size());
1150 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001151 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001152 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001153}
1154
Devin Moore7b8d5c92020-03-17 14:14:08 -07001155TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001156 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001157 auto parse_result = Parse("p/IFoo.aidl",
1158 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001159 interface IFoo {
1160 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1161 }
1162 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001163 typenames_, GetLanguage(), &error);
1164 ASSERT_NE(nullptr, parse_result);
1165 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001166 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001167 const auto& cpp_constants = interface->GetConstantDeclarations();
1168 EXPECT_EQ((size_t)1, cpp_constants.size());
1169 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001170 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001171 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001172}
1173
Devin Moore7b8d5c92020-03-17 14:14:08 -07001174TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001175 io_delegate_.SetFileContents(
1176 "p/Outer.aidl",
1177 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001178 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001179 const string input_path = "p/IFoo.aidl";
1180 const string input = "package p; import p.Outer; interface IFoo"
1181 " { Outer.Inner get(); }";
1182
Devin Moore7b8d5c92020-03-17 14:14:08 -07001183 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1184 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001185
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001186 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001187 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001188 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1189 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001190}
1191
Devin Moore7b8d5c92020-03-17 14:14:08 -07001192TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001193 io_delegate_.SetFileContents(
1194 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001195 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001196 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001197 const string input_path = "p/IFoo.aidl";
1198 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001199 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1200 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001201 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001202 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1203 native_type.Resolve(typenames_);
1204
1205 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1206 // C++ understands C++ specific stuff
1207 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1208 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001209 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001210 EXPECT_EQ(1u, headers.size());
1211 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001212}
1213
Christopher Wileyf8136192016-04-12 14:19:35 -07001214TEST_F(AidlTest, WritesCorrectDependencyFile) {
1215 // While the in tree build system always gives us an output file name,
1216 // other android tools take advantage of our ability to infer the intended
1217 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001218 vector<string> args = {
1219 "aidl",
1220 "-d dep/file/path",
1221 "-o place/for/output",
1222 "p/IFoo.aidl"};
1223 Options options = Options::From(args);
1224 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001225 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001226 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001227 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001228 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1229}
1230
Dan Willemsen93298ee2016-11-10 23:55:55 -08001231TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1232 // While the in tree build system always gives us an output file name,
1233 // other android tools take advantage of our ability to infer the intended
1234 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001235 vector<string> args = {
1236 "aidl",
1237 "-d dep/file/path",
1238 "--ninja",
1239 "-o place/for/output",
1240 "p/IFoo.aidl"};
1241 Options options = Options::From(args);
1242 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001243 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001244 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001245 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001246 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1247}
1248
Jiyong Parkdf202122019-09-30 20:48:35 +09001249TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001250 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1251 // this by calling aidl with every .aidl file it finds, then parsing the
1252 // generated dependency files. Those that reference .java output files are
1253 // for interfaces and those that do not are parcelables. However, for both
1254 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001255 vector<string> args = {
1256 "aidl",
1257 "-o place/for/output",
1258 "-d dep/file/path",
1259 "p/Foo.aidl"};
1260 Options options = Options::From(args);
1261 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001262 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001263 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001264 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001265 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1266}
1267
1268TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1269 vector<string> args = {
1270 "aidl",
1271 "--structured",
1272 "-o place/for/output",
1273 "-d dep/file/path",
1274 "p/Foo.aidl"};
1275 Options options = Options::From(args);
1276 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1277 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1278 string actual_dep_file_contents;
1279 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1280 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001281}
1282
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001283TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1284 vector<string> args = {
1285 "aidl",
1286 "--lang=java",
1287 "-o place/for/output",
1288 "p/Foo.aidl"};
1289 Options options = Options::From(args);
1290 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1291 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1292 string output_file_contents;
1293 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1294}
1295
Devin Moore21b26772020-08-26 16:37:56 -07001296TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001297 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001298 const string list_array_parcelable =
1299 "package a; parcelable Foo {\n"
1300 " List[] lists; }";
1301 CaptureStderr();
1302 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1304}
1305
Jiyong Parkf8d53612020-05-04 14:06:13 +09001306TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1307 AidlError error;
1308 string expected_stderr =
1309 "ERROR: a/IFoo.aidl:2.7-11: "
1310 "Encountered an untyped List or Map. The use of untyped List/Map is "
1311 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1312 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1313 if (GetLanguage() != Options::Language::JAVA) {
1314 expected_stderr =
1315 "ERROR: a/IFoo.aidl:2.1-7: "
1316 "Currently, only the Java backend supports non-generic List.\n";
1317 }
1318
1319 const string primitive_interface =
1320 "package a; interface IFoo {\n"
1321 " List foo(); }";
1322 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001323 AidlTypenames tn1;
1324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001325 {"--structured"}));
1326 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001327
1328 string primitive_parcelable =
1329 "package a; parcelable IFoo {\n"
1330 " List foo;}";
1331 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001332 AidlTypenames tn2;
1333 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001334 {"--structured"}));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336}
1337
Jeongik Cha225519b2020-08-29 01:55:32 +09001338TEST_P(AidlTest, ExtensionTest) {
1339 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001340 string extendable_parcelable =
1341 "package a; parcelable Data {\n"
1342 " ParcelableHolder extension;\n"
1343 " ParcelableHolder extension2;\n"
1344 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001345 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001346 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1347 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001348 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001349 "yet.\n",
1350 GetCapturedStderr());
1351 } else {
1352 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1353 EXPECT_EQ("", GetCapturedStderr());
1354 }
1355}
1356TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1357 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001358 string parcelableholder_return_interface =
1359 "package a; interface IFoo {\n"
1360 " ParcelableHolder foo();\n"
1361 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001362 EXPECT_EQ(nullptr,
1363 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001364
Jeongik Cha8f02a532020-10-14 00:16:28 +09001365 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001366 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001367 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001368 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001369 "yet.\n",
1370 GetCapturedStderr());
1371 return;
1372 }
1373 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1374 GetCapturedStderr());
1375}
1376
1377TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1378 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001379 string extendable_parcelable_arg_interface =
1380 "package a; interface IFoo {\n"
1381 " void foo(in ParcelableHolder ph);\n"
1382 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001383 EXPECT_EQ(nullptr,
1384 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1385
Jeongik Cha8f02a532020-10-14 00:16:28 +09001386 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001387 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001388 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001389 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001390 "yet.\n",
1391 GetCapturedStderr());
1392 return;
1393 }
1394 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1395 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001396}
1397
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001398TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1399 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1400 Options options =
1401 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1402 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1403 CaptureStderr();
1404 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1405 if (GetLanguage() == Options::Language::RUST) {
1406 EXPECT_EQ(
1407 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1408 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1409 "yet.\n",
1410 GetCapturedStderr());
1411 return;
1412 }
1413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1414}
1415
Jooyung Han3f347ca2020-12-01 12:41:50 +09001416TEST_P(AidlTest, ParcelablesWithConstants) {
1417 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1418 Options options =
1419 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1420 CaptureStderr();
1421 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1422 EXPECT_EQ("", GetCapturedStderr());
1423}
1424
1425TEST_P(AidlTest, UnionWithConstants) {
1426 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1427 Options options =
1428 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1429 CaptureStderr();
1430 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1431 EXPECT_EQ("", GetCapturedStderr());
1432}
1433
Jiyong Park02da7422018-07-16 16:00:26 +09001434TEST_F(AidlTest, ApiDump) {
1435 io_delegate_.SetFileContents(
1436 "foo/bar/IFoo.aidl",
1437 "package foo.bar;\n"
1438 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001439 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001440 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001441 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001442 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1443 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1444 " IFoo foo3(IFoo foo);\n"
1445 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001446 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001447 " const int A = 1;\n"
1448 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001449 "}\n");
1450 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1451 "package foo.bar;\n"
1452 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001453 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001454 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001455 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001456 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001457 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001458 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001459 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001460 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001461 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001462 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001463 "}\n");
1464 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001465 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1466 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001467 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001468 bool result = dump_api(options, io_delegate_);
1469 ASSERT_TRUE(result);
1470 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001471 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001472 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001473/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001474interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001475 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001476 int foo(out int[] a, String b, boolean c, inout List<String> d);
1477 int foo2(@utf8InCpp String x, inout List<String> y);
1478 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1479 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001480 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001481 const int A = 1;
1482 const String STR = "Hello";
1483}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001484)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001485
Jiyong Parke59c3682018-09-11 23:10:25 +09001486 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001487 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001488/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001489parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001490 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001491 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001492 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001493 int y;
1494 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001495 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001496 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001497}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001498)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001499}
1500
Jiyong Parked65bf42018-08-28 15:43:27 +09001501TEST_F(AidlTest, ApiDumpWithManualIds) {
1502 io_delegate_.SetFileContents(
1503 "foo/bar/IFoo.aidl",
1504 "package foo.bar;\n"
1505 "interface IFoo {\n"
1506 " int foo() = 1;\n"
1507 " int bar() = 2;\n"
1508 " int baz() = 10;\n"
1509 "}\n");
1510
Jiyong Parke59c3682018-09-11 23:10:25 +09001511 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001512 Options options = Options::From(args);
1513 bool result = dump_api(options, io_delegate_);
1514 ASSERT_TRUE(result);
1515 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001516 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001517 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001518interface IFoo {
1519 int foo() = 1;
1520 int bar() = 2;
1521 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001522}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001523)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001524}
1525
1526TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001527 const string expected_stderr =
1528 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1529 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001530 io_delegate_.SetFileContents(
1531 "foo/bar/IFoo.aidl",
1532 "package foo.bar;\n"
1533 "interface IFoo {\n"
1534 " int foo() = 1;\n"
1535 " int bar();\n"
1536 " int baz() = 10;\n"
1537 "}\n");
1538
Jiyong Parke59c3682018-09-11 23:10:25 +09001539 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001540 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001541 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001542 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001544}
1545
Jooyung Han965e31d2020-11-27 12:30:16 +09001546TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1547 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1548 "package foo.bar;\n"
1549 "interface IFoo {\n"
1550 " @utf8InCpp String foo();\n"
1551 " const @utf8InCpp String bar = \"bar\";\n"
1552 "}\n");
1553
1554 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1555 Options options = Options::From(args);
1556 CaptureStderr();
1557 EXPECT_TRUE(dump_api(options, io_delegate_));
1558 EXPECT_EQ("", GetCapturedStderr());
1559 string actual;
1560 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001561 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1562interface IFoo {
1563 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001564 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001565}
1566)"),
1567 actual);
1568}
1569
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001570TEST_F(AidlTest, ApiDumpWithEnums) {
1571 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1572 "package foo.bar;\n"
1573 "enum Enum {\n"
1574 " FOO,\n"
1575 " BAR = FOO + 1,\n"
1576 "}\n");
1577
1578 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1579 Options options = Options::From(args);
1580 CaptureStderr();
1581 EXPECT_TRUE(dump_api(options, io_delegate_));
1582 EXPECT_EQ("", GetCapturedStderr());
1583 string actual;
1584 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1585 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1586 "enum Enum {\n"
1587 " FOO = 0,\n"
1588 " BAR = 1,\n"
1589 "}\n"),
1590 actual);
1591}
1592
1593TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1594 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1595 "package foo.bar;\n"
1596 "enum Enum {\n"
1597 " FOO,\n"
1598 "}\n");
1599 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1600 "package foo.bar;\n"
1601 "import foo.bar.Enum;\n"
1602 "parcelable Foo {\n"
1603 " Enum e = Enum.FOO;\n"
1604 "}\n");
1605
1606 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1607 Options options = Options::From(args);
1608 CaptureStderr();
1609 EXPECT_TRUE(dump_api(options, io_delegate_));
1610 EXPECT_EQ("", GetCapturedStderr());
1611 string actual;
1612 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1613 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1614 "parcelable Foo {\n"
1615 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1616 "}\n"),
1617 actual);
1618}
1619
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001620TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001621 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001622 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1623 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001624 const string expected_map_stderr =
1625 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001626 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1627 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001628 "package p; interface IFoo {"
1629 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001630 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001631 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001632 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001633
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001634 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001635 "package p; interface IFoo {"
1636 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001637 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001638 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001639 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001640}
1641
Jeongik Chae48d9942020-01-02 17:39:00 +09001642TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001643 const string expected_stderr =
1644 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001645 Options options = Options::From("aidl -I p p/IFoo.aidl");
1646 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1647
1648 io_delegate_.SetFileContents("p/IFoo.aidl",
1649 "package p; interface IFoo {"
1650 "Map<String, Bar> foo();}");
1651 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1652
1653 io_delegate_.SetFileContents("p/IFoo.aidl",
1654 "package p; interface IFoo {"
1655 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001656 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001657 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001658 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001659
1660 io_delegate_.SetFileContents("p/IFoo.aidl",
1661 "package p; interface IFoo {"
1662 "Map<String, String> foo();}");
1663 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1664
1665 io_delegate_.SetFileContents("p/IFoo.aidl",
1666 "package p; interface IFoo {"
1667 "Map<String, ParcelFileDescriptor> foo();}");
1668 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1669}
1670
Jeongik Chadf76dc72019-11-28 00:08:47 +09001671TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001672 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001673 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1674 io_delegate_.SetFileContents(options.InputFiles().front(),
1675 "package p; interface IFoo {"
1676 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001677 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001678 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001679 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001680}
1681
1682TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1683 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1684 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001685 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001687 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1688 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001689
1690 Options options = Options::From("aidl -I p p/IFoo.aidl");
1691 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1692 io_delegate_.SetFileContents("p/IFoo.aidl",
1693 "package p; interface IFoo {"
1694 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001695 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001696 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001697 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001698 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001699 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001700 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001701 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1702 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001703 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1704 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1705 io_delegate_.SetFileContents("p/IFoo.aidl",
1706 "package p; interface IFoo {"
1707 "Bar<String, ParcelFileDescriptor> foo();}");
1708 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001709
1710 io_delegate_.SetFileContents("p/IFoo.aidl",
1711 "package p; interface IFoo {"
1712 "Bar<int, long> foo();}");
1713
1714 io_delegate_.SetFileContents("p/IFoo.aidl",
1715 "package p; interface IFoo {"
1716 "Bar<int[], long[]> foo();}");
1717
1718 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001719}
1720
Jeongik Cha0e426012019-07-29 15:57:02 +09001721TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1722 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001723 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1724 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001725 for (const auto& rawOption : rawOptions) {
1726 string expected_stderr =
1727 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001728 Options options = Options::From(rawOption);
1729 io_delegate_.SetFileContents(options.InputFiles().front(),
1730 "package foo.bar;\n"
1731 "interface IFoo1 { int foo(); }\n"
1732 "interface IFoo2 { int foo(); }\n"
1733 "parcelable Data1 { int a; int b;}\n"
1734 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001735 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001736 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001737 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001738
Jeongik Cha0e426012019-07-29 15:57:02 +09001739 io_delegate_.SetFileContents(options.InputFiles().front(),
1740 "package foo.bar;\n"
1741 "interface IFoo1 { int foo(); }\n"
1742 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001743 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001744 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001746
Devin Moore5de18ed2020-04-02 13:52:29 -07001747 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001748 io_delegate_.SetFileContents(options.InputFiles().front(),
1749 "package foo.bar;\n"
1750 "parcelable Data1 { int a; int b;}\n"
1751 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001752 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001753 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001754 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001755 }
1756}
1757
Devin Moorebdba2a82020-03-31 15:19:02 -07001758TEST_P(AidlTest, FailParseOnEmptyFile) {
1759 const string contents = "";
1760 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1761 CaptureStderr();
1762 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1763 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1764}
1765
Jiyong Parkb034bf02018-07-30 17:44:33 +09001766TEST_F(AidlTest, MultipleInputFiles) {
1767 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001768 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001769
1770 io_delegate_.SetFileContents(options.InputFiles().at(0),
1771 "package foo.bar;\n"
1772 "import foo.bar.Data;\n"
1773 "interface IFoo { Data getData(); }\n");
1774
1775 io_delegate_.SetFileContents(options.InputFiles().at(1),
1776 "package foo.bar;\n"
1777 "import foo.bar.IFoo;\n"
1778 "parcelable Data { IFoo foo; }\n");
1779
1780 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1781
1782 string content;
1783 for (const auto file : {
1784 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1785 content.clear();
1786 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1787 EXPECT_FALSE(content.empty());
1788 }
1789}
1790
1791TEST_F(AidlTest, MultipleInputFilesCpp) {
1792 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001793 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001794
1795 io_delegate_.SetFileContents(options.InputFiles().at(0),
1796 "package foo.bar;\n"
1797 "import foo.bar.Data;\n"
1798 "interface IFoo { Data getData(); }\n");
1799
1800 io_delegate_.SetFileContents(options.InputFiles().at(1),
1801 "package foo.bar;\n"
1802 "import foo.bar.IFoo;\n"
1803 "parcelable Data { IFoo foo; }\n");
1804
1805 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1806
1807 string content;
1808 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001809 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001810 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1811 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1812 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1813 content.clear();
1814 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1815 EXPECT_FALSE(content.empty());
1816 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001817}
1818
Andrei Homescub62afd92020-05-11 19:24:59 -07001819TEST_F(AidlTest, MultipleInputFilesRust) {
1820 Options options =
1821 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1822
1823 io_delegate_.SetFileContents(options.InputFiles().at(0),
1824 "package foo.bar;\n"
1825 "import foo.bar.Data;\n"
1826 "interface IFoo { Data getData(); }\n");
1827
1828 io_delegate_.SetFileContents(options.InputFiles().at(1),
1829 "package foo.bar;\n"
1830 "import foo.bar.IFoo;\n"
1831 "parcelable Data { IFoo foo; }\n");
1832
1833 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1834
1835 string content;
1836 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1837 content.clear();
1838 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1839 EXPECT_FALSE(content.empty());
1840 }
1841}
1842
Devin Moore097a3ab2020-03-11 16:08:44 -07001843TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1844 const string expected_stderr =
1845 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001846 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1847 // int getInterfaceVersion() is one of the meta transactions
1848 io_delegate_.SetFileContents(options.InputFiles().front(),
1849 "package p; interface IFoo {"
1850 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001851 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001852 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001853 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1854}
Jiyong Park309668e2018-07-28 16:55:44 +09001855
Devin Moore097a3ab2020-03-11 16:08:44 -07001856TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1857 // boolean getInterfaceVersion() is not a meta transaction, but should be
1858 // prevented because return type is not part of a method signature
1859 const string expected_stderr =
1860 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1861 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001862 io_delegate_.SetFileContents(options.InputFiles().front(),
1863 "package p; interface IFoo {"
1864 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001865 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001866 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1868}
Jiyong Park309668e2018-07-28 16:55:44 +09001869
Devin Moore097a3ab2020-03-11 16:08:44 -07001870TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001871 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001872 const string expected_stderr =
1873 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1874 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001875 io_delegate_.SetFileContents(options.InputFiles().front(),
1876 "package p; interface IFoo {"
1877 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001878 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001879 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001880 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001881
1882 // this is not a meta interface method as it differs type arguments
1883 io_delegate_.SetFileContents(options.InputFiles().front(),
1884 "package p; interface IFoo {"
1885 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001886 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001887}
1888
Daniel Norman85aed542019-08-21 12:01:14 -07001889TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001890 Options options = Options::From("aidl --checkapi old new");
1891 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1892 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1893 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1894 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1895
1896 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1897}
1898
Jiyong Park3656c3c2018-08-01 20:02:01 +09001899TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001900 Options options = Options::From("aidl --checkapi old new");
1901 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1902 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001903
1904 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1905}
1906
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001907TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1908 Options options = Options::From("aidl --checkapi old new");
1909 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1910 const string enum_definition = "package p; enum Enum { FOO }";
1911 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1912 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1913 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1914 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1915
1916 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1917}
1918
Daniel Norman85aed542019-08-21 12:01:14 -07001919class AidlTestCompatibleChanges : public AidlTest {
1920 protected:
1921 Options options_ = Options::From("aidl --checkapi old new");
1922};
1923
1924TEST_F(AidlTestCompatibleChanges, NewType) {
1925 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1926 "package p;"
1927 "interface IFoo {"
1928 " void foo(int a);"
1929 "}");
1930 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1931 "package p;"
1932 "interface IFoo {"
1933 " void foo(int a);"
1934 "}");
1935 io_delegate_.SetFileContents("new/p/IBar.aidl",
1936 "package p;"
1937 "interface IBar {"
1938 " void bar();"
1939 "}");
1940 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1941}
1942
1943TEST_F(AidlTestCompatibleChanges, NewMethod) {
1944 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1945 "package p;"
1946 "interface IFoo {"
1947 " void foo(int a);"
1948 "}");
1949 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1950 "package p;"
1951 "interface IFoo {"
1952 " void foo(int a);"
1953 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001954 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001955 "}");
1956 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1957}
1958
1959TEST_F(AidlTestCompatibleChanges, NewField) {
1960 io_delegate_.SetFileContents("old/p/Data.aidl",
1961 "package p;"
1962 "parcelable Data {"
1963 " int foo;"
1964 "}");
1965 io_delegate_.SetFileContents("new/p/Data.aidl",
1966 "package p;"
1967 "parcelable Data {"
1968 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001969 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001970 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001971 "}");
1972 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1973}
1974
1975TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1976 io_delegate_.SetFileContents("old/p/Enum.aidl",
1977 "package p;"
1978 "enum Enum {"
1979 " FOO = 1,"
1980 "}");
1981 io_delegate_.SetFileContents("new/p/Enum.aidl",
1982 "package p;"
1983 "enum Enum {"
1984 " FOO = 1,"
1985 " BAR = 2,"
1986 "}");
1987 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1988}
1989
1990TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1991 io_delegate_.SetFileContents("old/p/Enum.aidl",
1992 "package p;"
1993 "enum Enum {"
1994 " FOO = 1,"
1995 " BAR = 2,"
1996 "}");
1997 io_delegate_.SetFileContents("new/p/Enum.aidl",
1998 "package p;"
1999 "enum Enum {"
2000 " BAR = 2,"
2001 " FOO = 1,"
2002 "}");
2003 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2004}
2005
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002006TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2007 io_delegate_.SetFileContents("old/p/Union.aidl",
2008 "package p;"
2009 "union Union {"
2010 " String foo;"
2011 "}");
2012 io_delegate_.SetFileContents("new/p/Union.aidl",
2013 "package p;"
2014 "union Union {"
2015 " String foo;"
2016 " int num;"
2017 "}");
2018 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2019}
2020
Daniel Norman85aed542019-08-21 12:01:14 -07002021TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002022 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2023 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002024 "interface IFoo {"
2025 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002026 "}");
2027 io_delegate_.SetFileContents("old/p/Data.aidl",
2028 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002029 "parcelable Data {"
2030 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002031 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002032 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2033 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002034 "interface IFoo {"
2035 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002036 "}");
2037 io_delegate_.SetFileContents("new/p/Data.aidl",
2038 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002039 "parcelable Data {"
2040 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002041 "}");
2042 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2043 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002044 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002045 " void foo(int a);"
2046 "}");
2047 io_delegate_.SetFileContents("new/q/Data.aidl",
2048 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002049 "parcelable Data {"
2050 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002051 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002052 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2053}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002054
Daniel Norman85aed542019-08-21 12:01:14 -07002055TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2056 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2057 "package p;"
2058 "interface IFoo {"
2059 " void foo(int a);"
2060 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002061 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2062 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002063 "interface IFoo {"
2064 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002065 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002066 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2067}
Jiyong Parke59c3682018-09-11 23:10:25 +09002068
Daniel Norman85aed542019-08-21 12:01:14 -07002069TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002070 io_delegate_.SetFileContents("old/p/I.aidl",
2071 "package p; interface I {"
2072 "const int A = 1; }");
2073 io_delegate_.SetFileContents("new/p/I.aidl",
2074 "package p ; interface I {"
2075 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002076 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2077}
Jiyong Parka428d212018-08-29 22:26:30 +09002078
Daniel Norman85aed542019-08-21 12:01:14 -07002079TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002080 io_delegate_.SetFileContents("old/p/I.aidl",
2081 "package p; interface I {"
2082 "const int A = 1; const int B = 2;}");
2083 io_delegate_.SetFileContents("new/p/I.aidl",
2084 "package p ; interface I {"
2085 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002086 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002087}
2088
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002089TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2090 io_delegate_.SetFileContents("old/p/Foo.aidl",
2091 "package p;"
2092 "@JavaPassthrough(annotation=\"Alice\")"
2093 "@JavaPassthrough(annotation=\"Bob\")"
2094 "parcelable Foo {}");
2095 io_delegate_.SetFileContents("new/p/Foo.aidl",
2096 "package p;"
2097 "@JavaPassthrough(annotation=\"Bob\")"
2098 "@JavaPassthrough(annotation=\"Alice\")"
2099 "parcelable Foo {}");
2100 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2101}
2102
Jooyung Han00073272020-11-27 14:20:20 +09002103TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2104 io_delegate_.SetFileContents("old/p/Foo.aidl",
2105 "package p;"
2106 "parcelable Foo {}");
2107 io_delegate_.SetFileContents("new/p/Foo.aidl",
2108 "package p;"
2109 "@JavaPassthrough(annotation=\"@Deprecated\")"
2110 "parcelable Foo {}");
2111 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2112}
2113
Jooyung Han636fd2f2020-10-22 11:33:45 +09002114TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2115 io_delegate_.SetFileContents("old/p/Data.aidl",
2116 "package p;"
2117 "parcelable Data {"
2118 " int num;"
2119 "}");
2120 io_delegate_.SetFileContents(
2121 "new/p/Data.aidl",
2122 "package p;"
2123 "parcelable Data {"
2124 " int num;"
2125 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2126 "}");
2127 io_delegate_.SetFileContents("new/p/Enum.aidl",
2128 "package p;"
2129 "enum Enum {"
2130 " FOO = 0,"
2131 " BAR = 1,"
2132 "}");
2133 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2134}
2135
Daniel Norman85aed542019-08-21 12:01:14 -07002136class AidlTestIncompatibleChanges : public AidlTest {
2137 protected:
2138 Options options_ = Options::From("aidl --checkapi old new");
2139};
2140
2141TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002142 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002143 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2144 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002145 "interface IFoo {"
2146 " void foo(in String[] str);"
2147 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002148 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002149 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002150 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002151 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002152}
2153
2154TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002155 const string expected_stderr =
2156 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002157 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2158 "package p;"
2159 "interface IFoo {"
2160 " void foo(in String[] str);"
2161 " void bar(@utf8InCpp String str);"
2162 "}");
2163 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2164 "package p;"
2165 "interface IFoo {"
2166 " void foo(in String[] str);"
2167 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002168 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002169 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002170 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002171}
2172
Jiyong Parkf8d53612020-05-04 14:06:13 +09002173TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2174 const string expected_stderr =
2175 "ERROR: new/p/IFoo.aidl:1.61-65: "
2176 "Encountered an untyped List or Map. The use of untyped List/Map is "
2177 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2178 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2179 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2180 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2181 "package p;"
2182 "interface IFoo {"
2183 " void foo(in String[] str);"
2184 "}");
2185 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2186 "package p;"
2187 "interface IFoo {"
2188 " void foo(in String[] str);"
2189 " void bar(in List arg);"
2190 "}");
2191 CaptureStderr();
2192 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2194}
2195
2196TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2197 const string expected_stderr =
2198 "ERROR: new/p/Data.aidl:1.54-59: "
2199 "Encountered an untyped List or Map. The use of untyped List/Map is "
2200 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2201 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2202 "ERROR: new/p/Data.aidl: Failed to read.\n";
2203 io_delegate_.SetFileContents("old/p/Data.aidl",
2204 "package p;"
2205 "parcelable Data {"
2206 " int foo;"
2207 "}");
2208 io_delegate_.SetFileContents("new/p/Data.aidl",
2209 "package p;"
2210 "parcelable Data {"
2211 " int foo;"
2212 " @nullable List list;"
2213 "}");
2214 CaptureStderr();
2215 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2216 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2217}
2218
Daniel Norman85aed542019-08-21 12:01:14 -07002219TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002220 const string expected_stderr =
2221 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002222 io_delegate_.SetFileContents("old/p/Data.aidl",
2223 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002224 "parcelable Data {"
2225 " int foo;"
2226 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002227 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002228 io_delegate_.SetFileContents("new/p/Data.aidl",
2229 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002230 "parcelable Data {"
2231 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002232 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002233 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002234 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002235 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002236}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002237
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002238TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2239 const string expected_stderr =
2240 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2241 "backends. Please either provide a default value for this field or mark the field as "
2242 "@nullable. This value or a null value will be used automatically when an old version of "
2243 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2244 "order to make sure your code continues to be backwards compatible, make sure the default or "
2245 "null value does not cause a semantic change to this parcelable.\n";
2246 io_delegate_.SetFileContents("old/p/Data.aidl",
2247 "package p;"
2248 "parcelable Data {"
2249 " int num;"
2250 "}");
2251 io_delegate_.SetFileContents("new/p/Data.aidl",
2252 "package p;"
2253 "parcelable Data {"
2254 " int num;"
2255 " String str;"
2256 "}");
2257 CaptureStderr();
2258 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2260}
2261
Jooyung Han636fd2f2020-10-22 11:33:45 +09002262TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2263 const string expected_stderr =
2264 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2265 "Please make sure 'Enum' has '0' as a valid value.\n";
2266 io_delegate_.SetFileContents("old/p/Data.aidl",
2267 "package p;"
2268 "parcelable Data {"
2269 " int num;"
2270 "}");
2271 io_delegate_.SetFileContents("new/p/Data.aidl",
2272 "package p;"
2273 "parcelable Data {"
2274 " int num;"
2275 " p.Enum e;"
2276 "}");
2277 io_delegate_.SetFileContents("new/p/Enum.aidl",
2278 "package p;"
2279 "enum Enum {"
2280 " FOO = 1,"
2281 " BAR = 2,"
2282 "}");
2283 CaptureStderr();
2284 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2285 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2286}
2287
Daniel Norman85aed542019-08-21 12:01:14 -07002288TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002289 const string expected_stderr =
2290 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002291 io_delegate_.SetFileContents("old/p/Enum.aidl",
2292 "package p;"
2293 "enum Enum {"
2294 " FOO = 1,"
2295 " BAR = 2,"
2296 "}");
2297 io_delegate_.SetFileContents("new/p/Enum.aidl",
2298 "package p;"
2299 "enum Enum {"
2300 " BAR = 2,"
2301 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002302 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002303 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002304 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002305}
2306
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002307TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2308 const string expected_stderr =
2309 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2310 io_delegate_.SetFileContents("old/p/Union.aidl",
2311 "package p;"
2312 "union Union {"
2313 " String str;"
2314 " int num;"
2315 "}");
2316 io_delegate_.SetFileContents("new/p/Union.aidl",
2317 "package p;"
2318 "union Union {"
2319 " String str;"
2320 "}");
2321 CaptureStderr();
2322 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2324}
2325
Daniel Norman85aed542019-08-21 12:01:14 -07002326TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002327 const string expected_stderr =
2328 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002329 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2330 "package p;"
2331 "interface IFoo {"
2332 " void foo(in String[] str);"
2333 " void bar(@utf8InCpp String str);"
2334 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002335 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2336 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002337 "interface IFoo {"
2338 " void foo(in String[] str);"
2339 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002340 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002341 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002342 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002344}
2345
Daniel Norman85aed542019-08-21 12:01:14 -07002346TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002347 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002348 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2349 "package p;"
2350 "interface IFoo {"
2351 " void foo(in String[] str);"
2352 " void bar(@utf8InCpp String str);"
2353 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002354 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2355 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002356 "interface IFoo2 {"
2357 " void foo(in String[] str);"
2358 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002359 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002360 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002361 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002363}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002364
Daniel Norman85aed542019-08-21 12:01:14 -07002365TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 const string expected_stderr =
2367 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002368 io_delegate_.SetFileContents("old/p/Enum.aidl",
2369 "package p;"
2370 "enum Enum {"
2371 " FOO = 1,"
2372 " BAR = 2,"
2373 "}");
2374 io_delegate_.SetFileContents("new/p/Enum.aidl",
2375 "package p;"
2376 "enum Enum {"
2377 " FOO = 3,"
2378 " BAR = 2,"
2379 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002380 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002381 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002383}
2384
2385TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002386 const string expected_stderr =
2387 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2388 "from 0 to 1.\n"
2389 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2390 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002391 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2392 "package p;"
2393 "interface IFoo {"
2394 " void foo(in String[] str);"
2395 " void bar(@utf8InCpp String str);"
2396 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002397 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2398 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002399 "interface IFoo {"
2400 " void bar(@utf8InCpp String str);"
2401 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002402 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002403 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002404 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002405 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002406}
2407
2408TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002409 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002410 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2411 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002412 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002413 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002414 "parcelable Data {"
2415 " int foo;"
2416 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002417 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002418 io_delegate_.SetFileContents("new/p/Data.aidl",
2419 "package p;"
2420 "parcelable Data {"
2421 " int bar;"
2422 " int foo;"
2423 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002425 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002427}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002428
Daniel Norman85aed542019-08-21 12:01:14 -07002429TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002430 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002431 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002432 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002433 "interface IFoo {"
2434 " void foo(in String[] str);"
2435 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002436 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002437 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2438 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002439 "interface IFoo {"
2440 " void foo(out String[] str);"
2441 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002442 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002443 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002444 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002445 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002446}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002447
Daniel Norman85aed542019-08-21 12:01:14 -07002448TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002449 const string expected_stderr =
2450 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002451 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2452 "package p;"
2453 "interface IFoo {"
2454 " void foo(in String[] str);"
2455 " void bar(@utf8InCpp String str);"
2456 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002457 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2458 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002459 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002460 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002461 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002462 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002463 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002464 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002466}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002467
Daniel Norman85aed542019-08-21 12:01:14 -07002468TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002469 const string expected_stderr =
2470 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002471 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2472 "package p;"
2473 "interface IFoo {"
2474 " void foo(in String[] str);"
2475 " void bar(@utf8InCpp String str);"
2476 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002477 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2478 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002479 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002480 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002481 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002482 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002483 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002484 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002485 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002486}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002487
Jooyung Han60b2fde2020-10-29 15:12:40 +09002488TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2489 const string expected_stderr =
2490 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2491 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2492 io_delegate_.SetFileContents("old/p/Foo.aidl",
2493 "package p;"
2494 "@Backing(type=\"byte\")"
2495 "enum Foo {"
2496 " FOO, BAR,"
2497 "}");
2498 io_delegate_.SetFileContents("new/p/Foo.aidl",
2499 "package p;"
2500 "@Backing(type=\"long\")"
2501 "enum Foo {"
2502 " FOO, BAR,"
2503 "}");
2504 CaptureStderr();
2505 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2507}
2508
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002509TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2510 const string expected_stderr =
2511 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2512 "to @JavaPassthrough(annotation=\"Bob\")\n";
2513 io_delegate_.SetFileContents("old/p/Foo.aidl",
2514 "package p;"
2515 "@JavaPassthrough(annotation=\"Alice\")"
2516 "parcelable Foo {}");
2517 io_delegate_.SetFileContents("new/p/Foo.aidl",
2518 "package p;"
2519 "@JavaPassthrough(annotation=\"Bob\")"
2520 "parcelable Foo {}");
2521
2522 CaptureStderr();
2523 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2524 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2525}
2526
Devin Mooredb7ac512020-08-07 11:17:36 -07002527TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2528 const string expected_stderr =
2529 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2530 io_delegate_.SetFileContents("old/p/Foo.aidl",
2531 "package p;"
2532 "parcelable Foo {"
2533 " int A;"
2534 "}");
2535 io_delegate_.SetFileContents("new/p/Foo.aidl",
2536 "package p;"
2537 "@JavaOnlyStableParcelable parcelable Foo {"
2538 " int A;"
2539 "}");
2540 CaptureStderr();
2541 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2542 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2543}
2544
2545TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2546 const string expected_stderr =
2547 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2548 io_delegate_.SetFileContents("old/p/Foo.aidl",
2549 "package p;"
2550 "@JavaOnlyStableParcelable parcelable Foo {"
2551 " int A;"
2552 "}");
2553 io_delegate_.SetFileContents("new/p/Foo.aidl",
2554 "package p;"
2555 "parcelable Foo {"
2556 " int A;"
2557 "}");
2558 CaptureStderr();
2559 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2560 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2561}
2562
Daniel Norman85aed542019-08-21 12:01:14 -07002563TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002564 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002565 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2566 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002567 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002568 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002569 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002570 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002571}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002572
Daniel Norman85aed542019-08-21 12:01:14 -07002573TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002574 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002575 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2576 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002578 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002580}
Jiyong Parka428d212018-08-29 22:26:30 +09002581
Daniel Norman85aed542019-08-21 12:01:14 -07002582TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002583 const string expected_stderr =
2584 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002585 io_delegate_.SetFileContents("old/p/I.aidl",
2586 "package p; interface I {"
2587 "const int A = 1; const int B = 2;}");
2588 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002589 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002590 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002591 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002592}
Jiyong Parka428d212018-08-29 22:26:30 +09002593
Daniel Norman85aed542019-08-21 12:01:14 -07002594TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002595 const string expected_stderr =
2596 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002597 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2598 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002599 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002600 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002601 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002602}
2603
Devin Moorec7e47a32020-08-07 10:55:25 -07002604TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2605 const string expected_stderr =
2606 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2607 "This is an incompatible change for FixedSize types.\n";
2608 io_delegate_.SetFileContents("old/p/Foo.aidl",
2609 "package p; @FixedSize parcelable Foo { int A = 1; }");
2610 io_delegate_.SetFileContents("new/p/Foo.aidl",
2611 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2612 CaptureStderr();
2613 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2614 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2615}
2616
2617TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2618 const string expected_stderr =
2619 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2620 io_delegate_.SetFileContents("old/p/Foo.aidl",
2621 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2622 io_delegate_.SetFileContents("new/p/Foo.aidl",
2623 "package p; @FixedSize parcelable Foo { int A = 1; }");
2624 CaptureStderr();
2625 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2626 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2627}
2628
2629TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2630 const string expected_stderr =
2631 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2632 "a.\n"
2633 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2634 "b.\n"
2635 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2636 "c.\n"
2637 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2638 "d.\n"
2639 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2640 "e.\n"
2641 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2642 "f.\n";
2643
2644 io_delegate_.SetFileContents("Foo.aidl",
2645 "@FixedSize parcelable Foo { "
2646 " int[] a;"
2647 " Bar b;"
2648 " String c;"
2649 " ParcelFileDescriptor d;"
2650 " IBinder e;"
2651 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002652 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002653 "}");
2654 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2655 Options options =
2656 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2657
2658 CaptureStderr();
2659 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2661}
2662
2663TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2664 const string expected_stderr = "";
2665
2666 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2667 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2668 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2669 Options options =
2670 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2671
2672 CaptureStderr();
2673 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2674 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2675}
2676
Jiyong Park8c380532018-08-30 14:55:26 +09002677TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002678 const string expected_stderr =
2679 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2680 "dir1/q/IBar.aidl\n"
2681 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002682 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002683 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2684 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2685 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2686 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2687
Devin Moore097a3ab2020-03-11 16:08:44 -07002688 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002689 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002690 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002691}
2692
Jiyong Parked65bf42018-08-28 15:43:27 +09002693TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002694 const string expected_stderr =
2695 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2696 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002697 Options options = Options::From("aidl --checkapi old new");
2698 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2699 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002700
2701 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2702
Jiyong Parke59c3682018-09-11 23:10:25 +09002703 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002704 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002705 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002706 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002707}
2708
Jiyong Parke05195e2018-10-08 18:24:23 +09002709TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2710 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2711 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002712 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002713
2714 // use without import
2715 io_delegate_.SetFileContents("p/IFoo.aidl",
2716 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2717 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2718 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002719 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002720
Devin Moore7b8d5c92020-03-17 14:14:08 -07002721 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002722 io_delegate_.SetFileContents(
2723 "p/IFoo.aidl",
2724 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2725 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2726 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002727 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002728
2729 // use with import (as before)
2730 io_delegate_.SetFileContents("p/IFoo.aidl",
2731 "package p;"
2732 "import android.os.ParcelFileDescriptor;"
2733 "interface IFoo{"
2734 " void foo(in ParcelFileDescriptor fd);"
2735 "}");
2736 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2737 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002738 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002739}
Jiyong Parked65bf42018-08-28 15:43:27 +09002740
Jiyong Park3633b722019-04-11 15:38:26 +09002741TEST_F(AidlTest, ManualIds) {
2742 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2743 io_delegate_.SetFileContents("IFoo.aidl",
2744 "interface IFoo {\n"
2745 " void foo() = 0;\n"
2746 " void bar() = 1;\n"
2747 "}");
2748 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2749}
2750
2751TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2752 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2753 io_delegate_.SetFileContents("IFoo.aidl",
2754 "interface IFoo {\n"
2755 " void foo() = 0;\n"
2756 " void bar() = 1;\n"
2757 "}");
2758 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2759}
2760
2761TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002762 const string expected_stderr =
2763 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002764 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2765 io_delegate_.SetFileContents("IFoo.aidl",
2766 "interface IFoo {\n"
2767 " void foo() = 3;\n"
2768 " void bar() = 3;\n"
2769 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002770 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002771 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002773}
2774
2775TEST_F(AidlTest, FailOnOutOfRangeIds) {
2776 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002777 const string expected_stderr =
2778 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2779 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002780 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2781 io_delegate_.SetFileContents("IFoo.aidl",
2782 "interface IFoo {\n"
2783 " void foo() = 3;\n"
2784 " void bar() = 16777115;\n"
2785 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002786 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002787 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002788 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002789}
2790
2791TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002792 const string expected_stderr =
2793 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002794 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2795 io_delegate_.SetFileContents("IFoo.aidl",
2796 "interface IFoo {\n"
2797 " void foo() = 3;\n"
2798 " void bar();\n"
2799 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002800 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002801 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002802 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002803}
2804
Jiyong Parkc6816252019-07-08 08:12:28 +09002805TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2806 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2807 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2808 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2809 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2810}
2811
2812TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002813 const string expected_stderr =
2814 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2815 "dir/IBar.aidl\n"
2816 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002817 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002818
Jiyong Parkc6816252019-07-08 08:12:28 +09002819 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2820 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2821 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2822 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002823 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002824 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002825 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002826}
2827
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002828TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2829 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2830 "package a.b;\n"
2831 "import a.b.IBar;\n"
2832 "import a.b.IQux;\n"
2833 "interface IFoo { IQux foo(); }\n");
2834 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2835 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2836
2837 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2838 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2839
2840 string output;
2841 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2842 // IBar was imported but wasn't used. include is not expected.
2843 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2844 // IBar was imported and used. include is expected.
2845 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2846}
2847
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002848TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002849 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002850 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002851 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2852 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002853 interface IFoo {
2854 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002855 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002856 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002857 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002858 // JavaPassthrough should work with other types as well (e.g. enum)
2859 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2860 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2861 @JavaPassthrough(annotation="@com.android.AliceTwo")
2862 @Backing(type="byte")
2863 enum MyEnum {
2864 a, b, c
2865 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002866
Jooyung Han4cde01d2020-10-13 11:10:47 +09002867 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002868 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2869
2870 string java_out;
2871 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002872 // type-decl-level annotations with newline at the end
2873 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2874 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2875 // member-decl-level annotations with newline at the end
2876 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2877 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2878 // inline annotations with space at the end
2879 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002880
Jooyung Han4cde01d2020-10-13 11:10:47 +09002881 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2882 // type-decl-level annotations with newline at the end
2883 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2884 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2885
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002886 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002887 Options cpp_options =
2888 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002889 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2890
Jooyung Han4cde01d2020-10-13 11:10:47 +09002891 Options ndk_options =
2892 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002893 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002894
Jooyung Han4cde01d2020-10-13 11:10:47 +09002895 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002896 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002897}
2898
Andrei Homescue61feb52020-08-18 15:44:24 -07002899TEST_F(AidlTest, ParseRustDerive) {
2900 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2901 @RustDerive(Clone=true, Copy=false)
2902 parcelable Foo {
2903 int a;
2904 })");
2905
2906 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2907 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2908
2909 string rust_out;
2910 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2911 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2912
2913 // Other backends shouldn't be bothered
2914 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2915 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2916
2917 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2918 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2919
2920 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2921 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2922}
2923
Jiyong Park56f73d72019-06-11 12:20:28 +09002924class AidlOutputPathTest : public AidlTest {
2925 protected:
2926 void SetUp() override {
2927 AidlTest::SetUp();
2928 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2929 }
2930
2931 void Test(const Options& options, const std::string expected_output_path) {
2932 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2933 // check the existence
2934 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2935 }
2936};
2937
2938TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2939 // <out_dir> / <package_name> / <type_name>.java
2940 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2941}
2942
2943TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2944 // when output file is explicitly set, it is always respected. -o option is
2945 // ignored.
2946 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2947}
2948
2949TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2950 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2951}
2952
2953TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2954 // output is the same as the input file except for the suffix
2955 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2956}
2957
Devin Moore7b8d5c92020-03-17 14:14:08 -07002958TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002959 AidlError error;
2960 const string expected_stderr =
2961 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2962 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002963 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2964 R"(package p;
2965 interface IFoo {
2966 const int int32_max_oob = 2147483650;
2967 }
2968 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002969 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002970 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2971 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002972}
2973
Devin Moore7b8d5c92020-03-17 14:14:08 -07002974TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002975 AidlError error;
2976 const string expected_stderr =
2977 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2978 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002979 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2980 R"(package p;
2981 interface IFoo {
2982 const int int32_min_oob = -2147483650;
2983 }
2984 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002985 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002986 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2987 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002988}
2989
Devin Moore7b8d5c92020-03-17 14:14:08 -07002990TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002991 AidlError error;
2992 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002993 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002994 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002995 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2996 R"(package p;
2997 interface IFoo {
2998 const long int64_max_oob = 21474836509999999999999999;
2999 }
3000 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003001 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3003 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003004}
3005
Devin Moore7b8d5c92020-03-17 14:14:08 -07003006TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003007 AidlError error;
3008 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003009 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003010 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003011 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3012 R"(package p;
3013 interface IFoo {
3014 const long int64_min_oob = -21474836509999999999999999;
3015 }
3016 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003017 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3019 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003020}
3021
Devin Moore7b8d5c92020-03-17 14:14:08 -07003022TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003023 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003024 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003025 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003026 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3027 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003028 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3029 R"(package p;
3030 @Backing(type="byte")
3031 enum TestEnum {
3032 FOO = 127,
3033 BAR,
3034 }
3035 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003036 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003038 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003039}
3040
Devin Mooredecaf292020-04-30 09:16:40 -07003041TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3042 AidlError error;
3043 const string expected_stderr =
3044 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003045 "be one of: type\n";
3046 CaptureStderr();
3047 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3048 R"(package p;
3049 @Backing(foo="byte")
3050 enum TestEnum {
3051 FOO = 1,
3052 BAR,
3053 }
3054 )",
3055 typenames_, GetLanguage(), &error));
3056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3057 EXPECT_EQ(AidlError::BAD_TYPE, error);
3058}
3059
Jooyung Han5721a232020-12-24 04:34:55 +09003060TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3061 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3062 CaptureStderr();
3063 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3064 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3065}
3066
Jooyung Han66813932020-10-23 13:24:44 +09003067TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003068 io_delegate_.SetFileContents("Foo.aidl",
3069 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3070 "Map<String, Baz> d; Bar[] e; }");
3071 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3072 io_delegate_.SetFileContents("Baz.aidl",
3073 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003074 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3075 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3076}
3077
Jooyung Han66813932020-10-23 13:24:44 +09003078TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003079 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003080 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003081 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003082 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3083 "named 'bar'.\n";
3084 CaptureStderr();
3085 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3086 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3087 EXPECT_EQ(expected_error, GetCapturedStderr());
3088}
3089
3090TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3091 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3092 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3093 string expected_error =
3094 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003095 "named 'bar'.\n";
3096 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003097 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3098 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003099 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003100}
3101
Jooyung Han66813932020-10-23 13:24:44 +09003102TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003103 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003104 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3105 string expected_error =
3106 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3107 "only be an in parameter.\n";
3108 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003109 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3110 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003111 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003112}
3113
Jooyung Han66813932020-10-23 13:24:44 +09003114TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003115 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003116 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3117 string expected_error =
3118 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3119 "only be an in parameter.\n";
3120 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003121 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3122 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003123 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003124}
3125
Jooyung Han66813932020-10-23 13:24:44 +09003126TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003127 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003128 Options options = Options::From("aidl --lang=java Foo.aidl");
3129 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003130 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3131 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003132 CaptureStderr();
3133 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3134 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3135}
Devin Moore53fc99c2020-08-12 08:07:52 -07003136
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3138
3139#include <a/ByteEnum.h>
3140#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003141#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003142#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003143#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003144#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003145#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003146#include <locale>
3147#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003148#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003149#include <utility>
3150#include <variant>
3151#include <vector>
3152
Jooyung Handf39e192020-11-23 15:59:46 +09003153#ifndef __BIONIC__
3154#define __assert2(a,b,c,d) ((void)0)
3155#endif
3156
Jooyung Han1f14ab32020-10-14 13:48:29 +09003157namespace a {
3158
3159class Foo : public ::android::Parcelable {
3160public:
Jooyung Han97945de2020-10-15 16:41:38 +09003161 inline bool operator!=(const Foo& rhs) const {
3162 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003163 }
Jooyung Han97945de2020-10-15 16:41:38 +09003164 inline bool operator<(const Foo& rhs) const {
3165 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003166 }
Jooyung Han97945de2020-10-15 16:41:38 +09003167 inline bool operator<=(const Foo& rhs) const {
3168 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003169 }
Jooyung Han97945de2020-10-15 16:41:38 +09003170 inline bool operator==(const Foo& rhs) const {
3171 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003172 }
Jooyung Han97945de2020-10-15 16:41:38 +09003173 inline bool operator>(const Foo& rhs) const {
3174 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003175 }
Jooyung Han97945de2020-10-15 16:41:38 +09003176 inline bool operator>=(const Foo& rhs) const {
3177 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003178 }
Jooyung Han97945de2020-10-15 16:41:38 +09003179
Jooyung Han1f14ab32020-10-14 13:48:29 +09003180 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003181 ns = 0, // int[] ns;
3182 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003183 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184 };
Jooyung Han97945de2020-10-15 16:41:38 +09003185
Jooyung Han1f14ab32020-10-14 13:48:29 +09003186 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003187 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003188
3189 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003190 Foo(const Foo&) = default;
3191 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003192 Foo& operator=(const Foo&) = default;
3193 Foo& operator=(Foo&&) = default;
3194
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003195 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3196 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003197 constexpr Foo(_Tp&& _arg)
3198 : _value(std::forward<_Tp>(_arg)) {}
3199
3200 template <typename... _Tp>
3201 constexpr explicit Foo(_Tp&&... _args)
3202 : _value(std::forward<_Tp>(_args)...) {}
3203
3204 template <Tag _tag, typename... _Tp>
3205 static Foo make(_Tp&&... _args) {
3206 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003207 }
Jooyung Han97945de2020-10-15 16:41:38 +09003208
3209 template <Tag _tag, typename _Tp, typename... _Up>
3210 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3211 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003212 }
3213
3214 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003215 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003216 }
3217
Jooyung Han97945de2020-10-15 16:41:38 +09003218 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003219 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003220 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003221 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003222 }
3223
Jooyung Han97945de2020-10-15 16:41:38 +09003224 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003225 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003226 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003227 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003228 }
3229
Jooyung Han97945de2020-10-15 16:41:38 +09003230 template <Tag _tag, typename... _Tp>
3231 void set(_Tp&&... _args) {
3232 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003233 }
3234
3235 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3236 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3237 static const std::string& getParcelableDescriptor() {
3238 static const std::string DESCIPTOR = "a.Foo";
3239 return DESCIPTOR;
3240 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003241 template <typename _T> class _has_toString {
3242 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3243 template <typename _U> static std::false_type __has_toString(...);
3244 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3245 };
3246 template <typename _T> inline static std::string _call_toString(const _T& t) {
3247 if constexpr (_has_toString<_T>::value) return t.toString();
3248 return "{no toString() implemented}";
3249 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003250 inline std::string toString() const {
3251 std::ostringstream os;
3252 os << "Foo{";
3253 switch (getTag()) {
3254 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3255 case e: os << "e: " << a::toString(get<e>()); break;
3256 case pfd: os << "pfd: " << ""; break;
3257 }
3258 os << "}";
3259 return os.str();
3260 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003261private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003262 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003263}; // class Foo
3264
3265} // namespace a
3266)";
3267
3268const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3269
3270namespace a {
3271
3272::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3273 ::android::status_t _aidl_ret_status;
3274 int32_t _aidl_tag;
3275 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3276 switch (_aidl_tag) {
3277 case ns: {
3278 ::std::vector<int32_t> _aidl_value;
3279 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003280 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3281 set<ns>(_aidl_value);
3282 } else {
3283 // NOLINTNEXTLINE(performance-move-const-arg)
3284 set<ns>(std::move(_aidl_value));
3285 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003286 return ::android::OK; }
3287 case e: {
3288 ::a::ByteEnum _aidl_value;
3289 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003290 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3291 set<e>(_aidl_value);
3292 } else {
3293 // NOLINTNEXTLINE(performance-move-const-arg)
3294 set<e>(std::move(_aidl_value));
3295 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003296 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003297 case pfd: {
3298 ::android::os::ParcelFileDescriptor _aidl_value;
3299 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003300 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3301 set<pfd>(_aidl_value);
3302 } else {
3303 // NOLINTNEXTLINE(performance-move-const-arg)
3304 set<pfd>(std::move(_aidl_value));
3305 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003306 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003307 }
3308 return ::android::BAD_VALUE;
3309}
3310
3311::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3312 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3313 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3314 switch (getTag()) {
3315 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3316 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003317 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003318 }
Jooyung Handf39e192020-11-23 15:59:46 +09003319 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003320}
3321
3322} // namespace a
3323)";
3324
Jooyung Han6beac042020-10-17 21:59:43 +09003325const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3326#include <android/binder_interface_utils.h>
3327#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003328#include <codecvt>
3329#include <locale>
3330#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003331
Jooyung Handf39e192020-11-23 15:59:46 +09003332#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003333#include <type_traits>
3334#include <utility>
3335#include <variant>
3336#include <cstdint>
3337#include <memory>
3338#include <optional>
3339#include <string>
3340#include <vector>
3341#ifdef BINDER_STABILITY_SUPPORT
3342#include <android/binder_stability.h>
3343#endif // BINDER_STABILITY_SUPPORT
3344#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003345
3346#ifndef __BIONIC__
3347#define __assert2(a,b,c,d) ((void)0)
3348#endif
3349
Jooyung Han6beac042020-10-17 21:59:43 +09003350namespace aidl {
3351namespace a {
3352class Foo {
3353public:
3354 typedef std::false_type fixed_size;
3355 static const char* descriptor;
3356
3357 enum Tag : int32_t {
3358 ns = 0, // int[] ns;
3359 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003360 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003361 };
3362
3363 template<typename _Tp>
3364 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3365
3366 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3367 Foo(const Foo&) = default;
3368 Foo(Foo&&) = default;
3369 Foo& operator=(const Foo&) = default;
3370 Foo& operator=(Foo&&) = default;
3371
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003372 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3373 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003374 constexpr Foo(_Tp&& _arg)
3375 : _value(std::forward<_Tp>(_arg)) {}
3376
3377 template <typename... _Tp>
3378 constexpr explicit Foo(_Tp&&... _args)
3379 : _value(std::forward<_Tp>(_args)...) {}
3380
3381 template <Tag _tag, typename... _Tp>
3382 static Foo make(_Tp&&... _args) {
3383 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3384 }
3385
3386 template <Tag _tag, typename _Tp, typename... _Up>
3387 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3388 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3389 }
3390
3391 Tag getTag() const {
3392 return static_cast<Tag>(_value.index());
3393 }
3394
3395 template <Tag _tag>
3396 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003397 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003398 return std::get<_tag>(_value);
3399 }
3400
3401 template <Tag _tag>
3402 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003403 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003404 return std::get<_tag>(_value);
3405 }
3406
3407 template <Tag _tag, typename... _Tp>
3408 void set(_Tp&&... _args) {
3409 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3410 }
3411
3412 binder_status_t readFromParcel(const AParcel* _parcel);
3413 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003414
3415 inline bool operator!=(const Foo& rhs) const {
3416 return _value != rhs._value;
3417 }
3418 inline bool operator<(const Foo& rhs) const {
3419 return _value < rhs._value;
3420 }
3421 inline bool operator<=(const Foo& rhs) const {
3422 return _value <= rhs._value;
3423 }
3424 inline bool operator==(const Foo& rhs) const {
3425 return _value == rhs._value;
3426 }
3427 inline bool operator>(const Foo& rhs) const {
3428 return _value > rhs._value;
3429 }
3430 inline bool operator>=(const Foo& rhs) const {
3431 return _value >= rhs._value;
3432 }
3433
Jooyung Han6beac042020-10-17 21:59:43 +09003434 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003435 template <typename _T> class _has_toString {
3436 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3437 template <typename _U> static std::false_type __has_toString(...);
3438 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3439 };
3440 template <typename _T> inline static std::string _call_toString(const _T& t) {
3441 if constexpr (_has_toString<_T>::value) return t.toString();
3442 return "{no toString() implemented}";
3443 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003444 inline std::string toString() const {
3445 std::ostringstream os;
3446 os << "Foo{";
3447 switch (getTag()) {
3448 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3449 case e: os << "e: " << a::toString(get<e>()); break;
3450 case pfd: os << "pfd: " << ""; break;
3451 }
3452 os << "}";
3453 return os.str();
3454 }
Jooyung Han6beac042020-10-17 21:59:43 +09003455private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003456 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003457};
3458} // namespace a
3459} // namespace aidl
3460)";
3461
3462const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3463
3464#include <android/binder_parcel_utils.h>
3465
3466namespace aidl {
3467namespace a {
3468const char* Foo::descriptor = "a.Foo";
3469
3470binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3471 binder_status_t _aidl_ret_status;
3472 int32_t _aidl_tag;
3473 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3474 switch (_aidl_tag) {
3475 case ns: {
3476 std::vector<int32_t> _aidl_value;
3477 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003478 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3479 set<ns>(_aidl_value);
3480 } else {
3481 // NOLINTNEXTLINE(performance-move-const-arg)
3482 set<ns>(std::move(_aidl_value));
3483 }
Jooyung Han6beac042020-10-17 21:59:43 +09003484 return STATUS_OK; }
3485 case e: {
3486 ::aidl::a::ByteEnum _aidl_value;
3487 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003488 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3489 set<e>(_aidl_value);
3490 } else {
3491 // NOLINTNEXTLINE(performance-move-const-arg)
3492 set<e>(std::move(_aidl_value));
3493 }
Jooyung Han6beac042020-10-17 21:59:43 +09003494 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003495 case pfd: {
3496 ::ndk::ScopedFileDescriptor _aidl_value;
3497 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003498 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3499 set<pfd>(_aidl_value);
3500 } else {
3501 // NOLINTNEXTLINE(performance-move-const-arg)
3502 set<pfd>(std::move(_aidl_value));
3503 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003504 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003505 }
3506 return STATUS_BAD_VALUE;
3507}
3508binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3509 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3510 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3511 switch (getTag()) {
3512 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3513 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003514 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003515 }
Jooyung Handf39e192020-11-23 15:59:46 +09003516 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003517}
3518
3519} // namespace a
3520} // namespace aidl
3521)";
3522
Jooyung Han1f14ab32020-10-14 13:48:29 +09003523const char kUnionExampleExpectedOutputJava[] = R"(/*
3524 * This file is auto-generated. DO NOT MODIFY.
3525 */
3526package a;
3527
3528
3529public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003530 // tags for union fields
3531 public final static int ns = 0; // int[] ns;
3532 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003533 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003534
3535 private int _tag;
3536 private Object _value;
3537
3538 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003539 int[] _value = {42};
3540 this._tag = ns;
3541 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003542 }
Jooyung Han97945de2020-10-15 16:41:38 +09003543
Jooyung Han1f14ab32020-10-14 13:48:29 +09003544 private Foo(android.os.Parcel _aidl_parcel) {
3545 readFromParcel(_aidl_parcel);
3546 }
Jooyung Han97945de2020-10-15 16:41:38 +09003547
Jooyung Hance62f932020-10-25 10:21:49 +09003548 private Foo(int _tag, Object _value) {
3549 this._tag = _tag;
3550 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003551 }
3552
3553 public int getTag() {
3554 return _tag;
3555 }
3556
Jooyung Han97945de2020-10-15 16:41:38 +09003557 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003558
3559 public static Foo ns(int[] _value) {
3560 return new Foo(ns, _value);
3561 }
Jooyung Han97945de2020-10-15 16:41:38 +09003562
Jooyung Han1f14ab32020-10-14 13:48:29 +09003563 public int[] getNs() {
3564 _assertTag(ns);
3565 return (int[]) _value;
3566 }
Jooyung Han97945de2020-10-15 16:41:38 +09003567
Jooyung Han1f14ab32020-10-14 13:48:29 +09003568 public void setNs(int[] _value) {
3569 _set(ns, _value);
3570 }
3571
Jooyung Han97945de2020-10-15 16:41:38 +09003572 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003573
3574 public static Foo e(byte _value) {
3575 return new Foo(e, _value);
3576 }
Jooyung Han97945de2020-10-15 16:41:38 +09003577
Jooyung Han1f14ab32020-10-14 13:48:29 +09003578 public byte getE() {
3579 _assertTag(e);
3580 return (byte) _value;
3581 }
Jooyung Han97945de2020-10-15 16:41:38 +09003582
Jooyung Han1f14ab32020-10-14 13:48:29 +09003583 public void setE(byte _value) {
3584 _set(e, _value);
3585 }
3586
Jooyung Hand2fa0232020-10-19 02:51:41 +09003587 // ParcelFileDescriptor pfd;
3588
3589 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3590 return new Foo(pfd, _value);
3591 }
3592
3593 public android.os.ParcelFileDescriptor getPfd() {
3594 _assertTag(pfd);
3595 return (android.os.ParcelFileDescriptor) _value;
3596 }
3597
3598 public void setPfd(android.os.ParcelFileDescriptor _value) {
3599 _set(pfd, _value);
3600 }
3601
Jooyung Han1f14ab32020-10-14 13:48:29 +09003602 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3603 @Override
3604 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003605 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003606 }
3607 @Override
3608 public Foo[] newArray(int _aidl_size) {
3609 return new Foo[_aidl_size];
3610 }
3611 };
Jooyung Han97945de2020-10-15 16:41:38 +09003612
Jooyung Han1f14ab32020-10-14 13:48:29 +09003613 @Override
3614 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3615 _aidl_parcel.writeInt(_tag);
3616 switch (_tag) {
3617 case ns:
3618 _aidl_parcel.writeIntArray(getNs());
3619 break;
3620 case e:
3621 _aidl_parcel.writeByte(getE());
3622 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003623 case pfd:
3624 if ((getPfd()!=null)) {
3625 _aidl_parcel.writeInt(1);
3626 getPfd().writeToParcel(_aidl_parcel, 0);
3627 }
3628 else {
3629 _aidl_parcel.writeInt(0);
3630 }
3631 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003632 }
3633 }
Jooyung Han97945de2020-10-15 16:41:38 +09003634
Jooyung Han1f14ab32020-10-14 13:48:29 +09003635 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3636 int _aidl_tag;
3637 _aidl_tag = _aidl_parcel.readInt();
3638 switch (_aidl_tag) {
3639 case ns: {
3640 int[] _aidl_value;
3641 _aidl_value = _aidl_parcel.createIntArray();
3642 _set(_aidl_tag, _aidl_value);
3643 return; }
3644 case e: {
3645 byte _aidl_value;
3646 _aidl_value = _aidl_parcel.readByte();
3647 _set(_aidl_tag, _aidl_value);
3648 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003649 case pfd: {
3650 android.os.ParcelFileDescriptor _aidl_value;
3651 if ((0!=_aidl_parcel.readInt())) {
3652 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3653 }
3654 else {
3655 _aidl_value = null;
3656 }
3657 _set(_aidl_tag, _aidl_value);
3658 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003659 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003660 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003661 }
Jooyung Han97945de2020-10-15 16:41:38 +09003662
Jooyung Han1f14ab32020-10-14 13:48:29 +09003663 @Override
3664 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003665 int _mask = 0;
3666 switch (getTag()) {
3667 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003668 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003669 break;
3670 }
3671 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003672 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003673 private int describeContents(Object _v) {
3674 if (_v == null) return 0;
3675 if (_v instanceof android.os.Parcelable) {
3676 return ((android.os.Parcelable) _v).describeContents();
3677 }
3678 return 0;
3679 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003680
3681 private void _assertTag(int tag) {
3682 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003683 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003684 }
3685 }
Jooyung Han97945de2020-10-15 16:41:38 +09003686
Jooyung Han1f14ab32020-10-14 13:48:29 +09003687 private String _tagString(int _tag) {
3688 switch (_tag) {
3689 case ns: return "ns";
3690 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003691 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003692 }
3693 throw new IllegalStateException("unknown field: " + _tag);
3694 }
Jooyung Han97945de2020-10-15 16:41:38 +09003695
Jooyung Hance62f932020-10-25 10:21:49 +09003696 private void _set(int _tag, Object _value) {
3697 this._tag = _tag;
3698 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003699 }
3700}
3701)";
3702
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003703const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3704pub enum Foo {
3705 Ns(Vec<i32>),
3706 E(crate::mangled::_1_a_8_ByteEnum),
3707 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3708}
3709pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3710impl Default for Foo {
3711 fn default() -> Self {
3712 Self::Ns(vec!{42})
3713 }
3714}
3715impl binder::parcel::Serialize for Foo {
3716 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3717 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3718 }
3719}
3720impl binder::parcel::SerializeArray for Foo {}
3721impl binder::parcel::SerializeOption for Foo {
3722 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3723 let this = if let Some(this) = this {
3724 parcel.write(&1i32)?;
3725 this
3726 } else {
3727 return parcel.write(&0i32);
3728 };
3729 match this {
3730 Self::Ns(v) => {
3731 parcel.write(&0i32)?;
3732 parcel.write(v)
3733 }
3734 Self::E(v) => {
3735 parcel.write(&1i32)?;
3736 parcel.write(v)
3737 }
3738 Self::Pfd(v) => {
3739 parcel.write(&2i32)?;
3740 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3741 parcel.write(__field_ref)
3742 }
3743 }
3744 }
3745}
3746impl binder::parcel::Deserialize for Foo {
3747 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3748 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3749 .transpose()
3750 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3751 }
3752}
3753impl binder::parcel::DeserializeArray for Foo {}
3754impl binder::parcel::DeserializeOption for Foo {
3755 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3756 let status: i32 = parcel.read()?;
3757 if status == 0 { return Ok(None); }
3758 let tag: i32 = parcel.read()?;
3759 match tag {
3760 0 => {
3761 let value: Vec<i32> = parcel.read()?;
3762 Ok(Some(Self::Ns(value)))
3763 }
3764 1 => {
3765 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3766 Ok(Some(Self::E(value)))
3767 }
3768 2 => {
3769 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3770 Ok(Some(Self::Pfd(value)))
3771 }
3772 _ => {
3773 Err(binder::StatusCode::BAD_VALUE)
3774 }
3775 }
3776 }
3777}
3778)";
3779
Jooyung Han97945de2020-10-15 16:41:38 +09003780struct AidlUnionTest : ::testing::Test {
3781 void SetUp() override {
3782 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003783package a;
3784import a.ByteEnum;
3785union Foo {
3786 int[] ns = {42};
3787 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003788 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003789}
3790)");
Jooyung Han97945de2020-10-15 16:41:38 +09003791 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003792package a;
3793@Backing(type="byte")
3794enum ByteEnum {
3795 a, b, c
3796}
3797)");
Jooyung Han97945de2020-10-15 16:41:38 +09003798 }
3799 FakeIoDelegate io_delegate_;
3800 void Compile(string lang) {
3801 string command = "aidl --structured -I. -o out --lang=" + lang;
3802 if (lang == "cpp" || lang == "ndk") {
3803 command += " -h out";
3804 }
3805 command += " a/Foo.aidl";
3806 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003807 CaptureStderr();
3808 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3809 auto err = GetCapturedStderr();
3810 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003811 }
3812 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3813 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003814 string actual;
3815 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3816 EXPECT_EQ(expected, actual);
3817 }
Jooyung Han97945de2020-10-15 16:41:38 +09003818 }
3819};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003820
Jooyung Han97945de2020-10-15 16:41:38 +09003821TEST_F(AidlUnionTest, Example_Cpp) {
3822 Compile("cpp");
3823 EXPECT_COMPILE_OUTPUTS(
3824 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3825 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3826}
3827
Jooyung Han6beac042020-10-17 21:59:43 +09003828TEST_F(AidlUnionTest, Example_Ndk) {
3829 Compile("ndk");
3830 EXPECT_COMPILE_OUTPUTS(
3831 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3832 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3833}
3834
Jooyung Han97945de2020-10-15 16:41:38 +09003835TEST_F(AidlUnionTest, Example_Java) {
3836 Compile("java");
3837 EXPECT_COMPILE_OUTPUTS(
3838 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003839}
3840
3841TEST_F(AidlUnionTest, Example_Rust) {
3842 Compile("rust");
3843 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003844}
3845
Jooyung Hanfe89f122020-10-14 03:49:18 +09003846TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3847 const string method = "package a; union Foo {}";
3848 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3849 CaptureStderr();
3850 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3851 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3852}
3853
3854TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3855 const string method = "package a; union Foo { ParcelableHolder x; }";
3856 const string expected_stderr =
3857 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3858 CaptureStderr();
3859 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3860 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3861}
3862
Jooyung Han53fb4242020-12-17 16:03:49 +09003863TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3864 import_paths_.insert(".");
3865 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3866 const string expected_err = "The union's first member should have a useful default value.";
3867 CaptureStderr();
3868 EXPECT_EQ(nullptr,
3869 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3870 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3871}
3872
Devin Moore53fc99c2020-08-12 08:07:52 -07003873TEST_P(AidlTest, GenericStructuredParcelable) {
3874 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3875 Options options =
3876 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3877 const string expected_stderr = "";
3878 CaptureStderr();
3879 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3880 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3881}
3882
Jooyung Han3f347ca2020-12-01 12:41:50 +09003883TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3884 io_delegate_.SetFileContents("Foo.aidl",
3885 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3886 Options options =
3887 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3888 " -o out -h out");
3889 const string expected_stderr = "";
3890 CaptureStderr();
3891 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3892 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3893
3894 string code;
3895 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3896 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3897const ::android::String16& Foo<T,U>::s() {
3898 static const ::android::String16 value(::android::String16(""));
3899 return value;
3900})--"));
3901}
3902
3903TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3904 io_delegate_.SetFileContents("Foo.aidl",
3905 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3906 Options options =
3907 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3908 " -o out -h out");
3909 const string expected_stderr = "";
3910 CaptureStderr();
3911 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3913
3914 string code;
3915 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3916 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3917const char* Foo<T, U>::s = "";
3918)--"));
3919}
3920
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003921TEST_F(AidlTest, NestedTypeArgs) {
3922 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003923 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3924
3925 io_delegate_.SetFileContents("a/Foo.aidl",
3926 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3927 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003928 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3929 const string expected_stderr = "";
3930 CaptureStderr();
3931 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3932 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3933
3934 string code;
3935 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003936 EXPECT_THAT(code,
3937 testing::HasSubstr(
3938 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3939}
3940
3941TEST_F(AidlTest, DoubleArrayError) {
3942 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3943
3944 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3945 const string expected_stderr =
3946 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3947 CaptureStderr();
3948 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3949 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3950}
3951
3952TEST_F(AidlTest, DoubleGenericError) {
3953 io_delegate_.SetFileContents("a/Bar.aidl",
3954 "package a; parcelable Bar { List<String><String> a; }");
3955
3956 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3957 const string expected_stderr =
3958 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3959 CaptureStderr();
3960 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3961 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3962}
3963
3964TEST_F(AidlTest, ArrayBeforeGenericError) {
3965 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3966
3967 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3968 const string expected_stderr =
3969 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3970 CaptureStderr();
3971 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3972 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003973}
3974
Jooyung Han14004ed2020-10-16 03:49:57 +09003975struct GenericAidlTest : ::testing::Test {
3976 FakeIoDelegate io_delegate_;
3977 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003978 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003979 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3980 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3981 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3982
3983 Options options = Options::From(cmd);
3984 CaptureStderr();
3985 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3986 EXPECT_EQ("", GetCapturedStderr());
3987 }
3988};
3989
3990TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3991 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3992 string code;
3993 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3994 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3995 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3996 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3997}
3998
3999TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4000 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4001 string code;
4002 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4003 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4004 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4005 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4006}
4007
Devin Moore53fc99c2020-08-12 08:07:52 -07004008TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4009 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
4010 Options options =
4011 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4012 const string expected_stderr =
4013 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4014 CaptureStderr();
4015 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4017}
4018
4019TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4020 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
4021 Options options =
4022 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4023 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4024 CaptureStderr();
4025 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4026 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4027}
4028
Jooyung Han7a308842020-10-27 19:06:49 +09004029TEST_P(AidlTest, LongCommentWithinConstExpression) {
4030 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
4031 Options options =
4032 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4033 CaptureStderr();
4034 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4035 EXPECT_EQ("", GetCapturedStderr());
4036}
4037
Jeongik Chaef44e622020-10-23 16:00:52 +09004038TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4039 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4040 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4041 std::string expectedErr =
4042 "ERROR: a/Foo.aidl:1.28-30: "
4043 "Encountered an untyped List or Map. The use of untyped List/Map is "
4044 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4045 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4046 "ERROR: a/Foo.aidl:1.35-37: "
4047 "Encountered an untyped List or Map. The use of untyped List/Map is "
4048 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4049 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4050 CaptureStderr();
4051 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4052 EXPECT_EQ(expectedErr, GetCapturedStderr());
4053}
4054
4055TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004056 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4057 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004058 std::string expectedErr =
4059 "ERROR: a/Foo.aidl:1.33-35: "
4060 "Encountered an untyped List or Map. The use of untyped List/Map is "
4061 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4062 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4063 "ERROR: a/Foo.aidl:1.40-42: "
4064 "Encountered an untyped List or Map. The use of untyped List/Map is "
4065 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4066 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004067 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004068 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4069 EXPECT_EQ(expectedErr, GetCapturedStderr());
4070}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004071
Jeongik Chaef44e622020-10-23 16:00:52 +09004072TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4073 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4074 io_delegate_.SetFileContents(
4075 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4076 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4077 std::string expectedErr =
4078 "ERROR: a/Foo.aidl:1.52-54: "
4079 "Encountered an untyped List or Map. The use of untyped List/Map is "
4080 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4081 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4082 "ERROR: a/Foo.aidl:1.64-66: "
4083 "Encountered an untyped List or Map. The use of untyped List/Map is "
4084 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4085 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4086 CaptureStderr();
4087 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4088 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004089}
4090
Jooyung Han690f5842020-12-04 13:02:04 +09004091TEST_F(AidlTest, EnumWithDefaults_Java) {
4092 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4093 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4094package p;
4095import p.Enum;
4096parcelable Foo {
4097 Enum e = Enum.BAR;
4098})");
4099 CaptureStderr();
4100 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4101 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4102 auto err = GetCapturedStderr();
4103 EXPECT_EQ("", err);
4104
4105 string code;
4106 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004107 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004108}
4109
4110TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4111 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4112 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4113package p;
4114import p.Enum;
4115parcelable Foo {
4116 Enum e = Enum.BAR;
4117})");
4118 CaptureStderr();
4119 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4120 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4121 auto err = GetCapturedStderr();
4122 EXPECT_EQ("", err);
4123
4124 string code;
4125 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4126 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4127}
4128
4129TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4130 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4131 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4132package p;
4133import p.Enum;
4134parcelable Foo {
4135 Enum e = Enum.BAR;
4136})");
4137 CaptureStderr();
4138 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4139 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4140 auto err = GetCapturedStderr();
4141 EXPECT_EQ("", err);
4142
4143 string code;
4144 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4145 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4146}
4147
4148TEST_F(AidlTest, EnumWithDefaults_Rust) {
4149 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4150 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4151package p;
4152import p.Enum;
4153parcelable Foo {
4154 int n = 42;
4155 Enum e = Enum.BAR;
4156})");
4157 CaptureStderr();
4158 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4159 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4160 auto err = GetCapturedStderr();
4161 EXPECT_EQ("", err);
4162
4163 string code;
4164 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4165 EXPECT_THAT(code, testing::HasSubstr(R"(
4166 fn default() -> Self {
4167 Self {
4168 n: 42,
4169 e: crate::mangled::_1_p_4_Enum::BAR,
4170 }
4171 })"));
4172}
4173
4174TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4175 import_paths_.insert("a");
4176 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4177 CaptureStderr();
4178 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4179package p;
4180import p.Enum;
4181parcelable Foo {
4182 int e = Enum.FOO | Enum.BAR;
4183})",
4184 typenames_, GetLanguage());
4185 auto err = GetCapturedStderr();
4186 EXPECT_EQ("", err);
4187 EXPECT_TRUE(type);
4188 const auto& fields = type->AsStructuredParcelable()->GetFields();
4189 EXPECT_EQ("int e = 3", fields[0]->ToString());
4190}
4191
4192TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4193 CaptureStderr();
4194 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4195@Backing(type="int")
4196enum Foo {
4197 STANDARD_SHIFT = 16,
4198 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4199 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4200}
4201)",
4202 typenames_, GetLanguage());
4203 auto err = GetCapturedStderr();
4204 EXPECT_EQ("", err);
4205 EXPECT_TRUE(type);
4206 const auto& enum_type = type->AsEnumDeclaration();
4207 string code;
4208 enum_type->Dump(CodeWriter::ForString(&code).get());
4209 EXPECT_EQ(R"--(@Backing(type="int")
4210enum Foo {
4211 STANDARD_SHIFT = 16,
4212 STANDARD_BT709 = 65536,
4213 STANDARD_BT601_625 = 131072,
4214}
4215)--",
4216 code);
4217}
4218
4219TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4220 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4221 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4222package p;
4223import p.Enum;
4224parcelable Foo {
4225 Enum e = Enum.FOO | Enum.BAR;
4226})");
4227 CaptureStderr();
4228 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4229 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4230 auto err = GetCapturedStderr();
4231 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4232 err);
4233}
4234
4235TEST_P(AidlTest, DefaultWithEmptyArray) {
4236 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4237 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4238 CaptureStderr();
4239 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4240 " -o out -h out a/p/Foo.aidl");
4241 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4242 auto err = GetCapturedStderr();
4243 EXPECT_EQ("", err);
4244}
4245
4246TEST_P(AidlTest, RejectRefsInAnnotation) {
4247 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4248 "package p; interface IFoo {\n"
4249 " const String ANNOTATION = \"@Annotation\";\n"
4250 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4251 "}");
4252 CaptureStderr();
4253 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4254 " -o out -h out a/p/IFoo.aidl");
4255 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4256 auto err = GetCapturedStderr();
4257 EXPECT_EQ(
4258 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4259 "ANNOTATION.\n",
4260 err);
4261}
4262
4263TEST_F(AidlTest, DefaultWithEnumValues) {
4264 io_delegate_.SetFileContents(
4265 "a/p/Foo.aidl",
4266 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4267 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4268 CaptureStderr();
4269 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4270 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4271 auto err = GetCapturedStderr();
4272 EXPECT_EQ("", err);
4273 string code;
4274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4275 EXPECT_THAT(
4276 code, testing::HasSubstr(
4277 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4278}
4279
Jooyung Han14259392020-12-07 10:00:08 +09004280TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4281 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4282 CaptureStderr();
4283 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4284 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4285 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004286 EXPECT_EQ(
4287 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4288 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4289 err);
Jooyung Han14259392020-12-07 10:00:08 +09004290}
4291
4292TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4293 io_delegate_.SetFileContents("a/p/Foo.aidl",
4294 "package p; parcelable Foo { const int A = A + 1; }");
4295 CaptureStderr();
4296 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4297 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4298 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004299 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4300}
4301
4302TEST_F(AidlTest, RecursiveReferences) {
4303 io_delegate_.SetFileContents("a/p/Foo.aidl",
4304 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4305 io_delegate_.SetFileContents("a/p/Bar.aidl",
4306 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4307 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4308 CaptureStderr();
4309 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4310 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4311 EXPECT_EQ("", GetCapturedStderr());
4312}
4313
4314TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4315 string contents = R"(
4316import android.os.IBinder;
4317import android.os.IInterface;
4318interface IFoo {}
4319 )";
4320 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004321}
4322
Jooyung Han888c5bc2020-12-22 17:28:47 +09004323TEST_P(AidlTest, WarningInterfaceName) {
4324 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4325 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4326 " -Weverything -o out -h out p/Foo.aidl");
4327 CaptureStderr();
4328 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004329 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004330 GetCapturedStderr());
4331}
4332
4333TEST_P(AidlTest, ErrorInterfaceName) {
4334 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4335 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4336 " -Weverything -Werror -o out -h out p/Foo.aidl");
4337 CaptureStderr();
4338 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004339 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004340 GetCapturedStderr());
4341}
4342
Jooyung Hanfd3be322020-12-13 09:11:06 +09004343struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004344 string kind;
4345 string literal;
4346};
4347
Jooyung Hanfd3be322020-12-13 09:11:06 +09004348const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004349 {"primitive", "int"}, {"String", "String"},
4350 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4351 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4352 {"union", "a.Union"}, {"interface", "a.IBar"},
4353};
4354
4355const std::map<std::string, std::string> kListSupportExpectations = {
4356 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4357 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4358 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4359 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4360 {"cpp_String", ""},
4361 {"java_String", ""},
4362 {"ndk_String", ""},
4363 {"rust_String", ""},
4364 {"cpp_IBinder", ""},
4365 {"java_IBinder", ""},
4366 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4367 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004368 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004369 {"java_ParcelFileDescriptor", ""},
4370 {"ndk_ParcelFileDescriptor", ""},
4371 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004372 {"cpp_interface", "List<a.IBar> is not supported."},
4373 {"java_interface", "List<a.IBar> is not supported."},
4374 {"ndk_interface", "List<a.IBar> is not supported."},
4375 {"rust_interface", "List<a.IBar> is not supported."},
4376 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004377 {"java_parcelable", ""},
4378 {"ndk_parcelable", ""},
4379 {"rust_parcelable", ""},
4380 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4381 {"java_enum", "A generic type cannot have any primitive type parameters."},
4382 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4383 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004384 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004385 {"java_union", ""},
4386 {"ndk_union", ""},
4387 {"rust_union", ""},
4388};
4389
Jooyung Hand236e552020-12-13 09:21:27 +09004390const std::map<std::string, std::string> kArraySupportExpectations = {
4391 {"cpp_primitive", ""},
4392 {"java_primitive", ""},
4393 {"ndk_primitive", ""},
4394 {"rust_primitive", ""},
4395 {"cpp_String", ""},
4396 {"java_String", ""},
4397 {"ndk_String", ""},
4398 {"rust_String", ""},
4399 {"cpp_IBinder", ""},
4400 {"java_IBinder", ""},
4401 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4402 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4403 {"cpp_ParcelFileDescriptor", ""},
4404 {"java_ParcelFileDescriptor", ""},
4405 {"ndk_ParcelFileDescriptor", ""},
4406 {"rust_ParcelFileDescriptor", ""},
4407 {"cpp_interface", "Binder type cannot be an array"},
4408 {"java_interface", "Binder type cannot be an array"},
4409 {"ndk_interface", "Binder type cannot be an array"},
4410 {"rust_interface", "Binder type cannot be an array"},
4411 {"cpp_parcelable", ""},
4412 {"java_parcelable", ""},
4413 {"ndk_parcelable", ""},
4414 {"rust_parcelable", ""},
4415 {"cpp_enum", ""},
4416 {"java_enum", ""},
4417 {"ndk_enum", ""},
4418 {"rust_enum", ""},
4419 {"cpp_union", ""},
4420 {"java_union", ""},
4421 {"ndk_union", ""},
4422 {"rust_union", ""},
4423};
4424
Jooyung Hanfd3be322020-12-13 09:11:06 +09004425class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004426 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004427 void Run(const std::string& generic_type_decl,
4428 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004429 const auto& param = GetParam();
4430 const auto& lang = Options::LanguageToString(std::get<0>(param));
4431 const auto& kind = std::get<1>(param).kind;
4432
4433 FakeIoDelegate io;
4434 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4435 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4436 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004437 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4438 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004439
4440 const auto options =
4441 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4442 CaptureStderr();
4443 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004444 auto it = expectations.find(lang + "_" + kind);
4445 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004446 const string err = GetCapturedStderr();
4447 if (it->second.empty()) {
4448 EXPECT_EQ("", err);
4449 } else {
4450 EXPECT_THAT(err, testing::HasSubstr(it->second));
4451 }
4452 }
4453};
4454
4455INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004456 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004457 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4458 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004459 testing::ValuesIn(kTypeParams)),
4460 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004461 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4462 std::get<1>(info.param).kind;
4463 });
4464
Jooyung Hanfd3be322020-12-13 09:11:06 +09004465TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4466 Run("List<{}>", kListSupportExpectations);
4467}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004468
Jooyung Hand236e552020-12-13 09:21:27 +09004469TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4470 Run("{}[]", kArraySupportExpectations);
4471}
4472
Christopher Wiley90be4e32015-10-20 14:55:25 -07004473} // namespace aidl
4474} // namespace android