blob: f985575c62a72048a0b0fc0908bc3872876e9696 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Jooyung Hand2fa0232020-10-19 02:51:41 +090081const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 R"(/*
83 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080085@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090086public class Rect implements android.os.Parcelable
87{
88 // Comment
89
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080090 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090091 public int x = 5;
92
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080093 @android.annotation.Hide
94 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000095 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090096
97 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090098
99 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900100 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
101 @Override
102 public Rect createFromParcel(android.os.Parcel _aidl_source) {
103 Rect _aidl_out = new Rect();
104 _aidl_out.readFromParcel(_aidl_source);
105 return _aidl_out;
106 }
107 @Override
108 public Rect[] newArray(int _aidl_size) {
109 return new Rect[_aidl_size];
110 }
111 };
112 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
113 {
114 int _aidl_start_pos = _aidl_parcel.dataPosition();
115 _aidl_parcel.writeInt(0);
116 _aidl_parcel.writeInt(x);
117 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900118 if ((fd!=null)) {
119 _aidl_parcel.writeInt(1);
120 fd.writeToParcel(_aidl_parcel, 0);
121 }
122 else {
123 _aidl_parcel.writeInt(0);
124 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900125 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900126 int _aidl_end_pos = _aidl_parcel.dataPosition();
127 _aidl_parcel.setDataPosition(_aidl_start_pos);
128 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
129 _aidl_parcel.setDataPosition(_aidl_end_pos);
130 }
131 public final void readFromParcel(android.os.Parcel _aidl_parcel)
132 {
133 int _aidl_start_pos = _aidl_parcel.dataPosition();
134 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900136 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900137 x = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
139 y = _aidl_parcel.readInt();
140 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900141 if ((0!=_aidl_parcel.readInt())) {
142 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
143 }
144 else {
145 fd = null;
146 }
147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900148 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900149 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900150 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900151 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
152 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
153 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900154 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
155 }
156 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900157 @Override
158 public int describeContents() {
159 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900160 _mask |= describeContents(fd);
161 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900162 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900163 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900164 private int describeContents(Object _v) {
165 if (_v == null) return 0;
166 if (_v instanceof java.util.Collection) {
167 int _mask = 0;
168 for (Object o : (java.util.Collection) _v) {
169 _mask |= describeContents(o);
170 }
171 return _mask;
172 }
173 if (_v instanceof android.os.Parcelable) {
174 return ((android.os.Parcelable) _v).describeContents();
175 }
176 return 0;
177 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900178}
179)";
180
Devin Moore2f2077a2020-08-28 11:27:53 -0700181// clang-format off
182const char kExpectedCppHeaderOutput[] =
183 R"(#pragma once
184
185#include <binder/IBinder.h>
186#include <binder/IInterface.h>
187#include <binder/Status.h>
188#include <optional>
189#include <utils/String16.h>
190#include <utils/StrongPointer.h>
191#include <vector>
192
193class IFoo : public ::android::IInterface {
194public:
195 DECLARE_META_INTERFACE(Foo)
196 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
197}; // class IFoo
198class IFooDefault : public IFoo {
199public:
200 ::android::IBinder* onAsBinder() override {
201 return nullptr;
202 }
203 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
204 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
205 }
206}; // class IFooDefault
207)";
208// clang-format on
209
Christopher Wileyf8136192016-04-12 14:19:35 -0700210} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700213 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900214 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
215 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700216 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700217 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900218 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 args.emplace_back("aidl");
220 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700221 for (const string& s : additional_arguments) {
222 args.emplace_back(s);
223 }
224 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900225 args.emplace_back("--preprocessed=" + f);
226 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700227 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900228 args.emplace_back("--include=" + i);
229 }
230 args.emplace_back(path);
231 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900232 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900233 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700234 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900235 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900236
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700237 if (error != nullptr) {
238 *error = actual_error;
239 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900240
241 if (actual_error != AidlError::OK) {
242 return nullptr;
243 }
244
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900245 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900246 EXPECT_EQ(1ul, defined_types.size());
247
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900248 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700249 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700250
Devin Moore7b8d5c92020-03-17 14:14:08 -0700251 Options::Language GetLanguage() { return GetParam(); }
252
Christopher Wiley0522cd52015-10-28 15:39:44 -0700253 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800254 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900255 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900256 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700257};
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
260// tests with each of the supported languages as a parameter.
261INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
262 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700263 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 [](const testing::TestParamInfo<Options::Language>& info) {
265 return Options::LanguageToString(info.param);
266 });
267
268TEST_P(AidlTest, AcceptMissingPackage) {
269 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700270}
271
Devin Moore7b8d5c92020-03-17 14:14:08 -0700272TEST_P(AidlTest, EndsInSingleLineComment) {
273 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700274}
275
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000276TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
277 const string expected_stderr =
278 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
279 const std::string file_contents = "package a; interface IBar {}";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
283}
284
285TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
286 const string expected_stderr =
287 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
288 const std::string file_contents = "package a; interface Bar {}";
289 CaptureStderr();
290 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
291 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
292}
293
294TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
295 const string expected_stderr =
296 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
297 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
298 CaptureStderr();
299 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
300 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
301}
302
303TEST_P(AidlTest, EnumRequiresCorrectPath) {
304 const string expected_stderr =
305 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
306 const std::string file_contents = "package a; enum Bar { A, }";
307 CaptureStderr();
308 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
309 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
310}
311
Devin Moore7b8d5c92020-03-17 14:14:08 -0700312TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900313 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700314 io_delegate_.SetFileContents("bar/IBar.aidl",
315 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700316 const string path = "foo/IFoo.aidl";
317 const string contents =
318 "package foo;\n"
319 "import bar.IBar;\n"
320 "interface IFoo { void f(in IBar[] input); }";
321 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700323 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700325}
326
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700328 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700329 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900330}
Devin Moore097a3ab2020-03-11 16:08:44 -0700331
Jiyong Park40782d02020-07-24 19:17:43 +0900332TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700333 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
334 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900335 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
336 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700339 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900340}
341
Jiyong Park40782d02020-07-24 19:17:43 +0900342TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700343 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
344 const string expected_stderr =
345 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346 CaptureStderr();
347 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
348 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900349}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350
Jiyong Park40782d02020-07-24 19:17:43 +0900351TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700352 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900353 const string expected_stderr =
354 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
362 const string expected_stderr =
363 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
364 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700365 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700366 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
371 const string expected_stderr =
372 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
373 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700374 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800376}
377
Devin Moore2f2077a2020-08-28 11:27:53 -0700378TEST_P(AidlTest, AcceptNullableList) {
379 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
380 const string expected_stderr = "";
381 CaptureStderr();
382 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
383 EXPECT_EQ(expected_stderr, GetCapturedStderr());
384}
385
Devin Moore7b8d5c92020-03-17 14:14:08 -0700386TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700387 const string method = "package a; interface IFoo { void f(int a, int a); }";
388 const string expected_stderr =
389 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
390 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700393}
394
Jeongik Cha13066da2020-08-06 15:43:19 +0900395TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
396 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900397 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900398 CaptureStderr();
399 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
401}
402
Jooyung Hand902a972020-10-23 17:32:44 +0900403TEST_P(AidlTest, RejectsRepeatedAnnotations) {
404 const string method = R"(@Hide @Hide parcelable Foo {})";
405 const string expected_stderr =
406 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
407 "Foo.aidl:1.1-6\n";
408 CaptureStderr();
409 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
411}
412
Devin Moore7b8d5c92020-03-17 14:14:08 -0700413TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700414 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
415 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
416 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700418 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100419}
420
Devin Moore7b8d5c92020-03-17 14:14:08 -0700421TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700422 AidlError error;
423 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700424 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700425 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900426 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700427 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800428}
429
Devin Moore7b8d5c92020-03-17 14:14:08 -0700430TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700431 AidlError error;
432 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700433 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700434 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900435 EXPECT_THAT(GetCapturedStderr(),
436 HasSubstr("'JavaOnlyStableParcelable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700437 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800438}
439
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700441 AidlError error;
442 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700443 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000444 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900445 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700446 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800447}
448
Devin Moore7b8d5c92020-03-17 14:14:08 -0700449TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700450 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000451 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900454 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Jiyong Park40782d02020-07-24 19:17:43 +0900458TEST_P(AidlTest, ParsesNonNullableAnnotation) {
459 auto parse_result =
460 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
461 ASSERT_NE(nullptr, parse_result);
462 const AidlInterface* interface = parse_result->AsInterface();
463 ASSERT_NE(nullptr, interface);
464 ASSERT_FALSE(interface->GetMethods().empty());
465 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
466}
467
Devin Moore7b8d5c92020-03-17 14:14:08 -0700468TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900469 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
470 typenames_, GetLanguage());
471 ASSERT_NE(nullptr, parse_result);
472 const AidlInterface* interface = parse_result->AsInterface();
473 ASSERT_NE(nullptr, interface);
474 ASSERT_FALSE(interface->GetMethods().empty());
475 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
476}
477
478TEST_P(AidlTest, ParsesNonUtf8Annotations) {
479 auto parse_result =
480 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
481 ASSERT_NE(nullptr, parse_result);
482 const AidlInterface* interface = parse_result->AsInterface();
483 ASSERT_NE(nullptr, interface);
484 ASSERT_FALSE(interface->GetMethods().empty());
485 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800486}
487
Devin Moore7b8d5c92020-03-17 14:14:08 -0700488TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900489 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
490 typenames_, GetLanguage());
491 ASSERT_NE(nullptr, parse_result);
492 const AidlInterface* interface = parse_result->AsInterface();
493 ASSERT_NE(nullptr, interface);
494 ASSERT_FALSE(interface->GetMethods().empty());
495 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800496}
497
Devin Moore7b8d5c92020-03-17 14:14:08 -0700498TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700499 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700500 const string expected_stderr =
501 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
502 "\"vintf\"'\n"
503 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
504 "--structured\n";
505 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700506 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700507 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700509 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510}
511
Devin Moore7b8d5c92020-03-17 14:14:08 -0700512TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700513 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700514 const string expected_stderr =
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
528 "\"vintf\"'\n";
529 CaptureStderr();
530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700538 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
539 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700540 ASSERT_EQ(AidlError::OK, error);
541 ASSERT_NE(nullptr, parse_result);
542 const AidlInterface* interface = parse_result->AsInterface();
543 ASSERT_NE(nullptr, interface);
544 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545}
546
Jeongik Cha64783ed2019-06-07 18:30:54 +0900547TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
548 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900549 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
550 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900551 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700552 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900553 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900554 "a/Foo.aidl",
555 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900556
557 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900558 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700559 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900560 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700561 "Parcelable must be defined in AIDL directly.\n";
562 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900563 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700564 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700565
566 CaptureStderr();
567 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
568 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569}
570
Jooyung Han1cbc4962020-10-25 10:07:15 +0900571TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
572 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
573 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
574 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900575 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
576
577 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900578 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900579 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
580
581 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900582 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900583 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
584
Jooyung Han1cbc4962020-10-25 10:07:15 +0900585 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
587}
588
Jooyung Han1cbc4962020-10-25 10:07:15 +0900589TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
590 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
591 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
592 CaptureStderr();
593 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
594 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
595 EXPECT_EQ("", GetCapturedStderr());
596
597 const string expected_to_string_method = R"--(
598 @Override
599 public String toString() {
600 switch (_tag) {
601 case a: return "a.Foo.a(" + (getA()) + ")";
602 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
603 }
604 throw new IllegalStateException("unknown field: " + _tag);
605 }
606)--";
607
608 string java_out;
609 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
610 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
611}
612
Jiyong Park9aa3d042020-12-04 23:30:02 +0900613TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
614 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
615 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
616 CaptureStderr();
617 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
618 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
619 EXPECT_EQ("", GetCapturedStderr());
620
621 const std::string expected = R"--(
622 @Override
623 public boolean equals(Object other) {
624 if (this == other) return true;
625 if (other == null) return false;
626 if (!(other instanceof Foo)) return false;
627 Foo that = (Foo)other;
628 if (!java.util.Objects.deepEquals(a, that.a)) return false;
629 if (!java.util.Objects.deepEquals(b, that.b)) return false;
630 return true;
631 }
632
633 @Override
634 public int hashCode() {
635 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
636 }
637)--";
638
639 string java_out;
640 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
641 EXPECT_THAT(java_out, testing::HasSubstr(expected));
642}
643
644TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
645 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
646 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
647 CaptureStderr();
648 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
649 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
650 EXPECT_EQ("", GetCapturedStderr());
651
652 const std::string expected = R"--(
653 @Override
654 public boolean equals(Object other) {
655 if (this == other) return true;
656 if (other == null) return false;
657 if (!(other instanceof Foo)) return false;
658 Foo that = (Foo)other;
659 if (_tag != that._tag) return false;
660 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
661 return true;
662 }
663
664 @Override
665 public int hashCode() {
666 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
667 }
668)--";
669
670 string java_out;
671 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
672 EXPECT_THAT(java_out, testing::HasSubstr(expected));
673}
674
Jooyung Han90345002020-10-23 15:28:53 +0900675TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900676 {
Jooyung Han90345002020-10-23 15:28:53 +0900677 io_delegate_.SetFileContents("a/Foo.aidl",
678 "package a; @JavaDerive(blah=true) parcelable Foo{}");
679 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
680 CaptureStderr();
681 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
682 const std::string expected_stderr =
683 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900684 EXPECT_THAT(GetCapturedStderr(),
685 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900686 }
687
688 {
689 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900690 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
691 CaptureStderr();
692 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900693 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation"));
Jiyong Park43113fb2020-07-20 16:26:19 +0900694 }
695
696 {
Jooyung Han90345002020-10-23 15:28:53 +0900697 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900698 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
699 CaptureStderr();
700 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900701 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation"));
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 }
703}
704
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900705TEST_P(AidlTest, ParseDescriptorAnnotation) {
706 AidlError error;
707 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
708 typenames_, GetLanguage(), &error, {"--structured"});
709 ASSERT_EQ(AidlError::OK, error);
710 ASSERT_NE(nullptr, parse_result);
711 const AidlInterface* interface = parse_result->AsInterface();
712 ASSERT_NE(nullptr, interface);
713 ASSERT_EQ("IBar", interface->GetDescriptor());
714}
715
Jiyong Park40782d02020-07-24 19:17:43 +0900716TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700717 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700718 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900719}
720
721TEST_P(AidlTest, AcceptsOnewayInterface) {
722 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700723 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700724}
Christopher Wileyef140932015-11-03 09:29:19 -0800725
Devin Moore7b8d5c92020-03-17 14:14:08 -0700726TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700727 const string oneway_method =
728 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700729 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100730}
731
Steven Moreland65297cc2020-04-20 20:17:36 -0700732TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
733 const string oneway_method =
734 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
735 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
736 ASSERT_NE(nullptr, defined);
737 const AidlInterface* iface = defined->AsInterface();
738 ASSERT_NE(nullptr, iface);
739
740 const auto& methods = iface->GetMethods();
741 ASSERT_EQ(1u, methods.size());
742 const auto& method = methods[0];
743 const AidlTypeSpecifier& ret_type = method->GetType();
744
745 // TODO(b/151102494): these annotations should be on the method
746 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
747 ASSERT_TRUE(ret_type.IsHide());
748}
749
Devin Moore7b8d5c92020-03-17 14:14:08 -0700750TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100751 string foo_interface =
752 "package a; /* foo */ interface IFoo {"
753 " /* i */ int i();"
754 " /* j */ @nullable String j();"
755 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
756
Devin Moore7b8d5c92020-03-17 14:14:08 -0700757 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100758 EXPECT_NE(nullptr, parse_result);
759 EXPECT_EQ("/* foo */", parse_result->GetComments());
760
761 const AidlInterface* interface = parse_result->AsInterface();
762 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
763 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
764 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
765}
766
Jooyung Han1a551d32020-10-05 15:37:26 +0900767TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
768 io_delegate_.SetFileContents("p/cpp_header.aidl",
769 R"(package p;
770 parcelable cpp_header cpp_header "bar/header";)");
771 import_paths_.emplace("");
772 const string input_path = "p/IFoo.aidl";
773 const string input = R"(package p;
774 import p.cpp_header;
775 interface IFoo {
776 // get bar
777 cpp_header get();
778 })";
779
780 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
781 EXPECT_NE(nullptr, parse_result);
782 const AidlInterface* interface = parse_result->AsInterface();
783 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
784}
785
Christopher Wileyef140932015-11-03 09:29:19 -0800786TEST_F(AidlTest, ParsesPreprocessedFile) {
787 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
788 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700789 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900790 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800793}
794
795TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
796 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
797 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900798
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700799 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900800 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700801 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
802 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800803}
804
Devin Moore7b8d5c92020-03-17 14:14:08 -0700805TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800806 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
807 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
808 "interface IBar {}");
809 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900810 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900811 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700812 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800813 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900814
Christopher Wiley41544372015-11-03 14:52:29 -0800815 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700816 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
817 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800818 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700819 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900820 ambiguous_type.Resolve(typenames_);
821 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800822}
823
Jiyong Park8f6ec462020-01-19 20:52:47 +0900824// Special case of PreferImportToPreprocessed. Imported type should be preferred
825// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700826TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900827 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
828 io_delegate_.SetFileContents("one/IBar.aidl",
829 "package one; "
830 "interface IBar {}");
831 preprocessed_files_.push_back("preprocessed");
832 import_paths_.emplace("");
833 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700834 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900835 EXPECT_NE(nullptr, parse_result);
836
837 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700838 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
839 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900840 // But if we request just "IBar" we should get our imported one.
841 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
842 ambiguous_type.Resolve(typenames_);
843 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
844}
845
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800846TEST_F(AidlTest, WritePreprocessedFile) {
847 io_delegate_.SetFileContents("p/Outer.aidl",
848 "package p; parcelable Outer.Inner;");
849 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
850 "interface IBar {}");
851
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900852 vector<string> args {
853 "aidl",
854 "--preprocess",
855 "preprocessed",
856 "p/Outer.aidl",
857 "one/IBar.aidl"};
858 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800859 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
860
861 string output;
862 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
863 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
864}
865
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900866TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100867 io_delegate_.SetFileContents(
868 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800869 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100870 "parcelable Rect {\n"
871 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800872 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100873 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800874 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100875 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100876 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
877 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100878 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900879 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900880 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100881 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900882
883 vector<string> args{"aidl", "Rect.aidl"};
884 Options options = Options::From(args);
885 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
886
887 string output;
888 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900889 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900890}
891
Devin Moore2f2077a2020-08-28 11:27:53 -0700892TEST_F(AidlTest, CppHeaderIncludes) {
893 io_delegate_.SetFileContents("IFoo.aidl",
894 "interface IFoo {\n"
895 " @nullable List<String> foo();\n"
896 "}");
897
898 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
899 Options options = Options::From(args);
900 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
901 std::vector<std::string> empty;
902 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
903 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
904 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
905
906 // Make sure the optional and String16.h includes are added
907 string output;
908 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
909 EXPECT_EQ(kExpectedCppHeaderOutput, output);
910}
911
Devin Moore7b8d5c92020-03-17 14:14:08 -0700912TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700913 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800914 io_delegate_.SetFileContents("p/Outer.aidl",
915 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900916 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 CaptureStderr();
918 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
919 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700920 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800922}
923
Devin Moore7b8d5c92020-03-17 14:14:08 -0700924TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800925 io_delegate_.SetFileContents("preprocessed",
926 "parcelable p.Outer.Inner;");
927 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900928 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700929 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800930 // TODO(wiley): This should actually return nullptr because we require
931 // the outer class name. However, for legacy reasons,
932 // this behavior must be maintained. b/17415692
933 EXPECT_NE(nullptr, parse_result);
934}
935
Christopher Wiley632801d2015-11-05 14:15:49 -0800936TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700937 const string expected_foo_stderr =
938 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
939 "Declared parcelables should be in their own file and/or cannot be used with --structured "
940 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700941 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
942
Christopher Wiley632801d2015-11-05 14:15:49 -0800943 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700944 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700945 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900946 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700947 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900948
Steven Morelande2c64b42018-09-18 15:06:37 -0700949 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900950 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900952 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700954
Devin Moore097a3ab2020-03-11 16:08:44 -0700955 const string expected_bar_stderr =
956 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
957 "Declared parcelables should be in their own file and/or cannot be used with --structured "
958 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700959 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
960
Jiyong Parkda8c6932019-08-12 19:56:08 +0900961 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700962 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900964 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700965 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700966 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700967 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800970}
971
Devin Moore7b8d5c92020-03-17 14:14:08 -0700972TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700973 const string expected_stderr =
974 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
975 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700976 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
977 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 AidlError error;
979 CaptureStderr();
980 EXPECT_EQ(
981 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700982 Parse("p/IFoo.aidl",
983 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700984 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
986 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700987}
988
Devin Moore7b8d5c92020-03-17 14:14:08 -0700989TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700990 AidlError error;
991 const string expected_stderr =
992 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
993 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900994 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
995 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700996 interface IFoo {
997 const String DUPLICATED = "d";
998 const int DUPLICATED = 1;
999 }
1000 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001004}
1005
Steven Morelande689da22020-11-10 02:06:30 +00001006TEST_P(AidlTest, FailOnTooBigConstant) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1010 CaptureStderr();
1011 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1012 R"(package p;
1013 interface IFoo {
1014 const byte type2small = 256;
1015 }
1016 )",
1017 typenames_, GetLanguage(), &error));
1018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1019 EXPECT_EQ(AidlError::BAD_TYPE, error);
1020}
1021
Jooyung Han30f64ad2020-12-15 08:16:31 +09001022TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1023 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1024 CaptureStderr();
1025 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1026 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1027 EXPECT_EQ("", GetCapturedStderr());
1028 string code;
1029 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1030 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1031}
1032
Jooyung Han71a1b582020-12-25 23:58:41 +09001033TEST_F(AidlTest, ConstantValueCast) {
1034 using Ptr = unique_ptr<AidlConstantValue>;
1035 const AidlLocation& loc = AIDL_LOCATION_HERE;
1036
1037 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->Cast<char>());
1038 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->Cast<string>());
1039 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0"))->Cast<float>());
1040 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->Cast<bool>());
1041
1042 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1043 Ptr(AidlConstantValue::Integral(loc, "1")));
1044 EXPECT_EQ(2, one_plus_one.Cast<int32_t>());
1045
1046 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1047 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1048 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1049 vector<string> expected{"hello", "world"};
1050 EXPECT_EQ(expected,
1051 Ptr(AidlConstantValue::Array(loc, std::move(values)))->Cast<vector<string>>());
1052}
1053
Devin Moore7b8d5c92020-03-17 14:14:08 -07001054TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001055 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001056 const string expected_stderr =
1057 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001058 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001059 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1060 R"(package p;
1061 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001062 parcelable IBar {}
1063 parcelable StructuredParcelable {}
1064 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001065 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001066 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001067 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001068 // Parse success is important for clear error handling even if the cases aren't
1069 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001070 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001071}
1072
Devin Moore7b8d5c92020-03-17 14:14:08 -07001073TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001074 AidlError error;
1075 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1076 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001077 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001078 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1079 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001080}
1081
Steven Morelandf9e922f2020-07-08 21:15:27 +00001082TEST_P(AidlTest, FailOnEmptyListWithComma) {
1083 AidlError error;
1084 const string expected_stderr =
1085 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1086 CaptureStderr();
1087 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1088 typenames_, GetLanguage(), &error));
1089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1090 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1091}
1092
Devin Moore7b8d5c92020-03-17 14:14:08 -07001093TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001094 AidlError error;
1095 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001096 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001097 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001098 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1099 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001100 interface IFoo {
1101 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1102 }
1103 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001104 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1106 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001107}
1108
Jiyong Park18132182020-06-08 20:24:40 +09001109TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1110 AidlError error;
1111 const string expected_stderr =
1112 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1113 "cpp_header (which can also be used as an identifier)\n";
1114 CaptureStderr();
1115 // Notice the trailing dot(.) in the name, which isn't a correct name
1116 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1117 GetLanguage(), &error));
1118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1119 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1120}
1121
1122TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1123 AidlError error;
1124 const string expected_stderr =
1125 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1126 "cpp_header (which can also be used as an identifier)\n";
1127 CaptureStderr();
1128 // Notice the trailing dot(.) in the package name
1129 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1130 GetLanguage(), &error));
1131 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1132 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1133}
1134
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001136 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137 auto parse_result = Parse("p/IFoo.aidl",
1138 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001139 interface IFoo {
1140 const int POSITIVE_HEX_VALUE = 0xf5;
1141 }
1142 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143 typenames_, GetLanguage(), &error);
1144 EXPECT_NE(nullptr, parse_result);
1145 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001146 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001147 const auto& cpp_constants = interface->GetConstantDeclarations();
1148 EXPECT_EQ((size_t)1, cpp_constants.size());
1149 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001150 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001151 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001152}
1153
Devin Moore7b8d5c92020-03-17 14:14:08 -07001154TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001155 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001156 auto parse_result = Parse("p/IFoo.aidl",
1157 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001158 interface IFoo {
1159 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1160 }
1161 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001162 typenames_, GetLanguage(), &error);
1163 ASSERT_NE(nullptr, parse_result);
1164 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001165 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001166 const auto& cpp_constants = interface->GetConstantDeclarations();
1167 EXPECT_EQ((size_t)1, cpp_constants.size());
1168 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001169 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001170 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001171}
1172
Devin Moore7b8d5c92020-03-17 14:14:08 -07001173TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001174 io_delegate_.SetFileContents(
1175 "p/Outer.aidl",
1176 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001177 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001178 const string input_path = "p/IFoo.aidl";
1179 const string input = "package p; import p.Outer; interface IFoo"
1180 " { Outer.Inner get(); }";
1181
Devin Moore7b8d5c92020-03-17 14:14:08 -07001182 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1183 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001184
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001185 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001186 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001187 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1188 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001189}
1190
Devin Moore7b8d5c92020-03-17 14:14:08 -07001191TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001192 io_delegate_.SetFileContents(
1193 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001194 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001195 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001196 const string input_path = "p/IFoo.aidl";
1197 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001198 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1199 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001200 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001201 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1202 native_type.Resolve(typenames_);
1203
1204 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1205 // C++ understands C++ specific stuff
1206 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1207 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001208 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001209 EXPECT_EQ(1u, headers.size());
1210 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001211}
1212
Christopher Wileyf8136192016-04-12 14:19:35 -07001213TEST_F(AidlTest, WritesCorrectDependencyFile) {
1214 // While the in tree build system always gives us an output file name,
1215 // other android tools take advantage of our ability to infer the intended
1216 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001217 vector<string> args = {
1218 "aidl",
1219 "-d dep/file/path",
1220 "-o place/for/output",
1221 "p/IFoo.aidl"};
1222 Options options = Options::From(args);
1223 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001224 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001225 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001226 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001227 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1228}
1229
Dan Willemsen93298ee2016-11-10 23:55:55 -08001230TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1231 // While the in tree build system always gives us an output file name,
1232 // other android tools take advantage of our ability to infer the intended
1233 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001234 vector<string> args = {
1235 "aidl",
1236 "-d dep/file/path",
1237 "--ninja",
1238 "-o place/for/output",
1239 "p/IFoo.aidl"};
1240 Options options = Options::From(args);
1241 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001242 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001243 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001244 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001245 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1246}
1247
Jiyong Parkdf202122019-09-30 20:48:35 +09001248TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001249 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1250 // this by calling aidl with every .aidl file it finds, then parsing the
1251 // generated dependency files. Those that reference .java output files are
1252 // for interfaces and those that do not are parcelables. However, for both
1253 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001254 vector<string> args = {
1255 "aidl",
1256 "-o place/for/output",
1257 "-d dep/file/path",
1258 "p/Foo.aidl"};
1259 Options options = Options::From(args);
1260 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001261 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001262 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001263 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001264 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1265}
1266
1267TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1268 vector<string> args = {
1269 "aidl",
1270 "--structured",
1271 "-o place/for/output",
1272 "-d dep/file/path",
1273 "p/Foo.aidl"};
1274 Options options = Options::From(args);
1275 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1276 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1277 string actual_dep_file_contents;
1278 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1279 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001280}
1281
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001282TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1283 vector<string> args = {
1284 "aidl",
1285 "--lang=java",
1286 "-o place/for/output",
1287 "p/Foo.aidl"};
1288 Options options = Options::From(args);
1289 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1290 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1291 string output_file_contents;
1292 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1293}
1294
Devin Moore21b26772020-08-26 16:37:56 -07001295TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001296 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001297 const string list_array_parcelable =
1298 "package a; parcelable Foo {\n"
1299 " List[] lists; }";
1300 CaptureStderr();
1301 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1302 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1303}
1304
Jiyong Parkf8d53612020-05-04 14:06:13 +09001305TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1306 AidlError error;
1307 string expected_stderr =
1308 "ERROR: a/IFoo.aidl:2.7-11: "
1309 "Encountered an untyped List or Map. The use of untyped List/Map is "
1310 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1311 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1312 if (GetLanguage() != Options::Language::JAVA) {
1313 expected_stderr =
1314 "ERROR: a/IFoo.aidl:2.1-7: "
1315 "Currently, only the Java backend supports non-generic List.\n";
1316 }
1317
1318 const string primitive_interface =
1319 "package a; interface IFoo {\n"
1320 " List foo(); }";
1321 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001322 AidlTypenames tn1;
1323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001324 {"--structured"}));
1325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001326
1327 string primitive_parcelable =
1328 "package a; parcelable IFoo {\n"
1329 " List foo;}";
1330 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001331 AidlTypenames tn2;
1332 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001333 {"--structured"}));
1334 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1335}
1336
Jeongik Cha225519b2020-08-29 01:55:32 +09001337TEST_P(AidlTest, ExtensionTest) {
1338 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001339 string extendable_parcelable =
1340 "package a; parcelable Data {\n"
1341 " ParcelableHolder extension;\n"
1342 " ParcelableHolder extension2;\n"
1343 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001344 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001345 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1346 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001347 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001348 "yet.\n",
1349 GetCapturedStderr());
1350 } else {
1351 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1352 EXPECT_EQ("", GetCapturedStderr());
1353 }
1354}
1355TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1356 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001357 string parcelableholder_return_interface =
1358 "package a; interface IFoo {\n"
1359 " ParcelableHolder foo();\n"
1360 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001361 EXPECT_EQ(nullptr,
1362 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001363
Jeongik Cha8f02a532020-10-14 00:16:28 +09001364 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001365 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001366 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001367 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001368 "yet.\n",
1369 GetCapturedStderr());
1370 return;
1371 }
1372 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1373 GetCapturedStderr());
1374}
1375
1376TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1377 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001378 string extendable_parcelable_arg_interface =
1379 "package a; interface IFoo {\n"
1380 " void foo(in ParcelableHolder ph);\n"
1381 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001382 EXPECT_EQ(nullptr,
1383 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1384
Jeongik Cha8f02a532020-10-14 00:16:28 +09001385 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001386 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001387 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001388 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001389 "yet.\n",
1390 GetCapturedStderr());
1391 return;
1392 }
1393 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1394 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001395}
1396
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001397TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1398 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1399 Options options =
1400 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1401 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1402 CaptureStderr();
1403 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1404 if (GetLanguage() == Options::Language::RUST) {
1405 EXPECT_EQ(
1406 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1407 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1408 "yet.\n",
1409 GetCapturedStderr());
1410 return;
1411 }
1412 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1413}
1414
Jooyung Han3f347ca2020-12-01 12:41:50 +09001415TEST_P(AidlTest, ParcelablesWithConstants) {
1416 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1417 Options options =
1418 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1419 CaptureStderr();
1420 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1421 EXPECT_EQ("", GetCapturedStderr());
1422}
1423
1424TEST_P(AidlTest, UnionWithConstants) {
1425 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1426 Options options =
1427 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1428 CaptureStderr();
1429 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1430 EXPECT_EQ("", GetCapturedStderr());
1431}
1432
Jiyong Park02da7422018-07-16 16:00:26 +09001433TEST_F(AidlTest, ApiDump) {
1434 io_delegate_.SetFileContents(
1435 "foo/bar/IFoo.aidl",
1436 "package foo.bar;\n"
1437 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001438 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001439 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001440 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001441 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1442 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1443 " IFoo foo3(IFoo foo);\n"
1444 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001445 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001446 " const int A = 1;\n"
1447 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001448 "}\n");
1449 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1450 "package foo.bar;\n"
1451 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001452 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001453 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001454 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001455 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001456 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001457 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001458 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001459 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001460 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001461 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001462 "}\n");
1463 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001464 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1465 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001466 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001467 bool result = dump_api(options, io_delegate_);
1468 ASSERT_TRUE(result);
1469 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001470 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001471 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001472/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001473interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001474 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001475 int foo(out int[] a, String b, boolean c, inout List<String> d);
1476 int foo2(@utf8InCpp String x, inout List<String> y);
1477 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1478 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001479 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001480 const int A = 1;
1481 const String STR = "Hello";
1482}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001483)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001484
Jiyong Parke59c3682018-09-11 23:10:25 +09001485 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001486 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001487/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001488parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001489 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001490 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001491 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001492 int y;
1493 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001494 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001495 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001496}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001497)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001498}
1499
Jiyong Parked65bf42018-08-28 15:43:27 +09001500TEST_F(AidlTest, ApiDumpWithManualIds) {
1501 io_delegate_.SetFileContents(
1502 "foo/bar/IFoo.aidl",
1503 "package foo.bar;\n"
1504 "interface IFoo {\n"
1505 " int foo() = 1;\n"
1506 " int bar() = 2;\n"
1507 " int baz() = 10;\n"
1508 "}\n");
1509
Jiyong Parke59c3682018-09-11 23:10:25 +09001510 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001511 Options options = Options::From(args);
1512 bool result = dump_api(options, io_delegate_);
1513 ASSERT_TRUE(result);
1514 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001515 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001516 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001517interface IFoo {
1518 int foo() = 1;
1519 int bar() = 2;
1520 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001521}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001522)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001523}
1524
1525TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001526 const string expected_stderr =
1527 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1528 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001529 io_delegate_.SetFileContents(
1530 "foo/bar/IFoo.aidl",
1531 "package foo.bar;\n"
1532 "interface IFoo {\n"
1533 " int foo() = 1;\n"
1534 " int bar();\n"
1535 " int baz() = 10;\n"
1536 "}\n");
1537
Jiyong Parke59c3682018-09-11 23:10:25 +09001538 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001539 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001541 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001542 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001543}
1544
Jooyung Han965e31d2020-11-27 12:30:16 +09001545TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1546 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1547 "package foo.bar;\n"
1548 "interface IFoo {\n"
1549 " @utf8InCpp String foo();\n"
1550 " const @utf8InCpp String bar = \"bar\";\n"
1551 "}\n");
1552
1553 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1554 Options options = Options::From(args);
1555 CaptureStderr();
1556 EXPECT_TRUE(dump_api(options, io_delegate_));
1557 EXPECT_EQ("", GetCapturedStderr());
1558 string actual;
1559 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001560 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1561interface IFoo {
1562 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001563 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001564}
1565)"),
1566 actual);
1567}
1568
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001569TEST_F(AidlTest, ApiDumpWithEnums) {
1570 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1571 "package foo.bar;\n"
1572 "enum Enum {\n"
1573 " FOO,\n"
1574 " BAR = FOO + 1,\n"
1575 "}\n");
1576
1577 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1578 Options options = Options::From(args);
1579 CaptureStderr();
1580 EXPECT_TRUE(dump_api(options, io_delegate_));
1581 EXPECT_EQ("", GetCapturedStderr());
1582 string actual;
1583 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1584 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1585 "enum Enum {\n"
1586 " FOO = 0,\n"
1587 " BAR = 1,\n"
1588 "}\n"),
1589 actual);
1590}
1591
1592TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1593 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1594 "package foo.bar;\n"
1595 "enum Enum {\n"
1596 " FOO,\n"
1597 "}\n");
1598 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1599 "package foo.bar;\n"
1600 "import foo.bar.Enum;\n"
1601 "parcelable Foo {\n"
1602 " Enum e = Enum.FOO;\n"
1603 "}\n");
1604
1605 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1606 Options options = Options::From(args);
1607 CaptureStderr();
1608 EXPECT_TRUE(dump_api(options, io_delegate_));
1609 EXPECT_EQ("", GetCapturedStderr());
1610 string actual;
1611 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1612 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1613 "parcelable Foo {\n"
1614 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1615 "}\n"),
1616 actual);
1617}
1618
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001619TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001620 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001621 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1622 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001623 const string expected_map_stderr =
1624 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001625 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1626 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001627 "package p; interface IFoo {"
1628 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001629 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001630 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001631 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001632
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001633 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001634 "package p; interface IFoo {"
1635 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001637 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001639}
1640
Jeongik Chae48d9942020-01-02 17:39:00 +09001641TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001642 const string expected_stderr =
1643 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001644 Options options = Options::From("aidl -I p p/IFoo.aidl");
1645 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1646
1647 io_delegate_.SetFileContents("p/IFoo.aidl",
1648 "package p; interface IFoo {"
1649 "Map<String, Bar> foo();}");
1650 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1651
1652 io_delegate_.SetFileContents("p/IFoo.aidl",
1653 "package p; interface IFoo {"
1654 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001656 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001658
1659 io_delegate_.SetFileContents("p/IFoo.aidl",
1660 "package p; interface IFoo {"
1661 "Map<String, String> foo();}");
1662 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1663
1664 io_delegate_.SetFileContents("p/IFoo.aidl",
1665 "package p; interface IFoo {"
1666 "Map<String, ParcelFileDescriptor> foo();}");
1667 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1668}
1669
Jeongik Chadf76dc72019-11-28 00:08:47 +09001670TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001671 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001672 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1673 io_delegate_.SetFileContents(options.InputFiles().front(),
1674 "package p; interface IFoo {"
1675 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001676 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001678 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001679}
1680
1681TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1682 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1683 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001684 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001685 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001686 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1687 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001688
1689 Options options = Options::From("aidl -I p p/IFoo.aidl");
1690 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1691 io_delegate_.SetFileContents("p/IFoo.aidl",
1692 "package p; interface IFoo {"
1693 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001694 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001695 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001696 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001697 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001698 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001699 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001700 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1701 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001702 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1703 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1704 io_delegate_.SetFileContents("p/IFoo.aidl",
1705 "package p; interface IFoo {"
1706 "Bar<String, ParcelFileDescriptor> foo();}");
1707 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001708
1709 io_delegate_.SetFileContents("p/IFoo.aidl",
1710 "package p; interface IFoo {"
1711 "Bar<int, long> foo();}");
1712
1713 io_delegate_.SetFileContents("p/IFoo.aidl",
1714 "package p; interface IFoo {"
1715 "Bar<int[], long[]> foo();}");
1716
1717 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001718}
1719
Jeongik Cha0e426012019-07-29 15:57:02 +09001720TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1721 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001722 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1723 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001724 for (const auto& rawOption : rawOptions) {
1725 string expected_stderr =
1726 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001727 Options options = Options::From(rawOption);
1728 io_delegate_.SetFileContents(options.InputFiles().front(),
1729 "package foo.bar;\n"
1730 "interface IFoo1 { int foo(); }\n"
1731 "interface IFoo2 { int foo(); }\n"
1732 "parcelable Data1 { int a; int b;}\n"
1733 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001734 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001735 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001736 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001737
Jeongik Cha0e426012019-07-29 15:57:02 +09001738 io_delegate_.SetFileContents(options.InputFiles().front(),
1739 "package foo.bar;\n"
1740 "interface IFoo1 { int foo(); }\n"
1741 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001743 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001744 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001745
Devin Moore5de18ed2020-04-02 13:52:29 -07001746 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001747 io_delegate_.SetFileContents(options.InputFiles().front(),
1748 "package foo.bar;\n"
1749 "parcelable Data1 { int a; int b;}\n"
1750 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001751 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001752 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001753 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001754 }
1755}
1756
Devin Moorebdba2a82020-03-31 15:19:02 -07001757TEST_P(AidlTest, FailParseOnEmptyFile) {
1758 const string contents = "";
1759 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1760 CaptureStderr();
1761 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1762 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1763}
1764
Jiyong Parkb034bf02018-07-30 17:44:33 +09001765TEST_F(AidlTest, MultipleInputFiles) {
1766 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001767 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001768
1769 io_delegate_.SetFileContents(options.InputFiles().at(0),
1770 "package foo.bar;\n"
1771 "import foo.bar.Data;\n"
1772 "interface IFoo { Data getData(); }\n");
1773
1774 io_delegate_.SetFileContents(options.InputFiles().at(1),
1775 "package foo.bar;\n"
1776 "import foo.bar.IFoo;\n"
1777 "parcelable Data { IFoo foo; }\n");
1778
1779 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1780
1781 string content;
1782 for (const auto file : {
1783 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1784 content.clear();
1785 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1786 EXPECT_FALSE(content.empty());
1787 }
1788}
1789
1790TEST_F(AidlTest, MultipleInputFilesCpp) {
1791 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001792 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001793
1794 io_delegate_.SetFileContents(options.InputFiles().at(0),
1795 "package foo.bar;\n"
1796 "import foo.bar.Data;\n"
1797 "interface IFoo { Data getData(); }\n");
1798
1799 io_delegate_.SetFileContents(options.InputFiles().at(1),
1800 "package foo.bar;\n"
1801 "import foo.bar.IFoo;\n"
1802 "parcelable Data { IFoo foo; }\n");
1803
1804 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1805
1806 string content;
1807 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001808 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001809 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1810 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1811 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1812 content.clear();
1813 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1814 EXPECT_FALSE(content.empty());
1815 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001816}
1817
Andrei Homescub62afd92020-05-11 19:24:59 -07001818TEST_F(AidlTest, MultipleInputFilesRust) {
1819 Options options =
1820 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1821
1822 io_delegate_.SetFileContents(options.InputFiles().at(0),
1823 "package foo.bar;\n"
1824 "import foo.bar.Data;\n"
1825 "interface IFoo { Data getData(); }\n");
1826
1827 io_delegate_.SetFileContents(options.InputFiles().at(1),
1828 "package foo.bar;\n"
1829 "import foo.bar.IFoo;\n"
1830 "parcelable Data { IFoo foo; }\n");
1831
1832 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1833
1834 string content;
1835 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1836 content.clear();
1837 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1838 EXPECT_FALSE(content.empty());
1839 }
1840}
1841
Devin Moore097a3ab2020-03-11 16:08:44 -07001842TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1843 const string expected_stderr =
1844 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001845 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1846 // int getInterfaceVersion() is one of the meta transactions
1847 io_delegate_.SetFileContents(options.InputFiles().front(),
1848 "package p; interface IFoo {"
1849 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001850 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001851 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001852 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1853}
Jiyong Park309668e2018-07-28 16:55:44 +09001854
Devin Moore097a3ab2020-03-11 16:08:44 -07001855TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1856 // boolean getInterfaceVersion() is not a meta transaction, but should be
1857 // prevented because return type is not part of a method signature
1858 const string expected_stderr =
1859 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1860 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001861 io_delegate_.SetFileContents(options.InputFiles().front(),
1862 "package p; interface IFoo {"
1863 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001864 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001865 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001866 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1867}
Jiyong Park309668e2018-07-28 16:55:44 +09001868
Devin Moore097a3ab2020-03-11 16:08:44 -07001869TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001870 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001871 const string expected_stderr =
1872 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1873 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001874 io_delegate_.SetFileContents(options.InputFiles().front(),
1875 "package p; interface IFoo {"
1876 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001877 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001878 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001880
1881 // this is not a meta interface method as it differs type arguments
1882 io_delegate_.SetFileContents(options.InputFiles().front(),
1883 "package p; interface IFoo {"
1884 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001885 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001886}
1887
Daniel Norman85aed542019-08-21 12:01:14 -07001888TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001889 Options options = Options::From("aidl --checkapi old new");
1890 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1891 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1892 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1893 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1894
1895 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1896}
1897
Jiyong Park3656c3c2018-08-01 20:02:01 +09001898TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001899 Options options = Options::From("aidl --checkapi old new");
1900 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1901 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001902
1903 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1904}
1905
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001906TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1907 Options options = Options::From("aidl --checkapi old new");
1908 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1909 const string enum_definition = "package p; enum Enum { FOO }";
1910 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1911 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1912 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1913 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1914
1915 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1916}
1917
Daniel Norman85aed542019-08-21 12:01:14 -07001918class AidlTestCompatibleChanges : public AidlTest {
1919 protected:
1920 Options options_ = Options::From("aidl --checkapi old new");
1921};
1922
1923TEST_F(AidlTestCompatibleChanges, NewType) {
1924 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1925 "package p;"
1926 "interface IFoo {"
1927 " void foo(int a);"
1928 "}");
1929 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1930 "package p;"
1931 "interface IFoo {"
1932 " void foo(int a);"
1933 "}");
1934 io_delegate_.SetFileContents("new/p/IBar.aidl",
1935 "package p;"
1936 "interface IBar {"
1937 " void bar();"
1938 "}");
1939 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1940}
1941
1942TEST_F(AidlTestCompatibleChanges, NewMethod) {
1943 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1944 "package p;"
1945 "interface IFoo {"
1946 " void foo(int a);"
1947 "}");
1948 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1949 "package p;"
1950 "interface IFoo {"
1951 " void foo(int a);"
1952 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001953 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001954 "}");
1955 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1956}
1957
1958TEST_F(AidlTestCompatibleChanges, NewField) {
1959 io_delegate_.SetFileContents("old/p/Data.aidl",
1960 "package p;"
1961 "parcelable Data {"
1962 " int foo;"
1963 "}");
1964 io_delegate_.SetFileContents("new/p/Data.aidl",
1965 "package p;"
1966 "parcelable Data {"
1967 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001968 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001969 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001970 "}");
1971 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1972}
1973
1974TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1975 io_delegate_.SetFileContents("old/p/Enum.aidl",
1976 "package p;"
1977 "enum Enum {"
1978 " FOO = 1,"
1979 "}");
1980 io_delegate_.SetFileContents("new/p/Enum.aidl",
1981 "package p;"
1982 "enum Enum {"
1983 " FOO = 1,"
1984 " BAR = 2,"
1985 "}");
1986 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1987}
1988
1989TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1990 io_delegate_.SetFileContents("old/p/Enum.aidl",
1991 "package p;"
1992 "enum Enum {"
1993 " FOO = 1,"
1994 " BAR = 2,"
1995 "}");
1996 io_delegate_.SetFileContents("new/p/Enum.aidl",
1997 "package p;"
1998 "enum Enum {"
1999 " BAR = 2,"
2000 " FOO = 1,"
2001 "}");
2002 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2003}
2004
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002005TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2006 io_delegate_.SetFileContents("old/p/Union.aidl",
2007 "package p;"
2008 "union Union {"
2009 " String foo;"
2010 "}");
2011 io_delegate_.SetFileContents("new/p/Union.aidl",
2012 "package p;"
2013 "union Union {"
2014 " String foo;"
2015 " int num;"
2016 "}");
2017 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2018}
2019
Daniel Norman85aed542019-08-21 12:01:14 -07002020TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002021 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2022 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002023 "interface IFoo {"
2024 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002025 "}");
2026 io_delegate_.SetFileContents("old/p/Data.aidl",
2027 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002028 "parcelable Data {"
2029 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002030 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002031 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2032 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002033 "interface IFoo {"
2034 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002035 "}");
2036 io_delegate_.SetFileContents("new/p/Data.aidl",
2037 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002038 "parcelable Data {"
2039 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002040 "}");
2041 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2042 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002043 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002044 " void foo(int a);"
2045 "}");
2046 io_delegate_.SetFileContents("new/q/Data.aidl",
2047 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002048 "parcelable Data {"
2049 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002050 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002051 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2052}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002053
Daniel Norman85aed542019-08-21 12:01:14 -07002054TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2055 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2056 "package p;"
2057 "interface IFoo {"
2058 " void foo(int a);"
2059 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002060 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2061 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002062 "interface IFoo {"
2063 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002064 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002065 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2066}
Jiyong Parke59c3682018-09-11 23:10:25 +09002067
Daniel Norman85aed542019-08-21 12:01:14 -07002068TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002069 io_delegate_.SetFileContents("old/p/I.aidl",
2070 "package p; interface I {"
2071 "const int A = 1; }");
2072 io_delegate_.SetFileContents("new/p/I.aidl",
2073 "package p ; interface I {"
2074 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002075 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2076}
Jiyong Parka428d212018-08-29 22:26:30 +09002077
Daniel Norman85aed542019-08-21 12:01:14 -07002078TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002079 io_delegate_.SetFileContents("old/p/I.aidl",
2080 "package p; interface I {"
2081 "const int A = 1; const int B = 2;}");
2082 io_delegate_.SetFileContents("new/p/I.aidl",
2083 "package p ; interface I {"
2084 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002085 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002086}
2087
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002088TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2089 io_delegate_.SetFileContents("old/p/Foo.aidl",
2090 "package p;"
2091 "@JavaPassthrough(annotation=\"Alice\")"
2092 "@JavaPassthrough(annotation=\"Bob\")"
2093 "parcelable Foo {}");
2094 io_delegate_.SetFileContents("new/p/Foo.aidl",
2095 "package p;"
2096 "@JavaPassthrough(annotation=\"Bob\")"
2097 "@JavaPassthrough(annotation=\"Alice\")"
2098 "parcelable Foo {}");
2099 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2100}
2101
Jooyung Han00073272020-11-27 14:20:20 +09002102TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2103 io_delegate_.SetFileContents("old/p/Foo.aidl",
2104 "package p;"
2105 "parcelable Foo {}");
2106 io_delegate_.SetFileContents("new/p/Foo.aidl",
2107 "package p;"
2108 "@JavaPassthrough(annotation=\"@Deprecated\")"
2109 "parcelable Foo {}");
2110 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2111}
2112
Jooyung Han636fd2f2020-10-22 11:33:45 +09002113TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2114 io_delegate_.SetFileContents("old/p/Data.aidl",
2115 "package p;"
2116 "parcelable Data {"
2117 " int num;"
2118 "}");
2119 io_delegate_.SetFileContents(
2120 "new/p/Data.aidl",
2121 "package p;"
2122 "parcelable Data {"
2123 " int num;"
2124 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2125 "}");
2126 io_delegate_.SetFileContents("new/p/Enum.aidl",
2127 "package p;"
2128 "enum Enum {"
2129 " FOO = 0,"
2130 " BAR = 1,"
2131 "}");
2132 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2133}
2134
Daniel Norman85aed542019-08-21 12:01:14 -07002135class AidlTestIncompatibleChanges : public AidlTest {
2136 protected:
2137 Options options_ = Options::From("aidl --checkapi old new");
2138};
2139
2140TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002141 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002142 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2143 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002144 "interface IFoo {"
2145 " void foo(in String[] str);"
2146 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002147 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002148 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002149 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002150 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002151}
2152
2153TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002154 const string expected_stderr =
2155 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002156 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2157 "package p;"
2158 "interface IFoo {"
2159 " void foo(in String[] str);"
2160 " void bar(@utf8InCpp String str);"
2161 "}");
2162 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2163 "package p;"
2164 "interface IFoo {"
2165 " void foo(in String[] str);"
2166 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002167 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002168 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002170}
2171
Jiyong Parkf8d53612020-05-04 14:06:13 +09002172TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2173 const string expected_stderr =
2174 "ERROR: new/p/IFoo.aidl:1.61-65: "
2175 "Encountered an untyped List or Map. The use of untyped List/Map is "
2176 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2177 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2178 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2179 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2180 "package p;"
2181 "interface IFoo {"
2182 " void foo(in String[] str);"
2183 "}");
2184 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2185 "package p;"
2186 "interface IFoo {"
2187 " void foo(in String[] str);"
2188 " void bar(in List arg);"
2189 "}");
2190 CaptureStderr();
2191 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2193}
2194
2195TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2196 const string expected_stderr =
2197 "ERROR: new/p/Data.aidl:1.54-59: "
2198 "Encountered an untyped List or Map. The use of untyped List/Map is "
2199 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2200 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2201 "ERROR: new/p/Data.aidl: Failed to read.\n";
2202 io_delegate_.SetFileContents("old/p/Data.aidl",
2203 "package p;"
2204 "parcelable Data {"
2205 " int foo;"
2206 "}");
2207 io_delegate_.SetFileContents("new/p/Data.aidl",
2208 "package p;"
2209 "parcelable Data {"
2210 " int foo;"
2211 " @nullable List list;"
2212 "}");
2213 CaptureStderr();
2214 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2216}
2217
Daniel Norman85aed542019-08-21 12:01:14 -07002218TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002219 const string expected_stderr =
2220 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002221 io_delegate_.SetFileContents("old/p/Data.aidl",
2222 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002223 "parcelable Data {"
2224 " int foo;"
2225 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002226 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002227 io_delegate_.SetFileContents("new/p/Data.aidl",
2228 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002229 "parcelable Data {"
2230 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002231 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002233 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002235}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002236
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002237TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2238 const string expected_stderr =
2239 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2240 "backends. Please either provide a default value for this field or mark the field as "
2241 "@nullable. This value or a null value will be used automatically when an old version of "
2242 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2243 "order to make sure your code continues to be backwards compatible, make sure the default or "
2244 "null value does not cause a semantic change to this parcelable.\n";
2245 io_delegate_.SetFileContents("old/p/Data.aidl",
2246 "package p;"
2247 "parcelable Data {"
2248 " int num;"
2249 "}");
2250 io_delegate_.SetFileContents("new/p/Data.aidl",
2251 "package p;"
2252 "parcelable Data {"
2253 " int num;"
2254 " String str;"
2255 "}");
2256 CaptureStderr();
2257 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2258 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2259}
2260
Jooyung Han636fd2f2020-10-22 11:33:45 +09002261TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2262 const string expected_stderr =
2263 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2264 "Please make sure 'Enum' has '0' as a valid value.\n";
2265 io_delegate_.SetFileContents("old/p/Data.aidl",
2266 "package p;"
2267 "parcelable Data {"
2268 " int num;"
2269 "}");
2270 io_delegate_.SetFileContents("new/p/Data.aidl",
2271 "package p;"
2272 "parcelable Data {"
2273 " int num;"
2274 " p.Enum e;"
2275 "}");
2276 io_delegate_.SetFileContents("new/p/Enum.aidl",
2277 "package p;"
2278 "enum Enum {"
2279 " FOO = 1,"
2280 " BAR = 2,"
2281 "}");
2282 CaptureStderr();
2283 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2285}
2286
Daniel Norman85aed542019-08-21 12:01:14 -07002287TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002288 const string expected_stderr =
2289 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002290 io_delegate_.SetFileContents("old/p/Enum.aidl",
2291 "package p;"
2292 "enum Enum {"
2293 " FOO = 1,"
2294 " BAR = 2,"
2295 "}");
2296 io_delegate_.SetFileContents("new/p/Enum.aidl",
2297 "package p;"
2298 "enum Enum {"
2299 " BAR = 2,"
2300 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002301 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002302 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002304}
2305
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002306TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2307 const string expected_stderr =
2308 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2309 io_delegate_.SetFileContents("old/p/Union.aidl",
2310 "package p;"
2311 "union Union {"
2312 " String str;"
2313 " int num;"
2314 "}");
2315 io_delegate_.SetFileContents("new/p/Union.aidl",
2316 "package p;"
2317 "union Union {"
2318 " String str;"
2319 "}");
2320 CaptureStderr();
2321 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2323}
2324
Daniel Norman85aed542019-08-21 12:01:14 -07002325TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002326 const string expected_stderr =
2327 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002328 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2329 "package p;"
2330 "interface IFoo {"
2331 " void foo(in String[] str);"
2332 " void bar(@utf8InCpp String str);"
2333 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002334 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2335 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002336 "interface IFoo {"
2337 " void foo(in String[] str);"
2338 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002339 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002341 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002342 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002343}
2344
Daniel Norman85aed542019-08-21 12:01:14 -07002345TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002346 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002347 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2348 "package p;"
2349 "interface IFoo {"
2350 " void foo(in String[] str);"
2351 " void bar(@utf8InCpp String str);"
2352 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002353 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2354 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002355 "interface IFoo2 {"
2356 " void foo(in String[] str);"
2357 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002358 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002360 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002361 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002362}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002363
Daniel Norman85aed542019-08-21 12:01:14 -07002364TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002365 const string expected_stderr =
2366 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002367 io_delegate_.SetFileContents("old/p/Enum.aidl",
2368 "package p;"
2369 "enum Enum {"
2370 " FOO = 1,"
2371 " BAR = 2,"
2372 "}");
2373 io_delegate_.SetFileContents("new/p/Enum.aidl",
2374 "package p;"
2375 "enum Enum {"
2376 " FOO = 3,"
2377 " BAR = 2,"
2378 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002380 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002382}
2383
2384TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002385 const string expected_stderr =
2386 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2387 "from 0 to 1.\n"
2388 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2389 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002390 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2391 "package p;"
2392 "interface IFoo {"
2393 " void foo(in String[] str);"
2394 " void bar(@utf8InCpp String str);"
2395 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002396 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2397 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002398 "interface IFoo {"
2399 " void bar(@utf8InCpp String str);"
2400 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002401 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002402 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002403 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002404 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002405}
2406
2407TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002408 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002409 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2410 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002411 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002412 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002413 "parcelable Data {"
2414 " int foo;"
2415 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002416 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002417 io_delegate_.SetFileContents("new/p/Data.aidl",
2418 "package p;"
2419 "parcelable Data {"
2420 " int bar;"
2421 " int foo;"
2422 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002424 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002425 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002426}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002427
Daniel Norman85aed542019-08-21 12:01:14 -07002428TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002429 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002430 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002431 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002432 "interface IFoo {"
2433 " void foo(in String[] str);"
2434 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002435 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002436 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2437 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002438 "interface IFoo {"
2439 " void foo(out String[] str);"
2440 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002441 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002442 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002443 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002444 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002445}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002446
Daniel Norman85aed542019-08-21 12:01:14 -07002447TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002448 const string expected_stderr =
2449 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002450 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2451 "package p;"
2452 "interface IFoo {"
2453 " void foo(in String[] str);"
2454 " void bar(@utf8InCpp String str);"
2455 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002456 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2457 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002458 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002459 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002460 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002461 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002462 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002463 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002464 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002465}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002466
Daniel Norman85aed542019-08-21 12:01:14 -07002467TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002468 const string expected_stderr =
2469 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002470 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2471 "package p;"
2472 "interface IFoo {"
2473 " void foo(in String[] str);"
2474 " void bar(@utf8InCpp String str);"
2475 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002476 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2477 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002478 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002479 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002480 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002481 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002483 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002485}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002486
Jooyung Han60b2fde2020-10-29 15:12:40 +09002487TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2488 const string expected_stderr =
2489 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2490 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2491 io_delegate_.SetFileContents("old/p/Foo.aidl",
2492 "package p;"
2493 "@Backing(type=\"byte\")"
2494 "enum Foo {"
2495 " FOO, BAR,"
2496 "}");
2497 io_delegate_.SetFileContents("new/p/Foo.aidl",
2498 "package p;"
2499 "@Backing(type=\"long\")"
2500 "enum Foo {"
2501 " FOO, BAR,"
2502 "}");
2503 CaptureStderr();
2504 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2505 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2506}
2507
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002508TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2509 const string expected_stderr =
2510 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2511 "to @JavaPassthrough(annotation=\"Bob\")\n";
2512 io_delegate_.SetFileContents("old/p/Foo.aidl",
2513 "package p;"
2514 "@JavaPassthrough(annotation=\"Alice\")"
2515 "parcelable Foo {}");
2516 io_delegate_.SetFileContents("new/p/Foo.aidl",
2517 "package p;"
2518 "@JavaPassthrough(annotation=\"Bob\")"
2519 "parcelable Foo {}");
2520
2521 CaptureStderr();
2522 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2523 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2524}
2525
Devin Mooredb7ac512020-08-07 11:17:36 -07002526TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2527 const string expected_stderr =
2528 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2529 io_delegate_.SetFileContents("old/p/Foo.aidl",
2530 "package p;"
2531 "parcelable Foo {"
2532 " int A;"
2533 "}");
2534 io_delegate_.SetFileContents("new/p/Foo.aidl",
2535 "package p;"
2536 "@JavaOnlyStableParcelable parcelable Foo {"
2537 " int A;"
2538 "}");
2539 CaptureStderr();
2540 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2541 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2542}
2543
2544TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2545 const string expected_stderr =
2546 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2547 io_delegate_.SetFileContents("old/p/Foo.aidl",
2548 "package p;"
2549 "@JavaOnlyStableParcelable parcelable Foo {"
2550 " int A;"
2551 "}");
2552 io_delegate_.SetFileContents("new/p/Foo.aidl",
2553 "package p;"
2554 "parcelable Foo {"
2555 " int A;"
2556 "}");
2557 CaptureStderr();
2558 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2559 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2560}
2561
Daniel Norman85aed542019-08-21 12:01:14 -07002562TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002563 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002564 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2565 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002566 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002568 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002569 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002570}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002571
Daniel Norman85aed542019-08-21 12:01:14 -07002572TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002573 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002574 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2575 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002576 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002577 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002578 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002579}
Jiyong Parka428d212018-08-29 22:26:30 +09002580
Daniel Norman85aed542019-08-21 12:01:14 -07002581TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002582 const string expected_stderr =
2583 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002584 io_delegate_.SetFileContents("old/p/I.aidl",
2585 "package p; interface I {"
2586 "const int A = 1; const int B = 2;}");
2587 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002588 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002589 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002591}
Jiyong Parka428d212018-08-29 22:26:30 +09002592
Daniel Norman85aed542019-08-21 12:01:14 -07002593TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002594 const string expected_stderr =
2595 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002596 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2597 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002598 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002599 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002600 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002601}
2602
Devin Moorec7e47a32020-08-07 10:55:25 -07002603TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2604 const string expected_stderr =
2605 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2606 "This is an incompatible change for FixedSize types.\n";
2607 io_delegate_.SetFileContents("old/p/Foo.aidl",
2608 "package p; @FixedSize parcelable Foo { int A = 1; }");
2609 io_delegate_.SetFileContents("new/p/Foo.aidl",
2610 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2611 CaptureStderr();
2612 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2614}
2615
2616TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2617 const string expected_stderr =
2618 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2619 io_delegate_.SetFileContents("old/p/Foo.aidl",
2620 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2621 io_delegate_.SetFileContents("new/p/Foo.aidl",
2622 "package p; @FixedSize parcelable Foo { int A = 1; }");
2623 CaptureStderr();
2624 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2625 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2626}
2627
2628TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2629 const string expected_stderr =
2630 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2631 "a.\n"
2632 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2633 "b.\n"
2634 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2635 "c.\n"
2636 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2637 "d.\n"
2638 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2639 "e.\n"
2640 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2641 "f.\n";
2642
2643 io_delegate_.SetFileContents("Foo.aidl",
2644 "@FixedSize parcelable Foo { "
2645 " int[] a;"
2646 " Bar b;"
2647 " String c;"
2648 " ParcelFileDescriptor d;"
2649 " IBinder e;"
2650 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002651 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002652 "}");
2653 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2654 Options options =
2655 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2656
2657 CaptureStderr();
2658 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2659 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2660}
2661
2662TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2663 const string expected_stderr = "";
2664
2665 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2666 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2667 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2668 Options options =
2669 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2670
2671 CaptureStderr();
2672 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2673 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2674}
2675
Jiyong Park8c380532018-08-30 14:55:26 +09002676TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002677 const string expected_stderr =
2678 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2679 "dir1/q/IBar.aidl\n"
2680 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002681 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002682 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2683 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2684 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2685 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2686
Devin Moore097a3ab2020-03-11 16:08:44 -07002687 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002688 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002689 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002690}
2691
Jiyong Parked65bf42018-08-28 15:43:27 +09002692TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002693 const string expected_stderr =
2694 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2695 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002696 Options options = Options::From("aidl --checkapi old new");
2697 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2698 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002699
2700 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2701
Jiyong Parke59c3682018-09-11 23:10:25 +09002702 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002703 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002704 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002705 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002706}
2707
Jiyong Parke05195e2018-10-08 18:24:23 +09002708TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2709 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2710 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002711 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002712
2713 // use without import
2714 io_delegate_.SetFileContents("p/IFoo.aidl",
2715 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2716 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2717 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002718 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002719
Devin Moore7b8d5c92020-03-17 14:14:08 -07002720 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002721 io_delegate_.SetFileContents(
2722 "p/IFoo.aidl",
2723 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2724 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2725 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002726 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002727
2728 // use with import (as before)
2729 io_delegate_.SetFileContents("p/IFoo.aidl",
2730 "package p;"
2731 "import android.os.ParcelFileDescriptor;"
2732 "interface IFoo{"
2733 " void foo(in ParcelFileDescriptor fd);"
2734 "}");
2735 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2736 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002737 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002738}
Jiyong Parked65bf42018-08-28 15:43:27 +09002739
Jiyong Park3633b722019-04-11 15:38:26 +09002740TEST_F(AidlTest, ManualIds) {
2741 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2742 io_delegate_.SetFileContents("IFoo.aidl",
2743 "interface IFoo {\n"
2744 " void foo() = 0;\n"
2745 " void bar() = 1;\n"
2746 "}");
2747 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2748}
2749
2750TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2751 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2752 io_delegate_.SetFileContents("IFoo.aidl",
2753 "interface IFoo {\n"
2754 " void foo() = 0;\n"
2755 " void bar() = 1;\n"
2756 "}");
2757 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2758}
2759
2760TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 const string expected_stderr =
2762 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002763 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2764 io_delegate_.SetFileContents("IFoo.aidl",
2765 "interface IFoo {\n"
2766 " void foo() = 3;\n"
2767 " void bar() = 3;\n"
2768 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002769 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002770 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002771 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002772}
2773
2774TEST_F(AidlTest, FailOnOutOfRangeIds) {
2775 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002776 const string expected_stderr =
2777 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2778 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002779 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2780 io_delegate_.SetFileContents("IFoo.aidl",
2781 "interface IFoo {\n"
2782 " void foo() = 3;\n"
2783 " void bar() = 16777115;\n"
2784 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002785 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002786 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002787 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002788}
2789
2790TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002791 const string expected_stderr =
2792 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002793 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2794 io_delegate_.SetFileContents("IFoo.aidl",
2795 "interface IFoo {\n"
2796 " void foo() = 3;\n"
2797 " void bar();\n"
2798 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002799 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002800 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002801 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002802}
2803
Jiyong Parkc6816252019-07-08 08:12:28 +09002804TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2805 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2806 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2807 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2808 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2809}
2810
2811TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002812 const string expected_stderr =
2813 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2814 "dir/IBar.aidl\n"
2815 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002816 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002817
Jiyong Parkc6816252019-07-08 08:12:28 +09002818 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2819 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2820 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2821 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002822 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002823 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002824 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002825}
2826
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002827TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2828 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2829 "package a.b;\n"
2830 "import a.b.IBar;\n"
2831 "import a.b.IQux;\n"
2832 "interface IFoo { IQux foo(); }\n");
2833 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2834 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2835
2836 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2837 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2838
2839 string output;
2840 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2841 // IBar was imported but wasn't used. include is not expected.
2842 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2843 // IBar was imported and used. include is expected.
2844 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2845}
2846
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002847TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002848 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002849 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002850 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2851 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002852 interface IFoo {
2853 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002854 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002855 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002856 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002857 // JavaPassthrough should work with other types as well (e.g. enum)
2858 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2859 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2860 @JavaPassthrough(annotation="@com.android.AliceTwo")
2861 @Backing(type="byte")
2862 enum MyEnum {
2863 a, b, c
2864 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002865
Jooyung Han4cde01d2020-10-13 11:10:47 +09002866 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002867 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2868
2869 string java_out;
2870 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002871 // type-decl-level annotations with newline at the end
2872 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2873 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2874 // member-decl-level annotations with newline at the end
2875 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2876 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2877 // inline annotations with space at the end
2878 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002879
Jooyung Han4cde01d2020-10-13 11:10:47 +09002880 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2881 // type-decl-level annotations with newline at the end
2882 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2883 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2884
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002885 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002886 Options cpp_options =
2887 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002888 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2889
Jooyung Han4cde01d2020-10-13 11:10:47 +09002890 Options ndk_options =
2891 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002892 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002893
Jooyung Han4cde01d2020-10-13 11:10:47 +09002894 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002895 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002896}
2897
Andrei Homescue61feb52020-08-18 15:44:24 -07002898TEST_F(AidlTest, ParseRustDerive) {
2899 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2900 @RustDerive(Clone=true, Copy=false)
2901 parcelable Foo {
2902 int a;
2903 })");
2904
2905 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2906 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2907
2908 string rust_out;
2909 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2910 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2911
2912 // Other backends shouldn't be bothered
2913 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2914 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2915
2916 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2917 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2918
2919 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2920 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2921}
2922
Jiyong Park56f73d72019-06-11 12:20:28 +09002923class AidlOutputPathTest : public AidlTest {
2924 protected:
2925 void SetUp() override {
2926 AidlTest::SetUp();
2927 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2928 }
2929
2930 void Test(const Options& options, const std::string expected_output_path) {
2931 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2932 // check the existence
2933 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2934 }
2935};
2936
2937TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2938 // <out_dir> / <package_name> / <type_name>.java
2939 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2940}
2941
2942TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2943 // when output file is explicitly set, it is always respected. -o option is
2944 // ignored.
2945 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2946}
2947
2948TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2949 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2950}
2951
2952TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2953 // output is the same as the input file except for the suffix
2954 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2955}
2956
Devin Moore7b8d5c92020-03-17 14:14:08 -07002957TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002958 AidlError error;
2959 const string expected_stderr =
2960 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2961 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002962 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2963 R"(package p;
2964 interface IFoo {
2965 const int int32_max_oob = 2147483650;
2966 }
2967 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002968 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002969 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2970 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002971}
2972
Devin Moore7b8d5c92020-03-17 14:14:08 -07002973TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002974 AidlError error;
2975 const string expected_stderr =
2976 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2977 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002978 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2979 R"(package p;
2980 interface IFoo {
2981 const int int32_min_oob = -2147483650;
2982 }
2983 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002984 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2986 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002987}
2988
Devin Moore7b8d5c92020-03-17 14:14:08 -07002989TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002990 AidlError error;
2991 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002992 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002994 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2995 R"(package p;
2996 interface IFoo {
2997 const long int64_max_oob = 21474836509999999999999999;
2998 }
2999 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003000 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003001 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3002 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003003}
3004
Devin Moore7b8d5c92020-03-17 14:14:08 -07003005TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003006 AidlError error;
3007 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003008 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003010 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3011 R"(package p;
3012 interface IFoo {
3013 const long int64_min_oob = -21474836509999999999999999;
3014 }
3015 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003016 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003017 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3018 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003019}
3020
Devin Moore7b8d5c92020-03-17 14:14:08 -07003021TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003022 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003023 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003024 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003025 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3026 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003027 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3028 R"(package p;
3029 @Backing(type="byte")
3030 enum TestEnum {
3031 FOO = 127,
3032 BAR,
3033 }
3034 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003035 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003037 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003038}
3039
Devin Mooredecaf292020-04-30 09:16:40 -07003040TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3041 AidlError error;
3042 const string expected_stderr =
3043 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003044 "be one of: type\n";
3045 CaptureStderr();
3046 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3047 R"(package p;
3048 @Backing(foo="byte")
3049 enum TestEnum {
3050 FOO = 1,
3051 BAR,
3052 }
3053 )",
3054 typenames_, GetLanguage(), &error));
3055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3056 EXPECT_EQ(AidlError::BAD_TYPE, error);
3057}
3058
Jooyung Han5721a232020-12-24 04:34:55 +09003059TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3060 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3061 CaptureStderr();
3062 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3063 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3064}
3065
Jooyung Han66813932020-10-23 13:24:44 +09003066TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003067 io_delegate_.SetFileContents("Foo.aidl",
3068 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3069 "Map<String, Baz> d; Bar[] e; }");
3070 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3071 io_delegate_.SetFileContents("Baz.aidl",
3072 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003073 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3074 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3075}
3076
Jooyung Han66813932020-10-23 13:24:44 +09003077TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003078 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003079 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003080 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003081 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3082 "named 'bar'.\n";
3083 CaptureStderr();
3084 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3085 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3086 EXPECT_EQ(expected_error, GetCapturedStderr());
3087}
3088
3089TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3090 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3091 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3092 string expected_error =
3093 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003094 "named 'bar'.\n";
3095 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003096 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3097 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003098 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003099}
3100
Jooyung Han66813932020-10-23 13:24:44 +09003101TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003102 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003103 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3104 string expected_error =
3105 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3106 "only be an in parameter.\n";
3107 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003108 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3109 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003110 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003111}
3112
Jooyung Han66813932020-10-23 13:24:44 +09003113TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003114 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003115 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3116 string expected_error =
3117 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3118 "only be an in parameter.\n";
3119 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003120 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3121 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003122 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003123}
3124
Jooyung Han66813932020-10-23 13:24:44 +09003125TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003126 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003127 Options options = Options::From("aidl --lang=java Foo.aidl");
3128 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003129 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3130 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003131 CaptureStderr();
3132 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3134}
Devin Moore53fc99c2020-08-12 08:07:52 -07003135
Jooyung Han1f14ab32020-10-14 13:48:29 +09003136const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3137
3138#include <a/ByteEnum.h>
3139#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003140#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003141#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003142#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003143#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003144#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003145#include <locale>
3146#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003147#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003148#include <utility>
3149#include <variant>
3150#include <vector>
3151
Jooyung Handf39e192020-11-23 15:59:46 +09003152#ifndef __BIONIC__
3153#define __assert2(a,b,c,d) ((void)0)
3154#endif
3155
Jooyung Han1f14ab32020-10-14 13:48:29 +09003156namespace a {
3157
3158class Foo : public ::android::Parcelable {
3159public:
Jooyung Han97945de2020-10-15 16:41:38 +09003160 inline bool operator!=(const Foo& rhs) const {
3161 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003162 }
Jooyung Han97945de2020-10-15 16:41:38 +09003163 inline bool operator<(const Foo& rhs) const {
3164 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003165 }
Jooyung Han97945de2020-10-15 16:41:38 +09003166 inline bool operator<=(const Foo& rhs) const {
3167 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003168 }
Jooyung Han97945de2020-10-15 16:41:38 +09003169 inline bool operator==(const Foo& rhs) const {
3170 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003171 }
Jooyung Han97945de2020-10-15 16:41:38 +09003172 inline bool operator>(const Foo& rhs) const {
3173 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003174 }
Jooyung Han97945de2020-10-15 16:41:38 +09003175 inline bool operator>=(const Foo& rhs) const {
3176 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003177 }
Jooyung Han97945de2020-10-15 16:41:38 +09003178
Jooyung Han1f14ab32020-10-14 13:48:29 +09003179 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003180 ns = 0, // int[] ns;
3181 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003182 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003183 };
Jooyung Han97945de2020-10-15 16:41:38 +09003184
Jooyung Han1f14ab32020-10-14 13:48:29 +09003185 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003186 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187
3188 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003189 Foo(const Foo&) = default;
3190 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003191 Foo& operator=(const Foo&) = default;
3192 Foo& operator=(Foo&&) = default;
3193
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003194 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3195 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003196 constexpr Foo(_Tp&& _arg)
3197 : _value(std::forward<_Tp>(_arg)) {}
3198
3199 template <typename... _Tp>
3200 constexpr explicit Foo(_Tp&&... _args)
3201 : _value(std::forward<_Tp>(_args)...) {}
3202
3203 template <Tag _tag, typename... _Tp>
3204 static Foo make(_Tp&&... _args) {
3205 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003206 }
Jooyung Han97945de2020-10-15 16:41:38 +09003207
3208 template <Tag _tag, typename _Tp, typename... _Up>
3209 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3210 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003211 }
3212
3213 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003214 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003215 }
3216
Jooyung Han97945de2020-10-15 16:41:38 +09003217 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003218 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003219 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003220 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003221 }
3222
Jooyung Han97945de2020-10-15 16:41:38 +09003223 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003224 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003225 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003226 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003227 }
3228
Jooyung Han97945de2020-10-15 16:41:38 +09003229 template <Tag _tag, typename... _Tp>
3230 void set(_Tp&&... _args) {
3231 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003232 }
3233
3234 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3235 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3236 static const std::string& getParcelableDescriptor() {
3237 static const std::string DESCIPTOR = "a.Foo";
3238 return DESCIPTOR;
3239 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003240 template <typename _T> class _has_toString {
3241 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3242 template <typename _U> static std::false_type __has_toString(...);
3243 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3244 };
3245 template <typename _T> inline static std::string _call_toString(const _T& t) {
3246 if constexpr (_has_toString<_T>::value) return t.toString();
3247 return "{no toString() implemented}";
3248 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003249 inline std::string toString() const {
3250 std::ostringstream os;
3251 os << "Foo{";
3252 switch (getTag()) {
3253 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3254 case e: os << "e: " << a::toString(get<e>()); break;
3255 case pfd: os << "pfd: " << ""; break;
3256 }
3257 os << "}";
3258 return os.str();
3259 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003260private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003261 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003262}; // class Foo
3263
3264} // namespace a
3265)";
3266
3267const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3268
3269namespace a {
3270
3271::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3272 ::android::status_t _aidl_ret_status;
3273 int32_t _aidl_tag;
3274 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3275 switch (_aidl_tag) {
3276 case ns: {
3277 ::std::vector<int32_t> _aidl_value;
3278 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003279 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3280 set<ns>(_aidl_value);
3281 } else {
3282 // NOLINTNEXTLINE(performance-move-const-arg)
3283 set<ns>(std::move(_aidl_value));
3284 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003285 return ::android::OK; }
3286 case e: {
3287 ::a::ByteEnum _aidl_value;
3288 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003289 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3290 set<e>(_aidl_value);
3291 } else {
3292 // NOLINTNEXTLINE(performance-move-const-arg)
3293 set<e>(std::move(_aidl_value));
3294 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003295 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003296 case pfd: {
3297 ::android::os::ParcelFileDescriptor _aidl_value;
3298 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003299 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3300 set<pfd>(_aidl_value);
3301 } else {
3302 // NOLINTNEXTLINE(performance-move-const-arg)
3303 set<pfd>(std::move(_aidl_value));
3304 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003305 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003306 }
3307 return ::android::BAD_VALUE;
3308}
3309
3310::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3311 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3312 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3313 switch (getTag()) {
3314 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3315 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003316 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003317 }
Jooyung Handf39e192020-11-23 15:59:46 +09003318 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003319}
3320
3321} // namespace a
3322)";
3323
Jooyung Han6beac042020-10-17 21:59:43 +09003324const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3325#include <android/binder_interface_utils.h>
3326#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003327#include <codecvt>
3328#include <locale>
3329#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003330
Jooyung Handf39e192020-11-23 15:59:46 +09003331#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003332#include <type_traits>
3333#include <utility>
3334#include <variant>
3335#include <cstdint>
3336#include <memory>
3337#include <optional>
3338#include <string>
3339#include <vector>
3340#ifdef BINDER_STABILITY_SUPPORT
3341#include <android/binder_stability.h>
3342#endif // BINDER_STABILITY_SUPPORT
3343#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003344
3345#ifndef __BIONIC__
3346#define __assert2(a,b,c,d) ((void)0)
3347#endif
3348
Jooyung Han6beac042020-10-17 21:59:43 +09003349namespace aidl {
3350namespace a {
3351class Foo {
3352public:
3353 typedef std::false_type fixed_size;
3354 static const char* descriptor;
3355
3356 enum Tag : int32_t {
3357 ns = 0, // int[] ns;
3358 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003359 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003360 };
3361
3362 template<typename _Tp>
3363 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3364
3365 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3366 Foo(const Foo&) = default;
3367 Foo(Foo&&) = default;
3368 Foo& operator=(const Foo&) = default;
3369 Foo& operator=(Foo&&) = default;
3370
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003371 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3372 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003373 constexpr Foo(_Tp&& _arg)
3374 : _value(std::forward<_Tp>(_arg)) {}
3375
3376 template <typename... _Tp>
3377 constexpr explicit Foo(_Tp&&... _args)
3378 : _value(std::forward<_Tp>(_args)...) {}
3379
3380 template <Tag _tag, typename... _Tp>
3381 static Foo make(_Tp&&... _args) {
3382 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3383 }
3384
3385 template <Tag _tag, typename _Tp, typename... _Up>
3386 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3387 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3388 }
3389
3390 Tag getTag() const {
3391 return static_cast<Tag>(_value.index());
3392 }
3393
3394 template <Tag _tag>
3395 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003396 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003397 return std::get<_tag>(_value);
3398 }
3399
3400 template <Tag _tag>
3401 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003402 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003403 return std::get<_tag>(_value);
3404 }
3405
3406 template <Tag _tag, typename... _Tp>
3407 void set(_Tp&&... _args) {
3408 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3409 }
3410
3411 binder_status_t readFromParcel(const AParcel* _parcel);
3412 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003413
3414 inline bool operator!=(const Foo& rhs) const {
3415 return _value != rhs._value;
3416 }
3417 inline bool operator<(const Foo& rhs) const {
3418 return _value < rhs._value;
3419 }
3420 inline bool operator<=(const Foo& rhs) const {
3421 return _value <= rhs._value;
3422 }
3423 inline bool operator==(const Foo& rhs) const {
3424 return _value == rhs._value;
3425 }
3426 inline bool operator>(const Foo& rhs) const {
3427 return _value > rhs._value;
3428 }
3429 inline bool operator>=(const Foo& rhs) const {
3430 return _value >= rhs._value;
3431 }
3432
Jooyung Han6beac042020-10-17 21:59:43 +09003433 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003434 template <typename _T> class _has_toString {
3435 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3436 template <typename _U> static std::false_type __has_toString(...);
3437 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3438 };
3439 template <typename _T> inline static std::string _call_toString(const _T& t) {
3440 if constexpr (_has_toString<_T>::value) return t.toString();
3441 return "{no toString() implemented}";
3442 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003443 inline std::string toString() const {
3444 std::ostringstream os;
3445 os << "Foo{";
3446 switch (getTag()) {
3447 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3448 case e: os << "e: " << a::toString(get<e>()); break;
3449 case pfd: os << "pfd: " << ""; break;
3450 }
3451 os << "}";
3452 return os.str();
3453 }
Jooyung Han6beac042020-10-17 21:59:43 +09003454private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003455 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003456};
3457} // namespace a
3458} // namespace aidl
3459)";
3460
3461const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3462
3463#include <android/binder_parcel_utils.h>
3464
3465namespace aidl {
3466namespace a {
3467const char* Foo::descriptor = "a.Foo";
3468
3469binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3470 binder_status_t _aidl_ret_status;
3471 int32_t _aidl_tag;
3472 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3473 switch (_aidl_tag) {
3474 case ns: {
3475 std::vector<int32_t> _aidl_value;
3476 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003477 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3478 set<ns>(_aidl_value);
3479 } else {
3480 // NOLINTNEXTLINE(performance-move-const-arg)
3481 set<ns>(std::move(_aidl_value));
3482 }
Jooyung Han6beac042020-10-17 21:59:43 +09003483 return STATUS_OK; }
3484 case e: {
3485 ::aidl::a::ByteEnum _aidl_value;
3486 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003487 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3488 set<e>(_aidl_value);
3489 } else {
3490 // NOLINTNEXTLINE(performance-move-const-arg)
3491 set<e>(std::move(_aidl_value));
3492 }
Jooyung Han6beac042020-10-17 21:59:43 +09003493 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003494 case pfd: {
3495 ::ndk::ScopedFileDescriptor _aidl_value;
3496 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003497 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3498 set<pfd>(_aidl_value);
3499 } else {
3500 // NOLINTNEXTLINE(performance-move-const-arg)
3501 set<pfd>(std::move(_aidl_value));
3502 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003503 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003504 }
3505 return STATUS_BAD_VALUE;
3506}
3507binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3508 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3509 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3510 switch (getTag()) {
3511 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3512 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003513 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003514 }
Jooyung Handf39e192020-11-23 15:59:46 +09003515 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003516}
3517
3518} // namespace a
3519} // namespace aidl
3520)";
3521
Jooyung Han1f14ab32020-10-14 13:48:29 +09003522const char kUnionExampleExpectedOutputJava[] = R"(/*
3523 * This file is auto-generated. DO NOT MODIFY.
3524 */
3525package a;
3526
3527
3528public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003529 // tags for union fields
3530 public final static int ns = 0; // int[] ns;
3531 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003532 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003533
3534 private int _tag;
3535 private Object _value;
3536
3537 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003538 int[] _value = {42};
3539 this._tag = ns;
3540 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003541 }
Jooyung Han97945de2020-10-15 16:41:38 +09003542
Jooyung Han1f14ab32020-10-14 13:48:29 +09003543 private Foo(android.os.Parcel _aidl_parcel) {
3544 readFromParcel(_aidl_parcel);
3545 }
Jooyung Han97945de2020-10-15 16:41:38 +09003546
Jooyung Hance62f932020-10-25 10:21:49 +09003547 private Foo(int _tag, Object _value) {
3548 this._tag = _tag;
3549 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003550 }
3551
3552 public int getTag() {
3553 return _tag;
3554 }
3555
Jooyung Han97945de2020-10-15 16:41:38 +09003556 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003557
3558 public static Foo ns(int[] _value) {
3559 return new Foo(ns, _value);
3560 }
Jooyung Han97945de2020-10-15 16:41:38 +09003561
Jooyung Han1f14ab32020-10-14 13:48:29 +09003562 public int[] getNs() {
3563 _assertTag(ns);
3564 return (int[]) _value;
3565 }
Jooyung Han97945de2020-10-15 16:41:38 +09003566
Jooyung Han1f14ab32020-10-14 13:48:29 +09003567 public void setNs(int[] _value) {
3568 _set(ns, _value);
3569 }
3570
Jooyung Han97945de2020-10-15 16:41:38 +09003571 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003572
3573 public static Foo e(byte _value) {
3574 return new Foo(e, _value);
3575 }
Jooyung Han97945de2020-10-15 16:41:38 +09003576
Jooyung Han1f14ab32020-10-14 13:48:29 +09003577 public byte getE() {
3578 _assertTag(e);
3579 return (byte) _value;
3580 }
Jooyung Han97945de2020-10-15 16:41:38 +09003581
Jooyung Han1f14ab32020-10-14 13:48:29 +09003582 public void setE(byte _value) {
3583 _set(e, _value);
3584 }
3585
Jooyung Hand2fa0232020-10-19 02:51:41 +09003586 // ParcelFileDescriptor pfd;
3587
3588 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3589 return new Foo(pfd, _value);
3590 }
3591
3592 public android.os.ParcelFileDescriptor getPfd() {
3593 _assertTag(pfd);
3594 return (android.os.ParcelFileDescriptor) _value;
3595 }
3596
3597 public void setPfd(android.os.ParcelFileDescriptor _value) {
3598 _set(pfd, _value);
3599 }
3600
Jooyung Han1f14ab32020-10-14 13:48:29 +09003601 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3602 @Override
3603 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003604 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003605 }
3606 @Override
3607 public Foo[] newArray(int _aidl_size) {
3608 return new Foo[_aidl_size];
3609 }
3610 };
Jooyung Han97945de2020-10-15 16:41:38 +09003611
Jooyung Han1f14ab32020-10-14 13:48:29 +09003612 @Override
3613 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3614 _aidl_parcel.writeInt(_tag);
3615 switch (_tag) {
3616 case ns:
3617 _aidl_parcel.writeIntArray(getNs());
3618 break;
3619 case e:
3620 _aidl_parcel.writeByte(getE());
3621 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003622 case pfd:
3623 if ((getPfd()!=null)) {
3624 _aidl_parcel.writeInt(1);
3625 getPfd().writeToParcel(_aidl_parcel, 0);
3626 }
3627 else {
3628 _aidl_parcel.writeInt(0);
3629 }
3630 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003631 }
3632 }
Jooyung Han97945de2020-10-15 16:41:38 +09003633
Jooyung Han1f14ab32020-10-14 13:48:29 +09003634 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3635 int _aidl_tag;
3636 _aidl_tag = _aidl_parcel.readInt();
3637 switch (_aidl_tag) {
3638 case ns: {
3639 int[] _aidl_value;
3640 _aidl_value = _aidl_parcel.createIntArray();
3641 _set(_aidl_tag, _aidl_value);
3642 return; }
3643 case e: {
3644 byte _aidl_value;
3645 _aidl_value = _aidl_parcel.readByte();
3646 _set(_aidl_tag, _aidl_value);
3647 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003648 case pfd: {
3649 android.os.ParcelFileDescriptor _aidl_value;
3650 if ((0!=_aidl_parcel.readInt())) {
3651 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3652 }
3653 else {
3654 _aidl_value = null;
3655 }
3656 _set(_aidl_tag, _aidl_value);
3657 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003658 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003659 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003660 }
Jooyung Han97945de2020-10-15 16:41:38 +09003661
Jooyung Han1f14ab32020-10-14 13:48:29 +09003662 @Override
3663 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003664 int _mask = 0;
3665 switch (getTag()) {
3666 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003667 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003668 break;
3669 }
3670 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003671 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003672 private int describeContents(Object _v) {
3673 if (_v == null) return 0;
3674 if (_v instanceof android.os.Parcelable) {
3675 return ((android.os.Parcelable) _v).describeContents();
3676 }
3677 return 0;
3678 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003679
3680 private void _assertTag(int tag) {
3681 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003682 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003683 }
3684 }
Jooyung Han97945de2020-10-15 16:41:38 +09003685
Jooyung Han1f14ab32020-10-14 13:48:29 +09003686 private String _tagString(int _tag) {
3687 switch (_tag) {
3688 case ns: return "ns";
3689 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003690 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003691 }
3692 throw new IllegalStateException("unknown field: " + _tag);
3693 }
Jooyung Han97945de2020-10-15 16:41:38 +09003694
Jooyung Hance62f932020-10-25 10:21:49 +09003695 private void _set(int _tag, Object _value) {
3696 this._tag = _tag;
3697 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003698 }
3699}
3700)";
3701
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003702const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3703pub enum Foo {
3704 Ns(Vec<i32>),
3705 E(crate::mangled::_1_a_8_ByteEnum),
3706 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3707}
3708pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3709impl Default for Foo {
3710 fn default() -> Self {
3711 Self::Ns(vec!{42})
3712 }
3713}
3714impl binder::parcel::Serialize for Foo {
3715 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3716 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3717 }
3718}
3719impl binder::parcel::SerializeArray for Foo {}
3720impl binder::parcel::SerializeOption for Foo {
3721 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3722 let this = if let Some(this) = this {
3723 parcel.write(&1i32)?;
3724 this
3725 } else {
3726 return parcel.write(&0i32);
3727 };
3728 match this {
3729 Self::Ns(v) => {
3730 parcel.write(&0i32)?;
3731 parcel.write(v)
3732 }
3733 Self::E(v) => {
3734 parcel.write(&1i32)?;
3735 parcel.write(v)
3736 }
3737 Self::Pfd(v) => {
3738 parcel.write(&2i32)?;
3739 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3740 parcel.write(__field_ref)
3741 }
3742 }
3743 }
3744}
3745impl binder::parcel::Deserialize for Foo {
3746 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3747 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3748 .transpose()
3749 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3750 }
3751}
3752impl binder::parcel::DeserializeArray for Foo {}
3753impl binder::parcel::DeserializeOption for Foo {
3754 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3755 let status: i32 = parcel.read()?;
3756 if status == 0 { return Ok(None); }
3757 let tag: i32 = parcel.read()?;
3758 match tag {
3759 0 => {
3760 let value: Vec<i32> = parcel.read()?;
3761 Ok(Some(Self::Ns(value)))
3762 }
3763 1 => {
3764 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3765 Ok(Some(Self::E(value)))
3766 }
3767 2 => {
3768 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3769 Ok(Some(Self::Pfd(value)))
3770 }
3771 _ => {
3772 Err(binder::StatusCode::BAD_VALUE)
3773 }
3774 }
3775 }
3776}
3777)";
3778
Jooyung Han97945de2020-10-15 16:41:38 +09003779struct AidlUnionTest : ::testing::Test {
3780 void SetUp() override {
3781 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003782package a;
3783import a.ByteEnum;
3784union Foo {
3785 int[] ns = {42};
3786 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003787 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003788}
3789)");
Jooyung Han97945de2020-10-15 16:41:38 +09003790 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003791package a;
3792@Backing(type="byte")
3793enum ByteEnum {
3794 a, b, c
3795}
3796)");
Jooyung Han97945de2020-10-15 16:41:38 +09003797 }
3798 FakeIoDelegate io_delegate_;
3799 void Compile(string lang) {
3800 string command = "aidl --structured -I. -o out --lang=" + lang;
3801 if (lang == "cpp" || lang == "ndk") {
3802 command += " -h out";
3803 }
3804 command += " a/Foo.aidl";
3805 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003806 CaptureStderr();
3807 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3808 auto err = GetCapturedStderr();
3809 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003810 }
3811 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3812 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003813 string actual;
3814 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3815 EXPECT_EQ(expected, actual);
3816 }
Jooyung Han97945de2020-10-15 16:41:38 +09003817 }
3818};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003819
Jooyung Han97945de2020-10-15 16:41:38 +09003820TEST_F(AidlUnionTest, Example_Cpp) {
3821 Compile("cpp");
3822 EXPECT_COMPILE_OUTPUTS(
3823 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3824 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3825}
3826
Jooyung Han6beac042020-10-17 21:59:43 +09003827TEST_F(AidlUnionTest, Example_Ndk) {
3828 Compile("ndk");
3829 EXPECT_COMPILE_OUTPUTS(
3830 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3831 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3832}
3833
Jooyung Han97945de2020-10-15 16:41:38 +09003834TEST_F(AidlUnionTest, Example_Java) {
3835 Compile("java");
3836 EXPECT_COMPILE_OUTPUTS(
3837 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003838}
3839
3840TEST_F(AidlUnionTest, Example_Rust) {
3841 Compile("rust");
3842 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003843}
3844
Jooyung Hanfe89f122020-10-14 03:49:18 +09003845TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3846 const string method = "package a; union Foo {}";
3847 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3848 CaptureStderr();
3849 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3850 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3851}
3852
3853TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3854 const string method = "package a; union Foo { ParcelableHolder x; }";
3855 const string expected_stderr =
3856 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3857 CaptureStderr();
3858 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3859 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3860}
3861
Jooyung Han53fb4242020-12-17 16:03:49 +09003862TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3863 import_paths_.insert(".");
3864 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3865 const string expected_err = "The union's first member should have a useful default value.";
3866 CaptureStderr();
3867 EXPECT_EQ(nullptr,
3868 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3869 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3870}
3871
Devin Moore53fc99c2020-08-12 08:07:52 -07003872TEST_P(AidlTest, GenericStructuredParcelable) {
3873 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3874 Options options =
3875 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3876 const string expected_stderr = "";
3877 CaptureStderr();
3878 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3880}
3881
Jooyung Han3f347ca2020-12-01 12:41:50 +09003882TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3883 io_delegate_.SetFileContents("Foo.aidl",
3884 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3885 Options options =
3886 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3887 " -o out -h out");
3888 const string expected_stderr = "";
3889 CaptureStderr();
3890 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3891 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3892
3893 string code;
3894 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3895 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3896const ::android::String16& Foo<T,U>::s() {
3897 static const ::android::String16 value(::android::String16(""));
3898 return value;
3899})--"));
3900}
3901
3902TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3903 io_delegate_.SetFileContents("Foo.aidl",
3904 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3905 Options options =
3906 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3907 " -o out -h out");
3908 const string expected_stderr = "";
3909 CaptureStderr();
3910 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3911 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3912
3913 string code;
3914 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3915 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3916const char* Foo<T, U>::s = "";
3917)--"));
3918}
3919
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003920TEST_F(AidlTest, NestedTypeArgs) {
3921 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003922 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3923
3924 io_delegate_.SetFileContents("a/Foo.aidl",
3925 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3926 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003927 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3928 const string expected_stderr = "";
3929 CaptureStderr();
3930 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3931 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3932
3933 string code;
3934 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003935 EXPECT_THAT(code,
3936 testing::HasSubstr(
3937 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3938}
3939
3940TEST_F(AidlTest, DoubleArrayError) {
3941 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3942
3943 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3944 const string expected_stderr =
3945 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3946 CaptureStderr();
3947 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3948 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3949}
3950
3951TEST_F(AidlTest, DoubleGenericError) {
3952 io_delegate_.SetFileContents("a/Bar.aidl",
3953 "package a; parcelable Bar { List<String><String> a; }");
3954
3955 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3956 const string expected_stderr =
3957 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3958 CaptureStderr();
3959 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3960 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3961}
3962
3963TEST_F(AidlTest, ArrayBeforeGenericError) {
3964 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3965
3966 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3967 const string expected_stderr =
3968 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3969 CaptureStderr();
3970 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003972}
3973
Jooyung Han14004ed2020-10-16 03:49:57 +09003974struct GenericAidlTest : ::testing::Test {
3975 FakeIoDelegate io_delegate_;
3976 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003977 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003978 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3979 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3980 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3981
3982 Options options = Options::From(cmd);
3983 CaptureStderr();
3984 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3985 EXPECT_EQ("", GetCapturedStderr());
3986 }
3987};
3988
3989TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3990 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3991 string code;
3992 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3993 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3994 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3995 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3996}
3997
3998TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3999 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4000 string code;
4001 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4002 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4003 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4004 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4005}
4006
Devin Moore53fc99c2020-08-12 08:07:52 -07004007TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4008 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
4009 Options options =
4010 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4011 const string expected_stderr =
4012 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4013 CaptureStderr();
4014 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4015 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4016}
4017
4018TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4019 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
4020 Options options =
4021 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4022 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4023 CaptureStderr();
4024 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4025 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4026}
4027
Jooyung Han7a308842020-10-27 19:06:49 +09004028TEST_P(AidlTest, LongCommentWithinConstExpression) {
4029 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
4030 Options options =
4031 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4032 CaptureStderr();
4033 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4034 EXPECT_EQ("", GetCapturedStderr());
4035}
4036
Jeongik Chaef44e622020-10-23 16:00:52 +09004037TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4038 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4039 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4040 std::string expectedErr =
4041 "ERROR: a/Foo.aidl:1.28-30: "
4042 "Encountered an untyped List or Map. The use of untyped List/Map is "
4043 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4044 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4045 "ERROR: a/Foo.aidl:1.35-37: "
4046 "Encountered an untyped List or Map. The use of untyped List/Map is "
4047 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4048 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4049 CaptureStderr();
4050 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4051 EXPECT_EQ(expectedErr, GetCapturedStderr());
4052}
4053
4054TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004055 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4056 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004057 std::string expectedErr =
4058 "ERROR: a/Foo.aidl:1.33-35: "
4059 "Encountered an untyped List or Map. The use of untyped List/Map is "
4060 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4061 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4062 "ERROR: a/Foo.aidl:1.40-42: "
4063 "Encountered an untyped List or Map. The use of untyped List/Map is "
4064 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4065 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004066 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004067 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4068 EXPECT_EQ(expectedErr, GetCapturedStderr());
4069}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004070
Jeongik Chaef44e622020-10-23 16:00:52 +09004071TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4072 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4073 io_delegate_.SetFileContents(
4074 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4075 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4076 std::string expectedErr =
4077 "ERROR: a/Foo.aidl:1.52-54: "
4078 "Encountered an untyped List or Map. The use of untyped List/Map is "
4079 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4080 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4081 "ERROR: a/Foo.aidl:1.64-66: "
4082 "Encountered an untyped List or Map. The use of untyped List/Map is "
4083 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4084 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4085 CaptureStderr();
4086 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4087 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004088}
4089
Jooyung Han690f5842020-12-04 13:02:04 +09004090TEST_F(AidlTest, EnumWithDefaults_Java) {
4091 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4092 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4093package p;
4094import p.Enum;
4095parcelable Foo {
4096 Enum e = Enum.BAR;
4097})");
4098 CaptureStderr();
4099 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4100 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4101 auto err = GetCapturedStderr();
4102 EXPECT_EQ("", err);
4103
4104 string code;
4105 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004106 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004107}
4108
4109TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4110 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4111 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4112package p;
4113import p.Enum;
4114parcelable Foo {
4115 Enum e = Enum.BAR;
4116})");
4117 CaptureStderr();
4118 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4119 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4120 auto err = GetCapturedStderr();
4121 EXPECT_EQ("", err);
4122
4123 string code;
4124 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4125 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4126}
4127
4128TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4129 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4130 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4131package p;
4132import p.Enum;
4133parcelable Foo {
4134 Enum e = Enum.BAR;
4135})");
4136 CaptureStderr();
4137 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4138 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4139 auto err = GetCapturedStderr();
4140 EXPECT_EQ("", err);
4141
4142 string code;
4143 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4144 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4145}
4146
4147TEST_F(AidlTest, EnumWithDefaults_Rust) {
4148 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4149 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4150package p;
4151import p.Enum;
4152parcelable Foo {
4153 int n = 42;
4154 Enum e = Enum.BAR;
4155})");
4156 CaptureStderr();
4157 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4158 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4159 auto err = GetCapturedStderr();
4160 EXPECT_EQ("", err);
4161
4162 string code;
4163 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4164 EXPECT_THAT(code, testing::HasSubstr(R"(
4165 fn default() -> Self {
4166 Self {
4167 n: 42,
4168 e: crate::mangled::_1_p_4_Enum::BAR,
4169 }
4170 })"));
4171}
4172
4173TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4174 import_paths_.insert("a");
4175 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4176 CaptureStderr();
4177 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4178package p;
4179import p.Enum;
4180parcelable Foo {
4181 int e = Enum.FOO | Enum.BAR;
4182})",
4183 typenames_, GetLanguage());
4184 auto err = GetCapturedStderr();
4185 EXPECT_EQ("", err);
4186 EXPECT_TRUE(type);
4187 const auto& fields = type->AsStructuredParcelable()->GetFields();
4188 EXPECT_EQ("int e = 3", fields[0]->ToString());
4189}
4190
4191TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4192 CaptureStderr();
4193 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4194@Backing(type="int")
4195enum Foo {
4196 STANDARD_SHIFT = 16,
4197 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4198 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4199}
4200)",
4201 typenames_, GetLanguage());
4202 auto err = GetCapturedStderr();
4203 EXPECT_EQ("", err);
4204 EXPECT_TRUE(type);
4205 const auto& enum_type = type->AsEnumDeclaration();
4206 string code;
4207 enum_type->Dump(CodeWriter::ForString(&code).get());
4208 EXPECT_EQ(R"--(@Backing(type="int")
4209enum Foo {
4210 STANDARD_SHIFT = 16,
4211 STANDARD_BT709 = 65536,
4212 STANDARD_BT601_625 = 131072,
4213}
4214)--",
4215 code);
4216}
4217
4218TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4219 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4220 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4221package p;
4222import p.Enum;
4223parcelable Foo {
4224 Enum e = Enum.FOO | Enum.BAR;
4225})");
4226 CaptureStderr();
4227 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4228 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4229 auto err = GetCapturedStderr();
4230 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4231 err);
4232}
4233
4234TEST_P(AidlTest, DefaultWithEmptyArray) {
4235 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4236 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4237 CaptureStderr();
4238 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4239 " -o out -h out a/p/Foo.aidl");
4240 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4241 auto err = GetCapturedStderr();
4242 EXPECT_EQ("", err);
4243}
4244
4245TEST_P(AidlTest, RejectRefsInAnnotation) {
4246 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4247 "package p; interface IFoo {\n"
4248 " const String ANNOTATION = \"@Annotation\";\n"
4249 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4250 "}");
4251 CaptureStderr();
4252 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4253 " -o out -h out a/p/IFoo.aidl");
4254 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4255 auto err = GetCapturedStderr();
4256 EXPECT_EQ(
4257 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4258 "ANNOTATION.\n",
4259 err);
4260}
4261
4262TEST_F(AidlTest, DefaultWithEnumValues) {
4263 io_delegate_.SetFileContents(
4264 "a/p/Foo.aidl",
4265 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4266 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4267 CaptureStderr();
4268 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4269 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4270 auto err = GetCapturedStderr();
4271 EXPECT_EQ("", err);
4272 string code;
4273 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4274 EXPECT_THAT(
4275 code, testing::HasSubstr(
4276 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4277}
4278
Jooyung Han14259392020-12-07 10:00:08 +09004279TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4280 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4281 CaptureStderr();
4282 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4283 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4284 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004285 EXPECT_EQ(
4286 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4287 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4288 err);
Jooyung Han14259392020-12-07 10:00:08 +09004289}
4290
4291TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4292 io_delegate_.SetFileContents("a/p/Foo.aidl",
4293 "package p; parcelable Foo { const int A = A + 1; }");
4294 CaptureStderr();
4295 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4296 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4297 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004298 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4299}
4300
4301TEST_F(AidlTest, RecursiveReferences) {
4302 io_delegate_.SetFileContents("a/p/Foo.aidl",
4303 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4304 io_delegate_.SetFileContents("a/p/Bar.aidl",
4305 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4306 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4307 CaptureStderr();
4308 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4309 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4310 EXPECT_EQ("", GetCapturedStderr());
4311}
4312
4313TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4314 string contents = R"(
4315import android.os.IBinder;
4316import android.os.IInterface;
4317interface IFoo {}
4318 )";
4319 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004320}
4321
Jooyung Han888c5bc2020-12-22 17:28:47 +09004322TEST_P(AidlTest, WarningInterfaceName) {
4323 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4324 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4325 " -Weverything -o out -h out p/Foo.aidl");
4326 CaptureStderr();
4327 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han3557e482020-12-24 05:11:15 +09004328 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004329 GetCapturedStderr());
4330}
4331
4332TEST_P(AidlTest, ErrorInterfaceName) {
4333 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4334 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4335 " -Weverything -Werror -o out -h out p/Foo.aidl");
4336 CaptureStderr();
4337 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han3557e482020-12-24 05:11:15 +09004338 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I.[-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004339 GetCapturedStderr());
4340}
4341
Jooyung Hanfd3be322020-12-13 09:11:06 +09004342struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004343 string kind;
4344 string literal;
4345};
4346
Jooyung Hanfd3be322020-12-13 09:11:06 +09004347const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004348 {"primitive", "int"}, {"String", "String"},
4349 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4350 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4351 {"union", "a.Union"}, {"interface", "a.IBar"},
4352};
4353
4354const std::map<std::string, std::string> kListSupportExpectations = {
4355 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4356 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4357 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4358 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4359 {"cpp_String", ""},
4360 {"java_String", ""},
4361 {"ndk_String", ""},
4362 {"rust_String", ""},
4363 {"cpp_IBinder", ""},
4364 {"java_IBinder", ""},
4365 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4366 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004367 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004368 {"java_ParcelFileDescriptor", ""},
4369 {"ndk_ParcelFileDescriptor", ""},
4370 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004371 {"cpp_interface", "List<a.IBar> is not supported."},
4372 {"java_interface", "List<a.IBar> is not supported."},
4373 {"ndk_interface", "List<a.IBar> is not supported."},
4374 {"rust_interface", "List<a.IBar> is not supported."},
4375 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004376 {"java_parcelable", ""},
4377 {"ndk_parcelable", ""},
4378 {"rust_parcelable", ""},
4379 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4380 {"java_enum", "A generic type cannot have any primitive type parameters."},
4381 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4382 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004383 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004384 {"java_union", ""},
4385 {"ndk_union", ""},
4386 {"rust_union", ""},
4387};
4388
Jooyung Hand236e552020-12-13 09:21:27 +09004389const std::map<std::string, std::string> kArraySupportExpectations = {
4390 {"cpp_primitive", ""},
4391 {"java_primitive", ""},
4392 {"ndk_primitive", ""},
4393 {"rust_primitive", ""},
4394 {"cpp_String", ""},
4395 {"java_String", ""},
4396 {"ndk_String", ""},
4397 {"rust_String", ""},
4398 {"cpp_IBinder", ""},
4399 {"java_IBinder", ""},
4400 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4401 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4402 {"cpp_ParcelFileDescriptor", ""},
4403 {"java_ParcelFileDescriptor", ""},
4404 {"ndk_ParcelFileDescriptor", ""},
4405 {"rust_ParcelFileDescriptor", ""},
4406 {"cpp_interface", "Binder type cannot be an array"},
4407 {"java_interface", "Binder type cannot be an array"},
4408 {"ndk_interface", "Binder type cannot be an array"},
4409 {"rust_interface", "Binder type cannot be an array"},
4410 {"cpp_parcelable", ""},
4411 {"java_parcelable", ""},
4412 {"ndk_parcelable", ""},
4413 {"rust_parcelable", ""},
4414 {"cpp_enum", ""},
4415 {"java_enum", ""},
4416 {"ndk_enum", ""},
4417 {"rust_enum", ""},
4418 {"cpp_union", ""},
4419 {"java_union", ""},
4420 {"ndk_union", ""},
4421 {"rust_union", ""},
4422};
4423
Jooyung Hanfd3be322020-12-13 09:11:06 +09004424class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004425 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004426 void Run(const std::string& generic_type_decl,
4427 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004428 const auto& param = GetParam();
4429 const auto& lang = Options::LanguageToString(std::get<0>(param));
4430 const auto& kind = std::get<1>(param).kind;
4431
4432 FakeIoDelegate io;
4433 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4434 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4435 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004436 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4437 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004438
4439 const auto options =
4440 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4441 CaptureStderr();
4442 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004443 auto it = expectations.find(lang + "_" + kind);
4444 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004445 const string err = GetCapturedStderr();
4446 if (it->second.empty()) {
4447 EXPECT_EQ("", err);
4448 } else {
4449 EXPECT_THAT(err, testing::HasSubstr(it->second));
4450 }
4451 }
4452};
4453
4454INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004455 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004456 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4457 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004458 testing::ValuesIn(kTypeParams)),
4459 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004460 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4461 std::get<1>(info.param).kind;
4462 });
4463
Jooyung Hanfd3be322020-12-13 09:11:06 +09004464TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4465 Run("List<{}>", kListSupportExpectations);
4466}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004467
Jooyung Hand236e552020-12-13 09:21:27 +09004468TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4469 Run("{}[]", kArraySupportExpectations);
4470}
4471
Christopher Wiley90be4e32015-10-20 14:55:25 -07004472} // namespace aidl
4473} // namespace android