blob: 29bab6f9a47a3adc36caa0797e5b4080c4774df7 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Jooyung Hand2fa0232020-10-19 02:51:41 +090081const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 R"(/*
83 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080085@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090086public class Rect implements android.os.Parcelable
87{
88 // Comment
89
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080090 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090091 public int x = 5;
92
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080093 @android.annotation.Hide
94 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000095 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090096
97 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090098
99 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900100 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
101 @Override
102 public Rect createFromParcel(android.os.Parcel _aidl_source) {
103 Rect _aidl_out = new Rect();
104 _aidl_out.readFromParcel(_aidl_source);
105 return _aidl_out;
106 }
107 @Override
108 public Rect[] newArray(int _aidl_size) {
109 return new Rect[_aidl_size];
110 }
111 };
112 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
113 {
114 int _aidl_start_pos = _aidl_parcel.dataPosition();
115 _aidl_parcel.writeInt(0);
116 _aidl_parcel.writeInt(x);
117 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900118 if ((fd!=null)) {
119 _aidl_parcel.writeInt(1);
120 fd.writeToParcel(_aidl_parcel, 0);
121 }
122 else {
123 _aidl_parcel.writeInt(0);
124 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900125 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900126 int _aidl_end_pos = _aidl_parcel.dataPosition();
127 _aidl_parcel.setDataPosition(_aidl_start_pos);
128 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
129 _aidl_parcel.setDataPosition(_aidl_end_pos);
130 }
131 public final void readFromParcel(android.os.Parcel _aidl_parcel)
132 {
133 int _aidl_start_pos = _aidl_parcel.dataPosition();
134 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900136 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900137 x = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
139 y = _aidl_parcel.readInt();
140 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900141 if ((0!=_aidl_parcel.readInt())) {
142 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
143 }
144 else {
145 fd = null;
146 }
147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900148 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900149 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900150 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900151 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
152 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
153 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900154 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
155 }
156 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900157 @Override
158 public int describeContents() {
159 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900160 _mask |= describeContents(fd);
161 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900162 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900163 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900164 private int describeContents(Object _v) {
165 if (_v == null) return 0;
166 if (_v instanceof java.util.Collection) {
167 int _mask = 0;
168 for (Object o : (java.util.Collection) _v) {
169 _mask |= describeContents(o);
170 }
171 return _mask;
172 }
173 if (_v instanceof android.os.Parcelable) {
174 return ((android.os.Parcelable) _v).describeContents();
175 }
176 return 0;
177 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900178}
179)";
180
Devin Moore2f2077a2020-08-28 11:27:53 -0700181// clang-format off
182const char kExpectedCppHeaderOutput[] =
183 R"(#pragma once
184
185#include <binder/IBinder.h>
186#include <binder/IInterface.h>
187#include <binder/Status.h>
188#include <optional>
189#include <utils/String16.h>
190#include <utils/StrongPointer.h>
191#include <vector>
192
193class IFoo : public ::android::IInterface {
194public:
195 DECLARE_META_INTERFACE(Foo)
196 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
197}; // class IFoo
198class IFooDefault : public IFoo {
199public:
200 ::android::IBinder* onAsBinder() override {
201 return nullptr;
202 }
203 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
204 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
205 }
206}; // class IFooDefault
207)";
208// clang-format on
209
Christopher Wileyf8136192016-04-12 14:19:35 -0700210} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700213 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900214 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
215 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700216 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700217 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900218 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +0900220 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700221 for (const string& s : additional_arguments) {
222 args.emplace_back(s);
223 }
224 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900225 args.emplace_back("--preprocessed=" + f);
226 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700227 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900228 args.emplace_back("--include=" + i);
229 }
230 args.emplace_back(path);
231 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900232 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900233 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700234 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900235 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900236
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700237 if (error != nullptr) {
238 *error = actual_error;
239 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900240
241 if (actual_error != AidlError::OK) {
242 return nullptr;
243 }
244
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900245 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900246 EXPECT_EQ(1ul, defined_types.size());
247
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900248 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700249 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700250
Devin Moore7b8d5c92020-03-17 14:14:08 -0700251 Options::Language GetLanguage() { return GetParam(); }
252
Christopher Wiley0522cd52015-10-28 15:39:44 -0700253 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800254 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900255 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900256 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700257};
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
260// tests with each of the supported languages as a parameter.
261INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
262 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700263 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900265 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700266 });
267
268TEST_P(AidlTest, AcceptMissingPackage) {
269 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700270}
271
Devin Moore7b8d5c92020-03-17 14:14:08 -0700272TEST_P(AidlTest, EndsInSingleLineComment) {
273 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700274}
275
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000276TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
277 const string expected_stderr =
278 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
279 const std::string file_contents = "package a; interface IBar {}";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
283}
284
285TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
286 const string expected_stderr =
287 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
288 const std::string file_contents = "package a; interface Bar {}";
289 CaptureStderr();
290 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
291 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
292}
293
294TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
295 const string expected_stderr =
296 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
297 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
298 CaptureStderr();
299 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
300 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
301}
302
303TEST_P(AidlTest, EnumRequiresCorrectPath) {
304 const string expected_stderr =
305 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
306 const std::string file_contents = "package a; enum Bar { A, }";
307 CaptureStderr();
308 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
309 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
310}
311
Devin Moore7b8d5c92020-03-17 14:14:08 -0700312TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900313 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700314 io_delegate_.SetFileContents("bar/IBar.aidl",
315 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700316 const string path = "foo/IFoo.aidl";
317 const string contents =
318 "package foo;\n"
319 "import bar.IBar;\n"
320 "interface IFoo { void f(in IBar[] input); }";
321 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700323 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700325}
326
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700328 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700329 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900330}
Devin Moore097a3ab2020-03-11 16:08:44 -0700331
Jiyong Park40782d02020-07-24 19:17:43 +0900332TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700333 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
334 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900335 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
336 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700339 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900340}
341
Jiyong Park40782d02020-07-24 19:17:43 +0900342TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700343 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
344 const string expected_stderr =
345 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346 CaptureStderr();
347 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
348 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900349}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350
Jiyong Park40782d02020-07-24 19:17:43 +0900351TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700352 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900353 const string expected_stderr =
354 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
362 const string expected_stderr =
363 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
364 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700365 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700366 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
371 const string expected_stderr =
372 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
373 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700374 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800376}
377
Devin Moore2f2077a2020-08-28 11:27:53 -0700378TEST_P(AidlTest, AcceptNullableList) {
379 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
380 const string expected_stderr = "";
381 CaptureStderr();
382 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
383 EXPECT_EQ(expected_stderr, GetCapturedStderr());
384}
385
Devin Moore7b8d5c92020-03-17 14:14:08 -0700386TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700387 const string method = "package a; interface IFoo { void f(int a, int a); }";
388 const string expected_stderr =
389 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
390 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700393}
394
Jeongik Cha13066da2020-08-06 15:43:19 +0900395TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
396 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900397 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900398 CaptureStderr();
399 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
401}
402
Jooyung Hand902a972020-10-23 17:32:44 +0900403TEST_P(AidlTest, RejectsRepeatedAnnotations) {
404 const string method = R"(@Hide @Hide parcelable Foo {})";
405 const string expected_stderr =
406 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
407 "Foo.aidl:1.1-6\n";
408 CaptureStderr();
409 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
411}
412
Devin Moore7b8d5c92020-03-17 14:14:08 -0700413TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700414 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
415 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
416 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700418 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100419}
420
Devin Moore7b8d5c92020-03-17 14:14:08 -0700421TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700422 AidlError error;
423 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700424 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700425 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900426 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700427 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800428}
429
Devin Moore7b8d5c92020-03-17 14:14:08 -0700430TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700431 AidlError error;
432 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700433 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700434 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900435 EXPECT_THAT(GetCapturedStderr(),
436 HasSubstr("'JavaOnlyStableParcelable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700437 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800438}
439
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700441 AidlError error;
442 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700443 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000444 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900445 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700446 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800447}
448
Devin Moore7b8d5c92020-03-17 14:14:08 -0700449TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700450 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000451 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900454 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation"));
Devin Moorec054bf82020-03-10 16:31:48 -0700455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Jiyong Park40782d02020-07-24 19:17:43 +0900458TEST_P(AidlTest, ParsesNonNullableAnnotation) {
459 auto parse_result =
460 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
461 ASSERT_NE(nullptr, parse_result);
462 const AidlInterface* interface = parse_result->AsInterface();
463 ASSERT_NE(nullptr, interface);
464 ASSERT_FALSE(interface->GetMethods().empty());
465 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
466}
467
Devin Moore7b8d5c92020-03-17 14:14:08 -0700468TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900469 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
470 typenames_, GetLanguage());
471 ASSERT_NE(nullptr, parse_result);
472 const AidlInterface* interface = parse_result->AsInterface();
473 ASSERT_NE(nullptr, interface);
474 ASSERT_FALSE(interface->GetMethods().empty());
475 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
476}
477
478TEST_P(AidlTest, ParsesNonUtf8Annotations) {
479 auto parse_result =
480 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
481 ASSERT_NE(nullptr, parse_result);
482 const AidlInterface* interface = parse_result->AsInterface();
483 ASSERT_NE(nullptr, interface);
484 ASSERT_FALSE(interface->GetMethods().empty());
485 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800486}
487
Devin Moore7b8d5c92020-03-17 14:14:08 -0700488TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900489 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
490 typenames_, GetLanguage());
491 ASSERT_NE(nullptr, parse_result);
492 const AidlInterface* interface = parse_result->AsInterface();
493 ASSERT_NE(nullptr, interface);
494 ASSERT_FALSE(interface->GetMethods().empty());
495 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800496}
497
Devin Moore7b8d5c92020-03-17 14:14:08 -0700498TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700499 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700500 const string expected_stderr =
501 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
502 "\"vintf\"'\n"
503 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
504 "--structured\n";
505 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700506 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700507 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700509 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510}
511
Devin Moore7b8d5c92020-03-17 14:14:08 -0700512TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700513 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700514 const string expected_stderr =
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
528 "\"vintf\"'\n";
529 CaptureStderr();
530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700538 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
539 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700540 ASSERT_EQ(AidlError::OK, error);
541 ASSERT_NE(nullptr, parse_result);
542 const AidlInterface* interface = parse_result->AsInterface();
543 ASSERT_NE(nullptr, interface);
544 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545}
546
Jeongik Cha64783ed2019-06-07 18:30:54 +0900547TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
548 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900549 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
550 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900551 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700552 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900553 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900554 "a/Foo.aidl",
555 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900556
557 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900558 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700559 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900560 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700561 "Parcelable must be defined in AIDL directly.\n";
562 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900563 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700564 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700565
566 CaptureStderr();
567 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
568 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569}
570
Jooyung Han1cbc4962020-10-25 10:07:15 +0900571TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
572 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
573 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
574 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900575 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
576
577 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900578 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900579 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
580
581 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900582 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900583 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
584
Jooyung Han1cbc4962020-10-25 10:07:15 +0900585 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
587}
588
Jooyung Han1cbc4962020-10-25 10:07:15 +0900589TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
590 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
591 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
592 CaptureStderr();
593 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
594 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
595 EXPECT_EQ("", GetCapturedStderr());
596
597 const string expected_to_string_method = R"--(
598 @Override
599 public String toString() {
600 switch (_tag) {
601 case a: return "a.Foo.a(" + (getA()) + ")";
602 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
603 }
604 throw new IllegalStateException("unknown field: " + _tag);
605 }
606)--";
607
608 string java_out;
609 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
610 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
611}
612
Jiyong Park9aa3d042020-12-04 23:30:02 +0900613TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
614 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
615 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
616 CaptureStderr();
617 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
618 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
619 EXPECT_EQ("", GetCapturedStderr());
620
621 const std::string expected = R"--(
622 @Override
623 public boolean equals(Object other) {
624 if (this == other) return true;
625 if (other == null) return false;
626 if (!(other instanceof Foo)) return false;
627 Foo that = (Foo)other;
628 if (!java.util.Objects.deepEquals(a, that.a)) return false;
629 if (!java.util.Objects.deepEquals(b, that.b)) return false;
630 return true;
631 }
632
633 @Override
634 public int hashCode() {
635 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
636 }
637)--";
638
639 string java_out;
640 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
641 EXPECT_THAT(java_out, testing::HasSubstr(expected));
642}
643
644TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
645 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
646 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
647 CaptureStderr();
648 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
649 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
650 EXPECT_EQ("", GetCapturedStderr());
651
652 const std::string expected = R"--(
653 @Override
654 public boolean equals(Object other) {
655 if (this == other) return true;
656 if (other == null) return false;
657 if (!(other instanceof Foo)) return false;
658 Foo that = (Foo)other;
659 if (_tag != that._tag) return false;
660 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
661 return true;
662 }
663
664 @Override
665 public int hashCode() {
666 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
667 }
668)--";
669
670 string java_out;
671 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
672 EXPECT_THAT(java_out, testing::HasSubstr(expected));
673}
674
Jooyung Han90345002020-10-23 15:28:53 +0900675TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900676 {
Jooyung Han90345002020-10-23 15:28:53 +0900677 io_delegate_.SetFileContents("a/Foo.aidl",
678 "package a; @JavaDerive(blah=true) parcelable Foo{}");
679 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
680 CaptureStderr();
681 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
682 const std::string expected_stderr =
683 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900684 EXPECT_THAT(GetCapturedStderr(),
685 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900686 }
687
688 {
689 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900690 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
691 CaptureStderr();
692 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900693 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation"));
Jiyong Park43113fb2020-07-20 16:26:19 +0900694 }
695
696 {
Jooyung Han90345002020-10-23 15:28:53 +0900697 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900698 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
699 CaptureStderr();
700 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900701 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation"));
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 }
703}
704
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900705TEST_P(AidlTest, ParseDescriptorAnnotation) {
706 AidlError error;
707 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
708 typenames_, GetLanguage(), &error, {"--structured"});
709 ASSERT_EQ(AidlError::OK, error);
710 ASSERT_NE(nullptr, parse_result);
711 const AidlInterface* interface = parse_result->AsInterface();
712 ASSERT_NE(nullptr, interface);
713 ASSERT_EQ("IBar", interface->GetDescriptor());
714}
715
Jiyong Park40782d02020-07-24 19:17:43 +0900716TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700717 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700718 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900719}
720
721TEST_P(AidlTest, AcceptsOnewayInterface) {
722 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700723 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700724}
Christopher Wileyef140932015-11-03 09:29:19 -0800725
Devin Moore7b8d5c92020-03-17 14:14:08 -0700726TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700727 const string oneway_method =
728 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700729 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100730}
731
Steven Moreland65297cc2020-04-20 20:17:36 -0700732TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
733 const string oneway_method =
734 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
735 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
736 ASSERT_NE(nullptr, defined);
737 const AidlInterface* iface = defined->AsInterface();
738 ASSERT_NE(nullptr, iface);
739
740 const auto& methods = iface->GetMethods();
741 ASSERT_EQ(1u, methods.size());
742 const auto& method = methods[0];
743 const AidlTypeSpecifier& ret_type = method->GetType();
744
745 // TODO(b/151102494): these annotations should be on the method
746 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
747 ASSERT_TRUE(ret_type.IsHide());
748}
749
Devin Moore7b8d5c92020-03-17 14:14:08 -0700750TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100751 string foo_interface =
752 "package a; /* foo */ interface IFoo {"
753 " /* i */ int i();"
754 " /* j */ @nullable String j();"
755 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
756
Devin Moore7b8d5c92020-03-17 14:14:08 -0700757 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100758 EXPECT_NE(nullptr, parse_result);
759 EXPECT_EQ("/* foo */", parse_result->GetComments());
760
761 const AidlInterface* interface = parse_result->AsInterface();
762 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
763 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
764 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
765}
766
Jooyung Han1a551d32020-10-05 15:37:26 +0900767TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
768 io_delegate_.SetFileContents("p/cpp_header.aidl",
769 R"(package p;
770 parcelable cpp_header cpp_header "bar/header";)");
771 import_paths_.emplace("");
772 const string input_path = "p/IFoo.aidl";
773 const string input = R"(package p;
774 import p.cpp_header;
775 interface IFoo {
776 // get bar
777 cpp_header get();
778 })";
779
780 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
781 EXPECT_NE(nullptr, parse_result);
782 const AidlInterface* interface = parse_result->AsInterface();
783 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
784}
785
Christopher Wileyef140932015-11-03 09:29:19 -0800786TEST_F(AidlTest, ParsesPreprocessedFile) {
787 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
788 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700789 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900790 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800793}
794
795TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
796 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
797 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900798
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700799 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900800 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700801 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
802 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800803}
804
Devin Moore7b8d5c92020-03-17 14:14:08 -0700805TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800806 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
807 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
808 "interface IBar {}");
809 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900810 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900811 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700812 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800813 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900814
Christopher Wiley41544372015-11-03 14:52:29 -0800815 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700816 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
817 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800818 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700819 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900820 ambiguous_type.Resolve(typenames_);
821 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800822}
823
Jiyong Park8f6ec462020-01-19 20:52:47 +0900824// Special case of PreferImportToPreprocessed. Imported type should be preferred
825// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700826TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900827 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
828 io_delegate_.SetFileContents("one/IBar.aidl",
829 "package one; "
830 "interface IBar {}");
831 preprocessed_files_.push_back("preprocessed");
832 import_paths_.emplace("");
833 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700834 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900835 EXPECT_NE(nullptr, parse_result);
836
837 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700838 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
839 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900840 // But if we request just "IBar" we should get our imported one.
841 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
842 ambiguous_type.Resolve(typenames_);
843 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
844}
845
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800846TEST_F(AidlTest, WritePreprocessedFile) {
847 io_delegate_.SetFileContents("p/Outer.aidl",
848 "package p; parcelable Outer.Inner;");
849 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
850 "interface IBar {}");
851
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900852 vector<string> args {
853 "aidl",
854 "--preprocess",
855 "preprocessed",
856 "p/Outer.aidl",
857 "one/IBar.aidl"};
858 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800859 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
860
861 string output;
862 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
863 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
864}
865
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900866TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100867 io_delegate_.SetFileContents(
868 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800869 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100870 "parcelable Rect {\n"
871 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800872 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100873 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800874 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100875 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100876 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
877 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100878 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900879 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900880 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100881 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900882
883 vector<string> args{"aidl", "Rect.aidl"};
884 Options options = Options::From(args);
885 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
886
887 string output;
888 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900889 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900890}
891
Devin Moore2f2077a2020-08-28 11:27:53 -0700892TEST_F(AidlTest, CppHeaderIncludes) {
893 io_delegate_.SetFileContents("IFoo.aidl",
894 "interface IFoo {\n"
895 " @nullable List<String> foo();\n"
896 "}");
897
898 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
899 Options options = Options::From(args);
900 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
901 std::vector<std::string> empty;
902 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
903 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
904 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
905
906 // Make sure the optional and String16.h includes are added
907 string output;
908 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
909 EXPECT_EQ(kExpectedCppHeaderOutput, output);
910}
911
Devin Moore7b8d5c92020-03-17 14:14:08 -0700912TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700913 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800914 io_delegate_.SetFileContents("p/Outer.aidl",
915 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900916 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 CaptureStderr();
918 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
919 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700920 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800922}
923
Devin Moore7b8d5c92020-03-17 14:14:08 -0700924TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800925 io_delegate_.SetFileContents("preprocessed",
926 "parcelable p.Outer.Inner;");
927 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900928 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700929 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800930 // TODO(wiley): This should actually return nullptr because we require
931 // the outer class name. However, for legacy reasons,
932 // this behavior must be maintained. b/17415692
933 EXPECT_NE(nullptr, parse_result);
934}
935
Christopher Wiley632801d2015-11-05 14:15:49 -0800936TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700937 const string expected_foo_stderr =
938 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
939 "Declared parcelables should be in their own file and/or cannot be used with --structured "
940 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700941 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
942
Christopher Wiley632801d2015-11-05 14:15:49 -0800943 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700944 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700945 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900946 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700947 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900948
Steven Morelande2c64b42018-09-18 15:06:37 -0700949 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900950 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900952 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700954
Devin Moore097a3ab2020-03-11 16:08:44 -0700955 const string expected_bar_stderr =
956 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
957 "Declared parcelables should be in their own file and/or cannot be used with --structured "
958 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700959 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
960
Jiyong Parkda8c6932019-08-12 19:56:08 +0900961 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700962 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900964 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700965 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700966 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700967 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800970}
971
Devin Moore7b8d5c92020-03-17 14:14:08 -0700972TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700973 const string expected_stderr =
974 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
975 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700976 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
977 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 AidlError error;
979 CaptureStderr();
980 EXPECT_EQ(
981 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700982 Parse("p/IFoo.aidl",
983 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700984 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
986 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700987}
988
Devin Moore7b8d5c92020-03-17 14:14:08 -0700989TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700990 AidlError error;
991 const string expected_stderr =
992 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
993 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900994 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
995 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700996 interface IFoo {
997 const String DUPLICATED = "d";
998 const int DUPLICATED = 1;
999 }
1000 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001004}
1005
Steven Morelande689da22020-11-10 02:06:30 +00001006TEST_P(AidlTest, FailOnTooBigConstant) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1010 CaptureStderr();
1011 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1012 R"(package p;
1013 interface IFoo {
1014 const byte type2small = 256;
1015 }
1016 )",
1017 typenames_, GetLanguage(), &error));
1018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1019 EXPECT_EQ(AidlError::BAD_TYPE, error);
1020}
1021
Jooyung Han30f64ad2020-12-15 08:16:31 +09001022TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1023 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1024 CaptureStderr();
1025 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1026 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1027 EXPECT_EQ("", GetCapturedStderr());
1028 string code;
1029 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1030 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1031}
1032
Jooyung Han535c5e82020-12-29 15:16:59 +09001033TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001034 using Ptr = unique_ptr<AidlConstantValue>;
1035 const AidlLocation& loc = AIDL_LOCATION_HERE;
1036
Jooyung Han535c5e82020-12-29 15:16:59 +09001037 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1038 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1039 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1040 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001041
1042 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1043 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001044 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001045
1046 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1047 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1048 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1049 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001050 EXPECT_EQ(
1051 expected,
1052 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001053}
1054
Devin Moore7b8d5c92020-03-17 14:14:08 -07001055TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001056 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001057 const string expected_stderr =
1058 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001059 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001060 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1061 R"(package p;
1062 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001063 parcelable IBar {}
1064 parcelable StructuredParcelable {}
1065 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001066 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001067 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001068 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001069 // Parse success is important for clear error handling even if the cases aren't
1070 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001071 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001072}
1073
Devin Moore7b8d5c92020-03-17 14:14:08 -07001074TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001075 AidlError error;
1076 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1077 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001078 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001079 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1080 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001081}
1082
Steven Morelandf9e922f2020-07-08 21:15:27 +00001083TEST_P(AidlTest, FailOnEmptyListWithComma) {
1084 AidlError error;
1085 const string expected_stderr =
1086 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1087 CaptureStderr();
1088 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1089 typenames_, GetLanguage(), &error));
1090 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1091 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1092}
1093
Devin Moore7b8d5c92020-03-17 14:14:08 -07001094TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001095 AidlError error;
1096 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001097 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001098 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001099 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1100 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001101 interface IFoo {
1102 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1103 }
1104 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001105 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001106 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1107 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001108}
1109
Jiyong Park18132182020-06-08 20:24:40 +09001110TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1111 AidlError error;
1112 const string expected_stderr =
1113 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1114 "cpp_header (which can also be used as an identifier)\n";
1115 CaptureStderr();
1116 // Notice the trailing dot(.) in the name, which isn't a correct name
1117 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1118 GetLanguage(), &error));
1119 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1120 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1121}
1122
1123TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1124 AidlError error;
1125 const string expected_stderr =
1126 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1127 "cpp_header (which can also be used as an identifier)\n";
1128 CaptureStderr();
1129 // Notice the trailing dot(.) in the package name
1130 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1131 GetLanguage(), &error));
1132 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1133 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1134}
1135
Devin Moore7b8d5c92020-03-17 14:14:08 -07001136TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001137 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001138 auto parse_result = Parse("p/IFoo.aidl",
1139 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001140 interface IFoo {
1141 const int POSITIVE_HEX_VALUE = 0xf5;
1142 }
1143 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001144 typenames_, GetLanguage(), &error);
1145 EXPECT_NE(nullptr, parse_result);
1146 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001147 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001148 const auto& cpp_constants = interface->GetConstantDeclarations();
1149 EXPECT_EQ((size_t)1, cpp_constants.size());
1150 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001151 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001152 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001153}
1154
Devin Moore7b8d5c92020-03-17 14:14:08 -07001155TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001156 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001157 auto parse_result = Parse("p/IFoo.aidl",
1158 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001159 interface IFoo {
1160 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1161 }
1162 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001163 typenames_, GetLanguage(), &error);
1164 ASSERT_NE(nullptr, parse_result);
1165 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001166 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001167 const auto& cpp_constants = interface->GetConstantDeclarations();
1168 EXPECT_EQ((size_t)1, cpp_constants.size());
1169 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001170 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001171 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001172}
1173
Devin Moore7b8d5c92020-03-17 14:14:08 -07001174TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001175 io_delegate_.SetFileContents(
1176 "p/Outer.aidl",
1177 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001178 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001179 const string input_path = "p/IFoo.aidl";
1180 const string input = "package p; import p.Outer; interface IFoo"
1181 " { Outer.Inner get(); }";
1182
Devin Moore7b8d5c92020-03-17 14:14:08 -07001183 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1184 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001185
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001186 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001187 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001188 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1189 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001190}
1191
Devin Moore7b8d5c92020-03-17 14:14:08 -07001192TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001193 io_delegate_.SetFileContents(
1194 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001195 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001196 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001197 const string input_path = "p/IFoo.aidl";
1198 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001199 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1200 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001201 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001202 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1203 native_type.Resolve(typenames_);
1204
1205 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1206 // C++ understands C++ specific stuff
1207 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1208 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001209 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001210 EXPECT_EQ(1u, headers.size());
1211 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001212}
1213
Christopher Wileyf8136192016-04-12 14:19:35 -07001214TEST_F(AidlTest, WritesCorrectDependencyFile) {
1215 // While the in tree build system always gives us an output file name,
1216 // other android tools take advantage of our ability to infer the intended
1217 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001218 vector<string> args = {
1219 "aidl",
1220 "-d dep/file/path",
1221 "-o place/for/output",
1222 "p/IFoo.aidl"};
1223 Options options = Options::From(args);
1224 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001225 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001226 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001227 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001228 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1229}
1230
Dan Willemsen93298ee2016-11-10 23:55:55 -08001231TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1232 // While the in tree build system always gives us an output file name,
1233 // other android tools take advantage of our ability to infer the intended
1234 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001235 vector<string> args = {
1236 "aidl",
1237 "-d dep/file/path",
1238 "--ninja",
1239 "-o place/for/output",
1240 "p/IFoo.aidl"};
1241 Options options = Options::From(args);
1242 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001243 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001244 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001245 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001246 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1247}
1248
Jiyong Parkdf202122019-09-30 20:48:35 +09001249TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001250 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1251 // this by calling aidl with every .aidl file it finds, then parsing the
1252 // generated dependency files. Those that reference .java output files are
1253 // for interfaces and those that do not are parcelables. However, for both
1254 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001255 vector<string> args = {
1256 "aidl",
1257 "-o place/for/output",
1258 "-d dep/file/path",
1259 "p/Foo.aidl"};
1260 Options options = Options::From(args);
1261 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001262 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001263 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001264 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001265 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1266}
1267
1268TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1269 vector<string> args = {
1270 "aidl",
1271 "--structured",
1272 "-o place/for/output",
1273 "-d dep/file/path",
1274 "p/Foo.aidl"};
1275 Options options = Options::From(args);
1276 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1277 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1278 string actual_dep_file_contents;
1279 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1280 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001281}
1282
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001283TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1284 vector<string> args = {
1285 "aidl",
1286 "--lang=java",
1287 "-o place/for/output",
1288 "p/Foo.aidl"};
1289 Options options = Options::From(args);
1290 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1291 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1292 string output_file_contents;
1293 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1294}
1295
Devin Moore21b26772020-08-26 16:37:56 -07001296TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001297 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001298 const string list_array_parcelable =
1299 "package a; parcelable Foo {\n"
1300 " List[] lists; }";
1301 CaptureStderr();
1302 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1304}
1305
Jiyong Parkf8d53612020-05-04 14:06:13 +09001306TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1307 AidlError error;
1308 string expected_stderr =
1309 "ERROR: a/IFoo.aidl:2.7-11: "
1310 "Encountered an untyped List or Map. The use of untyped List/Map is "
1311 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1312 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1313 if (GetLanguage() != Options::Language::JAVA) {
1314 expected_stderr =
1315 "ERROR: a/IFoo.aidl:2.1-7: "
1316 "Currently, only the Java backend supports non-generic List.\n";
1317 }
1318
1319 const string primitive_interface =
1320 "package a; interface IFoo {\n"
1321 " List foo(); }";
1322 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001323 AidlTypenames tn1;
1324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001325 {"--structured"}));
1326 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001327
1328 string primitive_parcelable =
1329 "package a; parcelable IFoo {\n"
1330 " List foo;}";
1331 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001332 AidlTypenames tn2;
1333 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001334 {"--structured"}));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336}
1337
Jeongik Cha225519b2020-08-29 01:55:32 +09001338TEST_P(AidlTest, ExtensionTest) {
1339 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001340 string extendable_parcelable =
1341 "package a; parcelable Data {\n"
1342 " ParcelableHolder extension;\n"
1343 " ParcelableHolder extension2;\n"
1344 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001345 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001346 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1347 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001348 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001349 "yet.\n",
1350 GetCapturedStderr());
1351 } else {
1352 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1353 EXPECT_EQ("", GetCapturedStderr());
1354 }
1355}
1356TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1357 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001358 string parcelableholder_return_interface =
1359 "package a; interface IFoo {\n"
1360 " ParcelableHolder foo();\n"
1361 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001362 EXPECT_EQ(nullptr,
1363 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001364
Jeongik Cha8f02a532020-10-14 00:16:28 +09001365 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001366 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001367 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001368 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001369 "yet.\n",
1370 GetCapturedStderr());
1371 return;
1372 }
1373 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1374 GetCapturedStderr());
1375}
1376
1377TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1378 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001379 string extendable_parcelable_arg_interface =
1380 "package a; interface IFoo {\n"
1381 " void foo(in ParcelableHolder ph);\n"
1382 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001383 EXPECT_EQ(nullptr,
1384 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1385
Jeongik Cha8f02a532020-10-14 00:16:28 +09001386 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001387 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001388 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001389 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001390 "yet.\n",
1391 GetCapturedStderr());
1392 return;
1393 }
1394 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1395 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001396}
1397
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001398TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1399 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001400 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001401 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1402 CaptureStderr();
1403 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1404 if (GetLanguage() == Options::Language::RUST) {
1405 EXPECT_EQ(
1406 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1407 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1408 "yet.\n",
1409 GetCapturedStderr());
1410 return;
1411 }
1412 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1413}
1414
Jooyung Han3f347ca2020-12-01 12:41:50 +09001415TEST_P(AidlTest, ParcelablesWithConstants) {
1416 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001417 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001418 CaptureStderr();
1419 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1420 EXPECT_EQ("", GetCapturedStderr());
1421}
1422
1423TEST_P(AidlTest, UnionWithConstants) {
1424 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001425 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001426 CaptureStderr();
1427 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1428 EXPECT_EQ("", GetCapturedStderr());
1429}
1430
Jiyong Park02da7422018-07-16 16:00:26 +09001431TEST_F(AidlTest, ApiDump) {
1432 io_delegate_.SetFileContents(
1433 "foo/bar/IFoo.aidl",
1434 "package foo.bar;\n"
1435 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001436 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001437 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001438 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001439 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1440 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1441 " IFoo foo3(IFoo foo);\n"
1442 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001443 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001444 " const int A = 1;\n"
1445 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001446 "}\n");
1447 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1448 "package foo.bar;\n"
1449 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001450 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001451 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001452 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001453 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001454 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001455 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001456 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001457 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001458 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001459 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001460 "}\n");
1461 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001462 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1463 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001464 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001465 bool result = dump_api(options, io_delegate_);
1466 ASSERT_TRUE(result);
1467 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001468 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001469 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001470/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001471interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001472 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001473 int foo(out int[] a, String b, boolean c, inout List<String> d);
1474 int foo2(@utf8InCpp String x, inout List<String> y);
1475 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1476 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001477 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001478 const int A = 1;
1479 const String STR = "Hello";
1480}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001481)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001482
Jiyong Parke59c3682018-09-11 23:10:25 +09001483 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001484 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001485/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001486parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001487 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001488 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001489 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001490 int y;
1491 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001492 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001493 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001494}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001495)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001496}
1497
Jiyong Parked65bf42018-08-28 15:43:27 +09001498TEST_F(AidlTest, ApiDumpWithManualIds) {
1499 io_delegate_.SetFileContents(
1500 "foo/bar/IFoo.aidl",
1501 "package foo.bar;\n"
1502 "interface IFoo {\n"
1503 " int foo() = 1;\n"
1504 " int bar() = 2;\n"
1505 " int baz() = 10;\n"
1506 "}\n");
1507
Jiyong Parke59c3682018-09-11 23:10:25 +09001508 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001509 Options options = Options::From(args);
1510 bool result = dump_api(options, io_delegate_);
1511 ASSERT_TRUE(result);
1512 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001513 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001514 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001515interface IFoo {
1516 int foo() = 1;
1517 int bar() = 2;
1518 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001519}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001520)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001521}
1522
1523TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001524 const string expected_stderr =
1525 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1526 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001527 io_delegate_.SetFileContents(
1528 "foo/bar/IFoo.aidl",
1529 "package foo.bar;\n"
1530 "interface IFoo {\n"
1531 " int foo() = 1;\n"
1532 " int bar();\n"
1533 " int baz() = 10;\n"
1534 "}\n");
1535
Jiyong Parke59c3682018-09-11 23:10:25 +09001536 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001537 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001538 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001539 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001541}
1542
Jooyung Han965e31d2020-11-27 12:30:16 +09001543TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1544 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1545 "package foo.bar;\n"
1546 "interface IFoo {\n"
1547 " @utf8InCpp String foo();\n"
1548 " const @utf8InCpp String bar = \"bar\";\n"
1549 "}\n");
1550
1551 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1552 Options options = Options::From(args);
1553 CaptureStderr();
1554 EXPECT_TRUE(dump_api(options, io_delegate_));
1555 EXPECT_EQ("", GetCapturedStderr());
1556 string actual;
1557 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001558 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1559interface IFoo {
1560 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001561 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001562}
1563)"),
1564 actual);
1565}
1566
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001567TEST_F(AidlTest, ApiDumpWithEnums) {
1568 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1569 "package foo.bar;\n"
1570 "enum Enum {\n"
1571 " FOO,\n"
1572 " BAR = FOO + 1,\n"
1573 "}\n");
1574
1575 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1576 Options options = Options::From(args);
1577 CaptureStderr();
1578 EXPECT_TRUE(dump_api(options, io_delegate_));
1579 EXPECT_EQ("", GetCapturedStderr());
1580 string actual;
1581 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1582 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1583 "enum Enum {\n"
1584 " FOO = 0,\n"
1585 " BAR = 1,\n"
1586 "}\n"),
1587 actual);
1588}
1589
1590TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1591 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1592 "package foo.bar;\n"
1593 "enum Enum {\n"
1594 " FOO,\n"
1595 "}\n");
1596 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1597 "package foo.bar;\n"
1598 "import foo.bar.Enum;\n"
1599 "parcelable Foo {\n"
1600 " Enum e = Enum.FOO;\n"
1601 "}\n");
1602
1603 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1604 Options options = Options::From(args);
1605 CaptureStderr();
1606 EXPECT_TRUE(dump_api(options, io_delegate_));
1607 EXPECT_EQ("", GetCapturedStderr());
1608 string actual;
1609 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1610 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1611 "parcelable Foo {\n"
1612 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1613 "}\n"),
1614 actual);
1615}
1616
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001617TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001618 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001619 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1620 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001621 const string expected_map_stderr =
1622 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001623 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1624 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001625 "package p; interface IFoo {"
1626 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001627 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001628 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001629 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001630
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001631 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001632 "package p; interface IFoo {"
1633 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001634 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001635 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001637}
1638
Jeongik Chae48d9942020-01-02 17:39:00 +09001639TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001640 const string expected_stderr =
1641 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001642 Options options = Options::From("aidl -I p p/IFoo.aidl");
1643 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1644
1645 io_delegate_.SetFileContents("p/IFoo.aidl",
1646 "package p; interface IFoo {"
1647 "Map<String, Bar> foo();}");
1648 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1649
1650 io_delegate_.SetFileContents("p/IFoo.aidl",
1651 "package p; interface IFoo {"
1652 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001653 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001654 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001656
1657 io_delegate_.SetFileContents("p/IFoo.aidl",
1658 "package p; interface IFoo {"
1659 "Map<String, String> foo();}");
1660 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1661
1662 io_delegate_.SetFileContents("p/IFoo.aidl",
1663 "package p; interface IFoo {"
1664 "Map<String, ParcelFileDescriptor> foo();}");
1665 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1666}
1667
Jeongik Chadf76dc72019-11-28 00:08:47 +09001668TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001669 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001670 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1671 io_delegate_.SetFileContents(options.InputFiles().front(),
1672 "package p; interface IFoo {"
1673 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001674 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001675 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001676 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677}
1678
1679TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1680 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1681 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001682 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001683 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001684 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1685 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686
1687 Options options = Options::From("aidl -I p p/IFoo.aidl");
1688 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1689 io_delegate_.SetFileContents("p/IFoo.aidl",
1690 "package p; interface IFoo {"
1691 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001692 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001693 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001694 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001695 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001696 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001697 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001698 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1699 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001700 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1701 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1702 io_delegate_.SetFileContents("p/IFoo.aidl",
1703 "package p; interface IFoo {"
1704 "Bar<String, ParcelFileDescriptor> foo();}");
1705 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001706
1707 io_delegate_.SetFileContents("p/IFoo.aidl",
1708 "package p; interface IFoo {"
1709 "Bar<int, long> foo();}");
1710
1711 io_delegate_.SetFileContents("p/IFoo.aidl",
1712 "package p; interface IFoo {"
1713 "Bar<int[], long[]> foo();}");
1714
1715 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001716}
1717
Jeongik Cha0e426012019-07-29 15:57:02 +09001718TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1719 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001720 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1721 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001722 for (const auto& rawOption : rawOptions) {
1723 string expected_stderr =
1724 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001725 Options options = Options::From(rawOption);
1726 io_delegate_.SetFileContents(options.InputFiles().front(),
1727 "package foo.bar;\n"
1728 "interface IFoo1 { int foo(); }\n"
1729 "interface IFoo2 { int foo(); }\n"
1730 "parcelable Data1 { int a; int b;}\n"
1731 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001732 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001733 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001734 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001735
Jeongik Cha0e426012019-07-29 15:57:02 +09001736 io_delegate_.SetFileContents(options.InputFiles().front(),
1737 "package foo.bar;\n"
1738 "interface IFoo1 { int foo(); }\n"
1739 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001740 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001741 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001743
Devin Moore5de18ed2020-04-02 13:52:29 -07001744 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001745 io_delegate_.SetFileContents(options.InputFiles().front(),
1746 "package foo.bar;\n"
1747 "parcelable Data1 { int a; int b;}\n"
1748 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001749 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001750 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001752 }
1753}
1754
Devin Moorebdba2a82020-03-31 15:19:02 -07001755TEST_P(AidlTest, FailParseOnEmptyFile) {
1756 const string contents = "";
1757 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1758 CaptureStderr();
1759 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1760 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1761}
1762
Jiyong Parkb034bf02018-07-30 17:44:33 +09001763TEST_F(AidlTest, MultipleInputFiles) {
1764 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001765 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001766
1767 io_delegate_.SetFileContents(options.InputFiles().at(0),
1768 "package foo.bar;\n"
1769 "import foo.bar.Data;\n"
1770 "interface IFoo { Data getData(); }\n");
1771
1772 io_delegate_.SetFileContents(options.InputFiles().at(1),
1773 "package foo.bar;\n"
1774 "import foo.bar.IFoo;\n"
1775 "parcelable Data { IFoo foo; }\n");
1776
1777 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1778
1779 string content;
1780 for (const auto file : {
1781 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1782 content.clear();
1783 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1784 EXPECT_FALSE(content.empty());
1785 }
1786}
1787
1788TEST_F(AidlTest, MultipleInputFilesCpp) {
1789 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001790 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001791
1792 io_delegate_.SetFileContents(options.InputFiles().at(0),
1793 "package foo.bar;\n"
1794 "import foo.bar.Data;\n"
1795 "interface IFoo { Data getData(); }\n");
1796
1797 io_delegate_.SetFileContents(options.InputFiles().at(1),
1798 "package foo.bar;\n"
1799 "import foo.bar.IFoo;\n"
1800 "parcelable Data { IFoo foo; }\n");
1801
1802 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1803
1804 string content;
1805 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001806 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001807 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1808 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1809 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1810 content.clear();
1811 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1812 EXPECT_FALSE(content.empty());
1813 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001814}
1815
Andrei Homescub62afd92020-05-11 19:24:59 -07001816TEST_F(AidlTest, MultipleInputFilesRust) {
1817 Options options =
1818 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1819
1820 io_delegate_.SetFileContents(options.InputFiles().at(0),
1821 "package foo.bar;\n"
1822 "import foo.bar.Data;\n"
1823 "interface IFoo { Data getData(); }\n");
1824
1825 io_delegate_.SetFileContents(options.InputFiles().at(1),
1826 "package foo.bar;\n"
1827 "import foo.bar.IFoo;\n"
1828 "parcelable Data { IFoo foo; }\n");
1829
1830 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1831
1832 string content;
1833 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1834 content.clear();
1835 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1836 EXPECT_FALSE(content.empty());
1837 }
1838}
1839
Devin Moore097a3ab2020-03-11 16:08:44 -07001840TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1841 const string expected_stderr =
1842 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001843 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1844 // int getInterfaceVersion() is one of the meta transactions
1845 io_delegate_.SetFileContents(options.InputFiles().front(),
1846 "package p; interface IFoo {"
1847 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001848 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001849 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1851}
Jiyong Park309668e2018-07-28 16:55:44 +09001852
Devin Moore097a3ab2020-03-11 16:08:44 -07001853TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1854 // boolean getInterfaceVersion() is not a meta transaction, but should be
1855 // prevented because return type is not part of a method signature
1856 const string expected_stderr =
1857 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1858 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001859 io_delegate_.SetFileContents(options.InputFiles().front(),
1860 "package p; interface IFoo {"
1861 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001862 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001863 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001864 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1865}
Jiyong Park309668e2018-07-28 16:55:44 +09001866
Devin Moore097a3ab2020-03-11 16:08:44 -07001867TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001868 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001869 const string expected_stderr =
1870 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1871 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001872 io_delegate_.SetFileContents(options.InputFiles().front(),
1873 "package p; interface IFoo {"
1874 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001875 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001876 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001878
1879 // this is not a meta interface method as it differs type arguments
1880 io_delegate_.SetFileContents(options.InputFiles().front(),
1881 "package p; interface IFoo {"
1882 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001883 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001884}
1885
Daniel Norman85aed542019-08-21 12:01:14 -07001886TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001887 Options options = Options::From("aidl --checkapi old new");
1888 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1889 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1890 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1891 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1892
1893 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1894}
1895
Jiyong Park3656c3c2018-08-01 20:02:01 +09001896TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001897 Options options = Options::From("aidl --checkapi old new");
1898 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1899 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001900
1901 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1902}
1903
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001904TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1905 Options options = Options::From("aidl --checkapi old new");
1906 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1907 const string enum_definition = "package p; enum Enum { FOO }";
1908 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1909 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1910 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1911 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1912
1913 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1914}
1915
Daniel Norman85aed542019-08-21 12:01:14 -07001916class AidlTestCompatibleChanges : public AidlTest {
1917 protected:
1918 Options options_ = Options::From("aidl --checkapi old new");
1919};
1920
1921TEST_F(AidlTestCompatibleChanges, NewType) {
1922 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1923 "package p;"
1924 "interface IFoo {"
1925 " void foo(int a);"
1926 "}");
1927 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1928 "package p;"
1929 "interface IFoo {"
1930 " void foo(int a);"
1931 "}");
1932 io_delegate_.SetFileContents("new/p/IBar.aidl",
1933 "package p;"
1934 "interface IBar {"
1935 " void bar();"
1936 "}");
1937 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1938}
1939
1940TEST_F(AidlTestCompatibleChanges, NewMethod) {
1941 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1942 "package p;"
1943 "interface IFoo {"
1944 " void foo(int a);"
1945 "}");
1946 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1947 "package p;"
1948 "interface IFoo {"
1949 " void foo(int a);"
1950 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001951 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001952 "}");
1953 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1954}
1955
1956TEST_F(AidlTestCompatibleChanges, NewField) {
1957 io_delegate_.SetFileContents("old/p/Data.aidl",
1958 "package p;"
1959 "parcelable Data {"
1960 " int foo;"
1961 "}");
1962 io_delegate_.SetFileContents("new/p/Data.aidl",
1963 "package p;"
1964 "parcelable Data {"
1965 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001966 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001967 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001968 "}");
1969 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1970}
1971
1972TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1973 io_delegate_.SetFileContents("old/p/Enum.aidl",
1974 "package p;"
1975 "enum Enum {"
1976 " FOO = 1,"
1977 "}");
1978 io_delegate_.SetFileContents("new/p/Enum.aidl",
1979 "package p;"
1980 "enum Enum {"
1981 " FOO = 1,"
1982 " BAR = 2,"
1983 "}");
1984 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1985}
1986
1987TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1988 io_delegate_.SetFileContents("old/p/Enum.aidl",
1989 "package p;"
1990 "enum Enum {"
1991 " FOO = 1,"
1992 " BAR = 2,"
1993 "}");
1994 io_delegate_.SetFileContents("new/p/Enum.aidl",
1995 "package p;"
1996 "enum Enum {"
1997 " BAR = 2,"
1998 " FOO = 1,"
1999 "}");
2000 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2001}
2002
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002003TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2004 io_delegate_.SetFileContents("old/p/Union.aidl",
2005 "package p;"
2006 "union Union {"
2007 " String foo;"
2008 "}");
2009 io_delegate_.SetFileContents("new/p/Union.aidl",
2010 "package p;"
2011 "union Union {"
2012 " String foo;"
2013 " int num;"
2014 "}");
2015 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2016}
2017
Daniel Norman85aed542019-08-21 12:01:14 -07002018TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002019 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2020 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002021 "interface IFoo {"
2022 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002023 "}");
2024 io_delegate_.SetFileContents("old/p/Data.aidl",
2025 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002026 "parcelable Data {"
2027 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002028 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002029 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2030 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002031 "interface IFoo {"
2032 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002033 "}");
2034 io_delegate_.SetFileContents("new/p/Data.aidl",
2035 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002036 "parcelable Data {"
2037 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002038 "}");
2039 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2040 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002041 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002042 " void foo(int a);"
2043 "}");
2044 io_delegate_.SetFileContents("new/q/Data.aidl",
2045 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002046 "parcelable Data {"
2047 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002048 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002049 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2050}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002051
Daniel Norman85aed542019-08-21 12:01:14 -07002052TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2053 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2054 "package p;"
2055 "interface IFoo {"
2056 " void foo(int a);"
2057 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002058 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2059 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002060 "interface IFoo {"
2061 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002062 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002063 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2064}
Jiyong Parke59c3682018-09-11 23:10:25 +09002065
Daniel Norman85aed542019-08-21 12:01:14 -07002066TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002067 io_delegate_.SetFileContents("old/p/I.aidl",
2068 "package p; interface I {"
2069 "const int A = 1; }");
2070 io_delegate_.SetFileContents("new/p/I.aidl",
2071 "package p ; interface I {"
2072 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002073 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2074}
Jiyong Parka428d212018-08-29 22:26:30 +09002075
Daniel Norman85aed542019-08-21 12:01:14 -07002076TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 io_delegate_.SetFileContents("old/p/I.aidl",
2078 "package p; interface I {"
2079 "const int A = 1; const int B = 2;}");
2080 io_delegate_.SetFileContents("new/p/I.aidl",
2081 "package p ; interface I {"
2082 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002083 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002084}
2085
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002086TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2087 io_delegate_.SetFileContents("old/p/Foo.aidl",
2088 "package p;"
2089 "@JavaPassthrough(annotation=\"Alice\")"
2090 "@JavaPassthrough(annotation=\"Bob\")"
2091 "parcelable Foo {}");
2092 io_delegate_.SetFileContents("new/p/Foo.aidl",
2093 "package p;"
2094 "@JavaPassthrough(annotation=\"Bob\")"
2095 "@JavaPassthrough(annotation=\"Alice\")"
2096 "parcelable Foo {}");
2097 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2098}
2099
Jooyung Han00073272020-11-27 14:20:20 +09002100TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2101 io_delegate_.SetFileContents("old/p/Foo.aidl",
2102 "package p;"
2103 "parcelable Foo {}");
2104 io_delegate_.SetFileContents("new/p/Foo.aidl",
2105 "package p;"
2106 "@JavaPassthrough(annotation=\"@Deprecated\")"
2107 "parcelable Foo {}");
2108 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2109}
2110
Jooyung Han636fd2f2020-10-22 11:33:45 +09002111TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2112 io_delegate_.SetFileContents("old/p/Data.aidl",
2113 "package p;"
2114 "parcelable Data {"
2115 " int num;"
2116 "}");
2117 io_delegate_.SetFileContents(
2118 "new/p/Data.aidl",
2119 "package p;"
2120 "parcelable Data {"
2121 " int num;"
2122 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2123 "}");
2124 io_delegate_.SetFileContents("new/p/Enum.aidl",
2125 "package p;"
2126 "enum Enum {"
2127 " FOO = 0,"
2128 " BAR = 1,"
2129 "}");
2130 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2131}
2132
Daniel Norman85aed542019-08-21 12:01:14 -07002133class AidlTestIncompatibleChanges : public AidlTest {
2134 protected:
2135 Options options_ = Options::From("aidl --checkapi old new");
2136};
2137
2138TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002139 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002140 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2141 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002142 "interface IFoo {"
2143 " void foo(in String[] str);"
2144 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002145 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002146 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002147 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002148 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002149}
2150
2151TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002152 const string expected_stderr =
2153 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002154 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2155 "package p;"
2156 "interface IFoo {"
2157 " void foo(in String[] str);"
2158 " void bar(@utf8InCpp String str);"
2159 "}");
2160 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2161 "package p;"
2162 "interface IFoo {"
2163 " void foo(in String[] str);"
2164 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002165 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002166 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002167 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002168}
2169
Jiyong Parkf8d53612020-05-04 14:06:13 +09002170TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2171 const string expected_stderr =
2172 "ERROR: new/p/IFoo.aidl:1.61-65: "
2173 "Encountered an untyped List or Map. The use of untyped List/Map is "
2174 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2175 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2176 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2177 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2178 "package p;"
2179 "interface IFoo {"
2180 " void foo(in String[] str);"
2181 "}");
2182 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2183 "package p;"
2184 "interface IFoo {"
2185 " void foo(in String[] str);"
2186 " void bar(in List arg);"
2187 "}");
2188 CaptureStderr();
2189 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2191}
2192
2193TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2194 const string expected_stderr =
2195 "ERROR: new/p/Data.aidl:1.54-59: "
2196 "Encountered an untyped List or Map. The use of untyped List/Map is "
2197 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2198 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2199 "ERROR: new/p/Data.aidl: Failed to read.\n";
2200 io_delegate_.SetFileContents("old/p/Data.aidl",
2201 "package p;"
2202 "parcelable Data {"
2203 " int foo;"
2204 "}");
2205 io_delegate_.SetFileContents("new/p/Data.aidl",
2206 "package p;"
2207 "parcelable Data {"
2208 " int foo;"
2209 " @nullable List list;"
2210 "}");
2211 CaptureStderr();
2212 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2213 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2214}
2215
Daniel Norman85aed542019-08-21 12:01:14 -07002216TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002217 const string expected_stderr =
2218 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002219 io_delegate_.SetFileContents("old/p/Data.aidl",
2220 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002221 "parcelable Data {"
2222 " int foo;"
2223 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002224 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002225 io_delegate_.SetFileContents("new/p/Data.aidl",
2226 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002227 "parcelable Data {"
2228 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002229 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002230 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002231 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002233}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002234
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002235TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2236 const string expected_stderr =
2237 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2238 "backends. Please either provide a default value for this field or mark the field as "
2239 "@nullable. This value or a null value will be used automatically when an old version of "
2240 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2241 "order to make sure your code continues to be backwards compatible, make sure the default or "
2242 "null value does not cause a semantic change to this parcelable.\n";
2243 io_delegate_.SetFileContents("old/p/Data.aidl",
2244 "package p;"
2245 "parcelable Data {"
2246 " int num;"
2247 "}");
2248 io_delegate_.SetFileContents("new/p/Data.aidl",
2249 "package p;"
2250 "parcelable Data {"
2251 " int num;"
2252 " String str;"
2253 "}");
2254 CaptureStderr();
2255 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2257}
2258
Jooyung Han636fd2f2020-10-22 11:33:45 +09002259TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2260 const string expected_stderr =
2261 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2262 "Please make sure 'Enum' has '0' as a valid value.\n";
2263 io_delegate_.SetFileContents("old/p/Data.aidl",
2264 "package p;"
2265 "parcelable Data {"
2266 " int num;"
2267 "}");
2268 io_delegate_.SetFileContents("new/p/Data.aidl",
2269 "package p;"
2270 "parcelable Data {"
2271 " int num;"
2272 " p.Enum e;"
2273 "}");
2274 io_delegate_.SetFileContents("new/p/Enum.aidl",
2275 "package p;"
2276 "enum Enum {"
2277 " FOO = 1,"
2278 " BAR = 2,"
2279 "}");
2280 CaptureStderr();
2281 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2282 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2283}
2284
Daniel Norman85aed542019-08-21 12:01:14 -07002285TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002286 const string expected_stderr =
2287 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002288 io_delegate_.SetFileContents("old/p/Enum.aidl",
2289 "package p;"
2290 "enum Enum {"
2291 " FOO = 1,"
2292 " BAR = 2,"
2293 "}");
2294 io_delegate_.SetFileContents("new/p/Enum.aidl",
2295 "package p;"
2296 "enum Enum {"
2297 " BAR = 2,"
2298 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002299 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002300 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002301 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002302}
2303
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002304TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2305 const string expected_stderr =
2306 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2307 io_delegate_.SetFileContents("old/p/Union.aidl",
2308 "package p;"
2309 "union Union {"
2310 " String str;"
2311 " int num;"
2312 "}");
2313 io_delegate_.SetFileContents("new/p/Union.aidl",
2314 "package p;"
2315 "union Union {"
2316 " String str;"
2317 "}");
2318 CaptureStderr();
2319 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2321}
2322
Daniel Norman85aed542019-08-21 12:01:14 -07002323TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002324 const string expected_stderr =
2325 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002326 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2327 "package p;"
2328 "interface IFoo {"
2329 " void foo(in String[] str);"
2330 " void bar(@utf8InCpp String str);"
2331 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002332 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2333 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002334 "interface IFoo {"
2335 " void foo(in String[] str);"
2336 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002337 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002338 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002339 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002341}
2342
Daniel Norman85aed542019-08-21 12:01:14 -07002343TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002345 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2346 "package p;"
2347 "interface IFoo {"
2348 " void foo(in String[] str);"
2349 " void bar(@utf8InCpp String str);"
2350 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002351 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2352 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002353 "interface IFoo2 {"
2354 " void foo(in String[] str);"
2355 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002356 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002357 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002358 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002360}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002361
Daniel Norman85aed542019-08-21 12:01:14 -07002362TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002363 const string expected_stderr =
2364 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002365 io_delegate_.SetFileContents("old/p/Enum.aidl",
2366 "package p;"
2367 "enum Enum {"
2368 " FOO = 1,"
2369 " BAR = 2,"
2370 "}");
2371 io_delegate_.SetFileContents("new/p/Enum.aidl",
2372 "package p;"
2373 "enum Enum {"
2374 " FOO = 3,"
2375 " BAR = 2,"
2376 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002377 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002378 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002380}
2381
2382TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 const string expected_stderr =
2384 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2385 "from 0 to 1.\n"
2386 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2387 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002388 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2389 "package p;"
2390 "interface IFoo {"
2391 " void foo(in String[] str);"
2392 " void bar(@utf8InCpp String str);"
2393 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002394 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2395 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002396 "interface IFoo {"
2397 " void bar(@utf8InCpp String str);"
2398 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002399 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002401 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002403}
2404
2405TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002407 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2408 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002409 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002410 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002411 "parcelable Data {"
2412 " int foo;"
2413 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002414 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002415 io_delegate_.SetFileContents("new/p/Data.aidl",
2416 "package p;"
2417 "parcelable Data {"
2418 " int bar;"
2419 " int foo;"
2420 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002421 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002422 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002424}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002425
Daniel Norman85aed542019-08-21 12:01:14 -07002426TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002427 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002428 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002430 "interface IFoo {"
2431 " void foo(in String[] str);"
2432 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002433 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002434 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2435 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002436 "interface IFoo {"
2437 " void foo(out String[] str);"
2438 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002439 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002440 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002441 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002443}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002444
Daniel Norman85aed542019-08-21 12:01:14 -07002445TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002446 const string expected_stderr =
2447 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002448 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2449 "package p;"
2450 "interface IFoo {"
2451 " void foo(in String[] str);"
2452 " void bar(@utf8InCpp String str);"
2453 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002454 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2455 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002456 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002457 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002458 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002459 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002460 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002461 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002462 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002463}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002464
Daniel Norman85aed542019-08-21 12:01:14 -07002465TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002466 const string expected_stderr =
2467 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002468 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2469 "package p;"
2470 "interface IFoo {"
2471 " void foo(in String[] str);"
2472 " void bar(@utf8InCpp String str);"
2473 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2475 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002476 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002477 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002478 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002479 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002480 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002481 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002483}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002484
Jooyung Han60b2fde2020-10-29 15:12:40 +09002485TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2486 const string expected_stderr =
2487 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2488 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2489 io_delegate_.SetFileContents("old/p/Foo.aidl",
2490 "package p;"
2491 "@Backing(type=\"byte\")"
2492 "enum Foo {"
2493 " FOO, BAR,"
2494 "}");
2495 io_delegate_.SetFileContents("new/p/Foo.aidl",
2496 "package p;"
2497 "@Backing(type=\"long\")"
2498 "enum Foo {"
2499 " FOO, BAR,"
2500 "}");
2501 CaptureStderr();
2502 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2504}
2505
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002506TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2507 const string expected_stderr =
2508 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2509 "to @JavaPassthrough(annotation=\"Bob\")\n";
2510 io_delegate_.SetFileContents("old/p/Foo.aidl",
2511 "package p;"
2512 "@JavaPassthrough(annotation=\"Alice\")"
2513 "parcelable Foo {}");
2514 io_delegate_.SetFileContents("new/p/Foo.aidl",
2515 "package p;"
2516 "@JavaPassthrough(annotation=\"Bob\")"
2517 "parcelable Foo {}");
2518
2519 CaptureStderr();
2520 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2522}
2523
Devin Mooredb7ac512020-08-07 11:17:36 -07002524TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2525 const string expected_stderr =
2526 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2527 io_delegate_.SetFileContents("old/p/Foo.aidl",
2528 "package p;"
2529 "parcelable Foo {"
2530 " int A;"
2531 "}");
2532 io_delegate_.SetFileContents("new/p/Foo.aidl",
2533 "package p;"
2534 "@JavaOnlyStableParcelable parcelable Foo {"
2535 " int A;"
2536 "}");
2537 CaptureStderr();
2538 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2540}
2541
2542TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2543 const string expected_stderr =
2544 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2545 io_delegate_.SetFileContents("old/p/Foo.aidl",
2546 "package p;"
2547 "@JavaOnlyStableParcelable parcelable Foo {"
2548 " int A;"
2549 "}");
2550 io_delegate_.SetFileContents("new/p/Foo.aidl",
2551 "package p;"
2552 "parcelable Foo {"
2553 " int A;"
2554 "}");
2555 CaptureStderr();
2556 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2557 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2558}
2559
Daniel Norman85aed542019-08-21 12:01:14 -07002560TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002562 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2563 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002564 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002566 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002568}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002569
Daniel Norman85aed542019-08-21 12:01:14 -07002570TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002571 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002572 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2573 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002574 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002575 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002577}
Jiyong Parka428d212018-08-29 22:26:30 +09002578
Daniel Norman85aed542019-08-21 12:01:14 -07002579TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002580 const string expected_stderr =
2581 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002582 io_delegate_.SetFileContents("old/p/I.aidl",
2583 "package p; interface I {"
2584 "const int A = 1; const int B = 2;}");
2585 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002586 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002587 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002588 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002589}
Jiyong Parka428d212018-08-29 22:26:30 +09002590
Daniel Norman85aed542019-08-21 12:01:14 -07002591TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 const string expected_stderr =
2593 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002594 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2595 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002596 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002597 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002598 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002599}
2600
Devin Moorec7e47a32020-08-07 10:55:25 -07002601TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2602 const string expected_stderr =
2603 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2604 "This is an incompatible change for FixedSize types.\n";
2605 io_delegate_.SetFileContents("old/p/Foo.aidl",
2606 "package p; @FixedSize parcelable Foo { int A = 1; }");
2607 io_delegate_.SetFileContents("new/p/Foo.aidl",
2608 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2609 CaptureStderr();
2610 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2612}
2613
2614TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2615 const string expected_stderr =
2616 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2617 io_delegate_.SetFileContents("old/p/Foo.aidl",
2618 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2619 io_delegate_.SetFileContents("new/p/Foo.aidl",
2620 "package p; @FixedSize parcelable Foo { int A = 1; }");
2621 CaptureStderr();
2622 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2623 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2624}
2625
2626TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2627 const string expected_stderr =
2628 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2629 "a.\n"
2630 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2631 "b.\n"
2632 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2633 "c.\n"
2634 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2635 "d.\n"
2636 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2637 "e.\n"
2638 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2639 "f.\n";
2640
2641 io_delegate_.SetFileContents("Foo.aidl",
2642 "@FixedSize parcelable Foo { "
2643 " int[] a;"
2644 " Bar b;"
2645 " String c;"
2646 " ParcelFileDescriptor d;"
2647 " IBinder e;"
2648 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002649 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002650 "}");
2651 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002652 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002653
2654 CaptureStderr();
2655 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2657}
2658
2659TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2660 const string expected_stderr = "";
2661
2662 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2663 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2664 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002665 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002666
2667 CaptureStderr();
2668 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2669 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2670}
2671
Jiyong Park8c380532018-08-30 14:55:26 +09002672TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002673 const string expected_stderr =
2674 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2675 "dir1/q/IBar.aidl\n"
2676 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002677 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002678 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2679 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2680 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2681 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2682
Devin Moore097a3ab2020-03-11 16:08:44 -07002683 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002684 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002685 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002686}
2687
Jiyong Parked65bf42018-08-28 15:43:27 +09002688TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002689 const string expected_stderr =
2690 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2691 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002692 Options options = Options::From("aidl --checkapi old new");
2693 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2694 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002695
2696 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2697
Jiyong Parke59c3682018-09-11 23:10:25 +09002698 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002699 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002700 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002701 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002702}
2703
Jiyong Parke05195e2018-10-08 18:24:23 +09002704TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2705 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2706 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002707 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002708
2709 // use without import
2710 io_delegate_.SetFileContents("p/IFoo.aidl",
2711 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2712 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2713 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002714 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002715
Devin Moore7b8d5c92020-03-17 14:14:08 -07002716 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002717 io_delegate_.SetFileContents(
2718 "p/IFoo.aidl",
2719 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2720 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2721 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002722 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002723
2724 // use with import (as before)
2725 io_delegate_.SetFileContents("p/IFoo.aidl",
2726 "package p;"
2727 "import android.os.ParcelFileDescriptor;"
2728 "interface IFoo{"
2729 " void foo(in ParcelFileDescriptor fd);"
2730 "}");
2731 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2732 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002733 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002734}
Jiyong Parked65bf42018-08-28 15:43:27 +09002735
Jiyong Park3633b722019-04-11 15:38:26 +09002736TEST_F(AidlTest, ManualIds) {
2737 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2738 io_delegate_.SetFileContents("IFoo.aidl",
2739 "interface IFoo {\n"
2740 " void foo() = 0;\n"
2741 " void bar() = 1;\n"
2742 "}");
2743 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2744}
2745
2746TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2747 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2748 io_delegate_.SetFileContents("IFoo.aidl",
2749 "interface IFoo {\n"
2750 " void foo() = 0;\n"
2751 " void bar() = 1;\n"
2752 "}");
2753 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2754}
2755
2756TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002757 const string expected_stderr =
2758 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002759 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2760 io_delegate_.SetFileContents("IFoo.aidl",
2761 "interface IFoo {\n"
2762 " void foo() = 3;\n"
2763 " void bar() = 3;\n"
2764 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002765 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002766 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002767 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002768}
2769
2770TEST_F(AidlTest, FailOnOutOfRangeIds) {
2771 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002772 const string expected_stderr =
2773 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2774 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002775 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2776 io_delegate_.SetFileContents("IFoo.aidl",
2777 "interface IFoo {\n"
2778 " void foo() = 3;\n"
2779 " void bar() = 16777115;\n"
2780 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002781 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002782 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002783 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002784}
2785
2786TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002787 const string expected_stderr =
2788 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002789 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2790 io_delegate_.SetFileContents("IFoo.aidl",
2791 "interface IFoo {\n"
2792 " void foo() = 3;\n"
2793 " void bar();\n"
2794 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002795 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002796 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002797 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002798}
2799
Jiyong Parkc6816252019-07-08 08:12:28 +09002800TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2801 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2802 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2803 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2804 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2805}
2806
2807TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002808 const string expected_stderr =
2809 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2810 "dir/IBar.aidl\n"
2811 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002812 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002813
Jiyong Parkc6816252019-07-08 08:12:28 +09002814 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2815 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2816 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2817 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002818 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002819 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002821}
2822
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002823TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2824 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2825 "package a.b;\n"
2826 "import a.b.IBar;\n"
2827 "import a.b.IQux;\n"
2828 "interface IFoo { IQux foo(); }\n");
2829 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2830 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2831
2832 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2833 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2834
2835 string output;
2836 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2837 // IBar was imported but wasn't used. include is not expected.
2838 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2839 // IBar was imported and used. include is expected.
2840 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2841}
2842
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002843TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002844 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002845 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002846 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2847 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002848 interface IFoo {
2849 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002850 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002851 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002852 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002853 // JavaPassthrough should work with other types as well (e.g. enum)
2854 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2855 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2856 @JavaPassthrough(annotation="@com.android.AliceTwo")
2857 @Backing(type="byte")
2858 enum MyEnum {
2859 a, b, c
2860 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002861
Jooyung Han4cde01d2020-10-13 11:10:47 +09002862 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002863 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2864
2865 string java_out;
2866 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002867 // type-decl-level annotations with newline at the end
2868 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2869 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2870 // member-decl-level annotations with newline at the end
2871 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2872 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2873 // inline annotations with space at the end
2874 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002875
Jooyung Han4cde01d2020-10-13 11:10:47 +09002876 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2877 // type-decl-level annotations with newline at the end
2878 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2879 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2880
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002881 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002882 Options cpp_options =
2883 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002884 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2885
Jooyung Han4cde01d2020-10-13 11:10:47 +09002886 Options ndk_options =
2887 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002888 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002889
Jooyung Han4cde01d2020-10-13 11:10:47 +09002890 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002891 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002892}
2893
Andrei Homescue61feb52020-08-18 15:44:24 -07002894TEST_F(AidlTest, ParseRustDerive) {
2895 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2896 @RustDerive(Clone=true, Copy=false)
2897 parcelable Foo {
2898 int a;
2899 })");
2900
2901 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2902 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2903
2904 string rust_out;
2905 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2906 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2907
2908 // Other backends shouldn't be bothered
2909 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2910 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2911
2912 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2913 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2914
2915 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2916 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2917}
2918
Jiyong Park56f73d72019-06-11 12:20:28 +09002919class AidlOutputPathTest : public AidlTest {
2920 protected:
2921 void SetUp() override {
2922 AidlTest::SetUp();
2923 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2924 }
2925
2926 void Test(const Options& options, const std::string expected_output_path) {
2927 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2928 // check the existence
2929 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2930 }
2931};
2932
2933TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2934 // <out_dir> / <package_name> / <type_name>.java
2935 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2936}
2937
2938TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2939 // when output file is explicitly set, it is always respected. -o option is
2940 // ignored.
2941 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2942}
2943
2944TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2945 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2946}
2947
2948TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2949 // output is the same as the input file except for the suffix
2950 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2951}
2952
Devin Moore7b8d5c92020-03-17 14:14:08 -07002953TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002954 AidlError error;
2955 const string expected_stderr =
2956 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2957 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002958 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2959 R"(package p;
2960 interface IFoo {
2961 const int int32_max_oob = 2147483650;
2962 }
2963 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002964 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002965 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2966 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002967}
2968
Devin Moore7b8d5c92020-03-17 14:14:08 -07002969TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002970 AidlError error;
2971 const string expected_stderr =
2972 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2973 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002974 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2975 R"(package p;
2976 interface IFoo {
2977 const int int32_min_oob = -2147483650;
2978 }
2979 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002980 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002981 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2982 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002983}
2984
Devin Moore7b8d5c92020-03-17 14:14:08 -07002985TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002986 AidlError error;
2987 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002988 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002989 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002990 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2991 R"(package p;
2992 interface IFoo {
2993 const long int64_max_oob = 21474836509999999999999999;
2994 }
2995 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002996 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002997 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2998 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002999}
3000
Devin Moore7b8d5c92020-03-17 14:14:08 -07003001TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003002 AidlError error;
3003 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003004 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003005 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003006 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3007 R"(package p;
3008 interface IFoo {
3009 const long int64_min_oob = -21474836509999999999999999;
3010 }
3011 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003012 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3014 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003015}
3016
Devin Moore7b8d5c92020-03-17 14:14:08 -07003017TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003019 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003020 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003021 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3022 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003023 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3024 R"(package p;
3025 @Backing(type="byte")
3026 enum TestEnum {
3027 FOO = 127,
3028 BAR,
3029 }
3030 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003031 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003032 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003033 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003034}
3035
Devin Mooredecaf292020-04-30 09:16:40 -07003036TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3037 AidlError error;
3038 const string expected_stderr =
3039 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003040 "be one of: type\n";
3041 CaptureStderr();
3042 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3043 R"(package p;
3044 @Backing(foo="byte")
3045 enum TestEnum {
3046 FOO = 1,
3047 BAR,
3048 }
3049 )",
3050 typenames_, GetLanguage(), &error));
3051 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3052 EXPECT_EQ(AidlError::BAD_TYPE, error);
3053}
3054
Jooyung Han5721a232020-12-24 04:34:55 +09003055TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3056 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3057 CaptureStderr();
3058 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3059 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3060}
3061
Jooyung Han66813932020-10-23 13:24:44 +09003062TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003063 io_delegate_.SetFileContents("Foo.aidl",
3064 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3065 "Map<String, Baz> d; Bar[] e; }");
3066 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3067 io_delegate_.SetFileContents("Baz.aidl",
3068 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003069 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3070 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3071}
3072
Jooyung Han66813932020-10-23 13:24:44 +09003073TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003074 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003075 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003076 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003077 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3078 "named 'bar'.\n";
3079 CaptureStderr();
3080 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3081 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3082 EXPECT_EQ(expected_error, GetCapturedStderr());
3083}
3084
3085TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3086 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3087 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3088 string expected_error =
3089 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003090 "named 'bar'.\n";
3091 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003092 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3093 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003094 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003095}
3096
Jooyung Han66813932020-10-23 13:24:44 +09003097TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003098 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003099 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3100 string expected_error =
3101 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3102 "only be an in parameter.\n";
3103 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003104 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3105 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003106 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003107}
3108
Jooyung Han66813932020-10-23 13:24:44 +09003109TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003110 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003111 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3112 string expected_error =
3113 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3114 "only be an in parameter.\n";
3115 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003116 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3117 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003118 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003119}
3120
Jooyung Han66813932020-10-23 13:24:44 +09003121TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003122 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003123 Options options = Options::From("aidl --lang=java Foo.aidl");
3124 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003125 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3126 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003127 CaptureStderr();
3128 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3129 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3130}
Devin Moore53fc99c2020-08-12 08:07:52 -07003131
Jooyung Han1f14ab32020-10-14 13:48:29 +09003132const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3133
3134#include <a/ByteEnum.h>
3135#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003136#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003138#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003139#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003140#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003141#include <locale>
3142#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003143#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003144#include <utility>
3145#include <variant>
3146#include <vector>
3147
Jooyung Handf39e192020-11-23 15:59:46 +09003148#ifndef __BIONIC__
3149#define __assert2(a,b,c,d) ((void)0)
3150#endif
3151
Jooyung Han1f14ab32020-10-14 13:48:29 +09003152namespace a {
3153
3154class Foo : public ::android::Parcelable {
3155public:
Jooyung Han97945de2020-10-15 16:41:38 +09003156 inline bool operator!=(const Foo& rhs) const {
3157 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003158 }
Jooyung Han97945de2020-10-15 16:41:38 +09003159 inline bool operator<(const Foo& rhs) const {
3160 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003161 }
Jooyung Han97945de2020-10-15 16:41:38 +09003162 inline bool operator<=(const Foo& rhs) const {
3163 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003164 }
Jooyung Han97945de2020-10-15 16:41:38 +09003165 inline bool operator==(const Foo& rhs) const {
3166 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003167 }
Jooyung Han97945de2020-10-15 16:41:38 +09003168 inline bool operator>(const Foo& rhs) const {
3169 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003170 }
Jooyung Han97945de2020-10-15 16:41:38 +09003171 inline bool operator>=(const Foo& rhs) const {
3172 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003173 }
Jooyung Han97945de2020-10-15 16:41:38 +09003174
Jooyung Han1f14ab32020-10-14 13:48:29 +09003175 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003176 ns = 0, // int[] ns;
3177 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003178 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003179 };
Jooyung Han97945de2020-10-15 16:41:38 +09003180
Jooyung Han1f14ab32020-10-14 13:48:29 +09003181 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003182 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003183
3184 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003185 Foo(const Foo&) = default;
3186 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187 Foo& operator=(const Foo&) = default;
3188 Foo& operator=(Foo&&) = default;
3189
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003190 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3191 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003192 constexpr Foo(_Tp&& _arg)
3193 : _value(std::forward<_Tp>(_arg)) {}
3194
3195 template <typename... _Tp>
3196 constexpr explicit Foo(_Tp&&... _args)
3197 : _value(std::forward<_Tp>(_args)...) {}
3198
3199 template <Tag _tag, typename... _Tp>
3200 static Foo make(_Tp&&... _args) {
3201 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003202 }
Jooyung Han97945de2020-10-15 16:41:38 +09003203
3204 template <Tag _tag, typename _Tp, typename... _Up>
3205 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3206 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003207 }
3208
3209 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003210 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003211 }
3212
Jooyung Han97945de2020-10-15 16:41:38 +09003213 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003214 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003215 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003216 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003217 }
3218
Jooyung Han97945de2020-10-15 16:41:38 +09003219 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003220 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003221 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003222 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003223 }
3224
Jooyung Han97945de2020-10-15 16:41:38 +09003225 template <Tag _tag, typename... _Tp>
3226 void set(_Tp&&... _args) {
3227 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003228 }
3229
3230 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3231 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3232 static const std::string& getParcelableDescriptor() {
3233 static const std::string DESCIPTOR = "a.Foo";
3234 return DESCIPTOR;
3235 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003236 template <typename _T> class _has_toString {
3237 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3238 template <typename _U> static std::false_type __has_toString(...);
3239 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3240 };
3241 template <typename _T> inline static std::string _call_toString(const _T& t) {
3242 if constexpr (_has_toString<_T>::value) return t.toString();
3243 return "{no toString() implemented}";
3244 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003245 inline std::string toString() const {
3246 std::ostringstream os;
3247 os << "Foo{";
3248 switch (getTag()) {
3249 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3250 case e: os << "e: " << a::toString(get<e>()); break;
3251 case pfd: os << "pfd: " << ""; break;
3252 }
3253 os << "}";
3254 return os.str();
3255 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003256private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003257 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003258}; // class Foo
3259
3260} // namespace a
3261)";
3262
3263const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3264
3265namespace a {
3266
3267::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3268 ::android::status_t _aidl_ret_status;
3269 int32_t _aidl_tag;
3270 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3271 switch (_aidl_tag) {
3272 case ns: {
3273 ::std::vector<int32_t> _aidl_value;
3274 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003275 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3276 set<ns>(_aidl_value);
3277 } else {
3278 // NOLINTNEXTLINE(performance-move-const-arg)
3279 set<ns>(std::move(_aidl_value));
3280 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003281 return ::android::OK; }
3282 case e: {
3283 ::a::ByteEnum _aidl_value;
3284 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003285 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3286 set<e>(_aidl_value);
3287 } else {
3288 // NOLINTNEXTLINE(performance-move-const-arg)
3289 set<e>(std::move(_aidl_value));
3290 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003291 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003292 case pfd: {
3293 ::android::os::ParcelFileDescriptor _aidl_value;
3294 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003295 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3296 set<pfd>(_aidl_value);
3297 } else {
3298 // NOLINTNEXTLINE(performance-move-const-arg)
3299 set<pfd>(std::move(_aidl_value));
3300 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003301 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003302 }
3303 return ::android::BAD_VALUE;
3304}
3305
3306::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3307 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3308 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3309 switch (getTag()) {
3310 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3311 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003312 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003313 }
Jooyung Handf39e192020-11-23 15:59:46 +09003314 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003315}
3316
3317} // namespace a
3318)";
3319
Jooyung Han6beac042020-10-17 21:59:43 +09003320const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3321#include <android/binder_interface_utils.h>
3322#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003323#include <codecvt>
3324#include <locale>
3325#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003326
Jooyung Handf39e192020-11-23 15:59:46 +09003327#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003328#include <type_traits>
3329#include <utility>
3330#include <variant>
3331#include <cstdint>
3332#include <memory>
3333#include <optional>
3334#include <string>
3335#include <vector>
3336#ifdef BINDER_STABILITY_SUPPORT
3337#include <android/binder_stability.h>
3338#endif // BINDER_STABILITY_SUPPORT
3339#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003340
3341#ifndef __BIONIC__
3342#define __assert2(a,b,c,d) ((void)0)
3343#endif
3344
Jooyung Han6beac042020-10-17 21:59:43 +09003345namespace aidl {
3346namespace a {
3347class Foo {
3348public:
3349 typedef std::false_type fixed_size;
3350 static const char* descriptor;
3351
3352 enum Tag : int32_t {
3353 ns = 0, // int[] ns;
3354 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003355 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003356 };
3357
3358 template<typename _Tp>
3359 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3360
3361 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3362 Foo(const Foo&) = default;
3363 Foo(Foo&&) = default;
3364 Foo& operator=(const Foo&) = default;
3365 Foo& operator=(Foo&&) = default;
3366
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003367 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3368 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003369 constexpr Foo(_Tp&& _arg)
3370 : _value(std::forward<_Tp>(_arg)) {}
3371
3372 template <typename... _Tp>
3373 constexpr explicit Foo(_Tp&&... _args)
3374 : _value(std::forward<_Tp>(_args)...) {}
3375
3376 template <Tag _tag, typename... _Tp>
3377 static Foo make(_Tp&&... _args) {
3378 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3379 }
3380
3381 template <Tag _tag, typename _Tp, typename... _Up>
3382 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3383 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3384 }
3385
3386 Tag getTag() const {
3387 return static_cast<Tag>(_value.index());
3388 }
3389
3390 template <Tag _tag>
3391 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003392 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003393 return std::get<_tag>(_value);
3394 }
3395
3396 template <Tag _tag>
3397 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003398 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003399 return std::get<_tag>(_value);
3400 }
3401
3402 template <Tag _tag, typename... _Tp>
3403 void set(_Tp&&... _args) {
3404 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3405 }
3406
3407 binder_status_t readFromParcel(const AParcel* _parcel);
3408 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003409
3410 inline bool operator!=(const Foo& rhs) const {
3411 return _value != rhs._value;
3412 }
3413 inline bool operator<(const Foo& rhs) const {
3414 return _value < rhs._value;
3415 }
3416 inline bool operator<=(const Foo& rhs) const {
3417 return _value <= rhs._value;
3418 }
3419 inline bool operator==(const Foo& rhs) const {
3420 return _value == rhs._value;
3421 }
3422 inline bool operator>(const Foo& rhs) const {
3423 return _value > rhs._value;
3424 }
3425 inline bool operator>=(const Foo& rhs) const {
3426 return _value >= rhs._value;
3427 }
3428
Jooyung Han6beac042020-10-17 21:59:43 +09003429 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003430 template <typename _T> class _has_toString {
3431 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3432 template <typename _U> static std::false_type __has_toString(...);
3433 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3434 };
3435 template <typename _T> inline static std::string _call_toString(const _T& t) {
3436 if constexpr (_has_toString<_T>::value) return t.toString();
3437 return "{no toString() implemented}";
3438 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003439 inline std::string toString() const {
3440 std::ostringstream os;
3441 os << "Foo{";
3442 switch (getTag()) {
3443 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3444 case e: os << "e: " << a::toString(get<e>()); break;
3445 case pfd: os << "pfd: " << ""; break;
3446 }
3447 os << "}";
3448 return os.str();
3449 }
Jooyung Han6beac042020-10-17 21:59:43 +09003450private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003451 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003452};
3453} // namespace a
3454} // namespace aidl
3455)";
3456
3457const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3458
3459#include <android/binder_parcel_utils.h>
3460
3461namespace aidl {
3462namespace a {
3463const char* Foo::descriptor = "a.Foo";
3464
3465binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3466 binder_status_t _aidl_ret_status;
3467 int32_t _aidl_tag;
3468 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3469 switch (_aidl_tag) {
3470 case ns: {
3471 std::vector<int32_t> _aidl_value;
3472 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003473 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3474 set<ns>(_aidl_value);
3475 } else {
3476 // NOLINTNEXTLINE(performance-move-const-arg)
3477 set<ns>(std::move(_aidl_value));
3478 }
Jooyung Han6beac042020-10-17 21:59:43 +09003479 return STATUS_OK; }
3480 case e: {
3481 ::aidl::a::ByteEnum _aidl_value;
3482 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003483 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3484 set<e>(_aidl_value);
3485 } else {
3486 // NOLINTNEXTLINE(performance-move-const-arg)
3487 set<e>(std::move(_aidl_value));
3488 }
Jooyung Han6beac042020-10-17 21:59:43 +09003489 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003490 case pfd: {
3491 ::ndk::ScopedFileDescriptor _aidl_value;
3492 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003493 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3494 set<pfd>(_aidl_value);
3495 } else {
3496 // NOLINTNEXTLINE(performance-move-const-arg)
3497 set<pfd>(std::move(_aidl_value));
3498 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003499 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003500 }
3501 return STATUS_BAD_VALUE;
3502}
3503binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3504 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3505 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3506 switch (getTag()) {
3507 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3508 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003509 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003510 }
Jooyung Handf39e192020-11-23 15:59:46 +09003511 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003512}
3513
3514} // namespace a
3515} // namespace aidl
3516)";
3517
Jooyung Han1f14ab32020-10-14 13:48:29 +09003518const char kUnionExampleExpectedOutputJava[] = R"(/*
3519 * This file is auto-generated. DO NOT MODIFY.
3520 */
3521package a;
3522
3523
3524public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003525 // tags for union fields
3526 public final static int ns = 0; // int[] ns;
3527 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003528 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003529
3530 private int _tag;
3531 private Object _value;
3532
3533 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003534 int[] _value = {42};
3535 this._tag = ns;
3536 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003537 }
Jooyung Han97945de2020-10-15 16:41:38 +09003538
Jooyung Han1f14ab32020-10-14 13:48:29 +09003539 private Foo(android.os.Parcel _aidl_parcel) {
3540 readFromParcel(_aidl_parcel);
3541 }
Jooyung Han97945de2020-10-15 16:41:38 +09003542
Jooyung Hance62f932020-10-25 10:21:49 +09003543 private Foo(int _tag, Object _value) {
3544 this._tag = _tag;
3545 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003546 }
3547
3548 public int getTag() {
3549 return _tag;
3550 }
3551
Jooyung Han97945de2020-10-15 16:41:38 +09003552 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003553
3554 public static Foo ns(int[] _value) {
3555 return new Foo(ns, _value);
3556 }
Jooyung Han97945de2020-10-15 16:41:38 +09003557
Jooyung Han1f14ab32020-10-14 13:48:29 +09003558 public int[] getNs() {
3559 _assertTag(ns);
3560 return (int[]) _value;
3561 }
Jooyung Han97945de2020-10-15 16:41:38 +09003562
Jooyung Han1f14ab32020-10-14 13:48:29 +09003563 public void setNs(int[] _value) {
3564 _set(ns, _value);
3565 }
3566
Jooyung Han97945de2020-10-15 16:41:38 +09003567 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003568
3569 public static Foo e(byte _value) {
3570 return new Foo(e, _value);
3571 }
Jooyung Han97945de2020-10-15 16:41:38 +09003572
Jooyung Han1f14ab32020-10-14 13:48:29 +09003573 public byte getE() {
3574 _assertTag(e);
3575 return (byte) _value;
3576 }
Jooyung Han97945de2020-10-15 16:41:38 +09003577
Jooyung Han1f14ab32020-10-14 13:48:29 +09003578 public void setE(byte _value) {
3579 _set(e, _value);
3580 }
3581
Jooyung Hand2fa0232020-10-19 02:51:41 +09003582 // ParcelFileDescriptor pfd;
3583
3584 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3585 return new Foo(pfd, _value);
3586 }
3587
3588 public android.os.ParcelFileDescriptor getPfd() {
3589 _assertTag(pfd);
3590 return (android.os.ParcelFileDescriptor) _value;
3591 }
3592
3593 public void setPfd(android.os.ParcelFileDescriptor _value) {
3594 _set(pfd, _value);
3595 }
3596
Jooyung Han1f14ab32020-10-14 13:48:29 +09003597 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3598 @Override
3599 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003600 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003601 }
3602 @Override
3603 public Foo[] newArray(int _aidl_size) {
3604 return new Foo[_aidl_size];
3605 }
3606 };
Jooyung Han97945de2020-10-15 16:41:38 +09003607
Jooyung Han1f14ab32020-10-14 13:48:29 +09003608 @Override
3609 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3610 _aidl_parcel.writeInt(_tag);
3611 switch (_tag) {
3612 case ns:
3613 _aidl_parcel.writeIntArray(getNs());
3614 break;
3615 case e:
3616 _aidl_parcel.writeByte(getE());
3617 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003618 case pfd:
3619 if ((getPfd()!=null)) {
3620 _aidl_parcel.writeInt(1);
3621 getPfd().writeToParcel(_aidl_parcel, 0);
3622 }
3623 else {
3624 _aidl_parcel.writeInt(0);
3625 }
3626 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003627 }
3628 }
Jooyung Han97945de2020-10-15 16:41:38 +09003629
Jooyung Han1f14ab32020-10-14 13:48:29 +09003630 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3631 int _aidl_tag;
3632 _aidl_tag = _aidl_parcel.readInt();
3633 switch (_aidl_tag) {
3634 case ns: {
3635 int[] _aidl_value;
3636 _aidl_value = _aidl_parcel.createIntArray();
3637 _set(_aidl_tag, _aidl_value);
3638 return; }
3639 case e: {
3640 byte _aidl_value;
3641 _aidl_value = _aidl_parcel.readByte();
3642 _set(_aidl_tag, _aidl_value);
3643 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003644 case pfd: {
3645 android.os.ParcelFileDescriptor _aidl_value;
3646 if ((0!=_aidl_parcel.readInt())) {
3647 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3648 }
3649 else {
3650 _aidl_value = null;
3651 }
3652 _set(_aidl_tag, _aidl_value);
3653 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003654 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003655 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003656 }
Jooyung Han97945de2020-10-15 16:41:38 +09003657
Jooyung Han1f14ab32020-10-14 13:48:29 +09003658 @Override
3659 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003660 int _mask = 0;
3661 switch (getTag()) {
3662 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003663 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003664 break;
3665 }
3666 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003667 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003668 private int describeContents(Object _v) {
3669 if (_v == null) return 0;
3670 if (_v instanceof android.os.Parcelable) {
3671 return ((android.os.Parcelable) _v).describeContents();
3672 }
3673 return 0;
3674 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003675
3676 private void _assertTag(int tag) {
3677 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003678 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003679 }
3680 }
Jooyung Han97945de2020-10-15 16:41:38 +09003681
Jooyung Han1f14ab32020-10-14 13:48:29 +09003682 private String _tagString(int _tag) {
3683 switch (_tag) {
3684 case ns: return "ns";
3685 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003686 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003687 }
3688 throw new IllegalStateException("unknown field: " + _tag);
3689 }
Jooyung Han97945de2020-10-15 16:41:38 +09003690
Jooyung Hance62f932020-10-25 10:21:49 +09003691 private void _set(int _tag, Object _value) {
3692 this._tag = _tag;
3693 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003694 }
3695}
3696)";
3697
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003698const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3699pub enum Foo {
3700 Ns(Vec<i32>),
3701 E(crate::mangled::_1_a_8_ByteEnum),
3702 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3703}
3704pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3705impl Default for Foo {
3706 fn default() -> Self {
3707 Self::Ns(vec!{42})
3708 }
3709}
3710impl binder::parcel::Serialize for Foo {
3711 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3712 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3713 }
3714}
3715impl binder::parcel::SerializeArray for Foo {}
3716impl binder::parcel::SerializeOption for Foo {
3717 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3718 let this = if let Some(this) = this {
3719 parcel.write(&1i32)?;
3720 this
3721 } else {
3722 return parcel.write(&0i32);
3723 };
3724 match this {
3725 Self::Ns(v) => {
3726 parcel.write(&0i32)?;
3727 parcel.write(v)
3728 }
3729 Self::E(v) => {
3730 parcel.write(&1i32)?;
3731 parcel.write(v)
3732 }
3733 Self::Pfd(v) => {
3734 parcel.write(&2i32)?;
3735 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3736 parcel.write(__field_ref)
3737 }
3738 }
3739 }
3740}
3741impl binder::parcel::Deserialize for Foo {
3742 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3743 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3744 .transpose()
3745 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3746 }
3747}
3748impl binder::parcel::DeserializeArray for Foo {}
3749impl binder::parcel::DeserializeOption for Foo {
3750 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3751 let status: i32 = parcel.read()?;
3752 if status == 0 { return Ok(None); }
3753 let tag: i32 = parcel.read()?;
3754 match tag {
3755 0 => {
3756 let value: Vec<i32> = parcel.read()?;
3757 Ok(Some(Self::Ns(value)))
3758 }
3759 1 => {
3760 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3761 Ok(Some(Self::E(value)))
3762 }
3763 2 => {
3764 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3765 Ok(Some(Self::Pfd(value)))
3766 }
3767 _ => {
3768 Err(binder::StatusCode::BAD_VALUE)
3769 }
3770 }
3771 }
3772}
3773)";
3774
Jooyung Han97945de2020-10-15 16:41:38 +09003775struct AidlUnionTest : ::testing::Test {
3776 void SetUp() override {
3777 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003778package a;
3779import a.ByteEnum;
3780union Foo {
3781 int[] ns = {42};
3782 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003783 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003784}
3785)");
Jooyung Han97945de2020-10-15 16:41:38 +09003786 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003787package a;
3788@Backing(type="byte")
3789enum ByteEnum {
3790 a, b, c
3791}
3792)");
Jooyung Han97945de2020-10-15 16:41:38 +09003793 }
3794 FakeIoDelegate io_delegate_;
3795 void Compile(string lang) {
3796 string command = "aidl --structured -I. -o out --lang=" + lang;
3797 if (lang == "cpp" || lang == "ndk") {
3798 command += " -h out";
3799 }
3800 command += " a/Foo.aidl";
3801 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003802 CaptureStderr();
3803 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3804 auto err = GetCapturedStderr();
3805 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003806 }
3807 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3808 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003809 string actual;
3810 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3811 EXPECT_EQ(expected, actual);
3812 }
Jooyung Han97945de2020-10-15 16:41:38 +09003813 }
3814};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003815
Jooyung Han97945de2020-10-15 16:41:38 +09003816TEST_F(AidlUnionTest, Example_Cpp) {
3817 Compile("cpp");
3818 EXPECT_COMPILE_OUTPUTS(
3819 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3820 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3821}
3822
Jooyung Han6beac042020-10-17 21:59:43 +09003823TEST_F(AidlUnionTest, Example_Ndk) {
3824 Compile("ndk");
3825 EXPECT_COMPILE_OUTPUTS(
3826 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3827 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3828}
3829
Jooyung Han97945de2020-10-15 16:41:38 +09003830TEST_F(AidlUnionTest, Example_Java) {
3831 Compile("java");
3832 EXPECT_COMPILE_OUTPUTS(
3833 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003834}
3835
3836TEST_F(AidlUnionTest, Example_Rust) {
3837 Compile("rust");
3838 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003839}
3840
Jooyung Hanfe89f122020-10-14 03:49:18 +09003841TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3842 const string method = "package a; union Foo {}";
3843 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3844 CaptureStderr();
3845 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3846 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3847}
3848
3849TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3850 const string method = "package a; union Foo { ParcelableHolder x; }";
3851 const string expected_stderr =
3852 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3853 CaptureStderr();
3854 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3855 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3856}
3857
Jooyung Han53fb4242020-12-17 16:03:49 +09003858TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3859 import_paths_.insert(".");
3860 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3861 const string expected_err = "The union's first member should have a useful default value.";
3862 CaptureStderr();
3863 EXPECT_EQ(nullptr,
3864 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3865 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3866}
3867
Devin Moore53fc99c2020-08-12 08:07:52 -07003868TEST_P(AidlTest, GenericStructuredParcelable) {
3869 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003870 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003871 const string expected_stderr = "";
3872 CaptureStderr();
3873 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3874 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3875}
3876
Jooyung Han3f347ca2020-12-01 12:41:50 +09003877TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3878 io_delegate_.SetFileContents("Foo.aidl",
3879 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3880 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003881 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003882 const string expected_stderr = "";
3883 CaptureStderr();
3884 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3885 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3886
3887 string code;
3888 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3889 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3890const ::android::String16& Foo<T,U>::s() {
3891 static const ::android::String16 value(::android::String16(""));
3892 return value;
3893})--"));
3894}
3895
3896TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3897 io_delegate_.SetFileContents("Foo.aidl",
3898 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3899 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003900 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003901 const string expected_stderr = "";
3902 CaptureStderr();
3903 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3904 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3905
3906 string code;
3907 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3908 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3909const char* Foo<T, U>::s = "";
3910)--"));
3911}
3912
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003913TEST_F(AidlTest, NestedTypeArgs) {
3914 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003915 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3916
3917 io_delegate_.SetFileContents("a/Foo.aidl",
3918 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3919 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003920 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3921 const string expected_stderr = "";
3922 CaptureStderr();
3923 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3924 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3925
3926 string code;
3927 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003928 EXPECT_THAT(code,
3929 testing::HasSubstr(
3930 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3931}
3932
3933TEST_F(AidlTest, DoubleArrayError) {
3934 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3935
3936 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3937 const string expected_stderr =
3938 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3939 CaptureStderr();
3940 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3942}
3943
3944TEST_F(AidlTest, DoubleGenericError) {
3945 io_delegate_.SetFileContents("a/Bar.aidl",
3946 "package a; parcelable Bar { List<String><String> a; }");
3947
3948 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3949 const string expected_stderr =
3950 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3951 CaptureStderr();
3952 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3954}
3955
3956TEST_F(AidlTest, ArrayBeforeGenericError) {
3957 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3958
3959 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3960 const string expected_stderr =
3961 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3962 CaptureStderr();
3963 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3964 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003965}
3966
Jooyung Han14004ed2020-10-16 03:49:57 +09003967struct GenericAidlTest : ::testing::Test {
3968 FakeIoDelegate io_delegate_;
3969 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003970 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003971 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3972 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3973 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3974
3975 Options options = Options::From(cmd);
3976 CaptureStderr();
3977 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3978 EXPECT_EQ("", GetCapturedStderr());
3979 }
3980};
3981
3982TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3983 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3984 string code;
3985 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3986 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3987 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3988 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3989}
3990
3991TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3992 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3993 string code;
3994 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3995 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3996 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3997 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3998}
3999
Devin Moore53fc99c2020-08-12 08:07:52 -07004000TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4001 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004002 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004003 const string expected_stderr =
4004 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4005 CaptureStderr();
4006 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4007 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4008}
4009
4010TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4011 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004012 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004013 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4014 CaptureStderr();
4015 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4017}
4018
Jooyung Han7a308842020-10-27 19:06:49 +09004019TEST_P(AidlTest, LongCommentWithinConstExpression) {
4020 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004021 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004022 CaptureStderr();
4023 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4024 EXPECT_EQ("", GetCapturedStderr());
4025}
4026
Jeongik Chaef44e622020-10-23 16:00:52 +09004027TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4028 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4029 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4030 std::string expectedErr =
4031 "ERROR: a/Foo.aidl:1.28-30: "
4032 "Encountered an untyped List or Map. The use of untyped List/Map is "
4033 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4034 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4035 "ERROR: a/Foo.aidl:1.35-37: "
4036 "Encountered an untyped List or Map. The use of untyped List/Map is "
4037 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4038 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4039 CaptureStderr();
4040 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4041 EXPECT_EQ(expectedErr, GetCapturedStderr());
4042}
4043
4044TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004045 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4046 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004047 std::string expectedErr =
4048 "ERROR: a/Foo.aidl:1.33-35: "
4049 "Encountered an untyped List or Map. The use of untyped List/Map is "
4050 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4051 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4052 "ERROR: a/Foo.aidl:1.40-42: "
4053 "Encountered an untyped List or Map. The use of untyped List/Map is "
4054 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4055 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004056 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004057 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4058 EXPECT_EQ(expectedErr, GetCapturedStderr());
4059}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004060
Jeongik Chaef44e622020-10-23 16:00:52 +09004061TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4062 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4063 io_delegate_.SetFileContents(
4064 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4065 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4066 std::string expectedErr =
4067 "ERROR: a/Foo.aidl:1.52-54: "
4068 "Encountered an untyped List or Map. The use of untyped List/Map is "
4069 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4070 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4071 "ERROR: a/Foo.aidl:1.64-66: "
4072 "Encountered an untyped List or Map. The use of untyped List/Map is "
4073 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4074 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4075 CaptureStderr();
4076 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4077 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004078}
4079
Jooyung Han690f5842020-12-04 13:02:04 +09004080TEST_F(AidlTest, EnumWithDefaults_Java) {
4081 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4082 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4083package p;
4084import p.Enum;
4085parcelable Foo {
4086 Enum e = Enum.BAR;
4087})");
4088 CaptureStderr();
4089 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4090 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4091 auto err = GetCapturedStderr();
4092 EXPECT_EQ("", err);
4093
4094 string code;
4095 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004096 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004097}
4098
4099TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4100 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4101 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4102package p;
4103import p.Enum;
4104parcelable Foo {
4105 Enum e = Enum.BAR;
4106})");
4107 CaptureStderr();
4108 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4109 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4110 auto err = GetCapturedStderr();
4111 EXPECT_EQ("", err);
4112
4113 string code;
4114 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4115 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4116}
4117
4118TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4119 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4120 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4121package p;
4122import p.Enum;
4123parcelable Foo {
4124 Enum e = Enum.BAR;
4125})");
4126 CaptureStderr();
4127 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4128 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4129 auto err = GetCapturedStderr();
4130 EXPECT_EQ("", err);
4131
4132 string code;
4133 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4134 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4135}
4136
4137TEST_F(AidlTest, EnumWithDefaults_Rust) {
4138 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4139 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4140package p;
4141import p.Enum;
4142parcelable Foo {
4143 int n = 42;
4144 Enum e = Enum.BAR;
4145})");
4146 CaptureStderr();
4147 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4148 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4149 auto err = GetCapturedStderr();
4150 EXPECT_EQ("", err);
4151
4152 string code;
4153 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4154 EXPECT_THAT(code, testing::HasSubstr(R"(
4155 fn default() -> Self {
4156 Self {
4157 n: 42,
4158 e: crate::mangled::_1_p_4_Enum::BAR,
4159 }
4160 })"));
4161}
4162
4163TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4164 import_paths_.insert("a");
4165 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4166 CaptureStderr();
4167 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4168package p;
4169import p.Enum;
4170parcelable Foo {
4171 int e = Enum.FOO | Enum.BAR;
4172})",
4173 typenames_, GetLanguage());
4174 auto err = GetCapturedStderr();
4175 EXPECT_EQ("", err);
4176 EXPECT_TRUE(type);
4177 const auto& fields = type->AsStructuredParcelable()->GetFields();
4178 EXPECT_EQ("int e = 3", fields[0]->ToString());
4179}
4180
4181TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4182 CaptureStderr();
4183 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4184@Backing(type="int")
4185enum Foo {
4186 STANDARD_SHIFT = 16,
4187 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4188 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4189}
4190)",
4191 typenames_, GetLanguage());
4192 auto err = GetCapturedStderr();
4193 EXPECT_EQ("", err);
4194 EXPECT_TRUE(type);
4195 const auto& enum_type = type->AsEnumDeclaration();
4196 string code;
4197 enum_type->Dump(CodeWriter::ForString(&code).get());
4198 EXPECT_EQ(R"--(@Backing(type="int")
4199enum Foo {
4200 STANDARD_SHIFT = 16,
4201 STANDARD_BT709 = 65536,
4202 STANDARD_BT601_625 = 131072,
4203}
4204)--",
4205 code);
4206}
4207
4208TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4209 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4210 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4211package p;
4212import p.Enum;
4213parcelable Foo {
4214 Enum e = Enum.FOO | Enum.BAR;
4215})");
4216 CaptureStderr();
4217 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4218 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4219 auto err = GetCapturedStderr();
4220 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4221 err);
4222}
4223
4224TEST_P(AidlTest, DefaultWithEmptyArray) {
4225 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4226 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4227 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004228 auto options =
4229 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09004230 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4231 auto err = GetCapturedStderr();
4232 EXPECT_EQ("", err);
4233}
4234
4235TEST_P(AidlTest, RejectRefsInAnnotation) {
4236 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4237 "package p; interface IFoo {\n"
4238 " const String ANNOTATION = \"@Annotation\";\n"
4239 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4240 "}");
4241 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004242 auto options =
4243 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09004244 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4245 auto err = GetCapturedStderr();
4246 EXPECT_EQ(
4247 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4248 "ANNOTATION.\n",
4249 err);
4250}
4251
4252TEST_F(AidlTest, DefaultWithEnumValues) {
4253 io_delegate_.SetFileContents(
4254 "a/p/Foo.aidl",
4255 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4256 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4257 CaptureStderr();
4258 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4259 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4260 auto err = GetCapturedStderr();
4261 EXPECT_EQ("", err);
4262 string code;
4263 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4264 EXPECT_THAT(
4265 code, testing::HasSubstr(
4266 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4267}
4268
Jooyung Han14259392020-12-07 10:00:08 +09004269TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4270 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4271 CaptureStderr();
4272 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4273 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4274 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004275 EXPECT_EQ(
4276 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4277 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4278 err);
Jooyung Han14259392020-12-07 10:00:08 +09004279}
4280
4281TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4282 io_delegate_.SetFileContents("a/p/Foo.aidl",
4283 "package p; parcelable Foo { const int A = A + 1; }");
4284 CaptureStderr();
4285 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4286 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4287 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004288 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4289}
4290
4291TEST_F(AidlTest, RecursiveReferences) {
4292 io_delegate_.SetFileContents("a/p/Foo.aidl",
4293 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4294 io_delegate_.SetFileContents("a/p/Bar.aidl",
4295 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4296 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4297 CaptureStderr();
4298 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4299 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4300 EXPECT_EQ("", GetCapturedStderr());
4301}
4302
Jooyung Hane9f5b272021-01-07 00:18:11 +09004303TEST_P(AidlTest, UnknownConstReference) {
4304 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4305 auto options =
4306 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4307 const string err =
4308 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4309 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4310 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4311 CaptureStderr();
4312 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4313 EXPECT_EQ(err, GetCapturedStderr());
4314}
4315
Jooyung Han29813842020-12-08 01:28:03 +09004316TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4317 string contents = R"(
4318import android.os.IBinder;
4319import android.os.IInterface;
4320interface IFoo {}
4321 )";
4322 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004323}
4324
Jooyung Han888c5bc2020-12-22 17:28:47 +09004325TEST_P(AidlTest, WarningInterfaceName) {
4326 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004327 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004328 " -Weverything -o out -h out p/Foo.aidl");
4329 CaptureStderr();
4330 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004331 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004332 GetCapturedStderr());
4333}
4334
4335TEST_P(AidlTest, ErrorInterfaceName) {
4336 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004337 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004338 " -Weverything -Werror -o out -h out p/Foo.aidl");
4339 CaptureStderr();
4340 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004341 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004342 GetCapturedStderr());
4343}
4344
Jooyung Hanfd3be322020-12-13 09:11:06 +09004345struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004346 string kind;
4347 string literal;
4348};
4349
Jooyung Hanfd3be322020-12-13 09:11:06 +09004350const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004351 {"primitive", "int"}, {"String", "String"},
4352 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4353 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4354 {"union", "a.Union"}, {"interface", "a.IBar"},
4355};
4356
4357const std::map<std::string, std::string> kListSupportExpectations = {
4358 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4359 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4360 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4361 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4362 {"cpp_String", ""},
4363 {"java_String", ""},
4364 {"ndk_String", ""},
4365 {"rust_String", ""},
4366 {"cpp_IBinder", ""},
4367 {"java_IBinder", ""},
4368 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4369 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004370 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004371 {"java_ParcelFileDescriptor", ""},
4372 {"ndk_ParcelFileDescriptor", ""},
4373 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004374 {"cpp_interface", "List<a.IBar> is not supported."},
4375 {"java_interface", "List<a.IBar> is not supported."},
4376 {"ndk_interface", "List<a.IBar> is not supported."},
4377 {"rust_interface", "List<a.IBar> is not supported."},
4378 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004379 {"java_parcelable", ""},
4380 {"ndk_parcelable", ""},
4381 {"rust_parcelable", ""},
4382 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4383 {"java_enum", "A generic type cannot have any primitive type parameters."},
4384 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4385 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004386 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004387 {"java_union", ""},
4388 {"ndk_union", ""},
4389 {"rust_union", ""},
4390};
4391
Jooyung Hand236e552020-12-13 09:21:27 +09004392const std::map<std::string, std::string> kArraySupportExpectations = {
4393 {"cpp_primitive", ""},
4394 {"java_primitive", ""},
4395 {"ndk_primitive", ""},
4396 {"rust_primitive", ""},
4397 {"cpp_String", ""},
4398 {"java_String", ""},
4399 {"ndk_String", ""},
4400 {"rust_String", ""},
4401 {"cpp_IBinder", ""},
4402 {"java_IBinder", ""},
4403 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4404 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4405 {"cpp_ParcelFileDescriptor", ""},
4406 {"java_ParcelFileDescriptor", ""},
4407 {"ndk_ParcelFileDescriptor", ""},
4408 {"rust_ParcelFileDescriptor", ""},
4409 {"cpp_interface", "Binder type cannot be an array"},
4410 {"java_interface", "Binder type cannot be an array"},
4411 {"ndk_interface", "Binder type cannot be an array"},
4412 {"rust_interface", "Binder type cannot be an array"},
4413 {"cpp_parcelable", ""},
4414 {"java_parcelable", ""},
4415 {"ndk_parcelable", ""},
4416 {"rust_parcelable", ""},
4417 {"cpp_enum", ""},
4418 {"java_enum", ""},
4419 {"ndk_enum", ""},
4420 {"rust_enum", ""},
4421 {"cpp_union", ""},
4422 {"java_union", ""},
4423 {"ndk_union", ""},
4424 {"rust_union", ""},
4425};
4426
Jooyung Hanfd3be322020-12-13 09:11:06 +09004427class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004428 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004429 void Run(const std::string& generic_type_decl,
4430 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004431 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004432 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004433 const auto& kind = std::get<1>(param).kind;
4434
4435 FakeIoDelegate io;
4436 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4437 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4438 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004439 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4440 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004441
4442 const auto options =
4443 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4444 CaptureStderr();
4445 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004446 auto it = expectations.find(lang + "_" + kind);
4447 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004448 const string err = GetCapturedStderr();
4449 if (it->second.empty()) {
4450 EXPECT_EQ("", err);
4451 } else {
4452 EXPECT_THAT(err, testing::HasSubstr(it->second));
4453 }
4454 }
4455};
4456
4457INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004458 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004459 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4460 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004461 testing::ValuesIn(kTypeParams)),
4462 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004463 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004464 });
4465
Jooyung Hanfd3be322020-12-13 09:11:06 +09004466TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4467 Run("List<{}>", kListSupportExpectations);
4468}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004469
Jooyung Hand236e552020-12-13 09:21:27 +09004470TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4471 Run("{}[]", kArraySupportExpectations);
4472}
4473
Christopher Wiley90be4e32015-10-20 14:55:25 -07004474} // namespace aidl
4475} // namespace android