Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015, The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 17 | #include "aidl.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 18 | |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 19 | #include <android-base/format.h> |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 20 | #include <android-base/stringprintf.h> |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 21 | #include <gmock/gmock.h> |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 22 | #include <gtest/gtest.h> |
| 23 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 24 | #include <map> |
| 25 | #include <memory> |
| 26 | #include <set> |
| 27 | #include <string> |
| 28 | #include <vector> |
| 29 | |
Steven Moreland | 4958524 | 2019-12-18 16:06:49 -0800 | [diff] [blame] | 30 | #include "aidl_checkapi.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 31 | #include "aidl_language.h" |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 32 | #include "aidl_to_cpp.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 33 | #include "aidl_to_java.h" |
Jiyong Park | 2a7c92b | 2020-07-22 19:12:36 +0900 | [diff] [blame] | 34 | #include "logging.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 35 | #include "options.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 36 | #include "tests/fake_io_delegate.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 37 | |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 38 | using android::aidl::internals::parse_preprocessed_file; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 39 | using android::aidl::test::FakeIoDelegate; |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 40 | using android::base::StringPrintf; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 41 | using std::map; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 42 | using std::set; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 43 | using std::string; |
| 44 | using std::unique_ptr; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 45 | using std::vector; |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 46 | using testing::HasSubstr; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 47 | using testing::TestParamInfo; |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 48 | using testing::internal::CaptureStderr; |
| 49 | using testing::internal::GetCapturedStderr; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 50 | |
| 51 | namespace android { |
| 52 | namespace aidl { |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 53 | namespace { |
| 54 | |
| 55 | const char kExpectedDepFileContents[] = |
| 56 | R"(place/for/output/p/IFoo.java : \ |
| 57 | p/IFoo.aidl |
| 58 | |
| 59 | p/IFoo.aidl : |
| 60 | )"; |
| 61 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 62 | const char kExpectedNinjaDepFileContents[] = |
| 63 | R"(place/for/output/p/IFoo.java : \ |
| 64 | p/IFoo.aidl |
| 65 | )"; |
| 66 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 67 | const char kExpectedParcelableDeclarationDepFileContents[] = |
| 68 | R"( : \ |
| 69 | p/Foo.aidl |
| 70 | |
| 71 | p/Foo.aidl : |
| 72 | )"; |
| 73 | |
| 74 | const char kExpectedStructuredParcelableDepFileContents[] = |
Steven Moreland | 2a9a7d6 | 2019-02-05 16:11:54 -0800 | [diff] [blame] | 75 | R"(place/for/output/p/Foo.java : \ |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 76 | p/Foo.aidl |
| 77 | |
| 78 | p/Foo.aidl : |
| 79 | )"; |
| 80 | |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 81 | const char kExpectedJavaParcelableOutputContents[] = |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 82 | R"(/* |
| 83 | * This file is auto-generated. DO NOT MODIFY. |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 84 | */ |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 85 | @android.annotation.Hide |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 86 | public class Rect implements android.os.Parcelable |
| 87 | { |
| 88 | // Comment |
| 89 | |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 90 | @android.annotation.Hide |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 91 | public int x = 5; |
| 92 | |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 93 | @android.annotation.Hide |
| 94 | @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14") |
Steven Moreland | 541788d | 2020-05-21 22:05:52 +0000 | [diff] [blame] | 95 | public int y = 0; |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 96 | |
| 97 | public android.os.ParcelFileDescriptor fd; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 98 | |
| 99 | public java.util.List<android.os.ParcelFileDescriptor> fds; |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 100 | public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() { |
| 101 | @Override |
| 102 | public Rect createFromParcel(android.os.Parcel _aidl_source) { |
| 103 | Rect _aidl_out = new Rect(); |
| 104 | _aidl_out.readFromParcel(_aidl_source); |
| 105 | return _aidl_out; |
| 106 | } |
| 107 | @Override |
| 108 | public Rect[] newArray(int _aidl_size) { |
| 109 | return new Rect[_aidl_size]; |
| 110 | } |
| 111 | }; |
| 112 | @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) |
| 113 | { |
| 114 | int _aidl_start_pos = _aidl_parcel.dataPosition(); |
| 115 | _aidl_parcel.writeInt(0); |
| 116 | _aidl_parcel.writeInt(x); |
| 117 | _aidl_parcel.writeInt(y); |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 118 | if ((fd!=null)) { |
| 119 | _aidl_parcel.writeInt(1); |
| 120 | fd.writeToParcel(_aidl_parcel, 0); |
| 121 | } |
| 122 | else { |
| 123 | _aidl_parcel.writeInt(0); |
| 124 | } |
Jooyung Han | a61aa23 | 2020-10-20 04:00:08 +0900 | [diff] [blame] | 125 | _aidl_parcel.writeTypedList(fds); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 126 | int _aidl_end_pos = _aidl_parcel.dataPosition(); |
| 127 | _aidl_parcel.setDataPosition(_aidl_start_pos); |
| 128 | _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos); |
| 129 | _aidl_parcel.setDataPosition(_aidl_end_pos); |
| 130 | } |
| 131 | public final void readFromParcel(android.os.Parcel _aidl_parcel) |
| 132 | { |
| 133 | int _aidl_start_pos = _aidl_parcel.dataPosition(); |
| 134 | int _aidl_parcelable_size = _aidl_parcel.readInt(); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 135 | try { |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 136 | if (_aidl_parcelable_size < 0) return; |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 137 | x = _aidl_parcel.readInt(); |
| 138 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
| 139 | y = _aidl_parcel.readInt(); |
| 140 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 141 | if ((0!=_aidl_parcel.readInt())) { |
| 142 | fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel); |
| 143 | } |
| 144 | else { |
| 145 | fd = null; |
| 146 | } |
| 147 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
Jooyung Han | a61aa23 | 2020-10-20 04:00:08 +0900 | [diff] [blame] | 148 | fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 149 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 150 | } finally { |
Jeongik Cha | 8b32998 | 2020-09-01 20:59:36 +0900 | [diff] [blame] | 151 | if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) { |
| 152 | throw new android.os.BadParcelableException("Overflow in the size of parcelable"); |
| 153 | } |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 154 | _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size); |
| 155 | } |
| 156 | } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 157 | @Override |
| 158 | public int describeContents() { |
| 159 | int _mask = 0; |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 160 | _mask |= describeContents(fd); |
| 161 | _mask |= describeContents(fds); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 162 | return _mask; |
Jeongik Cha | 372a8c8 | 2018-12-12 16:31:11 +0900 | [diff] [blame] | 163 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 164 | private int describeContents(Object _v) { |
| 165 | if (_v == null) return 0; |
| 166 | if (_v instanceof java.util.Collection) { |
| 167 | int _mask = 0; |
| 168 | for (Object o : (java.util.Collection) _v) { |
| 169 | _mask |= describeContents(o); |
| 170 | } |
| 171 | return _mask; |
| 172 | } |
| 173 | if (_v instanceof android.os.Parcelable) { |
| 174 | return ((android.os.Parcelable) _v).describeContents(); |
| 175 | } |
| 176 | return 0; |
| 177 | } |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 178 | } |
| 179 | )"; |
| 180 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 181 | // clang-format off |
| 182 | const char kExpectedCppHeaderOutput[] = |
| 183 | R"(#pragma once |
| 184 | |
| 185 | #include <binder/IBinder.h> |
| 186 | #include <binder/IInterface.h> |
| 187 | #include <binder/Status.h> |
| 188 | #include <optional> |
| 189 | #include <utils/String16.h> |
| 190 | #include <utils/StrongPointer.h> |
| 191 | #include <vector> |
| 192 | |
| 193 | class IFoo : public ::android::IInterface { |
| 194 | public: |
| 195 | DECLARE_META_INTERFACE(Foo) |
| 196 | virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0; |
| 197 | }; // class IFoo |
| 198 | class IFooDefault : public IFoo { |
| 199 | public: |
| 200 | ::android::IBinder* onAsBinder() override { |
| 201 | return nullptr; |
| 202 | } |
| 203 | ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override { |
| 204 | return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION); |
| 205 | } |
| 206 | }; // class IFooDefault |
| 207 | )"; |
| 208 | // clang-format on |
| 209 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 210 | } // namespace |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 211 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 212 | class AidlTest : public ::testing::TestWithParam<Options::Language> { |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 213 | protected: |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 214 | AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_, |
| 215 | Options::Language lang, AidlError* error = nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 216 | const vector<string> additional_arguments = {}) { |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 217 | io_delegate_.SetFileContents(path, contents); |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 218 | vector<string> args; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 219 | args.emplace_back("aidl"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 220 | args.emplace_back("--lang=" + to_string(lang)); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 221 | for (const string& s : additional_arguments) { |
| 222 | args.emplace_back(s); |
| 223 | } |
| 224 | for (const string& f : preprocessed_files_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 225 | args.emplace_back("--preprocessed=" + f); |
| 226 | } |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 227 | for (const string& i : import_paths_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 228 | args.emplace_back("--include=" + i); |
| 229 | } |
| 230 | args.emplace_back(path); |
| 231 | Options options = Options::From(args); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 232 | vector<string> imported_files; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 233 | ImportResolver import_resolver{io_delegate_, path, import_paths_, {}}; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 234 | AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl( |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 235 | path, options, io_delegate_, &typenames_, &imported_files); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 236 | |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 237 | if (error != nullptr) { |
| 238 | *error = actual_error; |
| 239 | } |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 240 | |
| 241 | if (actual_error != AidlError::OK) { |
| 242 | return nullptr; |
| 243 | } |
| 244 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 245 | const auto& defined_types = typenames_.MainDocument().DefinedTypes(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 246 | EXPECT_EQ(1ul, defined_types.size()); |
| 247 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 248 | return defined_types.front().get(); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 249 | } |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 250 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 251 | Options::Language GetLanguage() { return GetParam(); } |
| 252 | |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 253 | FakeIoDelegate io_delegate_; |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 254 | vector<string> preprocessed_files_; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 255 | set<string> import_paths_; |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 256 | AidlTypenames typenames_; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 257 | }; |
| 258 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 259 | // Instantiate the AidlTest parameterized suite, calling all of the TEST_P |
| 260 | // tests with each of the supported languages as a parameter. |
| 261 | INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest, |
| 262 | testing::Values(Options::Language::CPP, Options::Language::JAVA, |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 263 | Options::Language::NDK, Options::Language::RUST), |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 264 | [](const testing::TestParamInfo<Options::Language>& info) { |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 265 | return to_string(info.param); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 266 | }); |
| 267 | |
| 268 | TEST_P(AidlTest, AcceptMissingPackage) { |
| 269 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 270 | } |
| 271 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 272 | TEST_P(AidlTest, EndsInSingleLineComment) { |
| 273 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage())); |
Steven Moreland | 9c2988f | 2019-07-17 17:49:10 -0700 | [diff] [blame] | 274 | } |
| 275 | |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 276 | TEST_P(AidlTest, InterfaceRequiresCorrectPath) { |
| 277 | const string expected_stderr = |
| 278 | "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n"; |
| 279 | const std::string file_contents = "package a; interface IBar {}"; |
| 280 | CaptureStderr(); |
| 281 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 282 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 283 | } |
| 284 | |
| 285 | TEST_P(AidlTest, ParcelableRequiresCorrectPath) { |
| 286 | const string expected_stderr = |
| 287 | "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n"; |
| 288 | const std::string file_contents = "package a; interface Bar {}"; |
| 289 | CaptureStderr(); |
| 290 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 291 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 292 | } |
| 293 | |
| 294 | TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) { |
| 295 | const string expected_stderr = |
| 296 | "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n"; |
| 297 | const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";"; |
| 298 | CaptureStderr(); |
| 299 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 300 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 301 | } |
| 302 | |
| 303 | TEST_P(AidlTest, EnumRequiresCorrectPath) { |
| 304 | const string expected_stderr = |
| 305 | "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n"; |
| 306 | const std::string file_contents = "package a; enum Bar { A, }"; |
| 307 | CaptureStderr(); |
| 308 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 309 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 310 | } |
| 311 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 312 | TEST_P(AidlTest, RejectsArraysOfBinders) { |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 313 | import_paths_.emplace(""); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 314 | io_delegate_.SetFileContents("bar/IBar.aidl", |
| 315 | "package bar; interface IBar {}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 316 | const string path = "foo/IFoo.aidl"; |
| 317 | const string contents = |
| 318 | "package foo;\n" |
| 319 | "import bar.IBar;\n" |
| 320 | "interface IFoo { void f(in IBar[] input); }"; |
| 321 | const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n"; |
| 322 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 323 | EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 324 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 325 | } |
| 326 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 327 | TEST_P(AidlTest, SupportOnlyOutParameters) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 328 | const string interface_list = "package a; interface IBar { void f(out List<String> bar); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 329 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 330 | } |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 331 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 332 | TEST_P(AidlTest, RejectOutParametersForIBinder) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 333 | const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }"; |
| 334 | const string expected_ibinder_stderr = |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 335 | "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an " |
| 336 | "in parameter.\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 337 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 338 | EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 339 | EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr()); |
Jeongik Cha | a2080bf | 2019-06-18 16:44:29 +0900 | [diff] [blame] | 340 | } |
| 341 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 342 | TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 343 | const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }"; |
| 344 | const string expected_stderr = |
| 345 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 346 | CaptureStderr(); |
| 347 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
| 348 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 349 | } |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 350 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 351 | TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 352 | const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }"; |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 353 | const string expected_stderr = |
| 354 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 355 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 356 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 357 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 358 | } |
| 359 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 360 | TEST_P(AidlTest, RejectsOnewayNonVoidReturn) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 361 | const string oneway_method = "package a; interface IFoo { oneway int f(); }"; |
| 362 | const string expected_stderr = |
| 363 | "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n"; |
| 364 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 365 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 366 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 367 | } |
| 368 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 369 | TEST_P(AidlTest, RejectsNullablePrimitive) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 370 | const string oneway_method = "package a; interface IFoo { @nullable int f(); }"; |
| 371 | const string expected_stderr = |
| 372 | "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n"; |
| 373 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 374 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 375 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Casey Dahlin | 57dbe24 | 2015-12-04 11:44:02 -0800 | [diff] [blame] | 376 | } |
| 377 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 378 | TEST_P(AidlTest, AcceptNullableList) { |
| 379 | const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }"; |
| 380 | const string expected_stderr = ""; |
| 381 | CaptureStderr(); |
| 382 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
| 383 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 384 | } |
| 385 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 386 | TEST_P(AidlTest, RejectsDuplicatedArgumentNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 387 | const string method = "package a; interface IFoo { void f(int a, int a); }"; |
| 388 | const string expected_stderr = |
| 389 | "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n"; |
| 390 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 391 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 392 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | b3cd3c7 | 2018-10-11 12:37:45 -0700 | [diff] [blame] | 393 | } |
| 394 | |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 395 | TEST_P(AidlTest, RejectsDuplicatedFieldNames) { |
| 396 | const string method = "package a; parcelable Foo { int a; String a; }"; |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 397 | const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n"; |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 398 | CaptureStderr(); |
| 399 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 400 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 401 | } |
| 402 | |
Jooyung Han | d902a97 | 2020-10-23 17:32:44 +0900 | [diff] [blame] | 403 | TEST_P(AidlTest, RejectsRepeatedAnnotations) { |
| 404 | const string method = R"(@Hide @Hide parcelable Foo {})"; |
| 405 | const string expected_stderr = |
| 406 | "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: " |
| 407 | "Foo.aidl:1.1-6\n"; |
| 408 | CaptureStderr(); |
| 409 | EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage())); |
| 410 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 411 | } |
| 412 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 413 | TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 414 | const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }"; |
| 415 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n"; |
| 416 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 417 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 418 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 419 | } |
| 420 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 421 | TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 422 | AidlError error; |
| 423 | const string method = "package a; @nullable interface IFoo { int f(); }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 424 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 425 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 426 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 427 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 428 | } |
| 429 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 430 | TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 431 | AidlError error; |
| 432 | const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 433 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 434 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 435 | EXPECT_THAT(GetCapturedStderr(), |
| 436 | HasSubstr("'JavaOnlyStableParcelable' is not a supported annotation")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 437 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 438 | } |
| 439 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 440 | TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 441 | AidlError error; |
| 442 | const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 443 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 444 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 445 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 446 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 447 | } |
| 448 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 449 | TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 450 | AidlError error; |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 451 | const string method = "package a; @nullable parcelable IFoo { String a; String b; }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 452 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 453 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 454 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("'nullable' is not a supported annotation")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 455 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 456 | } |
| 457 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 458 | TEST_P(AidlTest, ParsesNonNullableAnnotation) { |
| 459 | auto parse_result = |
| 460 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 461 | ASSERT_NE(nullptr, parse_result); |
| 462 | const AidlInterface* interface = parse_result->AsInterface(); |
| 463 | ASSERT_NE(nullptr, interface); |
| 464 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 465 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 466 | } |
| 467 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 468 | TEST_P(AidlTest, ParsesNullableAnnotation) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 469 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }", |
| 470 | typenames_, GetLanguage()); |
| 471 | ASSERT_NE(nullptr, parse_result); |
| 472 | const AidlInterface* interface = parse_result->AsInterface(); |
| 473 | ASSERT_NE(nullptr, interface); |
| 474 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 475 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 476 | } |
| 477 | |
| 478 | TEST_P(AidlTest, ParsesNonUtf8Annotations) { |
| 479 | auto parse_result = |
| 480 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 481 | ASSERT_NE(nullptr, parse_result); |
| 482 | const AidlInterface* interface = parse_result->AsInterface(); |
| 483 | ASSERT_NE(nullptr, interface); |
| 484 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 485 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 486 | } |
| 487 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 488 | TEST_P(AidlTest, ParsesUtf8Annotations) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 489 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }", |
| 490 | typenames_, GetLanguage()); |
| 491 | ASSERT_NE(nullptr, parse_result); |
| 492 | const AidlInterface* interface = parse_result->AsInterface(); |
| 493 | ASSERT_NE(nullptr, interface); |
| 494 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 495 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 496 | } |
| 497 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 498 | TEST_P(AidlTest, VintfRequiresStructuredAndStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 499 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 500 | const string expected_stderr = |
| 501 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 502 | "\"vintf\"'\n" |
| 503 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 504 | "--structured\n"; |
| 505 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 506 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 507 | GetLanguage(), &error)); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 508 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 509 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 510 | } |
| 511 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 512 | TEST_P(AidlTest, VintfRequiresStructured) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 513 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 514 | const string expected_stderr = |
| 515 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 516 | "--structured\n"; |
| 517 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 518 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 519 | GetLanguage(), &error, {"--stability", "vintf"})); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 520 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 521 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 522 | } |
| 523 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 524 | TEST_P(AidlTest, VintfRequiresSpecifiedStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 525 | AidlError error; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 526 | const string expected_stderr = |
| 527 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 528 | "\"vintf\"'\n"; |
| 529 | CaptureStderr(); |
| 530 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 531 | GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 532 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 533 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 534 | } |
| 535 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 536 | TEST_P(AidlTest, ParsesStabilityAnnotations) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 537 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 538 | auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
| 539 | GetLanguage(), &error, {"--structured", "--stability", "vintf"}); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 540 | ASSERT_EQ(AidlError::OK, error); |
| 541 | ASSERT_NE(nullptr, parse_result); |
| 542 | const AidlInterface* interface = parse_result->AsInterface(); |
| 543 | ASSERT_NE(nullptr, interface); |
| 544 | ASSERT_TRUE(interface->IsVintfStability()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 545 | } |
| 546 | |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 547 | TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) { |
| 548 | Options java_options = Options::From("aidl -o out --structured a/Foo.aidl"); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 549 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl"); |
| 550 | Options cpp_structured_options = |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 551 | Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 552 | Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl"); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 553 | io_delegate_.SetFileContents( |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 554 | "a/Foo.aidl", |
| 555 | StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;")); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 556 | |
| 557 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 558 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 559 | const string expected_stderr = |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 560 | "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. " |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 561 | "Parcelable must be defined in AIDL directly.\n"; |
| 562 | CaptureStderr(); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 563 | EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 564 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 565 | |
| 566 | CaptureStderr(); |
| 567 | EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
| 568 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 569 | } |
| 570 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 571 | TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) { |
| 572 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 573 | @JavaDerive(toString=true) parcelable Foo { int a; float b; })"); |
| 574 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 575 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 576 | |
| 577 | string java_out; |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 578 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 579 | EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {")); |
| 580 | |
| 581 | // Other backends shouldn't be bothered |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 582 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 583 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 584 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 585 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 586 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
| 587 | } |
| 588 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 589 | TEST_F(AidlTest, UnionSupportJavaDeriveToString) { |
| 590 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 591 | @JavaDerive(toString=true) union Foo { int a; int[] b; })"); |
| 592 | CaptureStderr(); |
| 593 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 594 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 595 | EXPECT_EQ("", GetCapturedStderr()); |
| 596 | |
| 597 | const string expected_to_string_method = R"--( |
| 598 | @Override |
| 599 | public String toString() { |
| 600 | switch (_tag) { |
| 601 | case a: return "a.Foo.a(" + (getA()) + ")"; |
| 602 | case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")"; |
| 603 | } |
| 604 | throw new IllegalStateException("unknown field: " + _tag); |
| 605 | } |
| 606 | )--"; |
| 607 | |
| 608 | string java_out; |
| 609 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 610 | EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method)); |
| 611 | } |
| 612 | |
Jiyong Park | 9aa3d04 | 2020-12-04 23:30:02 +0900 | [diff] [blame] | 613 | TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) { |
| 614 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 615 | @JavaDerive(equals=true) parcelable Foo { int a; float b; })"); |
| 616 | CaptureStderr(); |
| 617 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 618 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 619 | EXPECT_EQ("", GetCapturedStderr()); |
| 620 | |
| 621 | const std::string expected = R"--( |
| 622 | @Override |
| 623 | public boolean equals(Object other) { |
| 624 | if (this == other) return true; |
| 625 | if (other == null) return false; |
| 626 | if (!(other instanceof Foo)) return false; |
| 627 | Foo that = (Foo)other; |
| 628 | if (!java.util.Objects.deepEquals(a, that.a)) return false; |
| 629 | if (!java.util.Objects.deepEquals(b, that.b)) return false; |
| 630 | return true; |
| 631 | } |
| 632 | |
| 633 | @Override |
| 634 | public int hashCode() { |
| 635 | return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray()); |
| 636 | } |
| 637 | )--"; |
| 638 | |
| 639 | string java_out; |
| 640 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 641 | EXPECT_THAT(java_out, testing::HasSubstr(expected)); |
| 642 | } |
| 643 | |
| 644 | TEST_F(AidlTest, UnionSupportJavaDeriveEquals) { |
| 645 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 646 | @JavaDerive(equals=true) union Foo { int a; int[] b; })"); |
| 647 | CaptureStderr(); |
| 648 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 649 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 650 | EXPECT_EQ("", GetCapturedStderr()); |
| 651 | |
| 652 | const std::string expected = R"--( |
| 653 | @Override |
| 654 | public boolean equals(Object other) { |
| 655 | if (this == other) return true; |
| 656 | if (other == null) return false; |
| 657 | if (!(other instanceof Foo)) return false; |
| 658 | Foo that = (Foo)other; |
| 659 | if (_tag != that._tag) return false; |
| 660 | if (!java.util.Objects.deepEquals(_value, that._value)) return false; |
| 661 | return true; |
| 662 | } |
| 663 | |
| 664 | @Override |
| 665 | public int hashCode() { |
| 666 | return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray()); |
| 667 | } |
| 668 | )--"; |
| 669 | |
| 670 | string java_out; |
| 671 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 672 | EXPECT_THAT(java_out, testing::HasSubstr(expected)); |
| 673 | } |
| 674 | |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 675 | TEST_F(AidlTest, RejectsJavaDeriveAnnotation) { |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 676 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 677 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 678 | "package a; @JavaDerive(blah=true) parcelable Foo{}"); |
| 679 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 680 | CaptureStderr(); |
| 681 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 682 | const std::string expected_stderr = |
| 683 | "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive."; |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 684 | EXPECT_THAT(GetCapturedStderr(), |
| 685 | HasSubstr("Parameter blah not supported for annotation JavaDerive.")); |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 686 | } |
| 687 | |
| 688 | { |
| 689 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 690 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 691 | CaptureStderr(); |
| 692 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 693 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation")); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 694 | } |
| 695 | |
| 696 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 697 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 698 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 699 | CaptureStderr(); |
| 700 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 701 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("'JavaDerive' is not a supported annotation")); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 702 | } |
| 703 | } |
| 704 | |
Jiyong Park | 27fd7fd | 2020-08-27 16:25:09 +0900 | [diff] [blame] | 705 | TEST_P(AidlTest, ParseDescriptorAnnotation) { |
| 706 | AidlError error; |
| 707 | auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})", |
| 708 | typenames_, GetLanguage(), &error, {"--structured"}); |
| 709 | ASSERT_EQ(AidlError::OK, error); |
| 710 | ASSERT_NE(nullptr, parse_result); |
| 711 | const AidlInterface* interface = parse_result->AsInterface(); |
| 712 | ASSERT_NE(nullptr, interface); |
| 713 | ASSERT_EQ("IBar", interface->GetDescriptor()); |
| 714 | } |
| 715 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 716 | TEST_P(AidlTest, AcceptsOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 717 | const string oneway_method = "package a; interface IFoo { oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 718 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 719 | } |
| 720 | |
| 721 | TEST_P(AidlTest, AcceptsOnewayInterface) { |
| 722 | const string oneway_interface = "package a; oneway interface IBar { void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 723 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 724 | } |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 725 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 726 | TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 727 | const string oneway_method = |
| 728 | "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 729 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 730 | } |
| 731 | |
Steven Moreland | 65297cc | 2020-04-20 20:17:36 -0700 | [diff] [blame] | 732 | TEST_P(AidlTest, AnnotationsInMultiplePlaces) { |
| 733 | const string oneway_method = |
| 734 | "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }"; |
| 735 | const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()); |
| 736 | ASSERT_NE(nullptr, defined); |
| 737 | const AidlInterface* iface = defined->AsInterface(); |
| 738 | ASSERT_NE(nullptr, iface); |
| 739 | |
| 740 | const auto& methods = iface->GetMethods(); |
| 741 | ASSERT_EQ(1u, methods.size()); |
| 742 | const auto& method = methods[0]; |
| 743 | const AidlTypeSpecifier& ret_type = method->GetType(); |
| 744 | |
| 745 | // TODO(b/151102494): these annotations should be on the method |
| 746 | ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage()); |
| 747 | ASSERT_TRUE(ret_type.IsHide()); |
| 748 | } |
| 749 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 750 | TEST_P(AidlTest, WritesComments) { |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 751 | string foo_interface = |
| 752 | "package a; /* foo */ interface IFoo {" |
| 753 | " /* i */ int i();" |
| 754 | " /* j */ @nullable String j();" |
| 755 | " /* k */ @UnsupportedAppUsage oneway void k(int a); }"; |
| 756 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 757 | auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 758 | EXPECT_NE(nullptr, parse_result); |
| 759 | EXPECT_EQ("/* foo */", parse_result->GetComments()); |
| 760 | |
| 761 | const AidlInterface* interface = parse_result->AsInterface(); |
| 762 | EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments()); |
| 763 | EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments()); |
| 764 | EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments()); |
| 765 | } |
| 766 | |
Jooyung Han | 1a551d3 | 2020-10-05 15:37:26 +0900 | [diff] [blame] | 767 | TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) { |
| 768 | io_delegate_.SetFileContents("p/cpp_header.aidl", |
| 769 | R"(package p; |
| 770 | parcelable cpp_header cpp_header "bar/header";)"); |
| 771 | import_paths_.emplace(""); |
| 772 | const string input_path = "p/IFoo.aidl"; |
| 773 | const string input = R"(package p; |
| 774 | import p.cpp_header; |
| 775 | interface IFoo { |
| 776 | // get bar |
| 777 | cpp_header get(); |
| 778 | })"; |
| 779 | |
| 780 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 781 | EXPECT_NE(nullptr, parse_result); |
| 782 | const AidlInterface* interface = parse_result->AsInterface(); |
| 783 | EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments()); |
| 784 | } |
| 785 | |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 786 | TEST_F(AidlTest, ParsesPreprocessedFile) { |
| 787 | string simple_content = "parcelable a.Foo;\ninterface b.IBar;"; |
| 788 | io_delegate_.SetFileContents("path", simple_content); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 789 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 790 | EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 791 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 792 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 793 | } |
| 794 | |
| 795 | TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) { |
| 796 | string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t"; |
| 797 | io_delegate_.SetFileContents("path", simple_content); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 798 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 799 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 800 | EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 801 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 802 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 803 | } |
| 804 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 805 | TEST_P(AidlTest, PreferImportToPreprocessed) { |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 806 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;"); |
| 807 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; " |
| 808 | "interface IBar {}"); |
| 809 | preprocessed_files_.push_back("preprocessed"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 810 | import_paths_.emplace(""); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 811 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 812 | typenames_, GetLanguage()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 813 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 814 | |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 815 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 816 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 817 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 818 | // But if we request just "IBar" we should get our imported one. |
Steven Moreland | 02e012e | 2018-08-02 14:58:10 -0700 | [diff] [blame] | 819 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, ""); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 820 | ambiguous_type.Resolve(typenames_); |
| 821 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 822 | } |
| 823 | |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 824 | // Special case of PreferImportToPreprocessed. Imported type should be preferred |
| 825 | // even when the preprocessed file already has the same type. |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 826 | TEST_P(AidlTest, B147918827) { |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 827 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;"); |
| 828 | io_delegate_.SetFileContents("one/IBar.aidl", |
| 829 | "package one; " |
| 830 | "interface IBar {}"); |
| 831 | preprocessed_files_.push_back("preprocessed"); |
| 832 | import_paths_.emplace(""); |
| 833 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 834 | typenames_, GetLanguage()); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 835 | EXPECT_NE(nullptr, parse_result); |
| 836 | |
| 837 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 838 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 839 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 840 | // But if we request just "IBar" we should get our imported one. |
| 841 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, ""); |
| 842 | ambiguous_type.Resolve(typenames_); |
| 843 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
| 844 | } |
| 845 | |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 846 | TEST_F(AidlTest, WritePreprocessedFile) { |
| 847 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 848 | "package p; parcelable Outer.Inner;"); |
| 849 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;" |
| 850 | "interface IBar {}"); |
| 851 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 852 | vector<string> args { |
| 853 | "aidl", |
| 854 | "--preprocess", |
| 855 | "preprocessed", |
| 856 | "p/Outer.aidl", |
| 857 | "one/IBar.aidl"}; |
| 858 | Options options = Options::From(args); |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 859 | EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_)); |
| 860 | |
| 861 | string output; |
| 862 | EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output)); |
| 863 | EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output); |
| 864 | } |
| 865 | |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 866 | TEST_F(AidlTest, JavaParcelableOutput) { |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 867 | io_delegate_.SetFileContents( |
| 868 | "Rect.aidl", |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 869 | "@Hide\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 870 | "parcelable Rect {\n" |
| 871 | " // Comment\n" |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 872 | " @Hide\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 873 | " int x=5;\n" |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 874 | " @Hide\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 875 | " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", " |
Andrei Onea | 07fa3e0 | 2019-07-04 17:55:19 +0100 | [diff] [blame] | 876 | "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" " |
| 877 | "+ \"y\")\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 878 | " int y;\n" |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 879 | " ParcelFileDescriptor fd;\n" |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 880 | " List<ParcelFileDescriptor> fds;\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 881 | "}"); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 882 | |
| 883 | vector<string> args{"aidl", "Rect.aidl"}; |
| 884 | Options options = Options::From(args); |
| 885 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 886 | |
| 887 | string output; |
| 888 | EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output)); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 889 | EXPECT_EQ(kExpectedJavaParcelableOutputContents, output); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 890 | } |
| 891 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 892 | TEST_F(AidlTest, CppHeaderIncludes) { |
| 893 | io_delegate_.SetFileContents("IFoo.aidl", |
| 894 | "interface IFoo {\n" |
| 895 | " @nullable List<String> foo();\n" |
| 896 | "}"); |
| 897 | |
| 898 | vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"}; |
| 899 | Options options = Options::From(args); |
| 900 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 901 | std::vector<std::string> empty; |
| 902 | EXPECT_EQ(empty, io_delegate_.ListFiles("")); |
| 903 | EXPECT_EQ(empty, io_delegate_.ListFiles("/")); |
| 904 | EXPECT_EQ(empty, io_delegate_.ListFiles("out")); |
| 905 | |
| 906 | // Make sure the optional and String16.h includes are added |
| 907 | string output; |
| 908 | EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output)); |
| 909 | EXPECT_EQ(kExpectedCppHeaderOutput, output); |
| 910 | } |
| 911 | |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 912 | TEST_P(AidlTest, SupportDeprecated) { |
| 913 | struct TestCase { |
| 914 | std::string output_file; |
| 915 | std::string annotation; |
| 916 | }; |
| 917 | |
| 918 | auto CheckDeprecated = [&](const std::string& filename, const std::string& contents, |
| 919 | std::map<Options::Language, TestCase> expectation) { |
| 920 | io_delegate_.SetFileContents(filename, contents); |
| 921 | |
| 922 | auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename + |
| 923 | " --out=out --header_out=out"); |
| 924 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 925 | if (auto it = expectation.find(GetLanguage()); it != expectation.end()) { |
| 926 | const auto& test_case = it->second; |
| 927 | string output; |
| 928 | EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output)) |
| 929 | << base::Join(io_delegate_.ListOutputFiles(), ","); |
| 930 | EXPECT_THAT(output, HasSubstr(test_case.annotation)); |
| 931 | } |
| 932 | }; |
| 933 | |
| 934 | CheckDeprecated("IFoo.aidl", |
| 935 | "interface IFoo {\n" |
| 936 | " /** @deprecated use bar() */\n" |
| 937 | " List<String> foo();\n" |
| 938 | "}", |
| 939 | { |
| 940 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 941 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 942 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 943 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 944 | }); |
| 945 | |
| 946 | CheckDeprecated("Foo.aidl", |
| 947 | "parcelable Foo {\n" |
| 948 | " /** @deprecated use bar*/\n" |
| 949 | " int foo = 0;\n" |
| 950 | "}", |
| 951 | { |
| 952 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 953 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 954 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 955 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 956 | }); |
| 957 | |
| 958 | CheckDeprecated("IFoo.aidl", |
| 959 | "interface IFoo {\n" |
| 960 | " /** @deprecated use bar*/\n" |
| 961 | " const int FOO = 0;\n" |
| 962 | "}", |
| 963 | { |
| 964 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 965 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 966 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 967 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 968 | }); |
| 969 | |
| 970 | // union fields |
| 971 | CheckDeprecated("Foo.aidl", |
| 972 | "union Foo {\n" |
| 973 | " int bar = 0;\n" |
| 974 | " /** @deprecated use bar*/\n" |
| 975 | " int foo;\n" |
| 976 | "}", |
| 977 | { |
| 978 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 979 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 980 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 981 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 982 | }); |
| 983 | |
| 984 | CheckDeprecated("Foo.aidl", |
| 985 | "/** @deprecated use Bar */\n" |
| 986 | "parcelable Foo {}", |
| 987 | { |
| 988 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 989 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 990 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 991 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 992 | }); |
| 993 | |
| 994 | CheckDeprecated("Foo.aidl", |
| 995 | "/** @deprecated use Bar */\n" |
| 996 | "union Foo { int foo = 0; }", |
| 997 | { |
| 998 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 999 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1000 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 1001 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1002 | }); |
| 1003 | |
| 1004 | CheckDeprecated("IFoo.aidl", |
| 1005 | "/** @deprecated use IBar */\n" |
| 1006 | "interface IFoo {}", |
| 1007 | { |
| 1008 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 1009 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 1010 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 1011 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 1012 | }); |
| 1013 | |
| 1014 | CheckDeprecated("Foo.aidl", |
| 1015 | "/** @deprecated use IBar */\n" |
| 1016 | "enum Foo { FOO }", |
| 1017 | { |
| 1018 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 1019 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1020 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 1021 | // TODO(b/174514415) support "deprecated" |
| 1022 | // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1023 | }); |
| 1024 | } |
| 1025 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1026 | TEST_P(AidlTest, RequireOuterClass) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1027 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n"; |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1028 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 1029 | "package p; parcelable Outer.Inner;"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1030 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1031 | CaptureStderr(); |
| 1032 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1033 | "package p; import p.Outer; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1034 | typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1035 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1036 | } |
| 1037 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1038 | TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) { |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1039 | io_delegate_.SetFileContents("preprocessed", |
| 1040 | "parcelable p.Outer.Inner;"); |
| 1041 | preprocessed_files_.push_back("preprocessed"); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1042 | auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1043 | typenames_, GetLanguage()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1044 | // TODO(wiley): This should actually return nullptr because we require |
| 1045 | // the outer class name. However, for legacy reasons, |
| 1046 | // this behavior must be maintained. b/17415692 |
| 1047 | EXPECT_NE(nullptr, parse_result); |
| 1048 | } |
| 1049 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 1050 | TEST_F(AidlTest, FailOnParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1051 | const string expected_foo_stderr = |
| 1052 | "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. " |
| 1053 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 1054 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1055 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;"); |
| 1056 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 1057 | // By default, we shouldn't fail on parcelable. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1058 | Options options1 = Options::From("aidl p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1059 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1060 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1061 | EXPECT_EQ("", GetCapturedStderr()); |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1062 | |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1063 | // -b considers this an error |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1064 | Options options2 = Options::From("aidl -b p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1065 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1066 | EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1067 | EXPECT_EQ(expected_foo_stderr, GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1068 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1069 | const string expected_bar_stderr = |
| 1070 | "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. " |
| 1071 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 1072 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1073 | io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}"); |
| 1074 | |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 1075 | // With '-b' option, a parcelable and an interface should fail. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1076 | Options options3 = Options::From("aidl p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1077 | CaptureStderr(); |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 1078 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1079 | EXPECT_EQ("", GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1080 | Options options4 = Options::From("aidl -b p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1081 | CaptureStderr(); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1082 | EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1083 | EXPECT_EQ(expected_bar_stderr, GetCapturedStderr()); |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 1084 | } |
| 1085 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1086 | TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1087 | const string expected_stderr = |
| 1088 | "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a " |
| 1089 | "structured interface.\n"; |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 1090 | io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;"); |
| 1091 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1092 | AidlError error; |
| 1093 | CaptureStderr(); |
| 1094 | EXPECT_EQ( |
| 1095 | nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 1096 | Parse("p/IFoo.aidl", |
| 1097 | "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1098 | typenames_, GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1099 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1100 | EXPECT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 1101 | } |
| 1102 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1103 | TEST_P(AidlTest, FailOnDuplicateConstantNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1104 | AidlError error; |
| 1105 | const string expected_stderr = |
| 1106 | "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n"; |
| 1107 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1108 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1109 | R"(package p; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 1110 | interface IFoo { |
| 1111 | const String DUPLICATED = "d"; |
| 1112 | const int DUPLICATED = 1; |
| 1113 | } |
| 1114 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1115 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1116 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1117 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 1118 | } |
| 1119 | |
Steven Moreland | e689da2 | 2020-11-10 02:06:30 +0000 | [diff] [blame] | 1120 | TEST_P(AidlTest, FailOnTooBigConstant) { |
| 1121 | AidlError error; |
| 1122 | const string expected_stderr = |
| 1123 | "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n"; |
| 1124 | CaptureStderr(); |
| 1125 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1126 | R"(package p; |
| 1127 | interface IFoo { |
| 1128 | const byte type2small = 256; |
| 1129 | } |
| 1130 | )", |
| 1131 | typenames_, GetLanguage(), &error)); |
| 1132 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1133 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 1134 | } |
| 1135 | |
Jooyung Han | 30f64ad | 2020-12-15 08:16:31 +0900 | [diff] [blame] | 1136 | TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) { |
| 1137 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }"); |
| 1138 | CaptureStderr(); |
| 1139 | auto options = Options::From("aidl --lang java -o out a/Foo.aidl"); |
| 1140 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 1141 | EXPECT_EQ("", GetCapturedStderr()); |
| 1142 | string code; |
| 1143 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
| 1144 | EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;")); |
| 1145 | } |
| 1146 | |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1147 | TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) { |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1148 | using Ptr = unique_ptr<AidlConstantValue>; |
| 1149 | const AidlLocation& loc = AIDL_LOCATION_HERE; |
| 1150 | |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1151 | EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>()); |
| 1152 | EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>()); |
| 1153 | EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>()); |
| 1154 | EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1155 | |
| 1156 | AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+", |
| 1157 | Ptr(AidlConstantValue::Integral(loc, "1"))); |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1158 | EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1159 | |
| 1160 | auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>}; |
| 1161 | values->emplace_back(AidlConstantValue::String(loc, "\"hello\"")); |
| 1162 | values->emplace_back(AidlConstantValue::String(loc, "\"world\"")); |
| 1163 | vector<string> expected{"hello", "world"}; |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1164 | EXPECT_EQ( |
| 1165 | expected, |
| 1166 | Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1167 | } |
| 1168 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1169 | TEST_P(AidlTest, FailOnManyDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1170 | AidlError error; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1171 | const string expected_stderr = |
| 1172 | "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 1173 | CaptureStderr(); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1174 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1175 | R"(package p; |
| 1176 | interface IFoo {} |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1177 | parcelable IBar {} |
| 1178 | parcelable StructuredParcelable {} |
| 1179 | interface IBaz {} |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 1180 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1181 | typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 1182 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1183 | // Parse success is important for clear error handling even if the cases aren't |
| 1184 | // actually supported in code generation. |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1185 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1186 | } |
| 1187 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1188 | TEST_P(AidlTest, FailOnNoDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1189 | AidlError error; |
| 1190 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n"; |
| 1191 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1192 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1193 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1194 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1195 | } |
| 1196 | |
Steven Moreland | f9e922f | 2020-07-08 21:15:27 +0000 | [diff] [blame] | 1197 | TEST_P(AidlTest, FailOnEmptyListWithComma) { |
| 1198 | AidlError error; |
| 1199 | const string expected_stderr = |
| 1200 | "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n"; |
| 1201 | CaptureStderr(); |
| 1202 | EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })", |
| 1203 | typenames_, GetLanguage(), &error)); |
| 1204 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1205 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1206 | } |
| 1207 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1208 | TEST_P(AidlTest, FailOnMalformedConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1209 | AidlError error; |
| 1210 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 1211 | "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1212 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1213 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1214 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1215 | interface IFoo { |
| 1216 | const int BAD_HEX_VALUE = 0xffffffffffffffffff; |
| 1217 | } |
| 1218 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1219 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1220 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1221 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1222 | } |
| 1223 | |
Jiyong Park | 1813218 | 2020-06-08 20:24:40 +0900 | [diff] [blame] | 1224 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) { |
| 1225 | AidlError error; |
| 1226 | const string expected_stderr = |
| 1227 | "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or " |
| 1228 | "cpp_header (which can also be used as an identifier)\n"; |
| 1229 | CaptureStderr(); |
| 1230 | // Notice the trailing dot(.) in the name, which isn't a correct name |
| 1231 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_, |
| 1232 | GetLanguage(), &error)); |
| 1233 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1234 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1235 | } |
| 1236 | |
| 1237 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) { |
| 1238 | AidlError error; |
| 1239 | const string expected_stderr = |
| 1240 | "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or " |
| 1241 | "cpp_header (which can also be used as an identifier)\n"; |
| 1242 | CaptureStderr(); |
| 1243 | // Notice the trailing dot(.) in the package name |
| 1244 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_, |
| 1245 | GetLanguage(), &error)); |
| 1246 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1247 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1248 | } |
| 1249 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1250 | TEST_P(AidlTest, ParsePositiveConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1251 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1252 | auto parse_result = Parse("p/IFoo.aidl", |
| 1253 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1254 | interface IFoo { |
| 1255 | const int POSITIVE_HEX_VALUE = 0xf5; |
| 1256 | } |
| 1257 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1258 | typenames_, GetLanguage(), &error); |
| 1259 | EXPECT_NE(nullptr, parse_result); |
| 1260 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1261 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1262 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1263 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1264 | EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1265 | EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1266 | EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1267 | } |
| 1268 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1269 | TEST_P(AidlTest, ParseNegativeConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1270 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1271 | auto parse_result = Parse("p/IFoo.aidl", |
| 1272 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1273 | interface IFoo { |
| 1274 | const int NEGATIVE_HEX_VALUE = 0xffffffff; |
| 1275 | } |
| 1276 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1277 | typenames_, GetLanguage(), &error); |
| 1278 | ASSERT_NE(nullptr, parse_result); |
| 1279 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1280 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1281 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1282 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1283 | EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1284 | EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1285 | EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1286 | } |
| 1287 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1288 | TEST_P(AidlTest, UnderstandsNestedParcelables) { |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1289 | io_delegate_.SetFileContents( |
| 1290 | "p/Outer.aidl", |
| 1291 | "package p; parcelable Outer.Inner cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1292 | import_paths_.emplace(""); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1293 | const string input_path = "p/IFoo.aidl"; |
| 1294 | const string input = "package p; import p.Outer; interface IFoo" |
| 1295 | " { Outer.Inner get(); }"; |
| 1296 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1297 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1298 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1299 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1300 | EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1301 | // C++ uses "::" instead of "." to refer to a inner class. |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1302 | AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, ""); |
| 1303 | EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_)); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1304 | } |
| 1305 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1306 | TEST_P(AidlTest, UnderstandsNativeParcelables) { |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1307 | io_delegate_.SetFileContents( |
| 1308 | "p/Bar.aidl", |
Casey Dahlin | cd63921 | 2015-12-15 12:51:04 -0800 | [diff] [blame] | 1309 | "package p; parcelable Bar cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1310 | import_paths_.emplace(""); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1311 | const string input_path = "p/IFoo.aidl"; |
| 1312 | const string input = "package p; import p.Bar; interface IFoo { }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1313 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1314 | EXPECT_NE(nullptr, parse_result); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1315 | EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1316 | AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, ""); |
| 1317 | native_type.Resolve(typenames_); |
| 1318 | |
| 1319 | EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_)); |
| 1320 | // C++ understands C++ specific stuff |
| 1321 | EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_)); |
| 1322 | set<string> headers; |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 1323 | cpp::AddHeaders(native_type, typenames_, &headers); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1324 | EXPECT_EQ(1u, headers.size()); |
| 1325 | EXPECT_EQ(1u, headers.count("baz/header")); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1326 | } |
| 1327 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1328 | TEST_F(AidlTest, WritesCorrectDependencyFile) { |
| 1329 | // While the in tree build system always gives us an output file name, |
| 1330 | // other android tools take advantage of our ability to infer the intended |
| 1331 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1332 | vector<string> args = { |
| 1333 | "aidl", |
| 1334 | "-d dep/file/path", |
| 1335 | "-o place/for/output", |
| 1336 | "p/IFoo.aidl"}; |
| 1337 | Options options = Options::From(args); |
| 1338 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1339 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1340 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1341 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1342 | EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents); |
| 1343 | } |
| 1344 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1345 | TEST_F(AidlTest, WritesCorrectDependencyFileNinja) { |
| 1346 | // While the in tree build system always gives us an output file name, |
| 1347 | // other android tools take advantage of our ability to infer the intended |
| 1348 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1349 | vector<string> args = { |
| 1350 | "aidl", |
| 1351 | "-d dep/file/path", |
| 1352 | "--ninja", |
| 1353 | "-o place/for/output", |
| 1354 | "p/IFoo.aidl"}; |
| 1355 | Options options = Options::From(args); |
| 1356 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1357 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1358 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1359 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1360 | EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents); |
| 1361 | } |
| 1362 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1363 | TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) { |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1364 | // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does |
| 1365 | // this by calling aidl with every .aidl file it finds, then parsing the |
| 1366 | // generated dependency files. Those that reference .java output files are |
| 1367 | // for interfaces and those that do not are parcelables. However, for both |
| 1368 | // parcelables and interfaces, we *must* generate a non-empty dependency file. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1369 | vector<string> args = { |
| 1370 | "aidl", |
| 1371 | "-o place/for/output", |
| 1372 | "-d dep/file/path", |
| 1373 | "p/Foo.aidl"}; |
| 1374 | Options options = Options::From(args); |
| 1375 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1376 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1377 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1378 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1379 | EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents); |
| 1380 | } |
| 1381 | |
| 1382 | TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) { |
| 1383 | vector<string> args = { |
| 1384 | "aidl", |
| 1385 | "--structured", |
| 1386 | "-o place/for/output", |
| 1387 | "-d dep/file/path", |
| 1388 | "p/Foo.aidl"}; |
| 1389 | Options options = Options::From(args); |
| 1390 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}"); |
| 1391 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1392 | string actual_dep_file_contents; |
| 1393 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
| 1394 | EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1395 | } |
| 1396 | |
Jiyong Park | 9ca5c7e | 2019-10-17 15:01:14 +0900 | [diff] [blame] | 1397 | TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) { |
| 1398 | vector<string> args = { |
| 1399 | "aidl", |
| 1400 | "--lang=java", |
| 1401 | "-o place/for/output", |
| 1402 | "p/Foo.aidl"}; |
| 1403 | Options options = Options::From(args); |
| 1404 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
| 1405 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1406 | string output_file_contents; |
| 1407 | EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents)); |
| 1408 | } |
| 1409 | |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1410 | TEST_P(AidlTest, RejectsListArray) { |
Devin Moore | 6a01ca1 | 2020-08-28 10:24:19 -0700 | [diff] [blame] | 1411 | const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n"; |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1412 | const string list_array_parcelable = |
| 1413 | "package a; parcelable Foo {\n" |
| 1414 | " List[] lists; }"; |
| 1415 | CaptureStderr(); |
| 1416 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage())); |
| 1417 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1418 | } |
| 1419 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1420 | TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) { |
| 1421 | AidlError error; |
| 1422 | string expected_stderr = |
| 1423 | "ERROR: a/IFoo.aidl:2.7-11: " |
| 1424 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 1425 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 1426 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 1427 | if (GetLanguage() != Options::Language::JAVA) { |
| 1428 | expected_stderr = |
| 1429 | "ERROR: a/IFoo.aidl:2.1-7: " |
| 1430 | "Currently, only the Java backend supports non-generic List.\n"; |
| 1431 | } |
| 1432 | |
| 1433 | const string primitive_interface = |
| 1434 | "package a; interface IFoo {\n" |
| 1435 | " List foo(); }"; |
| 1436 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1437 | AidlTypenames tn1; |
| 1438 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1439 | {"--structured"})); |
| 1440 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1441 | |
| 1442 | string primitive_parcelable = |
| 1443 | "package a; parcelable IFoo {\n" |
| 1444 | " List foo;}"; |
| 1445 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1446 | AidlTypenames tn2; |
| 1447 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1448 | {"--structured"})); |
| 1449 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1450 | } |
| 1451 | |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1452 | TEST_P(AidlTest, ExtensionTest) { |
| 1453 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1454 | string extendable_parcelable = |
| 1455 | "package a; parcelable Data {\n" |
| 1456 | " ParcelableHolder extension;\n" |
| 1457 | " ParcelableHolder extension2;\n" |
| 1458 | "}"; |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1459 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1460 | EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1461 | EXPECT_EQ( |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1462 | "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1463 | "yet.\n", |
| 1464 | GetCapturedStderr()); |
| 1465 | } else { |
| 1466 | EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1467 | EXPECT_EQ("", GetCapturedStderr()); |
| 1468 | } |
| 1469 | } |
| 1470 | TEST_P(AidlTest, ParcelableHolderAsReturnType) { |
| 1471 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1472 | string parcelableholder_return_interface = |
| 1473 | "package a; interface IFoo {\n" |
| 1474 | " ParcelableHolder foo();\n" |
| 1475 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1476 | EXPECT_EQ(nullptr, |
| 1477 | Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage())); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1478 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1479 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1480 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1481 | "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1482 | "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1483 | "yet.\n", |
| 1484 | GetCapturedStderr()); |
| 1485 | return; |
| 1486 | } |
| 1487 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n", |
| 1488 | GetCapturedStderr()); |
| 1489 | } |
| 1490 | |
| 1491 | TEST_P(AidlTest, ParcelableHolderAsArgumentType) { |
| 1492 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1493 | string extendable_parcelable_arg_interface = |
| 1494 | "package a; interface IFoo {\n" |
| 1495 | " void foo(in ParcelableHolder ph);\n" |
| 1496 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1497 | EXPECT_EQ(nullptr, |
| 1498 | Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage())); |
| 1499 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1500 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1501 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1502 | "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1503 | "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1504 | "yet.\n", |
| 1505 | GetCapturedStderr()); |
| 1506 | return; |
| 1507 | } |
| 1508 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n", |
| 1509 | GetCapturedStderr()); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1510 | } |
| 1511 | |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1512 | TEST_P(AidlTest, RejectNullableParcelableHolderField) { |
| 1513 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1514 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1515 | const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"; |
| 1516 | CaptureStderr(); |
| 1517 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1518 | if (GetLanguage() == Options::Language::RUST) { |
| 1519 | EXPECT_EQ( |
| 1520 | "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n" |
| 1521 | "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder " |
| 1522 | "yet.\n", |
| 1523 | GetCapturedStderr()); |
| 1524 | return; |
| 1525 | } |
| 1526 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1527 | } |
| 1528 | |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1529 | TEST_P(AidlTest, ParcelablesWithConstants) { |
| 1530 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1531 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1532 | CaptureStderr(); |
| 1533 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1534 | EXPECT_EQ("", GetCapturedStderr()); |
| 1535 | } |
| 1536 | |
| 1537 | TEST_P(AidlTest, UnionWithConstants) { |
| 1538 | io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1539 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1540 | CaptureStderr(); |
| 1541 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1542 | EXPECT_EQ("", GetCapturedStderr()); |
| 1543 | } |
| 1544 | |
Jooyung Han | 633eab6 | 2021-01-07 14:12:40 +0900 | [diff] [blame^] | 1545 | TEST_F(AidlTest, ConstantsWithAnnotations) { |
| 1546 | io_delegate_.SetFileContents("IFoo.aidl", |
| 1547 | "interface IFoo {\n" |
| 1548 | " @JavaPassthrough(annotation=\"@Foo\")\n" |
| 1549 | " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n" |
| 1550 | "}"); |
| 1551 | Options options = Options::From("aidl IFoo.aidl --lang=java -o out"); |
| 1552 | CaptureStderr(); |
| 1553 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1554 | EXPECT_EQ("", GetCapturedStderr()); |
| 1555 | string code; |
| 1556 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code)); |
| 1557 | EXPECT_THAT(code, HasSubstr("@Foo\n")); |
| 1558 | EXPECT_THAT(code, HasSubstr("@Bar\n")); |
| 1559 | } |
| 1560 | |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1561 | TEST_F(AidlTest, ApiDump) { |
| 1562 | io_delegate_.SetFileContents( |
| 1563 | "foo/bar/IFoo.aidl", |
| 1564 | "package foo.bar;\n" |
| 1565 | "import foo.bar.Data;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1566 | "// comment @hide\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1567 | "interface IFoo {\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1568 | " /* @hide */\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1569 | " int foo(out int[] a, String b, boolean c, inout List<String> d);\n" |
| 1570 | " int foo2(@utf8InCpp String x, inout List<String> y);\n" |
| 1571 | " IFoo foo3(IFoo foo);\n" |
| 1572 | " Data getData();\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1573 | " // @hide\n" |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1574 | " const int A = 1;\n" |
| 1575 | " const String STR = \"Hello\";\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1576 | "}\n"); |
| 1577 | io_delegate_.SetFileContents("foo/bar/Data.aidl", |
| 1578 | "package foo.bar;\n" |
| 1579 | "import foo.bar.IFoo;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1580 | "/* @hide*/\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1581 | "parcelable Data {\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1582 | " // @hide\n" |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 1583 | " int x = 10;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1584 | " // @hide\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1585 | " int y;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1586 | " /*@hide2*/\n" |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 1587 | " IFoo foo;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1588 | " // It should be @hide property\n" |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1589 | " @nullable String[] c;\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1590 | "}\n"); |
| 1591 | io_delegate_.SetFileContents("api.aidl", ""); |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1592 | vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.", |
| 1593 | "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"}; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1594 | Options options = Options::From(args); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1595 | bool result = dump_api(options, io_delegate_); |
| 1596 | ASSERT_TRUE(result); |
| 1597 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1598 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1599 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1600 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1601 | interface IFoo { |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1602 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1603 | int foo(out int[] a, String b, boolean c, inout List<String> d); |
| 1604 | int foo2(@utf8InCpp String x, inout List<String> y); |
| 1605 | foo.bar.IFoo foo3(foo.bar.IFoo foo); |
| 1606 | foo.bar.Data getData(); |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1607 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1608 | const int A = 1; |
| 1609 | const String STR = "Hello"; |
| 1610 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1611 | )")); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1612 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1613 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1614 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1615 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1616 | parcelable Data { |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1617 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1618 | int x = 10; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1619 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1620 | int y; |
| 1621 | foo.bar.IFoo foo; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1622 | /* @hide */ |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1623 | @nullable String[] c; |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1624 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1625 | )")); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1626 | } |
| 1627 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1628 | TEST_F(AidlTest, ApiDumpWithManualIds) { |
| 1629 | io_delegate_.SetFileContents( |
| 1630 | "foo/bar/IFoo.aidl", |
| 1631 | "package foo.bar;\n" |
| 1632 | "interface IFoo {\n" |
| 1633 | " int foo() = 1;\n" |
| 1634 | " int bar() = 2;\n" |
| 1635 | " int baz() = 10;\n" |
| 1636 | "}\n"); |
| 1637 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1638 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1639 | Options options = Options::From(args); |
| 1640 | bool result = dump_api(options, io_delegate_); |
| 1641 | ASSERT_TRUE(result); |
| 1642 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1643 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1644 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1645 | interface IFoo { |
| 1646 | int foo() = 1; |
| 1647 | int bar() = 2; |
| 1648 | int baz() = 10; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1649 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1650 | )")); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1651 | } |
| 1652 | |
| 1653 | TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1654 | const string expected_stderr = |
| 1655 | "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of " |
| 1656 | "them.\n"; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1657 | io_delegate_.SetFileContents( |
| 1658 | "foo/bar/IFoo.aidl", |
| 1659 | "package foo.bar;\n" |
| 1660 | "interface IFoo {\n" |
| 1661 | " int foo() = 1;\n" |
| 1662 | " int bar();\n" |
| 1663 | " int baz() = 10;\n" |
| 1664 | "}\n"); |
| 1665 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1666 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1667 | Options options = Options::From(args); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1668 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1669 | EXPECT_FALSE(dump_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1670 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1671 | } |
| 1672 | |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1673 | TEST_F(AidlTest, ApiDumpConstWithAnnotation) { |
| 1674 | io_delegate_.SetFileContents("foo/bar/IFoo.aidl", |
| 1675 | "package foo.bar;\n" |
| 1676 | "interface IFoo {\n" |
| 1677 | " @utf8InCpp String foo();\n" |
| 1678 | " const @utf8InCpp String bar = \"bar\";\n" |
| 1679 | "}\n"); |
| 1680 | |
| 1681 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
| 1682 | Options options = Options::From(args); |
| 1683 | CaptureStderr(); |
| 1684 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1685 | EXPECT_EQ("", GetCapturedStderr()); |
| 1686 | string actual; |
| 1687 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1688 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
| 1689 | interface IFoo { |
| 1690 | @utf8InCpp String foo(); |
Jooyung Han | b3ca630 | 2020-11-27 14:13:27 +0900 | [diff] [blame] | 1691 | const @utf8InCpp String bar = "bar"; |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1692 | } |
| 1693 | )"), |
| 1694 | actual); |
| 1695 | } |
| 1696 | |
Jooyung Han | fdaae1d | 2020-12-14 13:16:15 +0900 | [diff] [blame] | 1697 | TEST_F(AidlTest, ApiDumpWithEnums) { |
| 1698 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 1699 | "package foo.bar;\n" |
| 1700 | "enum Enum {\n" |
| 1701 | " FOO,\n" |
| 1702 | " BAR = FOO + 1,\n" |
| 1703 | "}\n"); |
| 1704 | |
| 1705 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"}; |
| 1706 | Options options = Options::From(args); |
| 1707 | CaptureStderr(); |
| 1708 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1709 | EXPECT_EQ("", GetCapturedStderr()); |
| 1710 | string actual; |
| 1711 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual)); |
| 1712 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1713 | "enum Enum {\n" |
| 1714 | " FOO = 0,\n" |
| 1715 | " BAR = 1,\n" |
| 1716 | "}\n"), |
| 1717 | actual); |
| 1718 | } |
| 1719 | |
| 1720 | TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) { |
| 1721 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 1722 | "package foo.bar;\n" |
| 1723 | "enum Enum {\n" |
| 1724 | " FOO,\n" |
| 1725 | "}\n"); |
| 1726 | io_delegate_.SetFileContents("foo/bar/Foo.aidl", |
| 1727 | "package foo.bar;\n" |
| 1728 | "import foo.bar.Enum;\n" |
| 1729 | "parcelable Foo {\n" |
| 1730 | " Enum e = Enum.FOO;\n" |
| 1731 | "}\n"); |
| 1732 | |
| 1733 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"}; |
| 1734 | Options options = Options::From(args); |
| 1735 | CaptureStderr(); |
| 1736 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1737 | EXPECT_EQ("", GetCapturedStderr()); |
| 1738 | string actual; |
| 1739 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual)); |
| 1740 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1741 | "parcelable Foo {\n" |
| 1742 | " foo.bar.Enum e = foo.bar.Enum.FOO;\n" |
| 1743 | "}\n"), |
| 1744 | actual); |
| 1745 | } |
| 1746 | |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1747 | TEST_F(AidlTest, CheckNumGenericTypeSecifier) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1748 | const string expected_list_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1749 | "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: " |
| 1750 | "'List<String,String>'\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1751 | const string expected_map_stderr = |
| 1752 | "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n"; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1753 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1754 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1755 | "package p; interface IFoo {" |
| 1756 | "void foo(List<String, String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1757 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1758 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1759 | EXPECT_EQ(expected_list_stderr, GetCapturedStderr()); |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1760 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1761 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1762 | "package p; interface IFoo {" |
| 1763 | "void foo(Map<String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1764 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1765 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1766 | EXPECT_EQ(expected_map_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1767 | } |
| 1768 | |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1769 | TEST_F(AidlTest, CheckTypeParameterInMapType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1770 | const string expected_stderr = |
| 1771 | "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n"; |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1772 | Options options = Options::From("aidl -I p p/IFoo.aidl"); |
| 1773 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }"); |
| 1774 | |
| 1775 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1776 | "package p; interface IFoo {" |
| 1777 | "Map<String, Bar> foo();}"); |
| 1778 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1779 | |
| 1780 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1781 | "package p; interface IFoo {" |
| 1782 | "Map<Bar, Bar> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1783 | CaptureStderr(); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1784 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1785 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1786 | |
| 1787 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1788 | "package p; interface IFoo {" |
| 1789 | "Map<String, String> foo();}"); |
| 1790 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1791 | |
| 1792 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1793 | "package p; interface IFoo {" |
| 1794 | "Map<String, ParcelFileDescriptor> foo();}"); |
| 1795 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1796 | } |
| 1797 | |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1798 | TEST_F(AidlTest, WrongGenericType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1799 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n"; |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1800 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1801 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1802 | "package p; interface IFoo {" |
| 1803 | "String<String> foo(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1804 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1805 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1806 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1807 | } |
| 1808 | |
| 1809 | TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) { |
| 1810 | Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl"); |
| 1811 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1812 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1813 | EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1814 | EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n", |
| 1815 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1816 | |
| 1817 | Options options = Options::From("aidl -I p p/IFoo.aidl"); |
| 1818 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;"); |
| 1819 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1820 | "package p; interface IFoo {" |
| 1821 | "Bar<String, String> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1822 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1823 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1824 | EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1825 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1826 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1827 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1828 | EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n", |
| 1829 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1830 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;"); |
| 1831 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1832 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1833 | "package p; interface IFoo {" |
| 1834 | "Bar<String, ParcelFileDescriptor> foo();}"); |
| 1835 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jeongik Cha | e74c86d | 2019-12-12 16:54:03 +0900 | [diff] [blame] | 1836 | |
| 1837 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1838 | "package p; interface IFoo {" |
| 1839 | "Bar<int, long> foo();}"); |
| 1840 | |
| 1841 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1842 | "package p; interface IFoo {" |
| 1843 | "Bar<int[], long[]> foo();}"); |
| 1844 | |
| 1845 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1846 | } |
| 1847 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1848 | TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) { |
| 1849 | std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl", |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1850 | "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl", |
| 1851 | "aidl --lang=rust -o out foo/bar/Foo.aidl"}; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1852 | for (const auto& rawOption : rawOptions) { |
| 1853 | string expected_stderr = |
| 1854 | "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1855 | Options options = Options::From(rawOption); |
| 1856 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1857 | "package foo.bar;\n" |
| 1858 | "interface IFoo1 { int foo(); }\n" |
| 1859 | "interface IFoo2 { int foo(); }\n" |
| 1860 | "parcelable Data1 { int a; int b;}\n" |
| 1861 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1862 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1863 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1864 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1865 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1866 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1867 | "package foo.bar;\n" |
| 1868 | "interface IFoo1 { int foo(); }\n" |
| 1869 | "interface IFoo2 { int foo(); }\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1870 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1871 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1872 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1873 | |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1874 | expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1875 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1876 | "package foo.bar;\n" |
| 1877 | "parcelable Data1 { int a; int b;}\n" |
| 1878 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1879 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1880 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1881 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1882 | } |
| 1883 | } |
| 1884 | |
Devin Moore | bdba2a8 | 2020-03-31 15:19:02 -0700 | [diff] [blame] | 1885 | TEST_P(AidlTest, FailParseOnEmptyFile) { |
| 1886 | const string contents = ""; |
| 1887 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n"; |
| 1888 | CaptureStderr(); |
| 1889 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage())); |
| 1890 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1891 | } |
| 1892 | |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1893 | TEST_F(AidlTest, MultipleInputFiles) { |
| 1894 | Options options = Options::From( |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1895 | "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1896 | |
| 1897 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1898 | "package foo.bar;\n" |
| 1899 | "import foo.bar.Data;\n" |
| 1900 | "interface IFoo { Data getData(); }\n"); |
| 1901 | |
| 1902 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1903 | "package foo.bar;\n" |
| 1904 | "import foo.bar.IFoo;\n" |
| 1905 | "parcelable Data { IFoo foo; }\n"); |
| 1906 | |
| 1907 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1908 | |
| 1909 | string content; |
| 1910 | for (const auto file : { |
| 1911 | "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) { |
| 1912 | content.clear(); |
| 1913 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1914 | EXPECT_FALSE(content.empty()); |
| 1915 | } |
| 1916 | } |
| 1917 | |
| 1918 | TEST_F(AidlTest, MultipleInputFilesCpp) { |
| 1919 | Options options = Options::From("aidl --lang=cpp -o out -h out/include " |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1920 | "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1921 | |
| 1922 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1923 | "package foo.bar;\n" |
| 1924 | "import foo.bar.Data;\n" |
| 1925 | "interface IFoo { Data getData(); }\n"); |
| 1926 | |
| 1927 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1928 | "package foo.bar;\n" |
| 1929 | "import foo.bar.IFoo;\n" |
| 1930 | "parcelable Data { IFoo foo; }\n"); |
| 1931 | |
| 1932 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1933 | |
| 1934 | string content; |
| 1935 | for (const auto file : { |
Jiyong Park | b03551f | 2018-08-06 19:20:51 +0900 | [diff] [blame] | 1936 | "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp", |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1937 | "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h", |
| 1938 | "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h", |
| 1939 | "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) { |
| 1940 | content.clear(); |
| 1941 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1942 | EXPECT_FALSE(content.empty()); |
| 1943 | } |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1944 | } |
| 1945 | |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1946 | TEST_F(AidlTest, MultipleInputFilesRust) { |
| 1947 | Options options = |
| 1948 | Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
| 1949 | |
| 1950 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1951 | "package foo.bar;\n" |
| 1952 | "import foo.bar.Data;\n" |
| 1953 | "interface IFoo { Data getData(); }\n"); |
| 1954 | |
| 1955 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1956 | "package foo.bar;\n" |
| 1957 | "import foo.bar.IFoo;\n" |
| 1958 | "parcelable Data { IFoo foo; }\n"); |
| 1959 | |
| 1960 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1961 | |
| 1962 | string content; |
| 1963 | for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) { |
| 1964 | content.clear(); |
| 1965 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1966 | EXPECT_FALSE(content.empty()); |
| 1967 | } |
| 1968 | } |
| 1969 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1970 | TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) { |
| 1971 | const string expected_stderr = |
| 1972 | "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n"; |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1973 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
| 1974 | // int getInterfaceVersion() is one of the meta transactions |
| 1975 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1976 | "package p; interface IFoo {" |
| 1977 | "int getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1978 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1979 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1980 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1981 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1982 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1983 | TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) { |
| 1984 | // boolean getInterfaceVersion() is not a meta transaction, but should be |
| 1985 | // prevented because return type is not part of a method signature |
| 1986 | const string expected_stderr = |
| 1987 | "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n"; |
| 1988 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1989 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1990 | "package p; interface IFoo {" |
| 1991 | "boolean getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1992 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1993 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1994 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1995 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1996 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1997 | TEST_F(AidlTest, ConflictWithMetaTransactionGetName) { |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1998 | // this is another reserved name |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1999 | const string expected_stderr = |
| 2000 | "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n"; |
| 2001 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2002 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2003 | "package p; interface IFoo {" |
| 2004 | "String getTransactionName(int code); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2005 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2006 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2007 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2008 | |
| 2009 | // this is not a meta interface method as it differs type arguments |
| 2010 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2011 | "package p; interface IFoo {" |
| 2012 | "String getTransactionName(); }"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2013 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2014 | } |
| 2015 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2016 | TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) { |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 2017 | Options options = Options::From("aidl --checkapi old new"); |
| 2018 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2019 | "package p; interface IFoo{ @utf8InCpp @nullable String foo();}"); |
| 2020 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2021 | "package p; interface IFoo{ @nullable @utf8InCpp String foo();}"); |
| 2022 | |
| 2023 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2024 | } |
| 2025 | |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2026 | TEST_F(AidlTest, SuccessOnIdenticalApiDumps) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2027 | Options options = Options::From("aidl --checkapi old new"); |
| 2028 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
| 2029 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2030 | |
| 2031 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2032 | } |
| 2033 | |
Jooyung Han | fdaae1d | 2020-12-14 13:16:15 +0900 | [diff] [blame] | 2034 | TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) { |
| 2035 | Options options = Options::From("aidl --checkapi old new"); |
| 2036 | const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }"; |
| 2037 | const string enum_definition = "package p; enum Enum { FOO }"; |
| 2038 | io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition); |
| 2039 | io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition); |
| 2040 | io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition); |
| 2041 | io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition); |
| 2042 | |
| 2043 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2044 | } |
| 2045 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2046 | class AidlTestCompatibleChanges : public AidlTest { |
| 2047 | protected: |
| 2048 | Options options_ = Options::From("aidl --checkapi old new"); |
| 2049 | }; |
| 2050 | |
| 2051 | TEST_F(AidlTestCompatibleChanges, NewType) { |
| 2052 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2053 | "package p;" |
| 2054 | "interface IFoo {" |
| 2055 | " void foo(int a);" |
| 2056 | "}"); |
| 2057 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2058 | "package p;" |
| 2059 | "interface IFoo {" |
| 2060 | " void foo(int a);" |
| 2061 | "}"); |
| 2062 | io_delegate_.SetFileContents("new/p/IBar.aidl", |
| 2063 | "package p;" |
| 2064 | "interface IBar {" |
| 2065 | " void bar();" |
| 2066 | "}"); |
| 2067 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2068 | } |
| 2069 | |
| 2070 | TEST_F(AidlTestCompatibleChanges, NewMethod) { |
| 2071 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2072 | "package p;" |
| 2073 | "interface IFoo {" |
| 2074 | " void foo(int a);" |
| 2075 | "}"); |
| 2076 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2077 | "package p;" |
| 2078 | "interface IFoo {" |
| 2079 | " void foo(int a);" |
| 2080 | " void bar();" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2081 | " void baz(in List<IFoo> arg);" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2082 | "}"); |
| 2083 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2084 | } |
| 2085 | |
| 2086 | TEST_F(AidlTestCompatibleChanges, NewField) { |
| 2087 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2088 | "package p;" |
| 2089 | "parcelable Data {" |
| 2090 | " int foo;" |
| 2091 | "}"); |
| 2092 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2093 | "package p;" |
| 2094 | "parcelable Data {" |
| 2095 | " int foo;" |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2096 | " int bar = 0;" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2097 | " @nullable List<Data> list;" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2098 | "}"); |
| 2099 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2100 | } |
| 2101 | |
| 2102 | TEST_F(AidlTestCompatibleChanges, NewEnumerator) { |
| 2103 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2104 | "package p;" |
| 2105 | "enum Enum {" |
| 2106 | " FOO = 1," |
| 2107 | "}"); |
| 2108 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2109 | "package p;" |
| 2110 | "enum Enum {" |
| 2111 | " FOO = 1," |
| 2112 | " BAR = 2," |
| 2113 | "}"); |
| 2114 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2115 | } |
| 2116 | |
| 2117 | TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) { |
| 2118 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2119 | "package p;" |
| 2120 | "enum Enum {" |
| 2121 | " FOO = 1," |
| 2122 | " BAR = 2," |
| 2123 | "}"); |
| 2124 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2125 | "package p;" |
| 2126 | "enum Enum {" |
| 2127 | " BAR = 2," |
| 2128 | " FOO = 1," |
| 2129 | "}"); |
| 2130 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2131 | } |
| 2132 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2133 | TEST_F(AidlTestCompatibleChanges, NewUnionField) { |
| 2134 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2135 | "package p;" |
| 2136 | "union Union {" |
| 2137 | " String foo;" |
| 2138 | "}"); |
| 2139 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2140 | "package p;" |
| 2141 | "union Union {" |
| 2142 | " String foo;" |
| 2143 | " int num;" |
| 2144 | "}"); |
| 2145 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2146 | } |
| 2147 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2148 | TEST_F(AidlTestCompatibleChanges, NewPackage) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2149 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2150 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2151 | "interface IFoo {" |
| 2152 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2153 | "}"); |
| 2154 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2155 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2156 | "parcelable Data {" |
| 2157 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2158 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2159 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2160 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2161 | "interface IFoo {" |
| 2162 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2163 | "}"); |
| 2164 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2165 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2166 | "parcelable Data {" |
| 2167 | " int foo;" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2168 | "}"); |
| 2169 | io_delegate_.SetFileContents("new/q/IFoo.aidl", |
| 2170 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2171 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2172 | " void foo(int a);" |
| 2173 | "}"); |
| 2174 | io_delegate_.SetFileContents("new/q/Data.aidl", |
| 2175 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2176 | "parcelable Data {" |
| 2177 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2178 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2179 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2180 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2181 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2182 | TEST_F(AidlTestCompatibleChanges, ArgNameChange) { |
| 2183 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2184 | "package p;" |
| 2185 | "interface IFoo {" |
| 2186 | " void foo(int a);" |
| 2187 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2188 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2189 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2190 | "interface IFoo {" |
| 2191 | " void foo(int b);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2192 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2193 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2194 | } |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2195 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2196 | TEST_F(AidlTestCompatibleChanges, AddedConstValue) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2197 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2198 | "package p; interface I {" |
| 2199 | "const int A = 1; }"); |
| 2200 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 2201 | "package p ; interface I {" |
| 2202 | "const int A = 1; const int B = 2;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2203 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2204 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2205 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2206 | TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2207 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2208 | "package p; interface I {" |
| 2209 | "const int A = 1; const int B = 2;}"); |
| 2210 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 2211 | "package p ; interface I {" |
| 2212 | "const int B = 2; const int A = 1;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2213 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2214 | } |
| 2215 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2216 | TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) { |
| 2217 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2218 | "package p;" |
| 2219 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2220 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2221 | "parcelable Foo {}"); |
| 2222 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2223 | "package p;" |
| 2224 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2225 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2226 | "parcelable Foo {}"); |
| 2227 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2228 | } |
| 2229 | |
Jooyung Han | 0007327 | 2020-11-27 14:20:20 +0900 | [diff] [blame] | 2230 | TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) { |
| 2231 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2232 | "package p;" |
| 2233 | "parcelable Foo {}"); |
| 2234 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2235 | "package p;" |
| 2236 | "@JavaPassthrough(annotation=\"@Deprecated\")" |
| 2237 | "parcelable Foo {}"); |
| 2238 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2239 | } |
| 2240 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2241 | TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) { |
| 2242 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2243 | "package p;" |
| 2244 | "parcelable Data {" |
| 2245 | " int num;" |
| 2246 | "}"); |
| 2247 | io_delegate_.SetFileContents( |
| 2248 | "new/p/Data.aidl", |
| 2249 | "package p;" |
| 2250 | "parcelable Data {" |
| 2251 | " int num;" |
| 2252 | " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type |
| 2253 | "}"); |
| 2254 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2255 | "package p;" |
| 2256 | "enum Enum {" |
| 2257 | " FOO = 0," |
| 2258 | " BAR = 1," |
| 2259 | "}"); |
| 2260 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2261 | } |
| 2262 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2263 | class AidlTestIncompatibleChanges : public AidlTest { |
| 2264 | protected: |
| 2265 | Options options_ = Options::From("aidl --checkapi old new"); |
| 2266 | }; |
| 2267 | |
| 2268 | TEST_F(AidlTestIncompatibleChanges, RemovedType) { |
Jiyong Park | 0cf03b1 | 2020-07-22 19:36:34 +0900 | [diff] [blame] | 2269 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2270 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2271 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2272 | "interface IFoo {" |
| 2273 | " void foo(in String[] str);" |
| 2274 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2275 | "}"); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2276 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2277 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2278 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2279 | } |
| 2280 | |
| 2281 | TEST_F(AidlTestIncompatibleChanges, RemovedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2282 | const string expected_stderr = |
| 2283 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2284 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2285 | "package p;" |
| 2286 | "interface IFoo {" |
| 2287 | " void foo(in String[] str);" |
| 2288 | " void bar(@utf8InCpp String str);" |
| 2289 | "}"); |
| 2290 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2291 | "package p;" |
| 2292 | "interface IFoo {" |
| 2293 | " void foo(in String[] str);" |
| 2294 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2295 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2296 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2297 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2298 | } |
| 2299 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2300 | TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) { |
| 2301 | const string expected_stderr = |
| 2302 | "ERROR: new/p/IFoo.aidl:1.61-65: " |
| 2303 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2304 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2305 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2306 | "ERROR: new/p/IFoo.aidl: Failed to read.\n"; |
| 2307 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2308 | "package p;" |
| 2309 | "interface IFoo {" |
| 2310 | " void foo(in String[] str);" |
| 2311 | "}"); |
| 2312 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2313 | "package p;" |
| 2314 | "interface IFoo {" |
| 2315 | " void foo(in String[] str);" |
| 2316 | " void bar(in List arg);" |
| 2317 | "}"); |
| 2318 | CaptureStderr(); |
| 2319 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2320 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2321 | } |
| 2322 | |
| 2323 | TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) { |
| 2324 | const string expected_stderr = |
| 2325 | "ERROR: new/p/Data.aidl:1.54-59: " |
| 2326 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2327 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2328 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2329 | "ERROR: new/p/Data.aidl: Failed to read.\n"; |
| 2330 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2331 | "package p;" |
| 2332 | "parcelable Data {" |
| 2333 | " int foo;" |
| 2334 | "}"); |
| 2335 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2336 | "package p;" |
| 2337 | "parcelable Data {" |
| 2338 | " int foo;" |
| 2339 | " @nullable List list;" |
| 2340 | "}"); |
| 2341 | CaptureStderr(); |
| 2342 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2343 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2344 | } |
| 2345 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2346 | TEST_F(AidlTestIncompatibleChanges, RemovedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2347 | const string expected_stderr = |
| 2348 | "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2349 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2350 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2351 | "parcelable Data {" |
| 2352 | " int foo;" |
| 2353 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2354 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2355 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2356 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2357 | "parcelable Data {" |
| 2358 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2359 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2360 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2361 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2362 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2363 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2364 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2365 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) { |
| 2366 | const string expected_stderr = |
| 2367 | "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some " |
| 2368 | "backends. Please either provide a default value for this field or mark the field as " |
| 2369 | "@nullable. This value or a null value will be used automatically when an old version of " |
| 2370 | "this parcelable is sent to a process which understands a new version of this parcelable. In " |
| 2371 | "order to make sure your code continues to be backwards compatible, make sure the default or " |
| 2372 | "null value does not cause a semantic change to this parcelable.\n"; |
| 2373 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2374 | "package p;" |
| 2375 | "parcelable Data {" |
| 2376 | " int num;" |
| 2377 | "}"); |
| 2378 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2379 | "package p;" |
| 2380 | "parcelable Data {" |
| 2381 | " int num;" |
| 2382 | " String str;" |
| 2383 | "}"); |
| 2384 | CaptureStderr(); |
| 2385 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2386 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2387 | } |
| 2388 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2389 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) { |
| 2390 | const string expected_stderr = |
| 2391 | "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. " |
| 2392 | "Please make sure 'Enum' has '0' as a valid value.\n"; |
| 2393 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2394 | "package p;" |
| 2395 | "parcelable Data {" |
| 2396 | " int num;" |
| 2397 | "}"); |
| 2398 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2399 | "package p;" |
| 2400 | "parcelable Data {" |
| 2401 | " int num;" |
| 2402 | " p.Enum e;" |
| 2403 | "}"); |
| 2404 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2405 | "package p;" |
| 2406 | "enum Enum {" |
| 2407 | " FOO = 1," |
| 2408 | " BAR = 2," |
| 2409 | "}"); |
| 2410 | CaptureStderr(); |
| 2411 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2412 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2413 | } |
| 2414 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2415 | TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2416 | const string expected_stderr = |
| 2417 | "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2418 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2419 | "package p;" |
| 2420 | "enum Enum {" |
| 2421 | " FOO = 1," |
| 2422 | " BAR = 2," |
| 2423 | "}"); |
| 2424 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2425 | "package p;" |
| 2426 | "enum Enum {" |
| 2427 | " BAR = 2," |
| 2428 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2429 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2430 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2431 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2432 | } |
| 2433 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2434 | TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) { |
| 2435 | const string expected_stderr = |
| 2436 | "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n"; |
| 2437 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2438 | "package p;" |
| 2439 | "union Union {" |
| 2440 | " String str;" |
| 2441 | " int num;" |
| 2442 | "}"); |
| 2443 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2444 | "package p;" |
| 2445 | "union Union {" |
| 2446 | " String str;" |
| 2447 | "}"); |
| 2448 | CaptureStderr(); |
| 2449 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2450 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2451 | } |
| 2452 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2453 | TEST_F(AidlTestIncompatibleChanges, RenamedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2454 | const string expected_stderr = |
| 2455 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2456 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2457 | "package p;" |
| 2458 | "interface IFoo {" |
| 2459 | " void foo(in String[] str);" |
| 2460 | " void bar(@utf8InCpp String str);" |
| 2461 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2462 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2463 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2464 | "interface IFoo {" |
| 2465 | " void foo(in String[] str);" |
| 2466 | " void bar2(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2467 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2468 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2469 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2470 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2471 | } |
| 2472 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2473 | TEST_F(AidlTestIncompatibleChanges, RenamedType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2474 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2475 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2476 | "package p;" |
| 2477 | "interface IFoo {" |
| 2478 | " void foo(in String[] str);" |
| 2479 | " void bar(@utf8InCpp String str);" |
| 2480 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2481 | io_delegate_.SetFileContents("new/p/IFoo2.aidl", |
| 2482 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2483 | "interface IFoo2 {" |
| 2484 | " void foo(in String[] str);" |
| 2485 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2486 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2487 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2488 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2489 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2490 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2491 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2492 | TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2493 | const string expected_stderr = |
| 2494 | "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2495 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2496 | "package p;" |
| 2497 | "enum Enum {" |
| 2498 | " FOO = 1," |
| 2499 | " BAR = 2," |
| 2500 | "}"); |
| 2501 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2502 | "package p;" |
| 2503 | "enum Enum {" |
| 2504 | " FOO = 3," |
| 2505 | " BAR = 2," |
| 2506 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2507 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2508 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2509 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2510 | } |
| 2511 | |
| 2512 | TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2513 | const string expected_stderr = |
| 2514 | "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed " |
| 2515 | "from 0 to 1.\n" |
| 2516 | "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from " |
| 2517 | "1 to 0.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2518 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2519 | "package p;" |
| 2520 | "interface IFoo {" |
| 2521 | " void foo(in String[] str);" |
| 2522 | " void bar(@utf8InCpp String str);" |
| 2523 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2524 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2525 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2526 | "interface IFoo {" |
| 2527 | " void bar(@utf8InCpp String str);" |
| 2528 | " void foo(in String[] str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2529 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2530 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2531 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2532 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2533 | } |
| 2534 | |
| 2535 | TEST_F(AidlTestIncompatibleChanges, ReorderedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2536 | const string expected_stderr = |
Jiyong Park | b07d993 | 2020-05-15 12:56:54 +0900 | [diff] [blame] | 2537 | "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n" |
| 2538 | "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2539 | io_delegate_.SetFileContents("old/p/Data.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2540 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2541 | "parcelable Data {" |
| 2542 | " int foo;" |
| 2543 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2544 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2545 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2546 | "package p;" |
| 2547 | "parcelable Data {" |
| 2548 | " int bar;" |
| 2549 | " int foo;" |
| 2550 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2551 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2552 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2553 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2554 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2555 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2556 | TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) { |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2557 | const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2558 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2559 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2560 | "interface IFoo {" |
| 2561 | " void foo(in String[] str);" |
| 2562 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2563 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2564 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2565 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2566 | "interface IFoo {" |
| 2567 | " void foo(out String[] str);" |
| 2568 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2569 | "}"); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2570 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2571 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2572 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2573 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2574 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2575 | TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2576 | const string expected_stderr = |
| 2577 | "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2578 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2579 | "package p;" |
| 2580 | "interface IFoo {" |
| 2581 | " void foo(in String[] str);" |
| 2582 | " void bar(@utf8InCpp String str);" |
| 2583 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2584 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2585 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2586 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2587 | " void foo(in @utf8InCpp String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2588 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2589 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2590 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2591 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2592 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2593 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2594 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2595 | TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2596 | const string expected_stderr = |
| 2597 | "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2598 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2599 | "package p;" |
| 2600 | "interface IFoo {" |
| 2601 | " void foo(in String[] str);" |
| 2602 | " void bar(@utf8InCpp String str);" |
| 2603 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2604 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2605 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2606 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2607 | " void foo(in String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2608 | " void bar(String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2609 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2610 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2611 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2612 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2613 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2614 | |
Jooyung Han | 60b2fde | 2020-10-29 15:12:40 +0900 | [diff] [blame] | 2615 | TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) { |
| 2616 | const string expected_stderr = |
| 2617 | "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n" |
| 2618 | "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n"; |
| 2619 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2620 | "package p;" |
| 2621 | "@Backing(type=\"byte\")" |
| 2622 | "enum Foo {" |
| 2623 | " FOO, BAR," |
| 2624 | "}"); |
| 2625 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2626 | "package p;" |
| 2627 | "@Backing(type=\"long\")" |
| 2628 | "enum Foo {" |
| 2629 | " FOO, BAR," |
| 2630 | "}"); |
| 2631 | CaptureStderr(); |
| 2632 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2633 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2634 | } |
| 2635 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2636 | TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) { |
| 2637 | const string expected_stderr = |
| 2638 | "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") " |
| 2639 | "to @JavaPassthrough(annotation=\"Bob\")\n"; |
| 2640 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2641 | "package p;" |
| 2642 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2643 | "parcelable Foo {}"); |
| 2644 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2645 | "package p;" |
| 2646 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2647 | "parcelable Foo {}"); |
| 2648 | |
| 2649 | CaptureStderr(); |
| 2650 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2651 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2652 | } |
| 2653 | |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2654 | TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) { |
| 2655 | const string expected_stderr = |
| 2656 | "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n"; |
| 2657 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2658 | "package p;" |
| 2659 | "parcelable Foo {" |
| 2660 | " int A;" |
| 2661 | "}"); |
| 2662 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2663 | "package p;" |
| 2664 | "@JavaOnlyStableParcelable parcelable Foo {" |
| 2665 | " int A;" |
| 2666 | "}"); |
| 2667 | CaptureStderr(); |
| 2668 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2669 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2670 | } |
| 2671 | |
| 2672 | TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) { |
| 2673 | const string expected_stderr = |
| 2674 | "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n"; |
| 2675 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2676 | "package p;" |
| 2677 | "@JavaOnlyStableParcelable parcelable Foo {" |
| 2678 | " int A;" |
| 2679 | "}"); |
| 2680 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2681 | "package p;" |
| 2682 | "parcelable Foo {" |
| 2683 | " int A;" |
| 2684 | "}"); |
| 2685 | CaptureStderr(); |
| 2686 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2687 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2688 | } |
| 2689 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2690 | TEST_F(AidlTestIncompatibleChanges, RemovedPackage) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2691 | const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2692 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}"); |
| 2693 | io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2694 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2695 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2696 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2697 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2698 | } |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 2699 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2700 | TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) { |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2701 | const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2702 | io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }"); |
| 2703 | io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2704 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2705 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2706 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2707 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2708 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2709 | TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2710 | const string expected_stderr = |
| 2711 | "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2712 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2713 | "package p; interface I {" |
| 2714 | "const int A = 1; const int B = 2;}"); |
| 2715 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2716 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2717 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2718 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2719 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2720 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2721 | TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2722 | const string expected_stderr = |
| 2723 | "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2724 | io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }"); |
| 2725 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2726 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2727 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2728 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3c35e39 | 2018-08-30 13:10:30 +0900 | [diff] [blame] | 2729 | } |
| 2730 | |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2731 | TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) { |
| 2732 | const string expected_stderr = |
| 2733 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. " |
| 2734 | "This is an incompatible change for FixedSize types.\n"; |
| 2735 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2736 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 2737 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2738 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }"); |
| 2739 | CaptureStderr(); |
| 2740 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2741 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2742 | } |
| 2743 | |
| 2744 | TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) { |
| 2745 | const string expected_stderr = |
| 2746 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n"; |
| 2747 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2748 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }"); |
| 2749 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2750 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 2751 | CaptureStderr(); |
| 2752 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2753 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2754 | } |
| 2755 | |
| 2756 | TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) { |
| 2757 | const string expected_stderr = |
| 2758 | "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2759 | "a.\n" |
| 2760 | "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2761 | "b.\n" |
| 2762 | "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2763 | "c.\n" |
| 2764 | "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2765 | "d.\n" |
| 2766 | "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2767 | "e.\n" |
| 2768 | "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2769 | "f.\n"; |
| 2770 | |
| 2771 | io_delegate_.SetFileContents("Foo.aidl", |
| 2772 | "@FixedSize parcelable Foo { " |
| 2773 | " int[] a;" |
| 2774 | " Bar b;" |
| 2775 | " String c;" |
| 2776 | " ParcelFileDescriptor d;" |
| 2777 | " IBinder e;" |
| 2778 | " List<String> f;" |
Steven Moreland | 265f3d4 | 2020-09-24 19:06:54 +0000 | [diff] [blame] | 2779 | " int isFixedSize;" |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2780 | "}"); |
| 2781 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 2782 | Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage())); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2783 | |
| 2784 | CaptureStderr(); |
| 2785 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2786 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2787 | } |
| 2788 | |
| 2789 | TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) { |
| 2790 | const string expected_stderr = ""; |
| 2791 | |
| 2792 | io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }"); |
| 2793 | io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }"); |
| 2794 | io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 2795 | Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage())); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2796 | |
| 2797 | CaptureStderr(); |
| 2798 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2799 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2800 | } |
| 2801 | |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2802 | TEST_F(AidlTest, RejectAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2803 | const string expected_stderr = |
| 2804 | "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n" |
| 2805 | "dir1/q/IBar.aidl\n" |
| 2806 | "dir2/q/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2807 | "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n"; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2808 | Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl"); |
| 2809 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}"); |
| 2810 | io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}"); |
| 2811 | io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}"); |
| 2812 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2813 | CaptureStderr(); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2814 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2815 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2816 | } |
| 2817 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2818 | TEST_F(AidlTest, HandleManualIdAssignments) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2819 | const string expected_stderr = |
| 2820 | "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to " |
| 2821 | "11.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2822 | Options options = Options::From("aidl --checkapi old new"); |
| 2823 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
| 2824 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2825 | |
| 2826 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2827 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2828 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2829 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2830 | EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2831 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2832 | } |
| 2833 | |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2834 | TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) { |
| 2835 | Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl"); |
| 2836 | Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2837 | Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl"); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2838 | |
| 2839 | // use without import |
| 2840 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2841 | "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}"); |
| 2842 | EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_)); |
| 2843 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2844 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_)); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2845 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2846 | // use without import but with full name |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2847 | io_delegate_.SetFileContents( |
| 2848 | "p/IFoo.aidl", |
| 2849 | "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}"); |
| 2850 | EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_)); |
| 2851 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2852 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_)); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2853 | |
| 2854 | // use with import (as before) |
| 2855 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2856 | "package p;" |
| 2857 | "import android.os.ParcelFileDescriptor;" |
| 2858 | "interface IFoo{" |
| 2859 | " void foo(in ParcelFileDescriptor fd);" |
| 2860 | "}"); |
| 2861 | EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_)); |
| 2862 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2863 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_)); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2864 | } |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2865 | |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2866 | TEST_F(AidlTest, ManualIds) { |
| 2867 | Options options = Options::From("aidl --lang=java -o out IFoo.aidl"); |
| 2868 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2869 | "interface IFoo {\n" |
| 2870 | " void foo() = 0;\n" |
| 2871 | " void bar() = 1;\n" |
| 2872 | "}"); |
| 2873 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2874 | } |
| 2875 | |
| 2876 | TEST_F(AidlTest, ManualIdsWithMetaTransactions) { |
| 2877 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2878 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2879 | "interface IFoo {\n" |
| 2880 | " void foo() = 0;\n" |
| 2881 | " void bar() = 1;\n" |
| 2882 | "}"); |
| 2883 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2884 | } |
| 2885 | |
| 2886 | TEST_F(AidlTest, FailOnDuplicatedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2887 | const string expected_stderr = |
| 2888 | "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2889 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2890 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2891 | "interface IFoo {\n" |
| 2892 | " void foo() = 3;\n" |
| 2893 | " void bar() = 3;\n" |
| 2894 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2895 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2896 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2897 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2898 | } |
| 2899 | |
| 2900 | TEST_F(AidlTest, FailOnOutOfRangeIds) { |
| 2901 | // 16777115 is kLastMetaMethodId + 1 |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2902 | const string expected_stderr = |
| 2903 | "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. " |
| 2904 | "Value for id must be between 0 and 16777114 inclusive.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2905 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2906 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2907 | "interface IFoo {\n" |
| 2908 | " void foo() = 3;\n" |
| 2909 | " void bar() = 16777115;\n" |
| 2910 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2911 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2912 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2913 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2914 | } |
| 2915 | |
| 2916 | TEST_F(AidlTest, FailOnPartiallyAssignedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2917 | const string expected_stderr = |
| 2918 | "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2919 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2920 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2921 | "interface IFoo {\n" |
| 2922 | " void foo() = 3;\n" |
| 2923 | " void bar();\n" |
| 2924 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2925 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2926 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2927 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2928 | } |
| 2929 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2930 | TEST_F(AidlTest, AllowDuplicatedImportPaths) { |
| 2931 | Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl"); |
| 2932 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 2933 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
| 2934 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2935 | } |
| 2936 | |
| 2937 | TEST_F(AidlTest, FailOnAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2938 | const string expected_stderr = |
| 2939 | "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n" |
| 2940 | "dir/IBar.aidl\n" |
| 2941 | "dir2/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2942 | "ERROR: IFoo.aidl: Couldn't find import for class IBar\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2943 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2944 | Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl"); |
| 2945 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 2946 | io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}"); |
| 2947 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2948 | CaptureStderr(); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2949 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2950 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2951 | } |
| 2952 | |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 2953 | TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) { |
| 2954 | io_delegate_.SetFileContents("a/b/IFoo.aidl", |
| 2955 | "package a.b;\n" |
| 2956 | "import a.b.IBar;\n" |
| 2957 | "import a.b.IQux;\n" |
| 2958 | "interface IFoo { IQux foo(); }\n"); |
| 2959 | io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }"); |
| 2960 | io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }"); |
| 2961 | |
| 2962 | Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include"); |
| 2963 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2964 | |
| 2965 | string output; |
| 2966 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output)); |
| 2967 | // IBar was imported but wasn't used. include is not expected. |
| 2968 | EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>"))); |
| 2969 | // IBar was imported and used. include is expected. |
| 2970 | EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>"))); |
| 2971 | } |
| 2972 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2973 | TEST_F(AidlTest, ParseJavaPassthroughAnnotation) { |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2974 | io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a; |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2975 | import a.MyEnum; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2976 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 2977 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2978 | interface IFoo { |
| 2979 | @JavaPassthrough(annotation="@com.android.Bob") |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2980 | void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y); |
Jiyong Park | 7c3b0e4 | 2020-08-04 16:08:32 +0900 | [diff] [blame] | 2981 | const @JavaPassthrough(annotation="@com.android.David") int A = 3; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2982 | })--"); |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2983 | // JavaPassthrough should work with other types as well (e.g. enum) |
| 2984 | io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a; |
| 2985 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 2986 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
| 2987 | @Backing(type="byte") |
| 2988 | enum MyEnum { |
| 2989 | a, b, c |
| 2990 | })--"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2991 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2992 | Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2993 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 2994 | |
| 2995 | string java_out; |
| 2996 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out)); |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2997 | // type-decl-level annotations with newline at the end |
| 2998 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 2999 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 3000 | // member-decl-level annotations with newline at the end |
| 3001 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n")); |
| 3002 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n")); |
| 3003 | // inline annotations with space at the end |
| 3004 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat ")); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3005 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3006 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out)); |
| 3007 | // type-decl-level annotations with newline at the end |
| 3008 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 3009 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 3010 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3011 | // Other backends shouldn't be bothered |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3012 | Options cpp_options = |
| 3013 | Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3014 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 3015 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3016 | Options ndk_options = |
| 3017 | Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3018 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 3019 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3020 | Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 3021 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3022 | } |
| 3023 | |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 3024 | TEST_F(AidlTest, ParseRustDerive) { |
| 3025 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 3026 | @RustDerive(Clone=true, Copy=false) |
| 3027 | parcelable Foo { |
| 3028 | int a; |
| 3029 | })"); |
| 3030 | |
| 3031 | Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl"); |
| 3032 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
| 3033 | |
| 3034 | string rust_out; |
| 3035 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out)); |
| 3036 | EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]")); |
| 3037 | |
| 3038 | // Other backends shouldn't be bothered |
| 3039 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
| 3040 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 3041 | |
| 3042 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
| 3043 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
| 3044 | |
| 3045 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 3046 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 3047 | } |
| 3048 | |
Jiyong Park | 56f73d7 | 2019-06-11 12:20:28 +0900 | [diff] [blame] | 3049 | class AidlOutputPathTest : public AidlTest { |
| 3050 | protected: |
| 3051 | void SetUp() override { |
| 3052 | AidlTest::SetUp(); |
| 3053 | io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}"); |
| 3054 | } |
| 3055 | |
| 3056 | void Test(const Options& options, const std::string expected_output_path) { |
| 3057 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3058 | // check the existence |
| 3059 | EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr)); |
| 3060 | } |
| 3061 | }; |
| 3062 | |
| 3063 | TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) { |
| 3064 | // <out_dir> / <package_name> / <type_name>.java |
| 3065 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java"); |
| 3066 | } |
| 3067 | |
| 3068 | TEST_F(AidlOutputPathTest, OutDirWithOutputFile) { |
| 3069 | // when output file is explicitly set, it is always respected. -o option is |
| 3070 | // ignored. |
| 3071 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 3072 | } |
| 3073 | |
| 3074 | TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) { |
| 3075 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 3076 | } |
| 3077 | |
| 3078 | TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) { |
| 3079 | // output is the same as the input file except for the suffix |
| 3080 | Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java"); |
| 3081 | } |
| 3082 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3083 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3084 | AidlError error; |
| 3085 | const string expected_stderr = |
| 3086 | "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n"; |
| 3087 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3088 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3089 | R"(package p; |
| 3090 | interface IFoo { |
| 3091 | const int int32_max_oob = 2147483650; |
| 3092 | } |
| 3093 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3094 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3095 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3096 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3097 | } |
| 3098 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3099 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3100 | AidlError error; |
| 3101 | const string expected_stderr = |
| 3102 | "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n"; |
| 3103 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3104 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3105 | R"(package p; |
| 3106 | interface IFoo { |
| 3107 | const int int32_min_oob = -2147483650; |
| 3108 | } |
| 3109 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3110 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3111 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3112 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3113 | } |
| 3114 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3115 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3116 | AidlError error; |
| 3117 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 3118 | "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3119 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3120 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3121 | R"(package p; |
| 3122 | interface IFoo { |
| 3123 | const long int64_max_oob = 21474836509999999999999999; |
| 3124 | } |
| 3125 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3126 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3127 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3128 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3129 | } |
| 3130 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3131 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3132 | AidlError error; |
| 3133 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 3134 | "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3135 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3136 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3137 | R"(package p; |
| 3138 | interface IFoo { |
| 3139 | const long int64_min_oob = -21474836509999999999999999; |
| 3140 | } |
| 3141 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3142 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3143 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3144 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3145 | } |
| 3146 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3147 | TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3148 | AidlError error; |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3149 | const string expected_stderr = |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 3150 | "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n" |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3151 | "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n"; |
| 3152 | CaptureStderr(); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 3153 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 3154 | R"(package p; |
| 3155 | @Backing(type="byte") |
| 3156 | enum TestEnum { |
| 3157 | FOO = 127, |
| 3158 | BAR, |
| 3159 | } |
| 3160 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3161 | typenames_, GetLanguage(), &error)); |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3162 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3163 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 3164 | } |
| 3165 | |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 3166 | TEST_P(AidlTest, UnsupportedBackingAnnotationParam) { |
| 3167 | AidlError error; |
| 3168 | const string expected_stderr = |
| 3169 | "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must " |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 3170 | "be one of: type\n"; |
| 3171 | CaptureStderr(); |
| 3172 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 3173 | R"(package p; |
| 3174 | @Backing(foo="byte") |
| 3175 | enum TestEnum { |
| 3176 | FOO = 1, |
| 3177 | BAR, |
| 3178 | } |
| 3179 | )", |
| 3180 | typenames_, GetLanguage(), &error)); |
| 3181 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3182 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 3183 | } |
| 3184 | |
Jooyung Han | 5721a23 | 2020-12-24 04:34:55 +0900 | [diff] [blame] | 3185 | TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) { |
| 3186 | const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n"; |
| 3187 | CaptureStderr(); |
| 3188 | EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage())); |
| 3189 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3190 | } |
| 3191 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3192 | TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3193 | io_delegate_.SetFileContents("Foo.aidl", |
| 3194 | "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; " |
| 3195 | "Map<String, Baz> d; Bar[] e; }"); |
| 3196 | io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }"); |
| 3197 | io_delegate_.SetFileContents("Baz.aidl", |
| 3198 | "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3199 | Options options = Options::From("aidl --lang=java -I . Foo.aidl"); |
| 3200 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3201 | } |
| 3202 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3203 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3204 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3205 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3206 | string expected_error = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3207 | "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
| 3208 | "named 'bar'.\n"; |
| 3209 | CaptureStderr(); |
| 3210 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
| 3211 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3212 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
| 3213 | } |
| 3214 | |
| 3215 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) { |
| 3216 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }"); |
| 3217 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
| 3218 | string expected_error = |
| 3219 | "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3220 | "named 'bar'.\n"; |
| 3221 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3222 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
| 3223 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3224 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3225 | } |
| 3226 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3227 | TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3228 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3229 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }"); |
| 3230 | string expected_error = |
| 3231 | "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can " |
| 3232 | "only be an in parameter.\n"; |
| 3233 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3234 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
| 3235 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3236 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3237 | } |
| 3238 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3239 | TEST_F(AidlTest, ImmutableParcelableCannotBeOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3240 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3241 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }"); |
| 3242 | string expected_error = |
| 3243 | "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can " |
| 3244 | "only be an in parameter.\n"; |
| 3245 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3246 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
| 3247 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3248 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3249 | } |
| 3250 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3251 | TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3252 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }"); |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3253 | Options options = Options::From("aidl --lang=java Foo.aidl"); |
| 3254 | const string expected_stderr = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3255 | "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first " |
| 3256 | "letter\n"; |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3257 | CaptureStderr(); |
| 3258 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3259 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3260 | } |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3261 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3262 | const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once |
| 3263 | |
| 3264 | #include <a/ByteEnum.h> |
| 3265 | #include <binder/Parcel.h> |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3266 | #include <binder/ParcelFileDescriptor.h> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3267 | #include <binder/Status.h> |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3268 | #include <cassert> |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3269 | #include <codecvt> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3270 | #include <cstdint> |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3271 | #include <locale> |
| 3272 | #include <sstream> |
Jooyung Han | 3df81ae | 2020-10-17 17:59:59 +0900 | [diff] [blame] | 3273 | #include <type_traits> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3274 | #include <utility> |
| 3275 | #include <variant> |
| 3276 | #include <vector> |
| 3277 | |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3278 | #ifndef __BIONIC__ |
| 3279 | #define __assert2(a,b,c,d) ((void)0) |
| 3280 | #endif |
| 3281 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3282 | namespace a { |
| 3283 | |
| 3284 | class Foo : public ::android::Parcelable { |
| 3285 | public: |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3286 | inline bool operator!=(const Foo& rhs) const { |
| 3287 | return _value != rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3288 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3289 | inline bool operator<(const Foo& rhs) const { |
| 3290 | return _value < rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3291 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3292 | inline bool operator<=(const Foo& rhs) const { |
| 3293 | return _value <= rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3294 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3295 | inline bool operator==(const Foo& rhs) const { |
| 3296 | return _value == rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3297 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3298 | inline bool operator>(const Foo& rhs) const { |
| 3299 | return _value > rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3300 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3301 | inline bool operator>=(const Foo& rhs) const { |
| 3302 | return _value >= rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3303 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3304 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3305 | enum Tag : int32_t { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3306 | ns = 0, // int[] ns; |
| 3307 | e, // a.ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3308 | pfd, // ParcelFileDescriptor pfd; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3309 | }; |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3310 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3311 | template<typename _Tp> |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3312 | static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3313 | |
| 3314 | Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3315 | Foo(const Foo&) = default; |
| 3316 | Foo(Foo&&) = default; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3317 | Foo& operator=(const Foo&) = default; |
| 3318 | Foo& operator=(Foo&&) = default; |
| 3319 | |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3320 | template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>> |
| 3321 | // NOLINTNEXTLINE(google-explicit-constructor) |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3322 | constexpr Foo(_Tp&& _arg) |
| 3323 | : _value(std::forward<_Tp>(_arg)) {} |
| 3324 | |
| 3325 | template <typename... _Tp> |
| 3326 | constexpr explicit Foo(_Tp&&... _args) |
| 3327 | : _value(std::forward<_Tp>(_args)...) {} |
| 3328 | |
| 3329 | template <Tag _tag, typename... _Tp> |
| 3330 | static Foo make(_Tp&&... _args) { |
| 3331 | return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3332 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3333 | |
| 3334 | template <Tag _tag, typename _Tp, typename... _Up> |
| 3335 | static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) { |
| 3336 | return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3337 | } |
| 3338 | |
| 3339 | Tag getTag() const { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3340 | return static_cast<Tag>(_value.index()); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3341 | } |
| 3342 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3343 | template <Tag _tag> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3344 | const auto& get() const { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3345 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3346 | return std::get<_tag>(_value); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3347 | } |
| 3348 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3349 | template <Tag _tag> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3350 | auto& get() { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3351 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3352 | return std::get<_tag>(_value); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3353 | } |
| 3354 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3355 | template <Tag _tag, typename... _Tp> |
| 3356 | void set(_Tp&&... _args) { |
| 3357 | _value.emplace<_tag>(std::forward<_Tp>(_args)...); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3358 | } |
| 3359 | |
| 3360 | ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final; |
| 3361 | ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final; |
| 3362 | static const std::string& getParcelableDescriptor() { |
| 3363 | static const std::string DESCIPTOR = "a.Foo"; |
| 3364 | return DESCIPTOR; |
| 3365 | } |
Jooyung Han | b8e01b9 | 2020-11-01 16:49:13 +0900 | [diff] [blame] | 3366 | template <typename _T> class _has_toString { |
| 3367 | template <typename _U> static std::true_type __has_toString(decltype(&_U::toString)); |
| 3368 | template <typename _U> static std::false_type __has_toString(...); |
| 3369 | public: enum { value = decltype(__has_toString<_T>(nullptr))::value }; |
| 3370 | }; |
| 3371 | template <typename _T> inline static std::string _call_toString(const _T& t) { |
| 3372 | if constexpr (_has_toString<_T>::value) return t.toString(); |
| 3373 | return "{no toString() implemented}"; |
| 3374 | } |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3375 | inline std::string toString() const { |
| 3376 | std::ostringstream os; |
| 3377 | os << "Foo{"; |
| 3378 | switch (getTag()) { |
| 3379 | case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break; |
| 3380 | case e: os << "e: " << a::toString(get<e>()); break; |
| 3381 | case pfd: os << "pfd: " << ""; break; |
| 3382 | } |
| 3383 | os << "}"; |
| 3384 | return os.str(); |
| 3385 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3386 | private: |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3387 | std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3388 | }; // class Foo |
| 3389 | |
| 3390 | } // namespace a |
| 3391 | )"; |
| 3392 | |
| 3393 | const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h> |
| 3394 | |
| 3395 | namespace a { |
| 3396 | |
| 3397 | ::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) { |
| 3398 | ::android::status_t _aidl_ret_status; |
| 3399 | int32_t _aidl_tag; |
| 3400 | if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status; |
| 3401 | switch (_aidl_tag) { |
| 3402 | case ns: { |
| 3403 | ::std::vector<int32_t> _aidl_value; |
| 3404 | if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3405 | if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) { |
| 3406 | set<ns>(_aidl_value); |
| 3407 | } else { |
| 3408 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3409 | set<ns>(std::move(_aidl_value)); |
| 3410 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3411 | return ::android::OK; } |
| 3412 | case e: { |
| 3413 | ::a::ByteEnum _aidl_value; |
| 3414 | if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3415 | if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) { |
| 3416 | set<e>(_aidl_value); |
| 3417 | } else { |
| 3418 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3419 | set<e>(std::move(_aidl_value)); |
| 3420 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3421 | return ::android::OK; } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3422 | case pfd: { |
| 3423 | ::android::os::ParcelFileDescriptor _aidl_value; |
| 3424 | if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3425 | if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) { |
| 3426 | set<pfd>(_aidl_value); |
| 3427 | } else { |
| 3428 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3429 | set<pfd>(std::move(_aidl_value)); |
| 3430 | } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3431 | return ::android::OK; } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3432 | } |
| 3433 | return ::android::BAD_VALUE; |
| 3434 | } |
| 3435 | |
| 3436 | ::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const { |
| 3437 | ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag()); |
| 3438 | if (_aidl_ret_status != ::android::OK) return _aidl_ret_status; |
| 3439 | switch (getTag()) { |
| 3440 | case ns: return _aidl_parcel->writeInt32Vector(get<ns>()); |
| 3441 | case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>())); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3442 | case pfd: return _aidl_parcel->writeParcelable(get<pfd>()); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3443 | } |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3444 | __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here"); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3445 | } |
| 3446 | |
| 3447 | } // namespace a |
| 3448 | )"; |
| 3449 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3450 | const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once |
| 3451 | #include <android/binder_interface_utils.h> |
| 3452 | #include <android/binder_parcelable_utils.h> |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3453 | #include <codecvt> |
| 3454 | #include <locale> |
| 3455 | #include <sstream> |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3456 | |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3457 | #include <cassert> |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3458 | #include <type_traits> |
| 3459 | #include <utility> |
| 3460 | #include <variant> |
| 3461 | #include <cstdint> |
| 3462 | #include <memory> |
| 3463 | #include <optional> |
| 3464 | #include <string> |
| 3465 | #include <vector> |
| 3466 | #ifdef BINDER_STABILITY_SUPPORT |
| 3467 | #include <android/binder_stability.h> |
| 3468 | #endif // BINDER_STABILITY_SUPPORT |
| 3469 | #include <aidl/a/ByteEnum.h> |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3470 | |
| 3471 | #ifndef __BIONIC__ |
| 3472 | #define __assert2(a,b,c,d) ((void)0) |
| 3473 | #endif |
| 3474 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3475 | namespace aidl { |
| 3476 | namespace a { |
| 3477 | class Foo { |
| 3478 | public: |
| 3479 | typedef std::false_type fixed_size; |
| 3480 | static const char* descriptor; |
| 3481 | |
| 3482 | enum Tag : int32_t { |
| 3483 | ns = 0, // int[] ns; |
| 3484 | e, // a.ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3485 | pfd, // ParcelFileDescriptor pfd; |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3486 | }; |
| 3487 | |
| 3488 | template<typename _Tp> |
| 3489 | static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>; |
| 3490 | |
| 3491 | Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { } |
| 3492 | Foo(const Foo&) = default; |
| 3493 | Foo(Foo&&) = default; |
| 3494 | Foo& operator=(const Foo&) = default; |
| 3495 | Foo& operator=(Foo&&) = default; |
| 3496 | |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3497 | template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>> |
| 3498 | // NOLINTNEXTLINE(google-explicit-constructor) |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3499 | constexpr Foo(_Tp&& _arg) |
| 3500 | : _value(std::forward<_Tp>(_arg)) {} |
| 3501 | |
| 3502 | template <typename... _Tp> |
| 3503 | constexpr explicit Foo(_Tp&&... _args) |
| 3504 | : _value(std::forward<_Tp>(_args)...) {} |
| 3505 | |
| 3506 | template <Tag _tag, typename... _Tp> |
| 3507 | static Foo make(_Tp&&... _args) { |
| 3508 | return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...); |
| 3509 | } |
| 3510 | |
| 3511 | template <Tag _tag, typename _Tp, typename... _Up> |
| 3512 | static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) { |
| 3513 | return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...); |
| 3514 | } |
| 3515 | |
| 3516 | Tag getTag() const { |
| 3517 | return static_cast<Tag>(_value.index()); |
| 3518 | } |
| 3519 | |
| 3520 | template <Tag _tag> |
| 3521 | const auto& get() const { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3522 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3523 | return std::get<_tag>(_value); |
| 3524 | } |
| 3525 | |
| 3526 | template <Tag _tag> |
| 3527 | auto& get() { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3528 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3529 | return std::get<_tag>(_value); |
| 3530 | } |
| 3531 | |
| 3532 | template <Tag _tag, typename... _Tp> |
| 3533 | void set(_Tp&&... _args) { |
| 3534 | _value.emplace<_tag>(std::forward<_Tp>(_args)...); |
| 3535 | } |
| 3536 | |
| 3537 | binder_status_t readFromParcel(const AParcel* _parcel); |
| 3538 | binder_status_t writeToParcel(AParcel* _parcel) const; |
Steven Moreland | f58804a | 2020-12-07 18:12:15 +0000 | [diff] [blame] | 3539 | |
| 3540 | inline bool operator!=(const Foo& rhs) const { |
| 3541 | return _value != rhs._value; |
| 3542 | } |
| 3543 | inline bool operator<(const Foo& rhs) const { |
| 3544 | return _value < rhs._value; |
| 3545 | } |
| 3546 | inline bool operator<=(const Foo& rhs) const { |
| 3547 | return _value <= rhs._value; |
| 3548 | } |
| 3549 | inline bool operator==(const Foo& rhs) const { |
| 3550 | return _value == rhs._value; |
| 3551 | } |
| 3552 | inline bool operator>(const Foo& rhs) const { |
| 3553 | return _value > rhs._value; |
| 3554 | } |
| 3555 | inline bool operator>=(const Foo& rhs) const { |
| 3556 | return _value >= rhs._value; |
| 3557 | } |
| 3558 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3559 | static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL; |
Jooyung Han | b8e01b9 | 2020-11-01 16:49:13 +0900 | [diff] [blame] | 3560 | template <typename _T> class _has_toString { |
| 3561 | template <typename _U> static std::true_type __has_toString(decltype(&_U::toString)); |
| 3562 | template <typename _U> static std::false_type __has_toString(...); |
| 3563 | public: enum { value = decltype(__has_toString<_T>(nullptr))::value }; |
| 3564 | }; |
| 3565 | template <typename _T> inline static std::string _call_toString(const _T& t) { |
| 3566 | if constexpr (_has_toString<_T>::value) return t.toString(); |
| 3567 | return "{no toString() implemented}"; |
| 3568 | } |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3569 | inline std::string toString() const { |
| 3570 | std::ostringstream os; |
| 3571 | os << "Foo{"; |
| 3572 | switch (getTag()) { |
| 3573 | case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break; |
| 3574 | case e: os << "e: " << a::toString(get<e>()); break; |
| 3575 | case pfd: os << "pfd: " << ""; break; |
| 3576 | } |
| 3577 | os << "}"; |
| 3578 | return os.str(); |
| 3579 | } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3580 | private: |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3581 | std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value; |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3582 | }; |
| 3583 | } // namespace a |
| 3584 | } // namespace aidl |
| 3585 | )"; |
| 3586 | |
| 3587 | const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h" |
| 3588 | |
| 3589 | #include <android/binder_parcel_utils.h> |
| 3590 | |
| 3591 | namespace aidl { |
| 3592 | namespace a { |
| 3593 | const char* Foo::descriptor = "a.Foo"; |
| 3594 | |
| 3595 | binder_status_t Foo::readFromParcel(const AParcel* _parcel) { |
| 3596 | binder_status_t _aidl_ret_status; |
| 3597 | int32_t _aidl_tag; |
| 3598 | if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status; |
| 3599 | switch (_aidl_tag) { |
| 3600 | case ns: { |
| 3601 | std::vector<int32_t> _aidl_value; |
| 3602 | if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3603 | if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) { |
| 3604 | set<ns>(_aidl_value); |
| 3605 | } else { |
| 3606 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3607 | set<ns>(std::move(_aidl_value)); |
| 3608 | } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3609 | return STATUS_OK; } |
| 3610 | case e: { |
| 3611 | ::aidl::a::ByteEnum _aidl_value; |
| 3612 | if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3613 | if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) { |
| 3614 | set<e>(_aidl_value); |
| 3615 | } else { |
| 3616 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3617 | set<e>(std::move(_aidl_value)); |
| 3618 | } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3619 | return STATUS_OK; } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3620 | case pfd: { |
| 3621 | ::ndk::ScopedFileDescriptor _aidl_value; |
| 3622 | if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3623 | if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) { |
| 3624 | set<pfd>(_aidl_value); |
| 3625 | } else { |
| 3626 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3627 | set<pfd>(std::move(_aidl_value)); |
| 3628 | } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3629 | return STATUS_OK; } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3630 | } |
| 3631 | return STATUS_BAD_VALUE; |
| 3632 | } |
| 3633 | binder_status_t Foo::writeToParcel(AParcel* _parcel) const { |
| 3634 | binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag()); |
| 3635 | if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status; |
| 3636 | switch (getTag()) { |
| 3637 | case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>()); |
| 3638 | case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>())); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3639 | case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>()); |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3640 | } |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3641 | __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here"); |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3642 | } |
| 3643 | |
| 3644 | } // namespace a |
| 3645 | } // namespace aidl |
| 3646 | )"; |
| 3647 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3648 | const char kUnionExampleExpectedOutputJava[] = R"(/* |
| 3649 | * This file is auto-generated. DO NOT MODIFY. |
| 3650 | */ |
| 3651 | package a; |
| 3652 | |
| 3653 | |
| 3654 | public final class Foo implements android.os.Parcelable { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3655 | // tags for union fields |
| 3656 | public final static int ns = 0; // int[] ns; |
| 3657 | public final static int e = 1; // a.ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3658 | public final static int pfd = 2; // ParcelFileDescriptor pfd; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3659 | |
| 3660 | private int _tag; |
| 3661 | private Object _value; |
| 3662 | |
| 3663 | public Foo() { |
Jooyung Han | ce62f93 | 2020-10-25 10:21:49 +0900 | [diff] [blame] | 3664 | int[] _value = {42}; |
| 3665 | this._tag = ns; |
| 3666 | this._value = _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3667 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3668 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3669 | private Foo(android.os.Parcel _aidl_parcel) { |
| 3670 | readFromParcel(_aidl_parcel); |
| 3671 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3672 | |
Jooyung Han | ce62f93 | 2020-10-25 10:21:49 +0900 | [diff] [blame] | 3673 | private Foo(int _tag, Object _value) { |
| 3674 | this._tag = _tag; |
| 3675 | this._value = _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3676 | } |
| 3677 | |
| 3678 | public int getTag() { |
| 3679 | return _tag; |
| 3680 | } |
| 3681 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3682 | // int[] ns; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3683 | |
| 3684 | public static Foo ns(int[] _value) { |
| 3685 | return new Foo(ns, _value); |
| 3686 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3687 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3688 | public int[] getNs() { |
| 3689 | _assertTag(ns); |
| 3690 | return (int[]) _value; |
| 3691 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3692 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3693 | public void setNs(int[] _value) { |
| 3694 | _set(ns, _value); |
| 3695 | } |
| 3696 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3697 | // a.ByteEnum e; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3698 | |
| 3699 | public static Foo e(byte _value) { |
| 3700 | return new Foo(e, _value); |
| 3701 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3702 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3703 | public byte getE() { |
| 3704 | _assertTag(e); |
| 3705 | return (byte) _value; |
| 3706 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3707 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3708 | public void setE(byte _value) { |
| 3709 | _set(e, _value); |
| 3710 | } |
| 3711 | |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3712 | // ParcelFileDescriptor pfd; |
| 3713 | |
| 3714 | public static Foo pfd(android.os.ParcelFileDescriptor _value) { |
| 3715 | return new Foo(pfd, _value); |
| 3716 | } |
| 3717 | |
| 3718 | public android.os.ParcelFileDescriptor getPfd() { |
| 3719 | _assertTag(pfd); |
| 3720 | return (android.os.ParcelFileDescriptor) _value; |
| 3721 | } |
| 3722 | |
| 3723 | public void setPfd(android.os.ParcelFileDescriptor _value) { |
| 3724 | _set(pfd, _value); |
| 3725 | } |
| 3726 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3727 | public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() { |
| 3728 | @Override |
| 3729 | public Foo createFromParcel(android.os.Parcel _aidl_source) { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3730 | return new Foo(_aidl_source); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3731 | } |
| 3732 | @Override |
| 3733 | public Foo[] newArray(int _aidl_size) { |
| 3734 | return new Foo[_aidl_size]; |
| 3735 | } |
| 3736 | }; |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3737 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3738 | @Override |
| 3739 | public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) { |
| 3740 | _aidl_parcel.writeInt(_tag); |
| 3741 | switch (_tag) { |
| 3742 | case ns: |
| 3743 | _aidl_parcel.writeIntArray(getNs()); |
| 3744 | break; |
| 3745 | case e: |
| 3746 | _aidl_parcel.writeByte(getE()); |
| 3747 | break; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3748 | case pfd: |
| 3749 | if ((getPfd()!=null)) { |
| 3750 | _aidl_parcel.writeInt(1); |
| 3751 | getPfd().writeToParcel(_aidl_parcel, 0); |
| 3752 | } |
| 3753 | else { |
| 3754 | _aidl_parcel.writeInt(0); |
| 3755 | } |
| 3756 | break; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3757 | } |
| 3758 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3759 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3760 | public void readFromParcel(android.os.Parcel _aidl_parcel) { |
| 3761 | int _aidl_tag; |
| 3762 | _aidl_tag = _aidl_parcel.readInt(); |
| 3763 | switch (_aidl_tag) { |
| 3764 | case ns: { |
| 3765 | int[] _aidl_value; |
| 3766 | _aidl_value = _aidl_parcel.createIntArray(); |
| 3767 | _set(_aidl_tag, _aidl_value); |
| 3768 | return; } |
| 3769 | case e: { |
| 3770 | byte _aidl_value; |
| 3771 | _aidl_value = _aidl_parcel.readByte(); |
| 3772 | _set(_aidl_tag, _aidl_value); |
| 3773 | return; } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3774 | case pfd: { |
| 3775 | android.os.ParcelFileDescriptor _aidl_value; |
| 3776 | if ((0!=_aidl_parcel.readInt())) { |
| 3777 | _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel); |
| 3778 | } |
| 3779 | else { |
| 3780 | _aidl_value = null; |
| 3781 | } |
| 3782 | _set(_aidl_tag, _aidl_value); |
| 3783 | return; } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3784 | } |
Jooyung Han | c453bea | 2020-11-21 01:00:22 +0900 | [diff] [blame] | 3785 | throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3786 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3787 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3788 | @Override |
| 3789 | public int describeContents() { |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3790 | int _mask = 0; |
| 3791 | switch (getTag()) { |
| 3792 | case pfd: |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3793 | _mask |= describeContents(getPfd()); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3794 | break; |
| 3795 | } |
| 3796 | return _mask; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3797 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3798 | private int describeContents(Object _v) { |
| 3799 | if (_v == null) return 0; |
| 3800 | if (_v instanceof android.os.Parcelable) { |
| 3801 | return ((android.os.Parcelable) _v).describeContents(); |
| 3802 | } |
| 3803 | return 0; |
| 3804 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3805 | |
| 3806 | private void _assertTag(int tag) { |
| 3807 | if (getTag() != tag) { |
Jooyung Han | ef9b0f6 | 2020-10-14 21:52:55 +0900 | [diff] [blame] | 3808 | throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available."); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3809 | } |
| 3810 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3811 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3812 | private String _tagString(int _tag) { |
| 3813 | switch (_tag) { |
| 3814 | case ns: return "ns"; |
| 3815 | case e: return "e"; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3816 | case pfd: return "pfd"; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3817 | } |
| 3818 | throw new IllegalStateException("unknown field: " + _tag); |
| 3819 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3820 | |
Jooyung Han | ce62f93 | 2020-10-25 10:21:49 +0900 | [diff] [blame] | 3821 | private void _set(int _tag, Object _value) { |
| 3822 | this._tag = _tag; |
| 3823 | this._value = _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3824 | } |
| 3825 | } |
| 3826 | )"; |
| 3827 | |
Jooyung Han | f93b5bd | 2020-10-28 15:12:08 +0900 | [diff] [blame] | 3828 | const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)] |
| 3829 | pub enum Foo { |
| 3830 | Ns(Vec<i32>), |
| 3831 | E(crate::mangled::_1_a_8_ByteEnum), |
| 3832 | Pfd(Option<binder::parcel::ParcelFileDescriptor>), |
| 3833 | } |
| 3834 | pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; } |
| 3835 | impl Default for Foo { |
| 3836 | fn default() -> Self { |
| 3837 | Self::Ns(vec!{42}) |
| 3838 | } |
| 3839 | } |
| 3840 | impl binder::parcel::Serialize for Foo { |
| 3841 | fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> { |
| 3842 | <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel) |
| 3843 | } |
| 3844 | } |
| 3845 | impl binder::parcel::SerializeArray for Foo {} |
| 3846 | impl binder::parcel::SerializeOption for Foo { |
| 3847 | fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> { |
| 3848 | let this = if let Some(this) = this { |
| 3849 | parcel.write(&1i32)?; |
| 3850 | this |
| 3851 | } else { |
| 3852 | return parcel.write(&0i32); |
| 3853 | }; |
| 3854 | match this { |
| 3855 | Self::Ns(v) => { |
| 3856 | parcel.write(&0i32)?; |
| 3857 | parcel.write(v) |
| 3858 | } |
| 3859 | Self::E(v) => { |
| 3860 | parcel.write(&1i32)?; |
| 3861 | parcel.write(v) |
| 3862 | } |
| 3863 | Self::Pfd(v) => { |
| 3864 | parcel.write(&2i32)?; |
| 3865 | let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?; |
| 3866 | parcel.write(__field_ref) |
| 3867 | } |
| 3868 | } |
| 3869 | } |
| 3870 | } |
| 3871 | impl binder::parcel::Deserialize for Foo { |
| 3872 | fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> { |
| 3873 | <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel) |
| 3874 | .transpose() |
| 3875 | .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL)) |
| 3876 | } |
| 3877 | } |
| 3878 | impl binder::parcel::DeserializeArray for Foo {} |
| 3879 | impl binder::parcel::DeserializeOption for Foo { |
| 3880 | fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> { |
| 3881 | let status: i32 = parcel.read()?; |
| 3882 | if status == 0 { return Ok(None); } |
| 3883 | let tag: i32 = parcel.read()?; |
| 3884 | match tag { |
| 3885 | 0 => { |
| 3886 | let value: Vec<i32> = parcel.read()?; |
| 3887 | Ok(Some(Self::Ns(value))) |
| 3888 | } |
| 3889 | 1 => { |
| 3890 | let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?; |
| 3891 | Ok(Some(Self::E(value))) |
| 3892 | } |
| 3893 | 2 => { |
| 3894 | let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?); |
| 3895 | Ok(Some(Self::Pfd(value))) |
| 3896 | } |
| 3897 | _ => { |
| 3898 | Err(binder::StatusCode::BAD_VALUE) |
| 3899 | } |
| 3900 | } |
| 3901 | } |
| 3902 | } |
| 3903 | )"; |
| 3904 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3905 | struct AidlUnionTest : ::testing::Test { |
| 3906 | void SetUp() override { |
| 3907 | io_delegate_.SetFileContents("a/Foo.aidl", R"( |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3908 | package a; |
| 3909 | import a.ByteEnum; |
| 3910 | union Foo { |
| 3911 | int[] ns = {42}; |
| 3912 | ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3913 | ParcelFileDescriptor pfd; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3914 | } |
| 3915 | )"); |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3916 | io_delegate_.SetFileContents("a/ByteEnum.aidl", R"( |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3917 | package a; |
| 3918 | @Backing(type="byte") |
| 3919 | enum ByteEnum { |
| 3920 | a, b, c |
| 3921 | } |
| 3922 | )"); |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3923 | } |
| 3924 | FakeIoDelegate io_delegate_; |
| 3925 | void Compile(string lang) { |
| 3926 | string command = "aidl --structured -I. -o out --lang=" + lang; |
| 3927 | if (lang == "cpp" || lang == "ndk") { |
| 3928 | command += " -h out"; |
| 3929 | } |
| 3930 | command += " a/Foo.aidl"; |
| 3931 | auto opts = Options::From(command); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3932 | CaptureStderr(); |
| 3933 | auto ret = ::android::aidl::compile_aidl(opts, io_delegate_); |
| 3934 | auto err = GetCapturedStderr(); |
| 3935 | EXPECT_EQ(0, ret) << err; |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3936 | } |
| 3937 | void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) { |
| 3938 | for (const auto& [path, expected] : outputs) { |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3939 | string actual; |
| 3940 | EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found."; |
| 3941 | EXPECT_EQ(expected, actual); |
| 3942 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3943 | } |
| 3944 | }; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3945 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3946 | TEST_F(AidlUnionTest, Example_Cpp) { |
| 3947 | Compile("cpp"); |
| 3948 | EXPECT_COMPILE_OUTPUTS( |
| 3949 | map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource}, |
| 3950 | {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}})); |
| 3951 | } |
| 3952 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3953 | TEST_F(AidlUnionTest, Example_Ndk) { |
| 3954 | Compile("ndk"); |
| 3955 | EXPECT_COMPILE_OUTPUTS( |
| 3956 | map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource}, |
| 3957 | {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}})); |
| 3958 | } |
| 3959 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3960 | TEST_F(AidlUnionTest, Example_Java) { |
| 3961 | Compile("java"); |
| 3962 | EXPECT_COMPILE_OUTPUTS( |
| 3963 | map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}})); |
Jooyung Han | f93b5bd | 2020-10-28 15:12:08 +0900 | [diff] [blame] | 3964 | } |
| 3965 | |
| 3966 | TEST_F(AidlUnionTest, Example_Rust) { |
| 3967 | Compile("rust"); |
| 3968 | EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}})); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3969 | } |
| 3970 | |
Jooyung Han | fe89f12 | 2020-10-14 03:49:18 +0900 | [diff] [blame] | 3971 | TEST_P(AidlTest, UnionRejectsEmptyDecl) { |
| 3972 | const string method = "package a; union Foo {}"; |
| 3973 | const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n"; |
| 3974 | CaptureStderr(); |
| 3975 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3976 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3977 | } |
| 3978 | |
| 3979 | TEST_P(AidlTest, UnionRejectsParcelableHolder) { |
| 3980 | const string method = "package a; union Foo { ParcelableHolder x; }"; |
| 3981 | const string expected_stderr = |
| 3982 | "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n"; |
| 3983 | CaptureStderr(); |
| 3984 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3985 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3986 | } |
| 3987 | |
Jooyung Han | 53fb424 | 2020-12-17 16:03:49 +0900 | [diff] [blame] | 3988 | TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) { |
| 3989 | import_paths_.insert("."); |
| 3990 | io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }"); |
| 3991 | const string expected_err = "The union's first member should have a useful default value."; |
| 3992 | CaptureStderr(); |
| 3993 | EXPECT_EQ(nullptr, |
| 3994 | Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage())); |
| 3995 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err)); |
| 3996 | } |
| 3997 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3998 | TEST_P(AidlTest, GenericStructuredParcelable) { |
| 3999 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4000 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 4001 | const string expected_stderr = ""; |
| 4002 | CaptureStderr(); |
| 4003 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4004 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4005 | } |
| 4006 | |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 4007 | TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) { |
| 4008 | io_delegate_.SetFileContents("Foo.aidl", |
| 4009 | "parcelable Foo<T, U> { int a; const String s = \"\"; }"); |
| 4010 | Options options = |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4011 | Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out"); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 4012 | const string expected_stderr = ""; |
| 4013 | CaptureStderr(); |
| 4014 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4015 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4016 | |
| 4017 | string code; |
| 4018 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 4019 | EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U> |
| 4020 | const ::android::String16& Foo<T,U>::s() { |
| 4021 | static const ::android::String16 value(::android::String16("")); |
| 4022 | return value; |
| 4023 | })--")); |
| 4024 | } |
| 4025 | |
| 4026 | TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) { |
| 4027 | io_delegate_.SetFileContents("Foo.aidl", |
| 4028 | "parcelable Foo<T, U> { int a; const String s = \"\"; }"); |
| 4029 | Options options = |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4030 | Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out"); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 4031 | const string expected_stderr = ""; |
| 4032 | CaptureStderr(); |
| 4033 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4034 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4035 | |
| 4036 | string code; |
| 4037 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 4038 | EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U> |
| 4039 | const char* Foo<T, U>::s = ""; |
| 4040 | )--")); |
| 4041 | } |
| 4042 | |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 4043 | TEST_F(AidlTest, NestedTypeArgs) { |
| 4044 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }"); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 4045 | io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }"); |
| 4046 | |
| 4047 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 4048 | "package a; import a.Bar; import a.Baz; parcelable Foo { " |
| 4049 | "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }"); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 4050 | Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java"); |
| 4051 | const string expected_stderr = ""; |
| 4052 | CaptureStderr(); |
| 4053 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4054 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4055 | |
| 4056 | string code; |
| 4057 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 4058 | EXPECT_THAT(code, |
| 4059 | testing::HasSubstr( |
| 4060 | "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;")); |
| 4061 | } |
| 4062 | |
| 4063 | TEST_F(AidlTest, DoubleArrayError) { |
| 4064 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }"); |
| 4065 | |
| 4066 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 4067 | const string expected_stderr = |
| 4068 | "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n"; |
| 4069 | CaptureStderr(); |
| 4070 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4071 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4072 | } |
| 4073 | |
| 4074 | TEST_F(AidlTest, DoubleGenericError) { |
| 4075 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 4076 | "package a; parcelable Bar { List<String><String> a; }"); |
| 4077 | |
| 4078 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 4079 | const string expected_stderr = |
| 4080 | "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n"; |
| 4081 | CaptureStderr(); |
| 4082 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4083 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4084 | } |
| 4085 | |
| 4086 | TEST_F(AidlTest, ArrayBeforeGenericError) { |
| 4087 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }"); |
| 4088 | |
| 4089 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 4090 | const string expected_stderr = |
| 4091 | "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n"; |
| 4092 | CaptureStderr(); |
| 4093 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4094 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 4095 | } |
| 4096 | |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 4097 | struct GenericAidlTest : ::testing::Test { |
| 4098 | FakeIoDelegate io_delegate_; |
| 4099 | void Compile(string cmd) { |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 4100 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }"); |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 4101 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }"); |
| 4102 | io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }"); |
| 4103 | io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }"); |
| 4104 | |
| 4105 | Options options = Options::From(cmd); |
| 4106 | CaptureStderr(); |
| 4107 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4108 | EXPECT_EQ("", GetCapturedStderr()); |
| 4109 | } |
| 4110 | }; |
| 4111 | |
| 4112 | TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) { |
| 4113 | Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out"); |
| 4114 | string code; |
| 4115 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 4116 | EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>")); |
| 4117 | EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>")); |
| 4118 | EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>")); |
| 4119 | } |
| 4120 | |
| 4121 | TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) { |
| 4122 | Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out"); |
| 4123 | string code; |
| 4124 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 4125 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>")); |
| 4126 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>")); |
| 4127 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>")); |
| 4128 | } |
| 4129 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 4130 | TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) { |
| 4131 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4132 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 4133 | const string expected_stderr = |
| 4134 | "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n"; |
| 4135 | CaptureStderr(); |
| 4136 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4137 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4138 | } |
| 4139 | |
| 4140 | TEST_P(AidlTest, RejectGenericStructuredParcelableField) { |
| 4141 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4142 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 4143 | const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n"; |
| 4144 | CaptureStderr(); |
| 4145 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4146 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 4147 | } |
| 4148 | |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 4149 | TEST_P(AidlTest, LongCommentWithinConstExpression) { |
| 4150 | io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4151 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 4152 | CaptureStderr(); |
| 4153 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4154 | EXPECT_EQ("", GetCapturedStderr()); |
| 4155 | } |
| 4156 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 4157 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) { |
| 4158 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }"); |
| 4159 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
| 4160 | std::string expectedErr = |
| 4161 | "ERROR: a/Foo.aidl:1.28-30: " |
| 4162 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 4163 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 4164 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 4165 | "ERROR: a/Foo.aidl:1.35-37: " |
| 4166 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 4167 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 4168 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 4169 | CaptureStderr(); |
| 4170 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4171 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 4172 | } |
| 4173 | |
| 4174 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) { |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 4175 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }"); |
| 4176 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 4177 | std::string expectedErr = |
| 4178 | "ERROR: a/Foo.aidl:1.33-35: " |
| 4179 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 4180 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 4181 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 4182 | "ERROR: a/Foo.aidl:1.40-42: " |
| 4183 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 4184 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 4185 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 4186 | CaptureStderr(); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 4187 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4188 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 4189 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 4190 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 4191 | TEST_F(AidlTest, RejectNestedUntypedListAndMap) { |
| 4192 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;"); |
| 4193 | io_delegate_.SetFileContents( |
| 4194 | "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }"); |
| 4195 | Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out"); |
| 4196 | std::string expectedErr = |
| 4197 | "ERROR: a/Foo.aidl:1.52-54: " |
| 4198 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 4199 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 4200 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 4201 | "ERROR: a/Foo.aidl:1.64-66: " |
| 4202 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 4203 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 4204 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 4205 | CaptureStderr(); |
| 4206 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 4207 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 4208 | } |
| 4209 | |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4210 | TEST_F(AidlTest, EnumWithDefaults_Java) { |
| 4211 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 4212 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4213 | package p; |
| 4214 | import p.Enum; |
| 4215 | parcelable Foo { |
| 4216 | Enum e = Enum.BAR; |
| 4217 | })"); |
| 4218 | CaptureStderr(); |
| 4219 | auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl"); |
| 4220 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4221 | auto err = GetCapturedStderr(); |
| 4222 | EXPECT_EQ("", err); |
| 4223 | |
| 4224 | string code; |
| 4225 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code)); |
Jooyung Han | 2d83361 | 2020-12-17 15:59:27 +0900 | [diff] [blame] | 4226 | EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR")); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4227 | } |
| 4228 | |
| 4229 | TEST_F(AidlTest, EnumWithDefaults_Cpp) { |
| 4230 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 4231 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4232 | package p; |
| 4233 | import p.Enum; |
| 4234 | parcelable Foo { |
| 4235 | Enum e = Enum.BAR; |
| 4236 | })"); |
| 4237 | CaptureStderr(); |
| 4238 | auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl"); |
| 4239 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4240 | auto err = GetCapturedStderr(); |
| 4241 | EXPECT_EQ("", err); |
| 4242 | |
| 4243 | string code; |
| 4244 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code)); |
| 4245 | EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);")); |
| 4246 | } |
| 4247 | |
| 4248 | TEST_F(AidlTest, EnumWithDefaults_Ndk) { |
| 4249 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 4250 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4251 | package p; |
| 4252 | import p.Enum; |
| 4253 | parcelable Foo { |
| 4254 | Enum e = Enum.BAR; |
| 4255 | })"); |
| 4256 | CaptureStderr(); |
| 4257 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 4258 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4259 | auto err = GetCapturedStderr(); |
| 4260 | EXPECT_EQ("", err); |
| 4261 | |
| 4262 | string code; |
| 4263 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code)); |
| 4264 | EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;")); |
| 4265 | } |
| 4266 | |
| 4267 | TEST_F(AidlTest, EnumWithDefaults_Rust) { |
| 4268 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 4269 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4270 | package p; |
| 4271 | import p.Enum; |
| 4272 | parcelable Foo { |
| 4273 | int n = 42; |
| 4274 | Enum e = Enum.BAR; |
| 4275 | })"); |
| 4276 | CaptureStderr(); |
| 4277 | auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl"); |
| 4278 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4279 | auto err = GetCapturedStderr(); |
| 4280 | EXPECT_EQ("", err); |
| 4281 | |
| 4282 | string code; |
| 4283 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code)); |
| 4284 | EXPECT_THAT(code, testing::HasSubstr(R"( |
| 4285 | fn default() -> Self { |
| 4286 | Self { |
| 4287 | n: 42, |
| 4288 | e: crate::mangled::_1_p_4_Enum::BAR, |
| 4289 | } |
| 4290 | })")); |
| 4291 | } |
| 4292 | |
| 4293 | TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) { |
| 4294 | import_paths_.insert("a"); |
| 4295 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 4296 | CaptureStderr(); |
| 4297 | const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"( |
| 4298 | package p; |
| 4299 | import p.Enum; |
| 4300 | parcelable Foo { |
| 4301 | int e = Enum.FOO | Enum.BAR; |
| 4302 | })", |
| 4303 | typenames_, GetLanguage()); |
| 4304 | auto err = GetCapturedStderr(); |
| 4305 | EXPECT_EQ("", err); |
| 4306 | EXPECT_TRUE(type); |
| 4307 | const auto& fields = type->AsStructuredParcelable()->GetFields(); |
| 4308 | EXPECT_EQ("int e = 3", fields[0]->ToString()); |
| 4309 | } |
| 4310 | |
| 4311 | TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) { |
| 4312 | CaptureStderr(); |
| 4313 | const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"( |
| 4314 | @Backing(type="int") |
| 4315 | enum Foo { |
| 4316 | STANDARD_SHIFT = 16, |
| 4317 | STANDARD_BT709 = 1 << STANDARD_SHIFT, |
| 4318 | STANDARD_BT601_625 = 2 << STANDARD_SHIFT, |
| 4319 | } |
| 4320 | )", |
| 4321 | typenames_, GetLanguage()); |
| 4322 | auto err = GetCapturedStderr(); |
| 4323 | EXPECT_EQ("", err); |
| 4324 | EXPECT_TRUE(type); |
| 4325 | const auto& enum_type = type->AsEnumDeclaration(); |
| 4326 | string code; |
| 4327 | enum_type->Dump(CodeWriter::ForString(&code).get()); |
| 4328 | EXPECT_EQ(R"--(@Backing(type="int") |
| 4329 | enum Foo { |
| 4330 | STANDARD_SHIFT = 16, |
| 4331 | STANDARD_BT709 = 65536, |
| 4332 | STANDARD_BT601_625 = 131072, |
| 4333 | } |
| 4334 | )--", |
| 4335 | code); |
| 4336 | } |
| 4337 | |
| 4338 | TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) { |
| 4339 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 4340 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4341 | package p; |
| 4342 | import p.Enum; |
| 4343 | parcelable Foo { |
| 4344 | Enum e = Enum.FOO | Enum.BAR; |
| 4345 | })"); |
| 4346 | CaptureStderr(); |
| 4347 | auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl"); |
| 4348 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 4349 | auto err = GetCapturedStderr(); |
| 4350 | EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n", |
| 4351 | err); |
| 4352 | } |
| 4353 | |
| 4354 | TEST_P(AidlTest, DefaultWithEmptyArray) { |
| 4355 | io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }"); |
| 4356 | io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }"); |
| 4357 | CaptureStderr(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4358 | auto options = |
| 4359 | Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl"); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4360 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4361 | auto err = GetCapturedStderr(); |
| 4362 | EXPECT_EQ("", err); |
| 4363 | } |
| 4364 | |
| 4365 | TEST_P(AidlTest, RejectRefsInAnnotation) { |
| 4366 | io_delegate_.SetFileContents("a/p/IFoo.aidl", |
| 4367 | "package p; interface IFoo {\n" |
| 4368 | " const String ANNOTATION = \"@Annotation\";\n" |
| 4369 | " @JavaPassthrough(annotation=ANNOTATION) void foo();\n" |
| 4370 | "}"); |
| 4371 | CaptureStderr(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4372 | auto options = |
| 4373 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl"); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4374 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 4375 | auto err = GetCapturedStderr(); |
| 4376 | EXPECT_EQ( |
| 4377 | "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to " |
| 4378 | "ANNOTATION.\n", |
| 4379 | err); |
| 4380 | } |
| 4381 | |
| 4382 | TEST_F(AidlTest, DefaultWithEnumValues) { |
| 4383 | io_delegate_.SetFileContents( |
| 4384 | "a/p/Foo.aidl", |
| 4385 | "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }"); |
| 4386 | io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }"); |
| 4387 | CaptureStderr(); |
| 4388 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 4389 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4390 | auto err = GetCapturedStderr(); |
| 4391 | EXPECT_EQ("", err); |
| 4392 | string code; |
| 4393 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code)); |
| 4394 | EXPECT_THAT( |
| 4395 | code, testing::HasSubstr( |
| 4396 | "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};")); |
| 4397 | } |
| 4398 | |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4399 | TEST_F(AidlTest, RejectsCircularReferencingEnumerators) { |
| 4400 | io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }"); |
| 4401 | CaptureStderr(); |
| 4402 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 4403 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 4404 | auto err = GetCapturedStderr(); |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 4405 | EXPECT_EQ( |
| 4406 | "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n" |
| 4407 | "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n", |
| 4408 | err); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4409 | } |
| 4410 | |
| 4411 | TEST_F(AidlTest, RejectsCircularReferencingConsts) { |
| 4412 | io_delegate_.SetFileContents("a/p/Foo.aidl", |
| 4413 | "package p; parcelable Foo { const int A = A + 1; }"); |
| 4414 | CaptureStderr(); |
| 4415 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 4416 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 4417 | auto err = GetCapturedStderr(); |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 4418 | EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err); |
| 4419 | } |
| 4420 | |
| 4421 | TEST_F(AidlTest, RecursiveReferences) { |
| 4422 | io_delegate_.SetFileContents("a/p/Foo.aidl", |
| 4423 | "package p; parcelable Foo { const int A = p.Bar.A + 1; }"); |
| 4424 | io_delegate_.SetFileContents("a/p/Bar.aidl", |
| 4425 | "package p; parcelable Bar { const int A = p.Baz.A + 1; }"); |
| 4426 | io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }"); |
| 4427 | CaptureStderr(); |
| 4428 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
| 4429 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
| 4430 | EXPECT_EQ("", GetCapturedStderr()); |
| 4431 | } |
| 4432 | |
Jooyung Han | e9f5b27 | 2021-01-07 00:18:11 +0900 | [diff] [blame] | 4433 | TEST_P(AidlTest, UnknownConstReference) { |
| 4434 | io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }"); |
| 4435 | auto options = |
| 4436 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl"); |
| 4437 | const string err = |
| 4438 | "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n" |
| 4439 | "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n" |
| 4440 | "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n"; |
| 4441 | CaptureStderr(); |
| 4442 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
| 4443 | EXPECT_EQ(err, GetCapturedStderr()); |
| 4444 | } |
| 4445 | |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 4446 | TEST_P(AidlTest, JavaCompatibleBuiltinTypes) { |
| 4447 | string contents = R"( |
| 4448 | import android.os.IBinder; |
| 4449 | import android.os.IInterface; |
| 4450 | interface IFoo {} |
| 4451 | )"; |
| 4452 | EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage())); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4453 | } |
| 4454 | |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4455 | TEST_P(AidlTest, WarningInterfaceName) { |
| 4456 | io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4457 | auto options = Options::From("aidl --lang " + to_string(GetLanguage()) + |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4458 | " -Weverything -o out -h out p/Foo.aidl"); |
| 4459 | CaptureStderr(); |
| 4460 | EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 808a2a0 | 2020-12-28 16:46:54 +0900 | [diff] [blame] | 4461 | EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n", |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4462 | GetCapturedStderr()); |
| 4463 | } |
| 4464 | |
| 4465 | TEST_P(AidlTest, ErrorInterfaceName) { |
| 4466 | io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4467 | auto options = Options::From("aidl --lang " + to_string(GetLanguage()) + |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4468 | " -Weverything -Werror -o out -h out p/Foo.aidl"); |
| 4469 | CaptureStderr(); |
| 4470 | EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 808a2a0 | 2020-12-28 16:46:54 +0900 | [diff] [blame] | 4471 | EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n", |
Jooyung Han | 3b99018 | 2020-12-22 17:44:31 +0900 | [diff] [blame] | 4472 | GetCapturedStderr()); |
| 4473 | } |
| 4474 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4475 | struct TypeParam { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4476 | string kind; |
| 4477 | string literal; |
| 4478 | }; |
| 4479 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4480 | const TypeParam kTypeParams[] = { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4481 | {"primitive", "int"}, {"String", "String"}, |
| 4482 | {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"}, |
| 4483 | {"parcelable", "Foo"}, {"enum", "a.Enum"}, |
| 4484 | {"union", "a.Union"}, {"interface", "a.IBar"}, |
| 4485 | }; |
| 4486 | |
| 4487 | const std::map<std::string, std::string> kListSupportExpectations = { |
| 4488 | {"cpp_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4489 | {"java_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4490 | {"ndk_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4491 | {"rust_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4492 | {"cpp_String", ""}, |
| 4493 | {"java_String", ""}, |
| 4494 | {"ndk_String", ""}, |
| 4495 | {"rust_String", ""}, |
| 4496 | {"cpp_IBinder", ""}, |
| 4497 | {"java_IBinder", ""}, |
| 4498 | {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."}, |
| 4499 | {"rust_IBinder", ""}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 4500 | {"cpp_ParcelFileDescriptor", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4501 | {"java_ParcelFileDescriptor", ""}, |
| 4502 | {"ndk_ParcelFileDescriptor", ""}, |
| 4503 | {"rust_ParcelFileDescriptor", ""}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 4504 | {"cpp_interface", "List<a.IBar> is not supported."}, |
| 4505 | {"java_interface", "List<a.IBar> is not supported."}, |
| 4506 | {"ndk_interface", "List<a.IBar> is not supported."}, |
| 4507 | {"rust_interface", "List<a.IBar> is not supported."}, |
| 4508 | {"cpp_parcelable", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4509 | {"java_parcelable", ""}, |
| 4510 | {"ndk_parcelable", ""}, |
| 4511 | {"rust_parcelable", ""}, |
| 4512 | {"cpp_enum", "A generic type cannot have any primitive type parameters."}, |
| 4513 | {"java_enum", "A generic type cannot have any primitive type parameters."}, |
| 4514 | {"ndk_enum", "A generic type cannot have any primitive type parameters."}, |
| 4515 | {"rust_enum", "A generic type cannot have any primitive type parameters."}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 4516 | {"cpp_union", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4517 | {"java_union", ""}, |
| 4518 | {"ndk_union", ""}, |
| 4519 | {"rust_union", ""}, |
| 4520 | }; |
| 4521 | |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 4522 | const std::map<std::string, std::string> kArraySupportExpectations = { |
| 4523 | {"cpp_primitive", ""}, |
| 4524 | {"java_primitive", ""}, |
| 4525 | {"ndk_primitive", ""}, |
| 4526 | {"rust_primitive", ""}, |
| 4527 | {"cpp_String", ""}, |
| 4528 | {"java_String", ""}, |
| 4529 | {"ndk_String", ""}, |
| 4530 | {"rust_String", ""}, |
| 4531 | {"cpp_IBinder", ""}, |
| 4532 | {"java_IBinder", ""}, |
| 4533 | {"ndk_IBinder", "The ndk backend does not support array of IBinder"}, |
| 4534 | {"rust_IBinder", "The rust backend does not support array of IBinder"}, |
| 4535 | {"cpp_ParcelFileDescriptor", ""}, |
| 4536 | {"java_ParcelFileDescriptor", ""}, |
| 4537 | {"ndk_ParcelFileDescriptor", ""}, |
| 4538 | {"rust_ParcelFileDescriptor", ""}, |
| 4539 | {"cpp_interface", "Binder type cannot be an array"}, |
| 4540 | {"java_interface", "Binder type cannot be an array"}, |
| 4541 | {"ndk_interface", "Binder type cannot be an array"}, |
| 4542 | {"rust_interface", "Binder type cannot be an array"}, |
| 4543 | {"cpp_parcelable", ""}, |
| 4544 | {"java_parcelable", ""}, |
| 4545 | {"ndk_parcelable", ""}, |
| 4546 | {"rust_parcelable", ""}, |
| 4547 | {"cpp_enum", ""}, |
| 4548 | {"java_enum", ""}, |
| 4549 | {"ndk_enum", ""}, |
| 4550 | {"rust_enum", ""}, |
| 4551 | {"cpp_union", ""}, |
| 4552 | {"java_union", ""}, |
| 4553 | {"ndk_union", ""}, |
| 4554 | {"rust_union", ""}, |
| 4555 | }; |
| 4556 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4557 | class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4558 | public: |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4559 | void Run(const std::string& generic_type_decl, |
| 4560 | const std::map<std::string, std::string>& expectations) { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4561 | const auto& param = GetParam(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4562 | const auto& lang = to_string(std::get<0>(param)); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4563 | const auto& kind = std::get<1>(param).kind; |
| 4564 | |
| 4565 | FakeIoDelegate io; |
| 4566 | io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }"); |
| 4567 | io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }"); |
| 4568 | io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }"); |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4569 | std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal); |
| 4570 | io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }"); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4571 | |
| 4572 | const auto options = |
| 4573 | Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang)); |
| 4574 | CaptureStderr(); |
| 4575 | compile_aidl(options, io); |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4576 | auto it = expectations.find(lang + "_" + kind); |
| 4577 | EXPECT_TRUE(it != expectations.end()); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4578 | const string err = GetCapturedStderr(); |
| 4579 | if (it->second.empty()) { |
| 4580 | EXPECT_EQ("", err); |
| 4581 | } else { |
| 4582 | EXPECT_THAT(err, testing::HasSubstr(it->second)); |
| 4583 | } |
| 4584 | } |
| 4585 | }; |
| 4586 | |
| 4587 | INSTANTIATE_TEST_SUITE_P( |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4588 | AidlTestSuite, AidlTypeParamTest, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4589 | testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA, |
| 4590 | Options::Language::NDK, Options::Language::RUST), |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4591 | testing::ValuesIn(kTypeParams)), |
| 4592 | [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) { |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4593 | return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind; |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4594 | }); |
| 4595 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4596 | TEST_P(AidlTypeParamTest, ListSupportedTypes) { |
| 4597 | Run("List<{}>", kListSupportExpectations); |
| 4598 | } |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4599 | |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 4600 | TEST_P(AidlTypeParamTest, ArraySupportedTypes) { |
| 4601 | Run("{}[]", kArraySupportExpectations); |
| 4602 | } |
| 4603 | |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 4604 | } // namespace aidl |
| 4605 | } // namespace android |