blob: c74b78d9a902752c201040cd87cd36d3081613ab [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Christopher Wileyf8136192016-04-12 14:19:35 -070081} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070082
Devin Moore7b8d5c92020-03-17 14:14:08 -070083class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070084 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090085 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
86 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070087 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070088 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090089 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070090 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090091 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 for (const string& s : additional_arguments) {
93 args.emplace_back(s);
94 }
95 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090096 args.emplace_back("--preprocessed=" + f);
97 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -070098 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--include=" + i);
100 }
101 args.emplace_back(path);
102 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900103 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900104 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700105 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900106 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900107
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 if (error != nullptr) {
109 *error = actual_error;
110 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900111
112 if (actual_error != AidlError::OK) {
113 return nullptr;
114 }
115
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900116 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900117 EXPECT_EQ(1ul, defined_types.size());
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700120 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700121
Devin Moore7b8d5c92020-03-17 14:14:08 -0700122 Options::Language GetLanguage() { return GetParam(); }
123
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800125 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900126 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900127 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700128};
129
Devin Moore7b8d5c92020-03-17 14:14:08 -0700130// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
131// tests with each of the supported languages as a parameter.
132INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
133 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700134 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900136 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 });
138
139TEST_P(AidlTest, AcceptMissingPackage) {
140 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700141}
142
Devin Moore7b8d5c92020-03-17 14:14:08 -0700143TEST_P(AidlTest, EndsInSingleLineComment) {
144 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700145}
146
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000147TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
148 const string expected_stderr =
149 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
150 const std::string file_contents = "package a; interface IBar {}";
151 CaptureStderr();
152 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
153 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
154}
155
156TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
157 const string expected_stderr =
158 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
159 const std::string file_contents = "package a; interface Bar {}";
160 CaptureStderr();
161 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
162 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
163}
164
165TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
166 const string expected_stderr =
167 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
168 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
169 CaptureStderr();
170 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
171 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
172}
173
174TEST_P(AidlTest, EnumRequiresCorrectPath) {
175 const string expected_stderr =
176 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
177 const std::string file_contents = "package a; enum Bar { A, }";
178 CaptureStderr();
179 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
180 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
181}
182
Devin Moore7b8d5c92020-03-17 14:14:08 -0700183TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900184 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700185 io_delegate_.SetFileContents("bar/IBar.aidl",
186 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700187 const string path = "foo/IFoo.aidl";
188 const string contents =
189 "package foo;\n"
190 "import bar.IBar;\n"
191 "interface IFoo { void f(in IBar[] input); }";
192 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
193 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700194 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700195 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700196}
197
Devin Moore7b8d5c92020-03-17 14:14:08 -0700198TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700199 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900201}
Devin Moore097a3ab2020-03-11 16:08:44 -0700202
Jiyong Park40782d02020-07-24 19:17:43 +0900203TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
205 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900206 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
207 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700208 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700209 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900211}
212
Jiyong Park40782d02020-07-24 19:17:43 +0900213TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700214 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
215 const string expected_stderr =
216 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 CaptureStderr();
218 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
219 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900220}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700221
Jiyong Park40782d02020-07-24 19:17:43 +0900222TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700223 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900224 const string expected_stderr =
225 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700226 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700227 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700229}
230
Devin Moore7b8d5c92020-03-17 14:14:08 -0700231TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700232 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
233 const string expected_stderr =
234 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
235 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700238}
239
Devin Moore7b8d5c92020-03-17 14:14:08 -0700240TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700241 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
242 const string expected_stderr =
243 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
244 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800247}
248
Devin Moore2f2077a2020-08-28 11:27:53 -0700249TEST_P(AidlTest, AcceptNullableList) {
250 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
251 const string expected_stderr = "";
252 CaptureStderr();
253 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
254 EXPECT_EQ(expected_stderr, GetCapturedStderr());
255}
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700258 const string method = "package a; interface IFoo { void f(int a, int a); }";
259 const string expected_stderr =
260 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
261 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700264}
265
Jeongik Cha13066da2020-08-06 15:43:19 +0900266TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
267 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900268 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
272}
273
Jooyung Hand902a972020-10-23 17:32:44 +0900274TEST_P(AidlTest, RejectsRepeatedAnnotations) {
275 const string method = R"(@Hide @Hide parcelable Foo {})";
276 const string expected_stderr =
277 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
278 "Foo.aidl:1.1-6\n";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
282}
283
Devin Moore7b8d5c92020-03-17 14:14:08 -0700284TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700285 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
286 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
287 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700288 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100290}
291
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 AidlError error;
294 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900297 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700298 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800299}
300
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 AidlError error;
303 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700307 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 AidlError error;
312 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700313 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000314 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000321 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700322 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700325 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800326}
327
Jiyong Park40782d02020-07-24 19:17:43 +0900328TEST_P(AidlTest, ParsesNonNullableAnnotation) {
329 auto parse_result =
330 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
331 ASSERT_NE(nullptr, parse_result);
332 const AidlInterface* interface = parse_result->AsInterface();
333 ASSERT_NE(nullptr, interface);
334 ASSERT_FALSE(interface->GetMethods().empty());
335 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
336}
337
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900339 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
340 typenames_, GetLanguage());
341 ASSERT_NE(nullptr, parse_result);
342 const AidlInterface* interface = parse_result->AsInterface();
343 ASSERT_NE(nullptr, interface);
344 ASSERT_FALSE(interface->GetMethods().empty());
345 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
346}
347
348TEST_P(AidlTest, ParsesNonUtf8Annotations) {
349 auto parse_result =
350 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
351 ASSERT_NE(nullptr, parse_result);
352 const AidlInterface* interface = parse_result->AsInterface();
353 ASSERT_NE(nullptr, interface);
354 ASSERT_FALSE(interface->GetMethods().empty());
355 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900359 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
360 typenames_, GetLanguage());
361 ASSERT_NE(nullptr, parse_result);
362 const AidlInterface* interface = parse_result->AsInterface();
363 ASSERT_NE(nullptr, interface);
364 ASSERT_FALSE(interface->GetMethods().empty());
365 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700369 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700370 const string expected_stderr =
371 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
372 "\"vintf\"'\n"
373 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
374 "--structured\n";
375 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700376 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700377 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700379 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700380}
381
Devin Moore7b8d5c92020-03-17 14:14:08 -0700382TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700383 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700384 const string expected_stderr =
385 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
386 "--structured\n";
387 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700391 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392}
393
Devin Moore7b8d5c92020-03-17 14:14:08 -0700394TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700395 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 const string expected_stderr =
397 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
398 "\"vintf\"'\n";
399 CaptureStderr();
400 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700401 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700403 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700407 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
409 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700410 ASSERT_EQ(AidlError::OK, error);
411 ASSERT_NE(nullptr, parse_result);
412 const AidlInterface* interface = parse_result->AsInterface();
413 ASSERT_NE(nullptr, interface);
414 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700415}
416
Jeongik Cha64783ed2019-06-07 18:30:54 +0900417TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
418 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900419 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
420 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900421 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700422 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900423 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900424 "a/Foo.aidl",
425 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900426
427 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900428 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700429 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900430 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700431 "Parcelable must be defined in AIDL directly.\n";
432 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900433 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700435
436 CaptureStderr();
437 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900439}
440
Jooyung Han1cbc4962020-10-25 10:07:15 +0900441TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
442 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
443 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
444 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900445 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
446
447 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900448 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900449 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
450
451 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900452 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900453 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
454
Jooyung Han1cbc4962020-10-25 10:07:15 +0900455 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900456 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
457}
458
Jooyung Han1cbc4962020-10-25 10:07:15 +0900459TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
460 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
461 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
462 CaptureStderr();
463 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
464 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
465 EXPECT_EQ("", GetCapturedStderr());
466
467 const string expected_to_string_method = R"--(
468 @Override
469 public String toString() {
470 switch (_tag) {
471 case a: return "a.Foo.a(" + (getA()) + ")";
472 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
473 }
474 throw new IllegalStateException("unknown field: " + _tag);
475 }
476)--";
477
478 string java_out;
479 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
480 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
481}
482
Jiyong Park9aa3d042020-12-04 23:30:02 +0900483TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
484 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
485 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
486 CaptureStderr();
487 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
488 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
489 EXPECT_EQ("", GetCapturedStderr());
490
491 const std::string expected = R"--(
492 @Override
493 public boolean equals(Object other) {
494 if (this == other) return true;
495 if (other == null) return false;
496 if (!(other instanceof Foo)) return false;
497 Foo that = (Foo)other;
498 if (!java.util.Objects.deepEquals(a, that.a)) return false;
499 if (!java.util.Objects.deepEquals(b, that.b)) return false;
500 return true;
501 }
502
503 @Override
504 public int hashCode() {
505 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
506 }
507)--";
508
509 string java_out;
510 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
511 EXPECT_THAT(java_out, testing::HasSubstr(expected));
512}
513
514TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
515 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
516 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
517 CaptureStderr();
518 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
519 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
520 EXPECT_EQ("", GetCapturedStderr());
521
522 const std::string expected = R"--(
523 @Override
524 public boolean equals(Object other) {
525 if (this == other) return true;
526 if (other == null) return false;
527 if (!(other instanceof Foo)) return false;
528 Foo that = (Foo)other;
529 if (_tag != that._tag) return false;
530 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
531 return true;
532 }
533
534 @Override
535 public int hashCode() {
536 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
537 }
538)--";
539
540 string java_out;
541 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
542 EXPECT_THAT(java_out, testing::HasSubstr(expected));
543}
544
Jooyung Han90345002020-10-23 15:28:53 +0900545TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900546 {
Jooyung Han90345002020-10-23 15:28:53 +0900547 io_delegate_.SetFileContents("a/Foo.aidl",
548 "package a; @JavaDerive(blah=true) parcelable Foo{}");
549 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
550 CaptureStderr();
551 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
552 const std::string expected_stderr =
553 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900554 EXPECT_THAT(GetCapturedStderr(),
555 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900556 }
557
558 {
559 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900560 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
561 CaptureStderr();
562 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900563 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900564 }
565
566 {
Jooyung Han90345002020-10-23 15:28:53 +0900567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900571 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900572 }
573}
574
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900575TEST_P(AidlTest, ParseDescriptorAnnotation) {
576 AidlError error;
577 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
578 typenames_, GetLanguage(), &error, {"--structured"});
579 ASSERT_EQ(AidlError::OK, error);
580 ASSERT_NE(nullptr, parse_result);
581 const AidlInterface* interface = parse_result->AsInterface();
582 ASSERT_NE(nullptr, interface);
583 ASSERT_EQ("IBar", interface->GetDescriptor());
584}
585
Jiyong Park40782d02020-07-24 19:17:43 +0900586TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700587 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700588 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900589}
590
591TEST_P(AidlTest, AcceptsOnewayInterface) {
592 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700593 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700594}
Christopher Wileyef140932015-11-03 09:29:19 -0800595
Devin Moore7b8d5c92020-03-17 14:14:08 -0700596TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700597 const string oneway_method =
598 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700599 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100600}
601
Steven Moreland65297cc2020-04-20 20:17:36 -0700602TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
603 const string oneway_method =
604 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
605 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
606 ASSERT_NE(nullptr, defined);
607 const AidlInterface* iface = defined->AsInterface();
608 ASSERT_NE(nullptr, iface);
609
610 const auto& methods = iface->GetMethods();
611 ASSERT_EQ(1u, methods.size());
612 const auto& method = methods[0];
613 const AidlTypeSpecifier& ret_type = method->GetType();
614
615 // TODO(b/151102494): these annotations should be on the method
616 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
617 ASSERT_TRUE(ret_type.IsHide());
618}
619
Devin Moore7b8d5c92020-03-17 14:14:08 -0700620TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100621 string foo_interface =
622 "package a; /* foo */ interface IFoo {"
623 " /* i */ int i();"
624 " /* j */ @nullable String j();"
625 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
626
Devin Moore7b8d5c92020-03-17 14:14:08 -0700627 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100628 EXPECT_NE(nullptr, parse_result);
629 EXPECT_EQ("/* foo */", parse_result->GetComments());
630
631 const AidlInterface* interface = parse_result->AsInterface();
632 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
633 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
634 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
635}
636
Jooyung Han1a551d32020-10-05 15:37:26 +0900637TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
638 io_delegate_.SetFileContents("p/cpp_header.aidl",
639 R"(package p;
640 parcelable cpp_header cpp_header "bar/header";)");
641 import_paths_.emplace("");
642 const string input_path = "p/IFoo.aidl";
643 const string input = R"(package p;
644 import p.cpp_header;
645 interface IFoo {
646 // get bar
647 cpp_header get();
648 })";
649
650 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
651 EXPECT_NE(nullptr, parse_result);
652 const AidlInterface* interface = parse_result->AsInterface();
653 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
654}
655
Christopher Wileyef140932015-11-03 09:29:19 -0800656TEST_F(AidlTest, ParsesPreprocessedFile) {
657 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
658 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700659 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900660 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700661 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
662 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800663}
664
665TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
666 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
667 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900668
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700669 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900670 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700671 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
672 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800673}
674
Devin Moore7b8d5c92020-03-17 14:14:08 -0700675TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800676 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
677 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
678 "interface IBar {}");
679 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900680 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900681 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800683 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900684
Christopher Wiley41544372015-11-03 14:52:29 -0800685 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700686 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
687 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800688 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700689 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900690 ambiguous_type.Resolve(typenames_);
691 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800692}
693
Jiyong Park8f6ec462020-01-19 20:52:47 +0900694// Special case of PreferImportToPreprocessed. Imported type should be preferred
695// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700696TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900697 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
698 io_delegate_.SetFileContents("one/IBar.aidl",
699 "package one; "
700 "interface IBar {}");
701 preprocessed_files_.push_back("preprocessed");
702 import_paths_.emplace("");
703 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700704 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900705 EXPECT_NE(nullptr, parse_result);
706
707 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700708 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
709 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900710 // But if we request just "IBar" we should get our imported one.
711 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
712 ambiguous_type.Resolve(typenames_);
713 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
714}
715
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800716TEST_F(AidlTest, WritePreprocessedFile) {
717 io_delegate_.SetFileContents("p/Outer.aidl",
718 "package p; parcelable Outer.Inner;");
719 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
720 "interface IBar {}");
721
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900722 vector<string> args {
723 "aidl",
724 "--preprocess",
725 "preprocessed",
726 "p/Outer.aidl",
727 "one/IBar.aidl"};
728 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800729 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
730
731 string output;
732 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
733 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
734}
735
Jooyung Han720253d2021-01-05 19:13:17 +0900736TEST_P(AidlTest, SupportDeprecated) {
737 struct TestCase {
738 std::string output_file;
739 std::string annotation;
740 };
741
742 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900743 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900744 io_delegate_.SetFileContents(filename, contents);
745
746 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
747 " --out=out --header_out=out");
748 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900749 for (const auto& [lang, test_case] : expectations) {
750 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900751 string output;
752 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output))
753 << base::Join(io_delegate_.ListOutputFiles(), ",");
754 EXPECT_THAT(output, HasSubstr(test_case.annotation));
755 }
756 };
757
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900758 // Emit escaped string for notes
759 CheckDeprecated(
760 "IFoo.aidl",
761 R"(interface IFoo {
762 /**
763 * @note asdf
764 * @deprecated a really long deprecation message
765 *
766 * which is really long
767 * @param foo bar
768 */
769 List<String> foo();
770 })",
771 {
772 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
773 {Options::Language::CPP,
774 {"out/IFoo.h",
775 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
776 {Options::Language::NDK,
777 {"out/aidl/IFoo.h",
778 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
779 {Options::Language::RUST,
780 {"out/IFoo.rs",
781 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
782 });
783
784 // In AIDL @deprecated can be in any style of comments
785 CheckDeprecated(
786 "IFoo.aidl",
787 "interface IFoo {\n"
788 " // @deprecated use bar()\n"
789 " List<String> foo();\n"
790 "}",
791 {
792 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
793 // TODO(b/177276893) @deprecated should be in javadoc style comments
794 // {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
795 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
796 {Options::Language::NDK,
797 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
798 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
799 });
Jooyung Han720253d2021-01-05 19:13:17 +0900800
801 CheckDeprecated("Foo.aidl",
802 "parcelable Foo {\n"
803 " /** @deprecated use bar*/\n"
804 " int foo = 0;\n"
805 "}",
806 {
807 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
808 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
809 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
810 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
811 });
812
813 CheckDeprecated("IFoo.aidl",
814 "interface IFoo {\n"
815 " /** @deprecated use bar*/\n"
816 " const int FOO = 0;\n"
817 "}",
818 {
819 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
820 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
821 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
822 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
823 });
824
825 // union fields
826 CheckDeprecated("Foo.aidl",
827 "union Foo {\n"
828 " int bar = 0;\n"
829 " /** @deprecated use bar*/\n"
830 " int foo;\n"
831 "}",
832 {
833 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
834 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
835 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
836 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
837 });
838
839 CheckDeprecated("Foo.aidl",
840 "/** @deprecated use Bar */\n"
841 "parcelable Foo {}",
842 {
843 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
844 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
845 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
846 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
847 });
848
849 CheckDeprecated("Foo.aidl",
850 "/** @deprecated use Bar */\n"
851 "union Foo { int foo = 0; }",
852 {
853 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
854 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
855 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
856 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
857 });
858
859 CheckDeprecated("IFoo.aidl",
860 "/** @deprecated use IBar */\n"
861 "interface IFoo {}",
862 {
863 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
864 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
865 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
866 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
867 });
868
869 CheckDeprecated("Foo.aidl",
870 "/** @deprecated use IBar */\n"
871 "enum Foo { FOO }",
872 {
873 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
874 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
875 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
876 // TODO(b/174514415) support "deprecated"
877 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
878 });
879}
880
Devin Moore7b8d5c92020-03-17 14:14:08 -0700881TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700882 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800883 io_delegate_.SetFileContents("p/Outer.aidl",
884 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900885 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700886 CaptureStderr();
887 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
888 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700889 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700890 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800891}
892
Devin Moore7b8d5c92020-03-17 14:14:08 -0700893TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800894 io_delegate_.SetFileContents("preprocessed",
895 "parcelable p.Outer.Inner;");
896 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900897 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700898 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800899 // TODO(wiley): This should actually return nullptr because we require
900 // the outer class name. However, for legacy reasons,
901 // this behavior must be maintained. b/17415692
902 EXPECT_NE(nullptr, parse_result);
903}
904
Christopher Wiley632801d2015-11-05 14:15:49 -0800905TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 const string expected_foo_stderr =
907 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
908 "Declared parcelables should be in their own file and/or cannot be used with --structured "
909 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700910 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
911
Christopher Wiley632801d2015-11-05 14:15:49 -0800912 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700913 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700914 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900915 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700916 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900917
Steven Morelande2c64b42018-09-18 15:06:37 -0700918 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900919 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700920 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900921 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700923
Devin Moore097a3ab2020-03-11 16:08:44 -0700924 const string expected_bar_stderr =
925 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
926 "Declared parcelables should be in their own file and/or cannot be used with --structured "
927 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700928 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
929
Jiyong Parkda8c6932019-08-12 19:56:08 +0900930 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700931 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900933 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700935 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700937 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800939}
940
Devin Moore7b8d5c92020-03-17 14:14:08 -0700941TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 const string expected_stderr =
943 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
944 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700945 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
946 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700947 AidlError error;
948 CaptureStderr();
949 EXPECT_EQ(
950 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700951 Parse("p/IFoo.aidl",
952 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700953 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
955 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700956}
957
Devin Moore7b8d5c92020-03-17 14:14:08 -0700958TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700959 AidlError error;
960 const string expected_stderr =
961 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
962 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900963 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
964 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700965 interface IFoo {
966 const String DUPLICATED = "d";
967 const int DUPLICATED = 1;
968 }
969 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700970 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
972 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700973}
974
Steven Morelande689da22020-11-10 02:06:30 +0000975TEST_P(AidlTest, FailOnTooBigConstant) {
976 AidlError error;
977 const string expected_stderr =
978 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
979 CaptureStderr();
980 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
981 R"(package p;
982 interface IFoo {
983 const byte type2small = 256;
984 }
985 )",
986 typenames_, GetLanguage(), &error));
987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
988 EXPECT_EQ(AidlError::BAD_TYPE, error);
989}
990
Jooyung Han30f64ad2020-12-15 08:16:31 +0900991TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
992 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
993 CaptureStderr();
994 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
995 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
996 EXPECT_EQ("", GetCapturedStderr());
997 string code;
998 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
999 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1000}
1001
Jooyung Han535c5e82020-12-29 15:16:59 +09001002TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001003 using Ptr = unique_ptr<AidlConstantValue>;
1004 const AidlLocation& loc = AIDL_LOCATION_HERE;
1005
Jooyung Han535c5e82020-12-29 15:16:59 +09001006 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1007 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1008 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1009 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001010
1011 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1012 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001013 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001014
1015 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1016 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1017 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1018 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001019 EXPECT_EQ(
1020 expected,
1021 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001022}
1023
Devin Moore7b8d5c92020-03-17 14:14:08 -07001024TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001025 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001026 const string expected_stderr =
1027 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001028 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001029 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1030 R"(package p;
1031 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001032 parcelable IBar {}
1033 parcelable StructuredParcelable {}
1034 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001035 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001036 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001038 // Parse success is important for clear error handling even if the cases aren't
1039 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001040 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001041}
1042
Devin Moore7b8d5c92020-03-17 14:14:08 -07001043TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001044 AidlError error;
1045 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1046 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001047 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001048 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1049 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001050}
1051
Steven Morelandf9e922f2020-07-08 21:15:27 +00001052TEST_P(AidlTest, FailOnEmptyListWithComma) {
1053 AidlError error;
1054 const string expected_stderr =
1055 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1056 CaptureStderr();
1057 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1058 typenames_, GetLanguage(), &error));
1059 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1060 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1061}
1062
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001064 AidlError error;
1065 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001066 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001067 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001068 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1069 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001070 interface IFoo {
1071 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1072 }
1073 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001074 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1076 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001077}
1078
Jiyong Park18132182020-06-08 20:24:40 +09001079TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1080 AidlError error;
1081 const string expected_stderr =
1082 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1083 "cpp_header (which can also be used as an identifier)\n";
1084 CaptureStderr();
1085 // Notice the trailing dot(.) in the name, which isn't a correct name
1086 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1087 GetLanguage(), &error));
1088 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1089 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1090}
1091
1092TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1093 AidlError error;
1094 const string expected_stderr =
1095 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1096 "cpp_header (which can also be used as an identifier)\n";
1097 CaptureStderr();
1098 // Notice the trailing dot(.) in the package name
1099 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1100 GetLanguage(), &error));
1101 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1102 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1103}
1104
Devin Moore7b8d5c92020-03-17 14:14:08 -07001105TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001106 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001107 auto parse_result = Parse("p/IFoo.aidl",
1108 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001109 interface IFoo {
1110 const int POSITIVE_HEX_VALUE = 0xf5;
1111 }
1112 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001113 typenames_, GetLanguage(), &error);
1114 EXPECT_NE(nullptr, parse_result);
1115 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001116 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001117 const auto& cpp_constants = interface->GetConstantDeclarations();
1118 EXPECT_EQ((size_t)1, cpp_constants.size());
1119 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001120 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001121 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001122}
1123
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001125 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001126 auto parse_result = Parse("p/IFoo.aidl",
1127 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001128 interface IFoo {
1129 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1130 }
1131 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001132 typenames_, GetLanguage(), &error);
1133 ASSERT_NE(nullptr, parse_result);
1134 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001135 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001136 const auto& cpp_constants = interface->GetConstantDeclarations();
1137 EXPECT_EQ((size_t)1, cpp_constants.size());
1138 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001139 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001140 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001141}
1142
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001144 io_delegate_.SetFileContents(
1145 "p/Outer.aidl",
1146 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001147 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001148 const string input_path = "p/IFoo.aidl";
1149 const string input = "package p; import p.Outer; interface IFoo"
1150 " { Outer.Inner get(); }";
1151
Devin Moore7b8d5c92020-03-17 14:14:08 -07001152 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1153 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001154
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001155 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001156 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001157 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1158 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001159}
1160
Devin Moore7b8d5c92020-03-17 14:14:08 -07001161TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001162 io_delegate_.SetFileContents(
1163 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001164 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001165 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001166 const string input_path = "p/IFoo.aidl";
1167 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001168 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1169 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001170 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001171 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1172 native_type.Resolve(typenames_);
1173
1174 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1175 // C++ understands C++ specific stuff
1176 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1177 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001178 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001179 EXPECT_EQ(1u, headers.size());
1180 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001181}
1182
Christopher Wileyf8136192016-04-12 14:19:35 -07001183TEST_F(AidlTest, WritesCorrectDependencyFile) {
1184 // While the in tree build system always gives us an output file name,
1185 // other android tools take advantage of our ability to infer the intended
1186 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001187 vector<string> args = {
1188 "aidl",
1189 "-d dep/file/path",
1190 "-o place/for/output",
1191 "p/IFoo.aidl"};
1192 Options options = Options::From(args);
1193 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001194 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001195 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001196 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001197 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1198}
1199
Dan Willemsen93298ee2016-11-10 23:55:55 -08001200TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1201 // While the in tree build system always gives us an output file name,
1202 // other android tools take advantage of our ability to infer the intended
1203 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001204 vector<string> args = {
1205 "aidl",
1206 "-d dep/file/path",
1207 "--ninja",
1208 "-o place/for/output",
1209 "p/IFoo.aidl"};
1210 Options options = Options::From(args);
1211 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001212 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001213 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001214 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001215 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1216}
1217
Jiyong Parkdf202122019-09-30 20:48:35 +09001218TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001219 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1220 // this by calling aidl with every .aidl file it finds, then parsing the
1221 // generated dependency files. Those that reference .java output files are
1222 // for interfaces and those that do not are parcelables. However, for both
1223 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001224 vector<string> args = {
1225 "aidl",
1226 "-o place/for/output",
1227 "-d dep/file/path",
1228 "p/Foo.aidl"};
1229 Options options = Options::From(args);
1230 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001231 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001232 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001233 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001234 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1235}
1236
1237TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1238 vector<string> args = {
1239 "aidl",
1240 "--structured",
1241 "-o place/for/output",
1242 "-d dep/file/path",
1243 "p/Foo.aidl"};
1244 Options options = Options::From(args);
1245 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1246 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1247 string actual_dep_file_contents;
1248 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1249 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001250}
1251
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001252TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1253 vector<string> args = {
1254 "aidl",
1255 "--lang=java",
1256 "-o place/for/output",
1257 "p/Foo.aidl"};
1258 Options options = Options::From(args);
1259 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1260 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1261 string output_file_contents;
1262 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1263}
1264
Devin Moore21b26772020-08-26 16:37:56 -07001265TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001266 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001267 const string list_array_parcelable =
1268 "package a; parcelable Foo {\n"
1269 " List[] lists; }";
1270 CaptureStderr();
1271 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1272 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1273}
1274
Jiyong Parkf8d53612020-05-04 14:06:13 +09001275TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1276 AidlError error;
1277 string expected_stderr =
1278 "ERROR: a/IFoo.aidl:2.7-11: "
1279 "Encountered an untyped List or Map. The use of untyped List/Map is "
1280 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1281 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1282 if (GetLanguage() != Options::Language::JAVA) {
1283 expected_stderr =
1284 "ERROR: a/IFoo.aidl:2.1-7: "
1285 "Currently, only the Java backend supports non-generic List.\n";
1286 }
1287
1288 const string primitive_interface =
1289 "package a; interface IFoo {\n"
1290 " List foo(); }";
1291 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001292 AidlTypenames tn1;
1293 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001294 {"--structured"}));
1295 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001296
1297 string primitive_parcelable =
1298 "package a; parcelable IFoo {\n"
1299 " List foo;}";
1300 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001301 AidlTypenames tn2;
1302 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001303 {"--structured"}));
1304 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1305}
1306
Jeongik Cha225519b2020-08-29 01:55:32 +09001307TEST_P(AidlTest, ExtensionTest) {
1308 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001309 string extendable_parcelable =
1310 "package a; parcelable Data {\n"
1311 " ParcelableHolder extension;\n"
1312 " ParcelableHolder extension2;\n"
1313 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001314 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001315 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1316 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001317 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001318 "yet.\n",
1319 GetCapturedStderr());
1320 } else {
1321 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1322 EXPECT_EQ("", GetCapturedStderr());
1323 }
1324}
1325TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1326 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001327 string parcelableholder_return_interface =
1328 "package a; interface IFoo {\n"
1329 " ParcelableHolder foo();\n"
1330 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(nullptr,
1332 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001333
Jeongik Cha8f02a532020-10-14 00:16:28 +09001334 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001335 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001336 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001337 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001338 "yet.\n",
1339 GetCapturedStderr());
1340 return;
1341 }
1342 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1343 GetCapturedStderr());
1344}
1345
1346TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1347 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001348 string extendable_parcelable_arg_interface =
1349 "package a; interface IFoo {\n"
1350 " void foo(in ParcelableHolder ph);\n"
1351 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001352 EXPECT_EQ(nullptr,
1353 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1354
Jeongik Cha8f02a532020-10-14 00:16:28 +09001355 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001356 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001357 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001358 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001359 "yet.\n",
1360 GetCapturedStderr());
1361 return;
1362 }
1363 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1364 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001365}
1366
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001367TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1368 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001369 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001370 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1371 CaptureStderr();
1372 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1373 if (GetLanguage() == Options::Language::RUST) {
1374 EXPECT_EQ(
1375 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1376 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1377 "yet.\n",
1378 GetCapturedStderr());
1379 return;
1380 }
1381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1382}
1383
Jooyung Han3f347ca2020-12-01 12:41:50 +09001384TEST_P(AidlTest, ParcelablesWithConstants) {
1385 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001386 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001387 CaptureStderr();
1388 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1389 EXPECT_EQ("", GetCapturedStderr());
1390}
1391
1392TEST_P(AidlTest, UnionWithConstants) {
1393 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001394 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001395 CaptureStderr();
1396 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1397 EXPECT_EQ("", GetCapturedStderr());
1398}
1399
Jooyung Han633eab62021-01-07 14:12:40 +09001400TEST_F(AidlTest, ConstantsWithAnnotations) {
1401 io_delegate_.SetFileContents("IFoo.aidl",
1402 "interface IFoo {\n"
1403 " @JavaPassthrough(annotation=\"@Foo\")\n"
1404 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1405 "}");
1406 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1407 CaptureStderr();
1408 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1409 EXPECT_EQ("", GetCapturedStderr());
1410 string code;
1411 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1412 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1413 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1414}
1415
Jiyong Park02da7422018-07-16 16:00:26 +09001416TEST_F(AidlTest, ApiDump) {
1417 io_delegate_.SetFileContents(
1418 "foo/bar/IFoo.aidl",
1419 "package foo.bar;\n"
1420 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001421 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001422 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001423 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001424 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1425 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1426 " IFoo foo3(IFoo foo);\n"
1427 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001428 " // @hide\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001429 " /** blahblah\n"
1430 " @deprecated\n"
1431 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001432 " const int A = 1;\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001433 " // @deprecated do not use\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001434 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001435 "}\n");
1436 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1437 "package foo.bar;\n"
1438 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001439 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001440 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001441 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001442 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001443 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001444 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001445 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001446 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001447 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001448 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001449 "}\n");
1450 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001451 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1452 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001453 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001454 bool result = dump_api(options, io_delegate_);
1455 ASSERT_TRUE(result);
1456 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001457 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001458 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001459/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001460interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001461 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001462 int foo(out int[] a, String b, boolean c, inout List<String> d);
1463 int foo2(@utf8InCpp String x, inout List<String> y);
1464 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1465 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001466 /* @hide */
Jooyung Han9fd67022021-01-13 10:49:48 +09001467 /* @deprecated reason why... */
Jiyong Parke59c3682018-09-11 23:10:25 +09001468 const int A = 1;
Jooyung Han9fd67022021-01-13 10:49:48 +09001469 /* @deprecated do not use */
Jiyong Parke59c3682018-09-11 23:10:25 +09001470 const String STR = "Hello";
1471}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001472)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001473
Jiyong Parke59c3682018-09-11 23:10:25 +09001474 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001475 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001476/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001477parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001478 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001479 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001480 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001481 int y;
1482 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001483 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001484 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001485}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001486)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001487}
1488
Jiyong Parked65bf42018-08-28 15:43:27 +09001489TEST_F(AidlTest, ApiDumpWithManualIds) {
1490 io_delegate_.SetFileContents(
1491 "foo/bar/IFoo.aidl",
1492 "package foo.bar;\n"
1493 "interface IFoo {\n"
1494 " int foo() = 1;\n"
1495 " int bar() = 2;\n"
1496 " int baz() = 10;\n"
1497 "}\n");
1498
Jiyong Parke59c3682018-09-11 23:10:25 +09001499 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001500 Options options = Options::From(args);
1501 bool result = dump_api(options, io_delegate_);
1502 ASSERT_TRUE(result);
1503 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001504 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001505 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001506interface IFoo {
1507 int foo() = 1;
1508 int bar() = 2;
1509 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001510}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001511)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001512}
1513
1514TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001515 const string expected_stderr =
1516 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1517 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001518 io_delegate_.SetFileContents(
1519 "foo/bar/IFoo.aidl",
1520 "package foo.bar;\n"
1521 "interface IFoo {\n"
1522 " int foo() = 1;\n"
1523 " int bar();\n"
1524 " int baz() = 10;\n"
1525 "}\n");
1526
Jiyong Parke59c3682018-09-11 23:10:25 +09001527 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001528 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001529 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001530 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001531 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001532}
1533
Jooyung Han965e31d2020-11-27 12:30:16 +09001534TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1535 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1536 "package foo.bar;\n"
1537 "interface IFoo {\n"
1538 " @utf8InCpp String foo();\n"
1539 " const @utf8InCpp String bar = \"bar\";\n"
1540 "}\n");
1541
1542 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1543 Options options = Options::From(args);
1544 CaptureStderr();
1545 EXPECT_TRUE(dump_api(options, io_delegate_));
1546 EXPECT_EQ("", GetCapturedStderr());
1547 string actual;
1548 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001549 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1550interface IFoo {
1551 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001552 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001553}
1554)"),
1555 actual);
1556}
1557
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001558TEST_F(AidlTest, ApiDumpWithEnums) {
1559 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1560 "package foo.bar;\n"
1561 "enum Enum {\n"
1562 " FOO,\n"
1563 " BAR = FOO + 1,\n"
1564 "}\n");
1565
1566 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1567 Options options = Options::From(args);
1568 CaptureStderr();
1569 EXPECT_TRUE(dump_api(options, io_delegate_));
1570 EXPECT_EQ("", GetCapturedStderr());
1571 string actual;
1572 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1573 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1574 "enum Enum {\n"
1575 " FOO = 0,\n"
1576 " BAR = 1,\n"
1577 "}\n"),
1578 actual);
1579}
1580
1581TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1582 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1583 "package foo.bar;\n"
1584 "enum Enum {\n"
1585 " FOO,\n"
1586 "}\n");
1587 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1588 "package foo.bar;\n"
1589 "import foo.bar.Enum;\n"
1590 "parcelable Foo {\n"
1591 " Enum e = Enum.FOO;\n"
1592 "}\n");
1593
1594 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1595 Options options = Options::From(args);
1596 CaptureStderr();
1597 EXPECT_TRUE(dump_api(options, io_delegate_));
1598 EXPECT_EQ("", GetCapturedStderr());
1599 string actual;
1600 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1601 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1602 "parcelable Foo {\n"
1603 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1604 "}\n"),
1605 actual);
1606}
1607
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001608TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001609 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001610 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1611 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001612 const string expected_map_stderr =
1613 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001614 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1615 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001616 "package p; interface IFoo {"
1617 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001618 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001619 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001620 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001621
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001622 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001623 "package p; interface IFoo {"
1624 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001625 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001626 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001627 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001628}
1629
Jeongik Chae48d9942020-01-02 17:39:00 +09001630TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001631 const string expected_stderr =
1632 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001633 Options options = Options::From("aidl -I p p/IFoo.aidl");
1634 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1635
1636 io_delegate_.SetFileContents("p/IFoo.aidl",
1637 "package p; interface IFoo {"
1638 "Map<String, Bar> foo();}");
1639 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1640
1641 io_delegate_.SetFileContents("p/IFoo.aidl",
1642 "package p; interface IFoo {"
1643 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001644 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001645 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001647
1648 io_delegate_.SetFileContents("p/IFoo.aidl",
1649 "package p; interface IFoo {"
1650 "Map<String, String> foo();}");
1651 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1652
1653 io_delegate_.SetFileContents("p/IFoo.aidl",
1654 "package p; interface IFoo {"
1655 "Map<String, ParcelFileDescriptor> foo();}");
1656 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1657}
1658
Jeongik Chadf76dc72019-11-28 00:08:47 +09001659TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001660 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001661 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1662 io_delegate_.SetFileContents(options.InputFiles().front(),
1663 "package p; interface IFoo {"
1664 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001665 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001666 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001667 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001668}
1669
1670TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1671 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1672 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001673 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001674 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001675 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1676 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677
1678 Options options = Options::From("aidl -I p p/IFoo.aidl");
1679 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1680 io_delegate_.SetFileContents("p/IFoo.aidl",
1681 "package p; interface IFoo {"
1682 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001683 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001684 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001685 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001687 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001688 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001689 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1690 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001691 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1692 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1693 io_delegate_.SetFileContents("p/IFoo.aidl",
1694 "package p; interface IFoo {"
1695 "Bar<String, ParcelFileDescriptor> foo();}");
1696 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001697
1698 io_delegate_.SetFileContents("p/IFoo.aidl",
1699 "package p; interface IFoo {"
1700 "Bar<int, long> foo();}");
1701
1702 io_delegate_.SetFileContents("p/IFoo.aidl",
1703 "package p; interface IFoo {"
1704 "Bar<int[], long[]> foo();}");
1705
1706 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001707}
1708
Jeongik Cha0e426012019-07-29 15:57:02 +09001709TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1710 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001711 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1712 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001713 for (const auto& rawOption : rawOptions) {
1714 string expected_stderr =
1715 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001716 Options options = Options::From(rawOption);
1717 io_delegate_.SetFileContents(options.InputFiles().front(),
1718 "package foo.bar;\n"
1719 "interface IFoo1 { int foo(); }\n"
1720 "interface IFoo2 { int foo(); }\n"
1721 "parcelable Data1 { int a; int b;}\n"
1722 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001723 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001724 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001725 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001726
Jeongik Cha0e426012019-07-29 15:57:02 +09001727 io_delegate_.SetFileContents(options.InputFiles().front(),
1728 "package foo.bar;\n"
1729 "interface IFoo1 { int foo(); }\n"
1730 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001731 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001732 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001733 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001734
Devin Moore5de18ed2020-04-02 13:52:29 -07001735 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001736 io_delegate_.SetFileContents(options.InputFiles().front(),
1737 "package foo.bar;\n"
1738 "parcelable Data1 { int a; int b;}\n"
1739 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001740 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001741 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001743 }
1744}
1745
Devin Moorebdba2a82020-03-31 15:19:02 -07001746TEST_P(AidlTest, FailParseOnEmptyFile) {
1747 const string contents = "";
1748 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1749 CaptureStderr();
1750 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1752}
1753
Jiyong Parkb034bf02018-07-30 17:44:33 +09001754TEST_F(AidlTest, MultipleInputFiles) {
1755 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001756 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001757
1758 io_delegate_.SetFileContents(options.InputFiles().at(0),
1759 "package foo.bar;\n"
1760 "import foo.bar.Data;\n"
1761 "interface IFoo { Data getData(); }\n");
1762
1763 io_delegate_.SetFileContents(options.InputFiles().at(1),
1764 "package foo.bar;\n"
1765 "import foo.bar.IFoo;\n"
1766 "parcelable Data { IFoo foo; }\n");
1767
1768 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1769
1770 string content;
1771 for (const auto file : {
1772 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1773 content.clear();
1774 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1775 EXPECT_FALSE(content.empty());
1776 }
1777}
1778
1779TEST_F(AidlTest, MultipleInputFilesCpp) {
1780 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001781 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001782
1783 io_delegate_.SetFileContents(options.InputFiles().at(0),
1784 "package foo.bar;\n"
1785 "import foo.bar.Data;\n"
1786 "interface IFoo { Data getData(); }\n");
1787
1788 io_delegate_.SetFileContents(options.InputFiles().at(1),
1789 "package foo.bar;\n"
1790 "import foo.bar.IFoo;\n"
1791 "parcelable Data { IFoo foo; }\n");
1792
1793 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1794
1795 string content;
1796 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001797 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001798 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1799 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1800 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1801 content.clear();
1802 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1803 EXPECT_FALSE(content.empty());
1804 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001805}
1806
Andrei Homescub62afd92020-05-11 19:24:59 -07001807TEST_F(AidlTest, MultipleInputFilesRust) {
1808 Options options =
1809 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1810
1811 io_delegate_.SetFileContents(options.InputFiles().at(0),
1812 "package foo.bar;\n"
1813 "import foo.bar.Data;\n"
1814 "interface IFoo { Data getData(); }\n");
1815
1816 io_delegate_.SetFileContents(options.InputFiles().at(1),
1817 "package foo.bar;\n"
1818 "import foo.bar.IFoo;\n"
1819 "parcelable Data { IFoo foo; }\n");
1820
1821 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1822
1823 string content;
1824 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1825 content.clear();
1826 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1827 EXPECT_FALSE(content.empty());
1828 }
1829}
1830
Devin Moore097a3ab2020-03-11 16:08:44 -07001831TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1832 const string expected_stderr =
1833 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001834 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1835 // int getInterfaceVersion() is one of the meta transactions
1836 io_delegate_.SetFileContents(options.InputFiles().front(),
1837 "package p; interface IFoo {"
1838 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001839 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001840 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001841 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1842}
Jiyong Park309668e2018-07-28 16:55:44 +09001843
Devin Moore097a3ab2020-03-11 16:08:44 -07001844TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1845 // boolean getInterfaceVersion() is not a meta transaction, but should be
1846 // prevented because return type is not part of a method signature
1847 const string expected_stderr =
1848 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1849 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001850 io_delegate_.SetFileContents(options.InputFiles().front(),
1851 "package p; interface IFoo {"
1852 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001853 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001854 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001855 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1856}
Jiyong Park309668e2018-07-28 16:55:44 +09001857
Devin Moore097a3ab2020-03-11 16:08:44 -07001858TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001859 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001860 const string expected_stderr =
1861 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1862 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001863 io_delegate_.SetFileContents(options.InputFiles().front(),
1864 "package p; interface IFoo {"
1865 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001866 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001867 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001869
1870 // this is not a meta interface method as it differs type arguments
1871 io_delegate_.SetFileContents(options.InputFiles().front(),
1872 "package p; interface IFoo {"
1873 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001874 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001875}
1876
Daniel Norman85aed542019-08-21 12:01:14 -07001877TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001878 Options options = Options::From("aidl --checkapi old new");
1879 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1880 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1881 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1882 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1883
1884 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1885}
1886
Jiyong Park3656c3c2018-08-01 20:02:01 +09001887TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001888 Options options = Options::From("aidl --checkapi old new");
1889 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1890 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001891
1892 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1893}
1894
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001895TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1896 Options options = Options::From("aidl --checkapi old new");
1897 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1898 const string enum_definition = "package p; enum Enum { FOO }";
1899 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1900 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1901 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1902 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1903
1904 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1905}
1906
Daniel Norman85aed542019-08-21 12:01:14 -07001907class AidlTestCompatibleChanges : public AidlTest {
1908 protected:
1909 Options options_ = Options::From("aidl --checkapi old new");
1910};
1911
1912TEST_F(AidlTestCompatibleChanges, NewType) {
1913 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1914 "package p;"
1915 "interface IFoo {"
1916 " void foo(int a);"
1917 "}");
1918 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1919 "package p;"
1920 "interface IFoo {"
1921 " void foo(int a);"
1922 "}");
1923 io_delegate_.SetFileContents("new/p/IBar.aidl",
1924 "package p;"
1925 "interface IBar {"
1926 " void bar();"
1927 "}");
1928 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1929}
1930
1931TEST_F(AidlTestCompatibleChanges, NewMethod) {
1932 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1933 "package p;"
1934 "interface IFoo {"
1935 " void foo(int a);"
1936 "}");
1937 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1938 "package p;"
1939 "interface IFoo {"
1940 " void foo(int a);"
1941 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001942 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001943 "}");
1944 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1945}
1946
1947TEST_F(AidlTestCompatibleChanges, NewField) {
1948 io_delegate_.SetFileContents("old/p/Data.aidl",
1949 "package p;"
1950 "parcelable Data {"
1951 " int foo;"
1952 "}");
1953 io_delegate_.SetFileContents("new/p/Data.aidl",
1954 "package p;"
1955 "parcelable Data {"
1956 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001957 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001958 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001959 "}");
1960 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1961}
1962
1963TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1964 io_delegate_.SetFileContents("old/p/Enum.aidl",
1965 "package p;"
1966 "enum Enum {"
1967 " FOO = 1,"
1968 "}");
1969 io_delegate_.SetFileContents("new/p/Enum.aidl",
1970 "package p;"
1971 "enum Enum {"
1972 " FOO = 1,"
1973 " BAR = 2,"
1974 "}");
1975 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1976}
1977
1978TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1979 io_delegate_.SetFileContents("old/p/Enum.aidl",
1980 "package p;"
1981 "enum Enum {"
1982 " FOO = 1,"
1983 " BAR = 2,"
1984 "}");
1985 io_delegate_.SetFileContents("new/p/Enum.aidl",
1986 "package p;"
1987 "enum Enum {"
1988 " BAR = 2,"
1989 " FOO = 1,"
1990 "}");
1991 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1992}
1993
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001994TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1995 io_delegate_.SetFileContents("old/p/Union.aidl",
1996 "package p;"
1997 "union Union {"
1998 " String foo;"
1999 "}");
2000 io_delegate_.SetFileContents("new/p/Union.aidl",
2001 "package p;"
2002 "union Union {"
2003 " String foo;"
2004 " int num;"
2005 "}");
2006 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2007}
2008
Daniel Norman85aed542019-08-21 12:01:14 -07002009TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002010 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2011 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002012 "interface IFoo {"
2013 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002014 "}");
2015 io_delegate_.SetFileContents("old/p/Data.aidl",
2016 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002017 "parcelable Data {"
2018 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002019 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002020 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2021 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002022 "interface IFoo {"
2023 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002024 "}");
2025 io_delegate_.SetFileContents("new/p/Data.aidl",
2026 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002027 "parcelable Data {"
2028 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002029 "}");
2030 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2031 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002032 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002033 " void foo(int a);"
2034 "}");
2035 io_delegate_.SetFileContents("new/q/Data.aidl",
2036 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002037 "parcelable Data {"
2038 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002039 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002040 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2041}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002042
Daniel Norman85aed542019-08-21 12:01:14 -07002043TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2044 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2045 "package p;"
2046 "interface IFoo {"
2047 " void foo(int a);"
2048 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002049 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2050 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002051 "interface IFoo {"
2052 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002053 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002054 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2055}
Jiyong Parke59c3682018-09-11 23:10:25 +09002056
Daniel Norman85aed542019-08-21 12:01:14 -07002057TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002058 io_delegate_.SetFileContents("old/p/I.aidl",
2059 "package p; interface I {"
2060 "const int A = 1; }");
2061 io_delegate_.SetFileContents("new/p/I.aidl",
2062 "package p ; interface I {"
2063 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002064 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2065}
Jiyong Parka428d212018-08-29 22:26:30 +09002066
Daniel Norman85aed542019-08-21 12:01:14 -07002067TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002068 io_delegate_.SetFileContents("old/p/I.aidl",
2069 "package p; interface I {"
2070 "const int A = 1; const int B = 2;}");
2071 io_delegate_.SetFileContents("new/p/I.aidl",
2072 "package p ; interface I {"
2073 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002074 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002075}
2076
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002077TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2078 io_delegate_.SetFileContents("old/p/Foo.aidl",
2079 "package p;"
2080 "@JavaPassthrough(annotation=\"Alice\")"
2081 "@JavaPassthrough(annotation=\"Bob\")"
2082 "parcelable Foo {}");
2083 io_delegate_.SetFileContents("new/p/Foo.aidl",
2084 "package p;"
2085 "@JavaPassthrough(annotation=\"Bob\")"
2086 "@JavaPassthrough(annotation=\"Alice\")"
2087 "parcelable Foo {}");
2088 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2089}
2090
Jooyung Han00073272020-11-27 14:20:20 +09002091TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2092 io_delegate_.SetFileContents("old/p/Foo.aidl",
2093 "package p;"
2094 "parcelable Foo {}");
2095 io_delegate_.SetFileContents("new/p/Foo.aidl",
2096 "package p;"
2097 "@JavaPassthrough(annotation=\"@Deprecated\")"
2098 "parcelable Foo {}");
2099 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2100}
2101
Jooyung Han636fd2f2020-10-22 11:33:45 +09002102TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2103 io_delegate_.SetFileContents("old/p/Data.aidl",
2104 "package p;"
2105 "parcelable Data {"
2106 " int num;"
2107 "}");
2108 io_delegate_.SetFileContents(
2109 "new/p/Data.aidl",
2110 "package p;"
2111 "parcelable Data {"
2112 " int num;"
2113 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2114 "}");
2115 io_delegate_.SetFileContents("new/p/Enum.aidl",
2116 "package p;"
2117 "enum Enum {"
2118 " FOO = 0,"
2119 " BAR = 1,"
2120 "}");
2121 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2122}
2123
Daniel Norman85aed542019-08-21 12:01:14 -07002124class AidlTestIncompatibleChanges : public AidlTest {
2125 protected:
2126 Options options_ = Options::From("aidl --checkapi old new");
2127};
2128
2129TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002130 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002131 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2132 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002133 "interface IFoo {"
2134 " void foo(in String[] str);"
2135 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002136 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002137 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002138 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002139 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002140}
2141
2142TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002143 const string expected_stderr =
2144 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002145 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2146 "package p;"
2147 "interface IFoo {"
2148 " void foo(in String[] str);"
2149 " void bar(@utf8InCpp String str);"
2150 "}");
2151 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2152 "package p;"
2153 "interface IFoo {"
2154 " void foo(in String[] str);"
2155 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002156 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002157 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002158 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002159}
2160
Jiyong Parkf8d53612020-05-04 14:06:13 +09002161TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2162 const string expected_stderr =
2163 "ERROR: new/p/IFoo.aidl:1.61-65: "
2164 "Encountered an untyped List or Map. The use of untyped List/Map is "
2165 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2166 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2167 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2168 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2169 "package p;"
2170 "interface IFoo {"
2171 " void foo(in String[] str);"
2172 "}");
2173 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2174 "package p;"
2175 "interface IFoo {"
2176 " void foo(in String[] str);"
2177 " void bar(in List arg);"
2178 "}");
2179 CaptureStderr();
2180 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2181 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2182}
2183
2184TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2185 const string expected_stderr =
2186 "ERROR: new/p/Data.aidl:1.54-59: "
2187 "Encountered an untyped List or Map. The use of untyped List/Map is "
2188 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2189 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2190 "ERROR: new/p/Data.aidl: Failed to read.\n";
2191 io_delegate_.SetFileContents("old/p/Data.aidl",
2192 "package p;"
2193 "parcelable Data {"
2194 " int foo;"
2195 "}");
2196 io_delegate_.SetFileContents("new/p/Data.aidl",
2197 "package p;"
2198 "parcelable Data {"
2199 " int foo;"
2200 " @nullable List list;"
2201 "}");
2202 CaptureStderr();
2203 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2204 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2205}
2206
Daniel Norman85aed542019-08-21 12:01:14 -07002207TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002208 const string expected_stderr =
2209 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002210 io_delegate_.SetFileContents("old/p/Data.aidl",
2211 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002212 "parcelable Data {"
2213 " int foo;"
2214 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002215 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002216 io_delegate_.SetFileContents("new/p/Data.aidl",
2217 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002218 "parcelable Data {"
2219 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002220 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002221 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002222 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002223 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002224}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002225
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002226TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2227 const string expected_stderr =
2228 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2229 "backends. Please either provide a default value for this field or mark the field as "
2230 "@nullable. This value or a null value will be used automatically when an old version of "
2231 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2232 "order to make sure your code continues to be backwards compatible, make sure the default or "
2233 "null value does not cause a semantic change to this parcelable.\n";
2234 io_delegate_.SetFileContents("old/p/Data.aidl",
2235 "package p;"
2236 "parcelable Data {"
2237 " int num;"
2238 "}");
2239 io_delegate_.SetFileContents("new/p/Data.aidl",
2240 "package p;"
2241 "parcelable Data {"
2242 " int num;"
2243 " String str;"
2244 "}");
2245 CaptureStderr();
2246 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2248}
2249
Jooyung Han636fd2f2020-10-22 11:33:45 +09002250TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2251 const string expected_stderr =
2252 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2253 "Please make sure 'Enum' has '0' as a valid value.\n";
2254 io_delegate_.SetFileContents("old/p/Data.aidl",
2255 "package p;"
2256 "parcelable Data {"
2257 " int num;"
2258 "}");
2259 io_delegate_.SetFileContents("new/p/Data.aidl",
2260 "package p;"
2261 "parcelable Data {"
2262 " int num;"
2263 " p.Enum e;"
2264 "}");
2265 io_delegate_.SetFileContents("new/p/Enum.aidl",
2266 "package p;"
2267 "enum Enum {"
2268 " FOO = 1,"
2269 " BAR = 2,"
2270 "}");
2271 CaptureStderr();
2272 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2274}
2275
Daniel Norman85aed542019-08-21 12:01:14 -07002276TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002277 const string expected_stderr =
2278 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002279 io_delegate_.SetFileContents("old/p/Enum.aidl",
2280 "package p;"
2281 "enum Enum {"
2282 " FOO = 1,"
2283 " BAR = 2,"
2284 "}");
2285 io_delegate_.SetFileContents("new/p/Enum.aidl",
2286 "package p;"
2287 "enum Enum {"
2288 " BAR = 2,"
2289 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002290 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002291 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002293}
2294
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002295TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2296 const string expected_stderr =
2297 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2298 io_delegate_.SetFileContents("old/p/Union.aidl",
2299 "package p;"
2300 "union Union {"
2301 " String str;"
2302 " int num;"
2303 "}");
2304 io_delegate_.SetFileContents("new/p/Union.aidl",
2305 "package p;"
2306 "union Union {"
2307 " String str;"
2308 "}");
2309 CaptureStderr();
2310 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2312}
2313
Daniel Norman85aed542019-08-21 12:01:14 -07002314TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002315 const string expected_stderr =
2316 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002317 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2318 "package p;"
2319 "interface IFoo {"
2320 " void foo(in String[] str);"
2321 " void bar(@utf8InCpp String str);"
2322 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002323 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2324 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002325 "interface IFoo {"
2326 " void foo(in String[] str);"
2327 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002328 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002330 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002332}
2333
Daniel Norman85aed542019-08-21 12:01:14 -07002334TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002335 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002336 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2337 "package p;"
2338 "interface IFoo {"
2339 " void foo(in String[] str);"
2340 " void bar(@utf8InCpp String str);"
2341 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002342 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2343 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002344 "interface IFoo2 {"
2345 " void foo(in String[] str);"
2346 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002347 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002348 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002349 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002350 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002351}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002352
Daniel Norman85aed542019-08-21 12:01:14 -07002353TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002354 const string expected_stderr =
2355 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002356 io_delegate_.SetFileContents("old/p/Enum.aidl",
2357 "package p;"
2358 "enum Enum {"
2359 " FOO = 1,"
2360 " BAR = 2,"
2361 "}");
2362 io_delegate_.SetFileContents("new/p/Enum.aidl",
2363 "package p;"
2364 "enum Enum {"
2365 " FOO = 3,"
2366 " BAR = 2,"
2367 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002368 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002369 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002370 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002371}
2372
2373TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 const string expected_stderr =
2375 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2376 "from 0 to 1.\n"
2377 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2378 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002379 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2380 "package p;"
2381 "interface IFoo {"
2382 " void foo(in String[] str);"
2383 " void bar(@utf8InCpp String str);"
2384 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002385 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2386 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002387 "interface IFoo {"
2388 " void bar(@utf8InCpp String str);"
2389 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002390 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002391 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002392 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002393 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002394}
2395
2396TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002397 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002398 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2399 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002400 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002401 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002402 "parcelable Data {"
2403 " int foo;"
2404 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002405 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002406 io_delegate_.SetFileContents("new/p/Data.aidl",
2407 "package p;"
2408 "parcelable Data {"
2409 " int bar;"
2410 " int foo;"
2411 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002412 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002413 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002415}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002416
Daniel Norman85aed542019-08-21 12:01:14 -07002417TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002418 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002419 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002420 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002421 "interface IFoo {"
2422 " void foo(in String[] str);"
2423 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002424 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002425 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2426 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002427 "interface IFoo {"
2428 " void foo(out String[] str);"
2429 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002430 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002431 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002432 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002433 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002434}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002435
Daniel Norman85aed542019-08-21 12:01:14 -07002436TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002437 const string expected_stderr =
2438 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002439 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2440 "package p;"
2441 "interface IFoo {"
2442 " void foo(in String[] str);"
2443 " void bar(@utf8InCpp String str);"
2444 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002445 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2446 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002447 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002448 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002449 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002450 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002451 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002452 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002454}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002455
Daniel Norman85aed542019-08-21 12:01:14 -07002456TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 const string expected_stderr =
2458 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002459 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2460 "package p;"
2461 "interface IFoo {"
2462 " void foo(in String[] str);"
2463 " void bar(@utf8InCpp String str);"
2464 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002465 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2466 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002467 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002468 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002469 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002470 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002471 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002472 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002473 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002474}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002475
Jooyung Han60b2fde2020-10-29 15:12:40 +09002476TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2477 const string expected_stderr =
2478 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2479 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2480 io_delegate_.SetFileContents("old/p/Foo.aidl",
2481 "package p;"
2482 "@Backing(type=\"byte\")"
2483 "enum Foo {"
2484 " FOO, BAR,"
2485 "}");
2486 io_delegate_.SetFileContents("new/p/Foo.aidl",
2487 "package p;"
2488 "@Backing(type=\"long\")"
2489 "enum Foo {"
2490 " FOO, BAR,"
2491 "}");
2492 CaptureStderr();
2493 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2494 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2495}
2496
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002497TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2498 const string expected_stderr =
2499 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2500 "to @JavaPassthrough(annotation=\"Bob\")\n";
2501 io_delegate_.SetFileContents("old/p/Foo.aidl",
2502 "package p;"
2503 "@JavaPassthrough(annotation=\"Alice\")"
2504 "parcelable Foo {}");
2505 io_delegate_.SetFileContents("new/p/Foo.aidl",
2506 "package p;"
2507 "@JavaPassthrough(annotation=\"Bob\")"
2508 "parcelable Foo {}");
2509
2510 CaptureStderr();
2511 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2512 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2513}
2514
Devin Mooredb7ac512020-08-07 11:17:36 -07002515TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2516 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002517 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002518 io_delegate_.SetFileContents("old/p/Foo.aidl",
2519 "package p;"
2520 "parcelable Foo {"
2521 " int A;"
2522 "}");
2523 io_delegate_.SetFileContents("new/p/Foo.aidl",
2524 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002525 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002526 " int A;"
2527 "}");
2528 CaptureStderr();
2529 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2530 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2531}
2532
2533TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2534 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002535 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002536 io_delegate_.SetFileContents("old/p/Foo.aidl",
2537 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002538 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002539 " int A;"
2540 "}");
2541 io_delegate_.SetFileContents("new/p/Foo.aidl",
2542 "package p;"
2543 "parcelable Foo {"
2544 " int A;"
2545 "}");
2546 CaptureStderr();
2547 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2548 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2549}
2550
Daniel Norman85aed542019-08-21 12:01:14 -07002551TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002552 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002553 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2554 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002555 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002556 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002557 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002558 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002559}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002560
Daniel Norman85aed542019-08-21 12:01:14 -07002561TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002562 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002563 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2564 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002566 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002568}
Jiyong Parka428d212018-08-29 22:26:30 +09002569
Daniel Norman85aed542019-08-21 12:01:14 -07002570TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002571 const string expected_stderr =
2572 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002573 io_delegate_.SetFileContents("old/p/I.aidl",
2574 "package p; interface I {"
2575 "const int A = 1; const int B = 2;}");
2576 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002578 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002580}
Jiyong Parka428d212018-08-29 22:26:30 +09002581
Daniel Norman85aed542019-08-21 12:01:14 -07002582TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002583 const string expected_stderr =
2584 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002585 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2586 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002587 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002588 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002589 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002590}
2591
Devin Moorec7e47a32020-08-07 10:55:25 -07002592TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2593 const string expected_stderr =
2594 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2595 "This is an incompatible change for FixedSize types.\n";
2596 io_delegate_.SetFileContents("old/p/Foo.aidl",
2597 "package p; @FixedSize parcelable Foo { int A = 1; }");
2598 io_delegate_.SetFileContents("new/p/Foo.aidl",
2599 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2600 CaptureStderr();
2601 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2602 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2603}
2604
2605TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2606 const string expected_stderr =
2607 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2608 io_delegate_.SetFileContents("old/p/Foo.aidl",
2609 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2610 io_delegate_.SetFileContents("new/p/Foo.aidl",
2611 "package p; @FixedSize parcelable Foo { int A = 1; }");
2612 CaptureStderr();
2613 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2614 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2615}
2616
2617TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2618 const string expected_stderr =
2619 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2620 "a.\n"
2621 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2622 "b.\n"
2623 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2624 "c.\n"
2625 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2626 "d.\n"
2627 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2628 "e.\n"
2629 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2630 "f.\n";
2631
2632 io_delegate_.SetFileContents("Foo.aidl",
2633 "@FixedSize parcelable Foo { "
2634 " int[] a;"
2635 " Bar b;"
2636 " String c;"
2637 " ParcelFileDescriptor d;"
2638 " IBinder e;"
2639 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002640 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002641 "}");
2642 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002643 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002644
2645 CaptureStderr();
2646 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2647 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2648}
2649
2650TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2651 const string expected_stderr = "";
2652
2653 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2654 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2655 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002656 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002657
2658 CaptureStderr();
2659 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2661}
2662
Jiyong Park8c380532018-08-30 14:55:26 +09002663TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002664 const string expected_stderr =
2665 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2666 "dir1/q/IBar.aidl\n"
2667 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002668 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002669 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2670 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2671 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2672 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2673
Devin Moore097a3ab2020-03-11 16:08:44 -07002674 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002675 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002676 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002677}
2678
Jiyong Parked65bf42018-08-28 15:43:27 +09002679TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002680 const string expected_stderr =
2681 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2682 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002683 Options options = Options::From("aidl --checkapi old new");
2684 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2685 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002686
2687 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2688
Jiyong Parke59c3682018-09-11 23:10:25 +09002689 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002690 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002691 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002692 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002693}
2694
Jiyong Parke05195e2018-10-08 18:24:23 +09002695TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2696 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2697 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002698 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002699
2700 // use without import
2701 io_delegate_.SetFileContents("p/IFoo.aidl",
2702 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2703 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2704 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002705 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002706
Devin Moore7b8d5c92020-03-17 14:14:08 -07002707 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002708 io_delegate_.SetFileContents(
2709 "p/IFoo.aidl",
2710 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2711 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2712 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002713 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002714
2715 // use with import (as before)
2716 io_delegate_.SetFileContents("p/IFoo.aidl",
2717 "package p;"
2718 "import android.os.ParcelFileDescriptor;"
2719 "interface IFoo{"
2720 " void foo(in ParcelFileDescriptor fd);"
2721 "}");
2722 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2723 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002724 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002725}
Jiyong Parked65bf42018-08-28 15:43:27 +09002726
Jiyong Park3633b722019-04-11 15:38:26 +09002727TEST_F(AidlTest, ManualIds) {
2728 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2729 io_delegate_.SetFileContents("IFoo.aidl",
2730 "interface IFoo {\n"
2731 " void foo() = 0;\n"
2732 " void bar() = 1;\n"
2733 "}");
2734 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2735}
2736
2737TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2738 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2739 io_delegate_.SetFileContents("IFoo.aidl",
2740 "interface IFoo {\n"
2741 " void foo() = 0;\n"
2742 " void bar() = 1;\n"
2743 "}");
2744 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2745}
2746
2747TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002748 const string expected_stderr =
2749 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002750 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2751 io_delegate_.SetFileContents("IFoo.aidl",
2752 "interface IFoo {\n"
2753 " void foo() = 3;\n"
2754 " void bar() = 3;\n"
2755 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002756 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002757 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002758 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002759}
2760
2761TEST_F(AidlTest, FailOnOutOfRangeIds) {
2762 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002763 const string expected_stderr =
2764 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2765 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002766 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2767 io_delegate_.SetFileContents("IFoo.aidl",
2768 "interface IFoo {\n"
2769 " void foo() = 3;\n"
2770 " void bar() = 16777115;\n"
2771 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002772 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002773 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002774 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002775}
2776
2777TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002778 const string expected_stderr =
2779 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002780 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2781 io_delegate_.SetFileContents("IFoo.aidl",
2782 "interface IFoo {\n"
2783 " void foo() = 3;\n"
2784 " void bar();\n"
2785 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002786 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002787 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002788 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002789}
2790
Jiyong Parkc6816252019-07-08 08:12:28 +09002791TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2792 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2793 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2794 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2795 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2796}
2797
2798TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002799 const string expected_stderr =
2800 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2801 "dir/IBar.aidl\n"
2802 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002803 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002804
Jiyong Parkc6816252019-07-08 08:12:28 +09002805 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2806 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2807 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2808 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002809 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002810 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002811 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002812}
2813
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002814TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2815 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2816 "package a.b;\n"
2817 "import a.b.IBar;\n"
2818 "import a.b.IQux;\n"
2819 "interface IFoo { IQux foo(); }\n");
2820 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2821 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2822
2823 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2824 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2825
2826 string output;
2827 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2828 // IBar was imported but wasn't used. include is not expected.
2829 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2830 // IBar was imported and used. include is expected.
2831 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2832}
2833
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002834TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002835 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002836 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002837 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2838 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002839 interface IFoo {
2840 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002841 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002842 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002843 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002844 // JavaPassthrough should work with other types as well (e.g. enum)
2845 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2846 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2847 @JavaPassthrough(annotation="@com.android.AliceTwo")
2848 @Backing(type="byte")
2849 enum MyEnum {
2850 a, b, c
2851 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002852
Jooyung Han4cde01d2020-10-13 11:10:47 +09002853 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002854 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2855
2856 string java_out;
2857 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002858 // type-decl-level annotations with newline at the end
2859 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2860 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2861 // member-decl-level annotations with newline at the end
2862 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2863 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2864 // inline annotations with space at the end
2865 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002866
Jooyung Han4cde01d2020-10-13 11:10:47 +09002867 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2868 // type-decl-level annotations with newline at the end
2869 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2870 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2871
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002872 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002873 Options cpp_options =
2874 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002875 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2876
Jooyung Han4cde01d2020-10-13 11:10:47 +09002877 Options ndk_options =
2878 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002879 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002880
Jooyung Han4cde01d2020-10-13 11:10:47 +09002881 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002882 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002883}
2884
Andrei Homescue61feb52020-08-18 15:44:24 -07002885TEST_F(AidlTest, ParseRustDerive) {
2886 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2887 @RustDerive(Clone=true, Copy=false)
2888 parcelable Foo {
2889 int a;
2890 })");
2891
2892 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2893 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2894
2895 string rust_out;
2896 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2897 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2898
2899 // Other backends shouldn't be bothered
2900 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2901 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2902
2903 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2904 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2905
2906 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2907 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2908}
2909
Jiyong Park56f73d72019-06-11 12:20:28 +09002910class AidlOutputPathTest : public AidlTest {
2911 protected:
2912 void SetUp() override {
2913 AidlTest::SetUp();
2914 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2915 }
2916
2917 void Test(const Options& options, const std::string expected_output_path) {
2918 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2919 // check the existence
2920 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2921 }
2922};
2923
2924TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2925 // <out_dir> / <package_name> / <type_name>.java
2926 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2927}
2928
2929TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2930 // when output file is explicitly set, it is always respected. -o option is
2931 // ignored.
2932 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2933}
2934
2935TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2936 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2937}
2938
2939TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2940 // output is the same as the input file except for the suffix
2941 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2942}
2943
Devin Moore7b8d5c92020-03-17 14:14:08 -07002944TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002945 AidlError error;
2946 const string expected_stderr =
2947 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2948 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002949 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2950 R"(package p;
2951 interface IFoo {
2952 const int int32_max_oob = 2147483650;
2953 }
2954 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002955 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002956 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2957 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002958}
2959
Devin Moore7b8d5c92020-03-17 14:14:08 -07002960TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002961 AidlError error;
2962 const string expected_stderr =
2963 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2964 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002965 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2966 R"(package p;
2967 interface IFoo {
2968 const int int32_min_oob = -2147483650;
2969 }
2970 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002971 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002972 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2973 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002974}
2975
Devin Moore7b8d5c92020-03-17 14:14:08 -07002976TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002977 AidlError error;
2978 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002979 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002980 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002981 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2982 R"(package p;
2983 interface IFoo {
2984 const long int64_max_oob = 21474836509999999999999999;
2985 }
2986 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002987 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002988 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2989 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002990}
2991
Devin Moore7b8d5c92020-03-17 14:14:08 -07002992TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 AidlError error;
2994 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002995 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002996 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002997 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2998 R"(package p;
2999 interface IFoo {
3000 const long int64_min_oob = -21474836509999999999999999;
3001 }
3002 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003003 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3005 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003006}
3007
Devin Moore7b8d5c92020-03-17 14:14:08 -07003008TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003010 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003011 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003012 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3013 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003014 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3015 R"(package p;
3016 @Backing(type="byte")
3017 enum TestEnum {
3018 FOO = 127,
3019 BAR,
3020 }
3021 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003022 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003023 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003024 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003025}
3026
Devin Mooredecaf292020-04-30 09:16:40 -07003027TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3028 AidlError error;
3029 const string expected_stderr =
3030 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003031 "be one of: type\n";
3032 CaptureStderr();
3033 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3034 R"(package p;
3035 @Backing(foo="byte")
3036 enum TestEnum {
3037 FOO = 1,
3038 BAR,
3039 }
3040 )",
3041 typenames_, GetLanguage(), &error));
3042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3043 EXPECT_EQ(AidlError::BAD_TYPE, error);
3044}
3045
Jooyung Han5721a232020-12-24 04:34:55 +09003046TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3047 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3048 CaptureStderr();
3049 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3050 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3051}
3052
Jooyung Han66813932020-10-23 13:24:44 +09003053TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003054 io_delegate_.SetFileContents("Foo.aidl",
3055 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3056 "Map<String, Baz> d; Bar[] e; }");
3057 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3058 io_delegate_.SetFileContents("Baz.aidl",
3059 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003060 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3061 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3062}
3063
Jooyung Han66813932020-10-23 13:24:44 +09003064TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003065 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003066 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003067 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003068 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3069 "named 'bar'.\n";
3070 CaptureStderr();
3071 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3072 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3073 EXPECT_EQ(expected_error, GetCapturedStderr());
3074}
3075
3076TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3077 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3078 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3079 string expected_error =
3080 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003081 "named 'bar'.\n";
3082 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003083 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3084 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003085 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003086}
3087
Jooyung Han66813932020-10-23 13:24:44 +09003088TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003089 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003090 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3091 string expected_error =
3092 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3093 "only be an in parameter.\n";
3094 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003095 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3096 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003097 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003098}
3099
Jooyung Han66813932020-10-23 13:24:44 +09003100TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003101 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003102 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3103 string expected_error =
3104 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3105 "only be an in parameter.\n";
3106 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003107 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3108 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003109 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003110}
3111
Jooyung Han66813932020-10-23 13:24:44 +09003112TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003113 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003114 Options options = Options::From("aidl --lang=java Foo.aidl");
3115 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003116 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3117 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003118 CaptureStderr();
3119 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3120 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3121}
Devin Moore53fc99c2020-08-12 08:07:52 -07003122
Jooyung Hanfe89f122020-10-14 03:49:18 +09003123TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3124 const string method = "package a; union Foo {}";
3125 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3126 CaptureStderr();
3127 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3128 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3129}
3130
3131TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3132 const string method = "package a; union Foo { ParcelableHolder x; }";
3133 const string expected_stderr =
3134 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3135 CaptureStderr();
3136 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3137 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3138}
3139
Jooyung Han53fb4242020-12-17 16:03:49 +09003140TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3141 import_paths_.insert(".");
3142 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3143 const string expected_err = "The union's first member should have a useful default value.";
3144 CaptureStderr();
3145 EXPECT_EQ(nullptr,
3146 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3147 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3148}
3149
Devin Moore53fc99c2020-08-12 08:07:52 -07003150TEST_P(AidlTest, GenericStructuredParcelable) {
3151 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003152 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003153 const string expected_stderr = "";
3154 CaptureStderr();
3155 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3156 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3157}
3158
Jooyung Han3f347ca2020-12-01 12:41:50 +09003159TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3160 io_delegate_.SetFileContents("Foo.aidl",
3161 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3162 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003163 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003164 const string expected_stderr = "";
3165 CaptureStderr();
3166 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3167 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3168
3169 string code;
3170 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3171 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3172const ::android::String16& Foo<T,U>::s() {
3173 static const ::android::String16 value(::android::String16(""));
3174 return value;
3175})--"));
3176}
3177
3178TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3179 io_delegate_.SetFileContents("Foo.aidl",
3180 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3181 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003182 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003183 const string expected_stderr = "";
3184 CaptureStderr();
3185 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3186 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3187
3188 string code;
3189 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3190 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3191const char* Foo<T, U>::s = "";
3192)--"));
3193}
3194
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003195TEST_F(AidlTest, NestedTypeArgs) {
3196 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003197 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3198
3199 io_delegate_.SetFileContents("a/Foo.aidl",
3200 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3201 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003202 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3203 const string expected_stderr = "";
3204 CaptureStderr();
3205 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3207
3208 string code;
3209 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003210 EXPECT_THAT(code,
3211 testing::HasSubstr(
3212 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3213}
3214
3215TEST_F(AidlTest, DoubleArrayError) {
3216 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3217
3218 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3219 const string expected_stderr =
3220 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3221 CaptureStderr();
3222 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3223 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3224}
3225
3226TEST_F(AidlTest, DoubleGenericError) {
3227 io_delegate_.SetFileContents("a/Bar.aidl",
3228 "package a; parcelable Bar { List<String><String> a; }");
3229
3230 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3231 const string expected_stderr =
3232 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3233 CaptureStderr();
3234 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3235 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3236}
3237
3238TEST_F(AidlTest, ArrayBeforeGenericError) {
3239 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3240
3241 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3242 const string expected_stderr =
3243 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3244 CaptureStderr();
3245 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3246 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003247}
3248
Jooyung Han14004ed2020-10-16 03:49:57 +09003249struct GenericAidlTest : ::testing::Test {
3250 FakeIoDelegate io_delegate_;
3251 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003252 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003253 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3254 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3255 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3256
3257 Options options = Options::From(cmd);
3258 CaptureStderr();
3259 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3260 EXPECT_EQ("", GetCapturedStderr());
3261 }
3262};
3263
3264TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3265 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3266 string code;
3267 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3268 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3269 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3270 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3271}
3272
3273TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3274 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3275 string code;
3276 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3277 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3278 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3279 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3280}
3281
Devin Moore53fc99c2020-08-12 08:07:52 -07003282TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3283 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003284 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003285 const string expected_stderr =
3286 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3287 CaptureStderr();
3288 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3290}
3291
3292TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3293 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003294 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003295 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3296 CaptureStderr();
3297 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3298 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3299}
3300
Jooyung Han7a308842020-10-27 19:06:49 +09003301TEST_P(AidlTest, LongCommentWithinConstExpression) {
3302 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003303 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003304 CaptureStderr();
3305 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3306 EXPECT_EQ("", GetCapturedStderr());
3307}
3308
Jeongik Chaef44e622020-10-23 16:00:52 +09003309TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3310 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3311 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3312 std::string expectedErr =
3313 "ERROR: a/Foo.aidl:1.28-30: "
3314 "Encountered an untyped List or Map. The use of untyped List/Map is "
3315 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3316 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3317 "ERROR: a/Foo.aidl:1.35-37: "
3318 "Encountered an untyped List or Map. The use of untyped List/Map is "
3319 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3320 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3321 CaptureStderr();
3322 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3323 EXPECT_EQ(expectedErr, GetCapturedStderr());
3324}
3325
3326TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003327 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3328 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003329 std::string expectedErr =
3330 "ERROR: a/Foo.aidl:1.33-35: "
3331 "Encountered an untyped List or Map. The use of untyped List/Map is "
3332 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3333 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3334 "ERROR: a/Foo.aidl:1.40-42: "
3335 "Encountered an untyped List or Map. The use of untyped List/Map is "
3336 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3337 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003338 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003339 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3340 EXPECT_EQ(expectedErr, GetCapturedStderr());
3341}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003342
Jeongik Chaef44e622020-10-23 16:00:52 +09003343TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3344 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3345 io_delegate_.SetFileContents(
3346 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3347 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3348 std::string expectedErr =
3349 "ERROR: a/Foo.aidl:1.52-54: "
3350 "Encountered an untyped List or Map. The use of untyped List/Map is "
3351 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3352 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3353 "ERROR: a/Foo.aidl:1.64-66: "
3354 "Encountered an untyped List or Map. The use of untyped List/Map is "
3355 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3356 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3357 CaptureStderr();
3358 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3359 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003360}
3361
Jooyung Han690f5842020-12-04 13:02:04 +09003362TEST_F(AidlTest, EnumWithDefaults_Java) {
3363 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3364 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3365package p;
3366import p.Enum;
3367parcelable Foo {
3368 Enum e = Enum.BAR;
3369})");
3370 CaptureStderr();
3371 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3372 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3373 auto err = GetCapturedStderr();
3374 EXPECT_EQ("", err);
3375
3376 string code;
3377 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003378 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003379}
3380
3381TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3382 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3383 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3384package p;
3385import p.Enum;
3386parcelable Foo {
3387 Enum e = Enum.BAR;
3388})");
3389 CaptureStderr();
3390 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3391 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3392 auto err = GetCapturedStderr();
3393 EXPECT_EQ("", err);
3394
3395 string code;
3396 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3397 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3398}
3399
3400TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3401 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3402 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3403package p;
3404import p.Enum;
3405parcelable Foo {
3406 Enum e = Enum.BAR;
3407})");
3408 CaptureStderr();
3409 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3410 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3411 auto err = GetCapturedStderr();
3412 EXPECT_EQ("", err);
3413
3414 string code;
3415 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3416 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3417}
3418
3419TEST_F(AidlTest, EnumWithDefaults_Rust) {
3420 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3421 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3422package p;
3423import p.Enum;
3424parcelable Foo {
3425 int n = 42;
3426 Enum e = Enum.BAR;
3427})");
3428 CaptureStderr();
3429 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3430 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3431 auto err = GetCapturedStderr();
3432 EXPECT_EQ("", err);
3433
3434 string code;
3435 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3436 EXPECT_THAT(code, testing::HasSubstr(R"(
3437 fn default() -> Self {
3438 Self {
3439 n: 42,
3440 e: crate::mangled::_1_p_4_Enum::BAR,
3441 }
3442 })"));
3443}
3444
3445TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3446 import_paths_.insert("a");
3447 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3448 CaptureStderr();
3449 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3450package p;
3451import p.Enum;
3452parcelable Foo {
3453 int e = Enum.FOO | Enum.BAR;
3454})",
3455 typenames_, GetLanguage());
3456 auto err = GetCapturedStderr();
3457 EXPECT_EQ("", err);
3458 EXPECT_TRUE(type);
3459 const auto& fields = type->AsStructuredParcelable()->GetFields();
3460 EXPECT_EQ("int e = 3", fields[0]->ToString());
3461}
3462
3463TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3464 CaptureStderr();
3465 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3466@Backing(type="int")
3467enum Foo {
3468 STANDARD_SHIFT = 16,
3469 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3470 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3471}
3472)",
3473 typenames_, GetLanguage());
3474 auto err = GetCapturedStderr();
3475 EXPECT_EQ("", err);
3476 EXPECT_TRUE(type);
3477 const auto& enum_type = type->AsEnumDeclaration();
3478 string code;
3479 enum_type->Dump(CodeWriter::ForString(&code).get());
3480 EXPECT_EQ(R"--(@Backing(type="int")
3481enum Foo {
3482 STANDARD_SHIFT = 16,
3483 STANDARD_BT709 = 65536,
3484 STANDARD_BT601_625 = 131072,
3485}
3486)--",
3487 code);
3488}
3489
3490TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3491 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3492 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3493package p;
3494import p.Enum;
3495parcelable Foo {
3496 Enum e = Enum.FOO | Enum.BAR;
3497})");
3498 CaptureStderr();
3499 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3500 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3501 auto err = GetCapturedStderr();
3502 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3503 err);
3504}
3505
3506TEST_P(AidlTest, DefaultWithEmptyArray) {
3507 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3508 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3509 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003510 auto options =
3511 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003512 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3513 auto err = GetCapturedStderr();
3514 EXPECT_EQ("", err);
3515}
3516
3517TEST_P(AidlTest, RejectRefsInAnnotation) {
3518 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3519 "package p; interface IFoo {\n"
3520 " const String ANNOTATION = \"@Annotation\";\n"
3521 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3522 "}");
3523 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003524 auto options =
3525 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003526 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3527 auto err = GetCapturedStderr();
3528 EXPECT_EQ(
3529 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3530 "ANNOTATION.\n",
3531 err);
3532}
3533
3534TEST_F(AidlTest, DefaultWithEnumValues) {
3535 io_delegate_.SetFileContents(
3536 "a/p/Foo.aidl",
3537 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3538 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3539 CaptureStderr();
3540 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3541 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3542 auto err = GetCapturedStderr();
3543 EXPECT_EQ("", err);
3544 string code;
3545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3546 EXPECT_THAT(
3547 code, testing::HasSubstr(
3548 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3549}
3550
Jooyung Han14259392020-12-07 10:00:08 +09003551TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3552 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3553 CaptureStderr();
3554 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3555 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3556 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003557 EXPECT_EQ(
3558 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3559 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3560 err);
Jooyung Han14259392020-12-07 10:00:08 +09003561}
3562
3563TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3564 io_delegate_.SetFileContents("a/p/Foo.aidl",
3565 "package p; parcelable Foo { const int A = A + 1; }");
3566 CaptureStderr();
3567 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3568 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3569 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003570 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3571}
3572
3573TEST_F(AidlTest, RecursiveReferences) {
3574 io_delegate_.SetFileContents("a/p/Foo.aidl",
3575 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3576 io_delegate_.SetFileContents("a/p/Bar.aidl",
3577 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3578 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3579 CaptureStderr();
3580 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3581 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3582 EXPECT_EQ("", GetCapturedStderr());
3583}
3584
Jooyung Hane9f5b272021-01-07 00:18:11 +09003585TEST_P(AidlTest, UnknownConstReference) {
3586 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3587 auto options =
3588 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3589 const string err =
3590 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3591 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3592 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3593 CaptureStderr();
3594 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3595 EXPECT_EQ(err, GetCapturedStderr());
3596}
3597
Jooyung Han29813842020-12-08 01:28:03 +09003598TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3599 string contents = R"(
3600import android.os.IBinder;
3601import android.os.IInterface;
3602interface IFoo {}
3603 )";
3604 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003605}
3606
Jooyung Han888c5bc2020-12-22 17:28:47 +09003607TEST_P(AidlTest, WarningInterfaceName) {
3608 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003609 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003610 " -Weverything -o out -h out p/Foo.aidl");
3611 CaptureStderr();
3612 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003613 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003614 GetCapturedStderr());
3615}
3616
3617TEST_P(AidlTest, ErrorInterfaceName) {
3618 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003619 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003620 " -Weverything -Werror -o out -h out p/Foo.aidl");
3621 CaptureStderr();
3622 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003623 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003624 GetCapturedStderr());
3625}
3626
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003627TEST_F(AidlTest, HideIsNotForArgs) {
3628 io_delegate_.SetFileContents("IFoo.aidl",
3629 "interface IFoo {\n"
3630 " void foo(in @Hide int x);\n"
3631 "}");
3632 auto options = Options::From("aidl --lang=java IFoo.aidl");
3633 CaptureStderr();
3634 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3635 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3636}
3637
3638TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3639 io_delegate_.SetFileContents(
3640 "IFoo.aidl",
3641 "interface IFoo {\n"
3642 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3643 "}");
3644 auto options = Options::From("aidl --lang=java IFoo.aidl");
3645 CaptureStderr();
3646 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3647 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3648}
3649
Jooyung Hanfd3be322020-12-13 09:11:06 +09003650struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003651 string kind;
3652 string literal;
3653};
3654
Jooyung Hanfd3be322020-12-13 09:11:06 +09003655const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003656 {"primitive", "int"}, {"String", "String"},
3657 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3658 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3659 {"union", "a.Union"}, {"interface", "a.IBar"},
3660};
3661
3662const std::map<std::string, std::string> kListSupportExpectations = {
3663 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3664 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3665 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3666 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
3667 {"cpp_String", ""},
3668 {"java_String", ""},
3669 {"ndk_String", ""},
3670 {"rust_String", ""},
3671 {"cpp_IBinder", ""},
3672 {"java_IBinder", ""},
3673 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3674 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003675 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003676 {"java_ParcelFileDescriptor", ""},
3677 {"ndk_ParcelFileDescriptor", ""},
3678 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003679 {"cpp_interface", "List<a.IBar> is not supported."},
3680 {"java_interface", "List<a.IBar> is not supported."},
3681 {"ndk_interface", "List<a.IBar> is not supported."},
3682 {"rust_interface", "List<a.IBar> is not supported."},
3683 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003684 {"java_parcelable", ""},
3685 {"ndk_parcelable", ""},
3686 {"rust_parcelable", ""},
3687 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3688 {"java_enum", "A generic type cannot have any primitive type parameters."},
3689 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3690 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003691 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003692 {"java_union", ""},
3693 {"ndk_union", ""},
3694 {"rust_union", ""},
3695};
3696
Jooyung Hand236e552020-12-13 09:21:27 +09003697const std::map<std::string, std::string> kArraySupportExpectations = {
3698 {"cpp_primitive", ""},
3699 {"java_primitive", ""},
3700 {"ndk_primitive", ""},
3701 {"rust_primitive", ""},
3702 {"cpp_String", ""},
3703 {"java_String", ""},
3704 {"ndk_String", ""},
3705 {"rust_String", ""},
3706 {"cpp_IBinder", ""},
3707 {"java_IBinder", ""},
3708 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3709 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3710 {"cpp_ParcelFileDescriptor", ""},
3711 {"java_ParcelFileDescriptor", ""},
3712 {"ndk_ParcelFileDescriptor", ""},
3713 {"rust_ParcelFileDescriptor", ""},
3714 {"cpp_interface", "Binder type cannot be an array"},
3715 {"java_interface", "Binder type cannot be an array"},
3716 {"ndk_interface", "Binder type cannot be an array"},
3717 {"rust_interface", "Binder type cannot be an array"},
3718 {"cpp_parcelable", ""},
3719 {"java_parcelable", ""},
3720 {"ndk_parcelable", ""},
3721 {"rust_parcelable", ""},
3722 {"cpp_enum", ""},
3723 {"java_enum", ""},
3724 {"ndk_enum", ""},
3725 {"rust_enum", ""},
3726 {"cpp_union", ""},
3727 {"java_union", ""},
3728 {"ndk_union", ""},
3729 {"rust_union", ""},
3730};
3731
Jooyung Hanfd3be322020-12-13 09:11:06 +09003732class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003733 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003734 void Run(const std::string& generic_type_decl,
3735 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003736 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003737 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003738 const auto& kind = std::get<1>(param).kind;
3739
3740 FakeIoDelegate io;
3741 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3742 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3743 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003744 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3745 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003746
3747 const auto options =
3748 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3749 CaptureStderr();
3750 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003751 auto it = expectations.find(lang + "_" + kind);
3752 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003753 const string err = GetCapturedStderr();
3754 if (it->second.empty()) {
3755 EXPECT_EQ("", err);
3756 } else {
3757 EXPECT_THAT(err, testing::HasSubstr(it->second));
3758 }
3759 }
3760};
3761
3762INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003763 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003764 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3765 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003766 testing::ValuesIn(kTypeParams)),
3767 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003768 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003769 });
3770
Jooyung Hanfd3be322020-12-13 09:11:06 +09003771TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3772 Run("List<{}>", kListSupportExpectations);
3773}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003774
Jooyung Hand236e552020-12-13 09:21:27 +09003775TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3776 Run("{}[]", kArraySupportExpectations);
3777}
3778
Christopher Wiley90be4e32015-10-20 14:55:25 -07003779} // namespace aidl
3780} // namespace android