blob: 408bee89ca520ef14343c60dbf21191caffa5436 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Christopher Wileyf8136192016-04-12 14:19:35 -070081} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070082
Devin Moore7b8d5c92020-03-17 14:14:08 -070083class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070084 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090085 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
86 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070087 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070088 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090089 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070090 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090091 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 for (const string& s : additional_arguments) {
93 args.emplace_back(s);
94 }
95 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090096 args.emplace_back("--preprocessed=" + f);
97 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -070098 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--include=" + i);
100 }
101 args.emplace_back(path);
102 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900103 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900104 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700105 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900106 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900107
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 if (error != nullptr) {
109 *error = actual_error;
110 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900111
112 if (actual_error != AidlError::OK) {
113 return nullptr;
114 }
115
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900116 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900117 EXPECT_EQ(1ul, defined_types.size());
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700120 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700121
Devin Moore7b8d5c92020-03-17 14:14:08 -0700122 Options::Language GetLanguage() { return GetParam(); }
123
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800125 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900126 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900127 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700128};
129
Devin Moore7b8d5c92020-03-17 14:14:08 -0700130// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
131// tests with each of the supported languages as a parameter.
132INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
133 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700134 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900136 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 });
138
139TEST_P(AidlTest, AcceptMissingPackage) {
140 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700141}
142
Devin Moore7b8d5c92020-03-17 14:14:08 -0700143TEST_P(AidlTest, EndsInSingleLineComment) {
144 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700145}
146
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000147TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
148 const string expected_stderr =
149 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
150 const std::string file_contents = "package a; interface IBar {}";
151 CaptureStderr();
152 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
153 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
154}
155
156TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
157 const string expected_stderr =
158 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
159 const std::string file_contents = "package a; interface Bar {}";
160 CaptureStderr();
161 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
162 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
163}
164
165TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
166 const string expected_stderr =
167 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
168 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
169 CaptureStderr();
170 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
171 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
172}
173
174TEST_P(AidlTest, EnumRequiresCorrectPath) {
175 const string expected_stderr =
176 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
177 const std::string file_contents = "package a; enum Bar { A, }";
178 CaptureStderr();
179 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
180 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
181}
182
Devin Moore7b8d5c92020-03-17 14:14:08 -0700183TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900184 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700185 io_delegate_.SetFileContents("bar/IBar.aidl",
186 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700187 const string path = "foo/IFoo.aidl";
188 const string contents =
189 "package foo;\n"
190 "import bar.IBar;\n"
191 "interface IFoo { void f(in IBar[] input); }";
192 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
193 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700194 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700195 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700196}
197
Devin Moore7b8d5c92020-03-17 14:14:08 -0700198TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700199 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900201}
Devin Moore097a3ab2020-03-11 16:08:44 -0700202
Jiyong Park40782d02020-07-24 19:17:43 +0900203TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
205 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900206 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
207 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700208 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700209 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900211}
212
Jiyong Park40782d02020-07-24 19:17:43 +0900213TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700214 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
215 const string expected_stderr =
216 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 CaptureStderr();
218 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
219 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900220}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700221
Jiyong Park40782d02020-07-24 19:17:43 +0900222TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700223 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900224 const string expected_stderr =
225 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700226 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700227 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700229}
230
Devin Moore7b8d5c92020-03-17 14:14:08 -0700231TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700232 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
233 const string expected_stderr =
234 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
235 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700238}
239
Devin Moore7b8d5c92020-03-17 14:14:08 -0700240TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700241 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
242 const string expected_stderr =
243 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
244 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800247}
248
Devin Moore2f2077a2020-08-28 11:27:53 -0700249TEST_P(AidlTest, AcceptNullableList) {
250 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
251 const string expected_stderr = "";
252 CaptureStderr();
253 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
254 EXPECT_EQ(expected_stderr, GetCapturedStderr());
255}
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700258 const string method = "package a; interface IFoo { void f(int a, int a); }";
259 const string expected_stderr =
260 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
261 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700264}
265
Jeongik Cha13066da2020-08-06 15:43:19 +0900266TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
267 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900268 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
272}
273
Jooyung Hand902a972020-10-23 17:32:44 +0900274TEST_P(AidlTest, RejectsRepeatedAnnotations) {
275 const string method = R"(@Hide @Hide parcelable Foo {})";
276 const string expected_stderr =
277 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
278 "Foo.aidl:1.1-6\n";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
282}
283
Devin Moore7b8d5c92020-03-17 14:14:08 -0700284TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700285 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
286 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
287 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700288 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100290}
291
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 AidlError error;
294 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900297 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700298 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800299}
300
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 AidlError error;
303 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700307 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 AidlError error;
312 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700313 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000314 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000321 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700322 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700325 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800326}
327
Jiyong Park40782d02020-07-24 19:17:43 +0900328TEST_P(AidlTest, ParsesNonNullableAnnotation) {
329 auto parse_result =
330 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
331 ASSERT_NE(nullptr, parse_result);
332 const AidlInterface* interface = parse_result->AsInterface();
333 ASSERT_NE(nullptr, interface);
334 ASSERT_FALSE(interface->GetMethods().empty());
335 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
336}
337
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900339 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
340 typenames_, GetLanguage());
341 ASSERT_NE(nullptr, parse_result);
342 const AidlInterface* interface = parse_result->AsInterface();
343 ASSERT_NE(nullptr, interface);
344 ASSERT_FALSE(interface->GetMethods().empty());
345 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
346}
347
348TEST_P(AidlTest, ParsesNonUtf8Annotations) {
349 auto parse_result =
350 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
351 ASSERT_NE(nullptr, parse_result);
352 const AidlInterface* interface = parse_result->AsInterface();
353 ASSERT_NE(nullptr, interface);
354 ASSERT_FALSE(interface->GetMethods().empty());
355 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900359 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
360 typenames_, GetLanguage());
361 ASSERT_NE(nullptr, parse_result);
362 const AidlInterface* interface = parse_result->AsInterface();
363 ASSERT_NE(nullptr, interface);
364 ASSERT_FALSE(interface->GetMethods().empty());
365 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700369 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700370 const string expected_stderr =
371 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
372 "\"vintf\"'\n"
373 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
374 "--structured\n";
375 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700376 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700377 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700379 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700380}
381
Devin Moore7b8d5c92020-03-17 14:14:08 -0700382TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700383 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700384 const string expected_stderr =
385 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
386 "--structured\n";
387 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700391 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392}
393
Devin Moore7b8d5c92020-03-17 14:14:08 -0700394TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700395 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 const string expected_stderr =
397 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
398 "\"vintf\"'\n";
399 CaptureStderr();
400 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700401 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700403 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700407 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
409 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700410 ASSERT_EQ(AidlError::OK, error);
411 ASSERT_NE(nullptr, parse_result);
412 const AidlInterface* interface = parse_result->AsInterface();
413 ASSERT_NE(nullptr, interface);
414 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700415}
416
Jeongik Cha64783ed2019-06-07 18:30:54 +0900417TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
418 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900419 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
420 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900421 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700422 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900423 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900424 "a/Foo.aidl",
425 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900426
427 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900428 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700429 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900430 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700431 "Parcelable must be defined in AIDL directly.\n";
432 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900433 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700435
436 CaptureStderr();
437 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900439}
440
Jooyung Han1cbc4962020-10-25 10:07:15 +0900441TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
442 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
443 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
444 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900445 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
446
447 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900448 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900449 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
450
451 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900452 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900453 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
454
Jooyung Han1cbc4962020-10-25 10:07:15 +0900455 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900456 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
457}
458
Jooyung Han1cbc4962020-10-25 10:07:15 +0900459TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
460 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
461 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
462 CaptureStderr();
463 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
464 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
465 EXPECT_EQ("", GetCapturedStderr());
466
467 const string expected_to_string_method = R"--(
468 @Override
469 public String toString() {
470 switch (_tag) {
471 case a: return "a.Foo.a(" + (getA()) + ")";
472 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
473 }
474 throw new IllegalStateException("unknown field: " + _tag);
475 }
476)--";
477
478 string java_out;
479 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
480 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
481}
482
Jiyong Park9aa3d042020-12-04 23:30:02 +0900483TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
484 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
485 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
486 CaptureStderr();
487 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
488 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
489 EXPECT_EQ("", GetCapturedStderr());
490
491 const std::string expected = R"--(
492 @Override
493 public boolean equals(Object other) {
494 if (this == other) return true;
495 if (other == null) return false;
496 if (!(other instanceof Foo)) return false;
497 Foo that = (Foo)other;
498 if (!java.util.Objects.deepEquals(a, that.a)) return false;
499 if (!java.util.Objects.deepEquals(b, that.b)) return false;
500 return true;
501 }
502
503 @Override
504 public int hashCode() {
505 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
506 }
507)--";
508
509 string java_out;
510 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
511 EXPECT_THAT(java_out, testing::HasSubstr(expected));
512}
513
514TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
515 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
516 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
517 CaptureStderr();
518 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
519 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
520 EXPECT_EQ("", GetCapturedStderr());
521
522 const std::string expected = R"--(
523 @Override
524 public boolean equals(Object other) {
525 if (this == other) return true;
526 if (other == null) return false;
527 if (!(other instanceof Foo)) return false;
528 Foo that = (Foo)other;
529 if (_tag != that._tag) return false;
530 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
531 return true;
532 }
533
534 @Override
535 public int hashCode() {
536 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
537 }
538)--";
539
540 string java_out;
541 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
542 EXPECT_THAT(java_out, testing::HasSubstr(expected));
543}
544
Jooyung Han90345002020-10-23 15:28:53 +0900545TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900546 {
Jooyung Han90345002020-10-23 15:28:53 +0900547 io_delegate_.SetFileContents("a/Foo.aidl",
548 "package a; @JavaDerive(blah=true) parcelable Foo{}");
549 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
550 CaptureStderr();
551 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
552 const std::string expected_stderr =
553 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900554 EXPECT_THAT(GetCapturedStderr(),
555 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900556 }
557
558 {
559 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900560 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
561 CaptureStderr();
562 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900563 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900564 }
565
566 {
Jooyung Han90345002020-10-23 15:28:53 +0900567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900571 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900572 }
573}
574
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900575TEST_P(AidlTest, ParseDescriptorAnnotation) {
576 AidlError error;
577 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
578 typenames_, GetLanguage(), &error, {"--structured"});
579 ASSERT_EQ(AidlError::OK, error);
580 ASSERT_NE(nullptr, parse_result);
581 const AidlInterface* interface = parse_result->AsInterface();
582 ASSERT_NE(nullptr, interface);
583 ASSERT_EQ("IBar", interface->GetDescriptor());
584}
585
Jiyong Park40782d02020-07-24 19:17:43 +0900586TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700587 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700588 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900589}
590
591TEST_P(AidlTest, AcceptsOnewayInterface) {
592 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700593 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700594}
Christopher Wileyef140932015-11-03 09:29:19 -0800595
Devin Moore7b8d5c92020-03-17 14:14:08 -0700596TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700597 const string oneway_method =
598 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700599 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100600}
601
Steven Moreland65297cc2020-04-20 20:17:36 -0700602TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
603 const string oneway_method =
604 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
605 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
606 ASSERT_NE(nullptr, defined);
607 const AidlInterface* iface = defined->AsInterface();
608 ASSERT_NE(nullptr, iface);
609
610 const auto& methods = iface->GetMethods();
611 ASSERT_EQ(1u, methods.size());
612 const auto& method = methods[0];
613 const AidlTypeSpecifier& ret_type = method->GetType();
614
615 // TODO(b/151102494): these annotations should be on the method
616 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
617 ASSERT_TRUE(ret_type.IsHide());
618}
619
Devin Moore7b8d5c92020-03-17 14:14:08 -0700620TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100621 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900622 R"(package a;
623 /* foo */
624 interface IFoo {
625 /* i */
626 int i();
627 // j
628 @nullable String j();
629 // k1
630 /* k2 */
631 @UnsupportedAppUsage oneway void k(int a);
632 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100633
Jooyung Han8451a202021-01-16 03:07:06 +0900634 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700635 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100636 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900637 EXPECT_EQ("", GetCapturedStderr());
638
639 EXPECT_EQ((Comments{{Comment::Type::BLOCK, "/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100640
641 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han8451a202021-01-16 03:07:06 +0900642 EXPECT_EQ((Comments{{Comment::Type::BLOCK, "/* i */"}}),
643 interface->GetMethods()[0]->GetComments());
644 EXPECT_EQ((Comments{{Comment::Type::LINE, "// j\n"}}), interface->GetMethods()[1]->GetComments());
645 EXPECT_EQ((Comments{{Comment::Type::LINE, "// k1\n"}, {Comment::Type::BLOCK, "/* k2 */"}}),
646 interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100647}
648
Jooyung Han1a551d32020-10-05 15:37:26 +0900649TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
650 io_delegate_.SetFileContents("p/cpp_header.aidl",
651 R"(package p;
652 parcelable cpp_header cpp_header "bar/header";)");
653 import_paths_.emplace("");
654 const string input_path = "p/IFoo.aidl";
655 const string input = R"(package p;
656 import p.cpp_header;
657 interface IFoo {
658 // get bar
659 cpp_header get();
660 })";
661
662 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
663 EXPECT_NE(nullptr, parse_result);
664 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han8451a202021-01-16 03:07:06 +0900665 EXPECT_EQ((Comments{{Comment::Type::LINE, "// get bar\n"}}),
666 interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900667}
668
Christopher Wileyef140932015-11-03 09:29:19 -0800669TEST_F(AidlTest, ParsesPreprocessedFile) {
670 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
671 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700672 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900673 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700674 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
675 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800676}
677
678TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
679 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
680 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900681
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700682 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900683 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700684 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
685 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800686}
687
Devin Moore7b8d5c92020-03-17 14:14:08 -0700688TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800689 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
690 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
691 "interface IBar {}");
692 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900693 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900694 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700695 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800696 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900697
Christopher Wiley41544372015-11-03 14:52:29 -0800698 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700699 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
700 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800701 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900702 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900703 ambiguous_type.Resolve(typenames_);
704 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800705}
706
Jiyong Park8f6ec462020-01-19 20:52:47 +0900707// Special case of PreferImportToPreprocessed. Imported type should be preferred
708// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700709TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900710 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
711 io_delegate_.SetFileContents("one/IBar.aidl",
712 "package one; "
713 "interface IBar {}");
714 preprocessed_files_.push_back("preprocessed");
715 import_paths_.emplace("");
716 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700717 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900718 EXPECT_NE(nullptr, parse_result);
719
720 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700721 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
722 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900723 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900724 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900725 ambiguous_type.Resolve(typenames_);
726 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
727}
728
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800729TEST_F(AidlTest, WritePreprocessedFile) {
730 io_delegate_.SetFileContents("p/Outer.aidl",
731 "package p; parcelable Outer.Inner;");
732 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
733 "interface IBar {}");
734
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900735 vector<string> args {
736 "aidl",
737 "--preprocess",
738 "preprocessed",
739 "p/Outer.aidl",
740 "one/IBar.aidl"};
741 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800742 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
743
744 string output;
745 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
746 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
747}
748
Jooyung Han720253d2021-01-05 19:13:17 +0900749TEST_P(AidlTest, SupportDeprecated) {
750 struct TestCase {
751 std::string output_file;
752 std::string annotation;
753 };
754
755 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900756 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900757 io_delegate_.SetFileContents(filename, contents);
758
759 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
760 " --out=out --header_out=out");
761 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900762 for (const auto& [lang, test_case] : expectations) {
763 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900764 string output;
765 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output))
766 << base::Join(io_delegate_.ListOutputFiles(), ",");
767 EXPECT_THAT(output, HasSubstr(test_case.annotation));
768 }
769 };
770
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900771 // Emit escaped string for notes
772 CheckDeprecated(
773 "IFoo.aidl",
774 R"(interface IFoo {
775 /**
776 * @note asdf
777 * @deprecated a really long deprecation message
778 *
779 * which is really long
780 * @param foo bar
781 */
782 List<String> foo();
783 })",
784 {
785 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
786 {Options::Language::CPP,
787 {"out/IFoo.h",
788 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
789 {Options::Language::NDK,
790 {"out/aidl/IFoo.h",
791 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
792 {Options::Language::RUST,
793 {"out/IFoo.rs",
794 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
795 });
796
Jooyung Han24effbf2021-01-16 10:24:03 +0900797 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900798 CheckDeprecated(
799 "IFoo.aidl",
800 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900801 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900802 " List<String> foo();\n"
803 "}",
804 {
805 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
806 // TODO(b/177276893) @deprecated should be in javadoc style comments
807 // {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
808 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
809 {Options::Language::NDK,
810 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
811 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
812 });
Jooyung Han720253d2021-01-05 19:13:17 +0900813
Jooyung Han24effbf2021-01-16 10:24:03 +0900814 // but not in line comments
815 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
816 EXPECT_FALSE(parsed->IsDeprecated());
817
818 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900819 CheckDeprecated("Foo.aidl",
820 "parcelable Foo {\n"
821 " /** @deprecated use bar*/\n"
822 " int foo = 0;\n"
823 "}",
824 {
825 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
826 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
827 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
828 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
829 });
830
Jooyung Han24effbf2021-01-16 10:24:03 +0900831 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900832 CheckDeprecated("IFoo.aidl",
833 "interface IFoo {\n"
834 " /** @deprecated use bar*/\n"
835 " const int FOO = 0;\n"
836 "}",
837 {
838 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
839 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
840 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
841 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
842 });
843
844 // union fields
845 CheckDeprecated("Foo.aidl",
846 "union Foo {\n"
847 " int bar = 0;\n"
848 " /** @deprecated use bar*/\n"
849 " int foo;\n"
850 "}",
851 {
852 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
853 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
854 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
855 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
856 });
857
858 CheckDeprecated("Foo.aidl",
859 "/** @deprecated use Bar */\n"
860 "parcelable Foo {}",
861 {
862 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
863 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
864 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
865 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
866 });
867
868 CheckDeprecated("Foo.aidl",
869 "/** @deprecated use Bar */\n"
870 "union Foo { int foo = 0; }",
871 {
872 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
873 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
874 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
875 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
876 });
877
878 CheckDeprecated("IFoo.aidl",
879 "/** @deprecated use IBar */\n"
880 "interface IFoo {}",
881 {
882 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
883 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
884 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
885 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
886 });
887
888 CheckDeprecated("Foo.aidl",
889 "/** @deprecated use IBar */\n"
890 "enum Foo { FOO }",
891 {
892 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
893 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
894 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
895 // TODO(b/174514415) support "deprecated"
896 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
897 });
898}
899
Devin Moore7b8d5c92020-03-17 14:14:08 -0700900TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800902 io_delegate_.SetFileContents("p/Outer.aidl",
903 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900904 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700905 CaptureStderr();
906 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
907 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700908 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800910}
911
Devin Moore7b8d5c92020-03-17 14:14:08 -0700912TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800913 io_delegate_.SetFileContents("preprocessed",
914 "parcelable p.Outer.Inner;");
915 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900916 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700917 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800918 // TODO(wiley): This should actually return nullptr because we require
919 // the outer class name. However, for legacy reasons,
920 // this behavior must be maintained. b/17415692
921 EXPECT_NE(nullptr, parse_result);
922}
923
Christopher Wiley632801d2015-11-05 14:15:49 -0800924TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700925 const string expected_foo_stderr =
926 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
927 "Declared parcelables should be in their own file and/or cannot be used with --structured "
928 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700929 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
930
Christopher Wiley632801d2015-11-05 14:15:49 -0800931 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700932 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700933 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900934 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700935 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900936
Steven Morelande2c64b42018-09-18 15:06:37 -0700937 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900938 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700939 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900940 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700942
Devin Moore097a3ab2020-03-11 16:08:44 -0700943 const string expected_bar_stderr =
944 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
945 "Declared parcelables should be in their own file and/or cannot be used with --structured "
946 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700947 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
948
Jiyong Parkda8c6932019-08-12 19:56:08 +0900949 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700950 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900952 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700954 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700955 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700956 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700957 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800958}
959
Devin Moore7b8d5c92020-03-17 14:14:08 -0700960TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700961 const string expected_stderr =
962 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
963 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700964 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
965 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 AidlError error;
967 CaptureStderr();
968 EXPECT_EQ(
969 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700970 Parse("p/IFoo.aidl",
971 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700972 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700973 EXPECT_EQ(expected_stderr, GetCapturedStderr());
974 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700975}
976
Devin Moore7b8d5c92020-03-17 14:14:08 -0700977TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 AidlError error;
979 const string expected_stderr =
980 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
981 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900982 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
983 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700984 interface IFoo {
985 const String DUPLICATED = "d";
986 const int DUPLICATED = 1;
987 }
988 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700989 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
991 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700992}
993
Steven Morelande689da22020-11-10 02:06:30 +0000994TEST_P(AidlTest, FailOnTooBigConstant) {
995 AidlError error;
996 const string expected_stderr =
997 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
998 CaptureStderr();
999 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1000 R"(package p;
1001 interface IFoo {
1002 const byte type2small = 256;
1003 }
1004 )",
1005 typenames_, GetLanguage(), &error));
1006 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1007 EXPECT_EQ(AidlError::BAD_TYPE, error);
1008}
1009
Jooyung Han30f64ad2020-12-15 08:16:31 +09001010TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1011 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1012 CaptureStderr();
1013 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1014 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1015 EXPECT_EQ("", GetCapturedStderr());
1016 string code;
1017 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1018 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1019}
1020
Jooyung Han535c5e82020-12-29 15:16:59 +09001021TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001022 using Ptr = unique_ptr<AidlConstantValue>;
1023 const AidlLocation& loc = AIDL_LOCATION_HERE;
1024
Jooyung Han535c5e82020-12-29 15:16:59 +09001025 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1026 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1027 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1028 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001029
1030 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1031 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001032 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001033
1034 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1035 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1036 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1037 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001038 EXPECT_EQ(
1039 expected,
1040 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001041}
1042
Devin Moore7b8d5c92020-03-17 14:14:08 -07001043TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001044 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001045 const string expected_stderr =
1046 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001047 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001048 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1049 R"(package p;
1050 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001051 parcelable IBar {}
1052 parcelable StructuredParcelable {}
1053 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001054 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001055 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001057 // Parse success is important for clear error handling even if the cases aren't
1058 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001059 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001060}
1061
Devin Moore7b8d5c92020-03-17 14:14:08 -07001062TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001063 AidlError error;
1064 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1065 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001066 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001067 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1068 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001069}
1070
Steven Morelandf9e922f2020-07-08 21:15:27 +00001071TEST_P(AidlTest, FailOnEmptyListWithComma) {
1072 AidlError error;
1073 const string expected_stderr =
1074 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1075 CaptureStderr();
1076 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1077 typenames_, GetLanguage(), &error));
1078 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1079 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1080}
1081
Devin Moore7b8d5c92020-03-17 14:14:08 -07001082TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001083 AidlError error;
1084 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001085 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001086 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001087 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1088 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001089 interface IFoo {
1090 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1091 }
1092 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001093 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001094 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1095 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001096}
1097
Jiyong Park18132182020-06-08 20:24:40 +09001098TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1099 AidlError error;
1100 const string expected_stderr =
1101 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1102 "cpp_header (which can also be used as an identifier)\n";
1103 CaptureStderr();
1104 // Notice the trailing dot(.) in the name, which isn't a correct name
1105 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1106 GetLanguage(), &error));
1107 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1108 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1109}
1110
1111TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1112 AidlError error;
1113 const string expected_stderr =
1114 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1115 "cpp_header (which can also be used as an identifier)\n";
1116 CaptureStderr();
1117 // Notice the trailing dot(.) in the package name
1118 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1119 GetLanguage(), &error));
1120 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1121 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1122}
1123
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001125 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001126 auto parse_result = Parse("p/IFoo.aidl",
1127 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001128 interface IFoo {
1129 const int POSITIVE_HEX_VALUE = 0xf5;
1130 }
1131 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001132 typenames_, GetLanguage(), &error);
1133 EXPECT_NE(nullptr, parse_result);
1134 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001135 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001136 const auto& cpp_constants = interface->GetConstantDeclarations();
1137 EXPECT_EQ((size_t)1, cpp_constants.size());
1138 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001139 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001140 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001141}
1142
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001144 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 auto parse_result = Parse("p/IFoo.aidl",
1146 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001147 interface IFoo {
1148 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1149 }
1150 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001151 typenames_, GetLanguage(), &error);
1152 ASSERT_NE(nullptr, parse_result);
1153 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001154 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001155 const auto& cpp_constants = interface->GetConstantDeclarations();
1156 EXPECT_EQ((size_t)1, cpp_constants.size());
1157 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001158 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001159 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001160}
1161
Devin Moore7b8d5c92020-03-17 14:14:08 -07001162TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001163 io_delegate_.SetFileContents(
1164 "p/Outer.aidl",
1165 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001166 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001167 const string input_path = "p/IFoo.aidl";
1168 const string input = "package p; import p.Outer; interface IFoo"
1169 " { Outer.Inner get(); }";
1170
Devin Moore7b8d5c92020-03-17 14:14:08 -07001171 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1172 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001173
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001174 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001175 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001176 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001177 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001178}
1179
Devin Moore7b8d5c92020-03-17 14:14:08 -07001180TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001181 io_delegate_.SetFileContents(
1182 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001183 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001184 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001185 const string input_path = "p/IFoo.aidl";
1186 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001187 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1188 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001189 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001190 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001191 native_type.Resolve(typenames_);
1192
1193 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1194 // C++ understands C++ specific stuff
1195 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1196 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001197 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001198 EXPECT_EQ(1u, headers.size());
1199 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001200}
1201
Christopher Wileyf8136192016-04-12 14:19:35 -07001202TEST_F(AidlTest, WritesCorrectDependencyFile) {
1203 // While the in tree build system always gives us an output file name,
1204 // other android tools take advantage of our ability to infer the intended
1205 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001206 vector<string> args = {
1207 "aidl",
1208 "-d dep/file/path",
1209 "-o place/for/output",
1210 "p/IFoo.aidl"};
1211 Options options = Options::From(args);
1212 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001213 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001214 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001215 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001216 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1217}
1218
Dan Willemsen93298ee2016-11-10 23:55:55 -08001219TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1220 // While the in tree build system always gives us an output file name,
1221 // other android tools take advantage of our ability to infer the intended
1222 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001223 vector<string> args = {
1224 "aidl",
1225 "-d dep/file/path",
1226 "--ninja",
1227 "-o place/for/output",
1228 "p/IFoo.aidl"};
1229 Options options = Options::From(args);
1230 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001231 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001232 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001233 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001234 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1235}
1236
Jiyong Parkdf202122019-09-30 20:48:35 +09001237TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001238 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1239 // this by calling aidl with every .aidl file it finds, then parsing the
1240 // generated dependency files. Those that reference .java output files are
1241 // for interfaces and those that do not are parcelables. However, for both
1242 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001243 vector<string> args = {
1244 "aidl",
1245 "-o place/for/output",
1246 "-d dep/file/path",
1247 "p/Foo.aidl"};
1248 Options options = Options::From(args);
1249 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001250 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001251 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001252 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001253 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1254}
1255
1256TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1257 vector<string> args = {
1258 "aidl",
1259 "--structured",
1260 "-o place/for/output",
1261 "-d dep/file/path",
1262 "p/Foo.aidl"};
1263 Options options = Options::From(args);
1264 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1265 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1266 string actual_dep_file_contents;
1267 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1268 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001269}
1270
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001271TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1272 vector<string> args = {
1273 "aidl",
1274 "--lang=java",
1275 "-o place/for/output",
1276 "p/Foo.aidl"};
1277 Options options = Options::From(args);
1278 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1279 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1280 string output_file_contents;
1281 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1282}
1283
Devin Moore21b26772020-08-26 16:37:56 -07001284TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001285 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001286 const string list_array_parcelable =
1287 "package a; parcelable Foo {\n"
1288 " List[] lists; }";
1289 CaptureStderr();
1290 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1292}
1293
Jiyong Parkf8d53612020-05-04 14:06:13 +09001294TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1295 AidlError error;
1296 string expected_stderr =
1297 "ERROR: a/IFoo.aidl:2.7-11: "
1298 "Encountered an untyped List or Map. The use of untyped List/Map is "
1299 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1300 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1301 if (GetLanguage() != Options::Language::JAVA) {
1302 expected_stderr =
1303 "ERROR: a/IFoo.aidl:2.1-7: "
1304 "Currently, only the Java backend supports non-generic List.\n";
1305 }
1306
1307 const string primitive_interface =
1308 "package a; interface IFoo {\n"
1309 " List foo(); }";
1310 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001311 AidlTypenames tn1;
1312 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001313 {"--structured"}));
1314 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001315
1316 string primitive_parcelable =
1317 "package a; parcelable IFoo {\n"
1318 " List foo;}";
1319 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001320 AidlTypenames tn2;
1321 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001322 {"--structured"}));
1323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1324}
1325
Jeongik Cha225519b2020-08-29 01:55:32 +09001326TEST_P(AidlTest, ExtensionTest) {
1327 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001328 string extendable_parcelable =
1329 "package a; parcelable Data {\n"
1330 " ParcelableHolder extension;\n"
1331 " ParcelableHolder extension2;\n"
1332 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001333 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001334 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1335 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001336 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001337 "yet.\n",
1338 GetCapturedStderr());
1339 } else {
1340 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1341 EXPECT_EQ("", GetCapturedStderr());
1342 }
1343}
1344TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1345 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001346 string parcelableholder_return_interface =
1347 "package a; interface IFoo {\n"
1348 " ParcelableHolder foo();\n"
1349 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001350 EXPECT_EQ(nullptr,
1351 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001352
Jeongik Cha8f02a532020-10-14 00:16:28 +09001353 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001354 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001355 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001356 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001357 "yet.\n",
1358 GetCapturedStderr());
1359 return;
1360 }
1361 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1362 GetCapturedStderr());
1363}
1364
1365TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1366 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001367 string extendable_parcelable_arg_interface =
1368 "package a; interface IFoo {\n"
1369 " void foo(in ParcelableHolder ph);\n"
1370 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001371 EXPECT_EQ(nullptr,
1372 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1373
Jeongik Cha8f02a532020-10-14 00:16:28 +09001374 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001375 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001376 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001377 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001378 "yet.\n",
1379 GetCapturedStderr());
1380 return;
1381 }
1382 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1383 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001384}
1385
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001386TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1387 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001388 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001389 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1390 CaptureStderr();
1391 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1392 if (GetLanguage() == Options::Language::RUST) {
1393 EXPECT_EQ(
1394 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1395 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1396 "yet.\n",
1397 GetCapturedStderr());
1398 return;
1399 }
1400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1401}
1402
Jooyung Han3f347ca2020-12-01 12:41:50 +09001403TEST_P(AidlTest, ParcelablesWithConstants) {
1404 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001405 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001406 CaptureStderr();
1407 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1408 EXPECT_EQ("", GetCapturedStderr());
1409}
1410
1411TEST_P(AidlTest, UnionWithConstants) {
1412 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001413 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001414 CaptureStderr();
1415 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1416 EXPECT_EQ("", GetCapturedStderr());
1417}
1418
Jooyung Han633eab62021-01-07 14:12:40 +09001419TEST_F(AidlTest, ConstantsWithAnnotations) {
1420 io_delegate_.SetFileContents("IFoo.aidl",
1421 "interface IFoo {\n"
1422 " @JavaPassthrough(annotation=\"@Foo\")\n"
1423 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1424 "}");
1425 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1426 CaptureStderr();
1427 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1428 EXPECT_EQ("", GetCapturedStderr());
1429 string code;
1430 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1431 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1432 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1433}
1434
Jiyong Park02da7422018-07-16 16:00:26 +09001435TEST_F(AidlTest, ApiDump) {
1436 io_delegate_.SetFileContents(
1437 "foo/bar/IFoo.aidl",
1438 "package foo.bar;\n"
1439 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001440 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001441 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001442 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001443 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1444 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1445 " IFoo foo3(IFoo foo);\n"
1446 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001447 " // @hide\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001448 " /** blahblah\n"
1449 " @deprecated\n"
1450 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001451 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001452 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001453 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001454 "}\n");
1455 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1456 "package foo.bar;\n"
1457 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001458 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001459 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001460 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001461 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001462 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001463 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001464 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001465 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001466 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001467 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001468 "}\n");
1469 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001470 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1471 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001472 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001473 bool result = dump_api(options, io_delegate_);
1474 ASSERT_TRUE(result);
1475 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001476 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001477 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001478interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001479 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001480 int foo(out int[] a, String b, boolean c, inout List<String> d);
1481 int foo2(@utf8InCpp String x, inout List<String> y);
1482 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1483 foo.bar.Data getData();
Jooyung Han9fd67022021-01-13 10:49:48 +09001484 /* @deprecated reason why... */
Jiyong Parke59c3682018-09-11 23:10:25 +09001485 const int A = 1;
1486 const String STR = "Hello";
1487}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001488)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001489
Jiyong Parke59c3682018-09-11 23:10:25 +09001490 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001491 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001492/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001493parcelable Data {
1494 int x = 10;
1495 int y;
1496 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001497 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001498}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001499)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001500}
1501
Jiyong Parked65bf42018-08-28 15:43:27 +09001502TEST_F(AidlTest, ApiDumpWithManualIds) {
1503 io_delegate_.SetFileContents(
1504 "foo/bar/IFoo.aidl",
1505 "package foo.bar;\n"
1506 "interface IFoo {\n"
1507 " int foo() = 1;\n"
1508 " int bar() = 2;\n"
1509 " int baz() = 10;\n"
1510 "}\n");
1511
Jiyong Parke59c3682018-09-11 23:10:25 +09001512 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001513 Options options = Options::From(args);
1514 bool result = dump_api(options, io_delegate_);
1515 ASSERT_TRUE(result);
1516 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001517 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001518 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001519interface IFoo {
1520 int foo() = 1;
1521 int bar() = 2;
1522 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001523}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001524)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001525}
1526
1527TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001528 const string expected_stderr =
1529 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1530 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001531 io_delegate_.SetFileContents(
1532 "foo/bar/IFoo.aidl",
1533 "package foo.bar;\n"
1534 "interface IFoo {\n"
1535 " int foo() = 1;\n"
1536 " int bar();\n"
1537 " int baz() = 10;\n"
1538 "}\n");
1539
Jiyong Parke59c3682018-09-11 23:10:25 +09001540 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001541 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001542 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001543 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001545}
1546
Jooyung Han965e31d2020-11-27 12:30:16 +09001547TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1548 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1549 "package foo.bar;\n"
1550 "interface IFoo {\n"
1551 " @utf8InCpp String foo();\n"
1552 " const @utf8InCpp String bar = \"bar\";\n"
1553 "}\n");
1554
1555 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1556 Options options = Options::From(args);
1557 CaptureStderr();
1558 EXPECT_TRUE(dump_api(options, io_delegate_));
1559 EXPECT_EQ("", GetCapturedStderr());
1560 string actual;
1561 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001562 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1563interface IFoo {
1564 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001565 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001566}
1567)"),
1568 actual);
1569}
1570
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001571TEST_F(AidlTest, ApiDumpWithEnums) {
1572 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1573 "package foo.bar;\n"
1574 "enum Enum {\n"
1575 " FOO,\n"
1576 " BAR = FOO + 1,\n"
1577 "}\n");
1578
1579 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1580 Options options = Options::From(args);
1581 CaptureStderr();
1582 EXPECT_TRUE(dump_api(options, io_delegate_));
1583 EXPECT_EQ("", GetCapturedStderr());
1584 string actual;
1585 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1586 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1587 "enum Enum {\n"
1588 " FOO = 0,\n"
1589 " BAR = 1,\n"
1590 "}\n"),
1591 actual);
1592}
1593
1594TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1595 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1596 "package foo.bar;\n"
1597 "enum Enum {\n"
1598 " FOO,\n"
1599 "}\n");
1600 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1601 "package foo.bar;\n"
1602 "import foo.bar.Enum;\n"
1603 "parcelable Foo {\n"
1604 " Enum e = Enum.FOO;\n"
1605 "}\n");
1606
1607 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1608 Options options = Options::From(args);
1609 CaptureStderr();
1610 EXPECT_TRUE(dump_api(options, io_delegate_));
1611 EXPECT_EQ("", GetCapturedStderr());
1612 string actual;
1613 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1614 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1615 "parcelable Foo {\n"
1616 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1617 "}\n"),
1618 actual);
1619}
1620
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001621TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001622 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001623 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1624 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001625 const string expected_map_stderr =
1626 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001627 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1628 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001629 "package p; interface IFoo {"
1630 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001631 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001632 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001633 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001634
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001635 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001636 "package p; interface IFoo {"
1637 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001639 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001640 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001641}
1642
Jeongik Chae48d9942020-01-02 17:39:00 +09001643TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001644 const string expected_stderr =
1645 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001646 Options options = Options::From("aidl -I p p/IFoo.aidl");
1647 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1648
1649 io_delegate_.SetFileContents("p/IFoo.aidl",
1650 "package p; interface IFoo {"
1651 "Map<String, Bar> foo();}");
1652 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1653
1654 io_delegate_.SetFileContents("p/IFoo.aidl",
1655 "package p; interface IFoo {"
1656 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001657 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001658 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001659 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001660
1661 io_delegate_.SetFileContents("p/IFoo.aidl",
1662 "package p; interface IFoo {"
1663 "Map<String, String> foo();}");
1664 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1665
1666 io_delegate_.SetFileContents("p/IFoo.aidl",
1667 "package p; interface IFoo {"
1668 "Map<String, ParcelFileDescriptor> foo();}");
1669 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1670}
1671
Jeongik Chadf76dc72019-11-28 00:08:47 +09001672TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001673 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001674 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1675 io_delegate_.SetFileContents(options.InputFiles().front(),
1676 "package p; interface IFoo {"
1677 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001678 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001679 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001680 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001681}
1682
1683TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1684 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1685 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001686 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001687 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001688 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1689 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001690
1691 Options options = Options::From("aidl -I p p/IFoo.aidl");
1692 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1693 io_delegate_.SetFileContents("p/IFoo.aidl",
1694 "package p; interface IFoo {"
1695 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001696 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001697 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001698 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001699 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001700 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001701 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001702 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1703 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001704 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1705 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1706 io_delegate_.SetFileContents("p/IFoo.aidl",
1707 "package p; interface IFoo {"
1708 "Bar<String, ParcelFileDescriptor> foo();}");
1709 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001710
1711 io_delegate_.SetFileContents("p/IFoo.aidl",
1712 "package p; interface IFoo {"
1713 "Bar<int, long> foo();}");
1714
1715 io_delegate_.SetFileContents("p/IFoo.aidl",
1716 "package p; interface IFoo {"
1717 "Bar<int[], long[]> foo();}");
1718
1719 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001720}
1721
Jeongik Cha0e426012019-07-29 15:57:02 +09001722TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1723 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001724 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1725 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001726 for (const auto& rawOption : rawOptions) {
1727 string expected_stderr =
1728 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001729 Options options = Options::From(rawOption);
1730 io_delegate_.SetFileContents(options.InputFiles().front(),
1731 "package foo.bar;\n"
1732 "interface IFoo1 { int foo(); }\n"
1733 "interface IFoo2 { int foo(); }\n"
1734 "parcelable Data1 { int a; int b;}\n"
1735 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001736 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001737 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001738 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001739
Jeongik Cha0e426012019-07-29 15:57:02 +09001740 io_delegate_.SetFileContents(options.InputFiles().front(),
1741 "package foo.bar;\n"
1742 "interface IFoo1 { int foo(); }\n"
1743 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001744 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001745 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001746 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001747
Devin Moore5de18ed2020-04-02 13:52:29 -07001748 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001749 io_delegate_.SetFileContents(options.InputFiles().front(),
1750 "package foo.bar;\n"
1751 "parcelable Data1 { int a; int b;}\n"
1752 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001753 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001754 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001755 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001756 }
1757}
1758
Devin Moorebdba2a82020-03-31 15:19:02 -07001759TEST_P(AidlTest, FailParseOnEmptyFile) {
1760 const string contents = "";
1761 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1762 CaptureStderr();
1763 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1764 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1765}
1766
Jiyong Parkb034bf02018-07-30 17:44:33 +09001767TEST_F(AidlTest, MultipleInputFiles) {
1768 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001769 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001770
1771 io_delegate_.SetFileContents(options.InputFiles().at(0),
1772 "package foo.bar;\n"
1773 "import foo.bar.Data;\n"
1774 "interface IFoo { Data getData(); }\n");
1775
1776 io_delegate_.SetFileContents(options.InputFiles().at(1),
1777 "package foo.bar;\n"
1778 "import foo.bar.IFoo;\n"
1779 "parcelable Data { IFoo foo; }\n");
1780
1781 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1782
1783 string content;
1784 for (const auto file : {
1785 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1786 content.clear();
1787 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1788 EXPECT_FALSE(content.empty());
1789 }
1790}
1791
1792TEST_F(AidlTest, MultipleInputFilesCpp) {
1793 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001794 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001795
1796 io_delegate_.SetFileContents(options.InputFiles().at(0),
1797 "package foo.bar;\n"
1798 "import foo.bar.Data;\n"
1799 "interface IFoo { Data getData(); }\n");
1800
1801 io_delegate_.SetFileContents(options.InputFiles().at(1),
1802 "package foo.bar;\n"
1803 "import foo.bar.IFoo;\n"
1804 "parcelable Data { IFoo foo; }\n");
1805
1806 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1807
1808 string content;
1809 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001810 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001811 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1812 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1813 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1814 content.clear();
1815 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1816 EXPECT_FALSE(content.empty());
1817 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001818}
1819
Andrei Homescub62afd92020-05-11 19:24:59 -07001820TEST_F(AidlTest, MultipleInputFilesRust) {
1821 Options options =
1822 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1823
1824 io_delegate_.SetFileContents(options.InputFiles().at(0),
1825 "package foo.bar;\n"
1826 "import foo.bar.Data;\n"
1827 "interface IFoo { Data getData(); }\n");
1828
1829 io_delegate_.SetFileContents(options.InputFiles().at(1),
1830 "package foo.bar;\n"
1831 "import foo.bar.IFoo;\n"
1832 "parcelable Data { IFoo foo; }\n");
1833
1834 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1835
1836 string content;
1837 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1838 content.clear();
1839 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1840 EXPECT_FALSE(content.empty());
1841 }
1842}
1843
Devin Moore097a3ab2020-03-11 16:08:44 -07001844TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1845 const string expected_stderr =
1846 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001847 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1848 // int getInterfaceVersion() is one of the meta transactions
1849 io_delegate_.SetFileContents(options.InputFiles().front(),
1850 "package p; interface IFoo {"
1851 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001852 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001853 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001854 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1855}
Jiyong Park309668e2018-07-28 16:55:44 +09001856
Devin Moore097a3ab2020-03-11 16:08:44 -07001857TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1858 // boolean getInterfaceVersion() is not a meta transaction, but should be
1859 // prevented because return type is not part of a method signature
1860 const string expected_stderr =
1861 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1862 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001863 io_delegate_.SetFileContents(options.InputFiles().front(),
1864 "package p; interface IFoo {"
1865 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001866 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001867 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1869}
Jiyong Park309668e2018-07-28 16:55:44 +09001870
Devin Moore097a3ab2020-03-11 16:08:44 -07001871TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001872 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001873 const string expected_stderr =
1874 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1875 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001876 io_delegate_.SetFileContents(options.InputFiles().front(),
1877 "package p; interface IFoo {"
1878 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001879 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001880 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001881 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001882
1883 // this is not a meta interface method as it differs type arguments
1884 io_delegate_.SetFileContents(options.InputFiles().front(),
1885 "package p; interface IFoo {"
1886 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001887 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001888}
1889
Jooyung Hanb8a97772021-01-19 01:27:38 +09001890TEST_F(AidlTest, CheckApiForEquality) {
1891 CaptureStderr();
1892 Options options = Options::From("aidl --checkapi=equal old new");
1893
1894 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1895 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1896 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1897 "package p; interface IFoo{ @utf8InCpp String foo();}");
1898
1899 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1900 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1901}
1902
Daniel Norman85aed542019-08-21 12:01:14 -07001903TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001904 Options options = Options::From("aidl --checkapi old new");
1905 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1906 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1907 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1908 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1909
1910 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1911}
1912
Jiyong Park3656c3c2018-08-01 20:02:01 +09001913TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001914 Options options = Options::From("aidl --checkapi old new");
1915 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1916 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001917
1918 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1919}
1920
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001921TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1922 Options options = Options::From("aidl --checkapi old new");
1923 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1924 const string enum_definition = "package p; enum Enum { FOO }";
1925 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1926 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1927 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1928 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1929
1930 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1931}
1932
Daniel Norman85aed542019-08-21 12:01:14 -07001933class AidlTestCompatibleChanges : public AidlTest {
1934 protected:
1935 Options options_ = Options::From("aidl --checkapi old new");
1936};
1937
1938TEST_F(AidlTestCompatibleChanges, NewType) {
1939 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1940 "package p;"
1941 "interface IFoo {"
1942 " void foo(int a);"
1943 "}");
1944 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1945 "package p;"
1946 "interface IFoo {"
1947 " void foo(int a);"
1948 "}");
1949 io_delegate_.SetFileContents("new/p/IBar.aidl",
1950 "package p;"
1951 "interface IBar {"
1952 " void bar();"
1953 "}");
1954 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1955}
1956
1957TEST_F(AidlTestCompatibleChanges, NewMethod) {
1958 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1959 "package p;"
1960 "interface IFoo {"
1961 " void foo(int a);"
1962 "}");
1963 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1964 "package p;"
1965 "interface IFoo {"
1966 " void foo(int a);"
1967 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001968 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001969 "}");
1970 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1971}
1972
1973TEST_F(AidlTestCompatibleChanges, NewField) {
1974 io_delegate_.SetFileContents("old/p/Data.aidl",
1975 "package p;"
1976 "parcelable Data {"
1977 " int foo;"
1978 "}");
1979 io_delegate_.SetFileContents("new/p/Data.aidl",
1980 "package p;"
1981 "parcelable Data {"
1982 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001983 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001984 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001985 "}");
1986 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1987}
1988
1989TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1990 io_delegate_.SetFileContents("old/p/Enum.aidl",
1991 "package p;"
1992 "enum Enum {"
1993 " FOO = 1,"
1994 "}");
1995 io_delegate_.SetFileContents("new/p/Enum.aidl",
1996 "package p;"
1997 "enum Enum {"
1998 " FOO = 1,"
1999 " BAR = 2,"
2000 "}");
2001 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2002}
2003
2004TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2005 io_delegate_.SetFileContents("old/p/Enum.aidl",
2006 "package p;"
2007 "enum Enum {"
2008 " FOO = 1,"
2009 " BAR = 2,"
2010 "}");
2011 io_delegate_.SetFileContents("new/p/Enum.aidl",
2012 "package p;"
2013 "enum Enum {"
2014 " BAR = 2,"
2015 " FOO = 1,"
2016 "}");
2017 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2018}
2019
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002020TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2021 io_delegate_.SetFileContents("old/p/Union.aidl",
2022 "package p;"
2023 "union Union {"
2024 " String foo;"
2025 "}");
2026 io_delegate_.SetFileContents("new/p/Union.aidl",
2027 "package p;"
2028 "union Union {"
2029 " String foo;"
2030 " int num;"
2031 "}");
2032 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2033}
2034
Daniel Norman85aed542019-08-21 12:01:14 -07002035TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002036 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2037 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002038 "interface IFoo {"
2039 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002040 "}");
2041 io_delegate_.SetFileContents("old/p/Data.aidl",
2042 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002043 "parcelable Data {"
2044 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002045 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002046 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2047 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002048 "interface IFoo {"
2049 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002050 "}");
2051 io_delegate_.SetFileContents("new/p/Data.aidl",
2052 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002053 "parcelable Data {"
2054 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002055 "}");
2056 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2057 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002058 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002059 " void foo(int a);"
2060 "}");
2061 io_delegate_.SetFileContents("new/q/Data.aidl",
2062 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002063 "parcelable Data {"
2064 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002065 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002066 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2067}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002068
Daniel Norman85aed542019-08-21 12:01:14 -07002069TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2070 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2071 "package p;"
2072 "interface IFoo {"
2073 " void foo(int a);"
2074 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002075 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2076 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002077 "interface IFoo {"
2078 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002079 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002080 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2081}
Jiyong Parke59c3682018-09-11 23:10:25 +09002082
Daniel Norman85aed542019-08-21 12:01:14 -07002083TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002084 io_delegate_.SetFileContents("old/p/I.aidl",
2085 "package p; interface I {"
2086 "const int A = 1; }");
2087 io_delegate_.SetFileContents("new/p/I.aidl",
2088 "package p ; interface I {"
2089 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002090 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2091}
Jiyong Parka428d212018-08-29 22:26:30 +09002092
Daniel Norman85aed542019-08-21 12:01:14 -07002093TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002094 io_delegate_.SetFileContents("old/p/I.aidl",
2095 "package p; interface I {"
2096 "const int A = 1; const int B = 2;}");
2097 io_delegate_.SetFileContents("new/p/I.aidl",
2098 "package p ; interface I {"
2099 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002100 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002101}
2102
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002103TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2104 io_delegate_.SetFileContents("old/p/Foo.aidl",
2105 "package p;"
2106 "@JavaPassthrough(annotation=\"Alice\")"
2107 "@JavaPassthrough(annotation=\"Bob\")"
2108 "parcelable Foo {}");
2109 io_delegate_.SetFileContents("new/p/Foo.aidl",
2110 "package p;"
2111 "@JavaPassthrough(annotation=\"Bob\")"
2112 "@JavaPassthrough(annotation=\"Alice\")"
2113 "parcelable Foo {}");
2114 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2115}
2116
Jooyung Han00073272020-11-27 14:20:20 +09002117TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2118 io_delegate_.SetFileContents("old/p/Foo.aidl",
2119 "package p;"
2120 "parcelable Foo {}");
2121 io_delegate_.SetFileContents("new/p/Foo.aidl",
2122 "package p;"
2123 "@JavaPassthrough(annotation=\"@Deprecated\")"
2124 "parcelable Foo {}");
2125 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2126}
2127
Jooyung Han636fd2f2020-10-22 11:33:45 +09002128TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2129 io_delegate_.SetFileContents("old/p/Data.aidl",
2130 "package p;"
2131 "parcelable Data {"
2132 " int num;"
2133 "}");
2134 io_delegate_.SetFileContents(
2135 "new/p/Data.aidl",
2136 "package p;"
2137 "parcelable Data {"
2138 " int num;"
2139 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2140 "}");
2141 io_delegate_.SetFileContents("new/p/Enum.aidl",
2142 "package p;"
2143 "enum Enum {"
2144 " FOO = 0,"
2145 " BAR = 1,"
2146 "}");
2147 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2148}
2149
Daniel Norman85aed542019-08-21 12:01:14 -07002150class AidlTestIncompatibleChanges : public AidlTest {
2151 protected:
2152 Options options_ = Options::From("aidl --checkapi old new");
2153};
2154
2155TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002156 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002157 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2158 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002159 "interface IFoo {"
2160 " void foo(in String[] str);"
2161 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002162 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002163 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002164 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002165 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002166}
2167
2168TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 const string expected_stderr =
2170 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002171 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2172 "package p;"
2173 "interface IFoo {"
2174 " void foo(in String[] str);"
2175 " void bar(@utf8InCpp String str);"
2176 "}");
2177 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2178 "package p;"
2179 "interface IFoo {"
2180 " void foo(in String[] str);"
2181 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002182 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002183 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002184 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002185}
2186
Jiyong Parkf8d53612020-05-04 14:06:13 +09002187TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2188 const string expected_stderr =
2189 "ERROR: new/p/IFoo.aidl:1.61-65: "
2190 "Encountered an untyped List or Map. The use of untyped List/Map is "
2191 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2192 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2193 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2194 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2195 "package p;"
2196 "interface IFoo {"
2197 " void foo(in String[] str);"
2198 "}");
2199 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2200 "package p;"
2201 "interface IFoo {"
2202 " void foo(in String[] str);"
2203 " void bar(in List arg);"
2204 "}");
2205 CaptureStderr();
2206 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2207 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2208}
2209
2210TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2211 const string expected_stderr =
2212 "ERROR: new/p/Data.aidl:1.54-59: "
2213 "Encountered an untyped List or Map. The use of untyped List/Map is "
2214 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2215 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2216 "ERROR: new/p/Data.aidl: Failed to read.\n";
2217 io_delegate_.SetFileContents("old/p/Data.aidl",
2218 "package p;"
2219 "parcelable Data {"
2220 " int foo;"
2221 "}");
2222 io_delegate_.SetFileContents("new/p/Data.aidl",
2223 "package p;"
2224 "parcelable Data {"
2225 " int foo;"
2226 " @nullable List list;"
2227 "}");
2228 CaptureStderr();
2229 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2231}
2232
Daniel Norman85aed542019-08-21 12:01:14 -07002233TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 const string expected_stderr =
2235 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002236 io_delegate_.SetFileContents("old/p/Data.aidl",
2237 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002238 "parcelable Data {"
2239 " int foo;"
2240 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002241 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002242 io_delegate_.SetFileContents("new/p/Data.aidl",
2243 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002244 "parcelable Data {"
2245 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002246 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002247 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002248 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002250}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002251
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002252TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2253 const string expected_stderr =
2254 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2255 "backends. Please either provide a default value for this field or mark the field as "
2256 "@nullable. This value or a null value will be used automatically when an old version of "
2257 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2258 "order to make sure your code continues to be backwards compatible, make sure the default or "
2259 "null value does not cause a semantic change to this parcelable.\n";
2260 io_delegate_.SetFileContents("old/p/Data.aidl",
2261 "package p;"
2262 "parcelable Data {"
2263 " int num;"
2264 "}");
2265 io_delegate_.SetFileContents("new/p/Data.aidl",
2266 "package p;"
2267 "parcelable Data {"
2268 " int num;"
2269 " String str;"
2270 "}");
2271 CaptureStderr();
2272 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2274}
2275
Jooyung Han636fd2f2020-10-22 11:33:45 +09002276TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2277 const string expected_stderr =
2278 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2279 "Please make sure 'Enum' has '0' as a valid value.\n";
2280 io_delegate_.SetFileContents("old/p/Data.aidl",
2281 "package p;"
2282 "parcelable Data {"
2283 " int num;"
2284 "}");
2285 io_delegate_.SetFileContents("new/p/Data.aidl",
2286 "package p;"
2287 "parcelable Data {"
2288 " int num;"
2289 " p.Enum e;"
2290 "}");
2291 io_delegate_.SetFileContents("new/p/Enum.aidl",
2292 "package p;"
2293 "enum Enum {"
2294 " FOO = 1,"
2295 " BAR = 2,"
2296 "}");
2297 CaptureStderr();
2298 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2299 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2300}
2301
Daniel Norman85aed542019-08-21 12:01:14 -07002302TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 const string expected_stderr =
2304 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002305 io_delegate_.SetFileContents("old/p/Enum.aidl",
2306 "package p;"
2307 "enum Enum {"
2308 " FOO = 1,"
2309 " BAR = 2,"
2310 "}");
2311 io_delegate_.SetFileContents("new/p/Enum.aidl",
2312 "package p;"
2313 "enum Enum {"
2314 " BAR = 2,"
2315 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002316 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002317 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002318 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002319}
2320
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002321TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2322 const string expected_stderr =
2323 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2324 io_delegate_.SetFileContents("old/p/Union.aidl",
2325 "package p;"
2326 "union Union {"
2327 " String str;"
2328 " int num;"
2329 "}");
2330 io_delegate_.SetFileContents("new/p/Union.aidl",
2331 "package p;"
2332 "union Union {"
2333 " String str;"
2334 "}");
2335 CaptureStderr();
2336 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2337 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2338}
2339
Daniel Norman85aed542019-08-21 12:01:14 -07002340TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002341 const string expected_stderr =
2342 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002343 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2344 "package p;"
2345 "interface IFoo {"
2346 " void foo(in String[] str);"
2347 " void bar(@utf8InCpp String str);"
2348 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002349 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2350 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002351 "interface IFoo {"
2352 " void foo(in String[] str);"
2353 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002354 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002355 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002356 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002358}
2359
Daniel Norman85aed542019-08-21 12:01:14 -07002360TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002361 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002362 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2363 "package p;"
2364 "interface IFoo {"
2365 " void foo(in String[] str);"
2366 " void bar(@utf8InCpp String str);"
2367 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002368 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2369 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002370 "interface IFoo2 {"
2371 " void foo(in String[] str);"
2372 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002373 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002375 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002376 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002377}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002378
Daniel Norman85aed542019-08-21 12:01:14 -07002379TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002380 const string expected_stderr =
2381 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002382 io_delegate_.SetFileContents("old/p/Enum.aidl",
2383 "package p;"
2384 "enum Enum {"
2385 " FOO = 1,"
2386 " BAR = 2,"
2387 "}");
2388 io_delegate_.SetFileContents("new/p/Enum.aidl",
2389 "package p;"
2390 "enum Enum {"
2391 " FOO = 3,"
2392 " BAR = 2,"
2393 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002394 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002395 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002396 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002397}
2398
2399TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 const string expected_stderr =
2401 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2402 "from 0 to 1.\n"
2403 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2404 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002405 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2406 "package p;"
2407 "interface IFoo {"
2408 " void foo(in String[] str);"
2409 " void bar(@utf8InCpp String str);"
2410 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002411 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2412 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002413 "interface IFoo {"
2414 " void bar(@utf8InCpp String str);"
2415 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002416 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002417 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002418 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002419 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002420}
2421
2422TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002424 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2425 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002426 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002427 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002428 "parcelable Data {"
2429 " int foo;"
2430 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002431 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002432 io_delegate_.SetFileContents("new/p/Data.aidl",
2433 "package p;"
2434 "parcelable Data {"
2435 " int bar;"
2436 " int foo;"
2437 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002438 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002439 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002441}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002442
Daniel Norman85aed542019-08-21 12:01:14 -07002443TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002444 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002445 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002446 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002447 "interface IFoo {"
2448 " void foo(in String[] str);"
2449 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002450 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002451 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2452 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002453 "interface IFoo {"
2454 " void foo(out String[] str);"
2455 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002456 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002457 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002458 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002459 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002460}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002461
Daniel Norman85aed542019-08-21 12:01:14 -07002462TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002463 const string expected_stderr =
2464 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002465 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2466 "package p;"
2467 "interface IFoo {"
2468 " void foo(in String[] str);"
2469 " void bar(@utf8InCpp String str);"
2470 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002471 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2472 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002473 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002475 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002476 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002477 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002478 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002479 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002480}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002481
Daniel Norman85aed542019-08-21 12:01:14 -07002482TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002483 const string expected_stderr =
2484 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002485 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2486 "package p;"
2487 "interface IFoo {"
2488 " void foo(in String[] str);"
2489 " void bar(@utf8InCpp String str);"
2490 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002491 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2492 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002493 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002494 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002495 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002496 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002497 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002498 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002499 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002500}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002501
Jooyung Han60b2fde2020-10-29 15:12:40 +09002502TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2503 const string expected_stderr =
2504 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2505 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2506 io_delegate_.SetFileContents("old/p/Foo.aidl",
2507 "package p;"
2508 "@Backing(type=\"byte\")"
2509 "enum Foo {"
2510 " FOO, BAR,"
2511 "}");
2512 io_delegate_.SetFileContents("new/p/Foo.aidl",
2513 "package p;"
2514 "@Backing(type=\"long\")"
2515 "enum Foo {"
2516 " FOO, BAR,"
2517 "}");
2518 CaptureStderr();
2519 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2521}
2522
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002523TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2524 const string expected_stderr =
2525 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2526 "to @JavaPassthrough(annotation=\"Bob\")\n";
2527 io_delegate_.SetFileContents("old/p/Foo.aidl",
2528 "package p;"
2529 "@JavaPassthrough(annotation=\"Alice\")"
2530 "parcelable Foo {}");
2531 io_delegate_.SetFileContents("new/p/Foo.aidl",
2532 "package p;"
2533 "@JavaPassthrough(annotation=\"Bob\")"
2534 "parcelable Foo {}");
2535
2536 CaptureStderr();
2537 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2538 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2539}
2540
Devin Mooredb7ac512020-08-07 11:17:36 -07002541TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2542 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002543 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002544 io_delegate_.SetFileContents("old/p/Foo.aidl",
2545 "package p;"
2546 "parcelable Foo {"
2547 " int A;"
2548 "}");
2549 io_delegate_.SetFileContents("new/p/Foo.aidl",
2550 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002551 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002552 " int A;"
2553 "}");
2554 CaptureStderr();
2555 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2556 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2557}
2558
2559TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2560 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002561 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002562 io_delegate_.SetFileContents("old/p/Foo.aidl",
2563 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002564 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002565 " int A;"
2566 "}");
2567 io_delegate_.SetFileContents("new/p/Foo.aidl",
2568 "package p;"
2569 "parcelable Foo {"
2570 " int A;"
2571 "}");
2572 CaptureStderr();
2573 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2574 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2575}
2576
Daniel Norman85aed542019-08-21 12:01:14 -07002577TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002578 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002579 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2580 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002581 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002582 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002583 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002584 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002585}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002586
Daniel Norman85aed542019-08-21 12:01:14 -07002587TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002588 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002589 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2590 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002591 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002592 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002593 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002594}
Jiyong Parka428d212018-08-29 22:26:30 +09002595
Daniel Norman85aed542019-08-21 12:01:14 -07002596TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002597 const string expected_stderr =
2598 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002599 io_delegate_.SetFileContents("old/p/I.aidl",
2600 "package p; interface I {"
2601 "const int A = 1; const int B = 2;}");
2602 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002603 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002604 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002605 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002606}
Jiyong Parka428d212018-08-29 22:26:30 +09002607
Daniel Norman85aed542019-08-21 12:01:14 -07002608TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002609 const string expected_stderr =
2610 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002611 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2612 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002613 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002614 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002615 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002616}
2617
Devin Moorec7e47a32020-08-07 10:55:25 -07002618TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2619 const string expected_stderr =
2620 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2621 "This is an incompatible change for FixedSize types.\n";
2622 io_delegate_.SetFileContents("old/p/Foo.aidl",
2623 "package p; @FixedSize parcelable Foo { int A = 1; }");
2624 io_delegate_.SetFileContents("new/p/Foo.aidl",
2625 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2626 CaptureStderr();
2627 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2628 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2629}
2630
2631TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2632 const string expected_stderr =
2633 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2634 io_delegate_.SetFileContents("old/p/Foo.aidl",
2635 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2636 io_delegate_.SetFileContents("new/p/Foo.aidl",
2637 "package p; @FixedSize parcelable Foo { int A = 1; }");
2638 CaptureStderr();
2639 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2640 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2641}
2642
2643TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2644 const string expected_stderr =
2645 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2646 "a.\n"
2647 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2648 "b.\n"
2649 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2650 "c.\n"
2651 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2652 "d.\n"
2653 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2654 "e.\n"
2655 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2656 "f.\n";
2657
2658 io_delegate_.SetFileContents("Foo.aidl",
2659 "@FixedSize parcelable Foo { "
2660 " int[] a;"
2661 " Bar b;"
2662 " String c;"
2663 " ParcelFileDescriptor d;"
2664 " IBinder e;"
2665 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002666 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002667 "}");
2668 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002669 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002670
2671 CaptureStderr();
2672 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2673 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2674}
2675
2676TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2677 const string expected_stderr = "";
2678
2679 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2680 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2681 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002682 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002683
2684 CaptureStderr();
2685 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2686 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2687}
2688
Jiyong Park8c380532018-08-30 14:55:26 +09002689TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002690 const string expected_stderr =
2691 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2692 "dir1/q/IBar.aidl\n"
2693 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002694 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002695 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2696 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2697 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2698 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2699
Devin Moore097a3ab2020-03-11 16:08:44 -07002700 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002701 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002702 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002703}
2704
Jiyong Parked65bf42018-08-28 15:43:27 +09002705TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002706 const string expected_stderr =
2707 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2708 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002709 Options options = Options::From("aidl --checkapi old new");
2710 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2711 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002712
2713 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2714
Jiyong Parke59c3682018-09-11 23:10:25 +09002715 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002716 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002717 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002718 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002719}
2720
Jiyong Parke05195e2018-10-08 18:24:23 +09002721TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2722 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2723 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002724 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002725
2726 // use without import
2727 io_delegate_.SetFileContents("p/IFoo.aidl",
2728 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2729 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2730 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002731 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002732
Devin Moore7b8d5c92020-03-17 14:14:08 -07002733 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002734 io_delegate_.SetFileContents(
2735 "p/IFoo.aidl",
2736 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2737 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2738 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002739 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002740
2741 // use with import (as before)
2742 io_delegate_.SetFileContents("p/IFoo.aidl",
2743 "package p;"
2744 "import android.os.ParcelFileDescriptor;"
2745 "interface IFoo{"
2746 " void foo(in ParcelFileDescriptor fd);"
2747 "}");
2748 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2749 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002750 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002751}
Jiyong Parked65bf42018-08-28 15:43:27 +09002752
Jiyong Park3633b722019-04-11 15:38:26 +09002753TEST_F(AidlTest, ManualIds) {
2754 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2755 io_delegate_.SetFileContents("IFoo.aidl",
2756 "interface IFoo {\n"
2757 " void foo() = 0;\n"
2758 " void bar() = 1;\n"
2759 "}");
2760 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2761}
2762
2763TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2764 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2765 io_delegate_.SetFileContents("IFoo.aidl",
2766 "interface IFoo {\n"
2767 " void foo() = 0;\n"
2768 " void bar() = 1;\n"
2769 "}");
2770 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2771}
2772
2773TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002774 const string expected_stderr =
2775 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002776 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2777 io_delegate_.SetFileContents("IFoo.aidl",
2778 "interface IFoo {\n"
2779 " void foo() = 3;\n"
2780 " void bar() = 3;\n"
2781 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002782 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002783 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002784 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002785}
2786
2787TEST_F(AidlTest, FailOnOutOfRangeIds) {
2788 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002789 const string expected_stderr =
2790 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2791 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002792 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2793 io_delegate_.SetFileContents("IFoo.aidl",
2794 "interface IFoo {\n"
2795 " void foo() = 3;\n"
2796 " void bar() = 16777115;\n"
2797 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002798 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002799 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002800 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002801}
2802
2803TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002804 const string expected_stderr =
2805 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002806 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2807 io_delegate_.SetFileContents("IFoo.aidl",
2808 "interface IFoo {\n"
2809 " void foo() = 3;\n"
2810 " void bar();\n"
2811 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002812 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002813 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002814 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002815}
2816
Jiyong Parkc6816252019-07-08 08:12:28 +09002817TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2818 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2819 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2820 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2821 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2822}
2823
2824TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002825 const string expected_stderr =
2826 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2827 "dir/IBar.aidl\n"
2828 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002829 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002830
Jiyong Parkc6816252019-07-08 08:12:28 +09002831 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2832 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2833 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2834 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002835 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002836 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002837 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002838}
2839
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002840TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2841 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2842 "package a.b;\n"
2843 "import a.b.IBar;\n"
2844 "import a.b.IQux;\n"
2845 "interface IFoo { IQux foo(); }\n");
2846 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2847 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2848
2849 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2850 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2851
2852 string output;
2853 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2854 // IBar was imported but wasn't used. include is not expected.
2855 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2856 // IBar was imported and used. include is expected.
2857 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2858}
2859
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002860TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002861 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002862 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002863 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2864 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002865 interface IFoo {
2866 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002867 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002868 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002869 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002870 // JavaPassthrough should work with other types as well (e.g. enum)
2871 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2872 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2873 @JavaPassthrough(annotation="@com.android.AliceTwo")
2874 @Backing(type="byte")
2875 enum MyEnum {
2876 a, b, c
2877 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002878
Jooyung Han4cde01d2020-10-13 11:10:47 +09002879 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002880 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2881
2882 string java_out;
2883 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002884 // type-decl-level annotations with newline at the end
2885 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2886 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2887 // member-decl-level annotations with newline at the end
2888 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2889 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2890 // inline annotations with space at the end
2891 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002892
Jooyung Han4cde01d2020-10-13 11:10:47 +09002893 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2894 // type-decl-level annotations with newline at the end
2895 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2896 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2897
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002898 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002899 Options cpp_options =
2900 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002901 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2902
Jooyung Han4cde01d2020-10-13 11:10:47 +09002903 Options ndk_options =
2904 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002905 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002906
Jooyung Han4cde01d2020-10-13 11:10:47 +09002907 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002908 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002909}
2910
Andrei Homescue61feb52020-08-18 15:44:24 -07002911TEST_F(AidlTest, ParseRustDerive) {
2912 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2913 @RustDerive(Clone=true, Copy=false)
2914 parcelable Foo {
2915 int a;
2916 })");
2917
2918 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2919 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2920
2921 string rust_out;
2922 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2923 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2924
2925 // Other backends shouldn't be bothered
2926 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2927 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2928
2929 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2930 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2931
2932 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2933 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2934}
2935
Jiyong Park56f73d72019-06-11 12:20:28 +09002936class AidlOutputPathTest : public AidlTest {
2937 protected:
2938 void SetUp() override {
2939 AidlTest::SetUp();
2940 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2941 }
2942
2943 void Test(const Options& options, const std::string expected_output_path) {
2944 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2945 // check the existence
2946 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2947 }
2948};
2949
2950TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2951 // <out_dir> / <package_name> / <type_name>.java
2952 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2953}
2954
2955TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2956 // when output file is explicitly set, it is always respected. -o option is
2957 // ignored.
2958 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2959}
2960
2961TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2962 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2963}
2964
2965TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2966 // output is the same as the input file except for the suffix
2967 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2968}
2969
Devin Moore7b8d5c92020-03-17 14:14:08 -07002970TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002971 AidlError error;
2972 const string expected_stderr =
2973 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2974 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002975 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2976 R"(package p;
2977 interface IFoo {
2978 const int int32_max_oob = 2147483650;
2979 }
2980 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002981 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002982 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2983 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002984}
2985
Devin Moore7b8d5c92020-03-17 14:14:08 -07002986TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002987 AidlError error;
2988 const string expected_stderr =
2989 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2990 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002991 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2992 R"(package p;
2993 interface IFoo {
2994 const int int32_min_oob = -2147483650;
2995 }
2996 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002997 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002998 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2999 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003000}
3001
Devin Moore7b8d5c92020-03-17 14:14:08 -07003002TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003003 AidlError error;
3004 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003005 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003006 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003007 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3008 R"(package p;
3009 interface IFoo {
3010 const long int64_max_oob = 21474836509999999999999999;
3011 }
3012 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003013 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003014 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3015 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003016}
3017
Devin Moore7b8d5c92020-03-17 14:14:08 -07003018TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003019 AidlError error;
3020 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003021 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003022 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003023 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3024 R"(package p;
3025 interface IFoo {
3026 const long int64_min_oob = -21474836509999999999999999;
3027 }
3028 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003029 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003030 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3031 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003032}
3033
Devin Moore7b8d5c92020-03-17 14:14:08 -07003034TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003035 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003036 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003037 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003038 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3039 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003040 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3041 R"(package p;
3042 @Backing(type="byte")
3043 enum TestEnum {
3044 FOO = 127,
3045 BAR,
3046 }
3047 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003048 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003049 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003050 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003051}
3052
Devin Mooredecaf292020-04-30 09:16:40 -07003053TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3054 AidlError error;
3055 const string expected_stderr =
3056 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003057 "be one of: type\n";
3058 CaptureStderr();
3059 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3060 R"(package p;
3061 @Backing(foo="byte")
3062 enum TestEnum {
3063 FOO = 1,
3064 BAR,
3065 }
3066 )",
3067 typenames_, GetLanguage(), &error));
3068 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3069 EXPECT_EQ(AidlError::BAD_TYPE, error);
3070}
3071
Jooyung Han5721a232020-12-24 04:34:55 +09003072TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3073 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3074 CaptureStderr();
3075 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3077}
3078
Jooyung Han66813932020-10-23 13:24:44 +09003079TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003080 io_delegate_.SetFileContents("Foo.aidl",
3081 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3082 "Map<String, Baz> d; Bar[] e; }");
3083 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3084 io_delegate_.SetFileContents("Baz.aidl",
3085 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003086 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3087 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3088}
3089
Jooyung Han66813932020-10-23 13:24:44 +09003090TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003091 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003092 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003093 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003094 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3095 "named 'bar'.\n";
3096 CaptureStderr();
3097 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3098 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3099 EXPECT_EQ(expected_error, GetCapturedStderr());
3100}
3101
3102TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3103 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3104 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3105 string expected_error =
3106 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003107 "named 'bar'.\n";
3108 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003109 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3110 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003111 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003112}
3113
Jooyung Han66813932020-10-23 13:24:44 +09003114TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003115 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003116 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3117 string expected_error =
3118 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3119 "only be an in parameter.\n";
3120 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003121 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3122 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003123 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003124}
3125
Jooyung Han66813932020-10-23 13:24:44 +09003126TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003127 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003128 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3129 string expected_error =
3130 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3131 "only be an in parameter.\n";
3132 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003133 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3134 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003135 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003136}
3137
Jooyung Han66813932020-10-23 13:24:44 +09003138TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003139 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003140 Options options = Options::From("aidl --lang=java Foo.aidl");
3141 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003142 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3143 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003144 CaptureStderr();
3145 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3147}
Devin Moore53fc99c2020-08-12 08:07:52 -07003148
Jooyung Hanfe086af2021-01-16 03:44:47 +09003149TEST_P(AidlTest, UnionInUnion) {
3150 import_paths_.insert(".");
3151 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3152 CaptureStderr();
3153 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3154 EXPECT_THAT("", GetCapturedStderr());
3155}
3156
Jooyung Hanfe89f122020-10-14 03:49:18 +09003157TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3158 const string method = "package a; union Foo {}";
3159 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3160 CaptureStderr();
3161 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3162 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3163}
3164
3165TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3166 const string method = "package a; union Foo { ParcelableHolder x; }";
3167 const string expected_stderr =
3168 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3169 CaptureStderr();
3170 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3171 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3172}
3173
Jooyung Han53fb4242020-12-17 16:03:49 +09003174TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3175 import_paths_.insert(".");
3176 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3177 const string expected_err = "The union's first member should have a useful default value.";
3178 CaptureStderr();
3179 EXPECT_EQ(nullptr,
3180 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3181 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3182}
3183
Devin Moore53fc99c2020-08-12 08:07:52 -07003184TEST_P(AidlTest, GenericStructuredParcelable) {
3185 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003186 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003187 const string expected_stderr = "";
3188 CaptureStderr();
3189 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3191}
3192
Jooyung Han3f347ca2020-12-01 12:41:50 +09003193TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3194 io_delegate_.SetFileContents("Foo.aidl",
3195 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3196 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003197 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003198 const string expected_stderr = "";
3199 CaptureStderr();
3200 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3201 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3202
3203 string code;
3204 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3205 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3206const ::android::String16& Foo<T,U>::s() {
3207 static const ::android::String16 value(::android::String16(""));
3208 return value;
3209})--"));
3210}
3211
3212TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3213 io_delegate_.SetFileContents("Foo.aidl",
3214 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3215 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003216 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003217 const string expected_stderr = "";
3218 CaptureStderr();
3219 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3220 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3221
3222 string code;
3223 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3224 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3225const char* Foo<T, U>::s = "";
3226)--"));
3227}
3228
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003229TEST_F(AidlTest, NestedTypeArgs) {
3230 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003231 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3232
3233 io_delegate_.SetFileContents("a/Foo.aidl",
3234 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3235 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003236 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3237 const string expected_stderr = "";
3238 CaptureStderr();
3239 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3241
3242 string code;
3243 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003244 EXPECT_THAT(code,
3245 testing::HasSubstr(
3246 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3247}
3248
3249TEST_F(AidlTest, DoubleArrayError) {
3250 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3251
3252 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3253 const string expected_stderr =
3254 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3255 CaptureStderr();
3256 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3258}
3259
3260TEST_F(AidlTest, DoubleGenericError) {
3261 io_delegate_.SetFileContents("a/Bar.aidl",
3262 "package a; parcelable Bar { List<String><String> a; }");
3263
3264 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3265 const string expected_stderr =
3266 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3267 CaptureStderr();
3268 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3269 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3270}
3271
3272TEST_F(AidlTest, ArrayBeforeGenericError) {
3273 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3274
3275 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3276 const string expected_stderr =
3277 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3278 CaptureStderr();
3279 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3280 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003281}
3282
Jooyung Han14004ed2020-10-16 03:49:57 +09003283struct GenericAidlTest : ::testing::Test {
3284 FakeIoDelegate io_delegate_;
3285 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003286 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003287 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3288 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3289 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3290
3291 Options options = Options::From(cmd);
3292 CaptureStderr();
3293 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3294 EXPECT_EQ("", GetCapturedStderr());
3295 }
3296};
3297
3298TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3299 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3300 string code;
3301 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3302 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3303 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3304 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3305}
3306
3307TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3308 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3309 string code;
3310 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3311 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3312 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3313 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3314}
3315
Devin Moore53fc99c2020-08-12 08:07:52 -07003316TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3317 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003318 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003319 const string expected_stderr =
3320 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3321 CaptureStderr();
3322 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3324}
3325
3326TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3327 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003328 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003329 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3330 CaptureStderr();
3331 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3333}
3334
Jooyung Han7a308842020-10-27 19:06:49 +09003335TEST_P(AidlTest, LongCommentWithinConstExpression) {
3336 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003337 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003338 CaptureStderr();
3339 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3340 EXPECT_EQ("", GetCapturedStderr());
3341}
3342
Jeongik Chaef44e622020-10-23 16:00:52 +09003343TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3344 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3345 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3346 std::string expectedErr =
3347 "ERROR: a/Foo.aidl:1.28-30: "
3348 "Encountered an untyped List or Map. The use of untyped List/Map is "
3349 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3350 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3351 "ERROR: a/Foo.aidl:1.35-37: "
3352 "Encountered an untyped List or Map. The use of untyped List/Map is "
3353 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3354 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3355 CaptureStderr();
3356 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3357 EXPECT_EQ(expectedErr, GetCapturedStderr());
3358}
3359
3360TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003361 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3362 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003363 std::string expectedErr =
3364 "ERROR: a/Foo.aidl:1.33-35: "
3365 "Encountered an untyped List or Map. The use of untyped List/Map is "
3366 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3367 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3368 "ERROR: a/Foo.aidl:1.40-42: "
3369 "Encountered an untyped List or Map. The use of untyped List/Map is "
3370 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3371 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003372 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003373 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3374 EXPECT_EQ(expectedErr, GetCapturedStderr());
3375}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003376
Jeongik Chaef44e622020-10-23 16:00:52 +09003377TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3378 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3379 io_delegate_.SetFileContents(
3380 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3381 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3382 std::string expectedErr =
3383 "ERROR: a/Foo.aidl:1.52-54: "
3384 "Encountered an untyped List or Map. The use of untyped List/Map is "
3385 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3386 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3387 "ERROR: a/Foo.aidl:1.64-66: "
3388 "Encountered an untyped List or Map. The use of untyped List/Map is "
3389 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3390 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3391 CaptureStderr();
3392 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3393 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003394}
3395
Jooyung Han690f5842020-12-04 13:02:04 +09003396TEST_F(AidlTest, EnumWithDefaults_Java) {
3397 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3398 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3399package p;
3400import p.Enum;
3401parcelable Foo {
3402 Enum e = Enum.BAR;
3403})");
3404 CaptureStderr();
3405 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3406 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3407 auto err = GetCapturedStderr();
3408 EXPECT_EQ("", err);
3409
3410 string code;
3411 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003412 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003413}
3414
3415TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3416 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3417 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3418package p;
3419import p.Enum;
3420parcelable Foo {
3421 Enum e = Enum.BAR;
3422})");
3423 CaptureStderr();
3424 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3425 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3426 auto err = GetCapturedStderr();
3427 EXPECT_EQ("", err);
3428
3429 string code;
3430 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3431 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3432}
3433
3434TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3435 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3436 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3437package p;
3438import p.Enum;
3439parcelable Foo {
3440 Enum e = Enum.BAR;
3441})");
3442 CaptureStderr();
3443 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3444 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3445 auto err = GetCapturedStderr();
3446 EXPECT_EQ("", err);
3447
3448 string code;
3449 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3450 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3451}
3452
3453TEST_F(AidlTest, EnumWithDefaults_Rust) {
3454 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3455 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3456package p;
3457import p.Enum;
3458parcelable Foo {
3459 int n = 42;
3460 Enum e = Enum.BAR;
3461})");
3462 CaptureStderr();
3463 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3464 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3465 auto err = GetCapturedStderr();
3466 EXPECT_EQ("", err);
3467
3468 string code;
3469 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3470 EXPECT_THAT(code, testing::HasSubstr(R"(
3471 fn default() -> Self {
3472 Self {
3473 n: 42,
3474 e: crate::mangled::_1_p_4_Enum::BAR,
3475 }
3476 })"));
3477}
3478
3479TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3480 import_paths_.insert("a");
3481 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3482 CaptureStderr();
3483 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3484package p;
3485import p.Enum;
3486parcelable Foo {
3487 int e = Enum.FOO | Enum.BAR;
3488})",
3489 typenames_, GetLanguage());
3490 auto err = GetCapturedStderr();
3491 EXPECT_EQ("", err);
3492 EXPECT_TRUE(type);
3493 const auto& fields = type->AsStructuredParcelable()->GetFields();
3494 EXPECT_EQ("int e = 3", fields[0]->ToString());
3495}
3496
3497TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3498 CaptureStderr();
3499 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3500@Backing(type="int")
3501enum Foo {
3502 STANDARD_SHIFT = 16,
3503 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3504 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3505}
3506)",
3507 typenames_, GetLanguage());
3508 auto err = GetCapturedStderr();
3509 EXPECT_EQ("", err);
3510 EXPECT_TRUE(type);
3511 const auto& enum_type = type->AsEnumDeclaration();
3512 string code;
3513 enum_type->Dump(CodeWriter::ForString(&code).get());
3514 EXPECT_EQ(R"--(@Backing(type="int")
3515enum Foo {
3516 STANDARD_SHIFT = 16,
3517 STANDARD_BT709 = 65536,
3518 STANDARD_BT601_625 = 131072,
3519}
3520)--",
3521 code);
3522}
3523
3524TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3525 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3526 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3527package p;
3528import p.Enum;
3529parcelable Foo {
3530 Enum e = Enum.FOO | Enum.BAR;
3531})");
3532 CaptureStderr();
3533 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3534 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3535 auto err = GetCapturedStderr();
3536 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3537 err);
3538}
3539
3540TEST_P(AidlTest, DefaultWithEmptyArray) {
3541 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3542 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3543 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003544 auto options =
3545 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003546 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3547 auto err = GetCapturedStderr();
3548 EXPECT_EQ("", err);
3549}
3550
3551TEST_P(AidlTest, RejectRefsInAnnotation) {
3552 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3553 "package p; interface IFoo {\n"
3554 " const String ANNOTATION = \"@Annotation\";\n"
3555 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3556 "}");
3557 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003558 auto options =
3559 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003560 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3561 auto err = GetCapturedStderr();
3562 EXPECT_EQ(
3563 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3564 "ANNOTATION.\n",
3565 err);
3566}
3567
3568TEST_F(AidlTest, DefaultWithEnumValues) {
3569 io_delegate_.SetFileContents(
3570 "a/p/Foo.aidl",
3571 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3572 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3573 CaptureStderr();
3574 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3575 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3576 auto err = GetCapturedStderr();
3577 EXPECT_EQ("", err);
3578 string code;
3579 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3580 EXPECT_THAT(
3581 code, testing::HasSubstr(
3582 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3583}
3584
Jooyung Han14259392020-12-07 10:00:08 +09003585TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3586 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3587 CaptureStderr();
3588 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3589 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3590 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003591 EXPECT_EQ(
3592 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3593 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3594 err);
Jooyung Han14259392020-12-07 10:00:08 +09003595}
3596
3597TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3598 io_delegate_.SetFileContents("a/p/Foo.aidl",
3599 "package p; parcelable Foo { const int A = A + 1; }");
3600 CaptureStderr();
3601 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3602 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3603 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003604 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3605}
3606
3607TEST_F(AidlTest, RecursiveReferences) {
3608 io_delegate_.SetFileContents("a/p/Foo.aidl",
3609 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3610 io_delegate_.SetFileContents("a/p/Bar.aidl",
3611 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3612 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3613 CaptureStderr();
3614 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3615 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3616 EXPECT_EQ("", GetCapturedStderr());
3617}
3618
Jooyung Hane9f5b272021-01-07 00:18:11 +09003619TEST_P(AidlTest, UnknownConstReference) {
3620 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3621 auto options =
3622 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3623 const string err =
3624 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3625 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3626 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3627 CaptureStderr();
3628 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3629 EXPECT_EQ(err, GetCapturedStderr());
3630}
3631
Jooyung Han29813842020-12-08 01:28:03 +09003632TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3633 string contents = R"(
3634import android.os.IBinder;
3635import android.os.IInterface;
3636interface IFoo {}
3637 )";
3638 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003639}
3640
Jooyung Han888c5bc2020-12-22 17:28:47 +09003641TEST_P(AidlTest, WarningInterfaceName) {
3642 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003643 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003644 " -Weverything -o out -h out p/Foo.aidl");
3645 CaptureStderr();
3646 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003647 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003648 GetCapturedStderr());
3649}
3650
3651TEST_P(AidlTest, ErrorInterfaceName) {
3652 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003653 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003654 " -Weverything -Werror -o out -h out p/Foo.aidl");
3655 CaptureStderr();
3656 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003657 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003658 GetCapturedStderr());
3659}
3660
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003661TEST_F(AidlTest, HideIsNotForArgs) {
3662 io_delegate_.SetFileContents("IFoo.aidl",
3663 "interface IFoo {\n"
3664 " void foo(in @Hide int x);\n"
3665 "}");
3666 auto options = Options::From("aidl --lang=java IFoo.aidl");
3667 CaptureStderr();
3668 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3669 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3670}
3671
3672TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3673 io_delegate_.SetFileContents(
3674 "IFoo.aidl",
3675 "interface IFoo {\n"
3676 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3677 "}");
3678 auto options = Options::From("aidl --lang=java IFoo.aidl");
3679 CaptureStderr();
3680 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3681 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3682}
3683
Jooyung Hanfd3be322020-12-13 09:11:06 +09003684struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003685 string kind;
3686 string literal;
3687};
3688
Jooyung Hanfd3be322020-12-13 09:11:06 +09003689const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003690 {"primitive", "int"}, {"String", "String"},
3691 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3692 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3693 {"union", "a.Union"}, {"interface", "a.IBar"},
3694};
3695
3696const std::map<std::string, std::string> kListSupportExpectations = {
3697 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3698 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3699 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3700 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
3701 {"cpp_String", ""},
3702 {"java_String", ""},
3703 {"ndk_String", ""},
3704 {"rust_String", ""},
3705 {"cpp_IBinder", ""},
3706 {"java_IBinder", ""},
3707 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3708 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003709 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003710 {"java_ParcelFileDescriptor", ""},
3711 {"ndk_ParcelFileDescriptor", ""},
3712 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003713 {"cpp_interface", "List<a.IBar> is not supported."},
3714 {"java_interface", "List<a.IBar> is not supported."},
3715 {"ndk_interface", "List<a.IBar> is not supported."},
3716 {"rust_interface", "List<a.IBar> is not supported."},
3717 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003718 {"java_parcelable", ""},
3719 {"ndk_parcelable", ""},
3720 {"rust_parcelable", ""},
3721 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3722 {"java_enum", "A generic type cannot have any primitive type parameters."},
3723 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3724 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003725 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003726 {"java_union", ""},
3727 {"ndk_union", ""},
3728 {"rust_union", ""},
3729};
3730
Jooyung Hand236e552020-12-13 09:21:27 +09003731const std::map<std::string, std::string> kArraySupportExpectations = {
3732 {"cpp_primitive", ""},
3733 {"java_primitive", ""},
3734 {"ndk_primitive", ""},
3735 {"rust_primitive", ""},
3736 {"cpp_String", ""},
3737 {"java_String", ""},
3738 {"ndk_String", ""},
3739 {"rust_String", ""},
3740 {"cpp_IBinder", ""},
3741 {"java_IBinder", ""},
3742 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3743 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3744 {"cpp_ParcelFileDescriptor", ""},
3745 {"java_ParcelFileDescriptor", ""},
3746 {"ndk_ParcelFileDescriptor", ""},
3747 {"rust_ParcelFileDescriptor", ""},
3748 {"cpp_interface", "Binder type cannot be an array"},
3749 {"java_interface", "Binder type cannot be an array"},
3750 {"ndk_interface", "Binder type cannot be an array"},
3751 {"rust_interface", "Binder type cannot be an array"},
3752 {"cpp_parcelable", ""},
3753 {"java_parcelable", ""},
3754 {"ndk_parcelable", ""},
3755 {"rust_parcelable", ""},
3756 {"cpp_enum", ""},
3757 {"java_enum", ""},
3758 {"ndk_enum", ""},
3759 {"rust_enum", ""},
3760 {"cpp_union", ""},
3761 {"java_union", ""},
3762 {"ndk_union", ""},
3763 {"rust_union", ""},
3764};
3765
Jooyung Hanfd3be322020-12-13 09:11:06 +09003766class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003767 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003768 void Run(const std::string& generic_type_decl,
3769 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003770 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003771 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003772 const auto& kind = std::get<1>(param).kind;
3773
3774 FakeIoDelegate io;
3775 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3776 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3777 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003778 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3779 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003780
3781 const auto options =
3782 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3783 CaptureStderr();
3784 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003785 auto it = expectations.find(lang + "_" + kind);
3786 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003787 const string err = GetCapturedStderr();
3788 if (it->second.empty()) {
3789 EXPECT_EQ("", err);
3790 } else {
3791 EXPECT_THAT(err, testing::HasSubstr(it->second));
3792 }
3793 }
3794};
3795
3796INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003797 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003798 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3799 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003800 testing::ValuesIn(kTypeParams)),
3801 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003802 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003803 });
3804
Jooyung Hanfd3be322020-12-13 09:11:06 +09003805TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3806 Run("List<{}>", kListSupportExpectations);
3807}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003808
Jooyung Hand236e552020-12-13 09:21:27 +09003809TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3810 Run("{}[]", kArraySupportExpectations);
3811}
3812
Christopher Wiley90be4e32015-10-20 14:55:25 -07003813} // namespace aidl
3814} // namespace android