blob: 0364ede92a7f476bbeee8997b3166c8d97313386 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090046using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070047using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090048using testing::internal::CaptureStderr;
49using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070050
51namespace android {
52namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070053namespace {
54
55const char kExpectedDepFileContents[] =
56R"(place/for/output/p/IFoo.java : \
57 p/IFoo.aidl
58
59p/IFoo.aidl :
60)";
61
Dan Willemsen93298ee2016-11-10 23:55:55 -080062const char kExpectedNinjaDepFileContents[] =
63R"(place/for/output/p/IFoo.java : \
64 p/IFoo.aidl
65)";
66
Jiyong Parkdf202122019-09-30 20:48:35 +090067const char kExpectedParcelableDeclarationDepFileContents[] =
68 R"( : \
69 p/Foo.aidl
70
71p/Foo.aidl :
72)";
73
74const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080075 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070076 p/Foo.aidl
77
78p/Foo.aidl :
79)";
80
Christopher Wileyf8136192016-04-12 14:19:35 -070081} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070082
Devin Moore7b8d5c92020-03-17 14:14:08 -070083class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070084 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090085 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
86 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070087 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070088 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090089 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070090 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090091 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 for (const string& s : additional_arguments) {
93 args.emplace_back(s);
94 }
95 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090096 args.emplace_back("--preprocessed=" + f);
97 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -070098 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--include=" + i);
100 }
101 args.emplace_back(path);
102 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900103 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900104 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700105 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900106 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900107
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 if (error != nullptr) {
109 *error = actual_error;
110 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900111
112 if (actual_error != AidlError::OK) {
113 return nullptr;
114 }
115
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900116 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900117 EXPECT_EQ(1ul, defined_types.size());
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700120 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700121
Devin Moore7b8d5c92020-03-17 14:14:08 -0700122 Options::Language GetLanguage() { return GetParam(); }
123
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800125 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900126 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900127 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700128};
129
Devin Moore7b8d5c92020-03-17 14:14:08 -0700130// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
131// tests with each of the supported languages as a parameter.
132INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
133 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700134 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900136 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 });
138
139TEST_P(AidlTest, AcceptMissingPackage) {
140 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700141}
142
Devin Moore7b8d5c92020-03-17 14:14:08 -0700143TEST_P(AidlTest, EndsInSingleLineComment) {
144 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700145}
146
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000147TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
148 const string expected_stderr =
149 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
150 const std::string file_contents = "package a; interface IBar {}";
151 CaptureStderr();
152 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
153 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
154}
155
156TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
157 const string expected_stderr =
158 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
159 const std::string file_contents = "package a; interface Bar {}";
160 CaptureStderr();
161 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
162 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
163}
164
165TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
166 const string expected_stderr =
167 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
168 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
169 CaptureStderr();
170 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
171 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
172}
173
174TEST_P(AidlTest, EnumRequiresCorrectPath) {
175 const string expected_stderr =
176 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
177 const std::string file_contents = "package a; enum Bar { A, }";
178 CaptureStderr();
179 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
180 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
181}
182
Devin Moore7b8d5c92020-03-17 14:14:08 -0700183TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900184 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700185 io_delegate_.SetFileContents("bar/IBar.aidl",
186 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700187 const string path = "foo/IFoo.aidl";
188 const string contents =
189 "package foo;\n"
190 "import bar.IBar;\n"
191 "interface IFoo { void f(in IBar[] input); }";
192 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
193 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700194 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700195 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700196}
197
Devin Moore7b8d5c92020-03-17 14:14:08 -0700198TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700199 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900201}
Devin Moore097a3ab2020-03-11 16:08:44 -0700202
Jiyong Park40782d02020-07-24 19:17:43 +0900203TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
205 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900206 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
207 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700208 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700209 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900211}
212
Jiyong Park40782d02020-07-24 19:17:43 +0900213TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700214 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
215 const string expected_stderr =
216 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 CaptureStderr();
218 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
219 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900220}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700221
Jiyong Park40782d02020-07-24 19:17:43 +0900222TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700223 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900224 const string expected_stderr =
225 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700226 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700227 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700229}
230
Devin Moore7b8d5c92020-03-17 14:14:08 -0700231TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700232 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
233 const string expected_stderr =
234 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
235 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700238}
239
Devin Moore7b8d5c92020-03-17 14:14:08 -0700240TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700241 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
242 const string expected_stderr =
243 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
244 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800247}
248
Devin Moore2f2077a2020-08-28 11:27:53 -0700249TEST_P(AidlTest, AcceptNullableList) {
250 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
251 const string expected_stderr = "";
252 CaptureStderr();
253 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
254 EXPECT_EQ(expected_stderr, GetCapturedStderr());
255}
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700258 const string method = "package a; interface IFoo { void f(int a, int a); }";
259 const string expected_stderr =
260 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
261 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700264}
265
Jeongik Cha13066da2020-08-06 15:43:19 +0900266TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
267 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900268 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
272}
273
Jooyung Hand902a972020-10-23 17:32:44 +0900274TEST_P(AidlTest, RejectsRepeatedAnnotations) {
275 const string method = R"(@Hide @Hide parcelable Foo {})";
276 const string expected_stderr =
277 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
278 "Foo.aidl:1.1-6\n";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
282}
283
Devin Moore7b8d5c92020-03-17 14:14:08 -0700284TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700285 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
286 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
287 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700288 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100290}
291
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 AidlError error;
294 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900297 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700298 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800299}
300
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 AidlError error;
303 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700307 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 AidlError error;
312 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700313 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000314 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000321 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700322 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700325 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800326}
327
Jiyong Park40782d02020-07-24 19:17:43 +0900328TEST_P(AidlTest, ParsesNonNullableAnnotation) {
329 auto parse_result =
330 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
331 ASSERT_NE(nullptr, parse_result);
332 const AidlInterface* interface = parse_result->AsInterface();
333 ASSERT_NE(nullptr, interface);
334 ASSERT_FALSE(interface->GetMethods().empty());
335 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
336}
337
Devin Moore7b8d5c92020-03-17 14:14:08 -0700338TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900339 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
340 typenames_, GetLanguage());
341 ASSERT_NE(nullptr, parse_result);
342 const AidlInterface* interface = parse_result->AsInterface();
343 ASSERT_NE(nullptr, interface);
344 ASSERT_FALSE(interface->GetMethods().empty());
345 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
346}
347
348TEST_P(AidlTest, ParsesNonUtf8Annotations) {
349 auto parse_result =
350 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
351 ASSERT_NE(nullptr, parse_result);
352 const AidlInterface* interface = parse_result->AsInterface();
353 ASSERT_NE(nullptr, interface);
354 ASSERT_FALSE(interface->GetMethods().empty());
355 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900359 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
360 typenames_, GetLanguage());
361 ASSERT_NE(nullptr, parse_result);
362 const AidlInterface* interface = parse_result->AsInterface();
363 ASSERT_NE(nullptr, interface);
364 ASSERT_FALSE(interface->GetMethods().empty());
365 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700369 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700370 const string expected_stderr =
371 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
372 "\"vintf\"'\n"
373 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
374 "--structured\n";
375 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700376 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700377 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700379 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700380}
381
Devin Moore7b8d5c92020-03-17 14:14:08 -0700382TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700383 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700384 const string expected_stderr =
385 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
386 "--structured\n";
387 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700391 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392}
393
Devin Moore7b8d5c92020-03-17 14:14:08 -0700394TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700395 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 const string expected_stderr =
397 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
398 "\"vintf\"'\n";
399 CaptureStderr();
400 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700401 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700403 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700407 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
409 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700410 ASSERT_EQ(AidlError::OK, error);
411 ASSERT_NE(nullptr, parse_result);
412 const AidlInterface* interface = parse_result->AsInterface();
413 ASSERT_NE(nullptr, interface);
414 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700415}
416
Jeongik Cha64783ed2019-06-07 18:30:54 +0900417TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
418 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900419 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
420 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900421 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700422 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900423 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900424 "a/Foo.aidl",
425 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900426
427 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900428 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700429 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900430 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700431 "Parcelable must be defined in AIDL directly.\n";
432 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900433 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700435
436 CaptureStderr();
437 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900439}
440
Jooyung Han1cbc4962020-10-25 10:07:15 +0900441TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
442 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
443 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
444 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900445 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
446
447 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900448 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900449 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
450
451 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900452 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900453 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
454
Jooyung Han1cbc4962020-10-25 10:07:15 +0900455 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900456 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
457}
458
Jooyung Han1cbc4962020-10-25 10:07:15 +0900459TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
460 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
461 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
462 CaptureStderr();
463 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
464 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
465 EXPECT_EQ("", GetCapturedStderr());
466
467 const string expected_to_string_method = R"--(
468 @Override
469 public String toString() {
470 switch (_tag) {
471 case a: return "a.Foo.a(" + (getA()) + ")";
472 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
473 }
474 throw new IllegalStateException("unknown field: " + _tag);
475 }
476)--";
477
478 string java_out;
479 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
480 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
481}
482
Jiyong Park9aa3d042020-12-04 23:30:02 +0900483TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
484 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
485 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
486 CaptureStderr();
487 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
488 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
489 EXPECT_EQ("", GetCapturedStderr());
490
491 const std::string expected = R"--(
492 @Override
493 public boolean equals(Object other) {
494 if (this == other) return true;
495 if (other == null) return false;
496 if (!(other instanceof Foo)) return false;
497 Foo that = (Foo)other;
498 if (!java.util.Objects.deepEquals(a, that.a)) return false;
499 if (!java.util.Objects.deepEquals(b, that.b)) return false;
500 return true;
501 }
502
503 @Override
504 public int hashCode() {
505 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
506 }
507)--";
508
509 string java_out;
510 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
511 EXPECT_THAT(java_out, testing::HasSubstr(expected));
512}
513
514TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
515 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
516 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
517 CaptureStderr();
518 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
519 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
520 EXPECT_EQ("", GetCapturedStderr());
521
522 const std::string expected = R"--(
523 @Override
524 public boolean equals(Object other) {
525 if (this == other) return true;
526 if (other == null) return false;
527 if (!(other instanceof Foo)) return false;
528 Foo that = (Foo)other;
529 if (_tag != that._tag) return false;
530 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
531 return true;
532 }
533
534 @Override
535 public int hashCode() {
536 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
537 }
538)--";
539
540 string java_out;
541 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
542 EXPECT_THAT(java_out, testing::HasSubstr(expected));
543}
544
Jooyung Han90345002020-10-23 15:28:53 +0900545TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900546 {
Jooyung Han90345002020-10-23 15:28:53 +0900547 io_delegate_.SetFileContents("a/Foo.aidl",
548 "package a; @JavaDerive(blah=true) parcelable Foo{}");
549 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
550 CaptureStderr();
551 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
552 const std::string expected_stderr =
553 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900554 EXPECT_THAT(GetCapturedStderr(),
555 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900556 }
557
558 {
559 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900560 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
561 CaptureStderr();
562 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900563 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900564 }
565
566 {
Jooyung Han90345002020-10-23 15:28:53 +0900567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900571 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900572 }
573}
574
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900575TEST_P(AidlTest, ParseDescriptorAnnotation) {
576 AidlError error;
577 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
578 typenames_, GetLanguage(), &error, {"--structured"});
579 ASSERT_EQ(AidlError::OK, error);
580 ASSERT_NE(nullptr, parse_result);
581 const AidlInterface* interface = parse_result->AsInterface();
582 ASSERT_NE(nullptr, interface);
583 ASSERT_EQ("IBar", interface->GetDescriptor());
584}
585
Jiyong Park40782d02020-07-24 19:17:43 +0900586TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700587 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700588 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900589}
590
591TEST_P(AidlTest, AcceptsOnewayInterface) {
592 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700593 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700594}
Christopher Wileyef140932015-11-03 09:29:19 -0800595
Devin Moore7b8d5c92020-03-17 14:14:08 -0700596TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700597 const string oneway_method =
598 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700599 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100600}
601
Steven Moreland65297cc2020-04-20 20:17:36 -0700602TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
603 const string oneway_method =
604 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
605 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
606 ASSERT_NE(nullptr, defined);
607 const AidlInterface* iface = defined->AsInterface();
608 ASSERT_NE(nullptr, iface);
609
610 const auto& methods = iface->GetMethods();
611 ASSERT_EQ(1u, methods.size());
612 const auto& method = methods[0];
613 const AidlTypeSpecifier& ret_type = method->GetType();
614
615 // TODO(b/151102494): these annotations should be on the method
616 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
617 ASSERT_TRUE(ret_type.IsHide());
618}
619
Devin Moore7b8d5c92020-03-17 14:14:08 -0700620TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100621 string foo_interface =
622 "package a; /* foo */ interface IFoo {"
623 " /* i */ int i();"
624 " /* j */ @nullable String j();"
625 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
626
Devin Moore7b8d5c92020-03-17 14:14:08 -0700627 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100628 EXPECT_NE(nullptr, parse_result);
629 EXPECT_EQ("/* foo */", parse_result->GetComments());
630
631 const AidlInterface* interface = parse_result->AsInterface();
632 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
633 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
634 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
635}
636
Jooyung Han1a551d32020-10-05 15:37:26 +0900637TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
638 io_delegate_.SetFileContents("p/cpp_header.aidl",
639 R"(package p;
640 parcelable cpp_header cpp_header "bar/header";)");
641 import_paths_.emplace("");
642 const string input_path = "p/IFoo.aidl";
643 const string input = R"(package p;
644 import p.cpp_header;
645 interface IFoo {
646 // get bar
647 cpp_header get();
648 })";
649
650 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
651 EXPECT_NE(nullptr, parse_result);
652 const AidlInterface* interface = parse_result->AsInterface();
653 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
654}
655
Christopher Wileyef140932015-11-03 09:29:19 -0800656TEST_F(AidlTest, ParsesPreprocessedFile) {
657 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
658 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700659 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900660 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700661 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
662 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800663}
664
665TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
666 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
667 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900668
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700669 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900670 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700671 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
672 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800673}
674
Devin Moore7b8d5c92020-03-17 14:14:08 -0700675TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800676 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
677 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
678 "interface IBar {}");
679 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900680 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900681 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800683 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900684
Christopher Wiley41544372015-11-03 14:52:29 -0800685 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700686 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
687 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800688 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700689 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900690 ambiguous_type.Resolve(typenames_);
691 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800692}
693
Jiyong Park8f6ec462020-01-19 20:52:47 +0900694// Special case of PreferImportToPreprocessed. Imported type should be preferred
695// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700696TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900697 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
698 io_delegate_.SetFileContents("one/IBar.aidl",
699 "package one; "
700 "interface IBar {}");
701 preprocessed_files_.push_back("preprocessed");
702 import_paths_.emplace("");
703 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700704 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900705 EXPECT_NE(nullptr, parse_result);
706
707 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700708 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
709 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900710 // But if we request just "IBar" we should get our imported one.
711 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
712 ambiguous_type.Resolve(typenames_);
713 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
714}
715
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800716TEST_F(AidlTest, WritePreprocessedFile) {
717 io_delegate_.SetFileContents("p/Outer.aidl",
718 "package p; parcelable Outer.Inner;");
719 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
720 "interface IBar {}");
721
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900722 vector<string> args {
723 "aidl",
724 "--preprocess",
725 "preprocessed",
726 "p/Outer.aidl",
727 "one/IBar.aidl"};
728 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800729 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
730
731 string output;
732 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
733 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
734}
735
Jooyung Han720253d2021-01-05 19:13:17 +0900736TEST_P(AidlTest, SupportDeprecated) {
737 struct TestCase {
738 std::string output_file;
739 std::string annotation;
740 };
741
742 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900743 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900744 io_delegate_.SetFileContents(filename, contents);
745
746 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
747 " --out=out --header_out=out");
748 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900749 for (const auto& [lang, test_case] : expectations) {
750 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900751 string output;
752 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output))
753 << base::Join(io_delegate_.ListOutputFiles(), ",");
754 EXPECT_THAT(output, HasSubstr(test_case.annotation));
755 }
756 };
757
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900758 // Emit escaped string for notes
759 CheckDeprecated(
760 "IFoo.aidl",
761 R"(interface IFoo {
762 /**
763 * @note asdf
764 * @deprecated a really long deprecation message
765 *
766 * which is really long
767 * @param foo bar
768 */
769 List<String> foo();
770 })",
771 {
772 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
773 {Options::Language::CPP,
774 {"out/IFoo.h",
775 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
776 {Options::Language::NDK,
777 {"out/aidl/IFoo.h",
778 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
779 {Options::Language::RUST,
780 {"out/IFoo.rs",
781 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
782 });
783
Jooyung Han24effbf2021-01-16 10:24:03 +0900784 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900785 CheckDeprecated(
786 "IFoo.aidl",
787 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900788 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900789 " List<String> foo();\n"
790 "}",
791 {
792 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
793 // TODO(b/177276893) @deprecated should be in javadoc style comments
794 // {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
795 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
796 {Options::Language::NDK,
797 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
798 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
799 });
Jooyung Han720253d2021-01-05 19:13:17 +0900800
Jooyung Han24effbf2021-01-16 10:24:03 +0900801 // but not in line comments
802 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
803 EXPECT_FALSE(parsed->IsDeprecated());
804
805 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900806 CheckDeprecated("Foo.aidl",
807 "parcelable Foo {\n"
808 " /** @deprecated use bar*/\n"
809 " int foo = 0;\n"
810 "}",
811 {
812 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
813 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
814 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
815 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
816 });
817
Jooyung Han24effbf2021-01-16 10:24:03 +0900818 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900819 CheckDeprecated("IFoo.aidl",
820 "interface IFoo {\n"
821 " /** @deprecated use bar*/\n"
822 " const int FOO = 0;\n"
823 "}",
824 {
825 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
826 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
827 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
828 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
829 });
830
831 // union fields
832 CheckDeprecated("Foo.aidl",
833 "union Foo {\n"
834 " int bar = 0;\n"
835 " /** @deprecated use bar*/\n"
836 " int foo;\n"
837 "}",
838 {
839 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
840 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
841 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
842 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
843 });
844
845 CheckDeprecated("Foo.aidl",
846 "/** @deprecated use Bar */\n"
847 "parcelable Foo {}",
848 {
849 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
850 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
851 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
852 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
853 });
854
855 CheckDeprecated("Foo.aidl",
856 "/** @deprecated use Bar */\n"
857 "union Foo { int foo = 0; }",
858 {
859 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
860 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
861 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
862 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
863 });
864
865 CheckDeprecated("IFoo.aidl",
866 "/** @deprecated use IBar */\n"
867 "interface IFoo {}",
868 {
869 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
870 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
871 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
872 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
873 });
874
875 CheckDeprecated("Foo.aidl",
876 "/** @deprecated use IBar */\n"
877 "enum Foo { FOO }",
878 {
879 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
880 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
881 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
882 // TODO(b/174514415) support "deprecated"
883 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
884 });
885}
886
Devin Moore7b8d5c92020-03-17 14:14:08 -0700887TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700888 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800889 io_delegate_.SetFileContents("p/Outer.aidl",
890 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900891 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700892 CaptureStderr();
893 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
894 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700895 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700896 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800897}
898
Devin Moore7b8d5c92020-03-17 14:14:08 -0700899TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800900 io_delegate_.SetFileContents("preprocessed",
901 "parcelable p.Outer.Inner;");
902 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900903 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700904 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800905 // TODO(wiley): This should actually return nullptr because we require
906 // the outer class name. However, for legacy reasons,
907 // this behavior must be maintained. b/17415692
908 EXPECT_NE(nullptr, parse_result);
909}
910
Christopher Wiley632801d2015-11-05 14:15:49 -0800911TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700912 const string expected_foo_stderr =
913 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
914 "Declared parcelables should be in their own file and/or cannot be used with --structured "
915 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700916 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
917
Christopher Wiley632801d2015-11-05 14:15:49 -0800918 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700919 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700920 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900921 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900923
Steven Morelande2c64b42018-09-18 15:06:37 -0700924 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900925 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700926 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900927 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700928 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700929
Devin Moore097a3ab2020-03-11 16:08:44 -0700930 const string expected_bar_stderr =
931 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
932 "Declared parcelables should be in their own file and/or cannot be used with --structured "
933 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700934 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
935
Jiyong Parkda8c6932019-08-12 19:56:08 +0900936 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700937 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900939 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700941 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700943 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700944 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800945}
946
Devin Moore7b8d5c92020-03-17 14:14:08 -0700947TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700948 const string expected_stderr =
949 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
950 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700951 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
952 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 AidlError error;
954 CaptureStderr();
955 EXPECT_EQ(
956 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700957 Parse("p/IFoo.aidl",
958 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700959 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700960 EXPECT_EQ(expected_stderr, GetCapturedStderr());
961 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700962}
963
Devin Moore7b8d5c92020-03-17 14:14:08 -0700964TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700965 AidlError error;
966 const string expected_stderr =
967 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
968 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900969 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
970 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700971 interface IFoo {
972 const String DUPLICATED = "d";
973 const int DUPLICATED = 1;
974 }
975 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700976 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700977 EXPECT_EQ(expected_stderr, GetCapturedStderr());
978 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700979}
980
Steven Morelande689da22020-11-10 02:06:30 +0000981TEST_P(AidlTest, FailOnTooBigConstant) {
982 AidlError error;
983 const string expected_stderr =
984 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
985 CaptureStderr();
986 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
987 R"(package p;
988 interface IFoo {
989 const byte type2small = 256;
990 }
991 )",
992 typenames_, GetLanguage(), &error));
993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
994 EXPECT_EQ(AidlError::BAD_TYPE, error);
995}
996
Jooyung Han30f64ad2020-12-15 08:16:31 +0900997TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
998 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
999 CaptureStderr();
1000 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1001 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1002 EXPECT_EQ("", GetCapturedStderr());
1003 string code;
1004 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1005 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1006}
1007
Jooyung Han535c5e82020-12-29 15:16:59 +09001008TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001009 using Ptr = unique_ptr<AidlConstantValue>;
1010 const AidlLocation& loc = AIDL_LOCATION_HERE;
1011
Jooyung Han535c5e82020-12-29 15:16:59 +09001012 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1013 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1014 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1015 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001016
1017 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1018 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001019 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001020
1021 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1022 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1023 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1024 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001025 EXPECT_EQ(
1026 expected,
1027 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001028}
1029
Devin Moore7b8d5c92020-03-17 14:14:08 -07001030TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001031 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001032 const string expected_stderr =
1033 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001034 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001035 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1036 R"(package p;
1037 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001038 parcelable IBar {}
1039 parcelable StructuredParcelable {}
1040 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001041 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001042 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001043 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001044 // Parse success is important for clear error handling even if the cases aren't
1045 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001046 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001047}
1048
Devin Moore7b8d5c92020-03-17 14:14:08 -07001049TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001050 AidlError error;
1051 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1052 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001053 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1055 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001056}
1057
Steven Morelandf9e922f2020-07-08 21:15:27 +00001058TEST_P(AidlTest, FailOnEmptyListWithComma) {
1059 AidlError error;
1060 const string expected_stderr =
1061 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1062 CaptureStderr();
1063 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1064 typenames_, GetLanguage(), &error));
1065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1066 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1067}
1068
Devin Moore7b8d5c92020-03-17 14:14:08 -07001069TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001070 AidlError error;
1071 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001072 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001073 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001074 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1075 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001076 interface IFoo {
1077 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1078 }
1079 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001081 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1082 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001083}
1084
Jiyong Park18132182020-06-08 20:24:40 +09001085TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1086 AidlError error;
1087 const string expected_stderr =
1088 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1089 "cpp_header (which can also be used as an identifier)\n";
1090 CaptureStderr();
1091 // Notice the trailing dot(.) in the name, which isn't a correct name
1092 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1093 GetLanguage(), &error));
1094 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1095 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1096}
1097
1098TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1099 AidlError error;
1100 const string expected_stderr =
1101 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1102 "cpp_header (which can also be used as an identifier)\n";
1103 CaptureStderr();
1104 // Notice the trailing dot(.) in the package name
1105 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1106 GetLanguage(), &error));
1107 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1108 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1109}
1110
Devin Moore7b8d5c92020-03-17 14:14:08 -07001111TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001112 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001113 auto parse_result = Parse("p/IFoo.aidl",
1114 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001115 interface IFoo {
1116 const int POSITIVE_HEX_VALUE = 0xf5;
1117 }
1118 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001119 typenames_, GetLanguage(), &error);
1120 EXPECT_NE(nullptr, parse_result);
1121 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001122 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001123 const auto& cpp_constants = interface->GetConstantDeclarations();
1124 EXPECT_EQ((size_t)1, cpp_constants.size());
1125 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001126 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001127 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001128}
1129
Devin Moore7b8d5c92020-03-17 14:14:08 -07001130TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001131 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001132 auto parse_result = Parse("p/IFoo.aidl",
1133 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001134 interface IFoo {
1135 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1136 }
1137 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001138 typenames_, GetLanguage(), &error);
1139 ASSERT_NE(nullptr, parse_result);
1140 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001141 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001142 const auto& cpp_constants = interface->GetConstantDeclarations();
1143 EXPECT_EQ((size_t)1, cpp_constants.size());
1144 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001145 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001146 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001150 io_delegate_.SetFileContents(
1151 "p/Outer.aidl",
1152 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001153 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001154 const string input_path = "p/IFoo.aidl";
1155 const string input = "package p; import p.Outer; interface IFoo"
1156 " { Outer.Inner get(); }";
1157
Devin Moore7b8d5c92020-03-17 14:14:08 -07001158 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1159 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001160
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001161 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001162 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001163 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1164 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001165}
1166
Devin Moore7b8d5c92020-03-17 14:14:08 -07001167TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001168 io_delegate_.SetFileContents(
1169 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001170 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001171 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001172 const string input_path = "p/IFoo.aidl";
1173 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001174 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1175 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001176 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001177 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1178 native_type.Resolve(typenames_);
1179
1180 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1181 // C++ understands C++ specific stuff
1182 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1183 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001184 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001185 EXPECT_EQ(1u, headers.size());
1186 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001187}
1188
Christopher Wileyf8136192016-04-12 14:19:35 -07001189TEST_F(AidlTest, WritesCorrectDependencyFile) {
1190 // While the in tree build system always gives us an output file name,
1191 // other android tools take advantage of our ability to infer the intended
1192 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001193 vector<string> args = {
1194 "aidl",
1195 "-d dep/file/path",
1196 "-o place/for/output",
1197 "p/IFoo.aidl"};
1198 Options options = Options::From(args);
1199 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001200 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001201 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001202 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001203 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1204}
1205
Dan Willemsen93298ee2016-11-10 23:55:55 -08001206TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1207 // While the in tree build system always gives us an output file name,
1208 // other android tools take advantage of our ability to infer the intended
1209 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001210 vector<string> args = {
1211 "aidl",
1212 "-d dep/file/path",
1213 "--ninja",
1214 "-o place/for/output",
1215 "p/IFoo.aidl"};
1216 Options options = Options::From(args);
1217 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001218 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001219 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001220 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001221 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1222}
1223
Jiyong Parkdf202122019-09-30 20:48:35 +09001224TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001225 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1226 // this by calling aidl with every .aidl file it finds, then parsing the
1227 // generated dependency files. Those that reference .java output files are
1228 // for interfaces and those that do not are parcelables. However, for both
1229 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001230 vector<string> args = {
1231 "aidl",
1232 "-o place/for/output",
1233 "-d dep/file/path",
1234 "p/Foo.aidl"};
1235 Options options = Options::From(args);
1236 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001237 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001238 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001239 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001240 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1241}
1242
1243TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1244 vector<string> args = {
1245 "aidl",
1246 "--structured",
1247 "-o place/for/output",
1248 "-d dep/file/path",
1249 "p/Foo.aidl"};
1250 Options options = Options::From(args);
1251 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1252 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1253 string actual_dep_file_contents;
1254 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1255 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001256}
1257
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001258TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1259 vector<string> args = {
1260 "aidl",
1261 "--lang=java",
1262 "-o place/for/output",
1263 "p/Foo.aidl"};
1264 Options options = Options::From(args);
1265 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1266 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1267 string output_file_contents;
1268 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1269}
1270
Devin Moore21b26772020-08-26 16:37:56 -07001271TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001272 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001273 const string list_array_parcelable =
1274 "package a; parcelable Foo {\n"
1275 " List[] lists; }";
1276 CaptureStderr();
1277 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1278 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1279}
1280
Jiyong Parkf8d53612020-05-04 14:06:13 +09001281TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1282 AidlError error;
1283 string expected_stderr =
1284 "ERROR: a/IFoo.aidl:2.7-11: "
1285 "Encountered an untyped List or Map. The use of untyped List/Map is "
1286 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1287 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1288 if (GetLanguage() != Options::Language::JAVA) {
1289 expected_stderr =
1290 "ERROR: a/IFoo.aidl:2.1-7: "
1291 "Currently, only the Java backend supports non-generic List.\n";
1292 }
1293
1294 const string primitive_interface =
1295 "package a; interface IFoo {\n"
1296 " List foo(); }";
1297 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001298 AidlTypenames tn1;
1299 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001300 {"--structured"}));
1301 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001302
1303 string primitive_parcelable =
1304 "package a; parcelable IFoo {\n"
1305 " List foo;}";
1306 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001307 AidlTypenames tn2;
1308 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001309 {"--structured"}));
1310 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1311}
1312
Jeongik Cha225519b2020-08-29 01:55:32 +09001313TEST_P(AidlTest, ExtensionTest) {
1314 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001315 string extendable_parcelable =
1316 "package a; parcelable Data {\n"
1317 " ParcelableHolder extension;\n"
1318 " ParcelableHolder extension2;\n"
1319 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001320 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001321 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1322 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001323 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001324 "yet.\n",
1325 GetCapturedStderr());
1326 } else {
1327 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1328 EXPECT_EQ("", GetCapturedStderr());
1329 }
1330}
1331TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1332 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001333 string parcelableholder_return_interface =
1334 "package a; interface IFoo {\n"
1335 " ParcelableHolder foo();\n"
1336 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001337 EXPECT_EQ(nullptr,
1338 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001339
Jeongik Cha8f02a532020-10-14 00:16:28 +09001340 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001341 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001342 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001343 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001344 "yet.\n",
1345 GetCapturedStderr());
1346 return;
1347 }
1348 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1349 GetCapturedStderr());
1350}
1351
1352TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1353 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001354 string extendable_parcelable_arg_interface =
1355 "package a; interface IFoo {\n"
1356 " void foo(in ParcelableHolder ph);\n"
1357 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001358 EXPECT_EQ(nullptr,
1359 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1360
Jeongik Cha8f02a532020-10-14 00:16:28 +09001361 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001362 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001363 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001364 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001365 "yet.\n",
1366 GetCapturedStderr());
1367 return;
1368 }
1369 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1370 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001371}
1372
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001373TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1374 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001375 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001376 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1377 CaptureStderr();
1378 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1379 if (GetLanguage() == Options::Language::RUST) {
1380 EXPECT_EQ(
1381 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1382 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1383 "yet.\n",
1384 GetCapturedStderr());
1385 return;
1386 }
1387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1388}
1389
Jooyung Han3f347ca2020-12-01 12:41:50 +09001390TEST_P(AidlTest, ParcelablesWithConstants) {
1391 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001392 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001393 CaptureStderr();
1394 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1395 EXPECT_EQ("", GetCapturedStderr());
1396}
1397
1398TEST_P(AidlTest, UnionWithConstants) {
1399 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001400 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001401 CaptureStderr();
1402 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1403 EXPECT_EQ("", GetCapturedStderr());
1404}
1405
Jooyung Han633eab62021-01-07 14:12:40 +09001406TEST_F(AidlTest, ConstantsWithAnnotations) {
1407 io_delegate_.SetFileContents("IFoo.aidl",
1408 "interface IFoo {\n"
1409 " @JavaPassthrough(annotation=\"@Foo\")\n"
1410 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1411 "}");
1412 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1413 CaptureStderr();
1414 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1415 EXPECT_EQ("", GetCapturedStderr());
1416 string code;
1417 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1418 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1419 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1420}
1421
Jiyong Park02da7422018-07-16 16:00:26 +09001422TEST_F(AidlTest, ApiDump) {
1423 io_delegate_.SetFileContents(
1424 "foo/bar/IFoo.aidl",
1425 "package foo.bar;\n"
1426 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001427 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001428 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001429 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001430 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1431 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1432 " IFoo foo3(IFoo foo);\n"
1433 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001434 " // @hide\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001435 " /** blahblah\n"
1436 " @deprecated\n"
1437 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001438 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001439 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001440 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001441 "}\n");
1442 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1443 "package foo.bar;\n"
1444 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001445 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001446 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001447 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001448 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001449 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001450 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001451 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001452 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001453 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001454 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001455 "}\n");
1456 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001457 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1458 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001459 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001460 bool result = dump_api(options, io_delegate_);
1461 ASSERT_TRUE(result);
1462 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001463 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001464 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001465interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001466 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001467 int foo(out int[] a, String b, boolean c, inout List<String> d);
1468 int foo2(@utf8InCpp String x, inout List<String> y);
1469 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1470 foo.bar.Data getData();
Jooyung Han9fd67022021-01-13 10:49:48 +09001471 /* @deprecated reason why... */
Jiyong Parke59c3682018-09-11 23:10:25 +09001472 const int A = 1;
1473 const String STR = "Hello";
1474}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001475)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001476
Jiyong Parke59c3682018-09-11 23:10:25 +09001477 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001478 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001479/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001480parcelable Data {
1481 int x = 10;
1482 int y;
1483 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001484 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001485}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001486)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001487}
1488
Jiyong Parked65bf42018-08-28 15:43:27 +09001489TEST_F(AidlTest, ApiDumpWithManualIds) {
1490 io_delegate_.SetFileContents(
1491 "foo/bar/IFoo.aidl",
1492 "package foo.bar;\n"
1493 "interface IFoo {\n"
1494 " int foo() = 1;\n"
1495 " int bar() = 2;\n"
1496 " int baz() = 10;\n"
1497 "}\n");
1498
Jiyong Parke59c3682018-09-11 23:10:25 +09001499 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001500 Options options = Options::From(args);
1501 bool result = dump_api(options, io_delegate_);
1502 ASSERT_TRUE(result);
1503 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001504 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001505 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001506interface IFoo {
1507 int foo() = 1;
1508 int bar() = 2;
1509 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001510}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001511)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001512}
1513
1514TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001515 const string expected_stderr =
1516 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1517 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001518 io_delegate_.SetFileContents(
1519 "foo/bar/IFoo.aidl",
1520 "package foo.bar;\n"
1521 "interface IFoo {\n"
1522 " int foo() = 1;\n"
1523 " int bar();\n"
1524 " int baz() = 10;\n"
1525 "}\n");
1526
Jiyong Parke59c3682018-09-11 23:10:25 +09001527 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001528 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001529 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001530 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001531 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001532}
1533
Jooyung Han965e31d2020-11-27 12:30:16 +09001534TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1535 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1536 "package foo.bar;\n"
1537 "interface IFoo {\n"
1538 " @utf8InCpp String foo();\n"
1539 " const @utf8InCpp String bar = \"bar\";\n"
1540 "}\n");
1541
1542 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1543 Options options = Options::From(args);
1544 CaptureStderr();
1545 EXPECT_TRUE(dump_api(options, io_delegate_));
1546 EXPECT_EQ("", GetCapturedStderr());
1547 string actual;
1548 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001549 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1550interface IFoo {
1551 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001552 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001553}
1554)"),
1555 actual);
1556}
1557
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001558TEST_F(AidlTest, ApiDumpWithEnums) {
1559 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1560 "package foo.bar;\n"
1561 "enum Enum {\n"
1562 " FOO,\n"
1563 " BAR = FOO + 1,\n"
1564 "}\n");
1565
1566 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1567 Options options = Options::From(args);
1568 CaptureStderr();
1569 EXPECT_TRUE(dump_api(options, io_delegate_));
1570 EXPECT_EQ("", GetCapturedStderr());
1571 string actual;
1572 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1573 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1574 "enum Enum {\n"
1575 " FOO = 0,\n"
1576 " BAR = 1,\n"
1577 "}\n"),
1578 actual);
1579}
1580
1581TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1582 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1583 "package foo.bar;\n"
1584 "enum Enum {\n"
1585 " FOO,\n"
1586 "}\n");
1587 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1588 "package foo.bar;\n"
1589 "import foo.bar.Enum;\n"
1590 "parcelable Foo {\n"
1591 " Enum e = Enum.FOO;\n"
1592 "}\n");
1593
1594 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1595 Options options = Options::From(args);
1596 CaptureStderr();
1597 EXPECT_TRUE(dump_api(options, io_delegate_));
1598 EXPECT_EQ("", GetCapturedStderr());
1599 string actual;
1600 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1601 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1602 "parcelable Foo {\n"
1603 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1604 "}\n"),
1605 actual);
1606}
1607
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001608TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001609 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001610 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1611 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001612 const string expected_map_stderr =
1613 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001614 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1615 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001616 "package p; interface IFoo {"
1617 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001618 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001619 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001620 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001621
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001622 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001623 "package p; interface IFoo {"
1624 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001625 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001626 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001627 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001628}
1629
Jeongik Chae48d9942020-01-02 17:39:00 +09001630TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001631 const string expected_stderr =
1632 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001633 Options options = Options::From("aidl -I p p/IFoo.aidl");
1634 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1635
1636 io_delegate_.SetFileContents("p/IFoo.aidl",
1637 "package p; interface IFoo {"
1638 "Map<String, Bar> foo();}");
1639 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1640
1641 io_delegate_.SetFileContents("p/IFoo.aidl",
1642 "package p; interface IFoo {"
1643 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001644 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001645 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001647
1648 io_delegate_.SetFileContents("p/IFoo.aidl",
1649 "package p; interface IFoo {"
1650 "Map<String, String> foo();}");
1651 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1652
1653 io_delegate_.SetFileContents("p/IFoo.aidl",
1654 "package p; interface IFoo {"
1655 "Map<String, ParcelFileDescriptor> foo();}");
1656 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1657}
1658
Jeongik Chadf76dc72019-11-28 00:08:47 +09001659TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001660 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001661 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1662 io_delegate_.SetFileContents(options.InputFiles().front(),
1663 "package p; interface IFoo {"
1664 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001665 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001666 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001667 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001668}
1669
1670TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1671 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1672 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001673 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001674 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001675 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1676 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677
1678 Options options = Options::From("aidl -I p p/IFoo.aidl");
1679 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1680 io_delegate_.SetFileContents("p/IFoo.aidl",
1681 "package p; interface IFoo {"
1682 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001683 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001684 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001685 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001687 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001688 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001689 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1690 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001691 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1692 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1693 io_delegate_.SetFileContents("p/IFoo.aidl",
1694 "package p; interface IFoo {"
1695 "Bar<String, ParcelFileDescriptor> foo();}");
1696 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001697
1698 io_delegate_.SetFileContents("p/IFoo.aidl",
1699 "package p; interface IFoo {"
1700 "Bar<int, long> foo();}");
1701
1702 io_delegate_.SetFileContents("p/IFoo.aidl",
1703 "package p; interface IFoo {"
1704 "Bar<int[], long[]> foo();}");
1705
1706 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001707}
1708
Jeongik Cha0e426012019-07-29 15:57:02 +09001709TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1710 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001711 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1712 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001713 for (const auto& rawOption : rawOptions) {
1714 string expected_stderr =
1715 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001716 Options options = Options::From(rawOption);
1717 io_delegate_.SetFileContents(options.InputFiles().front(),
1718 "package foo.bar;\n"
1719 "interface IFoo1 { int foo(); }\n"
1720 "interface IFoo2 { int foo(); }\n"
1721 "parcelable Data1 { int a; int b;}\n"
1722 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001723 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001724 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001725 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001726
Jeongik Cha0e426012019-07-29 15:57:02 +09001727 io_delegate_.SetFileContents(options.InputFiles().front(),
1728 "package foo.bar;\n"
1729 "interface IFoo1 { int foo(); }\n"
1730 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001731 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001732 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001733 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001734
Devin Moore5de18ed2020-04-02 13:52:29 -07001735 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001736 io_delegate_.SetFileContents(options.InputFiles().front(),
1737 "package foo.bar;\n"
1738 "parcelable Data1 { int a; int b;}\n"
1739 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001740 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001741 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001743 }
1744}
1745
Devin Moorebdba2a82020-03-31 15:19:02 -07001746TEST_P(AidlTest, FailParseOnEmptyFile) {
1747 const string contents = "";
1748 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1749 CaptureStderr();
1750 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1752}
1753
Jiyong Parkb034bf02018-07-30 17:44:33 +09001754TEST_F(AidlTest, MultipleInputFiles) {
1755 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001756 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001757
1758 io_delegate_.SetFileContents(options.InputFiles().at(0),
1759 "package foo.bar;\n"
1760 "import foo.bar.Data;\n"
1761 "interface IFoo { Data getData(); }\n");
1762
1763 io_delegate_.SetFileContents(options.InputFiles().at(1),
1764 "package foo.bar;\n"
1765 "import foo.bar.IFoo;\n"
1766 "parcelable Data { IFoo foo; }\n");
1767
1768 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1769
1770 string content;
1771 for (const auto file : {
1772 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1773 content.clear();
1774 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1775 EXPECT_FALSE(content.empty());
1776 }
1777}
1778
1779TEST_F(AidlTest, MultipleInputFilesCpp) {
1780 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001781 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001782
1783 io_delegate_.SetFileContents(options.InputFiles().at(0),
1784 "package foo.bar;\n"
1785 "import foo.bar.Data;\n"
1786 "interface IFoo { Data getData(); }\n");
1787
1788 io_delegate_.SetFileContents(options.InputFiles().at(1),
1789 "package foo.bar;\n"
1790 "import foo.bar.IFoo;\n"
1791 "parcelable Data { IFoo foo; }\n");
1792
1793 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1794
1795 string content;
1796 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001797 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001798 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1799 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1800 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1801 content.clear();
1802 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1803 EXPECT_FALSE(content.empty());
1804 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001805}
1806
Andrei Homescub62afd92020-05-11 19:24:59 -07001807TEST_F(AidlTest, MultipleInputFilesRust) {
1808 Options options =
1809 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1810
1811 io_delegate_.SetFileContents(options.InputFiles().at(0),
1812 "package foo.bar;\n"
1813 "import foo.bar.Data;\n"
1814 "interface IFoo { Data getData(); }\n");
1815
1816 io_delegate_.SetFileContents(options.InputFiles().at(1),
1817 "package foo.bar;\n"
1818 "import foo.bar.IFoo;\n"
1819 "parcelable Data { IFoo foo; }\n");
1820
1821 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1822
1823 string content;
1824 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1825 content.clear();
1826 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1827 EXPECT_FALSE(content.empty());
1828 }
1829}
1830
Devin Moore097a3ab2020-03-11 16:08:44 -07001831TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1832 const string expected_stderr =
1833 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001834 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1835 // int getInterfaceVersion() is one of the meta transactions
1836 io_delegate_.SetFileContents(options.InputFiles().front(),
1837 "package p; interface IFoo {"
1838 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001839 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001840 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001841 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1842}
Jiyong Park309668e2018-07-28 16:55:44 +09001843
Devin Moore097a3ab2020-03-11 16:08:44 -07001844TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1845 // boolean getInterfaceVersion() is not a meta transaction, but should be
1846 // prevented because return type is not part of a method signature
1847 const string expected_stderr =
1848 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1849 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001850 io_delegate_.SetFileContents(options.InputFiles().front(),
1851 "package p; interface IFoo {"
1852 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001853 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001854 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001855 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1856}
Jiyong Park309668e2018-07-28 16:55:44 +09001857
Devin Moore097a3ab2020-03-11 16:08:44 -07001858TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001859 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001860 const string expected_stderr =
1861 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1862 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001863 io_delegate_.SetFileContents(options.InputFiles().front(),
1864 "package p; interface IFoo {"
1865 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001866 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001867 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001869
1870 // this is not a meta interface method as it differs type arguments
1871 io_delegate_.SetFileContents(options.InputFiles().front(),
1872 "package p; interface IFoo {"
1873 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001874 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001875}
1876
Jooyung Hanb8a97772021-01-19 01:27:38 +09001877TEST_F(AidlTest, CheckApiForEquality) {
1878 CaptureStderr();
1879 Options options = Options::From("aidl --checkapi=equal old new");
1880
1881 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1882 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1883 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1884 "package p; interface IFoo{ @utf8InCpp String foo();}");
1885
1886 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1887 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1888}
1889
Daniel Norman85aed542019-08-21 12:01:14 -07001890TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001891 Options options = Options::From("aidl --checkapi old new");
1892 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1893 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1894 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1895 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1896
1897 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1898}
1899
Jiyong Park3656c3c2018-08-01 20:02:01 +09001900TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001901 Options options = Options::From("aidl --checkapi old new");
1902 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1903 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001904
1905 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1906}
1907
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001908TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1909 Options options = Options::From("aidl --checkapi old new");
1910 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1911 const string enum_definition = "package p; enum Enum { FOO }";
1912 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1913 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1914 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1915 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1916
1917 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1918}
1919
Daniel Norman85aed542019-08-21 12:01:14 -07001920class AidlTestCompatibleChanges : public AidlTest {
1921 protected:
1922 Options options_ = Options::From("aidl --checkapi old new");
1923};
1924
1925TEST_F(AidlTestCompatibleChanges, NewType) {
1926 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1927 "package p;"
1928 "interface IFoo {"
1929 " void foo(int a);"
1930 "}");
1931 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1932 "package p;"
1933 "interface IFoo {"
1934 " void foo(int a);"
1935 "}");
1936 io_delegate_.SetFileContents("new/p/IBar.aidl",
1937 "package p;"
1938 "interface IBar {"
1939 " void bar();"
1940 "}");
1941 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1942}
1943
1944TEST_F(AidlTestCompatibleChanges, NewMethod) {
1945 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1946 "package p;"
1947 "interface IFoo {"
1948 " void foo(int a);"
1949 "}");
1950 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1951 "package p;"
1952 "interface IFoo {"
1953 " void foo(int a);"
1954 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001955 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001956 "}");
1957 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1958}
1959
1960TEST_F(AidlTestCompatibleChanges, NewField) {
1961 io_delegate_.SetFileContents("old/p/Data.aidl",
1962 "package p;"
1963 "parcelable Data {"
1964 " int foo;"
1965 "}");
1966 io_delegate_.SetFileContents("new/p/Data.aidl",
1967 "package p;"
1968 "parcelable Data {"
1969 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001970 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001971 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001972 "}");
1973 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1974}
1975
1976TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1977 io_delegate_.SetFileContents("old/p/Enum.aidl",
1978 "package p;"
1979 "enum Enum {"
1980 " FOO = 1,"
1981 "}");
1982 io_delegate_.SetFileContents("new/p/Enum.aidl",
1983 "package p;"
1984 "enum Enum {"
1985 " FOO = 1,"
1986 " BAR = 2,"
1987 "}");
1988 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1989}
1990
1991TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1992 io_delegate_.SetFileContents("old/p/Enum.aidl",
1993 "package p;"
1994 "enum Enum {"
1995 " FOO = 1,"
1996 " BAR = 2,"
1997 "}");
1998 io_delegate_.SetFileContents("new/p/Enum.aidl",
1999 "package p;"
2000 "enum Enum {"
2001 " BAR = 2,"
2002 " FOO = 1,"
2003 "}");
2004 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2005}
2006
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002007TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2008 io_delegate_.SetFileContents("old/p/Union.aidl",
2009 "package p;"
2010 "union Union {"
2011 " String foo;"
2012 "}");
2013 io_delegate_.SetFileContents("new/p/Union.aidl",
2014 "package p;"
2015 "union Union {"
2016 " String foo;"
2017 " int num;"
2018 "}");
2019 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2020}
2021
Daniel Norman85aed542019-08-21 12:01:14 -07002022TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002023 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2024 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002025 "interface IFoo {"
2026 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002027 "}");
2028 io_delegate_.SetFileContents("old/p/Data.aidl",
2029 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002030 "parcelable Data {"
2031 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002032 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002033 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2034 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002035 "interface IFoo {"
2036 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002037 "}");
2038 io_delegate_.SetFileContents("new/p/Data.aidl",
2039 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002040 "parcelable Data {"
2041 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002042 "}");
2043 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2044 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002045 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002046 " void foo(int a);"
2047 "}");
2048 io_delegate_.SetFileContents("new/q/Data.aidl",
2049 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002050 "parcelable Data {"
2051 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002052 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002053 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2054}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002055
Daniel Norman85aed542019-08-21 12:01:14 -07002056TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2057 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2058 "package p;"
2059 "interface IFoo {"
2060 " void foo(int a);"
2061 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002062 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2063 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002064 "interface IFoo {"
2065 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002066 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002067 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2068}
Jiyong Parke59c3682018-09-11 23:10:25 +09002069
Daniel Norman85aed542019-08-21 12:01:14 -07002070TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002071 io_delegate_.SetFileContents("old/p/I.aidl",
2072 "package p; interface I {"
2073 "const int A = 1; }");
2074 io_delegate_.SetFileContents("new/p/I.aidl",
2075 "package p ; interface I {"
2076 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002077 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2078}
Jiyong Parka428d212018-08-29 22:26:30 +09002079
Daniel Norman85aed542019-08-21 12:01:14 -07002080TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002081 io_delegate_.SetFileContents("old/p/I.aidl",
2082 "package p; interface I {"
2083 "const int A = 1; const int B = 2;}");
2084 io_delegate_.SetFileContents("new/p/I.aidl",
2085 "package p ; interface I {"
2086 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002087 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002088}
2089
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002090TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2091 io_delegate_.SetFileContents("old/p/Foo.aidl",
2092 "package p;"
2093 "@JavaPassthrough(annotation=\"Alice\")"
2094 "@JavaPassthrough(annotation=\"Bob\")"
2095 "parcelable Foo {}");
2096 io_delegate_.SetFileContents("new/p/Foo.aidl",
2097 "package p;"
2098 "@JavaPassthrough(annotation=\"Bob\")"
2099 "@JavaPassthrough(annotation=\"Alice\")"
2100 "parcelable Foo {}");
2101 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2102}
2103
Jooyung Han00073272020-11-27 14:20:20 +09002104TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2105 io_delegate_.SetFileContents("old/p/Foo.aidl",
2106 "package p;"
2107 "parcelable Foo {}");
2108 io_delegate_.SetFileContents("new/p/Foo.aidl",
2109 "package p;"
2110 "@JavaPassthrough(annotation=\"@Deprecated\")"
2111 "parcelable Foo {}");
2112 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2113}
2114
Jooyung Han636fd2f2020-10-22 11:33:45 +09002115TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2116 io_delegate_.SetFileContents("old/p/Data.aidl",
2117 "package p;"
2118 "parcelable Data {"
2119 " int num;"
2120 "}");
2121 io_delegate_.SetFileContents(
2122 "new/p/Data.aidl",
2123 "package p;"
2124 "parcelable Data {"
2125 " int num;"
2126 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2127 "}");
2128 io_delegate_.SetFileContents("new/p/Enum.aidl",
2129 "package p;"
2130 "enum Enum {"
2131 " FOO = 0,"
2132 " BAR = 1,"
2133 "}");
2134 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2135}
2136
Daniel Norman85aed542019-08-21 12:01:14 -07002137class AidlTestIncompatibleChanges : public AidlTest {
2138 protected:
2139 Options options_ = Options::From("aidl --checkapi old new");
2140};
2141
2142TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002143 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002144 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2145 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002146 "interface IFoo {"
2147 " void foo(in String[] str);"
2148 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002149 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002150 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002151 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002153}
2154
2155TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002156 const string expected_stderr =
2157 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002158 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2159 "package p;"
2160 "interface IFoo {"
2161 " void foo(in String[] str);"
2162 " void bar(@utf8InCpp String str);"
2163 "}");
2164 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2165 "package p;"
2166 "interface IFoo {"
2167 " void foo(in String[] str);"
2168 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002170 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002171 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002172}
2173
Jiyong Parkf8d53612020-05-04 14:06:13 +09002174TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2175 const string expected_stderr =
2176 "ERROR: new/p/IFoo.aidl:1.61-65: "
2177 "Encountered an untyped List or Map. The use of untyped List/Map is "
2178 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2179 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2180 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2181 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2182 "package p;"
2183 "interface IFoo {"
2184 " void foo(in String[] str);"
2185 "}");
2186 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2187 "package p;"
2188 "interface IFoo {"
2189 " void foo(in String[] str);"
2190 " void bar(in List arg);"
2191 "}");
2192 CaptureStderr();
2193 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2194 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2195}
2196
2197TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2198 const string expected_stderr =
2199 "ERROR: new/p/Data.aidl:1.54-59: "
2200 "Encountered an untyped List or Map. The use of untyped List/Map is "
2201 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2202 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2203 "ERROR: new/p/Data.aidl: Failed to read.\n";
2204 io_delegate_.SetFileContents("old/p/Data.aidl",
2205 "package p;"
2206 "parcelable Data {"
2207 " int foo;"
2208 "}");
2209 io_delegate_.SetFileContents("new/p/Data.aidl",
2210 "package p;"
2211 "parcelable Data {"
2212 " int foo;"
2213 " @nullable List list;"
2214 "}");
2215 CaptureStderr();
2216 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2217 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2218}
2219
Daniel Norman85aed542019-08-21 12:01:14 -07002220TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002221 const string expected_stderr =
2222 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002223 io_delegate_.SetFileContents("old/p/Data.aidl",
2224 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002225 "parcelable Data {"
2226 " int foo;"
2227 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002228 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002229 io_delegate_.SetFileContents("new/p/Data.aidl",
2230 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002231 "parcelable Data {"
2232 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002233 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002235 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002236 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002237}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002238
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002239TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2240 const string expected_stderr =
2241 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2242 "backends. Please either provide a default value for this field or mark the field as "
2243 "@nullable. This value or a null value will be used automatically when an old version of "
2244 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2245 "order to make sure your code continues to be backwards compatible, make sure the default or "
2246 "null value does not cause a semantic change to this parcelable.\n";
2247 io_delegate_.SetFileContents("old/p/Data.aidl",
2248 "package p;"
2249 "parcelable Data {"
2250 " int num;"
2251 "}");
2252 io_delegate_.SetFileContents("new/p/Data.aidl",
2253 "package p;"
2254 "parcelable Data {"
2255 " int num;"
2256 " String str;"
2257 "}");
2258 CaptureStderr();
2259 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2260 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2261}
2262
Jooyung Han636fd2f2020-10-22 11:33:45 +09002263TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2264 const string expected_stderr =
2265 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2266 "Please make sure 'Enum' has '0' as a valid value.\n";
2267 io_delegate_.SetFileContents("old/p/Data.aidl",
2268 "package p;"
2269 "parcelable Data {"
2270 " int num;"
2271 "}");
2272 io_delegate_.SetFileContents("new/p/Data.aidl",
2273 "package p;"
2274 "parcelable Data {"
2275 " int num;"
2276 " p.Enum e;"
2277 "}");
2278 io_delegate_.SetFileContents("new/p/Enum.aidl",
2279 "package p;"
2280 "enum Enum {"
2281 " FOO = 1,"
2282 " BAR = 2,"
2283 "}");
2284 CaptureStderr();
2285 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2286 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2287}
2288
Daniel Norman85aed542019-08-21 12:01:14 -07002289TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002290 const string expected_stderr =
2291 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002292 io_delegate_.SetFileContents("old/p/Enum.aidl",
2293 "package p;"
2294 "enum Enum {"
2295 " FOO = 1,"
2296 " BAR = 2,"
2297 "}");
2298 io_delegate_.SetFileContents("new/p/Enum.aidl",
2299 "package p;"
2300 "enum Enum {"
2301 " BAR = 2,"
2302 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002303 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002304 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002305 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002306}
2307
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002308TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2309 const string expected_stderr =
2310 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2311 io_delegate_.SetFileContents("old/p/Union.aidl",
2312 "package p;"
2313 "union Union {"
2314 " String str;"
2315 " int num;"
2316 "}");
2317 io_delegate_.SetFileContents("new/p/Union.aidl",
2318 "package p;"
2319 "union Union {"
2320 " String str;"
2321 "}");
2322 CaptureStderr();
2323 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2325}
2326
Daniel Norman85aed542019-08-21 12:01:14 -07002327TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002328 const string expected_stderr =
2329 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002330 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2331 "package p;"
2332 "interface IFoo {"
2333 " void foo(in String[] str);"
2334 " void bar(@utf8InCpp String str);"
2335 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002336 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2337 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002338 "interface IFoo {"
2339 " void foo(in String[] str);"
2340 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002341 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002342 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002343 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002345}
2346
Daniel Norman85aed542019-08-21 12:01:14 -07002347TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002348 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002349 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2350 "package p;"
2351 "interface IFoo {"
2352 " void foo(in String[] str);"
2353 " void bar(@utf8InCpp String str);"
2354 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002355 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2356 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002357 "interface IFoo2 {"
2358 " void foo(in String[] str);"
2359 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002360 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002361 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002362 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002364}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002365
Daniel Norman85aed542019-08-21 12:01:14 -07002366TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002367 const string expected_stderr =
2368 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002369 io_delegate_.SetFileContents("old/p/Enum.aidl",
2370 "package p;"
2371 "enum Enum {"
2372 " FOO = 1,"
2373 " BAR = 2,"
2374 "}");
2375 io_delegate_.SetFileContents("new/p/Enum.aidl",
2376 "package p;"
2377 "enum Enum {"
2378 " FOO = 3,"
2379 " BAR = 2,"
2380 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002382 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002384}
2385
2386TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 const string expected_stderr =
2388 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2389 "from 0 to 1.\n"
2390 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2391 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002392 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2393 "package p;"
2394 "interface IFoo {"
2395 " void foo(in String[] str);"
2396 " void bar(@utf8InCpp String str);"
2397 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002398 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2399 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002400 "interface IFoo {"
2401 " void bar(@utf8InCpp String str);"
2402 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002403 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002404 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002405 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002407}
2408
2409TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002410 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002411 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2412 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002413 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002414 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002415 "parcelable Data {"
2416 " int foo;"
2417 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002418 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002419 io_delegate_.SetFileContents("new/p/Data.aidl",
2420 "package p;"
2421 "parcelable Data {"
2422 " int bar;"
2423 " int foo;"
2424 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002425 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002426 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002428}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002429
Daniel Norman85aed542019-08-21 12:01:14 -07002430TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002431 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002432 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002433 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002434 "interface IFoo {"
2435 " void foo(in String[] str);"
2436 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002437 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002438 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2439 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002440 "interface IFoo {"
2441 " void foo(out String[] str);"
2442 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002443 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002444 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002445 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002447}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002448
Daniel Norman85aed542019-08-21 12:01:14 -07002449TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002450 const string expected_stderr =
2451 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002452 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2453 "package p;"
2454 "interface IFoo {"
2455 " void foo(in String[] str);"
2456 " void bar(@utf8InCpp String str);"
2457 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002458 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2459 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002460 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002461 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002462 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002463 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002464 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002465 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002467}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002468
Daniel Norman85aed542019-08-21 12:01:14 -07002469TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002470 const string expected_stderr =
2471 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002472 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2473 "package p;"
2474 "interface IFoo {"
2475 " void foo(in String[] str);"
2476 " void bar(@utf8InCpp String str);"
2477 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002478 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2479 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002480 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002481 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002482 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002483 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002485 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002486 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002487}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002488
Jooyung Han60b2fde2020-10-29 15:12:40 +09002489TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2490 const string expected_stderr =
2491 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2492 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2493 io_delegate_.SetFileContents("old/p/Foo.aidl",
2494 "package p;"
2495 "@Backing(type=\"byte\")"
2496 "enum Foo {"
2497 " FOO, BAR,"
2498 "}");
2499 io_delegate_.SetFileContents("new/p/Foo.aidl",
2500 "package p;"
2501 "@Backing(type=\"long\")"
2502 "enum Foo {"
2503 " FOO, BAR,"
2504 "}");
2505 CaptureStderr();
2506 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2507 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2508}
2509
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002510TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2511 const string expected_stderr =
2512 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2513 "to @JavaPassthrough(annotation=\"Bob\")\n";
2514 io_delegate_.SetFileContents("old/p/Foo.aidl",
2515 "package p;"
2516 "@JavaPassthrough(annotation=\"Alice\")"
2517 "parcelable Foo {}");
2518 io_delegate_.SetFileContents("new/p/Foo.aidl",
2519 "package p;"
2520 "@JavaPassthrough(annotation=\"Bob\")"
2521 "parcelable Foo {}");
2522
2523 CaptureStderr();
2524 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2525 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2526}
2527
Devin Mooredb7ac512020-08-07 11:17:36 -07002528TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2529 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002530 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002531 io_delegate_.SetFileContents("old/p/Foo.aidl",
2532 "package p;"
2533 "parcelable Foo {"
2534 " int A;"
2535 "}");
2536 io_delegate_.SetFileContents("new/p/Foo.aidl",
2537 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002538 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002539 " int A;"
2540 "}");
2541 CaptureStderr();
2542 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2544}
2545
2546TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2547 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002548 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002549 io_delegate_.SetFileContents("old/p/Foo.aidl",
2550 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002551 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002552 " int A;"
2553 "}");
2554 io_delegate_.SetFileContents("new/p/Foo.aidl",
2555 "package p;"
2556 "parcelable Foo {"
2557 " int A;"
2558 "}");
2559 CaptureStderr();
2560 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2561 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2562}
2563
Daniel Norman85aed542019-08-21 12:01:14 -07002564TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002566 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2567 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002568 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002569 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002570 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002571 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002572}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002573
Daniel Norman85aed542019-08-21 12:01:14 -07002574TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002575 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002576 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2577 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002578 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002579 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002581}
Jiyong Parka428d212018-08-29 22:26:30 +09002582
Daniel Norman85aed542019-08-21 12:01:14 -07002583TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002584 const string expected_stderr =
2585 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002586 io_delegate_.SetFileContents("old/p/I.aidl",
2587 "package p; interface I {"
2588 "const int A = 1; const int B = 2;}");
2589 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002591 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002593}
Jiyong Parka428d212018-08-29 22:26:30 +09002594
Daniel Norman85aed542019-08-21 12:01:14 -07002595TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002596 const string expected_stderr =
2597 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002598 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2599 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002600 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002601 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002602 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002603}
2604
Devin Moorec7e47a32020-08-07 10:55:25 -07002605TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2606 const string expected_stderr =
2607 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2608 "This is an incompatible change for FixedSize types.\n";
2609 io_delegate_.SetFileContents("old/p/Foo.aidl",
2610 "package p; @FixedSize parcelable Foo { int A = 1; }");
2611 io_delegate_.SetFileContents("new/p/Foo.aidl",
2612 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2613 CaptureStderr();
2614 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2615 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2616}
2617
2618TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2619 const string expected_stderr =
2620 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2621 io_delegate_.SetFileContents("old/p/Foo.aidl",
2622 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2623 io_delegate_.SetFileContents("new/p/Foo.aidl",
2624 "package p; @FixedSize parcelable Foo { int A = 1; }");
2625 CaptureStderr();
2626 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2627 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2628}
2629
2630TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2631 const string expected_stderr =
2632 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2633 "a.\n"
2634 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2635 "b.\n"
2636 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2637 "c.\n"
2638 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2639 "d.\n"
2640 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2641 "e.\n"
2642 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2643 "f.\n";
2644
2645 io_delegate_.SetFileContents("Foo.aidl",
2646 "@FixedSize parcelable Foo { "
2647 " int[] a;"
2648 " Bar b;"
2649 " String c;"
2650 " ParcelFileDescriptor d;"
2651 " IBinder e;"
2652 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002653 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002654 "}");
2655 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002656 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002657
2658 CaptureStderr();
2659 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2661}
2662
2663TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2664 const string expected_stderr = "";
2665
2666 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2667 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2668 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002669 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002670
2671 CaptureStderr();
2672 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2673 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2674}
2675
Jiyong Park8c380532018-08-30 14:55:26 +09002676TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002677 const string expected_stderr =
2678 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2679 "dir1/q/IBar.aidl\n"
2680 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002681 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002682 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2683 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2684 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2685 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2686
Devin Moore097a3ab2020-03-11 16:08:44 -07002687 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002688 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002689 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002690}
2691
Jiyong Parked65bf42018-08-28 15:43:27 +09002692TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002693 const string expected_stderr =
2694 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2695 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002696 Options options = Options::From("aidl --checkapi old new");
2697 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2698 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002699
2700 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2701
Jiyong Parke59c3682018-09-11 23:10:25 +09002702 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002703 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002704 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002705 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002706}
2707
Jiyong Parke05195e2018-10-08 18:24:23 +09002708TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2709 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2710 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002711 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002712
2713 // use without import
2714 io_delegate_.SetFileContents("p/IFoo.aidl",
2715 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2716 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2717 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002718 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002719
Devin Moore7b8d5c92020-03-17 14:14:08 -07002720 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002721 io_delegate_.SetFileContents(
2722 "p/IFoo.aidl",
2723 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2724 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2725 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002726 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002727
2728 // use with import (as before)
2729 io_delegate_.SetFileContents("p/IFoo.aidl",
2730 "package p;"
2731 "import android.os.ParcelFileDescriptor;"
2732 "interface IFoo{"
2733 " void foo(in ParcelFileDescriptor fd);"
2734 "}");
2735 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2736 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002737 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002738}
Jiyong Parked65bf42018-08-28 15:43:27 +09002739
Jiyong Park3633b722019-04-11 15:38:26 +09002740TEST_F(AidlTest, ManualIds) {
2741 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2742 io_delegate_.SetFileContents("IFoo.aidl",
2743 "interface IFoo {\n"
2744 " void foo() = 0;\n"
2745 " void bar() = 1;\n"
2746 "}");
2747 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2748}
2749
2750TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2751 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2752 io_delegate_.SetFileContents("IFoo.aidl",
2753 "interface IFoo {\n"
2754 " void foo() = 0;\n"
2755 " void bar() = 1;\n"
2756 "}");
2757 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2758}
2759
2760TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 const string expected_stderr =
2762 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002763 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2764 io_delegate_.SetFileContents("IFoo.aidl",
2765 "interface IFoo {\n"
2766 " void foo() = 3;\n"
2767 " void bar() = 3;\n"
2768 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002769 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002770 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002771 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002772}
2773
2774TEST_F(AidlTest, FailOnOutOfRangeIds) {
2775 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002776 const string expected_stderr =
2777 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2778 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002779 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2780 io_delegate_.SetFileContents("IFoo.aidl",
2781 "interface IFoo {\n"
2782 " void foo() = 3;\n"
2783 " void bar() = 16777115;\n"
2784 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002785 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002786 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002787 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002788}
2789
2790TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002791 const string expected_stderr =
2792 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002793 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2794 io_delegate_.SetFileContents("IFoo.aidl",
2795 "interface IFoo {\n"
2796 " void foo() = 3;\n"
2797 " void bar();\n"
2798 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002799 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002800 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002801 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002802}
2803
Jiyong Parkc6816252019-07-08 08:12:28 +09002804TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2805 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2806 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2807 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2808 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2809}
2810
2811TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002812 const string expected_stderr =
2813 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2814 "dir/IBar.aidl\n"
2815 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002816 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002817
Jiyong Parkc6816252019-07-08 08:12:28 +09002818 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2819 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2820 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2821 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002822 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002823 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002824 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002825}
2826
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002827TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2828 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2829 "package a.b;\n"
2830 "import a.b.IBar;\n"
2831 "import a.b.IQux;\n"
2832 "interface IFoo { IQux foo(); }\n");
2833 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2834 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2835
2836 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2837 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2838
2839 string output;
2840 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2841 // IBar was imported but wasn't used. include is not expected.
2842 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2843 // IBar was imported and used. include is expected.
2844 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2845}
2846
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002847TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002848 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002849 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002850 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2851 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002852 interface IFoo {
2853 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002854 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002855 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002856 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002857 // JavaPassthrough should work with other types as well (e.g. enum)
2858 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2859 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2860 @JavaPassthrough(annotation="@com.android.AliceTwo")
2861 @Backing(type="byte")
2862 enum MyEnum {
2863 a, b, c
2864 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002865
Jooyung Han4cde01d2020-10-13 11:10:47 +09002866 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002867 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2868
2869 string java_out;
2870 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002871 // type-decl-level annotations with newline at the end
2872 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2873 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2874 // member-decl-level annotations with newline at the end
2875 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2876 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2877 // inline annotations with space at the end
2878 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002879
Jooyung Han4cde01d2020-10-13 11:10:47 +09002880 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2881 // type-decl-level annotations with newline at the end
2882 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2883 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2884
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002885 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002886 Options cpp_options =
2887 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002888 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2889
Jooyung Han4cde01d2020-10-13 11:10:47 +09002890 Options ndk_options =
2891 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002892 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002893
Jooyung Han4cde01d2020-10-13 11:10:47 +09002894 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002895 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002896}
2897
Andrei Homescue61feb52020-08-18 15:44:24 -07002898TEST_F(AidlTest, ParseRustDerive) {
2899 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2900 @RustDerive(Clone=true, Copy=false)
2901 parcelable Foo {
2902 int a;
2903 })");
2904
2905 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2906 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2907
2908 string rust_out;
2909 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2910 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2911
2912 // Other backends shouldn't be bothered
2913 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2914 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2915
2916 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2917 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2918
2919 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2920 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2921}
2922
Jiyong Park56f73d72019-06-11 12:20:28 +09002923class AidlOutputPathTest : public AidlTest {
2924 protected:
2925 void SetUp() override {
2926 AidlTest::SetUp();
2927 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2928 }
2929
2930 void Test(const Options& options, const std::string expected_output_path) {
2931 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2932 // check the existence
2933 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2934 }
2935};
2936
2937TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2938 // <out_dir> / <package_name> / <type_name>.java
2939 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2940}
2941
2942TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2943 // when output file is explicitly set, it is always respected. -o option is
2944 // ignored.
2945 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2946}
2947
2948TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2949 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2950}
2951
2952TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2953 // output is the same as the input file except for the suffix
2954 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2955}
2956
Devin Moore7b8d5c92020-03-17 14:14:08 -07002957TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002958 AidlError error;
2959 const string expected_stderr =
2960 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2961 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002962 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2963 R"(package p;
2964 interface IFoo {
2965 const int int32_max_oob = 2147483650;
2966 }
2967 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002968 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002969 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2970 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002971}
2972
Devin Moore7b8d5c92020-03-17 14:14:08 -07002973TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002974 AidlError error;
2975 const string expected_stderr =
2976 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2977 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002978 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2979 R"(package p;
2980 interface IFoo {
2981 const int int32_min_oob = -2147483650;
2982 }
2983 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002984 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2986 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002987}
2988
Devin Moore7b8d5c92020-03-17 14:14:08 -07002989TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002990 AidlError error;
2991 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002992 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002994 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2995 R"(package p;
2996 interface IFoo {
2997 const long int64_max_oob = 21474836509999999999999999;
2998 }
2999 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003000 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003001 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3002 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003003}
3004
Devin Moore7b8d5c92020-03-17 14:14:08 -07003005TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003006 AidlError error;
3007 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003008 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003010 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3011 R"(package p;
3012 interface IFoo {
3013 const long int64_min_oob = -21474836509999999999999999;
3014 }
3015 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003016 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003017 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3018 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003019}
3020
Devin Moore7b8d5c92020-03-17 14:14:08 -07003021TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003022 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003023 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003024 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003025 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3026 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003027 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3028 R"(package p;
3029 @Backing(type="byte")
3030 enum TestEnum {
3031 FOO = 127,
3032 BAR,
3033 }
3034 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003035 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003037 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003038}
3039
Devin Mooredecaf292020-04-30 09:16:40 -07003040TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3041 AidlError error;
3042 const string expected_stderr =
3043 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003044 "be one of: type\n";
3045 CaptureStderr();
3046 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3047 R"(package p;
3048 @Backing(foo="byte")
3049 enum TestEnum {
3050 FOO = 1,
3051 BAR,
3052 }
3053 )",
3054 typenames_, GetLanguage(), &error));
3055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3056 EXPECT_EQ(AidlError::BAD_TYPE, error);
3057}
3058
Jooyung Han5721a232020-12-24 04:34:55 +09003059TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3060 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3061 CaptureStderr();
3062 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3063 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3064}
3065
Jooyung Han66813932020-10-23 13:24:44 +09003066TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003067 io_delegate_.SetFileContents("Foo.aidl",
3068 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3069 "Map<String, Baz> d; Bar[] e; }");
3070 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3071 io_delegate_.SetFileContents("Baz.aidl",
3072 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003073 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3074 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3075}
3076
Jooyung Han66813932020-10-23 13:24:44 +09003077TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003078 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003079 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003080 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003081 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3082 "named 'bar'.\n";
3083 CaptureStderr();
3084 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3085 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3086 EXPECT_EQ(expected_error, GetCapturedStderr());
3087}
3088
3089TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3090 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3091 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3092 string expected_error =
3093 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003094 "named 'bar'.\n";
3095 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003096 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3097 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003098 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003099}
3100
Jooyung Han66813932020-10-23 13:24:44 +09003101TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003102 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003103 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3104 string expected_error =
3105 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3106 "only be an in parameter.\n";
3107 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003108 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3109 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003110 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003111}
3112
Jooyung Han66813932020-10-23 13:24:44 +09003113TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003114 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003115 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3116 string expected_error =
3117 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3118 "only be an in parameter.\n";
3119 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003120 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3121 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003122 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003123}
3124
Jooyung Han66813932020-10-23 13:24:44 +09003125TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003126 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003127 Options options = Options::From("aidl --lang=java Foo.aidl");
3128 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003129 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3130 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003131 CaptureStderr();
3132 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3134}
Devin Moore53fc99c2020-08-12 08:07:52 -07003135
Jooyung Hanfe086af2021-01-16 03:44:47 +09003136TEST_P(AidlTest, UnionInUnion) {
3137 import_paths_.insert(".");
3138 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3139 CaptureStderr();
3140 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3141 EXPECT_THAT("", GetCapturedStderr());
3142}
3143
Jooyung Hanfe89f122020-10-14 03:49:18 +09003144TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3145 const string method = "package a; union Foo {}";
3146 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3147 CaptureStderr();
3148 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3149 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3150}
3151
3152TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3153 const string method = "package a; union Foo { ParcelableHolder x; }";
3154 const string expected_stderr =
3155 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3156 CaptureStderr();
3157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3158 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3159}
3160
Jooyung Han53fb4242020-12-17 16:03:49 +09003161TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3162 import_paths_.insert(".");
3163 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3164 const string expected_err = "The union's first member should have a useful default value.";
3165 CaptureStderr();
3166 EXPECT_EQ(nullptr,
3167 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3168 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3169}
3170
Devin Moore53fc99c2020-08-12 08:07:52 -07003171TEST_P(AidlTest, GenericStructuredParcelable) {
3172 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003173 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003174 const string expected_stderr = "";
3175 CaptureStderr();
3176 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3177 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3178}
3179
Jooyung Han3f347ca2020-12-01 12:41:50 +09003180TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3181 io_delegate_.SetFileContents("Foo.aidl",
3182 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3183 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003184 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003185 const string expected_stderr = "";
3186 CaptureStderr();
3187 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3188 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3189
3190 string code;
3191 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3192 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3193const ::android::String16& Foo<T,U>::s() {
3194 static const ::android::String16 value(::android::String16(""));
3195 return value;
3196})--"));
3197}
3198
3199TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3200 io_delegate_.SetFileContents("Foo.aidl",
3201 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3202 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003203 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003204 const string expected_stderr = "";
3205 CaptureStderr();
3206 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3207 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3208
3209 string code;
3210 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3211 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3212const char* Foo<T, U>::s = "";
3213)--"));
3214}
3215
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003216TEST_F(AidlTest, NestedTypeArgs) {
3217 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003218 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3219
3220 io_delegate_.SetFileContents("a/Foo.aidl",
3221 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3222 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003223 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3224 const string expected_stderr = "";
3225 CaptureStderr();
3226 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3227 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3228
3229 string code;
3230 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003231 EXPECT_THAT(code,
3232 testing::HasSubstr(
3233 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3234}
3235
3236TEST_F(AidlTest, DoubleArrayError) {
3237 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3238
3239 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3240 const string expected_stderr =
3241 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3242 CaptureStderr();
3243 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3244 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3245}
3246
3247TEST_F(AidlTest, DoubleGenericError) {
3248 io_delegate_.SetFileContents("a/Bar.aidl",
3249 "package a; parcelable Bar { List<String><String> a; }");
3250
3251 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3252 const string expected_stderr =
3253 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3254 CaptureStderr();
3255 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3257}
3258
3259TEST_F(AidlTest, ArrayBeforeGenericError) {
3260 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3261
3262 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3263 const string expected_stderr =
3264 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3265 CaptureStderr();
3266 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3267 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003268}
3269
Jooyung Han14004ed2020-10-16 03:49:57 +09003270struct GenericAidlTest : ::testing::Test {
3271 FakeIoDelegate io_delegate_;
3272 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003273 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003274 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3275 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3276 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3277
3278 Options options = Options::From(cmd);
3279 CaptureStderr();
3280 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3281 EXPECT_EQ("", GetCapturedStderr());
3282 }
3283};
3284
3285TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3286 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3287 string code;
3288 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3289 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3290 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3291 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3292}
3293
3294TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3295 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3296 string code;
3297 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3298 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3299 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3300 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3301}
3302
Devin Moore53fc99c2020-08-12 08:07:52 -07003303TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3304 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003305 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003306 const string expected_stderr =
3307 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3308 CaptureStderr();
3309 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3310 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3311}
3312
3313TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3314 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003315 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003316 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3317 CaptureStderr();
3318 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3319 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3320}
3321
Jooyung Han7a308842020-10-27 19:06:49 +09003322TEST_P(AidlTest, LongCommentWithinConstExpression) {
3323 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003324 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003325 CaptureStderr();
3326 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3327 EXPECT_EQ("", GetCapturedStderr());
3328}
3329
Jeongik Chaef44e622020-10-23 16:00:52 +09003330TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3331 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3332 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3333 std::string expectedErr =
3334 "ERROR: a/Foo.aidl:1.28-30: "
3335 "Encountered an untyped List or Map. The use of untyped List/Map is "
3336 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3337 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3338 "ERROR: a/Foo.aidl:1.35-37: "
3339 "Encountered an untyped List or Map. The use of untyped List/Map is "
3340 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3341 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3342 CaptureStderr();
3343 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3344 EXPECT_EQ(expectedErr, GetCapturedStderr());
3345}
3346
3347TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003348 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3349 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003350 std::string expectedErr =
3351 "ERROR: a/Foo.aidl:1.33-35: "
3352 "Encountered an untyped List or Map. The use of untyped List/Map is "
3353 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3354 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3355 "ERROR: a/Foo.aidl:1.40-42: "
3356 "Encountered an untyped List or Map. The use of untyped List/Map is "
3357 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3358 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003359 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003360 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3361 EXPECT_EQ(expectedErr, GetCapturedStderr());
3362}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003363
Jeongik Chaef44e622020-10-23 16:00:52 +09003364TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3365 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3366 io_delegate_.SetFileContents(
3367 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3368 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3369 std::string expectedErr =
3370 "ERROR: a/Foo.aidl:1.52-54: "
3371 "Encountered an untyped List or Map. The use of untyped List/Map is "
3372 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3373 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3374 "ERROR: a/Foo.aidl:1.64-66: "
3375 "Encountered an untyped List or Map. The use of untyped List/Map is "
3376 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3377 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3378 CaptureStderr();
3379 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3380 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003381}
3382
Jooyung Han690f5842020-12-04 13:02:04 +09003383TEST_F(AidlTest, EnumWithDefaults_Java) {
3384 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3385 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3386package p;
3387import p.Enum;
3388parcelable Foo {
3389 Enum e = Enum.BAR;
3390})");
3391 CaptureStderr();
3392 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3393 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3394 auto err = GetCapturedStderr();
3395 EXPECT_EQ("", err);
3396
3397 string code;
3398 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003399 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003400}
3401
3402TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3403 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3404 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3405package p;
3406import p.Enum;
3407parcelable Foo {
3408 Enum e = Enum.BAR;
3409})");
3410 CaptureStderr();
3411 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3412 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3413 auto err = GetCapturedStderr();
3414 EXPECT_EQ("", err);
3415
3416 string code;
3417 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3418 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3419}
3420
3421TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3422 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3423 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3424package p;
3425import p.Enum;
3426parcelable Foo {
3427 Enum e = Enum.BAR;
3428})");
3429 CaptureStderr();
3430 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3431 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3432 auto err = GetCapturedStderr();
3433 EXPECT_EQ("", err);
3434
3435 string code;
3436 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3437 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3438}
3439
3440TEST_F(AidlTest, EnumWithDefaults_Rust) {
3441 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3442 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3443package p;
3444import p.Enum;
3445parcelable Foo {
3446 int n = 42;
3447 Enum e = Enum.BAR;
3448})");
3449 CaptureStderr();
3450 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3451 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3452 auto err = GetCapturedStderr();
3453 EXPECT_EQ("", err);
3454
3455 string code;
3456 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3457 EXPECT_THAT(code, testing::HasSubstr(R"(
3458 fn default() -> Self {
3459 Self {
3460 n: 42,
3461 e: crate::mangled::_1_p_4_Enum::BAR,
3462 }
3463 })"));
3464}
3465
3466TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3467 import_paths_.insert("a");
3468 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3469 CaptureStderr();
3470 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3471package p;
3472import p.Enum;
3473parcelable Foo {
3474 int e = Enum.FOO | Enum.BAR;
3475})",
3476 typenames_, GetLanguage());
3477 auto err = GetCapturedStderr();
3478 EXPECT_EQ("", err);
3479 EXPECT_TRUE(type);
3480 const auto& fields = type->AsStructuredParcelable()->GetFields();
3481 EXPECT_EQ("int e = 3", fields[0]->ToString());
3482}
3483
3484TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3485 CaptureStderr();
3486 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3487@Backing(type="int")
3488enum Foo {
3489 STANDARD_SHIFT = 16,
3490 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3491 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3492}
3493)",
3494 typenames_, GetLanguage());
3495 auto err = GetCapturedStderr();
3496 EXPECT_EQ("", err);
3497 EXPECT_TRUE(type);
3498 const auto& enum_type = type->AsEnumDeclaration();
3499 string code;
3500 enum_type->Dump(CodeWriter::ForString(&code).get());
3501 EXPECT_EQ(R"--(@Backing(type="int")
3502enum Foo {
3503 STANDARD_SHIFT = 16,
3504 STANDARD_BT709 = 65536,
3505 STANDARD_BT601_625 = 131072,
3506}
3507)--",
3508 code);
3509}
3510
3511TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3512 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3513 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3514package p;
3515import p.Enum;
3516parcelable Foo {
3517 Enum e = Enum.FOO | Enum.BAR;
3518})");
3519 CaptureStderr();
3520 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3521 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3522 auto err = GetCapturedStderr();
3523 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3524 err);
3525}
3526
3527TEST_P(AidlTest, DefaultWithEmptyArray) {
3528 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3529 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3530 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003531 auto options =
3532 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003533 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3534 auto err = GetCapturedStderr();
3535 EXPECT_EQ("", err);
3536}
3537
3538TEST_P(AidlTest, RejectRefsInAnnotation) {
3539 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3540 "package p; interface IFoo {\n"
3541 " const String ANNOTATION = \"@Annotation\";\n"
3542 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3543 "}");
3544 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003545 auto options =
3546 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003547 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3548 auto err = GetCapturedStderr();
3549 EXPECT_EQ(
3550 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3551 "ANNOTATION.\n",
3552 err);
3553}
3554
3555TEST_F(AidlTest, DefaultWithEnumValues) {
3556 io_delegate_.SetFileContents(
3557 "a/p/Foo.aidl",
3558 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3559 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3560 CaptureStderr();
3561 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3562 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3563 auto err = GetCapturedStderr();
3564 EXPECT_EQ("", err);
3565 string code;
3566 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3567 EXPECT_THAT(
3568 code, testing::HasSubstr(
3569 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3570}
3571
Jooyung Han14259392020-12-07 10:00:08 +09003572TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3573 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3574 CaptureStderr();
3575 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3576 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3577 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003578 EXPECT_EQ(
3579 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3580 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3581 err);
Jooyung Han14259392020-12-07 10:00:08 +09003582}
3583
3584TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3585 io_delegate_.SetFileContents("a/p/Foo.aidl",
3586 "package p; parcelable Foo { const int A = A + 1; }");
3587 CaptureStderr();
3588 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3589 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3590 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003591 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3592}
3593
3594TEST_F(AidlTest, RecursiveReferences) {
3595 io_delegate_.SetFileContents("a/p/Foo.aidl",
3596 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3597 io_delegate_.SetFileContents("a/p/Bar.aidl",
3598 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3599 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3600 CaptureStderr();
3601 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3602 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3603 EXPECT_EQ("", GetCapturedStderr());
3604}
3605
Jooyung Hane9f5b272021-01-07 00:18:11 +09003606TEST_P(AidlTest, UnknownConstReference) {
3607 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3608 auto options =
3609 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3610 const string err =
3611 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3612 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3613 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3614 CaptureStderr();
3615 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3616 EXPECT_EQ(err, GetCapturedStderr());
3617}
3618
Jooyung Han29813842020-12-08 01:28:03 +09003619TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3620 string contents = R"(
3621import android.os.IBinder;
3622import android.os.IInterface;
3623interface IFoo {}
3624 )";
3625 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003626}
3627
Jooyung Han888c5bc2020-12-22 17:28:47 +09003628TEST_P(AidlTest, WarningInterfaceName) {
3629 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003630 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003631 " -Weverything -o out -h out p/Foo.aidl");
3632 CaptureStderr();
3633 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003634 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003635 GetCapturedStderr());
3636}
3637
3638TEST_P(AidlTest, ErrorInterfaceName) {
3639 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003640 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003641 " -Weverything -Werror -o out -h out p/Foo.aidl");
3642 CaptureStderr();
3643 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003644 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003645 GetCapturedStderr());
3646}
3647
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003648TEST_F(AidlTest, HideIsNotForArgs) {
3649 io_delegate_.SetFileContents("IFoo.aidl",
3650 "interface IFoo {\n"
3651 " void foo(in @Hide int x);\n"
3652 "}");
3653 auto options = Options::From("aidl --lang=java IFoo.aidl");
3654 CaptureStderr();
3655 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3657}
3658
3659TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3660 io_delegate_.SetFileContents(
3661 "IFoo.aidl",
3662 "interface IFoo {\n"
3663 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3664 "}");
3665 auto options = Options::From("aidl --lang=java IFoo.aidl");
3666 CaptureStderr();
3667 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3668 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3669}
3670
Jooyung Hanfd3be322020-12-13 09:11:06 +09003671struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003672 string kind;
3673 string literal;
3674};
3675
Jooyung Hanfd3be322020-12-13 09:11:06 +09003676const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003677 {"primitive", "int"}, {"String", "String"},
3678 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3679 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3680 {"union", "a.Union"}, {"interface", "a.IBar"},
3681};
3682
3683const std::map<std::string, std::string> kListSupportExpectations = {
3684 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3685 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3686 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3687 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
3688 {"cpp_String", ""},
3689 {"java_String", ""},
3690 {"ndk_String", ""},
3691 {"rust_String", ""},
3692 {"cpp_IBinder", ""},
3693 {"java_IBinder", ""},
3694 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3695 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003696 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003697 {"java_ParcelFileDescriptor", ""},
3698 {"ndk_ParcelFileDescriptor", ""},
3699 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003700 {"cpp_interface", "List<a.IBar> is not supported."},
3701 {"java_interface", "List<a.IBar> is not supported."},
3702 {"ndk_interface", "List<a.IBar> is not supported."},
3703 {"rust_interface", "List<a.IBar> is not supported."},
3704 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003705 {"java_parcelable", ""},
3706 {"ndk_parcelable", ""},
3707 {"rust_parcelable", ""},
3708 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3709 {"java_enum", "A generic type cannot have any primitive type parameters."},
3710 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3711 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003712 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003713 {"java_union", ""},
3714 {"ndk_union", ""},
3715 {"rust_union", ""},
3716};
3717
Jooyung Hand236e552020-12-13 09:21:27 +09003718const std::map<std::string, std::string> kArraySupportExpectations = {
3719 {"cpp_primitive", ""},
3720 {"java_primitive", ""},
3721 {"ndk_primitive", ""},
3722 {"rust_primitive", ""},
3723 {"cpp_String", ""},
3724 {"java_String", ""},
3725 {"ndk_String", ""},
3726 {"rust_String", ""},
3727 {"cpp_IBinder", ""},
3728 {"java_IBinder", ""},
3729 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3730 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3731 {"cpp_ParcelFileDescriptor", ""},
3732 {"java_ParcelFileDescriptor", ""},
3733 {"ndk_ParcelFileDescriptor", ""},
3734 {"rust_ParcelFileDescriptor", ""},
3735 {"cpp_interface", "Binder type cannot be an array"},
3736 {"java_interface", "Binder type cannot be an array"},
3737 {"ndk_interface", "Binder type cannot be an array"},
3738 {"rust_interface", "Binder type cannot be an array"},
3739 {"cpp_parcelable", ""},
3740 {"java_parcelable", ""},
3741 {"ndk_parcelable", ""},
3742 {"rust_parcelable", ""},
3743 {"cpp_enum", ""},
3744 {"java_enum", ""},
3745 {"ndk_enum", ""},
3746 {"rust_enum", ""},
3747 {"cpp_union", ""},
3748 {"java_union", ""},
3749 {"ndk_union", ""},
3750 {"rust_union", ""},
3751};
3752
Jooyung Hanfd3be322020-12-13 09:11:06 +09003753class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003754 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003755 void Run(const std::string& generic_type_decl,
3756 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003757 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003758 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003759 const auto& kind = std::get<1>(param).kind;
3760
3761 FakeIoDelegate io;
3762 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3763 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3764 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003765 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3766 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003767
3768 const auto options =
3769 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3770 CaptureStderr();
3771 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003772 auto it = expectations.find(lang + "_" + kind);
3773 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003774 const string err = GetCapturedStderr();
3775 if (it->second.empty()) {
3776 EXPECT_EQ("", err);
3777 } else {
3778 EXPECT_THAT(err, testing::HasSubstr(it->second));
3779 }
3780 }
3781};
3782
3783INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003784 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003785 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3786 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003787 testing::ValuesIn(kTypeParams)),
3788 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003789 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003790 });
3791
Jooyung Hanfd3be322020-12-13 09:11:06 +09003792TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3793 Run("List<{}>", kListSupportExpectations);
3794}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003795
Jooyung Hand236e552020-12-13 09:21:27 +09003796TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3797 Run("{}[]", kArraySupportExpectations);
3798}
3799
Christopher Wiley90be4e32015-10-20 14:55:25 -07003800} // namespace aidl
3801} // namespace android