blob: 05008c9bb90135b03f70e76f12e11f9d7e6d50c4 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070038#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070039
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090040using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070041using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080042using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090043using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045using std::string;
46using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080047using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090048using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070049using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090050using testing::internal::CaptureStderr;
51using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070052
53namespace android {
54namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070055namespace {
56
57const char kExpectedDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60
61p/IFoo.aidl :
62)";
63
Dan Willemsen93298ee2016-11-10 23:55:55 -080064const char kExpectedNinjaDepFileContents[] =
65R"(place/for/output/p/IFoo.java : \
66 p/IFoo.aidl
67)";
68
Jiyong Parkdf202122019-09-30 20:48:35 +090069const char kExpectedParcelableDeclarationDepFileContents[] =
70 R"( : \
71 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
76const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080077 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070078 p/Foo.aidl
79
80p/Foo.aidl :
81)";
82
Christopher Wileyf8136192016-04-12 14:19:35 -070083} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070084
Devin Moore7b8d5c92020-03-17 14:14:08 -070085class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070086 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090087 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
88 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070089 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070090 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090091 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070092 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090093 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070094 for (const string& s : additional_arguments) {
95 args.emplace_back(s);
96 }
97 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090098 args.emplace_back("--preprocessed=" + f);
99 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700100 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--include=" + i);
102 }
103 args.emplace_back(path);
104 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900105 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900106 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700107 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900108 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900109
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 if (error != nullptr) {
111 *error = actual_error;
112 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900113
114 if (actual_error != AidlError::OK) {
115 return nullptr;
116 }
117
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900118 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900119 EXPECT_EQ(1ul, defined_types.size());
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700122 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700123
Devin Moore7b8d5c92020-03-17 14:14:08 -0700124 Options::Language GetLanguage() { return GetParam(); }
125
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800127 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900128 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900129 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700130};
131
Devin Moore7b8d5c92020-03-17 14:14:08 -0700132// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
133// tests with each of the supported languages as a parameter.
134INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
135 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700136 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900138 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700139 });
140
141TEST_P(AidlTest, AcceptMissingPackage) {
142 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700143}
144
Devin Moore7b8d5c92020-03-17 14:14:08 -0700145TEST_P(AidlTest, EndsInSingleLineComment) {
146 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700147}
148
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000149TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
150 const string expected_stderr =
151 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
152 const std::string file_contents = "package a; interface IBar {}";
153 CaptureStderr();
154 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
155 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
156}
157
158TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
159 const string expected_stderr =
160 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
161 const std::string file_contents = "package a; interface Bar {}";
162 CaptureStderr();
163 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
164 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
165}
166
167TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
168 const string expected_stderr =
169 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
170 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
171 CaptureStderr();
172 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
173 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
174}
175
176TEST_P(AidlTest, EnumRequiresCorrectPath) {
177 const string expected_stderr =
178 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
179 const std::string file_contents = "package a; enum Bar { A, }";
180 CaptureStderr();
181 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
182 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
183}
184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900186 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700187 io_delegate_.SetFileContents("bar/IBar.aidl",
188 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700189 const string path = "foo/IFoo.aidl";
190 const string contents =
191 "package foo;\n"
192 "import bar.IBar;\n"
193 "interface IFoo { void f(in IBar[] input); }";
194 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
195 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700196 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700198}
199
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700201 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700202 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900203}
Devin Moore097a3ab2020-03-11 16:08:44 -0700204
Jiyong Park40782d02020-07-24 19:17:43 +0900205TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700206 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
207 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900208 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
209 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700212 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900213}
214
Jiyong Park40782d02020-07-24 19:17:43 +0900215TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700216 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
217 const string expected_stderr =
218 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 CaptureStderr();
220 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900222}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700223
Jiyong Park40782d02020-07-24 19:17:43 +0900224TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700225 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900226 const string expected_stderr =
227 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700229 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700231}
232
Devin Moore7b8d5c92020-03-17 14:14:08 -0700233TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700234 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
235 const string expected_stderr =
236 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
237 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700238 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700240}
241
Devin Moore7b8d5c92020-03-17 14:14:08 -0700242TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700243 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
244 const string expected_stderr =
245 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
246 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700247 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800249}
250
Devin Moore2f2077a2020-08-28 11:27:53 -0700251TEST_P(AidlTest, AcceptNullableList) {
252 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
253 const string expected_stderr = "";
254 CaptureStderr();
255 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
257}
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700260 const string method = "package a; interface IFoo { void f(int a, int a); }";
261 const string expected_stderr =
262 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
263 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700266}
267
Jeongik Cha13066da2020-08-06 15:43:19 +0900268TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
269 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900270 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
274}
275
Jooyung Hand902a972020-10-23 17:32:44 +0900276TEST_P(AidlTest, RejectsRepeatedAnnotations) {
277 const string method = R"(@Hide @Hide parcelable Foo {})";
278 const string expected_stderr =
279 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
280 "Foo.aidl:1.1-6\n";
281 CaptureStderr();
282 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
284}
285
Devin Moore7b8d5c92020-03-17 14:14:08 -0700286TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700287 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
288 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
289 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700290 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100292}
293
Devin Moore7b8d5c92020-03-17 14:14:08 -0700294TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700295 AidlError error;
296 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700297 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700298 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900299 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700300 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800301}
302
Devin Moore7b8d5c92020-03-17 14:14:08 -0700303TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700304 AidlError error;
305 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700306 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700307 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900308 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700309 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800310}
311
Devin Moore7b8d5c92020-03-17 14:14:08 -0700312TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700313 AidlError error;
314 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700315 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000316 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900317 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700318 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800319}
320
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700324 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000325 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900326 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700327 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800328}
329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, ParsesNonNullableAnnotation) {
331 auto parse_result =
332 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
333 ASSERT_NE(nullptr, parse_result);
334 const AidlInterface* interface = parse_result->AsInterface();
335 ASSERT_NE(nullptr, interface);
336 ASSERT_FALSE(interface->GetMethods().empty());
337 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
338}
339
Devin Moore7b8d5c92020-03-17 14:14:08 -0700340TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900341 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
342 typenames_, GetLanguage());
343 ASSERT_NE(nullptr, parse_result);
344 const AidlInterface* interface = parse_result->AsInterface();
345 ASSERT_NE(nullptr, interface);
346 ASSERT_FALSE(interface->GetMethods().empty());
347 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
348}
349
350TEST_P(AidlTest, ParsesNonUtf8Annotations) {
351 auto parse_result =
352 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
353 ASSERT_NE(nullptr, parse_result);
354 const AidlInterface* interface = parse_result->AsInterface();
355 ASSERT_NE(nullptr, interface);
356 ASSERT_FALSE(interface->GetMethods().empty());
357 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900361 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
362 typenames_, GetLanguage());
363 ASSERT_NE(nullptr, parse_result);
364 const AidlInterface* interface = parse_result->AsInterface();
365 ASSERT_NE(nullptr, interface);
366 ASSERT_FALSE(interface->GetMethods().empty());
367 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800368}
369
Devin Moore7b8d5c92020-03-17 14:14:08 -0700370TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700371 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700372 const string expected_stderr =
373 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
374 "\"vintf\"'\n"
375 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
376 "--structured\n";
377 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700378 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700379 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700381 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700385 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700386 const string expected_stderr =
387 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
388 "--structured\n";
389 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700393 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700394}
395
Devin Moore7b8d5c92020-03-17 14:14:08 -0700396TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700397 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700398 const string expected_stderr =
399 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
400 "\"vintf\"'\n";
401 CaptureStderr();
402 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700403 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700404 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700405 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700406}
407
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700409 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700410 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
411 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700412 ASSERT_EQ(AidlError::OK, error);
413 ASSERT_NE(nullptr, parse_result);
414 const AidlInterface* interface = parse_result->AsInterface();
415 ASSERT_NE(nullptr, interface);
416 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700417}
418
Jeongik Cha64783ed2019-06-07 18:30:54 +0900419TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
420 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900421 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
422 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900423 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700424 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900425 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900426 "a/Foo.aidl",
427 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900428
429 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900430 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700431 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900432 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700433 "Parcelable must be defined in AIDL directly.\n";
434 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900435 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700436 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700437
438 CaptureStderr();
439 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900441}
442
Jooyung Han1cbc4962020-10-25 10:07:15 +0900443TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
444 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
445 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
446 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900447 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
448
449 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900450 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900451 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
452
453 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900454 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900455 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
456
Jooyung Han1cbc4962020-10-25 10:07:15 +0900457 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900458 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
459}
460
Jooyung Han1cbc4962020-10-25 10:07:15 +0900461TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
462 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
463 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
464 CaptureStderr();
465 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
466 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
467 EXPECT_EQ("", GetCapturedStderr());
468
469 const string expected_to_string_method = R"--(
470 @Override
471 public String toString() {
472 switch (_tag) {
473 case a: return "a.Foo.a(" + (getA()) + ")";
474 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
475 }
476 throw new IllegalStateException("unknown field: " + _tag);
477 }
478)--";
479
480 string java_out;
481 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
482 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
483}
484
Jiyong Park9aa3d042020-12-04 23:30:02 +0900485TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
486 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
487 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
488 CaptureStderr();
489 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
490 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
491 EXPECT_EQ("", GetCapturedStderr());
492
493 const std::string expected = R"--(
494 @Override
495 public boolean equals(Object other) {
496 if (this == other) return true;
497 if (other == null) return false;
498 if (!(other instanceof Foo)) return false;
499 Foo that = (Foo)other;
500 if (!java.util.Objects.deepEquals(a, that.a)) return false;
501 if (!java.util.Objects.deepEquals(b, that.b)) return false;
502 return true;
503 }
504
505 @Override
506 public int hashCode() {
507 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
508 }
509)--";
510
511 string java_out;
512 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
513 EXPECT_THAT(java_out, testing::HasSubstr(expected));
514}
515
516TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
517 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
518 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
519 CaptureStderr();
520 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
521 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
522 EXPECT_EQ("", GetCapturedStderr());
523
524 const std::string expected = R"--(
525 @Override
526 public boolean equals(Object other) {
527 if (this == other) return true;
528 if (other == null) return false;
529 if (!(other instanceof Foo)) return false;
530 Foo that = (Foo)other;
531 if (_tag != that._tag) return false;
532 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
533 return true;
534 }
535
536 @Override
537 public int hashCode() {
538 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
539 }
540)--";
541
542 string java_out;
543 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
544 EXPECT_THAT(java_out, testing::HasSubstr(expected));
545}
546
Jooyung Han90345002020-10-23 15:28:53 +0900547TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900548 {
Jooyung Han90345002020-10-23 15:28:53 +0900549 io_delegate_.SetFileContents("a/Foo.aidl",
550 "package a; @JavaDerive(blah=true) parcelable Foo{}");
551 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
552 CaptureStderr();
553 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
554 const std::string expected_stderr =
555 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900556 EXPECT_THAT(GetCapturedStderr(),
557 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900558 }
559
560 {
561 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900562 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
563 CaptureStderr();
564 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900565 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900566 }
567
568 {
Jooyung Han90345002020-10-23 15:28:53 +0900569 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900570 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
571 CaptureStderr();
572 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900573 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900574 }
575}
576
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900577TEST_P(AidlTest, ParseDescriptorAnnotation) {
578 AidlError error;
579 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
580 typenames_, GetLanguage(), &error, {"--structured"});
581 ASSERT_EQ(AidlError::OK, error);
582 ASSERT_NE(nullptr, parse_result);
583 const AidlInterface* interface = parse_result->AsInterface();
584 ASSERT_NE(nullptr, interface);
585 ASSERT_EQ("IBar", interface->GetDescriptor());
586}
587
Jiyong Park40782d02020-07-24 19:17:43 +0900588TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700589 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700590 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900591}
592
593TEST_P(AidlTest, AcceptsOnewayInterface) {
594 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700595 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700596}
Christopher Wileyef140932015-11-03 09:29:19 -0800597
Devin Moore7b8d5c92020-03-17 14:14:08 -0700598TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700599 const string oneway_method =
600 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700601 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100602}
603
Steven Moreland65297cc2020-04-20 20:17:36 -0700604TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
605 const string oneway_method =
606 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
607 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
608 ASSERT_NE(nullptr, defined);
609 const AidlInterface* iface = defined->AsInterface();
610 ASSERT_NE(nullptr, iface);
611
612 const auto& methods = iface->GetMethods();
613 ASSERT_EQ(1u, methods.size());
614 const auto& method = methods[0];
615 const AidlTypeSpecifier& ret_type = method->GetType();
616
617 // TODO(b/151102494): these annotations should be on the method
618 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
619 ASSERT_TRUE(ret_type.IsHide());
620}
621
Devin Moore7b8d5c92020-03-17 14:14:08 -0700622TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100623 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900624 R"(package a;
625 /* foo */
626 interface IFoo {
627 /* i */
628 int i();
629 // j
630 @nullable String j();
631 // k1
632 /* k2 */
633 @UnsupportedAppUsage oneway void k(int a);
634 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100635
Jooyung Han8451a202021-01-16 03:07:06 +0900636 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700637 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100638 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900639 EXPECT_EQ("", GetCapturedStderr());
640
Jooyung Han161bb0f2021-01-21 12:30:16 +0900641 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100642
643 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900644 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
645 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
646 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100647}
648
Jooyung Han1a551d32020-10-05 15:37:26 +0900649TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
650 io_delegate_.SetFileContents("p/cpp_header.aidl",
651 R"(package p;
652 parcelable cpp_header cpp_header "bar/header";)");
653 import_paths_.emplace("");
654 const string input_path = "p/IFoo.aidl";
655 const string input = R"(package p;
656 import p.cpp_header;
657 interface IFoo {
658 // get bar
659 cpp_header get();
660 })";
661
662 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
663 EXPECT_NE(nullptr, parse_result);
664 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900665 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900666}
667
Christopher Wileyef140932015-11-03 09:29:19 -0800668TEST_F(AidlTest, ParsesPreprocessedFile) {
669 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
670 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700671 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900672 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700673 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
674 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800675}
676
677TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
678 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
679 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900680
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700681 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900682 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700683 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
684 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800685}
686
Devin Moore7b8d5c92020-03-17 14:14:08 -0700687TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800688 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
689 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
690 "interface IBar {}");
691 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900692 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900693 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700694 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800695 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900696
Christopher Wiley41544372015-11-03 14:52:29 -0800697 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700698 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
699 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800700 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900701 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900702 ambiguous_type.Resolve(typenames_);
703 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800704}
705
Jiyong Park8f6ec462020-01-19 20:52:47 +0900706// Special case of PreferImportToPreprocessed. Imported type should be preferred
707// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700708TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900709 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
710 io_delegate_.SetFileContents("one/IBar.aidl",
711 "package one; "
712 "interface IBar {}");
713 preprocessed_files_.push_back("preprocessed");
714 import_paths_.emplace("");
715 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700716 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900717 EXPECT_NE(nullptr, parse_result);
718
719 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700720 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
721 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900722 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900723 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900724 ambiguous_type.Resolve(typenames_);
725 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
726}
727
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800728TEST_F(AidlTest, WritePreprocessedFile) {
729 io_delegate_.SetFileContents("p/Outer.aidl",
730 "package p; parcelable Outer.Inner;");
731 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
732 "interface IBar {}");
733
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900734 vector<string> args {
735 "aidl",
736 "--preprocess",
737 "preprocessed",
738 "p/Outer.aidl",
739 "one/IBar.aidl"};
740 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800741 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
742
743 string output;
744 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
745 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
746}
747
Jooyung Han720253d2021-01-05 19:13:17 +0900748TEST_P(AidlTest, SupportDeprecated) {
749 struct TestCase {
750 std::string output_file;
751 std::string annotation;
752 };
753
754 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900755 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900756 io_delegate_.SetFileContents(filename, contents);
757
758 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
759 " --out=out --header_out=out");
760 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900761 for (const auto& [lang, test_case] : expectations) {
762 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900763 string output;
764 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output))
765 << base::Join(io_delegate_.ListOutputFiles(), ",");
766 EXPECT_THAT(output, HasSubstr(test_case.annotation));
767 }
768 };
769
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900770 // Emit escaped string for notes
771 CheckDeprecated(
772 "IFoo.aidl",
773 R"(interface IFoo {
774 /**
775 * @note asdf
776 * @deprecated a really long deprecation message
777 *
778 * which is really long
779 * @param foo bar
780 */
781 List<String> foo();
782 })",
783 {
784 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
785 {Options::Language::CPP,
786 {"out/IFoo.h",
787 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
788 {Options::Language::NDK,
789 {"out/aidl/IFoo.h",
790 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
791 {Options::Language::RUST,
792 {"out/IFoo.rs",
793 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
794 });
795
Jooyung Han24effbf2021-01-16 10:24:03 +0900796 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900797 CheckDeprecated(
798 "IFoo.aidl",
799 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900800 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900801 " List<String> foo();\n"
802 "}",
803 {
804 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900805 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900806 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
807 {Options::Language::NDK,
808 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
809 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
810 });
Jooyung Han720253d2021-01-05 19:13:17 +0900811
Jooyung Han24effbf2021-01-16 10:24:03 +0900812 // but not in line comments
813 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
814 EXPECT_FALSE(parsed->IsDeprecated());
815
816 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900817 CheckDeprecated("Foo.aidl",
818 "parcelable Foo {\n"
819 " /** @deprecated use bar*/\n"
820 " int foo = 0;\n"
821 "}",
822 {
823 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
824 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
825 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
826 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
827 });
828
Jooyung Han24effbf2021-01-16 10:24:03 +0900829 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900830 CheckDeprecated("IFoo.aidl",
831 "interface IFoo {\n"
832 " /** @deprecated use bar*/\n"
833 " const int FOO = 0;\n"
834 "}",
835 {
836 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
837 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
838 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
839 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
840 });
841
842 // union fields
843 CheckDeprecated("Foo.aidl",
844 "union Foo {\n"
845 " int bar = 0;\n"
846 " /** @deprecated use bar*/\n"
847 " int foo;\n"
848 "}",
849 {
850 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
851 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
852 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
853 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
854 });
855
856 CheckDeprecated("Foo.aidl",
857 "/** @deprecated use Bar */\n"
858 "parcelable Foo {}",
859 {
860 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
861 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
862 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
863 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
864 });
865
866 CheckDeprecated("Foo.aidl",
867 "/** @deprecated use Bar */\n"
868 "union Foo { int foo = 0; }",
869 {
870 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
871 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
872 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
873 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
874 });
875
876 CheckDeprecated("IFoo.aidl",
877 "/** @deprecated use IBar */\n"
878 "interface IFoo {}",
879 {
880 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
881 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
882 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
883 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
884 });
885
886 CheckDeprecated("Foo.aidl",
887 "/** @deprecated use IBar */\n"
888 "enum Foo { FOO }",
889 {
890 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
891 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
892 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900893 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +0900894 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
895 });
896}
897
Devin Moore7b8d5c92020-03-17 14:14:08 -0700898TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700899 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800900 io_delegate_.SetFileContents("p/Outer.aidl",
901 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900902 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700903 CaptureStderr();
904 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
905 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700906 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700907 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800908}
909
Devin Moore7b8d5c92020-03-17 14:14:08 -0700910TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800911 io_delegate_.SetFileContents("preprocessed",
912 "parcelable p.Outer.Inner;");
913 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900914 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700915 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800916 // TODO(wiley): This should actually return nullptr because we require
917 // the outer class name. However, for legacy reasons,
918 // this behavior must be maintained. b/17415692
919 EXPECT_NE(nullptr, parse_result);
920}
921
Christopher Wiley632801d2015-11-05 14:15:49 -0800922TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700923 const string expected_foo_stderr =
924 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
925 "Declared parcelables should be in their own file and/or cannot be used with --structured "
926 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700927 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
928
Christopher Wiley632801d2015-11-05 14:15:49 -0800929 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700930 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700931 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900932 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700933 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900934
Steven Morelande2c64b42018-09-18 15:06:37 -0700935 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900936 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700937 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900938 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700939 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700940
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 const string expected_bar_stderr =
942 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
943 "Declared parcelables should be in their own file and/or cannot be used with --structured "
944 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700945 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
946
Jiyong Parkda8c6932019-08-12 19:56:08 +0900947 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700948 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700949 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900950 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700952 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700954 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700955 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800956}
957
Devin Moore7b8d5c92020-03-17 14:14:08 -0700958TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700959 const string expected_stderr =
960 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
961 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700962 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
963 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 AidlError error;
965 CaptureStderr();
966 EXPECT_EQ(
967 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700968 Parse("p/IFoo.aidl",
969 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700970 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
972 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700973}
974
Devin Moore7b8d5c92020-03-17 14:14:08 -0700975TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700976 AidlError error;
977 const string expected_stderr =
978 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
979 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900980 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
981 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700982 interface IFoo {
983 const String DUPLICATED = "d";
984 const int DUPLICATED = 1;
985 }
986 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700987 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 EXPECT_EQ(expected_stderr, GetCapturedStderr());
989 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700990}
991
Steven Morelande689da22020-11-10 02:06:30 +0000992TEST_P(AidlTest, FailOnTooBigConstant) {
993 AidlError error;
994 const string expected_stderr =
995 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
996 CaptureStderr();
997 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
998 R"(package p;
999 interface IFoo {
1000 const byte type2small = 256;
1001 }
1002 )",
1003 typenames_, GetLanguage(), &error));
1004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::BAD_TYPE, error);
1006}
1007
Jooyung Han30f64ad2020-12-15 08:16:31 +09001008TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1009 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1010 CaptureStderr();
1011 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1012 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1013 EXPECT_EQ("", GetCapturedStderr());
1014 string code;
1015 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1016 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1017}
1018
Jooyung Han535c5e82020-12-29 15:16:59 +09001019TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001020 using Ptr = unique_ptr<AidlConstantValue>;
1021 const AidlLocation& loc = AIDL_LOCATION_HERE;
1022
Jooyung Han535c5e82020-12-29 15:16:59 +09001023 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1024 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1025 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1026 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001027
1028 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1029 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001030 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001031
1032 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1033 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1034 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1035 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001036 EXPECT_EQ(
1037 expected,
1038 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001039}
1040
Devin Moore7b8d5c92020-03-17 14:14:08 -07001041TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001042 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001043 const string expected_stderr =
1044 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001045 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001046 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1047 R"(package p;
1048 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001049 parcelable IBar {}
1050 parcelable StructuredParcelable {}
1051 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001052 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001053 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001055 // Parse success is important for clear error handling even if the cases aren't
1056 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001057 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001058}
1059
Devin Moore7b8d5c92020-03-17 14:14:08 -07001060TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001061 AidlError error;
1062 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1063 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1066 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001067}
1068
Steven Morelandf9e922f2020-07-08 21:15:27 +00001069TEST_P(AidlTest, FailOnEmptyListWithComma) {
1070 AidlError error;
1071 const string expected_stderr =
1072 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1073 CaptureStderr();
1074 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1075 typenames_, GetLanguage(), &error));
1076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1077 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1078}
1079
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001081 AidlError error;
1082 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001083 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001084 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001085 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1086 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001087 interface IFoo {
1088 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1089 }
1090 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001091 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001092 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1093 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001094}
1095
Jiyong Park18132182020-06-08 20:24:40 +09001096TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1097 AidlError error;
1098 const string expected_stderr =
1099 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1100 "cpp_header (which can also be used as an identifier)\n";
1101 CaptureStderr();
1102 // Notice the trailing dot(.) in the name, which isn't a correct name
1103 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1104 GetLanguage(), &error));
1105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1106 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1107}
1108
1109TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1110 AidlError error;
1111 const string expected_stderr =
1112 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1113 "cpp_header (which can also be used as an identifier)\n";
1114 CaptureStderr();
1115 // Notice the trailing dot(.) in the package name
1116 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1117 GetLanguage(), &error));
1118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1119 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1120}
1121
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001123 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124 auto parse_result = Parse("p/IFoo.aidl",
1125 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001126 interface IFoo {
1127 const int POSITIVE_HEX_VALUE = 0xf5;
1128 }
1129 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001130 typenames_, GetLanguage(), &error);
1131 EXPECT_NE(nullptr, parse_result);
1132 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001133 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001134 const auto& cpp_constants = interface->GetConstantDeclarations();
1135 EXPECT_EQ((size_t)1, cpp_constants.size());
1136 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001137 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001138 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001139}
1140
Devin Moore7b8d5c92020-03-17 14:14:08 -07001141TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143 auto parse_result = Parse("p/IFoo.aidl",
1144 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001145 interface IFoo {
1146 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1147 }
1148 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149 typenames_, GetLanguage(), &error);
1150 ASSERT_NE(nullptr, parse_result);
1151 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001152 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001153 const auto& cpp_constants = interface->GetConstantDeclarations();
1154 EXPECT_EQ((size_t)1, cpp_constants.size());
1155 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001156 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001157 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001158}
1159
Devin Moore7b8d5c92020-03-17 14:14:08 -07001160TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001161 io_delegate_.SetFileContents(
1162 "p/Outer.aidl",
1163 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001164 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001165 const string input_path = "p/IFoo.aidl";
1166 const string input = "package p; import p.Outer; interface IFoo"
1167 " { Outer.Inner get(); }";
1168
Devin Moore7b8d5c92020-03-17 14:14:08 -07001169 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1170 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001171
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001172 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001173 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001174 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001175 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001176}
1177
Devin Moore7b8d5c92020-03-17 14:14:08 -07001178TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001179 io_delegate_.SetFileContents(
1180 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001181 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001182 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001183 const string input_path = "p/IFoo.aidl";
1184 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001185 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1186 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001187 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001188 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001189 native_type.Resolve(typenames_);
1190
1191 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1192 // C++ understands C++ specific stuff
1193 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1194 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001195 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001196 EXPECT_EQ(1u, headers.size());
1197 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001198}
1199
Christopher Wileyf8136192016-04-12 14:19:35 -07001200TEST_F(AidlTest, WritesCorrectDependencyFile) {
1201 // While the in tree build system always gives us an output file name,
1202 // other android tools take advantage of our ability to infer the intended
1203 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001204 vector<string> args = {
1205 "aidl",
1206 "-d dep/file/path",
1207 "-o place/for/output",
1208 "p/IFoo.aidl"};
1209 Options options = Options::From(args);
1210 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001211 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001212 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001213 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001214 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1215}
1216
Dan Willemsen93298ee2016-11-10 23:55:55 -08001217TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1218 // While the in tree build system always gives us an output file name,
1219 // other android tools take advantage of our ability to infer the intended
1220 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001221 vector<string> args = {
1222 "aidl",
1223 "-d dep/file/path",
1224 "--ninja",
1225 "-o place/for/output",
1226 "p/IFoo.aidl"};
1227 Options options = Options::From(args);
1228 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001229 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001230 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001231 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001232 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1233}
1234
Jiyong Parkdf202122019-09-30 20:48:35 +09001235TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001236 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1237 // this by calling aidl with every .aidl file it finds, then parsing the
1238 // generated dependency files. Those that reference .java output files are
1239 // for interfaces and those that do not are parcelables. However, for both
1240 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001241 vector<string> args = {
1242 "aidl",
1243 "-o place/for/output",
1244 "-d dep/file/path",
1245 "p/Foo.aidl"};
1246 Options options = Options::From(args);
1247 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001248 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001249 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001250 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001251 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1252}
1253
1254TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1255 vector<string> args = {
1256 "aidl",
1257 "--structured",
1258 "-o place/for/output",
1259 "-d dep/file/path",
1260 "p/Foo.aidl"};
1261 Options options = Options::From(args);
1262 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1263 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1264 string actual_dep_file_contents;
1265 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1266 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001267}
1268
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001269TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1270 vector<string> args = {
1271 "aidl",
1272 "--lang=java",
1273 "-o place/for/output",
1274 "p/Foo.aidl"};
1275 Options options = Options::From(args);
1276 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1277 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1278 string output_file_contents;
1279 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1280}
1281
Devin Moore21b26772020-08-26 16:37:56 -07001282TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001283 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001284 const string list_array_parcelable =
1285 "package a; parcelable Foo {\n"
1286 " List[] lists; }";
1287 CaptureStderr();
1288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1290}
1291
Jiyong Parkf8d53612020-05-04 14:06:13 +09001292TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1293 AidlError error;
1294 string expected_stderr =
1295 "ERROR: a/IFoo.aidl:2.7-11: "
1296 "Encountered an untyped List or Map. The use of untyped List/Map is "
1297 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1298 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1299 if (GetLanguage() != Options::Language::JAVA) {
1300 expected_stderr =
1301 "ERROR: a/IFoo.aidl:2.1-7: "
1302 "Currently, only the Java backend supports non-generic List.\n";
1303 }
1304
1305 const string primitive_interface =
1306 "package a; interface IFoo {\n"
1307 " List foo(); }";
1308 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001309 AidlTypenames tn1;
1310 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001311 {"--structured"}));
1312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001313
1314 string primitive_parcelable =
1315 "package a; parcelable IFoo {\n"
1316 " List foo;}";
1317 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001318 AidlTypenames tn2;
1319 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001320 {"--structured"}));
1321 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1322}
1323
Jeongik Cha225519b2020-08-29 01:55:32 +09001324TEST_P(AidlTest, ExtensionTest) {
1325 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001326 string extendable_parcelable =
1327 "package a; parcelable Data {\n"
1328 " ParcelableHolder extension;\n"
1329 " ParcelableHolder extension2;\n"
1330 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001331 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001332 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1333 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001334 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001335 "yet.\n",
1336 GetCapturedStderr());
1337 } else {
1338 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1339 EXPECT_EQ("", GetCapturedStderr());
1340 }
1341}
1342TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1343 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001344 string parcelableholder_return_interface =
1345 "package a; interface IFoo {\n"
1346 " ParcelableHolder foo();\n"
1347 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001348 EXPECT_EQ(nullptr,
1349 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001350
Jeongik Cha8f02a532020-10-14 00:16:28 +09001351 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001352 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001353 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001354 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001355 "yet.\n",
1356 GetCapturedStderr());
1357 return;
1358 }
1359 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1360 GetCapturedStderr());
1361}
1362
1363TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1364 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001365 string extendable_parcelable_arg_interface =
1366 "package a; interface IFoo {\n"
1367 " void foo(in ParcelableHolder ph);\n"
1368 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001369 EXPECT_EQ(nullptr,
1370 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1371
Jeongik Cha8f02a532020-10-14 00:16:28 +09001372 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001373 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001374 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001375 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001376 "yet.\n",
1377 GetCapturedStderr());
1378 return;
1379 }
1380 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1381 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001382}
1383
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001384TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1385 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001386 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001387 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1388 CaptureStderr();
1389 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1390 if (GetLanguage() == Options::Language::RUST) {
1391 EXPECT_EQ(
1392 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1393 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1394 "yet.\n",
1395 GetCapturedStderr());
1396 return;
1397 }
1398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1399}
1400
Jooyung Han3f347ca2020-12-01 12:41:50 +09001401TEST_P(AidlTest, ParcelablesWithConstants) {
1402 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001403 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001404 CaptureStderr();
1405 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1406 EXPECT_EQ("", GetCapturedStderr());
1407}
1408
1409TEST_P(AidlTest, UnionWithConstants) {
1410 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001411 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001412 CaptureStderr();
1413 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1414 EXPECT_EQ("", GetCapturedStderr());
1415}
1416
Jooyung Han633eab62021-01-07 14:12:40 +09001417TEST_F(AidlTest, ConstantsWithAnnotations) {
1418 io_delegate_.SetFileContents("IFoo.aidl",
1419 "interface IFoo {\n"
1420 " @JavaPassthrough(annotation=\"@Foo\")\n"
1421 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1422 "}");
1423 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1424 CaptureStderr();
1425 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1426 EXPECT_EQ("", GetCapturedStderr());
1427 string code;
1428 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1429 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1430 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1431}
1432
Jiyong Park02da7422018-07-16 16:00:26 +09001433TEST_F(AidlTest, ApiDump) {
1434 io_delegate_.SetFileContents(
1435 "foo/bar/IFoo.aidl",
1436 "package foo.bar;\n"
1437 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001438 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001439 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001440 " /* @hide applied \n"
1441 " @deprecated use foo2 */\n"
1442 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1443 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001444 " IFoo foo3(IFoo foo);\n"
1445 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001446 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001447 " /** blahblah\n"
1448 " @deprecated\n"
1449 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001450 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001451 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001452 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001453 "}\n");
1454 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1455 "package foo.bar;\n"
1456 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001457 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001458 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001459 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001460 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001461 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001462 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001463 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001464 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001465 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001466 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001467 "}\n");
1468 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001469 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1470 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001471 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001472 bool result = dump_api(options, io_delegate_);
1473 ASSERT_TRUE(result);
1474 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001475 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001476 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001477interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001478 /**
1479 * @hide
1480 * @deprecated use foo2
1481 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001482 int foo(out int[] a, String b, boolean c, inout List<String> d);
1483 int foo2(@utf8InCpp String x, inout List<String> y);
1484 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1485 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001486 /**
1487 * @deprecated reason why...
1488 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001489 const int A = 1;
1490 const String STR = "Hello";
1491}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001492)"),
1493 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001494
Jiyong Parke59c3682018-09-11 23:10:25 +09001495 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001496 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1497/**
1498 * @hide
1499 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001500parcelable Data {
1501 int x = 10;
1502 int y;
1503 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001504 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001505}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001506)"),
1507 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001508}
1509
Jiyong Parked65bf42018-08-28 15:43:27 +09001510TEST_F(AidlTest, ApiDumpWithManualIds) {
1511 io_delegate_.SetFileContents(
1512 "foo/bar/IFoo.aidl",
1513 "package foo.bar;\n"
1514 "interface IFoo {\n"
1515 " int foo() = 1;\n"
1516 " int bar() = 2;\n"
1517 " int baz() = 10;\n"
1518 "}\n");
1519
Jiyong Parke59c3682018-09-11 23:10:25 +09001520 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001521 Options options = Options::From(args);
1522 bool result = dump_api(options, io_delegate_);
1523 ASSERT_TRUE(result);
1524 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001525 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001526 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001527interface IFoo {
1528 int foo() = 1;
1529 int bar() = 2;
1530 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001531}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001532)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001533}
1534
1535TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001536 const string expected_stderr =
1537 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1538 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001539 io_delegate_.SetFileContents(
1540 "foo/bar/IFoo.aidl",
1541 "package foo.bar;\n"
1542 "interface IFoo {\n"
1543 " int foo() = 1;\n"
1544 " int bar();\n"
1545 " int baz() = 10;\n"
1546 "}\n");
1547
Jiyong Parke59c3682018-09-11 23:10:25 +09001548 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001549 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001550 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001551 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001552 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001553}
1554
Jooyung Han965e31d2020-11-27 12:30:16 +09001555TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1556 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1557 "package foo.bar;\n"
1558 "interface IFoo {\n"
1559 " @utf8InCpp String foo();\n"
1560 " const @utf8InCpp String bar = \"bar\";\n"
1561 "}\n");
1562
1563 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1564 Options options = Options::From(args);
1565 CaptureStderr();
1566 EXPECT_TRUE(dump_api(options, io_delegate_));
1567 EXPECT_EQ("", GetCapturedStderr());
1568 string actual;
1569 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001570 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1571interface IFoo {
1572 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001573 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001574}
1575)"),
1576 actual);
1577}
1578
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001579TEST_F(AidlTest, ApiDumpWithEnums) {
1580 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1581 "package foo.bar;\n"
1582 "enum Enum {\n"
1583 " FOO,\n"
1584 " BAR = FOO + 1,\n"
1585 "}\n");
1586
1587 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1588 Options options = Options::From(args);
1589 CaptureStderr();
1590 EXPECT_TRUE(dump_api(options, io_delegate_));
1591 EXPECT_EQ("", GetCapturedStderr());
1592 string actual;
1593 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1594 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1595 "enum Enum {\n"
1596 " FOO = 0,\n"
1597 " BAR = 1,\n"
1598 "}\n"),
1599 actual);
1600}
1601
1602TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1603 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1604 "package foo.bar;\n"
1605 "enum Enum {\n"
1606 " FOO,\n"
1607 "}\n");
1608 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1609 "package foo.bar;\n"
1610 "import foo.bar.Enum;\n"
1611 "parcelable Foo {\n"
1612 " Enum e = Enum.FOO;\n"
1613 "}\n");
1614
1615 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1616 Options options = Options::From(args);
1617 CaptureStderr();
1618 EXPECT_TRUE(dump_api(options, io_delegate_));
1619 EXPECT_EQ("", GetCapturedStderr());
1620 string actual;
1621 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1622 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1623 "parcelable Foo {\n"
1624 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1625 "}\n"),
1626 actual);
1627}
1628
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001629TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001630 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001631 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1632 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001633 const string expected_map_stderr =
1634 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001635 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1636 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001637 "package p; interface IFoo {"
1638 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001639 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001640 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001641 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001642
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001643 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001644 "package p; interface IFoo {"
1645 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001646 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001647 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001648 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001649}
1650
Jeongik Chae48d9942020-01-02 17:39:00 +09001651TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001652 const string expected_stderr =
1653 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001654 Options options = Options::From("aidl -I p p/IFoo.aidl");
1655 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1656
1657 io_delegate_.SetFileContents("p/IFoo.aidl",
1658 "package p; interface IFoo {"
1659 "Map<String, Bar> foo();}");
1660 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1661
1662 io_delegate_.SetFileContents("p/IFoo.aidl",
1663 "package p; interface IFoo {"
1664 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001665 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001666 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001667 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001668
1669 io_delegate_.SetFileContents("p/IFoo.aidl",
1670 "package p; interface IFoo {"
1671 "Map<String, String> foo();}");
1672 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1673
1674 io_delegate_.SetFileContents("p/IFoo.aidl",
1675 "package p; interface IFoo {"
1676 "Map<String, ParcelFileDescriptor> foo();}");
1677 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1678}
1679
Jeongik Chadf76dc72019-11-28 00:08:47 +09001680TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001681 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001682 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1683 io_delegate_.SetFileContents(options.InputFiles().front(),
1684 "package p; interface IFoo {"
1685 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001686 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001687 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001688 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001689}
1690
1691TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1692 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1693 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001694 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001695 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001696 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1697 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001698
1699 Options options = Options::From("aidl -I p p/IFoo.aidl");
1700 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1701 io_delegate_.SetFileContents("p/IFoo.aidl",
1702 "package p; interface IFoo {"
1703 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001704 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001705 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001706 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001707 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001708 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001709 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001710 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1711 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001712 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1713 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1714 io_delegate_.SetFileContents("p/IFoo.aidl",
1715 "package p; interface IFoo {"
1716 "Bar<String, ParcelFileDescriptor> foo();}");
1717 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001718
1719 io_delegate_.SetFileContents("p/IFoo.aidl",
1720 "package p; interface IFoo {"
1721 "Bar<int, long> foo();}");
1722
1723 io_delegate_.SetFileContents("p/IFoo.aidl",
1724 "package p; interface IFoo {"
1725 "Bar<int[], long[]> foo();}");
1726
1727 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001728}
1729
Jeongik Cha0e426012019-07-29 15:57:02 +09001730TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1731 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001732 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1733 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001734 for (const auto& rawOption : rawOptions) {
1735 string expected_stderr =
1736 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001737 Options options = Options::From(rawOption);
1738 io_delegate_.SetFileContents(options.InputFiles().front(),
1739 "package foo.bar;\n"
1740 "interface IFoo1 { int foo(); }\n"
1741 "interface IFoo2 { int foo(); }\n"
1742 "parcelable Data1 { int a; int b;}\n"
1743 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001744 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001745 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001746 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001747
Jeongik Cha0e426012019-07-29 15:57:02 +09001748 io_delegate_.SetFileContents(options.InputFiles().front(),
1749 "package foo.bar;\n"
1750 "interface IFoo1 { int foo(); }\n"
1751 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001752 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001753 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001754 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001755
Devin Moore5de18ed2020-04-02 13:52:29 -07001756 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001757 io_delegate_.SetFileContents(options.InputFiles().front(),
1758 "package foo.bar;\n"
1759 "parcelable Data1 { int a; int b;}\n"
1760 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001761 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001762 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001763 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001764 }
1765}
1766
Devin Moorebdba2a82020-03-31 15:19:02 -07001767TEST_P(AidlTest, FailParseOnEmptyFile) {
1768 const string contents = "";
1769 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1770 CaptureStderr();
1771 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1773}
1774
Jiyong Parkb034bf02018-07-30 17:44:33 +09001775TEST_F(AidlTest, MultipleInputFiles) {
1776 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001777 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001778
1779 io_delegate_.SetFileContents(options.InputFiles().at(0),
1780 "package foo.bar;\n"
1781 "import foo.bar.Data;\n"
1782 "interface IFoo { Data getData(); }\n");
1783
1784 io_delegate_.SetFileContents(options.InputFiles().at(1),
1785 "package foo.bar;\n"
1786 "import foo.bar.IFoo;\n"
1787 "parcelable Data { IFoo foo; }\n");
1788
1789 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1790
1791 string content;
1792 for (const auto file : {
1793 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1794 content.clear();
1795 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1796 EXPECT_FALSE(content.empty());
1797 }
1798}
1799
1800TEST_F(AidlTest, MultipleInputFilesCpp) {
1801 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001802 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001803
1804 io_delegate_.SetFileContents(options.InputFiles().at(0),
1805 "package foo.bar;\n"
1806 "import foo.bar.Data;\n"
1807 "interface IFoo { Data getData(); }\n");
1808
1809 io_delegate_.SetFileContents(options.InputFiles().at(1),
1810 "package foo.bar;\n"
1811 "import foo.bar.IFoo;\n"
1812 "parcelable Data { IFoo foo; }\n");
1813
1814 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1815
1816 string content;
1817 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001818 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001819 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1820 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1821 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1822 content.clear();
1823 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1824 EXPECT_FALSE(content.empty());
1825 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001826}
1827
Andrei Homescub62afd92020-05-11 19:24:59 -07001828TEST_F(AidlTest, MultipleInputFilesRust) {
1829 Options options =
1830 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1831
1832 io_delegate_.SetFileContents(options.InputFiles().at(0),
1833 "package foo.bar;\n"
1834 "import foo.bar.Data;\n"
1835 "interface IFoo { Data getData(); }\n");
1836
1837 io_delegate_.SetFileContents(options.InputFiles().at(1),
1838 "package foo.bar;\n"
1839 "import foo.bar.IFoo;\n"
1840 "parcelable Data { IFoo foo; }\n");
1841
1842 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1843
1844 string content;
1845 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1846 content.clear();
1847 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1848 EXPECT_FALSE(content.empty());
1849 }
1850}
1851
Devin Moore097a3ab2020-03-11 16:08:44 -07001852TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1853 const string expected_stderr =
1854 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001855 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1856 // int getInterfaceVersion() is one of the meta transactions
1857 io_delegate_.SetFileContents(options.InputFiles().front(),
1858 "package p; interface IFoo {"
1859 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001860 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001861 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001862 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1863}
Jiyong Park309668e2018-07-28 16:55:44 +09001864
Devin Moore097a3ab2020-03-11 16:08:44 -07001865TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1866 // boolean getInterfaceVersion() is not a meta transaction, but should be
1867 // prevented because return type is not part of a method signature
1868 const string expected_stderr =
1869 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1870 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001871 io_delegate_.SetFileContents(options.InputFiles().front(),
1872 "package p; interface IFoo {"
1873 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001874 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001875 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001876 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1877}
Jiyong Park309668e2018-07-28 16:55:44 +09001878
Devin Moore097a3ab2020-03-11 16:08:44 -07001879TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001880 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001881 const string expected_stderr =
1882 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1883 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001884 io_delegate_.SetFileContents(options.InputFiles().front(),
1885 "package p; interface IFoo {"
1886 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001887 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001888 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001889 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001890
1891 // this is not a meta interface method as it differs type arguments
1892 io_delegate_.SetFileContents(options.InputFiles().front(),
1893 "package p; interface IFoo {"
1894 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001895 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001896}
1897
Jooyung Hanb8a97772021-01-19 01:27:38 +09001898TEST_F(AidlTest, CheckApiForEquality) {
1899 CaptureStderr();
1900 Options options = Options::From("aidl --checkapi=equal old new");
1901
1902 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1903 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1904 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1905 "package p; interface IFoo{ @utf8InCpp String foo();}");
1906
1907 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1908 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1909}
1910
Daniel Norman85aed542019-08-21 12:01:14 -07001911TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001912 Options options = Options::From("aidl --checkapi old new");
1913 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1914 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1915 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1916 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1917
1918 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1919}
1920
Jiyong Park3656c3c2018-08-01 20:02:01 +09001921TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001922 Options options = Options::From("aidl --checkapi old new");
1923 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1924 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001925
1926 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1927}
1928
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001929TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1930 Options options = Options::From("aidl --checkapi old new");
1931 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1932 const string enum_definition = "package p; enum Enum { FOO }";
1933 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1934 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1935 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1936 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1937
1938 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1939}
1940
Daniel Norman85aed542019-08-21 12:01:14 -07001941class AidlTestCompatibleChanges : public AidlTest {
1942 protected:
1943 Options options_ = Options::From("aidl --checkapi old new");
1944};
1945
1946TEST_F(AidlTestCompatibleChanges, NewType) {
1947 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1948 "package p;"
1949 "interface IFoo {"
1950 " void foo(int a);"
1951 "}");
1952 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1953 "package p;"
1954 "interface IFoo {"
1955 " void foo(int a);"
1956 "}");
1957 io_delegate_.SetFileContents("new/p/IBar.aidl",
1958 "package p;"
1959 "interface IBar {"
1960 " void bar();"
1961 "}");
1962 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1963}
1964
1965TEST_F(AidlTestCompatibleChanges, NewMethod) {
1966 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1967 "package p;"
1968 "interface IFoo {"
1969 " void foo(int a);"
1970 "}");
1971 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1972 "package p;"
1973 "interface IFoo {"
1974 " void foo(int a);"
1975 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001976 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001977 "}");
1978 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1979}
1980
1981TEST_F(AidlTestCompatibleChanges, NewField) {
1982 io_delegate_.SetFileContents("old/p/Data.aidl",
1983 "package p;"
1984 "parcelable Data {"
1985 " int foo;"
1986 "}");
1987 io_delegate_.SetFileContents("new/p/Data.aidl",
1988 "package p;"
1989 "parcelable Data {"
1990 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001991 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001992 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001993 "}");
1994 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1995}
1996
1997TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1998 io_delegate_.SetFileContents("old/p/Enum.aidl",
1999 "package p;"
2000 "enum Enum {"
2001 " FOO = 1,"
2002 "}");
2003 io_delegate_.SetFileContents("new/p/Enum.aidl",
2004 "package p;"
2005 "enum Enum {"
2006 " FOO = 1,"
2007 " BAR = 2,"
2008 "}");
2009 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2010}
2011
2012TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2013 io_delegate_.SetFileContents("old/p/Enum.aidl",
2014 "package p;"
2015 "enum Enum {"
2016 " FOO = 1,"
2017 " BAR = 2,"
2018 "}");
2019 io_delegate_.SetFileContents("new/p/Enum.aidl",
2020 "package p;"
2021 "enum Enum {"
2022 " BAR = 2,"
2023 " FOO = 1,"
2024 "}");
2025 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2026}
2027
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002028TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2029 io_delegate_.SetFileContents("old/p/Union.aidl",
2030 "package p;"
2031 "union Union {"
2032 " String foo;"
2033 "}");
2034 io_delegate_.SetFileContents("new/p/Union.aidl",
2035 "package p;"
2036 "union Union {"
2037 " String foo;"
2038 " int num;"
2039 "}");
2040 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2041}
2042
Daniel Norman85aed542019-08-21 12:01:14 -07002043TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002044 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2045 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002046 "interface IFoo {"
2047 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002048 "}");
2049 io_delegate_.SetFileContents("old/p/Data.aidl",
2050 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002051 "parcelable Data {"
2052 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002053 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002054 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2055 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002056 "interface IFoo {"
2057 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002058 "}");
2059 io_delegate_.SetFileContents("new/p/Data.aidl",
2060 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002061 "parcelable Data {"
2062 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002063 "}");
2064 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2065 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002066 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002067 " void foo(int a);"
2068 "}");
2069 io_delegate_.SetFileContents("new/q/Data.aidl",
2070 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002071 "parcelable Data {"
2072 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002073 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002074 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2075}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002076
Daniel Norman85aed542019-08-21 12:01:14 -07002077TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2078 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2079 "package p;"
2080 "interface IFoo {"
2081 " void foo(int a);"
2082 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002083 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2084 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002085 "interface IFoo {"
2086 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002087 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002088 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2089}
Jiyong Parke59c3682018-09-11 23:10:25 +09002090
Daniel Norman85aed542019-08-21 12:01:14 -07002091TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002092 io_delegate_.SetFileContents("old/p/I.aidl",
2093 "package p; interface I {"
2094 "const int A = 1; }");
2095 io_delegate_.SetFileContents("new/p/I.aidl",
2096 "package p ; interface I {"
2097 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002098 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2099}
Jiyong Parka428d212018-08-29 22:26:30 +09002100
Daniel Norman85aed542019-08-21 12:01:14 -07002101TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002102 io_delegate_.SetFileContents("old/p/I.aidl",
2103 "package p; interface I {"
2104 "const int A = 1; const int B = 2;}");
2105 io_delegate_.SetFileContents("new/p/I.aidl",
2106 "package p ; interface I {"
2107 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002108 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002109}
2110
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002111TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2112 io_delegate_.SetFileContents("old/p/Foo.aidl",
2113 "package p;"
2114 "@JavaPassthrough(annotation=\"Alice\")"
2115 "@JavaPassthrough(annotation=\"Bob\")"
2116 "parcelable Foo {}");
2117 io_delegate_.SetFileContents("new/p/Foo.aidl",
2118 "package p;"
2119 "@JavaPassthrough(annotation=\"Bob\")"
2120 "@JavaPassthrough(annotation=\"Alice\")"
2121 "parcelable Foo {}");
2122 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2123}
2124
Jooyung Han00073272020-11-27 14:20:20 +09002125TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2126 io_delegate_.SetFileContents("old/p/Foo.aidl",
2127 "package p;"
2128 "parcelable Foo {}");
2129 io_delegate_.SetFileContents("new/p/Foo.aidl",
2130 "package p;"
2131 "@JavaPassthrough(annotation=\"@Deprecated\")"
2132 "parcelable Foo {}");
2133 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2134}
2135
Jooyung Han636fd2f2020-10-22 11:33:45 +09002136TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2137 io_delegate_.SetFileContents("old/p/Data.aidl",
2138 "package p;"
2139 "parcelable Data {"
2140 " int num;"
2141 "}");
2142 io_delegate_.SetFileContents(
2143 "new/p/Data.aidl",
2144 "package p;"
2145 "parcelable Data {"
2146 " int num;"
2147 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2148 "}");
2149 io_delegate_.SetFileContents("new/p/Enum.aidl",
2150 "package p;"
2151 "enum Enum {"
2152 " FOO = 0,"
2153 " BAR = 1,"
2154 "}");
2155 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2156}
2157
Daniel Norman85aed542019-08-21 12:01:14 -07002158class AidlTestIncompatibleChanges : public AidlTest {
2159 protected:
2160 Options options_ = Options::From("aidl --checkapi old new");
2161};
2162
2163TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002164 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002165 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2166 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002167 "interface IFoo {"
2168 " void foo(in String[] str);"
2169 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002170 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002171 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002172 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002173 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002174}
2175
2176TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002177 const string expected_stderr =
2178 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002179 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2180 "package p;"
2181 "interface IFoo {"
2182 " void foo(in String[] str);"
2183 " void bar(@utf8InCpp String str);"
2184 "}");
2185 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2186 "package p;"
2187 "interface IFoo {"
2188 " void foo(in String[] str);"
2189 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002190 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002191 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002193}
2194
Jiyong Parkf8d53612020-05-04 14:06:13 +09002195TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2196 const string expected_stderr =
2197 "ERROR: new/p/IFoo.aidl:1.61-65: "
2198 "Encountered an untyped List or Map. The use of untyped List/Map is "
2199 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2200 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2201 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2202 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2203 "package p;"
2204 "interface IFoo {"
2205 " void foo(in String[] str);"
2206 "}");
2207 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2208 "package p;"
2209 "interface IFoo {"
2210 " void foo(in String[] str);"
2211 " void bar(in List arg);"
2212 "}");
2213 CaptureStderr();
2214 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2216}
2217
2218TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2219 const string expected_stderr =
2220 "ERROR: new/p/Data.aidl:1.54-59: "
2221 "Encountered an untyped List or Map. The use of untyped List/Map is "
2222 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2223 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2224 "ERROR: new/p/Data.aidl: Failed to read.\n";
2225 io_delegate_.SetFileContents("old/p/Data.aidl",
2226 "package p;"
2227 "parcelable Data {"
2228 " int foo;"
2229 "}");
2230 io_delegate_.SetFileContents("new/p/Data.aidl",
2231 "package p;"
2232 "parcelable Data {"
2233 " int foo;"
2234 " @nullable List list;"
2235 "}");
2236 CaptureStderr();
2237 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2239}
2240
Daniel Norman85aed542019-08-21 12:01:14 -07002241TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002242 const string expected_stderr =
2243 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002244 io_delegate_.SetFileContents("old/p/Data.aidl",
2245 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002246 "parcelable Data {"
2247 " int foo;"
2248 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002249 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002250 io_delegate_.SetFileContents("new/p/Data.aidl",
2251 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002252 "parcelable Data {"
2253 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002254 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002255 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002256 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002258}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002259
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002260TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2261 const string expected_stderr =
2262 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2263 "backends. Please either provide a default value for this field or mark the field as "
2264 "@nullable. This value or a null value will be used automatically when an old version of "
2265 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2266 "order to make sure your code continues to be backwards compatible, make sure the default or "
2267 "null value does not cause a semantic change to this parcelable.\n";
2268 io_delegate_.SetFileContents("old/p/Data.aidl",
2269 "package p;"
2270 "parcelable Data {"
2271 " int num;"
2272 "}");
2273 io_delegate_.SetFileContents("new/p/Data.aidl",
2274 "package p;"
2275 "parcelable Data {"
2276 " int num;"
2277 " String str;"
2278 "}");
2279 CaptureStderr();
2280 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2282}
2283
Jooyung Han636fd2f2020-10-22 11:33:45 +09002284TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2285 const string expected_stderr =
2286 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2287 "Please make sure 'Enum' has '0' as a valid value.\n";
2288 io_delegate_.SetFileContents("old/p/Data.aidl",
2289 "package p;"
2290 "parcelable Data {"
2291 " int num;"
2292 "}");
2293 io_delegate_.SetFileContents("new/p/Data.aidl",
2294 "package p;"
2295 "parcelable Data {"
2296 " int num;"
2297 " p.Enum e;"
2298 "}");
2299 io_delegate_.SetFileContents("new/p/Enum.aidl",
2300 "package p;"
2301 "enum Enum {"
2302 " FOO = 1,"
2303 " BAR = 2,"
2304 "}");
2305 CaptureStderr();
2306 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2307 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2308}
2309
Daniel Norman85aed542019-08-21 12:01:14 -07002310TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002311 const string expected_stderr =
2312 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002313 io_delegate_.SetFileContents("old/p/Enum.aidl",
2314 "package p;"
2315 "enum Enum {"
2316 " FOO = 1,"
2317 " BAR = 2,"
2318 "}");
2319 io_delegate_.SetFileContents("new/p/Enum.aidl",
2320 "package p;"
2321 "enum Enum {"
2322 " BAR = 2,"
2323 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002324 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002325 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002326 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002327}
2328
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002329TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2330 const string expected_stderr =
2331 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2332 io_delegate_.SetFileContents("old/p/Union.aidl",
2333 "package p;"
2334 "union Union {"
2335 " String str;"
2336 " int num;"
2337 "}");
2338 io_delegate_.SetFileContents("new/p/Union.aidl",
2339 "package p;"
2340 "union Union {"
2341 " String str;"
2342 "}");
2343 CaptureStderr();
2344 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2346}
2347
Daniel Norman85aed542019-08-21 12:01:14 -07002348TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002349 const string expected_stderr =
2350 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002351 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2352 "package p;"
2353 "interface IFoo {"
2354 " void foo(in String[] str);"
2355 " void bar(@utf8InCpp String str);"
2356 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002357 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2358 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002359 "interface IFoo {"
2360 " void foo(in String[] str);"
2361 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002362 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002363 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002364 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002366}
2367
Daniel Norman85aed542019-08-21 12:01:14 -07002368TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002370 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2371 "package p;"
2372 "interface IFoo {"
2373 " void foo(in String[] str);"
2374 " void bar(@utf8InCpp String str);"
2375 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002376 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2377 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002378 "interface IFoo2 {"
2379 " void foo(in String[] str);"
2380 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002381 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002382 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002383 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002384 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002385}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002386
Daniel Norman85aed542019-08-21 12:01:14 -07002387TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002388 const string expected_stderr =
2389 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002390 io_delegate_.SetFileContents("old/p/Enum.aidl",
2391 "package p;"
2392 "enum Enum {"
2393 " FOO = 1,"
2394 " BAR = 2,"
2395 "}");
2396 io_delegate_.SetFileContents("new/p/Enum.aidl",
2397 "package p;"
2398 "enum Enum {"
2399 " FOO = 3,"
2400 " BAR = 2,"
2401 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002402 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002403 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002404 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002405}
2406
2407TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002408 const string expected_stderr =
2409 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2410 "from 0 to 1.\n"
2411 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2412 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002413 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2414 "package p;"
2415 "interface IFoo {"
2416 " void foo(in String[] str);"
2417 " void bar(@utf8InCpp String str);"
2418 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002419 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2420 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002421 "interface IFoo {"
2422 " void bar(@utf8InCpp String str);"
2423 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002424 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002425 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002426 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002428}
2429
2430TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002431 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002432 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2433 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002434 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002435 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002436 "parcelable Data {"
2437 " int foo;"
2438 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002439 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002440 io_delegate_.SetFileContents("new/p/Data.aidl",
2441 "package p;"
2442 "parcelable Data {"
2443 " int bar;"
2444 " int foo;"
2445 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002446 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002447 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002448 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002449}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002450
Daniel Norman85aed542019-08-21 12:01:14 -07002451TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002452 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002453 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002454 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002455 "interface IFoo {"
2456 " void foo(in String[] str);"
2457 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002458 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002459 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2460 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002461 "interface IFoo {"
2462 " void foo(out String[] str);"
2463 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002464 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002465 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002466 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002468}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002469
Daniel Norman85aed542019-08-21 12:01:14 -07002470TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002471 const string expected_stderr =
2472 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002473 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2474 "package p;"
2475 "interface IFoo {"
2476 " void foo(in String[] str);"
2477 " void bar(@utf8InCpp String str);"
2478 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002479 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2480 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002481 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002482 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002483 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002484 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002485 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002486 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002487 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002488}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002489
Daniel Norman85aed542019-08-21 12:01:14 -07002490TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002491 const string expected_stderr =
2492 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002493 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2494 "package p;"
2495 "interface IFoo {"
2496 " void foo(in String[] str);"
2497 " void bar(@utf8InCpp String str);"
2498 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002499 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2500 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002501 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002502 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002503 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002504 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002505 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002506 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002507 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002508}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002509
Jooyung Han60b2fde2020-10-29 15:12:40 +09002510TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2511 const string expected_stderr =
2512 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2513 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2514 io_delegate_.SetFileContents("old/p/Foo.aidl",
2515 "package p;"
2516 "@Backing(type=\"byte\")"
2517 "enum Foo {"
2518 " FOO, BAR,"
2519 "}");
2520 io_delegate_.SetFileContents("new/p/Foo.aidl",
2521 "package p;"
2522 "@Backing(type=\"long\")"
2523 "enum Foo {"
2524 " FOO, BAR,"
2525 "}");
2526 CaptureStderr();
2527 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2528 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2529}
2530
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002531TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2532 const string expected_stderr =
2533 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2534 "to @JavaPassthrough(annotation=\"Bob\")\n";
2535 io_delegate_.SetFileContents("old/p/Foo.aidl",
2536 "package p;"
2537 "@JavaPassthrough(annotation=\"Alice\")"
2538 "parcelable Foo {}");
2539 io_delegate_.SetFileContents("new/p/Foo.aidl",
2540 "package p;"
2541 "@JavaPassthrough(annotation=\"Bob\")"
2542 "parcelable Foo {}");
2543
2544 CaptureStderr();
2545 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2546 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2547}
2548
Devin Mooredb7ac512020-08-07 11:17:36 -07002549TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2550 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002551 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002552 io_delegate_.SetFileContents("old/p/Foo.aidl",
2553 "package p;"
2554 "parcelable Foo {"
2555 " int A;"
2556 "}");
2557 io_delegate_.SetFileContents("new/p/Foo.aidl",
2558 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002559 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002560 " int A;"
2561 "}");
2562 CaptureStderr();
2563 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2564 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2565}
2566
2567TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2568 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002569 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002570 io_delegate_.SetFileContents("old/p/Foo.aidl",
2571 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002572 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002573 " int A;"
2574 "}");
2575 io_delegate_.SetFileContents("new/p/Foo.aidl",
2576 "package p;"
2577 "parcelable Foo {"
2578 " int A;"
2579 "}");
2580 CaptureStderr();
2581 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2582 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2583}
2584
Daniel Norman85aed542019-08-21 12:01:14 -07002585TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002586 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002587 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2588 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002589 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002591 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002593}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002594
Daniel Norman85aed542019-08-21 12:01:14 -07002595TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002596 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002597 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2598 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002599 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002600 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002601 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002602}
Jiyong Parka428d212018-08-29 22:26:30 +09002603
Daniel Norman85aed542019-08-21 12:01:14 -07002604TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002605 const string expected_stderr =
2606 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002607 io_delegate_.SetFileContents("old/p/I.aidl",
2608 "package p; interface I {"
2609 "const int A = 1; const int B = 2;}");
2610 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002611 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002612 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002614}
Jiyong Parka428d212018-08-29 22:26:30 +09002615
Daniel Norman85aed542019-08-21 12:01:14 -07002616TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002617 const string expected_stderr =
2618 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002619 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2620 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002621 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002622 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002623 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002624}
2625
Devin Moorec7e47a32020-08-07 10:55:25 -07002626TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2627 const string expected_stderr =
2628 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2629 "This is an incompatible change for FixedSize types.\n";
2630 io_delegate_.SetFileContents("old/p/Foo.aidl",
2631 "package p; @FixedSize parcelable Foo { int A = 1; }");
2632 io_delegate_.SetFileContents("new/p/Foo.aidl",
2633 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2634 CaptureStderr();
2635 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2636 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2637}
2638
2639TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2640 const string expected_stderr =
2641 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2642 io_delegate_.SetFileContents("old/p/Foo.aidl",
2643 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2644 io_delegate_.SetFileContents("new/p/Foo.aidl",
2645 "package p; @FixedSize parcelable Foo { int A = 1; }");
2646 CaptureStderr();
2647 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2648 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2649}
2650
2651TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2652 const string expected_stderr =
2653 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2654 "a.\n"
2655 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2656 "b.\n"
2657 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2658 "c.\n"
2659 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2660 "d.\n"
2661 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2662 "e.\n"
2663 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2664 "f.\n";
2665
2666 io_delegate_.SetFileContents("Foo.aidl",
2667 "@FixedSize parcelable Foo { "
2668 " int[] a;"
2669 " Bar b;"
2670 " String c;"
2671 " ParcelFileDescriptor d;"
2672 " IBinder e;"
2673 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002674 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002675 "}");
2676 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002677 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002678
2679 CaptureStderr();
2680 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2681 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2682}
2683
2684TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2685 const string expected_stderr = "";
2686
2687 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2688 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2689 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002690 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002691
2692 CaptureStderr();
2693 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2694 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2695}
2696
Jiyong Park8c380532018-08-30 14:55:26 +09002697TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002698 const string expected_stderr =
2699 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2700 "dir1/q/IBar.aidl\n"
2701 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002702 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002703 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2704 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2705 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2706 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2707
Devin Moore097a3ab2020-03-11 16:08:44 -07002708 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002709 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002710 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002711}
2712
Jiyong Parked65bf42018-08-28 15:43:27 +09002713TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002714 const string expected_stderr =
2715 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2716 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002717 Options options = Options::From("aidl --checkapi old new");
2718 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2719 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002720
2721 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2722
Jiyong Parke59c3682018-09-11 23:10:25 +09002723 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002724 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002725 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002726 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002727}
2728
Jiyong Parke05195e2018-10-08 18:24:23 +09002729TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2730 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2731 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002732 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002733
2734 // use without import
2735 io_delegate_.SetFileContents("p/IFoo.aidl",
2736 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2737 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2738 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002739 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002740
Devin Moore7b8d5c92020-03-17 14:14:08 -07002741 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002742 io_delegate_.SetFileContents(
2743 "p/IFoo.aidl",
2744 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2745 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2746 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002747 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002748
2749 // use with import (as before)
2750 io_delegate_.SetFileContents("p/IFoo.aidl",
2751 "package p;"
2752 "import android.os.ParcelFileDescriptor;"
2753 "interface IFoo{"
2754 " void foo(in ParcelFileDescriptor fd);"
2755 "}");
2756 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2757 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002758 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002759}
Jiyong Parked65bf42018-08-28 15:43:27 +09002760
Jiyong Park3633b722019-04-11 15:38:26 +09002761TEST_F(AidlTest, ManualIds) {
2762 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2763 io_delegate_.SetFileContents("IFoo.aidl",
2764 "interface IFoo {\n"
2765 " void foo() = 0;\n"
2766 " void bar() = 1;\n"
2767 "}");
2768 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2769}
2770
2771TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2772 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2773 io_delegate_.SetFileContents("IFoo.aidl",
2774 "interface IFoo {\n"
2775 " void foo() = 0;\n"
2776 " void bar() = 1;\n"
2777 "}");
2778 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2779}
2780
2781TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002782 const string expected_stderr =
2783 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002784 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2785 io_delegate_.SetFileContents("IFoo.aidl",
2786 "interface IFoo {\n"
2787 " void foo() = 3;\n"
2788 " void bar() = 3;\n"
2789 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002790 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002791 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002792 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002793}
2794
2795TEST_F(AidlTest, FailOnOutOfRangeIds) {
2796 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002797 const string expected_stderr =
2798 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2799 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002800 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2801 io_delegate_.SetFileContents("IFoo.aidl",
2802 "interface IFoo {\n"
2803 " void foo() = 3;\n"
2804 " void bar() = 16777115;\n"
2805 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002806 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002807 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002808 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002809}
2810
2811TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002812 const string expected_stderr =
2813 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002814 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2815 io_delegate_.SetFileContents("IFoo.aidl",
2816 "interface IFoo {\n"
2817 " void foo() = 3;\n"
2818 " void bar();\n"
2819 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002821 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002822 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002823}
2824
Jiyong Parkc6816252019-07-08 08:12:28 +09002825TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2826 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2827 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2828 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2829 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2830}
2831
2832TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002833 const string expected_stderr =
2834 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2835 "dir/IBar.aidl\n"
2836 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002837 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002838
Jiyong Parkc6816252019-07-08 08:12:28 +09002839 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2840 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2841 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2842 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002843 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002844 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002845 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002846}
2847
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002848TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2849 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2850 "package a.b;\n"
2851 "import a.b.IBar;\n"
2852 "import a.b.IQux;\n"
2853 "interface IFoo { IQux foo(); }\n");
2854 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2855 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2856
2857 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2858 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2859
2860 string output;
2861 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2862 // IBar was imported but wasn't used. include is not expected.
2863 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2864 // IBar was imported and used. include is expected.
2865 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2866}
2867
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002868TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002869 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002870 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002871 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2872 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002873 interface IFoo {
2874 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002875 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002876 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002877 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002878 // JavaPassthrough should work with other types as well (e.g. enum)
2879 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2880 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2881 @JavaPassthrough(annotation="@com.android.AliceTwo")
2882 @Backing(type="byte")
2883 enum MyEnum {
2884 a, b, c
2885 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002886
Jooyung Han4cde01d2020-10-13 11:10:47 +09002887 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002888 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2889
2890 string java_out;
2891 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002892 // type-decl-level annotations with newline at the end
2893 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2894 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2895 // member-decl-level annotations with newline at the end
2896 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2897 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2898 // inline annotations with space at the end
2899 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002900
Jooyung Han4cde01d2020-10-13 11:10:47 +09002901 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2902 // type-decl-level annotations with newline at the end
2903 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2904 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2905
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002906 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002907 Options cpp_options =
2908 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002909 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2910
Jooyung Han4cde01d2020-10-13 11:10:47 +09002911 Options ndk_options =
2912 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002913 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002914
Jooyung Han4cde01d2020-10-13 11:10:47 +09002915 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002916 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002917}
2918
Andrei Homescue61feb52020-08-18 15:44:24 -07002919TEST_F(AidlTest, ParseRustDerive) {
2920 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2921 @RustDerive(Clone=true, Copy=false)
2922 parcelable Foo {
2923 int a;
2924 })");
2925
2926 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2927 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2928
2929 string rust_out;
2930 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2931 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2932
2933 // Other backends shouldn't be bothered
2934 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2935 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2936
2937 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2938 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2939
2940 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2941 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2942}
2943
Jiyong Park56f73d72019-06-11 12:20:28 +09002944class AidlOutputPathTest : public AidlTest {
2945 protected:
2946 void SetUp() override {
2947 AidlTest::SetUp();
2948 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2949 }
2950
2951 void Test(const Options& options, const std::string expected_output_path) {
2952 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2953 // check the existence
2954 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2955 }
2956};
2957
2958TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2959 // <out_dir> / <package_name> / <type_name>.java
2960 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2961}
2962
2963TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2964 // when output file is explicitly set, it is always respected. -o option is
2965 // ignored.
2966 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2967}
2968
2969TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2970 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2971}
2972
2973TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2974 // output is the same as the input file except for the suffix
2975 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2976}
2977
Devin Moore7b8d5c92020-03-17 14:14:08 -07002978TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002979 AidlError error;
2980 const string expected_stderr =
2981 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2982 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002983 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2984 R"(package p;
2985 interface IFoo {
2986 const int int32_max_oob = 2147483650;
2987 }
2988 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002989 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2991 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002992}
2993
Devin Moore7b8d5c92020-03-17 14:14:08 -07002994TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002995 AidlError error;
2996 const string expected_stderr =
2997 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2998 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002999 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3000 R"(package p;
3001 interface IFoo {
3002 const int int32_min_oob = -2147483650;
3003 }
3004 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003005 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003006 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3007 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003008}
3009
Devin Moore7b8d5c92020-03-17 14:14:08 -07003010TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003011 AidlError error;
3012 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003013 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003014 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003015 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3016 R"(package p;
3017 interface IFoo {
3018 const long int64_max_oob = 21474836509999999999999999;
3019 }
3020 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003021 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003022 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3023 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003024}
3025
Devin Moore7b8d5c92020-03-17 14:14:08 -07003026TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003027 AidlError error;
3028 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003029 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003030 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003031 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3032 R"(package p;
3033 interface IFoo {
3034 const long int64_min_oob = -21474836509999999999999999;
3035 }
3036 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003037 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003038 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3039 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003040}
3041
Devin Moore7b8d5c92020-03-17 14:14:08 -07003042TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003043 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003044 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003045 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003046 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3047 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003048 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3049 R"(package p;
3050 @Backing(type="byte")
3051 enum TestEnum {
3052 FOO = 127,
3053 BAR,
3054 }
3055 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003056 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003057 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003058 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003059}
3060
Devin Mooredecaf292020-04-30 09:16:40 -07003061TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3062 AidlError error;
3063 const string expected_stderr =
3064 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003065 "be one of: type\n";
3066 CaptureStderr();
3067 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3068 R"(package p;
3069 @Backing(foo="byte")
3070 enum TestEnum {
3071 FOO = 1,
3072 BAR,
3073 }
3074 )",
3075 typenames_, GetLanguage(), &error));
3076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3077 EXPECT_EQ(AidlError::BAD_TYPE, error);
3078}
3079
Jooyung Han5721a232020-12-24 04:34:55 +09003080TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3081 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3082 CaptureStderr();
3083 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3084 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3085}
3086
Jooyung Han66813932020-10-23 13:24:44 +09003087TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003088 io_delegate_.SetFileContents("Foo.aidl",
3089 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3090 "Map<String, Baz> d; Bar[] e; }");
3091 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3092 io_delegate_.SetFileContents("Baz.aidl",
3093 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003094 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3095 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3096}
3097
Jooyung Han66813932020-10-23 13:24:44 +09003098TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003099 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003100 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003101 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003102 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3103 "named 'bar'.\n";
3104 CaptureStderr();
3105 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3106 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3107 EXPECT_EQ(expected_error, GetCapturedStderr());
3108}
3109
3110TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3111 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3112 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3113 string expected_error =
3114 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003115 "named 'bar'.\n";
3116 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003117 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3118 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003119 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003120}
3121
Jooyung Han66813932020-10-23 13:24:44 +09003122TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003123 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003124 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3125 string expected_error =
3126 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3127 "only be an in parameter.\n";
3128 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003129 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3130 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003131 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003132}
3133
Jooyung Han66813932020-10-23 13:24:44 +09003134TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003135 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003136 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3137 string expected_error =
3138 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3139 "only be an in parameter.\n";
3140 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003141 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3142 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003143 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003144}
3145
Jooyung Han66813932020-10-23 13:24:44 +09003146TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003147 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003148 Options options = Options::From("aidl --lang=java Foo.aidl");
3149 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003150 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3151 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003152 CaptureStderr();
3153 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3154 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3155}
Devin Moore53fc99c2020-08-12 08:07:52 -07003156
Jooyung Hanfe086af2021-01-16 03:44:47 +09003157TEST_P(AidlTest, UnionInUnion) {
3158 import_paths_.insert(".");
3159 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3160 CaptureStderr();
3161 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3162 EXPECT_THAT("", GetCapturedStderr());
3163}
3164
Jooyung Hanfe89f122020-10-14 03:49:18 +09003165TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3166 const string method = "package a; union Foo {}";
3167 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3168 CaptureStderr();
3169 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3170 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3171}
3172
3173TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3174 const string method = "package a; union Foo { ParcelableHolder x; }";
3175 const string expected_stderr =
3176 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3177 CaptureStderr();
3178 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3179 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3180}
3181
Jooyung Han53fb4242020-12-17 16:03:49 +09003182TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3183 import_paths_.insert(".");
3184 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3185 const string expected_err = "The union's first member should have a useful default value.";
3186 CaptureStderr();
3187 EXPECT_EQ(nullptr,
3188 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3189 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3190}
3191
Devin Moore53fc99c2020-08-12 08:07:52 -07003192TEST_P(AidlTest, GenericStructuredParcelable) {
3193 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003194 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003195 const string expected_stderr = "";
3196 CaptureStderr();
3197 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3199}
3200
Jooyung Han3f347ca2020-12-01 12:41:50 +09003201TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3202 io_delegate_.SetFileContents("Foo.aidl",
3203 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3204 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003205 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003206 const string expected_stderr = "";
3207 CaptureStderr();
3208 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3209 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3210
3211 string code;
3212 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3213 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3214const ::android::String16& Foo<T,U>::s() {
3215 static const ::android::String16 value(::android::String16(""));
3216 return value;
3217})--"));
3218}
3219
3220TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3221 io_delegate_.SetFileContents("Foo.aidl",
3222 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3223 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003224 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003225 const string expected_stderr = "";
3226 CaptureStderr();
3227 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3229
3230 string code;
3231 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3232 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3233const char* Foo<T, U>::s = "";
3234)--"));
3235}
3236
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003237TEST_F(AidlTest, NestedTypeArgs) {
3238 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003239 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3240
3241 io_delegate_.SetFileContents("a/Foo.aidl",
3242 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3243 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003244 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3245 const string expected_stderr = "";
3246 CaptureStderr();
3247 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3249
3250 string code;
3251 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003252 EXPECT_THAT(code,
3253 testing::HasSubstr(
3254 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3255}
3256
3257TEST_F(AidlTest, DoubleArrayError) {
3258 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3259
3260 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3261 const string expected_stderr =
3262 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3263 CaptureStderr();
3264 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3266}
3267
3268TEST_F(AidlTest, DoubleGenericError) {
3269 io_delegate_.SetFileContents("a/Bar.aidl",
3270 "package a; parcelable Bar { List<String><String> a; }");
3271
3272 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3273 const string expected_stderr =
3274 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3275 CaptureStderr();
3276 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3277 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3278}
3279
3280TEST_F(AidlTest, ArrayBeforeGenericError) {
3281 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3282
3283 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3284 const string expected_stderr =
3285 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3286 CaptureStderr();
3287 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3288 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003289}
3290
Jooyung Han14004ed2020-10-16 03:49:57 +09003291struct GenericAidlTest : ::testing::Test {
3292 FakeIoDelegate io_delegate_;
3293 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003294 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003295 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3296 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3297 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3298
3299 Options options = Options::From(cmd);
3300 CaptureStderr();
3301 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3302 EXPECT_EQ("", GetCapturedStderr());
3303 }
3304};
3305
3306TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3307 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3308 string code;
3309 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3310 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3311 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3312 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3313}
3314
3315TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3316 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3317 string code;
3318 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3319 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3320 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3321 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3322}
3323
Devin Moore53fc99c2020-08-12 08:07:52 -07003324TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3325 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003326 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003327 const string expected_stderr =
3328 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3329 CaptureStderr();
3330 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3332}
3333
3334TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3335 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003336 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003337 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3338 CaptureStderr();
3339 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3341}
3342
Jooyung Han7a308842020-10-27 19:06:49 +09003343TEST_P(AidlTest, LongCommentWithinConstExpression) {
3344 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003345 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003346 CaptureStderr();
3347 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3348 EXPECT_EQ("", GetCapturedStderr());
3349}
3350
Jeongik Chaef44e622020-10-23 16:00:52 +09003351TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3352 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3353 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3354 std::string expectedErr =
3355 "ERROR: a/Foo.aidl:1.28-30: "
3356 "Encountered an untyped List or Map. The use of untyped List/Map is "
3357 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3358 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3359 "ERROR: a/Foo.aidl:1.35-37: "
3360 "Encountered an untyped List or Map. The use of untyped List/Map is "
3361 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3362 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3363 CaptureStderr();
3364 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3365 EXPECT_EQ(expectedErr, GetCapturedStderr());
3366}
3367
3368TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003369 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3370 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003371 std::string expectedErr =
3372 "ERROR: a/Foo.aidl:1.33-35: "
3373 "Encountered an untyped List or Map. The use of untyped List/Map is "
3374 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3375 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3376 "ERROR: a/Foo.aidl:1.40-42: "
3377 "Encountered an untyped List or Map. The use of untyped List/Map is "
3378 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3379 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003380 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003381 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3382 EXPECT_EQ(expectedErr, GetCapturedStderr());
3383}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003384
Jeongik Chaef44e622020-10-23 16:00:52 +09003385TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3386 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3387 io_delegate_.SetFileContents(
3388 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3389 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3390 std::string expectedErr =
3391 "ERROR: a/Foo.aidl:1.52-54: "
3392 "Encountered an untyped List or Map. The use of untyped List/Map is "
3393 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3394 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3395 "ERROR: a/Foo.aidl:1.64-66: "
3396 "Encountered an untyped List or Map. The use of untyped List/Map is "
3397 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3398 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3399 CaptureStderr();
3400 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3401 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003402}
3403
Jooyung Han690f5842020-12-04 13:02:04 +09003404TEST_F(AidlTest, EnumWithDefaults_Java) {
3405 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3406 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3407package p;
3408import p.Enum;
3409parcelable Foo {
3410 Enum e = Enum.BAR;
3411})");
3412 CaptureStderr();
3413 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3414 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3415 auto err = GetCapturedStderr();
3416 EXPECT_EQ("", err);
3417
3418 string code;
3419 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003420 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003421}
3422
3423TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3424 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3425 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3426package p;
3427import p.Enum;
3428parcelable Foo {
3429 Enum e = Enum.BAR;
3430})");
3431 CaptureStderr();
3432 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3433 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3434 auto err = GetCapturedStderr();
3435 EXPECT_EQ("", err);
3436
3437 string code;
3438 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3439 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3440}
3441
3442TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3443 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3444 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3445package p;
3446import p.Enum;
3447parcelable Foo {
3448 Enum e = Enum.BAR;
3449})");
3450 CaptureStderr();
3451 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3452 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3453 auto err = GetCapturedStderr();
3454 EXPECT_EQ("", err);
3455
3456 string code;
3457 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3458 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3459}
3460
3461TEST_F(AidlTest, EnumWithDefaults_Rust) {
3462 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3463 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3464package p;
3465import p.Enum;
3466parcelable Foo {
3467 int n = 42;
3468 Enum e = Enum.BAR;
3469})");
3470 CaptureStderr();
3471 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3472 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3473 auto err = GetCapturedStderr();
3474 EXPECT_EQ("", err);
3475
3476 string code;
3477 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3478 EXPECT_THAT(code, testing::HasSubstr(R"(
3479 fn default() -> Self {
3480 Self {
3481 n: 42,
3482 e: crate::mangled::_1_p_4_Enum::BAR,
3483 }
3484 })"));
3485}
3486
3487TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3488 import_paths_.insert("a");
3489 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3490 CaptureStderr();
3491 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3492package p;
3493import p.Enum;
3494parcelable Foo {
3495 int e = Enum.FOO | Enum.BAR;
3496})",
3497 typenames_, GetLanguage());
3498 auto err = GetCapturedStderr();
3499 EXPECT_EQ("", err);
3500 EXPECT_TRUE(type);
3501 const auto& fields = type->AsStructuredParcelable()->GetFields();
3502 EXPECT_EQ("int e = 3", fields[0]->ToString());
3503}
3504
3505TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3506 CaptureStderr();
3507 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3508@Backing(type="int")
3509enum Foo {
3510 STANDARD_SHIFT = 16,
3511 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3512 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3513}
3514)",
3515 typenames_, GetLanguage());
3516 auto err = GetCapturedStderr();
3517 EXPECT_EQ("", err);
3518 EXPECT_TRUE(type);
3519 const auto& enum_type = type->AsEnumDeclaration();
3520 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003521 auto writer = CodeWriter::ForString(&code);
3522 DumpVisitor visitor(*writer);
3523 visitor.Visit(*enum_type);
3524 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003525 EXPECT_EQ(R"--(@Backing(type="int")
3526enum Foo {
3527 STANDARD_SHIFT = 16,
3528 STANDARD_BT709 = 65536,
3529 STANDARD_BT601_625 = 131072,
3530}
3531)--",
3532 code);
3533}
3534
3535TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3536 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3537 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3538package p;
3539import p.Enum;
3540parcelable Foo {
3541 Enum e = Enum.FOO | Enum.BAR;
3542})");
3543 CaptureStderr();
3544 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3545 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3546 auto err = GetCapturedStderr();
3547 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3548 err);
3549}
3550
3551TEST_P(AidlTest, DefaultWithEmptyArray) {
3552 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3553 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3554 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003555 auto options =
3556 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003557 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3558 auto err = GetCapturedStderr();
3559 EXPECT_EQ("", err);
3560}
3561
3562TEST_P(AidlTest, RejectRefsInAnnotation) {
3563 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3564 "package p; interface IFoo {\n"
3565 " const String ANNOTATION = \"@Annotation\";\n"
3566 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3567 "}");
3568 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003569 auto options =
3570 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003571 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3572 auto err = GetCapturedStderr();
3573 EXPECT_EQ(
3574 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3575 "ANNOTATION.\n",
3576 err);
3577}
3578
3579TEST_F(AidlTest, DefaultWithEnumValues) {
3580 io_delegate_.SetFileContents(
3581 "a/p/Foo.aidl",
3582 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3583 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3584 CaptureStderr();
3585 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3586 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3587 auto err = GetCapturedStderr();
3588 EXPECT_EQ("", err);
3589 string code;
3590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3591 EXPECT_THAT(
3592 code, testing::HasSubstr(
3593 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3594}
3595
Jooyung Han14259392020-12-07 10:00:08 +09003596TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3597 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3598 CaptureStderr();
3599 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3600 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3601 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003602 EXPECT_EQ(
3603 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3604 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3605 err);
Jooyung Han14259392020-12-07 10:00:08 +09003606}
3607
3608TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3609 io_delegate_.SetFileContents("a/p/Foo.aidl",
3610 "package p; parcelable Foo { const int A = A + 1; }");
3611 CaptureStderr();
3612 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3613 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3614 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003615 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3616}
3617
3618TEST_F(AidlTest, RecursiveReferences) {
3619 io_delegate_.SetFileContents("a/p/Foo.aidl",
3620 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3621 io_delegate_.SetFileContents("a/p/Bar.aidl",
3622 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3623 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3624 CaptureStderr();
3625 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3626 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3627 EXPECT_EQ("", GetCapturedStderr());
3628}
3629
Jooyung Hane9f5b272021-01-07 00:18:11 +09003630TEST_P(AidlTest, UnknownConstReference) {
3631 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3632 auto options =
3633 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3634 const string err =
3635 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3636 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3637 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3638 CaptureStderr();
3639 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3640 EXPECT_EQ(err, GetCapturedStderr());
3641}
3642
Jooyung Han29813842020-12-08 01:28:03 +09003643TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3644 string contents = R"(
3645import android.os.IBinder;
3646import android.os.IInterface;
3647interface IFoo {}
3648 )";
3649 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003650}
3651
Jooyung Han888c5bc2020-12-22 17:28:47 +09003652TEST_P(AidlTest, WarningInterfaceName) {
3653 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003654 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003655 " -Weverything -o out -h out p/Foo.aidl");
3656 CaptureStderr();
3657 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003658 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003659 GetCapturedStderr());
3660}
3661
3662TEST_P(AidlTest, ErrorInterfaceName) {
3663 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003664 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003665 " -Weverything -Werror -o out -h out p/Foo.aidl");
3666 CaptureStderr();
3667 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003668 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003669 GetCapturedStderr());
3670}
3671
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09003672TEST_F(AidlTest, FormatCommentsForJava) {
3673 using android::aidl::FormatCommentsForJava;
3674
3675 struct TestCase {
3676 vector<Comment> comments;
3677 string formatted;
3678 };
3679 vector<TestCase> testcases = {
3680 {{}, ""},
3681 {{{"// line comments\n"}}, "// line comments\n"},
3682 {{{"// @hide \n"}}, "// @hide \n"},
3683 // Transform the last block comment as Javadoc.
3684 {{{"/*\n"
3685 " * Hello, world!\n"
3686 " */"}},
3687 "/**\n"
3688 " * Hello, world!\n"
3689 " */"},
3690 {{{"/* @hide */"}}, "/** @hide */"},
3691 {{{"/**\n"
3692 " @param foo ...\n"
3693 "*/"}},
3694 "/**\n"
3695 " @param foo ...\n"
3696 "*/"},
3697 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
3698 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
3699 "/* @deprecated first *//** @deprecated second */"},
3700 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
3701 // Line comments are printed as they are
3702 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
3703 };
3704 for (const auto& [input, formatted] : testcases) {
3705 EXPECT_EQ(formatted, FormatCommentsForJava(input));
3706 }
3707}
3708
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003709TEST_F(AidlTest, HideIsNotForArgs) {
3710 io_delegate_.SetFileContents("IFoo.aidl",
3711 "interface IFoo {\n"
3712 " void foo(in @Hide int x);\n"
3713 "}");
3714 auto options = Options::From("aidl --lang=java IFoo.aidl");
3715 CaptureStderr();
3716 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3717 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3718}
3719
3720TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3721 io_delegate_.SetFileContents(
3722 "IFoo.aidl",
3723 "interface IFoo {\n"
3724 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3725 "}");
3726 auto options = Options::From("aidl --lang=java IFoo.aidl");
3727 CaptureStderr();
3728 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3729 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3730}
3731
Jooyung Hanfd3be322020-12-13 09:11:06 +09003732struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003733 string kind;
3734 string literal;
3735};
3736
Jooyung Hanfd3be322020-12-13 09:11:06 +09003737const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003738 {"primitive", "int"}, {"String", "String"},
3739 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3740 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3741 {"union", "a.Union"}, {"interface", "a.IBar"},
3742};
3743
3744const std::map<std::string, std::string> kListSupportExpectations = {
3745 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3746 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3747 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3748 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
3749 {"cpp_String", ""},
3750 {"java_String", ""},
3751 {"ndk_String", ""},
3752 {"rust_String", ""},
3753 {"cpp_IBinder", ""},
3754 {"java_IBinder", ""},
3755 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3756 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003757 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003758 {"java_ParcelFileDescriptor", ""},
3759 {"ndk_ParcelFileDescriptor", ""},
3760 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003761 {"cpp_interface", "List<a.IBar> is not supported."},
3762 {"java_interface", "List<a.IBar> is not supported."},
3763 {"ndk_interface", "List<a.IBar> is not supported."},
3764 {"rust_interface", "List<a.IBar> is not supported."},
3765 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003766 {"java_parcelable", ""},
3767 {"ndk_parcelable", ""},
3768 {"rust_parcelable", ""},
3769 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3770 {"java_enum", "A generic type cannot have any primitive type parameters."},
3771 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3772 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003773 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003774 {"java_union", ""},
3775 {"ndk_union", ""},
3776 {"rust_union", ""},
3777};
3778
Jooyung Hand236e552020-12-13 09:21:27 +09003779const std::map<std::string, std::string> kArraySupportExpectations = {
3780 {"cpp_primitive", ""},
3781 {"java_primitive", ""},
3782 {"ndk_primitive", ""},
3783 {"rust_primitive", ""},
3784 {"cpp_String", ""},
3785 {"java_String", ""},
3786 {"ndk_String", ""},
3787 {"rust_String", ""},
3788 {"cpp_IBinder", ""},
3789 {"java_IBinder", ""},
3790 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3791 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3792 {"cpp_ParcelFileDescriptor", ""},
3793 {"java_ParcelFileDescriptor", ""},
3794 {"ndk_ParcelFileDescriptor", ""},
3795 {"rust_ParcelFileDescriptor", ""},
3796 {"cpp_interface", "Binder type cannot be an array"},
3797 {"java_interface", "Binder type cannot be an array"},
3798 {"ndk_interface", "Binder type cannot be an array"},
3799 {"rust_interface", "Binder type cannot be an array"},
3800 {"cpp_parcelable", ""},
3801 {"java_parcelable", ""},
3802 {"ndk_parcelable", ""},
3803 {"rust_parcelable", ""},
3804 {"cpp_enum", ""},
3805 {"java_enum", ""},
3806 {"ndk_enum", ""},
3807 {"rust_enum", ""},
3808 {"cpp_union", ""},
3809 {"java_union", ""},
3810 {"ndk_union", ""},
3811 {"rust_union", ""},
3812};
3813
Jooyung Hanfd3be322020-12-13 09:11:06 +09003814class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003815 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003816 void Run(const std::string& generic_type_decl,
3817 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003818 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003819 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003820 const auto& kind = std::get<1>(param).kind;
3821
3822 FakeIoDelegate io;
3823 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3824 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3825 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003826 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3827 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003828
3829 const auto options =
3830 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3831 CaptureStderr();
3832 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003833 auto it = expectations.find(lang + "_" + kind);
3834 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003835 const string err = GetCapturedStderr();
3836 if (it->second.empty()) {
3837 EXPECT_EQ("", err);
3838 } else {
3839 EXPECT_THAT(err, testing::HasSubstr(it->second));
3840 }
3841 }
3842};
3843
3844INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003845 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003846 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3847 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003848 testing::ValuesIn(kTypeParams)),
3849 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003850 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003851 });
3852
Jooyung Hanfd3be322020-12-13 09:11:06 +09003853TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3854 Run("List<{}>", kListSupportExpectations);
3855}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003856
Jooyung Hand236e552020-12-13 09:21:27 +09003857TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3858 Run("{}[]", kArraySupportExpectations);
3859}
3860
Christopher Wiley90be4e32015-10-20 14:55:25 -07003861} // namespace aidl
3862} // namespace android