blob: 6d67b7dadefb4350f45072bedce144046befaa6f [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090034#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090035#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090036#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070038
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090039using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070040using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080041using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090042using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080043using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070044using std::string;
45using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090047using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070048using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090049using testing::internal::CaptureStderr;
50using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070051
52namespace android {
53namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070054namespace {
55
56const char kExpectedDepFileContents[] =
57R"(place/for/output/p/IFoo.java : \
58 p/IFoo.aidl
59
60p/IFoo.aidl :
61)";
62
Dan Willemsen93298ee2016-11-10 23:55:55 -080063const char kExpectedNinjaDepFileContents[] =
64R"(place/for/output/p/IFoo.java : \
65 p/IFoo.aidl
66)";
67
Jiyong Parkdf202122019-09-30 20:48:35 +090068const char kExpectedParcelableDeclarationDepFileContents[] =
69 R"( : \
70 p/Foo.aidl
71
72p/Foo.aidl :
73)";
74
75const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080076 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070077 p/Foo.aidl
78
79p/Foo.aidl :
80)";
81
Christopher Wileyf8136192016-04-12 14:19:35 -070082} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070083
Devin Moore7b8d5c92020-03-17 14:14:08 -070084class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070085 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090086 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
87 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070088 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070089 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090090 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070091 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090092 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070093 for (const string& s : additional_arguments) {
94 args.emplace_back(s);
95 }
96 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090097 args.emplace_back("--preprocessed=" + f);
98 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -070099 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900100 args.emplace_back("--include=" + i);
101 }
102 args.emplace_back(path);
103 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900104 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900105 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700106 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900107 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700109 if (error != nullptr) {
110 *error = actual_error;
111 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
113 if (actual_error != AidlError::OK) {
114 return nullptr;
115 }
116
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900117 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900118 EXPECT_EQ(1ul, defined_types.size());
119
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900120 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700121 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700122
Devin Moore7b8d5c92020-03-17 14:14:08 -0700123 Options::Language GetLanguage() { return GetParam(); }
124
Christopher Wiley0522cd52015-10-28 15:39:44 -0700125 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800126 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900127 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900128 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700129};
130
Devin Moore7b8d5c92020-03-17 14:14:08 -0700131// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
132// tests with each of the supported languages as a parameter.
133INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
134 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700135 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700136 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900137 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700138 });
139
140TEST_P(AidlTest, AcceptMissingPackage) {
141 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700142}
143
Devin Moore7b8d5c92020-03-17 14:14:08 -0700144TEST_P(AidlTest, EndsInSingleLineComment) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700146}
147
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000148TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
149 const string expected_stderr =
150 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
151 const std::string file_contents = "package a; interface IBar {}";
152 CaptureStderr();
153 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
154 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
155}
156
157TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
158 const string expected_stderr =
159 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
160 const std::string file_contents = "package a; interface Bar {}";
161 CaptureStderr();
162 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
163 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
164}
165
166TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
167 const string expected_stderr =
168 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
169 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
170 CaptureStderr();
171 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
172 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
173}
174
175TEST_P(AidlTest, EnumRequiresCorrectPath) {
176 const string expected_stderr =
177 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
178 const std::string file_contents = "package a; enum Bar { A, }";
179 CaptureStderr();
180 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
181 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
182}
183
Devin Moore7b8d5c92020-03-17 14:14:08 -0700184TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900185 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700186 io_delegate_.SetFileContents("bar/IBar.aidl",
187 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700188 const string path = "foo/IFoo.aidl";
189 const string contents =
190 "package foo;\n"
191 "import bar.IBar;\n"
192 "interface IFoo { void f(in IBar[] input); }";
193 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
194 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700195 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700196 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700197}
198
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900202}
Devin Moore097a3ab2020-03-11 16:08:44 -0700203
Jiyong Park40782d02020-07-24 19:17:43 +0900204TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700205 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
206 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900207 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
208 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700211 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900212}
213
Jiyong Park40782d02020-07-24 19:17:43 +0900214TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
216 const string expected_stderr =
217 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700218 CaptureStderr();
219 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
220 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900221}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222
Jiyong Park40782d02020-07-24 19:17:43 +0900223TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700224 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900225 const string expected_stderr =
226 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700227 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700228 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700229 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700230}
231
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
234 const string expected_stderr =
235 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
236 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700237 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700239}
240
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
243 const string expected_stderr =
244 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
245 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700246 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800248}
249
Devin Moore2f2077a2020-08-28 11:27:53 -0700250TEST_P(AidlTest, AcceptNullableList) {
251 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
252 const string expected_stderr = "";
253 CaptureStderr();
254 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
255 EXPECT_EQ(expected_stderr, GetCapturedStderr());
256}
257
Devin Moore7b8d5c92020-03-17 14:14:08 -0700258TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700259 const string method = "package a; interface IFoo { void f(int a, int a); }";
260 const string expected_stderr =
261 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
262 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700263 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700264 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700265}
266
Jeongik Cha13066da2020-08-06 15:43:19 +0900267TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
268 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900269 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900270 CaptureStderr();
271 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
272 EXPECT_EQ(expected_stderr, GetCapturedStderr());
273}
274
Jooyung Hand902a972020-10-23 17:32:44 +0900275TEST_P(AidlTest, RejectsRepeatedAnnotations) {
276 const string method = R"(@Hide @Hide parcelable Foo {})";
277 const string expected_stderr =
278 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
279 "Foo.aidl:1.1-6\n";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr());
283}
284
Devin Moore7b8d5c92020-03-17 14:14:08 -0700285TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700286 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
287 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
288 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700289 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700290 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100291}
292
Devin Moore7b8d5c92020-03-17 14:14:08 -0700293TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700294 AidlError error;
295 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700296 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700297 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900298 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700299 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800300}
301
Devin Moore7b8d5c92020-03-17 14:14:08 -0700302TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700303 AidlError error;
304 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700305 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700306 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900307 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700308 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700312 AidlError error;
313 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700314 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000315 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700317 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800318}
319
Devin Moore7b8d5c92020-03-17 14:14:08 -0700320TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700321 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000322 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700323 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900325 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700326 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800327}
328
Jiyong Park40782d02020-07-24 19:17:43 +0900329TEST_P(AidlTest, ParsesNonNullableAnnotation) {
330 auto parse_result =
331 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
332 ASSERT_NE(nullptr, parse_result);
333 const AidlInterface* interface = parse_result->AsInterface();
334 ASSERT_NE(nullptr, interface);
335 ASSERT_FALSE(interface->GetMethods().empty());
336 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
337}
338
Devin Moore7b8d5c92020-03-17 14:14:08 -0700339TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900340 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
341 typenames_, GetLanguage());
342 ASSERT_NE(nullptr, parse_result);
343 const AidlInterface* interface = parse_result->AsInterface();
344 ASSERT_NE(nullptr, interface);
345 ASSERT_FALSE(interface->GetMethods().empty());
346 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
347}
348
349TEST_P(AidlTest, ParsesNonUtf8Annotations) {
350 auto parse_result =
351 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
352 ASSERT_NE(nullptr, parse_result);
353 const AidlInterface* interface = parse_result->AsInterface();
354 ASSERT_NE(nullptr, interface);
355 ASSERT_FALSE(interface->GetMethods().empty());
356 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800357}
358
Devin Moore7b8d5c92020-03-17 14:14:08 -0700359TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900360 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
361 typenames_, GetLanguage());
362 ASSERT_NE(nullptr, parse_result);
363 const AidlInterface* interface = parse_result->AsInterface();
364 ASSERT_NE(nullptr, interface);
365 ASSERT_FALSE(interface->GetMethods().empty());
366 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700370 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700371 const string expected_stderr =
372 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
373 "\"vintf\"'\n"
374 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
375 "--structured\n";
376 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700377 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700379 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700380 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700381}
382
Devin Moore7b8d5c92020-03-17 14:14:08 -0700383TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700384 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700385 const string expected_stderr =
386 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
387 "--structured\n";
388 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700389 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700393}
394
Devin Moore7b8d5c92020-03-17 14:14:08 -0700395TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700396 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700397 const string expected_stderr =
398 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
399 "\"vintf\"'\n";
400 CaptureStderr();
401 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700402 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700403 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700405}
406
Devin Moore7b8d5c92020-03-17 14:14:08 -0700407TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700408 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700409 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
410 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700411 ASSERT_EQ(AidlError::OK, error);
412 ASSERT_NE(nullptr, parse_result);
413 const AidlInterface* interface = parse_result->AsInterface();
414 ASSERT_NE(nullptr, interface);
415 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700416}
417
Jeongik Cha64783ed2019-06-07 18:30:54 +0900418TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
419 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900420 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
421 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900422 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700423 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900424 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900425 "a/Foo.aidl",
426 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900427
428 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900429 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700430 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900431 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700432 "Parcelable must be defined in AIDL directly.\n";
433 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900434 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700435 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700436
437 CaptureStderr();
438 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900440}
441
Jooyung Han1cbc4962020-10-25 10:07:15 +0900442TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
443 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
444 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
445 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900446 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
447
448 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900449 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900450 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
451
452 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900453 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900454 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
455
Jooyung Han1cbc4962020-10-25 10:07:15 +0900456 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900457 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
458}
459
Jooyung Han1cbc4962020-10-25 10:07:15 +0900460TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
461 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
462 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
463 CaptureStderr();
464 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
465 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
466 EXPECT_EQ("", GetCapturedStderr());
467
468 const string expected_to_string_method = R"--(
469 @Override
470 public String toString() {
471 switch (_tag) {
472 case a: return "a.Foo.a(" + (getA()) + ")";
473 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
474 }
475 throw new IllegalStateException("unknown field: " + _tag);
476 }
477)--";
478
479 string java_out;
480 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
481 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
482}
483
Jiyong Park9aa3d042020-12-04 23:30:02 +0900484TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
485 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
486 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
487 CaptureStderr();
488 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
489 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
490 EXPECT_EQ("", GetCapturedStderr());
491
492 const std::string expected = R"--(
493 @Override
494 public boolean equals(Object other) {
495 if (this == other) return true;
496 if (other == null) return false;
497 if (!(other instanceof Foo)) return false;
498 Foo that = (Foo)other;
499 if (!java.util.Objects.deepEquals(a, that.a)) return false;
500 if (!java.util.Objects.deepEquals(b, that.b)) return false;
501 return true;
502 }
503
504 @Override
505 public int hashCode() {
506 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
507 }
508)--";
509
510 string java_out;
511 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
512 EXPECT_THAT(java_out, testing::HasSubstr(expected));
513}
514
515TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
516 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
517 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
518 CaptureStderr();
519 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
520 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
521 EXPECT_EQ("", GetCapturedStderr());
522
523 const std::string expected = R"--(
524 @Override
525 public boolean equals(Object other) {
526 if (this == other) return true;
527 if (other == null) return false;
528 if (!(other instanceof Foo)) return false;
529 Foo that = (Foo)other;
530 if (_tag != that._tag) return false;
531 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
532 return true;
533 }
534
535 @Override
536 public int hashCode() {
537 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
538 }
539)--";
540
541 string java_out;
542 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
543 EXPECT_THAT(java_out, testing::HasSubstr(expected));
544}
545
Jooyung Han90345002020-10-23 15:28:53 +0900546TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900547 {
Jooyung Han90345002020-10-23 15:28:53 +0900548 io_delegate_.SetFileContents("a/Foo.aidl",
549 "package a; @JavaDerive(blah=true) parcelable Foo{}");
550 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
551 CaptureStderr();
552 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
553 const std::string expected_stderr =
554 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900555 EXPECT_THAT(GetCapturedStderr(),
556 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900557 }
558
559 {
560 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900561 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
562 CaptureStderr();
563 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900564 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900565 }
566
567 {
Jooyung Han90345002020-10-23 15:28:53 +0900568 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900569 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
570 CaptureStderr();
571 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900572 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900573 }
574}
575
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900576TEST_P(AidlTest, ParseDescriptorAnnotation) {
577 AidlError error;
578 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
579 typenames_, GetLanguage(), &error, {"--structured"});
580 ASSERT_EQ(AidlError::OK, error);
581 ASSERT_NE(nullptr, parse_result);
582 const AidlInterface* interface = parse_result->AsInterface();
583 ASSERT_NE(nullptr, interface);
584 ASSERT_EQ("IBar", interface->GetDescriptor());
585}
586
Jiyong Park40782d02020-07-24 19:17:43 +0900587TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700588 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700589 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900590}
591
592TEST_P(AidlTest, AcceptsOnewayInterface) {
593 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700594 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700595}
Christopher Wileyef140932015-11-03 09:29:19 -0800596
Devin Moore7b8d5c92020-03-17 14:14:08 -0700597TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700598 const string oneway_method =
599 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700600 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100601}
602
Steven Moreland65297cc2020-04-20 20:17:36 -0700603TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
604 const string oneway_method =
605 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
606 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
607 ASSERT_NE(nullptr, defined);
608 const AidlInterface* iface = defined->AsInterface();
609 ASSERT_NE(nullptr, iface);
610
611 const auto& methods = iface->GetMethods();
612 ASSERT_EQ(1u, methods.size());
613 const auto& method = methods[0];
614 const AidlTypeSpecifier& ret_type = method->GetType();
615
616 // TODO(b/151102494): these annotations should be on the method
617 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
618 ASSERT_TRUE(ret_type.IsHide());
619}
620
Devin Moore7b8d5c92020-03-17 14:14:08 -0700621TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100622 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900623 R"(package a;
624 /* foo */
625 interface IFoo {
626 /* i */
627 int i();
628 // j
629 @nullable String j();
630 // k1
631 /* k2 */
632 @UnsupportedAppUsage oneway void k(int a);
633 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100634
Jooyung Han8451a202021-01-16 03:07:06 +0900635 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700636 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100637 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900638 EXPECT_EQ("", GetCapturedStderr());
639
Jooyung Han161bb0f2021-01-21 12:30:16 +0900640 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100641
642 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900643 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
644 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
645 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100646}
647
Jooyung Han1a551d32020-10-05 15:37:26 +0900648TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
649 io_delegate_.SetFileContents("p/cpp_header.aidl",
650 R"(package p;
651 parcelable cpp_header cpp_header "bar/header";)");
652 import_paths_.emplace("");
653 const string input_path = "p/IFoo.aidl";
654 const string input = R"(package p;
655 import p.cpp_header;
656 interface IFoo {
657 // get bar
658 cpp_header get();
659 })";
660
661 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
662 EXPECT_NE(nullptr, parse_result);
663 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900664 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900665}
666
Christopher Wileyef140932015-11-03 09:29:19 -0800667TEST_F(AidlTest, ParsesPreprocessedFile) {
668 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
669 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700670 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900671 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700672 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
673 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800674}
675
676TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
677 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
678 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900679
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700680 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900681 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700682 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
683 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800684}
685
Devin Moore7b8d5c92020-03-17 14:14:08 -0700686TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800687 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
688 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
689 "interface IBar {}");
690 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900691 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900692 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700693 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800694 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900695
Christopher Wiley41544372015-11-03 14:52:29 -0800696 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700697 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
698 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800699 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900700 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900701 ambiguous_type.Resolve(typenames_);
702 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800703}
704
Jiyong Park8f6ec462020-01-19 20:52:47 +0900705// Special case of PreferImportToPreprocessed. Imported type should be preferred
706// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700707TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900708 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
709 io_delegate_.SetFileContents("one/IBar.aidl",
710 "package one; "
711 "interface IBar {}");
712 preprocessed_files_.push_back("preprocessed");
713 import_paths_.emplace("");
714 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700715 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900716 EXPECT_NE(nullptr, parse_result);
717
718 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700719 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
720 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900721 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900722 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900723 ambiguous_type.Resolve(typenames_);
724 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
725}
726
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800727TEST_F(AidlTest, WritePreprocessedFile) {
728 io_delegate_.SetFileContents("p/Outer.aidl",
729 "package p; parcelable Outer.Inner;");
730 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
731 "interface IBar {}");
732
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900733 vector<string> args {
734 "aidl",
735 "--preprocess",
736 "preprocessed",
737 "p/Outer.aidl",
738 "one/IBar.aidl"};
739 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800740 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
741
742 string output;
743 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
744 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
745}
746
Jooyung Han720253d2021-01-05 19:13:17 +0900747TEST_P(AidlTest, SupportDeprecated) {
748 struct TestCase {
749 std::string output_file;
750 std::string annotation;
751 };
752
753 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900754 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900755 io_delegate_.SetFileContents(filename, contents);
756
757 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
758 " --out=out --header_out=out");
759 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900760 for (const auto& [lang, test_case] : expectations) {
761 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900762 string output;
763 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output))
764 << base::Join(io_delegate_.ListOutputFiles(), ",");
765 EXPECT_THAT(output, HasSubstr(test_case.annotation));
766 }
767 };
768
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900769 // Emit escaped string for notes
770 CheckDeprecated(
771 "IFoo.aidl",
772 R"(interface IFoo {
773 /**
774 * @note asdf
775 * @deprecated a really long deprecation message
776 *
777 * which is really long
778 * @param foo bar
779 */
780 List<String> foo();
781 })",
782 {
783 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
784 {Options::Language::CPP,
785 {"out/IFoo.h",
786 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
787 {Options::Language::NDK,
788 {"out/aidl/IFoo.h",
789 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
790 {Options::Language::RUST,
791 {"out/IFoo.rs",
792 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
793 });
794
Jooyung Han24effbf2021-01-16 10:24:03 +0900795 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900796 CheckDeprecated(
797 "IFoo.aidl",
798 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900799 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900800 " List<String> foo();\n"
801 "}",
802 {
803 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900804 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900805 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
806 {Options::Language::NDK,
807 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
808 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
809 });
Jooyung Han720253d2021-01-05 19:13:17 +0900810
Jooyung Han24effbf2021-01-16 10:24:03 +0900811 // but not in line comments
812 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
813 EXPECT_FALSE(parsed->IsDeprecated());
814
815 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900816 CheckDeprecated("Foo.aidl",
817 "parcelable Foo {\n"
818 " /** @deprecated use bar*/\n"
819 " int foo = 0;\n"
820 "}",
821 {
822 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
823 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
824 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
825 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
826 });
827
Jooyung Han24effbf2021-01-16 10:24:03 +0900828 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900829 CheckDeprecated("IFoo.aidl",
830 "interface IFoo {\n"
831 " /** @deprecated use bar*/\n"
832 " const int FOO = 0;\n"
833 "}",
834 {
835 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
836 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
837 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
838 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
839 });
840
841 // union fields
842 CheckDeprecated("Foo.aidl",
843 "union Foo {\n"
844 " int bar = 0;\n"
845 " /** @deprecated use bar*/\n"
846 " int foo;\n"
847 "}",
848 {
849 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
850 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
851 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
852 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
853 });
854
855 CheckDeprecated("Foo.aidl",
856 "/** @deprecated use Bar */\n"
857 "parcelable Foo {}",
858 {
859 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
860 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
861 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
862 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
863 });
864
865 CheckDeprecated("Foo.aidl",
866 "/** @deprecated use Bar */\n"
867 "union Foo { int foo = 0; }",
868 {
869 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
870 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
871 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
872 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
873 });
874
875 CheckDeprecated("IFoo.aidl",
876 "/** @deprecated use IBar */\n"
877 "interface IFoo {}",
878 {
879 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
880 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
881 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
882 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
883 });
884
885 CheckDeprecated("Foo.aidl",
886 "/** @deprecated use IBar */\n"
887 "enum Foo { FOO }",
888 {
889 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
890 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
891 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900892 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +0900893 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
894 });
895}
896
Devin Moore7b8d5c92020-03-17 14:14:08 -0700897TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700898 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800899 io_delegate_.SetFileContents("p/Outer.aidl",
900 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900901 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700902 CaptureStderr();
903 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
904 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700905 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800907}
908
Devin Moore7b8d5c92020-03-17 14:14:08 -0700909TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800910 io_delegate_.SetFileContents("preprocessed",
911 "parcelable p.Outer.Inner;");
912 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900913 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700914 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800915 // TODO(wiley): This should actually return nullptr because we require
916 // the outer class name. However, for legacy reasons,
917 // this behavior must be maintained. b/17415692
918 EXPECT_NE(nullptr, parse_result);
919}
920
Christopher Wiley632801d2015-11-05 14:15:49 -0800921TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 const string expected_foo_stderr =
923 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
924 "Declared parcelables should be in their own file and/or cannot be used with --structured "
925 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700926 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
927
Christopher Wiley632801d2015-11-05 14:15:49 -0800928 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700929 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700930 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900931 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900933
Steven Morelande2c64b42018-09-18 15:06:37 -0700934 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900935 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900937 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700939
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 const string expected_bar_stderr =
941 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
942 "Declared parcelables should be in their own file and/or cannot be used with --structured "
943 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700944 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
945
Jiyong Parkda8c6932019-08-12 19:56:08 +0900946 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700947 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700948 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900949 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700950 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700951 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700952 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700953 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800955}
956
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 const string expected_stderr =
959 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
960 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700961 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
962 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 AidlError error;
964 CaptureStderr();
965 EXPECT_EQ(
966 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700967 Parse("p/IFoo.aidl",
968 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700969 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 EXPECT_EQ(expected_stderr, GetCapturedStderr());
971 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700972}
973
Devin Moore7b8d5c92020-03-17 14:14:08 -0700974TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700975 AidlError error;
976 const string expected_stderr =
977 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
978 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900979 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
980 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700981 interface IFoo {
982 const String DUPLICATED = "d";
983 const int DUPLICATED = 1;
984 }
985 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700986 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
988 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700989}
990
Steven Morelande689da22020-11-10 02:06:30 +0000991TEST_P(AidlTest, FailOnTooBigConstant) {
992 AidlError error;
993 const string expected_stderr =
994 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
995 CaptureStderr();
996 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
997 R"(package p;
998 interface IFoo {
999 const byte type2small = 256;
1000 }
1001 )",
1002 typenames_, GetLanguage(), &error));
1003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1004 EXPECT_EQ(AidlError::BAD_TYPE, error);
1005}
1006
Jooyung Han30f64ad2020-12-15 08:16:31 +09001007TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1008 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1009 CaptureStderr();
1010 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1011 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1012 EXPECT_EQ("", GetCapturedStderr());
1013 string code;
1014 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1015 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1016}
1017
Jooyung Han535c5e82020-12-29 15:16:59 +09001018TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001019 using Ptr = unique_ptr<AidlConstantValue>;
1020 const AidlLocation& loc = AIDL_LOCATION_HERE;
1021
Jooyung Han535c5e82020-12-29 15:16:59 +09001022 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1023 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1024 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1025 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001026
1027 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1028 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001029 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001030
1031 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1032 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1033 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1034 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001035 EXPECT_EQ(
1036 expected,
1037 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001038}
1039
Devin Moore7b8d5c92020-03-17 14:14:08 -07001040TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001041 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001042 const string expected_stderr =
1043 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001044 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001045 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1046 R"(package p;
1047 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001048 parcelable IBar {}
1049 parcelable StructuredParcelable {}
1050 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001051 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001052 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001053 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001054 // Parse success is important for clear error handling even if the cases aren't
1055 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001056 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001057}
1058
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 AidlError error;
1061 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1062 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001064 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1065 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001066}
1067
Steven Morelandf9e922f2020-07-08 21:15:27 +00001068TEST_P(AidlTest, FailOnEmptyListWithComma) {
1069 AidlError error;
1070 const string expected_stderr =
1071 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1072 CaptureStderr();
1073 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1074 typenames_, GetLanguage(), &error));
1075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1076 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1077}
1078
Devin Moore7b8d5c92020-03-17 14:14:08 -07001079TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001080 AidlError error;
1081 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001082 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001083 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001084 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1085 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001086 interface IFoo {
1087 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1088 }
1089 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001090 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001091 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1092 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001093}
1094
Jiyong Park18132182020-06-08 20:24:40 +09001095TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1096 AidlError error;
1097 const string expected_stderr =
1098 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1099 "cpp_header (which can also be used as an identifier)\n";
1100 CaptureStderr();
1101 // Notice the trailing dot(.) in the name, which isn't a correct name
1102 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1103 GetLanguage(), &error));
1104 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1105 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1106}
1107
1108TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1109 AidlError error;
1110 const string expected_stderr =
1111 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1112 "cpp_header (which can also be used as an identifier)\n";
1113 CaptureStderr();
1114 // Notice the trailing dot(.) in the package name
1115 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1116 GetLanguage(), &error));
1117 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1118 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1119}
1120
Devin Moore7b8d5c92020-03-17 14:14:08 -07001121TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001122 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001123 auto parse_result = Parse("p/IFoo.aidl",
1124 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001125 interface IFoo {
1126 const int POSITIVE_HEX_VALUE = 0xf5;
1127 }
1128 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001129 typenames_, GetLanguage(), &error);
1130 EXPECT_NE(nullptr, parse_result);
1131 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001132 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001133 const auto& cpp_constants = interface->GetConstantDeclarations();
1134 EXPECT_EQ((size_t)1, cpp_constants.size());
1135 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001136 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001137 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001138}
1139
Devin Moore7b8d5c92020-03-17 14:14:08 -07001140TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001141 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001142 auto parse_result = Parse("p/IFoo.aidl",
1143 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001144 interface IFoo {
1145 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1146 }
1147 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001148 typenames_, GetLanguage(), &error);
1149 ASSERT_NE(nullptr, parse_result);
1150 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001151 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001152 const auto& cpp_constants = interface->GetConstantDeclarations();
1153 EXPECT_EQ((size_t)1, cpp_constants.size());
1154 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001155 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001156 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001157}
1158
Devin Moore7b8d5c92020-03-17 14:14:08 -07001159TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001160 io_delegate_.SetFileContents(
1161 "p/Outer.aidl",
1162 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001163 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001164 const string input_path = "p/IFoo.aidl";
1165 const string input = "package p; import p.Outer; interface IFoo"
1166 " { Outer.Inner get(); }";
1167
Devin Moore7b8d5c92020-03-17 14:14:08 -07001168 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1169 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001170
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001171 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001172 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001173 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001174 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001175}
1176
Devin Moore7b8d5c92020-03-17 14:14:08 -07001177TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001178 io_delegate_.SetFileContents(
1179 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001180 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001181 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001182 const string input_path = "p/IFoo.aidl";
1183 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001184 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1185 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001186 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001187 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001188 native_type.Resolve(typenames_);
1189
1190 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1191 // C++ understands C++ specific stuff
1192 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1193 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001194 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001195 EXPECT_EQ(1u, headers.size());
1196 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001197}
1198
Christopher Wileyf8136192016-04-12 14:19:35 -07001199TEST_F(AidlTest, WritesCorrectDependencyFile) {
1200 // While the in tree build system always gives us an output file name,
1201 // other android tools take advantage of our ability to infer the intended
1202 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001203 vector<string> args = {
1204 "aidl",
1205 "-d dep/file/path",
1206 "-o place/for/output",
1207 "p/IFoo.aidl"};
1208 Options options = Options::From(args);
1209 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001210 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001211 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001212 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001213 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1214}
1215
Dan Willemsen93298ee2016-11-10 23:55:55 -08001216TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1217 // While the in tree build system always gives us an output file name,
1218 // other android tools take advantage of our ability to infer the intended
1219 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001220 vector<string> args = {
1221 "aidl",
1222 "-d dep/file/path",
1223 "--ninja",
1224 "-o place/for/output",
1225 "p/IFoo.aidl"};
1226 Options options = Options::From(args);
1227 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001228 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001229 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001230 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001231 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1232}
1233
Jiyong Parkdf202122019-09-30 20:48:35 +09001234TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001235 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1236 // this by calling aidl with every .aidl file it finds, then parsing the
1237 // generated dependency files. Those that reference .java output files are
1238 // for interfaces and those that do not are parcelables. However, for both
1239 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001240 vector<string> args = {
1241 "aidl",
1242 "-o place/for/output",
1243 "-d dep/file/path",
1244 "p/Foo.aidl"};
1245 Options options = Options::From(args);
1246 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001247 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001248 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001249 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001250 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1251}
1252
1253TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1254 vector<string> args = {
1255 "aidl",
1256 "--structured",
1257 "-o place/for/output",
1258 "-d dep/file/path",
1259 "p/Foo.aidl"};
1260 Options options = Options::From(args);
1261 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1262 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1263 string actual_dep_file_contents;
1264 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1265 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001266}
1267
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001268TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1269 vector<string> args = {
1270 "aidl",
1271 "--lang=java",
1272 "-o place/for/output",
1273 "p/Foo.aidl"};
1274 Options options = Options::From(args);
1275 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1276 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1277 string output_file_contents;
1278 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1279}
1280
Devin Moore21b26772020-08-26 16:37:56 -07001281TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001282 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001283 const string list_array_parcelable =
1284 "package a; parcelable Foo {\n"
1285 " List[] lists; }";
1286 CaptureStderr();
1287 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1288 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1289}
1290
Jiyong Parkf8d53612020-05-04 14:06:13 +09001291TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1292 AidlError error;
1293 string expected_stderr =
1294 "ERROR: a/IFoo.aidl:2.7-11: "
1295 "Encountered an untyped List or Map. The use of untyped List/Map is "
1296 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1297 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1298 if (GetLanguage() != Options::Language::JAVA) {
1299 expected_stderr =
1300 "ERROR: a/IFoo.aidl:2.1-7: "
1301 "Currently, only the Java backend supports non-generic List.\n";
1302 }
1303
1304 const string primitive_interface =
1305 "package a; interface IFoo {\n"
1306 " List foo(); }";
1307 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001308 AidlTypenames tn1;
1309 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001310 {"--structured"}));
1311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001312
1313 string primitive_parcelable =
1314 "package a; parcelable IFoo {\n"
1315 " List foo;}";
1316 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001317 AidlTypenames tn2;
1318 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001319 {"--structured"}));
1320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1321}
1322
Jeongik Cha225519b2020-08-29 01:55:32 +09001323TEST_P(AidlTest, ExtensionTest) {
1324 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001325 string extendable_parcelable =
1326 "package a; parcelable Data {\n"
1327 " ParcelableHolder extension;\n"
1328 " ParcelableHolder extension2;\n"
1329 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001330 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1332 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001333 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001334 "yet.\n",
1335 GetCapturedStderr());
1336 } else {
1337 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1338 EXPECT_EQ("", GetCapturedStderr());
1339 }
1340}
1341TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1342 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001343 string parcelableholder_return_interface =
1344 "package a; interface IFoo {\n"
1345 " ParcelableHolder foo();\n"
1346 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001347 EXPECT_EQ(nullptr,
1348 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001349
Jeongik Cha8f02a532020-10-14 00:16:28 +09001350 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001351 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001352 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001353 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001354 "yet.\n",
1355 GetCapturedStderr());
1356 return;
1357 }
1358 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1359 GetCapturedStderr());
1360}
1361
1362TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1363 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001364 string extendable_parcelable_arg_interface =
1365 "package a; interface IFoo {\n"
1366 " void foo(in ParcelableHolder ph);\n"
1367 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001368 EXPECT_EQ(nullptr,
1369 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1370
Jeongik Cha8f02a532020-10-14 00:16:28 +09001371 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001372 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001373 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001374 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001375 "yet.\n",
1376 GetCapturedStderr());
1377 return;
1378 }
1379 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1380 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001381}
1382
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001383TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1384 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001385 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001386 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1387 CaptureStderr();
1388 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1389 if (GetLanguage() == Options::Language::RUST) {
1390 EXPECT_EQ(
1391 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1392 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1393 "yet.\n",
1394 GetCapturedStderr());
1395 return;
1396 }
1397 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1398}
1399
Jooyung Han3f347ca2020-12-01 12:41:50 +09001400TEST_P(AidlTest, ParcelablesWithConstants) {
1401 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001402 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001403 CaptureStderr();
1404 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1405 EXPECT_EQ("", GetCapturedStderr());
1406}
1407
1408TEST_P(AidlTest, UnionWithConstants) {
1409 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001410 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001411 CaptureStderr();
1412 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1413 EXPECT_EQ("", GetCapturedStderr());
1414}
1415
Jooyung Han633eab62021-01-07 14:12:40 +09001416TEST_F(AidlTest, ConstantsWithAnnotations) {
1417 io_delegate_.SetFileContents("IFoo.aidl",
1418 "interface IFoo {\n"
1419 " @JavaPassthrough(annotation=\"@Foo\")\n"
1420 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1421 "}");
1422 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1423 CaptureStderr();
1424 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1425 EXPECT_EQ("", GetCapturedStderr());
1426 string code;
1427 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1428 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1429 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1430}
1431
Jiyong Park02da7422018-07-16 16:00:26 +09001432TEST_F(AidlTest, ApiDump) {
1433 io_delegate_.SetFileContents(
1434 "foo/bar/IFoo.aidl",
1435 "package foo.bar;\n"
1436 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001437 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001438 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001439 " /* @hide applied \n"
1440 " @deprecated use foo2 */\n"
1441 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1442 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001443 " IFoo foo3(IFoo foo);\n"
1444 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001445 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001446 " /** blahblah\n"
1447 " @deprecated\n"
1448 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001449 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001450 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001451 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001452 "}\n");
1453 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1454 "package foo.bar;\n"
1455 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001456 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001457 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001458 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001459 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001460 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001461 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001462 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001463 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001464 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001465 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001466 "}\n");
1467 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001468 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1469 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001470 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001471 bool result = dump_api(options, io_delegate_);
1472 ASSERT_TRUE(result);
1473 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001474 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001475 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001476interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001477 /**
1478 * @hide
1479 * @deprecated use foo2
1480 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001481 int foo(out int[] a, String b, boolean c, inout List<String> d);
1482 int foo2(@utf8InCpp String x, inout List<String> y);
1483 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1484 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001485 /**
1486 * @deprecated reason why...
1487 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001488 const int A = 1;
1489 const String STR = "Hello";
1490}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001491)"),
1492 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001493
Jiyong Parke59c3682018-09-11 23:10:25 +09001494 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001495 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1496/**
1497 * @hide
1498 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001499parcelable Data {
1500 int x = 10;
1501 int y;
1502 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001503 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001504}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001505)"),
1506 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001507}
1508
Jiyong Parked65bf42018-08-28 15:43:27 +09001509TEST_F(AidlTest, ApiDumpWithManualIds) {
1510 io_delegate_.SetFileContents(
1511 "foo/bar/IFoo.aidl",
1512 "package foo.bar;\n"
1513 "interface IFoo {\n"
1514 " int foo() = 1;\n"
1515 " int bar() = 2;\n"
1516 " int baz() = 10;\n"
1517 "}\n");
1518
Jiyong Parke59c3682018-09-11 23:10:25 +09001519 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001520 Options options = Options::From(args);
1521 bool result = dump_api(options, io_delegate_);
1522 ASSERT_TRUE(result);
1523 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001524 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001525 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001526interface IFoo {
1527 int foo() = 1;
1528 int bar() = 2;
1529 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001530}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001531)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001532}
1533
1534TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001535 const string expected_stderr =
1536 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1537 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001538 io_delegate_.SetFileContents(
1539 "foo/bar/IFoo.aidl",
1540 "package foo.bar;\n"
1541 "interface IFoo {\n"
1542 " int foo() = 1;\n"
1543 " int bar();\n"
1544 " int baz() = 10;\n"
1545 "}\n");
1546
Jiyong Parke59c3682018-09-11 23:10:25 +09001547 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001548 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001549 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001550 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001552}
1553
Jooyung Han965e31d2020-11-27 12:30:16 +09001554TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1555 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1556 "package foo.bar;\n"
1557 "interface IFoo {\n"
1558 " @utf8InCpp String foo();\n"
1559 " const @utf8InCpp String bar = \"bar\";\n"
1560 "}\n");
1561
1562 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1563 Options options = Options::From(args);
1564 CaptureStderr();
1565 EXPECT_TRUE(dump_api(options, io_delegate_));
1566 EXPECT_EQ("", GetCapturedStderr());
1567 string actual;
1568 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001569 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1570interface IFoo {
1571 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001572 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001573}
1574)"),
1575 actual);
1576}
1577
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001578TEST_F(AidlTest, ApiDumpWithEnums) {
1579 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1580 "package foo.bar;\n"
1581 "enum Enum {\n"
1582 " FOO,\n"
1583 " BAR = FOO + 1,\n"
1584 "}\n");
1585
1586 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1587 Options options = Options::From(args);
1588 CaptureStderr();
1589 EXPECT_TRUE(dump_api(options, io_delegate_));
1590 EXPECT_EQ("", GetCapturedStderr());
1591 string actual;
1592 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1593 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1594 "enum Enum {\n"
1595 " FOO = 0,\n"
1596 " BAR = 1,\n"
1597 "}\n"),
1598 actual);
1599}
1600
1601TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1602 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1603 "package foo.bar;\n"
1604 "enum Enum {\n"
1605 " FOO,\n"
1606 "}\n");
1607 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1608 "package foo.bar;\n"
1609 "import foo.bar.Enum;\n"
1610 "parcelable Foo {\n"
1611 " Enum e = Enum.FOO;\n"
1612 "}\n");
1613
1614 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1615 Options options = Options::From(args);
1616 CaptureStderr();
1617 EXPECT_TRUE(dump_api(options, io_delegate_));
1618 EXPECT_EQ("", GetCapturedStderr());
1619 string actual;
1620 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1621 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1622 "parcelable Foo {\n"
1623 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1624 "}\n"),
1625 actual);
1626}
1627
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001628TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001629 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001630 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1631 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001632 const string expected_map_stderr =
1633 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001634 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1635 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001636 "package p; interface IFoo {"
1637 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001639 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001640 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001641
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001642 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001643 "package p; interface IFoo {"
1644 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001645 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001646 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001647 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001648}
1649
Jeongik Chae48d9942020-01-02 17:39:00 +09001650TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001651 const string expected_stderr =
1652 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001653 Options options = Options::From("aidl -I p p/IFoo.aidl");
1654 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1655
1656 io_delegate_.SetFileContents("p/IFoo.aidl",
1657 "package p; interface IFoo {"
1658 "Map<String, Bar> foo();}");
1659 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1660
1661 io_delegate_.SetFileContents("p/IFoo.aidl",
1662 "package p; interface IFoo {"
1663 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001664 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001665 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001666 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001667
1668 io_delegate_.SetFileContents("p/IFoo.aidl",
1669 "package p; interface IFoo {"
1670 "Map<String, String> foo();}");
1671 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1672
1673 io_delegate_.SetFileContents("p/IFoo.aidl",
1674 "package p; interface IFoo {"
1675 "Map<String, ParcelFileDescriptor> foo();}");
1676 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1677}
1678
Jeongik Chadf76dc72019-11-28 00:08:47 +09001679TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001680 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001681 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1682 io_delegate_.SetFileContents(options.InputFiles().front(),
1683 "package p; interface IFoo {"
1684 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001685 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001687 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001688}
1689
1690TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1691 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1692 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001693 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001694 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001695 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1696 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001697
1698 Options options = Options::From("aidl -I p p/IFoo.aidl");
1699 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1700 io_delegate_.SetFileContents("p/IFoo.aidl",
1701 "package p; interface IFoo {"
1702 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001703 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001704 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001705 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001706 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001707 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001708 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001709 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1710 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001711 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1712 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1713 io_delegate_.SetFileContents("p/IFoo.aidl",
1714 "package p; interface IFoo {"
1715 "Bar<String, ParcelFileDescriptor> foo();}");
1716 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001717
1718 io_delegate_.SetFileContents("p/IFoo.aidl",
1719 "package p; interface IFoo {"
1720 "Bar<int, long> foo();}");
1721
1722 io_delegate_.SetFileContents("p/IFoo.aidl",
1723 "package p; interface IFoo {"
1724 "Bar<int[], long[]> foo();}");
1725
1726 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001727}
1728
Jeongik Cha0e426012019-07-29 15:57:02 +09001729TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1730 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001731 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1732 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001733 for (const auto& rawOption : rawOptions) {
1734 string expected_stderr =
1735 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001736 Options options = Options::From(rawOption);
1737 io_delegate_.SetFileContents(options.InputFiles().front(),
1738 "package foo.bar;\n"
1739 "interface IFoo1 { int foo(); }\n"
1740 "interface IFoo2 { int foo(); }\n"
1741 "parcelable Data1 { int a; int b;}\n"
1742 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001743 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001744 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001746
Jeongik Cha0e426012019-07-29 15:57:02 +09001747 io_delegate_.SetFileContents(options.InputFiles().front(),
1748 "package foo.bar;\n"
1749 "interface IFoo1 { int foo(); }\n"
1750 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001751 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001752 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001753 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001754
Devin Moore5de18ed2020-04-02 13:52:29 -07001755 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001756 io_delegate_.SetFileContents(options.InputFiles().front(),
1757 "package foo.bar;\n"
1758 "parcelable Data1 { int a; int b;}\n"
1759 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001760 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001761 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001762 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001763 }
1764}
1765
Devin Moorebdba2a82020-03-31 15:19:02 -07001766TEST_P(AidlTest, FailParseOnEmptyFile) {
1767 const string contents = "";
1768 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1769 CaptureStderr();
1770 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1771 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1772}
1773
Jiyong Parkb034bf02018-07-30 17:44:33 +09001774TEST_F(AidlTest, MultipleInputFiles) {
1775 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001776 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001777
1778 io_delegate_.SetFileContents(options.InputFiles().at(0),
1779 "package foo.bar;\n"
1780 "import foo.bar.Data;\n"
1781 "interface IFoo { Data getData(); }\n");
1782
1783 io_delegate_.SetFileContents(options.InputFiles().at(1),
1784 "package foo.bar;\n"
1785 "import foo.bar.IFoo;\n"
1786 "parcelable Data { IFoo foo; }\n");
1787
1788 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1789
1790 string content;
1791 for (const auto file : {
1792 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1793 content.clear();
1794 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1795 EXPECT_FALSE(content.empty());
1796 }
1797}
1798
1799TEST_F(AidlTest, MultipleInputFilesCpp) {
1800 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001801 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001802
1803 io_delegate_.SetFileContents(options.InputFiles().at(0),
1804 "package foo.bar;\n"
1805 "import foo.bar.Data;\n"
1806 "interface IFoo { Data getData(); }\n");
1807
1808 io_delegate_.SetFileContents(options.InputFiles().at(1),
1809 "package foo.bar;\n"
1810 "import foo.bar.IFoo;\n"
1811 "parcelable Data { IFoo foo; }\n");
1812
1813 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1814
1815 string content;
1816 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001817 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001818 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1819 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1820 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1821 content.clear();
1822 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1823 EXPECT_FALSE(content.empty());
1824 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001825}
1826
Andrei Homescub62afd92020-05-11 19:24:59 -07001827TEST_F(AidlTest, MultipleInputFilesRust) {
1828 Options options =
1829 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1830
1831 io_delegate_.SetFileContents(options.InputFiles().at(0),
1832 "package foo.bar;\n"
1833 "import foo.bar.Data;\n"
1834 "interface IFoo { Data getData(); }\n");
1835
1836 io_delegate_.SetFileContents(options.InputFiles().at(1),
1837 "package foo.bar;\n"
1838 "import foo.bar.IFoo;\n"
1839 "parcelable Data { IFoo foo; }\n");
1840
1841 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1842
1843 string content;
1844 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1845 content.clear();
1846 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1847 EXPECT_FALSE(content.empty());
1848 }
1849}
1850
Devin Moore097a3ab2020-03-11 16:08:44 -07001851TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1852 const string expected_stderr =
1853 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001854 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1855 // int getInterfaceVersion() is one of the meta transactions
1856 io_delegate_.SetFileContents(options.InputFiles().front(),
1857 "package p; interface IFoo {"
1858 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001859 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001860 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001861 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1862}
Jiyong Park309668e2018-07-28 16:55:44 +09001863
Devin Moore097a3ab2020-03-11 16:08:44 -07001864TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1865 // boolean getInterfaceVersion() is not a meta transaction, but should be
1866 // prevented because return type is not part of a method signature
1867 const string expected_stderr =
1868 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1869 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001870 io_delegate_.SetFileContents(options.InputFiles().front(),
1871 "package p; interface IFoo {"
1872 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001873 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001874 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001875 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1876}
Jiyong Park309668e2018-07-28 16:55:44 +09001877
Devin Moore097a3ab2020-03-11 16:08:44 -07001878TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001879 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001880 const string expected_stderr =
1881 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1882 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001883 io_delegate_.SetFileContents(options.InputFiles().front(),
1884 "package p; interface IFoo {"
1885 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001886 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001887 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001888 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001889
1890 // this is not a meta interface method as it differs type arguments
1891 io_delegate_.SetFileContents(options.InputFiles().front(),
1892 "package p; interface IFoo {"
1893 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001894 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001895}
1896
Jooyung Hanb8a97772021-01-19 01:27:38 +09001897TEST_F(AidlTest, CheckApiForEquality) {
1898 CaptureStderr();
1899 Options options = Options::From("aidl --checkapi=equal old new");
1900
1901 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1902 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1903 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1904 "package p; interface IFoo{ @utf8InCpp String foo();}");
1905
1906 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1907 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1908}
1909
Daniel Norman85aed542019-08-21 12:01:14 -07001910TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001911 Options options = Options::From("aidl --checkapi old new");
1912 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1913 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1914 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1915 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1916
1917 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1918}
1919
Jiyong Park3656c3c2018-08-01 20:02:01 +09001920TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001921 Options options = Options::From("aidl --checkapi old new");
1922 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1923 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001924
1925 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1926}
1927
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001928TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1929 Options options = Options::From("aidl --checkapi old new");
1930 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1931 const string enum_definition = "package p; enum Enum { FOO }";
1932 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1933 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1934 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1935 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1936
1937 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1938}
1939
Daniel Norman85aed542019-08-21 12:01:14 -07001940class AidlTestCompatibleChanges : public AidlTest {
1941 protected:
1942 Options options_ = Options::From("aidl --checkapi old new");
1943};
1944
1945TEST_F(AidlTestCompatibleChanges, NewType) {
1946 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1947 "package p;"
1948 "interface IFoo {"
1949 " void foo(int a);"
1950 "}");
1951 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1952 "package p;"
1953 "interface IFoo {"
1954 " void foo(int a);"
1955 "}");
1956 io_delegate_.SetFileContents("new/p/IBar.aidl",
1957 "package p;"
1958 "interface IBar {"
1959 " void bar();"
1960 "}");
1961 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1962}
1963
1964TEST_F(AidlTestCompatibleChanges, NewMethod) {
1965 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1966 "package p;"
1967 "interface IFoo {"
1968 " void foo(int a);"
1969 "}");
1970 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1971 "package p;"
1972 "interface IFoo {"
1973 " void foo(int a);"
1974 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001975 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001976 "}");
1977 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1978}
1979
1980TEST_F(AidlTestCompatibleChanges, NewField) {
1981 io_delegate_.SetFileContents("old/p/Data.aidl",
1982 "package p;"
1983 "parcelable Data {"
1984 " int foo;"
1985 "}");
1986 io_delegate_.SetFileContents("new/p/Data.aidl",
1987 "package p;"
1988 "parcelable Data {"
1989 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001990 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001991 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001992 "}");
1993 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1994}
1995
1996TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1997 io_delegate_.SetFileContents("old/p/Enum.aidl",
1998 "package p;"
1999 "enum Enum {"
2000 " FOO = 1,"
2001 "}");
2002 io_delegate_.SetFileContents("new/p/Enum.aidl",
2003 "package p;"
2004 "enum Enum {"
2005 " FOO = 1,"
2006 " BAR = 2,"
2007 "}");
2008 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2009}
2010
2011TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2012 io_delegate_.SetFileContents("old/p/Enum.aidl",
2013 "package p;"
2014 "enum Enum {"
2015 " FOO = 1,"
2016 " BAR = 2,"
2017 "}");
2018 io_delegate_.SetFileContents("new/p/Enum.aidl",
2019 "package p;"
2020 "enum Enum {"
2021 " BAR = 2,"
2022 " FOO = 1,"
2023 "}");
2024 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2025}
2026
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002027TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2028 io_delegate_.SetFileContents("old/p/Union.aidl",
2029 "package p;"
2030 "union Union {"
2031 " String foo;"
2032 "}");
2033 io_delegate_.SetFileContents("new/p/Union.aidl",
2034 "package p;"
2035 "union Union {"
2036 " String foo;"
2037 " int num;"
2038 "}");
2039 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2040}
2041
Daniel Norman85aed542019-08-21 12:01:14 -07002042TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002043 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2044 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002045 "interface IFoo {"
2046 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002047 "}");
2048 io_delegate_.SetFileContents("old/p/Data.aidl",
2049 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002050 "parcelable Data {"
2051 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002052 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002053 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2054 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002055 "interface IFoo {"
2056 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002057 "}");
2058 io_delegate_.SetFileContents("new/p/Data.aidl",
2059 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002060 "parcelable Data {"
2061 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002062 "}");
2063 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2064 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002065 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002066 " void foo(int a);"
2067 "}");
2068 io_delegate_.SetFileContents("new/q/Data.aidl",
2069 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002070 "parcelable Data {"
2071 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002072 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002073 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2074}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002075
Daniel Norman85aed542019-08-21 12:01:14 -07002076TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2077 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2078 "package p;"
2079 "interface IFoo {"
2080 " void foo(int a);"
2081 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002082 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2083 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002084 "interface IFoo {"
2085 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002086 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002087 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2088}
Jiyong Parke59c3682018-09-11 23:10:25 +09002089
Daniel Norman85aed542019-08-21 12:01:14 -07002090TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002091 io_delegate_.SetFileContents("old/p/I.aidl",
2092 "package p; interface I {"
2093 "const int A = 1; }");
2094 io_delegate_.SetFileContents("new/p/I.aidl",
2095 "package p ; interface I {"
2096 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002097 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2098}
Jiyong Parka428d212018-08-29 22:26:30 +09002099
Daniel Norman85aed542019-08-21 12:01:14 -07002100TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002101 io_delegate_.SetFileContents("old/p/I.aidl",
2102 "package p; interface I {"
2103 "const int A = 1; const int B = 2;}");
2104 io_delegate_.SetFileContents("new/p/I.aidl",
2105 "package p ; interface I {"
2106 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002107 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002108}
2109
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002110TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2111 io_delegate_.SetFileContents("old/p/Foo.aidl",
2112 "package p;"
2113 "@JavaPassthrough(annotation=\"Alice\")"
2114 "@JavaPassthrough(annotation=\"Bob\")"
2115 "parcelable Foo {}");
2116 io_delegate_.SetFileContents("new/p/Foo.aidl",
2117 "package p;"
2118 "@JavaPassthrough(annotation=\"Bob\")"
2119 "@JavaPassthrough(annotation=\"Alice\")"
2120 "parcelable Foo {}");
2121 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2122}
2123
Jooyung Han00073272020-11-27 14:20:20 +09002124TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2125 io_delegate_.SetFileContents("old/p/Foo.aidl",
2126 "package p;"
2127 "parcelable Foo {}");
2128 io_delegate_.SetFileContents("new/p/Foo.aidl",
2129 "package p;"
2130 "@JavaPassthrough(annotation=\"@Deprecated\")"
2131 "parcelable Foo {}");
2132 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2133}
2134
Jooyung Han636fd2f2020-10-22 11:33:45 +09002135TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2136 io_delegate_.SetFileContents("old/p/Data.aidl",
2137 "package p;"
2138 "parcelable Data {"
2139 " int num;"
2140 "}");
2141 io_delegate_.SetFileContents(
2142 "new/p/Data.aidl",
2143 "package p;"
2144 "parcelable Data {"
2145 " int num;"
2146 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2147 "}");
2148 io_delegate_.SetFileContents("new/p/Enum.aidl",
2149 "package p;"
2150 "enum Enum {"
2151 " FOO = 0,"
2152 " BAR = 1,"
2153 "}");
2154 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2155}
2156
Daniel Norman85aed542019-08-21 12:01:14 -07002157class AidlTestIncompatibleChanges : public AidlTest {
2158 protected:
2159 Options options_ = Options::From("aidl --checkapi old new");
2160};
2161
2162TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002163 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002164 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2165 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002166 "interface IFoo {"
2167 " void foo(in String[] str);"
2168 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002169 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002170 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002171 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002172 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002173}
2174
2175TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002176 const string expected_stderr =
2177 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002178 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2179 "package p;"
2180 "interface IFoo {"
2181 " void foo(in String[] str);"
2182 " void bar(@utf8InCpp String str);"
2183 "}");
2184 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2185 "package p;"
2186 "interface IFoo {"
2187 " void foo(in String[] str);"
2188 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002189 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002190 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002191 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002192}
2193
Jiyong Parkf8d53612020-05-04 14:06:13 +09002194TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2195 const string expected_stderr =
2196 "ERROR: new/p/IFoo.aidl:1.61-65: "
2197 "Encountered an untyped List or Map. The use of untyped List/Map is "
2198 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2199 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2200 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2201 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2202 "package p;"
2203 "interface IFoo {"
2204 " void foo(in String[] str);"
2205 "}");
2206 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2207 "package p;"
2208 "interface IFoo {"
2209 " void foo(in String[] str);"
2210 " void bar(in List arg);"
2211 "}");
2212 CaptureStderr();
2213 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2214 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2215}
2216
2217TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2218 const string expected_stderr =
2219 "ERROR: new/p/Data.aidl:1.54-59: "
2220 "Encountered an untyped List or Map. The use of untyped List/Map is "
2221 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2222 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2223 "ERROR: new/p/Data.aidl: Failed to read.\n";
2224 io_delegate_.SetFileContents("old/p/Data.aidl",
2225 "package p;"
2226 "parcelable Data {"
2227 " int foo;"
2228 "}");
2229 io_delegate_.SetFileContents("new/p/Data.aidl",
2230 "package p;"
2231 "parcelable Data {"
2232 " int foo;"
2233 " @nullable List list;"
2234 "}");
2235 CaptureStderr();
2236 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2237 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2238}
2239
Daniel Norman85aed542019-08-21 12:01:14 -07002240TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002241 const string expected_stderr =
2242 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002243 io_delegate_.SetFileContents("old/p/Data.aidl",
2244 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002245 "parcelable Data {"
2246 " int foo;"
2247 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002248 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002249 io_delegate_.SetFileContents("new/p/Data.aidl",
2250 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002251 "parcelable Data {"
2252 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002253 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002254 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002255 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002257}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002258
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002259TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2260 const string expected_stderr =
2261 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2262 "backends. Please either provide a default value for this field or mark the field as "
2263 "@nullable. This value or a null value will be used automatically when an old version of "
2264 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2265 "order to make sure your code continues to be backwards compatible, make sure the default or "
2266 "null value does not cause a semantic change to this parcelable.\n";
2267 io_delegate_.SetFileContents("old/p/Data.aidl",
2268 "package p;"
2269 "parcelable Data {"
2270 " int num;"
2271 "}");
2272 io_delegate_.SetFileContents("new/p/Data.aidl",
2273 "package p;"
2274 "parcelable Data {"
2275 " int num;"
2276 " String str;"
2277 "}");
2278 CaptureStderr();
2279 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2280 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2281}
2282
Jooyung Han636fd2f2020-10-22 11:33:45 +09002283TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2284 const string expected_stderr =
2285 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2286 "Please make sure 'Enum' has '0' as a valid value.\n";
2287 io_delegate_.SetFileContents("old/p/Data.aidl",
2288 "package p;"
2289 "parcelable Data {"
2290 " int num;"
2291 "}");
2292 io_delegate_.SetFileContents("new/p/Data.aidl",
2293 "package p;"
2294 "parcelable Data {"
2295 " int num;"
2296 " p.Enum e;"
2297 "}");
2298 io_delegate_.SetFileContents("new/p/Enum.aidl",
2299 "package p;"
2300 "enum Enum {"
2301 " FOO = 1,"
2302 " BAR = 2,"
2303 "}");
2304 CaptureStderr();
2305 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2306 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2307}
2308
Daniel Norman85aed542019-08-21 12:01:14 -07002309TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 const string expected_stderr =
2311 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002312 io_delegate_.SetFileContents("old/p/Enum.aidl",
2313 "package p;"
2314 "enum Enum {"
2315 " FOO = 1,"
2316 " BAR = 2,"
2317 "}");
2318 io_delegate_.SetFileContents("new/p/Enum.aidl",
2319 "package p;"
2320 "enum Enum {"
2321 " BAR = 2,"
2322 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002323 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002324 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002326}
2327
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002328TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2329 const string expected_stderr =
2330 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2331 io_delegate_.SetFileContents("old/p/Union.aidl",
2332 "package p;"
2333 "union Union {"
2334 " String str;"
2335 " int num;"
2336 "}");
2337 io_delegate_.SetFileContents("new/p/Union.aidl",
2338 "package p;"
2339 "union Union {"
2340 " String str;"
2341 "}");
2342 CaptureStderr();
2343 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2345}
2346
Daniel Norman85aed542019-08-21 12:01:14 -07002347TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002348 const string expected_stderr =
2349 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002350 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2351 "package p;"
2352 "interface IFoo {"
2353 " void foo(in String[] str);"
2354 " void bar(@utf8InCpp String str);"
2355 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002356 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2357 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002358 "interface IFoo {"
2359 " void foo(in String[] str);"
2360 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002361 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002363 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002365}
2366
Daniel Norman85aed542019-08-21 12:01:14 -07002367TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002368 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002369 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2370 "package p;"
2371 "interface IFoo {"
2372 " void foo(in String[] str);"
2373 " void bar(@utf8InCpp String str);"
2374 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002375 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2376 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002377 "interface IFoo2 {"
2378 " void foo(in String[] str);"
2379 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002380 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002382 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002384}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002385
Daniel Norman85aed542019-08-21 12:01:14 -07002386TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 const string expected_stderr =
2388 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002389 io_delegate_.SetFileContents("old/p/Enum.aidl",
2390 "package p;"
2391 "enum Enum {"
2392 " FOO = 1,"
2393 " BAR = 2,"
2394 "}");
2395 io_delegate_.SetFileContents("new/p/Enum.aidl",
2396 "package p;"
2397 "enum Enum {"
2398 " FOO = 3,"
2399 " BAR = 2,"
2400 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002401 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002402 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002403 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002404}
2405
2406TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002407 const string expected_stderr =
2408 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2409 "from 0 to 1.\n"
2410 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2411 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002412 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2413 "package p;"
2414 "interface IFoo {"
2415 " void foo(in String[] str);"
2416 " void bar(@utf8InCpp String str);"
2417 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002418 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2419 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002420 "interface IFoo {"
2421 " void bar(@utf8InCpp String str);"
2422 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002423 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002425 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002427}
2428
2429TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002430 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002431 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2432 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002433 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002434 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002435 "parcelable Data {"
2436 " int foo;"
2437 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002438 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002439 io_delegate_.SetFileContents("new/p/Data.aidl",
2440 "package p;"
2441 "parcelable Data {"
2442 " int bar;"
2443 " int foo;"
2444 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002445 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002446 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002447 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002448}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002449
Daniel Norman85aed542019-08-21 12:01:14 -07002450TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002451 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002452 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002453 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002454 "interface IFoo {"
2455 " void foo(in String[] str);"
2456 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002457 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002458 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2459 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002460 "interface IFoo {"
2461 " void foo(out String[] str);"
2462 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002463 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002464 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002465 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002467}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002468
Daniel Norman85aed542019-08-21 12:01:14 -07002469TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002470 const string expected_stderr =
2471 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002472 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2473 "package p;"
2474 "interface IFoo {"
2475 " void foo(in String[] str);"
2476 " void bar(@utf8InCpp String str);"
2477 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002478 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2479 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002480 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002481 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002482 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002483 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002485 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002486 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002487}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002488
Daniel Norman85aed542019-08-21 12:01:14 -07002489TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002490 const string expected_stderr =
2491 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002492 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2493 "package p;"
2494 "interface IFoo {"
2495 " void foo(in String[] str);"
2496 " void bar(@utf8InCpp String str);"
2497 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002498 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2499 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002500 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002501 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002502 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002503 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002504 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002505 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002507}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002508
Jooyung Han60b2fde2020-10-29 15:12:40 +09002509TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2510 const string expected_stderr =
2511 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2512 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2513 io_delegate_.SetFileContents("old/p/Foo.aidl",
2514 "package p;"
2515 "@Backing(type=\"byte\")"
2516 "enum Foo {"
2517 " FOO, BAR,"
2518 "}");
2519 io_delegate_.SetFileContents("new/p/Foo.aidl",
2520 "package p;"
2521 "@Backing(type=\"long\")"
2522 "enum Foo {"
2523 " FOO, BAR,"
2524 "}");
2525 CaptureStderr();
2526 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2527 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2528}
2529
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002530TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2531 const string expected_stderr =
2532 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2533 "to @JavaPassthrough(annotation=\"Bob\")\n";
2534 io_delegate_.SetFileContents("old/p/Foo.aidl",
2535 "package p;"
2536 "@JavaPassthrough(annotation=\"Alice\")"
2537 "parcelable Foo {}");
2538 io_delegate_.SetFileContents("new/p/Foo.aidl",
2539 "package p;"
2540 "@JavaPassthrough(annotation=\"Bob\")"
2541 "parcelable Foo {}");
2542
2543 CaptureStderr();
2544 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2546}
2547
Devin Mooredb7ac512020-08-07 11:17:36 -07002548TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2549 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002550 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002551 io_delegate_.SetFileContents("old/p/Foo.aidl",
2552 "package p;"
2553 "parcelable Foo {"
2554 " int A;"
2555 "}");
2556 io_delegate_.SetFileContents("new/p/Foo.aidl",
2557 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002558 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002559 " int A;"
2560 "}");
2561 CaptureStderr();
2562 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2563 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2564}
2565
2566TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2567 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002568 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002569 io_delegate_.SetFileContents("old/p/Foo.aidl",
2570 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002571 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002572 " int A;"
2573 "}");
2574 io_delegate_.SetFileContents("new/p/Foo.aidl",
2575 "package p;"
2576 "parcelable Foo {"
2577 " int A;"
2578 "}");
2579 CaptureStderr();
2580 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2582}
2583
Daniel Norman85aed542019-08-21 12:01:14 -07002584TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002585 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002586 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2587 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002588 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002589 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002590 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002591 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002592}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002593
Daniel Norman85aed542019-08-21 12:01:14 -07002594TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002595 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002596 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2597 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002598 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002599 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002600 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002601}
Jiyong Parka428d212018-08-29 22:26:30 +09002602
Daniel Norman85aed542019-08-21 12:01:14 -07002603TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002604 const string expected_stderr =
2605 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002606 io_delegate_.SetFileContents("old/p/I.aidl",
2607 "package p; interface I {"
2608 "const int A = 1; const int B = 2;}");
2609 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002610 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002611 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002612 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002613}
Jiyong Parka428d212018-08-29 22:26:30 +09002614
Daniel Norman85aed542019-08-21 12:01:14 -07002615TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002616 const string expected_stderr =
2617 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002618 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2619 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002620 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002621 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002623}
2624
Devin Moorec7e47a32020-08-07 10:55:25 -07002625TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2626 const string expected_stderr =
2627 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2628 "This is an incompatible change for FixedSize types.\n";
2629 io_delegate_.SetFileContents("old/p/Foo.aidl",
2630 "package p; @FixedSize parcelable Foo { int A = 1; }");
2631 io_delegate_.SetFileContents("new/p/Foo.aidl",
2632 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2633 CaptureStderr();
2634 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2635 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2636}
2637
2638TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2639 const string expected_stderr =
2640 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2641 io_delegate_.SetFileContents("old/p/Foo.aidl",
2642 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2643 io_delegate_.SetFileContents("new/p/Foo.aidl",
2644 "package p; @FixedSize parcelable Foo { int A = 1; }");
2645 CaptureStderr();
2646 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2647 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2648}
2649
2650TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2651 const string expected_stderr =
2652 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2653 "a.\n"
2654 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2655 "b.\n"
2656 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2657 "c.\n"
2658 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2659 "d.\n"
2660 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2661 "e.\n"
2662 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2663 "f.\n";
2664
2665 io_delegate_.SetFileContents("Foo.aidl",
2666 "@FixedSize parcelable Foo { "
2667 " int[] a;"
2668 " Bar b;"
2669 " String c;"
2670 " ParcelFileDescriptor d;"
2671 " IBinder e;"
2672 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002673 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002674 "}");
2675 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002676 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002677
2678 CaptureStderr();
2679 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2680 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2681}
2682
2683TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2684 const string expected_stderr = "";
2685
2686 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2687 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2688 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002689 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002690
2691 CaptureStderr();
2692 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2693 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2694}
2695
Jiyong Park8c380532018-08-30 14:55:26 +09002696TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002697 const string expected_stderr =
2698 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2699 "dir1/q/IBar.aidl\n"
2700 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002701 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002702 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2703 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2704 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2705 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2706
Devin Moore097a3ab2020-03-11 16:08:44 -07002707 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002708 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002710}
2711
Jiyong Parked65bf42018-08-28 15:43:27 +09002712TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002713 const string expected_stderr =
2714 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2715 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002716 Options options = Options::From("aidl --checkapi old new");
2717 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2718 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002719
2720 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2721
Jiyong Parke59c3682018-09-11 23:10:25 +09002722 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002723 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002724 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002725 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002726}
2727
Jiyong Parke05195e2018-10-08 18:24:23 +09002728TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2729 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2730 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002731 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002732
2733 // use without import
2734 io_delegate_.SetFileContents("p/IFoo.aidl",
2735 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2736 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2737 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002738 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002739
Devin Moore7b8d5c92020-03-17 14:14:08 -07002740 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002741 io_delegate_.SetFileContents(
2742 "p/IFoo.aidl",
2743 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2744 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2745 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002746 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002747
2748 // use with import (as before)
2749 io_delegate_.SetFileContents("p/IFoo.aidl",
2750 "package p;"
2751 "import android.os.ParcelFileDescriptor;"
2752 "interface IFoo{"
2753 " void foo(in ParcelFileDescriptor fd);"
2754 "}");
2755 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2756 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002757 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002758}
Jiyong Parked65bf42018-08-28 15:43:27 +09002759
Jiyong Park3633b722019-04-11 15:38:26 +09002760TEST_F(AidlTest, ManualIds) {
2761 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2762 io_delegate_.SetFileContents("IFoo.aidl",
2763 "interface IFoo {\n"
2764 " void foo() = 0;\n"
2765 " void bar() = 1;\n"
2766 "}");
2767 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2768}
2769
2770TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2771 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2772 io_delegate_.SetFileContents("IFoo.aidl",
2773 "interface IFoo {\n"
2774 " void foo() = 0;\n"
2775 " void bar() = 1;\n"
2776 "}");
2777 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2778}
2779
2780TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002781 const string expected_stderr =
2782 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002783 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2784 io_delegate_.SetFileContents("IFoo.aidl",
2785 "interface IFoo {\n"
2786 " void foo() = 3;\n"
2787 " void bar() = 3;\n"
2788 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002789 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002790 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002791 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002792}
2793
2794TEST_F(AidlTest, FailOnOutOfRangeIds) {
2795 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002796 const string expected_stderr =
2797 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2798 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002799 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2800 io_delegate_.SetFileContents("IFoo.aidl",
2801 "interface IFoo {\n"
2802 " void foo() = 3;\n"
2803 " void bar() = 16777115;\n"
2804 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002805 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002806 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002807 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002808}
2809
2810TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002811 const string expected_stderr =
2812 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002813 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2814 io_delegate_.SetFileContents("IFoo.aidl",
2815 "interface IFoo {\n"
2816 " void foo() = 3;\n"
2817 " void bar();\n"
2818 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002819 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002820 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002821 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002822}
2823
Jiyong Parkc6816252019-07-08 08:12:28 +09002824TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2825 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2826 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2827 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2828 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2829}
2830
2831TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002832 const string expected_stderr =
2833 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2834 "dir/IBar.aidl\n"
2835 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002836 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002837
Jiyong Parkc6816252019-07-08 08:12:28 +09002838 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2839 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2840 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2841 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002842 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002843 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002844 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002845}
2846
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002847TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2848 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2849 "package a.b;\n"
2850 "import a.b.IBar;\n"
2851 "import a.b.IQux;\n"
2852 "interface IFoo { IQux foo(); }\n");
2853 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2854 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2855
2856 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2857 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2858
2859 string output;
2860 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2861 // IBar was imported but wasn't used. include is not expected.
2862 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2863 // IBar was imported and used. include is expected.
2864 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2865}
2866
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002867TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002868 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002869 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002870 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2871 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002872 interface IFoo {
2873 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002874 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002875 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002876 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002877 // JavaPassthrough should work with other types as well (e.g. enum)
2878 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2879 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2880 @JavaPassthrough(annotation="@com.android.AliceTwo")
2881 @Backing(type="byte")
2882 enum MyEnum {
2883 a, b, c
2884 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002885
Jooyung Han4cde01d2020-10-13 11:10:47 +09002886 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002887 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2888
2889 string java_out;
2890 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002891 // type-decl-level annotations with newline at the end
2892 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2893 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2894 // member-decl-level annotations with newline at the end
2895 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2896 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2897 // inline annotations with space at the end
2898 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002899
Jooyung Han4cde01d2020-10-13 11:10:47 +09002900 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2901 // type-decl-level annotations with newline at the end
2902 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2903 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2904
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002905 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002906 Options cpp_options =
2907 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002908 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2909
Jooyung Han4cde01d2020-10-13 11:10:47 +09002910 Options ndk_options =
2911 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002912 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002913
Jooyung Han4cde01d2020-10-13 11:10:47 +09002914 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002915 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002916}
2917
Andrei Homescue61feb52020-08-18 15:44:24 -07002918TEST_F(AidlTest, ParseRustDerive) {
2919 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2920 @RustDerive(Clone=true, Copy=false)
2921 parcelable Foo {
2922 int a;
2923 })");
2924
2925 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2926 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2927
2928 string rust_out;
2929 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2930 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2931
2932 // Other backends shouldn't be bothered
2933 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2934 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2935
2936 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2937 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2938
2939 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2940 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2941}
2942
Jiyong Park56f73d72019-06-11 12:20:28 +09002943class AidlOutputPathTest : public AidlTest {
2944 protected:
2945 void SetUp() override {
2946 AidlTest::SetUp();
2947 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2948 }
2949
2950 void Test(const Options& options, const std::string expected_output_path) {
2951 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2952 // check the existence
2953 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2954 }
2955};
2956
2957TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2958 // <out_dir> / <package_name> / <type_name>.java
2959 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2960}
2961
2962TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2963 // when output file is explicitly set, it is always respected. -o option is
2964 // ignored.
2965 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2966}
2967
2968TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2969 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2970}
2971
2972TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2973 // output is the same as the input file except for the suffix
2974 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2975}
2976
Devin Moore7b8d5c92020-03-17 14:14:08 -07002977TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002978 AidlError error;
2979 const string expected_stderr =
2980 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2981 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002982 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2983 R"(package p;
2984 interface IFoo {
2985 const int int32_max_oob = 2147483650;
2986 }
2987 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002988 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2990 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002991}
2992
Devin Moore7b8d5c92020-03-17 14:14:08 -07002993TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002994 AidlError error;
2995 const string expected_stderr =
2996 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2997 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002998 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2999 R"(package p;
3000 interface IFoo {
3001 const int int32_min_oob = -2147483650;
3002 }
3003 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003004 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003005 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3006 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003007}
3008
Devin Moore7b8d5c92020-03-17 14:14:08 -07003009TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003010 AidlError error;
3011 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003012 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003013 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003014 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3015 R"(package p;
3016 interface IFoo {
3017 const long int64_max_oob = 21474836509999999999999999;
3018 }
3019 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003020 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3022 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003023}
3024
Devin Moore7b8d5c92020-03-17 14:14:08 -07003025TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003026 AidlError error;
3027 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003028 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003029 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003030 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3031 R"(package p;
3032 interface IFoo {
3033 const long int64_min_oob = -21474836509999999999999999;
3034 }
3035 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003036 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3038 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003039}
3040
Devin Moore7b8d5c92020-03-17 14:14:08 -07003041TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003042 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003043 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003044 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003045 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3046 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003047 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3048 R"(package p;
3049 @Backing(type="byte")
3050 enum TestEnum {
3051 FOO = 127,
3052 BAR,
3053 }
3054 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003055 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003057 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003058}
3059
Devin Mooredecaf292020-04-30 09:16:40 -07003060TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3061 AidlError error;
3062 const string expected_stderr =
3063 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003064 "be one of: type\n";
3065 CaptureStderr();
3066 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3067 R"(package p;
3068 @Backing(foo="byte")
3069 enum TestEnum {
3070 FOO = 1,
3071 BAR,
3072 }
3073 )",
3074 typenames_, GetLanguage(), &error));
3075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3076 EXPECT_EQ(AidlError::BAD_TYPE, error);
3077}
3078
Jooyung Han5721a232020-12-24 04:34:55 +09003079TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3080 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3081 CaptureStderr();
3082 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3083 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3084}
3085
Jooyung Han66813932020-10-23 13:24:44 +09003086TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003087 io_delegate_.SetFileContents("Foo.aidl",
3088 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3089 "Map<String, Baz> d; Bar[] e; }");
3090 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3091 io_delegate_.SetFileContents("Baz.aidl",
3092 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003093 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3094 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3095}
3096
Jooyung Han66813932020-10-23 13:24:44 +09003097TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003098 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003099 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003100 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003101 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3102 "named 'bar'.\n";
3103 CaptureStderr();
3104 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3105 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3106 EXPECT_EQ(expected_error, GetCapturedStderr());
3107}
3108
3109TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3110 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3111 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3112 string expected_error =
3113 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003114 "named 'bar'.\n";
3115 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003116 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3117 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003118 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003119}
3120
Jooyung Han66813932020-10-23 13:24:44 +09003121TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003122 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003123 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3124 string expected_error =
3125 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3126 "only be an in parameter.\n";
3127 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003128 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3129 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003130 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003131}
3132
Jooyung Han66813932020-10-23 13:24:44 +09003133TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003134 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003135 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3136 string expected_error =
3137 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3138 "only be an in parameter.\n";
3139 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003140 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3141 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003142 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003143}
3144
Jooyung Han66813932020-10-23 13:24:44 +09003145TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003146 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003147 Options options = Options::From("aidl --lang=java Foo.aidl");
3148 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003149 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3150 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003151 CaptureStderr();
3152 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3153 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3154}
Devin Moore53fc99c2020-08-12 08:07:52 -07003155
Jooyung Hanfe086af2021-01-16 03:44:47 +09003156TEST_P(AidlTest, UnionInUnion) {
3157 import_paths_.insert(".");
3158 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3159 CaptureStderr();
3160 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3161 EXPECT_THAT("", GetCapturedStderr());
3162}
3163
Jooyung Hanfe89f122020-10-14 03:49:18 +09003164TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3165 const string method = "package a; union Foo {}";
3166 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3167 CaptureStderr();
3168 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3169 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3170}
3171
3172TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3173 const string method = "package a; union Foo { ParcelableHolder x; }";
3174 const string expected_stderr =
3175 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3176 CaptureStderr();
3177 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3178 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3179}
3180
Jooyung Han53fb4242020-12-17 16:03:49 +09003181TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3182 import_paths_.insert(".");
3183 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3184 const string expected_err = "The union's first member should have a useful default value.";
3185 CaptureStderr();
3186 EXPECT_EQ(nullptr,
3187 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3188 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3189}
3190
Devin Moore53fc99c2020-08-12 08:07:52 -07003191TEST_P(AidlTest, GenericStructuredParcelable) {
3192 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003193 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003194 const string expected_stderr = "";
3195 CaptureStderr();
3196 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3198}
3199
Jooyung Han3f347ca2020-12-01 12:41:50 +09003200TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3201 io_delegate_.SetFileContents("Foo.aidl",
3202 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3203 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003204 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003205 const string expected_stderr = "";
3206 CaptureStderr();
3207 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3208 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3209
3210 string code;
3211 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3212 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3213const ::android::String16& Foo<T,U>::s() {
3214 static const ::android::String16 value(::android::String16(""));
3215 return value;
3216})--"));
3217}
3218
3219TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3220 io_delegate_.SetFileContents("Foo.aidl",
3221 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3222 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003223 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003224 const string expected_stderr = "";
3225 CaptureStderr();
3226 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3227 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3228
3229 string code;
3230 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3231 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3232const char* Foo<T, U>::s = "";
3233)--"));
3234}
3235
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003236TEST_F(AidlTest, NestedTypeArgs) {
3237 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003238 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3239
3240 io_delegate_.SetFileContents("a/Foo.aidl",
3241 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3242 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003243 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3244 const string expected_stderr = "";
3245 CaptureStderr();
3246 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3248
3249 string code;
3250 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003251 EXPECT_THAT(code,
3252 testing::HasSubstr(
3253 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3254}
3255
3256TEST_F(AidlTest, DoubleArrayError) {
3257 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3258
3259 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3260 const string expected_stderr =
3261 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3262 CaptureStderr();
3263 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3264 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3265}
3266
3267TEST_F(AidlTest, DoubleGenericError) {
3268 io_delegate_.SetFileContents("a/Bar.aidl",
3269 "package a; parcelable Bar { List<String><String> a; }");
3270
3271 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3272 const string expected_stderr =
3273 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3274 CaptureStderr();
3275 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3276 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3277}
3278
3279TEST_F(AidlTest, ArrayBeforeGenericError) {
3280 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3281
3282 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3283 const string expected_stderr =
3284 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3285 CaptureStderr();
3286 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3287 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003288}
3289
Jooyung Han14004ed2020-10-16 03:49:57 +09003290struct GenericAidlTest : ::testing::Test {
3291 FakeIoDelegate io_delegate_;
3292 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003293 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003294 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3295 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3296 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3297
3298 Options options = Options::From(cmd);
3299 CaptureStderr();
3300 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3301 EXPECT_EQ("", GetCapturedStderr());
3302 }
3303};
3304
3305TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3306 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3307 string code;
3308 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3309 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3310 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3311 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3312}
3313
3314TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3315 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3316 string code;
3317 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3318 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3319 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3320 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3321}
3322
Devin Moore53fc99c2020-08-12 08:07:52 -07003323TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3324 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003325 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003326 const string expected_stderr =
3327 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3328 CaptureStderr();
3329 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3330 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3331}
3332
3333TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3334 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003335 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003336 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3337 CaptureStderr();
3338 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3339 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3340}
3341
Jooyung Han7a308842020-10-27 19:06:49 +09003342TEST_P(AidlTest, LongCommentWithinConstExpression) {
3343 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003344 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003345 CaptureStderr();
3346 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3347 EXPECT_EQ("", GetCapturedStderr());
3348}
3349
Jeongik Chaef44e622020-10-23 16:00:52 +09003350TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3351 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3352 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3353 std::string expectedErr =
3354 "ERROR: a/Foo.aidl:1.28-30: "
3355 "Encountered an untyped List or Map. The use of untyped List/Map is "
3356 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3357 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3358 "ERROR: a/Foo.aidl:1.35-37: "
3359 "Encountered an untyped List or Map. The use of untyped List/Map is "
3360 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3361 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3362 CaptureStderr();
3363 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3364 EXPECT_EQ(expectedErr, GetCapturedStderr());
3365}
3366
3367TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003368 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3369 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003370 std::string expectedErr =
3371 "ERROR: a/Foo.aidl:1.33-35: "
3372 "Encountered an untyped List or Map. The use of untyped List/Map is "
3373 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3374 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3375 "ERROR: a/Foo.aidl:1.40-42: "
3376 "Encountered an untyped List or Map. The use of untyped List/Map is "
3377 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3378 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003379 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003380 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3381 EXPECT_EQ(expectedErr, GetCapturedStderr());
3382}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003383
Jeongik Chaef44e622020-10-23 16:00:52 +09003384TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3385 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3386 io_delegate_.SetFileContents(
3387 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3388 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3389 std::string expectedErr =
3390 "ERROR: a/Foo.aidl:1.52-54: "
3391 "Encountered an untyped List or Map. The use of untyped List/Map is "
3392 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3393 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3394 "ERROR: a/Foo.aidl:1.64-66: "
3395 "Encountered an untyped List or Map. The use of untyped List/Map is "
3396 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3397 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3398 CaptureStderr();
3399 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3400 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003401}
3402
Jooyung Han690f5842020-12-04 13:02:04 +09003403TEST_F(AidlTest, EnumWithDefaults_Java) {
3404 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3405 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3406package p;
3407import p.Enum;
3408parcelable Foo {
3409 Enum e = Enum.BAR;
3410})");
3411 CaptureStderr();
3412 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3413 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3414 auto err = GetCapturedStderr();
3415 EXPECT_EQ("", err);
3416
3417 string code;
3418 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003419 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003420}
3421
3422TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3423 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3424 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3425package p;
3426import p.Enum;
3427parcelable Foo {
3428 Enum e = Enum.BAR;
3429})");
3430 CaptureStderr();
3431 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3432 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3433 auto err = GetCapturedStderr();
3434 EXPECT_EQ("", err);
3435
3436 string code;
3437 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3438 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3439}
3440
3441TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3442 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3443 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3444package p;
3445import p.Enum;
3446parcelable Foo {
3447 Enum e = Enum.BAR;
3448})");
3449 CaptureStderr();
3450 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3451 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3452 auto err = GetCapturedStderr();
3453 EXPECT_EQ("", err);
3454
3455 string code;
3456 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3457 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3458}
3459
3460TEST_F(AidlTest, EnumWithDefaults_Rust) {
3461 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3462 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3463package p;
3464import p.Enum;
3465parcelable Foo {
3466 int n = 42;
3467 Enum e = Enum.BAR;
3468})");
3469 CaptureStderr();
3470 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3471 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3472 auto err = GetCapturedStderr();
3473 EXPECT_EQ("", err);
3474
3475 string code;
3476 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3477 EXPECT_THAT(code, testing::HasSubstr(R"(
3478 fn default() -> Self {
3479 Self {
3480 n: 42,
3481 e: crate::mangled::_1_p_4_Enum::BAR,
3482 }
3483 })"));
3484}
3485
3486TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3487 import_paths_.insert("a");
3488 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3489 CaptureStderr();
3490 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3491package p;
3492import p.Enum;
3493parcelable Foo {
3494 int e = Enum.FOO | Enum.BAR;
3495})",
3496 typenames_, GetLanguage());
3497 auto err = GetCapturedStderr();
3498 EXPECT_EQ("", err);
3499 EXPECT_TRUE(type);
3500 const auto& fields = type->AsStructuredParcelable()->GetFields();
3501 EXPECT_EQ("int e = 3", fields[0]->ToString());
3502}
3503
3504TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3505 CaptureStderr();
3506 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3507@Backing(type="int")
3508enum Foo {
3509 STANDARD_SHIFT = 16,
3510 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3511 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3512}
3513)",
3514 typenames_, GetLanguage());
3515 auto err = GetCapturedStderr();
3516 EXPECT_EQ("", err);
3517 EXPECT_TRUE(type);
3518 const auto& enum_type = type->AsEnumDeclaration();
3519 string code;
3520 enum_type->Dump(CodeWriter::ForString(&code).get());
3521 EXPECT_EQ(R"--(@Backing(type="int")
3522enum Foo {
3523 STANDARD_SHIFT = 16,
3524 STANDARD_BT709 = 65536,
3525 STANDARD_BT601_625 = 131072,
3526}
3527)--",
3528 code);
3529}
3530
3531TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3532 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3533 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3534package p;
3535import p.Enum;
3536parcelable Foo {
3537 Enum e = Enum.FOO | Enum.BAR;
3538})");
3539 CaptureStderr();
3540 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3541 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3542 auto err = GetCapturedStderr();
3543 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3544 err);
3545}
3546
3547TEST_P(AidlTest, DefaultWithEmptyArray) {
3548 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3549 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3550 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003551 auto options =
3552 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003553 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3554 auto err = GetCapturedStderr();
3555 EXPECT_EQ("", err);
3556}
3557
3558TEST_P(AidlTest, RejectRefsInAnnotation) {
3559 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3560 "package p; interface IFoo {\n"
3561 " const String ANNOTATION = \"@Annotation\";\n"
3562 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3563 "}");
3564 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003565 auto options =
3566 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003567 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3568 auto err = GetCapturedStderr();
3569 EXPECT_EQ(
3570 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3571 "ANNOTATION.\n",
3572 err);
3573}
3574
3575TEST_F(AidlTest, DefaultWithEnumValues) {
3576 io_delegate_.SetFileContents(
3577 "a/p/Foo.aidl",
3578 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3579 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3580 CaptureStderr();
3581 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3582 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3583 auto err = GetCapturedStderr();
3584 EXPECT_EQ("", err);
3585 string code;
3586 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3587 EXPECT_THAT(
3588 code, testing::HasSubstr(
3589 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3590}
3591
Jooyung Han14259392020-12-07 10:00:08 +09003592TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3593 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3594 CaptureStderr();
3595 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3596 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3597 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003598 EXPECT_EQ(
3599 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3600 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3601 err);
Jooyung Han14259392020-12-07 10:00:08 +09003602}
3603
3604TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3605 io_delegate_.SetFileContents("a/p/Foo.aidl",
3606 "package p; parcelable Foo { const int A = A + 1; }");
3607 CaptureStderr();
3608 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3609 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3610 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003611 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3612}
3613
3614TEST_F(AidlTest, RecursiveReferences) {
3615 io_delegate_.SetFileContents("a/p/Foo.aidl",
3616 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3617 io_delegate_.SetFileContents("a/p/Bar.aidl",
3618 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3619 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3620 CaptureStderr();
3621 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3622 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3623 EXPECT_EQ("", GetCapturedStderr());
3624}
3625
Jooyung Hane9f5b272021-01-07 00:18:11 +09003626TEST_P(AidlTest, UnknownConstReference) {
3627 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3628 auto options =
3629 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3630 const string err =
3631 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3632 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3633 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3634 CaptureStderr();
3635 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3636 EXPECT_EQ(err, GetCapturedStderr());
3637}
3638
Jooyung Han29813842020-12-08 01:28:03 +09003639TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3640 string contents = R"(
3641import android.os.IBinder;
3642import android.os.IInterface;
3643interface IFoo {}
3644 )";
3645 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003646}
3647
Jooyung Han888c5bc2020-12-22 17:28:47 +09003648TEST_P(AidlTest, WarningInterfaceName) {
3649 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003650 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003651 " -Weverything -o out -h out p/Foo.aidl");
3652 CaptureStderr();
3653 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003654 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003655 GetCapturedStderr());
3656}
3657
3658TEST_P(AidlTest, ErrorInterfaceName) {
3659 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003660 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003661 " -Weverything -Werror -o out -h out p/Foo.aidl");
3662 CaptureStderr();
3663 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003664 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003665 GetCapturedStderr());
3666}
3667
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09003668TEST_F(AidlTest, FormatCommentsForJava) {
3669 using android::aidl::FormatCommentsForJava;
3670
3671 struct TestCase {
3672 vector<Comment> comments;
3673 string formatted;
3674 };
3675 vector<TestCase> testcases = {
3676 {{}, ""},
3677 {{{"// line comments\n"}}, "// line comments\n"},
3678 {{{"// @hide \n"}}, "// @hide \n"},
3679 // Transform the last block comment as Javadoc.
3680 {{{"/*\n"
3681 " * Hello, world!\n"
3682 " */"}},
3683 "/**\n"
3684 " * Hello, world!\n"
3685 " */"},
3686 {{{"/* @hide */"}}, "/** @hide */"},
3687 {{{"/**\n"
3688 " @param foo ...\n"
3689 "*/"}},
3690 "/**\n"
3691 " @param foo ...\n"
3692 "*/"},
3693 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
3694 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
3695 "/* @deprecated first *//** @deprecated second */"},
3696 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
3697 // Line comments are printed as they are
3698 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
3699 };
3700 for (const auto& [input, formatted] : testcases) {
3701 EXPECT_EQ(formatted, FormatCommentsForJava(input));
3702 }
3703}
3704
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003705TEST_F(AidlTest, HideIsNotForArgs) {
3706 io_delegate_.SetFileContents("IFoo.aidl",
3707 "interface IFoo {\n"
3708 " void foo(in @Hide int x);\n"
3709 "}");
3710 auto options = Options::From("aidl --lang=java IFoo.aidl");
3711 CaptureStderr();
3712 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3713 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3714}
3715
3716TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3717 io_delegate_.SetFileContents(
3718 "IFoo.aidl",
3719 "interface IFoo {\n"
3720 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3721 "}");
3722 auto options = Options::From("aidl --lang=java IFoo.aidl");
3723 CaptureStderr();
3724 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3725 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3726}
3727
Jooyung Hanfd3be322020-12-13 09:11:06 +09003728struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003729 string kind;
3730 string literal;
3731};
3732
Jooyung Hanfd3be322020-12-13 09:11:06 +09003733const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003734 {"primitive", "int"}, {"String", "String"},
3735 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3736 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3737 {"union", "a.Union"}, {"interface", "a.IBar"},
3738};
3739
3740const std::map<std::string, std::string> kListSupportExpectations = {
3741 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3742 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3743 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3744 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
3745 {"cpp_String", ""},
3746 {"java_String", ""},
3747 {"ndk_String", ""},
3748 {"rust_String", ""},
3749 {"cpp_IBinder", ""},
3750 {"java_IBinder", ""},
3751 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3752 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003753 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003754 {"java_ParcelFileDescriptor", ""},
3755 {"ndk_ParcelFileDescriptor", ""},
3756 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003757 {"cpp_interface", "List<a.IBar> is not supported."},
3758 {"java_interface", "List<a.IBar> is not supported."},
3759 {"ndk_interface", "List<a.IBar> is not supported."},
3760 {"rust_interface", "List<a.IBar> is not supported."},
3761 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003762 {"java_parcelable", ""},
3763 {"ndk_parcelable", ""},
3764 {"rust_parcelable", ""},
3765 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3766 {"java_enum", "A generic type cannot have any primitive type parameters."},
3767 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3768 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003769 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003770 {"java_union", ""},
3771 {"ndk_union", ""},
3772 {"rust_union", ""},
3773};
3774
Jooyung Hand236e552020-12-13 09:21:27 +09003775const std::map<std::string, std::string> kArraySupportExpectations = {
3776 {"cpp_primitive", ""},
3777 {"java_primitive", ""},
3778 {"ndk_primitive", ""},
3779 {"rust_primitive", ""},
3780 {"cpp_String", ""},
3781 {"java_String", ""},
3782 {"ndk_String", ""},
3783 {"rust_String", ""},
3784 {"cpp_IBinder", ""},
3785 {"java_IBinder", ""},
3786 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3787 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3788 {"cpp_ParcelFileDescriptor", ""},
3789 {"java_ParcelFileDescriptor", ""},
3790 {"ndk_ParcelFileDescriptor", ""},
3791 {"rust_ParcelFileDescriptor", ""},
3792 {"cpp_interface", "Binder type cannot be an array"},
3793 {"java_interface", "Binder type cannot be an array"},
3794 {"ndk_interface", "Binder type cannot be an array"},
3795 {"rust_interface", "Binder type cannot be an array"},
3796 {"cpp_parcelable", ""},
3797 {"java_parcelable", ""},
3798 {"ndk_parcelable", ""},
3799 {"rust_parcelable", ""},
3800 {"cpp_enum", ""},
3801 {"java_enum", ""},
3802 {"ndk_enum", ""},
3803 {"rust_enum", ""},
3804 {"cpp_union", ""},
3805 {"java_union", ""},
3806 {"ndk_union", ""},
3807 {"rust_union", ""},
3808};
3809
Jooyung Hanfd3be322020-12-13 09:11:06 +09003810class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003811 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003812 void Run(const std::string& generic_type_decl,
3813 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003814 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003815 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003816 const auto& kind = std::get<1>(param).kind;
3817
3818 FakeIoDelegate io;
3819 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3820 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3821 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003822 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3823 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003824
3825 const auto options =
3826 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3827 CaptureStderr();
3828 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003829 auto it = expectations.find(lang + "_" + kind);
3830 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003831 const string err = GetCapturedStderr();
3832 if (it->second.empty()) {
3833 EXPECT_EQ("", err);
3834 } else {
3835 EXPECT_THAT(err, testing::HasSubstr(it->second));
3836 }
3837 }
3838};
3839
3840INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003841 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003842 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3843 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003844 testing::ValuesIn(kTypeParams)),
3845 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003846 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003847 });
3848
Jooyung Hanfd3be322020-12-13 09:11:06 +09003849TEST_P(AidlTypeParamTest, ListSupportedTypes) {
3850 Run("List<{}>", kListSupportExpectations);
3851}
Jooyung Hane87cdd02020-12-11 16:47:35 +09003852
Jooyung Hand236e552020-12-13 09:21:27 +09003853TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
3854 Run("{}[]", kArraySupportExpectations);
3855}
3856
Christopher Wiley90be4e32015-10-20 14:55:25 -07003857} // namespace aidl
3858} // namespace android