blob: 1e81de74ae2625d2aac9f6f0013c140dba8859e2 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070038#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070039
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090040using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070041using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080042using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090043using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045using std::string;
46using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080047using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090048using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070049using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090050using testing::internal::CaptureStderr;
51using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070052
53namespace android {
54namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070055namespace {
56
57const char kExpectedDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60
61p/IFoo.aidl :
62)";
63
Dan Willemsen93298ee2016-11-10 23:55:55 -080064const char kExpectedNinjaDepFileContents[] =
65R"(place/for/output/p/IFoo.java : \
66 p/IFoo.aidl
67)";
68
Jiyong Parkdf202122019-09-30 20:48:35 +090069const char kExpectedParcelableDeclarationDepFileContents[] =
70 R"( : \
71 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
76const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080077 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070078 p/Foo.aidl
79
80p/Foo.aidl :
81)";
82
Christopher Wileyf8136192016-04-12 14:19:35 -070083} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070084
Devin Moore7b8d5c92020-03-17 14:14:08 -070085class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070086 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090087 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
88 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070089 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070090 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090091 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070092 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090093 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070094 for (const string& s : additional_arguments) {
95 args.emplace_back(s);
96 }
97 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090098 args.emplace_back("--preprocessed=" + f);
99 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700100 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--include=" + i);
102 }
103 args.emplace_back(path);
104 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900105 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900106 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700107 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900108 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900109
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 if (error != nullptr) {
111 *error = actual_error;
112 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900113
114 if (actual_error != AidlError::OK) {
115 return nullptr;
116 }
117
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900118 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900119 EXPECT_EQ(1ul, defined_types.size());
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700122 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700123
Devin Moore7b8d5c92020-03-17 14:14:08 -0700124 Options::Language GetLanguage() { return GetParam(); }
125
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800127 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900128 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900129 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700130};
131
Devin Moore7b8d5c92020-03-17 14:14:08 -0700132// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
133// tests with each of the supported languages as a parameter.
134INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
135 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700136 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900138 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700139 });
140
141TEST_P(AidlTest, AcceptMissingPackage) {
142 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700143}
144
Devin Moore7b8d5c92020-03-17 14:14:08 -0700145TEST_P(AidlTest, EndsInSingleLineComment) {
146 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700147}
148
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000149TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
150 const string expected_stderr =
151 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
152 const std::string file_contents = "package a; interface IBar {}";
153 CaptureStderr();
154 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
155 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
156}
157
158TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
159 const string expected_stderr =
160 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
161 const std::string file_contents = "package a; interface Bar {}";
162 CaptureStderr();
163 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
164 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
165}
166
167TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
168 const string expected_stderr =
169 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
170 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
171 CaptureStderr();
172 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
173 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
174}
175
176TEST_P(AidlTest, EnumRequiresCorrectPath) {
177 const string expected_stderr =
178 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
179 const std::string file_contents = "package a; enum Bar { A, }";
180 CaptureStderr();
181 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
182 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
183}
184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900186 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700187 io_delegate_.SetFileContents("bar/IBar.aidl",
188 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700189 const string path = "foo/IFoo.aidl";
190 const string contents =
191 "package foo;\n"
192 "import bar.IBar;\n"
193 "interface IFoo { void f(in IBar[] input); }";
194 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
195 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700196 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700198}
199
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700201 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700202 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900203}
Devin Moore097a3ab2020-03-11 16:08:44 -0700204
Jiyong Park40782d02020-07-24 19:17:43 +0900205TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700206 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
207 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900208 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
209 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700212 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900213}
214
Jiyong Park40782d02020-07-24 19:17:43 +0900215TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900216 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700217 const string expected_stderr =
218 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 CaptureStderr();
220 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900222}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700223
Jiyong Park40782d02020-07-24 19:17:43 +0900224TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900225 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900226 const string expected_stderr =
227 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700229 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700231}
232
Devin Moore7b8d5c92020-03-17 14:14:08 -0700233TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700234 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
235 const string expected_stderr =
236 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
237 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700238 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700240}
241
Devin Moore7b8d5c92020-03-17 14:14:08 -0700242TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700243 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
244 const string expected_stderr =
245 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
246 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700247 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800249}
250
Devin Moore2f2077a2020-08-28 11:27:53 -0700251TEST_P(AidlTest, AcceptNullableList) {
252 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
253 const string expected_stderr = "";
254 CaptureStderr();
255 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
257}
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700260 const string method = "package a; interface IFoo { void f(int a, int a); }";
261 const string expected_stderr =
262 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
263 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700266}
267
Jeongik Cha13066da2020-08-06 15:43:19 +0900268TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
269 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900270 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
274}
275
Jooyung Hand902a972020-10-23 17:32:44 +0900276TEST_P(AidlTest, RejectsRepeatedAnnotations) {
277 const string method = R"(@Hide @Hide parcelable Foo {})";
278 const string expected_stderr =
279 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
280 "Foo.aidl:1.1-6\n";
281 CaptureStderr();
282 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
284}
285
Jooyung Han05bd8a82021-04-28 23:56:38 +0900286TEST_P(AidlTest, AcceptsEmptyParcelable) {
287 CaptureStderr();
288 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
289 EXPECT_EQ("", GetCapturedStderr());
290}
291
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
294 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700297 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100298}
299
Devin Moore7b8d5c92020-03-17 14:14:08 -0700300TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700301 AidlError error;
302 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700303 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700304 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900305 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700306 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800307}
308
Devin Moore7b8d5c92020-03-17 14:14:08 -0700309TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700310 AidlError error;
311 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700312 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700313 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700315 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800316}
317
Devin Moore7b8d5c92020-03-17 14:14:08 -0700318TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700319 AidlError error;
320 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700321 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000322 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900323 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700324 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800325}
326
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700328 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000329 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700330 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000331 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900332 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700333 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800334}
335
Jiyong Park40782d02020-07-24 19:17:43 +0900336TEST_P(AidlTest, ParsesNonNullableAnnotation) {
337 auto parse_result =
338 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
339 ASSERT_NE(nullptr, parse_result);
340 const AidlInterface* interface = parse_result->AsInterface();
341 ASSERT_NE(nullptr, interface);
342 ASSERT_FALSE(interface->GetMethods().empty());
343 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
344}
345
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900347 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
348 typenames_, GetLanguage());
349 ASSERT_NE(nullptr, parse_result);
350 const AidlInterface* interface = parse_result->AsInterface();
351 ASSERT_NE(nullptr, interface);
352 ASSERT_FALSE(interface->GetMethods().empty());
353 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
354}
355
356TEST_P(AidlTest, ParsesNonUtf8Annotations) {
357 auto parse_result =
358 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
359 ASSERT_NE(nullptr, parse_result);
360 const AidlInterface* interface = parse_result->AsInterface();
361 ASSERT_NE(nullptr, interface);
362 ASSERT_FALSE(interface->GetMethods().empty());
363 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800364}
365
Devin Moore7b8d5c92020-03-17 14:14:08 -0700366TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900367 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
368 typenames_, GetLanguage());
369 ASSERT_NE(nullptr, parse_result);
370 const AidlInterface* interface = parse_result->AsInterface();
371 ASSERT_NE(nullptr, interface);
372 ASSERT_FALSE(interface->GetMethods().empty());
373 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700377 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700378 const string expected_stderr =
379 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
380 "\"vintf\"'\n"
381 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
382 "--structured\n";
383 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700384 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700386 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700387 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700388}
389
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700391 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700392 const string expected_stderr =
393 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
394 "--structured\n";
395 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700397 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700399 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700400}
401
Devin Moore7b8d5c92020-03-17 14:14:08 -0700402TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700403 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700404 const string expected_stderr =
405 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
406 "\"vintf\"'\n";
407 CaptureStderr();
408 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700409 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700411 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700412}
413
Devin Moore7b8d5c92020-03-17 14:14:08 -0700414TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700415 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
417 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700418 ASSERT_EQ(AidlError::OK, error);
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700423}
424
Jeongik Cha64783ed2019-06-07 18:30:54 +0900425TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
426 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900427 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
428 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900429 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700430 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900431 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900432 "a/Foo.aidl",
433 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900434
435 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900436 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700437 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900438 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700439 "Parcelable must be defined in AIDL directly.\n";
440 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900441 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700443
444 CaptureStderr();
445 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900447}
448
Jooyung Han1cbc4962020-10-25 10:07:15 +0900449TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
450 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
451 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
452 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900453 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
454
455 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900456 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900457 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
458
459 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900460 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900461 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
462
Jooyung Han1cbc4962020-10-25 10:07:15 +0900463 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900464 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
465}
466
Jooyung Han1cbc4962020-10-25 10:07:15 +0900467TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
468 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
469 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
470 CaptureStderr();
471 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
472 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
473 EXPECT_EQ("", GetCapturedStderr());
474
475 const string expected_to_string_method = R"--(
476 @Override
477 public String toString() {
478 switch (_tag) {
479 case a: return "a.Foo.a(" + (getA()) + ")";
480 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
481 }
482 throw new IllegalStateException("unknown field: " + _tag);
483 }
484)--";
485
486 string java_out;
487 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
488 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
489}
490
Jiyong Park9aa3d042020-12-04 23:30:02 +0900491TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
492 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
493 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
494 CaptureStderr();
495 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
496 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
497 EXPECT_EQ("", GetCapturedStderr());
498
499 const std::string expected = R"--(
500 @Override
501 public boolean equals(Object other) {
502 if (this == other) return true;
503 if (other == null) return false;
504 if (!(other instanceof Foo)) return false;
505 Foo that = (Foo)other;
506 if (!java.util.Objects.deepEquals(a, that.a)) return false;
507 if (!java.util.Objects.deepEquals(b, that.b)) return false;
508 return true;
509 }
510
511 @Override
512 public int hashCode() {
513 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
514 }
515)--";
516
517 string java_out;
518 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
519 EXPECT_THAT(java_out, testing::HasSubstr(expected));
520}
521
522TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
523 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
524 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
525 CaptureStderr();
526 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
527 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
528 EXPECT_EQ("", GetCapturedStderr());
529
530 const std::string expected = R"--(
531 @Override
532 public boolean equals(Object other) {
533 if (this == other) return true;
534 if (other == null) return false;
535 if (!(other instanceof Foo)) return false;
536 Foo that = (Foo)other;
537 if (_tag != that._tag) return false;
538 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
539 return true;
540 }
541
542 @Override
543 public int hashCode() {
544 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
545 }
546)--";
547
548 string java_out;
549 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
550 EXPECT_THAT(java_out, testing::HasSubstr(expected));
551}
552
Jooyung Han90345002020-10-23 15:28:53 +0900553TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900554 {
Jooyung Han90345002020-10-23 15:28:53 +0900555 io_delegate_.SetFileContents("a/Foo.aidl",
556 "package a; @JavaDerive(blah=true) parcelable Foo{}");
557 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
558 CaptureStderr();
559 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
560 const std::string expected_stderr =
561 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900562 EXPECT_THAT(GetCapturedStderr(),
563 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900564 }
565
566 {
567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900571 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900572 }
573
574 {
Jooyung Han90345002020-10-23 15:28:53 +0900575 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900576 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
577 CaptureStderr();
578 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900579 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900580 }
581}
582
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900583TEST_P(AidlTest, ParseDescriptorAnnotation) {
584 AidlError error;
585 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
586 typenames_, GetLanguage(), &error, {"--structured"});
587 ASSERT_EQ(AidlError::OK, error);
588 ASSERT_NE(nullptr, parse_result);
589 const AidlInterface* interface = parse_result->AsInterface();
590 ASSERT_NE(nullptr, interface);
591 ASSERT_EQ("IBar", interface->GetDescriptor());
592}
593
Jiyong Park40782d02020-07-24 19:17:43 +0900594TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700595 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700596 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900597}
598
599TEST_P(AidlTest, AcceptsOnewayInterface) {
600 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700601 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700602}
Christopher Wileyef140932015-11-03 09:29:19 -0800603
Devin Moore7b8d5c92020-03-17 14:14:08 -0700604TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700605 const string oneway_method =
606 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700607 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100608}
609
Steven Moreland65297cc2020-04-20 20:17:36 -0700610TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
611 const string oneway_method =
612 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
613 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
614 ASSERT_NE(nullptr, defined);
615 const AidlInterface* iface = defined->AsInterface();
616 ASSERT_NE(nullptr, iface);
617
618 const auto& methods = iface->GetMethods();
619 ASSERT_EQ(1u, methods.size());
620 const auto& method = methods[0];
621 const AidlTypeSpecifier& ret_type = method->GetType();
622
623 // TODO(b/151102494): these annotations should be on the method
624 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
625 ASSERT_TRUE(ret_type.IsHide());
626}
627
Devin Moore7b8d5c92020-03-17 14:14:08 -0700628TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100629 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900630 R"(package a;
631 /* foo */
632 interface IFoo {
633 /* i */
634 int i();
635 // j
636 @nullable String j();
637 // k1
638 /* k2 */
639 @UnsupportedAppUsage oneway void k(int a);
640 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100641
Jooyung Han8451a202021-01-16 03:07:06 +0900642 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700643 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100644 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900645 EXPECT_EQ("", GetCapturedStderr());
646
Jooyung Han161bb0f2021-01-21 12:30:16 +0900647 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100648
649 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900650 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
651 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
652 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100653}
654
Jooyung Han1a551d32020-10-05 15:37:26 +0900655TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
656 io_delegate_.SetFileContents("p/cpp_header.aidl",
657 R"(package p;
658 parcelable cpp_header cpp_header "bar/header";)");
659 import_paths_.emplace("");
660 const string input_path = "p/IFoo.aidl";
661 const string input = R"(package p;
662 import p.cpp_header;
663 interface IFoo {
664 // get bar
665 cpp_header get();
666 })";
667
668 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
669 EXPECT_NE(nullptr, parse_result);
670 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900671 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900672}
673
Christopher Wileyef140932015-11-03 09:29:19 -0800674TEST_F(AidlTest, ParsesPreprocessedFile) {
675 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
676 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700677 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900678 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700679 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
680 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800681}
682
683TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
684 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
685 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900686
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700687 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900688 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700689 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
690 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800691}
692
Devin Moore7b8d5c92020-03-17 14:14:08 -0700693TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800694 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
695 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
696 "interface IBar {}");
697 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900698 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900699 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700700 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800701 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900702
Christopher Wiley41544372015-11-03 14:52:29 -0800703 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700704 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
705 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800706 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900707 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900708 ambiguous_type.Resolve(typenames_);
709 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800710}
711
Jiyong Park8f6ec462020-01-19 20:52:47 +0900712// Special case of PreferImportToPreprocessed. Imported type should be preferred
713// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700714TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900715 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
716 io_delegate_.SetFileContents("one/IBar.aidl",
717 "package one; "
718 "interface IBar {}");
719 preprocessed_files_.push_back("preprocessed");
720 import_paths_.emplace("");
721 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700722 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900723 EXPECT_NE(nullptr, parse_result);
724
725 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700726 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
727 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900728 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900729 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900730 ambiguous_type.Resolve(typenames_);
731 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
732}
733
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800734TEST_F(AidlTest, WritePreprocessedFile) {
735 io_delegate_.SetFileContents("p/Outer.aidl",
736 "package p; parcelable Outer.Inner;");
737 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
738 "interface IBar {}");
739
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900740 vector<string> args {
741 "aidl",
742 "--preprocess",
743 "preprocessed",
744 "p/Outer.aidl",
745 "one/IBar.aidl"};
746 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800747 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
748
749 string output;
750 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
751 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
752}
753
Jooyung Han720253d2021-01-05 19:13:17 +0900754TEST_P(AidlTest, SupportDeprecated) {
755 struct TestCase {
756 std::string output_file;
757 std::string annotation;
758 };
759
760 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900761 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900762 io_delegate_.SetFileContents(filename, contents);
763
764 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
765 " --out=out --header_out=out");
766 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900767 for (const auto& [lang, test_case] : expectations) {
768 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900769 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900770 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900771 EXPECT_THAT(output, HasSubstr(test_case.annotation));
772 }
773 };
774
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900775 // Emit escaped string for notes
776 CheckDeprecated(
777 "IFoo.aidl",
778 R"(interface IFoo {
779 /**
780 * @note asdf
781 * @deprecated a really long deprecation message
782 *
783 * which is really long
784 * @param foo bar
785 */
786 List<String> foo();
787 })",
788 {
789 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
790 {Options::Language::CPP,
791 {"out/IFoo.h",
792 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
793 {Options::Language::NDK,
794 {"out/aidl/IFoo.h",
795 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
796 {Options::Language::RUST,
797 {"out/IFoo.rs",
798 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
799 });
800
Jooyung Han24effbf2021-01-16 10:24:03 +0900801 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900802 CheckDeprecated(
803 "IFoo.aidl",
804 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900805 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900806 " List<String> foo();\n"
807 "}",
808 {
809 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900810 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900811 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
812 {Options::Language::NDK,
813 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
814 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
815 });
Jooyung Han720253d2021-01-05 19:13:17 +0900816
Jooyung Han24effbf2021-01-16 10:24:03 +0900817 // but not in line comments
818 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
819 EXPECT_FALSE(parsed->IsDeprecated());
820
821 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900822 CheckDeprecated("Foo.aidl",
823 "parcelable Foo {\n"
824 " /** @deprecated use bar*/\n"
825 " int foo = 0;\n"
826 "}",
827 {
828 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
829 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
830 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
831 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
832 });
833
Jooyung Han24effbf2021-01-16 10:24:03 +0900834 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900835 CheckDeprecated("IFoo.aidl",
836 "interface IFoo {\n"
837 " /** @deprecated use bar*/\n"
838 " const int FOO = 0;\n"
839 "}",
840 {
841 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
842 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
843 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
844 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
845 });
846
847 // union fields
848 CheckDeprecated("Foo.aidl",
849 "union Foo {\n"
850 " int bar = 0;\n"
851 " /** @deprecated use bar*/\n"
852 " int foo;\n"
853 "}",
854 {
855 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
856 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
857 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
858 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
859 });
860
861 CheckDeprecated("Foo.aidl",
862 "/** @deprecated use Bar */\n"
863 "parcelable Foo {}",
864 {
865 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
866 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
867 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
868 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
869 });
870
871 CheckDeprecated("Foo.aidl",
872 "/** @deprecated use Bar */\n"
873 "union Foo { int foo = 0; }",
874 {
875 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
876 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
877 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
878 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
879 });
880
881 CheckDeprecated("IFoo.aidl",
882 "/** @deprecated use IBar */\n"
883 "interface IFoo {}",
884 {
885 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
886 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
887 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
888 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
889 });
890
891 CheckDeprecated("Foo.aidl",
892 "/** @deprecated use IBar */\n"
893 "enum Foo { FOO }",
894 {
895 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
896 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
897 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900898 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +0900899 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
900 });
901}
902
Devin Moore7b8d5c92020-03-17 14:14:08 -0700903TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700904 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800905 io_delegate_.SetFileContents("p/Outer.aidl",
906 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900907 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700908 CaptureStderr();
909 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
910 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700911 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800913}
914
Devin Moore7b8d5c92020-03-17 14:14:08 -0700915TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800916 io_delegate_.SetFileContents("preprocessed",
917 "parcelable p.Outer.Inner;");
918 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900919 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700920 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800921 // TODO(wiley): This should actually return nullptr because we require
922 // the outer class name. However, for legacy reasons,
923 // this behavior must be maintained. b/17415692
924 EXPECT_NE(nullptr, parse_result);
925}
926
Christopher Wiley632801d2015-11-05 14:15:49 -0800927TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700928 const string expected_foo_stderr =
929 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
930 "Declared parcelables should be in their own file and/or cannot be used with --structured "
931 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700932 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
933
Christopher Wiley632801d2015-11-05 14:15:49 -0800934 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700935 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900937 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900939
Steven Morelande2c64b42018-09-18 15:06:37 -0700940 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900941 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900943 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700944 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700945
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 const string expected_bar_stderr =
947 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
948 "Declared parcelables should be in their own file and/or cannot be used with --structured "
949 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700950 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
951
Jiyong Parkda8c6932019-08-12 19:56:08 +0900952 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700953 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900955 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700957 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700959 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700960 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800961}
962
Devin Moore7b8d5c92020-03-17 14:14:08 -0700963TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 const string expected_stderr =
965 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
966 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700967 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
968 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 AidlError error;
970 CaptureStderr();
971 EXPECT_EQ(
972 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700973 Parse("p/IFoo.aidl",
974 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700975 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700976 EXPECT_EQ(expected_stderr, GetCapturedStderr());
977 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700978}
979
Devin Moore7b8d5c92020-03-17 14:14:08 -0700980TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700981 AidlError error;
982 const string expected_stderr =
983 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
984 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900985 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
986 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700987 interface IFoo {
988 const String DUPLICATED = "d";
989 const int DUPLICATED = 1;
990 }
991 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700992 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
994 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700995}
996
Steven Morelande689da22020-11-10 02:06:30 +0000997TEST_P(AidlTest, FailOnTooBigConstant) {
998 AidlError error;
999 const string expected_stderr =
1000 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1001 CaptureStderr();
1002 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1003 R"(package p;
1004 interface IFoo {
1005 const byte type2small = 256;
1006 }
1007 )",
1008 typenames_, GetLanguage(), &error));
1009 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1010 EXPECT_EQ(AidlError::BAD_TYPE, error);
1011}
1012
Jooyung Han30f64ad2020-12-15 08:16:31 +09001013TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1014 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1015 CaptureStderr();
1016 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1017 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1018 EXPECT_EQ("", GetCapturedStderr());
1019 string code;
1020 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1021 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1022}
1023
Jooyung Han535c5e82020-12-29 15:16:59 +09001024TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001025 using Ptr = unique_ptr<AidlConstantValue>;
1026 const AidlLocation& loc = AIDL_LOCATION_HERE;
1027
Jooyung Han535c5e82020-12-29 15:16:59 +09001028 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1029 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1030 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1031 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001032
1033 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1034 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001035 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001036
1037 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1038 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1039 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1040 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001041 EXPECT_EQ(
1042 expected,
1043 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001044}
1045
Devin Moore7b8d5c92020-03-17 14:14:08 -07001046TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001047 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001048 const string expected_stderr =
1049 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001050 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001051 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1052 R"(package p;
1053 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001054 parcelable IBar {}
1055 parcelable StructuredParcelable {}
1056 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001057 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001058 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001059 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001060 // Parse success is important for clear error handling even if the cases aren't
1061 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001062 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001063}
1064
Devin Moore7b8d5c92020-03-17 14:14:08 -07001065TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001066 AidlError error;
1067 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1068 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001069 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001070 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1071 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001072}
1073
Steven Morelandf9e922f2020-07-08 21:15:27 +00001074TEST_P(AidlTest, FailOnEmptyListWithComma) {
1075 AidlError error;
1076 const string expected_stderr =
1077 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1078 CaptureStderr();
1079 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1080 typenames_, GetLanguage(), &error));
1081 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1082 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1083}
1084
Devin Moore7b8d5c92020-03-17 14:14:08 -07001085TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001086 AidlError error;
1087 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001088 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001089 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001090 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1091 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001092 interface IFoo {
1093 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1094 }
1095 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001096 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001097 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1098 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001099}
1100
Jiyong Park18132182020-06-08 20:24:40 +09001101TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1102 AidlError error;
1103 const string expected_stderr =
1104 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1105 "cpp_header (which can also be used as an identifier)\n";
1106 CaptureStderr();
1107 // Notice the trailing dot(.) in the name, which isn't a correct name
1108 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1109 GetLanguage(), &error));
1110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1111 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1112}
1113
1114TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1115 AidlError error;
1116 const string expected_stderr =
1117 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1118 "cpp_header (which can also be used as an identifier)\n";
1119 CaptureStderr();
1120 // Notice the trailing dot(.) in the package name
1121 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1122 GetLanguage(), &error));
1123 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1124 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1125}
1126
Devin Moore7b8d5c92020-03-17 14:14:08 -07001127TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001128 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001129 auto parse_result = Parse("p/IFoo.aidl",
1130 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001131 interface IFoo {
1132 const int POSITIVE_HEX_VALUE = 0xf5;
1133 }
1134 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135 typenames_, GetLanguage(), &error);
1136 EXPECT_NE(nullptr, parse_result);
1137 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001138 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001139 const auto& cpp_constants = interface->GetConstantDeclarations();
1140 EXPECT_EQ((size_t)1, cpp_constants.size());
1141 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001142 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001143 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001144}
1145
Devin Moore7b8d5c92020-03-17 14:14:08 -07001146TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001147 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001148 auto parse_result = Parse("p/IFoo.aidl",
1149 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001150 interface IFoo {
1151 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1152 }
1153 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001154 typenames_, GetLanguage(), &error);
1155 ASSERT_NE(nullptr, parse_result);
1156 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001157 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001158 const auto& cpp_constants = interface->GetConstantDeclarations();
1159 EXPECT_EQ((size_t)1, cpp_constants.size());
1160 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001161 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001162 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001163}
1164
Devin Moore7b8d5c92020-03-17 14:14:08 -07001165TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001166 io_delegate_.SetFileContents(
1167 "p/Outer.aidl",
1168 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001169 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001170 const string input_path = "p/IFoo.aidl";
1171 const string input = "package p; import p.Outer; interface IFoo"
1172 " { Outer.Inner get(); }";
1173
Devin Moore7b8d5c92020-03-17 14:14:08 -07001174 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1175 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001176
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001177 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001178 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001179 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001180 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001181}
1182
Devin Moore7b8d5c92020-03-17 14:14:08 -07001183TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001184 io_delegate_.SetFileContents(
1185 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001186 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001187 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001188 const string input_path = "p/IFoo.aidl";
1189 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001190 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1191 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001192 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001193 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001194 native_type.Resolve(typenames_);
1195
1196 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1197 // C++ understands C++ specific stuff
1198 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1199 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001200 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001201 EXPECT_EQ(1u, headers.size());
1202 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001203}
1204
Christopher Wileyf8136192016-04-12 14:19:35 -07001205TEST_F(AidlTest, WritesCorrectDependencyFile) {
1206 // While the in tree build system always gives us an output file name,
1207 // other android tools take advantage of our ability to infer the intended
1208 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001209 vector<string> args = {
1210 "aidl",
1211 "-d dep/file/path",
1212 "-o place/for/output",
1213 "p/IFoo.aidl"};
1214 Options options = Options::From(args);
1215 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001216 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001217 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001218 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001219 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1220}
1221
Dan Willemsen93298ee2016-11-10 23:55:55 -08001222TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1223 // While the in tree build system always gives us an output file name,
1224 // other android tools take advantage of our ability to infer the intended
1225 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001226 vector<string> args = {
1227 "aidl",
1228 "-d dep/file/path",
1229 "--ninja",
1230 "-o place/for/output",
1231 "p/IFoo.aidl"};
1232 Options options = Options::From(args);
1233 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001234 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001235 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001236 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001237 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1238}
1239
Jiyong Parkdf202122019-09-30 20:48:35 +09001240TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001241 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1242 // this by calling aidl with every .aidl file it finds, then parsing the
1243 // generated dependency files. Those that reference .java output files are
1244 // for interfaces and those that do not are parcelables. However, for both
1245 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001246 vector<string> args = {
1247 "aidl",
1248 "-o place/for/output",
1249 "-d dep/file/path",
1250 "p/Foo.aidl"};
1251 Options options = Options::From(args);
1252 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001253 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001254 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001255 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001256 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1257}
1258
1259TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1260 vector<string> args = {
1261 "aidl",
1262 "--structured",
1263 "-o place/for/output",
1264 "-d dep/file/path",
1265 "p/Foo.aidl"};
1266 Options options = Options::From(args);
1267 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1268 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1269 string actual_dep_file_contents;
1270 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1271 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001272}
1273
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001274TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1275 vector<string> args = {
1276 "aidl",
1277 "--lang=java",
1278 "-o place/for/output",
1279 "p/Foo.aidl"};
1280 Options options = Options::From(args);
1281 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1282 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1283 string output_file_contents;
1284 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1285}
1286
Devin Moore21b26772020-08-26 16:37:56 -07001287TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001288 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001289 const string list_array_parcelable =
1290 "package a; parcelable Foo {\n"
1291 " List[] lists; }";
1292 CaptureStderr();
1293 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1294 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1295}
1296
Jiyong Parkf8d53612020-05-04 14:06:13 +09001297TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1298 AidlError error;
1299 string expected_stderr =
1300 "ERROR: a/IFoo.aidl:2.7-11: "
1301 "Encountered an untyped List or Map. The use of untyped List/Map is "
1302 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1303 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1304 if (GetLanguage() != Options::Language::JAVA) {
1305 expected_stderr =
1306 "ERROR: a/IFoo.aidl:2.1-7: "
1307 "Currently, only the Java backend supports non-generic List.\n";
1308 }
1309
1310 const string primitive_interface =
1311 "package a; interface IFoo {\n"
1312 " List foo(); }";
1313 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001314 AidlTypenames tn1;
1315 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001316 {"--structured"}));
1317 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001318
1319 string primitive_parcelable =
1320 "package a; parcelable IFoo {\n"
1321 " List foo;}";
1322 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001323 AidlTypenames tn2;
1324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001325 {"--structured"}));
1326 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1327}
1328
Jeongik Cha225519b2020-08-29 01:55:32 +09001329TEST_P(AidlTest, ExtensionTest) {
1330 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001331 string extendable_parcelable =
1332 "package a; parcelable Data {\n"
1333 " ParcelableHolder extension;\n"
1334 " ParcelableHolder extension2;\n"
1335 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001336 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001337 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1338 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001339 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001340 "yet.\n",
1341 GetCapturedStderr());
1342 } else {
1343 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1344 EXPECT_EQ("", GetCapturedStderr());
1345 }
1346}
1347TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1348 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001349 string parcelableholder_return_interface =
1350 "package a; interface IFoo {\n"
1351 " ParcelableHolder foo();\n"
1352 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001353 EXPECT_EQ(nullptr,
1354 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001355
Jeongik Cha8f02a532020-10-14 00:16:28 +09001356 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001357 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001358 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001359 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001360 "yet.\n",
1361 GetCapturedStderr());
1362 return;
1363 }
1364 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1365 GetCapturedStderr());
1366}
1367
1368TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1369 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001370 string extendable_parcelable_arg_interface =
1371 "package a; interface IFoo {\n"
1372 " void foo(in ParcelableHolder ph);\n"
1373 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001374 EXPECT_EQ(nullptr,
1375 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1376
Jeongik Cha8f02a532020-10-14 00:16:28 +09001377 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001378 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001379 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001380 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001381 "yet.\n",
1382 GetCapturedStderr());
1383 return;
1384 }
1385 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1386 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001387}
1388
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001389TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1390 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001391 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001392 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1393 CaptureStderr();
1394 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1395 if (GetLanguage() == Options::Language::RUST) {
1396 EXPECT_EQ(
1397 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1398 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1399 "yet.\n",
1400 GetCapturedStderr());
1401 return;
1402 }
1403 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1404}
1405
Jooyung Han3f347ca2020-12-01 12:41:50 +09001406TEST_P(AidlTest, ParcelablesWithConstants) {
1407 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001408 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001409 CaptureStderr();
1410 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1411 EXPECT_EQ("", GetCapturedStderr());
1412}
1413
1414TEST_P(AidlTest, UnionWithConstants) {
1415 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001416 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001417 CaptureStderr();
1418 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1419 EXPECT_EQ("", GetCapturedStderr());
1420}
1421
Jooyung Han633eab62021-01-07 14:12:40 +09001422TEST_F(AidlTest, ConstantsWithAnnotations) {
1423 io_delegate_.SetFileContents("IFoo.aidl",
1424 "interface IFoo {\n"
1425 " @JavaPassthrough(annotation=\"@Foo\")\n"
1426 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1427 "}");
1428 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1429 CaptureStderr();
1430 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1431 EXPECT_EQ("", GetCapturedStderr());
1432 string code;
1433 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1434 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1435 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1436}
1437
Jiyong Park02da7422018-07-16 16:00:26 +09001438TEST_F(AidlTest, ApiDump) {
1439 io_delegate_.SetFileContents(
1440 "foo/bar/IFoo.aidl",
1441 "package foo.bar;\n"
1442 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001443 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001444 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001445 " /* @hide applied \n"
1446 " @deprecated use foo2 */\n"
1447 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1448 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001449 " IFoo foo3(IFoo foo);\n"
1450 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001451 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001452 " /** blahblah\n"
1453 " @deprecated\n"
1454 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001455 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001456 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001457 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001458 "}\n");
1459 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1460 "package foo.bar;\n"
1461 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001462 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001463 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001464 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001465 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001466 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001467 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001468 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001469 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001470 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001471 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001472 "}\n");
1473 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001474 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1475 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001476 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001477 bool result = dump_api(options, io_delegate_);
1478 ASSERT_TRUE(result);
1479 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001480 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001481 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001482interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001483 /**
1484 * @hide
1485 * @deprecated use foo2
1486 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001487 int foo(out int[] a, String b, boolean c, inout List<String> d);
1488 int foo2(@utf8InCpp String x, inout List<String> y);
1489 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1490 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001491 /**
1492 * @deprecated reason why...
1493 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001494 const int A = 1;
1495 const String STR = "Hello";
1496}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001497)"),
1498 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001499
Jiyong Parke59c3682018-09-11 23:10:25 +09001500 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001501 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001502/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001503parcelable Data {
1504 int x = 10;
1505 int y;
1506 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001507 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001508}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001509)"),
1510 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001511}
1512
Jiyong Parked65bf42018-08-28 15:43:27 +09001513TEST_F(AidlTest, ApiDumpWithManualIds) {
1514 io_delegate_.SetFileContents(
1515 "foo/bar/IFoo.aidl",
1516 "package foo.bar;\n"
1517 "interface IFoo {\n"
1518 " int foo() = 1;\n"
1519 " int bar() = 2;\n"
1520 " int baz() = 10;\n"
1521 "}\n");
1522
Jiyong Parke59c3682018-09-11 23:10:25 +09001523 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001524 Options options = Options::From(args);
1525 bool result = dump_api(options, io_delegate_);
1526 ASSERT_TRUE(result);
1527 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001528 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001529 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001530interface IFoo {
1531 int foo() = 1;
1532 int bar() = 2;
1533 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001534}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001535)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001536}
1537
1538TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001539 const string expected_stderr =
1540 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1541 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001542 io_delegate_.SetFileContents(
1543 "foo/bar/IFoo.aidl",
1544 "package foo.bar;\n"
1545 "interface IFoo {\n"
1546 " int foo() = 1;\n"
1547 " int bar();\n"
1548 " int baz() = 10;\n"
1549 "}\n");
1550
Jiyong Parke59c3682018-09-11 23:10:25 +09001551 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001552 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001553 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001554 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001555 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001556}
1557
Jooyung Han965e31d2020-11-27 12:30:16 +09001558TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1559 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1560 "package foo.bar;\n"
1561 "interface IFoo {\n"
1562 " @utf8InCpp String foo();\n"
1563 " const @utf8InCpp String bar = \"bar\";\n"
1564 "}\n");
1565
1566 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1567 Options options = Options::From(args);
1568 CaptureStderr();
1569 EXPECT_TRUE(dump_api(options, io_delegate_));
1570 EXPECT_EQ("", GetCapturedStderr());
1571 string actual;
1572 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001573 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1574interface IFoo {
1575 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001576 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001577}
1578)"),
1579 actual);
1580}
1581
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001582TEST_F(AidlTest, ApiDumpWithEnums) {
1583 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1584 "package foo.bar;\n"
1585 "enum Enum {\n"
1586 " FOO,\n"
1587 " BAR = FOO + 1,\n"
1588 "}\n");
1589
1590 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1591 Options options = Options::From(args);
1592 CaptureStderr();
1593 EXPECT_TRUE(dump_api(options, io_delegate_));
1594 EXPECT_EQ("", GetCapturedStderr());
1595 string actual;
1596 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1597 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1598 "enum Enum {\n"
1599 " FOO = 0,\n"
1600 " BAR = 1,\n"
1601 "}\n"),
1602 actual);
1603}
1604
1605TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1606 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1607 "package foo.bar;\n"
1608 "enum Enum {\n"
1609 " FOO,\n"
1610 "}\n");
1611 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1612 "package foo.bar;\n"
1613 "import foo.bar.Enum;\n"
1614 "parcelable Foo {\n"
1615 " Enum e = Enum.FOO;\n"
1616 "}\n");
1617
1618 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1619 Options options = Options::From(args);
1620 CaptureStderr();
1621 EXPECT_TRUE(dump_api(options, io_delegate_));
1622 EXPECT_EQ("", GetCapturedStderr());
1623 string actual;
1624 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1625 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1626 "parcelable Foo {\n"
1627 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1628 "}\n"),
1629 actual);
1630}
1631
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001632TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001633 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001634 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1635 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 const string expected_map_stderr =
1637 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001638 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1639 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001640 "package p; interface IFoo {"
1641 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001642 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001643 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001644 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001645
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001646 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001647 "package p; interface IFoo {"
1648 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001649 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001650 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001651 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001652}
1653
Jeongik Chae48d9942020-01-02 17:39:00 +09001654TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 const string expected_stderr =
1656 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001657 Options options = Options::From("aidl -I p p/IFoo.aidl");
1658 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1659
1660 io_delegate_.SetFileContents("p/IFoo.aidl",
1661 "package p; interface IFoo {"
1662 "Map<String, Bar> foo();}");
1663 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1664
1665 io_delegate_.SetFileContents("p/IFoo.aidl",
1666 "package p; interface IFoo {"
1667 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001668 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001669 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001670 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001671
1672 io_delegate_.SetFileContents("p/IFoo.aidl",
1673 "package p; interface IFoo {"
1674 "Map<String, String> foo();}");
1675 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1676
1677 io_delegate_.SetFileContents("p/IFoo.aidl",
1678 "package p; interface IFoo {"
1679 "Map<String, ParcelFileDescriptor> foo();}");
1680 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1681}
1682
Jeongik Chadf76dc72019-11-28 00:08:47 +09001683TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001684 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001685 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1686 io_delegate_.SetFileContents(options.InputFiles().front(),
1687 "package p; interface IFoo {"
1688 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001689 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001690 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001691 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001692}
1693
1694TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1695 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1696 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001697 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001698 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001699 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1700 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001701
1702 Options options = Options::From("aidl -I p p/IFoo.aidl");
1703 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1704 io_delegate_.SetFileContents("p/IFoo.aidl",
1705 "package p; interface IFoo {"
1706 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001707 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001708 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001709 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001710 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001711 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001712 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001713 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1714 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001715 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1716 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1717 io_delegate_.SetFileContents("p/IFoo.aidl",
1718 "package p; interface IFoo {"
1719 "Bar<String, ParcelFileDescriptor> foo();}");
1720 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001721
1722 io_delegate_.SetFileContents("p/IFoo.aidl",
1723 "package p; interface IFoo {"
1724 "Bar<int, long> foo();}");
1725
1726 io_delegate_.SetFileContents("p/IFoo.aidl",
1727 "package p; interface IFoo {"
1728 "Bar<int[], long[]> foo();}");
1729
1730 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001731}
1732
Jeongik Cha0e426012019-07-29 15:57:02 +09001733TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1734 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001735 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1736 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001737 for (const auto& rawOption : rawOptions) {
1738 string expected_stderr =
1739 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001740 Options options = Options::From(rawOption);
1741 io_delegate_.SetFileContents(options.InputFiles().front(),
1742 "package foo.bar;\n"
1743 "interface IFoo1 { int foo(); }\n"
1744 "interface IFoo2 { int foo(); }\n"
1745 "parcelable Data1 { int a; int b;}\n"
1746 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001747 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001748 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001749 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001750
Jeongik Cha0e426012019-07-29 15:57:02 +09001751 io_delegate_.SetFileContents(options.InputFiles().front(),
1752 "package foo.bar;\n"
1753 "interface IFoo1 { int foo(); }\n"
1754 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001755 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001756 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001757 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001758
Devin Moore5de18ed2020-04-02 13:52:29 -07001759 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001760 io_delegate_.SetFileContents(options.InputFiles().front(),
1761 "package foo.bar;\n"
1762 "parcelable Data1 { int a; int b;}\n"
1763 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001764 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001765 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001766 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001767 }
1768}
1769
Devin Moorebdba2a82020-03-31 15:19:02 -07001770TEST_P(AidlTest, FailParseOnEmptyFile) {
1771 const string contents = "";
1772 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1773 CaptureStderr();
1774 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1775 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1776}
1777
Jiyong Parkb034bf02018-07-30 17:44:33 +09001778TEST_F(AidlTest, MultipleInputFiles) {
1779 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001780 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001781
1782 io_delegate_.SetFileContents(options.InputFiles().at(0),
1783 "package foo.bar;\n"
1784 "import foo.bar.Data;\n"
1785 "interface IFoo { Data getData(); }\n");
1786
1787 io_delegate_.SetFileContents(options.InputFiles().at(1),
1788 "package foo.bar;\n"
1789 "import foo.bar.IFoo;\n"
1790 "parcelable Data { IFoo foo; }\n");
1791
1792 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1793
1794 string content;
1795 for (const auto file : {
1796 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1797 content.clear();
1798 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1799 EXPECT_FALSE(content.empty());
1800 }
1801}
1802
1803TEST_F(AidlTest, MultipleInputFilesCpp) {
1804 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001805 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001806
1807 io_delegate_.SetFileContents(options.InputFiles().at(0),
1808 "package foo.bar;\n"
1809 "import foo.bar.Data;\n"
1810 "interface IFoo { Data getData(); }\n");
1811
1812 io_delegate_.SetFileContents(options.InputFiles().at(1),
1813 "package foo.bar;\n"
1814 "import foo.bar.IFoo;\n"
1815 "parcelable Data { IFoo foo; }\n");
1816
1817 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1818
1819 string content;
1820 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001821 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001822 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1823 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1824 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1825 content.clear();
1826 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1827 EXPECT_FALSE(content.empty());
1828 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001829}
1830
Andrei Homescub62afd92020-05-11 19:24:59 -07001831TEST_F(AidlTest, MultipleInputFilesRust) {
1832 Options options =
1833 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1834
1835 io_delegate_.SetFileContents(options.InputFiles().at(0),
1836 "package foo.bar;\n"
1837 "import foo.bar.Data;\n"
1838 "interface IFoo { Data getData(); }\n");
1839
1840 io_delegate_.SetFileContents(options.InputFiles().at(1),
1841 "package foo.bar;\n"
1842 "import foo.bar.IFoo;\n"
1843 "parcelable Data { IFoo foo; }\n");
1844
1845 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1846
1847 string content;
1848 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1849 content.clear();
1850 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1851 EXPECT_FALSE(content.empty());
1852 }
1853}
1854
Devin Moore097a3ab2020-03-11 16:08:44 -07001855TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1856 const string expected_stderr =
1857 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001858 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1859 // int getInterfaceVersion() is one of the meta transactions
1860 io_delegate_.SetFileContents(options.InputFiles().front(),
1861 "package p; interface IFoo {"
1862 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001863 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001864 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001865 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1866}
Jiyong Park309668e2018-07-28 16:55:44 +09001867
Devin Moore097a3ab2020-03-11 16:08:44 -07001868TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1869 // boolean getInterfaceVersion() is not a meta transaction, but should be
1870 // prevented because return type is not part of a method signature
1871 const string expected_stderr =
1872 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1873 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001874 io_delegate_.SetFileContents(options.InputFiles().front(),
1875 "package p; interface IFoo {"
1876 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001877 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001878 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1880}
Jiyong Park309668e2018-07-28 16:55:44 +09001881
Devin Moore097a3ab2020-03-11 16:08:44 -07001882TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001883 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001884 const string expected_stderr =
1885 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1886 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001887 io_delegate_.SetFileContents(options.InputFiles().front(),
1888 "package p; interface IFoo {"
1889 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001890 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001891 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001892 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001893
1894 // this is not a meta interface method as it differs type arguments
1895 io_delegate_.SetFileContents(options.InputFiles().front(),
1896 "package p; interface IFoo {"
1897 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001898 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001899}
1900
Jooyung Hanb8a97772021-01-19 01:27:38 +09001901TEST_F(AidlTest, CheckApiForEquality) {
1902 CaptureStderr();
1903 Options options = Options::From("aidl --checkapi=equal old new");
1904
1905 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1906 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1907 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1908 "package p; interface IFoo{ @utf8InCpp String foo();}");
1909
1910 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1911 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1912}
1913
Daniel Norman85aed542019-08-21 12:01:14 -07001914TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001915 Options options = Options::From("aidl --checkapi old new");
1916 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1917 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1918 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1919 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1920
1921 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1922}
1923
Jiyong Park3656c3c2018-08-01 20:02:01 +09001924TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001925 Options options = Options::From("aidl --checkapi old new");
1926 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1927 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001928
1929 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1930}
1931
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001932TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1933 Options options = Options::From("aidl --checkapi old new");
1934 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1935 const string enum_definition = "package p; enum Enum { FOO }";
1936 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1937 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1938 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1939 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1940
1941 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1942}
1943
Jooyung Han02a11be2021-02-11 13:18:06 +09001944TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
1945 Options options = Options::From("aidl --checkapi=equal old new");
1946 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1947 const string enum_definition = "package p; enum Enum { FOO }";
1948 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1949 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1950 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1951 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1952 CaptureStderr();
1953 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1954 EXPECT_EQ("", GetCapturedStderr());
1955}
1956
Daniel Norman85aed542019-08-21 12:01:14 -07001957class AidlTestCompatibleChanges : public AidlTest {
1958 protected:
1959 Options options_ = Options::From("aidl --checkapi old new");
1960};
1961
1962TEST_F(AidlTestCompatibleChanges, NewType) {
1963 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1964 "package p;"
1965 "interface IFoo {"
1966 " void foo(int a);"
1967 "}");
1968 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1969 "package p;"
1970 "interface IFoo {"
1971 " void foo(int a);"
1972 "}");
1973 io_delegate_.SetFileContents("new/p/IBar.aidl",
1974 "package p;"
1975 "interface IBar {"
1976 " void bar();"
1977 "}");
1978 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1979}
1980
1981TEST_F(AidlTestCompatibleChanges, NewMethod) {
1982 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1983 "package p;"
1984 "interface IFoo {"
1985 " void foo(int a);"
1986 "}");
1987 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1988 "package p;"
1989 "interface IFoo {"
1990 " void foo(int a);"
1991 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001992 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001993 "}");
1994 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1995}
1996
1997TEST_F(AidlTestCompatibleChanges, NewField) {
1998 io_delegate_.SetFileContents("old/p/Data.aidl",
1999 "package p;"
2000 "parcelable Data {"
2001 " int foo;"
2002 "}");
2003 io_delegate_.SetFileContents("new/p/Data.aidl",
2004 "package p;"
2005 "parcelable Data {"
2006 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002007 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002008 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002009 "}");
2010 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2011}
2012
Jooyung Han05bd8a82021-04-28 23:56:38 +09002013TEST_F(AidlTestCompatibleChanges, NewField2) {
2014 io_delegate_.SetFileContents("old/p/Data.aidl",
2015 "package p;"
2016 "parcelable Data {"
2017 "}");
2018 io_delegate_.SetFileContents("new/p/Data.aidl",
2019 "package p;"
2020 "parcelable Data {"
2021 " int foo = 0;"
2022 "}");
2023 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2024}
2025
Daniel Norman85aed542019-08-21 12:01:14 -07002026TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2027 io_delegate_.SetFileContents("old/p/Enum.aidl",
2028 "package p;"
2029 "enum Enum {"
2030 " FOO = 1,"
2031 "}");
2032 io_delegate_.SetFileContents("new/p/Enum.aidl",
2033 "package p;"
2034 "enum Enum {"
2035 " FOO = 1,"
2036 " BAR = 2,"
2037 "}");
2038 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2039}
2040
2041TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2042 io_delegate_.SetFileContents("old/p/Enum.aidl",
2043 "package p;"
2044 "enum Enum {"
2045 " FOO = 1,"
2046 " BAR = 2,"
2047 "}");
2048 io_delegate_.SetFileContents("new/p/Enum.aidl",
2049 "package p;"
2050 "enum Enum {"
2051 " BAR = 2,"
2052 " FOO = 1,"
2053 "}");
2054 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2055}
2056
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002057TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2058 io_delegate_.SetFileContents("old/p/Union.aidl",
2059 "package p;"
2060 "union Union {"
2061 " String foo;"
2062 "}");
2063 io_delegate_.SetFileContents("new/p/Union.aidl",
2064 "package p;"
2065 "union Union {"
2066 " String foo;"
2067 " int num;"
2068 "}");
2069 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2070}
2071
Daniel Norman85aed542019-08-21 12:01:14 -07002072TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002073 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2074 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002075 "interface IFoo {"
2076 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 "}");
2078 io_delegate_.SetFileContents("old/p/Data.aidl",
2079 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002080 "parcelable Data {"
2081 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002082 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002083 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2084 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002085 "interface IFoo {"
2086 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002087 "}");
2088 io_delegate_.SetFileContents("new/p/Data.aidl",
2089 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002090 "parcelable Data {"
2091 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002092 "}");
2093 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2094 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002095 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002096 " void foo(int a);"
2097 "}");
2098 io_delegate_.SetFileContents("new/q/Data.aidl",
2099 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002100 "parcelable Data {"
2101 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002102 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002103 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2104}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002105
Daniel Norman85aed542019-08-21 12:01:14 -07002106TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2107 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2108 "package p;"
2109 "interface IFoo {"
2110 " void foo(int a);"
2111 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002112 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2113 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002114 "interface IFoo {"
2115 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002116 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002117 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2118}
Jiyong Parke59c3682018-09-11 23:10:25 +09002119
Daniel Norman85aed542019-08-21 12:01:14 -07002120TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002121 io_delegate_.SetFileContents("old/p/I.aidl",
2122 "package p; interface I {"
2123 "const int A = 1; }");
2124 io_delegate_.SetFileContents("new/p/I.aidl",
2125 "package p ; interface I {"
2126 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002127 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2128}
Jiyong Parka428d212018-08-29 22:26:30 +09002129
Daniel Norman85aed542019-08-21 12:01:14 -07002130TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002131 io_delegate_.SetFileContents("old/p/I.aidl",
2132 "package p; interface I {"
2133 "const int A = 1; const int B = 2;}");
2134 io_delegate_.SetFileContents("new/p/I.aidl",
2135 "package p ; interface I {"
2136 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002137 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002138}
2139
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002140TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2141 io_delegate_.SetFileContents("old/p/Foo.aidl",
2142 "package p;"
2143 "@JavaPassthrough(annotation=\"Alice\")"
2144 "@JavaPassthrough(annotation=\"Bob\")"
2145 "parcelable Foo {}");
2146 io_delegate_.SetFileContents("new/p/Foo.aidl",
2147 "package p;"
2148 "@JavaPassthrough(annotation=\"Bob\")"
2149 "@JavaPassthrough(annotation=\"Alice\")"
2150 "parcelable Foo {}");
2151 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2152}
2153
Jooyung Han00073272020-11-27 14:20:20 +09002154TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2155 io_delegate_.SetFileContents("old/p/Foo.aidl",
2156 "package p;"
2157 "parcelable Foo {}");
2158 io_delegate_.SetFileContents("new/p/Foo.aidl",
2159 "package p;"
2160 "@JavaPassthrough(annotation=\"@Deprecated\")"
2161 "parcelable Foo {}");
2162 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2163}
2164
Jooyung Han636fd2f2020-10-22 11:33:45 +09002165TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2166 io_delegate_.SetFileContents("old/p/Data.aidl",
2167 "package p;"
2168 "parcelable Data {"
2169 " int num;"
2170 "}");
2171 io_delegate_.SetFileContents(
2172 "new/p/Data.aidl",
2173 "package p;"
2174 "parcelable Data {"
2175 " int num;"
2176 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2177 "}");
2178 io_delegate_.SetFileContents("new/p/Enum.aidl",
2179 "package p;"
2180 "enum Enum {"
2181 " FOO = 0,"
2182 " BAR = 1,"
2183 "}");
2184 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2185}
2186
Jooyung Han308bbe02021-04-27 12:09:59 +09002187TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2188 io_delegate_.SetFileContents("old/p/Data.aidl",
2189 "package p;\n"
2190 "parcelable Data {\n"
2191 " p.Enum e;\n"
2192 "}");
2193 io_delegate_.SetFileContents("old/p/Enum.aidl",
2194 "package p;\n"
2195 "enum Enum {\n"
2196 " FOO = 0,\n"
2197 " BAR = 1,\n"
2198 "}");
2199 io_delegate_.SetFileContents("new/p/Data.aidl",
2200 "package p;\n"
2201 "parcelable Data {\n"
2202 " p.Enum e = p.Enum.FOO;\n"
2203 "}");
2204 io_delegate_.SetFileContents("new/p/Enum.aidl",
2205 "package p;\n"
2206 "enum Enum {\n"
2207 " FOO = 0,\n"
2208 " BAR = 1,\n"
2209 "}");
2210 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2211}
2212
Daniel Norman85aed542019-08-21 12:01:14 -07002213class AidlTestIncompatibleChanges : public AidlTest {
2214 protected:
2215 Options options_ = Options::From("aidl --checkapi old new");
2216};
2217
2218TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002219 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002220 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2221 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002222 "interface IFoo {"
2223 " void foo(in String[] str);"
2224 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002225 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002226 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002227 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002229}
2230
2231TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 const string expected_stderr =
2233 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002234 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2235 "package p;"
2236 "interface IFoo {"
2237 " void foo(in String[] str);"
2238 " void bar(@utf8InCpp String str);"
2239 "}");
2240 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2241 "package p;"
2242 "interface IFoo {"
2243 " void foo(in String[] str);"
2244 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002245 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002246 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002248}
2249
Jiyong Parkf8d53612020-05-04 14:06:13 +09002250TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2251 const string expected_stderr =
2252 "ERROR: new/p/IFoo.aidl:1.61-65: "
2253 "Encountered an untyped List or Map. The use of untyped List/Map is "
2254 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2255 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2256 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2257 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2258 "package p;"
2259 "interface IFoo {"
2260 " void foo(in String[] str);"
2261 "}");
2262 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2263 "package p;"
2264 "interface IFoo {"
2265 " void foo(in String[] str);"
2266 " void bar(in List arg);"
2267 "}");
2268 CaptureStderr();
2269 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2270 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2271}
2272
2273TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2274 const string expected_stderr =
2275 "ERROR: new/p/Data.aidl:1.54-59: "
2276 "Encountered an untyped List or Map. The use of untyped List/Map is "
2277 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2278 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2279 "ERROR: new/p/Data.aidl: Failed to read.\n";
2280 io_delegate_.SetFileContents("old/p/Data.aidl",
2281 "package p;"
2282 "parcelable Data {"
2283 " int foo;"
2284 "}");
2285 io_delegate_.SetFileContents("new/p/Data.aidl",
2286 "package p;"
2287 "parcelable Data {"
2288 " int foo;"
2289 " @nullable List list;"
2290 "}");
2291 CaptureStderr();
2292 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2293 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2294}
2295
Daniel Norman85aed542019-08-21 12:01:14 -07002296TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002297 const string expected_stderr =
2298 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002299 io_delegate_.SetFileContents("old/p/Data.aidl",
2300 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002301 "parcelable Data {"
2302 " int foo;"
2303 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002304 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002305 io_delegate_.SetFileContents("new/p/Data.aidl",
2306 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002307 "parcelable Data {"
2308 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002309 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002311 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002313}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002314
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002315TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2316 const string expected_stderr =
2317 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2318 "backends. Please either provide a default value for this field or mark the field as "
2319 "@nullable. This value or a null value will be used automatically when an old version of "
2320 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2321 "order to make sure your code continues to be backwards compatible, make sure the default or "
2322 "null value does not cause a semantic change to this parcelable.\n";
2323 io_delegate_.SetFileContents("old/p/Data.aidl",
2324 "package p;"
2325 "parcelable Data {"
2326 " int num;"
2327 "}");
2328 io_delegate_.SetFileContents("new/p/Data.aidl",
2329 "package p;"
2330 "parcelable Data {"
2331 " int num;"
2332 " String str;"
2333 "}");
2334 CaptureStderr();
2335 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2336 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2337}
2338
Jooyung Han636fd2f2020-10-22 11:33:45 +09002339TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2340 const string expected_stderr =
2341 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2342 "Please make sure 'Enum' has '0' as a valid value.\n";
2343 io_delegate_.SetFileContents("old/p/Data.aidl",
2344 "package p;"
2345 "parcelable Data {"
2346 " int num;"
2347 "}");
2348 io_delegate_.SetFileContents("new/p/Data.aidl",
2349 "package p;"
2350 "parcelable Data {"
2351 " int num;"
2352 " p.Enum e;"
2353 "}");
2354 io_delegate_.SetFileContents("new/p/Enum.aidl",
2355 "package p;"
2356 "enum Enum {"
2357 " FOO = 1,"
2358 " BAR = 2,"
2359 "}");
2360 CaptureStderr();
2361 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2362 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2363}
2364
Daniel Norman85aed542019-08-21 12:01:14 -07002365TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 const string expected_stderr =
2367 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002368 io_delegate_.SetFileContents("old/p/Enum.aidl",
2369 "package p;"
2370 "enum Enum {"
2371 " FOO = 1,"
2372 " BAR = 2,"
2373 "}");
2374 io_delegate_.SetFileContents("new/p/Enum.aidl",
2375 "package p;"
2376 "enum Enum {"
2377 " BAR = 2,"
2378 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002380 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002382}
2383
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002384TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2385 const string expected_stderr =
2386 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2387 io_delegate_.SetFileContents("old/p/Union.aidl",
2388 "package p;"
2389 "union Union {"
2390 " String str;"
2391 " int num;"
2392 "}");
2393 io_delegate_.SetFileContents("new/p/Union.aidl",
2394 "package p;"
2395 "union Union {"
2396 " String str;"
2397 "}");
2398 CaptureStderr();
2399 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2401}
2402
Daniel Norman85aed542019-08-21 12:01:14 -07002403TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002404 const string expected_stderr =
2405 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002406 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2407 "package p;"
2408 "interface IFoo {"
2409 " void foo(in String[] str);"
2410 " void bar(@utf8InCpp String str);"
2411 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002412 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2413 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002414 "interface IFoo {"
2415 " void foo(in String[] str);"
2416 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002417 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002418 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002419 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002420 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002421}
2422
Daniel Norman85aed542019-08-21 12:01:14 -07002423TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002424 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002425 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2426 "package p;"
2427 "interface IFoo {"
2428 " void foo(in String[] str);"
2429 " void bar(@utf8InCpp String str);"
2430 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002431 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2432 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002433 "interface IFoo2 {"
2434 " void foo(in String[] str);"
2435 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002436 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002437 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002438 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002440}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002441
Daniel Norman85aed542019-08-21 12:01:14 -07002442TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002443 const string expected_stderr =
2444 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002445 io_delegate_.SetFileContents("old/p/Enum.aidl",
2446 "package p;"
2447 "enum Enum {"
2448 " FOO = 1,"
2449 " BAR = 2,"
2450 "}");
2451 io_delegate_.SetFileContents("new/p/Enum.aidl",
2452 "package p;"
2453 "enum Enum {"
2454 " FOO = 3,"
2455 " BAR = 2,"
2456 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002458 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002459 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002460}
2461
2462TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002463 const string expected_stderr =
2464 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2465 "from 0 to 1.\n"
2466 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2467 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002468 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2469 "package p;"
2470 "interface IFoo {"
2471 " void foo(in String[] str);"
2472 " void bar(@utf8InCpp String str);"
2473 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2475 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002476 "interface IFoo {"
2477 " void bar(@utf8InCpp String str);"
2478 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002479 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002480 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002481 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002483}
2484
2485TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002486 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002487 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2488 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002489 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002490 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002491 "parcelable Data {"
2492 " int foo;"
2493 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002494 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002495 io_delegate_.SetFileContents("new/p/Data.aidl",
2496 "package p;"
2497 "parcelable Data {"
2498 " int bar;"
2499 " int foo;"
2500 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002501 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002502 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002504}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002505
Daniel Norman85aed542019-08-21 12:01:14 -07002506TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002507 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002508 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002509 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002510 "interface IFoo {"
2511 " void foo(in String[] str);"
2512 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002513 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002514 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2515 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002516 "interface IFoo {"
2517 " void foo(out String[] str);"
2518 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002519 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002520 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002521 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002522 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002523}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002524
Daniel Norman85aed542019-08-21 12:01:14 -07002525TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002526 const string expected_stderr =
2527 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002528 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2529 "package p;"
2530 "interface IFoo {"
2531 " void foo(in String[] str);"
2532 " void bar(@utf8InCpp String str);"
2533 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002534 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2535 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002536 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002537 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002538 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002539 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002540 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002541 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002542 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002543}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002544
Daniel Norman85aed542019-08-21 12:01:14 -07002545TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002546 const string expected_stderr =
2547 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002548 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2549 "package p;"
2550 "interface IFoo {"
2551 " void foo(in String[] str);"
2552 " void bar(@utf8InCpp String str);"
2553 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002554 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2555 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002556 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002557 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002558 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002559 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002560 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002561 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002562 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002563}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002564
Jooyung Han60b2fde2020-10-29 15:12:40 +09002565TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2566 const string expected_stderr =
2567 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2568 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2569 io_delegate_.SetFileContents("old/p/Foo.aidl",
2570 "package p;"
2571 "@Backing(type=\"byte\")"
2572 "enum Foo {"
2573 " FOO, BAR,"
2574 "}");
2575 io_delegate_.SetFileContents("new/p/Foo.aidl",
2576 "package p;"
2577 "@Backing(type=\"long\")"
2578 "enum Foo {"
2579 " FOO, BAR,"
2580 "}");
2581 CaptureStderr();
2582 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2583 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2584}
2585
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002586TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2587 const string expected_stderr =
2588 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2589 "to @JavaPassthrough(annotation=\"Bob\")\n";
2590 io_delegate_.SetFileContents("old/p/Foo.aidl",
2591 "package p;"
2592 "@JavaPassthrough(annotation=\"Alice\")"
2593 "parcelable Foo {}");
2594 io_delegate_.SetFileContents("new/p/Foo.aidl",
2595 "package p;"
2596 "@JavaPassthrough(annotation=\"Bob\")"
2597 "parcelable Foo {}");
2598
2599 CaptureStderr();
2600 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2601 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2602}
2603
Devin Mooredb7ac512020-08-07 11:17:36 -07002604TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2605 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002606 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002607 io_delegate_.SetFileContents("old/p/Foo.aidl",
2608 "package p;"
2609 "parcelable Foo {"
2610 " int A;"
2611 "}");
2612 io_delegate_.SetFileContents("new/p/Foo.aidl",
2613 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002614 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002615 " int A;"
2616 "}");
2617 CaptureStderr();
2618 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2619 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2620}
2621
2622TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2623 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002624 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002625 io_delegate_.SetFileContents("old/p/Foo.aidl",
2626 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002627 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002628 " int A;"
2629 "}");
2630 io_delegate_.SetFileContents("new/p/Foo.aidl",
2631 "package p;"
2632 "parcelable Foo {"
2633 " int A;"
2634 "}");
2635 CaptureStderr();
2636 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2637 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2638}
2639
Daniel Norman85aed542019-08-21 12:01:14 -07002640TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002641 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002642 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2643 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002644 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002645 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002646 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002647 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002648}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002649
Daniel Norman85aed542019-08-21 12:01:14 -07002650TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002651 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002652 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2653 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002654 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002655 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002657}
Jiyong Parka428d212018-08-29 22:26:30 +09002658
Daniel Norman85aed542019-08-21 12:01:14 -07002659TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002660 const string expected_stderr =
2661 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002662 io_delegate_.SetFileContents("old/p/I.aidl",
2663 "package p; interface I {"
2664 "const int A = 1; const int B = 2;}");
2665 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002666 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002667 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002668 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002669}
Jiyong Parka428d212018-08-29 22:26:30 +09002670
Daniel Norman85aed542019-08-21 12:01:14 -07002671TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002672 const string expected_stderr =
2673 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002674 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2675 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002676 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002677 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002678 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002679}
2680
Devin Moorec7e47a32020-08-07 10:55:25 -07002681TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2682 const string expected_stderr =
2683 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2684 "This is an incompatible change for FixedSize types.\n";
2685 io_delegate_.SetFileContents("old/p/Foo.aidl",
2686 "package p; @FixedSize parcelable Foo { int A = 1; }");
2687 io_delegate_.SetFileContents("new/p/Foo.aidl",
2688 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2689 CaptureStderr();
2690 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2691 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2692}
2693
Jeongik Cha68d18e72021-04-29 20:07:01 +09002694TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
2695 const string expected_stderr =
2696 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
2697 "android.net.UidRangeParcel is changed from 1 to 2. "
2698 "But it is forbidden because of legacy support.\n";
2699 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
2700 "package android.net; parcelable UidRangeParcel { int A = 1; }");
2701 io_delegate_.SetFileContents(
2702 "new/android/net/UidRangeParcel.aidl",
2703 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
2704 CaptureStderr();
2705 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2706 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2707}
2708
Devin Moorec7e47a32020-08-07 10:55:25 -07002709TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2710 const string expected_stderr =
2711 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2712 io_delegate_.SetFileContents("old/p/Foo.aidl",
2713 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2714 io_delegate_.SetFileContents("new/p/Foo.aidl",
2715 "package p; @FixedSize parcelable Foo { int A = 1; }");
2716 CaptureStderr();
2717 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2718 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2719}
2720
2721TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2722 const string expected_stderr =
2723 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2724 "a.\n"
2725 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2726 "b.\n"
2727 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2728 "c.\n"
2729 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2730 "d.\n"
2731 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2732 "e.\n"
2733 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2734 "f.\n";
2735
2736 io_delegate_.SetFileContents("Foo.aidl",
2737 "@FixedSize parcelable Foo { "
2738 " int[] a;"
2739 " Bar b;"
2740 " String c;"
2741 " ParcelFileDescriptor d;"
2742 " IBinder e;"
2743 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002744 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002745 "}");
2746 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002747 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002748
2749 CaptureStderr();
2750 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2752}
2753
2754TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2755 const string expected_stderr = "";
2756
2757 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2758 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2759 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002760 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002761
2762 CaptureStderr();
2763 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2764 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2765}
2766
Jiyong Park8c380532018-08-30 14:55:26 +09002767TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002768 const string expected_stderr =
2769 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2770 "dir1/q/IBar.aidl\n"
2771 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002772 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002773 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2774 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2775 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2776 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2777
Devin Moore097a3ab2020-03-11 16:08:44 -07002778 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002779 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002780 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002781}
2782
Jiyong Parked65bf42018-08-28 15:43:27 +09002783TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002784 const string expected_stderr =
2785 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2786 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002787 Options options = Options::From("aidl --checkapi old new");
2788 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2789 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002790
2791 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2792
Jiyong Parke59c3682018-09-11 23:10:25 +09002793 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002794 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002795 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002796 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002797}
2798
Jooyung Han652ce482021-02-26 12:40:35 +09002799TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2800 Options options =
2801 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002802
2803 // use without import
2804 io_delegate_.SetFileContents("p/IFoo.aidl",
2805 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002806 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2807
2808 // capture output files
2809 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09002810
Devin Moore7b8d5c92020-03-17 14:14:08 -07002811 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002812 io_delegate_.SetFileContents(
2813 "p/IFoo.aidl",
2814 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002815 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2816 // output files should be the same
2817 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002818
2819 // use with import (as before)
2820 io_delegate_.SetFileContents("p/IFoo.aidl",
2821 "package p;"
2822 "import android.os.ParcelFileDescriptor;"
2823 "interface IFoo{"
2824 " void foo(in ParcelFileDescriptor fd);"
2825 "}");
Jooyung Han652ce482021-02-26 12:40:35 +09002826 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2827 // output files should be the same
2828 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002829}
Jiyong Parked65bf42018-08-28 15:43:27 +09002830
Jooyung Han020d8d12021-02-26 17:23:02 +09002831TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
2832 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
2833 CaptureStderr();
2834 io_delegate_.SetFileContents("p/IFoo.aidl",
2835 "package p;"
2836 "interface IFoo{"
2837 " void foo(out ParcelFileDescriptor fd);"
2838 "}");
2839 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
2840 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
2841}
2842
2843TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
2844 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
2845 CaptureStderr();
2846 io_delegate_.SetFileContents("p/IFoo.aidl",
2847 "package p;"
2848 "interface IFoo{"
2849 " void foo(ParcelFileDescriptor fd);"
2850 "}");
2851 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
2852 EXPECT_THAT(GetCapturedStderr(),
2853 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
2854}
2855
Jiyong Park3633b722019-04-11 15:38:26 +09002856TEST_F(AidlTest, ManualIds) {
2857 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2858 io_delegate_.SetFileContents("IFoo.aidl",
2859 "interface IFoo {\n"
2860 " void foo() = 0;\n"
2861 " void bar() = 1;\n"
2862 "}");
2863 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2864}
2865
2866TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2867 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2868 io_delegate_.SetFileContents("IFoo.aidl",
2869 "interface IFoo {\n"
2870 " void foo() = 0;\n"
2871 " void bar() = 1;\n"
2872 "}");
2873 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2874}
2875
2876TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002877 const string expected_stderr =
2878 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002879 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2880 io_delegate_.SetFileContents("IFoo.aidl",
2881 "interface IFoo {\n"
2882 " void foo() = 3;\n"
2883 " void bar() = 3;\n"
2884 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002885 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002886 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002887 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002888}
2889
2890TEST_F(AidlTest, FailOnOutOfRangeIds) {
2891 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002892 const string expected_stderr =
2893 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2894 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002895 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2896 io_delegate_.SetFileContents("IFoo.aidl",
2897 "interface IFoo {\n"
2898 " void foo() = 3;\n"
2899 " void bar() = 16777115;\n"
2900 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002901 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002902 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002903 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002904}
2905
2906TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002907 const string expected_stderr =
2908 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002909 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2910 io_delegate_.SetFileContents("IFoo.aidl",
2911 "interface IFoo {\n"
2912 " void foo() = 3;\n"
2913 " void bar();\n"
2914 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002915 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002916 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002917 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002918}
2919
Jiyong Parkc6816252019-07-08 08:12:28 +09002920TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2921 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2922 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2923 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2924 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2925}
2926
2927TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002928 const string expected_stderr =
2929 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2930 "dir/IBar.aidl\n"
2931 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002932 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002933
Jiyong Parkc6816252019-07-08 08:12:28 +09002934 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2935 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2936 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2937 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002938 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002939 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002941}
2942
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002943TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2944 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2945 "package a.b;\n"
2946 "import a.b.IBar;\n"
2947 "import a.b.IQux;\n"
2948 "interface IFoo { IQux foo(); }\n");
2949 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2950 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2951
2952 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2953 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2954
2955 string output;
2956 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2957 // IBar was imported but wasn't used. include is not expected.
2958 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2959 // IBar was imported and used. include is expected.
2960 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2961}
2962
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002963TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002964 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002965 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002966 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2967 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002968 interface IFoo {
2969 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002970 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002971 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002972 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002973 // JavaPassthrough should work with other types as well (e.g. enum)
2974 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2975 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2976 @JavaPassthrough(annotation="@com.android.AliceTwo")
2977 @Backing(type="byte")
2978 enum MyEnum {
2979 a, b, c
2980 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002981
Jooyung Han4cde01d2020-10-13 11:10:47 +09002982 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002983 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2984
2985 string java_out;
2986 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002987 // type-decl-level annotations with newline at the end
2988 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2989 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2990 // member-decl-level annotations with newline at the end
2991 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2992 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2993 // inline annotations with space at the end
2994 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002995
Jooyung Han4cde01d2020-10-13 11:10:47 +09002996 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2997 // type-decl-level annotations with newline at the end
2998 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2999 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3000
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003001 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003002 Options cpp_options =
3003 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003004 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3005
Jooyung Han4cde01d2020-10-13 11:10:47 +09003006 Options ndk_options =
3007 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003008 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003009
Jooyung Han4cde01d2020-10-13 11:10:47 +09003010 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07003011 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003012}
3013
Andrei Homescue61feb52020-08-18 15:44:24 -07003014TEST_F(AidlTest, ParseRustDerive) {
3015 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3016 @RustDerive(Clone=true, Copy=false)
3017 parcelable Foo {
3018 int a;
3019 })");
3020
3021 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
3022 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
3023
3024 string rust_out;
3025 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3026 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3027
3028 // Other backends shouldn't be bothered
3029 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
3030 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3031
3032 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
3033 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
3034
3035 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
3036 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3037}
3038
Jiyong Park56f73d72019-06-11 12:20:28 +09003039class AidlOutputPathTest : public AidlTest {
3040 protected:
3041 void SetUp() override {
3042 AidlTest::SetUp();
3043 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3044 }
3045
3046 void Test(const Options& options, const std::string expected_output_path) {
3047 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3048 // check the existence
3049 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3050 }
3051};
3052
3053TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3054 // <out_dir> / <package_name> / <type_name>.java
3055 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3056}
3057
3058TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3059 // when output file is explicitly set, it is always respected. -o option is
3060 // ignored.
3061 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3062}
3063
3064TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3065 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3066}
3067
3068TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3069 // output is the same as the input file except for the suffix
3070 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3071}
3072
Devin Moore7b8d5c92020-03-17 14:14:08 -07003073TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003074 AidlError error;
3075 const string expected_stderr =
3076 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3077 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003078 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3079 R"(package p;
3080 interface IFoo {
3081 const int int32_max_oob = 2147483650;
3082 }
3083 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003084 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003085 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3086 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003087}
3088
Devin Moore7b8d5c92020-03-17 14:14:08 -07003089TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003090 AidlError error;
3091 const string expected_stderr =
3092 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3093 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003094 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3095 R"(package p;
3096 interface IFoo {
3097 const int int32_min_oob = -2147483650;
3098 }
3099 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003100 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003101 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3102 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003103}
3104
Devin Moore7b8d5c92020-03-17 14:14:08 -07003105TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003106 AidlError error;
3107 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003108 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003109 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003110 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3111 R"(package p;
3112 interface IFoo {
3113 const long int64_max_oob = 21474836509999999999999999;
3114 }
3115 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003116 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003117 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3118 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003119}
3120
Devin Moore7b8d5c92020-03-17 14:14:08 -07003121TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003122 AidlError error;
3123 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003124 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003125 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003126 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3127 R"(package p;
3128 interface IFoo {
3129 const long int64_min_oob = -21474836509999999999999999;
3130 }
3131 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003132 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3134 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003135}
3136
Devin Moore7b8d5c92020-03-17 14:14:08 -07003137TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003138 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003139 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003140 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003141 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3142 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003143 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3144 R"(package p;
3145 @Backing(type="byte")
3146 enum TestEnum {
3147 FOO = 127,
3148 BAR,
3149 }
3150 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003151 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003153 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003154}
3155
Devin Mooredecaf292020-04-30 09:16:40 -07003156TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3157 AidlError error;
3158 const string expected_stderr =
3159 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003160 "be one of: type\n";
3161 CaptureStderr();
3162 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3163 R"(package p;
3164 @Backing(foo="byte")
3165 enum TestEnum {
3166 FOO = 1,
3167 BAR,
3168 }
3169 )",
3170 typenames_, GetLanguage(), &error));
3171 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3172 EXPECT_EQ(AidlError::BAD_TYPE, error);
3173}
3174
Jooyung Han5721a232020-12-24 04:34:55 +09003175TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3176 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3177 CaptureStderr();
3178 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3179 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3180}
3181
Jooyung Han66813932020-10-23 13:24:44 +09003182TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003183 io_delegate_.SetFileContents("Foo.aidl",
3184 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3185 "Map<String, Baz> d; Bar[] e; }");
3186 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3187 io_delegate_.SetFileContents("Baz.aidl",
3188 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003189 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3190 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3191}
3192
Jooyung Han66813932020-10-23 13:24:44 +09003193TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003194 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003195 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003196 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003197 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3198 "named 'bar'.\n";
3199 CaptureStderr();
3200 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3201 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3202 EXPECT_EQ(expected_error, GetCapturedStderr());
3203}
3204
3205TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3206 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3207 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3208 string expected_error =
3209 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003210 "named 'bar'.\n";
3211 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003212 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3213 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003214 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003215}
3216
Jooyung Han66813932020-10-23 13:24:44 +09003217TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003218 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003219 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3220 string expected_error =
3221 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3222 "only be an in parameter.\n";
3223 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003224 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3225 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003226 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003227}
3228
Jooyung Han66813932020-10-23 13:24:44 +09003229TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003230 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003231 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3232 string expected_error =
3233 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3234 "only be an in parameter.\n";
3235 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003236 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3237 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003238 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003239}
3240
Jooyung Han66813932020-10-23 13:24:44 +09003241TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003242 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003243 Options options = Options::From("aidl --lang=java Foo.aidl");
3244 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003245 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3246 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003247 CaptureStderr();
3248 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3250}
Devin Moore53fc99c2020-08-12 08:07:52 -07003251
Jooyung Hanfe086af2021-01-16 03:44:47 +09003252TEST_P(AidlTest, UnionInUnion) {
3253 import_paths_.insert(".");
3254 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3255 CaptureStderr();
3256 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3257 EXPECT_THAT("", GetCapturedStderr());
3258}
3259
Jooyung Hanfe89f122020-10-14 03:49:18 +09003260TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3261 const string method = "package a; union Foo {}";
3262 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3263 CaptureStderr();
3264 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3265 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3266}
3267
3268TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3269 const string method = "package a; union Foo { ParcelableHolder x; }";
3270 const string expected_stderr =
3271 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3272 CaptureStderr();
3273 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3274 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3275}
3276
Jooyung Han53fb4242020-12-17 16:03:49 +09003277TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3278 import_paths_.insert(".");
3279 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3280 const string expected_err = "The union's first member should have a useful default value.";
3281 CaptureStderr();
3282 EXPECT_EQ(nullptr,
3283 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3284 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3285}
3286
Devin Moore53fc99c2020-08-12 08:07:52 -07003287TEST_P(AidlTest, GenericStructuredParcelable) {
3288 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003289 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003290 const string expected_stderr = "";
3291 CaptureStderr();
3292 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3293 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3294}
3295
Jooyung Han3f347ca2020-12-01 12:41:50 +09003296TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3297 io_delegate_.SetFileContents("Foo.aidl",
3298 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3299 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003300 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003301 const string expected_stderr = "";
3302 CaptureStderr();
3303 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3304 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3305
3306 string code;
3307 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3308 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3309const ::android::String16& Foo<T,U>::s() {
3310 static const ::android::String16 value(::android::String16(""));
3311 return value;
3312})--"));
3313}
3314
3315TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3316 io_delegate_.SetFileContents("Foo.aidl",
3317 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3318 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003319 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003320 const string expected_stderr = "";
3321 CaptureStderr();
3322 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3324
3325 string code;
3326 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3327 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3328const char* Foo<T, U>::s = "";
3329)--"));
3330}
3331
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003332TEST_F(AidlTest, NestedTypeArgs) {
3333 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003334 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3335
3336 io_delegate_.SetFileContents("a/Foo.aidl",
3337 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3338 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003339 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3340 const string expected_stderr = "";
3341 CaptureStderr();
3342 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3344
3345 string code;
3346 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003347 EXPECT_THAT(code,
3348 testing::HasSubstr(
3349 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3350}
3351
3352TEST_F(AidlTest, DoubleArrayError) {
3353 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3354
3355 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3356 const string expected_stderr =
3357 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3358 CaptureStderr();
3359 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3360 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3361}
3362
3363TEST_F(AidlTest, DoubleGenericError) {
3364 io_delegate_.SetFileContents("a/Bar.aidl",
3365 "package a; parcelable Bar { List<String><String> a; }");
3366
3367 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3368 const string expected_stderr =
3369 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3370 CaptureStderr();
3371 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3372 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3373}
3374
3375TEST_F(AidlTest, ArrayBeforeGenericError) {
3376 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3377
3378 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003379 CaptureStderr();
3380 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003381 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3382}
3383
3384TEST_F(AidlTest, NullableArraysAreNotSupported) {
3385 io_delegate_.SetFileContents("a/Bar.aidl",
3386 "package a; parcelable Bar { String @nullable [] a; }");
3387
3388 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3389 CaptureStderr();
3390 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3391 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3392}
3393
3394TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3395 io_delegate_.SetFileContents("a/Bar.aidl",
3396 "package a; parcelable Bar { List<@nullable String> a; }");
3397
3398 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3399 CaptureStderr();
3400 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3401 EXPECT_THAT(GetCapturedStderr(),
3402 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003403}
3404
Jooyung Han14004ed2020-10-16 03:49:57 +09003405struct GenericAidlTest : ::testing::Test {
3406 FakeIoDelegate io_delegate_;
3407 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003408 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003409 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3410 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3411 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3412
3413 Options options = Options::From(cmd);
3414 CaptureStderr();
3415 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3416 EXPECT_EQ("", GetCapturedStderr());
3417 }
3418};
3419
3420TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3421 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3422 string code;
3423 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3424 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3425 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3426 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3427}
3428
3429TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3430 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3431 string code;
3432 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3433 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3434 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3435 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3436}
3437
Devin Moore53fc99c2020-08-12 08:07:52 -07003438TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3439 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003440 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003441 const string expected_stderr =
3442 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3443 CaptureStderr();
3444 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3445 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3446}
3447
3448TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3449 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003450 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003451 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3452 CaptureStderr();
3453 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3455}
3456
Jooyung Han7a308842020-10-27 19:06:49 +09003457TEST_P(AidlTest, LongCommentWithinConstExpression) {
3458 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003459 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003460 CaptureStderr();
3461 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3462 EXPECT_EQ("", GetCapturedStderr());
3463}
3464
Jeongik Chaef44e622020-10-23 16:00:52 +09003465TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3466 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3467 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3468 std::string expectedErr =
3469 "ERROR: a/Foo.aidl:1.28-30: "
3470 "Encountered an untyped List or Map. The use of untyped List/Map is "
3471 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3472 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3473 "ERROR: a/Foo.aidl:1.35-37: "
3474 "Encountered an untyped List or Map. The use of untyped List/Map is "
3475 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3476 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3477 CaptureStderr();
3478 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3479 EXPECT_EQ(expectedErr, GetCapturedStderr());
3480}
3481
3482TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003483 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3484 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003485 std::string expectedErr =
3486 "ERROR: a/Foo.aidl:1.33-35: "
3487 "Encountered an untyped List or Map. The use of untyped List/Map is "
3488 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3489 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3490 "ERROR: a/Foo.aidl:1.40-42: "
3491 "Encountered an untyped List or Map. The use of untyped List/Map is "
3492 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3493 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003494 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003495 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3496 EXPECT_EQ(expectedErr, GetCapturedStderr());
3497}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003498
Jeongik Chaef44e622020-10-23 16:00:52 +09003499TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3500 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3501 io_delegate_.SetFileContents(
3502 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3503 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3504 std::string expectedErr =
3505 "ERROR: a/Foo.aidl:1.52-54: "
3506 "Encountered an untyped List or Map. The use of untyped List/Map is "
3507 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3508 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3509 "ERROR: a/Foo.aidl:1.64-66: "
3510 "Encountered an untyped List or Map. The use of untyped List/Map is "
3511 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3512 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3513 CaptureStderr();
3514 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3515 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003516}
3517
Jooyung Han690f5842020-12-04 13:02:04 +09003518TEST_F(AidlTest, EnumWithDefaults_Java) {
3519 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3520 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3521package p;
3522import p.Enum;
3523parcelable Foo {
3524 Enum e = Enum.BAR;
3525})");
3526 CaptureStderr();
3527 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3528 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3529 auto err = GetCapturedStderr();
3530 EXPECT_EQ("", err);
3531
3532 string code;
3533 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003534 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003535}
3536
3537TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3538 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3539 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3540package p;
3541import p.Enum;
3542parcelable Foo {
3543 Enum e = Enum.BAR;
3544})");
3545 CaptureStderr();
3546 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3547 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3548 auto err = GetCapturedStderr();
3549 EXPECT_EQ("", err);
3550
3551 string code;
3552 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3553 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3554}
3555
3556TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3557 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3558 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3559package p;
3560import p.Enum;
3561parcelable Foo {
3562 Enum e = Enum.BAR;
3563})");
3564 CaptureStderr();
3565 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3566 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3567 auto err = GetCapturedStderr();
3568 EXPECT_EQ("", err);
3569
3570 string code;
3571 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3572 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3573}
3574
3575TEST_F(AidlTest, EnumWithDefaults_Rust) {
3576 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3577 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3578package p;
3579import p.Enum;
3580parcelable Foo {
3581 int n = 42;
3582 Enum e = Enum.BAR;
3583})");
3584 CaptureStderr();
3585 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3586 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3587 auto err = GetCapturedStderr();
3588 EXPECT_EQ("", err);
3589
3590 string code;
3591 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3592 EXPECT_THAT(code, testing::HasSubstr(R"(
3593 fn default() -> Self {
3594 Self {
3595 n: 42,
3596 e: crate::mangled::_1_p_4_Enum::BAR,
3597 }
3598 })"));
3599}
3600
3601TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3602 import_paths_.insert("a");
3603 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3604 CaptureStderr();
3605 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3606package p;
3607import p.Enum;
3608parcelable Foo {
3609 int e = Enum.FOO | Enum.BAR;
3610})",
3611 typenames_, GetLanguage());
3612 auto err = GetCapturedStderr();
3613 EXPECT_EQ("", err);
3614 EXPECT_TRUE(type);
3615 const auto& fields = type->AsStructuredParcelable()->GetFields();
3616 EXPECT_EQ("int e = 3", fields[0]->ToString());
3617}
3618
3619TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3620 CaptureStderr();
3621 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3622@Backing(type="int")
3623enum Foo {
3624 STANDARD_SHIFT = 16,
3625 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3626 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3627}
3628)",
3629 typenames_, GetLanguage());
3630 auto err = GetCapturedStderr();
3631 EXPECT_EQ("", err);
3632 EXPECT_TRUE(type);
3633 const auto& enum_type = type->AsEnumDeclaration();
3634 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003635 auto writer = CodeWriter::ForString(&code);
3636 DumpVisitor visitor(*writer);
3637 visitor.Visit(*enum_type);
3638 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003639 EXPECT_EQ(R"--(@Backing(type="int")
3640enum Foo {
3641 STANDARD_SHIFT = 16,
3642 STANDARD_BT709 = 65536,
3643 STANDARD_BT601_625 = 131072,
3644}
3645)--",
3646 code);
3647}
3648
3649TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3650 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3651 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3652package p;
3653import p.Enum;
3654parcelable Foo {
3655 Enum e = Enum.FOO | Enum.BAR;
3656})");
3657 CaptureStderr();
3658 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3659 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3660 auto err = GetCapturedStderr();
3661 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3662 err);
3663}
3664
3665TEST_P(AidlTest, DefaultWithEmptyArray) {
3666 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3667 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3668 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003669 auto options =
3670 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003671 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3672 auto err = GetCapturedStderr();
3673 EXPECT_EQ("", err);
3674}
3675
3676TEST_P(AidlTest, RejectRefsInAnnotation) {
3677 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3678 "package p; interface IFoo {\n"
3679 " const String ANNOTATION = \"@Annotation\";\n"
3680 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3681 "}");
3682 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003683 auto options =
3684 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003685 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3686 auto err = GetCapturedStderr();
3687 EXPECT_EQ(
3688 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3689 "ANNOTATION.\n",
3690 err);
3691}
3692
3693TEST_F(AidlTest, DefaultWithEnumValues) {
3694 io_delegate_.SetFileContents(
3695 "a/p/Foo.aidl",
3696 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3697 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3698 CaptureStderr();
3699 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3700 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3701 auto err = GetCapturedStderr();
3702 EXPECT_EQ("", err);
3703 string code;
3704 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3705 EXPECT_THAT(
3706 code, testing::HasSubstr(
3707 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3708}
3709
Jooyung Han14259392020-12-07 10:00:08 +09003710TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3711 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3712 CaptureStderr();
3713 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3714 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3715 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003716 EXPECT_EQ(
3717 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
3718 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
3719 err);
Jooyung Han14259392020-12-07 10:00:08 +09003720}
3721
3722TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3723 io_delegate_.SetFileContents("a/p/Foo.aidl",
3724 "package p; parcelable Foo { const int A = A + 1; }");
3725 CaptureStderr();
3726 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3727 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3728 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003729 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3730}
3731
3732TEST_F(AidlTest, RecursiveReferences) {
3733 io_delegate_.SetFileContents("a/p/Foo.aidl",
3734 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3735 io_delegate_.SetFileContents("a/p/Bar.aidl",
3736 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3737 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3738 CaptureStderr();
3739 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3740 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3741 EXPECT_EQ("", GetCapturedStderr());
3742}
3743
Jooyung Hane9f5b272021-01-07 00:18:11 +09003744TEST_P(AidlTest, UnknownConstReference) {
3745 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3746 auto options =
3747 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3748 const string err =
3749 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3750 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3751 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3752 CaptureStderr();
3753 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3754 EXPECT_EQ(err, GetCapturedStderr());
3755}
3756
Jooyung Han29813842020-12-08 01:28:03 +09003757TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3758 string contents = R"(
3759import android.os.IBinder;
3760import android.os.IInterface;
3761interface IFoo {}
3762 )";
3763 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003764}
3765
Jooyung Han888c5bc2020-12-22 17:28:47 +09003766TEST_P(AidlTest, WarningInterfaceName) {
3767 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003768 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003769 " -Weverything -o out -h out p/Foo.aidl");
3770 CaptureStderr();
3771 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003772 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003773 GetCapturedStderr());
3774}
3775
3776TEST_P(AidlTest, ErrorInterfaceName) {
3777 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003778 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003779 " -Weverything -Werror -o out -h out p/Foo.aidl");
3780 CaptureStderr();
3781 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003782 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003783 GetCapturedStderr());
3784}
3785
Jiyong Park9f4c3822021-04-07 20:36:45 +09003786TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
3787 const std::string input_file = "base/p/q/IFoo.aidl";
3788 const std::string header_dir = "out/";
3789 const std::string output_file = "out/base/p/q/IFoo.cpp";
3790 const std::string package = "p.q"; // not base.p.q
3791 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
3792
3793 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
3794 CaptureStderr();
3795 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3796 EXPECT_THAT(
3797 GetCapturedStderr(),
3798 testing::StartsWith(
3799 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
3800 "but is out/base/p/q/IFoo.cpp."));
3801}
3802
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09003803TEST_F(AidlTest, FormatCommentsForJava) {
3804 using android::aidl::FormatCommentsForJava;
3805
3806 struct TestCase {
3807 vector<Comment> comments;
3808 string formatted;
3809 };
3810 vector<TestCase> testcases = {
3811 {{}, ""},
3812 {{{"// line comments\n"}}, "// line comments\n"},
3813 {{{"// @hide \n"}}, "// @hide \n"},
3814 // Transform the last block comment as Javadoc.
3815 {{{"/*\n"
3816 " * Hello, world!\n"
3817 " */"}},
3818 "/**\n"
3819 " * Hello, world!\n"
3820 " */"},
3821 {{{"/* @hide */"}}, "/** @hide */"},
3822 {{{"/**\n"
3823 " @param foo ...\n"
3824 "*/"}},
3825 "/**\n"
3826 " @param foo ...\n"
3827 "*/"},
3828 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
3829 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
3830 "/* @deprecated first *//** @deprecated second */"},
3831 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
3832 // Line comments are printed as they are
3833 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
3834 };
3835 for (const auto& [input, formatted] : testcases) {
3836 EXPECT_EQ(formatted, FormatCommentsForJava(input));
3837 }
3838}
3839
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003840TEST_F(AidlTest, HideIsNotForArgs) {
3841 io_delegate_.SetFileContents("IFoo.aidl",
3842 "interface IFoo {\n"
3843 " void foo(in @Hide int x);\n"
3844 "}");
3845 auto options = Options::From("aidl --lang=java IFoo.aidl");
3846 CaptureStderr();
3847 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3848 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3849}
3850
3851TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3852 io_delegate_.SetFileContents(
3853 "IFoo.aidl",
3854 "interface IFoo {\n"
3855 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3856 "}");
3857 auto options = Options::From("aidl --lang=java IFoo.aidl");
3858 CaptureStderr();
3859 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3860 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3861}
3862
Jooyung Hanfd3be322020-12-13 09:11:06 +09003863struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003864 string kind;
3865 string literal;
3866};
3867
Jooyung Hanfd3be322020-12-13 09:11:06 +09003868const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09003869 {"primitive", "int"}, {"primitiveArray", "int[]"},
3870 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003871 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3872 {"parcelable", "Foo"}, {"enum", "a.Enum"},
3873 {"union", "a.Union"}, {"interface", "a.IBar"},
3874};
3875
3876const std::map<std::string, std::string> kListSupportExpectations = {
3877 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
3878 {"java_primitive", "A generic type cannot have any primitive type parameters."},
3879 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
3880 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09003881 {"cpp_primitiveArray", "List of arrays is not supported."},
3882 {"java_primitiveArray", "List of arrays is not supported."},
3883 {"ndk_primitiveArray", "List of arrays is not supported."},
3884 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003885 {"cpp_String", ""},
3886 {"java_String", ""},
3887 {"ndk_String", ""},
3888 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09003889 {"cpp_StringArray", "List of arrays is not supported."},
3890 {"java_StringArray", "List of arrays is not supported."},
3891 {"ndk_StringArray", "List of arrays is not supported."},
3892 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003893 {"cpp_IBinder", ""},
3894 {"java_IBinder", ""},
3895 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
3896 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003897 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003898 {"java_ParcelFileDescriptor", ""},
3899 {"ndk_ParcelFileDescriptor", ""},
3900 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003901 {"cpp_interface", "List<a.IBar> is not supported."},
3902 {"java_interface", "List<a.IBar> is not supported."},
3903 {"ndk_interface", "List<a.IBar> is not supported."},
3904 {"rust_interface", "List<a.IBar> is not supported."},
3905 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003906 {"java_parcelable", ""},
3907 {"ndk_parcelable", ""},
3908 {"rust_parcelable", ""},
3909 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
3910 {"java_enum", "A generic type cannot have any primitive type parameters."},
3911 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
3912 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09003913 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003914 {"java_union", ""},
3915 {"ndk_union", ""},
3916 {"rust_union", ""},
3917};
3918
Jooyung Hand236e552020-12-13 09:21:27 +09003919const std::map<std::string, std::string> kArraySupportExpectations = {
3920 {"cpp_primitive", ""},
3921 {"java_primitive", ""},
3922 {"ndk_primitive", ""},
3923 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09003924 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
3925 {"java_primitiveArray", "Can only have one dimensional arrays."},
3926 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
3927 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09003928 {"cpp_String", ""},
3929 {"java_String", ""},
3930 {"ndk_String", ""},
3931 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09003932 {"cpp_StringArray", "Can only have one dimensional arrays."},
3933 {"java_StringArray", "Can only have one dimensional arrays."},
3934 {"ndk_StringArray", "Can only have one dimensional arrays."},
3935 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09003936 {"cpp_IBinder", ""},
3937 {"java_IBinder", ""},
3938 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
3939 {"rust_IBinder", "The rust backend does not support array of IBinder"},
3940 {"cpp_ParcelFileDescriptor", ""},
3941 {"java_ParcelFileDescriptor", ""},
3942 {"ndk_ParcelFileDescriptor", ""},
3943 {"rust_ParcelFileDescriptor", ""},
3944 {"cpp_interface", "Binder type cannot be an array"},
3945 {"java_interface", "Binder type cannot be an array"},
3946 {"ndk_interface", "Binder type cannot be an array"},
3947 {"rust_interface", "Binder type cannot be an array"},
3948 {"cpp_parcelable", ""},
3949 {"java_parcelable", ""},
3950 {"ndk_parcelable", ""},
3951 {"rust_parcelable", ""},
3952 {"cpp_enum", ""},
3953 {"java_enum", ""},
3954 {"ndk_enum", ""},
3955 {"rust_enum", ""},
3956 {"cpp_union", ""},
3957 {"java_union", ""},
3958 {"ndk_union", ""},
3959 {"rust_union", ""},
3960};
3961
Jooyung Hanfd3be322020-12-13 09:11:06 +09003962class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003963 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09003964 void Run(const std::string& generic_type_decl,
3965 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003966 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003967 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09003968 const auto& kind = std::get<1>(param).kind;
3969
3970 FakeIoDelegate io;
3971 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
3972 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
3973 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09003974 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
3975 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09003976
3977 const auto options =
3978 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
3979 CaptureStderr();
3980 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09003981 auto it = expectations.find(lang + "_" + kind);
3982 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09003983 const string err = GetCapturedStderr();
3984 if (it->second.empty()) {
3985 EXPECT_EQ("", err);
3986 } else {
3987 EXPECT_THAT(err, testing::HasSubstr(it->second));
3988 }
3989 }
3990};
3991
3992INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09003993 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09003994 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
3995 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09003996 testing::ValuesIn(kTypeParams)),
3997 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09003998 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09003999 });
4000
Jooyung Hanfd3be322020-12-13 09:11:06 +09004001TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4002 Run("List<{}>", kListSupportExpectations);
4003}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004004
Jooyung Hand236e552020-12-13 09:21:27 +09004005TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4006 Run("{}[]", kArraySupportExpectations);
4007}
4008
Christopher Wiley90be4e32015-10-20 14:55:25 -07004009} // namespace aidl
4010} // namespace android