blob: 81931a1da9511ac7fce313c2a6af0cb890c5861c [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070038#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070039
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090040using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070041using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080042using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090043using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045using std::string;
46using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080047using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090048using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070049using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090050using testing::internal::CaptureStderr;
51using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070052
53namespace android {
54namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070055namespace {
56
57const char kExpectedDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60
61p/IFoo.aidl :
62)";
63
Dan Willemsen93298ee2016-11-10 23:55:55 -080064const char kExpectedNinjaDepFileContents[] =
65R"(place/for/output/p/IFoo.java : \
66 p/IFoo.aidl
67)";
68
Jiyong Parkdf202122019-09-30 20:48:35 +090069const char kExpectedParcelableDeclarationDepFileContents[] =
70 R"( : \
71 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
76const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080077 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070078 p/Foo.aidl
79
80p/Foo.aidl :
81)";
82
Christopher Wileyf8136192016-04-12 14:19:35 -070083} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070084
Devin Moore7b8d5c92020-03-17 14:14:08 -070085class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070086 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090087 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
88 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070089 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070090 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090091 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070092 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090093 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070094 for (const string& s : additional_arguments) {
95 args.emplace_back(s);
96 }
97 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090098 args.emplace_back("--preprocessed=" + f);
99 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700100 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--include=" + i);
102 }
103 args.emplace_back(path);
104 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900105 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900106 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700107 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900108 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900109
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 if (error != nullptr) {
111 *error = actual_error;
112 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900113
114 if (actual_error != AidlError::OK) {
115 return nullptr;
116 }
117
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900118 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900119 EXPECT_EQ(1ul, defined_types.size());
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700122 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700123
Devin Moore7b8d5c92020-03-17 14:14:08 -0700124 Options::Language GetLanguage() { return GetParam(); }
125
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800127 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900128 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900129 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700130};
131
Devin Moore7b8d5c92020-03-17 14:14:08 -0700132// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
133// tests with each of the supported languages as a parameter.
134INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
135 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700136 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700137 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900138 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700139 });
140
141TEST_P(AidlTest, AcceptMissingPackage) {
142 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700143}
144
Devin Moore7b8d5c92020-03-17 14:14:08 -0700145TEST_P(AidlTest, EndsInSingleLineComment) {
146 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700147}
148
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000149TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
150 const string expected_stderr =
151 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
152 const std::string file_contents = "package a; interface IBar {}";
153 CaptureStderr();
154 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
155 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
156}
157
158TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
159 const string expected_stderr =
160 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
161 const std::string file_contents = "package a; interface Bar {}";
162 CaptureStderr();
163 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
164 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
165}
166
167TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
168 const string expected_stderr =
169 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
170 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
171 CaptureStderr();
172 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
173 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
174}
175
176TEST_P(AidlTest, EnumRequiresCorrectPath) {
177 const string expected_stderr =
178 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
179 const std::string file_contents = "package a; enum Bar { A, }";
180 CaptureStderr();
181 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
182 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
183}
184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900186 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700187 io_delegate_.SetFileContents("bar/IBar.aidl",
188 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700189 const string path = "foo/IFoo.aidl";
190 const string contents =
191 "package foo;\n"
192 "import bar.IBar;\n"
193 "interface IFoo { void f(in IBar[] input); }";
194 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
195 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700196 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700198}
199
Devin Moore7b8d5c92020-03-17 14:14:08 -0700200TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700201 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700202 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900203}
Devin Moore097a3ab2020-03-11 16:08:44 -0700204
Jiyong Park40782d02020-07-24 19:17:43 +0900205TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700206 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
207 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900208 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
209 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700210 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700212 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900213}
214
Jiyong Park40782d02020-07-24 19:17:43 +0900215TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900216 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700217 const string expected_stderr =
218 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700219 CaptureStderr();
220 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900222}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700223
Jiyong Park40782d02020-07-24 19:17:43 +0900224TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900225 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900226 const string expected_stderr =
227 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700228 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700229 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700231}
232
Devin Moore7b8d5c92020-03-17 14:14:08 -0700233TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700234 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
235 const string expected_stderr =
236 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
237 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700238 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700240}
241
Devin Moore7b8d5c92020-03-17 14:14:08 -0700242TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700243 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
244 const string expected_stderr =
245 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
246 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700247 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800249}
250
Devin Moore2f2077a2020-08-28 11:27:53 -0700251TEST_P(AidlTest, AcceptNullableList) {
252 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
253 const string expected_stderr = "";
254 CaptureStderr();
255 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
257}
258
Devin Moore7b8d5c92020-03-17 14:14:08 -0700259TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700260 const string method = "package a; interface IFoo { void f(int a, int a); }";
261 const string expected_stderr =
262 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
263 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700264 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700266}
267
Jeongik Cha13066da2020-08-06 15:43:19 +0900268TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
269 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900270 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
274}
275
Jooyung Hand902a972020-10-23 17:32:44 +0900276TEST_P(AidlTest, RejectsRepeatedAnnotations) {
277 const string method = R"(@Hide @Hide parcelable Foo {})";
278 const string expected_stderr =
279 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
280 "Foo.aidl:1.1-6\n";
281 CaptureStderr();
282 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
283 EXPECT_EQ(expected_stderr, GetCapturedStderr());
284}
285
Jooyung Han05bd8a82021-04-28 23:56:38 +0900286TEST_P(AidlTest, AcceptsEmptyParcelable) {
287 CaptureStderr();
288 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
289 EXPECT_EQ("", GetCapturedStderr());
290}
291
Devin Moore7b8d5c92020-03-17 14:14:08 -0700292TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700293 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
294 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700297 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100298}
299
Devin Moore7b8d5c92020-03-17 14:14:08 -0700300TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700301 AidlError error;
302 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700303 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700304 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900305 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700306 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800307}
308
Devin Moore7b8d5c92020-03-17 14:14:08 -0700309TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700310 AidlError error;
311 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700312 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700313 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700315 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800316}
317
Devin Moore7b8d5c92020-03-17 14:14:08 -0700318TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700319 AidlError error;
320 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700321 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000322 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900323 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700324 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800325}
326
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700328 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000329 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700330 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000331 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900332 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700333 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800334}
335
Jiyong Park40782d02020-07-24 19:17:43 +0900336TEST_P(AidlTest, ParsesNonNullableAnnotation) {
337 auto parse_result =
338 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
339 ASSERT_NE(nullptr, parse_result);
340 const AidlInterface* interface = parse_result->AsInterface();
341 ASSERT_NE(nullptr, interface);
342 ASSERT_FALSE(interface->GetMethods().empty());
343 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
344}
345
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900347 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
348 typenames_, GetLanguage());
349 ASSERT_NE(nullptr, parse_result);
350 const AidlInterface* interface = parse_result->AsInterface();
351 ASSERT_NE(nullptr, interface);
352 ASSERT_FALSE(interface->GetMethods().empty());
353 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
354}
355
356TEST_P(AidlTest, ParsesNonUtf8Annotations) {
357 auto parse_result =
358 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
359 ASSERT_NE(nullptr, parse_result);
360 const AidlInterface* interface = parse_result->AsInterface();
361 ASSERT_NE(nullptr, interface);
362 ASSERT_FALSE(interface->GetMethods().empty());
363 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800364}
365
Devin Moore7b8d5c92020-03-17 14:14:08 -0700366TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900367 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
368 typenames_, GetLanguage());
369 ASSERT_NE(nullptr, parse_result);
370 const AidlInterface* interface = parse_result->AsInterface();
371 ASSERT_NE(nullptr, interface);
372 ASSERT_FALSE(interface->GetMethods().empty());
373 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700377 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700378 const string expected_stderr =
379 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
380 "\"vintf\"'\n"
381 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
382 "--structured\n";
383 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700384 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700386 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700387 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700388}
389
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700391 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700392 const string expected_stderr =
393 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
394 "--structured\n";
395 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700396 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700397 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700399 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700400}
401
Devin Moore7b8d5c92020-03-17 14:14:08 -0700402TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700403 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700404 const string expected_stderr =
405 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
406 "\"vintf\"'\n";
407 CaptureStderr();
408 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700409 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700411 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700412}
413
Devin Moore7b8d5c92020-03-17 14:14:08 -0700414TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700415 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
417 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700418 ASSERT_EQ(AidlError::OK, error);
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700423}
424
Jeongik Cha64783ed2019-06-07 18:30:54 +0900425TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
426 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900427 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
428 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900429 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700430 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900431 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900432 "a/Foo.aidl",
433 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900434
435 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900436 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700437 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900438 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700439 "Parcelable must be defined in AIDL directly.\n";
440 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900441 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700443
444 CaptureStderr();
445 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900447}
448
Jooyung Han1cbc4962020-10-25 10:07:15 +0900449TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
450 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
451 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
452 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900453 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
454
455 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900456 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900457 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
458
459 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900460 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900461 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
462
Jooyung Han1cbc4962020-10-25 10:07:15 +0900463 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900464 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
465}
466
Jooyung Han1cbc4962020-10-25 10:07:15 +0900467TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
468 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
469 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
470 CaptureStderr();
471 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
472 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
473 EXPECT_EQ("", GetCapturedStderr());
474
475 const string expected_to_string_method = R"--(
476 @Override
477 public String toString() {
478 switch (_tag) {
479 case a: return "a.Foo.a(" + (getA()) + ")";
480 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
481 }
482 throw new IllegalStateException("unknown field: " + _tag);
483 }
484)--";
485
486 string java_out;
487 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
488 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
489}
490
Jiyong Park9aa3d042020-12-04 23:30:02 +0900491TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
492 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
493 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
494 CaptureStderr();
495 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
496 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
497 EXPECT_EQ("", GetCapturedStderr());
498
499 const std::string expected = R"--(
500 @Override
501 public boolean equals(Object other) {
502 if (this == other) return true;
503 if (other == null) return false;
504 if (!(other instanceof Foo)) return false;
505 Foo that = (Foo)other;
506 if (!java.util.Objects.deepEquals(a, that.a)) return false;
507 if (!java.util.Objects.deepEquals(b, that.b)) return false;
508 return true;
509 }
510
511 @Override
512 public int hashCode() {
513 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
514 }
515)--";
516
517 string java_out;
518 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
519 EXPECT_THAT(java_out, testing::HasSubstr(expected));
520}
521
522TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
523 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
524 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
525 CaptureStderr();
526 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
527 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
528 EXPECT_EQ("", GetCapturedStderr());
529
530 const std::string expected = R"--(
531 @Override
532 public boolean equals(Object other) {
533 if (this == other) return true;
534 if (other == null) return false;
535 if (!(other instanceof Foo)) return false;
536 Foo that = (Foo)other;
537 if (_tag != that._tag) return false;
538 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
539 return true;
540 }
541
542 @Override
543 public int hashCode() {
544 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
545 }
546)--";
547
548 string java_out;
549 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
550 EXPECT_THAT(java_out, testing::HasSubstr(expected));
551}
552
Jooyung Han90345002020-10-23 15:28:53 +0900553TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900554 {
Jooyung Han90345002020-10-23 15:28:53 +0900555 io_delegate_.SetFileContents("a/Foo.aidl",
556 "package a; @JavaDerive(blah=true) parcelable Foo{}");
557 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
558 CaptureStderr();
559 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
560 const std::string expected_stderr =
561 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900562 EXPECT_THAT(GetCapturedStderr(),
563 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900564 }
565
566 {
567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900571 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900572 }
573
574 {
Jooyung Han90345002020-10-23 15:28:53 +0900575 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900576 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
577 CaptureStderr();
578 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900579 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900580 }
581}
582
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900583TEST_P(AidlTest, ParseDescriptorAnnotation) {
584 AidlError error;
585 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
586 typenames_, GetLanguage(), &error, {"--structured"});
587 ASSERT_EQ(AidlError::OK, error);
588 ASSERT_NE(nullptr, parse_result);
589 const AidlInterface* interface = parse_result->AsInterface();
590 ASSERT_NE(nullptr, interface);
591 ASSERT_EQ("IBar", interface->GetDescriptor());
592}
593
Jiyong Park40782d02020-07-24 19:17:43 +0900594TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700595 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700596 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900597}
598
599TEST_P(AidlTest, AcceptsOnewayInterface) {
600 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700601 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700602}
Christopher Wileyef140932015-11-03 09:29:19 -0800603
Devin Moore7b8d5c92020-03-17 14:14:08 -0700604TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700605 const string oneway_method =
606 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700607 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100608}
609
Steven Moreland65297cc2020-04-20 20:17:36 -0700610TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
611 const string oneway_method =
612 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
613 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
614 ASSERT_NE(nullptr, defined);
615 const AidlInterface* iface = defined->AsInterface();
616 ASSERT_NE(nullptr, iface);
617
618 const auto& methods = iface->GetMethods();
619 ASSERT_EQ(1u, methods.size());
620 const auto& method = methods[0];
621 const AidlTypeSpecifier& ret_type = method->GetType();
622
623 // TODO(b/151102494): these annotations should be on the method
624 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
625 ASSERT_TRUE(ret_type.IsHide());
626}
627
Devin Moore7b8d5c92020-03-17 14:14:08 -0700628TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100629 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900630 R"(package a;
631 /* foo */
632 interface IFoo {
633 /* i */
634 int i();
635 // j
636 @nullable String j();
637 // k1
638 /* k2 */
639 @UnsupportedAppUsage oneway void k(int a);
640 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100641
Jooyung Han8451a202021-01-16 03:07:06 +0900642 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700643 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100644 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900645 EXPECT_EQ("", GetCapturedStderr());
646
Jooyung Han161bb0f2021-01-21 12:30:16 +0900647 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100648
649 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900650 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
651 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
652 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100653}
654
Jooyung Han1a551d32020-10-05 15:37:26 +0900655TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
656 io_delegate_.SetFileContents("p/cpp_header.aidl",
657 R"(package p;
658 parcelable cpp_header cpp_header "bar/header";)");
659 import_paths_.emplace("");
660 const string input_path = "p/IFoo.aidl";
661 const string input = R"(package p;
662 import p.cpp_header;
663 interface IFoo {
664 // get bar
665 cpp_header get();
666 })";
667
668 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
669 EXPECT_NE(nullptr, parse_result);
670 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900671 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900672}
673
Christopher Wileyef140932015-11-03 09:29:19 -0800674TEST_F(AidlTest, ParsesPreprocessedFile) {
675 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
676 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700677 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900678 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700679 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
680 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800681}
682
683TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
684 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
685 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900686
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700687 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900688 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700689 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
690 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800691}
692
Devin Moore7b8d5c92020-03-17 14:14:08 -0700693TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800694 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
695 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
696 "interface IBar {}");
697 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900698 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900699 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700700 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800701 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900702
Christopher Wiley41544372015-11-03 14:52:29 -0800703 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700704 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
705 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800706 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900707 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900708 ambiguous_type.Resolve(typenames_);
709 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800710}
711
Jiyong Park8f6ec462020-01-19 20:52:47 +0900712// Special case of PreferImportToPreprocessed. Imported type should be preferred
713// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700714TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900715 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
716 io_delegate_.SetFileContents("one/IBar.aidl",
717 "package one; "
718 "interface IBar {}");
719 preprocessed_files_.push_back("preprocessed");
720 import_paths_.emplace("");
721 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700722 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900723 EXPECT_NE(nullptr, parse_result);
724
725 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700726 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
727 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900728 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900729 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900730 ambiguous_type.Resolve(typenames_);
731 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
732}
733
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800734TEST_F(AidlTest, WritePreprocessedFile) {
735 io_delegate_.SetFileContents("p/Outer.aidl",
736 "package p; parcelable Outer.Inner;");
737 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
738 "interface IBar {}");
739
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900740 vector<string> args {
741 "aidl",
742 "--preprocess",
743 "preprocessed",
744 "p/Outer.aidl",
745 "one/IBar.aidl"};
746 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800747 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
748
749 string output;
750 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
751 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
752}
753
Jooyung Han720253d2021-01-05 19:13:17 +0900754TEST_P(AidlTest, SupportDeprecated) {
755 struct TestCase {
756 std::string output_file;
757 std::string annotation;
758 };
759
760 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900761 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900762 io_delegate_.SetFileContents(filename, contents);
763
764 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
765 " --out=out --header_out=out");
766 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900767 for (const auto& [lang, test_case] : expectations) {
768 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900769 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900770 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900771 EXPECT_THAT(output, HasSubstr(test_case.annotation));
772 }
773 };
774
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900775 // Emit escaped string for notes
776 CheckDeprecated(
777 "IFoo.aidl",
778 R"(interface IFoo {
779 /**
780 * @note asdf
781 * @deprecated a really long deprecation message
782 *
783 * which is really long
784 * @param foo bar
785 */
786 List<String> foo();
787 })",
788 {
789 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
790 {Options::Language::CPP,
791 {"out/IFoo.h",
792 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
793 {Options::Language::NDK,
794 {"out/aidl/IFoo.h",
795 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
796 {Options::Language::RUST,
797 {"out/IFoo.rs",
798 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
799 });
800
Jooyung Han24effbf2021-01-16 10:24:03 +0900801 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900802 CheckDeprecated(
803 "IFoo.aidl",
804 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900805 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900806 " List<String> foo();\n"
807 "}",
808 {
809 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900810 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900811 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
812 {Options::Language::NDK,
813 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
814 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
815 });
Jooyung Han720253d2021-01-05 19:13:17 +0900816
Jooyung Han24effbf2021-01-16 10:24:03 +0900817 // but not in line comments
818 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
819 EXPECT_FALSE(parsed->IsDeprecated());
820
821 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900822 CheckDeprecated("Foo.aidl",
823 "parcelable Foo {\n"
824 " /** @deprecated use bar*/\n"
825 " int foo = 0;\n"
826 "}",
827 {
828 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
829 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
830 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
831 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
832 });
833
Jooyung Han24effbf2021-01-16 10:24:03 +0900834 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900835 CheckDeprecated("IFoo.aidl",
836 "interface IFoo {\n"
837 " /** @deprecated use bar*/\n"
838 " const int FOO = 0;\n"
839 "}",
840 {
841 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
842 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
843 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
844 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
845 });
846
847 // union fields
848 CheckDeprecated("Foo.aidl",
849 "union Foo {\n"
850 " int bar = 0;\n"
851 " /** @deprecated use bar*/\n"
852 " int foo;\n"
853 "}",
854 {
855 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
856 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
857 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
858 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
859 });
860
861 CheckDeprecated("Foo.aidl",
862 "/** @deprecated use Bar */\n"
863 "parcelable Foo {}",
864 {
865 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
866 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
867 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
868 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
869 });
870
871 CheckDeprecated("Foo.aidl",
872 "/** @deprecated use Bar */\n"
873 "union Foo { int foo = 0; }",
874 {
875 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
876 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
877 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
878 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
879 });
880
881 CheckDeprecated("IFoo.aidl",
882 "/** @deprecated use IBar */\n"
883 "interface IFoo {}",
884 {
885 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
886 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
887 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
888 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
889 });
890
891 CheckDeprecated("Foo.aidl",
892 "/** @deprecated use IBar */\n"
893 "enum Foo { FOO }",
894 {
895 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
896 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
897 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900898 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +0900899 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
900 });
901}
902
Devin Moore7b8d5c92020-03-17 14:14:08 -0700903TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700904 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800905 io_delegate_.SetFileContents("p/Outer.aidl",
906 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900907 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700908 CaptureStderr();
909 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
910 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700911 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800913}
914
Devin Moore7b8d5c92020-03-17 14:14:08 -0700915TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800916 io_delegate_.SetFileContents("preprocessed",
917 "parcelable p.Outer.Inner;");
918 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900919 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700920 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800921 // TODO(wiley): This should actually return nullptr because we require
922 // the outer class name. However, for legacy reasons,
923 // this behavior must be maintained. b/17415692
924 EXPECT_NE(nullptr, parse_result);
925}
926
Christopher Wiley632801d2015-11-05 14:15:49 -0800927TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700928 const string expected_foo_stderr =
929 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
930 "Declared parcelables should be in their own file and/or cannot be used with --structured "
931 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700932 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
933
Christopher Wiley632801d2015-11-05 14:15:49 -0800934 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700935 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900937 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700938 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900939
Steven Morelande2c64b42018-09-18 15:06:37 -0700940 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900941 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900943 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700944 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700945
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 const string expected_bar_stderr =
947 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
948 "Declared parcelables should be in their own file and/or cannot be used with --structured "
949 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700950 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
951
Jiyong Parkda8c6932019-08-12 19:56:08 +0900952 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700953 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900955 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700957 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700959 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700960 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800961}
962
Devin Moore7b8d5c92020-03-17 14:14:08 -0700963TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +0900965 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700967 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
968 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 AidlError error;
970 CaptureStderr();
971 EXPECT_EQ(
972 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700973 Parse("p/IFoo.aidl",
974 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700975 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700976 EXPECT_EQ(expected_stderr, GetCapturedStderr());
977 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700978}
979
Devin Moore7b8d5c92020-03-17 14:14:08 -0700980TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700981 AidlError error;
982 const string expected_stderr =
983 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
984 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900985 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
986 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700987 interface IFoo {
988 const String DUPLICATED = "d";
989 const int DUPLICATED = 1;
990 }
991 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700992 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
994 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700995}
996
Steven Morelande689da22020-11-10 02:06:30 +0000997TEST_P(AidlTest, FailOnTooBigConstant) {
998 AidlError error;
999 const string expected_stderr =
1000 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1001 CaptureStderr();
1002 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1003 R"(package p;
1004 interface IFoo {
1005 const byte type2small = 256;
1006 }
1007 )",
1008 typenames_, GetLanguage(), &error));
1009 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1010 EXPECT_EQ(AidlError::BAD_TYPE, error);
1011}
1012
Jooyung Han30f64ad2020-12-15 08:16:31 +09001013TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1014 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1015 CaptureStderr();
1016 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1017 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1018 EXPECT_EQ("", GetCapturedStderr());
1019 string code;
1020 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1021 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1022}
1023
Jooyung Han535c5e82020-12-29 15:16:59 +09001024TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001025 using Ptr = unique_ptr<AidlConstantValue>;
1026 const AidlLocation& loc = AIDL_LOCATION_HERE;
1027
Jooyung Han535c5e82020-12-29 15:16:59 +09001028 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1029 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1030 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1031 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001032
1033 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1034 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001035 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001036
1037 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1038 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1039 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1040 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001041 EXPECT_EQ(
1042 expected,
1043 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001044}
1045
Devin Moore7b8d5c92020-03-17 14:14:08 -07001046TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001047 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001048 const string expected_stderr =
1049 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001050 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001051 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1052 R"(package p;
1053 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001054 parcelable IBar {}
1055 parcelable StructuredParcelable {}
1056 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001057 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001058 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001059 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001060 // Parse success is important for clear error handling even if the cases aren't
1061 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001062 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001063}
1064
Devin Moore7b8d5c92020-03-17 14:14:08 -07001065TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001066 AidlError error;
1067 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1068 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001069 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001070 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1071 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001072}
1073
Steven Morelandf9e922f2020-07-08 21:15:27 +00001074TEST_P(AidlTest, FailOnEmptyListWithComma) {
1075 AidlError error;
1076 const string expected_stderr =
1077 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1078 CaptureStderr();
1079 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1080 typenames_, GetLanguage(), &error));
1081 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1082 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1083}
1084
Devin Moore7b8d5c92020-03-17 14:14:08 -07001085TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001086 AidlError error;
1087 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001088 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001089 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001090 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1091 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001092 interface IFoo {
1093 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1094 }
1095 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001096 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001097 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1098 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001099}
1100
Jiyong Park18132182020-06-08 20:24:40 +09001101TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1102 AidlError error;
1103 const string expected_stderr =
1104 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1105 "cpp_header (which can also be used as an identifier)\n";
1106 CaptureStderr();
1107 // Notice the trailing dot(.) in the name, which isn't a correct name
1108 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1109 GetLanguage(), &error));
1110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1111 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1112}
1113
1114TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1115 AidlError error;
1116 const string expected_stderr =
1117 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1118 "cpp_header (which can also be used as an identifier)\n";
1119 CaptureStderr();
1120 // Notice the trailing dot(.) in the package name
1121 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1122 GetLanguage(), &error));
1123 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1124 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1125}
1126
Devin Moore7b8d5c92020-03-17 14:14:08 -07001127TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001128 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001129 auto parse_result = Parse("p/IFoo.aidl",
1130 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001131 interface IFoo {
1132 const int POSITIVE_HEX_VALUE = 0xf5;
1133 }
1134 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135 typenames_, GetLanguage(), &error);
1136 EXPECT_NE(nullptr, parse_result);
1137 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001138 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001139 const auto& cpp_constants = interface->GetConstantDeclarations();
1140 EXPECT_EQ((size_t)1, cpp_constants.size());
1141 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001142 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001143 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001144}
1145
Devin Moore7b8d5c92020-03-17 14:14:08 -07001146TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001147 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001148 auto parse_result = Parse("p/IFoo.aidl",
1149 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001150 interface IFoo {
1151 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1152 }
1153 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001154 typenames_, GetLanguage(), &error);
1155 ASSERT_NE(nullptr, parse_result);
1156 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001157 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001158 const auto& cpp_constants = interface->GetConstantDeclarations();
1159 EXPECT_EQ((size_t)1, cpp_constants.size());
1160 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001161 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001162 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001163}
1164
Devin Moore7b8d5c92020-03-17 14:14:08 -07001165TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001166 io_delegate_.SetFileContents(
1167 "p/Outer.aidl",
1168 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001169 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001170 const string input_path = "p/IFoo.aidl";
1171 const string input = "package p; import p.Outer; interface IFoo"
1172 " { Outer.Inner get(); }";
1173
Devin Moore7b8d5c92020-03-17 14:14:08 -07001174 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1175 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001176
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001177 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001178 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001179 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001180 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001181}
1182
Jooyung Han0a950bd2021-05-15 12:50:36 +09001183TEST_F(AidlTest, CppNameOf_GenericType) {
1184 io_delegate_.SetFileContents("p/Wrapper.aidl", "package p; parcelable Wrapper<T> { T wrapped; }");
1185 import_paths_.emplace("");
1186 // Since we don't support compilation of Wrapper directly (due to "T" reference),
1187 // prepare Holder so that Wrapper gets parsed into AidlTypenames
1188 const string input_path = "p/Holder.aidl";
1189 const string input =
1190 "package p; import p.Wrapper; parcelable Holder {\n"
1191 " @nullable Wrapper<String> value;\n"
1192 "}";
1193
1194 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1195 EXPECT_NE(nullptr, parse_result);
1196
1197 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1198 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1199 (..., params->emplace_back(std::move(type_params)));
1200 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1201 };
1202
1203 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1204 std::vector<AidlAnnotation> annotations;
1205 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", nullptr, {}));
1206 type->Annotate(std::move(annotations));
1207 return std::move(type);
1208 };
1209
1210 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1211 (void)type->SetArray();
1212 return std::move(type);
1213 };
1214
1215 auto w = type("p.Wrapper", type("String"));
1216 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1217
1218 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1219 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1220 cpp::CppNameOf(*nullable_w, typenames_));
1221
1222 auto array_w = set_array(type("p.Wrapper", type("String")));
1223 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1224 cpp::CppNameOf(*array_w, typenames_));
1225
1226 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1227 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1228 cpp::CppNameOf(*nullable_array_w, typenames_));
1229
1230 auto list_w = type("List", type("p.Wrapper", type("String")));
1231 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1232 cpp::CppNameOf(*list_w, typenames_));
1233
1234 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1235 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1236 cpp::CppNameOf(*nullable_list_w, typenames_));
1237}
1238
Devin Moore7b8d5c92020-03-17 14:14:08 -07001239TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001240 io_delegate_.SetFileContents(
1241 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001242 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001243 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001244 const string input_path = "p/IFoo.aidl";
1245 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1247 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001248 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001249 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001250 native_type.Resolve(typenames_);
1251
1252 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1253 // C++ understands C++ specific stuff
1254 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1255 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001256 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001257 EXPECT_EQ(1u, headers.size());
1258 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001259}
1260
Christopher Wileyf8136192016-04-12 14:19:35 -07001261TEST_F(AidlTest, WritesCorrectDependencyFile) {
1262 // While the in tree build system always gives us an output file name,
1263 // other android tools take advantage of our ability to infer the intended
1264 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001265 vector<string> args = {
1266 "aidl",
1267 "-d dep/file/path",
1268 "-o place/for/output",
1269 "p/IFoo.aidl"};
1270 Options options = Options::From(args);
1271 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001272 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001273 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001274 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001275 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1276}
1277
Dan Willemsen93298ee2016-11-10 23:55:55 -08001278TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1279 // While the in tree build system always gives us an output file name,
1280 // other android tools take advantage of our ability to infer the intended
1281 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001282 vector<string> args = {
1283 "aidl",
1284 "-d dep/file/path",
1285 "--ninja",
1286 "-o place/for/output",
1287 "p/IFoo.aidl"};
1288 Options options = Options::From(args);
1289 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001290 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001291 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001292 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001293 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1294}
1295
Jiyong Parkdf202122019-09-30 20:48:35 +09001296TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001297 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1298 // this by calling aidl with every .aidl file it finds, then parsing the
1299 // generated dependency files. Those that reference .java output files are
1300 // for interfaces and those that do not are parcelables. However, for both
1301 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001302 vector<string> args = {
1303 "aidl",
1304 "-o place/for/output",
1305 "-d dep/file/path",
1306 "p/Foo.aidl"};
1307 Options options = Options::From(args);
1308 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001309 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001310 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001311 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001312 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1313}
1314
1315TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1316 vector<string> args = {
1317 "aidl",
1318 "--structured",
1319 "-o place/for/output",
1320 "-d dep/file/path",
1321 "p/Foo.aidl"};
1322 Options options = Options::From(args);
1323 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1324 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1325 string actual_dep_file_contents;
1326 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1327 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001328}
1329
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001330TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1331 vector<string> args = {
1332 "aidl",
1333 "--lang=java",
1334 "-o place/for/output",
1335 "p/Foo.aidl"};
1336 Options options = Options::From(args);
1337 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1338 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1339 string output_file_contents;
1340 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1341}
1342
Devin Moore21b26772020-08-26 16:37:56 -07001343TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001344 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001345 const string list_array_parcelable =
1346 "package a; parcelable Foo {\n"
1347 " List[] lists; }";
1348 CaptureStderr();
1349 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1350 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1351}
1352
Jiyong Parkf8d53612020-05-04 14:06:13 +09001353TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1354 AidlError error;
1355 string expected_stderr =
1356 "ERROR: a/IFoo.aidl:2.7-11: "
1357 "Encountered an untyped List or Map. The use of untyped List/Map is "
1358 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1359 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1360 if (GetLanguage() != Options::Language::JAVA) {
1361 expected_stderr =
1362 "ERROR: a/IFoo.aidl:2.1-7: "
1363 "Currently, only the Java backend supports non-generic List.\n";
1364 }
1365
1366 const string primitive_interface =
1367 "package a; interface IFoo {\n"
1368 " List foo(); }";
1369 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001370 AidlTypenames tn1;
1371 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001372 {"--structured"}));
1373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001374
1375 string primitive_parcelable =
1376 "package a; parcelable IFoo {\n"
1377 " List foo;}";
1378 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001379 AidlTypenames tn2;
1380 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001381 {"--structured"}));
1382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1383}
1384
Jeongik Cha225519b2020-08-29 01:55:32 +09001385TEST_P(AidlTest, ExtensionTest) {
1386 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001387 string extendable_parcelable =
1388 "package a; parcelable Data {\n"
1389 " ParcelableHolder extension;\n"
1390 " ParcelableHolder extension2;\n"
1391 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001392 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001393 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1394 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001395 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001396 "yet.\n",
1397 GetCapturedStderr());
1398 } else {
1399 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1400 EXPECT_EQ("", GetCapturedStderr());
1401 }
1402}
1403TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1404 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001405 string parcelableholder_return_interface =
1406 "package a; interface IFoo {\n"
1407 " ParcelableHolder foo();\n"
1408 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001409 EXPECT_EQ(nullptr,
1410 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001411
Jeongik Cha8f02a532020-10-14 00:16:28 +09001412 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001413 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001414 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001415 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001416 "yet.\n",
1417 GetCapturedStderr());
1418 return;
1419 }
1420 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1421 GetCapturedStderr());
1422}
1423
1424TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1425 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001426 string extendable_parcelable_arg_interface =
1427 "package a; interface IFoo {\n"
1428 " void foo(in ParcelableHolder ph);\n"
1429 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001430 EXPECT_EQ(nullptr,
1431 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1432
Jeongik Cha8f02a532020-10-14 00:16:28 +09001433 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001434 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001435 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001436 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001437 "yet.\n",
1438 GetCapturedStderr());
1439 return;
1440 }
1441 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1442 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001443}
1444
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001445TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1446 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001447 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001448 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1449 CaptureStderr();
1450 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1451 if (GetLanguage() == Options::Language::RUST) {
1452 EXPECT_EQ(
1453 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1454 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1455 "yet.\n",
1456 GetCapturedStderr());
1457 return;
1458 }
1459 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1460}
1461
Jooyung Han3f347ca2020-12-01 12:41:50 +09001462TEST_P(AidlTest, ParcelablesWithConstants) {
1463 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001464 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001465 CaptureStderr();
1466 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1467 EXPECT_EQ("", GetCapturedStderr());
1468}
1469
1470TEST_P(AidlTest, UnionWithConstants) {
1471 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001472 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001473 CaptureStderr();
1474 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1475 EXPECT_EQ("", GetCapturedStderr());
1476}
1477
Jooyung Han633eab62021-01-07 14:12:40 +09001478TEST_F(AidlTest, ConstantsWithAnnotations) {
1479 io_delegate_.SetFileContents("IFoo.aidl",
1480 "interface IFoo {\n"
1481 " @JavaPassthrough(annotation=\"@Foo\")\n"
1482 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1483 "}");
1484 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1485 CaptureStderr();
1486 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1487 EXPECT_EQ("", GetCapturedStderr());
1488 string code;
1489 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1490 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1491 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1492}
1493
Jiyong Park02da7422018-07-16 16:00:26 +09001494TEST_F(AidlTest, ApiDump) {
1495 io_delegate_.SetFileContents(
1496 "foo/bar/IFoo.aidl",
1497 "package foo.bar;\n"
1498 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001499 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001500 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001501 " /* @hide applied \n"
1502 " @deprecated use foo2 */\n"
1503 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1504 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001505 " IFoo foo3(IFoo foo);\n"
1506 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001507 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001508 " /** blahblah\n"
1509 " @deprecated\n"
1510 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001511 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001512 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001513 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001514 "}\n");
1515 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1516 "package foo.bar;\n"
1517 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001518 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001519 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001520 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001521 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001522 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001523 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001524 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001525 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001526 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001527 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001528 "}\n");
1529 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001530 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1531 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001532 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001533 bool result = dump_api(options, io_delegate_);
1534 ASSERT_TRUE(result);
1535 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001536 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001537 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001538interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001539 /**
1540 * @hide
1541 * @deprecated use foo2
1542 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001543 int foo(out int[] a, String b, boolean c, inout List<String> d);
1544 int foo2(@utf8InCpp String x, inout List<String> y);
1545 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1546 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001547 /**
1548 * @deprecated reason why...
1549 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001550 const int A = 1;
1551 const String STR = "Hello";
1552}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001553)"),
1554 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001555
Jiyong Parke59c3682018-09-11 23:10:25 +09001556 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001557 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001558/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001559parcelable Data {
1560 int x = 10;
1561 int y;
1562 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001563 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001564}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001565)"),
1566 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001567}
1568
Jiyong Parked65bf42018-08-28 15:43:27 +09001569TEST_F(AidlTest, ApiDumpWithManualIds) {
1570 io_delegate_.SetFileContents(
1571 "foo/bar/IFoo.aidl",
1572 "package foo.bar;\n"
1573 "interface IFoo {\n"
1574 " int foo() = 1;\n"
1575 " int bar() = 2;\n"
1576 " int baz() = 10;\n"
1577 "}\n");
1578
Jiyong Parke59c3682018-09-11 23:10:25 +09001579 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001580 Options options = Options::From(args);
1581 bool result = dump_api(options, io_delegate_);
1582 ASSERT_TRUE(result);
1583 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001584 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001585 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001586interface IFoo {
1587 int foo() = 1;
1588 int bar() = 2;
1589 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001590}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001591)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001592}
1593
1594TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001595 const string expected_stderr =
1596 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1597 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001598 io_delegate_.SetFileContents(
1599 "foo/bar/IFoo.aidl",
1600 "package foo.bar;\n"
1601 "interface IFoo {\n"
1602 " int foo() = 1;\n"
1603 " int bar();\n"
1604 " int baz() = 10;\n"
1605 "}\n");
1606
Jiyong Parke59c3682018-09-11 23:10:25 +09001607 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001608 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001609 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001610 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001612}
1613
Jooyung Han965e31d2020-11-27 12:30:16 +09001614TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1615 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1616 "package foo.bar;\n"
1617 "interface IFoo {\n"
1618 " @utf8InCpp String foo();\n"
1619 " const @utf8InCpp String bar = \"bar\";\n"
1620 "}\n");
1621
1622 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1623 Options options = Options::From(args);
1624 CaptureStderr();
1625 EXPECT_TRUE(dump_api(options, io_delegate_));
1626 EXPECT_EQ("", GetCapturedStderr());
1627 string actual;
1628 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001629 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1630interface IFoo {
1631 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001632 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001633}
1634)"),
1635 actual);
1636}
1637
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001638TEST_F(AidlTest, ApiDumpWithEnums) {
1639 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1640 "package foo.bar;\n"
1641 "enum Enum {\n"
1642 " FOO,\n"
1643 " BAR = FOO + 1,\n"
1644 "}\n");
1645
1646 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1647 Options options = Options::From(args);
1648 CaptureStderr();
1649 EXPECT_TRUE(dump_api(options, io_delegate_));
1650 EXPECT_EQ("", GetCapturedStderr());
1651 string actual;
1652 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1653 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1654 "enum Enum {\n"
1655 " FOO = 0,\n"
1656 " BAR = 1,\n"
1657 "}\n"),
1658 actual);
1659}
1660
1661TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1662 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1663 "package foo.bar;\n"
1664 "enum Enum {\n"
1665 " FOO,\n"
1666 "}\n");
1667 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1668 "package foo.bar;\n"
1669 "import foo.bar.Enum;\n"
1670 "parcelable Foo {\n"
1671 " Enum e = Enum.FOO;\n"
1672 "}\n");
1673
1674 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1675 Options options = Options::From(args);
1676 CaptureStderr();
1677 EXPECT_TRUE(dump_api(options, io_delegate_));
1678 EXPECT_EQ("", GetCapturedStderr());
1679 string actual;
1680 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1681 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1682 "parcelable Foo {\n"
1683 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1684 "}\n"),
1685 actual);
1686}
1687
Jooyung Han71dfec32021-05-23 07:18:58 +09001688TEST_F(AidlTest, ApiDumpWithGenerics) {
1689 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1690 "package foo.bar;\n"
1691 "parcelable Foo<T, U> {\n"
1692 "}\n");
1693
1694 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1695 Options options = Options::From(args);
1696 CaptureStderr();
1697 EXPECT_TRUE(dump_api(options, io_delegate_));
1698 EXPECT_EQ("", GetCapturedStderr());
1699 string actual;
1700 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1701 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1702 "parcelable Foo<T, U> {\n"
1703 "}\n"),
1704 actual);
1705}
1706
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001707TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001708 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001709 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1710 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001711 const string expected_map_stderr =
1712 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001713 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1714 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001715 "package p; interface IFoo {"
1716 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001717 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001718 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001719 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001720
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001721 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001722 "package p; interface IFoo {"
1723 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001724 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001725 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001726 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001727}
1728
Jeongik Chae48d9942020-01-02 17:39:00 +09001729TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001730 const string expected_stderr =
1731 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001732 Options options = Options::From("aidl -I p p/IFoo.aidl");
1733 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1734
1735 io_delegate_.SetFileContents("p/IFoo.aidl",
1736 "package p; interface IFoo {"
1737 "Map<String, Bar> foo();}");
1738 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1739
1740 io_delegate_.SetFileContents("p/IFoo.aidl",
1741 "package p; interface IFoo {"
1742 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001743 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001744 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001746
1747 io_delegate_.SetFileContents("p/IFoo.aidl",
1748 "package p; interface IFoo {"
1749 "Map<String, String> foo();}");
1750 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1751
1752 io_delegate_.SetFileContents("p/IFoo.aidl",
1753 "package p; interface IFoo {"
1754 "Map<String, ParcelFileDescriptor> foo();}");
1755 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1756}
1757
Jeongik Chadf76dc72019-11-28 00:08:47 +09001758TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001759 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001760 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1761 io_delegate_.SetFileContents(options.InputFiles().front(),
1762 "package p; interface IFoo {"
1763 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001764 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001765 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001766 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001767}
1768
1769TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1770 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1771 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001772 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001773 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001774 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1775 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001776
1777 Options options = Options::From("aidl -I p p/IFoo.aidl");
1778 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1779 io_delegate_.SetFileContents("p/IFoo.aidl",
1780 "package p; interface IFoo {"
1781 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001782 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001783 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001784 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001785 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001786 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001787 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001788 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1789 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001790 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1791 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1792 io_delegate_.SetFileContents("p/IFoo.aidl",
1793 "package p; interface IFoo {"
1794 "Bar<String, ParcelFileDescriptor> foo();}");
1795 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001796
1797 io_delegate_.SetFileContents("p/IFoo.aidl",
1798 "package p; interface IFoo {"
1799 "Bar<int, long> foo();}");
1800
1801 io_delegate_.SetFileContents("p/IFoo.aidl",
1802 "package p; interface IFoo {"
1803 "Bar<int[], long[]> foo();}");
1804
1805 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001806}
1807
Jeongik Cha0e426012019-07-29 15:57:02 +09001808TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1809 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001810 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1811 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001812 for (const auto& rawOption : rawOptions) {
1813 string expected_stderr =
1814 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001815 Options options = Options::From(rawOption);
1816 io_delegate_.SetFileContents(options.InputFiles().front(),
1817 "package foo.bar;\n"
1818 "interface IFoo1 { int foo(); }\n"
1819 "interface IFoo2 { int foo(); }\n"
1820 "parcelable Data1 { int a; int b;}\n"
1821 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001822 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001823 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001824 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001825
Jeongik Cha0e426012019-07-29 15:57:02 +09001826 io_delegate_.SetFileContents(options.InputFiles().front(),
1827 "package foo.bar;\n"
1828 "interface IFoo1 { int foo(); }\n"
1829 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001830 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001831 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001832 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001833
Devin Moore5de18ed2020-04-02 13:52:29 -07001834 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001835 io_delegate_.SetFileContents(options.InputFiles().front(),
1836 "package foo.bar;\n"
1837 "parcelable Data1 { int a; int b;}\n"
1838 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001839 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001840 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001841 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001842 }
1843}
1844
Devin Moorebdba2a82020-03-31 15:19:02 -07001845TEST_P(AidlTest, FailParseOnEmptyFile) {
1846 const string contents = "";
1847 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1848 CaptureStderr();
1849 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1851}
1852
Jiyong Parkb034bf02018-07-30 17:44:33 +09001853TEST_F(AidlTest, MultipleInputFiles) {
1854 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001855 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001856
1857 io_delegate_.SetFileContents(options.InputFiles().at(0),
1858 "package foo.bar;\n"
1859 "import foo.bar.Data;\n"
1860 "interface IFoo { Data getData(); }\n");
1861
1862 io_delegate_.SetFileContents(options.InputFiles().at(1),
1863 "package foo.bar;\n"
1864 "import foo.bar.IFoo;\n"
1865 "parcelable Data { IFoo foo; }\n");
1866
1867 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1868
1869 string content;
1870 for (const auto file : {
1871 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1872 content.clear();
1873 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1874 EXPECT_FALSE(content.empty());
1875 }
1876}
1877
1878TEST_F(AidlTest, MultipleInputFilesCpp) {
1879 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001880 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001881
1882 io_delegate_.SetFileContents(options.InputFiles().at(0),
1883 "package foo.bar;\n"
1884 "import foo.bar.Data;\n"
1885 "interface IFoo { Data getData(); }\n");
1886
1887 io_delegate_.SetFileContents(options.InputFiles().at(1),
1888 "package foo.bar;\n"
1889 "import foo.bar.IFoo;\n"
1890 "parcelable Data { IFoo foo; }\n");
1891
1892 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1893
1894 string content;
1895 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001896 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001897 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1898 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1899 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1900 content.clear();
1901 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1902 EXPECT_FALSE(content.empty());
1903 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001904}
1905
Andrei Homescub62afd92020-05-11 19:24:59 -07001906TEST_F(AidlTest, MultipleInputFilesRust) {
1907 Options options =
1908 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1909
1910 io_delegate_.SetFileContents(options.InputFiles().at(0),
1911 "package foo.bar;\n"
1912 "import foo.bar.Data;\n"
1913 "interface IFoo { Data getData(); }\n");
1914
1915 io_delegate_.SetFileContents(options.InputFiles().at(1),
1916 "package foo.bar;\n"
1917 "import foo.bar.IFoo;\n"
1918 "parcelable Data { IFoo foo; }\n");
1919
1920 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1921
1922 string content;
1923 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1924 content.clear();
1925 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1926 EXPECT_FALSE(content.empty());
1927 }
1928}
1929
Devin Moore097a3ab2020-03-11 16:08:44 -07001930TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1931 const string expected_stderr =
1932 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001933 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1934 // int getInterfaceVersion() is one of the meta transactions
1935 io_delegate_.SetFileContents(options.InputFiles().front(),
1936 "package p; interface IFoo {"
1937 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001938 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001939 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1941}
Jiyong Park309668e2018-07-28 16:55:44 +09001942
Devin Moore097a3ab2020-03-11 16:08:44 -07001943TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1944 // boolean getInterfaceVersion() is not a meta transaction, but should be
1945 // prevented because return type is not part of a method signature
1946 const string expected_stderr =
1947 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1948 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001949 io_delegate_.SetFileContents(options.InputFiles().front(),
1950 "package p; interface IFoo {"
1951 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001952 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001953 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1955}
Jiyong Park309668e2018-07-28 16:55:44 +09001956
Devin Moore097a3ab2020-03-11 16:08:44 -07001957TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001958 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001959 const string expected_stderr =
1960 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1961 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001962 io_delegate_.SetFileContents(options.InputFiles().front(),
1963 "package p; interface IFoo {"
1964 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001965 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001966 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001967 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001968
1969 // this is not a meta interface method as it differs type arguments
1970 io_delegate_.SetFileContents(options.InputFiles().front(),
1971 "package p; interface IFoo {"
1972 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001973 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001974}
1975
Jooyung Hanb8a97772021-01-19 01:27:38 +09001976TEST_F(AidlTest, CheckApiForEquality) {
1977 CaptureStderr();
1978 Options options = Options::From("aidl --checkapi=equal old new");
1979
1980 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1981 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1982 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1983 "package p; interface IFoo{ @utf8InCpp String foo();}");
1984
1985 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
1986 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
1987}
1988
Daniel Norman85aed542019-08-21 12:01:14 -07001989TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001990 Options options = Options::From("aidl --checkapi old new");
1991 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1992 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1993 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1994 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1995
1996 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1997}
1998
Jiyong Park3656c3c2018-08-01 20:02:01 +09001999TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002000 Options options = Options::From("aidl --checkapi old new");
2001 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2002 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002003
2004 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2005}
2006
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002007TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2008 Options options = Options::From("aidl --checkapi old new");
2009 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2010 const string enum_definition = "package p; enum Enum { FOO }";
2011 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2012 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2013 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2014 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2015
2016 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2017}
2018
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002019TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2020 Options options = Options::From("aidl --checkapi old new -I import");
2021
2022 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2023 io_delegate_.SetFileContents("new/p/Foo.aidl",
2024 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2025 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2026
2027 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2028}
2029
Jooyung Han02a11be2021-02-11 13:18:06 +09002030TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2031 Options options = Options::From("aidl --checkapi=equal old new");
2032 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2033 const string enum_definition = "package p; enum Enum { FOO }";
2034 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2035 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2036 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2037 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2038 CaptureStderr();
2039 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2040 EXPECT_EQ("", GetCapturedStderr());
2041}
2042
Daniel Norman85aed542019-08-21 12:01:14 -07002043class AidlTestCompatibleChanges : public AidlTest {
2044 protected:
2045 Options options_ = Options::From("aidl --checkapi old new");
2046};
2047
2048TEST_F(AidlTestCompatibleChanges, NewType) {
2049 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2050 "package p;"
2051 "interface IFoo {"
2052 " void foo(int a);"
2053 "}");
2054 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2055 "package p;"
2056 "interface IFoo {"
2057 " void foo(int a);"
2058 "}");
2059 io_delegate_.SetFileContents("new/p/IBar.aidl",
2060 "package p;"
2061 "interface IBar {"
2062 " void bar();"
2063 "}");
2064 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2065}
2066
2067TEST_F(AidlTestCompatibleChanges, NewMethod) {
2068 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2069 "package p;"
2070 "interface IFoo {"
2071 " void foo(int a);"
2072 "}");
2073 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2074 "package p;"
2075 "interface IFoo {"
2076 " void foo(int a);"
2077 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002078 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002079 "}");
2080 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2081}
2082
2083TEST_F(AidlTestCompatibleChanges, NewField) {
2084 io_delegate_.SetFileContents("old/p/Data.aidl",
2085 "package p;"
2086 "parcelable Data {"
2087 " int foo;"
2088 "}");
2089 io_delegate_.SetFileContents("new/p/Data.aidl",
2090 "package p;"
2091 "parcelable Data {"
2092 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002093 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002094 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002095 "}");
2096 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2097}
2098
Jooyung Han05bd8a82021-04-28 23:56:38 +09002099TEST_F(AidlTestCompatibleChanges, NewField2) {
2100 io_delegate_.SetFileContents("old/p/Data.aidl",
2101 "package p;"
2102 "parcelable Data {"
2103 "}");
2104 io_delegate_.SetFileContents("new/p/Data.aidl",
2105 "package p;"
2106 "parcelable Data {"
2107 " int foo = 0;"
2108 "}");
2109 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2110}
2111
Daniel Norman85aed542019-08-21 12:01:14 -07002112TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2113 io_delegate_.SetFileContents("old/p/Enum.aidl",
2114 "package p;"
2115 "enum Enum {"
2116 " FOO = 1,"
2117 "}");
2118 io_delegate_.SetFileContents("new/p/Enum.aidl",
2119 "package p;"
2120 "enum Enum {"
2121 " FOO = 1,"
2122 " BAR = 2,"
2123 "}");
2124 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2125}
2126
2127TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2128 io_delegate_.SetFileContents("old/p/Enum.aidl",
2129 "package p;"
2130 "enum Enum {"
2131 " FOO = 1,"
2132 " BAR = 2,"
2133 "}");
2134 io_delegate_.SetFileContents("new/p/Enum.aidl",
2135 "package p;"
2136 "enum Enum {"
2137 " BAR = 2,"
2138 " FOO = 1,"
2139 "}");
2140 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2141}
2142
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002143TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2144 io_delegate_.SetFileContents("old/p/Union.aidl",
2145 "package p;"
2146 "union Union {"
2147 " String foo;"
2148 "}");
2149 io_delegate_.SetFileContents("new/p/Union.aidl",
2150 "package p;"
2151 "union Union {"
2152 " String foo;"
2153 " int num;"
2154 "}");
2155 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2156}
2157
Daniel Norman85aed542019-08-21 12:01:14 -07002158TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002159 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2160 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002161 "interface IFoo {"
2162 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002163 "}");
2164 io_delegate_.SetFileContents("old/p/Data.aidl",
2165 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002166 "parcelable Data {"
2167 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002168 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002169 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2170 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002171 "interface IFoo {"
2172 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002173 "}");
2174 io_delegate_.SetFileContents("new/p/Data.aidl",
2175 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002176 "parcelable Data {"
2177 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002178 "}");
2179 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2180 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002181 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002182 " void foo(int a);"
2183 "}");
2184 io_delegate_.SetFileContents("new/q/Data.aidl",
2185 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002186 "parcelable Data {"
2187 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002188 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002189 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2190}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002191
Daniel Norman85aed542019-08-21 12:01:14 -07002192TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2193 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2194 "package p;"
2195 "interface IFoo {"
2196 " void foo(int a);"
2197 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002198 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2199 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002200 "interface IFoo {"
2201 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002202 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002203 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2204}
Jiyong Parke59c3682018-09-11 23:10:25 +09002205
Daniel Norman85aed542019-08-21 12:01:14 -07002206TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002207 io_delegate_.SetFileContents("old/p/I.aidl",
2208 "package p; interface I {"
2209 "const int A = 1; }");
2210 io_delegate_.SetFileContents("new/p/I.aidl",
2211 "package p ; interface I {"
2212 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002213 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2214}
Jiyong Parka428d212018-08-29 22:26:30 +09002215
Daniel Norman85aed542019-08-21 12:01:14 -07002216TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002217 io_delegate_.SetFileContents("old/p/I.aidl",
2218 "package p; interface I {"
2219 "const int A = 1; const int B = 2;}");
2220 io_delegate_.SetFileContents("new/p/I.aidl",
2221 "package p ; interface I {"
2222 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002223 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002224}
2225
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002226TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2227 io_delegate_.SetFileContents("old/p/Foo.aidl",
2228 "package p;"
2229 "@JavaPassthrough(annotation=\"Alice\")"
2230 "@JavaPassthrough(annotation=\"Bob\")"
2231 "parcelable Foo {}");
2232 io_delegate_.SetFileContents("new/p/Foo.aidl",
2233 "package p;"
2234 "@JavaPassthrough(annotation=\"Bob\")"
2235 "@JavaPassthrough(annotation=\"Alice\")"
2236 "parcelable Foo {}");
2237 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2238}
2239
Jooyung Han00073272020-11-27 14:20:20 +09002240TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2241 io_delegate_.SetFileContents("old/p/Foo.aidl",
2242 "package p;"
2243 "parcelable Foo {}");
2244 io_delegate_.SetFileContents("new/p/Foo.aidl",
2245 "package p;"
2246 "@JavaPassthrough(annotation=\"@Deprecated\")"
2247 "parcelable Foo {}");
2248 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2249}
2250
Jooyung Han636fd2f2020-10-22 11:33:45 +09002251TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2252 io_delegate_.SetFileContents("old/p/Data.aidl",
2253 "package p;"
2254 "parcelable Data {"
2255 " int num;"
2256 "}");
2257 io_delegate_.SetFileContents(
2258 "new/p/Data.aidl",
2259 "package p;"
2260 "parcelable Data {"
2261 " int num;"
2262 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2263 "}");
2264 io_delegate_.SetFileContents("new/p/Enum.aidl",
2265 "package p;"
2266 "enum Enum {"
2267 " FOO = 0,"
2268 " BAR = 1,"
2269 "}");
2270 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2271}
2272
Jooyung Han308bbe02021-04-27 12:09:59 +09002273TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2274 io_delegate_.SetFileContents("old/p/Data.aidl",
2275 "package p;\n"
2276 "parcelable Data {\n"
2277 " p.Enum e;\n"
2278 "}");
2279 io_delegate_.SetFileContents("old/p/Enum.aidl",
2280 "package p;\n"
2281 "enum Enum {\n"
2282 " FOO = 0,\n"
2283 " BAR = 1,\n"
2284 "}");
2285 io_delegate_.SetFileContents("new/p/Data.aidl",
2286 "package p;\n"
2287 "parcelable Data {\n"
2288 " p.Enum e = p.Enum.FOO;\n"
2289 "}");
2290 io_delegate_.SetFileContents("new/p/Enum.aidl",
2291 "package p;\n"
2292 "enum Enum {\n"
2293 " FOO = 0,\n"
2294 " BAR = 1,\n"
2295 "}");
2296 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2297}
2298
Daniel Norman85aed542019-08-21 12:01:14 -07002299class AidlTestIncompatibleChanges : public AidlTest {
2300 protected:
2301 Options options_ = Options::From("aidl --checkapi old new");
2302};
2303
2304TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002305 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002306 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2307 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002308 "interface IFoo {"
2309 " void foo(in String[] str);"
2310 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002311 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002312 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002313 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002314 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002315}
2316
2317TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002318 const string expected_stderr =
2319 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002320 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2321 "package p;"
2322 "interface IFoo {"
2323 " void foo(in String[] str);"
2324 " void bar(@utf8InCpp String str);"
2325 "}");
2326 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2327 "package p;"
2328 "interface IFoo {"
2329 " void foo(in String[] str);"
2330 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002332 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002334}
2335
Jiyong Parkf8d53612020-05-04 14:06:13 +09002336TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2337 const string expected_stderr =
2338 "ERROR: new/p/IFoo.aidl:1.61-65: "
2339 "Encountered an untyped List or Map. The use of untyped List/Map is "
2340 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2341 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2342 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2343 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2344 "package p;"
2345 "interface IFoo {"
2346 " void foo(in String[] str);"
2347 "}");
2348 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2349 "package p;"
2350 "interface IFoo {"
2351 " void foo(in String[] str);"
2352 " void bar(in List arg);"
2353 "}");
2354 CaptureStderr();
2355 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2357}
2358
2359TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2360 const string expected_stderr =
2361 "ERROR: new/p/Data.aidl:1.54-59: "
2362 "Encountered an untyped List or Map. The use of untyped List/Map is "
2363 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2364 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2365 "ERROR: new/p/Data.aidl: Failed to read.\n";
2366 io_delegate_.SetFileContents("old/p/Data.aidl",
2367 "package p;"
2368 "parcelable Data {"
2369 " int foo;"
2370 "}");
2371 io_delegate_.SetFileContents("new/p/Data.aidl",
2372 "package p;"
2373 "parcelable Data {"
2374 " int foo;"
2375 " @nullable List list;"
2376 "}");
2377 CaptureStderr();
2378 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2379 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2380}
2381
Daniel Norman85aed542019-08-21 12:01:14 -07002382TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 const string expected_stderr =
2384 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002385 io_delegate_.SetFileContents("old/p/Data.aidl",
2386 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002387 "parcelable Data {"
2388 " int foo;"
2389 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002390 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002391 io_delegate_.SetFileContents("new/p/Data.aidl",
2392 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002393 "parcelable Data {"
2394 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002395 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002396 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002397 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002399}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002400
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002401TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2402 const string expected_stderr =
2403 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2404 "backends. Please either provide a default value for this field or mark the field as "
2405 "@nullable. This value or a null value will be used automatically when an old version of "
2406 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2407 "order to make sure your code continues to be backwards compatible, make sure the default or "
2408 "null value does not cause a semantic change to this parcelable.\n";
2409 io_delegate_.SetFileContents("old/p/Data.aidl",
2410 "package p;"
2411 "parcelable Data {"
2412 " int num;"
2413 "}");
2414 io_delegate_.SetFileContents("new/p/Data.aidl",
2415 "package p;"
2416 "parcelable Data {"
2417 " int num;"
2418 " String str;"
2419 "}");
2420 CaptureStderr();
2421 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2422 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2423}
2424
Jooyung Han636fd2f2020-10-22 11:33:45 +09002425TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2426 const string expected_stderr =
2427 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2428 "Please make sure 'Enum' has '0' as a valid value.\n";
2429 io_delegate_.SetFileContents("old/p/Data.aidl",
2430 "package p;"
2431 "parcelable Data {"
2432 " int num;"
2433 "}");
2434 io_delegate_.SetFileContents("new/p/Data.aidl",
2435 "package p;"
2436 "parcelable Data {"
2437 " int num;"
2438 " p.Enum e;"
2439 "}");
2440 io_delegate_.SetFileContents("new/p/Enum.aidl",
2441 "package p;"
2442 "enum Enum {"
2443 " FOO = 1,"
2444 " BAR = 2,"
2445 "}");
2446 CaptureStderr();
2447 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2448 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2449}
2450
Daniel Norman85aed542019-08-21 12:01:14 -07002451TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002452 const string expected_stderr =
2453 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002454 io_delegate_.SetFileContents("old/p/Enum.aidl",
2455 "package p;"
2456 "enum Enum {"
2457 " FOO = 1,"
2458 " BAR = 2,"
2459 "}");
2460 io_delegate_.SetFileContents("new/p/Enum.aidl",
2461 "package p;"
2462 "enum Enum {"
2463 " BAR = 2,"
2464 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002465 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002466 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002468}
2469
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002470TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2471 const string expected_stderr =
2472 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2473 io_delegate_.SetFileContents("old/p/Union.aidl",
2474 "package p;"
2475 "union Union {"
2476 " String str;"
2477 " int num;"
2478 "}");
2479 io_delegate_.SetFileContents("new/p/Union.aidl",
2480 "package p;"
2481 "union Union {"
2482 " String str;"
2483 "}");
2484 CaptureStderr();
2485 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2486 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2487}
2488
Daniel Norman85aed542019-08-21 12:01:14 -07002489TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002490 const string expected_stderr =
2491 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002492 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2493 "package p;"
2494 "interface IFoo {"
2495 " void foo(in String[] str);"
2496 " void bar(@utf8InCpp String str);"
2497 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002498 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2499 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002500 "interface IFoo {"
2501 " void foo(in String[] str);"
2502 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002503 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002504 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002505 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002507}
2508
Daniel Norman85aed542019-08-21 12:01:14 -07002509TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002510 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002511 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2512 "package p;"
2513 "interface IFoo {"
2514 " void foo(in String[] str);"
2515 " void bar(@utf8InCpp String str);"
2516 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002517 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2518 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002519 "interface IFoo2 {"
2520 " void foo(in String[] str);"
2521 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002522 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002523 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002524 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002525 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002526}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002527
Daniel Norman85aed542019-08-21 12:01:14 -07002528TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002529 const string expected_stderr =
2530 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002531 io_delegate_.SetFileContents("old/p/Enum.aidl",
2532 "package p;"
2533 "enum Enum {"
2534 " FOO = 1,"
2535 " BAR = 2,"
2536 "}");
2537 io_delegate_.SetFileContents("new/p/Enum.aidl",
2538 "package p;"
2539 "enum Enum {"
2540 " FOO = 3,"
2541 " BAR = 2,"
2542 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002543 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002544 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002546}
2547
2548TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002549 const string expected_stderr =
2550 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2551 "from 0 to 1.\n"
2552 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2553 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002554 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2555 "package p;"
2556 "interface IFoo {"
2557 " void foo(in String[] str);"
2558 " void bar(@utf8InCpp String str);"
2559 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002560 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2561 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002562 "interface IFoo {"
2563 " void bar(@utf8InCpp String str);"
2564 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002565 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002566 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002567 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002568 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002569}
2570
2571TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002572 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002573 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2574 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002575 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002576 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002577 "parcelable Data {"
2578 " int foo;"
2579 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002580 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002581 io_delegate_.SetFileContents("new/p/Data.aidl",
2582 "package p;"
2583 "parcelable Data {"
2584 " int bar;"
2585 " int foo;"
2586 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002587 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002588 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002589 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002590}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002591
Daniel Norman85aed542019-08-21 12:01:14 -07002592TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002593 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002594 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002595 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002596 "interface IFoo {"
2597 " void foo(in String[] str);"
2598 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002599 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002600 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2601 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002602 "interface IFoo {"
2603 " void foo(out String[] str);"
2604 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002605 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002606 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002607 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002608 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002609}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002610
Daniel Norman85aed542019-08-21 12:01:14 -07002611TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002612 const string expected_stderr =
2613 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002614 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2615 "package p;"
2616 "interface IFoo {"
2617 " void foo(in String[] str);"
2618 " void bar(@utf8InCpp String str);"
2619 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002620 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2621 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002622 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002623 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002624 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002625 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002626 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002627 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002628 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002629}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002630
Daniel Norman85aed542019-08-21 12:01:14 -07002631TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002632 const string expected_stderr =
2633 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002634 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2635 "package p;"
2636 "interface IFoo {"
2637 " void foo(in String[] str);"
2638 " void bar(@utf8InCpp String str);"
2639 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002640 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2641 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002642 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002643 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002644 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002645 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002646 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002647 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002648 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002649}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002650
Jooyung Han60b2fde2020-10-29 15:12:40 +09002651TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2652 const string expected_stderr =
2653 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2654 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2655 io_delegate_.SetFileContents("old/p/Foo.aidl",
2656 "package p;"
2657 "@Backing(type=\"byte\")"
2658 "enum Foo {"
2659 " FOO, BAR,"
2660 "}");
2661 io_delegate_.SetFileContents("new/p/Foo.aidl",
2662 "package p;"
2663 "@Backing(type=\"long\")"
2664 "enum Foo {"
2665 " FOO, BAR,"
2666 "}");
2667 CaptureStderr();
2668 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2669 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2670}
2671
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002672TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2673 const string expected_stderr =
2674 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2675 "to @JavaPassthrough(annotation=\"Bob\")\n";
2676 io_delegate_.SetFileContents("old/p/Foo.aidl",
2677 "package p;"
2678 "@JavaPassthrough(annotation=\"Alice\")"
2679 "parcelable Foo {}");
2680 io_delegate_.SetFileContents("new/p/Foo.aidl",
2681 "package p;"
2682 "@JavaPassthrough(annotation=\"Bob\")"
2683 "parcelable Foo {}");
2684
2685 CaptureStderr();
2686 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2687 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2688}
2689
Devin Mooredb7ac512020-08-07 11:17:36 -07002690TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2691 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002692 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002693 io_delegate_.SetFileContents("old/p/Foo.aidl",
2694 "package p;"
2695 "parcelable Foo {"
2696 " int A;"
2697 "}");
2698 io_delegate_.SetFileContents("new/p/Foo.aidl",
2699 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002700 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002701 " int A;"
2702 "}");
2703 CaptureStderr();
2704 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2705 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2706}
2707
2708TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2709 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002710 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002711 io_delegate_.SetFileContents("old/p/Foo.aidl",
2712 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002713 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002714 " int A;"
2715 "}");
2716 io_delegate_.SetFileContents("new/p/Foo.aidl",
2717 "package p;"
2718 "parcelable Foo {"
2719 " int A;"
2720 "}");
2721 CaptureStderr();
2722 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2723 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2724}
2725
Daniel Norman85aed542019-08-21 12:01:14 -07002726TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002727 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002728 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2729 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002730 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002731 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002732 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002733 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002734}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002735
Daniel Norman85aed542019-08-21 12:01:14 -07002736TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002737 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002738 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2739 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002740 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002741 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002743}
Jiyong Parka428d212018-08-29 22:26:30 +09002744
Daniel Norman85aed542019-08-21 12:01:14 -07002745TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002746 const string expected_stderr =
2747 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002748 io_delegate_.SetFileContents("old/p/I.aidl",
2749 "package p; interface I {"
2750 "const int A = 1; const int B = 2;}");
2751 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002752 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002753 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002754 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002755}
Jiyong Parka428d212018-08-29 22:26:30 +09002756
Daniel Norman85aed542019-08-21 12:01:14 -07002757TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002758 const string expected_stderr =
2759 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002760 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2761 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002762 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002763 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002764 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002765}
2766
Devin Moorec7e47a32020-08-07 10:55:25 -07002767TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2768 const string expected_stderr =
2769 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2770 "This is an incompatible change for FixedSize types.\n";
2771 io_delegate_.SetFileContents("old/p/Foo.aidl",
2772 "package p; @FixedSize parcelable Foo { int A = 1; }");
2773 io_delegate_.SetFileContents("new/p/Foo.aidl",
2774 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2775 CaptureStderr();
2776 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2777 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2778}
2779
Jeongik Cha68d18e72021-04-29 20:07:01 +09002780TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
2781 const string expected_stderr =
2782 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
2783 "android.net.UidRangeParcel is changed from 1 to 2. "
2784 "But it is forbidden because of legacy support.\n";
2785 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
2786 "package android.net; parcelable UidRangeParcel { int A = 1; }");
2787 io_delegate_.SetFileContents(
2788 "new/android/net/UidRangeParcel.aidl",
2789 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
2790 CaptureStderr();
2791 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2792 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2793}
2794
Devin Moorec7e47a32020-08-07 10:55:25 -07002795TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2796 const string expected_stderr =
2797 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2798 io_delegate_.SetFileContents("old/p/Foo.aidl",
2799 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2800 io_delegate_.SetFileContents("new/p/Foo.aidl",
2801 "package p; @FixedSize parcelable Foo { int A = 1; }");
2802 CaptureStderr();
2803 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2804 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2805}
2806
2807TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2808 const string expected_stderr =
2809 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2810 "a.\n"
2811 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2812 "b.\n"
2813 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2814 "c.\n"
2815 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2816 "d.\n"
2817 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2818 "e.\n"
2819 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2820 "f.\n";
2821
2822 io_delegate_.SetFileContents("Foo.aidl",
2823 "@FixedSize parcelable Foo { "
2824 " int[] a;"
2825 " Bar b;"
2826 " String c;"
2827 " ParcelFileDescriptor d;"
2828 " IBinder e;"
2829 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002830 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002831 "}");
2832 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002833 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002834
2835 CaptureStderr();
2836 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2837 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2838}
2839
2840TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2841 const string expected_stderr = "";
2842
2843 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2844 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2845 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002846 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002847
2848 CaptureStderr();
2849 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2851}
2852
Jiyong Park8c380532018-08-30 14:55:26 +09002853TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002854 const string expected_stderr =
2855 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2856 "dir1/q/IBar.aidl\n"
2857 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002858 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002859 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2860 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2861 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2862 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2863
Devin Moore097a3ab2020-03-11 16:08:44 -07002864 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002865 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002866 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002867}
2868
Jiyong Parked65bf42018-08-28 15:43:27 +09002869TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002870 const string expected_stderr =
2871 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2872 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002873 Options options = Options::From("aidl --checkapi old new");
2874 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2875 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002876
2877 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2878
Jiyong Parke59c3682018-09-11 23:10:25 +09002879 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002880 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002881 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002882 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002883}
2884
Jooyung Han652ce482021-02-26 12:40:35 +09002885TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2886 Options options =
2887 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002888
2889 // use without import
2890 io_delegate_.SetFileContents("p/IFoo.aidl",
2891 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002892 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2893
2894 // capture output files
2895 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09002896
Devin Moore7b8d5c92020-03-17 14:14:08 -07002897 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002898 io_delegate_.SetFileContents(
2899 "p/IFoo.aidl",
2900 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002901 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2902 // output files should be the same
2903 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002904
2905 // use with import (as before)
2906 io_delegate_.SetFileContents("p/IFoo.aidl",
2907 "package p;"
2908 "import android.os.ParcelFileDescriptor;"
2909 "interface IFoo{"
2910 " void foo(in ParcelFileDescriptor fd);"
2911 "}");
Jooyung Han652ce482021-02-26 12:40:35 +09002912 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2913 // output files should be the same
2914 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002915}
Jiyong Parked65bf42018-08-28 15:43:27 +09002916
Jooyung Han020d8d12021-02-26 17:23:02 +09002917TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
2918 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
2919 CaptureStderr();
2920 io_delegate_.SetFileContents("p/IFoo.aidl",
2921 "package p;"
2922 "interface IFoo{"
2923 " void foo(out ParcelFileDescriptor fd);"
2924 "}");
2925 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
2926 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
2927}
2928
2929TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
2930 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
2931 CaptureStderr();
2932 io_delegate_.SetFileContents("p/IFoo.aidl",
2933 "package p;"
2934 "interface IFoo{"
2935 " void foo(ParcelFileDescriptor fd);"
2936 "}");
2937 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
2938 EXPECT_THAT(GetCapturedStderr(),
2939 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
2940}
2941
Jiyong Park3633b722019-04-11 15:38:26 +09002942TEST_F(AidlTest, ManualIds) {
2943 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2944 io_delegate_.SetFileContents("IFoo.aidl",
2945 "interface IFoo {\n"
2946 " void foo() = 0;\n"
2947 " void bar() = 1;\n"
2948 "}");
2949 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2950}
2951
2952TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2953 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2954 io_delegate_.SetFileContents("IFoo.aidl",
2955 "interface IFoo {\n"
2956 " void foo() = 0;\n"
2957 " void bar() = 1;\n"
2958 "}");
2959 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2960}
2961
2962TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002963 const string expected_stderr =
2964 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002965 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2966 io_delegate_.SetFileContents("IFoo.aidl",
2967 "interface IFoo {\n"
2968 " void foo() = 3;\n"
2969 " void bar() = 3;\n"
2970 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002971 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002972 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002973 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002974}
2975
2976TEST_F(AidlTest, FailOnOutOfRangeIds) {
2977 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002978 const string expected_stderr =
2979 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2980 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002981 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2982 io_delegate_.SetFileContents("IFoo.aidl",
2983 "interface IFoo {\n"
2984 " void foo() = 3;\n"
2985 " void bar() = 16777115;\n"
2986 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002987 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002988 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002990}
2991
2992TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 const string expected_stderr =
2994 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002995 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2996 io_delegate_.SetFileContents("IFoo.aidl",
2997 "interface IFoo {\n"
2998 " void foo() = 3;\n"
2999 " void bar();\n"
3000 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003001 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003002 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003004}
3005
Jiyong Parkc6816252019-07-08 08:12:28 +09003006TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3007 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3008 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3009 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
3010 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3011}
3012
3013TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003014 const string expected_stderr =
3015 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3016 "dir/IBar.aidl\n"
3017 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003018 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003019
Jiyong Parkc6816252019-07-08 08:12:28 +09003020 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3021 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3022 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3023 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003024 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09003025 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003026 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003027}
3028
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003029TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3030 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3031 "package a.b;\n"
3032 "import a.b.IBar;\n"
3033 "import a.b.IQux;\n"
3034 "interface IFoo { IQux foo(); }\n");
3035 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3036 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3037
3038 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
3039 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3040
3041 string output;
3042 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3043 // IBar was imported but wasn't used. include is not expected.
3044 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3045 // IBar was imported and used. include is expected.
3046 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3047}
3048
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003049TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003050 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003051 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003052 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3053 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003054 interface IFoo {
3055 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003056 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003057 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003058 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003059 // JavaPassthrough should work with other types as well (e.g. enum)
3060 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3061 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3062 @JavaPassthrough(annotation="@com.android.AliceTwo")
3063 @Backing(type="byte")
3064 enum MyEnum {
3065 a, b, c
3066 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003067
Jooyung Han4cde01d2020-10-13 11:10:47 +09003068 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003069 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3070
3071 string java_out;
3072 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003073 // type-decl-level annotations with newline at the end
3074 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3075 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3076 // member-decl-level annotations with newline at the end
3077 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3078 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3079 // inline annotations with space at the end
3080 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003081
Jooyung Han4cde01d2020-10-13 11:10:47 +09003082 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3083 // type-decl-level annotations with newline at the end
3084 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3085 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3086
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003087 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003088 Options cpp_options =
3089 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003090 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3091
Jooyung Han4cde01d2020-10-13 11:10:47 +09003092 Options ndk_options =
3093 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003094 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003095
Jooyung Han4cde01d2020-10-13 11:10:47 +09003096 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07003097 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003098}
3099
Andrei Homescue61feb52020-08-18 15:44:24 -07003100TEST_F(AidlTest, ParseRustDerive) {
3101 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3102 @RustDerive(Clone=true, Copy=false)
3103 parcelable Foo {
3104 int a;
3105 })");
3106
3107 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
3108 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
3109
3110 string rust_out;
3111 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3112 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3113
3114 // Other backends shouldn't be bothered
3115 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
3116 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3117
3118 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
3119 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
3120
3121 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
3122 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3123}
3124
Jiyong Park56f73d72019-06-11 12:20:28 +09003125class AidlOutputPathTest : public AidlTest {
3126 protected:
3127 void SetUp() override {
3128 AidlTest::SetUp();
3129 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3130 }
3131
3132 void Test(const Options& options, const std::string expected_output_path) {
3133 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3134 // check the existence
3135 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3136 }
3137};
3138
3139TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3140 // <out_dir> / <package_name> / <type_name>.java
3141 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3142}
3143
3144TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3145 // when output file is explicitly set, it is always respected. -o option is
3146 // ignored.
3147 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3148}
3149
3150TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3151 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3152}
3153
3154TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3155 // output is the same as the input file except for the suffix
3156 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3157}
3158
Devin Moore7b8d5c92020-03-17 14:14:08 -07003159TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003160 AidlError error;
3161 const string expected_stderr =
3162 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3163 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003164 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3165 R"(package p;
3166 interface IFoo {
3167 const int int32_max_oob = 2147483650;
3168 }
3169 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003170 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003171 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3172 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003173}
3174
Devin Moore7b8d5c92020-03-17 14:14:08 -07003175TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003176 AidlError error;
3177 const string expected_stderr =
3178 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3179 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003180 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3181 R"(package p;
3182 interface IFoo {
3183 const int int32_min_oob = -2147483650;
3184 }
3185 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003186 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003187 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3188 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003189}
3190
Devin Moore7b8d5c92020-03-17 14:14:08 -07003191TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003192 AidlError error;
3193 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003194 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003195 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003196 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3197 R"(package p;
3198 interface IFoo {
3199 const long int64_max_oob = 21474836509999999999999999;
3200 }
3201 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003202 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003203 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3204 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003205}
3206
Devin Moore7b8d5c92020-03-17 14:14:08 -07003207TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003208 AidlError error;
3209 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003210 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003211 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003212 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3213 R"(package p;
3214 interface IFoo {
3215 const long int64_min_oob = -21474836509999999999999999;
3216 }
3217 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003218 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003219 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3220 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003221}
3222
Devin Moore7b8d5c92020-03-17 14:14:08 -07003223TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003224 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003225 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003226 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003227 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3228 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003229 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3230 R"(package p;
3231 @Backing(type="byte")
3232 enum TestEnum {
3233 FOO = 127,
3234 BAR,
3235 }
3236 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003237 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003239 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003240}
3241
Devin Mooredecaf292020-04-30 09:16:40 -07003242TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3243 AidlError error;
3244 const string expected_stderr =
3245 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003246 "be one of: type\n";
3247 CaptureStderr();
3248 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3249 R"(package p;
3250 @Backing(foo="byte")
3251 enum TestEnum {
3252 FOO = 1,
3253 BAR,
3254 }
3255 )",
3256 typenames_, GetLanguage(), &error));
3257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3258 EXPECT_EQ(AidlError::BAD_TYPE, error);
3259}
3260
Jooyung Han5721a232020-12-24 04:34:55 +09003261TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3262 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3263 CaptureStderr();
3264 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3266}
3267
Jooyung Han66813932020-10-23 13:24:44 +09003268TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003269 io_delegate_.SetFileContents("Foo.aidl",
3270 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3271 "Map<String, Baz> d; Bar[] e; }");
3272 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3273 io_delegate_.SetFileContents("Baz.aidl",
3274 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003275 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3276 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3277}
3278
Jooyung Han66813932020-10-23 13:24:44 +09003279TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003280 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003281 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003282 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003283 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3284 "named 'bar'.\n";
3285 CaptureStderr();
3286 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3287 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3288 EXPECT_EQ(expected_error, GetCapturedStderr());
3289}
3290
Jooyung Han09e551c2021-05-11 11:44:48 +09003291TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3292 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3293 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3294 CaptureStderr();
3295 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3296 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3297 EXPECT_EQ("", GetCapturedStderr());
3298}
3299
Jooyung Han59af9cc2020-10-25 21:44:14 +09003300TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3301 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3302 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3303 string expected_error =
3304 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003305 "named 'bar'.\n";
3306 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003307 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3308 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003309 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003310}
3311
Jooyung Han66813932020-10-23 13:24:44 +09003312TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003313 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003314 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3315 string expected_error =
3316 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3317 "only be an in parameter.\n";
3318 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003319 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3320 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003321 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003322}
3323
Jooyung Han66813932020-10-23 13:24:44 +09003324TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003325 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003326 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3327 string expected_error =
3328 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3329 "only be an in parameter.\n";
3330 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003331 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3332 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003333 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003334}
3335
Jooyung Han66813932020-10-23 13:24:44 +09003336TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003337 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003338 Options options = Options::From("aidl --lang=java Foo.aidl");
3339 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003340 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3341 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003342 CaptureStderr();
3343 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3345}
Devin Moore53fc99c2020-08-12 08:07:52 -07003346
Jooyung Hanfe086af2021-01-16 03:44:47 +09003347TEST_P(AidlTest, UnionInUnion) {
3348 import_paths_.insert(".");
3349 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3350 CaptureStderr();
3351 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3352 EXPECT_THAT("", GetCapturedStderr());
3353}
3354
Jooyung Hanfe89f122020-10-14 03:49:18 +09003355TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3356 const string method = "package a; union Foo {}";
3357 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3358 CaptureStderr();
3359 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3360 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3361}
3362
3363TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3364 const string method = "package a; union Foo { ParcelableHolder x; }";
3365 const string expected_stderr =
3366 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3367 CaptureStderr();
3368 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3369 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3370}
3371
Jooyung Han53fb4242020-12-17 16:03:49 +09003372TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3373 import_paths_.insert(".");
3374 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3375 const string expected_err = "The union's first member should have a useful default value.";
3376 CaptureStderr();
3377 EXPECT_EQ(nullptr,
3378 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3379 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3380}
3381
Devin Moore53fc99c2020-08-12 08:07:52 -07003382TEST_P(AidlTest, GenericStructuredParcelable) {
3383 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003384 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003385 const string expected_stderr = "";
3386 CaptureStderr();
3387 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3388 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3389}
3390
Jooyung Han3f347ca2020-12-01 12:41:50 +09003391TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3392 io_delegate_.SetFileContents("Foo.aidl",
3393 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3394 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003395 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003396 const string expected_stderr = "";
3397 CaptureStderr();
3398 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3400
3401 string code;
3402 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3403 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3404const ::android::String16& Foo<T,U>::s() {
3405 static const ::android::String16 value(::android::String16(""));
3406 return value;
3407})--"));
3408}
3409
3410TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3411 io_delegate_.SetFileContents("Foo.aidl",
3412 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3413 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003414 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003415 const string expected_stderr = "";
3416 CaptureStderr();
3417 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3418 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3419
3420 string code;
3421 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3422 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3423const char* Foo<T, U>::s = "";
3424)--"));
3425}
3426
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003427TEST_F(AidlTest, NestedTypeArgs) {
3428 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003429 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3430
3431 io_delegate_.SetFileContents("a/Foo.aidl",
3432 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3433 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003434 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3435 const string expected_stderr = "";
3436 CaptureStderr();
3437 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3439
3440 string code;
3441 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003442 EXPECT_THAT(code,
3443 testing::HasSubstr(
3444 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3445}
3446
3447TEST_F(AidlTest, DoubleArrayError) {
3448 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3449
3450 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3451 const string expected_stderr =
3452 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3453 CaptureStderr();
3454 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3456}
3457
3458TEST_F(AidlTest, DoubleGenericError) {
3459 io_delegate_.SetFileContents("a/Bar.aidl",
3460 "package a; parcelable Bar { List<String><String> a; }");
3461
3462 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3463 const string expected_stderr =
3464 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3465 CaptureStderr();
3466 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3468}
3469
3470TEST_F(AidlTest, ArrayBeforeGenericError) {
3471 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3472
3473 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003474 CaptureStderr();
3475 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003476 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3477}
3478
3479TEST_F(AidlTest, NullableArraysAreNotSupported) {
3480 io_delegate_.SetFileContents("a/Bar.aidl",
3481 "package a; parcelable Bar { String @nullable [] a; }");
3482
3483 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3484 CaptureStderr();
3485 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3486 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3487}
3488
3489TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3490 io_delegate_.SetFileContents("a/Bar.aidl",
3491 "package a; parcelable Bar { List<@nullable String> a; }");
3492
3493 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3494 CaptureStderr();
3495 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3496 EXPECT_THAT(GetCapturedStderr(),
3497 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003498}
3499
Jooyung Han14004ed2020-10-16 03:49:57 +09003500struct GenericAidlTest : ::testing::Test {
3501 FakeIoDelegate io_delegate_;
3502 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003503 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003504 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3505 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3506 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3507
3508 Options options = Options::From(cmd);
3509 CaptureStderr();
3510 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3511 EXPECT_EQ("", GetCapturedStderr());
3512 }
3513};
3514
3515TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3516 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3517 string code;
3518 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3519 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3520 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3521 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3522}
3523
3524TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3525 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3526 string code;
3527 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3528 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3529 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3530 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3531}
3532
Devin Moore53fc99c2020-08-12 08:07:52 -07003533TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3534 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003535 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003536 const string expected_stderr =
3537 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3538 CaptureStderr();
3539 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3541}
3542
3543TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3544 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003545 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003546 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3547 CaptureStderr();
3548 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3550}
3551
Jooyung Han7a308842020-10-27 19:06:49 +09003552TEST_P(AidlTest, LongCommentWithinConstExpression) {
3553 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003554 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003555 CaptureStderr();
3556 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3557 EXPECT_EQ("", GetCapturedStderr());
3558}
3559
Jeongik Chaef44e622020-10-23 16:00:52 +09003560TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3561 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3562 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3563 std::string expectedErr =
3564 "ERROR: a/Foo.aidl:1.28-30: "
3565 "Encountered an untyped List or Map. The use of untyped List/Map is "
3566 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3567 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3568 "ERROR: a/Foo.aidl:1.35-37: "
3569 "Encountered an untyped List or Map. The use of untyped List/Map is "
3570 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3571 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3572 CaptureStderr();
3573 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3574 EXPECT_EQ(expectedErr, GetCapturedStderr());
3575}
3576
3577TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003578 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3579 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003580 std::string expectedErr =
3581 "ERROR: a/Foo.aidl:1.33-35: "
3582 "Encountered an untyped List or Map. The use of untyped List/Map is "
3583 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3584 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3585 "ERROR: a/Foo.aidl:1.40-42: "
3586 "Encountered an untyped List or Map. The use of untyped List/Map is "
3587 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3588 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003589 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003590 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3591 EXPECT_EQ(expectedErr, GetCapturedStderr());
3592}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003593
Jeongik Chaef44e622020-10-23 16:00:52 +09003594TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3595 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3596 io_delegate_.SetFileContents(
3597 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3598 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3599 std::string expectedErr =
3600 "ERROR: a/Foo.aidl:1.52-54: "
3601 "Encountered an untyped List or Map. The use of untyped List/Map is "
3602 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3603 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3604 "ERROR: a/Foo.aidl:1.64-66: "
3605 "Encountered an untyped List or Map. The use of untyped List/Map is "
3606 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3607 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3608 CaptureStderr();
3609 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3610 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003611}
3612
Jooyung Han690f5842020-12-04 13:02:04 +09003613TEST_F(AidlTest, EnumWithDefaults_Java) {
3614 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3615 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3616package p;
3617import p.Enum;
3618parcelable Foo {
3619 Enum e = Enum.BAR;
3620})");
3621 CaptureStderr();
3622 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3623 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3624 auto err = GetCapturedStderr();
3625 EXPECT_EQ("", err);
3626
3627 string code;
3628 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003629 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003630}
3631
3632TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3633 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3634 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3635package p;
3636import p.Enum;
3637parcelable Foo {
3638 Enum e = Enum.BAR;
3639})");
3640 CaptureStderr();
3641 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3642 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3643 auto err = GetCapturedStderr();
3644 EXPECT_EQ("", err);
3645
3646 string code;
3647 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3648 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3649}
3650
3651TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3652 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3653 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3654package p;
3655import p.Enum;
3656parcelable Foo {
3657 Enum e = Enum.BAR;
3658})");
3659 CaptureStderr();
3660 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3661 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3662 auto err = GetCapturedStderr();
3663 EXPECT_EQ("", err);
3664
3665 string code;
3666 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3667 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3668}
3669
3670TEST_F(AidlTest, EnumWithDefaults_Rust) {
3671 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3672 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3673package p;
3674import p.Enum;
3675parcelable Foo {
3676 int n = 42;
3677 Enum e = Enum.BAR;
3678})");
3679 CaptureStderr();
3680 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3681 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3682 auto err = GetCapturedStderr();
3683 EXPECT_EQ("", err);
3684
3685 string code;
3686 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3687 EXPECT_THAT(code, testing::HasSubstr(R"(
3688 fn default() -> Self {
3689 Self {
3690 n: 42,
3691 e: crate::mangled::_1_p_4_Enum::BAR,
3692 }
3693 })"));
3694}
3695
3696TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3697 import_paths_.insert("a");
3698 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3699 CaptureStderr();
3700 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3701package p;
3702import p.Enum;
3703parcelable Foo {
3704 int e = Enum.FOO | Enum.BAR;
3705})",
3706 typenames_, GetLanguage());
3707 auto err = GetCapturedStderr();
3708 EXPECT_EQ("", err);
3709 EXPECT_TRUE(type);
3710 const auto& fields = type->AsStructuredParcelable()->GetFields();
3711 EXPECT_EQ("int e = 3", fields[0]->ToString());
3712}
3713
3714TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3715 CaptureStderr();
3716 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3717@Backing(type="int")
3718enum Foo {
3719 STANDARD_SHIFT = 16,
3720 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3721 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3722}
3723)",
3724 typenames_, GetLanguage());
3725 auto err = GetCapturedStderr();
3726 EXPECT_EQ("", err);
3727 EXPECT_TRUE(type);
3728 const auto& enum_type = type->AsEnumDeclaration();
3729 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003730 auto writer = CodeWriter::ForString(&code);
3731 DumpVisitor visitor(*writer);
3732 visitor.Visit(*enum_type);
3733 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003734 EXPECT_EQ(R"--(@Backing(type="int")
3735enum Foo {
3736 STANDARD_SHIFT = 16,
3737 STANDARD_BT709 = 65536,
3738 STANDARD_BT601_625 = 131072,
3739}
3740)--",
3741 code);
3742}
3743
3744TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3745 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3746 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3747package p;
3748import p.Enum;
3749parcelable Foo {
3750 Enum e = Enum.FOO | Enum.BAR;
3751})");
3752 CaptureStderr();
3753 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3754 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3755 auto err = GetCapturedStderr();
3756 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3757 err);
3758}
3759
Jooyung Han361cd102021-05-24 11:30:10 +09003760TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
3761 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3762 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3763package p;
3764import p.Enum;
3765parcelable Foo {
3766 Enum e = 1;
3767})");
3768 CaptureStderr();
3769 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3770 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3771 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
3772}
3773
Jooyung Han690f5842020-12-04 13:02:04 +09003774TEST_P(AidlTest, DefaultWithEmptyArray) {
3775 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3776 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3777 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003778 auto options =
3779 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003780 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3781 auto err = GetCapturedStderr();
3782 EXPECT_EQ("", err);
3783}
3784
3785TEST_P(AidlTest, RejectRefsInAnnotation) {
3786 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3787 "package p; interface IFoo {\n"
3788 " const String ANNOTATION = \"@Annotation\";\n"
3789 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3790 "}");
3791 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003792 auto options =
3793 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003794 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3795 auto err = GetCapturedStderr();
3796 EXPECT_EQ(
3797 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3798 "ANNOTATION.\n",
3799 err);
3800}
3801
3802TEST_F(AidlTest, DefaultWithEnumValues) {
3803 io_delegate_.SetFileContents(
3804 "a/p/Foo.aidl",
3805 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3806 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3807 CaptureStderr();
3808 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3809 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3810 auto err = GetCapturedStderr();
3811 EXPECT_EQ("", err);
3812 string code;
3813 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3814 EXPECT_THAT(
3815 code, testing::HasSubstr(
3816 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3817}
3818
Jooyung Han14259392020-12-07 10:00:08 +09003819TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3820 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3821 CaptureStderr();
3822 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3823 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3824 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09003825 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09003826}
3827
3828TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3829 io_delegate_.SetFileContents("a/p/Foo.aidl",
3830 "package p; parcelable Foo { const int A = A + 1; }");
3831 CaptureStderr();
3832 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3833 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3834 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003835 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3836}
3837
3838TEST_F(AidlTest, RecursiveReferences) {
3839 io_delegate_.SetFileContents("a/p/Foo.aidl",
3840 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3841 io_delegate_.SetFileContents("a/p/Bar.aidl",
3842 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3843 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3844 CaptureStderr();
3845 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3846 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3847 EXPECT_EQ("", GetCapturedStderr());
3848}
3849
Jooyung Hanb9d60e02021-05-21 07:54:17 +09003850TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
3851 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
3852 auto options =
3853 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
3854 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
3855 CaptureStderr();
3856 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3857 EXPECT_EQ(err, GetCapturedStderr());
3858}
3859
3860TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
3861 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
3862 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
3863 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
3864 auto options =
3865 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
3866 CaptureStderr();
3867 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3868 EXPECT_EQ("", GetCapturedStderr());
3869}
3870
Jooyung Hane9f5b272021-01-07 00:18:11 +09003871TEST_P(AidlTest, UnknownConstReference) {
3872 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3873 auto options =
3874 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3875 const string err =
3876 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3877 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3878 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3879 CaptureStderr();
3880 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3881 EXPECT_EQ(err, GetCapturedStderr());
3882}
3883
Jooyung Han29813842020-12-08 01:28:03 +09003884TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3885 string contents = R"(
3886import android.os.IBinder;
3887import android.os.IInterface;
3888interface IFoo {}
3889 )";
3890 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003891}
3892
Jooyung Han888c5bc2020-12-22 17:28:47 +09003893TEST_P(AidlTest, WarningInterfaceName) {
3894 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003895 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003896 " -Weverything -o out -h out p/Foo.aidl");
3897 CaptureStderr();
3898 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003899 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003900 GetCapturedStderr());
3901}
3902
3903TEST_P(AidlTest, ErrorInterfaceName) {
3904 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003905 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003906 " -Weverything -Werror -o out -h out p/Foo.aidl");
3907 CaptureStderr();
3908 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003909 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003910 GetCapturedStderr());
3911}
3912
Jiyong Park9f4c3822021-04-07 20:36:45 +09003913TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
3914 const std::string input_file = "base/p/q/IFoo.aidl";
3915 const std::string header_dir = "out/";
3916 const std::string output_file = "out/base/p/q/IFoo.cpp";
3917 const std::string package = "p.q"; // not base.p.q
3918 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
3919
3920 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
3921 CaptureStderr();
3922 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3923 EXPECT_THAT(
3924 GetCapturedStderr(),
3925 testing::StartsWith(
3926 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
3927 "but is out/base/p/q/IFoo.cpp."));
3928}
3929
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09003930TEST_F(AidlTest, FormatCommentsForJava) {
3931 using android::aidl::FormatCommentsForJava;
3932
3933 struct TestCase {
3934 vector<Comment> comments;
3935 string formatted;
3936 };
3937 vector<TestCase> testcases = {
3938 {{}, ""},
3939 {{{"// line comments\n"}}, "// line comments\n"},
3940 {{{"// @hide \n"}}, "// @hide \n"},
3941 // Transform the last block comment as Javadoc.
3942 {{{"/*\n"
3943 " * Hello, world!\n"
3944 " */"}},
3945 "/**\n"
3946 " * Hello, world!\n"
3947 " */"},
3948 {{{"/* @hide */"}}, "/** @hide */"},
3949 {{{"/**\n"
3950 " @param foo ...\n"
3951 "*/"}},
3952 "/**\n"
3953 " @param foo ...\n"
3954 "*/"},
3955 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
3956 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
3957 "/* @deprecated first *//** @deprecated second */"},
3958 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
3959 // Line comments are printed as they are
3960 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
3961 };
3962 for (const auto& [input, formatted] : testcases) {
3963 EXPECT_EQ(formatted, FormatCommentsForJava(input));
3964 }
3965}
3966
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003967TEST_F(AidlTest, HideIsNotForArgs) {
3968 io_delegate_.SetFileContents("IFoo.aidl",
3969 "interface IFoo {\n"
3970 " void foo(in @Hide int x);\n"
3971 "}");
3972 auto options = Options::From("aidl --lang=java IFoo.aidl");
3973 CaptureStderr();
3974 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3975 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
3976}
3977
3978TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
3979 io_delegate_.SetFileContents(
3980 "IFoo.aidl",
3981 "interface IFoo {\n"
3982 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
3983 "}");
3984 auto options = Options::From("aidl --lang=java IFoo.aidl");
3985 CaptureStderr();
3986 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3987 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
3988}
3989
Jooyung Hanfd3be322020-12-13 09:11:06 +09003990struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09003991 string kind;
3992 string literal;
3993};
3994
Jooyung Hanfd3be322020-12-13 09:11:06 +09003995const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09003996 {"primitive", "int"}, {"primitiveArray", "int[]"},
3997 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09003998 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
3999 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4000 {"union", "a.Union"}, {"interface", "a.IBar"},
4001};
4002
4003const std::map<std::string, std::string> kListSupportExpectations = {
4004 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4005 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4006 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4007 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004008 {"cpp_primitiveArray", "List of arrays is not supported."},
4009 {"java_primitiveArray", "List of arrays is not supported."},
4010 {"ndk_primitiveArray", "List of arrays is not supported."},
4011 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004012 {"cpp_String", ""},
4013 {"java_String", ""},
4014 {"ndk_String", ""},
4015 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004016 {"cpp_StringArray", "List of arrays is not supported."},
4017 {"java_StringArray", "List of arrays is not supported."},
4018 {"ndk_StringArray", "List of arrays is not supported."},
4019 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004020 {"cpp_IBinder", ""},
4021 {"java_IBinder", ""},
4022 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4023 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004024 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004025 {"java_ParcelFileDescriptor", ""},
4026 {"ndk_ParcelFileDescriptor", ""},
4027 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004028 {"cpp_interface", "List<a.IBar> is not supported."},
4029 {"java_interface", "List<a.IBar> is not supported."},
4030 {"ndk_interface", "List<a.IBar> is not supported."},
4031 {"rust_interface", "List<a.IBar> is not supported."},
4032 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004033 {"java_parcelable", ""},
4034 {"ndk_parcelable", ""},
4035 {"rust_parcelable", ""},
4036 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4037 {"java_enum", "A generic type cannot have any primitive type parameters."},
4038 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4039 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004040 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004041 {"java_union", ""},
4042 {"ndk_union", ""},
4043 {"rust_union", ""},
4044};
4045
Jooyung Hand236e552020-12-13 09:21:27 +09004046const std::map<std::string, std::string> kArraySupportExpectations = {
4047 {"cpp_primitive", ""},
4048 {"java_primitive", ""},
4049 {"ndk_primitive", ""},
4050 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004051 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4052 {"java_primitiveArray", "Can only have one dimensional arrays."},
4053 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4054 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004055 {"cpp_String", ""},
4056 {"java_String", ""},
4057 {"ndk_String", ""},
4058 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004059 {"cpp_StringArray", "Can only have one dimensional arrays."},
4060 {"java_StringArray", "Can only have one dimensional arrays."},
4061 {"ndk_StringArray", "Can only have one dimensional arrays."},
4062 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004063 {"cpp_IBinder", ""},
4064 {"java_IBinder", ""},
4065 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4066 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4067 {"cpp_ParcelFileDescriptor", ""},
4068 {"java_ParcelFileDescriptor", ""},
4069 {"ndk_ParcelFileDescriptor", ""},
4070 {"rust_ParcelFileDescriptor", ""},
4071 {"cpp_interface", "Binder type cannot be an array"},
4072 {"java_interface", "Binder type cannot be an array"},
4073 {"ndk_interface", "Binder type cannot be an array"},
4074 {"rust_interface", "Binder type cannot be an array"},
4075 {"cpp_parcelable", ""},
4076 {"java_parcelable", ""},
4077 {"ndk_parcelable", ""},
4078 {"rust_parcelable", ""},
4079 {"cpp_enum", ""},
4080 {"java_enum", ""},
4081 {"ndk_enum", ""},
4082 {"rust_enum", ""},
4083 {"cpp_union", ""},
4084 {"java_union", ""},
4085 {"ndk_union", ""},
4086 {"rust_union", ""},
4087};
4088
Jooyung Hanfd3be322020-12-13 09:11:06 +09004089class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004090 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004091 void Run(const std::string& generic_type_decl,
4092 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004093 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004094 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004095 const auto& kind = std::get<1>(param).kind;
4096
4097 FakeIoDelegate io;
4098 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4099 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4100 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004101 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4102 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004103
4104 const auto options =
4105 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4106 CaptureStderr();
4107 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004108 auto it = expectations.find(lang + "_" + kind);
4109 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004110 const string err = GetCapturedStderr();
4111 if (it->second.empty()) {
4112 EXPECT_EQ("", err);
4113 } else {
4114 EXPECT_THAT(err, testing::HasSubstr(it->second));
4115 }
4116 }
4117};
4118
4119INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004120 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004121 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4122 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004123 testing::ValuesIn(kTypeParams)),
4124 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004125 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004126 });
4127
Jooyung Hanfd3be322020-12-13 09:11:06 +09004128TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4129 Run("List<{}>", kListSupportExpectations);
4130}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004131
Jooyung Hand236e552020-12-13 09:21:27 +09004132TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4133 Run("{}[]", kArraySupportExpectations);
4134}
4135
Christopher Wiley90be4e32015-10-20 14:55:25 -07004136} // namespace aidl
4137} // namespace android