blob: 5e887e23cd78c6cf88b7e12cd347c9b0d6657580 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090038#include "parser.h"
39#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070040#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041
42using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080043using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090044using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070046using std::string;
47using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080048using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090049using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070050using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090051using testing::internal::CaptureStderr;
52using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070053
54namespace android {
55namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070056namespace {
57
58const char kExpectedDepFileContents[] =
59R"(place/for/output/p/IFoo.java : \
60 p/IFoo.aidl
61
62p/IFoo.aidl :
63)";
64
Dan Willemsen93298ee2016-11-10 23:55:55 -080065const char kExpectedNinjaDepFileContents[] =
66R"(place/for/output/p/IFoo.java : \
67 p/IFoo.aidl
68)";
69
Jiyong Parkdf202122019-09-30 20:48:35 +090070const char kExpectedParcelableDeclarationDepFileContents[] =
71 R"( : \
72 p/Foo.aidl
73
74p/Foo.aidl :
75)";
76
77const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080078 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070079 p/Foo.aidl
80
81p/Foo.aidl :
82)";
83
Christopher Wileyf8136192016-04-12 14:19:35 -070084} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070085
Devin Moore7b8d5c92020-03-17 14:14:08 -070086class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070087 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090088 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
89 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070090 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070091 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090092 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070093 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090094 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070095 for (const string& s : additional_arguments) {
96 args.emplace_back(s);
97 }
98 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--preprocessed=" + f);
100 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700101 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900102 args.emplace_back("--include=" + i);
103 }
104 args.emplace_back(path);
105 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900106 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900107 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900109 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900110
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700111 if (error != nullptr) {
112 *error = actual_error;
113 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900114
115 if (actual_error != AidlError::OK) {
116 return nullptr;
117 }
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900120 EXPECT_EQ(1ul, defined_types.size());
121
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900122 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700123 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124
Devin Moore7b8d5c92020-03-17 14:14:08 -0700125 Options::Language GetLanguage() { return GetParam(); }
126
Christopher Wiley0522cd52015-10-28 15:39:44 -0700127 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800128 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900129 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900130 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700131};
132
Devin Moore7b8d5c92020-03-17 14:14:08 -0700133// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
134// tests with each of the supported languages as a parameter.
135INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
136 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700137 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700138 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900139 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 });
141
142TEST_P(AidlTest, AcceptMissingPackage) {
143 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700144}
145
Devin Moore7b8d5c92020-03-17 14:14:08 -0700146TEST_P(AidlTest, EndsInSingleLineComment) {
147 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700148}
149
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000150TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
151 const string expected_stderr =
152 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
153 const std::string file_contents = "package a; interface IBar {}";
154 CaptureStderr();
155 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
156 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
157}
158
159TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
160 const string expected_stderr =
161 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
162 const std::string file_contents = "package a; interface Bar {}";
163 CaptureStderr();
164 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
165 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
166}
167
168TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
169 const string expected_stderr =
170 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
171 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
172 CaptureStderr();
173 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
174 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
175}
176
177TEST_P(AidlTest, EnumRequiresCorrectPath) {
178 const string expected_stderr =
179 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
180 const std::string file_contents = "package a; enum Bar { A, }";
181 CaptureStderr();
182 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
183 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
184}
185
Devin Moore7b8d5c92020-03-17 14:14:08 -0700186TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900187 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700188 io_delegate_.SetFileContents("bar/IBar.aidl",
189 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700190 const string path = "foo/IFoo.aidl";
191 const string contents =
192 "package foo;\n"
193 "import bar.IBar;\n"
194 "interface IFoo { void f(in IBar[] input); }";
195 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
196 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700197 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700199}
200
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700202 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900204}
Devin Moore097a3ab2020-03-11 16:08:44 -0700205
Jiyong Park40782d02020-07-24 19:17:43 +0900206TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700207 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
208 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900209 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
210 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700211 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900214}
215
Jiyong Park40782d02020-07-24 19:17:43 +0900216TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900217 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700218 const string expected_stderr =
219 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700220 CaptureStderr();
221 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900223}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224
Jiyong Park40782d02020-07-24 19:17:43 +0900225TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900226 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900227 const string expected_stderr =
228 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700229 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700230 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700232}
233
Devin Moore7b8d5c92020-03-17 14:14:08 -0700234TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700235 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
236 const string expected_stderr =
237 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
238 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700239 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700241}
242
Devin Moore7b8d5c92020-03-17 14:14:08 -0700243TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700244 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
245 const string expected_stderr =
246 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
247 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800250}
251
Devin Moore2f2077a2020-08-28 11:27:53 -0700252TEST_P(AidlTest, AcceptNullableList) {
253 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
254 const string expected_stderr = "";
255 CaptureStderr();
256 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
258}
259
Devin Moore7b8d5c92020-03-17 14:14:08 -0700260TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700261 const string method = "package a; interface IFoo { void f(int a, int a); }";
262 const string expected_stderr =
263 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
264 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700265 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700266 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700267}
268
Jeongik Cha13066da2020-08-06 15:43:19 +0900269TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
270 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900271 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900272 CaptureStderr();
273 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
274 EXPECT_EQ(expected_stderr, GetCapturedStderr());
275}
276
Jooyung Hand902a972020-10-23 17:32:44 +0900277TEST_P(AidlTest, RejectsRepeatedAnnotations) {
278 const string method = R"(@Hide @Hide parcelable Foo {})";
279 const string expected_stderr =
280 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
281 "Foo.aidl:1.1-6\n";
282 CaptureStderr();
283 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
285}
286
Jooyung Han05bd8a82021-04-28 23:56:38 +0900287TEST_P(AidlTest, AcceptsEmptyParcelable) {
288 CaptureStderr();
289 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
290 EXPECT_EQ("", GetCapturedStderr());
291}
292
Devin Moore7b8d5c92020-03-17 14:14:08 -0700293TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700294 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
295 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
296 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700297 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700298 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100299}
300
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 AidlError error;
303 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700307 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 AidlError error;
312 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700313 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700314 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 AidlError error;
321 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700322 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700325 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800326}
327
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700329 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000330 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700331 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000332 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900333 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700334 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800335}
336
Jiyong Park40782d02020-07-24 19:17:43 +0900337TEST_P(AidlTest, ParsesNonNullableAnnotation) {
338 auto parse_result =
339 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
340 ASSERT_NE(nullptr, parse_result);
341 const AidlInterface* interface = parse_result->AsInterface();
342 ASSERT_NE(nullptr, interface);
343 ASSERT_FALSE(interface->GetMethods().empty());
344 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
345}
346
Devin Moore7b8d5c92020-03-17 14:14:08 -0700347TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900348 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
349 typenames_, GetLanguage());
350 ASSERT_NE(nullptr, parse_result);
351 const AidlInterface* interface = parse_result->AsInterface();
352 ASSERT_NE(nullptr, interface);
353 ASSERT_FALSE(interface->GetMethods().empty());
354 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
355}
356
357TEST_P(AidlTest, ParsesNonUtf8Annotations) {
358 auto parse_result =
359 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
360 ASSERT_NE(nullptr, parse_result);
361 const AidlInterface* interface = parse_result->AsInterface();
362 ASSERT_NE(nullptr, interface);
363 ASSERT_FALSE(interface->GetMethods().empty());
364 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900368 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
369 typenames_, GetLanguage());
370 ASSERT_NE(nullptr, parse_result);
371 const AidlInterface* interface = parse_result->AsInterface();
372 ASSERT_NE(nullptr, interface);
373 ASSERT_FALSE(interface->GetMethods().empty());
374 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800375}
376
Devin Moore7b8d5c92020-03-17 14:14:08 -0700377TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700378 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700379 const string expected_stderr =
380 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
381 "\"vintf\"'\n"
382 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
383 "--structured\n";
384 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700386 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700388 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700389}
390
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700393 const string expected_stderr =
394 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
395 "--structured\n";
396 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700397 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700398 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700400 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700401}
402
Devin Moore7b8d5c92020-03-17 14:14:08 -0700403TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700405 const string expected_stderr =
406 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
407 "\"vintf\"'\n";
408 CaptureStderr();
409 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700410 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700411 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700412 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700413}
414
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700416 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
418 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700419 ASSERT_EQ(AidlError::OK, error);
420 ASSERT_NE(nullptr, parse_result);
421 const AidlInterface* interface = parse_result->AsInterface();
422 ASSERT_NE(nullptr, interface);
423 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700424}
425
Jeongik Cha64783ed2019-06-07 18:30:54 +0900426TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
427 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900428 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
429 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900430 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700431 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900432 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900433 "a/Foo.aidl",
434 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900435
436 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900437 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700438 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900439 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700440 "Parcelable must be defined in AIDL directly.\n";
441 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900442 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700443 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700444
445 CaptureStderr();
446 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
447 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900448}
449
Jooyung Han1cbc4962020-10-25 10:07:15 +0900450TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
451 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
452 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
453 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900454 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
455
456 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900457 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900458 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
459
460 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900461 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900462 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
463
Jooyung Han1cbc4962020-10-25 10:07:15 +0900464 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900465 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
466}
467
Jooyung Han1cbc4962020-10-25 10:07:15 +0900468TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
469 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
470 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
471 CaptureStderr();
472 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
473 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
474 EXPECT_EQ("", GetCapturedStderr());
475
476 const string expected_to_string_method = R"--(
477 @Override
478 public String toString() {
479 switch (_tag) {
480 case a: return "a.Foo.a(" + (getA()) + ")";
481 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
482 }
483 throw new IllegalStateException("unknown field: " + _tag);
484 }
485)--";
486
487 string java_out;
488 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
489 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
490}
491
Jiyong Park9aa3d042020-12-04 23:30:02 +0900492TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
493 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
494 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
495 CaptureStderr();
496 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
497 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
498 EXPECT_EQ("", GetCapturedStderr());
499
500 const std::string expected = R"--(
501 @Override
502 public boolean equals(Object other) {
503 if (this == other) return true;
504 if (other == null) return false;
505 if (!(other instanceof Foo)) return false;
506 Foo that = (Foo)other;
507 if (!java.util.Objects.deepEquals(a, that.a)) return false;
508 if (!java.util.Objects.deepEquals(b, that.b)) return false;
509 return true;
510 }
511
512 @Override
513 public int hashCode() {
514 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
515 }
516)--";
517
518 string java_out;
519 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
520 EXPECT_THAT(java_out, testing::HasSubstr(expected));
521}
522
523TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
524 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
525 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
526 CaptureStderr();
527 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
528 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
529 EXPECT_EQ("", GetCapturedStderr());
530
531 const std::string expected = R"--(
532 @Override
533 public boolean equals(Object other) {
534 if (this == other) return true;
535 if (other == null) return false;
536 if (!(other instanceof Foo)) return false;
537 Foo that = (Foo)other;
538 if (_tag != that._tag) return false;
539 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
540 return true;
541 }
542
543 @Override
544 public int hashCode() {
545 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
546 }
547)--";
548
549 string java_out;
550 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
551 EXPECT_THAT(java_out, testing::HasSubstr(expected));
552}
553
Jooyung Han90345002020-10-23 15:28:53 +0900554TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900555 {
Jooyung Han90345002020-10-23 15:28:53 +0900556 io_delegate_.SetFileContents("a/Foo.aidl",
557 "package a; @JavaDerive(blah=true) parcelable Foo{}");
558 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
559 CaptureStderr();
560 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
561 const std::string expected_stderr =
562 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900563 EXPECT_THAT(GetCapturedStderr(),
564 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900565 }
566
567 {
568 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900569 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
570 CaptureStderr();
571 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900572 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900573 }
574
575 {
Jooyung Han90345002020-10-23 15:28:53 +0900576 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900577 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900580 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900581 }
582}
583
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900584TEST_P(AidlTest, ParseDescriptorAnnotation) {
585 AidlError error;
586 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
587 typenames_, GetLanguage(), &error, {"--structured"});
588 ASSERT_EQ(AidlError::OK, error);
589 ASSERT_NE(nullptr, parse_result);
590 const AidlInterface* interface = parse_result->AsInterface();
591 ASSERT_NE(nullptr, interface);
592 ASSERT_EQ("IBar", interface->GetDescriptor());
593}
594
Jiyong Park40782d02020-07-24 19:17:43 +0900595TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700596 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700597 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900598}
599
600TEST_P(AidlTest, AcceptsOnewayInterface) {
601 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700602 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700603}
Christopher Wileyef140932015-11-03 09:29:19 -0800604
Devin Moore7b8d5c92020-03-17 14:14:08 -0700605TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700606 const string oneway_method =
607 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700608 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100609}
610
Steven Moreland65297cc2020-04-20 20:17:36 -0700611TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
612 const string oneway_method =
613 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
614 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
615 ASSERT_NE(nullptr, defined);
616 const AidlInterface* iface = defined->AsInterface();
617 ASSERT_NE(nullptr, iface);
618
619 const auto& methods = iface->GetMethods();
620 ASSERT_EQ(1u, methods.size());
621 const auto& method = methods[0];
622 const AidlTypeSpecifier& ret_type = method->GetType();
623
624 // TODO(b/151102494): these annotations should be on the method
625 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
626 ASSERT_TRUE(ret_type.IsHide());
627}
628
Devin Moore7b8d5c92020-03-17 14:14:08 -0700629TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100630 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900631 R"(package a;
632 /* foo */
633 interface IFoo {
634 /* i */
635 int i();
636 // j
637 @nullable String j();
638 // k1
639 /* k2 */
640 @UnsupportedAppUsage oneway void k(int a);
641 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100642
Jooyung Han8451a202021-01-16 03:07:06 +0900643 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700644 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100645 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900646 EXPECT_EQ("", GetCapturedStderr());
647
Jooyung Han161bb0f2021-01-21 12:30:16 +0900648 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100649
650 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900651 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
652 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
653 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100654}
655
Jooyung Han1a551d32020-10-05 15:37:26 +0900656TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
657 io_delegate_.SetFileContents("p/cpp_header.aidl",
658 R"(package p;
659 parcelable cpp_header cpp_header "bar/header";)");
660 import_paths_.emplace("");
661 const string input_path = "p/IFoo.aidl";
662 const string input = R"(package p;
663 import p.cpp_header;
664 interface IFoo {
665 // get bar
666 cpp_header get();
667 })";
668
669 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
670 EXPECT_NE(nullptr, parse_result);
671 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900672 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900673}
674
Christopher Wileyef140932015-11-03 09:29:19 -0800675TEST_F(AidlTest, ParsesPreprocessedFile) {
676 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
677 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700678 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900679 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700680 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
681 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800682}
683
684TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
685 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
686 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900687
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700688 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900689 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700690 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
691 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800692}
693
Devin Moore7b8d5c92020-03-17 14:14:08 -0700694TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800695 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
696 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
697 "interface IBar {}");
698 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900699 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900700 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700701 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800702 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900703
Christopher Wiley41544372015-11-03 14:52:29 -0800704 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700705 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
706 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800707 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900708 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900709 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900710 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800711}
712
Jiyong Park8f6ec462020-01-19 20:52:47 +0900713// Special case of PreferImportToPreprocessed. Imported type should be preferred
714// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700715TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900716 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
717 io_delegate_.SetFileContents("one/IBar.aidl",
718 "package one; "
719 "interface IBar {}");
720 preprocessed_files_.push_back("preprocessed");
721 import_paths_.emplace("");
722 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700723 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900724 EXPECT_NE(nullptr, parse_result);
725
726 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700727 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
728 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900729 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900730 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900731 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900732 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
733}
734
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800735TEST_F(AidlTest, WritePreprocessedFile) {
736 io_delegate_.SetFileContents("p/Outer.aidl",
737 "package p; parcelable Outer.Inner;");
738 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
739 "interface IBar {}");
740
Jooyung Han93f48f02021-06-05 00:11:16 +0900741 vector<string> args{"aidl", "--preprocess", "preprocessed",
742 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900743 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900744 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800745
Jooyung Han93f48f02021-06-05 00:11:16 +0900746 std::map<std::string, std::string> expected = {{"preprocessed",
747 "parcelable p.Outer.Inner;\n"
748 "interface one.IBar {\n"
749 "}\n"}};
750 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
751}
752
753TEST_F(AidlTest, PreprocessVariousThings) {
754 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
755 "package foo.bar;\n"
756 "interface IFoo {\n"
757 " int foo();\n"
758 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
759 "}\n");
760 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
761 "package foo.bar;\n"
762 "parcelable Bar {\n"
763 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
764 " imported.Foo foo;\n"
765 "}\n");
766 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
767 "package foo.bar;\n"
768 "parcelable Gen<T> {\n"
769 "}\n");
770 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
771 "package foo.bar;\n"
772 "enum Enum {\n"
773 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
774 "}\n");
775 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
776 "package imported;\n"
777 "parcelable Foo {\n"
778 " const int FOO = 42;\n"
779 "}\n");
780
781 vector<string> args = {
782 "aidl",
783 "--preprocess",
784 "preprocessed",
785 "-Isub",
786 "-I.",
787 "foo/bar/IFoo.aidl",
788 "foo/bar/Bar.aidl",
789 "foo/bar/Gen.aidl",
790 "foo/bar/Enum.aidl",
791 };
792 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
793 std::string preprocessed =
794 "interface foo.bar.IFoo {\n"
795 " const int FOO = 44;\n"
796 "}\n"
797 "parcelable foo.bar.Bar {\n"
798 " const int BAR = 43;\n"
799 "}\n"
800 "parcelable foo.bar.Gen<T> {\n"
801 "}\n"
802 "enum foo.bar.Enum {\n"
803 " FOO = 3,\n"
804 " BAR = 6,\n"
805 "}\n";
806 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
807 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
808
809 // use preprocessed
810 io_delegate_.SetFileContents("a/Foo.aidl",
811 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
812 io_delegate_.SetFileContents("preprocessed", preprocessed);
813 CaptureStderr();
814 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
815 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
816 EXPECT_EQ("", GetCapturedStderr());
817 string code;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
819 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
820}
821
Jooyung Han35784982021-06-29 06:26:12 +0900822TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
823 io_delegate_.SetFileContents("p/IFoo.aidl",
824 "package p;\n"
825 "import x.Outer;\n"
826 "interface IFoo {\n"
827 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
828 "}");
829 io_delegate_.SetFileContents("imported/x/Outer.aidl",
830 "package x;\n"
831 "parcelable Outer.Inner1;\n"
832 "parcelable Outer.Inner2;\n");
833 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
834 CaptureStderr();
835 EXPECT_EQ(0, ::android::aidl::compile_aidl(opt, io_delegate_));
836 EXPECT_EQ("", GetCapturedStderr());
837}
838
839TEST_F(AidlTest,
840 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
841 // Main doc(Foo.aidl) is loaded
842 // And then framework.aidl is loaded as preprocessed. (conflict)
843 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
844 io_delegate_.SetFileContents("x/Foo.aidl",
845 "package x;\n"
846 "parcelable Foo.Inner;\n");
847 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
848 CaptureStderr();
849 EXPECT_EQ(0, ::android::aidl::compile_aidl(opt, io_delegate_));
850 EXPECT_EQ("", GetCapturedStderr());
851}
852
853TEST_F(AidlTest,
854 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
855 // Main doc(IBar.aidl) is loaded first.
856 // Framework.aidl is loaded as preprocessed.
857 // And then import(Foo.aidl) is loaded. (conflict)
858 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
859 io_delegate_.SetFileContents("x/IBar.aidl",
860 "package x;\n"
861 "import x.Foo;\n"
862 "interface IBar {\n"
863 " void bar(in Foo.Inner inner);\n"
864 "}");
865 io_delegate_.SetFileContents("x/Foo.aidl",
866 "package x;\n"
867 "parcelable Foo.Inner;\n");
868 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
869 CaptureStderr();
870 EXPECT_EQ(0, ::android::aidl::compile_aidl(opt, io_delegate_));
871 EXPECT_EQ("", GetCapturedStderr());
872}
873
Jooyung Han93f48f02021-06-05 00:11:16 +0900874TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
875 string simple_content = "package xxx; parcelable a.Foo;";
876 io_delegate_.SetFileContents("path", simple_content);
877 CaptureStderr();
878 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
879 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
880}
881
882TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
883 string simple_content = "parcelable a.Foo {}";
884 io_delegate_.SetFileContents("path", simple_content);
885 CaptureStderr();
886 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
887 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800888}
889
Jooyung Han13f1fa52021-06-11 18:06:12 +0900890TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
891 string contents = R"(
892 interface android.os.IBinder;
893 interface android.os.IInterface;
894 parcelable android.os.ParcelFileDescriptor;
895 )";
896 io_delegate_.SetFileContents("path", contents);
897 CaptureStderr();
898 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
899 EXPECT_THAT(GetCapturedStderr(), "");
900}
901
Jooyung Han720253d2021-01-05 19:13:17 +0900902TEST_P(AidlTest, SupportDeprecated) {
903 struct TestCase {
904 std::string output_file;
905 std::string annotation;
906 };
907
908 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900909 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900910 io_delegate_.SetFileContents(filename, contents);
911
912 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
913 " --out=out --header_out=out");
914 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900915 for (const auto& [lang, test_case] : expectations) {
916 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900917 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900918 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900919 EXPECT_THAT(output, HasSubstr(test_case.annotation));
920 }
921 };
922
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900923 // Emit escaped string for notes
924 CheckDeprecated(
925 "IFoo.aidl",
926 R"(interface IFoo {
927 /**
928 * @note asdf
929 * @deprecated a really long deprecation message
930 *
931 * which is really long
932 * @param foo bar
933 */
934 List<String> foo();
935 })",
936 {
937 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
938 {Options::Language::CPP,
939 {"out/IFoo.h",
940 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
941 {Options::Language::NDK,
942 {"out/aidl/IFoo.h",
943 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
944 {Options::Language::RUST,
945 {"out/IFoo.rs",
946 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
947 });
948
Jooyung Han24effbf2021-01-16 10:24:03 +0900949 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900950 CheckDeprecated(
951 "IFoo.aidl",
952 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900953 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900954 " List<String> foo();\n"
955 "}",
956 {
957 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900958 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900959 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
960 {Options::Language::NDK,
961 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
962 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
963 });
Jooyung Han720253d2021-01-05 19:13:17 +0900964
Jooyung Han24effbf2021-01-16 10:24:03 +0900965 // but not in line comments
966 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
967 EXPECT_FALSE(parsed->IsDeprecated());
968
969 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900970 CheckDeprecated("Foo.aidl",
971 "parcelable Foo {\n"
972 " /** @deprecated use bar*/\n"
973 " int foo = 0;\n"
974 "}",
975 {
976 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
977 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
978 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
979 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
980 });
981
Jooyung Han24effbf2021-01-16 10:24:03 +0900982 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900983 CheckDeprecated("IFoo.aidl",
984 "interface IFoo {\n"
985 " /** @deprecated use bar*/\n"
986 " const int FOO = 0;\n"
987 "}",
988 {
989 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
990 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
991 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
992 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
993 });
994
995 // union fields
996 CheckDeprecated("Foo.aidl",
997 "union Foo {\n"
998 " int bar = 0;\n"
999 " /** @deprecated use bar*/\n"
1000 " int foo;\n"
1001 "}",
1002 {
1003 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1004 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1005 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1006 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1007 });
1008
1009 CheckDeprecated("Foo.aidl",
1010 "/** @deprecated use Bar */\n"
1011 "parcelable Foo {}",
1012 {
1013 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1014 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1015 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1016 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1017 });
1018
1019 CheckDeprecated("Foo.aidl",
1020 "/** @deprecated use Bar */\n"
1021 "union Foo { int foo = 0; }",
1022 {
1023 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1024 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1025 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1026 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1027 });
1028
1029 CheckDeprecated("IFoo.aidl",
1030 "/** @deprecated use IBar */\n"
1031 "interface IFoo {}",
1032 {
1033 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1034 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1035 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1036 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1037 });
1038
1039 CheckDeprecated("Foo.aidl",
1040 "/** @deprecated use IBar */\n"
1041 "enum Foo { FOO }",
1042 {
1043 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1044 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1045 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001046 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001047 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1048 });
1049}
1050
Devin Moore7b8d5c92020-03-17 14:14:08 -07001051TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001052 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001053 io_delegate_.SetFileContents("p/Outer.aidl",
1054 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001055 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001056 CaptureStderr();
1057 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1058 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001061}
1062
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001064 io_delegate_.SetFileContents("preprocessed",
1065 "parcelable p.Outer.Inner;");
1066 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001067 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001068 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001069 // TODO(wiley): This should actually return nullptr because we require
1070 // the outer class name. However, for legacy reasons,
1071 // this behavior must be maintained. b/17415692
1072 EXPECT_NE(nullptr, parse_result);
1073}
1074
Christopher Wiley632801d2015-11-05 14:15:49 -08001075TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001076 const string expected_foo_stderr =
1077 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1078 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1079 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001080 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1081
Christopher Wiley632801d2015-11-05 14:15:49 -08001082 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001083 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001084 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001085 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001086 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001087
Steven Morelande2c64b42018-09-18 15:06:37 -07001088 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001089 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001090 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001091 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001092 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001093
Devin Moore097a3ab2020-03-11 16:08:44 -07001094 const string expected_bar_stderr =
1095 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1096 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1097 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001098 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1099
Jiyong Parkda8c6932019-08-12 19:56:08 +09001100 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001101 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001102 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +09001103 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001104 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001105 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001106 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -07001107 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001108 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001109}
1110
Jooyung Han13f1fa52021-06-11 18:06:12 +09001111TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1112 string contents = R"(
1113 import android.os.IBinder;
1114 import android.os.IInterface;
1115 interface IFoo {
1116 void foo(in IBinder b);
1117 }
1118 )";
1119 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1120}
1121
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001123 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001124 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001125 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001126 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
1127 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001128 AidlError error;
1129 CaptureStderr();
1130 EXPECT_EQ(
1131 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001132 Parse("p/IFoo.aidl",
1133 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001134 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001135 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1136 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001137}
1138
Devin Moore7b8d5c92020-03-17 14:14:08 -07001139TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001140 AidlError error;
1141 const string expected_stderr =
1142 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1143 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001144 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1145 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001146 interface IFoo {
1147 const String DUPLICATED = "d";
1148 const int DUPLICATED = 1;
1149 }
1150 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001151 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1153 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001154}
1155
Steven Morelande689da22020-11-10 02:06:30 +00001156TEST_P(AidlTest, FailOnTooBigConstant) {
1157 AidlError error;
1158 const string expected_stderr =
1159 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1160 CaptureStderr();
1161 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1162 R"(package p;
1163 interface IFoo {
1164 const byte type2small = 256;
1165 }
1166 )",
1167 typenames_, GetLanguage(), &error));
1168 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1169 EXPECT_EQ(AidlError::BAD_TYPE, error);
1170}
1171
Jooyung Han30f64ad2020-12-15 08:16:31 +09001172TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1173 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1174 CaptureStderr();
1175 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1176 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1177 EXPECT_EQ("", GetCapturedStderr());
1178 string code;
1179 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1180 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1181}
1182
Jooyung Han535c5e82020-12-29 15:16:59 +09001183TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001184 using Ptr = unique_ptr<AidlConstantValue>;
1185 const AidlLocation& loc = AIDL_LOCATION_HERE;
1186
Jooyung Han535c5e82020-12-29 15:16:59 +09001187 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1188 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1189 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1190 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001191
1192 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1193 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001194 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001195
1196 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1197 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1198 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1199 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001200 EXPECT_EQ(
1201 expected,
1202 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001203}
1204
Devin Moore7b8d5c92020-03-17 14:14:08 -07001205TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001206 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001207 const string expected_stderr =
1208 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001209 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001210 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1211 R"(package p;
1212 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001213 parcelable IBar {}
1214 parcelable StructuredParcelable {}
1215 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001216 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001217 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001218 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001219 // Parse success is important for clear error handling even if the cases aren't
1220 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001221 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001222}
1223
Devin Moore7b8d5c92020-03-17 14:14:08 -07001224TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001225 AidlError error;
1226 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1227 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001228 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001229 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1230 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001231}
1232
Steven Morelandf9e922f2020-07-08 21:15:27 +00001233TEST_P(AidlTest, FailOnEmptyListWithComma) {
1234 AidlError error;
1235 const string expected_stderr =
1236 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1237 CaptureStderr();
1238 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1239 typenames_, GetLanguage(), &error));
1240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1241 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1242}
1243
Devin Moore7b8d5c92020-03-17 14:14:08 -07001244TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001245 AidlError error;
1246 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001247 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001248 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001249 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1250 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001251 interface IFoo {
1252 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1253 }
1254 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001255 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1257 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001258}
1259
Jiyong Park18132182020-06-08 20:24:40 +09001260TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1261 AidlError error;
1262 const string expected_stderr =
1263 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1264 "cpp_header (which can also be used as an identifier)\n";
1265 CaptureStderr();
1266 // Notice the trailing dot(.) in the name, which isn't a correct name
1267 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1268 GetLanguage(), &error));
1269 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1270 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1271}
1272
1273TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1274 AidlError error;
1275 const string expected_stderr =
1276 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1277 "cpp_header (which can also be used as an identifier)\n";
1278 CaptureStderr();
1279 // Notice the trailing dot(.) in the package name
1280 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1281 GetLanguage(), &error));
1282 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1283 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1284}
1285
Devin Moore7b8d5c92020-03-17 14:14:08 -07001286TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001287 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001288 auto parse_result = Parse("p/IFoo.aidl",
1289 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001290 interface IFoo {
1291 const int POSITIVE_HEX_VALUE = 0xf5;
1292 }
1293 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001294 typenames_, GetLanguage(), &error);
1295 EXPECT_NE(nullptr, parse_result);
1296 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001297 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001298 const auto& cpp_constants = interface->GetConstantDeclarations();
1299 EXPECT_EQ((size_t)1, cpp_constants.size());
1300 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001301 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001302 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001303}
1304
Devin Moore7b8d5c92020-03-17 14:14:08 -07001305TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001306 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001307 auto parse_result = Parse("p/IFoo.aidl",
1308 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001309 interface IFoo {
1310 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1311 }
1312 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001313 typenames_, GetLanguage(), &error);
1314 ASSERT_NE(nullptr, parse_result);
1315 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001316 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001317 const auto& cpp_constants = interface->GetConstantDeclarations();
1318 EXPECT_EQ((size_t)1, cpp_constants.size());
1319 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001320 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001321 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001322}
1323
Devin Moore7b8d5c92020-03-17 14:14:08 -07001324TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001325 io_delegate_.SetFileContents(
1326 "p/Outer.aidl",
1327 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001328 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001329 const string input_path = "p/IFoo.aidl";
1330 const string input = "package p; import p.Outer; interface IFoo"
1331 " { Outer.Inner get(); }";
1332
Devin Moore7b8d5c92020-03-17 14:14:08 -07001333 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1334 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001335
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001336 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001337 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001338 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001339 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001340}
1341
Jooyung Han78fcaa82021-06-11 22:27:57 +09001342TEST_P(AidlTest, UnderstandsNestedParcelablesWithoutImports) {
1343 io_delegate_.SetFileContents("p/Outer.aidl",
1344 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1345 import_paths_.emplace("");
1346 const string input_path = "p/IFoo.aidl";
1347 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1348
1349 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1350 EXPECT_NE(nullptr, parse_result);
1351
1352 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1353 // C++ uses "::" instead of "." to refer to a inner class.
1354 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1355 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1356}
1357
Jooyung Han0a950bd2021-05-15 12:50:36 +09001358TEST_F(AidlTest, CppNameOf_GenericType) {
1359 io_delegate_.SetFileContents("p/Wrapper.aidl", "package p; parcelable Wrapper<T> { T wrapped; }");
1360 import_paths_.emplace("");
1361 // Since we don't support compilation of Wrapper directly (due to "T" reference),
1362 // prepare Holder so that Wrapper gets parsed into AidlTypenames
1363 const string input_path = "p/Holder.aidl";
1364 const string input =
1365 "package p; import p.Wrapper; parcelable Holder {\n"
1366 " @nullable Wrapper<String> value;\n"
1367 "}";
1368
1369 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1370 EXPECT_NE(nullptr, parse_result);
1371
1372 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1373 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1374 (..., params->emplace_back(std::move(type_params)));
1375 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1376 };
1377
1378 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1379 std::vector<AidlAnnotation> annotations;
1380 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", nullptr, {}));
1381 type->Annotate(std::move(annotations));
1382 return std::move(type);
1383 };
1384
1385 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1386 (void)type->SetArray();
1387 return std::move(type);
1388 };
1389
1390 auto w = type("p.Wrapper", type("String"));
1391 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1392
1393 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1394 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1395 cpp::CppNameOf(*nullable_w, typenames_));
1396
1397 auto array_w = set_array(type("p.Wrapper", type("String")));
1398 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1399 cpp::CppNameOf(*array_w, typenames_));
1400
1401 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1402 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1403 cpp::CppNameOf(*nullable_array_w, typenames_));
1404
1405 auto list_w = type("List", type("p.Wrapper", type("String")));
1406 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1407 cpp::CppNameOf(*list_w, typenames_));
1408
1409 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1410 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1411 cpp::CppNameOf(*nullable_list_w, typenames_));
1412}
1413
Devin Moore7b8d5c92020-03-17 14:14:08 -07001414TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001415 io_delegate_.SetFileContents(
1416 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001417 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001418 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001419 const string input_path = "p/IFoo.aidl";
1420 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001421 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1422 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001423 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001424 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001425 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001426
1427 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1428 // C++ understands C++ specific stuff
1429 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1430 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001431 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001432 EXPECT_EQ(1u, headers.size());
1433 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001434}
1435
Christopher Wileyf8136192016-04-12 14:19:35 -07001436TEST_F(AidlTest, WritesCorrectDependencyFile) {
1437 // While the in tree build system always gives us an output file name,
1438 // other android tools take advantage of our ability to infer the intended
1439 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001440 vector<string> args = {
1441 "aidl",
1442 "-d dep/file/path",
1443 "-o place/for/output",
1444 "p/IFoo.aidl"};
1445 Options options = Options::From(args);
1446 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001447 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001448 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001449 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001450 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1451}
1452
Dan Willemsen93298ee2016-11-10 23:55:55 -08001453TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1454 // While the in tree build system always gives us an output file name,
1455 // other android tools take advantage of our ability to infer the intended
1456 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001457 vector<string> args = {
1458 "aidl",
1459 "-d dep/file/path",
1460 "--ninja",
1461 "-o place/for/output",
1462 "p/IFoo.aidl"};
1463 Options options = Options::From(args);
1464 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001465 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001466 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001467 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001468 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1469}
1470
Jiyong Parkdf202122019-09-30 20:48:35 +09001471TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001472 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1473 // this by calling aidl with every .aidl file it finds, then parsing the
1474 // generated dependency files. Those that reference .java output files are
1475 // for interfaces and those that do not are parcelables. However, for both
1476 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001477 vector<string> args = {
1478 "aidl",
1479 "-o place/for/output",
1480 "-d dep/file/path",
1481 "p/Foo.aidl"};
1482 Options options = Options::From(args);
1483 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001484 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001485 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001486 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001487 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1488}
1489
1490TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1491 vector<string> args = {
1492 "aidl",
1493 "--structured",
1494 "-o place/for/output",
1495 "-d dep/file/path",
1496 "p/Foo.aidl"};
1497 Options options = Options::From(args);
1498 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1499 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1500 string actual_dep_file_contents;
1501 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1502 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001503}
1504
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001505TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1506 vector<string> args = {
1507 "aidl",
1508 "--lang=java",
1509 "-o place/for/output",
1510 "p/Foo.aidl"};
1511 Options options = Options::From(args);
1512 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1513 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1514 string output_file_contents;
1515 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1516}
1517
Devin Moore21b26772020-08-26 16:37:56 -07001518TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001519 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001520 const string list_array_parcelable =
1521 "package a; parcelable Foo {\n"
1522 " List[] lists; }";
1523 CaptureStderr();
1524 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1525 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1526}
1527
Jiyong Parkf8d53612020-05-04 14:06:13 +09001528TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1529 AidlError error;
1530 string expected_stderr =
1531 "ERROR: a/IFoo.aidl:2.7-11: "
1532 "Encountered an untyped List or Map. The use of untyped List/Map is "
1533 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1534 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1535 if (GetLanguage() != Options::Language::JAVA) {
1536 expected_stderr =
1537 "ERROR: a/IFoo.aidl:2.1-7: "
1538 "Currently, only the Java backend supports non-generic List.\n";
1539 }
1540
1541 const string primitive_interface =
1542 "package a; interface IFoo {\n"
1543 " List foo(); }";
1544 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001545 AidlTypenames tn1;
1546 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001547 {"--structured"}));
1548 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001549
1550 string primitive_parcelable =
1551 "package a; parcelable IFoo {\n"
1552 " List foo;}";
1553 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001554 AidlTypenames tn2;
1555 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001556 {"--structured"}));
1557 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1558}
1559
Jeongik Cha225519b2020-08-29 01:55:32 +09001560TEST_P(AidlTest, ExtensionTest) {
1561 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001562 string extendable_parcelable =
1563 "package a; parcelable Data {\n"
1564 " ParcelableHolder extension;\n"
1565 " ParcelableHolder extension2;\n"
1566 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001567 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001568 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1569 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001570 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001571 "yet.\n",
1572 GetCapturedStderr());
1573 } else {
1574 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1575 EXPECT_EQ("", GetCapturedStderr());
1576 }
1577}
1578TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1579 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001580 string parcelableholder_return_interface =
1581 "package a; interface IFoo {\n"
1582 " ParcelableHolder foo();\n"
1583 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001584 EXPECT_EQ(nullptr,
1585 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001586
Jeongik Cha8f02a532020-10-14 00:16:28 +09001587 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001588 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001589 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001590 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001591 "yet.\n",
1592 GetCapturedStderr());
1593 return;
1594 }
1595 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1596 GetCapturedStderr());
1597}
1598
1599TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1600 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001601 string extendable_parcelable_arg_interface =
1602 "package a; interface IFoo {\n"
1603 " void foo(in ParcelableHolder ph);\n"
1604 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001605 EXPECT_EQ(nullptr,
1606 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1607
Jeongik Cha8f02a532020-10-14 00:16:28 +09001608 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001609 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001610 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001611 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001612 "yet.\n",
1613 GetCapturedStderr());
1614 return;
1615 }
1616 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1617 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001618}
1619
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001620TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1621 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001622 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001623 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1624 CaptureStderr();
1625 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1626 if (GetLanguage() == Options::Language::RUST) {
1627 EXPECT_EQ(
1628 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1629 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1630 "yet.\n",
1631 GetCapturedStderr());
1632 return;
1633 }
1634 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1635}
1636
Jooyung Han3f347ca2020-12-01 12:41:50 +09001637TEST_P(AidlTest, ParcelablesWithConstants) {
1638 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001639 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001640 CaptureStderr();
1641 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1642 EXPECT_EQ("", GetCapturedStderr());
1643}
1644
1645TEST_P(AidlTest, UnionWithConstants) {
1646 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001647 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001648 CaptureStderr();
1649 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1650 EXPECT_EQ("", GetCapturedStderr());
1651}
1652
Jooyung Han633eab62021-01-07 14:12:40 +09001653TEST_F(AidlTest, ConstantsWithAnnotations) {
1654 io_delegate_.SetFileContents("IFoo.aidl",
1655 "interface IFoo {\n"
1656 " @JavaPassthrough(annotation=\"@Foo\")\n"
1657 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1658 "}");
1659 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1660 CaptureStderr();
1661 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1662 EXPECT_EQ("", GetCapturedStderr());
1663 string code;
1664 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1665 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1666 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1667}
1668
Jiyong Park02da7422018-07-16 16:00:26 +09001669TEST_F(AidlTest, ApiDump) {
1670 io_delegate_.SetFileContents(
1671 "foo/bar/IFoo.aidl",
1672 "package foo.bar;\n"
1673 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001674 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001675 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001676 " /* @hide applied \n"
1677 " @deprecated use foo2 */\n"
1678 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1679 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001680 " IFoo foo3(IFoo foo);\n"
1681 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001682 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001683 " /** blahblah\n"
1684 " @deprecated\n"
1685 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001686 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001687 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001688 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001689 "}\n");
1690 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1691 "package foo.bar;\n"
1692 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001693 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001694 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001695 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001696 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001697 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001698 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001699 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001700 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001701 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001702 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001703 "}\n");
1704 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001705 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1706 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001707 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001708 bool result = dump_api(options, io_delegate_);
1709 ASSERT_TRUE(result);
1710 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001711 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001712 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001713interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001714 /**
1715 * @hide
1716 * @deprecated use foo2
1717 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001718 int foo(out int[] a, String b, boolean c, inout List<String> d);
1719 int foo2(@utf8InCpp String x, inout List<String> y);
1720 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1721 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001722 /**
1723 * @deprecated reason why...
1724 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001725 const int A = 1;
1726 const String STR = "Hello";
1727}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001728)"),
1729 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001730
Jiyong Parke59c3682018-09-11 23:10:25 +09001731 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001732 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001733/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001734parcelable Data {
1735 int x = 10;
1736 int y;
1737 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001738 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001739}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001740)"),
1741 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001742}
1743
Jiyong Parked65bf42018-08-28 15:43:27 +09001744TEST_F(AidlTest, ApiDumpWithManualIds) {
1745 io_delegate_.SetFileContents(
1746 "foo/bar/IFoo.aidl",
1747 "package foo.bar;\n"
1748 "interface IFoo {\n"
1749 " int foo() = 1;\n"
1750 " int bar() = 2;\n"
1751 " int baz() = 10;\n"
1752 "}\n");
1753
Jiyong Parke59c3682018-09-11 23:10:25 +09001754 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001755 Options options = Options::From(args);
1756 bool result = dump_api(options, io_delegate_);
1757 ASSERT_TRUE(result);
1758 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001759 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001760 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001761interface IFoo {
1762 int foo() = 1;
1763 int bar() = 2;
1764 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001765}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001766)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001767}
1768
1769TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001770 const string expected_stderr =
1771 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1772 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001773 io_delegate_.SetFileContents(
1774 "foo/bar/IFoo.aidl",
1775 "package foo.bar;\n"
1776 "interface IFoo {\n"
1777 " int foo() = 1;\n"
1778 " int bar();\n"
1779 " int baz() = 10;\n"
1780 "}\n");
1781
Jiyong Parke59c3682018-09-11 23:10:25 +09001782 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001783 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001784 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001785 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001786 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001787}
1788
Jooyung Han965e31d2020-11-27 12:30:16 +09001789TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1790 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1791 "package foo.bar;\n"
1792 "interface IFoo {\n"
1793 " @utf8InCpp String foo();\n"
1794 " const @utf8InCpp String bar = \"bar\";\n"
1795 "}\n");
1796
1797 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1798 Options options = Options::From(args);
1799 CaptureStderr();
1800 EXPECT_TRUE(dump_api(options, io_delegate_));
1801 EXPECT_EQ("", GetCapturedStderr());
1802 string actual;
1803 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001804 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1805interface IFoo {
1806 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001807 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001808}
1809)"),
1810 actual);
1811}
1812
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001813TEST_F(AidlTest, ApiDumpWithEnums) {
1814 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1815 "package foo.bar;\n"
1816 "enum Enum {\n"
1817 " FOO,\n"
1818 " BAR = FOO + 1,\n"
1819 "}\n");
1820
1821 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1822 Options options = Options::From(args);
1823 CaptureStderr();
1824 EXPECT_TRUE(dump_api(options, io_delegate_));
1825 EXPECT_EQ("", GetCapturedStderr());
1826 string actual;
1827 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1828 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1829 "enum Enum {\n"
1830 " FOO = 0,\n"
1831 " BAR = 1,\n"
1832 "}\n"),
1833 actual);
1834}
1835
1836TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1837 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1838 "package foo.bar;\n"
1839 "enum Enum {\n"
1840 " FOO,\n"
1841 "}\n");
1842 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1843 "package foo.bar;\n"
1844 "import foo.bar.Enum;\n"
1845 "parcelable Foo {\n"
1846 " Enum e = Enum.FOO;\n"
1847 "}\n");
1848
1849 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1850 Options options = Options::From(args);
1851 CaptureStderr();
1852 EXPECT_TRUE(dump_api(options, io_delegate_));
1853 EXPECT_EQ("", GetCapturedStderr());
1854 string actual;
1855 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1856 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1857 "parcelable Foo {\n"
1858 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1859 "}\n"),
1860 actual);
1861}
1862
Jooyung Han71dfec32021-05-23 07:18:58 +09001863TEST_F(AidlTest, ApiDumpWithGenerics) {
1864 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1865 "package foo.bar;\n"
1866 "parcelable Foo<T, U> {\n"
1867 "}\n");
1868
1869 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1870 Options options = Options::From(args);
1871 CaptureStderr();
1872 EXPECT_TRUE(dump_api(options, io_delegate_));
1873 EXPECT_EQ("", GetCapturedStderr());
1874 string actual;
1875 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1876 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1877 "parcelable Foo<T, U> {\n"
1878 "}\n"),
1879 actual);
1880}
1881
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001882TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001883 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001884 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1885 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001886 const string expected_map_stderr =
1887 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001888 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1889 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001890 "package p; interface IFoo {"
1891 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001892 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001893 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001894 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001895
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001896 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001897 "package p; interface IFoo {"
1898 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001899 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001900 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001901 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001902}
1903
Jeongik Chae48d9942020-01-02 17:39:00 +09001904TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001905 const string expected_stderr =
1906 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09001907 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09001908 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1909
1910 io_delegate_.SetFileContents("p/IFoo.aidl",
1911 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001912 "Map<String, p.Bar> foo();}");
Jeongik Chae48d9942020-01-02 17:39:00 +09001913 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1914
1915 io_delegate_.SetFileContents("p/IFoo.aidl",
1916 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001917 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001918 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001919 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001920 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001921
1922 io_delegate_.SetFileContents("p/IFoo.aidl",
1923 "package p; interface IFoo {"
1924 "Map<String, String> foo();}");
1925 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1926
1927 io_delegate_.SetFileContents("p/IFoo.aidl",
1928 "package p; interface IFoo {"
1929 "Map<String, ParcelFileDescriptor> foo();}");
1930 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1931}
1932
Jeongik Chadf76dc72019-11-28 00:08:47 +09001933TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001934 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001935 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1936 io_delegate_.SetFileContents(options.InputFiles().front(),
1937 "package p; interface IFoo {"
1938 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001939 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001940 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001942}
1943
1944TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09001945 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09001946 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001947 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001948 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001949 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1950 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001951
Jooyung Han13f1fa52021-06-11 18:06:12 +09001952 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09001953 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1954 io_delegate_.SetFileContents("p/IFoo.aidl",
1955 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001956 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001957 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001958 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09001959 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001960 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001961 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001962 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09001963 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001964 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1965 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1966 io_delegate_.SetFileContents("p/IFoo.aidl",
1967 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001968 "p.Bar<String, ParcelFileDescriptor> foo();}");
Jeongik Chadf76dc72019-11-28 00:08:47 +09001969 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001970
1971 io_delegate_.SetFileContents("p/IFoo.aidl",
1972 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001973 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09001974
1975 io_delegate_.SetFileContents("p/IFoo.aidl",
1976 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001977 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09001978
1979 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001980}
1981
Jeongik Cha0e426012019-07-29 15:57:02 +09001982TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1983 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001984 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1985 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001986 for (const auto& rawOption : rawOptions) {
1987 string expected_stderr =
1988 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001989 Options options = Options::From(rawOption);
1990 io_delegate_.SetFileContents(options.InputFiles().front(),
1991 "package foo.bar;\n"
1992 "interface IFoo1 { int foo(); }\n"
1993 "interface IFoo2 { int foo(); }\n"
1994 "parcelable Data1 { int a; int b;}\n"
1995 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001996 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001997 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001998 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001999
Jeongik Cha0e426012019-07-29 15:57:02 +09002000 io_delegate_.SetFileContents(options.InputFiles().front(),
2001 "package foo.bar;\n"
2002 "interface IFoo1 { int foo(); }\n"
2003 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002004 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09002005 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002006 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002007
Devin Moore5de18ed2020-04-02 13:52:29 -07002008 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002009 io_delegate_.SetFileContents(options.InputFiles().front(),
2010 "package foo.bar;\n"
2011 "parcelable Data1 { int a; int b;}\n"
2012 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002013 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09002014 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002015 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002016 }
2017}
2018
Devin Moorebdba2a82020-03-31 15:19:02 -07002019TEST_P(AidlTest, FailParseOnEmptyFile) {
2020 const string contents = "";
2021 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2022 CaptureStderr();
2023 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2024 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2025}
2026
Jiyong Parkb034bf02018-07-30 17:44:33 +09002027TEST_F(AidlTest, MultipleInputFiles) {
2028 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002029 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002030
2031 io_delegate_.SetFileContents(options.InputFiles().at(0),
2032 "package foo.bar;\n"
2033 "import foo.bar.Data;\n"
2034 "interface IFoo { Data getData(); }\n");
2035
2036 io_delegate_.SetFileContents(options.InputFiles().at(1),
2037 "package foo.bar;\n"
2038 "import foo.bar.IFoo;\n"
2039 "parcelable Data { IFoo foo; }\n");
2040
2041 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2042
2043 string content;
2044 for (const auto file : {
2045 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2046 content.clear();
2047 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2048 EXPECT_FALSE(content.empty());
2049 }
2050}
2051
2052TEST_F(AidlTest, MultipleInputFilesCpp) {
2053 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002054 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002055
2056 io_delegate_.SetFileContents(options.InputFiles().at(0),
2057 "package foo.bar;\n"
2058 "import foo.bar.Data;\n"
2059 "interface IFoo { Data getData(); }\n");
2060
2061 io_delegate_.SetFileContents(options.InputFiles().at(1),
2062 "package foo.bar;\n"
2063 "import foo.bar.IFoo;\n"
2064 "parcelable Data { IFoo foo; }\n");
2065
2066 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2067
2068 string content;
2069 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002070 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002071 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2072 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2073 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2074 content.clear();
2075 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2076 EXPECT_FALSE(content.empty());
2077 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002078}
2079
Andrei Homescub62afd92020-05-11 19:24:59 -07002080TEST_F(AidlTest, MultipleInputFilesRust) {
2081 Options options =
2082 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2083
2084 io_delegate_.SetFileContents(options.InputFiles().at(0),
2085 "package foo.bar;\n"
2086 "import foo.bar.Data;\n"
2087 "interface IFoo { Data getData(); }\n");
2088
2089 io_delegate_.SetFileContents(options.InputFiles().at(1),
2090 "package foo.bar;\n"
2091 "import foo.bar.IFoo;\n"
2092 "parcelable Data { IFoo foo; }\n");
2093
2094 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2095
2096 string content;
2097 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2098 content.clear();
2099 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2100 EXPECT_FALSE(content.empty());
2101 }
2102}
2103
Devin Moore097a3ab2020-03-11 16:08:44 -07002104TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2105 const string expected_stderr =
2106 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002107 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2108 // int getInterfaceVersion() is one of the meta transactions
2109 io_delegate_.SetFileContents(options.InputFiles().front(),
2110 "package p; interface IFoo {"
2111 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002112 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09002113 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002114 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2115}
Jiyong Park309668e2018-07-28 16:55:44 +09002116
Devin Moore097a3ab2020-03-11 16:08:44 -07002117TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2118 // boolean getInterfaceVersion() is not a meta transaction, but should be
2119 // prevented because return type is not part of a method signature
2120 const string expected_stderr =
2121 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2122 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002123 io_delegate_.SetFileContents(options.InputFiles().front(),
2124 "package p; interface IFoo {"
2125 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002126 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09002127 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002128 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2129}
Jiyong Park309668e2018-07-28 16:55:44 +09002130
Devin Moore097a3ab2020-03-11 16:08:44 -07002131TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002132 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002133 const string expected_stderr =
2134 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2135 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002136 io_delegate_.SetFileContents(options.InputFiles().front(),
2137 "package p; interface IFoo {"
2138 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002139 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09002140 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002141 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002142
2143 // this is not a meta interface method as it differs type arguments
2144 io_delegate_.SetFileContents(options.InputFiles().front(),
2145 "package p; interface IFoo {"
2146 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002147 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002148}
2149
Jooyung Hanb8a97772021-01-19 01:27:38 +09002150TEST_F(AidlTest, CheckApiForEquality) {
2151 CaptureStderr();
2152 Options options = Options::From("aidl --checkapi=equal old new");
2153
2154 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2155 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2156 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2157 "package p; interface IFoo{ @utf8InCpp String foo();}");
2158
2159 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2160 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2161}
2162
Daniel Norman85aed542019-08-21 12:01:14 -07002163TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002164 Options options = Options::From("aidl --checkapi old new");
2165 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2166 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2167 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2168 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2169
2170 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2171}
2172
Jiyong Park3656c3c2018-08-01 20:02:01 +09002173TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002174 Options options = Options::From("aidl --checkapi old new");
2175 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2176 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002177
2178 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2179}
2180
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002181TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2182 Options options = Options::From("aidl --checkapi old new");
2183 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2184 const string enum_definition = "package p; enum Enum { FOO }";
2185 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2186 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2187 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2188 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2189
2190 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2191}
2192
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002193TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2194 Options options = Options::From("aidl --checkapi old new -I import");
2195
2196 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2197 io_delegate_.SetFileContents("new/p/Foo.aidl",
2198 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2199 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2200
2201 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2202}
2203
Jooyung Han02a11be2021-02-11 13:18:06 +09002204TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2205 Options options = Options::From("aidl --checkapi=equal old new");
2206 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2207 const string enum_definition = "package p; enum Enum { FOO }";
2208 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2209 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2210 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2211 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2212 CaptureStderr();
2213 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2214 EXPECT_EQ("", GetCapturedStderr());
2215}
2216
Daniel Norman85aed542019-08-21 12:01:14 -07002217class AidlTestCompatibleChanges : public AidlTest {
2218 protected:
2219 Options options_ = Options::From("aidl --checkapi old new");
2220};
2221
2222TEST_F(AidlTestCompatibleChanges, NewType) {
2223 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2224 "package p;"
2225 "interface IFoo {"
2226 " void foo(int a);"
2227 "}");
2228 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2229 "package p;"
2230 "interface IFoo {"
2231 " void foo(int a);"
2232 "}");
2233 io_delegate_.SetFileContents("new/p/IBar.aidl",
2234 "package p;"
2235 "interface IBar {"
2236 " void bar();"
2237 "}");
2238 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2239}
2240
2241TEST_F(AidlTestCompatibleChanges, NewMethod) {
2242 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2243 "package p;"
2244 "interface IFoo {"
2245 " void foo(int a);"
2246 "}");
2247 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2248 "package p;"
2249 "interface IFoo {"
2250 " void foo(int a);"
2251 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002252 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002253 "}");
2254 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2255}
2256
2257TEST_F(AidlTestCompatibleChanges, NewField) {
2258 io_delegate_.SetFileContents("old/p/Data.aidl",
2259 "package p;"
2260 "parcelable Data {"
2261 " int foo;"
2262 "}");
2263 io_delegate_.SetFileContents("new/p/Data.aidl",
2264 "package p;"
2265 "parcelable Data {"
2266 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002267 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002268 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002269 "}");
2270 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2271}
2272
Jooyung Han05bd8a82021-04-28 23:56:38 +09002273TEST_F(AidlTestCompatibleChanges, NewField2) {
2274 io_delegate_.SetFileContents("old/p/Data.aidl",
2275 "package p;"
2276 "parcelable Data {"
2277 "}");
2278 io_delegate_.SetFileContents("new/p/Data.aidl",
2279 "package p;"
2280 "parcelable Data {"
2281 " int foo = 0;"
2282 "}");
2283 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2284}
2285
Daniel Norman85aed542019-08-21 12:01:14 -07002286TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2287 io_delegate_.SetFileContents("old/p/Enum.aidl",
2288 "package p;"
2289 "enum Enum {"
2290 " FOO = 1,"
2291 "}");
2292 io_delegate_.SetFileContents("new/p/Enum.aidl",
2293 "package p;"
2294 "enum Enum {"
2295 " FOO = 1,"
2296 " BAR = 2,"
2297 "}");
2298 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2299}
2300
2301TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2302 io_delegate_.SetFileContents("old/p/Enum.aidl",
2303 "package p;"
2304 "enum Enum {"
2305 " FOO = 1,"
2306 " BAR = 2,"
2307 "}");
2308 io_delegate_.SetFileContents("new/p/Enum.aidl",
2309 "package p;"
2310 "enum Enum {"
2311 " BAR = 2,"
2312 " FOO = 1,"
2313 "}");
2314 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2315}
2316
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002317TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2318 io_delegate_.SetFileContents("old/p/Union.aidl",
2319 "package p;"
2320 "union Union {"
2321 " String foo;"
2322 "}");
2323 io_delegate_.SetFileContents("new/p/Union.aidl",
2324 "package p;"
2325 "union Union {"
2326 " String foo;"
2327 " int num;"
2328 "}");
2329 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2330}
2331
Daniel Norman85aed542019-08-21 12:01:14 -07002332TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002333 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2334 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002335 "interface IFoo {"
2336 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002337 "}");
2338 io_delegate_.SetFileContents("old/p/Data.aidl",
2339 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002340 "parcelable Data {"
2341 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002342 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002343 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2344 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002345 "interface IFoo {"
2346 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002347 "}");
2348 io_delegate_.SetFileContents("new/p/Data.aidl",
2349 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002350 "parcelable Data {"
2351 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002352 "}");
2353 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2354 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002355 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002356 " void foo(int a);"
2357 "}");
2358 io_delegate_.SetFileContents("new/q/Data.aidl",
2359 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002360 "parcelable Data {"
2361 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002362 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002363 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2364}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002365
Daniel Norman85aed542019-08-21 12:01:14 -07002366TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2367 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2368 "package p;"
2369 "interface IFoo {"
2370 " void foo(int a);"
2371 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002372 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2373 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002374 "interface IFoo {"
2375 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002376 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002377 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2378}
Jiyong Parke59c3682018-09-11 23:10:25 +09002379
Daniel Norman85aed542019-08-21 12:01:14 -07002380TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002381 io_delegate_.SetFileContents("old/p/I.aidl",
2382 "package p; interface I {"
2383 "const int A = 1; }");
2384 io_delegate_.SetFileContents("new/p/I.aidl",
2385 "package p ; interface I {"
2386 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002387 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2388}
Jiyong Parka428d212018-08-29 22:26:30 +09002389
Daniel Norman85aed542019-08-21 12:01:14 -07002390TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002391 io_delegate_.SetFileContents("old/p/I.aidl",
2392 "package p; interface I {"
2393 "const int A = 1; const int B = 2;}");
2394 io_delegate_.SetFileContents("new/p/I.aidl",
2395 "package p ; interface I {"
2396 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002397 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002398}
2399
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002400TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2401 io_delegate_.SetFileContents("old/p/Foo.aidl",
2402 "package p;"
2403 "@JavaPassthrough(annotation=\"Alice\")"
2404 "@JavaPassthrough(annotation=\"Bob\")"
2405 "parcelable Foo {}");
2406 io_delegate_.SetFileContents("new/p/Foo.aidl",
2407 "package p;"
2408 "@JavaPassthrough(annotation=\"Bob\")"
2409 "@JavaPassthrough(annotation=\"Alice\")"
2410 "parcelable Foo {}");
2411 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2412}
2413
Jooyung Han00073272020-11-27 14:20:20 +09002414TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2415 io_delegate_.SetFileContents("old/p/Foo.aidl",
2416 "package p;"
2417 "parcelable Foo {}");
2418 io_delegate_.SetFileContents("new/p/Foo.aidl",
2419 "package p;"
2420 "@JavaPassthrough(annotation=\"@Deprecated\")"
2421 "parcelable Foo {}");
2422 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2423}
2424
Jooyung Han636fd2f2020-10-22 11:33:45 +09002425TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2426 io_delegate_.SetFileContents("old/p/Data.aidl",
2427 "package p;"
2428 "parcelable Data {"
2429 " int num;"
2430 "}");
2431 io_delegate_.SetFileContents(
2432 "new/p/Data.aidl",
2433 "package p;"
2434 "parcelable Data {"
2435 " int num;"
2436 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2437 "}");
2438 io_delegate_.SetFileContents("new/p/Enum.aidl",
2439 "package p;"
2440 "enum Enum {"
2441 " FOO = 0,"
2442 " BAR = 1,"
2443 "}");
2444 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2445}
2446
Jooyung Han308bbe02021-04-27 12:09:59 +09002447TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2448 io_delegate_.SetFileContents("old/p/Data.aidl",
2449 "package p;\n"
2450 "parcelable Data {\n"
2451 " p.Enum e;\n"
2452 "}");
2453 io_delegate_.SetFileContents("old/p/Enum.aidl",
2454 "package p;\n"
2455 "enum Enum {\n"
2456 " FOO = 0,\n"
2457 " BAR = 1,\n"
2458 "}");
2459 io_delegate_.SetFileContents("new/p/Data.aidl",
2460 "package p;\n"
2461 "parcelable Data {\n"
2462 " p.Enum e = p.Enum.FOO;\n"
2463 "}");
2464 io_delegate_.SetFileContents("new/p/Enum.aidl",
2465 "package p;\n"
2466 "enum Enum {\n"
2467 " FOO = 0,\n"
2468 " BAR = 1,\n"
2469 "}");
2470 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2471}
2472
Daniel Norman85aed542019-08-21 12:01:14 -07002473class AidlTestIncompatibleChanges : public AidlTest {
2474 protected:
2475 Options options_ = Options::From("aidl --checkapi old new");
2476};
2477
2478TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002479 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002480 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2481 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002482 "interface IFoo {"
2483 " void foo(in String[] str);"
2484 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002485 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002486 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002487 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002488 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002489}
2490
2491TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002492 const string expected_stderr =
2493 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002494 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2495 "package p;"
2496 "interface IFoo {"
2497 " void foo(in String[] str);"
2498 " void bar(@utf8InCpp String str);"
2499 "}");
2500 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2501 "package p;"
2502 "interface IFoo {"
2503 " void foo(in String[] str);"
2504 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002505 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002506 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002507 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002508}
2509
Jiyong Parkf8d53612020-05-04 14:06:13 +09002510TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2511 const string expected_stderr =
2512 "ERROR: new/p/IFoo.aidl:1.61-65: "
2513 "Encountered an untyped List or Map. The use of untyped List/Map is "
2514 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2515 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2516 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2517 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2518 "package p;"
2519 "interface IFoo {"
2520 " void foo(in String[] str);"
2521 "}");
2522 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2523 "package p;"
2524 "interface IFoo {"
2525 " void foo(in String[] str);"
2526 " void bar(in List arg);"
2527 "}");
2528 CaptureStderr();
2529 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2530 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2531}
2532
2533TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2534 const string expected_stderr =
2535 "ERROR: new/p/Data.aidl:1.54-59: "
2536 "Encountered an untyped List or Map. The use of untyped List/Map is "
2537 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2538 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2539 "ERROR: new/p/Data.aidl: Failed to read.\n";
2540 io_delegate_.SetFileContents("old/p/Data.aidl",
2541 "package p;"
2542 "parcelable Data {"
2543 " int foo;"
2544 "}");
2545 io_delegate_.SetFileContents("new/p/Data.aidl",
2546 "package p;"
2547 "parcelable Data {"
2548 " int foo;"
2549 " @nullable List list;"
2550 "}");
2551 CaptureStderr();
2552 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2553 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2554}
2555
Daniel Norman85aed542019-08-21 12:01:14 -07002556TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002557 const string expected_stderr =
2558 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002559 io_delegate_.SetFileContents("old/p/Data.aidl",
2560 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002561 "parcelable Data {"
2562 " int foo;"
2563 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002564 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002565 io_delegate_.SetFileContents("new/p/Data.aidl",
2566 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002567 "parcelable Data {"
2568 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002569 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002570 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002571 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002572 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002573}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002574
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002575TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2576 const string expected_stderr =
2577 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2578 "backends. Please either provide a default value for this field or mark the field as "
2579 "@nullable. This value or a null value will be used automatically when an old version of "
2580 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2581 "order to make sure your code continues to be backwards compatible, make sure the default or "
2582 "null value does not cause a semantic change to this parcelable.\n";
2583 io_delegate_.SetFileContents("old/p/Data.aidl",
2584 "package p;"
2585 "parcelable Data {"
2586 " int num;"
2587 "}");
2588 io_delegate_.SetFileContents("new/p/Data.aidl",
2589 "package p;"
2590 "parcelable Data {"
2591 " int num;"
2592 " String str;"
2593 "}");
2594 CaptureStderr();
2595 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2596 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2597}
2598
Jooyung Han636fd2f2020-10-22 11:33:45 +09002599TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2600 const string expected_stderr =
2601 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2602 "Please make sure 'Enum' has '0' as a valid value.\n";
2603 io_delegate_.SetFileContents("old/p/Data.aidl",
2604 "package p;"
2605 "parcelable Data {"
2606 " int num;"
2607 "}");
2608 io_delegate_.SetFileContents("new/p/Data.aidl",
2609 "package p;"
2610 "parcelable Data {"
2611 " int num;"
2612 " p.Enum e;"
2613 "}");
2614 io_delegate_.SetFileContents("new/p/Enum.aidl",
2615 "package p;"
2616 "enum Enum {"
2617 " FOO = 1,"
2618 " BAR = 2,"
2619 "}");
2620 CaptureStderr();
2621 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2623}
2624
Daniel Norman85aed542019-08-21 12:01:14 -07002625TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002626 const string expected_stderr =
2627 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002628 io_delegate_.SetFileContents("old/p/Enum.aidl",
2629 "package p;"
2630 "enum Enum {"
2631 " FOO = 1,"
2632 " BAR = 2,"
2633 "}");
2634 io_delegate_.SetFileContents("new/p/Enum.aidl",
2635 "package p;"
2636 "enum Enum {"
2637 " BAR = 2,"
2638 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002639 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002640 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002641 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002642}
2643
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002644TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2645 const string expected_stderr =
2646 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2647 io_delegate_.SetFileContents("old/p/Union.aidl",
2648 "package p;"
2649 "union Union {"
2650 " String str;"
2651 " int num;"
2652 "}");
2653 io_delegate_.SetFileContents("new/p/Union.aidl",
2654 "package p;"
2655 "union Union {"
2656 " String str;"
2657 "}");
2658 CaptureStderr();
2659 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2661}
2662
Daniel Norman85aed542019-08-21 12:01:14 -07002663TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002664 const string expected_stderr =
2665 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002666 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2667 "package p;"
2668 "interface IFoo {"
2669 " void foo(in String[] str);"
2670 " void bar(@utf8InCpp String str);"
2671 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002672 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2673 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002674 "interface IFoo {"
2675 " void foo(in String[] str);"
2676 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002677 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002678 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002679 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002680 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002681}
2682
Daniel Norman85aed542019-08-21 12:01:14 -07002683TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002684 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002685 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2686 "package p;"
2687 "interface IFoo {"
2688 " void foo(in String[] str);"
2689 " void bar(@utf8InCpp String str);"
2690 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002691 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2692 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002693 "interface IFoo2 {"
2694 " void foo(in String[] str);"
2695 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002696 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002697 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002698 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002699 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002700}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002701
Daniel Norman85aed542019-08-21 12:01:14 -07002702TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002703 const string expected_stderr =
2704 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002705 io_delegate_.SetFileContents("old/p/Enum.aidl",
2706 "package p;"
2707 "enum Enum {"
2708 " FOO = 1,"
2709 " BAR = 2,"
2710 "}");
2711 io_delegate_.SetFileContents("new/p/Enum.aidl",
2712 "package p;"
2713 "enum Enum {"
2714 " FOO = 3,"
2715 " BAR = 2,"
2716 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002717 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002718 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002719 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002720}
2721
2722TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002723 const string expected_stderr =
2724 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2725 "from 0 to 1.\n"
2726 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2727 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002728 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2729 "package p;"
2730 "interface IFoo {"
2731 " void foo(in String[] str);"
2732 " void bar(@utf8InCpp String str);"
2733 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002734 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2735 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002736 "interface IFoo {"
2737 " void bar(@utf8InCpp String str);"
2738 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002739 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002740 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002741 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002743}
2744
2745TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002746 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002747 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2748 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002749 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002750 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002751 "parcelable Data {"
2752 " int foo;"
2753 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002754 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002755 io_delegate_.SetFileContents("new/p/Data.aidl",
2756 "package p;"
2757 "parcelable Data {"
2758 " int bar;"
2759 " int foo;"
2760 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002762 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002763 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002764}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002765
Daniel Norman85aed542019-08-21 12:01:14 -07002766TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002767 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002768 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002769 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002770 "interface IFoo {"
2771 " void foo(in String[] str);"
2772 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002773 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002774 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2775 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002776 "interface IFoo {"
2777 " void foo(out String[] str);"
2778 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002779 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002780 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002781 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002782 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002783}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002784
Daniel Norman85aed542019-08-21 12:01:14 -07002785TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002786 const string expected_stderr =
2787 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002788 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2789 "package p;"
2790 "interface IFoo {"
2791 " void foo(in String[] str);"
2792 " void bar(@utf8InCpp String str);"
2793 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002794 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2795 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002796 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002797 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002798 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002799 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002800 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002801 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002802 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002803}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002804
Daniel Norman85aed542019-08-21 12:01:14 -07002805TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002806 const string expected_stderr =
2807 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002808 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2809 "package p;"
2810 "interface IFoo {"
2811 " void foo(in String[] str);"
2812 " void bar(@utf8InCpp String str);"
2813 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002814 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2815 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002816 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002817 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002818 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002819 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002821 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002822 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002823}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002824
Jooyung Han60b2fde2020-10-29 15:12:40 +09002825TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2826 const string expected_stderr =
2827 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2828 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2829 io_delegate_.SetFileContents("old/p/Foo.aidl",
2830 "package p;"
2831 "@Backing(type=\"byte\")"
2832 "enum Foo {"
2833 " FOO, BAR,"
2834 "}");
2835 io_delegate_.SetFileContents("new/p/Foo.aidl",
2836 "package p;"
2837 "@Backing(type=\"long\")"
2838 "enum Foo {"
2839 " FOO, BAR,"
2840 "}");
2841 CaptureStderr();
2842 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2843 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2844}
2845
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002846TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2847 const string expected_stderr =
2848 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2849 "to @JavaPassthrough(annotation=\"Bob\")\n";
2850 io_delegate_.SetFileContents("old/p/Foo.aidl",
2851 "package p;"
2852 "@JavaPassthrough(annotation=\"Alice\")"
2853 "parcelable Foo {}");
2854 io_delegate_.SetFileContents("new/p/Foo.aidl",
2855 "package p;"
2856 "@JavaPassthrough(annotation=\"Bob\")"
2857 "parcelable Foo {}");
2858
2859 CaptureStderr();
2860 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2861 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2862}
2863
Devin Mooredb7ac512020-08-07 11:17:36 -07002864TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2865 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002866 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002867 io_delegate_.SetFileContents("old/p/Foo.aidl",
2868 "package p;"
2869 "parcelable Foo {"
2870 " int A;"
2871 "}");
2872 io_delegate_.SetFileContents("new/p/Foo.aidl",
2873 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002874 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002875 " int A;"
2876 "}");
2877 CaptureStderr();
2878 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2880}
2881
2882TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2883 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002884 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002885 io_delegate_.SetFileContents("old/p/Foo.aidl",
2886 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002887 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002888 " int A;"
2889 "}");
2890 io_delegate_.SetFileContents("new/p/Foo.aidl",
2891 "package p;"
2892 "parcelable Foo {"
2893 " int A;"
2894 "}");
2895 CaptureStderr();
2896 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2897 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2898}
2899
Daniel Norman85aed542019-08-21 12:01:14 -07002900TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002901 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002902 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2903 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002904 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002905 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002906 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002907 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002908}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002909
Daniel Norman85aed542019-08-21 12:01:14 -07002910TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002911 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002912 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2913 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002914 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002915 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002916 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002917}
Jiyong Parka428d212018-08-29 22:26:30 +09002918
Daniel Norman85aed542019-08-21 12:01:14 -07002919TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002920 const string expected_stderr =
2921 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002922 io_delegate_.SetFileContents("old/p/I.aidl",
2923 "package p; interface I {"
2924 "const int A = 1; const int B = 2;}");
2925 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002926 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002927 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002928 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002929}
Jiyong Parka428d212018-08-29 22:26:30 +09002930
Daniel Norman85aed542019-08-21 12:01:14 -07002931TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002932 const string expected_stderr =
2933 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002934 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2935 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002936 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002937 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002938 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002939}
2940
Devin Moorec7e47a32020-08-07 10:55:25 -07002941TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2942 const string expected_stderr =
2943 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2944 "This is an incompatible change for FixedSize types.\n";
2945 io_delegate_.SetFileContents("old/p/Foo.aidl",
2946 "package p; @FixedSize parcelable Foo { int A = 1; }");
2947 io_delegate_.SetFileContents("new/p/Foo.aidl",
2948 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2949 CaptureStderr();
2950 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2952}
2953
Jeongik Cha68d18e72021-04-29 20:07:01 +09002954TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
2955 const string expected_stderr =
2956 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
2957 "android.net.UidRangeParcel is changed from 1 to 2. "
2958 "But it is forbidden because of legacy support.\n";
2959 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
2960 "package android.net; parcelable UidRangeParcel { int A = 1; }");
2961 io_delegate_.SetFileContents(
2962 "new/android/net/UidRangeParcel.aidl",
2963 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
2964 CaptureStderr();
2965 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2967}
2968
Devin Moorec7e47a32020-08-07 10:55:25 -07002969TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2970 const string expected_stderr =
2971 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2972 io_delegate_.SetFileContents("old/p/Foo.aidl",
2973 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2974 io_delegate_.SetFileContents("new/p/Foo.aidl",
2975 "package p; @FixedSize parcelable Foo { int A = 1; }");
2976 CaptureStderr();
2977 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2979}
2980
2981TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2982 const string expected_stderr =
2983 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2984 "a.\n"
2985 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2986 "b.\n"
2987 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2988 "c.\n"
2989 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2990 "d.\n"
2991 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2992 "e.\n"
2993 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2994 "f.\n";
2995
2996 io_delegate_.SetFileContents("Foo.aidl",
2997 "@FixedSize parcelable Foo { "
2998 " int[] a;"
2999 " Bar b;"
3000 " String c;"
3001 " ParcelFileDescriptor d;"
3002 " IBinder e;"
3003 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00003004 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07003005 "}");
3006 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003007 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003008
3009 CaptureStderr();
3010 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3011 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3012}
3013
3014TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3015 const string expected_stderr = "";
3016
3017 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3018 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3019 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003020 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003021
3022 CaptureStderr();
3023 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3024 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3025}
3026
Jiyong Park8c380532018-08-30 14:55:26 +09003027TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003028 const string expected_stderr =
3029 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3030 "dir1/q/IBar.aidl\n"
3031 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003032 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003033 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3034 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3035 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3036 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3037
Devin Moore097a3ab2020-03-11 16:08:44 -07003038 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09003039 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003040 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003041}
3042
Jiyong Parked65bf42018-08-28 15:43:27 +09003043TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003044 const string expected_stderr =
3045 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3046 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003047 Options options = Options::From("aidl --checkapi old new");
3048 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3049 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003050
3051 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3052
Jiyong Parke59c3682018-09-11 23:10:25 +09003053 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003054 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003055 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003057}
3058
Jooyung Han652ce482021-02-26 12:40:35 +09003059TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3060 Options options =
3061 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003062
3063 // use without import
3064 io_delegate_.SetFileContents("p/IFoo.aidl",
3065 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09003066 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3067
3068 // capture output files
3069 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003070
Devin Moore7b8d5c92020-03-17 14:14:08 -07003071 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003072 io_delegate_.SetFileContents(
3073 "p/IFoo.aidl",
3074 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09003075 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3076 // output files should be the same
3077 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003078
3079 // use with import (as before)
3080 io_delegate_.SetFileContents("p/IFoo.aidl",
3081 "package p;"
3082 "import android.os.ParcelFileDescriptor;"
3083 "interface IFoo{"
3084 " void foo(in ParcelFileDescriptor fd);"
3085 "}");
Jooyung Han652ce482021-02-26 12:40:35 +09003086 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3087 // output files should be the same
3088 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003089}
Jiyong Parked65bf42018-08-28 15:43:27 +09003090
Jooyung Han020d8d12021-02-26 17:23:02 +09003091TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3092 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3093 CaptureStderr();
3094 io_delegate_.SetFileContents("p/IFoo.aidl",
3095 "package p;"
3096 "interface IFoo{"
3097 " void foo(out ParcelFileDescriptor fd);"
3098 "}");
3099 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3100 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3101}
3102
3103TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3104 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3105 CaptureStderr();
3106 io_delegate_.SetFileContents("p/IFoo.aidl",
3107 "package p;"
3108 "interface IFoo{"
3109 " void foo(ParcelFileDescriptor fd);"
3110 "}");
3111 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3112 EXPECT_THAT(GetCapturedStderr(),
3113 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3114}
3115
Jiyong Park3633b722019-04-11 15:38:26 +09003116TEST_F(AidlTest, ManualIds) {
3117 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3118 io_delegate_.SetFileContents("IFoo.aidl",
3119 "interface IFoo {\n"
3120 " void foo() = 0;\n"
3121 " void bar() = 1;\n"
3122 "}");
3123 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3124}
3125
3126TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3127 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3128 io_delegate_.SetFileContents("IFoo.aidl",
3129 "interface IFoo {\n"
3130 " void foo() = 0;\n"
3131 " void bar() = 1;\n"
3132 "}");
3133 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3134}
3135
3136TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003137 const string expected_stderr =
3138 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003139 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3140 io_delegate_.SetFileContents("IFoo.aidl",
3141 "interface IFoo {\n"
3142 " void foo() = 3;\n"
3143 " void bar() = 3;\n"
3144 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003145 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003146 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003147 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003148}
3149
3150TEST_F(AidlTest, FailOnOutOfRangeIds) {
3151 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003152 const string expected_stderr =
3153 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3154 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003155 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3156 io_delegate_.SetFileContents("IFoo.aidl",
3157 "interface IFoo {\n"
3158 " void foo() = 3;\n"
3159 " void bar() = 16777115;\n"
3160 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003161 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003162 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003163 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003164}
3165
3166TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003167 const string expected_stderr =
3168 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003169 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3170 io_delegate_.SetFileContents("IFoo.aidl",
3171 "interface IFoo {\n"
3172 " void foo() = 3;\n"
3173 " void bar();\n"
3174 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003175 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003176 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003177 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003178}
3179
Jiyong Parkc6816252019-07-08 08:12:28 +09003180TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3181 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3182 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3183 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
3184 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3185}
3186
3187TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003188 const string expected_stderr =
3189 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3190 "dir/IBar.aidl\n"
3191 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003192 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003193
Jiyong Parkc6816252019-07-08 08:12:28 +09003194 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3195 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3196 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3197 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003198 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09003199 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003201}
3202
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003203TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3204 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3205 "package a.b;\n"
3206 "import a.b.IBar;\n"
3207 "import a.b.IQux;\n"
3208 "interface IFoo { IQux foo(); }\n");
3209 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3210 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3211
3212 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
3213 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3214
3215 string output;
3216 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3217 // IBar was imported but wasn't used. include is not expected.
3218 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3219 // IBar was imported and used. include is expected.
3220 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3221}
3222
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003223TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003224 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003225 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003226 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3227 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003228 interface IFoo {
3229 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003230 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003231 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003232 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003233 // JavaPassthrough should work with other types as well (e.g. enum)
3234 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3235 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3236 @JavaPassthrough(annotation="@com.android.AliceTwo")
3237 @Backing(type="byte")
3238 enum MyEnum {
3239 a, b, c
3240 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003241
Jooyung Han4cde01d2020-10-13 11:10:47 +09003242 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003243 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3244
3245 string java_out;
3246 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003247 // type-decl-level annotations with newline at the end
3248 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3249 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3250 // member-decl-level annotations with newline at the end
3251 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3252 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3253 // inline annotations with space at the end
3254 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003255
Jooyung Han4cde01d2020-10-13 11:10:47 +09003256 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3257 // type-decl-level annotations with newline at the end
3258 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3259 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3260
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003261 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003262 Options cpp_options =
3263 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003264 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3265
Jooyung Han4cde01d2020-10-13 11:10:47 +09003266 Options ndk_options =
3267 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003268 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003269
Jooyung Han4cde01d2020-10-13 11:10:47 +09003270 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07003271 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003272}
3273
Andrei Homescue61feb52020-08-18 15:44:24 -07003274TEST_F(AidlTest, ParseRustDerive) {
3275 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3276 @RustDerive(Clone=true, Copy=false)
3277 parcelable Foo {
3278 int a;
3279 })");
3280
3281 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
3282 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
3283
3284 string rust_out;
3285 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3286 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3287
3288 // Other backends shouldn't be bothered
3289 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
3290 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3291
3292 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
3293 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
3294
3295 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
3296 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3297}
3298
Jiyong Park56f73d72019-06-11 12:20:28 +09003299class AidlOutputPathTest : public AidlTest {
3300 protected:
3301 void SetUp() override {
3302 AidlTest::SetUp();
3303 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3304 }
3305
3306 void Test(const Options& options, const std::string expected_output_path) {
3307 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3308 // check the existence
3309 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3310 }
3311};
3312
3313TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3314 // <out_dir> / <package_name> / <type_name>.java
3315 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3316}
3317
3318TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3319 // when output file is explicitly set, it is always respected. -o option is
3320 // ignored.
3321 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3322}
3323
3324TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3325 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3326}
3327
3328TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3329 // output is the same as the input file except for the suffix
3330 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3331}
3332
Devin Moore7b8d5c92020-03-17 14:14:08 -07003333TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003334 AidlError error;
3335 const string expected_stderr =
3336 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3337 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003338 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3339 R"(package p;
3340 interface IFoo {
3341 const int int32_max_oob = 2147483650;
3342 }
3343 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003344 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3346 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003347}
3348
Devin Moore7b8d5c92020-03-17 14:14:08 -07003349TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003350 AidlError error;
3351 const string expected_stderr =
3352 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3353 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003354 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3355 R"(package p;
3356 interface IFoo {
3357 const int int32_min_oob = -2147483650;
3358 }
3359 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003360 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003361 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3362 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003363}
3364
Devin Moore7b8d5c92020-03-17 14:14:08 -07003365TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003366 AidlError error;
3367 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003368 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003369 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003370 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3371 R"(package p;
3372 interface IFoo {
3373 const long int64_max_oob = 21474836509999999999999999;
3374 }
3375 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003376 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003379}
3380
Devin Moore7b8d5c92020-03-17 14:14:08 -07003381TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003382 AidlError error;
3383 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003384 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003385 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003386 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3387 R"(package p;
3388 interface IFoo {
3389 const long int64_min_oob = -21474836509999999999999999;
3390 }
3391 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003392 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003393 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3394 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003395}
3396
Devin Moore7b8d5c92020-03-17 14:14:08 -07003397TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003398 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003399 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003400 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003401 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3402 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003403 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3404 R"(package p;
3405 @Backing(type="byte")
3406 enum TestEnum {
3407 FOO = 127,
3408 BAR,
3409 }
3410 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003411 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003412 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003413 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003414}
3415
Devin Mooredecaf292020-04-30 09:16:40 -07003416TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3417 AidlError error;
3418 const string expected_stderr =
3419 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003420 "be one of: type\n";
3421 CaptureStderr();
3422 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3423 R"(package p;
3424 @Backing(foo="byte")
3425 enum TestEnum {
3426 FOO = 1,
3427 BAR,
3428 }
3429 )",
3430 typenames_, GetLanguage(), &error));
3431 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3432 EXPECT_EQ(AidlError::BAD_TYPE, error);
3433}
3434
Jooyung Han5721a232020-12-24 04:34:55 +09003435TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3436 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3437 CaptureStderr();
3438 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3440}
3441
Jooyung Han66813932020-10-23 13:24:44 +09003442TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003443 io_delegate_.SetFileContents("Foo.aidl",
3444 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3445 "Map<String, Baz> d; Bar[] e; }");
3446 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3447 io_delegate_.SetFileContents("Baz.aidl",
3448 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003449 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3450 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3451}
3452
Jooyung Han66813932020-10-23 13:24:44 +09003453TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003454 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003455 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003456 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003457 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3458 "named 'bar'.\n";
3459 CaptureStderr();
3460 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3461 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3462 EXPECT_EQ(expected_error, GetCapturedStderr());
3463}
3464
Jooyung Han09e551c2021-05-11 11:44:48 +09003465TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3466 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3467 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3468 CaptureStderr();
3469 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3470 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3471 EXPECT_EQ("", GetCapturedStderr());
3472}
3473
Jooyung Han59af9cc2020-10-25 21:44:14 +09003474TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3475 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3476 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3477 string expected_error =
3478 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003479 "named 'bar'.\n";
3480 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003481 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3482 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003483 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003484}
3485
Jooyung Han66813932020-10-23 13:24:44 +09003486TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003487 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003488 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3489 string expected_error =
3490 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3491 "only be an in parameter.\n";
3492 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003493 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3494 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003495 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003496}
3497
Jooyung Han66813932020-10-23 13:24:44 +09003498TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003499 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003500 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3501 string expected_error =
3502 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3503 "only be an in parameter.\n";
3504 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003505 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3506 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003507 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003508}
3509
Jooyung Han66813932020-10-23 13:24:44 +09003510TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003511 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003512 Options options = Options::From("aidl --lang=java Foo.aidl");
3513 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003514 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3515 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003516 CaptureStderr();
3517 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3518 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3519}
Devin Moore53fc99c2020-08-12 08:07:52 -07003520
Jooyung Hanfe086af2021-01-16 03:44:47 +09003521TEST_P(AidlTest, UnionInUnion) {
3522 import_paths_.insert(".");
3523 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3524 CaptureStderr();
3525 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3526 EXPECT_THAT("", GetCapturedStderr());
3527}
3528
Jooyung Hanfe89f122020-10-14 03:49:18 +09003529TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3530 const string method = "package a; union Foo {}";
3531 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3532 CaptureStderr();
3533 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3534 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3535}
3536
3537TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3538 const string method = "package a; union Foo { ParcelableHolder x; }";
3539 const string expected_stderr =
3540 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3541 CaptureStderr();
3542 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3543 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3544}
3545
Jooyung Han53fb4242020-12-17 16:03:49 +09003546TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3547 import_paths_.insert(".");
3548 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3549 const string expected_err = "The union's first member should have a useful default value.";
3550 CaptureStderr();
3551 EXPECT_EQ(nullptr,
3552 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3553 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3554}
3555
Devin Moore53fc99c2020-08-12 08:07:52 -07003556TEST_P(AidlTest, GenericStructuredParcelable) {
3557 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003558 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003559 const string expected_stderr = "";
3560 CaptureStderr();
3561 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3562 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3563}
3564
Jooyung Han3f347ca2020-12-01 12:41:50 +09003565TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3566 io_delegate_.SetFileContents("Foo.aidl",
3567 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3568 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003569 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003570 const string expected_stderr = "";
3571 CaptureStderr();
3572 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3573 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3574
3575 string code;
3576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3577 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3578const ::android::String16& Foo<T,U>::s() {
3579 static const ::android::String16 value(::android::String16(""));
3580 return value;
3581})--"));
3582}
3583
3584TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3585 io_delegate_.SetFileContents("Foo.aidl",
3586 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3587 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003588 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003589 const string expected_stderr = "";
3590 CaptureStderr();
3591 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3593
3594 string code;
3595 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3596 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3597const char* Foo<T, U>::s = "";
3598)--"));
3599}
3600
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003601TEST_F(AidlTest, NestedTypeArgs) {
3602 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003603 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3604
3605 io_delegate_.SetFileContents("a/Foo.aidl",
3606 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3607 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003608 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3609 const string expected_stderr = "";
3610 CaptureStderr();
3611 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3612 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3613
3614 string code;
3615 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003616 EXPECT_THAT(code,
3617 testing::HasSubstr(
3618 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3619}
3620
3621TEST_F(AidlTest, DoubleArrayError) {
3622 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3623
3624 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3625 const string expected_stderr =
3626 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3627 CaptureStderr();
3628 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3629 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3630}
3631
3632TEST_F(AidlTest, DoubleGenericError) {
3633 io_delegate_.SetFileContents("a/Bar.aidl",
3634 "package a; parcelable Bar { List<String><String> a; }");
3635
3636 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3637 const string expected_stderr =
3638 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3639 CaptureStderr();
3640 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3641 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3642}
3643
3644TEST_F(AidlTest, ArrayBeforeGenericError) {
3645 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3646
3647 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003648 CaptureStderr();
3649 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003650 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3651}
3652
3653TEST_F(AidlTest, NullableArraysAreNotSupported) {
3654 io_delegate_.SetFileContents("a/Bar.aidl",
3655 "package a; parcelable Bar { String @nullable [] a; }");
3656
3657 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3658 CaptureStderr();
3659 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3660 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3661}
3662
3663TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3664 io_delegate_.SetFileContents("a/Bar.aidl",
3665 "package a; parcelable Bar { List<@nullable String> a; }");
3666
3667 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3668 CaptureStderr();
3669 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3670 EXPECT_THAT(GetCapturedStderr(),
3671 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003672}
3673
Jooyung Han14004ed2020-10-16 03:49:57 +09003674struct GenericAidlTest : ::testing::Test {
3675 FakeIoDelegate io_delegate_;
3676 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003677 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003678 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3679 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3680 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3681
3682 Options options = Options::From(cmd);
3683 CaptureStderr();
3684 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3685 EXPECT_EQ("", GetCapturedStderr());
3686 }
3687};
3688
3689TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3690 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3691 string code;
3692 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3693 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3694 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3695 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3696}
3697
3698TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3699 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3700 string code;
3701 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3702 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3703 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3704 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3705}
3706
Devin Moore53fc99c2020-08-12 08:07:52 -07003707TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3708 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003709 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003710 const string expected_stderr =
3711 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3712 CaptureStderr();
3713 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3714 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3715}
3716
3717TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3718 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003719 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003720 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3721 CaptureStderr();
3722 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3723 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3724}
3725
Jooyung Han7a308842020-10-27 19:06:49 +09003726TEST_P(AidlTest, LongCommentWithinConstExpression) {
3727 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003728 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003729 CaptureStderr();
3730 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3731 EXPECT_EQ("", GetCapturedStderr());
3732}
3733
Jeongik Chaef44e622020-10-23 16:00:52 +09003734TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3735 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3736 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3737 std::string expectedErr =
3738 "ERROR: a/Foo.aidl:1.28-30: "
3739 "Encountered an untyped List or Map. The use of untyped List/Map is "
3740 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3741 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3742 "ERROR: a/Foo.aidl:1.35-37: "
3743 "Encountered an untyped List or Map. The use of untyped List/Map is "
3744 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3745 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3746 CaptureStderr();
3747 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3748 EXPECT_EQ(expectedErr, GetCapturedStderr());
3749}
3750
3751TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003752 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3753 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003754 std::string expectedErr =
3755 "ERROR: a/Foo.aidl:1.33-35: "
3756 "Encountered an untyped List or Map. The use of untyped List/Map is "
3757 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3758 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3759 "ERROR: a/Foo.aidl:1.40-42: "
3760 "Encountered an untyped List or Map. The use of untyped List/Map is "
3761 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3762 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003763 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003764 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3765 EXPECT_EQ(expectedErr, GetCapturedStderr());
3766}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003767
Jeongik Chaef44e622020-10-23 16:00:52 +09003768TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3769 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3770 io_delegate_.SetFileContents(
3771 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3772 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3773 std::string expectedErr =
3774 "ERROR: a/Foo.aidl:1.52-54: "
3775 "Encountered an untyped List or Map. The use of untyped List/Map is "
3776 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3777 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3778 "ERROR: a/Foo.aidl:1.64-66: "
3779 "Encountered an untyped List or Map. The use of untyped List/Map is "
3780 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3781 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3782 CaptureStderr();
3783 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3784 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003785}
3786
Jooyung Han690f5842020-12-04 13:02:04 +09003787TEST_F(AidlTest, EnumWithDefaults_Java) {
3788 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3789 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3790package p;
3791import p.Enum;
3792parcelable Foo {
3793 Enum e = Enum.BAR;
3794})");
3795 CaptureStderr();
3796 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3797 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3798 auto err = GetCapturedStderr();
3799 EXPECT_EQ("", err);
3800
3801 string code;
3802 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003803 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003804}
3805
3806TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3807 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3808 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3809package p;
3810import p.Enum;
3811parcelable Foo {
3812 Enum e = Enum.BAR;
3813})");
3814 CaptureStderr();
3815 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3816 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3817 auto err = GetCapturedStderr();
3818 EXPECT_EQ("", err);
3819
3820 string code;
3821 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3822 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3823}
3824
3825TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3826 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3827 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3828package p;
3829import p.Enum;
3830parcelable Foo {
3831 Enum e = Enum.BAR;
3832})");
3833 CaptureStderr();
3834 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3835 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3836 auto err = GetCapturedStderr();
3837 EXPECT_EQ("", err);
3838
3839 string code;
3840 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3841 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3842}
3843
3844TEST_F(AidlTest, EnumWithDefaults_Rust) {
3845 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3846 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3847package p;
3848import p.Enum;
3849parcelable Foo {
3850 int n = 42;
3851 Enum e = Enum.BAR;
3852})");
3853 CaptureStderr();
3854 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3855 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3856 auto err = GetCapturedStderr();
3857 EXPECT_EQ("", err);
3858
3859 string code;
3860 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3861 EXPECT_THAT(code, testing::HasSubstr(R"(
3862 fn default() -> Self {
3863 Self {
3864 n: 42,
3865 e: crate::mangled::_1_p_4_Enum::BAR,
3866 }
3867 })"));
3868}
3869
3870TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3871 import_paths_.insert("a");
3872 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3873 CaptureStderr();
3874 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3875package p;
3876import p.Enum;
3877parcelable Foo {
3878 int e = Enum.FOO | Enum.BAR;
3879})",
3880 typenames_, GetLanguage());
3881 auto err = GetCapturedStderr();
3882 EXPECT_EQ("", err);
3883 EXPECT_TRUE(type);
3884 const auto& fields = type->AsStructuredParcelable()->GetFields();
3885 EXPECT_EQ("int e = 3", fields[0]->ToString());
3886}
3887
3888TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3889 CaptureStderr();
3890 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3891@Backing(type="int")
3892enum Foo {
3893 STANDARD_SHIFT = 16,
3894 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3895 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3896}
3897)",
3898 typenames_, GetLanguage());
3899 auto err = GetCapturedStderr();
3900 EXPECT_EQ("", err);
3901 EXPECT_TRUE(type);
3902 const auto& enum_type = type->AsEnumDeclaration();
3903 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003904 auto writer = CodeWriter::ForString(&code);
3905 DumpVisitor visitor(*writer);
3906 visitor.Visit(*enum_type);
3907 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003908 EXPECT_EQ(R"--(@Backing(type="int")
3909enum Foo {
3910 STANDARD_SHIFT = 16,
3911 STANDARD_BT709 = 65536,
3912 STANDARD_BT601_625 = 131072,
3913}
3914)--",
3915 code);
3916}
3917
3918TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3919 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3920 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3921package p;
3922import p.Enum;
3923parcelable Foo {
3924 Enum e = Enum.FOO | Enum.BAR;
3925})");
3926 CaptureStderr();
3927 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3928 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3929 auto err = GetCapturedStderr();
3930 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3931 err);
3932}
3933
Jooyung Han361cd102021-05-24 11:30:10 +09003934TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
3935 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3936 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3937package p;
3938import p.Enum;
3939parcelable Foo {
3940 Enum e = 1;
3941})");
3942 CaptureStderr();
3943 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3944 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3945 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
3946}
3947
Jooyung Han690f5842020-12-04 13:02:04 +09003948TEST_P(AidlTest, DefaultWithEmptyArray) {
3949 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3950 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3951 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003952 auto options =
3953 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003954 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3955 auto err = GetCapturedStderr();
3956 EXPECT_EQ("", err);
3957}
3958
3959TEST_P(AidlTest, RejectRefsInAnnotation) {
3960 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3961 "package p; interface IFoo {\n"
3962 " const String ANNOTATION = \"@Annotation\";\n"
3963 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3964 "}");
3965 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003966 auto options =
3967 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003968 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3969 auto err = GetCapturedStderr();
3970 EXPECT_EQ(
3971 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3972 "ANNOTATION.\n",
3973 err);
3974}
3975
3976TEST_F(AidlTest, DefaultWithEnumValues) {
3977 io_delegate_.SetFileContents(
3978 "a/p/Foo.aidl",
3979 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3980 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3981 CaptureStderr();
3982 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3983 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3984 auto err = GetCapturedStderr();
3985 EXPECT_EQ("", err);
3986 string code;
3987 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3988 EXPECT_THAT(
3989 code, testing::HasSubstr(
3990 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3991}
3992
Jooyung Han14259392020-12-07 10:00:08 +09003993TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3994 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3995 CaptureStderr();
3996 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3997 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3998 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09003999 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004000}
4001
4002TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4003 io_delegate_.SetFileContents("a/p/Foo.aidl",
4004 "package p; parcelable Foo { const int A = A + 1; }");
4005 CaptureStderr();
4006 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4007 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4008 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004009 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4010}
4011
4012TEST_F(AidlTest, RecursiveReferences) {
4013 io_delegate_.SetFileContents("a/p/Foo.aidl",
4014 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4015 io_delegate_.SetFileContents("a/p/Bar.aidl",
4016 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4017 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4018 CaptureStderr();
4019 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4020 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4021 EXPECT_EQ("", GetCapturedStderr());
4022}
4023
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004024TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4025 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4026 auto options =
4027 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4028 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4029 CaptureStderr();
4030 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4031 EXPECT_EQ(err, GetCapturedStderr());
4032}
4033
4034TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4035 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4036 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4037 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4038 auto options =
4039 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4040 CaptureStderr();
4041 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4042 EXPECT_EQ("", GetCapturedStderr());
4043}
4044
Jooyung Hane9f5b272021-01-07 00:18:11 +09004045TEST_P(AidlTest, UnknownConstReference) {
4046 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4047 auto options =
4048 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4049 const string err =
4050 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4051 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4052 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4053 CaptureStderr();
4054 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4055 EXPECT_EQ(err, GetCapturedStderr());
4056}
4057
Jooyung Han29813842020-12-08 01:28:03 +09004058TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4059 string contents = R"(
4060import android.os.IBinder;
4061import android.os.IInterface;
4062interface IFoo {}
4063 )";
4064 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004065}
4066
Jooyung Han888c5bc2020-12-22 17:28:47 +09004067TEST_P(AidlTest, WarningInterfaceName) {
4068 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004069 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004070 " -Weverything -o out -h out p/Foo.aidl");
4071 CaptureStderr();
4072 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004073 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004074 GetCapturedStderr());
4075}
4076
4077TEST_P(AidlTest, ErrorInterfaceName) {
4078 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004079 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004080 " -Weverything -Werror -o out -h out p/Foo.aidl");
4081 CaptureStderr();
4082 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004083 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004084 GetCapturedStderr());
4085}
4086
Jiyong Park9f4c3822021-04-07 20:36:45 +09004087TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4088 const std::string input_file = "base/p/q/IFoo.aidl";
4089 const std::string header_dir = "out/";
4090 const std::string output_file = "out/base/p/q/IFoo.cpp";
4091 const std::string package = "p.q"; // not base.p.q
4092 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4093
4094 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4095 CaptureStderr();
4096 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4097 EXPECT_THAT(
4098 GetCapturedStderr(),
4099 testing::StartsWith(
4100 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4101 "but is out/base/p/q/IFoo.cpp."));
4102}
4103
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004104TEST_F(AidlTest, FormatCommentsForJava) {
4105 using android::aidl::FormatCommentsForJava;
4106
4107 struct TestCase {
4108 vector<Comment> comments;
4109 string formatted;
4110 };
4111 vector<TestCase> testcases = {
4112 {{}, ""},
4113 {{{"// line comments\n"}}, "// line comments\n"},
4114 {{{"// @hide \n"}}, "// @hide \n"},
4115 // Transform the last block comment as Javadoc.
4116 {{{"/*\n"
4117 " * Hello, world!\n"
4118 " */"}},
4119 "/**\n"
4120 " * Hello, world!\n"
4121 " */"},
4122 {{{"/* @hide */"}}, "/** @hide */"},
4123 {{{"/**\n"
4124 " @param foo ...\n"
4125 "*/"}},
4126 "/**\n"
4127 " @param foo ...\n"
4128 "*/"},
4129 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4130 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4131 "/* @deprecated first *//** @deprecated second */"},
4132 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4133 // Line comments are printed as they are
4134 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4135 };
4136 for (const auto& [input, formatted] : testcases) {
4137 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4138 }
4139}
4140
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004141TEST_F(AidlTest, HideIsNotForArgs) {
4142 io_delegate_.SetFileContents("IFoo.aidl",
4143 "interface IFoo {\n"
4144 " void foo(in @Hide int x);\n"
4145 "}");
4146 auto options = Options::From("aidl --lang=java IFoo.aidl");
4147 CaptureStderr();
4148 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4149 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4150}
4151
4152TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4153 io_delegate_.SetFileContents(
4154 "IFoo.aidl",
4155 "interface IFoo {\n"
4156 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4157 "}");
4158 auto options = Options::From("aidl --lang=java IFoo.aidl");
4159 CaptureStderr();
4160 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4161 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4162}
4163
Jooyung Hanfa181932021-06-12 07:56:53 +09004164TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4165 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4166 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4167 CaptureStderr();
4168 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4169 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4170}
4171
Jooyung Hanfd3be322020-12-13 09:11:06 +09004172struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004173 string kind;
4174 string literal;
4175};
4176
Jooyung Hanfd3be322020-12-13 09:11:06 +09004177const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004178 {"primitive", "int"}, {"primitiveArray", "int[]"},
4179 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004180 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4181 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4182 {"union", "a.Union"}, {"interface", "a.IBar"},
4183};
4184
4185const std::map<std::string, std::string> kListSupportExpectations = {
4186 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4187 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4188 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4189 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004190 {"cpp_primitiveArray", "List of arrays is not supported."},
4191 {"java_primitiveArray", "List of arrays is not supported."},
4192 {"ndk_primitiveArray", "List of arrays is not supported."},
4193 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004194 {"cpp_String", ""},
4195 {"java_String", ""},
4196 {"ndk_String", ""},
4197 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004198 {"cpp_StringArray", "List of arrays is not supported."},
4199 {"java_StringArray", "List of arrays is not supported."},
4200 {"ndk_StringArray", "List of arrays is not supported."},
4201 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004202 {"cpp_IBinder", ""},
4203 {"java_IBinder", ""},
4204 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4205 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004206 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004207 {"java_ParcelFileDescriptor", ""},
4208 {"ndk_ParcelFileDescriptor", ""},
4209 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004210 {"cpp_interface", "List<a.IBar> is not supported."},
4211 {"java_interface", "List<a.IBar> is not supported."},
4212 {"ndk_interface", "List<a.IBar> is not supported."},
4213 {"rust_interface", "List<a.IBar> is not supported."},
4214 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004215 {"java_parcelable", ""},
4216 {"ndk_parcelable", ""},
4217 {"rust_parcelable", ""},
4218 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4219 {"java_enum", "A generic type cannot have any primitive type parameters."},
4220 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4221 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004222 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004223 {"java_union", ""},
4224 {"ndk_union", ""},
4225 {"rust_union", ""},
4226};
4227
Jooyung Hand236e552020-12-13 09:21:27 +09004228const std::map<std::string, std::string> kArraySupportExpectations = {
4229 {"cpp_primitive", ""},
4230 {"java_primitive", ""},
4231 {"ndk_primitive", ""},
4232 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004233 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4234 {"java_primitiveArray", "Can only have one dimensional arrays."},
4235 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4236 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004237 {"cpp_String", ""},
4238 {"java_String", ""},
4239 {"ndk_String", ""},
4240 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004241 {"cpp_StringArray", "Can only have one dimensional arrays."},
4242 {"java_StringArray", "Can only have one dimensional arrays."},
4243 {"ndk_StringArray", "Can only have one dimensional arrays."},
4244 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004245 {"cpp_IBinder", ""},
4246 {"java_IBinder", ""},
4247 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4248 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4249 {"cpp_ParcelFileDescriptor", ""},
4250 {"java_ParcelFileDescriptor", ""},
4251 {"ndk_ParcelFileDescriptor", ""},
4252 {"rust_ParcelFileDescriptor", ""},
4253 {"cpp_interface", "Binder type cannot be an array"},
4254 {"java_interface", "Binder type cannot be an array"},
4255 {"ndk_interface", "Binder type cannot be an array"},
4256 {"rust_interface", "Binder type cannot be an array"},
4257 {"cpp_parcelable", ""},
4258 {"java_parcelable", ""},
4259 {"ndk_parcelable", ""},
4260 {"rust_parcelable", ""},
4261 {"cpp_enum", ""},
4262 {"java_enum", ""},
4263 {"ndk_enum", ""},
4264 {"rust_enum", ""},
4265 {"cpp_union", ""},
4266 {"java_union", ""},
4267 {"ndk_union", ""},
4268 {"rust_union", ""},
4269};
4270
Jooyung Hanfd3be322020-12-13 09:11:06 +09004271class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004272 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004273 void Run(const std::string& generic_type_decl,
4274 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004275 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004276 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004277 const auto& kind = std::get<1>(param).kind;
4278
4279 FakeIoDelegate io;
4280 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4281 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4282 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004283 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4284 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004285
4286 const auto options =
4287 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4288 CaptureStderr();
4289 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004290 auto it = expectations.find(lang + "_" + kind);
4291 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004292 const string err = GetCapturedStderr();
4293 if (it->second.empty()) {
4294 EXPECT_EQ("", err);
4295 } else {
4296 EXPECT_THAT(err, testing::HasSubstr(it->second));
4297 }
4298 }
4299};
4300
4301INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004302 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004303 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4304 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004305 testing::ValuesIn(kTypeParams)),
4306 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004307 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004308 });
4309
Jooyung Hanfd3be322020-12-13 09:11:06 +09004310TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4311 Run("List<{}>", kListSupportExpectations);
4312}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004313
Jooyung Hand236e552020-12-13 09:21:27 +09004314TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4315 Run("{}[]", kArraySupportExpectations);
4316}
4317
Christopher Wiley90be4e32015-10-20 14:55:25 -07004318} // namespace aidl
4319} // namespace android