blob: b3e07bd4b9c072f4049558cab703b82fc8e84f21 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090038#include "parser.h"
39#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070040#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041
42using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080043using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090044using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070046using std::string;
47using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080048using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090049using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070050using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090051using testing::internal::CaptureStderr;
52using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070053
54namespace android {
55namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070056namespace {
57
58const char kExpectedDepFileContents[] =
59R"(place/for/output/p/IFoo.java : \
60 p/IFoo.aidl
61
62p/IFoo.aidl :
63)";
64
Dan Willemsen93298ee2016-11-10 23:55:55 -080065const char kExpectedNinjaDepFileContents[] =
66R"(place/for/output/p/IFoo.java : \
67 p/IFoo.aidl
68)";
69
Jiyong Parkdf202122019-09-30 20:48:35 +090070const char kExpectedParcelableDeclarationDepFileContents[] =
71 R"( : \
72 p/Foo.aidl
73
74p/Foo.aidl :
75)";
76
77const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080078 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070079 p/Foo.aidl
80
81p/Foo.aidl :
82)";
83
Christopher Wileyf8136192016-04-12 14:19:35 -070084} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070085
Devin Moore7b8d5c92020-03-17 14:14:08 -070086class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070087 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090088 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
89 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070090 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070091 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090092 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070093 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090094 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070095 for (const string& s : additional_arguments) {
96 args.emplace_back(s);
97 }
98 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--preprocessed=" + f);
100 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700101 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900102 args.emplace_back("--include=" + i);
103 }
104 args.emplace_back(path);
105 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900106 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900107 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900109 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900110
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700111 if (error != nullptr) {
112 *error = actual_error;
113 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900114
115 if (actual_error != AidlError::OK) {
116 return nullptr;
117 }
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900120 EXPECT_EQ(1ul, defined_types.size());
121
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900122 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700123 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124
Devin Moore7b8d5c92020-03-17 14:14:08 -0700125 Options::Language GetLanguage() { return GetParam(); }
126
Christopher Wiley0522cd52015-10-28 15:39:44 -0700127 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800128 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900129 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900130 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700131};
132
Devin Moore7b8d5c92020-03-17 14:14:08 -0700133// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
134// tests with each of the supported languages as a parameter.
135INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
136 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700137 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700138 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900139 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 });
141
142TEST_P(AidlTest, AcceptMissingPackage) {
143 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700144}
145
Devin Moore7b8d5c92020-03-17 14:14:08 -0700146TEST_P(AidlTest, EndsInSingleLineComment) {
147 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700148}
149
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000150TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
151 const string expected_stderr =
152 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
153 const std::string file_contents = "package a; interface IBar {}";
154 CaptureStderr();
155 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
156 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
157}
158
159TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
160 const string expected_stderr =
161 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
162 const std::string file_contents = "package a; interface Bar {}";
163 CaptureStderr();
164 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
165 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
166}
167
168TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
169 const string expected_stderr =
170 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
171 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
172 CaptureStderr();
173 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
174 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
175}
176
177TEST_P(AidlTest, EnumRequiresCorrectPath) {
178 const string expected_stderr =
179 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
180 const std::string file_contents = "package a; enum Bar { A, }";
181 CaptureStderr();
182 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
183 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
184}
185
Devin Moore7b8d5c92020-03-17 14:14:08 -0700186TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900187 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700188 io_delegate_.SetFileContents("bar/IBar.aidl",
189 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700190 const string path = "foo/IFoo.aidl";
191 const string contents =
192 "package foo;\n"
193 "import bar.IBar;\n"
194 "interface IFoo { void f(in IBar[] input); }";
195 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
196 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700197 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700199}
200
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700202 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900204}
Devin Moore097a3ab2020-03-11 16:08:44 -0700205
Jiyong Park40782d02020-07-24 19:17:43 +0900206TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700207 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
208 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900209 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
210 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700211 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900214}
215
Jiyong Park40782d02020-07-24 19:17:43 +0900216TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900217 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700218 const string expected_stderr =
219 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700220 CaptureStderr();
221 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900223}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224
Jiyong Park40782d02020-07-24 19:17:43 +0900225TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900226 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900227 const string expected_stderr =
228 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700229 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700230 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700232}
233
Devin Moore7b8d5c92020-03-17 14:14:08 -0700234TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700235 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
236 const string expected_stderr =
237 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
238 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700239 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700241}
242
Devin Moore7b8d5c92020-03-17 14:14:08 -0700243TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700244 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
245 const string expected_stderr =
246 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
247 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800250}
251
Devin Moore2f2077a2020-08-28 11:27:53 -0700252TEST_P(AidlTest, AcceptNullableList) {
253 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
254 const string expected_stderr = "";
255 CaptureStderr();
256 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
258}
259
Devin Moore7b8d5c92020-03-17 14:14:08 -0700260TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700261 const string method = "package a; interface IFoo { void f(int a, int a); }";
262 const string expected_stderr =
263 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
264 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700265 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700266 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700267}
268
Jeongik Cha13066da2020-08-06 15:43:19 +0900269TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
270 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900271 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900272 CaptureStderr();
273 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
274 EXPECT_EQ(expected_stderr, GetCapturedStderr());
275}
276
Jooyung Hand902a972020-10-23 17:32:44 +0900277TEST_P(AidlTest, RejectsRepeatedAnnotations) {
278 const string method = R"(@Hide @Hide parcelable Foo {})";
279 const string expected_stderr =
280 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
281 "Foo.aidl:1.1-6\n";
282 CaptureStderr();
283 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
285}
286
Jooyung Han05bd8a82021-04-28 23:56:38 +0900287TEST_P(AidlTest, AcceptsEmptyParcelable) {
288 CaptureStderr();
289 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
290 EXPECT_EQ("", GetCapturedStderr());
291}
292
Devin Moore7b8d5c92020-03-17 14:14:08 -0700293TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700294 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
295 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
296 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700297 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700298 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100299}
300
Devin Moore7b8d5c92020-03-17 14:14:08 -0700301TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700302 AidlError error;
303 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700304 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700305 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700307 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 AidlError error;
312 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700313 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700314 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900315 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 AidlError error;
321 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700322 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900324 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700325 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800326}
327
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700329 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000330 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700331 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000332 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900333 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700334 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800335}
336
Jiyong Park40782d02020-07-24 19:17:43 +0900337TEST_P(AidlTest, ParsesNonNullableAnnotation) {
338 auto parse_result =
339 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
340 ASSERT_NE(nullptr, parse_result);
341 const AidlInterface* interface = parse_result->AsInterface();
342 ASSERT_NE(nullptr, interface);
343 ASSERT_FALSE(interface->GetMethods().empty());
344 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
345}
346
Devin Moore7b8d5c92020-03-17 14:14:08 -0700347TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900348 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
349 typenames_, GetLanguage());
350 ASSERT_NE(nullptr, parse_result);
351 const AidlInterface* interface = parse_result->AsInterface();
352 ASSERT_NE(nullptr, interface);
353 ASSERT_FALSE(interface->GetMethods().empty());
354 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
355}
356
357TEST_P(AidlTest, ParsesNonUtf8Annotations) {
358 auto parse_result =
359 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
360 ASSERT_NE(nullptr, parse_result);
361 const AidlInterface* interface = parse_result->AsInterface();
362 ASSERT_NE(nullptr, interface);
363 ASSERT_FALSE(interface->GetMethods().empty());
364 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900368 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
369 typenames_, GetLanguage());
370 ASSERT_NE(nullptr, parse_result);
371 const AidlInterface* interface = parse_result->AsInterface();
372 ASSERT_NE(nullptr, interface);
373 ASSERT_FALSE(interface->GetMethods().empty());
374 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800375}
376
Devin Moore7b8d5c92020-03-17 14:14:08 -0700377TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700378 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700379 const string expected_stderr =
380 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
381 "\"vintf\"'\n"
382 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
383 "--structured\n";
384 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700386 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700388 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700389}
390
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700392 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700393 const string expected_stderr =
394 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
395 "--structured\n";
396 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700397 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700398 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700400 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700401}
402
Devin Moore7b8d5c92020-03-17 14:14:08 -0700403TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700404 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700405 const string expected_stderr =
406 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
407 "\"vintf\"'\n";
408 CaptureStderr();
409 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700410 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700411 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700412 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700413}
414
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700416 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
418 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700419 ASSERT_EQ(AidlError::OK, error);
420 ASSERT_NE(nullptr, parse_result);
421 const AidlInterface* interface = parse_result->AsInterface();
422 ASSERT_NE(nullptr, interface);
423 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700424}
425
Jeongik Cha64783ed2019-06-07 18:30:54 +0900426TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
427 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900428 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
429 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900430 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700431 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900432 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900433 "a/Foo.aidl",
434 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900435
436 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900437 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700438 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900439 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700440 "Parcelable must be defined in AIDL directly.\n";
441 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900442 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700443 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700444
445 CaptureStderr();
446 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
447 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900448}
449
Jooyung Han1cbc4962020-10-25 10:07:15 +0900450TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
451 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
452 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
453 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900454 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
455
456 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900457 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900458 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
459
460 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900461 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900462 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
463
Jooyung Han1cbc4962020-10-25 10:07:15 +0900464 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900465 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
466}
467
Jooyung Han1cbc4962020-10-25 10:07:15 +0900468TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
469 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
470 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
471 CaptureStderr();
472 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
473 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
474 EXPECT_EQ("", GetCapturedStderr());
475
476 const string expected_to_string_method = R"--(
477 @Override
478 public String toString() {
479 switch (_tag) {
480 case a: return "a.Foo.a(" + (getA()) + ")";
481 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
482 }
483 throw new IllegalStateException("unknown field: " + _tag);
484 }
485)--";
486
487 string java_out;
488 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
489 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
490}
491
Jiyong Park9aa3d042020-12-04 23:30:02 +0900492TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
493 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
494 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
495 CaptureStderr();
496 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
497 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
498 EXPECT_EQ("", GetCapturedStderr());
499
500 const std::string expected = R"--(
501 @Override
502 public boolean equals(Object other) {
503 if (this == other) return true;
504 if (other == null) return false;
505 if (!(other instanceof Foo)) return false;
506 Foo that = (Foo)other;
507 if (!java.util.Objects.deepEquals(a, that.a)) return false;
508 if (!java.util.Objects.deepEquals(b, that.b)) return false;
509 return true;
510 }
511
512 @Override
513 public int hashCode() {
514 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
515 }
516)--";
517
518 string java_out;
519 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
520 EXPECT_THAT(java_out, testing::HasSubstr(expected));
521}
522
523TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
524 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
525 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
526 CaptureStderr();
527 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
528 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
529 EXPECT_EQ("", GetCapturedStderr());
530
531 const std::string expected = R"--(
532 @Override
533 public boolean equals(Object other) {
534 if (this == other) return true;
535 if (other == null) return false;
536 if (!(other instanceof Foo)) return false;
537 Foo that = (Foo)other;
538 if (_tag != that._tag) return false;
539 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
540 return true;
541 }
542
543 @Override
544 public int hashCode() {
545 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
546 }
547)--";
548
549 string java_out;
550 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
551 EXPECT_THAT(java_out, testing::HasSubstr(expected));
552}
553
Jooyung Han90345002020-10-23 15:28:53 +0900554TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900555 {
Jooyung Han90345002020-10-23 15:28:53 +0900556 io_delegate_.SetFileContents("a/Foo.aidl",
557 "package a; @JavaDerive(blah=true) parcelable Foo{}");
558 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
559 CaptureStderr();
560 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
561 const std::string expected_stderr =
562 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900563 EXPECT_THAT(GetCapturedStderr(),
564 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900565 }
566
567 {
568 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900569 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
570 CaptureStderr();
571 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900572 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900573 }
574
575 {
Jooyung Han90345002020-10-23 15:28:53 +0900576 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900577 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900580 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900581 }
582}
583
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900584TEST_P(AidlTest, ParseDescriptorAnnotation) {
585 AidlError error;
586 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
587 typenames_, GetLanguage(), &error, {"--structured"});
588 ASSERT_EQ(AidlError::OK, error);
589 ASSERT_NE(nullptr, parse_result);
590 const AidlInterface* interface = parse_result->AsInterface();
591 ASSERT_NE(nullptr, interface);
592 ASSERT_EQ("IBar", interface->GetDescriptor());
593}
594
Jiyong Park40782d02020-07-24 19:17:43 +0900595TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700596 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700597 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900598}
599
600TEST_P(AidlTest, AcceptsOnewayInterface) {
601 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700602 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700603}
Christopher Wileyef140932015-11-03 09:29:19 -0800604
Devin Moore7b8d5c92020-03-17 14:14:08 -0700605TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700606 const string oneway_method =
607 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700608 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100609}
610
Steven Moreland65297cc2020-04-20 20:17:36 -0700611TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
612 const string oneway_method =
613 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
614 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
615 ASSERT_NE(nullptr, defined);
616 const AidlInterface* iface = defined->AsInterface();
617 ASSERT_NE(nullptr, iface);
618
619 const auto& methods = iface->GetMethods();
620 ASSERT_EQ(1u, methods.size());
621 const auto& method = methods[0];
622 const AidlTypeSpecifier& ret_type = method->GetType();
623
624 // TODO(b/151102494): these annotations should be on the method
625 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
626 ASSERT_TRUE(ret_type.IsHide());
627}
628
Devin Moore7b8d5c92020-03-17 14:14:08 -0700629TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100630 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900631 R"(package a;
632 /* foo */
633 interface IFoo {
634 /* i */
635 int i();
636 // j
637 @nullable String j();
638 // k1
639 /* k2 */
640 @UnsupportedAppUsage oneway void k(int a);
641 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100642
Jooyung Han8451a202021-01-16 03:07:06 +0900643 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700644 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100645 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900646 EXPECT_EQ("", GetCapturedStderr());
647
Jooyung Han161bb0f2021-01-21 12:30:16 +0900648 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100649
650 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900651 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
652 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
653 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100654}
655
Jooyung Han1a551d32020-10-05 15:37:26 +0900656TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
657 io_delegate_.SetFileContents("p/cpp_header.aidl",
658 R"(package p;
659 parcelable cpp_header cpp_header "bar/header";)");
660 import_paths_.emplace("");
661 const string input_path = "p/IFoo.aidl";
662 const string input = R"(package p;
663 import p.cpp_header;
664 interface IFoo {
665 // get bar
666 cpp_header get();
667 })";
668
669 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
670 EXPECT_NE(nullptr, parse_result);
671 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900672 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900673}
674
Christopher Wileyef140932015-11-03 09:29:19 -0800675TEST_F(AidlTest, ParsesPreprocessedFile) {
676 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
677 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700678 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900679 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700680 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
681 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800682}
683
684TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
685 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
686 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900687
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700688 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900689 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700690 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
691 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800692}
693
Devin Moore7b8d5c92020-03-17 14:14:08 -0700694TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800695 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
696 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
697 "interface IBar {}");
698 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900699 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900700 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700701 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800702 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900703
Christopher Wiley41544372015-11-03 14:52:29 -0800704 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700705 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
706 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800707 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900708 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900709 ambiguous_type.Resolve(typenames_);
710 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800711}
712
Jiyong Park8f6ec462020-01-19 20:52:47 +0900713// Special case of PreferImportToPreprocessed. Imported type should be preferred
714// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700715TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900716 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
717 io_delegate_.SetFileContents("one/IBar.aidl",
718 "package one; "
719 "interface IBar {}");
720 preprocessed_files_.push_back("preprocessed");
721 import_paths_.emplace("");
722 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700723 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900724 EXPECT_NE(nullptr, parse_result);
725
726 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700727 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
728 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900729 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900730 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jiyong Park8f6ec462020-01-19 20:52:47 +0900731 ambiguous_type.Resolve(typenames_);
732 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
733}
734
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800735TEST_F(AidlTest, WritePreprocessedFile) {
736 io_delegate_.SetFileContents("p/Outer.aidl",
737 "package p; parcelable Outer.Inner;");
738 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
739 "interface IBar {}");
740
Jooyung Han93f48f02021-06-05 00:11:16 +0900741 vector<string> args{"aidl", "--preprocess", "preprocessed",
742 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900743 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900744 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800745
Jooyung Han93f48f02021-06-05 00:11:16 +0900746 std::map<std::string, std::string> expected = {{"preprocessed",
747 "parcelable p.Outer.Inner;\n"
748 "interface one.IBar {\n"
749 "}\n"}};
750 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
751}
752
753TEST_F(AidlTest, PreprocessVariousThings) {
754 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
755 "package foo.bar;\n"
756 "interface IFoo {\n"
757 " int foo();\n"
758 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
759 "}\n");
760 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
761 "package foo.bar;\n"
762 "parcelable Bar {\n"
763 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
764 " imported.Foo foo;\n"
765 "}\n");
766 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
767 "package foo.bar;\n"
768 "parcelable Gen<T> {\n"
769 "}\n");
770 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
771 "package foo.bar;\n"
772 "enum Enum {\n"
773 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
774 "}\n");
775 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
776 "package imported;\n"
777 "parcelable Foo {\n"
778 " const int FOO = 42;\n"
779 "}\n");
780
781 vector<string> args = {
782 "aidl",
783 "--preprocess",
784 "preprocessed",
785 "-Isub",
786 "-I.",
787 "foo/bar/IFoo.aidl",
788 "foo/bar/Bar.aidl",
789 "foo/bar/Gen.aidl",
790 "foo/bar/Enum.aidl",
791 };
792 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
793 std::string preprocessed =
794 "interface foo.bar.IFoo {\n"
795 " const int FOO = 44;\n"
796 "}\n"
797 "parcelable foo.bar.Bar {\n"
798 " const int BAR = 43;\n"
799 "}\n"
800 "parcelable foo.bar.Gen<T> {\n"
801 "}\n"
802 "enum foo.bar.Enum {\n"
803 " FOO = 3,\n"
804 " BAR = 6,\n"
805 "}\n";
806 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
807 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
808
809 // use preprocessed
810 io_delegate_.SetFileContents("a/Foo.aidl",
811 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
812 io_delegate_.SetFileContents("preprocessed", preprocessed);
813 CaptureStderr();
814 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
815 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
816 EXPECT_EQ("", GetCapturedStderr());
817 string code;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
819 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
820}
821
822TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
823 string simple_content = "package xxx; parcelable a.Foo;";
824 io_delegate_.SetFileContents("path", simple_content);
825 CaptureStderr();
826 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
827 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
828}
829
830TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
831 string simple_content = "parcelable a.Foo {}";
832 io_delegate_.SetFileContents("path", simple_content);
833 CaptureStderr();
834 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
835 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800836}
837
Jooyung Han720253d2021-01-05 19:13:17 +0900838TEST_P(AidlTest, SupportDeprecated) {
839 struct TestCase {
840 std::string output_file;
841 std::string annotation;
842 };
843
844 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900845 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900846 io_delegate_.SetFileContents(filename, contents);
847
848 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
849 " --out=out --header_out=out");
850 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900851 for (const auto& [lang, test_case] : expectations) {
852 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900853 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900854 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900855 EXPECT_THAT(output, HasSubstr(test_case.annotation));
856 }
857 };
858
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900859 // Emit escaped string for notes
860 CheckDeprecated(
861 "IFoo.aidl",
862 R"(interface IFoo {
863 /**
864 * @note asdf
865 * @deprecated a really long deprecation message
866 *
867 * which is really long
868 * @param foo bar
869 */
870 List<String> foo();
871 })",
872 {
873 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
874 {Options::Language::CPP,
875 {"out/IFoo.h",
876 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
877 {Options::Language::NDK,
878 {"out/aidl/IFoo.h",
879 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
880 {Options::Language::RUST,
881 {"out/IFoo.rs",
882 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
883 });
884
Jooyung Han24effbf2021-01-16 10:24:03 +0900885 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900886 CheckDeprecated(
887 "IFoo.aidl",
888 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +0900889 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900890 " List<String> foo();\n"
891 "}",
892 {
893 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900894 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900895 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
896 {Options::Language::NDK,
897 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
898 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
899 });
Jooyung Han720253d2021-01-05 19:13:17 +0900900
Jooyung Han24effbf2021-01-16 10:24:03 +0900901 // but not in line comments
902 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
903 EXPECT_FALSE(parsed->IsDeprecated());
904
905 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +0900906 CheckDeprecated("Foo.aidl",
907 "parcelable Foo {\n"
908 " /** @deprecated use bar*/\n"
909 " int foo = 0;\n"
910 "}",
911 {
912 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
913 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
914 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
915 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
916 });
917
Jooyung Han24effbf2021-01-16 10:24:03 +0900918 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +0900919 CheckDeprecated("IFoo.aidl",
920 "interface IFoo {\n"
921 " /** @deprecated use bar*/\n"
922 " const int FOO = 0;\n"
923 "}",
924 {
925 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
926 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
927 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
928 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
929 });
930
931 // union fields
932 CheckDeprecated("Foo.aidl",
933 "union Foo {\n"
934 " int bar = 0;\n"
935 " /** @deprecated use bar*/\n"
936 " int foo;\n"
937 "}",
938 {
939 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
940 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
941 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
942 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
943 });
944
945 CheckDeprecated("Foo.aidl",
946 "/** @deprecated use Bar */\n"
947 "parcelable Foo {}",
948 {
949 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
950 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
951 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
952 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
953 });
954
955 CheckDeprecated("Foo.aidl",
956 "/** @deprecated use Bar */\n"
957 "union Foo { int foo = 0; }",
958 {
959 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
960 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
961 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
962 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
963 });
964
965 CheckDeprecated("IFoo.aidl",
966 "/** @deprecated use IBar */\n"
967 "interface IFoo {}",
968 {
969 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
970 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
971 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
972 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
973 });
974
975 CheckDeprecated("Foo.aidl",
976 "/** @deprecated use IBar */\n"
977 "enum Foo { FOO }",
978 {
979 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
980 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
981 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +0900982 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +0900983 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
984 });
985}
986
Devin Moore7b8d5c92020-03-17 14:14:08 -0700987TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800989 io_delegate_.SetFileContents("p/Outer.aidl",
990 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900991 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700992 CaptureStderr();
993 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
994 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700995 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700996 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800997}
998
Devin Moore7b8d5c92020-03-17 14:14:08 -0700999TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001000 io_delegate_.SetFileContents("preprocessed",
1001 "parcelable p.Outer.Inner;");
1002 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001003 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001004 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001005 // TODO(wiley): This should actually return nullptr because we require
1006 // the outer class name. However, for legacy reasons,
1007 // this behavior must be maintained. b/17415692
1008 EXPECT_NE(nullptr, parse_result);
1009}
1010
Christopher Wiley632801d2015-11-05 14:15:49 -08001011TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001012 const string expected_foo_stderr =
1013 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1014 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1015 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001016 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1017
Christopher Wiley632801d2015-11-05 14:15:49 -08001018 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001019 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001020 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001021 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001022 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001023
Steven Morelande2c64b42018-09-18 15:06:37 -07001024 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001025 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001026 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001027 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001028 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001029
Devin Moore097a3ab2020-03-11 16:08:44 -07001030 const string expected_bar_stderr =
1031 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1032 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1033 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001034 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1035
Jiyong Parkda8c6932019-08-12 19:56:08 +09001036 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001037 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001038 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +09001039 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001040 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001041 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001042 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -07001043 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001044 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001045}
1046
Devin Moore7b8d5c92020-03-17 14:14:08 -07001047TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001048 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001049 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001050 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001051 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
1052 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001053 AidlError error;
1054 CaptureStderr();
1055 EXPECT_EQ(
1056 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001057 Parse("p/IFoo.aidl",
1058 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1061 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001062}
1063
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001065 AidlError error;
1066 const string expected_stderr =
1067 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1068 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001069 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1070 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001071 interface IFoo {
1072 const String DUPLICATED = "d";
1073 const int DUPLICATED = 1;
1074 }
1075 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001076 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001077 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1078 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001079}
1080
Steven Morelande689da22020-11-10 02:06:30 +00001081TEST_P(AidlTest, FailOnTooBigConstant) {
1082 AidlError error;
1083 const string expected_stderr =
1084 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1085 CaptureStderr();
1086 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1087 R"(package p;
1088 interface IFoo {
1089 const byte type2small = 256;
1090 }
1091 )",
1092 typenames_, GetLanguage(), &error));
1093 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1094 EXPECT_EQ(AidlError::BAD_TYPE, error);
1095}
1096
Jooyung Han30f64ad2020-12-15 08:16:31 +09001097TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1098 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1099 CaptureStderr();
1100 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1101 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1102 EXPECT_EQ("", GetCapturedStderr());
1103 string code;
1104 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1105 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1106}
1107
Jooyung Han535c5e82020-12-29 15:16:59 +09001108TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001109 using Ptr = unique_ptr<AidlConstantValue>;
1110 const AidlLocation& loc = AIDL_LOCATION_HERE;
1111
Jooyung Han535c5e82020-12-29 15:16:59 +09001112 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1113 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1114 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1115 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001116
1117 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1118 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001119 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001120
1121 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1122 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1123 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1124 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001125 EXPECT_EQ(
1126 expected,
1127 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001128}
1129
Devin Moore7b8d5c92020-03-17 14:14:08 -07001130TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001131 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001132 const string expected_stderr =
1133 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001134 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001135 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1136 R"(package p;
1137 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001138 parcelable IBar {}
1139 parcelable StructuredParcelable {}
1140 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001141 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001142 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001143 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001144 // Parse success is important for clear error handling even if the cases aren't
1145 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001150 AidlError error;
1151 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1152 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001154 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1155 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001156}
1157
Steven Morelandf9e922f2020-07-08 21:15:27 +00001158TEST_P(AidlTest, FailOnEmptyListWithComma) {
1159 AidlError error;
1160 const string expected_stderr =
1161 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1162 CaptureStderr();
1163 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1164 typenames_, GetLanguage(), &error));
1165 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1166 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1167}
1168
Devin Moore7b8d5c92020-03-17 14:14:08 -07001169TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 AidlError error;
1171 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001172 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001173 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001174 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1175 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001176 interface IFoo {
1177 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1178 }
1179 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001180 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001181 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1182 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001183}
1184
Jiyong Park18132182020-06-08 20:24:40 +09001185TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1186 AidlError error;
1187 const string expected_stderr =
1188 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1189 "cpp_header (which can also be used as an identifier)\n";
1190 CaptureStderr();
1191 // Notice the trailing dot(.) in the name, which isn't a correct name
1192 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1193 GetLanguage(), &error));
1194 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1195 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1196}
1197
1198TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1199 AidlError error;
1200 const string expected_stderr =
1201 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1202 "cpp_header (which can also be used as an identifier)\n";
1203 CaptureStderr();
1204 // Notice the trailing dot(.) in the package name
1205 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1206 GetLanguage(), &error));
1207 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1208 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1209}
1210
Devin Moore7b8d5c92020-03-17 14:14:08 -07001211TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001212 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001213 auto parse_result = Parse("p/IFoo.aidl",
1214 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001215 interface IFoo {
1216 const int POSITIVE_HEX_VALUE = 0xf5;
1217 }
1218 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001219 typenames_, GetLanguage(), &error);
1220 EXPECT_NE(nullptr, parse_result);
1221 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001222 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001223 const auto& cpp_constants = interface->GetConstantDeclarations();
1224 EXPECT_EQ((size_t)1, cpp_constants.size());
1225 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001226 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001227 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001228}
1229
Devin Moore7b8d5c92020-03-17 14:14:08 -07001230TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001231 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001232 auto parse_result = Parse("p/IFoo.aidl",
1233 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001234 interface IFoo {
1235 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1236 }
1237 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001238 typenames_, GetLanguage(), &error);
1239 ASSERT_NE(nullptr, parse_result);
1240 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001241 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001242 const auto& cpp_constants = interface->GetConstantDeclarations();
1243 EXPECT_EQ((size_t)1, cpp_constants.size());
1244 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001245 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001246 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001247}
1248
Devin Moore7b8d5c92020-03-17 14:14:08 -07001249TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001250 io_delegate_.SetFileContents(
1251 "p/Outer.aidl",
1252 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001253 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001254 const string input_path = "p/IFoo.aidl";
1255 const string input = "package p; import p.Outer; interface IFoo"
1256 " { Outer.Inner get(); }";
1257
Devin Moore7b8d5c92020-03-17 14:14:08 -07001258 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1259 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001260
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001261 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001262 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001263 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001264 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001265}
1266
Jooyung Han0a950bd2021-05-15 12:50:36 +09001267TEST_F(AidlTest, CppNameOf_GenericType) {
1268 io_delegate_.SetFileContents("p/Wrapper.aidl", "package p; parcelable Wrapper<T> { T wrapped; }");
1269 import_paths_.emplace("");
1270 // Since we don't support compilation of Wrapper directly (due to "T" reference),
1271 // prepare Holder so that Wrapper gets parsed into AidlTypenames
1272 const string input_path = "p/Holder.aidl";
1273 const string input =
1274 "package p; import p.Wrapper; parcelable Holder {\n"
1275 " @nullable Wrapper<String> value;\n"
1276 "}";
1277
1278 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1279 EXPECT_NE(nullptr, parse_result);
1280
1281 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1282 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1283 (..., params->emplace_back(std::move(type_params)));
1284 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1285 };
1286
1287 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1288 std::vector<AidlAnnotation> annotations;
1289 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", nullptr, {}));
1290 type->Annotate(std::move(annotations));
1291 return std::move(type);
1292 };
1293
1294 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1295 (void)type->SetArray();
1296 return std::move(type);
1297 };
1298
1299 auto w = type("p.Wrapper", type("String"));
1300 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1301
1302 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1303 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1304 cpp::CppNameOf(*nullable_w, typenames_));
1305
1306 auto array_w = set_array(type("p.Wrapper", type("String")));
1307 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1308 cpp::CppNameOf(*array_w, typenames_));
1309
1310 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1311 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1312 cpp::CppNameOf(*nullable_array_w, typenames_));
1313
1314 auto list_w = type("List", type("p.Wrapper", type("String")));
1315 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1316 cpp::CppNameOf(*list_w, typenames_));
1317
1318 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1319 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1320 cpp::CppNameOf(*nullable_list_w, typenames_));
1321}
1322
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001324 io_delegate_.SetFileContents(
1325 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001326 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001327 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001328 const string input_path = "p/IFoo.aidl";
1329 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001330 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1331 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001332 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001333 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Devin Moore7b8d5c92020-03-17 14:14:08 -07001334 native_type.Resolve(typenames_);
1335
1336 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1337 // C++ understands C++ specific stuff
1338 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1339 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001340 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001341 EXPECT_EQ(1u, headers.size());
1342 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001343}
1344
Christopher Wileyf8136192016-04-12 14:19:35 -07001345TEST_F(AidlTest, WritesCorrectDependencyFile) {
1346 // While the in tree build system always gives us an output file name,
1347 // other android tools take advantage of our ability to infer the intended
1348 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001349 vector<string> args = {
1350 "aidl",
1351 "-d dep/file/path",
1352 "-o place/for/output",
1353 "p/IFoo.aidl"};
1354 Options options = Options::From(args);
1355 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001356 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001357 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001358 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001359 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1360}
1361
Dan Willemsen93298ee2016-11-10 23:55:55 -08001362TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1363 // While the in tree build system always gives us an output file name,
1364 // other android tools take advantage of our ability to infer the intended
1365 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001366 vector<string> args = {
1367 "aidl",
1368 "-d dep/file/path",
1369 "--ninja",
1370 "-o place/for/output",
1371 "p/IFoo.aidl"};
1372 Options options = Options::From(args);
1373 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001374 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001375 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001376 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001377 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1378}
1379
Jiyong Parkdf202122019-09-30 20:48:35 +09001380TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001381 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1382 // this by calling aidl with every .aidl file it finds, then parsing the
1383 // generated dependency files. Those that reference .java output files are
1384 // for interfaces and those that do not are parcelables. However, for both
1385 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001386 vector<string> args = {
1387 "aidl",
1388 "-o place/for/output",
1389 "-d dep/file/path",
1390 "p/Foo.aidl"};
1391 Options options = Options::From(args);
1392 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001393 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001394 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001395 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001396 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1397}
1398
1399TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1400 vector<string> args = {
1401 "aidl",
1402 "--structured",
1403 "-o place/for/output",
1404 "-d dep/file/path",
1405 "p/Foo.aidl"};
1406 Options options = Options::From(args);
1407 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1408 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1409 string actual_dep_file_contents;
1410 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1411 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001412}
1413
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001414TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1415 vector<string> args = {
1416 "aidl",
1417 "--lang=java",
1418 "-o place/for/output",
1419 "p/Foo.aidl"};
1420 Options options = Options::From(args);
1421 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1422 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1423 string output_file_contents;
1424 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1425}
1426
Devin Moore21b26772020-08-26 16:37:56 -07001427TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001428 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001429 const string list_array_parcelable =
1430 "package a; parcelable Foo {\n"
1431 " List[] lists; }";
1432 CaptureStderr();
1433 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1435}
1436
Jiyong Parkf8d53612020-05-04 14:06:13 +09001437TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1438 AidlError error;
1439 string expected_stderr =
1440 "ERROR: a/IFoo.aidl:2.7-11: "
1441 "Encountered an untyped List or Map. The use of untyped List/Map is "
1442 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1443 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1444 if (GetLanguage() != Options::Language::JAVA) {
1445 expected_stderr =
1446 "ERROR: a/IFoo.aidl:2.1-7: "
1447 "Currently, only the Java backend supports non-generic List.\n";
1448 }
1449
1450 const string primitive_interface =
1451 "package a; interface IFoo {\n"
1452 " List foo(); }";
1453 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001454 AidlTypenames tn1;
1455 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001456 {"--structured"}));
1457 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001458
1459 string primitive_parcelable =
1460 "package a; parcelable IFoo {\n"
1461 " List foo;}";
1462 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001463 AidlTypenames tn2;
1464 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001465 {"--structured"}));
1466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1467}
1468
Jeongik Cha225519b2020-08-29 01:55:32 +09001469TEST_P(AidlTest, ExtensionTest) {
1470 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001471 string extendable_parcelable =
1472 "package a; parcelable Data {\n"
1473 " ParcelableHolder extension;\n"
1474 " ParcelableHolder extension2;\n"
1475 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001476 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001477 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1478 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001479 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001480 "yet.\n",
1481 GetCapturedStderr());
1482 } else {
1483 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1484 EXPECT_EQ("", GetCapturedStderr());
1485 }
1486}
1487TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1488 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001489 string parcelableholder_return_interface =
1490 "package a; interface IFoo {\n"
1491 " ParcelableHolder foo();\n"
1492 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001493 EXPECT_EQ(nullptr,
1494 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001495
Jeongik Cha8f02a532020-10-14 00:16:28 +09001496 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001497 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001498 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001499 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001500 "yet.\n",
1501 GetCapturedStderr());
1502 return;
1503 }
1504 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1505 GetCapturedStderr());
1506}
1507
1508TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1509 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001510 string extendable_parcelable_arg_interface =
1511 "package a; interface IFoo {\n"
1512 " void foo(in ParcelableHolder ph);\n"
1513 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001514 EXPECT_EQ(nullptr,
1515 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1516
Jeongik Cha8f02a532020-10-14 00:16:28 +09001517 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001518 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001519 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001520 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001521 "yet.\n",
1522 GetCapturedStderr());
1523 return;
1524 }
1525 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1526 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001527}
1528
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001529TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1530 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001531 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001532 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1533 CaptureStderr();
1534 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1535 if (GetLanguage() == Options::Language::RUST) {
1536 EXPECT_EQ(
1537 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1538 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1539 "yet.\n",
1540 GetCapturedStderr());
1541 return;
1542 }
1543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1544}
1545
Jooyung Han3f347ca2020-12-01 12:41:50 +09001546TEST_P(AidlTest, ParcelablesWithConstants) {
1547 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001548 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001549 CaptureStderr();
1550 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1551 EXPECT_EQ("", GetCapturedStderr());
1552}
1553
1554TEST_P(AidlTest, UnionWithConstants) {
1555 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001556 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001557 CaptureStderr();
1558 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1559 EXPECT_EQ("", GetCapturedStderr());
1560}
1561
Jooyung Han633eab62021-01-07 14:12:40 +09001562TEST_F(AidlTest, ConstantsWithAnnotations) {
1563 io_delegate_.SetFileContents("IFoo.aidl",
1564 "interface IFoo {\n"
1565 " @JavaPassthrough(annotation=\"@Foo\")\n"
1566 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1567 "}");
1568 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1569 CaptureStderr();
1570 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1571 EXPECT_EQ("", GetCapturedStderr());
1572 string code;
1573 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1574 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1575 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1576}
1577
Jiyong Park02da7422018-07-16 16:00:26 +09001578TEST_F(AidlTest, ApiDump) {
1579 io_delegate_.SetFileContents(
1580 "foo/bar/IFoo.aidl",
1581 "package foo.bar;\n"
1582 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001583 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001584 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001585 " /* @hide applied \n"
1586 " @deprecated use foo2 */\n"
1587 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1588 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001589 " IFoo foo3(IFoo foo);\n"
1590 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001591 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001592 " /** blahblah\n"
1593 " @deprecated\n"
1594 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001595 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001596 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001597 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001598 "}\n");
1599 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1600 "package foo.bar;\n"
1601 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001602 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001603 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001604 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001605 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001606 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001607 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001608 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001609 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001610 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001611 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001612 "}\n");
1613 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001614 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1615 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001616 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001617 bool result = dump_api(options, io_delegate_);
1618 ASSERT_TRUE(result);
1619 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001620 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001621 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001622interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001623 /**
1624 * @hide
1625 * @deprecated use foo2
1626 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001627 int foo(out int[] a, String b, boolean c, inout List<String> d);
1628 int foo2(@utf8InCpp String x, inout List<String> y);
1629 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1630 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001631 /**
1632 * @deprecated reason why...
1633 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001634 const int A = 1;
1635 const String STR = "Hello";
1636}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001637)"),
1638 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001639
Jiyong Parke59c3682018-09-11 23:10:25 +09001640 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001641 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001642/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001643parcelable Data {
1644 int x = 10;
1645 int y;
1646 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001647 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001648}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001649)"),
1650 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001651}
1652
Jiyong Parked65bf42018-08-28 15:43:27 +09001653TEST_F(AidlTest, ApiDumpWithManualIds) {
1654 io_delegate_.SetFileContents(
1655 "foo/bar/IFoo.aidl",
1656 "package foo.bar;\n"
1657 "interface IFoo {\n"
1658 " int foo() = 1;\n"
1659 " int bar() = 2;\n"
1660 " int baz() = 10;\n"
1661 "}\n");
1662
Jiyong Parke59c3682018-09-11 23:10:25 +09001663 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001664 Options options = Options::From(args);
1665 bool result = dump_api(options, io_delegate_);
1666 ASSERT_TRUE(result);
1667 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001668 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001669 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001670interface IFoo {
1671 int foo() = 1;
1672 int bar() = 2;
1673 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001674}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001675)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001676}
1677
1678TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001679 const string expected_stderr =
1680 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1681 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001682 io_delegate_.SetFileContents(
1683 "foo/bar/IFoo.aidl",
1684 "package foo.bar;\n"
1685 "interface IFoo {\n"
1686 " int foo() = 1;\n"
1687 " int bar();\n"
1688 " int baz() = 10;\n"
1689 "}\n");
1690
Jiyong Parke59c3682018-09-11 23:10:25 +09001691 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001692 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001693 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001694 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001695 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001696}
1697
Jooyung Han965e31d2020-11-27 12:30:16 +09001698TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1699 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1700 "package foo.bar;\n"
1701 "interface IFoo {\n"
1702 " @utf8InCpp String foo();\n"
1703 " const @utf8InCpp String bar = \"bar\";\n"
1704 "}\n");
1705
1706 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1707 Options options = Options::From(args);
1708 CaptureStderr();
1709 EXPECT_TRUE(dump_api(options, io_delegate_));
1710 EXPECT_EQ("", GetCapturedStderr());
1711 string actual;
1712 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001713 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1714interface IFoo {
1715 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001716 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001717}
1718)"),
1719 actual);
1720}
1721
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001722TEST_F(AidlTest, ApiDumpWithEnums) {
1723 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1724 "package foo.bar;\n"
1725 "enum Enum {\n"
1726 " FOO,\n"
1727 " BAR = FOO + 1,\n"
1728 "}\n");
1729
1730 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1731 Options options = Options::From(args);
1732 CaptureStderr();
1733 EXPECT_TRUE(dump_api(options, io_delegate_));
1734 EXPECT_EQ("", GetCapturedStderr());
1735 string actual;
1736 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1737 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1738 "enum Enum {\n"
1739 " FOO = 0,\n"
1740 " BAR = 1,\n"
1741 "}\n"),
1742 actual);
1743}
1744
1745TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1746 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1747 "package foo.bar;\n"
1748 "enum Enum {\n"
1749 " FOO,\n"
1750 "}\n");
1751 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1752 "package foo.bar;\n"
1753 "import foo.bar.Enum;\n"
1754 "parcelable Foo {\n"
1755 " Enum e = Enum.FOO;\n"
1756 "}\n");
1757
1758 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1759 Options options = Options::From(args);
1760 CaptureStderr();
1761 EXPECT_TRUE(dump_api(options, io_delegate_));
1762 EXPECT_EQ("", GetCapturedStderr());
1763 string actual;
1764 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1765 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1766 "parcelable Foo {\n"
1767 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1768 "}\n"),
1769 actual);
1770}
1771
Jooyung Han71dfec32021-05-23 07:18:58 +09001772TEST_F(AidlTest, ApiDumpWithGenerics) {
1773 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1774 "package foo.bar;\n"
1775 "parcelable Foo<T, U> {\n"
1776 "}\n");
1777
1778 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1779 Options options = Options::From(args);
1780 CaptureStderr();
1781 EXPECT_TRUE(dump_api(options, io_delegate_));
1782 EXPECT_EQ("", GetCapturedStderr());
1783 string actual;
1784 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1785 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1786 "parcelable Foo<T, U> {\n"
1787 "}\n"),
1788 actual);
1789}
1790
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001791TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001792 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001793 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1794 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001795 const string expected_map_stderr =
1796 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001797 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1798 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001799 "package p; interface IFoo {"
1800 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001801 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001802 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001803 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001804
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001805 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001806 "package p; interface IFoo {"
1807 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001808 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001809 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001810 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001811}
1812
Jeongik Chae48d9942020-01-02 17:39:00 +09001813TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001814 const string expected_stderr =
1815 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001816 Options options = Options::From("aidl -I p p/IFoo.aidl");
1817 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1818
1819 io_delegate_.SetFileContents("p/IFoo.aidl",
1820 "package p; interface IFoo {"
1821 "Map<String, Bar> foo();}");
1822 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1823
1824 io_delegate_.SetFileContents("p/IFoo.aidl",
1825 "package p; interface IFoo {"
1826 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001827 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001828 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001829 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001830
1831 io_delegate_.SetFileContents("p/IFoo.aidl",
1832 "package p; interface IFoo {"
1833 "Map<String, String> foo();}");
1834 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1835
1836 io_delegate_.SetFileContents("p/IFoo.aidl",
1837 "package p; interface IFoo {"
1838 "Map<String, ParcelFileDescriptor> foo();}");
1839 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1840}
1841
Jeongik Chadf76dc72019-11-28 00:08:47 +09001842TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001843 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001844 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1845 io_delegate_.SetFileContents(options.InputFiles().front(),
1846 "package p; interface IFoo {"
1847 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001848 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001849 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001851}
1852
1853TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1854 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1855 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001856 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001857 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001858 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1859 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001860
1861 Options options = Options::From("aidl -I p p/IFoo.aidl");
1862 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1863 io_delegate_.SetFileContents("p/IFoo.aidl",
1864 "package p; interface IFoo {"
1865 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001866 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001867 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001868 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001869 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001870 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001871 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001872 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1873 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001874 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1875 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1876 io_delegate_.SetFileContents("p/IFoo.aidl",
1877 "package p; interface IFoo {"
1878 "Bar<String, ParcelFileDescriptor> foo();}");
1879 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001880
1881 io_delegate_.SetFileContents("p/IFoo.aidl",
1882 "package p; interface IFoo {"
1883 "Bar<int, long> foo();}");
1884
1885 io_delegate_.SetFileContents("p/IFoo.aidl",
1886 "package p; interface IFoo {"
1887 "Bar<int[], long[]> foo();}");
1888
1889 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001890}
1891
Jeongik Cha0e426012019-07-29 15:57:02 +09001892TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1893 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001894 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1895 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001896 for (const auto& rawOption : rawOptions) {
1897 string expected_stderr =
1898 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001899 Options options = Options::From(rawOption);
1900 io_delegate_.SetFileContents(options.InputFiles().front(),
1901 "package foo.bar;\n"
1902 "interface IFoo1 { int foo(); }\n"
1903 "interface IFoo2 { int foo(); }\n"
1904 "parcelable Data1 { int a; int b;}\n"
1905 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001906 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001907 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001908 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001909
Jeongik Cha0e426012019-07-29 15:57:02 +09001910 io_delegate_.SetFileContents(options.InputFiles().front(),
1911 "package foo.bar;\n"
1912 "interface IFoo1 { int foo(); }\n"
1913 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001914 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001915 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001916 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001917
Devin Moore5de18ed2020-04-02 13:52:29 -07001918 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001919 io_delegate_.SetFileContents(options.InputFiles().front(),
1920 "package foo.bar;\n"
1921 "parcelable Data1 { int a; int b;}\n"
1922 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001923 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001924 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001925 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001926 }
1927}
1928
Devin Moorebdba2a82020-03-31 15:19:02 -07001929TEST_P(AidlTest, FailParseOnEmptyFile) {
1930 const string contents = "";
1931 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1932 CaptureStderr();
1933 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1934 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1935}
1936
Jiyong Parkb034bf02018-07-30 17:44:33 +09001937TEST_F(AidlTest, MultipleInputFiles) {
1938 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001939 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001940
1941 io_delegate_.SetFileContents(options.InputFiles().at(0),
1942 "package foo.bar;\n"
1943 "import foo.bar.Data;\n"
1944 "interface IFoo { Data getData(); }\n");
1945
1946 io_delegate_.SetFileContents(options.InputFiles().at(1),
1947 "package foo.bar;\n"
1948 "import foo.bar.IFoo;\n"
1949 "parcelable Data { IFoo foo; }\n");
1950
1951 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1952
1953 string content;
1954 for (const auto file : {
1955 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1956 content.clear();
1957 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1958 EXPECT_FALSE(content.empty());
1959 }
1960}
1961
1962TEST_F(AidlTest, MultipleInputFilesCpp) {
1963 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001964 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001965
1966 io_delegate_.SetFileContents(options.InputFiles().at(0),
1967 "package foo.bar;\n"
1968 "import foo.bar.Data;\n"
1969 "interface IFoo { Data getData(); }\n");
1970
1971 io_delegate_.SetFileContents(options.InputFiles().at(1),
1972 "package foo.bar;\n"
1973 "import foo.bar.IFoo;\n"
1974 "parcelable Data { IFoo foo; }\n");
1975
1976 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1977
1978 string content;
1979 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001980 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001981 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1982 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1983 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1984 content.clear();
1985 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1986 EXPECT_FALSE(content.empty());
1987 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001988}
1989
Andrei Homescub62afd92020-05-11 19:24:59 -07001990TEST_F(AidlTest, MultipleInputFilesRust) {
1991 Options options =
1992 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1993
1994 io_delegate_.SetFileContents(options.InputFiles().at(0),
1995 "package foo.bar;\n"
1996 "import foo.bar.Data;\n"
1997 "interface IFoo { Data getData(); }\n");
1998
1999 io_delegate_.SetFileContents(options.InputFiles().at(1),
2000 "package foo.bar;\n"
2001 "import foo.bar.IFoo;\n"
2002 "parcelable Data { IFoo foo; }\n");
2003
2004 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2005
2006 string content;
2007 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2008 content.clear();
2009 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2010 EXPECT_FALSE(content.empty());
2011 }
2012}
2013
Devin Moore097a3ab2020-03-11 16:08:44 -07002014TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2015 const string expected_stderr =
2016 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002017 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2018 // int getInterfaceVersion() is one of the meta transactions
2019 io_delegate_.SetFileContents(options.InputFiles().front(),
2020 "package p; interface IFoo {"
2021 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002022 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09002023 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002024 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2025}
Jiyong Park309668e2018-07-28 16:55:44 +09002026
Devin Moore097a3ab2020-03-11 16:08:44 -07002027TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2028 // boolean getInterfaceVersion() is not a meta transaction, but should be
2029 // prevented because return type is not part of a method signature
2030 const string expected_stderr =
2031 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2032 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002033 io_delegate_.SetFileContents(options.InputFiles().front(),
2034 "package p; interface IFoo {"
2035 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002036 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09002037 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002038 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2039}
Jiyong Park309668e2018-07-28 16:55:44 +09002040
Devin Moore097a3ab2020-03-11 16:08:44 -07002041TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002042 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002043 const string expected_stderr =
2044 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2045 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002046 io_delegate_.SetFileContents(options.InputFiles().front(),
2047 "package p; interface IFoo {"
2048 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002049 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09002050 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002051 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002052
2053 // this is not a meta interface method as it differs type arguments
2054 io_delegate_.SetFileContents(options.InputFiles().front(),
2055 "package p; interface IFoo {"
2056 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002057 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002058}
2059
Jooyung Hanb8a97772021-01-19 01:27:38 +09002060TEST_F(AidlTest, CheckApiForEquality) {
2061 CaptureStderr();
2062 Options options = Options::From("aidl --checkapi=equal old new");
2063
2064 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2065 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2066 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2067 "package p; interface IFoo{ @utf8InCpp String foo();}");
2068
2069 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2070 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2071}
2072
Daniel Norman85aed542019-08-21 12:01:14 -07002073TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002074 Options options = Options::From("aidl --checkapi old new");
2075 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2076 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2077 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2078 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2079
2080 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2081}
2082
Jiyong Park3656c3c2018-08-01 20:02:01 +09002083TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002084 Options options = Options::From("aidl --checkapi old new");
2085 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2086 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002087
2088 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2089}
2090
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002091TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2092 Options options = Options::From("aidl --checkapi old new");
2093 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2094 const string enum_definition = "package p; enum Enum { FOO }";
2095 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2096 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2097 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2098 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2099
2100 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2101}
2102
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002103TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2104 Options options = Options::From("aidl --checkapi old new -I import");
2105
2106 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2107 io_delegate_.SetFileContents("new/p/Foo.aidl",
2108 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2109 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2110
2111 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2112}
2113
Jooyung Han02a11be2021-02-11 13:18:06 +09002114TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2115 Options options = Options::From("aidl --checkapi=equal old new");
2116 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2117 const string enum_definition = "package p; enum Enum { FOO }";
2118 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2119 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2120 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2121 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2122 CaptureStderr();
2123 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2124 EXPECT_EQ("", GetCapturedStderr());
2125}
2126
Daniel Norman85aed542019-08-21 12:01:14 -07002127class AidlTestCompatibleChanges : public AidlTest {
2128 protected:
2129 Options options_ = Options::From("aidl --checkapi old new");
2130};
2131
2132TEST_F(AidlTestCompatibleChanges, NewType) {
2133 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2134 "package p;"
2135 "interface IFoo {"
2136 " void foo(int a);"
2137 "}");
2138 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2139 "package p;"
2140 "interface IFoo {"
2141 " void foo(int a);"
2142 "}");
2143 io_delegate_.SetFileContents("new/p/IBar.aidl",
2144 "package p;"
2145 "interface IBar {"
2146 " void bar();"
2147 "}");
2148 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2149}
2150
2151TEST_F(AidlTestCompatibleChanges, NewMethod) {
2152 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2153 "package p;"
2154 "interface IFoo {"
2155 " void foo(int a);"
2156 "}");
2157 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2158 "package p;"
2159 "interface IFoo {"
2160 " void foo(int a);"
2161 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002162 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002163 "}");
2164 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2165}
2166
2167TEST_F(AidlTestCompatibleChanges, NewField) {
2168 io_delegate_.SetFileContents("old/p/Data.aidl",
2169 "package p;"
2170 "parcelable Data {"
2171 " int foo;"
2172 "}");
2173 io_delegate_.SetFileContents("new/p/Data.aidl",
2174 "package p;"
2175 "parcelable Data {"
2176 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002177 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002178 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002179 "}");
2180 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2181}
2182
Jooyung Han05bd8a82021-04-28 23:56:38 +09002183TEST_F(AidlTestCompatibleChanges, NewField2) {
2184 io_delegate_.SetFileContents("old/p/Data.aidl",
2185 "package p;"
2186 "parcelable Data {"
2187 "}");
2188 io_delegate_.SetFileContents("new/p/Data.aidl",
2189 "package p;"
2190 "parcelable Data {"
2191 " int foo = 0;"
2192 "}");
2193 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2194}
2195
Daniel Norman85aed542019-08-21 12:01:14 -07002196TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2197 io_delegate_.SetFileContents("old/p/Enum.aidl",
2198 "package p;"
2199 "enum Enum {"
2200 " FOO = 1,"
2201 "}");
2202 io_delegate_.SetFileContents("new/p/Enum.aidl",
2203 "package p;"
2204 "enum Enum {"
2205 " FOO = 1,"
2206 " BAR = 2,"
2207 "}");
2208 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2209}
2210
2211TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2212 io_delegate_.SetFileContents("old/p/Enum.aidl",
2213 "package p;"
2214 "enum Enum {"
2215 " FOO = 1,"
2216 " BAR = 2,"
2217 "}");
2218 io_delegate_.SetFileContents("new/p/Enum.aidl",
2219 "package p;"
2220 "enum Enum {"
2221 " BAR = 2,"
2222 " FOO = 1,"
2223 "}");
2224 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2225}
2226
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002227TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2228 io_delegate_.SetFileContents("old/p/Union.aidl",
2229 "package p;"
2230 "union Union {"
2231 " String foo;"
2232 "}");
2233 io_delegate_.SetFileContents("new/p/Union.aidl",
2234 "package p;"
2235 "union Union {"
2236 " String foo;"
2237 " int num;"
2238 "}");
2239 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2240}
2241
Daniel Norman85aed542019-08-21 12:01:14 -07002242TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002243 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2244 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002245 "interface IFoo {"
2246 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002247 "}");
2248 io_delegate_.SetFileContents("old/p/Data.aidl",
2249 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002250 "parcelable Data {"
2251 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002252 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002253 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2254 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002255 "interface IFoo {"
2256 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002257 "}");
2258 io_delegate_.SetFileContents("new/p/Data.aidl",
2259 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002260 "parcelable Data {"
2261 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002262 "}");
2263 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2264 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002265 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002266 " void foo(int a);"
2267 "}");
2268 io_delegate_.SetFileContents("new/q/Data.aidl",
2269 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002270 "parcelable Data {"
2271 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002272 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002273 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2274}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002275
Daniel Norman85aed542019-08-21 12:01:14 -07002276TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2277 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2278 "package p;"
2279 "interface IFoo {"
2280 " void foo(int a);"
2281 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002282 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2283 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002284 "interface IFoo {"
2285 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002287 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2288}
Jiyong Parke59c3682018-09-11 23:10:25 +09002289
Daniel Norman85aed542019-08-21 12:01:14 -07002290TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002291 io_delegate_.SetFileContents("old/p/I.aidl",
2292 "package p; interface I {"
2293 "const int A = 1; }");
2294 io_delegate_.SetFileContents("new/p/I.aidl",
2295 "package p ; interface I {"
2296 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002297 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2298}
Jiyong Parka428d212018-08-29 22:26:30 +09002299
Daniel Norman85aed542019-08-21 12:01:14 -07002300TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002301 io_delegate_.SetFileContents("old/p/I.aidl",
2302 "package p; interface I {"
2303 "const int A = 1; const int B = 2;}");
2304 io_delegate_.SetFileContents("new/p/I.aidl",
2305 "package p ; interface I {"
2306 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002307 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002308}
2309
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002310TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2311 io_delegate_.SetFileContents("old/p/Foo.aidl",
2312 "package p;"
2313 "@JavaPassthrough(annotation=\"Alice\")"
2314 "@JavaPassthrough(annotation=\"Bob\")"
2315 "parcelable Foo {}");
2316 io_delegate_.SetFileContents("new/p/Foo.aidl",
2317 "package p;"
2318 "@JavaPassthrough(annotation=\"Bob\")"
2319 "@JavaPassthrough(annotation=\"Alice\")"
2320 "parcelable Foo {}");
2321 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2322}
2323
Jooyung Han00073272020-11-27 14:20:20 +09002324TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2325 io_delegate_.SetFileContents("old/p/Foo.aidl",
2326 "package p;"
2327 "parcelable Foo {}");
2328 io_delegate_.SetFileContents("new/p/Foo.aidl",
2329 "package p;"
2330 "@JavaPassthrough(annotation=\"@Deprecated\")"
2331 "parcelable Foo {}");
2332 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2333}
2334
Jooyung Han636fd2f2020-10-22 11:33:45 +09002335TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2336 io_delegate_.SetFileContents("old/p/Data.aidl",
2337 "package p;"
2338 "parcelable Data {"
2339 " int num;"
2340 "}");
2341 io_delegate_.SetFileContents(
2342 "new/p/Data.aidl",
2343 "package p;"
2344 "parcelable Data {"
2345 " int num;"
2346 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2347 "}");
2348 io_delegate_.SetFileContents("new/p/Enum.aidl",
2349 "package p;"
2350 "enum Enum {"
2351 " FOO = 0,"
2352 " BAR = 1,"
2353 "}");
2354 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2355}
2356
Jooyung Han308bbe02021-04-27 12:09:59 +09002357TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2358 io_delegate_.SetFileContents("old/p/Data.aidl",
2359 "package p;\n"
2360 "parcelable Data {\n"
2361 " p.Enum e;\n"
2362 "}");
2363 io_delegate_.SetFileContents("old/p/Enum.aidl",
2364 "package p;\n"
2365 "enum Enum {\n"
2366 " FOO = 0,\n"
2367 " BAR = 1,\n"
2368 "}");
2369 io_delegate_.SetFileContents("new/p/Data.aidl",
2370 "package p;\n"
2371 "parcelable Data {\n"
2372 " p.Enum e = p.Enum.FOO;\n"
2373 "}");
2374 io_delegate_.SetFileContents("new/p/Enum.aidl",
2375 "package p;\n"
2376 "enum Enum {\n"
2377 " FOO = 0,\n"
2378 " BAR = 1,\n"
2379 "}");
2380 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2381}
2382
Daniel Norman85aed542019-08-21 12:01:14 -07002383class AidlTestIncompatibleChanges : public AidlTest {
2384 protected:
2385 Options options_ = Options::From("aidl --checkapi old new");
2386};
2387
2388TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002389 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002390 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2391 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002392 "interface IFoo {"
2393 " void foo(in String[] str);"
2394 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002395 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002396 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002397 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002399}
2400
2401TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002402 const string expected_stderr =
2403 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002404 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2405 "package p;"
2406 "interface IFoo {"
2407 " void foo(in String[] str);"
2408 " void bar(@utf8InCpp String str);"
2409 "}");
2410 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2411 "package p;"
2412 "interface IFoo {"
2413 " void foo(in String[] str);"
2414 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002415 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002416 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002418}
2419
Jiyong Parkf8d53612020-05-04 14:06:13 +09002420TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2421 const string expected_stderr =
2422 "ERROR: new/p/IFoo.aidl:1.61-65: "
2423 "Encountered an untyped List or Map. The use of untyped List/Map is "
2424 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2425 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2426 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2427 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2428 "package p;"
2429 "interface IFoo {"
2430 " void foo(in String[] str);"
2431 "}");
2432 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2433 "package p;"
2434 "interface IFoo {"
2435 " void foo(in String[] str);"
2436 " void bar(in List arg);"
2437 "}");
2438 CaptureStderr();
2439 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2441}
2442
2443TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2444 const string expected_stderr =
2445 "ERROR: new/p/Data.aidl:1.54-59: "
2446 "Encountered an untyped List or Map. The use of untyped List/Map is "
2447 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2448 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2449 "ERROR: new/p/Data.aidl: Failed to read.\n";
2450 io_delegate_.SetFileContents("old/p/Data.aidl",
2451 "package p;"
2452 "parcelable Data {"
2453 " int foo;"
2454 "}");
2455 io_delegate_.SetFileContents("new/p/Data.aidl",
2456 "package p;"
2457 "parcelable Data {"
2458 " int foo;"
2459 " @nullable List list;"
2460 "}");
2461 CaptureStderr();
2462 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2463 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2464}
2465
Daniel Norman85aed542019-08-21 12:01:14 -07002466TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002467 const string expected_stderr =
2468 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002469 io_delegate_.SetFileContents("old/p/Data.aidl",
2470 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002471 "parcelable Data {"
2472 " int foo;"
2473 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002474 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002475 io_delegate_.SetFileContents("new/p/Data.aidl",
2476 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002477 "parcelable Data {"
2478 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002479 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002480 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002481 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002483}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002484
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002485TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2486 const string expected_stderr =
2487 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2488 "backends. Please either provide a default value for this field or mark the field as "
2489 "@nullable. This value or a null value will be used automatically when an old version of "
2490 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2491 "order to make sure your code continues to be backwards compatible, make sure the default or "
2492 "null value does not cause a semantic change to this parcelable.\n";
2493 io_delegate_.SetFileContents("old/p/Data.aidl",
2494 "package p;"
2495 "parcelable Data {"
2496 " int num;"
2497 "}");
2498 io_delegate_.SetFileContents("new/p/Data.aidl",
2499 "package p;"
2500 "parcelable Data {"
2501 " int num;"
2502 " String str;"
2503 "}");
2504 CaptureStderr();
2505 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2507}
2508
Jooyung Han636fd2f2020-10-22 11:33:45 +09002509TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2510 const string expected_stderr =
2511 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2512 "Please make sure 'Enum' has '0' as a valid value.\n";
2513 io_delegate_.SetFileContents("old/p/Data.aidl",
2514 "package p;"
2515 "parcelable Data {"
2516 " int num;"
2517 "}");
2518 io_delegate_.SetFileContents("new/p/Data.aidl",
2519 "package p;"
2520 "parcelable Data {"
2521 " int num;"
2522 " p.Enum e;"
2523 "}");
2524 io_delegate_.SetFileContents("new/p/Enum.aidl",
2525 "package p;"
2526 "enum Enum {"
2527 " FOO = 1,"
2528 " BAR = 2,"
2529 "}");
2530 CaptureStderr();
2531 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2533}
2534
Daniel Norman85aed542019-08-21 12:01:14 -07002535TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002536 const string expected_stderr =
2537 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002538 io_delegate_.SetFileContents("old/p/Enum.aidl",
2539 "package p;"
2540 "enum Enum {"
2541 " FOO = 1,"
2542 " BAR = 2,"
2543 "}");
2544 io_delegate_.SetFileContents("new/p/Enum.aidl",
2545 "package p;"
2546 "enum Enum {"
2547 " BAR = 2,"
2548 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002549 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002550 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002552}
2553
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002554TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2555 const string expected_stderr =
2556 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2557 io_delegate_.SetFileContents("old/p/Union.aidl",
2558 "package p;"
2559 "union Union {"
2560 " String str;"
2561 " int num;"
2562 "}");
2563 io_delegate_.SetFileContents("new/p/Union.aidl",
2564 "package p;"
2565 "union Union {"
2566 " String str;"
2567 "}");
2568 CaptureStderr();
2569 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2570 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2571}
2572
Daniel Norman85aed542019-08-21 12:01:14 -07002573TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002574 const string expected_stderr =
2575 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002576 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2577 "package p;"
2578 "interface IFoo {"
2579 " void foo(in String[] str);"
2580 " void bar(@utf8InCpp String str);"
2581 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002582 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2583 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002584 "interface IFoo {"
2585 " void foo(in String[] str);"
2586 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002587 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002588 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002589 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002591}
2592
Daniel Norman85aed542019-08-21 12:01:14 -07002593TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002594 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002595 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2596 "package p;"
2597 "interface IFoo {"
2598 " void foo(in String[] str);"
2599 " void bar(@utf8InCpp String str);"
2600 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002601 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2602 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002603 "interface IFoo2 {"
2604 " void foo(in String[] str);"
2605 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002606 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002607 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002608 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002609 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002610}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002611
Daniel Norman85aed542019-08-21 12:01:14 -07002612TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002613 const string expected_stderr =
2614 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002615 io_delegate_.SetFileContents("old/p/Enum.aidl",
2616 "package p;"
2617 "enum Enum {"
2618 " FOO = 1,"
2619 " BAR = 2,"
2620 "}");
2621 io_delegate_.SetFileContents("new/p/Enum.aidl",
2622 "package p;"
2623 "enum Enum {"
2624 " FOO = 3,"
2625 " BAR = 2,"
2626 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002627 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002628 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002629 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002630}
2631
2632TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002633 const string expected_stderr =
2634 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2635 "from 0 to 1.\n"
2636 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2637 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002638 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2639 "package p;"
2640 "interface IFoo {"
2641 " void foo(in String[] str);"
2642 " void bar(@utf8InCpp String str);"
2643 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002644 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2645 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002646 "interface IFoo {"
2647 " void bar(@utf8InCpp String str);"
2648 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002649 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002650 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002651 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002652 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002653}
2654
2655TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002656 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002657 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2658 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002659 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002660 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002661 "parcelable Data {"
2662 " int foo;"
2663 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002664 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002665 io_delegate_.SetFileContents("new/p/Data.aidl",
2666 "package p;"
2667 "parcelable Data {"
2668 " int bar;"
2669 " int foo;"
2670 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002671 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002672 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002673 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002674}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002675
Daniel Norman85aed542019-08-21 12:01:14 -07002676TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002677 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002678 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002679 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002680 "interface IFoo {"
2681 " void foo(in String[] str);"
2682 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002683 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002684 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2685 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002686 "interface IFoo {"
2687 " void foo(out String[] str);"
2688 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002689 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002690 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002691 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002692 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002693}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002694
Daniel Norman85aed542019-08-21 12:01:14 -07002695TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002696 const string expected_stderr =
2697 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002698 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2699 "package p;"
2700 "interface IFoo {"
2701 " void foo(in String[] str);"
2702 " void bar(@utf8InCpp String str);"
2703 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002704 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2705 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002706 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002707 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002708 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002709 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002710 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002711 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002712 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002713}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002714
Daniel Norman85aed542019-08-21 12:01:14 -07002715TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002716 const string expected_stderr =
2717 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002718 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2719 "package p;"
2720 "interface IFoo {"
2721 " void foo(in String[] str);"
2722 " void bar(@utf8InCpp String str);"
2723 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002724 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2725 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002726 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002727 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002728 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002729 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002730 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002731 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002732 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002733}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002734
Jooyung Han60b2fde2020-10-29 15:12:40 +09002735TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2736 const string expected_stderr =
2737 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2738 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2739 io_delegate_.SetFileContents("old/p/Foo.aidl",
2740 "package p;"
2741 "@Backing(type=\"byte\")"
2742 "enum Foo {"
2743 " FOO, BAR,"
2744 "}");
2745 io_delegate_.SetFileContents("new/p/Foo.aidl",
2746 "package p;"
2747 "@Backing(type=\"long\")"
2748 "enum Foo {"
2749 " FOO, BAR,"
2750 "}");
2751 CaptureStderr();
2752 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2753 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2754}
2755
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002756TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2757 const string expected_stderr =
2758 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2759 "to @JavaPassthrough(annotation=\"Bob\")\n";
2760 io_delegate_.SetFileContents("old/p/Foo.aidl",
2761 "package p;"
2762 "@JavaPassthrough(annotation=\"Alice\")"
2763 "parcelable Foo {}");
2764 io_delegate_.SetFileContents("new/p/Foo.aidl",
2765 "package p;"
2766 "@JavaPassthrough(annotation=\"Bob\")"
2767 "parcelable Foo {}");
2768
2769 CaptureStderr();
2770 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2771 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2772}
2773
Devin Mooredb7ac512020-08-07 11:17:36 -07002774TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2775 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002776 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002777 io_delegate_.SetFileContents("old/p/Foo.aidl",
2778 "package p;"
2779 "parcelable Foo {"
2780 " int A;"
2781 "}");
2782 io_delegate_.SetFileContents("new/p/Foo.aidl",
2783 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002784 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002785 " int A;"
2786 "}");
2787 CaptureStderr();
2788 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2789 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2790}
2791
2792TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2793 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002794 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002795 io_delegate_.SetFileContents("old/p/Foo.aidl",
2796 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002797 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002798 " int A;"
2799 "}");
2800 io_delegate_.SetFileContents("new/p/Foo.aidl",
2801 "package p;"
2802 "parcelable Foo {"
2803 " int A;"
2804 "}");
2805 CaptureStderr();
2806 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2807 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2808}
2809
Daniel Norman85aed542019-08-21 12:01:14 -07002810TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002811 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002812 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2813 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002814 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002815 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002816 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002817 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002818}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002819
Daniel Norman85aed542019-08-21 12:01:14 -07002820TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002821 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002822 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2823 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002824 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002825 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002826 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002827}
Jiyong Parka428d212018-08-29 22:26:30 +09002828
Daniel Norman85aed542019-08-21 12:01:14 -07002829TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002830 const string expected_stderr =
2831 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002832 io_delegate_.SetFileContents("old/p/I.aidl",
2833 "package p; interface I {"
2834 "const int A = 1; const int B = 2;}");
2835 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002836 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002837 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002838 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002839}
Jiyong Parka428d212018-08-29 22:26:30 +09002840
Daniel Norman85aed542019-08-21 12:01:14 -07002841TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002842 const string expected_stderr =
2843 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002844 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2845 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002846 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002847 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002848 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002849}
2850
Devin Moorec7e47a32020-08-07 10:55:25 -07002851TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2852 const string expected_stderr =
2853 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2854 "This is an incompatible change for FixedSize types.\n";
2855 io_delegate_.SetFileContents("old/p/Foo.aidl",
2856 "package p; @FixedSize parcelable Foo { int A = 1; }");
2857 io_delegate_.SetFileContents("new/p/Foo.aidl",
2858 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2859 CaptureStderr();
2860 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2861 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2862}
2863
Jeongik Cha68d18e72021-04-29 20:07:01 +09002864TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
2865 const string expected_stderr =
2866 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
2867 "android.net.UidRangeParcel is changed from 1 to 2. "
2868 "But it is forbidden because of legacy support.\n";
2869 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
2870 "package android.net; parcelable UidRangeParcel { int A = 1; }");
2871 io_delegate_.SetFileContents(
2872 "new/android/net/UidRangeParcel.aidl",
2873 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
2874 CaptureStderr();
2875 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2876 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2877}
2878
Devin Moorec7e47a32020-08-07 10:55:25 -07002879TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2880 const string expected_stderr =
2881 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2882 io_delegate_.SetFileContents("old/p/Foo.aidl",
2883 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2884 io_delegate_.SetFileContents("new/p/Foo.aidl",
2885 "package p; @FixedSize parcelable Foo { int A = 1; }");
2886 CaptureStderr();
2887 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2888 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2889}
2890
2891TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2892 const string expected_stderr =
2893 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2894 "a.\n"
2895 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2896 "b.\n"
2897 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2898 "c.\n"
2899 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2900 "d.\n"
2901 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2902 "e.\n"
2903 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2904 "f.\n";
2905
2906 io_delegate_.SetFileContents("Foo.aidl",
2907 "@FixedSize parcelable Foo { "
2908 " int[] a;"
2909 " Bar b;"
2910 " String c;"
2911 " ParcelFileDescriptor d;"
2912 " IBinder e;"
2913 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002914 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002915 "}");
2916 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002917 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002918
2919 CaptureStderr();
2920 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2921 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2922}
2923
2924TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2925 const string expected_stderr = "";
2926
2927 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2928 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2929 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002930 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07002931
2932 CaptureStderr();
2933 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2934 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2935}
2936
Jiyong Park8c380532018-08-30 14:55:26 +09002937TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002938 const string expected_stderr =
2939 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2940 "dir1/q/IBar.aidl\n"
2941 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002942 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002943 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2944 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2945 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2946 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2947
Devin Moore097a3ab2020-03-11 16:08:44 -07002948 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002949 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002950 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002951}
2952
Jiyong Parked65bf42018-08-28 15:43:27 +09002953TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002954 const string expected_stderr =
2955 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2956 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002957 Options options = Options::From("aidl --checkapi old new");
2958 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2959 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002960
2961 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2962
Jiyong Parke59c3682018-09-11 23:10:25 +09002963 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002964 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002965 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002967}
2968
Jooyung Han652ce482021-02-26 12:40:35 +09002969TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2970 Options options =
2971 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002972
2973 // use without import
2974 io_delegate_.SetFileContents("p/IFoo.aidl",
2975 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002976 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2977
2978 // capture output files
2979 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09002980
Devin Moore7b8d5c92020-03-17 14:14:08 -07002981 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002982 io_delegate_.SetFileContents(
2983 "p/IFoo.aidl",
2984 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Jooyung Han652ce482021-02-26 12:40:35 +09002985 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2986 // output files should be the same
2987 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002988
2989 // use with import (as before)
2990 io_delegate_.SetFileContents("p/IFoo.aidl",
2991 "package p;"
2992 "import android.os.ParcelFileDescriptor;"
2993 "interface IFoo{"
2994 " void foo(in ParcelFileDescriptor fd);"
2995 "}");
Jooyung Han652ce482021-02-26 12:40:35 +09002996 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2997 // output files should be the same
2998 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09002999}
Jiyong Parked65bf42018-08-28 15:43:27 +09003000
Jooyung Han020d8d12021-02-26 17:23:02 +09003001TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3002 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3003 CaptureStderr();
3004 io_delegate_.SetFileContents("p/IFoo.aidl",
3005 "package p;"
3006 "interface IFoo{"
3007 " void foo(out ParcelFileDescriptor fd);"
3008 "}");
3009 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3010 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3011}
3012
3013TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3014 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3015 CaptureStderr();
3016 io_delegate_.SetFileContents("p/IFoo.aidl",
3017 "package p;"
3018 "interface IFoo{"
3019 " void foo(ParcelFileDescriptor fd);"
3020 "}");
3021 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3022 EXPECT_THAT(GetCapturedStderr(),
3023 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3024}
3025
Jiyong Park3633b722019-04-11 15:38:26 +09003026TEST_F(AidlTest, ManualIds) {
3027 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3028 io_delegate_.SetFileContents("IFoo.aidl",
3029 "interface IFoo {\n"
3030 " void foo() = 0;\n"
3031 " void bar() = 1;\n"
3032 "}");
3033 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3034}
3035
3036TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3037 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3038 io_delegate_.SetFileContents("IFoo.aidl",
3039 "interface IFoo {\n"
3040 " void foo() = 0;\n"
3041 " void bar() = 1;\n"
3042 "}");
3043 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3044}
3045
3046TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003047 const string expected_stderr =
3048 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003049 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3050 io_delegate_.SetFileContents("IFoo.aidl",
3051 "interface IFoo {\n"
3052 " void foo() = 3;\n"
3053 " void bar() = 3;\n"
3054 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003055 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003056 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003057 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003058}
3059
3060TEST_F(AidlTest, FailOnOutOfRangeIds) {
3061 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003062 const string expected_stderr =
3063 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3064 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003065 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3066 io_delegate_.SetFileContents("IFoo.aidl",
3067 "interface IFoo {\n"
3068 " void foo() = 3;\n"
3069 " void bar() = 16777115;\n"
3070 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003071 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003072 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003073 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003074}
3075
3076TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003077 const string expected_stderr =
3078 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003079 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3080 io_delegate_.SetFileContents("IFoo.aidl",
3081 "interface IFoo {\n"
3082 " void foo() = 3;\n"
3083 " void bar();\n"
3084 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003085 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09003086 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003087 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003088}
3089
Jiyong Parkc6816252019-07-08 08:12:28 +09003090TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3091 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3092 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3093 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
3094 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3095}
3096
3097TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003098 const string expected_stderr =
3099 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3100 "dir/IBar.aidl\n"
3101 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003102 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003103
Jiyong Parkc6816252019-07-08 08:12:28 +09003104 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3105 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3106 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3107 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003108 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09003109 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003111}
3112
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003113TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3114 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3115 "package a.b;\n"
3116 "import a.b.IBar;\n"
3117 "import a.b.IQux;\n"
3118 "interface IFoo { IQux foo(); }\n");
3119 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3120 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3121
3122 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
3123 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3124
3125 string output;
3126 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3127 // IBar was imported but wasn't used. include is not expected.
3128 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3129 // IBar was imported and used. include is expected.
3130 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3131}
3132
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003133TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003134 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003135 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003136 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3137 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003138 interface IFoo {
3139 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003140 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003141 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003142 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003143 // JavaPassthrough should work with other types as well (e.g. enum)
3144 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3145 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3146 @JavaPassthrough(annotation="@com.android.AliceTwo")
3147 @Backing(type="byte")
3148 enum MyEnum {
3149 a, b, c
3150 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003151
Jooyung Han4cde01d2020-10-13 11:10:47 +09003152 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003153 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3154
3155 string java_out;
3156 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003157 // type-decl-level annotations with newline at the end
3158 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3159 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3160 // member-decl-level annotations with newline at the end
3161 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3162 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3163 // inline annotations with space at the end
3164 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003165
Jooyung Han4cde01d2020-10-13 11:10:47 +09003166 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3167 // type-decl-level annotations with newline at the end
3168 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3169 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3170
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003171 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003172 Options cpp_options =
3173 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003174 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3175
Jooyung Han4cde01d2020-10-13 11:10:47 +09003176 Options ndk_options =
3177 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003178 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003179
Jooyung Han4cde01d2020-10-13 11:10:47 +09003180 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07003181 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003182}
3183
Andrei Homescue61feb52020-08-18 15:44:24 -07003184TEST_F(AidlTest, ParseRustDerive) {
3185 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3186 @RustDerive(Clone=true, Copy=false)
3187 parcelable Foo {
3188 int a;
3189 })");
3190
3191 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
3192 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
3193
3194 string rust_out;
3195 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3196 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3197
3198 // Other backends shouldn't be bothered
3199 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
3200 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
3201
3202 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
3203 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
3204
3205 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
3206 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
3207}
3208
Jiyong Park56f73d72019-06-11 12:20:28 +09003209class AidlOutputPathTest : public AidlTest {
3210 protected:
3211 void SetUp() override {
3212 AidlTest::SetUp();
3213 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3214 }
3215
3216 void Test(const Options& options, const std::string expected_output_path) {
3217 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3218 // check the existence
3219 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3220 }
3221};
3222
3223TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3224 // <out_dir> / <package_name> / <type_name>.java
3225 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3226}
3227
3228TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3229 // when output file is explicitly set, it is always respected. -o option is
3230 // ignored.
3231 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3232}
3233
3234TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3235 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3236}
3237
3238TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3239 // output is the same as the input file except for the suffix
3240 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3241}
3242
Devin Moore7b8d5c92020-03-17 14:14:08 -07003243TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003244 AidlError error;
3245 const string expected_stderr =
3246 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3247 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003248 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3249 R"(package p;
3250 interface IFoo {
3251 const int int32_max_oob = 2147483650;
3252 }
3253 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003254 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003255 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3256 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003257}
3258
Devin Moore7b8d5c92020-03-17 14:14:08 -07003259TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003260 AidlError error;
3261 const string expected_stderr =
3262 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3263 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003264 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3265 R"(package p;
3266 interface IFoo {
3267 const int int32_min_oob = -2147483650;
3268 }
3269 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003270 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3272 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003273}
3274
Devin Moore7b8d5c92020-03-17 14:14:08 -07003275TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003276 AidlError error;
3277 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003278 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003279 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003280 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3281 R"(package p;
3282 interface IFoo {
3283 const long int64_max_oob = 21474836509999999999999999;
3284 }
3285 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003286 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003287 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3288 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003289}
3290
Devin Moore7b8d5c92020-03-17 14:14:08 -07003291TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003292 AidlError error;
3293 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003294 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003295 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003296 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3297 R"(package p;
3298 interface IFoo {
3299 const long int64_min_oob = -21474836509999999999999999;
3300 }
3301 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003302 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3304 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003305}
3306
Devin Moore7b8d5c92020-03-17 14:14:08 -07003307TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003308 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003309 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003310 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003311 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3312 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003313 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3314 R"(package p;
3315 @Backing(type="byte")
3316 enum TestEnum {
3317 FOO = 127,
3318 BAR,
3319 }
3320 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003321 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003323 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003324}
3325
Devin Mooredecaf292020-04-30 09:16:40 -07003326TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3327 AidlError error;
3328 const string expected_stderr =
3329 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003330 "be one of: type\n";
3331 CaptureStderr();
3332 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3333 R"(package p;
3334 @Backing(foo="byte")
3335 enum TestEnum {
3336 FOO = 1,
3337 BAR,
3338 }
3339 )",
3340 typenames_, GetLanguage(), &error));
3341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3342 EXPECT_EQ(AidlError::BAD_TYPE, error);
3343}
3344
Jooyung Han5721a232020-12-24 04:34:55 +09003345TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3346 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3347 CaptureStderr();
3348 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3349 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3350}
3351
Jooyung Han66813932020-10-23 13:24:44 +09003352TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003353 io_delegate_.SetFileContents("Foo.aidl",
3354 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3355 "Map<String, Baz> d; Bar[] e; }");
3356 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3357 io_delegate_.SetFileContents("Baz.aidl",
3358 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003359 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3360 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3361}
3362
Jooyung Han66813932020-10-23 13:24:44 +09003363TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003364 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003365 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003366 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003367 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3368 "named 'bar'.\n";
3369 CaptureStderr();
3370 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3371 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3372 EXPECT_EQ(expected_error, GetCapturedStderr());
3373}
3374
Jooyung Han09e551c2021-05-11 11:44:48 +09003375TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3376 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3377 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3378 CaptureStderr();
3379 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3380 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3381 EXPECT_EQ("", GetCapturedStderr());
3382}
3383
Jooyung Han59af9cc2020-10-25 21:44:14 +09003384TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3385 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3386 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3387 string expected_error =
3388 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003389 "named 'bar'.\n";
3390 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003391 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3392 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003393 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003394}
3395
Jooyung Han66813932020-10-23 13:24:44 +09003396TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003397 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003398 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3399 string expected_error =
3400 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3401 "only be an in parameter.\n";
3402 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003403 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3404 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003405 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003406}
3407
Jooyung Han66813932020-10-23 13:24:44 +09003408TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003409 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003410 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3411 string expected_error =
3412 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3413 "only be an in parameter.\n";
3414 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003415 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3416 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003417 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003418}
3419
Jooyung Han66813932020-10-23 13:24:44 +09003420TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003421 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003422 Options options = Options::From("aidl --lang=java Foo.aidl");
3423 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003424 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3425 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003426 CaptureStderr();
3427 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3429}
Devin Moore53fc99c2020-08-12 08:07:52 -07003430
Jooyung Hanfe086af2021-01-16 03:44:47 +09003431TEST_P(AidlTest, UnionInUnion) {
3432 import_paths_.insert(".");
3433 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3434 CaptureStderr();
3435 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3436 EXPECT_THAT("", GetCapturedStderr());
3437}
3438
Jooyung Hanfe89f122020-10-14 03:49:18 +09003439TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3440 const string method = "package a; union Foo {}";
3441 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3442 CaptureStderr();
3443 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3444 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3445}
3446
3447TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3448 const string method = "package a; union Foo { ParcelableHolder x; }";
3449 const string expected_stderr =
3450 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3451 CaptureStderr();
3452 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3453 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3454}
3455
Jooyung Han53fb4242020-12-17 16:03:49 +09003456TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3457 import_paths_.insert(".");
3458 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3459 const string expected_err = "The union's first member should have a useful default value.";
3460 CaptureStderr();
3461 EXPECT_EQ(nullptr,
3462 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3463 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3464}
3465
Devin Moore53fc99c2020-08-12 08:07:52 -07003466TEST_P(AidlTest, GenericStructuredParcelable) {
3467 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003468 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003469 const string expected_stderr = "";
3470 CaptureStderr();
3471 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3472 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3473}
3474
Jooyung Han3f347ca2020-12-01 12:41:50 +09003475TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3476 io_delegate_.SetFileContents("Foo.aidl",
3477 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3478 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003479 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003480 const string expected_stderr = "";
3481 CaptureStderr();
3482 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3483 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3484
3485 string code;
3486 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3487 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3488const ::android::String16& Foo<T,U>::s() {
3489 static const ::android::String16 value(::android::String16(""));
3490 return value;
3491})--"));
3492}
3493
3494TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3495 io_delegate_.SetFileContents("Foo.aidl",
3496 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3497 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003498 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003499 const string expected_stderr = "";
3500 CaptureStderr();
3501 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3502 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3503
3504 string code;
3505 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3506 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3507const char* Foo<T, U>::s = "";
3508)--"));
3509}
3510
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003511TEST_F(AidlTest, NestedTypeArgs) {
3512 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003513 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3514
3515 io_delegate_.SetFileContents("a/Foo.aidl",
3516 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3517 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003518 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3519 const string expected_stderr = "";
3520 CaptureStderr();
3521 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3522 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3523
3524 string code;
3525 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003526 EXPECT_THAT(code,
3527 testing::HasSubstr(
3528 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3529}
3530
3531TEST_F(AidlTest, DoubleArrayError) {
3532 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3533
3534 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3535 const string expected_stderr =
3536 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3537 CaptureStderr();
3538 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3540}
3541
3542TEST_F(AidlTest, DoubleGenericError) {
3543 io_delegate_.SetFileContents("a/Bar.aidl",
3544 "package a; parcelable Bar { List<String><String> a; }");
3545
3546 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3547 const string expected_stderr =
3548 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3549 CaptureStderr();
3550 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3552}
3553
3554TEST_F(AidlTest, ArrayBeforeGenericError) {
3555 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3556
3557 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003558 CaptureStderr();
3559 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003560 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3561}
3562
3563TEST_F(AidlTest, NullableArraysAreNotSupported) {
3564 io_delegate_.SetFileContents("a/Bar.aidl",
3565 "package a; parcelable Bar { String @nullable [] a; }");
3566
3567 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3568 CaptureStderr();
3569 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3570 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3571}
3572
3573TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3574 io_delegate_.SetFileContents("a/Bar.aidl",
3575 "package a; parcelable Bar { List<@nullable String> a; }");
3576
3577 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3578 CaptureStderr();
3579 EXPECT_EQ(1, ::android::aidl::compile_aidl(options, io_delegate_));
3580 EXPECT_THAT(GetCapturedStderr(),
3581 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003582}
3583
Jooyung Han14004ed2020-10-16 03:49:57 +09003584struct GenericAidlTest : ::testing::Test {
3585 FakeIoDelegate io_delegate_;
3586 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003587 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003588 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3589 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3590 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3591
3592 Options options = Options::From(cmd);
3593 CaptureStderr();
3594 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3595 EXPECT_EQ("", GetCapturedStderr());
3596 }
3597};
3598
3599TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3600 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3601 string code;
3602 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3603 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3604 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3605 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3606}
3607
3608TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3609 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3610 string code;
3611 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3612 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3613 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3614 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3615}
3616
Devin Moore53fc99c2020-08-12 08:07:52 -07003617TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3618 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003619 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003620 const string expected_stderr =
3621 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3622 CaptureStderr();
3623 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3624 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3625}
3626
3627TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3628 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003629 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003630 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3631 CaptureStderr();
3632 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3633 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3634}
3635
Jooyung Han7a308842020-10-27 19:06:49 +09003636TEST_P(AidlTest, LongCommentWithinConstExpression) {
3637 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003638 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003639 CaptureStderr();
3640 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3641 EXPECT_EQ("", GetCapturedStderr());
3642}
3643
Jeongik Chaef44e622020-10-23 16:00:52 +09003644TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3645 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3646 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3647 std::string expectedErr =
3648 "ERROR: a/Foo.aidl:1.28-30: "
3649 "Encountered an untyped List or Map. The use of untyped List/Map is "
3650 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3651 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3652 "ERROR: a/Foo.aidl:1.35-37: "
3653 "Encountered an untyped List or Map. The use of untyped List/Map is "
3654 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3655 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3656 CaptureStderr();
3657 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3658 EXPECT_EQ(expectedErr, GetCapturedStderr());
3659}
3660
3661TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003662 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3663 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003664 std::string expectedErr =
3665 "ERROR: a/Foo.aidl:1.33-35: "
3666 "Encountered an untyped List or Map. The use of untyped List/Map is "
3667 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3668 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3669 "ERROR: a/Foo.aidl:1.40-42: "
3670 "Encountered an untyped List or Map. The use of untyped List/Map is "
3671 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3672 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003673 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003674 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3675 EXPECT_EQ(expectedErr, GetCapturedStderr());
3676}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003677
Jeongik Chaef44e622020-10-23 16:00:52 +09003678TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3679 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3680 io_delegate_.SetFileContents(
3681 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3682 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3683 std::string expectedErr =
3684 "ERROR: a/Foo.aidl:1.52-54: "
3685 "Encountered an untyped List or Map. The use of untyped List/Map is "
3686 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3687 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3688 "ERROR: a/Foo.aidl:1.64-66: "
3689 "Encountered an untyped List or Map. The use of untyped List/Map is "
3690 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3691 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3692 CaptureStderr();
3693 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3694 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003695}
3696
Jooyung Han690f5842020-12-04 13:02:04 +09003697TEST_F(AidlTest, EnumWithDefaults_Java) {
3698 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3699 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3700package p;
3701import p.Enum;
3702parcelable Foo {
3703 Enum e = Enum.BAR;
3704})");
3705 CaptureStderr();
3706 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3707 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3708 auto err = GetCapturedStderr();
3709 EXPECT_EQ("", err);
3710
3711 string code;
3712 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003713 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003714}
3715
3716TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3717 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3718 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3719package p;
3720import p.Enum;
3721parcelable Foo {
3722 Enum e = Enum.BAR;
3723})");
3724 CaptureStderr();
3725 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3726 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3727 auto err = GetCapturedStderr();
3728 EXPECT_EQ("", err);
3729
3730 string code;
3731 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3732 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3733}
3734
3735TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3736 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3737 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3738package p;
3739import p.Enum;
3740parcelable Foo {
3741 Enum e = Enum.BAR;
3742})");
3743 CaptureStderr();
3744 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3745 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3746 auto err = GetCapturedStderr();
3747 EXPECT_EQ("", err);
3748
3749 string code;
3750 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3751 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3752}
3753
3754TEST_F(AidlTest, EnumWithDefaults_Rust) {
3755 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3756 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3757package p;
3758import p.Enum;
3759parcelable Foo {
3760 int n = 42;
3761 Enum e = Enum.BAR;
3762})");
3763 CaptureStderr();
3764 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
3765 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3766 auto err = GetCapturedStderr();
3767 EXPECT_EQ("", err);
3768
3769 string code;
3770 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3771 EXPECT_THAT(code, testing::HasSubstr(R"(
3772 fn default() -> Self {
3773 Self {
3774 n: 42,
3775 e: crate::mangled::_1_p_4_Enum::BAR,
3776 }
3777 })"));
3778}
3779
3780TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3781 import_paths_.insert("a");
3782 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3783 CaptureStderr();
3784 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3785package p;
3786import p.Enum;
3787parcelable Foo {
3788 int e = Enum.FOO | Enum.BAR;
3789})",
3790 typenames_, GetLanguage());
3791 auto err = GetCapturedStderr();
3792 EXPECT_EQ("", err);
3793 EXPECT_TRUE(type);
3794 const auto& fields = type->AsStructuredParcelable()->GetFields();
3795 EXPECT_EQ("int e = 3", fields[0]->ToString());
3796}
3797
3798TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3799 CaptureStderr();
3800 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3801@Backing(type="int")
3802enum Foo {
3803 STANDARD_SHIFT = 16,
3804 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3805 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3806}
3807)",
3808 typenames_, GetLanguage());
3809 auto err = GetCapturedStderr();
3810 EXPECT_EQ("", err);
3811 EXPECT_TRUE(type);
3812 const auto& enum_type = type->AsEnumDeclaration();
3813 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003814 auto writer = CodeWriter::ForString(&code);
3815 DumpVisitor visitor(*writer);
3816 visitor.Visit(*enum_type);
3817 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003818 EXPECT_EQ(R"--(@Backing(type="int")
3819enum Foo {
3820 STANDARD_SHIFT = 16,
3821 STANDARD_BT709 = 65536,
3822 STANDARD_BT601_625 = 131072,
3823}
3824)--",
3825 code);
3826}
3827
3828TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3829 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3830 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3831package p;
3832import p.Enum;
3833parcelable Foo {
3834 Enum e = Enum.FOO | Enum.BAR;
3835})");
3836 CaptureStderr();
3837 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3838 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3839 auto err = GetCapturedStderr();
3840 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3841 err);
3842}
3843
Jooyung Han361cd102021-05-24 11:30:10 +09003844TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
3845 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3846 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3847package p;
3848import p.Enum;
3849parcelable Foo {
3850 Enum e = 1;
3851})");
3852 CaptureStderr();
3853 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
3854 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3855 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
3856}
3857
Jooyung Han690f5842020-12-04 13:02:04 +09003858TEST_P(AidlTest, DefaultWithEmptyArray) {
3859 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
3860 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
3861 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003862 auto options =
3863 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003864 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3865 auto err = GetCapturedStderr();
3866 EXPECT_EQ("", err);
3867}
3868
3869TEST_P(AidlTest, RejectRefsInAnnotation) {
3870 io_delegate_.SetFileContents("a/p/IFoo.aidl",
3871 "package p; interface IFoo {\n"
3872 " const String ANNOTATION = \"@Annotation\";\n"
3873 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
3874 "}");
3875 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09003876 auto options =
3877 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Jooyung Han690f5842020-12-04 13:02:04 +09003878 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3879 auto err = GetCapturedStderr();
3880 EXPECT_EQ(
3881 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
3882 "ANNOTATION.\n",
3883 err);
3884}
3885
3886TEST_F(AidlTest, DefaultWithEnumValues) {
3887 io_delegate_.SetFileContents(
3888 "a/p/Foo.aidl",
3889 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
3890 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
3891 CaptureStderr();
3892 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3893 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3894 auto err = GetCapturedStderr();
3895 EXPECT_EQ("", err);
3896 string code;
3897 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3898 EXPECT_THAT(
3899 code, testing::HasSubstr(
3900 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
3901}
3902
Jooyung Han14259392020-12-07 10:00:08 +09003903TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
3904 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
3905 CaptureStderr();
3906 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3907 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3908 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09003909 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09003910}
3911
3912TEST_F(AidlTest, RejectsCircularReferencingConsts) {
3913 io_delegate_.SetFileContents("a/p/Foo.aidl",
3914 "package p; parcelable Foo { const int A = A + 1; }");
3915 CaptureStderr();
3916 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3917 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3918 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09003919 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
3920}
3921
3922TEST_F(AidlTest, RecursiveReferences) {
3923 io_delegate_.SetFileContents("a/p/Foo.aidl",
3924 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
3925 io_delegate_.SetFileContents("a/p/Bar.aidl",
3926 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
3927 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
3928 CaptureStderr();
3929 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
3930 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3931 EXPECT_EQ("", GetCapturedStderr());
3932}
3933
Jooyung Hanb9d60e02021-05-21 07:54:17 +09003934TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
3935 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
3936 auto options =
3937 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
3938 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
3939 CaptureStderr();
3940 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3941 EXPECT_EQ(err, GetCapturedStderr());
3942}
3943
3944TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
3945 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
3946 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
3947 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
3948 auto options =
3949 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
3950 CaptureStderr();
3951 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3952 EXPECT_EQ("", GetCapturedStderr());
3953}
3954
Jooyung Hane9f5b272021-01-07 00:18:11 +09003955TEST_P(AidlTest, UnknownConstReference) {
3956 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
3957 auto options =
3958 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
3959 const string err =
3960 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
3961 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
3962 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
3963 CaptureStderr();
3964 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
3965 EXPECT_EQ(err, GetCapturedStderr());
3966}
3967
Jooyung Han29813842020-12-08 01:28:03 +09003968TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
3969 string contents = R"(
3970import android.os.IBinder;
3971import android.os.IInterface;
3972interface IFoo {}
3973 )";
3974 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09003975}
3976
Jooyung Han888c5bc2020-12-22 17:28:47 +09003977TEST_P(AidlTest, WarningInterfaceName) {
3978 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003979 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003980 " -Weverything -o out -h out p/Foo.aidl");
3981 CaptureStderr();
3982 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003983 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09003984 GetCapturedStderr());
3985}
3986
3987TEST_P(AidlTest, ErrorInterfaceName) {
3988 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003989 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09003990 " -Weverything -Werror -o out -h out p/Foo.aidl");
3991 CaptureStderr();
3992 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09003993 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09003994 GetCapturedStderr());
3995}
3996
Jiyong Park9f4c3822021-04-07 20:36:45 +09003997TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
3998 const std::string input_file = "base/p/q/IFoo.aidl";
3999 const std::string header_dir = "out/";
4000 const std::string output_file = "out/base/p/q/IFoo.cpp";
4001 const std::string package = "p.q"; // not base.p.q
4002 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4003
4004 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4005 CaptureStderr();
4006 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4007 EXPECT_THAT(
4008 GetCapturedStderr(),
4009 testing::StartsWith(
4010 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4011 "but is out/base/p/q/IFoo.cpp."));
4012}
4013
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004014TEST_F(AidlTest, FormatCommentsForJava) {
4015 using android::aidl::FormatCommentsForJava;
4016
4017 struct TestCase {
4018 vector<Comment> comments;
4019 string formatted;
4020 };
4021 vector<TestCase> testcases = {
4022 {{}, ""},
4023 {{{"// line comments\n"}}, "// line comments\n"},
4024 {{{"// @hide \n"}}, "// @hide \n"},
4025 // Transform the last block comment as Javadoc.
4026 {{{"/*\n"
4027 " * Hello, world!\n"
4028 " */"}},
4029 "/**\n"
4030 " * Hello, world!\n"
4031 " */"},
4032 {{{"/* @hide */"}}, "/** @hide */"},
4033 {{{"/**\n"
4034 " @param foo ...\n"
4035 "*/"}},
4036 "/**\n"
4037 " @param foo ...\n"
4038 "*/"},
4039 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4040 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4041 "/* @deprecated first *//** @deprecated second */"},
4042 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4043 // Line comments are printed as they are
4044 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4045 };
4046 for (const auto& [input, formatted] : testcases) {
4047 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4048 }
4049}
4050
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004051TEST_F(AidlTest, HideIsNotForArgs) {
4052 io_delegate_.SetFileContents("IFoo.aidl",
4053 "interface IFoo {\n"
4054 " void foo(in @Hide int x);\n"
4055 "}");
4056 auto options = Options::From("aidl --lang=java IFoo.aidl");
4057 CaptureStderr();
4058 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4059 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4060}
4061
4062TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4063 io_delegate_.SetFileContents(
4064 "IFoo.aidl",
4065 "interface IFoo {\n"
4066 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4067 "}");
4068 auto options = Options::From("aidl --lang=java IFoo.aidl");
4069 CaptureStderr();
4070 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4071 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4072}
4073
Jooyung Hanfd3be322020-12-13 09:11:06 +09004074struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004075 string kind;
4076 string literal;
4077};
4078
Jooyung Hanfd3be322020-12-13 09:11:06 +09004079const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004080 {"primitive", "int"}, {"primitiveArray", "int[]"},
4081 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004082 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4083 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4084 {"union", "a.Union"}, {"interface", "a.IBar"},
4085};
4086
4087const std::map<std::string, std::string> kListSupportExpectations = {
4088 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4089 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4090 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4091 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004092 {"cpp_primitiveArray", "List of arrays is not supported."},
4093 {"java_primitiveArray", "List of arrays is not supported."},
4094 {"ndk_primitiveArray", "List of arrays is not supported."},
4095 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004096 {"cpp_String", ""},
4097 {"java_String", ""},
4098 {"ndk_String", ""},
4099 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004100 {"cpp_StringArray", "List of arrays is not supported."},
4101 {"java_StringArray", "List of arrays is not supported."},
4102 {"ndk_StringArray", "List of arrays is not supported."},
4103 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004104 {"cpp_IBinder", ""},
4105 {"java_IBinder", ""},
4106 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4107 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004108 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004109 {"java_ParcelFileDescriptor", ""},
4110 {"ndk_ParcelFileDescriptor", ""},
4111 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004112 {"cpp_interface", "List<a.IBar> is not supported."},
4113 {"java_interface", "List<a.IBar> is not supported."},
4114 {"ndk_interface", "List<a.IBar> is not supported."},
4115 {"rust_interface", "List<a.IBar> is not supported."},
4116 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004117 {"java_parcelable", ""},
4118 {"ndk_parcelable", ""},
4119 {"rust_parcelable", ""},
4120 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4121 {"java_enum", "A generic type cannot have any primitive type parameters."},
4122 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4123 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004124 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004125 {"java_union", ""},
4126 {"ndk_union", ""},
4127 {"rust_union", ""},
4128};
4129
Jooyung Hand236e552020-12-13 09:21:27 +09004130const std::map<std::string, std::string> kArraySupportExpectations = {
4131 {"cpp_primitive", ""},
4132 {"java_primitive", ""},
4133 {"ndk_primitive", ""},
4134 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004135 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4136 {"java_primitiveArray", "Can only have one dimensional arrays."},
4137 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4138 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004139 {"cpp_String", ""},
4140 {"java_String", ""},
4141 {"ndk_String", ""},
4142 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004143 {"cpp_StringArray", "Can only have one dimensional arrays."},
4144 {"java_StringArray", "Can only have one dimensional arrays."},
4145 {"ndk_StringArray", "Can only have one dimensional arrays."},
4146 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004147 {"cpp_IBinder", ""},
4148 {"java_IBinder", ""},
4149 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4150 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4151 {"cpp_ParcelFileDescriptor", ""},
4152 {"java_ParcelFileDescriptor", ""},
4153 {"ndk_ParcelFileDescriptor", ""},
4154 {"rust_ParcelFileDescriptor", ""},
4155 {"cpp_interface", "Binder type cannot be an array"},
4156 {"java_interface", "Binder type cannot be an array"},
4157 {"ndk_interface", "Binder type cannot be an array"},
4158 {"rust_interface", "Binder type cannot be an array"},
4159 {"cpp_parcelable", ""},
4160 {"java_parcelable", ""},
4161 {"ndk_parcelable", ""},
4162 {"rust_parcelable", ""},
4163 {"cpp_enum", ""},
4164 {"java_enum", ""},
4165 {"ndk_enum", ""},
4166 {"rust_enum", ""},
4167 {"cpp_union", ""},
4168 {"java_union", ""},
4169 {"ndk_union", ""},
4170 {"rust_union", ""},
4171};
4172
Jooyung Hanfd3be322020-12-13 09:11:06 +09004173class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004174 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004175 void Run(const std::string& generic_type_decl,
4176 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004177 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004178 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004179 const auto& kind = std::get<1>(param).kind;
4180
4181 FakeIoDelegate io;
4182 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4183 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4184 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004185 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4186 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004187
4188 const auto options =
4189 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4190 CaptureStderr();
4191 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004192 auto it = expectations.find(lang + "_" + kind);
4193 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004194 const string err = GetCapturedStderr();
4195 if (it->second.empty()) {
4196 EXPECT_EQ("", err);
4197 } else {
4198 EXPECT_THAT(err, testing::HasSubstr(it->second));
4199 }
4200 }
4201};
4202
4203INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004204 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004205 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4206 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004207 testing::ValuesIn(kTypeParams)),
4208 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004209 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004210 });
4211
Jooyung Hanfd3be322020-12-13 09:11:06 +09004212TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4213 Run("List<{}>", kListSupportExpectations);
4214}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004215
Jooyung Hand236e552020-12-13 09:21:27 +09004216TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4217 Run("{}[]", kArraySupportExpectations);
4218}
4219
Christopher Wiley90be4e32015-10-20 14:55:25 -07004220} // namespace aidl
4221} // namespace android