blob: cfa5d4a7a59e3c77c7244e4607bd24b4e6ffefef [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090038#include "parser.h"
39#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070040#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041
42using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080043using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090044using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070046using std::string;
47using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080048using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090049using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070050using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090051using testing::internal::CaptureStderr;
52using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070053
54namespace android {
55namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070056namespace {
57
58const char kExpectedDepFileContents[] =
59R"(place/for/output/p/IFoo.java : \
60 p/IFoo.aidl
61
62p/IFoo.aidl :
63)";
64
Dan Willemsen93298ee2016-11-10 23:55:55 -080065const char kExpectedNinjaDepFileContents[] =
66R"(place/for/output/p/IFoo.java : \
67 p/IFoo.aidl
68)";
69
Jiyong Parkdf202122019-09-30 20:48:35 +090070const char kExpectedParcelableDeclarationDepFileContents[] =
71 R"( : \
72 p/Foo.aidl
73
74p/Foo.aidl :
75)";
76
77const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080078 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070079 p/Foo.aidl
80
81p/Foo.aidl :
82)";
83
Christopher Wileyf8136192016-04-12 14:19:35 -070084} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070085
Devin Moore7b8d5c92020-03-17 14:14:08 -070086class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070087 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090088 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
89 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070090 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070091 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090092 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070093 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090094 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070095 for (const string& s : additional_arguments) {
96 args.emplace_back(s);
97 }
98 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--preprocessed=" + f);
100 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700101 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900102 args.emplace_back("--include=" + i);
103 }
104 args.emplace_back(path);
105 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900106 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900107 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900109 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900110
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700111 if (error != nullptr) {
112 *error = actual_error;
113 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900114
115 if (actual_error != AidlError::OK) {
116 return nullptr;
117 }
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900120 EXPECT_EQ(1ul, defined_types.size());
121
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900122 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700123 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124
Devin Moore7b8d5c92020-03-17 14:14:08 -0700125 Options::Language GetLanguage() { return GetParam(); }
126
Christopher Wiley0522cd52015-10-28 15:39:44 -0700127 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800128 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900129 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900130 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700131};
132
Devin Moore7b8d5c92020-03-17 14:14:08 -0700133// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
134// tests with each of the supported languages as a parameter.
135INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
136 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700137 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700138 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900139 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 });
141
142TEST_P(AidlTest, AcceptMissingPackage) {
143 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700144}
145
Devin Moore7b8d5c92020-03-17 14:14:08 -0700146TEST_P(AidlTest, EndsInSingleLineComment) {
147 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700148}
149
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000150TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
151 const string expected_stderr =
152 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
153 const std::string file_contents = "package a; interface IBar {}";
154 CaptureStderr();
155 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
156 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
157}
158
159TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
160 const string expected_stderr =
161 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
162 const std::string file_contents = "package a; interface Bar {}";
163 CaptureStderr();
164 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
165 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
166}
167
168TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
169 const string expected_stderr =
170 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
171 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
172 CaptureStderr();
173 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
174 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
175}
176
177TEST_P(AidlTest, EnumRequiresCorrectPath) {
178 const string expected_stderr =
179 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
180 const std::string file_contents = "package a; enum Bar { A, }";
181 CaptureStderr();
182 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
183 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
184}
185
Devin Moore7b8d5c92020-03-17 14:14:08 -0700186TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900187 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700188 io_delegate_.SetFileContents("bar/IBar.aidl",
189 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700190 const string path = "foo/IFoo.aidl";
191 const string contents =
192 "package foo;\n"
193 "import bar.IBar;\n"
194 "interface IFoo { void f(in IBar[] input); }";
195 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
196 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700197 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700199}
200
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700202 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900204}
Devin Moore097a3ab2020-03-11 16:08:44 -0700205
Jiyong Park40782d02020-07-24 19:17:43 +0900206TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700207 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
208 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900209 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
210 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700211 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900214}
215
Jiyong Park40782d02020-07-24 19:17:43 +0900216TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900217 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700218 const string expected_stderr =
219 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700220 CaptureStderr();
221 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900223}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224
Jiyong Park40782d02020-07-24 19:17:43 +0900225TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900226 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900227 const string expected_stderr =
228 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700229 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700230 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700232}
233
Devin Moore7b8d5c92020-03-17 14:14:08 -0700234TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700235 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
236 const string expected_stderr =
237 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
238 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700239 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700241}
242
Devin Moore7b8d5c92020-03-17 14:14:08 -0700243TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700244 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
245 const string expected_stderr =
246 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
247 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800250}
251
Devin Moore2f2077a2020-08-28 11:27:53 -0700252TEST_P(AidlTest, AcceptNullableList) {
253 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
254 const string expected_stderr = "";
255 CaptureStderr();
256 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
258}
259
Jooyung Han01720ed2021-08-13 07:46:07 +0900260TEST_P(AidlTest, RejectRecursiveParcelable) {
261 CaptureStderr();
262 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
263 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
264}
265
266TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
267 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
268 import_paths_.emplace("");
269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
271 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
272}
273
274TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
275 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
276 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
277 import_paths_.emplace("");
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
280 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
281}
282
283TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
284 CaptureStderr();
285 std::string java_only_map_field;
286 if (GetLanguage() == Options::Language::JAVA) {
287 java_only_map_field = " Map<String, Foo> map;\n";
288 }
289 EXPECT_NE(nullptr, Parse("Foo.aidl",
290 "parcelable Foo {\n"
291 " List<Foo> list;\n" +
292 java_only_map_field +
293 " Foo[] arr;\n"
294 " @nullable(heap=true) Foo heap_nullable;\n"
295 "}\n",
296 typenames_, GetLanguage()));
297 EXPECT_THAT(GetCapturedStderr(), "");
298}
299
300TEST_P(AidlTest, InterfaceCanReferenceItself) {
301 CaptureStderr();
302 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
303 GetLanguage()));
304 EXPECT_THAT(GetCapturedStderr(), "");
305}
306
307TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
308 CaptureStderr();
309 EXPECT_EQ(nullptr, Parse("Foo.aidl",
310 "parcelable Foo {\n"
311 " @nullable(heap=true) String s;\n"
312 "}",
313 typenames_, GetLanguage()));
314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
315}
316
Devin Moore7b8d5c92020-03-17 14:14:08 -0700317TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700318 const string method = "package a; interface IFoo { void f(int a, int a); }";
319 const string expected_stderr =
320 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700324}
325
Jeongik Cha13066da2020-08-06 15:43:19 +0900326TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
327 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900328 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900329 CaptureStderr();
330 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
332}
333
Jooyung Hand902a972020-10-23 17:32:44 +0900334TEST_P(AidlTest, RejectsRepeatedAnnotations) {
335 const string method = R"(@Hide @Hide parcelable Foo {})";
336 const string expected_stderr =
337 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
338 "Foo.aidl:1.1-6\n";
339 CaptureStderr();
340 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
342}
343
Jooyung Han05bd8a82021-04-28 23:56:38 +0900344TEST_P(AidlTest, AcceptsEmptyParcelable) {
345 CaptureStderr();
346 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
347 EXPECT_EQ("", GetCapturedStderr());
348}
349
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
352 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 AidlError error;
360 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700361 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700362 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900363 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700364 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 AidlError error;
369 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700370 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700371 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900372 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700373 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700377 AidlError error;
378 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700379 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000380 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900381 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700382 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000387 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700388 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900390 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700391 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800392}
393
Jiyong Park40782d02020-07-24 19:17:43 +0900394TEST_P(AidlTest, ParsesNonNullableAnnotation) {
395 auto parse_result =
396 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
397 ASSERT_NE(nullptr, parse_result);
398 const AidlInterface* interface = parse_result->AsInterface();
399 ASSERT_NE(nullptr, interface);
400 ASSERT_FALSE(interface->GetMethods().empty());
401 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
402}
403
Devin Moore7b8d5c92020-03-17 14:14:08 -0700404TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900405 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
406 typenames_, GetLanguage());
407 ASSERT_NE(nullptr, parse_result);
408 const AidlInterface* interface = parse_result->AsInterface();
409 ASSERT_NE(nullptr, interface);
410 ASSERT_FALSE(interface->GetMethods().empty());
411 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
412}
413
414TEST_P(AidlTest, ParsesNonUtf8Annotations) {
415 auto parse_result =
416 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
417 ASSERT_NE(nullptr, parse_result);
418 const AidlInterface* interface = parse_result->AsInterface();
419 ASSERT_NE(nullptr, interface);
420 ASSERT_FALSE(interface->GetMethods().empty());
421 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800422}
423
Devin Moore7b8d5c92020-03-17 14:14:08 -0700424TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900425 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
426 typenames_, GetLanguage());
427 ASSERT_NE(nullptr, parse_result);
428 const AidlInterface* interface = parse_result->AsInterface();
429 ASSERT_NE(nullptr, interface);
430 ASSERT_FALSE(interface->GetMethods().empty());
431 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800432}
433
Devin Moore7b8d5c92020-03-17 14:14:08 -0700434TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700435 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700436 const string expected_stderr =
437 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
438 "\"vintf\"'\n"
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
440 "--structured\n";
441 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700442 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700443 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700444 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700445 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700446}
447
Devin Moore7b8d5c92020-03-17 14:14:08 -0700448TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700449 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700450 const string expected_stderr =
451 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
452 "--structured\n";
453 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700454 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700455 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700456 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700457 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700458}
459
Devin Moore7b8d5c92020-03-17 14:14:08 -0700460TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700461 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700462 const string expected_stderr =
463 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
464 "\"vintf\"'\n";
465 CaptureStderr();
466 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700467 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700468 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700469 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700470}
471
Devin Moore7b8d5c92020-03-17 14:14:08 -0700472TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700473 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
475 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700476 ASSERT_EQ(AidlError::OK, error);
477 ASSERT_NE(nullptr, parse_result);
478 const AidlInterface* interface = parse_result->AsInterface();
479 ASSERT_NE(nullptr, interface);
480 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700481}
482
Jeongik Cha64783ed2019-06-07 18:30:54 +0900483TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
484 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900485 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
486 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900487 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700488 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900490 "a/Foo.aidl",
491 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900492
Steven Moreland4e059132021-08-11 13:36:30 -0700493 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
494 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900495
Devin Moorec054bf82020-03-10 16:31:48 -0700496 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700497 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900498 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700499
500 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700501 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900502 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900503}
504
Jooyung Han1cbc4962020-10-25 10:07:15 +0900505TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
506 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
507 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
508 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700509 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900510
511 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900512 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900513 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
514
515 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900516 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700517 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900518
Jooyung Han1cbc4962020-10-25 10:07:15 +0900519 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700520 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900521}
522
Jooyung Han1cbc4962020-10-25 10:07:15 +0900523TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
524 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
525 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
526 CaptureStderr();
527 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700528 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900529 EXPECT_EQ("", GetCapturedStderr());
530
531 const string expected_to_string_method = R"--(
532 @Override
533 public String toString() {
534 switch (_tag) {
535 case a: return "a.Foo.a(" + (getA()) + ")";
536 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
537 }
538 throw new IllegalStateException("unknown field: " + _tag);
539 }
540)--";
541
542 string java_out;
543 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
544 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
545}
546
Jiyong Park9aa3d042020-12-04 23:30:02 +0900547TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
548 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
549 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
550 CaptureStderr();
551 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700552 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900553 EXPECT_EQ("", GetCapturedStderr());
554
555 const std::string expected = R"--(
556 @Override
557 public boolean equals(Object other) {
558 if (this == other) return true;
559 if (other == null) return false;
560 if (!(other instanceof Foo)) return false;
561 Foo that = (Foo)other;
562 if (!java.util.Objects.deepEquals(a, that.a)) return false;
563 if (!java.util.Objects.deepEquals(b, that.b)) return false;
564 return true;
565 }
566
567 @Override
568 public int hashCode() {
569 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
570 }
571)--";
572
573 string java_out;
574 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
575 EXPECT_THAT(java_out, testing::HasSubstr(expected));
576}
577
578TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
579 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
580 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
581 CaptureStderr();
582 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700583 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900584 EXPECT_EQ("", GetCapturedStderr());
585
586 const std::string expected = R"--(
587 @Override
588 public boolean equals(Object other) {
589 if (this == other) return true;
590 if (other == null) return false;
591 if (!(other instanceof Foo)) return false;
592 Foo that = (Foo)other;
593 if (_tag != that._tag) return false;
594 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
595 return true;
596 }
597
598 @Override
599 public int hashCode() {
600 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
601 }
602)--";
603
604 string java_out;
605 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
606 EXPECT_THAT(java_out, testing::HasSubstr(expected));
607}
608
Jooyung Han90345002020-10-23 15:28:53 +0900609TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900610 {
Jooyung Han90345002020-10-23 15:28:53 +0900611 io_delegate_.SetFileContents("a/Foo.aidl",
612 "package a; @JavaDerive(blah=true) parcelable Foo{}");
613 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
614 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700615 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900616 const std::string expected_stderr =
617 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900618 EXPECT_THAT(GetCapturedStderr(),
619 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900620 }
621
622 {
623 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900624 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
625 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700626 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900628 }
629
630 {
Jooyung Han90345002020-10-23 15:28:53 +0900631 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900632 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
633 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700634 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900635 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900636 }
637}
638
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900639TEST_P(AidlTest, ParseDescriptorAnnotation) {
640 AidlError error;
641 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
642 typenames_, GetLanguage(), &error, {"--structured"});
643 ASSERT_EQ(AidlError::OK, error);
644 ASSERT_NE(nullptr, parse_result);
645 const AidlInterface* interface = parse_result->AsInterface();
646 ASSERT_NE(nullptr, interface);
647 ASSERT_EQ("IBar", interface->GetDescriptor());
648}
649
Jiyong Park40782d02020-07-24 19:17:43 +0900650TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700651 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700652 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900653}
654
655TEST_P(AidlTest, AcceptsOnewayInterface) {
656 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700657 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700658}
Christopher Wileyef140932015-11-03 09:29:19 -0800659
Devin Moore7b8d5c92020-03-17 14:14:08 -0700660TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700661 const string oneway_method =
662 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700663 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100664}
665
Steven Moreland65297cc2020-04-20 20:17:36 -0700666TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
667 const string oneway_method =
668 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
669 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
670 ASSERT_NE(nullptr, defined);
671 const AidlInterface* iface = defined->AsInterface();
672 ASSERT_NE(nullptr, iface);
673
674 const auto& methods = iface->GetMethods();
675 ASSERT_EQ(1u, methods.size());
676 const auto& method = methods[0];
677 const AidlTypeSpecifier& ret_type = method->GetType();
678
679 // TODO(b/151102494): these annotations should be on the method
680 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
681 ASSERT_TRUE(ret_type.IsHide());
682}
683
Devin Moore7b8d5c92020-03-17 14:14:08 -0700684TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100685 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900686 R"(package a;
687 /* foo */
688 interface IFoo {
689 /* i */
690 int i();
691 // j
692 @nullable String j();
693 // k1
694 /* k2 */
695 @UnsupportedAppUsage oneway void k(int a);
696 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100697
Jooyung Han8451a202021-01-16 03:07:06 +0900698 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700699 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100700 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900701 EXPECT_EQ("", GetCapturedStderr());
702
Jooyung Han161bb0f2021-01-21 12:30:16 +0900703 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100704
705 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900706 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
707 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
708 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100709}
710
Jooyung Han1a551d32020-10-05 15:37:26 +0900711TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
712 io_delegate_.SetFileContents("p/cpp_header.aidl",
713 R"(package p;
714 parcelable cpp_header cpp_header "bar/header";)");
715 import_paths_.emplace("");
716 const string input_path = "p/IFoo.aidl";
717 const string input = R"(package p;
718 import p.cpp_header;
719 interface IFoo {
720 // get bar
721 cpp_header get();
722 })";
723
724 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
725 EXPECT_NE(nullptr, parse_result);
726 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900727 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900728}
729
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900730TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
731 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
732 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
733 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700734 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900735 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
736}
737
738TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
739 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
740 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
741 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
742 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700743 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
745}
746
Christopher Wileyef140932015-11-03 09:29:19 -0800747TEST_F(AidlTest, ParsesPreprocessedFile) {
748 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
749 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700750 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900751 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700752 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
753 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800754}
755
756TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
757 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
758 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900759
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700760 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900761 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700762 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
763 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800764}
765
Devin Moore7b8d5c92020-03-17 14:14:08 -0700766TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800767 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
768 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
769 "interface IBar {}");
770 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900771 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900772 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700773 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800774 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900775
Christopher Wiley41544372015-11-03 14:52:29 -0800776 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700777 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
778 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800779 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900780 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900781 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900782 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800783}
784
Jiyong Park8f6ec462020-01-19 20:52:47 +0900785// Special case of PreferImportToPreprocessed. Imported type should be preferred
786// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900788 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
789 io_delegate_.SetFileContents("one/IBar.aidl",
790 "package one; "
791 "interface IBar {}");
792 preprocessed_files_.push_back("preprocessed");
793 import_paths_.emplace("");
794 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700795 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900796 EXPECT_NE(nullptr, parse_result);
797
798 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700799 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
800 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900801 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900802 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900803 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900804 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
805}
806
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800807TEST_F(AidlTest, WritePreprocessedFile) {
808 io_delegate_.SetFileContents("p/Outer.aidl",
809 "package p; parcelable Outer.Inner;");
810 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
811 "interface IBar {}");
812
Jooyung Han93f48f02021-06-05 00:11:16 +0900813 vector<string> args{"aidl", "--preprocess", "preprocessed",
814 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900815 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900816 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800817
Jooyung Han93f48f02021-06-05 00:11:16 +0900818 std::map<std::string, std::string> expected = {{"preprocessed",
819 "parcelable p.Outer.Inner;\n"
820 "interface one.IBar {\n"
821 "}\n"}};
822 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
823}
824
825TEST_F(AidlTest, PreprocessVariousThings) {
826 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
827 "package foo.bar;\n"
828 "interface IFoo {\n"
829 " int foo();\n"
830 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
831 "}\n");
832 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
833 "package foo.bar;\n"
834 "parcelable Bar {\n"
835 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
836 " imported.Foo foo;\n"
837 "}\n");
838 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
839 "package foo.bar;\n"
840 "parcelable Gen<T> {\n"
841 "}\n");
842 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
843 "package foo.bar;\n"
844 "enum Enum {\n"
845 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
846 "}\n");
847 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
848 "package imported;\n"
849 "parcelable Foo {\n"
850 " const int FOO = 42;\n"
851 "}\n");
852
853 vector<string> args = {
854 "aidl",
855 "--preprocess",
856 "preprocessed",
857 "-Isub",
858 "-I.",
859 "foo/bar/IFoo.aidl",
860 "foo/bar/Bar.aidl",
861 "foo/bar/Gen.aidl",
862 "foo/bar/Enum.aidl",
863 };
864 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
865 std::string preprocessed =
866 "interface foo.bar.IFoo {\n"
867 " const int FOO = 44;\n"
868 "}\n"
869 "parcelable foo.bar.Bar {\n"
870 " const int BAR = 43;\n"
871 "}\n"
872 "parcelable foo.bar.Gen<T> {\n"
873 "}\n"
874 "enum foo.bar.Enum {\n"
875 " FOO = 3,\n"
876 " BAR = 6,\n"
877 "}\n";
878 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
879 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
880
881 // use preprocessed
882 io_delegate_.SetFileContents("a/Foo.aidl",
883 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
884 io_delegate_.SetFileContents("preprocessed", preprocessed);
885 CaptureStderr();
886 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700887 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900888 EXPECT_EQ("", GetCapturedStderr());
889 string code;
890 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
891 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
892}
893
Jooyung Han35784982021-06-29 06:26:12 +0900894TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
895 io_delegate_.SetFileContents("p/IFoo.aidl",
896 "package p;\n"
897 "import x.Outer;\n"
898 "interface IFoo {\n"
899 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
900 "}");
901 io_delegate_.SetFileContents("imported/x/Outer.aidl",
902 "package x;\n"
903 "parcelable Outer.Inner1;\n"
904 "parcelable Outer.Inner2;\n");
905 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
906 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700907 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900908 EXPECT_EQ("", GetCapturedStderr());
909}
910
911TEST_F(AidlTest,
912 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
913 // Main doc(Foo.aidl) is loaded
914 // And then framework.aidl is loaded as preprocessed. (conflict)
915 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
916 io_delegate_.SetFileContents("x/Foo.aidl",
917 "package x;\n"
918 "parcelable Foo.Inner;\n");
919 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
927 // Main doc(IBar.aidl) is loaded first.
928 // Framework.aidl is loaded as preprocessed.
929 // And then import(Foo.aidl) is loaded. (conflict)
930 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
931 io_delegate_.SetFileContents("x/IBar.aidl",
932 "package x;\n"
933 "import x.Foo;\n"
934 "interface IBar {\n"
935 " void bar(in Foo.Inner inner);\n"
936 "}");
937 io_delegate_.SetFileContents("x/Foo.aidl",
938 "package x;\n"
939 "parcelable Foo.Inner;\n");
940 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
941 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700942 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900943 EXPECT_EQ("", GetCapturedStderr());
944}
945
Jooyung Han93f48f02021-06-05 00:11:16 +0900946TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
947 string simple_content = "package xxx; parcelable a.Foo;";
948 io_delegate_.SetFileContents("path", simple_content);
949 CaptureStderr();
950 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
951 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
952}
953
954TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
955 string simple_content = "parcelable a.Foo {}";
956 io_delegate_.SetFileContents("path", simple_content);
957 CaptureStderr();
958 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
959 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800960}
961
Jooyung Han13f1fa52021-06-11 18:06:12 +0900962TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
963 string contents = R"(
964 interface android.os.IBinder;
965 interface android.os.IInterface;
966 parcelable android.os.ParcelFileDescriptor;
967 )";
968 io_delegate_.SetFileContents("path", contents);
969 CaptureStderr();
970 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
971 EXPECT_THAT(GetCapturedStderr(), "");
972}
973
Jooyung Han720253d2021-01-05 19:13:17 +0900974TEST_P(AidlTest, SupportDeprecated) {
975 struct TestCase {
976 std::string output_file;
977 std::string annotation;
978 };
979
980 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900981 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900982 io_delegate_.SetFileContents(filename, contents);
983
984 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
985 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -0700986 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900987 for (const auto& [lang, test_case] : expectations) {
988 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900989 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900990 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900991 EXPECT_THAT(output, HasSubstr(test_case.annotation));
992 }
993 };
994
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 // Emit escaped string for notes
996 CheckDeprecated(
997 "IFoo.aidl",
998 R"(interface IFoo {
999 /**
1000 * @note asdf
1001 * @deprecated a really long deprecation message
1002 *
1003 * which is really long
1004 * @param foo bar
1005 */
1006 List<String> foo();
1007 })",
1008 {
1009 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1010 {Options::Language::CPP,
1011 {"out/IFoo.h",
1012 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1013 {Options::Language::NDK,
1014 {"out/aidl/IFoo.h",
1015 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1016 {Options::Language::RUST,
1017 {"out/IFoo.rs",
1018 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1019 });
1020
Jooyung Han24effbf2021-01-16 10:24:03 +09001021 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001022 CheckDeprecated(
1023 "IFoo.aidl",
1024 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001025 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001026 " List<String> foo();\n"
1027 "}",
1028 {
1029 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001030 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001031 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1032 {Options::Language::NDK,
1033 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1034 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1035 });
Jooyung Han720253d2021-01-05 19:13:17 +09001036
Jooyung Han24effbf2021-01-16 10:24:03 +09001037 // but not in line comments
1038 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1039 EXPECT_FALSE(parsed->IsDeprecated());
1040
1041 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001042 CheckDeprecated("Foo.aidl",
1043 "parcelable Foo {\n"
1044 " /** @deprecated use bar*/\n"
1045 " int foo = 0;\n"
1046 "}",
1047 {
1048 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1049 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1050 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1051 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1052 });
1053
Jooyung Han24effbf2021-01-16 10:24:03 +09001054 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001055 CheckDeprecated("IFoo.aidl",
1056 "interface IFoo {\n"
1057 " /** @deprecated use bar*/\n"
1058 " const int FOO = 0;\n"
1059 "}",
1060 {
1061 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1062 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1063 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1064 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1065 });
1066
1067 // union fields
1068 CheckDeprecated("Foo.aidl",
1069 "union Foo {\n"
1070 " int bar = 0;\n"
1071 " /** @deprecated use bar*/\n"
1072 " int foo;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1079 });
1080
1081 CheckDeprecated("Foo.aidl",
1082 "/** @deprecated use Bar */\n"
1083 "parcelable Foo {}",
1084 {
1085 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1086 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1087 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1088 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1089 });
1090
1091 CheckDeprecated("Foo.aidl",
1092 "/** @deprecated use Bar */\n"
1093 "union Foo { int foo = 0; }",
1094 {
1095 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1096 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1097 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1098 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1099 });
1100
1101 CheckDeprecated("IFoo.aidl",
1102 "/** @deprecated use IBar */\n"
1103 "interface IFoo {}",
1104 {
1105 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1106 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1107 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1108 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1109 });
1110
1111 CheckDeprecated("Foo.aidl",
1112 "/** @deprecated use IBar */\n"
1113 "enum Foo { FOO }",
1114 {
1115 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1116 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1117 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001118 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001119 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1120 });
1121}
1122
Devin Moore7b8d5c92020-03-17 14:14:08 -07001123TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001124 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001125 io_delegate_.SetFileContents("p/Outer.aidl",
1126 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001127 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001128 CaptureStderr();
1129 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1130 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001131 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001132 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001133}
1134
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001136 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001137 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001138 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001139 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001140 // TODO(wiley): This should actually return nullptr because we require
1141 // the outer class name. However, for legacy reasons,
1142 // this behavior must be maintained. b/17415692
1143 EXPECT_NE(nullptr, parse_result);
1144}
1145
Christopher Wiley632801d2015-11-05 14:15:49 -08001146TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001147 const string expected_foo_stderr =
1148 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1149 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1150 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001151 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1152
Christopher Wiley632801d2015-11-05 14:15:49 -08001153 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001154 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001155 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001156 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001157 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001158
Steven Morelande2c64b42018-09-18 15:06:37 -07001159 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001160 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001161 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001162 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001163 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001164
Devin Moore097a3ab2020-03-11 16:08:44 -07001165 const string expected_bar_stderr =
1166 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1167 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1168 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001169 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1170
Jiyong Parkda8c6932019-08-12 19:56:08 +09001171 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001172 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001173 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001174 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001175 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001176 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001177 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001178 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001179 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001180}
1181
Jooyung Han13f1fa52021-06-11 18:06:12 +09001182TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1183 string contents = R"(
1184 import android.os.IBinder;
1185 import android.os.IInterface;
1186 interface IFoo {
1187 void foo(in IBinder b);
1188 }
1189 )";
1190 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1191}
1192
Devin Moore7b8d5c92020-03-17 14:14:08 -07001193TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001194 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001195 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001197 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1198 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001199 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 AidlError error;
1201 CaptureStderr();
1202 EXPECT_EQ(
1203 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001204 Parse("p/IFoo.aidl",
1205 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001206 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001207 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1208 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001209}
1210
Devin Moore7b8d5c92020-03-17 14:14:08 -07001211TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001212 AidlError error;
1213 const string expected_stderr =
1214 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1215 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001216 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1217 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001218 interface IFoo {
1219 const String DUPLICATED = "d";
1220 const int DUPLICATED = 1;
1221 }
1222 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001223 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1225 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001226}
1227
Steven Morelande689da22020-11-10 02:06:30 +00001228TEST_P(AidlTest, FailOnTooBigConstant) {
1229 AidlError error;
1230 const string expected_stderr =
1231 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1232 CaptureStderr();
1233 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1234 R"(package p;
1235 interface IFoo {
1236 const byte type2small = 256;
1237 }
1238 )",
1239 typenames_, GetLanguage(), &error));
1240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1241 EXPECT_EQ(AidlError::BAD_TYPE, error);
1242}
1243
Jooyung Han30f64ad2020-12-15 08:16:31 +09001244TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1245 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1246 CaptureStderr();
1247 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001248 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001249 EXPECT_EQ("", GetCapturedStderr());
1250 string code;
1251 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1252 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1253}
1254
Jooyung Han535c5e82020-12-29 15:16:59 +09001255TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001256 using Ptr = unique_ptr<AidlConstantValue>;
1257 const AidlLocation& loc = AIDL_LOCATION_HERE;
1258
Jooyung Han535c5e82020-12-29 15:16:59 +09001259 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1260 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1261 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1262 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001263
1264 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1265 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001266 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001267
1268 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1269 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1270 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1271 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001272 EXPECT_EQ(
1273 expected,
1274 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001275}
1276
Devin Moore7b8d5c92020-03-17 14:14:08 -07001277TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001278 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001279 const string expected_stderr =
1280 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001281 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001282 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1283 R"(package p;
1284 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001285 parcelable IBar {}
1286 parcelable StructuredParcelable {}
1287 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001288 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001289 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001290 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001291 // Parse success is important for clear error handling even if the cases aren't
1292 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001293 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001294}
1295
Devin Moore7b8d5c92020-03-17 14:14:08 -07001296TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001297 AidlError error;
1298 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1299 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1302 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001303}
1304
Steven Morelandf9e922f2020-07-08 21:15:27 +00001305TEST_P(AidlTest, FailOnEmptyListWithComma) {
1306 AidlError error;
1307 const string expected_stderr =
1308 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1309 CaptureStderr();
1310 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1311 typenames_, GetLanguage(), &error));
1312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1313 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1314}
1315
Devin Moore7b8d5c92020-03-17 14:14:08 -07001316TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001317 AidlError error;
1318 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001319 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001321 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1322 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001323 interface IFoo {
1324 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1325 }
1326 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001327 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001328 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1329 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001330}
1331
Jiyong Park18132182020-06-08 20:24:40 +09001332TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1333 AidlError error;
1334 const string expected_stderr =
1335 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1336 "cpp_header (which can also be used as an identifier)\n";
1337 CaptureStderr();
1338 // Notice the trailing dot(.) in the name, which isn't a correct name
1339 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1340 GetLanguage(), &error));
1341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1342 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1343}
1344
1345TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1346 AidlError error;
1347 const string expected_stderr =
1348 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1349 "cpp_header (which can also be used as an identifier)\n";
1350 CaptureStderr();
1351 // Notice the trailing dot(.) in the package name
1352 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1353 GetLanguage(), &error));
1354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1355 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1356}
1357
Devin Moore7b8d5c92020-03-17 14:14:08 -07001358TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001359 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001360 auto parse_result = Parse("p/IFoo.aidl",
1361 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001362 interface IFoo {
1363 const int POSITIVE_HEX_VALUE = 0xf5;
1364 }
1365 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001366 typenames_, GetLanguage(), &error);
1367 EXPECT_NE(nullptr, parse_result);
1368 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001369 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001370 const auto& cpp_constants = interface->GetConstantDeclarations();
1371 EXPECT_EQ((size_t)1, cpp_constants.size());
1372 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001373 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001374 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001375}
1376
Devin Moore7b8d5c92020-03-17 14:14:08 -07001377TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001378 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001379 auto parse_result = Parse("p/IFoo.aidl",
1380 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001381 interface IFoo {
1382 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1383 }
1384 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001385 typenames_, GetLanguage(), &error);
1386 ASSERT_NE(nullptr, parse_result);
1387 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001388 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001389 const auto& cpp_constants = interface->GetConstantDeclarations();
1390 EXPECT_EQ((size_t)1, cpp_constants.size());
1391 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001392 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001393 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001394}
1395
Devin Moore7b8d5c92020-03-17 14:14:08 -07001396TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001397 io_delegate_.SetFileContents(
1398 "p/Outer.aidl",
1399 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001400 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001401 const string input_path = "p/IFoo.aidl";
1402 const string input = "package p; import p.Outer; interface IFoo"
1403 " { Outer.Inner get(); }";
1404
Devin Moore7b8d5c92020-03-17 14:14:08 -07001405 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1406 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001407
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001408 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001409 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001410 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001411 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001412}
1413
Jooyung Han78fcaa82021-06-11 22:27:57 +09001414TEST_P(AidlTest, UnderstandsNestedParcelablesWithoutImports) {
1415 io_delegate_.SetFileContents("p/Outer.aidl",
1416 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1417 import_paths_.emplace("");
1418 const string input_path = "p/IFoo.aidl";
1419 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1420
1421 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1422 EXPECT_NE(nullptr, parse_result);
1423
1424 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1425 // C++ uses "::" instead of "." to refer to a inner class.
1426 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1427 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1428}
1429
Jooyung Han0a950bd2021-05-15 12:50:36 +09001430TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001431 const string input_path = "p/Wrapper.aidl";
1432 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001433
1434 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1435 EXPECT_NE(nullptr, parse_result);
1436
1437 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1438 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1439 (..., params->emplace_back(std::move(type_params)));
1440 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1441 };
1442
1443 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1444 std::vector<AidlAnnotation> annotations;
1445 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", nullptr, {}));
1446 type->Annotate(std::move(annotations));
1447 return std::move(type);
1448 };
1449
1450 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1451 (void)type->SetArray();
1452 return std::move(type);
1453 };
1454
1455 auto w = type("p.Wrapper", type("String"));
1456 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1457
1458 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1459 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1460 cpp::CppNameOf(*nullable_w, typenames_));
1461
1462 auto array_w = set_array(type("p.Wrapper", type("String")));
1463 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1464 cpp::CppNameOf(*array_w, typenames_));
1465
1466 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1467 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1468 cpp::CppNameOf(*nullable_array_w, typenames_));
1469
1470 auto list_w = type("List", type("p.Wrapper", type("String")));
1471 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1472 cpp::CppNameOf(*list_w, typenames_));
1473
1474 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1475 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1476 cpp::CppNameOf(*nullable_list_w, typenames_));
1477}
1478
Devin Moore7b8d5c92020-03-17 14:14:08 -07001479TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001480 io_delegate_.SetFileContents(
1481 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001482 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001483 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001484 const string input_path = "p/IFoo.aidl";
1485 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001486 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1487 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001488 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001489 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001490 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001491
1492 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1493 // C++ understands C++ specific stuff
1494 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1495 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001496 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001497 EXPECT_EQ(1u, headers.size());
1498 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001499}
1500
Christopher Wileyf8136192016-04-12 14:19:35 -07001501TEST_F(AidlTest, WritesCorrectDependencyFile) {
1502 // While the in tree build system always gives us an output file name,
1503 // other android tools take advantage of our ability to infer the intended
1504 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001505 vector<string> args = {
1506 "aidl",
1507 "-d dep/file/path",
1508 "-o place/for/output",
1509 "p/IFoo.aidl"};
1510 Options options = Options::From(args);
1511 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001512 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001513 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001514 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001515 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1516}
1517
Dan Willemsen93298ee2016-11-10 23:55:55 -08001518TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1519 // While the in tree build system always gives us an output file name,
1520 // other android tools take advantage of our ability to infer the intended
1521 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001522 vector<string> args = {
1523 "aidl",
1524 "-d dep/file/path",
1525 "--ninja",
1526 "-o place/for/output",
1527 "p/IFoo.aidl"};
1528 Options options = Options::From(args);
1529 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001530 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001531 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001532 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001533 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1534}
1535
Jiyong Parkdf202122019-09-30 20:48:35 +09001536TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001537 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1538 // this by calling aidl with every .aidl file it finds, then parsing the
1539 // generated dependency files. Those that reference .java output files are
1540 // for interfaces and those that do not are parcelables. However, for both
1541 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001542 vector<string> args = {
1543 "aidl",
1544 "-o place/for/output",
1545 "-d dep/file/path",
1546 "p/Foo.aidl"};
1547 Options options = Options::From(args);
1548 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001549 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001550 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001551 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001552 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1553}
1554
1555TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1556 vector<string> args = {
1557 "aidl",
1558 "--structured",
1559 "-o place/for/output",
1560 "-d dep/file/path",
1561 "p/Foo.aidl"};
1562 Options options = Options::From(args);
1563 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001564 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001565 string actual_dep_file_contents;
1566 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1567 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001568}
1569
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001570TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1571 vector<string> args = {
1572 "aidl",
1573 "--lang=java",
1574 "-o place/for/output",
1575 "p/Foo.aidl"};
1576 Options options = Options::From(args);
1577 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001578 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001579 string output_file_contents;
1580 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1581}
1582
Devin Moore21b26772020-08-26 16:37:56 -07001583TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001584 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001585 const string list_array_parcelable =
1586 "package a; parcelable Foo {\n"
1587 " List[] lists; }";
1588 CaptureStderr();
1589 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1590 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1591}
1592
Jiyong Parkf8d53612020-05-04 14:06:13 +09001593TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1594 AidlError error;
1595 string expected_stderr =
1596 "ERROR: a/IFoo.aidl:2.7-11: "
1597 "Encountered an untyped List or Map. The use of untyped List/Map is "
1598 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1599 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1600 if (GetLanguage() != Options::Language::JAVA) {
1601 expected_stderr =
1602 "ERROR: a/IFoo.aidl:2.1-7: "
1603 "Currently, only the Java backend supports non-generic List.\n";
1604 }
1605
1606 const string primitive_interface =
1607 "package a; interface IFoo {\n"
1608 " List foo(); }";
1609 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001610 AidlTypenames tn1;
1611 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001612 {"--structured"}));
1613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001614
1615 string primitive_parcelable =
1616 "package a; parcelable IFoo {\n"
1617 " List foo;}";
1618 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001619 AidlTypenames tn2;
1620 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001621 {"--structured"}));
1622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1623}
1624
Jeongik Cha225519b2020-08-29 01:55:32 +09001625TEST_P(AidlTest, ExtensionTest) {
1626 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001627 string extendable_parcelable =
1628 "package a; parcelable Data {\n"
1629 " ParcelableHolder extension;\n"
1630 " ParcelableHolder extension2;\n"
1631 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001632 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001633 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1634 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001635 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001636 "yet.\n",
1637 GetCapturedStderr());
1638 } else {
1639 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1640 EXPECT_EQ("", GetCapturedStderr());
1641 }
1642}
1643TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1644 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001645 string parcelableholder_return_interface =
1646 "package a; interface IFoo {\n"
1647 " ParcelableHolder foo();\n"
1648 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001649 EXPECT_EQ(nullptr,
1650 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001651
Jeongik Cha8f02a532020-10-14 00:16:28 +09001652 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001653 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001654 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001655 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001656 "yet.\n",
1657 GetCapturedStderr());
1658 return;
1659 }
1660 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1661 GetCapturedStderr());
1662}
1663
1664TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1665 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001666 string extendable_parcelable_arg_interface =
1667 "package a; interface IFoo {\n"
1668 " void foo(in ParcelableHolder ph);\n"
1669 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001670 EXPECT_EQ(nullptr,
1671 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1672
Jeongik Cha8f02a532020-10-14 00:16:28 +09001673 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001674 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001675 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001676 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001677 "yet.\n",
1678 GetCapturedStderr());
1679 return;
1680 }
1681 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1682 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001683}
1684
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001685TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1686 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001687 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001688 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1689 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001690 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001691 if (GetLanguage() == Options::Language::RUST) {
1692 EXPECT_EQ(
1693 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1694 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1695 "yet.\n",
1696 GetCapturedStderr());
1697 return;
1698 }
1699 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1700}
1701
Jooyung Han3f347ca2020-12-01 12:41:50 +09001702TEST_P(AidlTest, ParcelablesWithConstants) {
1703 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001704 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001705 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001706 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001707 EXPECT_EQ("", GetCapturedStderr());
1708}
1709
1710TEST_P(AidlTest, UnionWithConstants) {
1711 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001712 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001713 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001714 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001715 EXPECT_EQ("", GetCapturedStderr());
1716}
1717
Jooyung Han633eab62021-01-07 14:12:40 +09001718TEST_F(AidlTest, ConstantsWithAnnotations) {
1719 io_delegate_.SetFileContents("IFoo.aidl",
1720 "interface IFoo {\n"
1721 " @JavaPassthrough(annotation=\"@Foo\")\n"
1722 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1723 "}");
1724 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1725 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001726 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09001727 EXPECT_EQ("", GetCapturedStderr());
1728 string code;
1729 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1730 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1731 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1732}
1733
Jiyong Park02da7422018-07-16 16:00:26 +09001734TEST_F(AidlTest, ApiDump) {
1735 io_delegate_.SetFileContents(
1736 "foo/bar/IFoo.aidl",
1737 "package foo.bar;\n"
1738 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001739 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001740 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001741 " /* @hide applied \n"
1742 " @deprecated use foo2 */\n"
1743 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1744 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001745 " IFoo foo3(IFoo foo);\n"
1746 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001747 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001748 " /** blahblah\n"
1749 " @deprecated\n"
1750 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001751 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001752 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001753 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001754 "}\n");
1755 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1756 "package foo.bar;\n"
1757 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001758 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001759 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001760 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001761 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001762 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001763 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001764 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001765 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001766 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001767 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001768 "}\n");
1769 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001770 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1771 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001772 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001773 bool result = dump_api(options, io_delegate_);
1774 ASSERT_TRUE(result);
1775 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001776 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001777 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001778interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001779 /**
1780 * @hide
1781 * @deprecated use foo2
1782 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001783 int foo(out int[] a, String b, boolean c, inout List<String> d);
1784 int foo2(@utf8InCpp String x, inout List<String> y);
1785 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1786 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001787 /**
1788 * @deprecated reason why...
1789 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001790 const int A = 1;
1791 const String STR = "Hello";
1792}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001793)"),
1794 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001795
Jiyong Parke59c3682018-09-11 23:10:25 +09001796 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001797 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001798/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001799parcelable Data {
1800 int x = 10;
1801 int y;
1802 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001803 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001804}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001805)"),
1806 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001807}
1808
Jiyong Parked65bf42018-08-28 15:43:27 +09001809TEST_F(AidlTest, ApiDumpWithManualIds) {
1810 io_delegate_.SetFileContents(
1811 "foo/bar/IFoo.aidl",
1812 "package foo.bar;\n"
1813 "interface IFoo {\n"
1814 " int foo() = 1;\n"
1815 " int bar() = 2;\n"
1816 " int baz() = 10;\n"
1817 "}\n");
1818
Jiyong Parke59c3682018-09-11 23:10:25 +09001819 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001820 Options options = Options::From(args);
1821 bool result = dump_api(options, io_delegate_);
1822 ASSERT_TRUE(result);
1823 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001824 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001825 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001826interface IFoo {
1827 int foo() = 1;
1828 int bar() = 2;
1829 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001830}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001831)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001832}
1833
1834TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001835 const string expected_stderr =
1836 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1837 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001838 io_delegate_.SetFileContents(
1839 "foo/bar/IFoo.aidl",
1840 "package foo.bar;\n"
1841 "interface IFoo {\n"
1842 " int foo() = 1;\n"
1843 " int bar();\n"
1844 " int baz() = 10;\n"
1845 "}\n");
1846
Jiyong Parke59c3682018-09-11 23:10:25 +09001847 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001848 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001849 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001850 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001851 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001852}
1853
Jooyung Han965e31d2020-11-27 12:30:16 +09001854TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1855 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1856 "package foo.bar;\n"
1857 "interface IFoo {\n"
1858 " @utf8InCpp String foo();\n"
1859 " const @utf8InCpp String bar = \"bar\";\n"
1860 "}\n");
1861
1862 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1863 Options options = Options::From(args);
1864 CaptureStderr();
1865 EXPECT_TRUE(dump_api(options, io_delegate_));
1866 EXPECT_EQ("", GetCapturedStderr());
1867 string actual;
1868 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001869 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1870interface IFoo {
1871 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001872 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001873}
1874)"),
1875 actual);
1876}
1877
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001878TEST_F(AidlTest, ApiDumpWithEnums) {
1879 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1880 "package foo.bar;\n"
1881 "enum Enum {\n"
1882 " FOO,\n"
1883 " BAR = FOO + 1,\n"
1884 "}\n");
1885
1886 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1887 Options options = Options::From(args);
1888 CaptureStderr();
1889 EXPECT_TRUE(dump_api(options, io_delegate_));
1890 EXPECT_EQ("", GetCapturedStderr());
1891 string actual;
1892 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1893 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1894 "enum Enum {\n"
1895 " FOO = 0,\n"
1896 " BAR = 1,\n"
1897 "}\n"),
1898 actual);
1899}
1900
1901TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1902 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1903 "package foo.bar;\n"
1904 "enum Enum {\n"
1905 " FOO,\n"
1906 "}\n");
1907 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1908 "package foo.bar;\n"
1909 "import foo.bar.Enum;\n"
1910 "parcelable Foo {\n"
1911 " Enum e = Enum.FOO;\n"
1912 "}\n");
1913
1914 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1915 Options options = Options::From(args);
1916 CaptureStderr();
1917 EXPECT_TRUE(dump_api(options, io_delegate_));
1918 EXPECT_EQ("", GetCapturedStderr());
1919 string actual;
1920 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1921 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1922 "parcelable Foo {\n"
1923 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1924 "}\n"),
1925 actual);
1926}
1927
Jooyung Han71dfec32021-05-23 07:18:58 +09001928TEST_F(AidlTest, ApiDumpWithGenerics) {
1929 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1930 "package foo.bar;\n"
1931 "parcelable Foo<T, U> {\n"
1932 "}\n");
1933
1934 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1935 Options options = Options::From(args);
1936 CaptureStderr();
1937 EXPECT_TRUE(dump_api(options, io_delegate_));
1938 EXPECT_EQ("", GetCapturedStderr());
1939 string actual;
1940 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1941 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1942 "parcelable Foo<T, U> {\n"
1943 "}\n"),
1944 actual);
1945}
1946
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001947TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001948 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001949 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1950 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001951 const string expected_map_stderr =
1952 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001953 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1954 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001955 "package p; interface IFoo {"
1956 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001957 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001958 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001959 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001960
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001961 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001962 "package p; interface IFoo {"
1963 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001964 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001965 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001966 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001967}
1968
Jeongik Chae48d9942020-01-02 17:39:00 +09001969TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001970 const string expected_stderr =
1971 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09001972 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09001973 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1974
1975 io_delegate_.SetFileContents("p/IFoo.aidl",
1976 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001977 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07001978 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09001979
1980 io_delegate_.SetFileContents("p/IFoo.aidl",
1981 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09001982 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001983 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001984 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001985 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001986
1987 io_delegate_.SetFileContents("p/IFoo.aidl",
1988 "package p; interface IFoo {"
1989 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07001990 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09001991
1992 io_delegate_.SetFileContents("p/IFoo.aidl",
1993 "package p; interface IFoo {"
1994 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07001995 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09001996}
1997
Jeongik Chadf76dc72019-11-28 00:08:47 +09001998TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001999 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002000 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2001 io_delegate_.SetFileContents(options.InputFiles().front(),
2002 "package p; interface IFoo {"
2003 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002004 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002005 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002006 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002007}
2008
2009TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002010 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002011 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002012 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002013 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002014 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2015 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002016
Jooyung Han13f1fa52021-06-11 18:06:12 +09002017 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002018 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2019 io_delegate_.SetFileContents("p/IFoo.aidl",
2020 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002021 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002022 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002023 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002024 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002025 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002026 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002027 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002028 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002029 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002030 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002031 io_delegate_.SetFileContents("p/IFoo.aidl",
2032 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002033 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002034 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002035
2036 io_delegate_.SetFileContents("p/IFoo.aidl",
2037 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002038 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002039
2040 io_delegate_.SetFileContents("p/IFoo.aidl",
2041 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002042 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002043
Steven Moreland4e059132021-08-11 13:36:30 -07002044 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002045}
2046
Jeongik Cha0e426012019-07-29 15:57:02 +09002047TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2048 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002049 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2050 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002051 for (const auto& rawOption : rawOptions) {
2052 string expected_stderr =
2053 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002054 Options options = Options::From(rawOption);
2055 io_delegate_.SetFileContents(options.InputFiles().front(),
2056 "package foo.bar;\n"
2057 "interface IFoo1 { int foo(); }\n"
2058 "interface IFoo2 { int foo(); }\n"
2059 "parcelable Data1 { int a; int b;}\n"
2060 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002061 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002062 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002063 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002064
Jeongik Cha0e426012019-07-29 15:57:02 +09002065 io_delegate_.SetFileContents(options.InputFiles().front(),
2066 "package foo.bar;\n"
2067 "interface IFoo1 { int foo(); }\n"
2068 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002069 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002070 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002071 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002072
Devin Moore5de18ed2020-04-02 13:52:29 -07002073 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002074 io_delegate_.SetFileContents(options.InputFiles().front(),
2075 "package foo.bar;\n"
2076 "parcelable Data1 { int a; int b;}\n"
2077 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002078 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002079 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002080 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002081 }
2082}
2083
Devin Moorebdba2a82020-03-31 15:19:02 -07002084TEST_P(AidlTest, FailParseOnEmptyFile) {
2085 const string contents = "";
2086 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2087 CaptureStderr();
2088 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2090}
2091
Jiyong Parkb034bf02018-07-30 17:44:33 +09002092TEST_F(AidlTest, MultipleInputFiles) {
2093 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002094 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002095
2096 io_delegate_.SetFileContents(options.InputFiles().at(0),
2097 "package foo.bar;\n"
2098 "import foo.bar.Data;\n"
2099 "interface IFoo { Data getData(); }\n");
2100
2101 io_delegate_.SetFileContents(options.InputFiles().at(1),
2102 "package foo.bar;\n"
2103 "import foo.bar.IFoo;\n"
2104 "parcelable Data { IFoo foo; }\n");
2105
Steven Moreland4e059132021-08-11 13:36:30 -07002106 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002107
2108 string content;
2109 for (const auto file : {
2110 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2111 content.clear();
2112 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2113 EXPECT_FALSE(content.empty());
2114 }
2115}
2116
2117TEST_F(AidlTest, MultipleInputFilesCpp) {
2118 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002119 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002120
2121 io_delegate_.SetFileContents(options.InputFiles().at(0),
2122 "package foo.bar;\n"
2123 "import foo.bar.Data;\n"
2124 "interface IFoo { Data getData(); }\n");
2125
2126 io_delegate_.SetFileContents(options.InputFiles().at(1),
2127 "package foo.bar;\n"
2128 "import foo.bar.IFoo;\n"
2129 "parcelable Data { IFoo foo; }\n");
2130
Steven Moreland4e059132021-08-11 13:36:30 -07002131 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002132
2133 string content;
2134 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002135 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002136 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2137 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2138 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2139 content.clear();
2140 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2141 EXPECT_FALSE(content.empty());
2142 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002143}
2144
Andrei Homescub62afd92020-05-11 19:24:59 -07002145TEST_F(AidlTest, MultipleInputFilesRust) {
2146 Options options =
2147 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2148
2149 io_delegate_.SetFileContents(options.InputFiles().at(0),
2150 "package foo.bar;\n"
2151 "import foo.bar.Data;\n"
2152 "interface IFoo { Data getData(); }\n");
2153
2154 io_delegate_.SetFileContents(options.InputFiles().at(1),
2155 "package foo.bar;\n"
2156 "import foo.bar.IFoo;\n"
2157 "parcelable Data { IFoo foo; }\n");
2158
Steven Moreland4e059132021-08-11 13:36:30 -07002159 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002160
2161 string content;
2162 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2163 content.clear();
2164 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2165 EXPECT_FALSE(content.empty());
2166 }
2167}
2168
Devin Moore097a3ab2020-03-11 16:08:44 -07002169TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2170 const string expected_stderr =
2171 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002172 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2173 // int getInterfaceVersion() is one of the meta transactions
2174 io_delegate_.SetFileContents(options.InputFiles().front(),
2175 "package p; interface IFoo {"
2176 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002177 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002178 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002179 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2180}
Jiyong Park309668e2018-07-28 16:55:44 +09002181
Devin Moore097a3ab2020-03-11 16:08:44 -07002182TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2183 // boolean getInterfaceVersion() is not a meta transaction, but should be
2184 // prevented because return type is not part of a method signature
2185 const string expected_stderr =
2186 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2187 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002188 io_delegate_.SetFileContents(options.InputFiles().front(),
2189 "package p; interface IFoo {"
2190 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002191 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002192 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2194}
Jiyong Park309668e2018-07-28 16:55:44 +09002195
Devin Moore097a3ab2020-03-11 16:08:44 -07002196TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002197 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002198 const string expected_stderr =
2199 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2200 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002201 io_delegate_.SetFileContents(options.InputFiles().front(),
2202 "package p; interface IFoo {"
2203 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002204 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002205 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002207
2208 // this is not a meta interface method as it differs type arguments
2209 io_delegate_.SetFileContents(options.InputFiles().front(),
2210 "package p; interface IFoo {"
2211 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002212 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002213}
2214
Jooyung Hanb8a97772021-01-19 01:27:38 +09002215TEST_F(AidlTest, CheckApiForEquality) {
2216 CaptureStderr();
2217 Options options = Options::From("aidl --checkapi=equal old new");
2218
2219 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2220 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2221 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2222 "package p; interface IFoo{ @utf8InCpp String foo();}");
2223
2224 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2225 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2226}
2227
Daniel Norman85aed542019-08-21 12:01:14 -07002228TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002229 Options options = Options::From("aidl --checkapi old new");
2230 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2231 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2232 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2233 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2234
2235 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2236}
2237
Jiyong Park3656c3c2018-08-01 20:02:01 +09002238TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002239 Options options = Options::From("aidl --checkapi old new");
2240 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2241 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002242
2243 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2244}
2245
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002246TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2247 Options options = Options::From("aidl --checkapi old new");
2248 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2249 const string enum_definition = "package p; enum Enum { FOO }";
2250 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2251 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2252 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2253 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2254
2255 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2256}
2257
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002258TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2259 Options options = Options::From("aidl --checkapi old new -I import");
2260
2261 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2262 io_delegate_.SetFileContents("new/p/Foo.aidl",
2263 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2264 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2265
2266 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2267}
2268
Jooyung Han02a11be2021-02-11 13:18:06 +09002269TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2270 Options options = Options::From("aidl --checkapi=equal old new");
2271 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2272 const string enum_definition = "package p; enum Enum { FOO }";
2273 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2274 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2275 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2276 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2277 CaptureStderr();
2278 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2279 EXPECT_EQ("", GetCapturedStderr());
2280}
2281
Daniel Norman85aed542019-08-21 12:01:14 -07002282class AidlTestCompatibleChanges : public AidlTest {
2283 protected:
2284 Options options_ = Options::From("aidl --checkapi old new");
2285};
2286
2287TEST_F(AidlTestCompatibleChanges, NewType) {
2288 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2289 "package p;"
2290 "interface IFoo {"
2291 " void foo(int a);"
2292 "}");
2293 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2294 "package p;"
2295 "interface IFoo {"
2296 " void foo(int a);"
2297 "}");
2298 io_delegate_.SetFileContents("new/p/IBar.aidl",
2299 "package p;"
2300 "interface IBar {"
2301 " void bar();"
2302 "}");
2303 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2304}
2305
2306TEST_F(AidlTestCompatibleChanges, NewMethod) {
2307 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2308 "package p;"
2309 "interface IFoo {"
2310 " void foo(int a);"
2311 "}");
2312 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2313 "package p;"
2314 "interface IFoo {"
2315 " void foo(int a);"
2316 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002317 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002318 "}");
2319 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2320}
2321
2322TEST_F(AidlTestCompatibleChanges, NewField) {
2323 io_delegate_.SetFileContents("old/p/Data.aidl",
2324 "package p;"
2325 "parcelable Data {"
2326 " int foo;"
2327 "}");
2328 io_delegate_.SetFileContents("new/p/Data.aidl",
2329 "package p;"
2330 "parcelable Data {"
2331 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002332 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002333 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002334 "}");
2335 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2336}
2337
Jooyung Han05bd8a82021-04-28 23:56:38 +09002338TEST_F(AidlTestCompatibleChanges, NewField2) {
2339 io_delegate_.SetFileContents("old/p/Data.aidl",
2340 "package p;"
2341 "parcelable Data {"
2342 "}");
2343 io_delegate_.SetFileContents("new/p/Data.aidl",
2344 "package p;"
2345 "parcelable Data {"
2346 " int foo = 0;"
2347 "}");
2348 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2349}
2350
Daniel Norman85aed542019-08-21 12:01:14 -07002351TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2352 io_delegate_.SetFileContents("old/p/Enum.aidl",
2353 "package p;"
2354 "enum Enum {"
2355 " FOO = 1,"
2356 "}");
2357 io_delegate_.SetFileContents("new/p/Enum.aidl",
2358 "package p;"
2359 "enum Enum {"
2360 " FOO = 1,"
2361 " BAR = 2,"
2362 "}");
2363 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2364}
2365
2366TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2367 io_delegate_.SetFileContents("old/p/Enum.aidl",
2368 "package p;"
2369 "enum Enum {"
2370 " FOO = 1,"
2371 " BAR = 2,"
2372 "}");
2373 io_delegate_.SetFileContents("new/p/Enum.aidl",
2374 "package p;"
2375 "enum Enum {"
2376 " BAR = 2,"
2377 " FOO = 1,"
2378 "}");
2379 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2380}
2381
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002382TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2383 io_delegate_.SetFileContents("old/p/Union.aidl",
2384 "package p;"
2385 "union Union {"
2386 " String foo;"
2387 "}");
2388 io_delegate_.SetFileContents("new/p/Union.aidl",
2389 "package p;"
2390 "union Union {"
2391 " String foo;"
2392 " int num;"
2393 "}");
2394 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2395}
2396
Daniel Norman85aed542019-08-21 12:01:14 -07002397TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002398 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2399 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002400 "interface IFoo {"
2401 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002402 "}");
2403 io_delegate_.SetFileContents("old/p/Data.aidl",
2404 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002405 "parcelable Data {"
2406 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002407 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002408 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2409 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002410 "interface IFoo {"
2411 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002412 "}");
2413 io_delegate_.SetFileContents("new/p/Data.aidl",
2414 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002415 "parcelable Data {"
2416 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002417 "}");
2418 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2419 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002420 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002421 " void foo(int a);"
2422 "}");
2423 io_delegate_.SetFileContents("new/q/Data.aidl",
2424 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002425 "parcelable Data {"
2426 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002427 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002428 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2429}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002430
Daniel Norman85aed542019-08-21 12:01:14 -07002431TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2432 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2433 "package p;"
2434 "interface IFoo {"
2435 " void foo(int a);"
2436 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002437 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2438 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002439 "interface IFoo {"
2440 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002441 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002442 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2443}
Jiyong Parke59c3682018-09-11 23:10:25 +09002444
Daniel Norman85aed542019-08-21 12:01:14 -07002445TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002446 io_delegate_.SetFileContents("old/p/I.aidl",
2447 "package p; interface I {"
2448 "const int A = 1; }");
2449 io_delegate_.SetFileContents("new/p/I.aidl",
2450 "package p ; interface I {"
2451 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002452 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2453}
Jiyong Parka428d212018-08-29 22:26:30 +09002454
Daniel Norman85aed542019-08-21 12:01:14 -07002455TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002456 io_delegate_.SetFileContents("old/p/I.aidl",
2457 "package p; interface I {"
2458 "const int A = 1; const int B = 2;}");
2459 io_delegate_.SetFileContents("new/p/I.aidl",
2460 "package p ; interface I {"
2461 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002462 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002463}
2464
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002465TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2466 io_delegate_.SetFileContents("old/p/Foo.aidl",
2467 "package p;"
2468 "@JavaPassthrough(annotation=\"Alice\")"
2469 "@JavaPassthrough(annotation=\"Bob\")"
2470 "parcelable Foo {}");
2471 io_delegate_.SetFileContents("new/p/Foo.aidl",
2472 "package p;"
2473 "@JavaPassthrough(annotation=\"Bob\")"
2474 "@JavaPassthrough(annotation=\"Alice\")"
2475 "parcelable Foo {}");
2476 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2477}
2478
Jooyung Han00073272020-11-27 14:20:20 +09002479TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2480 io_delegate_.SetFileContents("old/p/Foo.aidl",
2481 "package p;"
2482 "parcelable Foo {}");
2483 io_delegate_.SetFileContents("new/p/Foo.aidl",
2484 "package p;"
2485 "@JavaPassthrough(annotation=\"@Deprecated\")"
2486 "parcelable Foo {}");
2487 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2488}
2489
Jooyung Han636fd2f2020-10-22 11:33:45 +09002490TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2491 io_delegate_.SetFileContents("old/p/Data.aidl",
2492 "package p;"
2493 "parcelable Data {"
2494 " int num;"
2495 "}");
2496 io_delegate_.SetFileContents(
2497 "new/p/Data.aidl",
2498 "package p;"
2499 "parcelable Data {"
2500 " int num;"
2501 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2502 "}");
2503 io_delegate_.SetFileContents("new/p/Enum.aidl",
2504 "package p;"
2505 "enum Enum {"
2506 " FOO = 0,"
2507 " BAR = 1,"
2508 "}");
2509 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2510}
2511
Jooyung Han308bbe02021-04-27 12:09:59 +09002512TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2513 io_delegate_.SetFileContents("old/p/Data.aidl",
2514 "package p;\n"
2515 "parcelable Data {\n"
2516 " p.Enum e;\n"
2517 "}");
2518 io_delegate_.SetFileContents("old/p/Enum.aidl",
2519 "package p;\n"
2520 "enum Enum {\n"
2521 " FOO = 0,\n"
2522 " BAR = 1,\n"
2523 "}");
2524 io_delegate_.SetFileContents("new/p/Data.aidl",
2525 "package p;\n"
2526 "parcelable Data {\n"
2527 " p.Enum e = p.Enum.FOO;\n"
2528 "}");
2529 io_delegate_.SetFileContents("new/p/Enum.aidl",
2530 "package p;\n"
2531 "enum Enum {\n"
2532 " FOO = 0,\n"
2533 " BAR = 1,\n"
2534 "}");
2535 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2536}
2537
Daniel Norman85aed542019-08-21 12:01:14 -07002538class AidlTestIncompatibleChanges : public AidlTest {
2539 protected:
2540 Options options_ = Options::From("aidl --checkapi old new");
2541};
2542
2543TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002544 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002545 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2546 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002547 "interface IFoo {"
2548 " void foo(in String[] str);"
2549 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002550 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002551 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002552 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002553 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002554}
2555
2556TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002557 const string expected_stderr =
2558 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002559 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2560 "package p;"
2561 "interface IFoo {"
2562 " void foo(in String[] str);"
2563 " void bar(@utf8InCpp String str);"
2564 "}");
2565 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2566 "package p;"
2567 "interface IFoo {"
2568 " void foo(in String[] str);"
2569 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002570 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002571 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002572 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002573}
2574
Jiyong Parkf8d53612020-05-04 14:06:13 +09002575TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2576 const string expected_stderr =
2577 "ERROR: new/p/IFoo.aidl:1.61-65: "
2578 "Encountered an untyped List or Map. The use of untyped List/Map is "
2579 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2580 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2581 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2582 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2583 "package p;"
2584 "interface IFoo {"
2585 " void foo(in String[] str);"
2586 "}");
2587 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2588 "package p;"
2589 "interface IFoo {"
2590 " void foo(in String[] str);"
2591 " void bar(in List arg);"
2592 "}");
2593 CaptureStderr();
2594 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2595 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2596}
2597
2598TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2599 const string expected_stderr =
2600 "ERROR: new/p/Data.aidl:1.54-59: "
2601 "Encountered an untyped List or Map. The use of untyped List/Map is "
2602 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2603 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2604 "ERROR: new/p/Data.aidl: Failed to read.\n";
2605 io_delegate_.SetFileContents("old/p/Data.aidl",
2606 "package p;"
2607 "parcelable Data {"
2608 " int foo;"
2609 "}");
2610 io_delegate_.SetFileContents("new/p/Data.aidl",
2611 "package p;"
2612 "parcelable Data {"
2613 " int foo;"
2614 " @nullable List list;"
2615 "}");
2616 CaptureStderr();
2617 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2618 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2619}
2620
Daniel Norman85aed542019-08-21 12:01:14 -07002621TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002622 const string expected_stderr =
2623 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002624 io_delegate_.SetFileContents("old/p/Data.aidl",
2625 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002626 "parcelable Data {"
2627 " int foo;"
2628 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002629 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002630 io_delegate_.SetFileContents("new/p/Data.aidl",
2631 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002632 "parcelable Data {"
2633 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002634 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002635 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002636 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002637 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002638}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002639
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002640TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2641 const string expected_stderr =
2642 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2643 "backends. Please either provide a default value for this field or mark the field as "
2644 "@nullable. This value or a null value will be used automatically when an old version of "
2645 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2646 "order to make sure your code continues to be backwards compatible, make sure the default or "
2647 "null value does not cause a semantic change to this parcelable.\n";
2648 io_delegate_.SetFileContents("old/p/Data.aidl",
2649 "package p;"
2650 "parcelable Data {"
2651 " int num;"
2652 "}");
2653 io_delegate_.SetFileContents("new/p/Data.aidl",
2654 "package p;"
2655 "parcelable Data {"
2656 " int num;"
2657 " String str;"
2658 "}");
2659 CaptureStderr();
2660 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2662}
2663
Jooyung Han636fd2f2020-10-22 11:33:45 +09002664TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2665 const string expected_stderr =
2666 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2667 "Please make sure 'Enum' has '0' as a valid value.\n";
2668 io_delegate_.SetFileContents("old/p/Data.aidl",
2669 "package p;"
2670 "parcelable Data {"
2671 " int num;"
2672 "}");
2673 io_delegate_.SetFileContents("new/p/Data.aidl",
2674 "package p;"
2675 "parcelable Data {"
2676 " int num;"
2677 " p.Enum e;"
2678 "}");
2679 io_delegate_.SetFileContents("new/p/Enum.aidl",
2680 "package p;"
2681 "enum Enum {"
2682 " FOO = 1,"
2683 " BAR = 2,"
2684 "}");
2685 CaptureStderr();
2686 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2687 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2688}
2689
Daniel Norman85aed542019-08-21 12:01:14 -07002690TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002691 const string expected_stderr =
2692 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002693 io_delegate_.SetFileContents("old/p/Enum.aidl",
2694 "package p;"
2695 "enum Enum {"
2696 " FOO = 1,"
2697 " BAR = 2,"
2698 "}");
2699 io_delegate_.SetFileContents("new/p/Enum.aidl",
2700 "package p;"
2701 "enum Enum {"
2702 " BAR = 2,"
2703 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002704 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002705 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002706 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002707}
2708
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002709TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2710 const string expected_stderr =
2711 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2712 io_delegate_.SetFileContents("old/p/Union.aidl",
2713 "package p;"
2714 "union Union {"
2715 " String str;"
2716 " int num;"
2717 "}");
2718 io_delegate_.SetFileContents("new/p/Union.aidl",
2719 "package p;"
2720 "union Union {"
2721 " String str;"
2722 "}");
2723 CaptureStderr();
2724 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2725 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2726}
2727
Daniel Norman85aed542019-08-21 12:01:14 -07002728TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002729 const string expected_stderr =
2730 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002731 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2732 "package p;"
2733 "interface IFoo {"
2734 " void foo(in String[] str);"
2735 " void bar(@utf8InCpp String str);"
2736 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002737 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2738 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002739 "interface IFoo {"
2740 " void foo(in String[] str);"
2741 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002742 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002743 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002744 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002746}
2747
Daniel Norman85aed542019-08-21 12:01:14 -07002748TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002749 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002750 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2751 "package p;"
2752 "interface IFoo {"
2753 " void foo(in String[] str);"
2754 " void bar(@utf8InCpp String str);"
2755 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002756 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2757 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002758 "interface IFoo2 {"
2759 " void foo(in String[] str);"
2760 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002761 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002762 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002763 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002764 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002765}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002766
Daniel Norman85aed542019-08-21 12:01:14 -07002767TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002768 const string expected_stderr =
2769 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002770 io_delegate_.SetFileContents("old/p/Enum.aidl",
2771 "package p;"
2772 "enum Enum {"
2773 " FOO = 1,"
2774 " BAR = 2,"
2775 "}");
2776 io_delegate_.SetFileContents("new/p/Enum.aidl",
2777 "package p;"
2778 "enum Enum {"
2779 " FOO = 3,"
2780 " BAR = 2,"
2781 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002782 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002783 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002784 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002785}
2786
2787TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002788 const string expected_stderr =
2789 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2790 "from 0 to 1.\n"
2791 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2792 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002793 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2794 "package p;"
2795 "interface IFoo {"
2796 " void foo(in String[] str);"
2797 " void bar(@utf8InCpp String str);"
2798 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002799 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2800 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002801 "interface IFoo {"
2802 " void bar(@utf8InCpp String str);"
2803 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002804 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002805 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002806 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002807 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002808}
2809
2810TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002811 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002812 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2813 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002814 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002815 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002816 "parcelable Data {"
2817 " int foo;"
2818 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002819 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002820 io_delegate_.SetFileContents("new/p/Data.aidl",
2821 "package p;"
2822 "parcelable Data {"
2823 " int bar;"
2824 " int foo;"
2825 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002826 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002827 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002828 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002829}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002830
Daniel Norman85aed542019-08-21 12:01:14 -07002831TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002832 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002833 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002834 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002835 "interface IFoo {"
2836 " void foo(in String[] str);"
2837 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002838 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002839 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2840 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002841 "interface IFoo {"
2842 " void foo(out String[] str);"
2843 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002844 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002845 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002846 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002847 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002848}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002849
Daniel Norman85aed542019-08-21 12:01:14 -07002850TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002851 const string expected_stderr =
2852 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002853 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2854 "package p;"
2855 "interface IFoo {"
2856 " void foo(in String[] str);"
2857 " void bar(@utf8InCpp String str);"
2858 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002859 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2860 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002861 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002862 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002863 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002864 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002865 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002866 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002868}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002869
Daniel Norman85aed542019-08-21 12:01:14 -07002870TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002871 const string expected_stderr =
2872 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002873 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2874 "package p;"
2875 "interface IFoo {"
2876 " void foo(in String[] str);"
2877 " void bar(@utf8InCpp String str);"
2878 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002879 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2880 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002881 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002882 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002883 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002884 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002885 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002886 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002887 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002888}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002889
Jooyung Han60b2fde2020-10-29 15:12:40 +09002890TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2891 const string expected_stderr =
2892 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2893 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2894 io_delegate_.SetFileContents("old/p/Foo.aidl",
2895 "package p;"
2896 "@Backing(type=\"byte\")"
2897 "enum Foo {"
2898 " FOO, BAR,"
2899 "}");
2900 io_delegate_.SetFileContents("new/p/Foo.aidl",
2901 "package p;"
2902 "@Backing(type=\"long\")"
2903 "enum Foo {"
2904 " FOO, BAR,"
2905 "}");
2906 CaptureStderr();
2907 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2908 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2909}
2910
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002911TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2912 const string expected_stderr =
2913 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2914 "to @JavaPassthrough(annotation=\"Bob\")\n";
2915 io_delegate_.SetFileContents("old/p/Foo.aidl",
2916 "package p;"
2917 "@JavaPassthrough(annotation=\"Alice\")"
2918 "parcelable Foo {}");
2919 io_delegate_.SetFileContents("new/p/Foo.aidl",
2920 "package p;"
2921 "@JavaPassthrough(annotation=\"Bob\")"
2922 "parcelable Foo {}");
2923
2924 CaptureStderr();
2925 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2926 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2927}
2928
Devin Mooredb7ac512020-08-07 11:17:36 -07002929TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2930 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002931 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002932 io_delegate_.SetFileContents("old/p/Foo.aidl",
2933 "package p;"
2934 "parcelable Foo {"
2935 " int A;"
2936 "}");
2937 io_delegate_.SetFileContents("new/p/Foo.aidl",
2938 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002939 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002940 " int A;"
2941 "}");
2942 CaptureStderr();
2943 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2944 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2945}
2946
2947TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2948 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002949 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002950 io_delegate_.SetFileContents("old/p/Foo.aidl",
2951 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002952 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002953 " int A;"
2954 "}");
2955 io_delegate_.SetFileContents("new/p/Foo.aidl",
2956 "package p;"
2957 "parcelable Foo {"
2958 " int A;"
2959 "}");
2960 CaptureStderr();
2961 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2962 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2963}
2964
Daniel Norman85aed542019-08-21 12:01:14 -07002965TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002966 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002967 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2968 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002969 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002970 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002971 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002972 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002973}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002974
Daniel Norman85aed542019-08-21 12:01:14 -07002975TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002976 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002977 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2978 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002979 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002980 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002981 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002982}
Jiyong Parka428d212018-08-29 22:26:30 +09002983
Daniel Norman85aed542019-08-21 12:01:14 -07002984TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002985 const string expected_stderr =
2986 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002987 io_delegate_.SetFileContents("old/p/I.aidl",
2988 "package p; interface I {"
2989 "const int A = 1; const int B = 2;}");
2990 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002991 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002992 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002994}
Jiyong Parka428d212018-08-29 22:26:30 +09002995
Daniel Norman85aed542019-08-21 12:01:14 -07002996TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002997 const string expected_stderr =
2998 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002999 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3000 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003001 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003002 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003004}
3005
Devin Moorec7e47a32020-08-07 10:55:25 -07003006TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3007 const string expected_stderr =
3008 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3009 "This is an incompatible change for FixedSize types.\n";
3010 io_delegate_.SetFileContents("old/p/Foo.aidl",
3011 "package p; @FixedSize parcelable Foo { int A = 1; }");
3012 io_delegate_.SetFileContents("new/p/Foo.aidl",
3013 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3014 CaptureStderr();
3015 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3017}
3018
Jeongik Cha68d18e72021-04-29 20:07:01 +09003019TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3020 const string expected_stderr =
3021 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3022 "android.net.UidRangeParcel is changed from 1 to 2. "
3023 "But it is forbidden because of legacy support.\n";
3024 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3025 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3026 io_delegate_.SetFileContents(
3027 "new/android/net/UidRangeParcel.aidl",
3028 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3029 CaptureStderr();
3030 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3031 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3032}
3033
Devin Moorec7e47a32020-08-07 10:55:25 -07003034TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3035 const string expected_stderr =
3036 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3037 io_delegate_.SetFileContents("old/p/Foo.aidl",
3038 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3039 io_delegate_.SetFileContents("new/p/Foo.aidl",
3040 "package p; @FixedSize parcelable Foo { int A = 1; }");
3041 CaptureStderr();
3042 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3043 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3044}
3045
3046TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3047 const string expected_stderr =
3048 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3049 "a.\n"
3050 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3051 "b.\n"
3052 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3053 "c.\n"
3054 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3055 "d.\n"
3056 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3057 "e.\n"
3058 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3059 "f.\n";
3060
3061 io_delegate_.SetFileContents("Foo.aidl",
3062 "@FixedSize parcelable Foo { "
3063 " int[] a;"
3064 " Bar b;"
3065 " String c;"
3066 " ParcelFileDescriptor d;"
3067 " IBinder e;"
3068 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00003069 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07003070 "}");
3071 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003072 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003073
3074 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003075 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3077}
3078
3079TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3080 const string expected_stderr = "";
3081
3082 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3083 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3084 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003085 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003086
3087 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003088 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3090}
3091
Jiyong Park8c380532018-08-30 14:55:26 +09003092TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003093 const string expected_stderr =
3094 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3095 "dir1/q/IBar.aidl\n"
3096 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003097 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003098 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3099 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3100 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3101 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3102
Devin Moore097a3ab2020-03-11 16:08:44 -07003103 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003104 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003106}
3107
Jiyong Parked65bf42018-08-28 15:43:27 +09003108TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003109 const string expected_stderr =
3110 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3111 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003112 Options options = Options::From("aidl --checkapi old new");
3113 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3114 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003115
3116 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3117
Jiyong Parke59c3682018-09-11 23:10:25 +09003118 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003119 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003120 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003121 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003122}
3123
Jooyung Han652ce482021-02-26 12:40:35 +09003124TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3125 Options options =
3126 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003127
3128 // use without import
3129 io_delegate_.SetFileContents("p/IFoo.aidl",
3130 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003131 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003132
3133 // capture output files
3134 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003135
Devin Moore7b8d5c92020-03-17 14:14:08 -07003136 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003137 io_delegate_.SetFileContents(
3138 "p/IFoo.aidl",
3139 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003140 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003141 // output files should be the same
3142 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003143
3144 // use with import (as before)
3145 io_delegate_.SetFileContents("p/IFoo.aidl",
3146 "package p;"
3147 "import android.os.ParcelFileDescriptor;"
3148 "interface IFoo{"
3149 " void foo(in ParcelFileDescriptor fd);"
3150 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003151 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003152 // output files should be the same
3153 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003154}
Jiyong Parked65bf42018-08-28 15:43:27 +09003155
Jooyung Han020d8d12021-02-26 17:23:02 +09003156TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3157 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3158 CaptureStderr();
3159 io_delegate_.SetFileContents("p/IFoo.aidl",
3160 "package p;"
3161 "interface IFoo{"
3162 " void foo(out ParcelFileDescriptor fd);"
3163 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003164 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003165 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3166}
3167
3168TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3169 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3170 CaptureStderr();
3171 io_delegate_.SetFileContents("p/IFoo.aidl",
3172 "package p;"
3173 "interface IFoo{"
3174 " void foo(ParcelFileDescriptor fd);"
3175 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003176 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003177 EXPECT_THAT(GetCapturedStderr(),
3178 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3179}
3180
Jiyong Park3633b722019-04-11 15:38:26 +09003181TEST_F(AidlTest, ManualIds) {
3182 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3183 io_delegate_.SetFileContents("IFoo.aidl",
3184 "interface IFoo {\n"
3185 " void foo() = 0;\n"
3186 " void bar() = 1;\n"
3187 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003188 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003189}
3190
3191TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3192 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3193 io_delegate_.SetFileContents("IFoo.aidl",
3194 "interface IFoo {\n"
3195 " void foo() = 0;\n"
3196 " void bar() = 1;\n"
3197 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003198 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003199}
3200
3201TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003202 const string expected_stderr =
3203 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003204 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3205 io_delegate_.SetFileContents("IFoo.aidl",
3206 "interface IFoo {\n"
3207 " void foo() = 3;\n"
3208 " void bar() = 3;\n"
3209 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003210 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003211 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003212 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003213}
3214
3215TEST_F(AidlTest, FailOnOutOfRangeIds) {
3216 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003217 const string expected_stderr =
3218 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3219 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003220 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3221 io_delegate_.SetFileContents("IFoo.aidl",
3222 "interface IFoo {\n"
3223 " void foo() = 3;\n"
3224 " void bar() = 16777115;\n"
3225 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003226 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003227 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003229}
3230
3231TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003232 const string expected_stderr =
3233 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003234 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3235 io_delegate_.SetFileContents("IFoo.aidl",
3236 "interface IFoo {\n"
3237 " void foo() = 3;\n"
3238 " void bar();\n"
3239 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003240 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003241 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003243}
3244
Jiyong Parkc6816252019-07-08 08:12:28 +09003245TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3246 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3247 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3248 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003249 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003250}
3251
3252TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003253 const string expected_stderr =
3254 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3255 "dir/IBar.aidl\n"
3256 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003257 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003258
Jiyong Parkc6816252019-07-08 08:12:28 +09003259 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3260 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3261 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3262 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003263 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003264 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003266}
3267
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003268TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3269 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3270 "package a.b;\n"
3271 "import a.b.IBar;\n"
3272 "import a.b.IQux;\n"
3273 "interface IFoo { IQux foo(); }\n");
3274 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3275 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3276
3277 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003278 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003279
3280 string output;
3281 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3282 // IBar was imported but wasn't used. include is not expected.
3283 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3284 // IBar was imported and used. include is expected.
3285 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3286}
3287
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003288TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003289 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003290 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003291 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3292 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003293 interface IFoo {
3294 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003295 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003296 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003297 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003298 // JavaPassthrough should work with other types as well (e.g. enum)
3299 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3300 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3301 @JavaPassthrough(annotation="@com.android.AliceTwo")
3302 @Backing(type="byte")
3303 enum MyEnum {
3304 a, b, c
3305 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003306
Jooyung Han4cde01d2020-10-13 11:10:47 +09003307 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003308 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003309
3310 string java_out;
3311 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003312 // type-decl-level annotations with newline at the end
3313 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3314 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3315 // member-decl-level annotations with newline at the end
3316 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3317 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3318 // inline annotations with space at the end
3319 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003320
Jooyung Han4cde01d2020-10-13 11:10:47 +09003321 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3322 // type-decl-level annotations with newline at the end
3323 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3324 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3325
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003326 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003327 Options cpp_options =
3328 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003329 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003330
Jooyung Han4cde01d2020-10-13 11:10:47 +09003331 Options ndk_options =
3332 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003333 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003334
Jooyung Han4cde01d2020-10-13 11:10:47 +09003335 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003336 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003337}
3338
Andrei Homescue61feb52020-08-18 15:44:24 -07003339TEST_F(AidlTest, ParseRustDerive) {
3340 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3341 @RustDerive(Clone=true, Copy=false)
3342 parcelable Foo {
3343 int a;
3344 })");
3345
3346 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003347 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003348
3349 string rust_out;
3350 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3351 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3352
3353 // Other backends shouldn't be bothered
3354 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003355 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003356
3357 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003358 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003359
3360 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003361 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003362}
3363
Jiyong Park56f73d72019-06-11 12:20:28 +09003364class AidlOutputPathTest : public AidlTest {
3365 protected:
3366 void SetUp() override {
3367 AidlTest::SetUp();
3368 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3369 }
3370
3371 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003372 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003373 // check the existence
3374 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3375 }
3376};
3377
3378TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3379 // <out_dir> / <package_name> / <type_name>.java
3380 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3381}
3382
3383TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3384 // when output file is explicitly set, it is always respected. -o option is
3385 // ignored.
3386 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3387}
3388
3389TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3390 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3391}
3392
3393TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3394 // output is the same as the input file except for the suffix
3395 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3396}
3397
Devin Moore7b8d5c92020-03-17 14:14:08 -07003398TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003399 AidlError error;
3400 const string expected_stderr =
3401 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3402 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003403 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3404 R"(package p;
3405 interface IFoo {
3406 const int int32_max_oob = 2147483650;
3407 }
3408 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003409 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3411 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003412}
3413
Devin Moore7b8d5c92020-03-17 14:14:08 -07003414TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003415 AidlError error;
3416 const string expected_stderr =
3417 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3418 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003419 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3420 R"(package p;
3421 interface IFoo {
3422 const int int32_min_oob = -2147483650;
3423 }
3424 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003425 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3427 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003428}
3429
Devin Moore7b8d5c92020-03-17 14:14:08 -07003430TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003431 AidlError error;
3432 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003433 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003434 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003435 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3436 R"(package p;
3437 interface IFoo {
3438 const long int64_max_oob = 21474836509999999999999999;
3439 }
3440 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003441 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3443 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003444}
3445
Devin Moore7b8d5c92020-03-17 14:14:08 -07003446TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003447 AidlError error;
3448 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003449 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003450 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003451 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3452 R"(package p;
3453 interface IFoo {
3454 const long int64_min_oob = -21474836509999999999999999;
3455 }
3456 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003457 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3459 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003460}
3461
Devin Moore7b8d5c92020-03-17 14:14:08 -07003462TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003463 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003464 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003465 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003466 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3467 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003468 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3469 R"(package p;
3470 @Backing(type="byte")
3471 enum TestEnum {
3472 FOO = 127,
3473 BAR,
3474 }
3475 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003476 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003477 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003478 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003479}
3480
Devin Mooredecaf292020-04-30 09:16:40 -07003481TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3482 AidlError error;
3483 const string expected_stderr =
3484 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003485 "be one of: type\n";
3486 CaptureStderr();
3487 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3488 R"(package p;
3489 @Backing(foo="byte")
3490 enum TestEnum {
3491 FOO = 1,
3492 BAR,
3493 }
3494 )",
3495 typenames_, GetLanguage(), &error));
3496 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3497 EXPECT_EQ(AidlError::BAD_TYPE, error);
3498}
3499
Jooyung Han5721a232020-12-24 04:34:55 +09003500TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3501 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3502 CaptureStderr();
3503 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3504 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3505}
3506
Jooyung Han66813932020-10-23 13:24:44 +09003507TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003508 io_delegate_.SetFileContents("Foo.aidl",
3509 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3510 "Map<String, Baz> d; Bar[] e; }");
3511 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3512 io_delegate_.SetFileContents("Baz.aidl",
3513 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003514 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003515 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003516}
3517
Jooyung Han66813932020-10-23 13:24:44 +09003518TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003519 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003520 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003521 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003522 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3523 "named 'bar'.\n";
3524 CaptureStderr();
3525 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003526 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003527 EXPECT_EQ(expected_error, GetCapturedStderr());
3528}
3529
Jooyung Han09e551c2021-05-11 11:44:48 +09003530TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3531 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3532 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3533 CaptureStderr();
3534 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003535 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003536 EXPECT_EQ("", GetCapturedStderr());
3537}
3538
Jooyung Han59af9cc2020-10-25 21:44:14 +09003539TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3540 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3541 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3542 string expected_error =
3543 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003544 "named 'bar'.\n";
3545 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003546 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003547 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003548 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003549}
3550
Jooyung Han66813932020-10-23 13:24:44 +09003551TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003552 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003553 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3554 string expected_error =
3555 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3556 "only be an in parameter.\n";
3557 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003558 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003559 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003560 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003561}
3562
Jooyung Han66813932020-10-23 13:24:44 +09003563TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003564 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003565 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3566 string expected_error =
3567 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3568 "only be an in parameter.\n";
3569 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003570 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003571 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003572 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003573}
3574
Jooyung Han66813932020-10-23 13:24:44 +09003575TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003576 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003577 Options options = Options::From("aidl --lang=java Foo.aidl");
3578 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003579 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3580 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003581 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003582 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003583 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3584}
Devin Moore53fc99c2020-08-12 08:07:52 -07003585
Jooyung Hanfe086af2021-01-16 03:44:47 +09003586TEST_P(AidlTest, UnionInUnion) {
3587 import_paths_.insert(".");
3588 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3589 CaptureStderr();
3590 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3591 EXPECT_THAT("", GetCapturedStderr());
3592}
3593
Jooyung Hanfe89f122020-10-14 03:49:18 +09003594TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3595 const string method = "package a; union Foo {}";
3596 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3597 CaptureStderr();
3598 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3599 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3600}
3601
3602TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3603 const string method = "package a; union Foo { ParcelableHolder x; }";
3604 const string expected_stderr =
3605 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3606 CaptureStderr();
3607 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3608 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3609}
3610
Jooyung Han53fb4242020-12-17 16:03:49 +09003611TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3612 import_paths_.insert(".");
3613 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3614 const string expected_err = "The union's first member should have a useful default value.";
3615 CaptureStderr();
3616 EXPECT_EQ(nullptr,
3617 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3618 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3619}
3620
Devin Moore53fc99c2020-08-12 08:07:52 -07003621TEST_P(AidlTest, GenericStructuredParcelable) {
3622 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003623 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003624 const string expected_stderr = "";
3625 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003626 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003627 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3628}
3629
Jooyung Han3f347ca2020-12-01 12:41:50 +09003630TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3631 io_delegate_.SetFileContents("Foo.aidl",
3632 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3633 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003634 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003635 const string expected_stderr = "";
3636 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003637 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003638 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3639
3640 string code;
3641 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3642 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3643const ::android::String16& Foo<T,U>::s() {
3644 static const ::android::String16 value(::android::String16(""));
3645 return value;
3646})--"));
3647}
3648
3649TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3650 io_delegate_.SetFileContents("Foo.aidl",
3651 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3652 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003653 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003654 const string expected_stderr = "";
3655 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003656 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3658
3659 string code;
3660 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3661 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3662const char* Foo<T, U>::s = "";
3663)--"));
3664}
3665
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003666TEST_F(AidlTest, NestedTypeArgs) {
3667 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003668 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3669
3670 io_delegate_.SetFileContents("a/Foo.aidl",
3671 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3672 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003673 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3674 const string expected_stderr = "";
3675 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003676 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003677 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3678
3679 string code;
3680 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003681 EXPECT_THAT(code,
3682 testing::HasSubstr(
3683 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3684}
3685
3686TEST_F(AidlTest, DoubleArrayError) {
3687 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3688
3689 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3690 const string expected_stderr =
3691 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3692 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003693 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003694 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3695}
3696
3697TEST_F(AidlTest, DoubleGenericError) {
3698 io_delegate_.SetFileContents("a/Bar.aidl",
3699 "package a; parcelable Bar { List<String><String> a; }");
3700
3701 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3702 const string expected_stderr =
3703 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3704 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003705 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003706 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3707}
3708
3709TEST_F(AidlTest, ArrayBeforeGenericError) {
3710 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3711
3712 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003713 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003714 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003715 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3716}
3717
3718TEST_F(AidlTest, NullableArraysAreNotSupported) {
3719 io_delegate_.SetFileContents("a/Bar.aidl",
3720 "package a; parcelable Bar { String @nullable [] a; }");
3721
3722 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3723 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003724 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003725 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3726}
3727
3728TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3729 io_delegate_.SetFileContents("a/Bar.aidl",
3730 "package a; parcelable Bar { List<@nullable String> a; }");
3731
3732 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3733 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003734 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003735 EXPECT_THAT(GetCapturedStderr(),
3736 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003737}
3738
Jooyung Han14004ed2020-10-16 03:49:57 +09003739struct GenericAidlTest : ::testing::Test {
3740 FakeIoDelegate io_delegate_;
3741 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003742 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003743 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3744 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3745 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3746
3747 Options options = Options::From(cmd);
3748 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003749 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09003750 EXPECT_EQ("", GetCapturedStderr());
3751 }
3752};
3753
3754TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3755 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3756 string code;
3757 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3758 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3759 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3760 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3761}
3762
3763TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3764 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3765 string code;
3766 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3767 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3768 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3769 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3770}
3771
Devin Moore53fc99c2020-08-12 08:07:52 -07003772TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3773 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003774 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003775 const string expected_stderr =
3776 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3777 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003778 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003779 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3780}
3781
3782TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3783 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003784 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003785 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3786 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003787 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003788 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3789}
3790
Jooyung Han7a308842020-10-27 19:06:49 +09003791TEST_P(AidlTest, LongCommentWithinConstExpression) {
3792 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003793 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003794 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003795 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09003796 EXPECT_EQ("", GetCapturedStderr());
3797}
3798
Jeongik Chaef44e622020-10-23 16:00:52 +09003799TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3800 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3801 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3802 std::string expectedErr =
3803 "ERROR: a/Foo.aidl:1.28-30: "
3804 "Encountered an untyped List or Map. The use of untyped List/Map is "
3805 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3806 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3807 "ERROR: a/Foo.aidl:1.35-37: "
3808 "Encountered an untyped List or Map. The use of untyped List/Map is "
3809 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3810 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3811 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003812 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003813 EXPECT_EQ(expectedErr, GetCapturedStderr());
3814}
3815
3816TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003817 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3818 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003819 std::string expectedErr =
3820 "ERROR: a/Foo.aidl:1.33-35: "
3821 "Encountered an untyped List or Map. The use of untyped List/Map is "
3822 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3823 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3824 "ERROR: a/Foo.aidl:1.40-42: "
3825 "Encountered an untyped List or Map. The use of untyped List/Map is "
3826 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3827 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003828 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003829 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003830 EXPECT_EQ(expectedErr, GetCapturedStderr());
3831}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003832
Jeongik Chaef44e622020-10-23 16:00:52 +09003833TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3834 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3835 io_delegate_.SetFileContents(
3836 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3837 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3838 std::string expectedErr =
3839 "ERROR: a/Foo.aidl:1.52-54: "
3840 "Encountered an untyped List or Map. The use of untyped List/Map is "
3841 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3842 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3843 "ERROR: a/Foo.aidl:1.64-66: "
3844 "Encountered an untyped List or Map. The use of untyped List/Map is "
3845 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3846 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3847 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003848 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003849 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003850}
3851
Jooyung Han690f5842020-12-04 13:02:04 +09003852TEST_F(AidlTest, EnumWithDefaults_Java) {
3853 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3854 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3855package p;
3856import p.Enum;
3857parcelable Foo {
3858 Enum e = Enum.BAR;
3859})");
3860 CaptureStderr();
3861 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003862 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003863 auto err = GetCapturedStderr();
3864 EXPECT_EQ("", err);
3865
3866 string code;
3867 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003868 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003869}
3870
3871TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3872 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3873 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3874package p;
3875import p.Enum;
3876parcelable Foo {
3877 Enum e = Enum.BAR;
3878})");
3879 CaptureStderr();
3880 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003881 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003882 auto err = GetCapturedStderr();
3883 EXPECT_EQ("", err);
3884
3885 string code;
3886 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3887 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3888}
3889
3890TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3891 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3892 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3893package p;
3894import p.Enum;
3895parcelable Foo {
3896 Enum e = Enum.BAR;
3897})");
3898 CaptureStderr();
3899 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003900 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003901 auto err = GetCapturedStderr();
3902 EXPECT_EQ("", err);
3903
3904 string code;
3905 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3906 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3907}
3908
3909TEST_F(AidlTest, EnumWithDefaults_Rust) {
3910 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3911 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3912package p;
3913import p.Enum;
3914parcelable Foo {
3915 int n = 42;
3916 Enum e = Enum.BAR;
3917})");
3918 CaptureStderr();
3919 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003920 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003921 auto err = GetCapturedStderr();
3922 EXPECT_EQ("", err);
3923
3924 string code;
3925 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3926 EXPECT_THAT(code, testing::HasSubstr(R"(
3927 fn default() -> Self {
3928 Self {
3929 n: 42,
3930 e: crate::mangled::_1_p_4_Enum::BAR,
3931 }
3932 })"));
3933}
3934
3935TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
3936 import_paths_.insert("a");
3937 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3938 CaptureStderr();
3939 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3940package p;
3941import p.Enum;
3942parcelable Foo {
3943 int e = Enum.FOO | Enum.BAR;
3944})",
3945 typenames_, GetLanguage());
3946 auto err = GetCapturedStderr();
3947 EXPECT_EQ("", err);
3948 EXPECT_TRUE(type);
3949 const auto& fields = type->AsStructuredParcelable()->GetFields();
3950 EXPECT_EQ("int e = 3", fields[0]->ToString());
3951}
3952
3953TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
3954 CaptureStderr();
3955 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
3956@Backing(type="int")
3957enum Foo {
3958 STANDARD_SHIFT = 16,
3959 STANDARD_BT709 = 1 << STANDARD_SHIFT,
3960 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
3961}
3962)",
3963 typenames_, GetLanguage());
3964 auto err = GetCapturedStderr();
3965 EXPECT_EQ("", err);
3966 EXPECT_TRUE(type);
3967 const auto& enum_type = type->AsEnumDeclaration();
3968 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09003969 auto writer = CodeWriter::ForString(&code);
3970 DumpVisitor visitor(*writer);
3971 visitor.Visit(*enum_type);
3972 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09003973 EXPECT_EQ(R"--(@Backing(type="int")
3974enum Foo {
3975 STANDARD_SHIFT = 16,
3976 STANDARD_BT709 = 65536,
3977 STANDARD_BT601_625 = 131072,
3978}
3979)--",
3980 code);
3981}
3982
3983TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
3984 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
3985 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3986package p;
3987import p.Enum;
3988parcelable Foo {
3989 Enum e = Enum.FOO | Enum.BAR;
3990})");
3991 CaptureStderr();
3992 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003993 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003994 auto err = GetCapturedStderr();
3995 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
3996 err);
3997}
3998
Jooyung Han361cd102021-05-24 11:30:10 +09003999TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4000 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4001 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4002package p;
4003import p.Enum;
4004parcelable Foo {
4005 Enum e = 1;
4006})");
4007 CaptureStderr();
4008 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004009 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004010 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4011}
4012
Jooyung Han690f5842020-12-04 13:02:04 +09004013TEST_P(AidlTest, DefaultWithEmptyArray) {
4014 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4015 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4016 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004017 auto options =
4018 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004019 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004020 auto err = GetCapturedStderr();
4021 EXPECT_EQ("", err);
4022}
4023
4024TEST_P(AidlTest, RejectRefsInAnnotation) {
4025 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4026 "package p; interface IFoo {\n"
4027 " const String ANNOTATION = \"@Annotation\";\n"
4028 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4029 "}");
4030 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004031 auto options =
4032 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004033 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004034 auto err = GetCapturedStderr();
4035 EXPECT_EQ(
4036 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4037 "ANNOTATION.\n",
4038 err);
4039}
4040
4041TEST_F(AidlTest, DefaultWithEnumValues) {
4042 io_delegate_.SetFileContents(
4043 "a/p/Foo.aidl",
4044 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4045 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4046 CaptureStderr();
4047 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004048 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004049 auto err = GetCapturedStderr();
4050 EXPECT_EQ("", err);
4051 string code;
4052 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4053 EXPECT_THAT(
4054 code, testing::HasSubstr(
4055 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4056}
4057
Jooyung Han14259392020-12-07 10:00:08 +09004058TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4059 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4060 CaptureStderr();
4061 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004062 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004063 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004064 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004065}
4066
4067TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4068 io_delegate_.SetFileContents("a/p/Foo.aidl",
4069 "package p; parcelable Foo { const int A = A + 1; }");
4070 CaptureStderr();
4071 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004072 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004073 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004074 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4075}
4076
4077TEST_F(AidlTest, RecursiveReferences) {
4078 io_delegate_.SetFileContents("a/p/Foo.aidl",
4079 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4080 io_delegate_.SetFileContents("a/p/Bar.aidl",
4081 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4082 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4083 CaptureStderr();
4084 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004085 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004086 EXPECT_EQ("", GetCapturedStderr());
4087}
4088
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004089TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4090 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4091 auto options =
4092 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4093 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4094 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004095 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004096 EXPECT_EQ(err, GetCapturedStderr());
4097}
4098
4099TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4100 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4101 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4102 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4103 auto options =
4104 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4105 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004106 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004107 EXPECT_EQ("", GetCapturedStderr());
4108}
4109
Jooyung Hane9f5b272021-01-07 00:18:11 +09004110TEST_P(AidlTest, UnknownConstReference) {
4111 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4112 auto options =
4113 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4114 const string err =
4115 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4116 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4117 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4118 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004119 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004120 EXPECT_EQ(err, GetCapturedStderr());
4121}
4122
Jooyung Han29813842020-12-08 01:28:03 +09004123TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4124 string contents = R"(
4125import android.os.IBinder;
4126import android.os.IInterface;
4127interface IFoo {}
4128 )";
4129 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004130}
4131
Jooyung Han888c5bc2020-12-22 17:28:47 +09004132TEST_P(AidlTest, WarningInterfaceName) {
4133 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004134 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004135 " -Weverything -o out -h out p/Foo.aidl");
4136 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004137 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004138 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004139 GetCapturedStderr());
4140}
4141
4142TEST_P(AidlTest, ErrorInterfaceName) {
4143 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004144 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004145 " -Weverything -Werror -o out -h out p/Foo.aidl");
4146 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004147 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004148 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004149 GetCapturedStderr());
4150}
4151
Jiyong Park9f4c3822021-04-07 20:36:45 +09004152TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4153 const std::string input_file = "base/p/q/IFoo.aidl";
4154 const std::string header_dir = "out/";
4155 const std::string output_file = "out/base/p/q/IFoo.cpp";
4156 const std::string package = "p.q"; // not base.p.q
4157 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4158
4159 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4160 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004161 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004162 EXPECT_THAT(
4163 GetCapturedStderr(),
4164 testing::StartsWith(
4165 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4166 "but is out/base/p/q/IFoo.cpp."));
4167}
4168
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004169TEST_F(AidlTest, FormatCommentsForJava) {
4170 using android::aidl::FormatCommentsForJava;
4171
4172 struct TestCase {
4173 vector<Comment> comments;
4174 string formatted;
4175 };
4176 vector<TestCase> testcases = {
4177 {{}, ""},
4178 {{{"// line comments\n"}}, "// line comments\n"},
4179 {{{"// @hide \n"}}, "// @hide \n"},
4180 // Transform the last block comment as Javadoc.
4181 {{{"/*\n"
4182 " * Hello, world!\n"
4183 " */"}},
4184 "/**\n"
4185 " * Hello, world!\n"
4186 " */"},
4187 {{{"/* @hide */"}}, "/** @hide */"},
4188 {{{"/**\n"
4189 " @param foo ...\n"
4190 "*/"}},
4191 "/**\n"
4192 " @param foo ...\n"
4193 "*/"},
4194 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4195 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4196 "/* @deprecated first *//** @deprecated second */"},
4197 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4198 // Line comments are printed as they are
4199 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4200 };
4201 for (const auto& [input, formatted] : testcases) {
4202 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4203 }
4204}
4205
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004206TEST_F(AidlTest, HideIsNotForArgs) {
4207 io_delegate_.SetFileContents("IFoo.aidl",
4208 "interface IFoo {\n"
4209 " void foo(in @Hide int x);\n"
4210 "}");
4211 auto options = Options::From("aidl --lang=java IFoo.aidl");
4212 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004213 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004214 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4215}
4216
4217TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4218 io_delegate_.SetFileContents(
4219 "IFoo.aidl",
4220 "interface IFoo {\n"
4221 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4222 "}");
4223 auto options = Options::From("aidl --lang=java IFoo.aidl");
4224 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004225 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004226 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4227}
4228
Jooyung Hanfa181932021-06-12 07:56:53 +09004229TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4230 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4231 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4232 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004233 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004234 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4235}
4236
Jooyung Hanfd3be322020-12-13 09:11:06 +09004237struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004238 string kind;
4239 string literal;
4240};
4241
Jooyung Hanfd3be322020-12-13 09:11:06 +09004242const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004243 {"primitive", "int"}, {"primitiveArray", "int[]"},
4244 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004245 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4246 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4247 {"union", "a.Union"}, {"interface", "a.IBar"},
4248};
4249
4250const std::map<std::string, std::string> kListSupportExpectations = {
4251 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4252 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4253 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4254 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004255 {"cpp_primitiveArray", "List of arrays is not supported."},
4256 {"java_primitiveArray", "List of arrays is not supported."},
4257 {"ndk_primitiveArray", "List of arrays is not supported."},
4258 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004259 {"cpp_String", ""},
4260 {"java_String", ""},
4261 {"ndk_String", ""},
4262 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004263 {"cpp_StringArray", "List of arrays is not supported."},
4264 {"java_StringArray", "List of arrays is not supported."},
4265 {"ndk_StringArray", "List of arrays is not supported."},
4266 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004267 {"cpp_IBinder", ""},
4268 {"java_IBinder", ""},
4269 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4270 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004271 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004272 {"java_ParcelFileDescriptor", ""},
4273 {"ndk_ParcelFileDescriptor", ""},
4274 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004275 {"cpp_interface", "List<a.IBar> is not supported."},
4276 {"java_interface", "List<a.IBar> is not supported."},
4277 {"ndk_interface", "List<a.IBar> is not supported."},
4278 {"rust_interface", "List<a.IBar> is not supported."},
4279 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004280 {"java_parcelable", ""},
4281 {"ndk_parcelable", ""},
4282 {"rust_parcelable", ""},
4283 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4284 {"java_enum", "A generic type cannot have any primitive type parameters."},
4285 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4286 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004287 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004288 {"java_union", ""},
4289 {"ndk_union", ""},
4290 {"rust_union", ""},
4291};
4292
Jooyung Hand236e552020-12-13 09:21:27 +09004293const std::map<std::string, std::string> kArraySupportExpectations = {
4294 {"cpp_primitive", ""},
4295 {"java_primitive", ""},
4296 {"ndk_primitive", ""},
4297 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004298 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4299 {"java_primitiveArray", "Can only have one dimensional arrays."},
4300 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4301 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004302 {"cpp_String", ""},
4303 {"java_String", ""},
4304 {"ndk_String", ""},
4305 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004306 {"cpp_StringArray", "Can only have one dimensional arrays."},
4307 {"java_StringArray", "Can only have one dimensional arrays."},
4308 {"ndk_StringArray", "Can only have one dimensional arrays."},
4309 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004310 {"cpp_IBinder", ""},
4311 {"java_IBinder", ""},
4312 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4313 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4314 {"cpp_ParcelFileDescriptor", ""},
4315 {"java_ParcelFileDescriptor", ""},
4316 {"ndk_ParcelFileDescriptor", ""},
4317 {"rust_ParcelFileDescriptor", ""},
4318 {"cpp_interface", "Binder type cannot be an array"},
4319 {"java_interface", "Binder type cannot be an array"},
4320 {"ndk_interface", "Binder type cannot be an array"},
4321 {"rust_interface", "Binder type cannot be an array"},
4322 {"cpp_parcelable", ""},
4323 {"java_parcelable", ""},
4324 {"ndk_parcelable", ""},
4325 {"rust_parcelable", ""},
4326 {"cpp_enum", ""},
4327 {"java_enum", ""},
4328 {"ndk_enum", ""},
4329 {"rust_enum", ""},
4330 {"cpp_union", ""},
4331 {"java_union", ""},
4332 {"ndk_union", ""},
4333 {"rust_union", ""},
4334};
4335
Jooyung Hanfd3be322020-12-13 09:11:06 +09004336class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004337 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004338 void Run(const std::string& generic_type_decl,
4339 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004340 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004341 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004342 const auto& kind = std::get<1>(param).kind;
4343
4344 FakeIoDelegate io;
4345 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4346 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4347 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004348 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4349 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004350
4351 const auto options =
4352 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4353 CaptureStderr();
4354 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004355 auto it = expectations.find(lang + "_" + kind);
4356 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004357 const string err = GetCapturedStderr();
4358 if (it->second.empty()) {
4359 EXPECT_EQ("", err);
4360 } else {
4361 EXPECT_THAT(err, testing::HasSubstr(it->second));
4362 }
4363 }
4364};
4365
4366INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004367 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004368 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4369 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004370 testing::ValuesIn(kTypeParams)),
4371 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004372 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004373 });
4374
Jooyung Hanfd3be322020-12-13 09:11:06 +09004375TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4376 Run("List<{}>", kListSupportExpectations);
4377}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004378
Jooyung Hand236e552020-12-13 09:21:27 +09004379TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4380 Run("{}[]", kArraySupportExpectations);
4381}
4382
Christopher Wiley90be4e32015-10-20 14:55:25 -07004383} // namespace aidl
4384} // namespace android