Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015, The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 17 | #include "aidl.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 18 | |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 19 | #include <android-base/format.h> |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 20 | #include <android-base/stringprintf.h> |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 21 | #include <gmock/gmock.h> |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 22 | #include <gtest/gtest.h> |
| 23 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 24 | #include <map> |
| 25 | #include <memory> |
| 26 | #include <set> |
| 27 | #include <string> |
| 28 | #include <vector> |
| 29 | |
Steven Moreland | 4958524 | 2019-12-18 16:06:49 -0800 | [diff] [blame] | 30 | #include "aidl_checkapi.h" |
Jooyung Han | 1f56b70 | 2021-02-11 13:16:15 +0900 | [diff] [blame] | 31 | #include "aidl_dumpapi.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 32 | #include "aidl_language.h" |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 33 | #include "aidl_to_cpp.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 34 | #include "aidl_to_java.h" |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 35 | #include "comments.h" |
Jiyong Park | 2a7c92b | 2020-07-22 19:12:36 +0900 | [diff] [blame] | 36 | #include "logging.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 37 | #include "options.h" |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 38 | #include "parser.h" |
| 39 | #include "preprocess.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 40 | #include "tests/fake_io_delegate.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 41 | |
| 42 | using android::aidl::test::FakeIoDelegate; |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 43 | using android::base::StringPrintf; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 44 | using std::map; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 45 | using std::set; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 46 | using std::string; |
| 47 | using std::unique_ptr; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 48 | using std::vector; |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 49 | using testing::HasSubstr; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 50 | using testing::TestParamInfo; |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 51 | using testing::internal::CaptureStderr; |
| 52 | using testing::internal::GetCapturedStderr; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 53 | |
| 54 | namespace android { |
| 55 | namespace aidl { |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 56 | namespace { |
| 57 | |
| 58 | const char kExpectedDepFileContents[] = |
| 59 | R"(place/for/output/p/IFoo.java : \ |
| 60 | p/IFoo.aidl |
| 61 | |
| 62 | p/IFoo.aidl : |
| 63 | )"; |
| 64 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 65 | const char kExpectedNinjaDepFileContents[] = |
| 66 | R"(place/for/output/p/IFoo.java : \ |
| 67 | p/IFoo.aidl |
| 68 | )"; |
| 69 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 70 | const char kExpectedParcelableDeclarationDepFileContents[] = |
| 71 | R"( : \ |
| 72 | p/Foo.aidl |
| 73 | |
| 74 | p/Foo.aidl : |
| 75 | )"; |
| 76 | |
| 77 | const char kExpectedStructuredParcelableDepFileContents[] = |
Steven Moreland | 2a9a7d6 | 2019-02-05 16:11:54 -0800 | [diff] [blame] | 78 | R"(place/for/output/p/Foo.java : \ |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 79 | p/Foo.aidl |
| 80 | |
| 81 | p/Foo.aidl : |
| 82 | )"; |
| 83 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 84 | } // namespace |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 85 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 86 | class AidlTest : public ::testing::TestWithParam<Options::Language> { |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 87 | protected: |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 88 | AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_, |
| 89 | Options::Language lang, AidlError* error = nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 90 | const vector<string> additional_arguments = {}) { |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 91 | io_delegate_.SetFileContents(path, contents); |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 92 | vector<string> args; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 93 | args.emplace_back("aidl"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 94 | args.emplace_back("--lang=" + to_string(lang)); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 95 | for (const string& s : additional_arguments) { |
| 96 | args.emplace_back(s); |
| 97 | } |
| 98 | for (const string& f : preprocessed_files_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 99 | args.emplace_back("--preprocessed=" + f); |
| 100 | } |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 101 | for (const string& i : import_paths_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 102 | args.emplace_back("--include=" + i); |
| 103 | } |
| 104 | args.emplace_back(path); |
| 105 | Options options = Options::From(args); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 106 | vector<string> imported_files; |
Jooyung Han | 6529b82 | 2021-06-11 22:05:26 +0900 | [diff] [blame] | 107 | ImportResolver import_resolver{io_delegate_, path, import_paths_}; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 108 | AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl( |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 109 | path, options, io_delegate_, &typenames_, &imported_files); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 110 | |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 111 | if (error != nullptr) { |
| 112 | *error = actual_error; |
| 113 | } |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 114 | |
| 115 | if (actual_error != AidlError::OK) { |
| 116 | return nullptr; |
| 117 | } |
| 118 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 119 | const auto& defined_types = typenames_.MainDocument().DefinedTypes(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 120 | EXPECT_EQ(1ul, defined_types.size()); |
| 121 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 122 | return defined_types.front().get(); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 123 | } |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 124 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 125 | Options::Language GetLanguage() { return GetParam(); } |
| 126 | |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 127 | FakeIoDelegate io_delegate_; |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 128 | vector<string> preprocessed_files_; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 129 | set<string> import_paths_; |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 130 | AidlTypenames typenames_; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 131 | }; |
| 132 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 133 | // Instantiate the AidlTest parameterized suite, calling all of the TEST_P |
| 134 | // tests with each of the supported languages as a parameter. |
| 135 | INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest, |
| 136 | testing::Values(Options::Language::CPP, Options::Language::JAVA, |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 137 | Options::Language::NDK, Options::Language::RUST), |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 138 | [](const testing::TestParamInfo<Options::Language>& info) { |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 139 | return to_string(info.param); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 140 | }); |
| 141 | |
| 142 | TEST_P(AidlTest, AcceptMissingPackage) { |
| 143 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 144 | } |
| 145 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 146 | TEST_P(AidlTest, EndsInSingleLineComment) { |
| 147 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage())); |
Steven Moreland | 9c2988f | 2019-07-17 17:49:10 -0700 | [diff] [blame] | 148 | } |
| 149 | |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 150 | TEST_P(AidlTest, InterfaceRequiresCorrectPath) { |
| 151 | const string expected_stderr = |
| 152 | "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n"; |
| 153 | const std::string file_contents = "package a; interface IBar {}"; |
| 154 | CaptureStderr(); |
| 155 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 156 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 157 | } |
| 158 | |
| 159 | TEST_P(AidlTest, ParcelableRequiresCorrectPath) { |
| 160 | const string expected_stderr = |
| 161 | "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n"; |
| 162 | const std::string file_contents = "package a; interface Bar {}"; |
| 163 | CaptureStderr(); |
| 164 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 165 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 166 | } |
| 167 | |
| 168 | TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) { |
| 169 | const string expected_stderr = |
| 170 | "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n"; |
| 171 | const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";"; |
| 172 | CaptureStderr(); |
| 173 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 174 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 175 | } |
| 176 | |
| 177 | TEST_P(AidlTest, EnumRequiresCorrectPath) { |
| 178 | const string expected_stderr = |
| 179 | "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n"; |
| 180 | const std::string file_contents = "package a; enum Bar { A, }"; |
| 181 | CaptureStderr(); |
| 182 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 183 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 184 | } |
| 185 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 186 | TEST_P(AidlTest, RejectsArraysOfBinders) { |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 187 | import_paths_.emplace(""); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 188 | io_delegate_.SetFileContents("bar/IBar.aidl", |
| 189 | "package bar; interface IBar {}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 190 | const string path = "foo/IFoo.aidl"; |
| 191 | const string contents = |
| 192 | "package foo;\n" |
| 193 | "import bar.IBar;\n" |
| 194 | "interface IFoo { void f(in IBar[] input); }"; |
| 195 | const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n"; |
| 196 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 197 | EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 198 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 199 | } |
| 200 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 201 | TEST_P(AidlTest, SupportOnlyOutParameters) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 202 | const string interface_list = "package a; interface IBar { void f(out List<String> bar); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 203 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 204 | } |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 205 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 206 | TEST_P(AidlTest, RejectOutParametersForIBinder) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 207 | const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }"; |
| 208 | const string expected_ibinder_stderr = |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 209 | "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an " |
| 210 | "in parameter.\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 211 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 212 | EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 213 | EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr()); |
Jeongik Cha | a2080bf | 2019-06-18 16:44:29 +0900 | [diff] [blame] | 214 | } |
| 215 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 216 | TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) { |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 217 | const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 218 | const string expected_stderr = |
| 219 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 220 | CaptureStderr(); |
| 221 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
| 222 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 223 | } |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 224 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 225 | TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) { |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 226 | const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }"; |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 227 | const string expected_stderr = |
| 228 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 229 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 230 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 231 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 232 | } |
| 233 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 234 | TEST_P(AidlTest, RejectsOnewayNonVoidReturn) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 235 | const string oneway_method = "package a; interface IFoo { oneway int f(); }"; |
| 236 | const string expected_stderr = |
| 237 | "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n"; |
| 238 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 239 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 240 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 241 | } |
| 242 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 243 | TEST_P(AidlTest, RejectsNullablePrimitive) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 244 | const string oneway_method = "package a; interface IFoo { @nullable int f(); }"; |
| 245 | const string expected_stderr = |
| 246 | "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n"; |
| 247 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 248 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 249 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Casey Dahlin | 57dbe24 | 2015-12-04 11:44:02 -0800 | [diff] [blame] | 250 | } |
| 251 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 252 | TEST_P(AidlTest, AcceptNullableList) { |
| 253 | const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }"; |
| 254 | const string expected_stderr = ""; |
| 255 | CaptureStderr(); |
| 256 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
| 257 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 258 | } |
| 259 | |
Jooyung Han | 01720ed | 2021-08-13 07:46:07 +0900 | [diff] [blame] | 260 | TEST_P(AidlTest, RejectRecursiveParcelable) { |
| 261 | CaptureStderr(); |
| 262 | EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage())); |
| 263 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable")); |
| 264 | } |
| 265 | |
| 266 | TEST_P(AidlTest, RejectIndirectRecursiveParcelable) { |
| 267 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }"); |
| 268 | import_paths_.emplace(""); |
| 269 | CaptureStderr(); |
| 270 | EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage())); |
| 271 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable")); |
| 272 | } |
| 273 | |
| 274 | TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) { |
| 275 | // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T> |
| 276 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }"); |
| 277 | import_paths_.emplace(""); |
| 278 | CaptureStderr(); |
| 279 | EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage())); |
| 280 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable")); |
| 281 | } |
| 282 | |
| 283 | TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) { |
| 284 | CaptureStderr(); |
| 285 | std::string java_only_map_field; |
| 286 | if (GetLanguage() == Options::Language::JAVA) { |
| 287 | java_only_map_field = " Map<String, Foo> map;\n"; |
| 288 | } |
| 289 | EXPECT_NE(nullptr, Parse("Foo.aidl", |
| 290 | "parcelable Foo {\n" |
| 291 | " List<Foo> list;\n" + |
| 292 | java_only_map_field + |
| 293 | " Foo[] arr;\n" |
| 294 | " @nullable(heap=true) Foo heap_nullable;\n" |
| 295 | "}\n", |
| 296 | typenames_, GetLanguage())); |
| 297 | EXPECT_THAT(GetCapturedStderr(), ""); |
| 298 | } |
| 299 | |
| 300 | TEST_P(AidlTest, InterfaceCanReferenceItself) { |
| 301 | CaptureStderr(); |
| 302 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_, |
| 303 | GetLanguage())); |
| 304 | EXPECT_THAT(GetCapturedStderr(), ""); |
| 305 | } |
| 306 | |
| 307 | TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) { |
| 308 | CaptureStderr(); |
| 309 | EXPECT_EQ(nullptr, Parse("Foo.aidl", |
| 310 | "parcelable Foo {\n" |
| 311 | " @nullable(heap=true) String s;\n" |
| 312 | "}", |
| 313 | typenames_, GetLanguage())); |
| 314 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables")); |
| 315 | } |
| 316 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 317 | TEST_P(AidlTest, RejectsDuplicatedArgumentNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 318 | const string method = "package a; interface IFoo { void f(int a, int a); }"; |
| 319 | const string expected_stderr = |
| 320 | "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n"; |
| 321 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 322 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 323 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | b3cd3c7 | 2018-10-11 12:37:45 -0700 | [diff] [blame] | 324 | } |
| 325 | |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 326 | TEST_P(AidlTest, RejectsDuplicatedFieldNames) { |
| 327 | const string method = "package a; parcelable Foo { int a; String a; }"; |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 328 | const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n"; |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 329 | CaptureStderr(); |
| 330 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 331 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 332 | } |
| 333 | |
Jooyung Han | d902a97 | 2020-10-23 17:32:44 +0900 | [diff] [blame] | 334 | TEST_P(AidlTest, RejectsRepeatedAnnotations) { |
| 335 | const string method = R"(@Hide @Hide parcelable Foo {})"; |
| 336 | const string expected_stderr = |
| 337 | "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: " |
| 338 | "Foo.aidl:1.1-6\n"; |
| 339 | CaptureStderr(); |
| 340 | EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage())); |
| 341 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 342 | } |
| 343 | |
Jooyung Han | 05bd8a8 | 2021-04-28 23:56:38 +0900 | [diff] [blame] | 344 | TEST_P(AidlTest, AcceptsEmptyParcelable) { |
| 345 | CaptureStderr(); |
| 346 | EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage())); |
| 347 | EXPECT_EQ("", GetCapturedStderr()); |
| 348 | } |
| 349 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 350 | TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 351 | const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }"; |
| 352 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n"; |
| 353 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 354 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 355 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 356 | } |
| 357 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 358 | TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 359 | AidlError error; |
| 360 | const string method = "package a; @nullable interface IFoo { int f(); }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 361 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 362 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 363 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 364 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 365 | } |
| 366 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 367 | TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 368 | AidlError error; |
| 369 | const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 370 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 371 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 372 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 373 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 374 | } |
| 375 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 376 | TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 377 | AidlError error; |
| 378 | const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 379 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 380 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 381 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 382 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 383 | } |
| 384 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 385 | TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 386 | AidlError error; |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 387 | const string method = "package a; @nullable parcelable IFoo { String a; String b; }"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 388 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 389 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 390 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available.")); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 391 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 392 | } |
| 393 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 394 | TEST_P(AidlTest, ParsesNonNullableAnnotation) { |
| 395 | auto parse_result = |
| 396 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 397 | ASSERT_NE(nullptr, parse_result); |
| 398 | const AidlInterface* interface = parse_result->AsInterface(); |
| 399 | ASSERT_NE(nullptr, interface); |
| 400 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 401 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 402 | } |
| 403 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 404 | TEST_P(AidlTest, ParsesNullableAnnotation) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 405 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }", |
| 406 | typenames_, GetLanguage()); |
| 407 | ASSERT_NE(nullptr, parse_result); |
| 408 | const AidlInterface* interface = parse_result->AsInterface(); |
| 409 | ASSERT_NE(nullptr, interface); |
| 410 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 411 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 412 | } |
| 413 | |
| 414 | TEST_P(AidlTest, ParsesNonUtf8Annotations) { |
| 415 | auto parse_result = |
| 416 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 417 | ASSERT_NE(nullptr, parse_result); |
| 418 | const AidlInterface* interface = parse_result->AsInterface(); |
| 419 | ASSERT_NE(nullptr, interface); |
| 420 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 421 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 422 | } |
| 423 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 424 | TEST_P(AidlTest, ParsesUtf8Annotations) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 425 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }", |
| 426 | typenames_, GetLanguage()); |
| 427 | ASSERT_NE(nullptr, parse_result); |
| 428 | const AidlInterface* interface = parse_result->AsInterface(); |
| 429 | ASSERT_NE(nullptr, interface); |
| 430 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 431 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 432 | } |
| 433 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 434 | TEST_P(AidlTest, VintfRequiresStructuredAndStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 435 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 436 | const string expected_stderr = |
| 437 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 438 | "\"vintf\"'\n" |
| 439 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 440 | "--structured\n"; |
| 441 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 442 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 443 | GetLanguage(), &error)); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 444 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 445 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 446 | } |
| 447 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 448 | TEST_P(AidlTest, VintfRequiresStructured) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 449 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 450 | const string expected_stderr = |
| 451 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 452 | "--structured\n"; |
| 453 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 454 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 455 | GetLanguage(), &error, {"--stability", "vintf"})); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 456 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 457 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 458 | } |
| 459 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 460 | TEST_P(AidlTest, VintfRequiresSpecifiedStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 461 | AidlError error; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 462 | const string expected_stderr = |
| 463 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 464 | "\"vintf\"'\n"; |
| 465 | CaptureStderr(); |
| 466 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 467 | GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 468 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 469 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 470 | } |
| 471 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 472 | TEST_P(AidlTest, ParsesStabilityAnnotations) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 473 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 474 | auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
| 475 | GetLanguage(), &error, {"--structured", "--stability", "vintf"}); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 476 | ASSERT_EQ(AidlError::OK, error); |
| 477 | ASSERT_NE(nullptr, parse_result); |
| 478 | const AidlInterface* interface = parse_result->AsInterface(); |
| 479 | ASSERT_NE(nullptr, interface); |
| 480 | ASSERT_TRUE(interface->IsVintfStability()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 481 | } |
| 482 | |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 483 | TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) { |
| 484 | Options java_options = Options::From("aidl -o out --structured a/Foo.aidl"); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 485 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl"); |
| 486 | Options cpp_structured_options = |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 487 | Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 488 | Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl"); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 489 | io_delegate_.SetFileContents( |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 490 | "a/Foo.aidl", |
| 491 | StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;")); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 492 | |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 493 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
| 494 | EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_)); |
Jooyung Han | 2cb8ecd | 2021-07-28 18:41:30 +0900 | [diff] [blame] | 495 | |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 496 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 497 | EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_)); |
Jooyung Han | 2cb8ecd | 2021-07-28 18:41:30 +0900 | [diff] [blame] | 498 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured")); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 499 | |
| 500 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 501 | EXPECT_FALSE(compile_aidl(rust_options, io_delegate_)); |
Jooyung Han | 2cb8ecd | 2021-07-28 18:41:30 +0900 | [diff] [blame] | 502 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured")); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 503 | } |
| 504 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 505 | TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) { |
| 506 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 507 | @JavaDerive(toString=true) parcelable Foo { int a; float b; })"); |
| 508 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 509 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 510 | |
| 511 | string java_out; |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 512 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 513 | EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {")); |
| 514 | |
| 515 | // Other backends shouldn't be bothered |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 516 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 517 | EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 518 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 519 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 520 | EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 521 | } |
| 522 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 523 | TEST_F(AidlTest, UnionSupportJavaDeriveToString) { |
| 524 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 525 | @JavaDerive(toString=true) union Foo { int a; int[] b; })"); |
| 526 | CaptureStderr(); |
| 527 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 528 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 529 | EXPECT_EQ("", GetCapturedStderr()); |
| 530 | |
| 531 | const string expected_to_string_method = R"--( |
| 532 | @Override |
| 533 | public String toString() { |
| 534 | switch (_tag) { |
| 535 | case a: return "a.Foo.a(" + (getA()) + ")"; |
| 536 | case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")"; |
| 537 | } |
| 538 | throw new IllegalStateException("unknown field: " + _tag); |
| 539 | } |
| 540 | )--"; |
| 541 | |
| 542 | string java_out; |
| 543 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 544 | EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method)); |
| 545 | } |
| 546 | |
Jiyong Park | 9aa3d04 | 2020-12-04 23:30:02 +0900 | [diff] [blame] | 547 | TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) { |
| 548 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 549 | @JavaDerive(equals=true) parcelable Foo { int a; float b; })"); |
| 550 | CaptureStderr(); |
| 551 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 552 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
Jiyong Park | 9aa3d04 | 2020-12-04 23:30:02 +0900 | [diff] [blame] | 553 | EXPECT_EQ("", GetCapturedStderr()); |
| 554 | |
| 555 | const std::string expected = R"--( |
| 556 | @Override |
| 557 | public boolean equals(Object other) { |
| 558 | if (this == other) return true; |
| 559 | if (other == null) return false; |
| 560 | if (!(other instanceof Foo)) return false; |
| 561 | Foo that = (Foo)other; |
| 562 | if (!java.util.Objects.deepEquals(a, that.a)) return false; |
| 563 | if (!java.util.Objects.deepEquals(b, that.b)) return false; |
| 564 | return true; |
| 565 | } |
| 566 | |
| 567 | @Override |
| 568 | public int hashCode() { |
| 569 | return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray()); |
| 570 | } |
| 571 | )--"; |
| 572 | |
| 573 | string java_out; |
| 574 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 575 | EXPECT_THAT(java_out, testing::HasSubstr(expected)); |
| 576 | } |
| 577 | |
| 578 | TEST_F(AidlTest, UnionSupportJavaDeriveEquals) { |
| 579 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 580 | @JavaDerive(equals=true) union Foo { int a; int[] b; })"); |
| 581 | CaptureStderr(); |
| 582 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 583 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
Jiyong Park | 9aa3d04 | 2020-12-04 23:30:02 +0900 | [diff] [blame] | 584 | EXPECT_EQ("", GetCapturedStderr()); |
| 585 | |
| 586 | const std::string expected = R"--( |
| 587 | @Override |
| 588 | public boolean equals(Object other) { |
| 589 | if (this == other) return true; |
| 590 | if (other == null) return false; |
| 591 | if (!(other instanceof Foo)) return false; |
| 592 | Foo that = (Foo)other; |
| 593 | if (_tag != that._tag) return false; |
| 594 | if (!java.util.Objects.deepEquals(_value, that._value)) return false; |
| 595 | return true; |
| 596 | } |
| 597 | |
| 598 | @Override |
| 599 | public int hashCode() { |
| 600 | return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray()); |
| 601 | } |
| 602 | )--"; |
| 603 | |
| 604 | string java_out; |
| 605 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 606 | EXPECT_THAT(java_out, testing::HasSubstr(expected)); |
| 607 | } |
| 608 | |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 609 | TEST_F(AidlTest, RejectsJavaDeriveAnnotation) { |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 610 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 611 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 612 | "package a; @JavaDerive(blah=true) parcelable Foo{}"); |
| 613 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 614 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 615 | EXPECT_FALSE(compile_aidl(java_options, io_delegate_)); |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 616 | const std::string expected_stderr = |
| 617 | "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive."; |
Jooyung Han | f8dbbcc | 2020-12-26 03:05:55 +0900 | [diff] [blame] | 618 | EXPECT_THAT(GetCapturedStderr(), |
| 619 | HasSubstr("Parameter blah not supported for annotation JavaDerive.")); |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 620 | } |
| 621 | |
| 622 | { |
| 623 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 624 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 625 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 626 | EXPECT_FALSE(compile_aidl(java_options, io_delegate_)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 627 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available.")); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 628 | } |
| 629 | |
| 630 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 631 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 632 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 633 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 634 | EXPECT_FALSE(compile_aidl(java_options, io_delegate_)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 635 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available.")); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 636 | } |
| 637 | } |
| 638 | |
Jiyong Park | 27fd7fd | 2020-08-27 16:25:09 +0900 | [diff] [blame] | 639 | TEST_P(AidlTest, ParseDescriptorAnnotation) { |
| 640 | AidlError error; |
| 641 | auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})", |
| 642 | typenames_, GetLanguage(), &error, {"--structured"}); |
| 643 | ASSERT_EQ(AidlError::OK, error); |
| 644 | ASSERT_NE(nullptr, parse_result); |
| 645 | const AidlInterface* interface = parse_result->AsInterface(); |
| 646 | ASSERT_NE(nullptr, interface); |
| 647 | ASSERT_EQ("IBar", interface->GetDescriptor()); |
| 648 | } |
| 649 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 650 | TEST_P(AidlTest, AcceptsOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 651 | const string oneway_method = "package a; interface IFoo { oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 652 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 653 | } |
| 654 | |
| 655 | TEST_P(AidlTest, AcceptsOnewayInterface) { |
| 656 | const string oneway_interface = "package a; oneway interface IBar { void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 657 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 658 | } |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 659 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 660 | TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 661 | const string oneway_method = |
| 662 | "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 663 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 664 | } |
| 665 | |
Steven Moreland | 65297cc | 2020-04-20 20:17:36 -0700 | [diff] [blame] | 666 | TEST_P(AidlTest, AnnotationsInMultiplePlaces) { |
| 667 | const string oneway_method = |
| 668 | "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }"; |
| 669 | const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()); |
| 670 | ASSERT_NE(nullptr, defined); |
| 671 | const AidlInterface* iface = defined->AsInterface(); |
| 672 | ASSERT_NE(nullptr, iface); |
| 673 | |
| 674 | const auto& methods = iface->GetMethods(); |
| 675 | ASSERT_EQ(1u, methods.size()); |
| 676 | const auto& method = methods[0]; |
| 677 | const AidlTypeSpecifier& ret_type = method->GetType(); |
| 678 | |
| 679 | // TODO(b/151102494): these annotations should be on the method |
| 680 | ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage()); |
| 681 | ASSERT_TRUE(ret_type.IsHide()); |
| 682 | } |
| 683 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 684 | TEST_P(AidlTest, WritesComments) { |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 685 | string foo_interface = |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 686 | R"(package a; |
| 687 | /* foo */ |
| 688 | interface IFoo { |
| 689 | /* i */ |
| 690 | int i(); |
| 691 | // j |
| 692 | @nullable String j(); |
| 693 | // k1 |
| 694 | /* k2 */ |
| 695 | @UnsupportedAppUsage oneway void k(int a); |
| 696 | })"; |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 697 | |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 698 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 699 | auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 700 | EXPECT_NE(nullptr, parse_result); |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 701 | EXPECT_EQ("", GetCapturedStderr()); |
| 702 | |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 703 | EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 704 | |
| 705 | const AidlInterface* interface = parse_result->AsInterface(); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 706 | EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments()); |
| 707 | EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments()); |
| 708 | EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 709 | } |
| 710 | |
Jooyung Han | 1a551d3 | 2020-10-05 15:37:26 +0900 | [diff] [blame] | 711 | TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) { |
| 712 | io_delegate_.SetFileContents("p/cpp_header.aidl", |
| 713 | R"(package p; |
| 714 | parcelable cpp_header cpp_header "bar/header";)"); |
| 715 | import_paths_.emplace(""); |
| 716 | const string input_path = "p/IFoo.aidl"; |
| 717 | const string input = R"(package p; |
| 718 | import p.cpp_header; |
| 719 | interface IFoo { |
| 720 | // get bar |
| 721 | cpp_header get(); |
| 722 | })"; |
| 723 | |
| 724 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 725 | EXPECT_NE(nullptr, parse_result); |
| 726 | const AidlInterface* interface = parse_result->AsInterface(); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 727 | EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments()); |
Jooyung Han | 1a551d3 | 2020-10-05 15:37:26 +0900 | [diff] [blame] | 728 | } |
| 729 | |
Jooyung Han | 2cb8ecd | 2021-07-28 18:41:30 +0900 | [diff] [blame] | 730 | TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) { |
| 731 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;"); |
| 732 | Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl"); |
| 733 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 734 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 2cb8ecd | 2021-07-28 18:41:30 +0900 | [diff] [blame] | 735 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined")); |
| 736 | } |
| 737 | |
| 738 | TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) { |
| 739 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;"); |
| 740 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }"); |
| 741 | Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl"); |
| 742 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 743 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 2cb8ecd | 2021-07-28 18:41:30 +0900 | [diff] [blame] | 744 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined")); |
| 745 | } |
| 746 | |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 747 | TEST_F(AidlTest, ParsesPreprocessedFile) { |
| 748 | string simple_content = "parcelable a.Foo;\ninterface b.IBar;"; |
| 749 | io_delegate_.SetFileContents("path", simple_content); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 750 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 751 | EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 752 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 753 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 754 | } |
| 755 | |
| 756 | TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) { |
| 757 | string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t"; |
| 758 | io_delegate_.SetFileContents("path", simple_content); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 759 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 760 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 761 | EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 762 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 763 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 764 | } |
| 765 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 766 | TEST_P(AidlTest, PreferImportToPreprocessed) { |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 767 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;"); |
| 768 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; " |
| 769 | "interface IBar {}"); |
| 770 | preprocessed_files_.push_back("preprocessed"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 771 | import_paths_.emplace(""); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 772 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 773 | typenames_, GetLanguage()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 774 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 775 | |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 776 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 777 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 778 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 779 | // But if we request just "IBar" we should get our imported one. |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 780 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {}); |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 781 | ambiguous_type.Resolve(typenames_, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 782 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 783 | } |
| 784 | |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 785 | // Special case of PreferImportToPreprocessed. Imported type should be preferred |
| 786 | // even when the preprocessed file already has the same type. |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 787 | TEST_P(AidlTest, B147918827) { |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 788 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;"); |
| 789 | io_delegate_.SetFileContents("one/IBar.aidl", |
| 790 | "package one; " |
| 791 | "interface IBar {}"); |
| 792 | preprocessed_files_.push_back("preprocessed"); |
| 793 | import_paths_.emplace(""); |
| 794 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 795 | typenames_, GetLanguage()); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 796 | EXPECT_NE(nullptr, parse_result); |
| 797 | |
| 798 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 799 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 800 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 801 | // But if we request just "IBar" we should get our imported one. |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 802 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {}); |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 803 | ambiguous_type.Resolve(typenames_, parse_result); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 804 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
| 805 | } |
| 806 | |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 807 | TEST_F(AidlTest, WritePreprocessedFile) { |
| 808 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 809 | "package p; parcelable Outer.Inner;"); |
| 810 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;" |
| 811 | "interface IBar {}"); |
| 812 | |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 813 | vector<string> args{"aidl", "--preprocess", "preprocessed", |
| 814 | "-I.", "p/Outer.aidl", "one/IBar.aidl"}; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 815 | Options options = Options::From(args); |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 816 | EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_)); |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 817 | |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 818 | std::map<std::string, std::string> expected = {{"preprocessed", |
| 819 | "parcelable p.Outer.Inner;\n" |
| 820 | "interface one.IBar {\n" |
| 821 | "}\n"}}; |
| 822 | EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected)); |
| 823 | } |
| 824 | |
| 825 | TEST_F(AidlTest, PreprocessVariousThings) { |
| 826 | io_delegate_.SetFileContents("foo/bar/IFoo.aidl", |
| 827 | "package foo.bar;\n" |
| 828 | "interface IFoo {\n" |
| 829 | " int foo();\n" |
| 830 | " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n" |
| 831 | "}\n"); |
| 832 | io_delegate_.SetFileContents("foo/bar/Bar.aidl", |
| 833 | "package foo.bar;\n" |
| 834 | "parcelable Bar {\n" |
| 835 | " const int BAR = imported.Foo.FOO + 1; // should be 43\n" |
| 836 | " imported.Foo foo;\n" |
| 837 | "}\n"); |
| 838 | io_delegate_.SetFileContents("foo/bar/Gen.aidl", |
| 839 | "package foo.bar;\n" |
| 840 | "parcelable Gen<T> {\n" |
| 841 | "}\n"); |
| 842 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 843 | "package foo.bar;\n" |
| 844 | "enum Enum {\n" |
| 845 | " FOO = 3, BAR = FOO + 3, // should be 3, 6\n" |
| 846 | "}\n"); |
| 847 | io_delegate_.SetFileContents("sub/imported/Foo.aidl", |
| 848 | "package imported;\n" |
| 849 | "parcelable Foo {\n" |
| 850 | " const int FOO = 42;\n" |
| 851 | "}\n"); |
| 852 | |
| 853 | vector<string> args = { |
| 854 | "aidl", |
| 855 | "--preprocess", |
| 856 | "preprocessed", |
| 857 | "-Isub", |
| 858 | "-I.", |
| 859 | "foo/bar/IFoo.aidl", |
| 860 | "foo/bar/Bar.aidl", |
| 861 | "foo/bar/Gen.aidl", |
| 862 | "foo/bar/Enum.aidl", |
| 863 | }; |
| 864 | ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_)); |
| 865 | std::string preprocessed = |
| 866 | "interface foo.bar.IFoo {\n" |
| 867 | " const int FOO = 44;\n" |
| 868 | "}\n" |
| 869 | "parcelable foo.bar.Bar {\n" |
| 870 | " const int BAR = 43;\n" |
| 871 | "}\n" |
| 872 | "parcelable foo.bar.Gen<T> {\n" |
| 873 | "}\n" |
| 874 | "enum foo.bar.Enum {\n" |
| 875 | " FOO = 3,\n" |
| 876 | " BAR = 6,\n" |
| 877 | "}\n"; |
| 878 | std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}}; |
| 879 | EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected)); |
| 880 | |
| 881 | // use preprocessed |
| 882 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 883 | "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }"); |
| 884 | io_delegate_.SetFileContents("preprocessed", preprocessed); |
| 885 | CaptureStderr(); |
| 886 | auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 887 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 888 | EXPECT_EQ("", GetCapturedStderr()); |
| 889 | string code; |
| 890 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
| 891 | EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;")); |
| 892 | } |
| 893 | |
Jooyung Han | 3578498 | 2021-06-29 06:26:12 +0900 | [diff] [blame] | 894 | TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) { |
| 895 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 896 | "package p;\n" |
| 897 | "import x.Outer;\n" |
| 898 | "interface IFoo {\n" |
| 899 | " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n" |
| 900 | "}"); |
| 901 | io_delegate_.SetFileContents("imported/x/Outer.aidl", |
| 902 | "package x;\n" |
| 903 | "parcelable Outer.Inner1;\n" |
| 904 | "parcelable Outer.Inner2;\n"); |
| 905 | auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl"); |
| 906 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 907 | EXPECT_TRUE(compile_aidl(opt, io_delegate_)); |
Jooyung Han | 3578498 | 2021-06-29 06:26:12 +0900 | [diff] [blame] | 908 | EXPECT_EQ("", GetCapturedStderr()); |
| 909 | } |
| 910 | |
| 911 | TEST_F(AidlTest, |
| 912 | StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) { |
| 913 | // Main doc(Foo.aidl) is loaded |
| 914 | // And then framework.aidl is loaded as preprocessed. (conflict) |
| 915 | io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n"); |
| 916 | io_delegate_.SetFileContents("x/Foo.aidl", |
| 917 | "package x;\n" |
| 918 | "parcelable Foo.Inner;\n"); |
| 919 | auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl"); |
| 920 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 921 | EXPECT_TRUE(compile_aidl(opt, io_delegate_)); |
Jooyung Han | 3578498 | 2021-06-29 06:26:12 +0900 | [diff] [blame] | 922 | EXPECT_EQ("", GetCapturedStderr()); |
| 923 | } |
| 924 | |
| 925 | TEST_F(AidlTest, |
| 926 | StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) { |
| 927 | // Main doc(IBar.aidl) is loaded first. |
| 928 | // Framework.aidl is loaded as preprocessed. |
| 929 | // And then import(Foo.aidl) is loaded. (conflict) |
| 930 | io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n"); |
| 931 | io_delegate_.SetFileContents("x/IBar.aidl", |
| 932 | "package x;\n" |
| 933 | "import x.Foo;\n" |
| 934 | "interface IBar {\n" |
| 935 | " void bar(in Foo.Inner inner);\n" |
| 936 | "}"); |
| 937 | io_delegate_.SetFileContents("x/Foo.aidl", |
| 938 | "package x;\n" |
| 939 | "parcelable Foo.Inner;\n"); |
| 940 | auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl"); |
| 941 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 942 | EXPECT_TRUE(compile_aidl(opt, io_delegate_)); |
Jooyung Han | 3578498 | 2021-06-29 06:26:12 +0900 | [diff] [blame] | 943 | EXPECT_EQ("", GetCapturedStderr()); |
| 944 | } |
| 945 | |
Jooyung Han | 93f48f0 | 2021-06-05 00:11:16 +0900 | [diff] [blame] | 946 | TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) { |
| 947 | string simple_content = "package xxx; parcelable a.Foo;"; |
| 948 | io_delegate_.SetFileContents("path", simple_content); |
| 949 | CaptureStderr(); |
| 950 | EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true)); |
| 951 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package.")); |
| 952 | } |
| 953 | |
| 954 | TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) { |
| 955 | string simple_content = "parcelable a.Foo {}"; |
| 956 | io_delegate_.SetFileContents("path", simple_content); |
| 957 | CaptureStderr(); |
| 958 | EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false)); |
| 959 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified")); |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 960 | } |
| 961 | |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 962 | TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) { |
| 963 | string contents = R"( |
| 964 | interface android.os.IBinder; |
| 965 | interface android.os.IInterface; |
| 966 | parcelable android.os.ParcelFileDescriptor; |
| 967 | )"; |
| 968 | io_delegate_.SetFileContents("path", contents); |
| 969 | CaptureStderr(); |
| 970 | EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true)); |
| 971 | EXPECT_THAT(GetCapturedStderr(), ""); |
| 972 | } |
| 973 | |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 974 | TEST_P(AidlTest, SupportDeprecated) { |
| 975 | struct TestCase { |
| 976 | std::string output_file; |
| 977 | std::string annotation; |
| 978 | }; |
| 979 | |
| 980 | auto CheckDeprecated = [&](const std::string& filename, const std::string& contents, |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 981 | std::vector<std::pair<Options::Language, TestCase>> expectations) { |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 982 | io_delegate_.SetFileContents(filename, contents); |
| 983 | |
| 984 | auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename + |
| 985 | " --out=out --header_out=out"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 986 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 987 | for (const auto& [lang, test_case] : expectations) { |
| 988 | if (lang != GetLanguage()) continue; |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 989 | string output; |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 990 | EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output)); |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 991 | EXPECT_THAT(output, HasSubstr(test_case.annotation)); |
| 992 | } |
| 993 | }; |
| 994 | |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 995 | // Emit escaped string for notes |
| 996 | CheckDeprecated( |
| 997 | "IFoo.aidl", |
| 998 | R"(interface IFoo { |
| 999 | /** |
| 1000 | * @note asdf |
| 1001 | * @deprecated a really long deprecation message |
| 1002 | * |
| 1003 | * which is really long |
| 1004 | * @param foo bar |
| 1005 | */ |
| 1006 | List<String> foo(); |
| 1007 | })", |
| 1008 | { |
| 1009 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 1010 | {Options::Language::CPP, |
| 1011 | {"out/IFoo.h", |
| 1012 | R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}}, |
| 1013 | {Options::Language::NDK, |
| 1014 | {"out/aidl/IFoo.h", |
| 1015 | R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}}, |
| 1016 | {Options::Language::RUST, |
| 1017 | {"out/IFoo.rs", |
| 1018 | R"(#[deprecated = "a really long deprecation message which is really long"])"}}, |
| 1019 | }); |
| 1020 | |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1021 | // In AIDL @deprecated can be in block comments as well as javadoc style |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 1022 | CheckDeprecated( |
| 1023 | "IFoo.aidl", |
| 1024 | "interface IFoo {\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1025 | " /* @deprecated use bar() */\n" |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 1026 | " List<String> foo();\n" |
| 1027 | "}", |
| 1028 | { |
| 1029 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
Jooyung Han | b7a60ec | 2021-01-21 13:47:59 +0900 | [diff] [blame] | 1030 | {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}}, |
Jooyung Han | d4fe00e | 2021-01-11 16:21:53 +0900 | [diff] [blame] | 1031 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}}, |
| 1032 | {Options::Language::NDK, |
| 1033 | {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}}, |
| 1034 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}}, |
| 1035 | }); |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 1036 | |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1037 | // but not in line comments |
| 1038 | auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage()); |
| 1039 | EXPECT_FALSE(parsed->IsDeprecated()); |
| 1040 | |
| 1041 | // parcelable |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 1042 | CheckDeprecated("Foo.aidl", |
| 1043 | "parcelable Foo {\n" |
| 1044 | " /** @deprecated use bar*/\n" |
| 1045 | " int foo = 0;\n" |
| 1046 | "}", |
| 1047 | { |
| 1048 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 1049 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1050 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 1051 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1052 | }); |
| 1053 | |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1054 | // interface constants |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 1055 | CheckDeprecated("IFoo.aidl", |
| 1056 | "interface IFoo {\n" |
| 1057 | " /** @deprecated use bar*/\n" |
| 1058 | " const int FOO = 0;\n" |
| 1059 | "}", |
| 1060 | { |
| 1061 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 1062 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 1063 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 1064 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 1065 | }); |
| 1066 | |
| 1067 | // union fields |
| 1068 | CheckDeprecated("Foo.aidl", |
| 1069 | "union Foo {\n" |
| 1070 | " int bar = 0;\n" |
| 1071 | " /** @deprecated use bar*/\n" |
| 1072 | " int foo;\n" |
| 1073 | "}", |
| 1074 | { |
| 1075 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 1076 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1077 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 1078 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1079 | }); |
| 1080 | |
| 1081 | CheckDeprecated("Foo.aidl", |
| 1082 | "/** @deprecated use Bar */\n" |
| 1083 | "parcelable Foo {}", |
| 1084 | { |
| 1085 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 1086 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1087 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 1088 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1089 | }); |
| 1090 | |
| 1091 | CheckDeprecated("Foo.aidl", |
| 1092 | "/** @deprecated use Bar */\n" |
| 1093 | "union Foo { int foo = 0; }", |
| 1094 | { |
| 1095 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 1096 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1097 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
| 1098 | {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1099 | }); |
| 1100 | |
| 1101 | CheckDeprecated("IFoo.aidl", |
| 1102 | "/** @deprecated use IBar */\n" |
| 1103 | "interface IFoo {}", |
| 1104 | { |
| 1105 | {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}}, |
| 1106 | {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}}, |
| 1107 | {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}}, |
| 1108 | {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}}, |
| 1109 | }); |
| 1110 | |
| 1111 | CheckDeprecated("Foo.aidl", |
| 1112 | "/** @deprecated use IBar */\n" |
| 1113 | "enum Foo { FOO }", |
| 1114 | { |
| 1115 | {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}}, |
| 1116 | {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}}, |
| 1117 | {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}}, |
Jooyung Han | b7a60ec | 2021-01-21 13:47:59 +0900 | [diff] [blame] | 1118 | // TODO(b/177860423) support "deprecated" in Rust enum |
Jooyung Han | 720253d | 2021-01-05 19:13:17 +0900 | [diff] [blame] | 1119 | // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}}, |
| 1120 | }); |
| 1121 | } |
| 1122 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1123 | TEST_P(AidlTest, RequireOuterClass) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1124 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n"; |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1125 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 1126 | "package p; parcelable Outer.Inner;"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1127 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1128 | CaptureStderr(); |
| 1129 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1130 | "package p; import p.Outer; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1131 | typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1132 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1133 | } |
| 1134 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1135 | TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) { |
Steven Moreland | 58d402b | 2021-07-27 18:35:07 -0700 | [diff] [blame] | 1136 | io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";"); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1137 | preprocessed_files_.push_back("preprocessed"); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1138 | auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1139 | typenames_, GetLanguage()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 1140 | // TODO(wiley): This should actually return nullptr because we require |
| 1141 | // the outer class name. However, for legacy reasons, |
| 1142 | // this behavior must be maintained. b/17415692 |
| 1143 | EXPECT_NE(nullptr, parse_result); |
| 1144 | } |
| 1145 | |
Jooyung Han | 05a532a | 2021-08-18 10:41:40 +0900 | [diff] [blame] | 1146 | TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) { |
| 1147 | io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;"); |
| 1148 | |
| 1149 | Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl"); |
| 1150 | CaptureStderr(); |
| 1151 | EXPECT_EQ(0, aidl_entry(options1, io_delegate_)); |
| 1152 | EXPECT_EQ("", GetCapturedStderr()); |
| 1153 | } |
| 1154 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 1155 | TEST_F(AidlTest, FailOnParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1156 | const string expected_foo_stderr = |
| 1157 | "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. " |
| 1158 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 1159 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1160 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;"); |
| 1161 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 1162 | // By default, we shouldn't fail on parcelable. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1163 | Options options1 = Options::From("aidl p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1164 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1165 | EXPECT_TRUE(compile_aidl(options1, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1166 | EXPECT_EQ("", GetCapturedStderr()); |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1167 | |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1168 | // -b considers this an error |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1169 | Options options2 = Options::From("aidl -b p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1170 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1171 | EXPECT_FALSE(compile_aidl(options2, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1172 | EXPECT_EQ(expected_foo_stderr, GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1173 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1174 | const string expected_bar_stderr = |
| 1175 | "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. " |
| 1176 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 1177 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1178 | io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}"); |
| 1179 | |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 1180 | // With '-b' option, a parcelable and an interface should fail. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1181 | Options options3 = Options::From("aidl p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1182 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1183 | EXPECT_TRUE(compile_aidl(options3, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1184 | EXPECT_EQ("", GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 1185 | Options options4 = Options::From("aidl -b p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1186 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1187 | EXPECT_FALSE(compile_aidl(options4, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1188 | EXPECT_EQ(expected_bar_stderr, GetCapturedStderr()); |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 1189 | } |
| 1190 | |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 1191 | TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) { |
| 1192 | string contents = R"( |
| 1193 | import android.os.IBinder; |
| 1194 | import android.os.IInterface; |
| 1195 | interface IFoo { |
| 1196 | void foo(in IBinder b); |
| 1197 | } |
| 1198 | )"; |
| 1199 | EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage())); |
| 1200 | } |
| 1201 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1202 | TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1203 | const string expected_stderr = |
Jooyung Han | 397a760 | 2021-06-05 00:06:22 +0900 | [diff] [blame] | 1204 | "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a " |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1205 | "structured interface.\n"; |
Steven Moreland | 58d402b | 2021-07-27 18:35:07 -0700 | [diff] [blame] | 1206 | io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", |
| 1207 | "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";"); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 1208 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1209 | AidlError error; |
| 1210 | CaptureStderr(); |
| 1211 | EXPECT_EQ( |
| 1212 | nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 1213 | Parse("p/IFoo.aidl", |
| 1214 | "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1215 | typenames_, GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1216 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1217 | EXPECT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 1218 | } |
| 1219 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1220 | TEST_P(AidlTest, FailOnDuplicateConstantNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1221 | AidlError error; |
| 1222 | const string expected_stderr = |
| 1223 | "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n"; |
| 1224 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1225 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1226 | R"(package p; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 1227 | interface IFoo { |
| 1228 | const String DUPLICATED = "d"; |
| 1229 | const int DUPLICATED = 1; |
| 1230 | } |
| 1231 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1232 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1233 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1234 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 1235 | } |
| 1236 | |
Steven Moreland | e689da2 | 2020-11-10 02:06:30 +0000 | [diff] [blame] | 1237 | TEST_P(AidlTest, FailOnTooBigConstant) { |
| 1238 | AidlError error; |
| 1239 | const string expected_stderr = |
| 1240 | "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n"; |
| 1241 | CaptureStderr(); |
| 1242 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1243 | R"(package p; |
| 1244 | interface IFoo { |
| 1245 | const byte type2small = 256; |
| 1246 | } |
| 1247 | )", |
| 1248 | typenames_, GetLanguage(), &error)); |
| 1249 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1250 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 1251 | } |
| 1252 | |
Jooyung Han | 30f64ad | 2020-12-15 08:16:31 +0900 | [diff] [blame] | 1253 | TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) { |
| 1254 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }"); |
| 1255 | CaptureStderr(); |
| 1256 | auto options = Options::From("aidl --lang java -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1257 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 30f64ad | 2020-12-15 08:16:31 +0900 | [diff] [blame] | 1258 | EXPECT_EQ("", GetCapturedStderr()); |
| 1259 | string code; |
| 1260 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
| 1261 | EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;")); |
| 1262 | } |
| 1263 | |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1264 | TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) { |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1265 | using Ptr = unique_ptr<AidlConstantValue>; |
| 1266 | const AidlLocation& loc = AIDL_LOCATION_HERE; |
| 1267 | |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1268 | EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>()); |
| 1269 | EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>()); |
| 1270 | EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>()); |
| 1271 | EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1272 | |
| 1273 | AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+", |
| 1274 | Ptr(AidlConstantValue::Integral(loc, "1"))); |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1275 | EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1276 | |
| 1277 | auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>}; |
| 1278 | values->emplace_back(AidlConstantValue::String(loc, "\"hello\"")); |
| 1279 | values->emplace_back(AidlConstantValue::String(loc, "\"world\"")); |
| 1280 | vector<string> expected{"hello", "world"}; |
Jooyung Han | 535c5e8 | 2020-12-29 15:16:59 +0900 | [diff] [blame] | 1281 | EXPECT_EQ( |
| 1282 | expected, |
| 1283 | Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>()); |
Jooyung Han | 71a1b58 | 2020-12-25 23:58:41 +0900 | [diff] [blame] | 1284 | } |
| 1285 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1286 | TEST_P(AidlTest, FailOnManyDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1287 | AidlError error; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1288 | const string expected_stderr = |
| 1289 | "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 1290 | CaptureStderr(); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1291 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1292 | R"(package p; |
| 1293 | interface IFoo {} |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1294 | parcelable IBar {} |
| 1295 | parcelable StructuredParcelable {} |
| 1296 | interface IBaz {} |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 1297 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1298 | typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 1299 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1300 | // Parse success is important for clear error handling even if the cases aren't |
| 1301 | // actually supported in code generation. |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1302 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1303 | } |
| 1304 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1305 | TEST_P(AidlTest, FailOnNoDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1306 | AidlError error; |
| 1307 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n"; |
| 1308 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1309 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1310 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1311 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1312 | } |
| 1313 | |
Steven Moreland | f9e922f | 2020-07-08 21:15:27 +0000 | [diff] [blame] | 1314 | TEST_P(AidlTest, FailOnEmptyListWithComma) { |
| 1315 | AidlError error; |
| 1316 | const string expected_stderr = |
| 1317 | "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n"; |
| 1318 | CaptureStderr(); |
| 1319 | EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })", |
| 1320 | typenames_, GetLanguage(), &error)); |
| 1321 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1322 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1323 | } |
| 1324 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1325 | TEST_P(AidlTest, FailOnMalformedConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1326 | AidlError error; |
| 1327 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 1328 | "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1329 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1330 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1331 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1332 | interface IFoo { |
| 1333 | const int BAD_HEX_VALUE = 0xffffffffffffffffff; |
| 1334 | } |
| 1335 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1336 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1337 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1338 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1339 | } |
| 1340 | |
Jiyong Park | 1813218 | 2020-06-08 20:24:40 +0900 | [diff] [blame] | 1341 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) { |
| 1342 | AidlError error; |
| 1343 | const string expected_stderr = |
| 1344 | "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or " |
| 1345 | "cpp_header (which can also be used as an identifier)\n"; |
| 1346 | CaptureStderr(); |
| 1347 | // Notice the trailing dot(.) in the name, which isn't a correct name |
| 1348 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_, |
| 1349 | GetLanguage(), &error)); |
| 1350 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1351 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1352 | } |
| 1353 | |
| 1354 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) { |
| 1355 | AidlError error; |
| 1356 | const string expected_stderr = |
| 1357 | "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or " |
| 1358 | "cpp_header (which can also be used as an identifier)\n"; |
| 1359 | CaptureStderr(); |
| 1360 | // Notice the trailing dot(.) in the package name |
| 1361 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_, |
| 1362 | GetLanguage(), &error)); |
| 1363 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1364 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1365 | } |
| 1366 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1367 | TEST_P(AidlTest, ParsePositiveConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1368 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1369 | auto parse_result = Parse("p/IFoo.aidl", |
| 1370 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1371 | interface IFoo { |
| 1372 | const int POSITIVE_HEX_VALUE = 0xf5; |
| 1373 | } |
| 1374 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1375 | typenames_, GetLanguage(), &error); |
| 1376 | EXPECT_NE(nullptr, parse_result); |
| 1377 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1378 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1379 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1380 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1381 | EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1382 | EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1383 | EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1384 | } |
| 1385 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1386 | TEST_P(AidlTest, ParseNegativeConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1387 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1388 | auto parse_result = Parse("p/IFoo.aidl", |
| 1389 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1390 | interface IFoo { |
| 1391 | const int NEGATIVE_HEX_VALUE = 0xffffffff; |
| 1392 | } |
| 1393 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1394 | typenames_, GetLanguage(), &error); |
| 1395 | ASSERT_NE(nullptr, parse_result); |
| 1396 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1397 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1398 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1399 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1400 | EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1401 | EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1402 | EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1403 | } |
| 1404 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1405 | TEST_P(AidlTest, UnderstandsNestedParcelables) { |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1406 | io_delegate_.SetFileContents( |
| 1407 | "p/Outer.aidl", |
| 1408 | "package p; parcelable Outer.Inner cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1409 | import_paths_.emplace(""); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1410 | const string input_path = "p/IFoo.aidl"; |
| 1411 | const string input = "package p; import p.Outer; interface IFoo" |
| 1412 | " { Outer.Inner get(); }"; |
| 1413 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1414 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1415 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1416 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1417 | EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1418 | // C++ uses "::" instead of "." to refer to a inner class. |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 1419 | AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {}); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1420 | EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_)); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1421 | } |
| 1422 | |
Jooyung Han | 78fcaa8 | 2021-06-11 22:27:57 +0900 | [diff] [blame] | 1423 | TEST_P(AidlTest, UnderstandsNestedParcelablesWithoutImports) { |
| 1424 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 1425 | "package p; parcelable Outer.Inner cpp_header \"baz/header\";"); |
| 1426 | import_paths_.emplace(""); |
| 1427 | const string input_path = "p/IFoo.aidl"; |
| 1428 | const string input = "package p; interface IFoo { p.Outer.Inner get(); }"; |
| 1429 | |
| 1430 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1431 | EXPECT_NE(nullptr, parse_result); |
| 1432 | |
| 1433 | EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved); |
| 1434 | // C++ uses "::" instead of "." to refer to a inner class. |
| 1435 | AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {}); |
| 1436 | EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_)); |
| 1437 | } |
| 1438 | |
Jooyung Han | 0a950bd | 2021-05-15 12:50:36 +0900 | [diff] [blame] | 1439 | TEST_F(AidlTest, CppNameOf_GenericType) { |
Jooyung Han | 01720ed | 2021-08-13 07:46:07 +0900 | [diff] [blame] | 1440 | const string input_path = "p/Wrapper.aidl"; |
| 1441 | const string input = "package p; parcelable Wrapper<T> {}"; |
Jooyung Han | 0a950bd | 2021-05-15 12:50:36 +0900 | [diff] [blame] | 1442 | |
| 1443 | auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP); |
| 1444 | EXPECT_NE(nullptr, parse_result); |
| 1445 | |
| 1446 | auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> { |
| 1447 | auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>; |
| 1448 | (..., params->emplace_back(std::move(type_params))); |
| 1449 | return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{}); |
| 1450 | }; |
| 1451 | |
| 1452 | auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) { |
| 1453 | std::vector<AidlAnnotation> annotations; |
| 1454 | annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", nullptr, {})); |
| 1455 | type->Annotate(std::move(annotations)); |
| 1456 | return std::move(type); |
| 1457 | }; |
| 1458 | |
| 1459 | auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) { |
| 1460 | (void)type->SetArray(); |
| 1461 | return std::move(type); |
| 1462 | }; |
| 1463 | |
| 1464 | auto w = type("p.Wrapper", type("String")); |
| 1465 | EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_)); |
| 1466 | |
| 1467 | auto nullable_w = set_nullable(type("p.Wrapper", type("String"))); |
| 1468 | EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>", |
| 1469 | cpp::CppNameOf(*nullable_w, typenames_)); |
| 1470 | |
| 1471 | auto array_w = set_array(type("p.Wrapper", type("String"))); |
| 1472 | EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>", |
| 1473 | cpp::CppNameOf(*array_w, typenames_)); |
| 1474 | |
| 1475 | auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String")))); |
| 1476 | EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>", |
| 1477 | cpp::CppNameOf(*nullable_array_w, typenames_)); |
| 1478 | |
| 1479 | auto list_w = type("List", type("p.Wrapper", type("String"))); |
| 1480 | EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>", |
| 1481 | cpp::CppNameOf(*list_w, typenames_)); |
| 1482 | |
| 1483 | auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String")))); |
| 1484 | EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>", |
| 1485 | cpp::CppNameOf(*nullable_list_w, typenames_)); |
| 1486 | } |
| 1487 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1488 | TEST_P(AidlTest, UnderstandsNativeParcelables) { |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1489 | io_delegate_.SetFileContents( |
| 1490 | "p/Bar.aidl", |
Casey Dahlin | cd63921 | 2015-12-15 12:51:04 -0800 | [diff] [blame] | 1491 | "package p; parcelable Bar cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1492 | import_paths_.emplace(""); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1493 | const string input_path = "p/IFoo.aidl"; |
| 1494 | const string input = "package p; import p.Bar; interface IFoo { }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1495 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1496 | EXPECT_NE(nullptr, parse_result); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1497 | EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved); |
Jooyung Han | 8451a20 | 2021-01-16 03:07:06 +0900 | [diff] [blame] | 1498 | AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {}); |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 1499 | native_type.Resolve(typenames_, parse_result); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1500 | |
| 1501 | EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_)); |
| 1502 | // C++ understands C++ specific stuff |
| 1503 | EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_)); |
| 1504 | set<string> headers; |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 1505 | cpp::AddHeaders(native_type, typenames_, &headers); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1506 | EXPECT_EQ(1u, headers.size()); |
| 1507 | EXPECT_EQ(1u, headers.count("baz/header")); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1508 | } |
| 1509 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1510 | TEST_F(AidlTest, WritesCorrectDependencyFile) { |
| 1511 | // While the in tree build system always gives us an output file name, |
| 1512 | // other android tools take advantage of our ability to infer the intended |
| 1513 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1514 | vector<string> args = { |
| 1515 | "aidl", |
| 1516 | "-d dep/file/path", |
| 1517 | "-o place/for/output", |
| 1518 | "p/IFoo.aidl"}; |
| 1519 | Options options = Options::From(args); |
| 1520 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1521 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1522 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1523 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1524 | EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents); |
| 1525 | } |
| 1526 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1527 | TEST_F(AidlTest, WritesCorrectDependencyFileNinja) { |
| 1528 | // While the in tree build system always gives us an output file name, |
| 1529 | // other android tools take advantage of our ability to infer the intended |
| 1530 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1531 | vector<string> args = { |
| 1532 | "aidl", |
| 1533 | "-d dep/file/path", |
| 1534 | "--ninja", |
| 1535 | "-o place/for/output", |
| 1536 | "p/IFoo.aidl"}; |
| 1537 | Options options = Options::From(args); |
| 1538 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1539 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1540 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1541 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1542 | EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents); |
| 1543 | } |
| 1544 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1545 | TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) { |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1546 | // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does |
| 1547 | // this by calling aidl with every .aidl file it finds, then parsing the |
| 1548 | // generated dependency files. Those that reference .java output files are |
| 1549 | // for interfaces and those that do not are parcelables. However, for both |
| 1550 | // parcelables and interfaces, we *must* generate a non-empty dependency file. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1551 | vector<string> args = { |
| 1552 | "aidl", |
| 1553 | "-o place/for/output", |
| 1554 | "-d dep/file/path", |
| 1555 | "p/Foo.aidl"}; |
| 1556 | Options options = Options::From(args); |
| 1557 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1558 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1559 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1560 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1561 | EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents); |
| 1562 | } |
| 1563 | |
| 1564 | TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) { |
| 1565 | vector<string> args = { |
| 1566 | "aidl", |
| 1567 | "--structured", |
| 1568 | "-o place/for/output", |
| 1569 | "-d dep/file/path", |
| 1570 | "p/Foo.aidl"}; |
| 1571 | Options options = Options::From(args); |
| 1572 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1573 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1574 | string actual_dep_file_contents; |
| 1575 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
| 1576 | EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1577 | } |
| 1578 | |
Jiyong Park | 9ca5c7e | 2019-10-17 15:01:14 +0900 | [diff] [blame] | 1579 | TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) { |
| 1580 | vector<string> args = { |
| 1581 | "aidl", |
| 1582 | "--lang=java", |
| 1583 | "-o place/for/output", |
| 1584 | "p/Foo.aidl"}; |
| 1585 | Options options = Options::From(args); |
| 1586 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1587 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | 9ca5c7e | 2019-10-17 15:01:14 +0900 | [diff] [blame] | 1588 | string output_file_contents; |
| 1589 | EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents)); |
| 1590 | } |
| 1591 | |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1592 | TEST_P(AidlTest, RejectsListArray) { |
Devin Moore | 6a01ca1 | 2020-08-28 10:24:19 -0700 | [diff] [blame] | 1593 | const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n"; |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1594 | const string list_array_parcelable = |
| 1595 | "package a; parcelable Foo {\n" |
| 1596 | " List[] lists; }"; |
| 1597 | CaptureStderr(); |
| 1598 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage())); |
| 1599 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1600 | } |
| 1601 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1602 | TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) { |
| 1603 | AidlError error; |
| 1604 | string expected_stderr = |
| 1605 | "ERROR: a/IFoo.aidl:2.7-11: " |
| 1606 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 1607 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 1608 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 1609 | if (GetLanguage() != Options::Language::JAVA) { |
| 1610 | expected_stderr = |
| 1611 | "ERROR: a/IFoo.aidl:2.1-7: " |
| 1612 | "Currently, only the Java backend supports non-generic List.\n"; |
| 1613 | } |
| 1614 | |
| 1615 | const string primitive_interface = |
| 1616 | "package a; interface IFoo {\n" |
| 1617 | " List foo(); }"; |
| 1618 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1619 | AidlTypenames tn1; |
| 1620 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1621 | {"--structured"})); |
| 1622 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1623 | |
| 1624 | string primitive_parcelable = |
| 1625 | "package a; parcelable IFoo {\n" |
| 1626 | " List foo;}"; |
| 1627 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1628 | AidlTypenames tn2; |
| 1629 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1630 | {"--structured"})); |
| 1631 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1632 | } |
| 1633 | |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1634 | TEST_P(AidlTest, ExtensionTest) { |
| 1635 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1636 | string extendable_parcelable = |
| 1637 | "package a; parcelable Data {\n" |
| 1638 | " ParcelableHolder extension;\n" |
| 1639 | " ParcelableHolder extension2;\n" |
| 1640 | "}"; |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1641 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1642 | EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1643 | EXPECT_EQ( |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1644 | "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1645 | "yet.\n", |
| 1646 | GetCapturedStderr()); |
| 1647 | } else { |
| 1648 | EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1649 | EXPECT_EQ("", GetCapturedStderr()); |
| 1650 | } |
| 1651 | } |
| 1652 | TEST_P(AidlTest, ParcelableHolderAsReturnType) { |
| 1653 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1654 | string parcelableholder_return_interface = |
| 1655 | "package a; interface IFoo {\n" |
| 1656 | " ParcelableHolder foo();\n" |
| 1657 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1658 | EXPECT_EQ(nullptr, |
| 1659 | Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage())); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1660 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1661 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1662 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1663 | "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1664 | "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1665 | "yet.\n", |
| 1666 | GetCapturedStderr()); |
| 1667 | return; |
| 1668 | } |
| 1669 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n", |
| 1670 | GetCapturedStderr()); |
| 1671 | } |
| 1672 | |
| 1673 | TEST_P(AidlTest, ParcelableHolderAsArgumentType) { |
| 1674 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1675 | string extendable_parcelable_arg_interface = |
| 1676 | "package a; interface IFoo {\n" |
| 1677 | " void foo(in ParcelableHolder ph);\n" |
| 1678 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1679 | EXPECT_EQ(nullptr, |
| 1680 | Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage())); |
| 1681 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1682 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1683 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1684 | "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1685 | "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1686 | "yet.\n", |
| 1687 | GetCapturedStderr()); |
| 1688 | return; |
| 1689 | } |
| 1690 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n", |
| 1691 | GetCapturedStderr()); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1692 | } |
| 1693 | |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1694 | TEST_P(AidlTest, RejectNullableParcelableHolderField) { |
| 1695 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1696 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1697 | const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"; |
| 1698 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1699 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1700 | if (GetLanguage() == Options::Language::RUST) { |
| 1701 | EXPECT_EQ( |
| 1702 | "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n" |
| 1703 | "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder " |
| 1704 | "yet.\n", |
| 1705 | GetCapturedStderr()); |
| 1706 | return; |
| 1707 | } |
| 1708 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1709 | } |
| 1710 | |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1711 | TEST_P(AidlTest, ParcelablesWithConstants) { |
| 1712 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1713 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1714 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1715 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1716 | EXPECT_EQ("", GetCapturedStderr()); |
| 1717 | } |
| 1718 | |
| 1719 | TEST_P(AidlTest, UnionWithConstants) { |
| 1720 | io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 1721 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1722 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1723 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 1724 | EXPECT_EQ("", GetCapturedStderr()); |
| 1725 | } |
| 1726 | |
Jooyung Han | 633eab6 | 2021-01-07 14:12:40 +0900 | [diff] [blame] | 1727 | TEST_F(AidlTest, ConstantsWithAnnotations) { |
| 1728 | io_delegate_.SetFileContents("IFoo.aidl", |
| 1729 | "interface IFoo {\n" |
| 1730 | " @JavaPassthrough(annotation=\"@Foo\")\n" |
| 1731 | " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n" |
| 1732 | "}"); |
| 1733 | Options options = Options::From("aidl IFoo.aidl --lang=java -o out"); |
| 1734 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1735 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 633eab6 | 2021-01-07 14:12:40 +0900 | [diff] [blame] | 1736 | EXPECT_EQ("", GetCapturedStderr()); |
| 1737 | string code; |
| 1738 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code)); |
| 1739 | EXPECT_THAT(code, HasSubstr("@Foo\n")); |
| 1740 | EXPECT_THAT(code, HasSubstr("@Bar\n")); |
| 1741 | } |
| 1742 | |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1743 | TEST_F(AidlTest, ApiDump) { |
| 1744 | io_delegate_.SetFileContents( |
| 1745 | "foo/bar/IFoo.aidl", |
| 1746 | "package foo.bar;\n" |
| 1747 | "import foo.bar.Data;\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1748 | "// commented /* @hide */\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1749 | "interface IFoo {\n" |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1750 | " /* @hide applied \n" |
| 1751 | " @deprecated use foo2 */\n" |
| 1752 | " int foo(out int[] a, String b, boolean c, inout List<String> d);\n" |
| 1753 | " int foo2(@utf8InCpp String x, inout List<String> y);\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1754 | " IFoo foo3(IFoo foo);\n" |
| 1755 | " Data getData();\n" |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1756 | " // @hide not applied\n" |
Jooyung Han | 9fd6702 | 2021-01-13 10:49:48 +0900 | [diff] [blame] | 1757 | " /** blahblah\n" |
| 1758 | " @deprecated\n" |
| 1759 | " reason why... */\n" |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1760 | " const int A = 1;\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1761 | " // @deprecated tags in line comments are ignored\n" |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1762 | " const String STR = \"Hello\";\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1763 | "}\n"); |
| 1764 | io_delegate_.SetFileContents("foo/bar/Data.aidl", |
| 1765 | "package foo.bar;\n" |
| 1766 | "import foo.bar.IFoo;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1767 | "/* @hide*/\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1768 | "parcelable Data {\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1769 | " // @hide\n" |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 1770 | " int x = 10;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1771 | " // @hide\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1772 | " int y;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1773 | " /*@hide2*/\n" |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 1774 | " IFoo foo;\n" |
Jooyung Han | 24effbf | 2021-01-16 10:24:03 +0900 | [diff] [blame] | 1775 | " // Ignore @hide property in line comment\n" |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1776 | " @nullable String[] c;\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1777 | "}\n"); |
| 1778 | io_delegate_.SetFileContents("api.aidl", ""); |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1779 | vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.", |
| 1780 | "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"}; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1781 | Options options = Options::From(args); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1782 | bool result = dump_api(options, io_delegate_); |
| 1783 | ASSERT_TRUE(result); |
| 1784 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1785 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1786 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1787 | interface IFoo { |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1788 | /** |
| 1789 | * @hide |
| 1790 | * @deprecated use foo2 |
| 1791 | */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1792 | int foo(out int[] a, String b, boolean c, inout List<String> d); |
| 1793 | int foo2(@utf8InCpp String x, inout List<String> y); |
| 1794 | foo.bar.IFoo foo3(foo.bar.IFoo foo); |
| 1795 | foo.bar.Data getData(); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1796 | /** |
| 1797 | * @deprecated reason why... |
| 1798 | */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1799 | const int A = 1; |
| 1800 | const String STR = "Hello"; |
| 1801 | } |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1802 | )"), |
| 1803 | actual); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1804 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1805 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual)); |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1806 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
Jooyung Han | 8db6594 | 2021-03-02 18:14:44 +0900 | [diff] [blame] | 1807 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1808 | parcelable Data { |
| 1809 | int x = 10; |
| 1810 | int y; |
| 1811 | foo.bar.IFoo foo; |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1812 | @nullable String[] c; |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1813 | } |
Jooyung Han | 161bb0f | 2021-01-21 12:30:16 +0900 | [diff] [blame] | 1814 | )"), |
| 1815 | actual); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1816 | } |
| 1817 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1818 | TEST_F(AidlTest, ApiDumpWithManualIds) { |
| 1819 | io_delegate_.SetFileContents( |
| 1820 | "foo/bar/IFoo.aidl", |
| 1821 | "package foo.bar;\n" |
| 1822 | "interface IFoo {\n" |
| 1823 | " int foo() = 1;\n" |
| 1824 | " int bar() = 2;\n" |
| 1825 | " int baz() = 10;\n" |
| 1826 | "}\n"); |
| 1827 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1828 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1829 | Options options = Options::From(args); |
| 1830 | bool result = dump_api(options, io_delegate_); |
| 1831 | ASSERT_TRUE(result); |
| 1832 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1833 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1834 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1835 | interface IFoo { |
| 1836 | int foo() = 1; |
| 1837 | int bar() = 2; |
| 1838 | int baz() = 10; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1839 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1840 | )")); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1841 | } |
| 1842 | |
| 1843 | TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1844 | const string expected_stderr = |
| 1845 | "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of " |
| 1846 | "them.\n"; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1847 | io_delegate_.SetFileContents( |
| 1848 | "foo/bar/IFoo.aidl", |
| 1849 | "package foo.bar;\n" |
| 1850 | "interface IFoo {\n" |
| 1851 | " int foo() = 1;\n" |
| 1852 | " int bar();\n" |
| 1853 | " int baz() = 10;\n" |
| 1854 | "}\n"); |
| 1855 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1856 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1857 | Options options = Options::From(args); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1858 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1859 | EXPECT_FALSE(dump_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1860 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1861 | } |
| 1862 | |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1863 | TEST_F(AidlTest, ApiDumpConstWithAnnotation) { |
| 1864 | io_delegate_.SetFileContents("foo/bar/IFoo.aidl", |
| 1865 | "package foo.bar;\n" |
| 1866 | "interface IFoo {\n" |
| 1867 | " @utf8InCpp String foo();\n" |
| 1868 | " const @utf8InCpp String bar = \"bar\";\n" |
| 1869 | "}\n"); |
| 1870 | |
| 1871 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
| 1872 | Options options = Options::From(args); |
| 1873 | CaptureStderr(); |
| 1874 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1875 | EXPECT_EQ("", GetCapturedStderr()); |
| 1876 | string actual; |
| 1877 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1878 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
| 1879 | interface IFoo { |
| 1880 | @utf8InCpp String foo(); |
Jooyung Han | b3ca630 | 2020-11-27 14:13:27 +0900 | [diff] [blame] | 1881 | const @utf8InCpp String bar = "bar"; |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame] | 1882 | } |
| 1883 | )"), |
| 1884 | actual); |
| 1885 | } |
| 1886 | |
Jooyung Han | fdaae1d | 2020-12-14 13:16:15 +0900 | [diff] [blame] | 1887 | TEST_F(AidlTest, ApiDumpWithEnums) { |
| 1888 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 1889 | "package foo.bar;\n" |
| 1890 | "enum Enum {\n" |
| 1891 | " FOO,\n" |
| 1892 | " BAR = FOO + 1,\n" |
| 1893 | "}\n"); |
| 1894 | |
| 1895 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"}; |
| 1896 | Options options = Options::From(args); |
| 1897 | CaptureStderr(); |
| 1898 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1899 | EXPECT_EQ("", GetCapturedStderr()); |
| 1900 | string actual; |
| 1901 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual)); |
| 1902 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1903 | "enum Enum {\n" |
| 1904 | " FOO = 0,\n" |
| 1905 | " BAR = 1,\n" |
| 1906 | "}\n"), |
| 1907 | actual); |
| 1908 | } |
| 1909 | |
| 1910 | TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) { |
| 1911 | io_delegate_.SetFileContents("foo/bar/Enum.aidl", |
| 1912 | "package foo.bar;\n" |
| 1913 | "enum Enum {\n" |
| 1914 | " FOO,\n" |
| 1915 | "}\n"); |
| 1916 | io_delegate_.SetFileContents("foo/bar/Foo.aidl", |
| 1917 | "package foo.bar;\n" |
| 1918 | "import foo.bar.Enum;\n" |
| 1919 | "parcelable Foo {\n" |
| 1920 | " Enum e = Enum.FOO;\n" |
| 1921 | "}\n"); |
| 1922 | |
| 1923 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"}; |
| 1924 | Options options = Options::From(args); |
| 1925 | CaptureStderr(); |
| 1926 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1927 | EXPECT_EQ("", GetCapturedStderr()); |
| 1928 | string actual; |
| 1929 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual)); |
| 1930 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1931 | "parcelable Foo {\n" |
| 1932 | " foo.bar.Enum e = foo.bar.Enum.FOO;\n" |
| 1933 | "}\n"), |
| 1934 | actual); |
| 1935 | } |
| 1936 | |
Jooyung Han | 71dfec3 | 2021-05-23 07:18:58 +0900 | [diff] [blame] | 1937 | TEST_F(AidlTest, ApiDumpWithGenerics) { |
| 1938 | io_delegate_.SetFileContents("foo/bar/Foo.aidl", |
| 1939 | "package foo.bar;\n" |
| 1940 | "parcelable Foo<T, U> {\n" |
| 1941 | "}\n"); |
| 1942 | |
| 1943 | vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"}; |
| 1944 | Options options = Options::From(args); |
| 1945 | CaptureStderr(); |
| 1946 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1947 | EXPECT_EQ("", GetCapturedStderr()); |
| 1948 | string actual; |
| 1949 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual)); |
| 1950 | EXPECT_EQ(string(kPreamble).append("package foo.bar;\n" |
| 1951 | "parcelable Foo<T, U> {\n" |
| 1952 | "}\n"), |
| 1953 | actual); |
| 1954 | } |
| 1955 | |
Jooyung Han | d9ee6f0 | 2021-09-13 17:27:24 +0900 | [diff] [blame^] | 1956 | TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) { |
| 1957 | io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n"); |
| 1958 | io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n"); |
| 1959 | |
| 1960 | vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"}; |
| 1961 | Options options = Options::From(args); |
| 1962 | CaptureStderr(); |
| 1963 | EXPECT_FALSE(dump_api(options, io_delegate_)); |
| 1964 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo")); |
| 1965 | } |
| 1966 | |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1967 | TEST_F(AidlTest, CheckNumGenericTypeSecifier) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1968 | const string expected_list_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1969 | "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: " |
| 1970 | "'List<String,String>'\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1971 | const string expected_map_stderr = |
| 1972 | "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n"; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1973 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1974 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1975 | "package p; interface IFoo {" |
| 1976 | "void foo(List<String, String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1977 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1978 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1979 | EXPECT_EQ(expected_list_stderr, GetCapturedStderr()); |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1980 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1981 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1982 | "package p; interface IFoo {" |
| 1983 | "void foo(Map<String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1984 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1985 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1986 | EXPECT_EQ(expected_map_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1987 | } |
| 1988 | |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1989 | TEST_F(AidlTest, CheckTypeParameterInMapType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1990 | const string expected_stderr = |
| 1991 | "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n"; |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 1992 | Options options = Options::From("aidl -I . p/IFoo.aidl"); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1993 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }"); |
| 1994 | |
| 1995 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1996 | "package p; interface IFoo {" |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 1997 | "Map<String, p.Bar> foo();}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 1998 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1999 | |
| 2000 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2001 | "package p; interface IFoo {" |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2002 | "Map<p.Bar, p.Bar> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2003 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2004 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2005 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 2006 | |
| 2007 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2008 | "package p; interface IFoo {" |
| 2009 | "Map<String, String> foo();}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2010 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 2011 | |
| 2012 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2013 | "package p; interface IFoo {" |
| 2014 | "Map<String, ParcelFileDescriptor> foo();}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2015 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 2016 | } |
| 2017 | |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2018 | TEST_F(AidlTest, WrongGenericType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2019 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n"; |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2020 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 2021 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2022 | "package p; interface IFoo {" |
| 2023 | "String<String> foo(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2024 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2025 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2026 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2027 | } |
| 2028 | |
| 2029 | TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) { |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2030 | Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl"); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2031 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2032 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2033 | EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2034 | EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n", |
| 2035 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2036 | |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2037 | Options options = Options::From("aidl -I . p/IFoo.aidl"); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2038 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;"); |
| 2039 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2040 | "package p; interface IFoo {" |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2041 | "p.Bar<String, String> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2042 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2043 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2044 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type")); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2045 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2046 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2047 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2048 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2")); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2049 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2050 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2051 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2052 | "package p; interface IFoo {" |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2053 | "p.Bar<String, ParcelFileDescriptor> foo();}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2054 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | e74c86d | 2019-12-12 16:54:03 +0900 | [diff] [blame] | 2055 | |
| 2056 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2057 | "package p; interface IFoo {" |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2058 | "p.Bar<int, long> foo();}"); |
Jeongik Cha | e74c86d | 2019-12-12 16:54:03 +0900 | [diff] [blame] | 2059 | |
| 2060 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2061 | "package p; interface IFoo {" |
Jooyung Han | 13f1fa5 | 2021-06-11 18:06:12 +0900 | [diff] [blame] | 2062 | "p.Bar<int[], long[]> foo();}"); |
Jeongik Cha | e74c86d | 2019-12-12 16:54:03 +0900 | [diff] [blame] | 2063 | |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2064 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 2065 | } |
| 2066 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 2067 | TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) { |
| 2068 | std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl", |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2069 | "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl", |
| 2070 | "aidl --lang=rust -o out foo/bar/Foo.aidl"}; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2071 | for (const auto& rawOption : rawOptions) { |
| 2072 | string expected_stderr = |
| 2073 | "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 2074 | Options options = Options::From(rawOption); |
| 2075 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2076 | "package foo.bar;\n" |
| 2077 | "interface IFoo1 { int foo(); }\n" |
| 2078 | "interface IFoo2 { int foo(); }\n" |
| 2079 | "parcelable Data1 { int a; int b;}\n" |
| 2080 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2081 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2082 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2083 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2084 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 2085 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2086 | "package foo.bar;\n" |
| 2087 | "interface IFoo1 { int foo(); }\n" |
| 2088 | "interface IFoo2 { int foo(); }\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2089 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2090 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2091 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2092 | |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2093 | expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 2094 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2095 | "package foo.bar;\n" |
| 2096 | "parcelable Data1 { int a; int b;}\n" |
| 2097 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2098 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2099 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2100 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2101 | } |
| 2102 | } |
| 2103 | |
Devin Moore | bdba2a8 | 2020-03-31 15:19:02 -0700 | [diff] [blame] | 2104 | TEST_P(AidlTest, FailParseOnEmptyFile) { |
| 2105 | const string contents = ""; |
| 2106 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n"; |
| 2107 | CaptureStderr(); |
| 2108 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage())); |
| 2109 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2110 | } |
| 2111 | |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2112 | TEST_F(AidlTest, MultipleInputFiles) { |
| 2113 | Options options = Options::From( |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 2114 | "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2115 | |
| 2116 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 2117 | "package foo.bar;\n" |
| 2118 | "import foo.bar.Data;\n" |
| 2119 | "interface IFoo { Data getData(); }\n"); |
| 2120 | |
| 2121 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 2122 | "package foo.bar;\n" |
| 2123 | "import foo.bar.IFoo;\n" |
| 2124 | "parcelable Data { IFoo foo; }\n"); |
| 2125 | |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2126 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2127 | |
| 2128 | string content; |
| 2129 | for (const auto file : { |
| 2130 | "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) { |
| 2131 | content.clear(); |
| 2132 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 2133 | EXPECT_FALSE(content.empty()); |
| 2134 | } |
| 2135 | } |
| 2136 | |
| 2137 | TEST_F(AidlTest, MultipleInputFilesCpp) { |
| 2138 | Options options = Options::From("aidl --lang=cpp -o out -h out/include " |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 2139 | "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2140 | |
| 2141 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 2142 | "package foo.bar;\n" |
| 2143 | "import foo.bar.Data;\n" |
| 2144 | "interface IFoo { Data getData(); }\n"); |
| 2145 | |
| 2146 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 2147 | "package foo.bar;\n" |
| 2148 | "import foo.bar.IFoo;\n" |
| 2149 | "parcelable Data { IFoo foo; }\n"); |
| 2150 | |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2151 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2152 | |
| 2153 | string content; |
| 2154 | for (const auto file : { |
Jiyong Park | b03551f | 2018-08-06 19:20:51 +0900 | [diff] [blame] | 2155 | "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp", |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 2156 | "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h", |
| 2157 | "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h", |
| 2158 | "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) { |
| 2159 | content.clear(); |
| 2160 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 2161 | EXPECT_FALSE(content.empty()); |
| 2162 | } |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 2163 | } |
| 2164 | |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2165 | TEST_F(AidlTest, MultipleInputFilesRust) { |
| 2166 | Options options = |
| 2167 | Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
| 2168 | |
| 2169 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 2170 | "package foo.bar;\n" |
| 2171 | "import foo.bar.Data;\n" |
| 2172 | "interface IFoo { Data getData(); }\n"); |
| 2173 | |
| 2174 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 2175 | "package foo.bar;\n" |
| 2176 | "import foo.bar.IFoo;\n" |
| 2177 | "parcelable Data { IFoo foo; }\n"); |
| 2178 | |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2179 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2180 | |
| 2181 | string content; |
| 2182 | for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) { |
| 2183 | content.clear(); |
| 2184 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 2185 | EXPECT_FALSE(content.empty()); |
| 2186 | } |
| 2187 | } |
| 2188 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2189 | TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) { |
| 2190 | const string expected_stderr = |
| 2191 | "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n"; |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2192 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
| 2193 | // int getInterfaceVersion() is one of the meta transactions |
| 2194 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2195 | "package p; interface IFoo {" |
| 2196 | "int getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2197 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2198 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2199 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2200 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2201 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2202 | TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) { |
| 2203 | // boolean getInterfaceVersion() is not a meta transaction, but should be |
| 2204 | // prevented because return type is not part of a method signature |
| 2205 | const string expected_stderr = |
| 2206 | "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n"; |
| 2207 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2208 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2209 | "package p; interface IFoo {" |
| 2210 | "boolean getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2211 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2212 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2213 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2214 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2215 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2216 | TEST_F(AidlTest, ConflictWithMetaTransactionGetName) { |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2217 | // this is another reserved name |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2218 | const string expected_stderr = |
| 2219 | "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n"; |
| 2220 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2221 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2222 | "package p; interface IFoo {" |
| 2223 | "String getTransactionName(int code); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2224 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2225 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2226 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2227 | |
| 2228 | // this is not a meta interface method as it differs type arguments |
| 2229 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 2230 | "package p; interface IFoo {" |
| 2231 | "String getTransactionName(); }"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 2232 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 2233 | } |
| 2234 | |
Jooyung Han | b8a9777 | 2021-01-19 01:27:38 +0900 | [diff] [blame] | 2235 | TEST_F(AidlTest, CheckApiForEquality) { |
| 2236 | CaptureStderr(); |
| 2237 | Options options = Options::From("aidl --checkapi=equal old new"); |
| 2238 | |
| 2239 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2240 | "package p; interface IFoo{ @utf8InCpp @nullable String foo();}"); |
| 2241 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2242 | "package p; interface IFoo{ @utf8InCpp String foo();}"); |
| 2243 | |
| 2244 | EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_)); |
| 2245 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();")); |
| 2246 | } |
| 2247 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2248 | TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) { |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 2249 | Options options = Options::From("aidl --checkapi old new"); |
| 2250 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2251 | "package p; interface IFoo{ @utf8InCpp @nullable String foo();}"); |
| 2252 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2253 | "package p; interface IFoo{ @nullable @utf8InCpp String foo();}"); |
| 2254 | |
| 2255 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2256 | } |
| 2257 | |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2258 | TEST_F(AidlTest, SuccessOnIdenticalApiDumps) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2259 | Options options = Options::From("aidl --checkapi old new"); |
| 2260 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
| 2261 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2262 | |
| 2263 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2264 | } |
| 2265 | |
Jooyung Han | fdaae1d | 2020-12-14 13:16:15 +0900 | [diff] [blame] | 2266 | TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) { |
| 2267 | Options options = Options::From("aidl --checkapi old new"); |
| 2268 | const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }"; |
| 2269 | const string enum_definition = "package p; enum Enum { FOO }"; |
| 2270 | io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition); |
| 2271 | io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition); |
| 2272 | io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition); |
| 2273 | io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition); |
| 2274 | |
| 2275 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2276 | } |
| 2277 | |
Jooyung Han | 8e3b72c | 2021-05-22 02:54:37 +0900 | [diff] [blame] | 2278 | TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) { |
| 2279 | Options options = Options::From("aidl --checkapi old new -I import"); |
| 2280 | |
| 2281 | io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }"); |
| 2282 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2283 | "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }"); |
| 2284 | io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }"); |
| 2285 | |
| 2286 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2287 | } |
| 2288 | |
Jooyung Han | 02a11be | 2021-02-11 13:18:06 +0900 | [diff] [blame] | 2289 | TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) { |
| 2290 | Options options = Options::From("aidl --checkapi=equal old new"); |
| 2291 | const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }"; |
| 2292 | const string enum_definition = "package p; enum Enum { FOO }"; |
| 2293 | io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition); |
| 2294 | io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition); |
| 2295 | io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition); |
| 2296 | io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition); |
| 2297 | CaptureStderr(); |
| 2298 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2299 | EXPECT_EQ("", GetCapturedStderr()); |
| 2300 | } |
| 2301 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2302 | class AidlTestCompatibleChanges : public AidlTest { |
| 2303 | protected: |
| 2304 | Options options_ = Options::From("aidl --checkapi old new"); |
| 2305 | }; |
| 2306 | |
| 2307 | TEST_F(AidlTestCompatibleChanges, NewType) { |
| 2308 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2309 | "package p;" |
| 2310 | "interface IFoo {" |
| 2311 | " void foo(int a);" |
| 2312 | "}"); |
| 2313 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2314 | "package p;" |
| 2315 | "interface IFoo {" |
| 2316 | " void foo(int a);" |
| 2317 | "}"); |
| 2318 | io_delegate_.SetFileContents("new/p/IBar.aidl", |
| 2319 | "package p;" |
| 2320 | "interface IBar {" |
| 2321 | " void bar();" |
| 2322 | "}"); |
| 2323 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2324 | } |
| 2325 | |
| 2326 | TEST_F(AidlTestCompatibleChanges, NewMethod) { |
| 2327 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2328 | "package p;" |
| 2329 | "interface IFoo {" |
| 2330 | " void foo(int a);" |
| 2331 | "}"); |
| 2332 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2333 | "package p;" |
| 2334 | "interface IFoo {" |
| 2335 | " void foo(int a);" |
| 2336 | " void bar();" |
Jooyung Han | 8e3b72c | 2021-05-22 02:54:37 +0900 | [diff] [blame] | 2337 | " void baz(in List<String> arg);" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2338 | "}"); |
| 2339 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2340 | } |
| 2341 | |
| 2342 | TEST_F(AidlTestCompatibleChanges, NewField) { |
| 2343 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2344 | "package p;" |
| 2345 | "parcelable Data {" |
| 2346 | " int foo;" |
| 2347 | "}"); |
| 2348 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2349 | "package p;" |
| 2350 | "parcelable Data {" |
| 2351 | " int foo;" |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2352 | " int bar = 0;" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2353 | " @nullable List<Data> list;" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2354 | "}"); |
| 2355 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2356 | } |
| 2357 | |
Jooyung Han | 05bd8a8 | 2021-04-28 23:56:38 +0900 | [diff] [blame] | 2358 | TEST_F(AidlTestCompatibleChanges, NewField2) { |
| 2359 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2360 | "package p;" |
| 2361 | "parcelable Data {" |
| 2362 | "}"); |
| 2363 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2364 | "package p;" |
| 2365 | "parcelable Data {" |
| 2366 | " int foo = 0;" |
| 2367 | "}"); |
| 2368 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2369 | } |
| 2370 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2371 | TEST_F(AidlTestCompatibleChanges, NewEnumerator) { |
| 2372 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2373 | "package p;" |
| 2374 | "enum Enum {" |
| 2375 | " FOO = 1," |
| 2376 | "}"); |
| 2377 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2378 | "package p;" |
| 2379 | "enum Enum {" |
| 2380 | " FOO = 1," |
| 2381 | " BAR = 2," |
| 2382 | "}"); |
| 2383 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2384 | } |
| 2385 | |
| 2386 | TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) { |
| 2387 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2388 | "package p;" |
| 2389 | "enum Enum {" |
| 2390 | " FOO = 1," |
| 2391 | " BAR = 2," |
| 2392 | "}"); |
| 2393 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2394 | "package p;" |
| 2395 | "enum Enum {" |
| 2396 | " BAR = 2," |
| 2397 | " FOO = 1," |
| 2398 | "}"); |
| 2399 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2400 | } |
| 2401 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2402 | TEST_F(AidlTestCompatibleChanges, NewUnionField) { |
| 2403 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2404 | "package p;" |
| 2405 | "union Union {" |
| 2406 | " String foo;" |
| 2407 | "}"); |
| 2408 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2409 | "package p;" |
| 2410 | "union Union {" |
| 2411 | " String foo;" |
| 2412 | " int num;" |
| 2413 | "}"); |
| 2414 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2415 | } |
| 2416 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2417 | TEST_F(AidlTestCompatibleChanges, NewPackage) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2418 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2419 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2420 | "interface IFoo {" |
| 2421 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2422 | "}"); |
| 2423 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2424 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2425 | "parcelable Data {" |
| 2426 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2427 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2428 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2429 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2430 | "interface IFoo {" |
| 2431 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2432 | "}"); |
| 2433 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2434 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2435 | "parcelable Data {" |
| 2436 | " int foo;" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2437 | "}"); |
| 2438 | io_delegate_.SetFileContents("new/q/IFoo.aidl", |
| 2439 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2440 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2441 | " void foo(int a);" |
| 2442 | "}"); |
| 2443 | io_delegate_.SetFileContents("new/q/Data.aidl", |
| 2444 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2445 | "parcelable Data {" |
| 2446 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2447 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2448 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2449 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2450 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2451 | TEST_F(AidlTestCompatibleChanges, ArgNameChange) { |
| 2452 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2453 | "package p;" |
| 2454 | "interface IFoo {" |
| 2455 | " void foo(int a);" |
| 2456 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2457 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2458 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2459 | "interface IFoo {" |
| 2460 | " void foo(int b);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2461 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2462 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2463 | } |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2464 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2465 | TEST_F(AidlTestCompatibleChanges, AddedConstValue) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2466 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2467 | "package p; interface I {" |
| 2468 | "const int A = 1; }"); |
| 2469 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 2470 | "package p ; interface I {" |
| 2471 | "const int A = 1; const int B = 2;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2472 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2473 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2474 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2475 | TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2476 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2477 | "package p; interface I {" |
| 2478 | "const int A = 1; const int B = 2;}"); |
| 2479 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 2480 | "package p ; interface I {" |
| 2481 | "const int B = 2; const int A = 1;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2482 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2483 | } |
| 2484 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2485 | TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) { |
| 2486 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2487 | "package p;" |
| 2488 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2489 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2490 | "parcelable Foo {}"); |
| 2491 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2492 | "package p;" |
| 2493 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2494 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2495 | "parcelable Foo {}"); |
| 2496 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2497 | } |
| 2498 | |
Jooyung Han | 0007327 | 2020-11-27 14:20:20 +0900 | [diff] [blame] | 2499 | TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) { |
| 2500 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2501 | "package p;" |
| 2502 | "parcelable Foo {}"); |
| 2503 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2504 | "package p;" |
| 2505 | "@JavaPassthrough(annotation=\"@Deprecated\")" |
| 2506 | "parcelable Foo {}"); |
| 2507 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2508 | } |
| 2509 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2510 | TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) { |
| 2511 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2512 | "package p;" |
| 2513 | "parcelable Data {" |
| 2514 | " int num;" |
| 2515 | "}"); |
| 2516 | io_delegate_.SetFileContents( |
| 2517 | "new/p/Data.aidl", |
| 2518 | "package p;" |
| 2519 | "parcelable Data {" |
| 2520 | " int num;" |
| 2521 | " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type |
| 2522 | "}"); |
| 2523 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2524 | "package p;" |
| 2525 | "enum Enum {" |
| 2526 | " FOO = 0," |
| 2527 | " BAR = 1," |
| 2528 | "}"); |
| 2529 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2530 | } |
| 2531 | |
Jooyung Han | 308bbe0 | 2021-04-27 12:09:59 +0900 | [diff] [blame] | 2532 | TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) { |
| 2533 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2534 | "package p;\n" |
| 2535 | "parcelable Data {\n" |
| 2536 | " p.Enum e;\n" |
| 2537 | "}"); |
| 2538 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2539 | "package p;\n" |
| 2540 | "enum Enum {\n" |
| 2541 | " FOO = 0,\n" |
| 2542 | " BAR = 1,\n" |
| 2543 | "}"); |
| 2544 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2545 | "package p;\n" |
| 2546 | "parcelable Data {\n" |
| 2547 | " p.Enum e = p.Enum.FOO;\n" |
| 2548 | "}"); |
| 2549 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2550 | "package p;\n" |
| 2551 | "enum Enum {\n" |
| 2552 | " FOO = 0,\n" |
| 2553 | " BAR = 1,\n" |
| 2554 | "}"); |
| 2555 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2556 | } |
| 2557 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2558 | class AidlTestIncompatibleChanges : public AidlTest { |
| 2559 | protected: |
| 2560 | Options options_ = Options::From("aidl --checkapi old new"); |
| 2561 | }; |
| 2562 | |
| 2563 | TEST_F(AidlTestIncompatibleChanges, RemovedType) { |
Jiyong Park | 0cf03b1 | 2020-07-22 19:36:34 +0900 | [diff] [blame] | 2564 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2565 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2566 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2567 | "interface IFoo {" |
| 2568 | " void foo(in String[] str);" |
| 2569 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2570 | "}"); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2571 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2572 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2573 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2574 | } |
| 2575 | |
| 2576 | TEST_F(AidlTestIncompatibleChanges, RemovedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2577 | const string expected_stderr = |
| 2578 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2579 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2580 | "package p;" |
| 2581 | "interface IFoo {" |
| 2582 | " void foo(in String[] str);" |
| 2583 | " void bar(@utf8InCpp String str);" |
| 2584 | "}"); |
| 2585 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2586 | "package p;" |
| 2587 | "interface IFoo {" |
| 2588 | " void foo(in String[] str);" |
| 2589 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2590 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2591 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2592 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2593 | } |
| 2594 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2595 | TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) { |
| 2596 | const string expected_stderr = |
| 2597 | "ERROR: new/p/IFoo.aidl:1.61-65: " |
| 2598 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2599 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2600 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2601 | "ERROR: new/p/IFoo.aidl: Failed to read.\n"; |
| 2602 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2603 | "package p;" |
| 2604 | "interface IFoo {" |
| 2605 | " void foo(in String[] str);" |
| 2606 | "}"); |
| 2607 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2608 | "package p;" |
| 2609 | "interface IFoo {" |
| 2610 | " void foo(in String[] str);" |
| 2611 | " void bar(in List arg);" |
| 2612 | "}"); |
| 2613 | CaptureStderr(); |
| 2614 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2615 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2616 | } |
| 2617 | |
| 2618 | TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) { |
| 2619 | const string expected_stderr = |
| 2620 | "ERROR: new/p/Data.aidl:1.54-59: " |
| 2621 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2622 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2623 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2624 | "ERROR: new/p/Data.aidl: Failed to read.\n"; |
| 2625 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2626 | "package p;" |
| 2627 | "parcelable Data {" |
| 2628 | " int foo;" |
| 2629 | "}"); |
| 2630 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2631 | "package p;" |
| 2632 | "parcelable Data {" |
| 2633 | " int foo;" |
| 2634 | " @nullable List list;" |
| 2635 | "}"); |
| 2636 | CaptureStderr(); |
| 2637 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2638 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2639 | } |
| 2640 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2641 | TEST_F(AidlTestIncompatibleChanges, RemovedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2642 | const string expected_stderr = |
| 2643 | "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2644 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2645 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2646 | "parcelable Data {" |
| 2647 | " int foo;" |
| 2648 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2649 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2650 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2651 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2652 | "parcelable Data {" |
| 2653 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2654 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2655 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2656 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2657 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2658 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2659 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2660 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) { |
| 2661 | const string expected_stderr = |
| 2662 | "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some " |
| 2663 | "backends. Please either provide a default value for this field or mark the field as " |
| 2664 | "@nullable. This value or a null value will be used automatically when an old version of " |
| 2665 | "this parcelable is sent to a process which understands a new version of this parcelable. In " |
| 2666 | "order to make sure your code continues to be backwards compatible, make sure the default or " |
| 2667 | "null value does not cause a semantic change to this parcelable.\n"; |
| 2668 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2669 | "package p;" |
| 2670 | "parcelable Data {" |
| 2671 | " int num;" |
| 2672 | "}"); |
| 2673 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2674 | "package p;" |
| 2675 | "parcelable Data {" |
| 2676 | " int num;" |
| 2677 | " String str;" |
| 2678 | "}"); |
| 2679 | CaptureStderr(); |
| 2680 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2681 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2682 | } |
| 2683 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2684 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) { |
| 2685 | const string expected_stderr = |
| 2686 | "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. " |
| 2687 | "Please make sure 'Enum' has '0' as a valid value.\n"; |
| 2688 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2689 | "package p;" |
| 2690 | "parcelable Data {" |
| 2691 | " int num;" |
| 2692 | "}"); |
| 2693 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2694 | "package p;" |
| 2695 | "parcelable Data {" |
| 2696 | " int num;" |
| 2697 | " p.Enum e;" |
| 2698 | "}"); |
| 2699 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2700 | "package p;" |
| 2701 | "enum Enum {" |
| 2702 | " FOO = 1," |
| 2703 | " BAR = 2," |
| 2704 | "}"); |
| 2705 | CaptureStderr(); |
| 2706 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2707 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2708 | } |
| 2709 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2710 | TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2711 | const string expected_stderr = |
| 2712 | "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2713 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2714 | "package p;" |
| 2715 | "enum Enum {" |
| 2716 | " FOO = 1," |
| 2717 | " BAR = 2," |
| 2718 | "}"); |
| 2719 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2720 | "package p;" |
| 2721 | "enum Enum {" |
| 2722 | " BAR = 2," |
| 2723 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2724 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2725 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2726 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2727 | } |
| 2728 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2729 | TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) { |
| 2730 | const string expected_stderr = |
| 2731 | "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n"; |
| 2732 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2733 | "package p;" |
| 2734 | "union Union {" |
| 2735 | " String str;" |
| 2736 | " int num;" |
| 2737 | "}"); |
| 2738 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2739 | "package p;" |
| 2740 | "union Union {" |
| 2741 | " String str;" |
| 2742 | "}"); |
| 2743 | CaptureStderr(); |
| 2744 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2745 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2746 | } |
| 2747 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2748 | TEST_F(AidlTestIncompatibleChanges, RenamedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2749 | const string expected_stderr = |
| 2750 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2751 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2752 | "package p;" |
| 2753 | "interface IFoo {" |
| 2754 | " void foo(in String[] str);" |
| 2755 | " void bar(@utf8InCpp String str);" |
| 2756 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2757 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2758 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2759 | "interface IFoo {" |
| 2760 | " void foo(in String[] str);" |
| 2761 | " void bar2(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2762 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2763 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2764 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2765 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2766 | } |
| 2767 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2768 | TEST_F(AidlTestIncompatibleChanges, RenamedType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2769 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2770 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2771 | "package p;" |
| 2772 | "interface IFoo {" |
| 2773 | " void foo(in String[] str);" |
| 2774 | " void bar(@utf8InCpp String str);" |
| 2775 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2776 | io_delegate_.SetFileContents("new/p/IFoo2.aidl", |
| 2777 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2778 | "interface IFoo2 {" |
| 2779 | " void foo(in String[] str);" |
| 2780 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2781 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2782 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2783 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2784 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2785 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2786 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2787 | TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2788 | const string expected_stderr = |
| 2789 | "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2790 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2791 | "package p;" |
| 2792 | "enum Enum {" |
| 2793 | " FOO = 1," |
| 2794 | " BAR = 2," |
| 2795 | "}"); |
| 2796 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2797 | "package p;" |
| 2798 | "enum Enum {" |
| 2799 | " FOO = 3," |
| 2800 | " BAR = 2," |
| 2801 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2802 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2803 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2804 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2805 | } |
| 2806 | |
| 2807 | TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2808 | const string expected_stderr = |
| 2809 | "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed " |
| 2810 | "from 0 to 1.\n" |
| 2811 | "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from " |
| 2812 | "1 to 0.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2813 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2814 | "package p;" |
| 2815 | "interface IFoo {" |
| 2816 | " void foo(in String[] str);" |
| 2817 | " void bar(@utf8InCpp String str);" |
| 2818 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2819 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2820 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2821 | "interface IFoo {" |
| 2822 | " void bar(@utf8InCpp String str);" |
| 2823 | " void foo(in String[] str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2824 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2825 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2826 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2827 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2828 | } |
| 2829 | |
| 2830 | TEST_F(AidlTestIncompatibleChanges, ReorderedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2831 | const string expected_stderr = |
Jiyong Park | b07d993 | 2020-05-15 12:56:54 +0900 | [diff] [blame] | 2832 | "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n" |
| 2833 | "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2834 | io_delegate_.SetFileContents("old/p/Data.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2835 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2836 | "parcelable Data {" |
| 2837 | " int foo;" |
| 2838 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2839 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2840 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2841 | "package p;" |
| 2842 | "parcelable Data {" |
| 2843 | " int bar;" |
| 2844 | " int foo;" |
| 2845 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2846 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2847 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2848 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2849 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2850 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2851 | TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) { |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2852 | const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2853 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2854 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2855 | "interface IFoo {" |
| 2856 | " void foo(in String[] str);" |
| 2857 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2858 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2859 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2860 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2861 | "interface IFoo {" |
| 2862 | " void foo(out String[] str);" |
| 2863 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2864 | "}"); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2865 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2866 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2867 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2868 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2869 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2870 | TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2871 | const string expected_stderr = |
| 2872 | "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2873 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2874 | "package p;" |
| 2875 | "interface IFoo {" |
| 2876 | " void foo(in String[] str);" |
| 2877 | " void bar(@utf8InCpp String str);" |
| 2878 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2879 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2880 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2881 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2882 | " void foo(in @utf8InCpp String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2883 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2884 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2885 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2886 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2887 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2888 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2889 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2890 | TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2891 | const string expected_stderr = |
| 2892 | "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2893 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2894 | "package p;" |
| 2895 | "interface IFoo {" |
| 2896 | " void foo(in String[] str);" |
| 2897 | " void bar(@utf8InCpp String str);" |
| 2898 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2899 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2900 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2901 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2902 | " void foo(in String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2903 | " void bar(String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2904 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2905 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2906 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2907 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2908 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2909 | |
Jooyung Han | 60b2fde | 2020-10-29 15:12:40 +0900 | [diff] [blame] | 2910 | TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) { |
| 2911 | const string expected_stderr = |
| 2912 | "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n" |
| 2913 | "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n"; |
| 2914 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2915 | "package p;" |
| 2916 | "@Backing(type=\"byte\")" |
| 2917 | "enum Foo {" |
| 2918 | " FOO, BAR," |
| 2919 | "}"); |
| 2920 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2921 | "package p;" |
| 2922 | "@Backing(type=\"long\")" |
| 2923 | "enum Foo {" |
| 2924 | " FOO, BAR," |
| 2925 | "}"); |
| 2926 | CaptureStderr(); |
| 2927 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2928 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2929 | } |
| 2930 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2931 | TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) { |
| 2932 | const string expected_stderr = |
| 2933 | "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") " |
| 2934 | "to @JavaPassthrough(annotation=\"Bob\")\n"; |
| 2935 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2936 | "package p;" |
| 2937 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2938 | "parcelable Foo {}"); |
| 2939 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2940 | "package p;" |
| 2941 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2942 | "parcelable Foo {}"); |
| 2943 | |
| 2944 | CaptureStderr(); |
| 2945 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2946 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2947 | } |
| 2948 | |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2949 | TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) { |
| 2950 | const string expected_stderr = |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2951 | "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n"; |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2952 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2953 | "package p;" |
| 2954 | "parcelable Foo {" |
| 2955 | " int A;" |
| 2956 | "}"); |
| 2957 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2958 | "package p;" |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2959 | "@FixedSize parcelable Foo {" |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2960 | " int A;" |
| 2961 | "}"); |
| 2962 | CaptureStderr(); |
| 2963 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2964 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2965 | } |
| 2966 | |
| 2967 | TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) { |
| 2968 | const string expected_stderr = |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2969 | "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n"; |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2970 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2971 | "package p;" |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 2972 | "@FixedSize parcelable Foo {" |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2973 | " int A;" |
| 2974 | "}"); |
| 2975 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2976 | "package p;" |
| 2977 | "parcelable Foo {" |
| 2978 | " int A;" |
| 2979 | "}"); |
| 2980 | CaptureStderr(); |
| 2981 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2982 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2983 | } |
| 2984 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2985 | TEST_F(AidlTestIncompatibleChanges, RemovedPackage) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2986 | const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2987 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}"); |
| 2988 | io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2989 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2990 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2991 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2992 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2993 | } |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 2994 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2995 | TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) { |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2996 | const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2997 | io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }"); |
| 2998 | io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2999 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3000 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3001 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3002 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 3003 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3004 | TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3005 | const string expected_stderr = |
| 3006 | "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 3007 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 3008 | "package p; interface I {" |
| 3009 | "const int A = 1; const int B = 2;}"); |
| 3010 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3011 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3012 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3013 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3014 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 3015 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3016 | TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3017 | const string expected_stderr = |
| 3018 | "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 3019 | io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }"); |
| 3020 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3021 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 3022 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3023 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3c35e39 | 2018-08-30 13:10:30 +0900 | [diff] [blame] | 3024 | } |
| 3025 | |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3026 | TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) { |
| 3027 | const string expected_stderr = |
| 3028 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. " |
| 3029 | "This is an incompatible change for FixedSize types.\n"; |
| 3030 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 3031 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 3032 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 3033 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }"); |
| 3034 | CaptureStderr(); |
| 3035 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 3036 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3037 | } |
| 3038 | |
Jeongik Cha | 68d18e7 | 2021-04-29 20:07:01 +0900 | [diff] [blame] | 3039 | TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) { |
| 3040 | const string expected_stderr = |
| 3041 | "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in " |
| 3042 | "android.net.UidRangeParcel is changed from 1 to 2. " |
| 3043 | "But it is forbidden because of legacy support.\n"; |
| 3044 | io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl", |
| 3045 | "package android.net; parcelable UidRangeParcel { int A = 1; }"); |
| 3046 | io_delegate_.SetFileContents( |
| 3047 | "new/android/net/UidRangeParcel.aidl", |
| 3048 | "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }"); |
| 3049 | CaptureStderr(); |
| 3050 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 3051 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3052 | } |
| 3053 | |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3054 | TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) { |
| 3055 | const string expected_stderr = |
| 3056 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n"; |
| 3057 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 3058 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }"); |
| 3059 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 3060 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 3061 | CaptureStderr(); |
| 3062 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 3063 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3064 | } |
| 3065 | |
| 3066 | TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) { |
| 3067 | const string expected_stderr = |
| 3068 | "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 3069 | "a.\n" |
| 3070 | "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 3071 | "b.\n" |
| 3072 | "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 3073 | "c.\n" |
| 3074 | "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 3075 | "d.\n" |
| 3076 | "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 3077 | "e.\n" |
| 3078 | "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 3079 | "f.\n"; |
| 3080 | |
| 3081 | io_delegate_.SetFileContents("Foo.aidl", |
| 3082 | "@FixedSize parcelable Foo { " |
| 3083 | " int[] a;" |
| 3084 | " Bar b;" |
| 3085 | " String c;" |
| 3086 | " ParcelFileDescriptor d;" |
| 3087 | " IBinder e;" |
| 3088 | " List<String> f;" |
Steven Moreland | 265f3d4 | 2020-09-24 19:06:54 +0000 | [diff] [blame] | 3089 | " int isFixedSize;" |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3090 | "}"); |
| 3091 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3092 | Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage())); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3093 | |
| 3094 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3095 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3096 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3097 | } |
| 3098 | |
| 3099 | TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) { |
| 3100 | const string expected_stderr = ""; |
| 3101 | |
| 3102 | io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }"); |
| 3103 | io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }"); |
| 3104 | io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3105 | Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage())); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3106 | |
| 3107 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3108 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 3109 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3110 | } |
| 3111 | |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 3112 | TEST_F(AidlTest, RejectAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3113 | const string expected_stderr = |
| 3114 | "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n" |
| 3115 | "dir1/q/IBar.aidl\n" |
| 3116 | "dir2/q/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 3117 | "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n"; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 3118 | Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl"); |
| 3119 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}"); |
| 3120 | io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}"); |
| 3121 | io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}"); |
| 3122 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3123 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3124 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3125 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 3126 | } |
| 3127 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 3128 | TEST_F(AidlTest, HandleManualIdAssignments) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3129 | const string expected_stderr = |
| 3130 | "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to " |
| 3131 | "11.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 3132 | Options options = Options::From("aidl --checkapi old new"); |
| 3133 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
| 3134 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 3135 | |
| 3136 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 3137 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 3138 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3139 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 3140 | EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3141 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 3142 | } |
| 3143 | |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 3144 | TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) { |
| 3145 | Options options = |
| 3146 | Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl"); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 3147 | |
| 3148 | // use without import |
| 3149 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 3150 | "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3151 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 3152 | |
| 3153 | // capture output files |
| 3154 | map<string, string> outputs = io_delegate_.OutputFiles(); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 3155 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3156 | // use without import but with full name |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 3157 | io_delegate_.SetFileContents( |
| 3158 | "p/IFoo.aidl", |
| 3159 | "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3160 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 3161 | // output files should be the same |
| 3162 | EXPECT_EQ(outputs, io_delegate_.OutputFiles()); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 3163 | |
| 3164 | // use with import (as before) |
| 3165 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 3166 | "package p;" |
| 3167 | "import android.os.ParcelFileDescriptor;" |
| 3168 | "interface IFoo{" |
| 3169 | " void foo(in ParcelFileDescriptor fd);" |
| 3170 | "}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3171 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 652ce48 | 2021-02-26 12:40:35 +0900 | [diff] [blame] | 3172 | // output files should be the same |
| 3173 | EXPECT_EQ(outputs, io_delegate_.OutputFiles()); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 3174 | } |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 3175 | |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 3176 | TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) { |
| 3177 | Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage())); |
| 3178 | CaptureStderr(); |
| 3179 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 3180 | "package p;" |
| 3181 | "interface IFoo{" |
| 3182 | " void foo(out ParcelFileDescriptor fd);" |
| 3183 | "}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3184 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 3185 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter")); |
| 3186 | } |
| 3187 | |
| 3188 | TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) { |
| 3189 | Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage())); |
| 3190 | CaptureStderr(); |
| 3191 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 3192 | "package p;" |
| 3193 | "interface IFoo{" |
| 3194 | " void foo(ParcelFileDescriptor fd);" |
| 3195 | "}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3196 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 020d8d1 | 2021-02-26 17:23:02 +0900 | [diff] [blame] | 3197 | EXPECT_THAT(GetCapturedStderr(), |
| 3198 | HasSubstr("ParcelFileDescriptor can be an in or inout parameter.")); |
| 3199 | } |
| 3200 | |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3201 | TEST_F(AidlTest, ManualIds) { |
| 3202 | Options options = Options::From("aidl --lang=java -o out IFoo.aidl"); |
| 3203 | io_delegate_.SetFileContents("IFoo.aidl", |
| 3204 | "interface IFoo {\n" |
| 3205 | " void foo() = 0;\n" |
| 3206 | " void bar() = 1;\n" |
| 3207 | "}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3208 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3209 | } |
| 3210 | |
| 3211 | TEST_F(AidlTest, ManualIdsWithMetaTransactions) { |
| 3212 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 3213 | io_delegate_.SetFileContents("IFoo.aidl", |
| 3214 | "interface IFoo {\n" |
| 3215 | " void foo() = 0;\n" |
| 3216 | " void bar() = 1;\n" |
| 3217 | "}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3218 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3219 | } |
| 3220 | |
| 3221 | TEST_F(AidlTest, FailOnDuplicatedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3222 | const string expected_stderr = |
| 3223 | "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3224 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 3225 | io_delegate_.SetFileContents("IFoo.aidl", |
| 3226 | "interface IFoo {\n" |
| 3227 | " void foo() = 3;\n" |
| 3228 | " void bar() = 3;\n" |
| 3229 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3230 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3231 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3232 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3233 | } |
| 3234 | |
| 3235 | TEST_F(AidlTest, FailOnOutOfRangeIds) { |
| 3236 | // 16777115 is kLastMetaMethodId + 1 |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3237 | const string expected_stderr = |
| 3238 | "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. " |
| 3239 | "Value for id must be between 0 and 16777114 inclusive.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3240 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 3241 | io_delegate_.SetFileContents("IFoo.aidl", |
| 3242 | "interface IFoo {\n" |
| 3243 | " void foo() = 3;\n" |
| 3244 | " void bar() = 16777115;\n" |
| 3245 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3246 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3247 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3248 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3249 | } |
| 3250 | |
| 3251 | TEST_F(AidlTest, FailOnPartiallyAssignedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3252 | const string expected_stderr = |
| 3253 | "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3254 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 3255 | io_delegate_.SetFileContents("IFoo.aidl", |
| 3256 | "interface IFoo {\n" |
| 3257 | " void foo() = 3;\n" |
| 3258 | " void bar();\n" |
| 3259 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3260 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3261 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3262 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 3263 | } |
| 3264 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 3265 | TEST_F(AidlTest, AllowDuplicatedImportPaths) { |
| 3266 | Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl"); |
| 3267 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 3268 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3269 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 3270 | } |
| 3271 | |
| 3272 | TEST_F(AidlTest, FailOnAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3273 | const string expected_stderr = |
| 3274 | "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n" |
| 3275 | "dir/IBar.aidl\n" |
| 3276 | "dir2/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 3277 | "ERROR: IFoo.aidl: Couldn't find import for class IBar\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3278 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 3279 | Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl"); |
| 3280 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 3281 | io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}"); |
| 3282 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3283 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3284 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3285 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 3286 | } |
| 3287 | |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 3288 | TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) { |
| 3289 | io_delegate_.SetFileContents("a/b/IFoo.aidl", |
| 3290 | "package a.b;\n" |
| 3291 | "import a.b.IBar;\n" |
| 3292 | "import a.b.IQux;\n" |
| 3293 | "interface IFoo { IQux foo(); }\n"); |
| 3294 | io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }"); |
| 3295 | io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }"); |
| 3296 | |
| 3297 | Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3298 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 3299 | |
| 3300 | string output; |
| 3301 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output)); |
| 3302 | // IBar was imported but wasn't used. include is not expected. |
| 3303 | EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>"))); |
| 3304 | // IBar was imported and used. include is expected. |
| 3305 | EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>"))); |
| 3306 | } |
| 3307 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3308 | TEST_F(AidlTest, ParseJavaPassthroughAnnotation) { |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 3309 | io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a; |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3310 | import a.MyEnum; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 3311 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 3312 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3313 | interface IFoo { |
| 3314 | @JavaPassthrough(annotation="@com.android.Bob") |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3315 | void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y); |
Jiyong Park | 7c3b0e4 | 2020-08-04 16:08:32 +0900 | [diff] [blame] | 3316 | const @JavaPassthrough(annotation="@com.android.David") int A = 3; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 3317 | })--"); |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3318 | // JavaPassthrough should work with other types as well (e.g. enum) |
| 3319 | io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a; |
| 3320 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 3321 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
| 3322 | @Backing(type="byte") |
| 3323 | enum MyEnum { |
| 3324 | a, b, c |
| 3325 | })--"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3326 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3327 | Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3328 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3329 | |
| 3330 | string java_out; |
| 3331 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out)); |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 3332 | // type-decl-level annotations with newline at the end |
| 3333 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 3334 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 3335 | // member-decl-level annotations with newline at the end |
| 3336 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n")); |
| 3337 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n")); |
| 3338 | // inline annotations with space at the end |
| 3339 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat ")); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3340 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3341 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out)); |
| 3342 | // type-decl-level annotations with newline at the end |
| 3343 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 3344 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 3345 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3346 | // Other backends shouldn't be bothered |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3347 | Options cpp_options = |
| 3348 | Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3349 | EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_)); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3350 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3351 | Options ndk_options = |
| 3352 | Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3353 | EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 3354 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 3355 | Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3356 | EXPECT_TRUE(compile_aidl(rust_options, io_delegate_)); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 3357 | } |
| 3358 | |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 3359 | TEST_F(AidlTest, ParseRustDerive) { |
| 3360 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 3361 | @RustDerive(Clone=true, Copy=false) |
| 3362 | parcelable Foo { |
| 3363 | int a; |
| 3364 | })"); |
| 3365 | |
| 3366 | Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3367 | EXPECT_TRUE(compile_aidl(rust_options, io_delegate_)); |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 3368 | |
| 3369 | string rust_out; |
| 3370 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out)); |
| 3371 | EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]")); |
| 3372 | |
| 3373 | // Other backends shouldn't be bothered |
| 3374 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3375 | EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_)); |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 3376 | |
| 3377 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3378 | EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_)); |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 3379 | |
| 3380 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3381 | EXPECT_TRUE(compile_aidl(java_options, io_delegate_)); |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 3382 | } |
| 3383 | |
Jiyong Park | 56f73d7 | 2019-06-11 12:20:28 +0900 | [diff] [blame] | 3384 | class AidlOutputPathTest : public AidlTest { |
| 3385 | protected: |
| 3386 | void SetUp() override { |
| 3387 | AidlTest::SetUp(); |
| 3388 | io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}"); |
| 3389 | } |
| 3390 | |
| 3391 | void Test(const Options& options, const std::string expected_output_path) { |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3392 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jiyong Park | 56f73d7 | 2019-06-11 12:20:28 +0900 | [diff] [blame] | 3393 | // check the existence |
| 3394 | EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr)); |
| 3395 | } |
| 3396 | }; |
| 3397 | |
| 3398 | TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) { |
| 3399 | // <out_dir> / <package_name> / <type_name>.java |
| 3400 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java"); |
| 3401 | } |
| 3402 | |
| 3403 | TEST_F(AidlOutputPathTest, OutDirWithOutputFile) { |
| 3404 | // when output file is explicitly set, it is always respected. -o option is |
| 3405 | // ignored. |
| 3406 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 3407 | } |
| 3408 | |
| 3409 | TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) { |
| 3410 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 3411 | } |
| 3412 | |
| 3413 | TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) { |
| 3414 | // output is the same as the input file except for the suffix |
| 3415 | Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java"); |
| 3416 | } |
| 3417 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3418 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3419 | AidlError error; |
| 3420 | const string expected_stderr = |
| 3421 | "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n"; |
| 3422 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3423 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3424 | R"(package p; |
| 3425 | interface IFoo { |
| 3426 | const int int32_max_oob = 2147483650; |
| 3427 | } |
| 3428 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3429 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3430 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3431 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3432 | } |
| 3433 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3434 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3435 | AidlError error; |
| 3436 | const string expected_stderr = |
| 3437 | "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n"; |
| 3438 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3439 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3440 | R"(package p; |
| 3441 | interface IFoo { |
| 3442 | const int int32_min_oob = -2147483650; |
| 3443 | } |
| 3444 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3445 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3446 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3447 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3448 | } |
| 3449 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3450 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3451 | AidlError error; |
| 3452 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 3453 | "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3454 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3455 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3456 | R"(package p; |
| 3457 | interface IFoo { |
| 3458 | const long int64_max_oob = 21474836509999999999999999; |
| 3459 | } |
| 3460 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3461 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3462 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3463 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3464 | } |
| 3465 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3466 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3467 | AidlError error; |
| 3468 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 3469 | "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3470 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3471 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 3472 | R"(package p; |
| 3473 | interface IFoo { |
| 3474 | const long int64_min_oob = -21474836509999999999999999; |
| 3475 | } |
| 3476 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3477 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3478 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3479 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 3480 | } |
| 3481 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3482 | TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3483 | AidlError error; |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3484 | const string expected_stderr = |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 3485 | "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n" |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3486 | "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n"; |
| 3487 | CaptureStderr(); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 3488 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 3489 | R"(package p; |
| 3490 | @Backing(type="byte") |
| 3491 | enum TestEnum { |
| 3492 | FOO = 127, |
| 3493 | BAR, |
| 3494 | } |
| 3495 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 3496 | typenames_, GetLanguage(), &error)); |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 3497 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 3498 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 3499 | } |
| 3500 | |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 3501 | TEST_P(AidlTest, UnsupportedBackingAnnotationParam) { |
| 3502 | AidlError error; |
| 3503 | const string expected_stderr = |
| 3504 | "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must " |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 3505 | "be one of: type\n"; |
| 3506 | CaptureStderr(); |
| 3507 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 3508 | R"(package p; |
| 3509 | @Backing(foo="byte") |
| 3510 | enum TestEnum { |
| 3511 | FOO = 1, |
| 3512 | BAR, |
| 3513 | } |
| 3514 | )", |
| 3515 | typenames_, GetLanguage(), &error)); |
| 3516 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3517 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 3518 | } |
| 3519 | |
Jooyung Han | 5721a23 | 2020-12-24 04:34:55 +0900 | [diff] [blame] | 3520 | TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) { |
| 3521 | const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n"; |
| 3522 | CaptureStderr(); |
| 3523 | EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage())); |
| 3524 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3525 | } |
| 3526 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3527 | TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3528 | io_delegate_.SetFileContents("Foo.aidl", |
| 3529 | "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; " |
| 3530 | "Map<String, Baz> d; Bar[] e; }"); |
| 3531 | io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }"); |
| 3532 | io_delegate_.SetFileContents("Baz.aidl", |
| 3533 | "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3534 | Options options = Options::From("aidl --lang=java -I . Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3535 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3536 | } |
| 3537 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3538 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3539 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3540 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3541 | string expected_error = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3542 | "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
| 3543 | "named 'bar'.\n"; |
| 3544 | CaptureStderr(); |
| 3545 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3546 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3547 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
| 3548 | } |
| 3549 | |
Jooyung Han | 09e551c | 2021-05-11 11:44:48 +0900 | [diff] [blame] | 3550 | TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) { |
| 3551 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }"); |
| 3552 | io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }"); |
| 3553 | CaptureStderr(); |
| 3554 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3555 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 09e551c | 2021-05-11 11:44:48 +0900 | [diff] [blame] | 3556 | EXPECT_EQ("", GetCapturedStderr()); |
| 3557 | } |
| 3558 | |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3559 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) { |
| 3560 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }"); |
| 3561 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
| 3562 | string expected_error = |
| 3563 | "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3564 | "named 'bar'.\n"; |
| 3565 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3566 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3567 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 3568 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3569 | } |
| 3570 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3571 | TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3572 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3573 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }"); |
| 3574 | string expected_error = |
| 3575 | "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can " |
| 3576 | "only be an in parameter.\n"; |
| 3577 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3578 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3579 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3580 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3581 | } |
| 3582 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3583 | TEST_F(AidlTest, ImmutableParcelableCannotBeOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3584 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3585 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }"); |
| 3586 | string expected_error = |
| 3587 | "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can " |
| 3588 | "only be an in parameter.\n"; |
| 3589 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3590 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3591 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 3592 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 3593 | } |
| 3594 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3595 | TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3596 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }"); |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3597 | Options options = Options::From("aidl --lang=java Foo.aidl"); |
| 3598 | const string expected_stderr = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3599 | "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first " |
| 3600 | "letter\n"; |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3601 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3602 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3603 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3604 | } |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3605 | |
Jooyung Han | fe086af | 2021-01-16 03:44:47 +0900 | [diff] [blame] | 3606 | TEST_P(AidlTest, UnionInUnion) { |
| 3607 | import_paths_.insert("."); |
| 3608 | io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }"); |
| 3609 | CaptureStderr(); |
| 3610 | EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage())); |
| 3611 | EXPECT_THAT("", GetCapturedStderr()); |
| 3612 | } |
| 3613 | |
Jooyung Han | fe89f12 | 2020-10-14 03:49:18 +0900 | [diff] [blame] | 3614 | TEST_P(AidlTest, UnionRejectsEmptyDecl) { |
| 3615 | const string method = "package a; union Foo {}"; |
| 3616 | const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n"; |
| 3617 | CaptureStderr(); |
| 3618 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3619 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3620 | } |
| 3621 | |
| 3622 | TEST_P(AidlTest, UnionRejectsParcelableHolder) { |
| 3623 | const string method = "package a; union Foo { ParcelableHolder x; }"; |
| 3624 | const string expected_stderr = |
| 3625 | "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n"; |
| 3626 | CaptureStderr(); |
| 3627 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3628 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3629 | } |
| 3630 | |
Jooyung Han | 53fb424 | 2020-12-17 16:03:49 +0900 | [diff] [blame] | 3631 | TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) { |
| 3632 | import_paths_.insert("."); |
| 3633 | io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }"); |
| 3634 | const string expected_err = "The union's first member should have a useful default value."; |
| 3635 | CaptureStderr(); |
| 3636 | EXPECT_EQ(nullptr, |
| 3637 | Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage())); |
| 3638 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err)); |
| 3639 | } |
| 3640 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3641 | TEST_P(AidlTest, GenericStructuredParcelable) { |
| 3642 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3643 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3644 | const string expected_stderr = ""; |
| 3645 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3646 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3647 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3648 | } |
| 3649 | |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3650 | TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) { |
| 3651 | io_delegate_.SetFileContents("Foo.aidl", |
| 3652 | "parcelable Foo<T, U> { int a; const String s = \"\"; }"); |
| 3653 | Options options = |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3654 | Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out"); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3655 | const string expected_stderr = ""; |
| 3656 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3657 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3658 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3659 | |
| 3660 | string code; |
| 3661 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 3662 | EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U> |
| 3663 | const ::android::String16& Foo<T,U>::s() { |
| 3664 | static const ::android::String16 value(::android::String16("")); |
| 3665 | return value; |
| 3666 | })--")); |
| 3667 | } |
| 3668 | |
| 3669 | TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) { |
| 3670 | io_delegate_.SetFileContents("Foo.aidl", |
| 3671 | "parcelable Foo<T, U> { int a; const String s = \"\"; }"); |
| 3672 | Options options = |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3673 | Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out"); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3674 | const string expected_stderr = ""; |
| 3675 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3676 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 3f347ca | 2020-12-01 12:41:50 +0900 | [diff] [blame] | 3677 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3678 | |
| 3679 | string code; |
| 3680 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 3681 | EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U> |
| 3682 | const char* Foo<T, U>::s = ""; |
| 3683 | )--")); |
| 3684 | } |
| 3685 | |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3686 | TEST_F(AidlTest, NestedTypeArgs) { |
| 3687 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }"); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3688 | io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }"); |
| 3689 | |
| 3690 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 3691 | "package a; import a.Bar; import a.Baz; parcelable Foo { " |
| 3692 | "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }"); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3693 | Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java"); |
| 3694 | const string expected_stderr = ""; |
| 3695 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3696 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3697 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3698 | |
| 3699 | string code; |
| 3700 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3701 | EXPECT_THAT(code, |
| 3702 | testing::HasSubstr( |
| 3703 | "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;")); |
| 3704 | } |
| 3705 | |
| 3706 | TEST_F(AidlTest, DoubleArrayError) { |
| 3707 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }"); |
| 3708 | |
| 3709 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3710 | const string expected_stderr = |
| 3711 | "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n"; |
| 3712 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3713 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3714 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3715 | } |
| 3716 | |
| 3717 | TEST_F(AidlTest, DoubleGenericError) { |
| 3718 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3719 | "package a; parcelable Bar { List<String><String> a; }"); |
| 3720 | |
| 3721 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3722 | const string expected_stderr = |
| 3723 | "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n"; |
| 3724 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3725 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3726 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3727 | } |
| 3728 | |
| 3729 | TEST_F(AidlTest, ArrayBeforeGenericError) { |
| 3730 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }"); |
| 3731 | |
| 3732 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3733 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3734 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 97c324a | 2021-02-15 16:09:51 +0900 | [diff] [blame] | 3735 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'")); |
| 3736 | } |
| 3737 | |
| 3738 | TEST_F(AidlTest, NullableArraysAreNotSupported) { |
| 3739 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3740 | "package a; parcelable Bar { String @nullable [] a; }"); |
| 3741 | |
| 3742 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3743 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3744 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 97c324a | 2021-02-15 16:09:51 +0900 | [diff] [blame] | 3745 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported.")); |
| 3746 | } |
| 3747 | |
| 3748 | TEST_F(AidlTest, ListOfNullablesAreNotSupported) { |
| 3749 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3750 | "package a; parcelable Bar { List<@nullable String> a; }"); |
| 3751 | |
| 3752 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3753 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3754 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 97c324a | 2021-02-15 16:09:51 +0900 | [diff] [blame] | 3755 | EXPECT_THAT(GetCapturedStderr(), |
| 3756 | testing::HasSubstr("Annotations for type arguments are not supported.")); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3757 | } |
| 3758 | |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3759 | struct GenericAidlTest : ::testing::Test { |
| 3760 | FakeIoDelegate io_delegate_; |
| 3761 | void Compile(string cmd) { |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3762 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }"); |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3763 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }"); |
| 3764 | io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }"); |
| 3765 | io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }"); |
| 3766 | |
| 3767 | Options options = Options::From(cmd); |
| 3768 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3769 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3770 | EXPECT_EQ("", GetCapturedStderr()); |
| 3771 | } |
| 3772 | }; |
| 3773 | |
| 3774 | TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) { |
| 3775 | Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out"); |
| 3776 | string code; |
| 3777 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 3778 | EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>")); |
| 3779 | EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>")); |
| 3780 | EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>")); |
| 3781 | } |
| 3782 | |
| 3783 | TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) { |
| 3784 | Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out"); |
| 3785 | string code; |
| 3786 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 3787 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>")); |
| 3788 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>")); |
| 3789 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>")); |
| 3790 | } |
| 3791 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3792 | TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) { |
| 3793 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3794 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3795 | const string expected_stderr = |
| 3796 | "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n"; |
| 3797 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3798 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3799 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3800 | } |
| 3801 | |
| 3802 | TEST_P(AidlTest, RejectGenericStructuredParcelableField) { |
| 3803 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3804 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3805 | const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n"; |
| 3806 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3807 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3808 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3809 | } |
| 3810 | |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 3811 | TEST_P(AidlTest, LongCommentWithinConstExpression) { |
| 3812 | io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 3813 | Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage())); |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 3814 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3815 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 3816 | EXPECT_EQ("", GetCapturedStderr()); |
| 3817 | } |
| 3818 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3819 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) { |
| 3820 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }"); |
| 3821 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
| 3822 | std::string expectedErr = |
| 3823 | "ERROR: a/Foo.aidl:1.28-30: " |
| 3824 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3825 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3826 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3827 | "ERROR: a/Foo.aidl:1.35-37: " |
| 3828 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3829 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3830 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 3831 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3832 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3833 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 3834 | } |
| 3835 | |
| 3836 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) { |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3837 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }"); |
| 3838 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3839 | std::string expectedErr = |
| 3840 | "ERROR: a/Foo.aidl:1.33-35: " |
| 3841 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3842 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3843 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3844 | "ERROR: a/Foo.aidl:1.40-42: " |
| 3845 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3846 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3847 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3848 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3849 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3850 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 3851 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3852 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3853 | TEST_F(AidlTest, RejectNestedUntypedListAndMap) { |
| 3854 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;"); |
| 3855 | io_delegate_.SetFileContents( |
| 3856 | "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }"); |
| 3857 | Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out"); |
| 3858 | std::string expectedErr = |
| 3859 | "ERROR: a/Foo.aidl:1.52-54: " |
| 3860 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3861 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3862 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3863 | "ERROR: a/Foo.aidl:1.64-66: " |
| 3864 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3865 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3866 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 3867 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3868 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3869 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3870 | } |
| 3871 | |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3872 | TEST_F(AidlTest, EnumWithDefaults_Java) { |
| 3873 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3874 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3875 | package p; |
| 3876 | import p.Enum; |
| 3877 | parcelable Foo { |
| 3878 | Enum e = Enum.BAR; |
| 3879 | })"); |
| 3880 | CaptureStderr(); |
| 3881 | auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3882 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3883 | auto err = GetCapturedStderr(); |
| 3884 | EXPECT_EQ("", err); |
| 3885 | |
| 3886 | string code; |
| 3887 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code)); |
Jooyung Han | 2d83361 | 2020-12-17 15:59:27 +0900 | [diff] [blame] | 3888 | EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR")); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3889 | } |
| 3890 | |
| 3891 | TEST_F(AidlTest, EnumWithDefaults_Cpp) { |
| 3892 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3893 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3894 | package p; |
| 3895 | import p.Enum; |
| 3896 | parcelable Foo { |
| 3897 | Enum e = Enum.BAR; |
| 3898 | })"); |
| 3899 | CaptureStderr(); |
| 3900 | auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3901 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3902 | auto err = GetCapturedStderr(); |
| 3903 | EXPECT_EQ("", err); |
| 3904 | |
| 3905 | string code; |
| 3906 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code)); |
| 3907 | EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);")); |
| 3908 | } |
| 3909 | |
| 3910 | TEST_F(AidlTest, EnumWithDefaults_Ndk) { |
| 3911 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3912 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3913 | package p; |
| 3914 | import p.Enum; |
| 3915 | parcelable Foo { |
| 3916 | Enum e = Enum.BAR; |
| 3917 | })"); |
| 3918 | CaptureStderr(); |
| 3919 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3920 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3921 | auto err = GetCapturedStderr(); |
| 3922 | EXPECT_EQ("", err); |
| 3923 | |
| 3924 | string code; |
| 3925 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code)); |
| 3926 | EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;")); |
| 3927 | } |
| 3928 | |
| 3929 | TEST_F(AidlTest, EnumWithDefaults_Rust) { |
| 3930 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }"); |
| 3931 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 3932 | package p; |
| 3933 | import p.Enum; |
| 3934 | parcelable Foo { |
| 3935 | int n = 42; |
| 3936 | Enum e = Enum.BAR; |
| 3937 | })"); |
| 3938 | CaptureStderr(); |
| 3939 | auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 3940 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3941 | auto err = GetCapturedStderr(); |
| 3942 | EXPECT_EQ("", err); |
| 3943 | |
| 3944 | string code; |
| 3945 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code)); |
| 3946 | EXPECT_THAT(code, testing::HasSubstr(R"( |
| 3947 | fn default() -> Self { |
| 3948 | Self { |
| 3949 | n: 42, |
| 3950 | e: crate::mangled::_1_p_4_Enum::BAR, |
| 3951 | } |
| 3952 | })")); |
| 3953 | } |
| 3954 | |
| 3955 | TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) { |
| 3956 | import_paths_.insert("a"); |
| 3957 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 3958 | CaptureStderr(); |
| 3959 | const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"( |
| 3960 | package p; |
| 3961 | import p.Enum; |
| 3962 | parcelable Foo { |
| 3963 | int e = Enum.FOO | Enum.BAR; |
| 3964 | })", |
| 3965 | typenames_, GetLanguage()); |
| 3966 | auto err = GetCapturedStderr(); |
| 3967 | EXPECT_EQ("", err); |
| 3968 | EXPECT_TRUE(type); |
| 3969 | const auto& fields = type->AsStructuredParcelable()->GetFields(); |
| 3970 | EXPECT_EQ("int e = 3", fields[0]->ToString()); |
| 3971 | } |
| 3972 | |
| 3973 | TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) { |
| 3974 | CaptureStderr(); |
| 3975 | const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"( |
| 3976 | @Backing(type="int") |
| 3977 | enum Foo { |
| 3978 | STANDARD_SHIFT = 16, |
| 3979 | STANDARD_BT709 = 1 << STANDARD_SHIFT, |
| 3980 | STANDARD_BT601_625 = 2 << STANDARD_SHIFT, |
| 3981 | } |
| 3982 | )", |
| 3983 | typenames_, GetLanguage()); |
| 3984 | auto err = GetCapturedStderr(); |
| 3985 | EXPECT_EQ("", err); |
| 3986 | EXPECT_TRUE(type); |
| 3987 | const auto& enum_type = type->AsEnumDeclaration(); |
| 3988 | string code; |
Jooyung Han | 1f56b70 | 2021-02-11 13:16:15 +0900 | [diff] [blame] | 3989 | auto writer = CodeWriter::ForString(&code); |
| 3990 | DumpVisitor visitor(*writer); |
| 3991 | visitor.Visit(*enum_type); |
| 3992 | writer->Close(); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 3993 | EXPECT_EQ(R"--(@Backing(type="int") |
| 3994 | enum Foo { |
| 3995 | STANDARD_SHIFT = 16, |
| 3996 | STANDARD_BT709 = 65536, |
| 3997 | STANDARD_BT601_625 = 131072, |
| 3998 | } |
| 3999 | )--", |
| 4000 | code); |
| 4001 | } |
| 4002 | |
| 4003 | TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) { |
| 4004 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 4005 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4006 | package p; |
| 4007 | import p.Enum; |
| 4008 | parcelable Foo { |
| 4009 | Enum e = Enum.FOO | Enum.BAR; |
| 4010 | })"); |
| 4011 | CaptureStderr(); |
| 4012 | auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4013 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4014 | auto err = GetCapturedStderr(); |
| 4015 | EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n", |
| 4016 | err); |
| 4017 | } |
| 4018 | |
Jooyung Han | 361cd10 | 2021-05-24 11:30:10 +0900 | [diff] [blame] | 4019 | TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) { |
| 4020 | io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}"); |
| 4021 | io_delegate_.SetFileContents("a/p/Foo.aidl", R"( |
| 4022 | package p; |
| 4023 | import p.Enum; |
| 4024 | parcelable Foo { |
| 4025 | Enum e = 1; |
| 4026 | })"); |
| 4027 | CaptureStderr(); |
| 4028 | auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4029 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 361cd10 | 2021-05-24 11:30:10 +0900 | [diff] [blame] | 4030 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum")); |
| 4031 | } |
| 4032 | |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4033 | TEST_P(AidlTest, DefaultWithEmptyArray) { |
| 4034 | io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }"); |
| 4035 | io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }"); |
| 4036 | CaptureStderr(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4037 | auto options = |
| 4038 | Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4039 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4040 | auto err = GetCapturedStderr(); |
| 4041 | EXPECT_EQ("", err); |
| 4042 | } |
| 4043 | |
| 4044 | TEST_P(AidlTest, RejectRefsInAnnotation) { |
| 4045 | io_delegate_.SetFileContents("a/p/IFoo.aidl", |
| 4046 | "package p; interface IFoo {\n" |
| 4047 | " const String ANNOTATION = \"@Annotation\";\n" |
| 4048 | " @JavaPassthrough(annotation=ANNOTATION) void foo();\n" |
| 4049 | "}"); |
| 4050 | CaptureStderr(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4051 | auto options = |
| 4052 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4053 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4054 | auto err = GetCapturedStderr(); |
| 4055 | EXPECT_EQ( |
| 4056 | "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to " |
| 4057 | "ANNOTATION.\n", |
| 4058 | err); |
| 4059 | } |
| 4060 | |
| 4061 | TEST_F(AidlTest, DefaultWithEnumValues) { |
| 4062 | io_delegate_.SetFileContents( |
| 4063 | "a/p/Foo.aidl", |
| 4064 | "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }"); |
| 4065 | io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }"); |
| 4066 | CaptureStderr(); |
| 4067 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4068 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 690f584 | 2020-12-04 13:02:04 +0900 | [diff] [blame] | 4069 | auto err = GetCapturedStderr(); |
| 4070 | EXPECT_EQ("", err); |
| 4071 | string code; |
| 4072 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code)); |
| 4073 | EXPECT_THAT( |
| 4074 | code, testing::HasSubstr( |
| 4075 | "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};")); |
| 4076 | } |
| 4077 | |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4078 | TEST_F(AidlTest, RejectsCircularReferencingEnumerators) { |
| 4079 | io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }"); |
| 4080 | CaptureStderr(); |
| 4081 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4082 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4083 | auto err = GetCapturedStderr(); |
Jooyung Han | b9d60e0 | 2021-05-21 07:54:17 +0900 | [diff] [blame] | 4084 | EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4085 | } |
| 4086 | |
| 4087 | TEST_F(AidlTest, RejectsCircularReferencingConsts) { |
| 4088 | io_delegate_.SetFileContents("a/p/Foo.aidl", |
| 4089 | "package p; parcelable Foo { const int A = A + 1; }"); |
| 4090 | CaptureStderr(); |
| 4091 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4092 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4093 | auto err = GetCapturedStderr(); |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 4094 | EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err); |
| 4095 | } |
| 4096 | |
| 4097 | TEST_F(AidlTest, RecursiveReferences) { |
| 4098 | io_delegate_.SetFileContents("a/p/Foo.aidl", |
| 4099 | "package p; parcelable Foo { const int A = p.Bar.A + 1; }"); |
| 4100 | io_delegate_.SetFileContents("a/p/Bar.aidl", |
| 4101 | "package p; parcelable Bar { const int A = p.Baz.A + 1; }"); |
| 4102 | io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }"); |
| 4103 | CaptureStderr(); |
| 4104 | auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl"); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4105 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 4106 | EXPECT_EQ("", GetCapturedStderr()); |
| 4107 | } |
| 4108 | |
Jooyung Han | b9d60e0 | 2021-05-21 07:54:17 +0900 | [diff] [blame] | 4109 | TEST_P(AidlTest, CircularReferenceWithFullyQualified) { |
| 4110 | io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }"); |
| 4111 | auto options = |
| 4112 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl"); |
| 4113 | const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n"; |
| 4114 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4115 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | b9d60e0 | 2021-05-21 07:54:17 +0900 | [diff] [blame] | 4116 | EXPECT_EQ(err, GetCapturedStderr()); |
| 4117 | } |
| 4118 | |
| 4119 | TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) { |
| 4120 | io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }"); |
| 4121 | // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C. |
| 4122 | io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }"); |
| 4123 | auto options = |
| 4124 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl"); |
| 4125 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4126 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | b9d60e0 | 2021-05-21 07:54:17 +0900 | [diff] [blame] | 4127 | EXPECT_EQ("", GetCapturedStderr()); |
| 4128 | } |
| 4129 | |
Jooyung Han | e9f5b27 | 2021-01-07 00:18:11 +0900 | [diff] [blame] | 4130 | TEST_P(AidlTest, UnknownConstReference) { |
| 4131 | io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }"); |
| 4132 | auto options = |
| 4133 | Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl"); |
| 4134 | const string err = |
| 4135 | "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n" |
| 4136 | "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n" |
| 4137 | "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n"; |
| 4138 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4139 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | e9f5b27 | 2021-01-07 00:18:11 +0900 | [diff] [blame] | 4140 | EXPECT_EQ(err, GetCapturedStderr()); |
| 4141 | } |
| 4142 | |
Jooyung Han | 2981384 | 2020-12-08 01:28:03 +0900 | [diff] [blame] | 4143 | TEST_P(AidlTest, JavaCompatibleBuiltinTypes) { |
| 4144 | string contents = R"( |
| 4145 | import android.os.IBinder; |
| 4146 | import android.os.IInterface; |
| 4147 | interface IFoo {} |
| 4148 | )"; |
| 4149 | EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage())); |
Jooyung Han | 1425939 | 2020-12-07 10:00:08 +0900 | [diff] [blame] | 4150 | } |
| 4151 | |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4152 | TEST_P(AidlTest, WarningInterfaceName) { |
| 4153 | io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4154 | auto options = Options::From("aidl --lang " + to_string(GetLanguage()) + |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4155 | " -Weverything -o out -h out p/Foo.aidl"); |
| 4156 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4157 | EXPECT_TRUE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 808a2a0 | 2020-12-28 16:46:54 +0900 | [diff] [blame] | 4158 | EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n", |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4159 | GetCapturedStderr()); |
| 4160 | } |
| 4161 | |
| 4162 | TEST_P(AidlTest, ErrorInterfaceName) { |
| 4163 | io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}"); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4164 | auto options = Options::From("aidl --lang " + to_string(GetLanguage()) + |
Jooyung Han | 888c5bc | 2020-12-22 17:28:47 +0900 | [diff] [blame] | 4165 | " -Weverything -Werror -o out -h out p/Foo.aidl"); |
| 4166 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4167 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 808a2a0 | 2020-12-28 16:46:54 +0900 | [diff] [blame] | 4168 | EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n", |
Jooyung Han | 3b99018 | 2020-12-22 17:44:31 +0900 | [diff] [blame] | 4169 | GetCapturedStderr()); |
| 4170 | } |
| 4171 | |
Jiyong Park | 9f4c382 | 2021-04-07 20:36:45 +0900 | [diff] [blame] | 4172 | TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) { |
| 4173 | const std::string input_file = "base/p/q/IFoo.aidl"; |
| 4174 | const std::string header_dir = "out/"; |
| 4175 | const std::string output_file = "out/base/p/q/IFoo.cpp"; |
| 4176 | const std::string package = "p.q"; // not base.p.q |
| 4177 | io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}"); |
| 4178 | |
| 4179 | auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file}); |
| 4180 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4181 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jiyong Park | 9f4c382 | 2021-04-07 20:36:45 +0900 | [diff] [blame] | 4182 | EXPECT_THAT( |
| 4183 | GetCapturedStderr(), |
| 4184 | testing::StartsWith( |
| 4185 | "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, " |
| 4186 | "but is out/base/p/q/IFoo.cpp.")); |
| 4187 | } |
| 4188 | |
Jooyung Han | b7a60ec | 2021-01-21 13:47:59 +0900 | [diff] [blame] | 4189 | TEST_F(AidlTest, FormatCommentsForJava) { |
| 4190 | using android::aidl::FormatCommentsForJava; |
| 4191 | |
| 4192 | struct TestCase { |
| 4193 | vector<Comment> comments; |
| 4194 | string formatted; |
| 4195 | }; |
| 4196 | vector<TestCase> testcases = { |
| 4197 | {{}, ""}, |
| 4198 | {{{"// line comments\n"}}, "// line comments\n"}, |
| 4199 | {{{"// @hide \n"}}, "// @hide \n"}, |
| 4200 | // Transform the last block comment as Javadoc. |
| 4201 | {{{"/*\n" |
| 4202 | " * Hello, world!\n" |
| 4203 | " */"}}, |
| 4204 | "/**\n" |
| 4205 | " * Hello, world!\n" |
| 4206 | " */"}, |
| 4207 | {{{"/* @hide */"}}, "/** @hide */"}, |
| 4208 | {{{"/**\n" |
| 4209 | " @param foo ...\n" |
| 4210 | "*/"}}, |
| 4211 | "/**\n" |
| 4212 | " @param foo ...\n" |
| 4213 | "*/"}, |
| 4214 | {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"}, |
| 4215 | {{{"/* @deprecated first */"}, {"/* @deprecated second */"}}, |
| 4216 | "/* @deprecated first *//** @deprecated second */"}, |
| 4217 | {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"}, |
| 4218 | // Line comments are printed as they are |
| 4219 | {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"}, |
| 4220 | }; |
| 4221 | for (const auto& [input, formatted] : testcases) { |
| 4222 | EXPECT_EQ(formatted, FormatCommentsForJava(input)); |
| 4223 | } |
| 4224 | } |
| 4225 | |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 4226 | TEST_F(AidlTest, HideIsNotForArgs) { |
| 4227 | io_delegate_.SetFileContents("IFoo.aidl", |
| 4228 | "interface IFoo {\n" |
| 4229 | " void foo(in @Hide int x);\n" |
| 4230 | "}"); |
| 4231 | auto options = Options::From("aidl --lang=java IFoo.aidl"); |
| 4232 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4233 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 4234 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available")); |
| 4235 | } |
| 4236 | |
| 4237 | TEST_F(AidlTest, SuppressWarningsIsNotForArgs) { |
| 4238 | io_delegate_.SetFileContents( |
| 4239 | "IFoo.aidl", |
| 4240 | "interface IFoo {\n" |
| 4241 | " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n" |
| 4242 | "}"); |
| 4243 | auto options = Options::From("aidl --lang=java IFoo.aidl"); |
| 4244 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4245 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | 2d6b5c4 | 2021-01-09 01:01:06 +0900 | [diff] [blame] | 4246 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available")); |
| 4247 | } |
| 4248 | |
Jooyung Han | fa18193 | 2021-06-12 07:56:53 +0900 | [diff] [blame] | 4249 | TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) { |
| 4250 | io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}"); |
| 4251 | auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl"); |
| 4252 | CaptureStderr(); |
Steven Moreland | 4e05913 | 2021-08-11 13:36:30 -0700 | [diff] [blame] | 4253 | EXPECT_FALSE(compile_aidl(options, io_delegate_)); |
Jooyung Han | fa18193 | 2021-06-12 07:56:53 +0900 | [diff] [blame] | 4254 | EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'")); |
| 4255 | } |
| 4256 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4257 | struct TypeParam { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4258 | string kind; |
| 4259 | string literal; |
| 4260 | }; |
| 4261 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4262 | const TypeParam kTypeParams[] = { |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 4263 | {"primitive", "int"}, {"primitiveArray", "int[]"}, |
| 4264 | {"String", "String"}, {"StringArray", "String[]"}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4265 | {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"}, |
| 4266 | {"parcelable", "Foo"}, {"enum", "a.Enum"}, |
| 4267 | {"union", "a.Union"}, {"interface", "a.IBar"}, |
| 4268 | }; |
| 4269 | |
| 4270 | const std::map<std::string, std::string> kListSupportExpectations = { |
| 4271 | {"cpp_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4272 | {"java_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4273 | {"ndk_primitive", "A generic type cannot have any primitive type parameters."}, |
| 4274 | {"rust_primitive", "A generic type cannot have any primitive type parameters."}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 4275 | {"cpp_primitiveArray", "List of arrays is not supported."}, |
| 4276 | {"java_primitiveArray", "List of arrays is not supported."}, |
| 4277 | {"ndk_primitiveArray", "List of arrays is not supported."}, |
| 4278 | {"rust_primitiveArray", "List of arrays is not supported."}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4279 | {"cpp_String", ""}, |
| 4280 | {"java_String", ""}, |
| 4281 | {"ndk_String", ""}, |
| 4282 | {"rust_String", ""}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 4283 | {"cpp_StringArray", "List of arrays is not supported."}, |
| 4284 | {"java_StringArray", "List of arrays is not supported."}, |
| 4285 | {"ndk_StringArray", "List of arrays is not supported."}, |
| 4286 | {"rust_StringArray", "List of arrays is not supported."}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4287 | {"cpp_IBinder", ""}, |
| 4288 | {"java_IBinder", ""}, |
| 4289 | {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."}, |
| 4290 | {"rust_IBinder", ""}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 4291 | {"cpp_ParcelFileDescriptor", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4292 | {"java_ParcelFileDescriptor", ""}, |
| 4293 | {"ndk_ParcelFileDescriptor", ""}, |
| 4294 | {"rust_ParcelFileDescriptor", ""}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 4295 | {"cpp_interface", "List<a.IBar> is not supported."}, |
| 4296 | {"java_interface", "List<a.IBar> is not supported."}, |
| 4297 | {"ndk_interface", "List<a.IBar> is not supported."}, |
| 4298 | {"rust_interface", "List<a.IBar> is not supported."}, |
| 4299 | {"cpp_parcelable", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4300 | {"java_parcelable", ""}, |
| 4301 | {"ndk_parcelable", ""}, |
| 4302 | {"rust_parcelable", ""}, |
| 4303 | {"cpp_enum", "A generic type cannot have any primitive type parameters."}, |
| 4304 | {"java_enum", "A generic type cannot have any primitive type parameters."}, |
| 4305 | {"ndk_enum", "A generic type cannot have any primitive type parameters."}, |
| 4306 | {"rust_enum", "A generic type cannot have any primitive type parameters."}, |
Jooyung Han | 55f96ad | 2020-12-13 10:08:33 +0900 | [diff] [blame] | 4307 | {"cpp_union", ""}, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4308 | {"java_union", ""}, |
| 4309 | {"ndk_union", ""}, |
| 4310 | {"rust_union", ""}, |
| 4311 | }; |
| 4312 | |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 4313 | const std::map<std::string, std::string> kArraySupportExpectations = { |
| 4314 | {"cpp_primitive", ""}, |
| 4315 | {"java_primitive", ""}, |
| 4316 | {"ndk_primitive", ""}, |
| 4317 | {"rust_primitive", ""}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 4318 | {"cpp_primitiveArray", "Can only have one dimensional arrays."}, |
| 4319 | {"java_primitiveArray", "Can only have one dimensional arrays."}, |
| 4320 | {"ndk_primitiveArray", "Can only have one dimensional arrays."}, |
| 4321 | {"rust_primitiveArray", "Can only have one dimensional arrays."}, |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 4322 | {"cpp_String", ""}, |
| 4323 | {"java_String", ""}, |
| 4324 | {"ndk_String", ""}, |
| 4325 | {"rust_String", ""}, |
Jooyung Han | cea8900 | 2021-02-15 17:04:04 +0900 | [diff] [blame] | 4326 | {"cpp_StringArray", "Can only have one dimensional arrays."}, |
| 4327 | {"java_StringArray", "Can only have one dimensional arrays."}, |
| 4328 | {"ndk_StringArray", "Can only have one dimensional arrays."}, |
| 4329 | {"rust_StringArray", "Can only have one dimensional arrays."}, |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 4330 | {"cpp_IBinder", ""}, |
| 4331 | {"java_IBinder", ""}, |
| 4332 | {"ndk_IBinder", "The ndk backend does not support array of IBinder"}, |
| 4333 | {"rust_IBinder", "The rust backend does not support array of IBinder"}, |
| 4334 | {"cpp_ParcelFileDescriptor", ""}, |
| 4335 | {"java_ParcelFileDescriptor", ""}, |
| 4336 | {"ndk_ParcelFileDescriptor", ""}, |
| 4337 | {"rust_ParcelFileDescriptor", ""}, |
| 4338 | {"cpp_interface", "Binder type cannot be an array"}, |
| 4339 | {"java_interface", "Binder type cannot be an array"}, |
| 4340 | {"ndk_interface", "Binder type cannot be an array"}, |
| 4341 | {"rust_interface", "Binder type cannot be an array"}, |
| 4342 | {"cpp_parcelable", ""}, |
| 4343 | {"java_parcelable", ""}, |
| 4344 | {"ndk_parcelable", ""}, |
| 4345 | {"rust_parcelable", ""}, |
| 4346 | {"cpp_enum", ""}, |
| 4347 | {"java_enum", ""}, |
| 4348 | {"ndk_enum", ""}, |
| 4349 | {"rust_enum", ""}, |
| 4350 | {"cpp_union", ""}, |
| 4351 | {"java_union", ""}, |
| 4352 | {"ndk_union", ""}, |
| 4353 | {"rust_union", ""}, |
| 4354 | }; |
| 4355 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4356 | class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4357 | public: |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4358 | void Run(const std::string& generic_type_decl, |
| 4359 | const std::map<std::string, std::string>& expectations) { |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4360 | const auto& param = GetParam(); |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4361 | const auto& lang = to_string(std::get<0>(param)); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4362 | const auto& kind = std::get<1>(param).kind; |
| 4363 | |
| 4364 | FakeIoDelegate io; |
| 4365 | io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }"); |
| 4366 | io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }"); |
| 4367 | io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }"); |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4368 | std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal); |
| 4369 | io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }"); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4370 | |
| 4371 | const auto options = |
| 4372 | Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang)); |
| 4373 | CaptureStderr(); |
| 4374 | compile_aidl(options, io); |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4375 | auto it = expectations.find(lang + "_" + kind); |
| 4376 | EXPECT_TRUE(it != expectations.end()); |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4377 | const string err = GetCapturedStderr(); |
| 4378 | if (it->second.empty()) { |
| 4379 | EXPECT_EQ("", err); |
| 4380 | } else { |
| 4381 | EXPECT_THAT(err, testing::HasSubstr(it->second)); |
| 4382 | } |
| 4383 | } |
| 4384 | }; |
| 4385 | |
| 4386 | INSTANTIATE_TEST_SUITE_P( |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4387 | AidlTestSuite, AidlTypeParamTest, |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4388 | testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA, |
| 4389 | Options::Language::NDK, Options::Language::RUST), |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4390 | testing::ValuesIn(kTypeParams)), |
| 4391 | [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) { |
Jooyung Han | 9435e9a | 2021-01-06 10:16:31 +0900 | [diff] [blame] | 4392 | return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind; |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4393 | }); |
| 4394 | |
Jooyung Han | fd3be32 | 2020-12-13 09:11:06 +0900 | [diff] [blame] | 4395 | TEST_P(AidlTypeParamTest, ListSupportedTypes) { |
| 4396 | Run("List<{}>", kListSupportExpectations); |
| 4397 | } |
Jooyung Han | e87cdd0 | 2020-12-11 16:47:35 +0900 | [diff] [blame] | 4398 | |
Jooyung Han | d236e55 | 2020-12-13 09:21:27 +0900 | [diff] [blame] | 4399 | TEST_P(AidlTypeParamTest, ArraySupportedTypes) { |
| 4400 | Run("{}[]", kArraySupportExpectations); |
| 4401 | } |
| 4402 | |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 4403 | } // namespace aidl |
| 4404 | } // namespace android |