blob: 25437f92dc9ceaf9ddb5d93b04e6e294b8209bef [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090038#include "parser.h"
39#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070040#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041
42using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080043using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090044using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070046using std::string;
47using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080048using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090049using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070050using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090051using testing::internal::CaptureStderr;
52using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070053
54namespace android {
55namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070056namespace {
57
58const char kExpectedDepFileContents[] =
59R"(place/for/output/p/IFoo.java : \
60 p/IFoo.aidl
61
62p/IFoo.aidl :
63)";
64
Dan Willemsen93298ee2016-11-10 23:55:55 -080065const char kExpectedNinjaDepFileContents[] =
66R"(place/for/output/p/IFoo.java : \
67 p/IFoo.aidl
68)";
69
Jiyong Parkdf202122019-09-30 20:48:35 +090070const char kExpectedParcelableDeclarationDepFileContents[] =
71 R"( : \
72 p/Foo.aidl
73
74p/Foo.aidl :
75)";
76
77const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080078 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070079 p/Foo.aidl
80
81p/Foo.aidl :
82)";
83
Christopher Wileyf8136192016-04-12 14:19:35 -070084} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070085
Devin Moore7b8d5c92020-03-17 14:14:08 -070086class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070087 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090088 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
89 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070090 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070091 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090092 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070093 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090094 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070095 for (const string& s : additional_arguments) {
96 args.emplace_back(s);
97 }
98 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--preprocessed=" + f);
100 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700101 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900102 args.emplace_back("--include=" + i);
103 }
104 args.emplace_back(path);
105 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900106 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900107 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900109 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900110
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700111 if (error != nullptr) {
112 *error = actual_error;
113 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900114
115 if (actual_error != AidlError::OK) {
116 return nullptr;
117 }
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900120 EXPECT_EQ(1ul, defined_types.size());
121
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900122 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700123 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124
Devin Moore7b8d5c92020-03-17 14:14:08 -0700125 Options::Language GetLanguage() { return GetParam(); }
126
Christopher Wiley0522cd52015-10-28 15:39:44 -0700127 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800128 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900129 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900130 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700131};
132
Devin Moore7b8d5c92020-03-17 14:14:08 -0700133// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
134// tests with each of the supported languages as a parameter.
135INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
136 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700137 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700138 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900139 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 });
141
142TEST_P(AidlTest, AcceptMissingPackage) {
143 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700144}
145
Devin Moore7b8d5c92020-03-17 14:14:08 -0700146TEST_P(AidlTest, EndsInSingleLineComment) {
147 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700148}
149
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000150TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
151 const string expected_stderr =
152 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
153 const std::string file_contents = "package a; interface IBar {}";
154 CaptureStderr();
155 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
156 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
157}
158
159TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
160 const string expected_stderr =
161 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
162 const std::string file_contents = "package a; interface Bar {}";
163 CaptureStderr();
164 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
165 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
166}
167
168TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
169 const string expected_stderr =
170 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
171 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
172 CaptureStderr();
173 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
174 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
175}
176
177TEST_P(AidlTest, EnumRequiresCorrectPath) {
178 const string expected_stderr =
179 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
180 const std::string file_contents = "package a; enum Bar { A, }";
181 CaptureStderr();
182 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
183 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
184}
185
Devin Moore7b8d5c92020-03-17 14:14:08 -0700186TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900187 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700188 io_delegate_.SetFileContents("bar/IBar.aidl",
189 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700190 const string path = "foo/IFoo.aidl";
191 const string contents =
192 "package foo;\n"
193 "import bar.IBar;\n"
194 "interface IFoo { void f(in IBar[] input); }";
195 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
196 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700197 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700199}
200
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700202 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900204}
Devin Moore097a3ab2020-03-11 16:08:44 -0700205
Jiyong Park40782d02020-07-24 19:17:43 +0900206TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700207 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
208 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900209 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
210 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700211 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900214}
215
Jiyong Park40782d02020-07-24 19:17:43 +0900216TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900217 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700218 const string expected_stderr =
219 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700220 CaptureStderr();
221 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900223}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224
Jiyong Park40782d02020-07-24 19:17:43 +0900225TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900226 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900227 const string expected_stderr =
228 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700229 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700230 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700232}
233
Devin Moore7b8d5c92020-03-17 14:14:08 -0700234TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700235 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
236 const string expected_stderr =
237 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
238 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700239 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700241}
242
Devin Moore7b8d5c92020-03-17 14:14:08 -0700243TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700244 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
245 const string expected_stderr =
246 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
247 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800250}
251
Devin Moore2f2077a2020-08-28 11:27:53 -0700252TEST_P(AidlTest, AcceptNullableList) {
253 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
254 const string expected_stderr = "";
255 CaptureStderr();
256 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
258}
259
Jooyung Han01720ed2021-08-13 07:46:07 +0900260TEST_P(AidlTest, RejectRecursiveParcelable) {
261 CaptureStderr();
262 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
263 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
264}
265
266TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
267 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
268 import_paths_.emplace("");
269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
271 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
272}
273
274TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
275 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
276 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
277 import_paths_.emplace("");
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
280 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
281}
282
283TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
284 CaptureStderr();
285 std::string java_only_map_field;
286 if (GetLanguage() == Options::Language::JAVA) {
287 java_only_map_field = " Map<String, Foo> map;\n";
288 }
289 EXPECT_NE(nullptr, Parse("Foo.aidl",
290 "parcelable Foo {\n"
291 " List<Foo> list;\n" +
292 java_only_map_field +
293 " Foo[] arr;\n"
294 " @nullable(heap=true) Foo heap_nullable;\n"
295 "}\n",
296 typenames_, GetLanguage()));
297 EXPECT_THAT(GetCapturedStderr(), "");
298}
299
300TEST_P(AidlTest, InterfaceCanReferenceItself) {
301 CaptureStderr();
302 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
303 GetLanguage()));
304 EXPECT_THAT(GetCapturedStderr(), "");
305}
306
307TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
308 CaptureStderr();
309 EXPECT_EQ(nullptr, Parse("Foo.aidl",
310 "parcelable Foo {\n"
311 " @nullable(heap=true) String s;\n"
312 "}",
313 typenames_, GetLanguage()));
314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
315}
316
Devin Moore7b8d5c92020-03-17 14:14:08 -0700317TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700318 const string method = "package a; interface IFoo { void f(int a, int a); }";
319 const string expected_stderr =
320 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700324}
325
Jeongik Cha13066da2020-08-06 15:43:19 +0900326TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
327 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900328 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900329 CaptureStderr();
330 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
332}
333
Jooyung Hand902a972020-10-23 17:32:44 +0900334TEST_P(AidlTest, RejectsRepeatedAnnotations) {
335 const string method = R"(@Hide @Hide parcelable Foo {})";
336 const string expected_stderr =
337 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
338 "Foo.aidl:1.1-6\n";
339 CaptureStderr();
340 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
342}
343
Jooyung Han05bd8a82021-04-28 23:56:38 +0900344TEST_P(AidlTest, AcceptsEmptyParcelable) {
345 CaptureStderr();
346 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
347 EXPECT_EQ("", GetCapturedStderr());
348}
349
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
352 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 AidlError error;
360 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700361 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700362 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900363 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700364 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 AidlError error;
369 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700370 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700371 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900372 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700373 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700377 AidlError error;
378 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700379 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000380 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900381 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700382 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000387 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700388 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900390 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700391 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800392}
393
Jiyong Park40782d02020-07-24 19:17:43 +0900394TEST_P(AidlTest, ParsesNonNullableAnnotation) {
395 auto parse_result =
396 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
397 ASSERT_NE(nullptr, parse_result);
398 const AidlInterface* interface = parse_result->AsInterface();
399 ASSERT_NE(nullptr, interface);
400 ASSERT_FALSE(interface->GetMethods().empty());
401 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
402}
403
Devin Moore7b8d5c92020-03-17 14:14:08 -0700404TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900405 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
406 typenames_, GetLanguage());
407 ASSERT_NE(nullptr, parse_result);
408 const AidlInterface* interface = parse_result->AsInterface();
409 ASSERT_NE(nullptr, interface);
410 ASSERT_FALSE(interface->GetMethods().empty());
411 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
412}
413
414TEST_P(AidlTest, ParsesNonUtf8Annotations) {
415 auto parse_result =
416 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
417 ASSERT_NE(nullptr, parse_result);
418 const AidlInterface* interface = parse_result->AsInterface();
419 ASSERT_NE(nullptr, interface);
420 ASSERT_FALSE(interface->GetMethods().empty());
421 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800422}
423
Devin Moore7b8d5c92020-03-17 14:14:08 -0700424TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900425 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
426 typenames_, GetLanguage());
427 ASSERT_NE(nullptr, parse_result);
428 const AidlInterface* interface = parse_result->AsInterface();
429 ASSERT_NE(nullptr, interface);
430 ASSERT_FALSE(interface->GetMethods().empty());
431 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800432}
433
Devin Moore7b8d5c92020-03-17 14:14:08 -0700434TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700435 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700436 const string expected_stderr =
437 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
438 "\"vintf\"'\n"
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
440 "--structured\n";
441 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700442 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700443 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700444 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700445 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700446}
447
Devin Moore7b8d5c92020-03-17 14:14:08 -0700448TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700449 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700450 const string expected_stderr =
451 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
452 "--structured\n";
453 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700454 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700455 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700456 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700457 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700458}
459
Devin Moore7b8d5c92020-03-17 14:14:08 -0700460TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700461 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700462 const string expected_stderr =
463 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
464 "\"vintf\"'\n";
465 CaptureStderr();
466 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700467 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700468 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700469 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700470}
471
Devin Moore7b8d5c92020-03-17 14:14:08 -0700472TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700473 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
475 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700476 ASSERT_EQ(AidlError::OK, error);
477 ASSERT_NE(nullptr, parse_result);
478 const AidlInterface* interface = parse_result->AsInterface();
479 ASSERT_NE(nullptr, interface);
480 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700481}
482
Jeongik Cha64783ed2019-06-07 18:30:54 +0900483TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
484 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900485 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
486 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900487 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700488 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900490 "a/Foo.aidl",
491 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900492
Steven Moreland4e059132021-08-11 13:36:30 -0700493 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
494 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900495
Devin Moorec054bf82020-03-10 16:31:48 -0700496 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700497 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900498 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700499
500 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700501 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900502 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900503}
504
Jooyung Han1cbc4962020-10-25 10:07:15 +0900505TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
506 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
507 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
508 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700509 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900510
511 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900512 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900513 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
514
515 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900516 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700517 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900518
Jooyung Han1cbc4962020-10-25 10:07:15 +0900519 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700520 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900521}
522
Jooyung Han1cbc4962020-10-25 10:07:15 +0900523TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
524 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
525 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
526 CaptureStderr();
527 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700528 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900529 EXPECT_EQ("", GetCapturedStderr());
530
531 const string expected_to_string_method = R"--(
532 @Override
533 public String toString() {
534 switch (_tag) {
535 case a: return "a.Foo.a(" + (getA()) + ")";
536 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
537 }
538 throw new IllegalStateException("unknown field: " + _tag);
539 }
540)--";
541
542 string java_out;
543 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
544 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
545}
546
Jiyong Park9aa3d042020-12-04 23:30:02 +0900547TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
548 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
549 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
550 CaptureStderr();
551 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700552 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900553 EXPECT_EQ("", GetCapturedStderr());
554
555 const std::string expected = R"--(
556 @Override
557 public boolean equals(Object other) {
558 if (this == other) return true;
559 if (other == null) return false;
560 if (!(other instanceof Foo)) return false;
561 Foo that = (Foo)other;
562 if (!java.util.Objects.deepEquals(a, that.a)) return false;
563 if (!java.util.Objects.deepEquals(b, that.b)) return false;
564 return true;
565 }
566
567 @Override
568 public int hashCode() {
569 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
570 }
571)--";
572
573 string java_out;
574 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
575 EXPECT_THAT(java_out, testing::HasSubstr(expected));
576}
577
578TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
579 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
580 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
581 CaptureStderr();
582 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700583 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900584 EXPECT_EQ("", GetCapturedStderr());
585
586 const std::string expected = R"--(
587 @Override
588 public boolean equals(Object other) {
589 if (this == other) return true;
590 if (other == null) return false;
591 if (!(other instanceof Foo)) return false;
592 Foo that = (Foo)other;
593 if (_tag != that._tag) return false;
594 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
595 return true;
596 }
597
598 @Override
599 public int hashCode() {
600 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
601 }
602)--";
603
604 string java_out;
605 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
606 EXPECT_THAT(java_out, testing::HasSubstr(expected));
607}
608
Jooyung Han90345002020-10-23 15:28:53 +0900609TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900610 {
Jooyung Han90345002020-10-23 15:28:53 +0900611 io_delegate_.SetFileContents("a/Foo.aidl",
612 "package a; @JavaDerive(blah=true) parcelable Foo{}");
613 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
614 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700615 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900616 const std::string expected_stderr =
617 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900618 EXPECT_THAT(GetCapturedStderr(),
619 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900620 }
621
622 {
623 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900624 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
625 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700626 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900628 }
629
630 {
Jooyung Han90345002020-10-23 15:28:53 +0900631 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900632 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
633 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700634 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900635 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900636 }
637}
638
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900639TEST_P(AidlTest, ParseDescriptorAnnotation) {
640 AidlError error;
641 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
642 typenames_, GetLanguage(), &error, {"--structured"});
643 ASSERT_EQ(AidlError::OK, error);
644 ASSERT_NE(nullptr, parse_result);
645 const AidlInterface* interface = parse_result->AsInterface();
646 ASSERT_NE(nullptr, interface);
647 ASSERT_EQ("IBar", interface->GetDescriptor());
648}
649
Jooyung Han55db8112021-09-15 22:37:39 +0900650TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900651 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900652 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
653 GetLanguage()));
654 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
655
656 CaptureStderr();
657 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
658 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900659 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
660}
661
Jiyong Park40782d02020-07-24 19:17:43 +0900662TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700663 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700664 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900665}
666
667TEST_P(AidlTest, AcceptsOnewayInterface) {
668 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700669 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700670}
Christopher Wileyef140932015-11-03 09:29:19 -0800671
Devin Moore7b8d5c92020-03-17 14:14:08 -0700672TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700673 const string oneway_method =
674 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700675 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100676}
677
Steven Moreland65297cc2020-04-20 20:17:36 -0700678TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
679 const string oneway_method =
680 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
681 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
682 ASSERT_NE(nullptr, defined);
683 const AidlInterface* iface = defined->AsInterface();
684 ASSERT_NE(nullptr, iface);
685
686 const auto& methods = iface->GetMethods();
687 ASSERT_EQ(1u, methods.size());
688 const auto& method = methods[0];
689 const AidlTypeSpecifier& ret_type = method->GetType();
690
691 // TODO(b/151102494): these annotations should be on the method
692 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
693 ASSERT_TRUE(ret_type.IsHide());
694}
695
Devin Moore7b8d5c92020-03-17 14:14:08 -0700696TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100697 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900698 R"(package a;
699 /* foo */
700 interface IFoo {
701 /* i */
702 int i();
703 // j
704 @nullable String j();
705 // k1
706 /* k2 */
707 @UnsupportedAppUsage oneway void k(int a);
708 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100709
Jooyung Han8451a202021-01-16 03:07:06 +0900710 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700711 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100712 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900713 EXPECT_EQ("", GetCapturedStderr());
714
Jooyung Han161bb0f2021-01-21 12:30:16 +0900715 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100716
717 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900718 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
719 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
720 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100721}
722
Jooyung Han1a551d32020-10-05 15:37:26 +0900723TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
724 io_delegate_.SetFileContents("p/cpp_header.aidl",
725 R"(package p;
726 parcelable cpp_header cpp_header "bar/header";)");
727 import_paths_.emplace("");
728 const string input_path = "p/IFoo.aidl";
729 const string input = R"(package p;
730 import p.cpp_header;
731 interface IFoo {
732 // get bar
733 cpp_header get();
734 })";
735
736 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
737 EXPECT_NE(nullptr, parse_result);
738 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900739 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900740}
741
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900742TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
743 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
744 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
745 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700746 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900747 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
748}
749
750TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
751 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
752 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
753 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
754 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700755 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900756 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
757}
758
Christopher Wileyef140932015-11-03 09:29:19 -0800759TEST_F(AidlTest, ParsesPreprocessedFile) {
760 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
761 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700762 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900763 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
765 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800766}
767
768TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
769 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
770 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900771
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700772 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900773 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
775 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800776}
777
Devin Moore7b8d5c92020-03-17 14:14:08 -0700778TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800779 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
780 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
781 "interface IBar {}");
782 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900783 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900784 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700785 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800786 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900787
Christopher Wiley41544372015-11-03 14:52:29 -0800788 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700789 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
790 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800791 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900792 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900793 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900794 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800795}
796
Jiyong Park8f6ec462020-01-19 20:52:47 +0900797// Special case of PreferImportToPreprocessed. Imported type should be preferred
798// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700799TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900800 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
801 io_delegate_.SetFileContents("one/IBar.aidl",
802 "package one; "
803 "interface IBar {}");
804 preprocessed_files_.push_back("preprocessed");
805 import_paths_.emplace("");
806 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700807 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900808 EXPECT_NE(nullptr, parse_result);
809
810 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700811 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
812 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900813 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900814 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900815 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900816 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
817}
818
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800819TEST_F(AidlTest, WritePreprocessedFile) {
820 io_delegate_.SetFileContents("p/Outer.aidl",
821 "package p; parcelable Outer.Inner;");
822 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
823 "interface IBar {}");
824
Jooyung Han93f48f02021-06-05 00:11:16 +0900825 vector<string> args{"aidl", "--preprocess", "preprocessed",
826 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900827 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900828 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800829
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 std::map<std::string, std::string> expected = {{"preprocessed",
831 "parcelable p.Outer.Inner;\n"
832 "interface one.IBar {\n"
833 "}\n"}};
834 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
835}
836
837TEST_F(AidlTest, PreprocessVariousThings) {
838 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
839 "package foo.bar;\n"
840 "interface IFoo {\n"
841 " int foo();\n"
842 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
843 "}\n");
844 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
845 "package foo.bar;\n"
846 "parcelable Bar {\n"
847 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
848 " imported.Foo foo;\n"
849 "}\n");
850 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
851 "package foo.bar;\n"
852 "parcelable Gen<T> {\n"
853 "}\n");
854 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
855 "package foo.bar;\n"
856 "enum Enum {\n"
857 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
858 "}\n");
859 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
860 "package imported;\n"
861 "parcelable Foo {\n"
862 " const int FOO = 42;\n"
863 "}\n");
864
865 vector<string> args = {
866 "aidl",
867 "--preprocess",
868 "preprocessed",
869 "-Isub",
870 "-I.",
871 "foo/bar/IFoo.aidl",
872 "foo/bar/Bar.aidl",
873 "foo/bar/Gen.aidl",
874 "foo/bar/Enum.aidl",
875 };
876 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
877 std::string preprocessed =
878 "interface foo.bar.IFoo {\n"
879 " const int FOO = 44;\n"
880 "}\n"
881 "parcelable foo.bar.Bar {\n"
882 " const int BAR = 43;\n"
883 "}\n"
884 "parcelable foo.bar.Gen<T> {\n"
885 "}\n"
886 "enum foo.bar.Enum {\n"
887 " FOO = 3,\n"
888 " BAR = 6,\n"
889 "}\n";
890 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
891 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
892
893 // use preprocessed
894 io_delegate_.SetFileContents("a/Foo.aidl",
895 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
896 io_delegate_.SetFileContents("preprocessed", preprocessed);
897 CaptureStderr();
898 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700899 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900900 EXPECT_EQ("", GetCapturedStderr());
901 string code;
902 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
903 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
904}
905
Jooyung Han35784982021-06-29 06:26:12 +0900906TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
907 io_delegate_.SetFileContents("p/IFoo.aidl",
908 "package p;\n"
909 "import x.Outer;\n"
910 "interface IFoo {\n"
911 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
912 "}");
913 io_delegate_.SetFileContents("imported/x/Outer.aidl",
914 "package x;\n"
915 "parcelable Outer.Inner1;\n"
916 "parcelable Outer.Inner2;\n");
917 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
918 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700919 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900920 EXPECT_EQ("", GetCapturedStderr());
921}
922
923TEST_F(AidlTest,
924 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
925 // Main doc(Foo.aidl) is loaded
926 // And then framework.aidl is loaded as preprocessed. (conflict)
927 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
928 io_delegate_.SetFileContents("x/Foo.aidl",
929 "package x;\n"
930 "parcelable Foo.Inner;\n");
931 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
932 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700933 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900934 EXPECT_EQ("", GetCapturedStderr());
935}
936
937TEST_F(AidlTest,
938 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
939 // Main doc(IBar.aidl) is loaded first.
940 // Framework.aidl is loaded as preprocessed.
941 // And then import(Foo.aidl) is loaded. (conflict)
942 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
943 io_delegate_.SetFileContents("x/IBar.aidl",
944 "package x;\n"
945 "import x.Foo;\n"
946 "interface IBar {\n"
947 " void bar(in Foo.Inner inner);\n"
948 "}");
949 io_delegate_.SetFileContents("x/Foo.aidl",
950 "package x;\n"
951 "parcelable Foo.Inner;\n");
952 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
953 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700954 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900955 EXPECT_EQ("", GetCapturedStderr());
956}
957
Jooyung Han93f48f02021-06-05 00:11:16 +0900958TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
959 string simple_content = "package xxx; parcelable a.Foo;";
960 io_delegate_.SetFileContents("path", simple_content);
961 CaptureStderr();
962 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
963 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
964}
965
966TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
967 string simple_content = "parcelable a.Foo {}";
968 io_delegate_.SetFileContents("path", simple_content);
969 CaptureStderr();
970 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
971 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800972}
973
Jooyung Han13f1fa52021-06-11 18:06:12 +0900974TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
975 string contents = R"(
976 interface android.os.IBinder;
977 interface android.os.IInterface;
978 parcelable android.os.ParcelFileDescriptor;
979 )";
980 io_delegate_.SetFileContents("path", contents);
981 CaptureStderr();
982 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
983 EXPECT_THAT(GetCapturedStderr(), "");
984}
985
Jooyung Han720253d2021-01-05 19:13:17 +0900986TEST_P(AidlTest, SupportDeprecated) {
987 struct TestCase {
988 std::string output_file;
989 std::string annotation;
990 };
991
992 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900993 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900994 io_delegate_.SetFileContents(filename, contents);
995
996 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
997 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -0700998 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900999 for (const auto& [lang, test_case] : expectations) {
1000 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001001 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001002 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001003 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1004 }
1005 };
1006
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001007 // Emit escaped string for notes
1008 CheckDeprecated(
1009 "IFoo.aidl",
1010 R"(interface IFoo {
1011 /**
1012 * @note asdf
1013 * @deprecated a really long deprecation message
1014 *
1015 * which is really long
1016 * @param foo bar
1017 */
1018 List<String> foo();
1019 })",
1020 {
1021 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1022 {Options::Language::CPP,
1023 {"out/IFoo.h",
1024 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1025 {Options::Language::NDK,
1026 {"out/aidl/IFoo.h",
1027 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1028 {Options::Language::RUST,
1029 {"out/IFoo.rs",
1030 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1031 });
1032
Jooyung Han24effbf2021-01-16 10:24:03 +09001033 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001034 CheckDeprecated(
1035 "IFoo.aidl",
1036 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001037 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001038 " List<String> foo();\n"
1039 "}",
1040 {
1041 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001042 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001043 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1044 {Options::Language::NDK,
1045 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1047 });
Jooyung Han720253d2021-01-05 19:13:17 +09001048
Jooyung Han24effbf2021-01-16 10:24:03 +09001049 // but not in line comments
1050 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1051 EXPECT_FALSE(parsed->IsDeprecated());
1052
1053 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001054 CheckDeprecated("Foo.aidl",
1055 "parcelable Foo {\n"
1056 " /** @deprecated use bar*/\n"
1057 " int foo = 0;\n"
1058 "}",
1059 {
1060 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1061 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1062 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1063 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1064 });
1065
Jooyung Han24effbf2021-01-16 10:24:03 +09001066 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001067 CheckDeprecated("IFoo.aidl",
1068 "interface IFoo {\n"
1069 " /** @deprecated use bar*/\n"
1070 " const int FOO = 0;\n"
1071 "}",
1072 {
1073 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1074 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1075 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1076 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1077 });
1078
1079 // union fields
1080 CheckDeprecated("Foo.aidl",
1081 "union Foo {\n"
1082 " int bar = 0;\n"
1083 " /** @deprecated use bar*/\n"
1084 " int foo;\n"
1085 "}",
1086 {
1087 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1088 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1089 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1090 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1091 });
1092
1093 CheckDeprecated("Foo.aidl",
1094 "/** @deprecated use Bar */\n"
1095 "parcelable Foo {}",
1096 {
1097 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1098 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1099 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1100 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1101 });
1102
1103 CheckDeprecated("Foo.aidl",
1104 "/** @deprecated use Bar */\n"
1105 "union Foo { int foo = 0; }",
1106 {
1107 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1108 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1109 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1110 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1111 });
1112
1113 CheckDeprecated("IFoo.aidl",
1114 "/** @deprecated use IBar */\n"
1115 "interface IFoo {}",
1116 {
1117 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1118 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1119 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1120 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1121 });
1122
1123 CheckDeprecated("Foo.aidl",
1124 "/** @deprecated use IBar */\n"
1125 "enum Foo { FOO }",
1126 {
1127 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1128 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1129 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001130 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001131 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1132 });
1133}
1134
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001136 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001137 io_delegate_.SetFileContents("p/Outer.aidl",
1138 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001139 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001140 CaptureStderr();
1141 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1142 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001144 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001145}
1146
Devin Moore7b8d5c92020-03-17 14:14:08 -07001147TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001148 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001149 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001150 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001151 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001152 // TODO(wiley): This should actually return nullptr because we require
1153 // the outer class name. However, for legacy reasons,
1154 // this behavior must be maintained. b/17415692
1155 EXPECT_NE(nullptr, parse_result);
1156}
1157
Jooyung Han05a532a2021-08-18 10:41:40 +09001158TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1159 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1160
1161 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1162 CaptureStderr();
1163 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1164 EXPECT_EQ("", GetCapturedStderr());
1165}
1166
Christopher Wiley632801d2015-11-05 14:15:49 -08001167TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001168 const string expected_foo_stderr =
1169 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1170 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1171 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001172 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1173
Christopher Wiley632801d2015-11-05 14:15:49 -08001174 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001175 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001176 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001177 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001179
Steven Morelande2c64b42018-09-18 15:06:37 -07001180 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001182 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001183 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001185
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 const string expected_bar_stderr =
1187 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1188 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1189 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001190 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1191
Jiyong Parkda8c6932019-08-12 19:56:08 +09001192 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001193 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001194 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001195 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001197 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001199 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001201}
1202
Jooyung Han13f1fa52021-06-11 18:06:12 +09001203TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1204 string contents = R"(
1205 import android.os.IBinder;
1206 import android.os.IInterface;
1207 interface IFoo {
1208 void foo(in IBinder b);
1209 }
1210 )";
1211 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1212}
1213
Devin Moore7b8d5c92020-03-17 14:14:08 -07001214TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001215 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001216 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001218 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1219 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001220 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001221 AidlError error;
1222 CaptureStderr();
1223 EXPECT_EQ(
1224 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001225 Parse("p/IFoo.aidl",
1226 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001227 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1229 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001230}
1231
Devin Moore7b8d5c92020-03-17 14:14:08 -07001232TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001233 AidlError error;
1234 const string expected_stderr =
1235 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1236 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001237 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1238 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001239 interface IFoo {
1240 const String DUPLICATED = "d";
1241 const int DUPLICATED = 1;
1242 }
1243 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001244 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001245 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1246 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001247}
1248
Steven Morelande689da22020-11-10 02:06:30 +00001249TEST_P(AidlTest, FailOnTooBigConstant) {
1250 AidlError error;
1251 const string expected_stderr =
1252 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1253 CaptureStderr();
1254 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1255 R"(package p;
1256 interface IFoo {
1257 const byte type2small = 256;
1258 }
1259 )",
1260 typenames_, GetLanguage(), &error));
1261 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1262 EXPECT_EQ(AidlError::BAD_TYPE, error);
1263}
1264
Jooyung Han30f64ad2020-12-15 08:16:31 +09001265TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1266 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1267 CaptureStderr();
1268 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001269 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001270 EXPECT_EQ("", GetCapturedStderr());
1271 string code;
1272 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1273 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1274}
1275
Jooyung Han535c5e82020-12-29 15:16:59 +09001276TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001277 using Ptr = unique_ptr<AidlConstantValue>;
1278 const AidlLocation& loc = AIDL_LOCATION_HERE;
1279
Jooyung Han535c5e82020-12-29 15:16:59 +09001280 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1281 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1282 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1283 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001284
1285 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1286 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001287 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001288
1289 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1290 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1291 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1292 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001293 EXPECT_EQ(
1294 expected,
1295 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001296}
1297
Devin Moore7b8d5c92020-03-17 14:14:08 -07001298TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001299 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001300 const string expected_stderr =
1301 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001302 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001303 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1304 R"(package p;
1305 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001306 parcelable IBar {}
1307 parcelable StructuredParcelable {}
1308 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001309 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001310 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001312 // Parse success is important for clear error handling even if the cases aren't
1313 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001314 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001315}
1316
Devin Moore7b8d5c92020-03-17 14:14:08 -07001317TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001318 AidlError error;
1319 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001321 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1323 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001324}
1325
Steven Morelandf9e922f2020-07-08 21:15:27 +00001326TEST_P(AidlTest, FailOnEmptyListWithComma) {
1327 AidlError error;
1328 const string expected_stderr =
1329 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1330 CaptureStderr();
1331 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1332 typenames_, GetLanguage(), &error));
1333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1334 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1335}
1336
Devin Moore7b8d5c92020-03-17 14:14:08 -07001337TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001338 AidlError error;
1339 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001340 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001341 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001342 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1343 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001344 interface IFoo {
1345 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1346 }
1347 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001348 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001349 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1350 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001351}
1352
Jiyong Park18132182020-06-08 20:24:40 +09001353TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1354 AidlError error;
1355 const string expected_stderr =
1356 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1357 "cpp_header (which can also be used as an identifier)\n";
1358 CaptureStderr();
1359 // Notice the trailing dot(.) in the name, which isn't a correct name
1360 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1361 GetLanguage(), &error));
1362 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1363 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1364}
1365
1366TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1367 AidlError error;
1368 const string expected_stderr =
1369 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1370 "cpp_header (which can also be used as an identifier)\n";
1371 CaptureStderr();
1372 // Notice the trailing dot(.) in the package name
1373 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1374 GetLanguage(), &error));
1375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1376 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1377}
1378
Devin Moore7b8d5c92020-03-17 14:14:08 -07001379TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001380 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381 auto parse_result = Parse("p/IFoo.aidl",
1382 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001383 interface IFoo {
1384 const int POSITIVE_HEX_VALUE = 0xf5;
1385 }
1386 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001387 typenames_, GetLanguage(), &error);
1388 EXPECT_NE(nullptr, parse_result);
1389 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001390 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001391 const auto& cpp_constants = interface->GetConstantDeclarations();
1392 EXPECT_EQ((size_t)1, cpp_constants.size());
1393 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001394 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001395 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001396}
1397
Devin Moore7b8d5c92020-03-17 14:14:08 -07001398TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001399 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400 auto parse_result = Parse("p/IFoo.aidl",
1401 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001402 interface IFoo {
1403 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1404 }
1405 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001406 typenames_, GetLanguage(), &error);
1407 ASSERT_NE(nullptr, parse_result);
1408 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001409 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001410 const auto& cpp_constants = interface->GetConstantDeclarations();
1411 EXPECT_EQ((size_t)1, cpp_constants.size());
1412 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001413 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001414 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001415}
1416
Devin Moore7b8d5c92020-03-17 14:14:08 -07001417TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001418 io_delegate_.SetFileContents(
1419 "p/Outer.aidl",
1420 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001421 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001422 const string input_path = "p/IFoo.aidl";
1423 const string input = "package p; import p.Outer; interface IFoo"
1424 " { Outer.Inner get(); }";
1425
Devin Moore7b8d5c92020-03-17 14:14:08 -07001426 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1427 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001428
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001429 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001430 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001431 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001432 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001433}
1434
Jooyung Han78fcaa82021-06-11 22:27:57 +09001435TEST_P(AidlTest, UnderstandsNestedParcelablesWithoutImports) {
1436 io_delegate_.SetFileContents("p/Outer.aidl",
1437 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1438 import_paths_.emplace("");
1439 const string input_path = "p/IFoo.aidl";
1440 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1441
1442 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1443 EXPECT_NE(nullptr, parse_result);
1444
1445 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1446 // C++ uses "::" instead of "." to refer to a inner class.
1447 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1448 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1449}
1450
Jooyung Han0a950bd2021-05-15 12:50:36 +09001451TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001452 const string input_path = "p/Wrapper.aidl";
1453 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001454
1455 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1456 EXPECT_NE(nullptr, parse_result);
1457
1458 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1459 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1460 (..., params->emplace_back(std::move(type_params)));
1461 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1462 };
1463
1464 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1465 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001466 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001467 type->Annotate(std::move(annotations));
1468 return std::move(type);
1469 };
1470
1471 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1472 (void)type->SetArray();
1473 return std::move(type);
1474 };
1475
1476 auto w = type("p.Wrapper", type("String"));
1477 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1478
1479 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1480 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1481 cpp::CppNameOf(*nullable_w, typenames_));
1482
1483 auto array_w = set_array(type("p.Wrapper", type("String")));
1484 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1485 cpp::CppNameOf(*array_w, typenames_));
1486
1487 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1488 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1489 cpp::CppNameOf(*nullable_array_w, typenames_));
1490
1491 auto list_w = type("List", type("p.Wrapper", type("String")));
1492 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1493 cpp::CppNameOf(*list_w, typenames_));
1494
1495 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1496 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1497 cpp::CppNameOf(*nullable_list_w, typenames_));
1498}
1499
Devin Moore7b8d5c92020-03-17 14:14:08 -07001500TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001501 io_delegate_.SetFileContents(
1502 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001503 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001504 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001505 const string input_path = "p/IFoo.aidl";
1506 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001507 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1508 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001509 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001510 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001511 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001512
1513 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1514 // C++ understands C++ specific stuff
1515 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1516 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001517 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001518 EXPECT_EQ(1u, headers.size());
1519 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001520}
1521
Christopher Wileyf8136192016-04-12 14:19:35 -07001522TEST_F(AidlTest, WritesCorrectDependencyFile) {
1523 // While the in tree build system always gives us an output file name,
1524 // other android tools take advantage of our ability to infer the intended
1525 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001526 vector<string> args = {
1527 "aidl",
1528 "-d dep/file/path",
1529 "-o place/for/output",
1530 "p/IFoo.aidl"};
1531 Options options = Options::From(args);
1532 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001533 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001534 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001535 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001536 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1537}
1538
Dan Willemsen93298ee2016-11-10 23:55:55 -08001539TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1540 // While the in tree build system always gives us an output file name,
1541 // other android tools take advantage of our ability to infer the intended
1542 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001543 vector<string> args = {
1544 "aidl",
1545 "-d dep/file/path",
1546 "--ninja",
1547 "-o place/for/output",
1548 "p/IFoo.aidl"};
1549 Options options = Options::From(args);
1550 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001551 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001552 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001553 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001554 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1555}
1556
Jiyong Parkdf202122019-09-30 20:48:35 +09001557TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001558 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1559 // this by calling aidl with every .aidl file it finds, then parsing the
1560 // generated dependency files. Those that reference .java output files are
1561 // for interfaces and those that do not are parcelables. However, for both
1562 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001563 vector<string> args = {
1564 "aidl",
1565 "-o place/for/output",
1566 "-d dep/file/path",
1567 "p/Foo.aidl"};
1568 Options options = Options::From(args);
1569 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001570 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001571 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001572 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001573 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1574}
1575
1576TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1577 vector<string> args = {
1578 "aidl",
1579 "--structured",
1580 "-o place/for/output",
1581 "-d dep/file/path",
1582 "p/Foo.aidl"};
1583 Options options = Options::From(args);
1584 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001585 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001586 string actual_dep_file_contents;
1587 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1588 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001589}
1590
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001591TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1592 vector<string> args = {
1593 "aidl",
1594 "--lang=java",
1595 "-o place/for/output",
1596 "p/Foo.aidl"};
1597 Options options = Options::From(args);
1598 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001599 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001600 string output_file_contents;
1601 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1602}
1603
Devin Moore21b26772020-08-26 16:37:56 -07001604TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001605 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001606 const string list_array_parcelable =
1607 "package a; parcelable Foo {\n"
1608 " List[] lists; }";
1609 CaptureStderr();
1610 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1612}
1613
Jiyong Parkf8d53612020-05-04 14:06:13 +09001614TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1615 AidlError error;
1616 string expected_stderr =
1617 "ERROR: a/IFoo.aidl:2.7-11: "
1618 "Encountered an untyped List or Map. The use of untyped List/Map is "
1619 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1620 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1621 if (GetLanguage() != Options::Language::JAVA) {
1622 expected_stderr =
1623 "ERROR: a/IFoo.aidl:2.1-7: "
1624 "Currently, only the Java backend supports non-generic List.\n";
1625 }
1626
1627 const string primitive_interface =
1628 "package a; interface IFoo {\n"
1629 " List foo(); }";
1630 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001631 AidlTypenames tn1;
1632 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001633 {"--structured"}));
1634 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001635
1636 string primitive_parcelable =
1637 "package a; parcelable IFoo {\n"
1638 " List foo;}";
1639 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001640 AidlTypenames tn2;
1641 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001642 {"--structured"}));
1643 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1644}
1645
Jeongik Cha225519b2020-08-29 01:55:32 +09001646TEST_P(AidlTest, ExtensionTest) {
1647 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001648 string extendable_parcelable =
1649 "package a; parcelable Data {\n"
1650 " ParcelableHolder extension;\n"
1651 " ParcelableHolder extension2;\n"
1652 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001653 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001654 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1655 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001656 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001657 "yet.\n",
1658 GetCapturedStderr());
1659 } else {
1660 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1661 EXPECT_EQ("", GetCapturedStderr());
1662 }
1663}
1664TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1665 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001666 string parcelableholder_return_interface =
1667 "package a; interface IFoo {\n"
1668 " ParcelableHolder foo();\n"
1669 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001670 EXPECT_EQ(nullptr,
1671 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001672
Jeongik Cha8f02a532020-10-14 00:16:28 +09001673 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001674 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001675 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001676 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001677 "yet.\n",
1678 GetCapturedStderr());
1679 return;
1680 }
1681 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1682 GetCapturedStderr());
1683}
1684
1685TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1686 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001687 string extendable_parcelable_arg_interface =
1688 "package a; interface IFoo {\n"
1689 " void foo(in ParcelableHolder ph);\n"
1690 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001691 EXPECT_EQ(nullptr,
1692 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1693
Jeongik Cha8f02a532020-10-14 00:16:28 +09001694 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001695 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001696 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001697 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001698 "yet.\n",
1699 GetCapturedStderr());
1700 return;
1701 }
1702 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1703 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001704}
1705
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001706TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1707 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001708 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001709 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1710 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001711 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001712 if (GetLanguage() == Options::Language::RUST) {
1713 EXPECT_EQ(
1714 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1715 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1716 "yet.\n",
1717 GetCapturedStderr());
1718 return;
1719 }
1720 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1721}
1722
Jooyung Han3f347ca2020-12-01 12:41:50 +09001723TEST_P(AidlTest, ParcelablesWithConstants) {
1724 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001725 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001726 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001727 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001728 EXPECT_EQ("", GetCapturedStderr());
1729}
1730
1731TEST_P(AidlTest, UnionWithConstants) {
1732 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001733 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001734 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001735 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001736 EXPECT_EQ("", GetCapturedStderr());
1737}
1738
Jooyung Han633eab62021-01-07 14:12:40 +09001739TEST_F(AidlTest, ConstantsWithAnnotations) {
1740 io_delegate_.SetFileContents("IFoo.aidl",
1741 "interface IFoo {\n"
1742 " @JavaPassthrough(annotation=\"@Foo\")\n"
1743 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1744 "}");
1745 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1746 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001747 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09001748 EXPECT_EQ("", GetCapturedStderr());
1749 string code;
1750 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1751 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1752 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1753}
1754
Jiyong Park02da7422018-07-16 16:00:26 +09001755TEST_F(AidlTest, ApiDump) {
1756 io_delegate_.SetFileContents(
1757 "foo/bar/IFoo.aidl",
1758 "package foo.bar;\n"
1759 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001760 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001761 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001762 " /* @hide applied \n"
1763 " @deprecated use foo2 */\n"
1764 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1765 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001766 " IFoo foo3(IFoo foo);\n"
1767 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001768 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001769 " /** blahblah\n"
1770 " @deprecated\n"
1771 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001772 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001773 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001774 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001775 "}\n");
1776 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1777 "package foo.bar;\n"
1778 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001779 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001780 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001781 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001782 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001783 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001784 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001785 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001786 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001787 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001788 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001789 "}\n");
1790 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001791 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1792 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001793 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001794 bool result = dump_api(options, io_delegate_);
1795 ASSERT_TRUE(result);
1796 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001797 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001798 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001799interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001800 /**
1801 * @hide
1802 * @deprecated use foo2
1803 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001804 int foo(out int[] a, String b, boolean c, inout List<String> d);
1805 int foo2(@utf8InCpp String x, inout List<String> y);
1806 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1807 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001808 /**
1809 * @deprecated reason why...
1810 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001811 const int A = 1;
1812 const String STR = "Hello";
1813}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001814)"),
1815 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001816
Jiyong Parke59c3682018-09-11 23:10:25 +09001817 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001818 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001819/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001820parcelable Data {
1821 int x = 10;
1822 int y;
1823 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001824 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001825}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001826)"),
1827 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001828}
1829
Jiyong Parked65bf42018-08-28 15:43:27 +09001830TEST_F(AidlTest, ApiDumpWithManualIds) {
1831 io_delegate_.SetFileContents(
1832 "foo/bar/IFoo.aidl",
1833 "package foo.bar;\n"
1834 "interface IFoo {\n"
1835 " int foo() = 1;\n"
1836 " int bar() = 2;\n"
1837 " int baz() = 10;\n"
1838 "}\n");
1839
Jiyong Parke59c3682018-09-11 23:10:25 +09001840 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001841 Options options = Options::From(args);
1842 bool result = dump_api(options, io_delegate_);
1843 ASSERT_TRUE(result);
1844 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001845 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001846 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001847interface IFoo {
1848 int foo() = 1;
1849 int bar() = 2;
1850 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001851}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001852)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001853}
1854
1855TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001856 const string expected_stderr =
1857 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1858 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001859 io_delegate_.SetFileContents(
1860 "foo/bar/IFoo.aidl",
1861 "package foo.bar;\n"
1862 "interface IFoo {\n"
1863 " int foo() = 1;\n"
1864 " int bar();\n"
1865 " int baz() = 10;\n"
1866 "}\n");
1867
Jiyong Parke59c3682018-09-11 23:10:25 +09001868 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001869 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001870 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001871 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001872 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001873}
1874
Jooyung Han965e31d2020-11-27 12:30:16 +09001875TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1876 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1877 "package foo.bar;\n"
1878 "interface IFoo {\n"
1879 " @utf8InCpp String foo();\n"
1880 " const @utf8InCpp String bar = \"bar\";\n"
1881 "}\n");
1882
1883 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1884 Options options = Options::From(args);
1885 CaptureStderr();
1886 EXPECT_TRUE(dump_api(options, io_delegate_));
1887 EXPECT_EQ("", GetCapturedStderr());
1888 string actual;
1889 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001890 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1891interface IFoo {
1892 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001893 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001894}
1895)"),
1896 actual);
1897}
1898
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001899TEST_F(AidlTest, ApiDumpWithEnums) {
1900 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1901 "package foo.bar;\n"
1902 "enum Enum {\n"
1903 " FOO,\n"
1904 " BAR = FOO + 1,\n"
1905 "}\n");
1906
1907 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1908 Options options = Options::From(args);
1909 CaptureStderr();
1910 EXPECT_TRUE(dump_api(options, io_delegate_));
1911 EXPECT_EQ("", GetCapturedStderr());
1912 string actual;
1913 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1914 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1915 "enum Enum {\n"
1916 " FOO = 0,\n"
1917 " BAR = 1,\n"
1918 "}\n"),
1919 actual);
1920}
1921
1922TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1923 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1924 "package foo.bar;\n"
1925 "enum Enum {\n"
1926 " FOO,\n"
1927 "}\n");
1928 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1929 "package foo.bar;\n"
1930 "import foo.bar.Enum;\n"
1931 "parcelable Foo {\n"
1932 " Enum e = Enum.FOO;\n"
1933 "}\n");
1934
1935 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1936 Options options = Options::From(args);
1937 CaptureStderr();
1938 EXPECT_TRUE(dump_api(options, io_delegate_));
1939 EXPECT_EQ("", GetCapturedStderr());
1940 string actual;
1941 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1942 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1943 "parcelable Foo {\n"
1944 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1945 "}\n"),
1946 actual);
1947}
1948
Jooyung Han71dfec32021-05-23 07:18:58 +09001949TEST_F(AidlTest, ApiDumpWithGenerics) {
1950 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1951 "package foo.bar;\n"
1952 "parcelable Foo<T, U> {\n"
1953 "}\n");
1954
1955 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1956 Options options = Options::From(args);
1957 CaptureStderr();
1958 EXPECT_TRUE(dump_api(options, io_delegate_));
1959 EXPECT_EQ("", GetCapturedStderr());
1960 string actual;
1961 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1962 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1963 "parcelable Foo<T, U> {\n"
1964 "}\n"),
1965 actual);
1966}
1967
Jooyung Hand9ee6f02021-09-13 17:27:24 +09001968TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
1969 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
1970 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
1971
1972 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
1973 Options options = Options::From(args);
1974 CaptureStderr();
1975 EXPECT_FALSE(dump_api(options, io_delegate_));
1976 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
1977}
1978
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001979TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001980 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001981 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1982 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001983 const string expected_map_stderr =
1984 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001985 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1986 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001987 "package p; interface IFoo {"
1988 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001989 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001990 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001991 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001992
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001993 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001994 "package p; interface IFoo {"
1995 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001996 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001997 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001998 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001999}
2000
Jeongik Chae48d9942020-01-02 17:39:00 +09002001TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002002 const string expected_stderr =
2003 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002004 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002005 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2006
2007 io_delegate_.SetFileContents("p/IFoo.aidl",
2008 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002009 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002010 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002011
2012 io_delegate_.SetFileContents("p/IFoo.aidl",
2013 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002014 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002015 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002016 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002017 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002018
2019 io_delegate_.SetFileContents("p/IFoo.aidl",
2020 "package p; interface IFoo {"
2021 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002022 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002023
2024 io_delegate_.SetFileContents("p/IFoo.aidl",
2025 "package p; interface IFoo {"
2026 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002027 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002028}
2029
Jeongik Chadf76dc72019-11-28 00:08:47 +09002030TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002031 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002032 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2033 io_delegate_.SetFileContents(options.InputFiles().front(),
2034 "package p; interface IFoo {"
2035 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002036 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002037 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002038 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002039}
2040
2041TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002042 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002043 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002044 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002045 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002046 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2047 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002048
Jooyung Han13f1fa52021-06-11 18:06:12 +09002049 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002050 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2051 io_delegate_.SetFileContents("p/IFoo.aidl",
2052 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002053 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002054 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002055 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002056 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002057 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002058 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002059 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002060 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002061 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002062 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002063 io_delegate_.SetFileContents("p/IFoo.aidl",
2064 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002065 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002066 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002067
2068 io_delegate_.SetFileContents("p/IFoo.aidl",
2069 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002070 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002071
2072 io_delegate_.SetFileContents("p/IFoo.aidl",
2073 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002074 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002075
Steven Moreland4e059132021-08-11 13:36:30 -07002076 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002077}
2078
Jeongik Cha0e426012019-07-29 15:57:02 +09002079TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2080 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002081 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2082 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002083 for (const auto& rawOption : rawOptions) {
2084 string expected_stderr =
2085 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002086 Options options = Options::From(rawOption);
2087 io_delegate_.SetFileContents(options.InputFiles().front(),
2088 "package foo.bar;\n"
2089 "interface IFoo1 { int foo(); }\n"
2090 "interface IFoo2 { int foo(); }\n"
2091 "parcelable Data1 { int a; int b;}\n"
2092 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002093 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002094 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002095 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002096
Jeongik Cha0e426012019-07-29 15:57:02 +09002097 io_delegate_.SetFileContents(options.InputFiles().front(),
2098 "package foo.bar;\n"
2099 "interface IFoo1 { int foo(); }\n"
2100 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002101 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002102 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002103 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002104
Devin Moore5de18ed2020-04-02 13:52:29 -07002105 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002106 io_delegate_.SetFileContents(options.InputFiles().front(),
2107 "package foo.bar;\n"
2108 "parcelable Data1 { int a; int b;}\n"
2109 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002110 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002111 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002112 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002113 }
2114}
2115
Devin Moorebdba2a82020-03-31 15:19:02 -07002116TEST_P(AidlTest, FailParseOnEmptyFile) {
2117 const string contents = "";
2118 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2119 CaptureStderr();
2120 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2121 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2122}
2123
Jiyong Parkb034bf02018-07-30 17:44:33 +09002124TEST_F(AidlTest, MultipleInputFiles) {
2125 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002126 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002127
2128 io_delegate_.SetFileContents(options.InputFiles().at(0),
2129 "package foo.bar;\n"
2130 "import foo.bar.Data;\n"
2131 "interface IFoo { Data getData(); }\n");
2132
2133 io_delegate_.SetFileContents(options.InputFiles().at(1),
2134 "package foo.bar;\n"
2135 "import foo.bar.IFoo;\n"
2136 "parcelable Data { IFoo foo; }\n");
2137
Steven Moreland4e059132021-08-11 13:36:30 -07002138 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002139
2140 string content;
2141 for (const auto file : {
2142 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2143 content.clear();
2144 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2145 EXPECT_FALSE(content.empty());
2146 }
2147}
2148
2149TEST_F(AidlTest, MultipleInputFilesCpp) {
2150 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002151 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002152
2153 io_delegate_.SetFileContents(options.InputFiles().at(0),
2154 "package foo.bar;\n"
2155 "import foo.bar.Data;\n"
2156 "interface IFoo { Data getData(); }\n");
2157
2158 io_delegate_.SetFileContents(options.InputFiles().at(1),
2159 "package foo.bar;\n"
2160 "import foo.bar.IFoo;\n"
2161 "parcelable Data { IFoo foo; }\n");
2162
Steven Moreland4e059132021-08-11 13:36:30 -07002163 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002164
2165 string content;
2166 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002167 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002168 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2169 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2170 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2171 content.clear();
2172 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2173 EXPECT_FALSE(content.empty());
2174 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002175}
2176
Andrei Homescub62afd92020-05-11 19:24:59 -07002177TEST_F(AidlTest, MultipleInputFilesRust) {
2178 Options options =
2179 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2180
2181 io_delegate_.SetFileContents(options.InputFiles().at(0),
2182 "package foo.bar;\n"
2183 "import foo.bar.Data;\n"
2184 "interface IFoo { Data getData(); }\n");
2185
2186 io_delegate_.SetFileContents(options.InputFiles().at(1),
2187 "package foo.bar;\n"
2188 "import foo.bar.IFoo;\n"
2189 "parcelable Data { IFoo foo; }\n");
2190
Steven Moreland4e059132021-08-11 13:36:30 -07002191 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002192
2193 string content;
2194 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2195 content.clear();
2196 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2197 EXPECT_FALSE(content.empty());
2198 }
2199}
2200
Devin Moore097a3ab2020-03-11 16:08:44 -07002201TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2202 const string expected_stderr =
2203 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002204 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2205 // int getInterfaceVersion() is one of the meta transactions
2206 io_delegate_.SetFileContents(options.InputFiles().front(),
2207 "package p; interface IFoo {"
2208 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002209 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002210 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2212}
Jiyong Park309668e2018-07-28 16:55:44 +09002213
Devin Moore097a3ab2020-03-11 16:08:44 -07002214TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2215 // boolean getInterfaceVersion() is not a meta transaction, but should be
2216 // prevented because return type is not part of a method signature
2217 const string expected_stderr =
2218 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2219 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002220 io_delegate_.SetFileContents(options.InputFiles().front(),
2221 "package p; interface IFoo {"
2222 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002223 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002224 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002225 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2226}
Jiyong Park309668e2018-07-28 16:55:44 +09002227
Devin Moore097a3ab2020-03-11 16:08:44 -07002228TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002229 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002230 const string expected_stderr =
2231 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2232 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002233 io_delegate_.SetFileContents(options.InputFiles().front(),
2234 "package p; interface IFoo {"
2235 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002236 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002237 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002239
2240 // this is not a meta interface method as it differs type arguments
2241 io_delegate_.SetFileContents(options.InputFiles().front(),
2242 "package p; interface IFoo {"
2243 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002244 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002245}
2246
Jooyung Hanb8a97772021-01-19 01:27:38 +09002247TEST_F(AidlTest, CheckApiForEquality) {
2248 CaptureStderr();
2249 Options options = Options::From("aidl --checkapi=equal old new");
2250
2251 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2252 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2253 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2254 "package p; interface IFoo{ @utf8InCpp String foo();}");
2255
2256 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2257 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2258}
2259
Daniel Norman85aed542019-08-21 12:01:14 -07002260TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002261 Options options = Options::From("aidl --checkapi old new");
2262 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2263 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2264 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2265 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2266
2267 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2268}
2269
Jiyong Park3656c3c2018-08-01 20:02:01 +09002270TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002271 Options options = Options::From("aidl --checkapi old new");
2272 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2273 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002274
2275 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2276}
2277
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002278TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2279 Options options = Options::From("aidl --checkapi old new");
2280 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2281 const string enum_definition = "package p; enum Enum { FOO }";
2282 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2283 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2284 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2285 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2286
2287 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2288}
2289
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002290TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2291 Options options = Options::From("aidl --checkapi old new -I import");
2292
2293 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2294 io_delegate_.SetFileContents("new/p/Foo.aidl",
2295 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2296 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2297
2298 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2299}
2300
Jooyung Han02a11be2021-02-11 13:18:06 +09002301TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2302 Options options = Options::From("aidl --checkapi=equal old new");
2303 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2304 const string enum_definition = "package p; enum Enum { FOO }";
2305 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2306 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2307 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2308 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2309 CaptureStderr();
2310 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2311 EXPECT_EQ("", GetCapturedStderr());
2312}
2313
Daniel Norman85aed542019-08-21 12:01:14 -07002314class AidlTestCompatibleChanges : public AidlTest {
2315 protected:
2316 Options options_ = Options::From("aidl --checkapi old new");
2317};
2318
2319TEST_F(AidlTestCompatibleChanges, NewType) {
2320 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2321 "package p;"
2322 "interface IFoo {"
2323 " void foo(int a);"
2324 "}");
2325 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2326 "package p;"
2327 "interface IFoo {"
2328 " void foo(int a);"
2329 "}");
2330 io_delegate_.SetFileContents("new/p/IBar.aidl",
2331 "package p;"
2332 "interface IBar {"
2333 " void bar();"
2334 "}");
2335 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2336}
2337
2338TEST_F(AidlTestCompatibleChanges, NewMethod) {
2339 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2340 "package p;"
2341 "interface IFoo {"
2342 " void foo(int a);"
2343 "}");
2344 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2345 "package p;"
2346 "interface IFoo {"
2347 " void foo(int a);"
2348 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002349 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002350 "}");
2351 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2352}
2353
2354TEST_F(AidlTestCompatibleChanges, NewField) {
2355 io_delegate_.SetFileContents("old/p/Data.aidl",
2356 "package p;"
2357 "parcelable Data {"
2358 " int foo;"
2359 "}");
2360 io_delegate_.SetFileContents("new/p/Data.aidl",
2361 "package p;"
2362 "parcelable Data {"
2363 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002364 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002365 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002366 "}");
2367 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2368}
2369
Jooyung Han05bd8a82021-04-28 23:56:38 +09002370TEST_F(AidlTestCompatibleChanges, NewField2) {
2371 io_delegate_.SetFileContents("old/p/Data.aidl",
2372 "package p;"
2373 "parcelable Data {"
2374 "}");
2375 io_delegate_.SetFileContents("new/p/Data.aidl",
2376 "package p;"
2377 "parcelable Data {"
2378 " int foo = 0;"
2379 "}");
2380 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2381}
2382
Daniel Norman85aed542019-08-21 12:01:14 -07002383TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2384 io_delegate_.SetFileContents("old/p/Enum.aidl",
2385 "package p;"
2386 "enum Enum {"
2387 " FOO = 1,"
2388 "}");
2389 io_delegate_.SetFileContents("new/p/Enum.aidl",
2390 "package p;"
2391 "enum Enum {"
2392 " FOO = 1,"
2393 " BAR = 2,"
2394 "}");
2395 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2396}
2397
2398TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2399 io_delegate_.SetFileContents("old/p/Enum.aidl",
2400 "package p;"
2401 "enum Enum {"
2402 " FOO = 1,"
2403 " BAR = 2,"
2404 "}");
2405 io_delegate_.SetFileContents("new/p/Enum.aidl",
2406 "package p;"
2407 "enum Enum {"
2408 " BAR = 2,"
2409 " FOO = 1,"
2410 "}");
2411 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2412}
2413
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002414TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2415 io_delegate_.SetFileContents("old/p/Union.aidl",
2416 "package p;"
2417 "union Union {"
2418 " String foo;"
2419 "}");
2420 io_delegate_.SetFileContents("new/p/Union.aidl",
2421 "package p;"
2422 "union Union {"
2423 " String foo;"
2424 " int num;"
2425 "}");
2426 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2427}
2428
Daniel Norman85aed542019-08-21 12:01:14 -07002429TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002430 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2431 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002432 "interface IFoo {"
2433 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002434 "}");
2435 io_delegate_.SetFileContents("old/p/Data.aidl",
2436 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002437 "parcelable Data {"
2438 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002439 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002440 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2441 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002442 "interface IFoo {"
2443 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002444 "}");
2445 io_delegate_.SetFileContents("new/p/Data.aidl",
2446 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002447 "parcelable Data {"
2448 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002449 "}");
2450 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2451 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002452 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002453 " void foo(int a);"
2454 "}");
2455 io_delegate_.SetFileContents("new/q/Data.aidl",
2456 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002457 "parcelable Data {"
2458 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002459 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002460 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2461}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002462
Daniel Norman85aed542019-08-21 12:01:14 -07002463TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2464 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2465 "package p;"
2466 "interface IFoo {"
2467 " void foo(int a);"
2468 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002469 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2470 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002471 "interface IFoo {"
2472 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002473 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002474 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2475}
Jiyong Parke59c3682018-09-11 23:10:25 +09002476
Daniel Norman85aed542019-08-21 12:01:14 -07002477TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002478 io_delegate_.SetFileContents("old/p/I.aidl",
2479 "package p; interface I {"
2480 "const int A = 1; }");
2481 io_delegate_.SetFileContents("new/p/I.aidl",
2482 "package p ; interface I {"
2483 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002484 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2485}
Jiyong Parka428d212018-08-29 22:26:30 +09002486
Daniel Norman85aed542019-08-21 12:01:14 -07002487TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002488 io_delegate_.SetFileContents("old/p/I.aidl",
2489 "package p; interface I {"
2490 "const int A = 1; const int B = 2;}");
2491 io_delegate_.SetFileContents("new/p/I.aidl",
2492 "package p ; interface I {"
2493 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002494 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002495}
2496
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002497TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2498 io_delegate_.SetFileContents("old/p/Foo.aidl",
2499 "package p;"
2500 "@JavaPassthrough(annotation=\"Alice\")"
2501 "@JavaPassthrough(annotation=\"Bob\")"
2502 "parcelable Foo {}");
2503 io_delegate_.SetFileContents("new/p/Foo.aidl",
2504 "package p;"
2505 "@JavaPassthrough(annotation=\"Bob\")"
2506 "@JavaPassthrough(annotation=\"Alice\")"
2507 "parcelable Foo {}");
2508 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2509}
2510
Jooyung Han00073272020-11-27 14:20:20 +09002511TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2512 io_delegate_.SetFileContents("old/p/Foo.aidl",
2513 "package p;"
2514 "parcelable Foo {}");
2515 io_delegate_.SetFileContents("new/p/Foo.aidl",
2516 "package p;"
2517 "@JavaPassthrough(annotation=\"@Deprecated\")"
2518 "parcelable Foo {}");
2519 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2520}
2521
Jooyung Han636fd2f2020-10-22 11:33:45 +09002522TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2523 io_delegate_.SetFileContents("old/p/Data.aidl",
2524 "package p;"
2525 "parcelable Data {"
2526 " int num;"
2527 "}");
2528 io_delegate_.SetFileContents(
2529 "new/p/Data.aidl",
2530 "package p;"
2531 "parcelable Data {"
2532 " int num;"
2533 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2534 "}");
2535 io_delegate_.SetFileContents("new/p/Enum.aidl",
2536 "package p;"
2537 "enum Enum {"
2538 " FOO = 0,"
2539 " BAR = 1,"
2540 "}");
2541 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2542}
2543
Jooyung Han308bbe02021-04-27 12:09:59 +09002544TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2545 io_delegate_.SetFileContents("old/p/Data.aidl",
2546 "package p;\n"
2547 "parcelable Data {\n"
2548 " p.Enum e;\n"
2549 "}");
2550 io_delegate_.SetFileContents("old/p/Enum.aidl",
2551 "package p;\n"
2552 "enum Enum {\n"
2553 " FOO = 0,\n"
2554 " BAR = 1,\n"
2555 "}");
2556 io_delegate_.SetFileContents("new/p/Data.aidl",
2557 "package p;\n"
2558 "parcelable Data {\n"
2559 " p.Enum e = p.Enum.FOO;\n"
2560 "}");
2561 io_delegate_.SetFileContents("new/p/Enum.aidl",
2562 "package p;\n"
2563 "enum Enum {\n"
2564 " FOO = 0,\n"
2565 " BAR = 1,\n"
2566 "}");
2567 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2568}
2569
Daniel Norman85aed542019-08-21 12:01:14 -07002570class AidlTestIncompatibleChanges : public AidlTest {
2571 protected:
2572 Options options_ = Options::From("aidl --checkapi old new");
2573};
2574
2575TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002576 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002577 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2578 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002579 "interface IFoo {"
2580 " void foo(in String[] str);"
2581 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002582 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002583 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002584 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002585 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002586}
2587
2588TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002589 const string expected_stderr =
2590 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002591 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2592 "package p;"
2593 "interface IFoo {"
2594 " void foo(in String[] str);"
2595 " void bar(@utf8InCpp String str);"
2596 "}");
2597 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2598 "package p;"
2599 "interface IFoo {"
2600 " void foo(in String[] str);"
2601 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002602 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002603 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002604 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002605}
2606
Jiyong Parkf8d53612020-05-04 14:06:13 +09002607TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2608 const string expected_stderr =
2609 "ERROR: new/p/IFoo.aidl:1.61-65: "
2610 "Encountered an untyped List or Map. The use of untyped List/Map is "
2611 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2612 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2613 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2614 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2615 "package p;"
2616 "interface IFoo {"
2617 " void foo(in String[] str);"
2618 "}");
2619 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2620 "package p;"
2621 "interface IFoo {"
2622 " void foo(in String[] str);"
2623 " void bar(in List arg);"
2624 "}");
2625 CaptureStderr();
2626 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2627 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2628}
2629
2630TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2631 const string expected_stderr =
2632 "ERROR: new/p/Data.aidl:1.54-59: "
2633 "Encountered an untyped List or Map. The use of untyped List/Map is "
2634 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2635 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2636 "ERROR: new/p/Data.aidl: Failed to read.\n";
2637 io_delegate_.SetFileContents("old/p/Data.aidl",
2638 "package p;"
2639 "parcelable Data {"
2640 " int foo;"
2641 "}");
2642 io_delegate_.SetFileContents("new/p/Data.aidl",
2643 "package p;"
2644 "parcelable Data {"
2645 " int foo;"
2646 " @nullable List list;"
2647 "}");
2648 CaptureStderr();
2649 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2650 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2651}
2652
Daniel Norman85aed542019-08-21 12:01:14 -07002653TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002654 const string expected_stderr =
2655 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002656 io_delegate_.SetFileContents("old/p/Data.aidl",
2657 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002658 "parcelable Data {"
2659 " int foo;"
2660 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002661 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002662 io_delegate_.SetFileContents("new/p/Data.aidl",
2663 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002664 "parcelable Data {"
2665 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002666 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002667 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002668 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002669 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002670}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002671
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002672TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2673 const string expected_stderr =
2674 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2675 "backends. Please either provide a default value for this field or mark the field as "
2676 "@nullable. This value or a null value will be used automatically when an old version of "
2677 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2678 "order to make sure your code continues to be backwards compatible, make sure the default or "
2679 "null value does not cause a semantic change to this parcelable.\n";
2680 io_delegate_.SetFileContents("old/p/Data.aidl",
2681 "package p;"
2682 "parcelable Data {"
2683 " int num;"
2684 "}");
2685 io_delegate_.SetFileContents("new/p/Data.aidl",
2686 "package p;"
2687 "parcelable Data {"
2688 " int num;"
2689 " String str;"
2690 "}");
2691 CaptureStderr();
2692 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2693 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2694}
2695
Jooyung Han636fd2f2020-10-22 11:33:45 +09002696TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2697 const string expected_stderr =
2698 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2699 "Please make sure 'Enum' has '0' as a valid value.\n";
2700 io_delegate_.SetFileContents("old/p/Data.aidl",
2701 "package p;"
2702 "parcelable Data {"
2703 " int num;"
2704 "}");
2705 io_delegate_.SetFileContents("new/p/Data.aidl",
2706 "package p;"
2707 "parcelable Data {"
2708 " int num;"
2709 " p.Enum e;"
2710 "}");
2711 io_delegate_.SetFileContents("new/p/Enum.aidl",
2712 "package p;"
2713 "enum Enum {"
2714 " FOO = 1,"
2715 " BAR = 2,"
2716 "}");
2717 CaptureStderr();
2718 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2719 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2720}
2721
Daniel Norman85aed542019-08-21 12:01:14 -07002722TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002723 const string expected_stderr =
2724 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002725 io_delegate_.SetFileContents("old/p/Enum.aidl",
2726 "package p;"
2727 "enum Enum {"
2728 " FOO = 1,"
2729 " BAR = 2,"
2730 "}");
2731 io_delegate_.SetFileContents("new/p/Enum.aidl",
2732 "package p;"
2733 "enum Enum {"
2734 " BAR = 2,"
2735 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002736 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002737 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002738 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002739}
2740
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002741TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2742 const string expected_stderr =
2743 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2744 io_delegate_.SetFileContents("old/p/Union.aidl",
2745 "package p;"
2746 "union Union {"
2747 " String str;"
2748 " int num;"
2749 "}");
2750 io_delegate_.SetFileContents("new/p/Union.aidl",
2751 "package p;"
2752 "union Union {"
2753 " String str;"
2754 "}");
2755 CaptureStderr();
2756 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2757 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2758}
2759
Daniel Norman85aed542019-08-21 12:01:14 -07002760TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 const string expected_stderr =
2762 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002763 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2764 "package p;"
2765 "interface IFoo {"
2766 " void foo(in String[] str);"
2767 " void bar(@utf8InCpp String str);"
2768 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002769 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2770 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002771 "interface IFoo {"
2772 " void foo(in String[] str);"
2773 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002774 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002775 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002776 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002777 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002778}
2779
Daniel Norman85aed542019-08-21 12:01:14 -07002780TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002781 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002782 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2783 "package p;"
2784 "interface IFoo {"
2785 " void foo(in String[] str);"
2786 " void bar(@utf8InCpp String str);"
2787 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002788 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2789 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002790 "interface IFoo2 {"
2791 " void foo(in String[] str);"
2792 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002793 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002794 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002795 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002796 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002797}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002798
Daniel Norman85aed542019-08-21 12:01:14 -07002799TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002800 const string expected_stderr =
2801 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002802 io_delegate_.SetFileContents("old/p/Enum.aidl",
2803 "package p;"
2804 "enum Enum {"
2805 " FOO = 1,"
2806 " BAR = 2,"
2807 "}");
2808 io_delegate_.SetFileContents("new/p/Enum.aidl",
2809 "package p;"
2810 "enum Enum {"
2811 " FOO = 3,"
2812 " BAR = 2,"
2813 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002814 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002815 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002816 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002817}
2818
2819TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 const string expected_stderr =
2821 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2822 "from 0 to 1.\n"
2823 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2824 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002825 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2826 "package p;"
2827 "interface IFoo {"
2828 " void foo(in String[] str);"
2829 " void bar(@utf8InCpp String str);"
2830 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002831 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2832 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002833 "interface IFoo {"
2834 " void bar(@utf8InCpp String str);"
2835 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002836 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002837 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002838 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002839 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002840}
2841
2842TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002843 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002844 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2845 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002846 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002847 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002848 "parcelable Data {"
2849 " int foo;"
2850 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002851 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002852 io_delegate_.SetFileContents("new/p/Data.aidl",
2853 "package p;"
2854 "parcelable Data {"
2855 " int bar;"
2856 " int foo;"
2857 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002858 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002859 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002860 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002861}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002862
Daniel Norman85aed542019-08-21 12:01:14 -07002863TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002864 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002865 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002866 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002867 "interface IFoo {"
2868 " void foo(in String[] str);"
2869 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002870 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002871 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2872 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002873 "interface IFoo {"
2874 " void foo(out String[] str);"
2875 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002876 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002877 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002878 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002879 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002880}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002881
Daniel Norman85aed542019-08-21 12:01:14 -07002882TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002883 const string expected_stderr =
2884 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002885 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2886 "package p;"
2887 "interface IFoo {"
2888 " void foo(in String[] str);"
2889 " void bar(@utf8InCpp String str);"
2890 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002891 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2892 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002893 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002894 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002895 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002896 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002897 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002898 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002899 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002900}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002901
Daniel Norman85aed542019-08-21 12:01:14 -07002902TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002903 const string expected_stderr =
2904 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002905 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2906 "package p;"
2907 "interface IFoo {"
2908 " void foo(in String[] str);"
2909 " void bar(@utf8InCpp String str);"
2910 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002911 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2912 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002913 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002914 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002915 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002916 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002917 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002918 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002919 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002920}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002921
Jooyung Han60b2fde2020-10-29 15:12:40 +09002922TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2923 const string expected_stderr =
2924 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2925 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2926 io_delegate_.SetFileContents("old/p/Foo.aidl",
2927 "package p;"
2928 "@Backing(type=\"byte\")"
2929 "enum Foo {"
2930 " FOO, BAR,"
2931 "}");
2932 io_delegate_.SetFileContents("new/p/Foo.aidl",
2933 "package p;"
2934 "@Backing(type=\"long\")"
2935 "enum Foo {"
2936 " FOO, BAR,"
2937 "}");
2938 CaptureStderr();
2939 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2941}
2942
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002943TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2944 const string expected_stderr =
2945 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2946 "to @JavaPassthrough(annotation=\"Bob\")\n";
2947 io_delegate_.SetFileContents("old/p/Foo.aidl",
2948 "package p;"
2949 "@JavaPassthrough(annotation=\"Alice\")"
2950 "parcelable Foo {}");
2951 io_delegate_.SetFileContents("new/p/Foo.aidl",
2952 "package p;"
2953 "@JavaPassthrough(annotation=\"Bob\")"
2954 "parcelable Foo {}");
2955
2956 CaptureStderr();
2957 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2958 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2959}
2960
Devin Mooredb7ac512020-08-07 11:17:36 -07002961TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2962 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002963 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002964 io_delegate_.SetFileContents("old/p/Foo.aidl",
2965 "package p;"
2966 "parcelable Foo {"
2967 " int A;"
2968 "}");
2969 io_delegate_.SetFileContents("new/p/Foo.aidl",
2970 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002971 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002972 " int A;"
2973 "}");
2974 CaptureStderr();
2975 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2976 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2977}
2978
2979TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2980 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002981 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002982 io_delegate_.SetFileContents("old/p/Foo.aidl",
2983 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002984 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002985 " int A;"
2986 "}");
2987 io_delegate_.SetFileContents("new/p/Foo.aidl",
2988 "package p;"
2989 "parcelable Foo {"
2990 " int A;"
2991 "}");
2992 CaptureStderr();
2993 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2994 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2995}
2996
Daniel Norman85aed542019-08-21 12:01:14 -07002997TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002998 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002999 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3000 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003001 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003002 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003003 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003005}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003006
Daniel Norman85aed542019-08-21 12:01:14 -07003007TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003008 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003009 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3010 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003011 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003012 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003014}
Jiyong Parka428d212018-08-29 22:26:30 +09003015
Daniel Norman85aed542019-08-21 12:01:14 -07003016TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003017 const string expected_stderr =
3018 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003019 io_delegate_.SetFileContents("old/p/I.aidl",
3020 "package p; interface I {"
3021 "const int A = 1; const int B = 2;}");
3022 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003023 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003024 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003025 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003026}
Jiyong Parka428d212018-08-29 22:26:30 +09003027
Daniel Norman85aed542019-08-21 12:01:14 -07003028TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003029 const string expected_stderr =
3030 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003031 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3032 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003033 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003034 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003035 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003036}
3037
Devin Moorec7e47a32020-08-07 10:55:25 -07003038TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3039 const string expected_stderr =
3040 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3041 "This is an incompatible change for FixedSize types.\n";
3042 io_delegate_.SetFileContents("old/p/Foo.aidl",
3043 "package p; @FixedSize parcelable Foo { int A = 1; }");
3044 io_delegate_.SetFileContents("new/p/Foo.aidl",
3045 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3046 CaptureStderr();
3047 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3048 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3049}
3050
Jeongik Cha68d18e72021-04-29 20:07:01 +09003051TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3052 const string expected_stderr =
3053 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3054 "android.net.UidRangeParcel is changed from 1 to 2. "
3055 "But it is forbidden because of legacy support.\n";
3056 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3057 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3058 io_delegate_.SetFileContents(
3059 "new/android/net/UidRangeParcel.aidl",
3060 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3061 CaptureStderr();
3062 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3063 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3064}
3065
Devin Moorec7e47a32020-08-07 10:55:25 -07003066TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3067 const string expected_stderr =
3068 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3069 io_delegate_.SetFileContents("old/p/Foo.aidl",
3070 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3071 io_delegate_.SetFileContents("new/p/Foo.aidl",
3072 "package p; @FixedSize parcelable Foo { int A = 1; }");
3073 CaptureStderr();
3074 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3076}
3077
3078TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3079 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003080 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003081 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003082 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3083 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003084 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003085 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003086 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003087 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003088 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003089 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3090 "f.\n"
3091 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3092 "nullable1.\n"
3093 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3094 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003095
3096 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003097 "@FixedSize parcelable Foo {\n"
3098 " int[] a;\n"
3099 " Bar b;\n"
3100 " String c;\n"
3101 " ParcelFileDescriptor d;\n"
3102 " IBinder e;\n"
3103 " List<String> f;\n"
3104 " int isFixedSize;\n"
3105 " @nullable OtherFixed nullable1;\n"
3106 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003107 "}");
3108 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003109 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003110 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003111
3112 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003113 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003114 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3115}
3116
3117TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3118 const string expected_stderr = "";
3119
3120 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3121 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3122 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003123 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003124
3125 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003126 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003127 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3128}
3129
Jiyong Park8c380532018-08-30 14:55:26 +09003130TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003131 const string expected_stderr =
3132 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3133 "dir1/q/IBar.aidl\n"
3134 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003135 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003136 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3137 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3138 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3139 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3140
Devin Moore097a3ab2020-03-11 16:08:44 -07003141 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003142 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003143 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003144}
3145
Jiyong Parked65bf42018-08-28 15:43:27 +09003146TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003147 const string expected_stderr =
3148 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3149 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003150 Options options = Options::From("aidl --checkapi old new");
3151 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3152 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003153
3154 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3155
Jiyong Parke59c3682018-09-11 23:10:25 +09003156 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003157 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003158 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003159 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003160}
3161
Jooyung Han652ce482021-02-26 12:40:35 +09003162TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3163 Options options =
3164 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003165
3166 // use without import
3167 io_delegate_.SetFileContents("p/IFoo.aidl",
3168 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003169 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003170
3171 // capture output files
3172 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003173
Devin Moore7b8d5c92020-03-17 14:14:08 -07003174 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003175 io_delegate_.SetFileContents(
3176 "p/IFoo.aidl",
3177 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003178 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003179 // output files should be the same
3180 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003181
3182 // use with import (as before)
3183 io_delegate_.SetFileContents("p/IFoo.aidl",
3184 "package p;"
3185 "import android.os.ParcelFileDescriptor;"
3186 "interface IFoo{"
3187 " void foo(in ParcelFileDescriptor fd);"
3188 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003189 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003190 // output files should be the same
3191 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003192}
Jiyong Parked65bf42018-08-28 15:43:27 +09003193
Jooyung Han020d8d12021-02-26 17:23:02 +09003194TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3195 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3196 CaptureStderr();
3197 io_delegate_.SetFileContents("p/IFoo.aidl",
3198 "package p;"
3199 "interface IFoo{"
3200 " void foo(out ParcelFileDescriptor fd);"
3201 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003202 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003203 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3204}
3205
3206TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3207 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3208 CaptureStderr();
3209 io_delegate_.SetFileContents("p/IFoo.aidl",
3210 "package p;"
3211 "interface IFoo{"
3212 " void foo(ParcelFileDescriptor fd);"
3213 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003214 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003215 EXPECT_THAT(GetCapturedStderr(),
3216 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3217}
3218
Jiyong Park3633b722019-04-11 15:38:26 +09003219TEST_F(AidlTest, ManualIds) {
3220 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3221 io_delegate_.SetFileContents("IFoo.aidl",
3222 "interface IFoo {\n"
3223 " void foo() = 0;\n"
3224 " void bar() = 1;\n"
3225 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003226 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003227}
3228
3229TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3230 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3231 io_delegate_.SetFileContents("IFoo.aidl",
3232 "interface IFoo {\n"
3233 " void foo() = 0;\n"
3234 " void bar() = 1;\n"
3235 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003236 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003237}
3238
3239TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003240 const string expected_stderr =
3241 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003242 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3243 io_delegate_.SetFileContents("IFoo.aidl",
3244 "interface IFoo {\n"
3245 " void foo() = 3;\n"
3246 " void bar() = 3;\n"
3247 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003248 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003249 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003251}
3252
3253TEST_F(AidlTest, FailOnOutOfRangeIds) {
3254 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003255 const string expected_stderr =
3256 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3257 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003258 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3259 io_delegate_.SetFileContents("IFoo.aidl",
3260 "interface IFoo {\n"
3261 " void foo() = 3;\n"
3262 " void bar() = 16777115;\n"
3263 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003264 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003265 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003266 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003267}
3268
3269TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003270 const string expected_stderr =
3271 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003272 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3273 io_delegate_.SetFileContents("IFoo.aidl",
3274 "interface IFoo {\n"
3275 " void foo() = 3;\n"
3276 " void bar();\n"
3277 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003278 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003279 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003280 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003281}
3282
Jiyong Parkc6816252019-07-08 08:12:28 +09003283TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3284 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3285 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3286 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003287 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003288}
3289
3290TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003291 const string expected_stderr =
3292 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3293 "dir/IBar.aidl\n"
3294 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003295 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003296
Jiyong Parkc6816252019-07-08 08:12:28 +09003297 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3298 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3299 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3300 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003301 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003302 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003304}
3305
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003306TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3307 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3308 "package a.b;\n"
3309 "import a.b.IBar;\n"
3310 "import a.b.IQux;\n"
3311 "interface IFoo { IQux foo(); }\n");
3312 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3313 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3314
3315 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003316 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003317
3318 string output;
3319 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3320 // IBar was imported but wasn't used. include is not expected.
3321 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3322 // IBar was imported and used. include is expected.
3323 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3324}
3325
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003326TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003327 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003328 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003329 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3330 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003331 interface IFoo {
3332 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003333 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003334 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003335 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003336 // JavaPassthrough should work with other types as well (e.g. enum)
3337 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3338 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3339 @JavaPassthrough(annotation="@com.android.AliceTwo")
3340 @Backing(type="byte")
3341 enum MyEnum {
3342 a, b, c
3343 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003344
Jooyung Han4cde01d2020-10-13 11:10:47 +09003345 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003346 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003347
3348 string java_out;
3349 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003350 // type-decl-level annotations with newline at the end
3351 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3352 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3353 // member-decl-level annotations with newline at the end
3354 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3355 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3356 // inline annotations with space at the end
3357 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003358
Jooyung Han4cde01d2020-10-13 11:10:47 +09003359 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3360 // type-decl-level annotations with newline at the end
3361 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3362 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3363
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003364 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003365 Options cpp_options =
3366 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003367 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003368
Jooyung Han4cde01d2020-10-13 11:10:47 +09003369 Options ndk_options =
3370 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003371 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003372
Jooyung Han4cde01d2020-10-13 11:10:47 +09003373 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003374 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003375}
3376
Andrei Homescue61feb52020-08-18 15:44:24 -07003377TEST_F(AidlTest, ParseRustDerive) {
3378 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3379 @RustDerive(Clone=true, Copy=false)
3380 parcelable Foo {
3381 int a;
3382 })");
3383
3384 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003385 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003386
3387 string rust_out;
3388 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3389 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3390
3391 // Other backends shouldn't be bothered
3392 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003393 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003394
3395 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003396 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003397
3398 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003399 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003400}
3401
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003402TEST_F(AidlTest, EmptyEnforceAnnotation) {
3403 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3404 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3405 interface IFoo {
3406 @Enforce()
3407 void Protected();
3408 })");
3409
3410 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3411 CaptureStderr();
3412 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3414}
3415
3416TEST_F(AidlTest, EmptyEnforceCondition) {
3417 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3418 interface IFoo {
3419 @Enforce(condition="")
3420 void Protected();
3421 })");
3422
3423 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3424 CaptureStderr();
3425 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3426 EXPECT_THAT(GetCapturedStderr(),
3427 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3428}
3429
3430TEST_F(AidlTest, InvalidEnforceCondition) {
3431 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3432 interface IFoo {
3433 @Enforce(condition="invalid")
3434 void Protected();
3435 })");
3436
3437 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3438 CaptureStderr();
3439 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3440 EXPECT_THAT(GetCapturedStderr(),
3441 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3442}
3443
Jiyong Park56f73d72019-06-11 12:20:28 +09003444class AidlOutputPathTest : public AidlTest {
3445 protected:
3446 void SetUp() override {
3447 AidlTest::SetUp();
3448 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3449 }
3450
3451 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003452 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003453 // check the existence
3454 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3455 }
3456};
3457
3458TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3459 // <out_dir> / <package_name> / <type_name>.java
3460 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3461}
3462
3463TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3464 // when output file is explicitly set, it is always respected. -o option is
3465 // ignored.
3466 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3467}
3468
3469TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3470 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3471}
3472
3473TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3474 // output is the same as the input file except for the suffix
3475 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3476}
3477
Devin Moore7b8d5c92020-03-17 14:14:08 -07003478TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003479 AidlError error;
3480 const string expected_stderr =
3481 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3482 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003483 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3484 R"(package p;
3485 interface IFoo {
3486 const int int32_max_oob = 2147483650;
3487 }
3488 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003489 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003490 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3491 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003492}
3493
Devin Moore7b8d5c92020-03-17 14:14:08 -07003494TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003495 AidlError error;
3496 const string expected_stderr =
3497 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3498 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003499 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3500 R"(package p;
3501 interface IFoo {
3502 const int int32_min_oob = -2147483650;
3503 }
3504 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003505 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3507 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003508}
3509
Devin Moore7b8d5c92020-03-17 14:14:08 -07003510TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003511 AidlError error;
3512 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003513 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003514 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003515 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3516 R"(package p;
3517 interface IFoo {
3518 const long int64_max_oob = 21474836509999999999999999;
3519 }
3520 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003521 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003522 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3523 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003524}
3525
Devin Moore7b8d5c92020-03-17 14:14:08 -07003526TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003527 AidlError error;
3528 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003529 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003530 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003531 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3532 R"(package p;
3533 interface IFoo {
3534 const long int64_min_oob = -21474836509999999999999999;
3535 }
3536 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003537 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003538 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3539 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003540}
3541
Devin Moore7b8d5c92020-03-17 14:14:08 -07003542TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003543 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003544 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003545 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003546 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3547 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003548 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3549 R"(package p;
3550 @Backing(type="byte")
3551 enum TestEnum {
3552 FOO = 127,
3553 BAR,
3554 }
3555 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003556 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003557 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003558 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003559}
3560
Devin Mooredecaf292020-04-30 09:16:40 -07003561TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3562 AidlError error;
3563 const string expected_stderr =
3564 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003565 "be one of: type\n";
3566 CaptureStderr();
3567 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3568 R"(package p;
3569 @Backing(foo="byte")
3570 enum TestEnum {
3571 FOO = 1,
3572 BAR,
3573 }
3574 )",
3575 typenames_, GetLanguage(), &error));
3576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3577 EXPECT_EQ(AidlError::BAD_TYPE, error);
3578}
3579
Jooyung Han5721a232020-12-24 04:34:55 +09003580TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3581 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3582 CaptureStderr();
3583 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3584 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3585}
3586
Jooyung Han66813932020-10-23 13:24:44 +09003587TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003588 io_delegate_.SetFileContents("Foo.aidl",
3589 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3590 "Map<String, Baz> d; Bar[] e; }");
3591 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3592 io_delegate_.SetFileContents("Baz.aidl",
3593 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003594 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003595 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003596}
3597
Jooyung Han66813932020-10-23 13:24:44 +09003598TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003599 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003600 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003601 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003602 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3603 "named 'bar'.\n";
3604 CaptureStderr();
3605 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003606 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003607 EXPECT_EQ(expected_error, GetCapturedStderr());
3608}
3609
Jooyung Han09e551c2021-05-11 11:44:48 +09003610TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3611 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3612 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3613 CaptureStderr();
3614 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003615 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003616 EXPECT_EQ("", GetCapturedStderr());
3617}
3618
Jooyung Han59af9cc2020-10-25 21:44:14 +09003619TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3620 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3621 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3622 string expected_error =
3623 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003624 "named 'bar'.\n";
3625 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003626 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003627 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003628 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003629}
3630
Jooyung Han66813932020-10-23 13:24:44 +09003631TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003632 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003633 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3634 string expected_error =
3635 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3636 "only be an in parameter.\n";
3637 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003638 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003639 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003640 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003641}
3642
Jooyung Han66813932020-10-23 13:24:44 +09003643TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003644 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003645 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3646 string expected_error =
3647 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3648 "only be an in parameter.\n";
3649 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003650 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003651 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003652 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003653}
3654
Jooyung Han66813932020-10-23 13:24:44 +09003655TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003656 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003657 Options options = Options::From("aidl --lang=java Foo.aidl");
3658 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003659 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3660 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003661 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003662 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003663 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3664}
Devin Moore53fc99c2020-08-12 08:07:52 -07003665
Jooyung Hanfe086af2021-01-16 03:44:47 +09003666TEST_P(AidlTest, UnionInUnion) {
3667 import_paths_.insert(".");
3668 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3669 CaptureStderr();
3670 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3671 EXPECT_THAT("", GetCapturedStderr());
3672}
3673
Jooyung Hanfe89f122020-10-14 03:49:18 +09003674TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3675 const string method = "package a; union Foo {}";
3676 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3677 CaptureStderr();
3678 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3679 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3680}
3681
3682TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3683 const string method = "package a; union Foo { ParcelableHolder x; }";
3684 const string expected_stderr =
3685 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3686 CaptureStderr();
3687 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3688 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3689}
3690
Jooyung Han53fb4242020-12-17 16:03:49 +09003691TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3692 import_paths_.insert(".");
3693 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3694 const string expected_err = "The union's first member should have a useful default value.";
3695 CaptureStderr();
3696 EXPECT_EQ(nullptr,
3697 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3698 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3699}
3700
Devin Moore53fc99c2020-08-12 08:07:52 -07003701TEST_P(AidlTest, GenericStructuredParcelable) {
3702 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003703 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003704 const string expected_stderr = "";
3705 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003706 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003707 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3708}
3709
Jooyung Han3f347ca2020-12-01 12:41:50 +09003710TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3711 io_delegate_.SetFileContents("Foo.aidl",
3712 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3713 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003714 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003715 const string expected_stderr = "";
3716 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003717 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003718 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3719
3720 string code;
3721 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3722 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3723const ::android::String16& Foo<T,U>::s() {
3724 static const ::android::String16 value(::android::String16(""));
3725 return value;
3726})--"));
3727}
3728
3729TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3730 io_delegate_.SetFileContents("Foo.aidl",
3731 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3732 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003733 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003734 const string expected_stderr = "";
3735 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003736 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003737 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3738
3739 string code;
3740 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3741 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3742const char* Foo<T, U>::s = "";
3743)--"));
3744}
3745
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003746TEST_F(AidlTest, NestedTypeArgs) {
3747 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003748 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3749
3750 io_delegate_.SetFileContents("a/Foo.aidl",
3751 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3752 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003753 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3754 const string expected_stderr = "";
3755 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003756 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003757 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3758
3759 string code;
3760 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003761 EXPECT_THAT(code,
3762 testing::HasSubstr(
3763 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3764}
3765
3766TEST_F(AidlTest, DoubleArrayError) {
3767 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3768
3769 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3770 const string expected_stderr =
3771 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3772 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003773 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003774 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3775}
3776
3777TEST_F(AidlTest, DoubleGenericError) {
3778 io_delegate_.SetFileContents("a/Bar.aidl",
3779 "package a; parcelable Bar { List<String><String> a; }");
3780
3781 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3782 const string expected_stderr =
3783 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3784 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003785 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003786 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3787}
3788
3789TEST_F(AidlTest, ArrayBeforeGenericError) {
3790 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3791
3792 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003793 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003794 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003795 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3796}
3797
3798TEST_F(AidlTest, NullableArraysAreNotSupported) {
3799 io_delegate_.SetFileContents("a/Bar.aidl",
3800 "package a; parcelable Bar { String @nullable [] a; }");
3801
3802 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3803 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003804 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003805 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3806}
3807
3808TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3809 io_delegate_.SetFileContents("a/Bar.aidl",
3810 "package a; parcelable Bar { List<@nullable String> a; }");
3811
3812 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3813 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003814 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003815 EXPECT_THAT(GetCapturedStderr(),
3816 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003817}
3818
Jooyung Han14004ed2020-10-16 03:49:57 +09003819struct GenericAidlTest : ::testing::Test {
3820 FakeIoDelegate io_delegate_;
3821 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003822 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003823 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3824 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3825 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3826
3827 Options options = Options::From(cmd);
3828 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003829 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09003830 EXPECT_EQ("", GetCapturedStderr());
3831 }
3832};
3833
3834TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3835 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3836 string code;
3837 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3838 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3839 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3840 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3841}
3842
3843TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3844 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3845 string code;
3846 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3847 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3848 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3849 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3850}
3851
Devin Moore53fc99c2020-08-12 08:07:52 -07003852TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3853 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003854 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003855 const string expected_stderr =
3856 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3857 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003858 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003859 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3860}
3861
3862TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3863 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003864 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003865 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3866 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003867 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3869}
3870
Jooyung Han7a308842020-10-27 19:06:49 +09003871TEST_P(AidlTest, LongCommentWithinConstExpression) {
3872 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003873 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003874 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003875 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09003876 EXPECT_EQ("", GetCapturedStderr());
3877}
3878
Jeongik Chaef44e622020-10-23 16:00:52 +09003879TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3880 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3881 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3882 std::string expectedErr =
3883 "ERROR: a/Foo.aidl:1.28-30: "
3884 "Encountered an untyped List or Map. The use of untyped List/Map is "
3885 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3886 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3887 "ERROR: a/Foo.aidl:1.35-37: "
3888 "Encountered an untyped List or Map. The use of untyped List/Map is "
3889 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3890 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3891 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003892 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003893 EXPECT_EQ(expectedErr, GetCapturedStderr());
3894}
3895
3896TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003897 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3898 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003899 std::string expectedErr =
3900 "ERROR: a/Foo.aidl:1.33-35: "
3901 "Encountered an untyped List or Map. The use of untyped List/Map is "
3902 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3903 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3904 "ERROR: a/Foo.aidl:1.40-42: "
3905 "Encountered an untyped List or Map. The use of untyped List/Map is "
3906 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3907 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003908 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003909 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003910 EXPECT_EQ(expectedErr, GetCapturedStderr());
3911}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003912
Jeongik Chaef44e622020-10-23 16:00:52 +09003913TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3914 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3915 io_delegate_.SetFileContents(
3916 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3917 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3918 std::string expectedErr =
3919 "ERROR: a/Foo.aidl:1.52-54: "
3920 "Encountered an untyped List or Map. The use of untyped List/Map is "
3921 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3922 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3923 "ERROR: a/Foo.aidl:1.64-66: "
3924 "Encountered an untyped List or Map. The use of untyped List/Map is "
3925 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3926 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3927 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003928 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003929 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003930}
3931
Jooyung Han690f5842020-12-04 13:02:04 +09003932TEST_F(AidlTest, EnumWithDefaults_Java) {
3933 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3934 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3935package p;
3936import p.Enum;
3937parcelable Foo {
3938 Enum e = Enum.BAR;
3939})");
3940 CaptureStderr();
3941 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003942 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003943 auto err = GetCapturedStderr();
3944 EXPECT_EQ("", err);
3945
3946 string code;
3947 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003948 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003949}
3950
3951TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3952 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3953 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3954package p;
3955import p.Enum;
3956parcelable Foo {
3957 Enum e = Enum.BAR;
3958})");
3959 CaptureStderr();
3960 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003961 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003962 auto err = GetCapturedStderr();
3963 EXPECT_EQ("", err);
3964
3965 string code;
3966 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3967 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3968}
3969
3970TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3971 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3972 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3973package p;
3974import p.Enum;
3975parcelable Foo {
3976 Enum e = Enum.BAR;
3977})");
3978 CaptureStderr();
3979 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003980 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003981 auto err = GetCapturedStderr();
3982 EXPECT_EQ("", err);
3983
3984 string code;
3985 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3986 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3987}
3988
3989TEST_F(AidlTest, EnumWithDefaults_Rust) {
3990 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3991 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3992package p;
3993import p.Enum;
3994parcelable Foo {
3995 int n = 42;
3996 Enum e = Enum.BAR;
3997})");
3998 CaptureStderr();
3999 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004001 auto err = GetCapturedStderr();
4002 EXPECT_EQ("", err);
4003
4004 string code;
4005 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4006 EXPECT_THAT(code, testing::HasSubstr(R"(
4007 fn default() -> Self {
4008 Self {
4009 n: 42,
4010 e: crate::mangled::_1_p_4_Enum::BAR,
4011 }
4012 })"));
4013}
4014
4015TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4016 import_paths_.insert("a");
4017 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4018 CaptureStderr();
4019 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4020package p;
4021import p.Enum;
4022parcelable Foo {
4023 int e = Enum.FOO | Enum.BAR;
4024})",
4025 typenames_, GetLanguage());
4026 auto err = GetCapturedStderr();
4027 EXPECT_EQ("", err);
4028 EXPECT_TRUE(type);
4029 const auto& fields = type->AsStructuredParcelable()->GetFields();
4030 EXPECT_EQ("int e = 3", fields[0]->ToString());
4031}
4032
4033TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4034 CaptureStderr();
4035 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4036@Backing(type="int")
4037enum Foo {
4038 STANDARD_SHIFT = 16,
4039 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4040 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4041}
4042)",
4043 typenames_, GetLanguage());
4044 auto err = GetCapturedStderr();
4045 EXPECT_EQ("", err);
4046 EXPECT_TRUE(type);
4047 const auto& enum_type = type->AsEnumDeclaration();
4048 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004049 auto writer = CodeWriter::ForString(&code);
4050 DumpVisitor visitor(*writer);
4051 visitor.Visit(*enum_type);
4052 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004053 EXPECT_EQ(R"--(@Backing(type="int")
4054enum Foo {
4055 STANDARD_SHIFT = 16,
4056 STANDARD_BT709 = 65536,
4057 STANDARD_BT601_625 = 131072,
4058}
4059)--",
4060 code);
4061}
4062
4063TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4064 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4065 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4066package p;
4067import p.Enum;
4068parcelable Foo {
4069 Enum e = Enum.FOO | Enum.BAR;
4070})");
4071 CaptureStderr();
4072 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004073 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004074 auto err = GetCapturedStderr();
4075 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4076 err);
4077}
4078
Jooyung Han361cd102021-05-24 11:30:10 +09004079TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4080 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4081 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4082package p;
4083import p.Enum;
4084parcelable Foo {
4085 Enum e = 1;
4086})");
4087 CaptureStderr();
4088 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004089 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004090 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4091}
4092
Jooyung Han690f5842020-12-04 13:02:04 +09004093TEST_P(AidlTest, DefaultWithEmptyArray) {
4094 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4095 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4096 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004097 auto options =
4098 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004099 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004100 auto err = GetCapturedStderr();
4101 EXPECT_EQ("", err);
4102}
4103
4104TEST_P(AidlTest, RejectRefsInAnnotation) {
4105 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4106 "package p; interface IFoo {\n"
4107 " const String ANNOTATION = \"@Annotation\";\n"
4108 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4109 "}");
4110 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004111 auto options =
4112 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004113 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004114 auto err = GetCapturedStderr();
4115 EXPECT_EQ(
4116 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4117 "ANNOTATION.\n",
4118 err);
4119}
4120
4121TEST_F(AidlTest, DefaultWithEnumValues) {
4122 io_delegate_.SetFileContents(
4123 "a/p/Foo.aidl",
4124 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4125 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4126 CaptureStderr();
4127 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004128 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004129 auto err = GetCapturedStderr();
4130 EXPECT_EQ("", err);
4131 string code;
4132 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4133 EXPECT_THAT(
4134 code, testing::HasSubstr(
4135 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4136}
4137
Jooyung Han14259392020-12-07 10:00:08 +09004138TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4139 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4140 CaptureStderr();
4141 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004142 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004143 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004144 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004145}
4146
4147TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4148 io_delegate_.SetFileContents("a/p/Foo.aidl",
4149 "package p; parcelable Foo { const int A = A + 1; }");
4150 CaptureStderr();
4151 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004152 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004153 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004154 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4155}
4156
4157TEST_F(AidlTest, RecursiveReferences) {
4158 io_delegate_.SetFileContents("a/p/Foo.aidl",
4159 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4160 io_delegate_.SetFileContents("a/p/Bar.aidl",
4161 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4162 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4163 CaptureStderr();
4164 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004165 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004166 EXPECT_EQ("", GetCapturedStderr());
4167}
4168
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004169TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4170 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4171 auto options =
4172 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4173 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4174 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004175 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004176 EXPECT_EQ(err, GetCapturedStderr());
4177}
4178
4179TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4180 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4181 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4182 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4183 auto options =
4184 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4185 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004186 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004187 EXPECT_EQ("", GetCapturedStderr());
4188}
4189
Jooyung Hane9f5b272021-01-07 00:18:11 +09004190TEST_P(AidlTest, UnknownConstReference) {
4191 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4192 auto options =
4193 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4194 const string err =
4195 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4196 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4197 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4198 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004199 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004200 EXPECT_EQ(err, GetCapturedStderr());
4201}
4202
Jooyung Han29813842020-12-08 01:28:03 +09004203TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4204 string contents = R"(
4205import android.os.IBinder;
4206import android.os.IInterface;
4207interface IFoo {}
4208 )";
4209 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004210}
4211
Jooyung Han888c5bc2020-12-22 17:28:47 +09004212TEST_P(AidlTest, WarningInterfaceName) {
4213 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004214 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004215 " -Weverything -o out -h out p/Foo.aidl");
4216 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004217 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004218 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004219 GetCapturedStderr());
4220}
4221
4222TEST_P(AidlTest, ErrorInterfaceName) {
4223 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004224 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004225 " -Weverything -Werror -o out -h out p/Foo.aidl");
4226 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004227 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004228 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004229 GetCapturedStderr());
4230}
4231
Jiyong Park9f4c3822021-04-07 20:36:45 +09004232TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4233 const std::string input_file = "base/p/q/IFoo.aidl";
4234 const std::string header_dir = "out/";
4235 const std::string output_file = "out/base/p/q/IFoo.cpp";
4236 const std::string package = "p.q"; // not base.p.q
4237 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4238
4239 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4240 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004241 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004242 EXPECT_THAT(
4243 GetCapturedStderr(),
4244 testing::StartsWith(
4245 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4246 "but is out/base/p/q/IFoo.cpp."));
4247}
4248
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004249TEST_F(AidlTest, FormatCommentsForJava) {
4250 using android::aidl::FormatCommentsForJava;
4251
4252 struct TestCase {
4253 vector<Comment> comments;
4254 string formatted;
4255 };
4256 vector<TestCase> testcases = {
4257 {{}, ""},
4258 {{{"// line comments\n"}}, "// line comments\n"},
4259 {{{"// @hide \n"}}, "// @hide \n"},
4260 // Transform the last block comment as Javadoc.
4261 {{{"/*\n"
4262 " * Hello, world!\n"
4263 " */"}},
4264 "/**\n"
4265 " * Hello, world!\n"
4266 " */"},
4267 {{{"/* @hide */"}}, "/** @hide */"},
4268 {{{"/**\n"
4269 " @param foo ...\n"
4270 "*/"}},
4271 "/**\n"
4272 " @param foo ...\n"
4273 "*/"},
4274 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4275 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4276 "/* @deprecated first *//** @deprecated second */"},
4277 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4278 // Line comments are printed as they are
4279 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4280 };
4281 for (const auto& [input, formatted] : testcases) {
4282 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4283 }
4284}
4285
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004286TEST_F(AidlTest, HideIsNotForArgs) {
4287 io_delegate_.SetFileContents("IFoo.aidl",
4288 "interface IFoo {\n"
4289 " void foo(in @Hide int x);\n"
4290 "}");
4291 auto options = Options::From("aidl --lang=java IFoo.aidl");
4292 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004293 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004294 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4295}
4296
4297TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4298 io_delegate_.SetFileContents(
4299 "IFoo.aidl",
4300 "interface IFoo {\n"
4301 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4302 "}");
4303 auto options = Options::From("aidl --lang=java IFoo.aidl");
4304 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004305 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4307}
4308
Jooyung Hanfa181932021-06-12 07:56:53 +09004309TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4310 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4311 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4312 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004313 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4315}
4316
Jooyung Hanfd3be322020-12-13 09:11:06 +09004317struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004318 string kind;
4319 string literal;
4320};
4321
Jooyung Hanfd3be322020-12-13 09:11:06 +09004322const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004323 {"primitive", "int"}, {"primitiveArray", "int[]"},
4324 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004325 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4326 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4327 {"union", "a.Union"}, {"interface", "a.IBar"},
4328};
4329
4330const std::map<std::string, std::string> kListSupportExpectations = {
4331 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4332 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4333 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4334 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004335 {"cpp_primitiveArray", "List of arrays is not supported."},
4336 {"java_primitiveArray", "List of arrays is not supported."},
4337 {"ndk_primitiveArray", "List of arrays is not supported."},
4338 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004339 {"cpp_String", ""},
4340 {"java_String", ""},
4341 {"ndk_String", ""},
4342 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004343 {"cpp_StringArray", "List of arrays is not supported."},
4344 {"java_StringArray", "List of arrays is not supported."},
4345 {"ndk_StringArray", "List of arrays is not supported."},
4346 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004347 {"cpp_IBinder", ""},
4348 {"java_IBinder", ""},
4349 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4350 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004351 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004352 {"java_ParcelFileDescriptor", ""},
4353 {"ndk_ParcelFileDescriptor", ""},
4354 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004355 {"cpp_interface", "List<a.IBar> is not supported."},
4356 {"java_interface", "List<a.IBar> is not supported."},
4357 {"ndk_interface", "List<a.IBar> is not supported."},
4358 {"rust_interface", "List<a.IBar> is not supported."},
4359 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004360 {"java_parcelable", ""},
4361 {"ndk_parcelable", ""},
4362 {"rust_parcelable", ""},
4363 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4364 {"java_enum", "A generic type cannot have any primitive type parameters."},
4365 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4366 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004367 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004368 {"java_union", ""},
4369 {"ndk_union", ""},
4370 {"rust_union", ""},
4371};
4372
Jooyung Hand236e552020-12-13 09:21:27 +09004373const std::map<std::string, std::string> kArraySupportExpectations = {
4374 {"cpp_primitive", ""},
4375 {"java_primitive", ""},
4376 {"ndk_primitive", ""},
4377 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004378 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4379 {"java_primitiveArray", "Can only have one dimensional arrays."},
4380 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4381 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004382 {"cpp_String", ""},
4383 {"java_String", ""},
4384 {"ndk_String", ""},
4385 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004386 {"cpp_StringArray", "Can only have one dimensional arrays."},
4387 {"java_StringArray", "Can only have one dimensional arrays."},
4388 {"ndk_StringArray", "Can only have one dimensional arrays."},
4389 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004390 {"cpp_IBinder", ""},
4391 {"java_IBinder", ""},
4392 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4393 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4394 {"cpp_ParcelFileDescriptor", ""},
4395 {"java_ParcelFileDescriptor", ""},
4396 {"ndk_ParcelFileDescriptor", ""},
4397 {"rust_ParcelFileDescriptor", ""},
4398 {"cpp_interface", "Binder type cannot be an array"},
4399 {"java_interface", "Binder type cannot be an array"},
4400 {"ndk_interface", "Binder type cannot be an array"},
4401 {"rust_interface", "Binder type cannot be an array"},
4402 {"cpp_parcelable", ""},
4403 {"java_parcelable", ""},
4404 {"ndk_parcelable", ""},
4405 {"rust_parcelable", ""},
4406 {"cpp_enum", ""},
4407 {"java_enum", ""},
4408 {"ndk_enum", ""},
4409 {"rust_enum", ""},
4410 {"cpp_union", ""},
4411 {"java_union", ""},
4412 {"ndk_union", ""},
4413 {"rust_union", ""},
4414};
4415
Jooyung Hanfd3be322020-12-13 09:11:06 +09004416class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004417 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004418 void Run(const std::string& generic_type_decl,
4419 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004420 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004421 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004422 const auto& kind = std::get<1>(param).kind;
4423
4424 FakeIoDelegate io;
4425 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4426 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4427 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004428 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4429 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004430
4431 const auto options =
4432 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4433 CaptureStderr();
4434 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004435 auto it = expectations.find(lang + "_" + kind);
4436 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004437 const string err = GetCapturedStderr();
4438 if (it->second.empty()) {
4439 EXPECT_EQ("", err);
4440 } else {
4441 EXPECT_THAT(err, testing::HasSubstr(it->second));
4442 }
4443 }
4444};
4445
4446INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004447 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004448 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4449 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004450 testing::ValuesIn(kTypeParams)),
4451 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004452 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004453 });
4454
Jooyung Hanfd3be322020-12-13 09:11:06 +09004455TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4456 Run("List<{}>", kListSupportExpectations);
4457}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004458
Jooyung Hand236e552020-12-13 09:21:27 +09004459TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4460 Run("{}[]", kArraySupportExpectations);
4461}
4462
Christopher Wiley90be4e32015-10-20 14:55:25 -07004463} // namespace aidl
4464} // namespace android