blob: 10268a82c606b309ee013e52ca962ce7d70e9475 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090031#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070032#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070033#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090035#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090036#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090037#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090038#include "parser.h"
39#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070040#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041
42using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080043using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090044using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070046using std::string;
47using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080048using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090049using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070050using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090051using testing::internal::CaptureStderr;
52using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070053
54namespace android {
55namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070056namespace {
57
58const char kExpectedDepFileContents[] =
59R"(place/for/output/p/IFoo.java : \
60 p/IFoo.aidl
61
62p/IFoo.aidl :
63)";
64
Dan Willemsen93298ee2016-11-10 23:55:55 -080065const char kExpectedNinjaDepFileContents[] =
66R"(place/for/output/p/IFoo.java : \
67 p/IFoo.aidl
68)";
69
Jiyong Parkdf202122019-09-30 20:48:35 +090070const char kExpectedParcelableDeclarationDepFileContents[] =
71 R"( : \
72 p/Foo.aidl
73
74p/Foo.aidl :
75)";
76
77const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080078 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070079 p/Foo.aidl
80
81p/Foo.aidl :
82)";
83
Christopher Wileyf8136192016-04-12 14:19:35 -070084} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070085
Devin Moore7b8d5c92020-03-17 14:14:08 -070086class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070087 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090088 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
89 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070090 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070091 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090092 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070093 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090094 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070095 for (const string& s : additional_arguments) {
96 args.emplace_back(s);
97 }
98 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +090099 args.emplace_back("--preprocessed=" + f);
100 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700101 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900102 args.emplace_back("--include=" + i);
103 }
104 args.emplace_back(path);
105 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900106 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900107 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700108 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900109 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900110
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700111 if (error != nullptr) {
112 *error = actual_error;
113 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900114
115 if (actual_error != AidlError::OK) {
116 return nullptr;
117 }
118
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900119 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900120 EXPECT_EQ(1ul, defined_types.size());
121
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900122 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700123 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700124
Devin Moore7b8d5c92020-03-17 14:14:08 -0700125 Options::Language GetLanguage() { return GetParam(); }
126
Christopher Wiley0522cd52015-10-28 15:39:44 -0700127 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800128 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900129 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900130 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700131};
132
Devin Moore7b8d5c92020-03-17 14:14:08 -0700133// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
134// tests with each of the supported languages as a parameter.
135INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
136 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700137 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700138 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900139 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 });
141
142TEST_P(AidlTest, AcceptMissingPackage) {
143 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700144}
145
Devin Moore7b8d5c92020-03-17 14:14:08 -0700146TEST_P(AidlTest, EndsInSingleLineComment) {
147 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700148}
149
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000150TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
151 const string expected_stderr =
152 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
153 const std::string file_contents = "package a; interface IBar {}";
154 CaptureStderr();
155 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
156 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
157}
158
159TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
160 const string expected_stderr =
161 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
162 const std::string file_contents = "package a; interface Bar {}";
163 CaptureStderr();
164 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
165 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
166}
167
168TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
169 const string expected_stderr =
170 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
171 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
172 CaptureStderr();
173 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
174 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
175}
176
177TEST_P(AidlTest, EnumRequiresCorrectPath) {
178 const string expected_stderr =
179 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
180 const std::string file_contents = "package a; enum Bar { A, }";
181 CaptureStderr();
182 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
183 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
184}
185
Devin Moore7b8d5c92020-03-17 14:14:08 -0700186TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900187 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700188 io_delegate_.SetFileContents("bar/IBar.aidl",
189 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700190 const string path = "foo/IFoo.aidl";
191 const string contents =
192 "package foo;\n"
193 "import bar.IBar;\n"
194 "interface IFoo { void f(in IBar[] input); }";
195 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
196 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700197 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700199}
200
Devin Moore7b8d5c92020-03-17 14:14:08 -0700201TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700202 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900204}
Devin Moore097a3ab2020-03-11 16:08:44 -0700205
Jiyong Park40782d02020-07-24 19:17:43 +0900206TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700207 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
208 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900209 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
210 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700211 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700212 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900214}
215
Jiyong Park40782d02020-07-24 19:17:43 +0900216TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900217 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700218 const string expected_stderr =
219 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700220 CaptureStderr();
221 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900223}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224
Jiyong Park40782d02020-07-24 19:17:43 +0900225TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900226 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900227 const string expected_stderr =
228 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700229 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700230 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700232}
233
Devin Moore7b8d5c92020-03-17 14:14:08 -0700234TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700235 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
236 const string expected_stderr =
237 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
238 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700239 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700241}
242
Devin Moore7b8d5c92020-03-17 14:14:08 -0700243TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700244 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
245 const string expected_stderr =
246 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
247 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700248 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800250}
251
Devin Moore2f2077a2020-08-28 11:27:53 -0700252TEST_P(AidlTest, AcceptNullableList) {
253 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
254 const string expected_stderr = "";
255 CaptureStderr();
256 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
258}
259
Jooyung Han01720ed2021-08-13 07:46:07 +0900260TEST_P(AidlTest, RejectRecursiveParcelable) {
261 CaptureStderr();
262 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
263 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
264}
265
266TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
267 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
268 import_paths_.emplace("");
269 CaptureStderr();
270 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
271 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
272}
273
274TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
275 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
276 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
277 import_paths_.emplace("");
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
280 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
281}
282
283TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
284 CaptureStderr();
285 std::string java_only_map_field;
286 if (GetLanguage() == Options::Language::JAVA) {
287 java_only_map_field = " Map<String, Foo> map;\n";
288 }
289 EXPECT_NE(nullptr, Parse("Foo.aidl",
290 "parcelable Foo {\n"
291 " List<Foo> list;\n" +
292 java_only_map_field +
293 " Foo[] arr;\n"
294 " @nullable(heap=true) Foo heap_nullable;\n"
295 "}\n",
296 typenames_, GetLanguage()));
297 EXPECT_THAT(GetCapturedStderr(), "");
298}
299
300TEST_P(AidlTest, InterfaceCanReferenceItself) {
301 CaptureStderr();
302 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
303 GetLanguage()));
304 EXPECT_THAT(GetCapturedStderr(), "");
305}
306
307TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
308 CaptureStderr();
309 EXPECT_EQ(nullptr, Parse("Foo.aidl",
310 "parcelable Foo {\n"
311 " @nullable(heap=true) String s;\n"
312 "}",
313 typenames_, GetLanguage()));
314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
315}
316
Devin Moore7b8d5c92020-03-17 14:14:08 -0700317TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700318 const string method = "package a; interface IFoo { void f(int a, int a); }";
319 const string expected_stderr =
320 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700324}
325
Jeongik Cha13066da2020-08-06 15:43:19 +0900326TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
327 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900328 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900329 CaptureStderr();
330 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
332}
333
Jooyung Hand902a972020-10-23 17:32:44 +0900334TEST_P(AidlTest, RejectsRepeatedAnnotations) {
335 const string method = R"(@Hide @Hide parcelable Foo {})";
336 const string expected_stderr =
337 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
338 "Foo.aidl:1.1-6\n";
339 CaptureStderr();
340 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
342}
343
Jooyung Han05bd8a82021-04-28 23:56:38 +0900344TEST_P(AidlTest, AcceptsEmptyParcelable) {
345 CaptureStderr();
346 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
347 EXPECT_EQ("", GetCapturedStderr());
348}
349
Devin Moore7b8d5c92020-03-17 14:14:08 -0700350TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
352 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 AidlError error;
360 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700361 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700362 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900363 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700364 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 AidlError error;
369 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700370 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700371 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900372 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700373 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700377 AidlError error;
378 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700379 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000380 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900381 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700382 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000387 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700388 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900390 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700391 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800392}
393
Jiyong Park40782d02020-07-24 19:17:43 +0900394TEST_P(AidlTest, ParsesNonNullableAnnotation) {
395 auto parse_result =
396 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
397 ASSERT_NE(nullptr, parse_result);
398 const AidlInterface* interface = parse_result->AsInterface();
399 ASSERT_NE(nullptr, interface);
400 ASSERT_FALSE(interface->GetMethods().empty());
401 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
402}
403
Devin Moore7b8d5c92020-03-17 14:14:08 -0700404TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900405 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
406 typenames_, GetLanguage());
407 ASSERT_NE(nullptr, parse_result);
408 const AidlInterface* interface = parse_result->AsInterface();
409 ASSERT_NE(nullptr, interface);
410 ASSERT_FALSE(interface->GetMethods().empty());
411 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
412}
413
414TEST_P(AidlTest, ParsesNonUtf8Annotations) {
415 auto parse_result =
416 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
417 ASSERT_NE(nullptr, parse_result);
418 const AidlInterface* interface = parse_result->AsInterface();
419 ASSERT_NE(nullptr, interface);
420 ASSERT_FALSE(interface->GetMethods().empty());
421 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800422}
423
Devin Moore7b8d5c92020-03-17 14:14:08 -0700424TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900425 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
426 typenames_, GetLanguage());
427 ASSERT_NE(nullptr, parse_result);
428 const AidlInterface* interface = parse_result->AsInterface();
429 ASSERT_NE(nullptr, interface);
430 ASSERT_FALSE(interface->GetMethods().empty());
431 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800432}
433
Devin Moore7b8d5c92020-03-17 14:14:08 -0700434TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700435 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700436 const string expected_stderr =
437 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
438 "\"vintf\"'\n"
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
440 "--structured\n";
441 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700442 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700443 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700444 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700445 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700446}
447
Devin Moore7b8d5c92020-03-17 14:14:08 -0700448TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700449 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700450 const string expected_stderr =
451 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
452 "--structured\n";
453 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700454 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700455 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700456 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700457 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700458}
459
Devin Moore7b8d5c92020-03-17 14:14:08 -0700460TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700461 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700462 const string expected_stderr =
463 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
464 "\"vintf\"'\n";
465 CaptureStderr();
466 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700467 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700468 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700469 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700470}
471
Devin Moore7b8d5c92020-03-17 14:14:08 -0700472TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700473 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
475 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700476 ASSERT_EQ(AidlError::OK, error);
477 ASSERT_NE(nullptr, parse_result);
478 const AidlInterface* interface = parse_result->AsInterface();
479 ASSERT_NE(nullptr, interface);
480 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700481}
482
Jeongik Cha64783ed2019-06-07 18:30:54 +0900483TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
484 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900485 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
486 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900487 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700488 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900490 "a/Foo.aidl",
491 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900492
Steven Moreland4e059132021-08-11 13:36:30 -0700493 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
494 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900495
Devin Moorec054bf82020-03-10 16:31:48 -0700496 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700497 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900498 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700499
500 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700501 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900502 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900503}
504
Jooyung Han1cbc4962020-10-25 10:07:15 +0900505TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
506 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
507 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
508 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700509 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900510
511 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900512 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900513 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
514
515 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900516 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700517 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900518
Jooyung Han1cbc4962020-10-25 10:07:15 +0900519 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700520 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900521}
522
Jooyung Han1cbc4962020-10-25 10:07:15 +0900523TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
524 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
525 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
526 CaptureStderr();
527 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700528 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900529 EXPECT_EQ("", GetCapturedStderr());
530
531 const string expected_to_string_method = R"--(
532 @Override
533 public String toString() {
534 switch (_tag) {
535 case a: return "a.Foo.a(" + (getA()) + ")";
536 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
537 }
538 throw new IllegalStateException("unknown field: " + _tag);
539 }
540)--";
541
542 string java_out;
543 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
544 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
545}
546
Jiyong Park9aa3d042020-12-04 23:30:02 +0900547TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
548 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
549 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
550 CaptureStderr();
551 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700552 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900553 EXPECT_EQ("", GetCapturedStderr());
554
555 const std::string expected = R"--(
556 @Override
557 public boolean equals(Object other) {
558 if (this == other) return true;
559 if (other == null) return false;
560 if (!(other instanceof Foo)) return false;
561 Foo that = (Foo)other;
562 if (!java.util.Objects.deepEquals(a, that.a)) return false;
563 if (!java.util.Objects.deepEquals(b, that.b)) return false;
564 return true;
565 }
566
567 @Override
568 public int hashCode() {
569 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
570 }
571)--";
572
573 string java_out;
574 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
575 EXPECT_THAT(java_out, testing::HasSubstr(expected));
576}
577
578TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
579 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
580 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
581 CaptureStderr();
582 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700583 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900584 EXPECT_EQ("", GetCapturedStderr());
585
586 const std::string expected = R"--(
587 @Override
588 public boolean equals(Object other) {
589 if (this == other) return true;
590 if (other == null) return false;
591 if (!(other instanceof Foo)) return false;
592 Foo that = (Foo)other;
593 if (_tag != that._tag) return false;
594 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
595 return true;
596 }
597
598 @Override
599 public int hashCode() {
600 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
601 }
602)--";
603
604 string java_out;
605 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
606 EXPECT_THAT(java_out, testing::HasSubstr(expected));
607}
608
Jooyung Han90345002020-10-23 15:28:53 +0900609TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900610 {
Jooyung Han90345002020-10-23 15:28:53 +0900611 io_delegate_.SetFileContents("a/Foo.aidl",
612 "package a; @JavaDerive(blah=true) parcelable Foo{}");
613 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
614 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700615 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900616 const std::string expected_stderr =
617 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900618 EXPECT_THAT(GetCapturedStderr(),
619 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900620 }
621
622 {
623 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900624 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
625 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700626 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900628 }
629
630 {
Jooyung Han90345002020-10-23 15:28:53 +0900631 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900632 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
633 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700634 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900635 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900636 }
637}
638
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900639TEST_P(AidlTest, ParseDescriptorAnnotation) {
640 AidlError error;
641 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
642 typenames_, GetLanguage(), &error, {"--structured"});
643 ASSERT_EQ(AidlError::OK, error);
644 ASSERT_NE(nullptr, parse_result);
645 const AidlInterface* interface = parse_result->AsInterface();
646 ASSERT_NE(nullptr, interface);
647 ASSERT_EQ("IBar", interface->GetDescriptor());
648}
649
Jooyung Han55db8112021-09-15 22:37:39 +0900650TEST_P(AidlTest, UnknownAnnotation) {
651 const string oneway_method = "package a; @Unknown interface IFoo { }";
652 CaptureStderr();
653 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
654 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
655}
656
Jiyong Park40782d02020-07-24 19:17:43 +0900657TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700658 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700659 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900660}
661
662TEST_P(AidlTest, AcceptsOnewayInterface) {
663 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700664 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700665}
Christopher Wileyef140932015-11-03 09:29:19 -0800666
Devin Moore7b8d5c92020-03-17 14:14:08 -0700667TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700668 const string oneway_method =
669 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700670 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100671}
672
Steven Moreland65297cc2020-04-20 20:17:36 -0700673TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
674 const string oneway_method =
675 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
676 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
677 ASSERT_NE(nullptr, defined);
678 const AidlInterface* iface = defined->AsInterface();
679 ASSERT_NE(nullptr, iface);
680
681 const auto& methods = iface->GetMethods();
682 ASSERT_EQ(1u, methods.size());
683 const auto& method = methods[0];
684 const AidlTypeSpecifier& ret_type = method->GetType();
685
686 // TODO(b/151102494): these annotations should be on the method
687 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
688 ASSERT_TRUE(ret_type.IsHide());
689}
690
Devin Moore7b8d5c92020-03-17 14:14:08 -0700691TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100692 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900693 R"(package a;
694 /* foo */
695 interface IFoo {
696 /* i */
697 int i();
698 // j
699 @nullable String j();
700 // k1
701 /* k2 */
702 @UnsupportedAppUsage oneway void k(int a);
703 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100704
Jooyung Han8451a202021-01-16 03:07:06 +0900705 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700706 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100707 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900708 EXPECT_EQ("", GetCapturedStderr());
709
Jooyung Han161bb0f2021-01-21 12:30:16 +0900710 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
712 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900713 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
714 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
715 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100716}
717
Jooyung Han1a551d32020-10-05 15:37:26 +0900718TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
719 io_delegate_.SetFileContents("p/cpp_header.aidl",
720 R"(package p;
721 parcelable cpp_header cpp_header "bar/header";)");
722 import_paths_.emplace("");
723 const string input_path = "p/IFoo.aidl";
724 const string input = R"(package p;
725 import p.cpp_header;
726 interface IFoo {
727 // get bar
728 cpp_header get();
729 })";
730
731 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
732 EXPECT_NE(nullptr, parse_result);
733 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900734 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900735}
736
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900737TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
738 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
739 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
740 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700741 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900742 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
743}
744
745TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
746 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
747 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
748 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
749 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700750 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900751 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
752}
753
Christopher Wileyef140932015-11-03 09:29:19 -0800754TEST_F(AidlTest, ParsesPreprocessedFile) {
755 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
756 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700757 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900758 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700759 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
760 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800761}
762
763TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
764 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
765 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900766
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700767 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900768 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700769 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
770 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800771}
772
Devin Moore7b8d5c92020-03-17 14:14:08 -0700773TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800774 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
775 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
776 "interface IBar {}");
777 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900778 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900779 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800781 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900782
Christopher Wiley41544372015-11-03 14:52:29 -0800783 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700784 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
785 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800786 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900787 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900788 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800790}
791
Jiyong Park8f6ec462020-01-19 20:52:47 +0900792// Special case of PreferImportToPreprocessed. Imported type should be preferred
793// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700794TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900795 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
796 io_delegate_.SetFileContents("one/IBar.aidl",
797 "package one; "
798 "interface IBar {}");
799 preprocessed_files_.push_back("preprocessed");
800 import_paths_.emplace("");
801 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700802 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900803 EXPECT_NE(nullptr, parse_result);
804
805 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700806 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
807 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900808 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900809 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900810 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900811 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
812}
813
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800814TEST_F(AidlTest, WritePreprocessedFile) {
815 io_delegate_.SetFileContents("p/Outer.aidl",
816 "package p; parcelable Outer.Inner;");
817 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
818 "interface IBar {}");
819
Jooyung Han93f48f02021-06-05 00:11:16 +0900820 vector<string> args{"aidl", "--preprocess", "preprocessed",
821 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900822 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900823 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800824
Jooyung Han93f48f02021-06-05 00:11:16 +0900825 std::map<std::string, std::string> expected = {{"preprocessed",
826 "parcelable p.Outer.Inner;\n"
827 "interface one.IBar {\n"
828 "}\n"}};
829 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
830}
831
832TEST_F(AidlTest, PreprocessVariousThings) {
833 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
834 "package foo.bar;\n"
835 "interface IFoo {\n"
836 " int foo();\n"
837 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
838 "}\n");
839 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
840 "package foo.bar;\n"
841 "parcelable Bar {\n"
842 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
843 " imported.Foo foo;\n"
844 "}\n");
845 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
846 "package foo.bar;\n"
847 "parcelable Gen<T> {\n"
848 "}\n");
849 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
850 "package foo.bar;\n"
851 "enum Enum {\n"
852 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
853 "}\n");
854 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
855 "package imported;\n"
856 "parcelable Foo {\n"
857 " const int FOO = 42;\n"
858 "}\n");
859
860 vector<string> args = {
861 "aidl",
862 "--preprocess",
863 "preprocessed",
864 "-Isub",
865 "-I.",
866 "foo/bar/IFoo.aidl",
867 "foo/bar/Bar.aidl",
868 "foo/bar/Gen.aidl",
869 "foo/bar/Enum.aidl",
870 };
871 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
872 std::string preprocessed =
873 "interface foo.bar.IFoo {\n"
874 " const int FOO = 44;\n"
875 "}\n"
876 "parcelable foo.bar.Bar {\n"
877 " const int BAR = 43;\n"
878 "}\n"
879 "parcelable foo.bar.Gen<T> {\n"
880 "}\n"
881 "enum foo.bar.Enum {\n"
882 " FOO = 3,\n"
883 " BAR = 6,\n"
884 "}\n";
885 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
886 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
887
888 // use preprocessed
889 io_delegate_.SetFileContents("a/Foo.aidl",
890 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
891 io_delegate_.SetFileContents("preprocessed", preprocessed);
892 CaptureStderr();
893 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700894 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900895 EXPECT_EQ("", GetCapturedStderr());
896 string code;
897 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
898 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
899}
900
Jooyung Han35784982021-06-29 06:26:12 +0900901TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
902 io_delegate_.SetFileContents("p/IFoo.aidl",
903 "package p;\n"
904 "import x.Outer;\n"
905 "interface IFoo {\n"
906 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
907 "}");
908 io_delegate_.SetFileContents("imported/x/Outer.aidl",
909 "package x;\n"
910 "parcelable Outer.Inner1;\n"
911 "parcelable Outer.Inner2;\n");
912 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
913 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700914 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900915 EXPECT_EQ("", GetCapturedStderr());
916}
917
918TEST_F(AidlTest,
919 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
920 // Main doc(Foo.aidl) is loaded
921 // And then framework.aidl is loaded as preprocessed. (conflict)
922 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
923 io_delegate_.SetFileContents("x/Foo.aidl",
924 "package x;\n"
925 "parcelable Foo.Inner;\n");
926 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
927 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700928 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900929 EXPECT_EQ("", GetCapturedStderr());
930}
931
932TEST_F(AidlTest,
933 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
934 // Main doc(IBar.aidl) is loaded first.
935 // Framework.aidl is loaded as preprocessed.
936 // And then import(Foo.aidl) is loaded. (conflict)
937 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
938 io_delegate_.SetFileContents("x/IBar.aidl",
939 "package x;\n"
940 "import x.Foo;\n"
941 "interface IBar {\n"
942 " void bar(in Foo.Inner inner);\n"
943 "}");
944 io_delegate_.SetFileContents("x/Foo.aidl",
945 "package x;\n"
946 "parcelable Foo.Inner;\n");
947 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
948 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700949 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900950 EXPECT_EQ("", GetCapturedStderr());
951}
952
Jooyung Han93f48f02021-06-05 00:11:16 +0900953TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
954 string simple_content = "package xxx; parcelable a.Foo;";
955 io_delegate_.SetFileContents("path", simple_content);
956 CaptureStderr();
957 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
958 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
959}
960
961TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
962 string simple_content = "parcelable a.Foo {}";
963 io_delegate_.SetFileContents("path", simple_content);
964 CaptureStderr();
965 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
966 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800967}
968
Jooyung Han13f1fa52021-06-11 18:06:12 +0900969TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
970 string contents = R"(
971 interface android.os.IBinder;
972 interface android.os.IInterface;
973 parcelable android.os.ParcelFileDescriptor;
974 )";
975 io_delegate_.SetFileContents("path", contents);
976 CaptureStderr();
977 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
978 EXPECT_THAT(GetCapturedStderr(), "");
979}
980
Jooyung Han720253d2021-01-05 19:13:17 +0900981TEST_P(AidlTest, SupportDeprecated) {
982 struct TestCase {
983 std::string output_file;
984 std::string annotation;
985 };
986
987 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900988 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900989 io_delegate_.SetFileContents(filename, contents);
990
991 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
992 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -0700993 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900994 for (const auto& [lang, test_case] : expectations) {
995 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900996 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900997 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900998 EXPECT_THAT(output, HasSubstr(test_case.annotation));
999 }
1000 };
1001
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001002 // Emit escaped string for notes
1003 CheckDeprecated(
1004 "IFoo.aidl",
1005 R"(interface IFoo {
1006 /**
1007 * @note asdf
1008 * @deprecated a really long deprecation message
1009 *
1010 * which is really long
1011 * @param foo bar
1012 */
1013 List<String> foo();
1014 })",
1015 {
1016 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1017 {Options::Language::CPP,
1018 {"out/IFoo.h",
1019 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1020 {Options::Language::NDK,
1021 {"out/aidl/IFoo.h",
1022 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1023 {Options::Language::RUST,
1024 {"out/IFoo.rs",
1025 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1026 });
1027
Jooyung Han24effbf2021-01-16 10:24:03 +09001028 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001029 CheckDeprecated(
1030 "IFoo.aidl",
1031 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001032 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001033 " List<String> foo();\n"
1034 "}",
1035 {
1036 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001037 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001038 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1039 {Options::Language::NDK,
1040 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1041 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1042 });
Jooyung Han720253d2021-01-05 19:13:17 +09001043
Jooyung Han24effbf2021-01-16 10:24:03 +09001044 // but not in line comments
1045 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1046 EXPECT_FALSE(parsed->IsDeprecated());
1047
1048 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001049 CheckDeprecated("Foo.aidl",
1050 "parcelable Foo {\n"
1051 " /** @deprecated use bar*/\n"
1052 " int foo = 0;\n"
1053 "}",
1054 {
1055 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1056 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1057 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1058 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1059 });
1060
Jooyung Han24effbf2021-01-16 10:24:03 +09001061 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001062 CheckDeprecated("IFoo.aidl",
1063 "interface IFoo {\n"
1064 " /** @deprecated use bar*/\n"
1065 " const int FOO = 0;\n"
1066 "}",
1067 {
1068 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1069 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1070 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1071 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1072 });
1073
1074 // union fields
1075 CheckDeprecated("Foo.aidl",
1076 "union Foo {\n"
1077 " int bar = 0;\n"
1078 " /** @deprecated use bar*/\n"
1079 " int foo;\n"
1080 "}",
1081 {
1082 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1083 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1084 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1085 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1086 });
1087
1088 CheckDeprecated("Foo.aidl",
1089 "/** @deprecated use Bar */\n"
1090 "parcelable Foo {}",
1091 {
1092 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1093 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1094 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1095 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1096 });
1097
1098 CheckDeprecated("Foo.aidl",
1099 "/** @deprecated use Bar */\n"
1100 "union Foo { int foo = 0; }",
1101 {
1102 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1103 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1104 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1105 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1106 });
1107
1108 CheckDeprecated("IFoo.aidl",
1109 "/** @deprecated use IBar */\n"
1110 "interface IFoo {}",
1111 {
1112 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1113 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1114 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1115 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1116 });
1117
1118 CheckDeprecated("Foo.aidl",
1119 "/** @deprecated use IBar */\n"
1120 "enum Foo { FOO }",
1121 {
1122 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1123 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1124 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001125 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001126 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1127 });
1128}
1129
Devin Moore7b8d5c92020-03-17 14:14:08 -07001130TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001131 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001132 io_delegate_.SetFileContents("p/Outer.aidl",
1133 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001134 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001135 CaptureStderr();
1136 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1137 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001138 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001139 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001140}
1141
Devin Moore7b8d5c92020-03-17 14:14:08 -07001142TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001143 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001144 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001145 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001146 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147 // TODO(wiley): This should actually return nullptr because we require
1148 // the outer class name. However, for legacy reasons,
1149 // this behavior must be maintained. b/17415692
1150 EXPECT_NE(nullptr, parse_result);
1151}
1152
Jooyung Han05a532a2021-08-18 10:41:40 +09001153TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1154 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1155
1156 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1157 CaptureStderr();
1158 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1159 EXPECT_EQ("", GetCapturedStderr());
1160}
1161
Christopher Wiley632801d2015-11-05 14:15:49 -08001162TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001163 const string expected_foo_stderr =
1164 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1165 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1166 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001167 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001170 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001171 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001172 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001173 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001174
Steven Morelande2c64b42018-09-18 15:06:37 -07001175 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001176 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001177 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001178 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001179 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001180
Devin Moore097a3ab2020-03-11 16:08:44 -07001181 const string expected_bar_stderr =
1182 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1183 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1184 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001185 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1186
Jiyong Parkda8c6932019-08-12 19:56:08 +09001187 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001188 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001189 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001190 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001191 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001193 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001194 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001195 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001196}
1197
Jooyung Han13f1fa52021-06-11 18:06:12 +09001198TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1199 string contents = R"(
1200 import android.os.IBinder;
1201 import android.os.IInterface;
1202 interface IFoo {
1203 void foo(in IBinder b);
1204 }
1205 )";
1206 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1207}
1208
Devin Moore7b8d5c92020-03-17 14:14:08 -07001209TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001210 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001211 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001212 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001213 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1214 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001215 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001216 AidlError error;
1217 CaptureStderr();
1218 EXPECT_EQ(
1219 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001220 Parse("p/IFoo.aidl",
1221 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001222 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1224 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001225}
1226
Devin Moore7b8d5c92020-03-17 14:14:08 -07001227TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001228 AidlError error;
1229 const string expected_stderr =
1230 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1231 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001232 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1233 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001234 interface IFoo {
1235 const String DUPLICATED = "d";
1236 const int DUPLICATED = 1;
1237 }
1238 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001239 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1241 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001242}
1243
Steven Morelande689da22020-11-10 02:06:30 +00001244TEST_P(AidlTest, FailOnTooBigConstant) {
1245 AidlError error;
1246 const string expected_stderr =
1247 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1248 CaptureStderr();
1249 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1250 R"(package p;
1251 interface IFoo {
1252 const byte type2small = 256;
1253 }
1254 )",
1255 typenames_, GetLanguage(), &error));
1256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1257 EXPECT_EQ(AidlError::BAD_TYPE, error);
1258}
1259
Jooyung Han30f64ad2020-12-15 08:16:31 +09001260TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1261 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1262 CaptureStderr();
1263 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001264 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001265 EXPECT_EQ("", GetCapturedStderr());
1266 string code;
1267 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1268 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1269}
1270
Jooyung Han535c5e82020-12-29 15:16:59 +09001271TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001272 using Ptr = unique_ptr<AidlConstantValue>;
1273 const AidlLocation& loc = AIDL_LOCATION_HERE;
1274
Jooyung Han535c5e82020-12-29 15:16:59 +09001275 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1276 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1277 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1278 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001279
1280 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1281 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001283
1284 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1285 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1286 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1287 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001288 EXPECT_EQ(
1289 expected,
1290 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001291}
1292
Devin Moore7b8d5c92020-03-17 14:14:08 -07001293TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001294 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001295 const string expected_stderr =
1296 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001297 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001298 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1299 R"(package p;
1300 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001301 parcelable IBar {}
1302 parcelable StructuredParcelable {}
1303 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001304 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001305 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001306 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001307 // Parse success is important for clear error handling even if the cases aren't
1308 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001309 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001310}
1311
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001313 AidlError error;
1314 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1315 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001316 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001317 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1318 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001319}
1320
Steven Morelandf9e922f2020-07-08 21:15:27 +00001321TEST_P(AidlTest, FailOnEmptyListWithComma) {
1322 AidlError error;
1323 const string expected_stderr =
1324 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1325 CaptureStderr();
1326 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1327 typenames_, GetLanguage(), &error));
1328 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1329 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1330}
1331
Devin Moore7b8d5c92020-03-17 14:14:08 -07001332TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001333 AidlError error;
1334 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001335 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001336 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001337 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1338 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001339 interface IFoo {
1340 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1341 }
1342 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001343 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1345 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346}
1347
Jiyong Park18132182020-06-08 20:24:40 +09001348TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1349 AidlError error;
1350 const string expected_stderr =
1351 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1352 "cpp_header (which can also be used as an identifier)\n";
1353 CaptureStderr();
1354 // Notice the trailing dot(.) in the name, which isn't a correct name
1355 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1356 GetLanguage(), &error));
1357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1358 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1359}
1360
1361TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1362 AidlError error;
1363 const string expected_stderr =
1364 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1365 "cpp_header (which can also be used as an identifier)\n";
1366 CaptureStderr();
1367 // Notice the trailing dot(.) in the package name
1368 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1369 GetLanguage(), &error));
1370 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1371 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1372}
1373
Devin Moore7b8d5c92020-03-17 14:14:08 -07001374TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001375 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001376 auto parse_result = Parse("p/IFoo.aidl",
1377 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001378 interface IFoo {
1379 const int POSITIVE_HEX_VALUE = 0xf5;
1380 }
1381 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001382 typenames_, GetLanguage(), &error);
1383 EXPECT_NE(nullptr, parse_result);
1384 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001385 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001386 const auto& cpp_constants = interface->GetConstantDeclarations();
1387 EXPECT_EQ((size_t)1, cpp_constants.size());
1388 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001389 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001390 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001391}
1392
Devin Moore7b8d5c92020-03-17 14:14:08 -07001393TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001394 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001395 auto parse_result = Parse("p/IFoo.aidl",
1396 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001397 interface IFoo {
1398 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1399 }
1400 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001401 typenames_, GetLanguage(), &error);
1402 ASSERT_NE(nullptr, parse_result);
1403 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001404 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001405 const auto& cpp_constants = interface->GetConstantDeclarations();
1406 EXPECT_EQ((size_t)1, cpp_constants.size());
1407 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001408 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001409 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001410}
1411
Devin Moore7b8d5c92020-03-17 14:14:08 -07001412TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001413 io_delegate_.SetFileContents(
1414 "p/Outer.aidl",
1415 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001416 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001417 const string input_path = "p/IFoo.aidl";
1418 const string input = "package p; import p.Outer; interface IFoo"
1419 " { Outer.Inner get(); }";
1420
Devin Moore7b8d5c92020-03-17 14:14:08 -07001421 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1422 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001423
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001424 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001425 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001426 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001427 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001428}
1429
Jooyung Han78fcaa82021-06-11 22:27:57 +09001430TEST_P(AidlTest, UnderstandsNestedParcelablesWithoutImports) {
1431 io_delegate_.SetFileContents("p/Outer.aidl",
1432 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1433 import_paths_.emplace("");
1434 const string input_path = "p/IFoo.aidl";
1435 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1436
1437 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1438 EXPECT_NE(nullptr, parse_result);
1439
1440 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1441 // C++ uses "::" instead of "." to refer to a inner class.
1442 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1443 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1444}
1445
Jooyung Han0a950bd2021-05-15 12:50:36 +09001446TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001447 const string input_path = "p/Wrapper.aidl";
1448 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001449
1450 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1451 EXPECT_NE(nullptr, parse_result);
1452
1453 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1454 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1455 (..., params->emplace_back(std::move(type_params)));
1456 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1457 };
1458
1459 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1460 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001461 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001462 type->Annotate(std::move(annotations));
1463 return std::move(type);
1464 };
1465
1466 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1467 (void)type->SetArray();
1468 return std::move(type);
1469 };
1470
1471 auto w = type("p.Wrapper", type("String"));
1472 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1473
1474 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1475 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1476 cpp::CppNameOf(*nullable_w, typenames_));
1477
1478 auto array_w = set_array(type("p.Wrapper", type("String")));
1479 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1480 cpp::CppNameOf(*array_w, typenames_));
1481
1482 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1483 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1484 cpp::CppNameOf(*nullable_array_w, typenames_));
1485
1486 auto list_w = type("List", type("p.Wrapper", type("String")));
1487 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1488 cpp::CppNameOf(*list_w, typenames_));
1489
1490 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1491 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1492 cpp::CppNameOf(*nullable_list_w, typenames_));
1493}
1494
Devin Moore7b8d5c92020-03-17 14:14:08 -07001495TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001496 io_delegate_.SetFileContents(
1497 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001498 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001499 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001500 const string input_path = "p/IFoo.aidl";
1501 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001502 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1503 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001504 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001505 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001506 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001507
1508 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1509 // C++ understands C++ specific stuff
1510 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1511 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001512 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001513 EXPECT_EQ(1u, headers.size());
1514 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001515}
1516
Christopher Wileyf8136192016-04-12 14:19:35 -07001517TEST_F(AidlTest, WritesCorrectDependencyFile) {
1518 // While the in tree build system always gives us an output file name,
1519 // other android tools take advantage of our ability to infer the intended
1520 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001521 vector<string> args = {
1522 "aidl",
1523 "-d dep/file/path",
1524 "-o place/for/output",
1525 "p/IFoo.aidl"};
1526 Options options = Options::From(args);
1527 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001528 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001529 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001530 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001531 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1532}
1533
Dan Willemsen93298ee2016-11-10 23:55:55 -08001534TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1535 // While the in tree build system always gives us an output file name,
1536 // other android tools take advantage of our ability to infer the intended
1537 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001538 vector<string> args = {
1539 "aidl",
1540 "-d dep/file/path",
1541 "--ninja",
1542 "-o place/for/output",
1543 "p/IFoo.aidl"};
1544 Options options = Options::From(args);
1545 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001546 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001547 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001548 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001549 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1550}
1551
Jiyong Parkdf202122019-09-30 20:48:35 +09001552TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001553 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1554 // this by calling aidl with every .aidl file it finds, then parsing the
1555 // generated dependency files. Those that reference .java output files are
1556 // for interfaces and those that do not are parcelables. However, for both
1557 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001558 vector<string> args = {
1559 "aidl",
1560 "-o place/for/output",
1561 "-d dep/file/path",
1562 "p/Foo.aidl"};
1563 Options options = Options::From(args);
1564 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001565 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001566 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001567 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001568 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1569}
1570
1571TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1572 vector<string> args = {
1573 "aidl",
1574 "--structured",
1575 "-o place/for/output",
1576 "-d dep/file/path",
1577 "p/Foo.aidl"};
1578 Options options = Options::From(args);
1579 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001580 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001581 string actual_dep_file_contents;
1582 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1583 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001584}
1585
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001586TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1587 vector<string> args = {
1588 "aidl",
1589 "--lang=java",
1590 "-o place/for/output",
1591 "p/Foo.aidl"};
1592 Options options = Options::From(args);
1593 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001594 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001595 string output_file_contents;
1596 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1597}
1598
Devin Moore21b26772020-08-26 16:37:56 -07001599TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001600 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001601 const string list_array_parcelable =
1602 "package a; parcelable Foo {\n"
1603 " List[] lists; }";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1606 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1607}
1608
Jiyong Parkf8d53612020-05-04 14:06:13 +09001609TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1610 AidlError error;
1611 string expected_stderr =
1612 "ERROR: a/IFoo.aidl:2.7-11: "
1613 "Encountered an untyped List or Map. The use of untyped List/Map is "
1614 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1615 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1616 if (GetLanguage() != Options::Language::JAVA) {
1617 expected_stderr =
1618 "ERROR: a/IFoo.aidl:2.1-7: "
1619 "Currently, only the Java backend supports non-generic List.\n";
1620 }
1621
1622 const string primitive_interface =
1623 "package a; interface IFoo {\n"
1624 " List foo(); }";
1625 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001626 AidlTypenames tn1;
1627 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001628 {"--structured"}));
1629 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001630
1631 string primitive_parcelable =
1632 "package a; parcelable IFoo {\n"
1633 " List foo;}";
1634 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001635 AidlTypenames tn2;
1636 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001637 {"--structured"}));
1638 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1639}
1640
Jeongik Cha225519b2020-08-29 01:55:32 +09001641TEST_P(AidlTest, ExtensionTest) {
1642 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001643 string extendable_parcelable =
1644 "package a; parcelable Data {\n"
1645 " ParcelableHolder extension;\n"
1646 " ParcelableHolder extension2;\n"
1647 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001648 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001649 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1650 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001651 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001652 "yet.\n",
1653 GetCapturedStderr());
1654 } else {
1655 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1656 EXPECT_EQ("", GetCapturedStderr());
1657 }
1658}
1659TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1660 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001661 string parcelableholder_return_interface =
1662 "package a; interface IFoo {\n"
1663 " ParcelableHolder foo();\n"
1664 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001665 EXPECT_EQ(nullptr,
1666 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001667
Jeongik Cha8f02a532020-10-14 00:16:28 +09001668 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001669 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001670 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001671 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001672 "yet.\n",
1673 GetCapturedStderr());
1674 return;
1675 }
1676 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1677 GetCapturedStderr());
1678}
1679
1680TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1681 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001682 string extendable_parcelable_arg_interface =
1683 "package a; interface IFoo {\n"
1684 " void foo(in ParcelableHolder ph);\n"
1685 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001686 EXPECT_EQ(nullptr,
1687 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1688
Jeongik Cha8f02a532020-10-14 00:16:28 +09001689 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001690 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001691 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001692 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001693 "yet.\n",
1694 GetCapturedStderr());
1695 return;
1696 }
1697 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1698 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001699}
1700
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001701TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1702 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001703 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001704 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1705 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001706 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001707 if (GetLanguage() == Options::Language::RUST) {
1708 EXPECT_EQ(
1709 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1710 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1711 "yet.\n",
1712 GetCapturedStderr());
1713 return;
1714 }
1715 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1716}
1717
Jooyung Han3f347ca2020-12-01 12:41:50 +09001718TEST_P(AidlTest, ParcelablesWithConstants) {
1719 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001720 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001721 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001722 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001723 EXPECT_EQ("", GetCapturedStderr());
1724}
1725
1726TEST_P(AidlTest, UnionWithConstants) {
1727 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001728 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001729 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001730 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001731 EXPECT_EQ("", GetCapturedStderr());
1732}
1733
Jooyung Han633eab62021-01-07 14:12:40 +09001734TEST_F(AidlTest, ConstantsWithAnnotations) {
1735 io_delegate_.SetFileContents("IFoo.aidl",
1736 "interface IFoo {\n"
1737 " @JavaPassthrough(annotation=\"@Foo\")\n"
1738 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1739 "}");
1740 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1741 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001742 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09001743 EXPECT_EQ("", GetCapturedStderr());
1744 string code;
1745 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1746 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1747 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1748}
1749
Jiyong Park02da7422018-07-16 16:00:26 +09001750TEST_F(AidlTest, ApiDump) {
1751 io_delegate_.SetFileContents(
1752 "foo/bar/IFoo.aidl",
1753 "package foo.bar;\n"
1754 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001755 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001756 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001757 " /* @hide applied \n"
1758 " @deprecated use foo2 */\n"
1759 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1760 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001761 " IFoo foo3(IFoo foo);\n"
1762 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001763 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001764 " /** blahblah\n"
1765 " @deprecated\n"
1766 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001767 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001768 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001769 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001770 "}\n");
1771 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1772 "package foo.bar;\n"
1773 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001774 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001775 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001776 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001777 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001778 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001779 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001780 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001781 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001782 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001783 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001784 "}\n");
1785 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001786 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1787 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001788 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001789 bool result = dump_api(options, io_delegate_);
1790 ASSERT_TRUE(result);
1791 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001792 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001793 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001794interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09001795 /**
1796 * @hide
1797 * @deprecated use foo2
1798 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001799 int foo(out int[] a, String b, boolean c, inout List<String> d);
1800 int foo2(@utf8InCpp String x, inout List<String> y);
1801 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1802 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09001803 /**
1804 * @deprecated reason why...
1805 */
Jiyong Parke59c3682018-09-11 23:10:25 +09001806 const int A = 1;
1807 const String STR = "Hello";
1808}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001809)"),
1810 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001811
Jiyong Parke59c3682018-09-11 23:10:25 +09001812 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09001813 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09001814/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001815parcelable Data {
1816 int x = 10;
1817 int y;
1818 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001819 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001820}
Jooyung Han161bb0f2021-01-21 12:30:16 +09001821)"),
1822 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09001823}
1824
Jiyong Parked65bf42018-08-28 15:43:27 +09001825TEST_F(AidlTest, ApiDumpWithManualIds) {
1826 io_delegate_.SetFileContents(
1827 "foo/bar/IFoo.aidl",
1828 "package foo.bar;\n"
1829 "interface IFoo {\n"
1830 " int foo() = 1;\n"
1831 " int bar() = 2;\n"
1832 " int baz() = 10;\n"
1833 "}\n");
1834
Jiyong Parke59c3682018-09-11 23:10:25 +09001835 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001836 Options options = Options::From(args);
1837 bool result = dump_api(options, io_delegate_);
1838 ASSERT_TRUE(result);
1839 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001840 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001841 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001842interface IFoo {
1843 int foo() = 1;
1844 int bar() = 2;
1845 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001846}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001847)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001848}
1849
1850TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001851 const string expected_stderr =
1852 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1853 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001854 io_delegate_.SetFileContents(
1855 "foo/bar/IFoo.aidl",
1856 "package foo.bar;\n"
1857 "interface IFoo {\n"
1858 " int foo() = 1;\n"
1859 " int bar();\n"
1860 " int baz() = 10;\n"
1861 "}\n");
1862
Jiyong Parke59c3682018-09-11 23:10:25 +09001863 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001864 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001865 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001866 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001868}
1869
Jooyung Han965e31d2020-11-27 12:30:16 +09001870TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1871 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1872 "package foo.bar;\n"
1873 "interface IFoo {\n"
1874 " @utf8InCpp String foo();\n"
1875 " const @utf8InCpp String bar = \"bar\";\n"
1876 "}\n");
1877
1878 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1879 Options options = Options::From(args);
1880 CaptureStderr();
1881 EXPECT_TRUE(dump_api(options, io_delegate_));
1882 EXPECT_EQ("", GetCapturedStderr());
1883 string actual;
1884 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001885 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1886interface IFoo {
1887 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001888 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001889}
1890)"),
1891 actual);
1892}
1893
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001894TEST_F(AidlTest, ApiDumpWithEnums) {
1895 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1896 "package foo.bar;\n"
1897 "enum Enum {\n"
1898 " FOO,\n"
1899 " BAR = FOO + 1,\n"
1900 "}\n");
1901
1902 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1903 Options options = Options::From(args);
1904 CaptureStderr();
1905 EXPECT_TRUE(dump_api(options, io_delegate_));
1906 EXPECT_EQ("", GetCapturedStderr());
1907 string actual;
1908 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1909 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1910 "enum Enum {\n"
1911 " FOO = 0,\n"
1912 " BAR = 1,\n"
1913 "}\n"),
1914 actual);
1915}
1916
1917TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1918 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1919 "package foo.bar;\n"
1920 "enum Enum {\n"
1921 " FOO,\n"
1922 "}\n");
1923 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1924 "package foo.bar;\n"
1925 "import foo.bar.Enum;\n"
1926 "parcelable Foo {\n"
1927 " Enum e = Enum.FOO;\n"
1928 "}\n");
1929
1930 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1931 Options options = Options::From(args);
1932 CaptureStderr();
1933 EXPECT_TRUE(dump_api(options, io_delegate_));
1934 EXPECT_EQ("", GetCapturedStderr());
1935 string actual;
1936 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1937 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1938 "parcelable Foo {\n"
1939 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1940 "}\n"),
1941 actual);
1942}
1943
Jooyung Han71dfec32021-05-23 07:18:58 +09001944TEST_F(AidlTest, ApiDumpWithGenerics) {
1945 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1946 "package foo.bar;\n"
1947 "parcelable Foo<T, U> {\n"
1948 "}\n");
1949
1950 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1951 Options options = Options::From(args);
1952 CaptureStderr();
1953 EXPECT_TRUE(dump_api(options, io_delegate_));
1954 EXPECT_EQ("", GetCapturedStderr());
1955 string actual;
1956 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1957 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1958 "parcelable Foo<T, U> {\n"
1959 "}\n"),
1960 actual);
1961}
1962
Jooyung Hand9ee6f02021-09-13 17:27:24 +09001963TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
1964 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
1965 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
1966
1967 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
1968 Options options = Options::From(args);
1969 CaptureStderr();
1970 EXPECT_FALSE(dump_api(options, io_delegate_));
1971 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
1972}
1973
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001974TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001975 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001976 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1977 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001978 const string expected_map_stderr =
1979 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001980 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1981 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001982 "package p; interface IFoo {"
1983 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001984 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001985 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001986 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001987
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001988 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001989 "package p; interface IFoo {"
1990 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001991 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001992 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001993 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001994}
1995
Jeongik Chae48d9942020-01-02 17:39:00 +09001996TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001997 const string expected_stderr =
1998 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09001999 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002000 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2001
2002 io_delegate_.SetFileContents("p/IFoo.aidl",
2003 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002004 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002005 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002006
2007 io_delegate_.SetFileContents("p/IFoo.aidl",
2008 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002009 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002010 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002011 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002012 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002013
2014 io_delegate_.SetFileContents("p/IFoo.aidl",
2015 "package p; interface IFoo {"
2016 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002017 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002018
2019 io_delegate_.SetFileContents("p/IFoo.aidl",
2020 "package p; interface IFoo {"
2021 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002022 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002023}
2024
Jeongik Chadf76dc72019-11-28 00:08:47 +09002025TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002026 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002027 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2028 io_delegate_.SetFileContents(options.InputFiles().front(),
2029 "package p; interface IFoo {"
2030 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002031 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002032 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002033 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002034}
2035
2036TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002037 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002038 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002039 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002040 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002041 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2042 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002043
Jooyung Han13f1fa52021-06-11 18:06:12 +09002044 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002045 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2046 io_delegate_.SetFileContents("p/IFoo.aidl",
2047 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002048 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002049 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002050 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002051 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002052 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002053 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002054 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002055 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002056 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002057 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002058 io_delegate_.SetFileContents("p/IFoo.aidl",
2059 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002060 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002061 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002062
2063 io_delegate_.SetFileContents("p/IFoo.aidl",
2064 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002065 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002066
2067 io_delegate_.SetFileContents("p/IFoo.aidl",
2068 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002069 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002070
Steven Moreland4e059132021-08-11 13:36:30 -07002071 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002072}
2073
Jeongik Cha0e426012019-07-29 15:57:02 +09002074TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2075 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002076 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2077 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002078 for (const auto& rawOption : rawOptions) {
2079 string expected_stderr =
2080 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002081 Options options = Options::From(rawOption);
2082 io_delegate_.SetFileContents(options.InputFiles().front(),
2083 "package foo.bar;\n"
2084 "interface IFoo1 { int foo(); }\n"
2085 "interface IFoo2 { int foo(); }\n"
2086 "parcelable Data1 { int a; int b;}\n"
2087 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002088 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002089 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002090 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002091
Jeongik Cha0e426012019-07-29 15:57:02 +09002092 io_delegate_.SetFileContents(options.InputFiles().front(),
2093 "package foo.bar;\n"
2094 "interface IFoo1 { int foo(); }\n"
2095 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002096 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002097 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002098 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002099
Devin Moore5de18ed2020-04-02 13:52:29 -07002100 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002101 io_delegate_.SetFileContents(options.InputFiles().front(),
2102 "package foo.bar;\n"
2103 "parcelable Data1 { int a; int b;}\n"
2104 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002105 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002106 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002107 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002108 }
2109}
2110
Devin Moorebdba2a82020-03-31 15:19:02 -07002111TEST_P(AidlTest, FailParseOnEmptyFile) {
2112 const string contents = "";
2113 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2114 CaptureStderr();
2115 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2117}
2118
Jiyong Parkb034bf02018-07-30 17:44:33 +09002119TEST_F(AidlTest, MultipleInputFiles) {
2120 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002121 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002122
2123 io_delegate_.SetFileContents(options.InputFiles().at(0),
2124 "package foo.bar;\n"
2125 "import foo.bar.Data;\n"
2126 "interface IFoo { Data getData(); }\n");
2127
2128 io_delegate_.SetFileContents(options.InputFiles().at(1),
2129 "package foo.bar;\n"
2130 "import foo.bar.IFoo;\n"
2131 "parcelable Data { IFoo foo; }\n");
2132
Steven Moreland4e059132021-08-11 13:36:30 -07002133 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002134
2135 string content;
2136 for (const auto file : {
2137 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2138 content.clear();
2139 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2140 EXPECT_FALSE(content.empty());
2141 }
2142}
2143
2144TEST_F(AidlTest, MultipleInputFilesCpp) {
2145 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002146 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002147
2148 io_delegate_.SetFileContents(options.InputFiles().at(0),
2149 "package foo.bar;\n"
2150 "import foo.bar.Data;\n"
2151 "interface IFoo { Data getData(); }\n");
2152
2153 io_delegate_.SetFileContents(options.InputFiles().at(1),
2154 "package foo.bar;\n"
2155 "import foo.bar.IFoo;\n"
2156 "parcelable Data { IFoo foo; }\n");
2157
Steven Moreland4e059132021-08-11 13:36:30 -07002158 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002159
2160 string content;
2161 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002162 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002163 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2164 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2165 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2166 content.clear();
2167 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2168 EXPECT_FALSE(content.empty());
2169 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002170}
2171
Andrei Homescub62afd92020-05-11 19:24:59 -07002172TEST_F(AidlTest, MultipleInputFilesRust) {
2173 Options options =
2174 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2175
2176 io_delegate_.SetFileContents(options.InputFiles().at(0),
2177 "package foo.bar;\n"
2178 "import foo.bar.Data;\n"
2179 "interface IFoo { Data getData(); }\n");
2180
2181 io_delegate_.SetFileContents(options.InputFiles().at(1),
2182 "package foo.bar;\n"
2183 "import foo.bar.IFoo;\n"
2184 "parcelable Data { IFoo foo; }\n");
2185
Steven Moreland4e059132021-08-11 13:36:30 -07002186 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002187
2188 string content;
2189 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2190 content.clear();
2191 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2192 EXPECT_FALSE(content.empty());
2193 }
2194}
2195
Devin Moore097a3ab2020-03-11 16:08:44 -07002196TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2197 const string expected_stderr =
2198 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002199 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2200 // int getInterfaceVersion() is one of the meta transactions
2201 io_delegate_.SetFileContents(options.InputFiles().front(),
2202 "package p; interface IFoo {"
2203 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002204 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002205 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2207}
Jiyong Park309668e2018-07-28 16:55:44 +09002208
Devin Moore097a3ab2020-03-11 16:08:44 -07002209TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2210 // boolean getInterfaceVersion() is not a meta transaction, but should be
2211 // prevented because return type is not part of a method signature
2212 const string expected_stderr =
2213 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2214 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002215 io_delegate_.SetFileContents(options.InputFiles().front(),
2216 "package p; interface IFoo {"
2217 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002218 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002219 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002220 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2221}
Jiyong Park309668e2018-07-28 16:55:44 +09002222
Devin Moore097a3ab2020-03-11 16:08:44 -07002223TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002224 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002225 const string expected_stderr =
2226 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2227 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002228 io_delegate_.SetFileContents(options.InputFiles().front(),
2229 "package p; interface IFoo {"
2230 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002231 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002232 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002234
2235 // this is not a meta interface method as it differs type arguments
2236 io_delegate_.SetFileContents(options.InputFiles().front(),
2237 "package p; interface IFoo {"
2238 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002239 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002240}
2241
Jooyung Hanb8a97772021-01-19 01:27:38 +09002242TEST_F(AidlTest, CheckApiForEquality) {
2243 CaptureStderr();
2244 Options options = Options::From("aidl --checkapi=equal old new");
2245
2246 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2247 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2248 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2249 "package p; interface IFoo{ @utf8InCpp String foo();}");
2250
2251 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2252 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2253}
2254
Daniel Norman85aed542019-08-21 12:01:14 -07002255TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002256 Options options = Options::From("aidl --checkapi old new");
2257 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2258 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2259 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2260 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2261
2262 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2263}
2264
Jiyong Park3656c3c2018-08-01 20:02:01 +09002265TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002266 Options options = Options::From("aidl --checkapi old new");
2267 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2268 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002269
2270 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2271}
2272
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002273TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2274 Options options = Options::From("aidl --checkapi old new");
2275 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2276 const string enum_definition = "package p; enum Enum { FOO }";
2277 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2278 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2279 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2280 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2281
2282 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2283}
2284
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002285TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2286 Options options = Options::From("aidl --checkapi old new -I import");
2287
2288 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2289 io_delegate_.SetFileContents("new/p/Foo.aidl",
2290 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2291 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2292
2293 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2294}
2295
Jooyung Han02a11be2021-02-11 13:18:06 +09002296TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2297 Options options = Options::From("aidl --checkapi=equal old new");
2298 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2299 const string enum_definition = "package p; enum Enum { FOO }";
2300 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2301 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2302 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2303 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2304 CaptureStderr();
2305 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2306 EXPECT_EQ("", GetCapturedStderr());
2307}
2308
Daniel Norman85aed542019-08-21 12:01:14 -07002309class AidlTestCompatibleChanges : public AidlTest {
2310 protected:
2311 Options options_ = Options::From("aidl --checkapi old new");
2312};
2313
2314TEST_F(AidlTestCompatibleChanges, NewType) {
2315 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2316 "package p;"
2317 "interface IFoo {"
2318 " void foo(int a);"
2319 "}");
2320 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2321 "package p;"
2322 "interface IFoo {"
2323 " void foo(int a);"
2324 "}");
2325 io_delegate_.SetFileContents("new/p/IBar.aidl",
2326 "package p;"
2327 "interface IBar {"
2328 " void bar();"
2329 "}");
2330 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2331}
2332
2333TEST_F(AidlTestCompatibleChanges, NewMethod) {
2334 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2335 "package p;"
2336 "interface IFoo {"
2337 " void foo(int a);"
2338 "}");
2339 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2340 "package p;"
2341 "interface IFoo {"
2342 " void foo(int a);"
2343 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002344 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002345 "}");
2346 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2347}
2348
2349TEST_F(AidlTestCompatibleChanges, NewField) {
2350 io_delegate_.SetFileContents("old/p/Data.aidl",
2351 "package p;"
2352 "parcelable Data {"
2353 " int foo;"
2354 "}");
2355 io_delegate_.SetFileContents("new/p/Data.aidl",
2356 "package p;"
2357 "parcelable Data {"
2358 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002359 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002360 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002361 "}");
2362 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2363}
2364
Jooyung Han05bd8a82021-04-28 23:56:38 +09002365TEST_F(AidlTestCompatibleChanges, NewField2) {
2366 io_delegate_.SetFileContents("old/p/Data.aidl",
2367 "package p;"
2368 "parcelable Data {"
2369 "}");
2370 io_delegate_.SetFileContents("new/p/Data.aidl",
2371 "package p;"
2372 "parcelable Data {"
2373 " int foo = 0;"
2374 "}");
2375 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2376}
2377
Daniel Norman85aed542019-08-21 12:01:14 -07002378TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2379 io_delegate_.SetFileContents("old/p/Enum.aidl",
2380 "package p;"
2381 "enum Enum {"
2382 " FOO = 1,"
2383 "}");
2384 io_delegate_.SetFileContents("new/p/Enum.aidl",
2385 "package p;"
2386 "enum Enum {"
2387 " FOO = 1,"
2388 " BAR = 2,"
2389 "}");
2390 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2391}
2392
2393TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2394 io_delegate_.SetFileContents("old/p/Enum.aidl",
2395 "package p;"
2396 "enum Enum {"
2397 " FOO = 1,"
2398 " BAR = 2,"
2399 "}");
2400 io_delegate_.SetFileContents("new/p/Enum.aidl",
2401 "package p;"
2402 "enum Enum {"
2403 " BAR = 2,"
2404 " FOO = 1,"
2405 "}");
2406 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2407}
2408
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002409TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2410 io_delegate_.SetFileContents("old/p/Union.aidl",
2411 "package p;"
2412 "union Union {"
2413 " String foo;"
2414 "}");
2415 io_delegate_.SetFileContents("new/p/Union.aidl",
2416 "package p;"
2417 "union Union {"
2418 " String foo;"
2419 " int num;"
2420 "}");
2421 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2422}
2423
Daniel Norman85aed542019-08-21 12:01:14 -07002424TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002425 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2426 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002427 "interface IFoo {"
2428 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 "}");
2430 io_delegate_.SetFileContents("old/p/Data.aidl",
2431 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002432 "parcelable Data {"
2433 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002434 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002435 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2436 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002437 "interface IFoo {"
2438 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002439 "}");
2440 io_delegate_.SetFileContents("new/p/Data.aidl",
2441 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002442 "parcelable Data {"
2443 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002444 "}");
2445 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2446 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002447 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002448 " void foo(int a);"
2449 "}");
2450 io_delegate_.SetFileContents("new/q/Data.aidl",
2451 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002452 "parcelable Data {"
2453 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002454 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002455 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2456}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002457
Daniel Norman85aed542019-08-21 12:01:14 -07002458TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2459 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2460 "package p;"
2461 "interface IFoo {"
2462 " void foo(int a);"
2463 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002464 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2465 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002466 "interface IFoo {"
2467 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002468 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002469 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2470}
Jiyong Parke59c3682018-09-11 23:10:25 +09002471
Daniel Norman85aed542019-08-21 12:01:14 -07002472TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002473 io_delegate_.SetFileContents("old/p/I.aidl",
2474 "package p; interface I {"
2475 "const int A = 1; }");
2476 io_delegate_.SetFileContents("new/p/I.aidl",
2477 "package p ; interface I {"
2478 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002479 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2480}
Jiyong Parka428d212018-08-29 22:26:30 +09002481
Daniel Norman85aed542019-08-21 12:01:14 -07002482TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002483 io_delegate_.SetFileContents("old/p/I.aidl",
2484 "package p; interface I {"
2485 "const int A = 1; const int B = 2;}");
2486 io_delegate_.SetFileContents("new/p/I.aidl",
2487 "package p ; interface I {"
2488 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002489 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002490}
2491
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002492TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2493 io_delegate_.SetFileContents("old/p/Foo.aidl",
2494 "package p;"
2495 "@JavaPassthrough(annotation=\"Alice\")"
2496 "@JavaPassthrough(annotation=\"Bob\")"
2497 "parcelable Foo {}");
2498 io_delegate_.SetFileContents("new/p/Foo.aidl",
2499 "package p;"
2500 "@JavaPassthrough(annotation=\"Bob\")"
2501 "@JavaPassthrough(annotation=\"Alice\")"
2502 "parcelable Foo {}");
2503 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2504}
2505
Jooyung Han00073272020-11-27 14:20:20 +09002506TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2507 io_delegate_.SetFileContents("old/p/Foo.aidl",
2508 "package p;"
2509 "parcelable Foo {}");
2510 io_delegate_.SetFileContents("new/p/Foo.aidl",
2511 "package p;"
2512 "@JavaPassthrough(annotation=\"@Deprecated\")"
2513 "parcelable Foo {}");
2514 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2515}
2516
Jooyung Han636fd2f2020-10-22 11:33:45 +09002517TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2518 io_delegate_.SetFileContents("old/p/Data.aidl",
2519 "package p;"
2520 "parcelable Data {"
2521 " int num;"
2522 "}");
2523 io_delegate_.SetFileContents(
2524 "new/p/Data.aidl",
2525 "package p;"
2526 "parcelable Data {"
2527 " int num;"
2528 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2529 "}");
2530 io_delegate_.SetFileContents("new/p/Enum.aidl",
2531 "package p;"
2532 "enum Enum {"
2533 " FOO = 0,"
2534 " BAR = 1,"
2535 "}");
2536 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2537}
2538
Jooyung Han308bbe02021-04-27 12:09:59 +09002539TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2540 io_delegate_.SetFileContents("old/p/Data.aidl",
2541 "package p;\n"
2542 "parcelable Data {\n"
2543 " p.Enum e;\n"
2544 "}");
2545 io_delegate_.SetFileContents("old/p/Enum.aidl",
2546 "package p;\n"
2547 "enum Enum {\n"
2548 " FOO = 0,\n"
2549 " BAR = 1,\n"
2550 "}");
2551 io_delegate_.SetFileContents("new/p/Data.aidl",
2552 "package p;\n"
2553 "parcelable Data {\n"
2554 " p.Enum e = p.Enum.FOO;\n"
2555 "}");
2556 io_delegate_.SetFileContents("new/p/Enum.aidl",
2557 "package p;\n"
2558 "enum Enum {\n"
2559 " FOO = 0,\n"
2560 " BAR = 1,\n"
2561 "}");
2562 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2563}
2564
Daniel Norman85aed542019-08-21 12:01:14 -07002565class AidlTestIncompatibleChanges : public AidlTest {
2566 protected:
2567 Options options_ = Options::From("aidl --checkapi old new");
2568};
2569
2570TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002571 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002572 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2573 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002574 "interface IFoo {"
2575 " void foo(in String[] str);"
2576 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002577 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002578 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002579 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002581}
2582
2583TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002584 const string expected_stderr =
2585 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002586 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2587 "package p;"
2588 "interface IFoo {"
2589 " void foo(in String[] str);"
2590 " void bar(@utf8InCpp String str);"
2591 "}");
2592 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2593 "package p;"
2594 "interface IFoo {"
2595 " void foo(in String[] str);"
2596 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002597 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002598 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002599 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002600}
2601
Jiyong Parkf8d53612020-05-04 14:06:13 +09002602TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2603 const string expected_stderr =
2604 "ERROR: new/p/IFoo.aidl:1.61-65: "
2605 "Encountered an untyped List or Map. The use of untyped List/Map is "
2606 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2607 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2608 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2609 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2610 "package p;"
2611 "interface IFoo {"
2612 " void foo(in String[] str);"
2613 "}");
2614 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2615 "package p;"
2616 "interface IFoo {"
2617 " void foo(in String[] str);"
2618 " void bar(in List arg);"
2619 "}");
2620 CaptureStderr();
2621 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2623}
2624
2625TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2626 const string expected_stderr =
2627 "ERROR: new/p/Data.aidl:1.54-59: "
2628 "Encountered an untyped List or Map. The use of untyped List/Map is "
2629 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2630 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2631 "ERROR: new/p/Data.aidl: Failed to read.\n";
2632 io_delegate_.SetFileContents("old/p/Data.aidl",
2633 "package p;"
2634 "parcelable Data {"
2635 " int foo;"
2636 "}");
2637 io_delegate_.SetFileContents("new/p/Data.aidl",
2638 "package p;"
2639 "parcelable Data {"
2640 " int foo;"
2641 " @nullable List list;"
2642 "}");
2643 CaptureStderr();
2644 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2645 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2646}
2647
Daniel Norman85aed542019-08-21 12:01:14 -07002648TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002649 const string expected_stderr =
2650 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002651 io_delegate_.SetFileContents("old/p/Data.aidl",
2652 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002653 "parcelable Data {"
2654 " int foo;"
2655 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002656 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002657 io_delegate_.SetFileContents("new/p/Data.aidl",
2658 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002659 "parcelable Data {"
2660 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002661 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002662 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002663 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002664 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002665}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002666
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002667TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2668 const string expected_stderr =
2669 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2670 "backends. Please either provide a default value for this field or mark the field as "
2671 "@nullable. This value or a null value will be used automatically when an old version of "
2672 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2673 "order to make sure your code continues to be backwards compatible, make sure the default or "
2674 "null value does not cause a semantic change to this parcelable.\n";
2675 io_delegate_.SetFileContents("old/p/Data.aidl",
2676 "package p;"
2677 "parcelable Data {"
2678 " int num;"
2679 "}");
2680 io_delegate_.SetFileContents("new/p/Data.aidl",
2681 "package p;"
2682 "parcelable Data {"
2683 " int num;"
2684 " String str;"
2685 "}");
2686 CaptureStderr();
2687 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2688 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2689}
2690
Jooyung Han636fd2f2020-10-22 11:33:45 +09002691TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2692 const string expected_stderr =
2693 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2694 "Please make sure 'Enum' has '0' as a valid value.\n";
2695 io_delegate_.SetFileContents("old/p/Data.aidl",
2696 "package p;"
2697 "parcelable Data {"
2698 " int num;"
2699 "}");
2700 io_delegate_.SetFileContents("new/p/Data.aidl",
2701 "package p;"
2702 "parcelable Data {"
2703 " int num;"
2704 " p.Enum e;"
2705 "}");
2706 io_delegate_.SetFileContents("new/p/Enum.aidl",
2707 "package p;"
2708 "enum Enum {"
2709 " FOO = 1,"
2710 " BAR = 2,"
2711 "}");
2712 CaptureStderr();
2713 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2714 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2715}
2716
Daniel Norman85aed542019-08-21 12:01:14 -07002717TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002718 const string expected_stderr =
2719 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002720 io_delegate_.SetFileContents("old/p/Enum.aidl",
2721 "package p;"
2722 "enum Enum {"
2723 " FOO = 1,"
2724 " BAR = 2,"
2725 "}");
2726 io_delegate_.SetFileContents("new/p/Enum.aidl",
2727 "package p;"
2728 "enum Enum {"
2729 " BAR = 2,"
2730 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002731 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002732 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002733 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002734}
2735
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002736TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2737 const string expected_stderr =
2738 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2739 io_delegate_.SetFileContents("old/p/Union.aidl",
2740 "package p;"
2741 "union Union {"
2742 " String str;"
2743 " int num;"
2744 "}");
2745 io_delegate_.SetFileContents("new/p/Union.aidl",
2746 "package p;"
2747 "union Union {"
2748 " String str;"
2749 "}");
2750 CaptureStderr();
2751 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2752 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2753}
2754
Daniel Norman85aed542019-08-21 12:01:14 -07002755TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002756 const string expected_stderr =
2757 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002758 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2759 "package p;"
2760 "interface IFoo {"
2761 " void foo(in String[] str);"
2762 " void bar(@utf8InCpp String str);"
2763 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002764 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2765 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002766 "interface IFoo {"
2767 " void foo(in String[] str);"
2768 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002769 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002770 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002771 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002773}
2774
Daniel Norman85aed542019-08-21 12:01:14 -07002775TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002776 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002777 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2778 "package p;"
2779 "interface IFoo {"
2780 " void foo(in String[] str);"
2781 " void bar(@utf8InCpp String str);"
2782 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002783 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2784 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002785 "interface IFoo2 {"
2786 " void foo(in String[] str);"
2787 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002788 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002789 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002790 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002791 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002792}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002793
Daniel Norman85aed542019-08-21 12:01:14 -07002794TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002795 const string expected_stderr =
2796 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002797 io_delegate_.SetFileContents("old/p/Enum.aidl",
2798 "package p;"
2799 "enum Enum {"
2800 " FOO = 1,"
2801 " BAR = 2,"
2802 "}");
2803 io_delegate_.SetFileContents("new/p/Enum.aidl",
2804 "package p;"
2805 "enum Enum {"
2806 " FOO = 3,"
2807 " BAR = 2,"
2808 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002809 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002810 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002811 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002812}
2813
2814TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002815 const string expected_stderr =
2816 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2817 "from 0 to 1.\n"
2818 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2819 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002820 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2821 "package p;"
2822 "interface IFoo {"
2823 " void foo(in String[] str);"
2824 " void bar(@utf8InCpp String str);"
2825 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002826 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2827 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002828 "interface IFoo {"
2829 " void bar(@utf8InCpp String str);"
2830 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002831 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002832 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002833 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002834 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002835}
2836
2837TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002838 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002839 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2840 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002841 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002842 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002843 "parcelable Data {"
2844 " int foo;"
2845 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002846 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002847 io_delegate_.SetFileContents("new/p/Data.aidl",
2848 "package p;"
2849 "parcelable Data {"
2850 " int bar;"
2851 " int foo;"
2852 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002853 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002854 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002855 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002856}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002857
Daniel Norman85aed542019-08-21 12:01:14 -07002858TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002859 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002860 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002861 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002862 "interface IFoo {"
2863 " void foo(in String[] str);"
2864 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002865 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002866 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2867 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002868 "interface IFoo {"
2869 " void foo(out String[] str);"
2870 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002871 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002872 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002873 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002874 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002875}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002876
Daniel Norman85aed542019-08-21 12:01:14 -07002877TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002878 const string expected_stderr =
2879 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002880 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2881 "package p;"
2882 "interface IFoo {"
2883 " void foo(in String[] str);"
2884 " void bar(@utf8InCpp String str);"
2885 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002886 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2887 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002888 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002889 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002890 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002891 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002892 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002893 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002894 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002895}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002896
Daniel Norman85aed542019-08-21 12:01:14 -07002897TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002898 const string expected_stderr =
2899 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002900 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2901 "package p;"
2902 "interface IFoo {"
2903 " void foo(in String[] str);"
2904 " void bar(@utf8InCpp String str);"
2905 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002906 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2907 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002908 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002909 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002910 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002911 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002912 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002913 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002914 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002915}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002916
Jooyung Han60b2fde2020-10-29 15:12:40 +09002917TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2918 const string expected_stderr =
2919 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2920 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2921 io_delegate_.SetFileContents("old/p/Foo.aidl",
2922 "package p;"
2923 "@Backing(type=\"byte\")"
2924 "enum Foo {"
2925 " FOO, BAR,"
2926 "}");
2927 io_delegate_.SetFileContents("new/p/Foo.aidl",
2928 "package p;"
2929 "@Backing(type=\"long\")"
2930 "enum Foo {"
2931 " FOO, BAR,"
2932 "}");
2933 CaptureStderr();
2934 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2935 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2936}
2937
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002938TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2939 const string expected_stderr =
2940 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2941 "to @JavaPassthrough(annotation=\"Bob\")\n";
2942 io_delegate_.SetFileContents("old/p/Foo.aidl",
2943 "package p;"
2944 "@JavaPassthrough(annotation=\"Alice\")"
2945 "parcelable Foo {}");
2946 io_delegate_.SetFileContents("new/p/Foo.aidl",
2947 "package p;"
2948 "@JavaPassthrough(annotation=\"Bob\")"
2949 "parcelable Foo {}");
2950
2951 CaptureStderr();
2952 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2954}
2955
Devin Mooredb7ac512020-08-07 11:17:36 -07002956TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2957 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002958 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002959 io_delegate_.SetFileContents("old/p/Foo.aidl",
2960 "package p;"
2961 "parcelable Foo {"
2962 " int A;"
2963 "}");
2964 io_delegate_.SetFileContents("new/p/Foo.aidl",
2965 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002966 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002967 " int A;"
2968 "}");
2969 CaptureStderr();
2970 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2972}
2973
2974TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2975 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002976 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07002977 io_delegate_.SetFileContents("old/p/Foo.aidl",
2978 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09002979 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07002980 " int A;"
2981 "}");
2982 io_delegate_.SetFileContents("new/p/Foo.aidl",
2983 "package p;"
2984 "parcelable Foo {"
2985 " int A;"
2986 "}");
2987 CaptureStderr();
2988 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2990}
2991
Daniel Norman85aed542019-08-21 12:01:14 -07002992TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002994 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2995 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002996 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002997 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002998 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002999 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003000}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003001
Daniel Norman85aed542019-08-21 12:01:14 -07003002TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003003 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003004 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3005 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003006 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003007 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003008 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003009}
Jiyong Parka428d212018-08-29 22:26:30 +09003010
Daniel Norman85aed542019-08-21 12:01:14 -07003011TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003012 const string expected_stderr =
3013 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003014 io_delegate_.SetFileContents("old/p/I.aidl",
3015 "package p; interface I {"
3016 "const int A = 1; const int B = 2;}");
3017 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003019 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003021}
Jiyong Parka428d212018-08-29 22:26:30 +09003022
Daniel Norman85aed542019-08-21 12:01:14 -07003023TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003024 const string expected_stderr =
3025 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003026 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3027 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003028 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003029 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003030 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003031}
3032
Devin Moorec7e47a32020-08-07 10:55:25 -07003033TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3034 const string expected_stderr =
3035 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3036 "This is an incompatible change for FixedSize types.\n";
3037 io_delegate_.SetFileContents("old/p/Foo.aidl",
3038 "package p; @FixedSize parcelable Foo { int A = 1; }");
3039 io_delegate_.SetFileContents("new/p/Foo.aidl",
3040 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3041 CaptureStderr();
3042 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3043 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3044}
3045
Jeongik Cha68d18e72021-04-29 20:07:01 +09003046TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3047 const string expected_stderr =
3048 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3049 "android.net.UidRangeParcel is changed from 1 to 2. "
3050 "But it is forbidden because of legacy support.\n";
3051 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3052 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3053 io_delegate_.SetFileContents(
3054 "new/android/net/UidRangeParcel.aidl",
3055 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3056 CaptureStderr();
3057 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3058 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3059}
3060
Devin Moorec7e47a32020-08-07 10:55:25 -07003061TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3062 const string expected_stderr =
3063 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3064 io_delegate_.SetFileContents("old/p/Foo.aidl",
3065 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3066 io_delegate_.SetFileContents("new/p/Foo.aidl",
3067 "package p; @FixedSize parcelable Foo { int A = 1; }");
3068 CaptureStderr();
3069 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3070 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3071}
3072
3073TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3074 const string expected_stderr =
3075 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3076 "a.\n"
3077 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3078 "b.\n"
3079 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3080 "c.\n"
3081 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3082 "d.\n"
3083 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3084 "e.\n"
3085 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3086 "f.\n";
3087
3088 io_delegate_.SetFileContents("Foo.aidl",
3089 "@FixedSize parcelable Foo { "
3090 " int[] a;"
3091 " Bar b;"
3092 " String c;"
3093 " ParcelFileDescriptor d;"
3094 " IBinder e;"
3095 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00003096 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07003097 "}");
3098 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003099 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003100
3101 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003102 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003103 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3104}
3105
3106TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3107 const string expected_stderr = "";
3108
3109 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3110 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3111 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003112 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003113
3114 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003115 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3117}
3118
Jiyong Park8c380532018-08-30 14:55:26 +09003119TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003120 const string expected_stderr =
3121 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3122 "dir1/q/IBar.aidl\n"
3123 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003124 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003125 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3126 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3127 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3128 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3129
Devin Moore097a3ab2020-03-11 16:08:44 -07003130 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003131 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003132 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003133}
3134
Jiyong Parked65bf42018-08-28 15:43:27 +09003135TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003136 const string expected_stderr =
3137 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3138 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003139 Options options = Options::From("aidl --checkapi old new");
3140 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3141 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003142
3143 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3144
Jiyong Parke59c3682018-09-11 23:10:25 +09003145 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003146 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003147 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003148 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003149}
3150
Jooyung Han652ce482021-02-26 12:40:35 +09003151TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3152 Options options =
3153 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003154
3155 // use without import
3156 io_delegate_.SetFileContents("p/IFoo.aidl",
3157 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003158 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003159
3160 // capture output files
3161 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003162
Devin Moore7b8d5c92020-03-17 14:14:08 -07003163 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003164 io_delegate_.SetFileContents(
3165 "p/IFoo.aidl",
3166 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003167 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003168 // output files should be the same
3169 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003170
3171 // use with import (as before)
3172 io_delegate_.SetFileContents("p/IFoo.aidl",
3173 "package p;"
3174 "import android.os.ParcelFileDescriptor;"
3175 "interface IFoo{"
3176 " void foo(in ParcelFileDescriptor fd);"
3177 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003178 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003179 // output files should be the same
3180 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003181}
Jiyong Parked65bf42018-08-28 15:43:27 +09003182
Jooyung Han020d8d12021-02-26 17:23:02 +09003183TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3184 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3185 CaptureStderr();
3186 io_delegate_.SetFileContents("p/IFoo.aidl",
3187 "package p;"
3188 "interface IFoo{"
3189 " void foo(out ParcelFileDescriptor fd);"
3190 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003191 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003192 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3193}
3194
3195TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3196 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3197 CaptureStderr();
3198 io_delegate_.SetFileContents("p/IFoo.aidl",
3199 "package p;"
3200 "interface IFoo{"
3201 " void foo(ParcelFileDescriptor fd);"
3202 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003203 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003204 EXPECT_THAT(GetCapturedStderr(),
3205 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3206}
3207
Jiyong Park3633b722019-04-11 15:38:26 +09003208TEST_F(AidlTest, ManualIds) {
3209 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3210 io_delegate_.SetFileContents("IFoo.aidl",
3211 "interface IFoo {\n"
3212 " void foo() = 0;\n"
3213 " void bar() = 1;\n"
3214 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003215 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003216}
3217
3218TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3219 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3220 io_delegate_.SetFileContents("IFoo.aidl",
3221 "interface IFoo {\n"
3222 " void foo() = 0;\n"
3223 " void bar() = 1;\n"
3224 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003225 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003226}
3227
3228TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003229 const string expected_stderr =
3230 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003231 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3232 io_delegate_.SetFileContents("IFoo.aidl",
3233 "interface IFoo {\n"
3234 " void foo() = 3;\n"
3235 " void bar() = 3;\n"
3236 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003237 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003238 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003240}
3241
3242TEST_F(AidlTest, FailOnOutOfRangeIds) {
3243 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003244 const string expected_stderr =
3245 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3246 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003247 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3248 io_delegate_.SetFileContents("IFoo.aidl",
3249 "interface IFoo {\n"
3250 " void foo() = 3;\n"
3251 " void bar() = 16777115;\n"
3252 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003253 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003254 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003255 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003256}
3257
3258TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003259 const string expected_stderr =
3260 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003261 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3262 io_delegate_.SetFileContents("IFoo.aidl",
3263 "interface IFoo {\n"
3264 " void foo() = 3;\n"
3265 " void bar();\n"
3266 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003267 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003268 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003269 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003270}
3271
Jiyong Parkc6816252019-07-08 08:12:28 +09003272TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3273 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3274 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3275 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003276 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003277}
3278
3279TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003280 const string expected_stderr =
3281 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3282 "dir/IBar.aidl\n"
3283 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003284 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003285
Jiyong Parkc6816252019-07-08 08:12:28 +09003286 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3287 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3288 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3289 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003290 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003291 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003293}
3294
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003295TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3296 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3297 "package a.b;\n"
3298 "import a.b.IBar;\n"
3299 "import a.b.IQux;\n"
3300 "interface IFoo { IQux foo(); }\n");
3301 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3302 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3303
3304 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003305 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003306
3307 string output;
3308 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3309 // IBar was imported but wasn't used. include is not expected.
3310 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3311 // IBar was imported and used. include is expected.
3312 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3313}
3314
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003315TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003316 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003317 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003318 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3319 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003320 interface IFoo {
3321 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003322 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003323 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003324 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003325 // JavaPassthrough should work with other types as well (e.g. enum)
3326 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3327 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3328 @JavaPassthrough(annotation="@com.android.AliceTwo")
3329 @Backing(type="byte")
3330 enum MyEnum {
3331 a, b, c
3332 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003333
Jooyung Han4cde01d2020-10-13 11:10:47 +09003334 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003335 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003336
3337 string java_out;
3338 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003339 // type-decl-level annotations with newline at the end
3340 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3341 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3342 // member-decl-level annotations with newline at the end
3343 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3344 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3345 // inline annotations with space at the end
3346 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003347
Jooyung Han4cde01d2020-10-13 11:10:47 +09003348 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3349 // type-decl-level annotations with newline at the end
3350 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3351 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3352
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003353 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003354 Options cpp_options =
3355 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003356 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003357
Jooyung Han4cde01d2020-10-13 11:10:47 +09003358 Options ndk_options =
3359 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003360 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003361
Jooyung Han4cde01d2020-10-13 11:10:47 +09003362 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003363 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003364}
3365
Andrei Homescue61feb52020-08-18 15:44:24 -07003366TEST_F(AidlTest, ParseRustDerive) {
3367 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3368 @RustDerive(Clone=true, Copy=false)
3369 parcelable Foo {
3370 int a;
3371 })");
3372
3373 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003374 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003375
3376 string rust_out;
3377 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3378 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3379
3380 // Other backends shouldn't be bothered
3381 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003382 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003383
3384 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003385 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003386
3387 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003388 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003389}
3390
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003391TEST_F(AidlTest, EmptyEnforceAnnotation) {
3392 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3393 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3394 interface IFoo {
3395 @Enforce()
3396 void Protected();
3397 })");
3398
3399 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3400 CaptureStderr();
3401 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3403}
3404
3405TEST_F(AidlTest, EmptyEnforceCondition) {
3406 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3407 interface IFoo {
3408 @Enforce(condition="")
3409 void Protected();
3410 })");
3411
3412 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3413 CaptureStderr();
3414 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3415 EXPECT_THAT(GetCapturedStderr(),
3416 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3417}
3418
3419TEST_F(AidlTest, InvalidEnforceCondition) {
3420 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3421 interface IFoo {
3422 @Enforce(condition="invalid")
3423 void Protected();
3424 })");
3425
3426 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3427 CaptureStderr();
3428 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3429 EXPECT_THAT(GetCapturedStderr(),
3430 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3431}
3432
Jiyong Park56f73d72019-06-11 12:20:28 +09003433class AidlOutputPathTest : public AidlTest {
3434 protected:
3435 void SetUp() override {
3436 AidlTest::SetUp();
3437 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3438 }
3439
3440 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003441 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003442 // check the existence
3443 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3444 }
3445};
3446
3447TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3448 // <out_dir> / <package_name> / <type_name>.java
3449 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3450}
3451
3452TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3453 // when output file is explicitly set, it is always respected. -o option is
3454 // ignored.
3455 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3456}
3457
3458TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3459 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3460}
3461
3462TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3463 // output is the same as the input file except for the suffix
3464 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3465}
3466
Devin Moore7b8d5c92020-03-17 14:14:08 -07003467TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003468 AidlError error;
3469 const string expected_stderr =
3470 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3471 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003472 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3473 R"(package p;
3474 interface IFoo {
3475 const int int32_max_oob = 2147483650;
3476 }
3477 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003478 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003479 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3480 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003481}
3482
Devin Moore7b8d5c92020-03-17 14:14:08 -07003483TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003484 AidlError error;
3485 const string expected_stderr =
3486 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3487 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003488 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3489 R"(package p;
3490 interface IFoo {
3491 const int int32_min_oob = -2147483650;
3492 }
3493 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003494 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003495 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3496 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003497}
3498
Devin Moore7b8d5c92020-03-17 14:14:08 -07003499TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003500 AidlError error;
3501 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003502 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003503 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003504 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3505 R"(package p;
3506 interface IFoo {
3507 const long int64_max_oob = 21474836509999999999999999;
3508 }
3509 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003510 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3512 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003513}
3514
Devin Moore7b8d5c92020-03-17 14:14:08 -07003515TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003516 AidlError error;
3517 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003518 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003519 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003520 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3521 R"(package p;
3522 interface IFoo {
3523 const long int64_min_oob = -21474836509999999999999999;
3524 }
3525 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003526 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003527 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3528 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003529}
3530
Devin Moore7b8d5c92020-03-17 14:14:08 -07003531TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003532 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003533 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003534 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003535 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3536 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003537 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3538 R"(package p;
3539 @Backing(type="byte")
3540 enum TestEnum {
3541 FOO = 127,
3542 BAR,
3543 }
3544 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003545 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003546 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003547 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003548}
3549
Devin Mooredecaf292020-04-30 09:16:40 -07003550TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3551 AidlError error;
3552 const string expected_stderr =
3553 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003554 "be one of: type\n";
3555 CaptureStderr();
3556 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3557 R"(package p;
3558 @Backing(foo="byte")
3559 enum TestEnum {
3560 FOO = 1,
3561 BAR,
3562 }
3563 )",
3564 typenames_, GetLanguage(), &error));
3565 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3566 EXPECT_EQ(AidlError::BAD_TYPE, error);
3567}
3568
Jooyung Han5721a232020-12-24 04:34:55 +09003569TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3570 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3571 CaptureStderr();
3572 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3573 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3574}
3575
Jooyung Han66813932020-10-23 13:24:44 +09003576TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003577 io_delegate_.SetFileContents("Foo.aidl",
3578 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3579 "Map<String, Baz> d; Bar[] e; }");
3580 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3581 io_delegate_.SetFileContents("Baz.aidl",
3582 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003583 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003584 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003585}
3586
Jooyung Han66813932020-10-23 13:24:44 +09003587TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003588 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003589 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003590 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003591 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3592 "named 'bar'.\n";
3593 CaptureStderr();
3594 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003595 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003596 EXPECT_EQ(expected_error, GetCapturedStderr());
3597}
3598
Jooyung Han09e551c2021-05-11 11:44:48 +09003599TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3600 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3601 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3602 CaptureStderr();
3603 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003604 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003605 EXPECT_EQ("", GetCapturedStderr());
3606}
3607
Jooyung Han59af9cc2020-10-25 21:44:14 +09003608TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3609 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3610 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3611 string expected_error =
3612 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003613 "named 'bar'.\n";
3614 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003615 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003616 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003617 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003618}
3619
Jooyung Han66813932020-10-23 13:24:44 +09003620TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003621 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003622 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3623 string expected_error =
3624 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3625 "only be an in parameter.\n";
3626 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003627 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003628 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003629 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003630}
3631
Jooyung Han66813932020-10-23 13:24:44 +09003632TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003633 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003634 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3635 string expected_error =
3636 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3637 "only be an in parameter.\n";
3638 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003639 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003640 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003641 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003642}
3643
Jooyung Han66813932020-10-23 13:24:44 +09003644TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003645 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003646 Options options = Options::From("aidl --lang=java Foo.aidl");
3647 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003648 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3649 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003650 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003651 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003652 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3653}
Devin Moore53fc99c2020-08-12 08:07:52 -07003654
Jooyung Hanfe086af2021-01-16 03:44:47 +09003655TEST_P(AidlTest, UnionInUnion) {
3656 import_paths_.insert(".");
3657 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3658 CaptureStderr();
3659 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3660 EXPECT_THAT("", GetCapturedStderr());
3661}
3662
Jooyung Hanfe89f122020-10-14 03:49:18 +09003663TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3664 const string method = "package a; union Foo {}";
3665 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3666 CaptureStderr();
3667 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3668 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3669}
3670
3671TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3672 const string method = "package a; union Foo { ParcelableHolder x; }";
3673 const string expected_stderr =
3674 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3675 CaptureStderr();
3676 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3677 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3678}
3679
Jooyung Han53fb4242020-12-17 16:03:49 +09003680TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3681 import_paths_.insert(".");
3682 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3683 const string expected_err = "The union's first member should have a useful default value.";
3684 CaptureStderr();
3685 EXPECT_EQ(nullptr,
3686 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3687 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3688}
3689
Devin Moore53fc99c2020-08-12 08:07:52 -07003690TEST_P(AidlTest, GenericStructuredParcelable) {
3691 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003692 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003693 const string expected_stderr = "";
3694 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003695 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003696 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3697}
3698
Jooyung Han3f347ca2020-12-01 12:41:50 +09003699TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3700 io_delegate_.SetFileContents("Foo.aidl",
3701 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3702 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003703 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003704 const string expected_stderr = "";
3705 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003706 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003707 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3708
3709 string code;
3710 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3711 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3712const ::android::String16& Foo<T,U>::s() {
3713 static const ::android::String16 value(::android::String16(""));
3714 return value;
3715})--"));
3716}
3717
3718TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3719 io_delegate_.SetFileContents("Foo.aidl",
3720 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3721 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003722 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003723 const string expected_stderr = "";
3724 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003725 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003726 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3727
3728 string code;
3729 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3730 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3731const char* Foo<T, U>::s = "";
3732)--"));
3733}
3734
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003735TEST_F(AidlTest, NestedTypeArgs) {
3736 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003737 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3738
3739 io_delegate_.SetFileContents("a/Foo.aidl",
3740 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3741 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003742 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3743 const string expected_stderr = "";
3744 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003745 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003746 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3747
3748 string code;
3749 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003750 EXPECT_THAT(code,
3751 testing::HasSubstr(
3752 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3753}
3754
3755TEST_F(AidlTest, DoubleArrayError) {
3756 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3757
3758 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3759 const string expected_stderr =
3760 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3761 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003762 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003763 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3764}
3765
3766TEST_F(AidlTest, DoubleGenericError) {
3767 io_delegate_.SetFileContents("a/Bar.aidl",
3768 "package a; parcelable Bar { List<String><String> a; }");
3769
3770 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3771 const string expected_stderr =
3772 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3773 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003774 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003775 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3776}
3777
3778TEST_F(AidlTest, ArrayBeforeGenericError) {
3779 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3780
3781 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00003782 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003783 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003784 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
3785}
3786
3787TEST_F(AidlTest, NullableArraysAreNotSupported) {
3788 io_delegate_.SetFileContents("a/Bar.aidl",
3789 "package a; parcelable Bar { String @nullable [] a; }");
3790
3791 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3792 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003793 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003794 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
3795}
3796
3797TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
3798 io_delegate_.SetFileContents("a/Bar.aidl",
3799 "package a; parcelable Bar { List<@nullable String> a; }");
3800
3801 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3802 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003803 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09003804 EXPECT_THAT(GetCapturedStderr(),
3805 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003806}
3807
Jooyung Han14004ed2020-10-16 03:49:57 +09003808struct GenericAidlTest : ::testing::Test {
3809 FakeIoDelegate io_delegate_;
3810 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003811 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003812 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3813 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3814 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3815
3816 Options options = Options::From(cmd);
3817 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003818 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09003819 EXPECT_EQ("", GetCapturedStderr());
3820 }
3821};
3822
3823TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3824 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3825 string code;
3826 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3827 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3828 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3829 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3830}
3831
3832TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3833 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3834 string code;
3835 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3836 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3837 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3838 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3839}
3840
Devin Moore53fc99c2020-08-12 08:07:52 -07003841TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3842 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003843 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003844 const string expected_stderr =
3845 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3846 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003847 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003848 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3849}
3850
3851TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3852 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003853 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003854 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3855 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003856 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003857 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3858}
3859
Jooyung Han7a308842020-10-27 19:06:49 +09003860TEST_P(AidlTest, LongCommentWithinConstExpression) {
3861 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003862 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09003863 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003864 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09003865 EXPECT_EQ("", GetCapturedStderr());
3866}
3867
Jeongik Chaef44e622020-10-23 16:00:52 +09003868TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3869 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3870 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3871 std::string expectedErr =
3872 "ERROR: a/Foo.aidl:1.28-30: "
3873 "Encountered an untyped List or Map. The use of untyped List/Map is "
3874 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3875 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3876 "ERROR: a/Foo.aidl:1.35-37: "
3877 "Encountered an untyped List or Map. The use of untyped List/Map is "
3878 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3879 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3880 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003881 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003882 EXPECT_EQ(expectedErr, GetCapturedStderr());
3883}
3884
3885TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003886 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3887 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003888 std::string expectedErr =
3889 "ERROR: a/Foo.aidl:1.33-35: "
3890 "Encountered an untyped List or Map. The use of untyped List/Map is "
3891 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3892 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3893 "ERROR: a/Foo.aidl:1.40-42: "
3894 "Encountered an untyped List or Map. The use of untyped List/Map is "
3895 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3896 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003897 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003898 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003899 EXPECT_EQ(expectedErr, GetCapturedStderr());
3900}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003901
Jeongik Chaef44e622020-10-23 16:00:52 +09003902TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3903 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3904 io_delegate_.SetFileContents(
3905 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3906 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3907 std::string expectedErr =
3908 "ERROR: a/Foo.aidl:1.52-54: "
3909 "Encountered an untyped List or Map. The use of untyped List/Map is "
3910 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3911 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3912 "ERROR: a/Foo.aidl:1.64-66: "
3913 "Encountered an untyped List or Map. The use of untyped List/Map is "
3914 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3915 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3916 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003917 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09003918 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003919}
3920
Jooyung Han690f5842020-12-04 13:02:04 +09003921TEST_F(AidlTest, EnumWithDefaults_Java) {
3922 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3923 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3924package p;
3925import p.Enum;
3926parcelable Foo {
3927 Enum e = Enum.BAR;
3928})");
3929 CaptureStderr();
3930 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003931 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003932 auto err = GetCapturedStderr();
3933 EXPECT_EQ("", err);
3934
3935 string code;
3936 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09003937 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09003938}
3939
3940TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3941 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3942 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3943package p;
3944import p.Enum;
3945parcelable Foo {
3946 Enum e = Enum.BAR;
3947})");
3948 CaptureStderr();
3949 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003950 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003951 auto err = GetCapturedStderr();
3952 EXPECT_EQ("", err);
3953
3954 string code;
3955 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3956 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
3957}
3958
3959TEST_F(AidlTest, EnumWithDefaults_Ndk) {
3960 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3961 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3962package p;
3963import p.Enum;
3964parcelable Foo {
3965 Enum e = Enum.BAR;
3966})");
3967 CaptureStderr();
3968 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003969 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003970 auto err = GetCapturedStderr();
3971 EXPECT_EQ("", err);
3972
3973 string code;
3974 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
3975 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
3976}
3977
3978TEST_F(AidlTest, EnumWithDefaults_Rust) {
3979 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3980 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3981package p;
3982import p.Enum;
3983parcelable Foo {
3984 int n = 42;
3985 Enum e = Enum.BAR;
3986})");
3987 CaptureStderr();
3988 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003989 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09003990 auto err = GetCapturedStderr();
3991 EXPECT_EQ("", err);
3992
3993 string code;
3994 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
3995 EXPECT_THAT(code, testing::HasSubstr(R"(
3996 fn default() -> Self {
3997 Self {
3998 n: 42,
3999 e: crate::mangled::_1_p_4_Enum::BAR,
4000 }
4001 })"));
4002}
4003
4004TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4005 import_paths_.insert("a");
4006 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4007 CaptureStderr();
4008 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4009package p;
4010import p.Enum;
4011parcelable Foo {
4012 int e = Enum.FOO | Enum.BAR;
4013})",
4014 typenames_, GetLanguage());
4015 auto err = GetCapturedStderr();
4016 EXPECT_EQ("", err);
4017 EXPECT_TRUE(type);
4018 const auto& fields = type->AsStructuredParcelable()->GetFields();
4019 EXPECT_EQ("int e = 3", fields[0]->ToString());
4020}
4021
4022TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4023 CaptureStderr();
4024 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4025@Backing(type="int")
4026enum Foo {
4027 STANDARD_SHIFT = 16,
4028 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4029 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4030}
4031)",
4032 typenames_, GetLanguage());
4033 auto err = GetCapturedStderr();
4034 EXPECT_EQ("", err);
4035 EXPECT_TRUE(type);
4036 const auto& enum_type = type->AsEnumDeclaration();
4037 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004038 auto writer = CodeWriter::ForString(&code);
4039 DumpVisitor visitor(*writer);
4040 visitor.Visit(*enum_type);
4041 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004042 EXPECT_EQ(R"--(@Backing(type="int")
4043enum Foo {
4044 STANDARD_SHIFT = 16,
4045 STANDARD_BT709 = 65536,
4046 STANDARD_BT601_625 = 131072,
4047}
4048)--",
4049 code);
4050}
4051
4052TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4053 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4054 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4055package p;
4056import p.Enum;
4057parcelable Foo {
4058 Enum e = Enum.FOO | Enum.BAR;
4059})");
4060 CaptureStderr();
4061 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004062 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004063 auto err = GetCapturedStderr();
4064 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4065 err);
4066}
4067
Jooyung Han361cd102021-05-24 11:30:10 +09004068TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4069 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4070 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4071package p;
4072import p.Enum;
4073parcelable Foo {
4074 Enum e = 1;
4075})");
4076 CaptureStderr();
4077 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004078 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004079 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4080}
4081
Jooyung Han690f5842020-12-04 13:02:04 +09004082TEST_P(AidlTest, DefaultWithEmptyArray) {
4083 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4084 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4085 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004086 auto options =
4087 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004088 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004089 auto err = GetCapturedStderr();
4090 EXPECT_EQ("", err);
4091}
4092
4093TEST_P(AidlTest, RejectRefsInAnnotation) {
4094 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4095 "package p; interface IFoo {\n"
4096 " const String ANNOTATION = \"@Annotation\";\n"
4097 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4098 "}");
4099 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004100 auto options =
4101 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004102 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004103 auto err = GetCapturedStderr();
4104 EXPECT_EQ(
4105 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4106 "ANNOTATION.\n",
4107 err);
4108}
4109
4110TEST_F(AidlTest, DefaultWithEnumValues) {
4111 io_delegate_.SetFileContents(
4112 "a/p/Foo.aidl",
4113 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4114 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4115 CaptureStderr();
4116 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004117 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004118 auto err = GetCapturedStderr();
4119 EXPECT_EQ("", err);
4120 string code;
4121 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4122 EXPECT_THAT(
4123 code, testing::HasSubstr(
4124 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4125}
4126
Jooyung Han14259392020-12-07 10:00:08 +09004127TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4128 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4129 CaptureStderr();
4130 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004131 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004132 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004133 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004134}
4135
4136TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4137 io_delegate_.SetFileContents("a/p/Foo.aidl",
4138 "package p; parcelable Foo { const int A = A + 1; }");
4139 CaptureStderr();
4140 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004141 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004142 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004143 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4144}
4145
4146TEST_F(AidlTest, RecursiveReferences) {
4147 io_delegate_.SetFileContents("a/p/Foo.aidl",
4148 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4149 io_delegate_.SetFileContents("a/p/Bar.aidl",
4150 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4151 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4152 CaptureStderr();
4153 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004154 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004155 EXPECT_EQ("", GetCapturedStderr());
4156}
4157
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004158TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4159 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4160 auto options =
4161 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4162 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4163 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004164 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004165 EXPECT_EQ(err, GetCapturedStderr());
4166}
4167
4168TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4169 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4170 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4171 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4172 auto options =
4173 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4174 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004175 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004176 EXPECT_EQ("", GetCapturedStderr());
4177}
4178
Jooyung Hane9f5b272021-01-07 00:18:11 +09004179TEST_P(AidlTest, UnknownConstReference) {
4180 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4181 auto options =
4182 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4183 const string err =
4184 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4185 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4186 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4187 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004188 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004189 EXPECT_EQ(err, GetCapturedStderr());
4190}
4191
Jooyung Han29813842020-12-08 01:28:03 +09004192TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4193 string contents = R"(
4194import android.os.IBinder;
4195import android.os.IInterface;
4196interface IFoo {}
4197 )";
4198 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004199}
4200
Jooyung Han888c5bc2020-12-22 17:28:47 +09004201TEST_P(AidlTest, WarningInterfaceName) {
4202 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004203 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004204 " -Weverything -o out -h out p/Foo.aidl");
4205 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004206 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004207 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004208 GetCapturedStderr());
4209}
4210
4211TEST_P(AidlTest, ErrorInterfaceName) {
4212 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004213 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004214 " -Weverything -Werror -o out -h out p/Foo.aidl");
4215 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004216 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004217 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004218 GetCapturedStderr());
4219}
4220
Jiyong Park9f4c3822021-04-07 20:36:45 +09004221TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4222 const std::string input_file = "base/p/q/IFoo.aidl";
4223 const std::string header_dir = "out/";
4224 const std::string output_file = "out/base/p/q/IFoo.cpp";
4225 const std::string package = "p.q"; // not base.p.q
4226 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4227
4228 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4229 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004230 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004231 EXPECT_THAT(
4232 GetCapturedStderr(),
4233 testing::StartsWith(
4234 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4235 "but is out/base/p/q/IFoo.cpp."));
4236}
4237
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004238TEST_F(AidlTest, FormatCommentsForJava) {
4239 using android::aidl::FormatCommentsForJava;
4240
4241 struct TestCase {
4242 vector<Comment> comments;
4243 string formatted;
4244 };
4245 vector<TestCase> testcases = {
4246 {{}, ""},
4247 {{{"// line comments\n"}}, "// line comments\n"},
4248 {{{"// @hide \n"}}, "// @hide \n"},
4249 // Transform the last block comment as Javadoc.
4250 {{{"/*\n"
4251 " * Hello, world!\n"
4252 " */"}},
4253 "/**\n"
4254 " * Hello, world!\n"
4255 " */"},
4256 {{{"/* @hide */"}}, "/** @hide */"},
4257 {{{"/**\n"
4258 " @param foo ...\n"
4259 "*/"}},
4260 "/**\n"
4261 " @param foo ...\n"
4262 "*/"},
4263 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4264 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4265 "/* @deprecated first *//** @deprecated second */"},
4266 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4267 // Line comments are printed as they are
4268 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4269 };
4270 for (const auto& [input, formatted] : testcases) {
4271 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4272 }
4273}
4274
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004275TEST_F(AidlTest, HideIsNotForArgs) {
4276 io_delegate_.SetFileContents("IFoo.aidl",
4277 "interface IFoo {\n"
4278 " void foo(in @Hide int x);\n"
4279 "}");
4280 auto options = Options::From("aidl --lang=java IFoo.aidl");
4281 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004282 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004283 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4284}
4285
4286TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4287 io_delegate_.SetFileContents(
4288 "IFoo.aidl",
4289 "interface IFoo {\n"
4290 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4291 "}");
4292 auto options = Options::From("aidl --lang=java IFoo.aidl");
4293 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004294 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004295 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4296}
4297
Jooyung Hanfa181932021-06-12 07:56:53 +09004298TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4299 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4300 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4301 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004302 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004303 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4304}
4305
Jooyung Hanfd3be322020-12-13 09:11:06 +09004306struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004307 string kind;
4308 string literal;
4309};
4310
Jooyung Hanfd3be322020-12-13 09:11:06 +09004311const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004312 {"primitive", "int"}, {"primitiveArray", "int[]"},
4313 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004314 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4315 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4316 {"union", "a.Union"}, {"interface", "a.IBar"},
4317};
4318
4319const std::map<std::string, std::string> kListSupportExpectations = {
4320 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4321 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4322 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4323 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004324 {"cpp_primitiveArray", "List of arrays is not supported."},
4325 {"java_primitiveArray", "List of arrays is not supported."},
4326 {"ndk_primitiveArray", "List of arrays is not supported."},
4327 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004328 {"cpp_String", ""},
4329 {"java_String", ""},
4330 {"ndk_String", ""},
4331 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004332 {"cpp_StringArray", "List of arrays is not supported."},
4333 {"java_StringArray", "List of arrays is not supported."},
4334 {"ndk_StringArray", "List of arrays is not supported."},
4335 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004336 {"cpp_IBinder", ""},
4337 {"java_IBinder", ""},
4338 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4339 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004340 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004341 {"java_ParcelFileDescriptor", ""},
4342 {"ndk_ParcelFileDescriptor", ""},
4343 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004344 {"cpp_interface", "List<a.IBar> is not supported."},
4345 {"java_interface", "List<a.IBar> is not supported."},
4346 {"ndk_interface", "List<a.IBar> is not supported."},
4347 {"rust_interface", "List<a.IBar> is not supported."},
4348 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004349 {"java_parcelable", ""},
4350 {"ndk_parcelable", ""},
4351 {"rust_parcelable", ""},
4352 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4353 {"java_enum", "A generic type cannot have any primitive type parameters."},
4354 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4355 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004356 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004357 {"java_union", ""},
4358 {"ndk_union", ""},
4359 {"rust_union", ""},
4360};
4361
Jooyung Hand236e552020-12-13 09:21:27 +09004362const std::map<std::string, std::string> kArraySupportExpectations = {
4363 {"cpp_primitive", ""},
4364 {"java_primitive", ""},
4365 {"ndk_primitive", ""},
4366 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004367 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4368 {"java_primitiveArray", "Can only have one dimensional arrays."},
4369 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4370 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004371 {"cpp_String", ""},
4372 {"java_String", ""},
4373 {"ndk_String", ""},
4374 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004375 {"cpp_StringArray", "Can only have one dimensional arrays."},
4376 {"java_StringArray", "Can only have one dimensional arrays."},
4377 {"ndk_StringArray", "Can only have one dimensional arrays."},
4378 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004379 {"cpp_IBinder", ""},
4380 {"java_IBinder", ""},
4381 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4382 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4383 {"cpp_ParcelFileDescriptor", ""},
4384 {"java_ParcelFileDescriptor", ""},
4385 {"ndk_ParcelFileDescriptor", ""},
4386 {"rust_ParcelFileDescriptor", ""},
4387 {"cpp_interface", "Binder type cannot be an array"},
4388 {"java_interface", "Binder type cannot be an array"},
4389 {"ndk_interface", "Binder type cannot be an array"},
4390 {"rust_interface", "Binder type cannot be an array"},
4391 {"cpp_parcelable", ""},
4392 {"java_parcelable", ""},
4393 {"ndk_parcelable", ""},
4394 {"rust_parcelable", ""},
4395 {"cpp_enum", ""},
4396 {"java_enum", ""},
4397 {"ndk_enum", ""},
4398 {"rust_enum", ""},
4399 {"cpp_union", ""},
4400 {"java_union", ""},
4401 {"ndk_union", ""},
4402 {"rust_union", ""},
4403};
4404
Jooyung Hanfd3be322020-12-13 09:11:06 +09004405class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004406 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004407 void Run(const std::string& generic_type_decl,
4408 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004409 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004410 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004411 const auto& kind = std::get<1>(param).kind;
4412
4413 FakeIoDelegate io;
4414 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4415 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4416 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004417 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4418 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004419
4420 const auto options =
4421 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4422 CaptureStderr();
4423 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004424 auto it = expectations.find(lang + "_" + kind);
4425 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004426 const string err = GetCapturedStderr();
4427 if (it->second.empty()) {
4428 EXPECT_EQ("", err);
4429 } else {
4430 EXPECT_THAT(err, testing::HasSubstr(it->second));
4431 }
4432 }
4433};
4434
4435INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004436 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004437 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4438 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004439 testing::ValuesIn(kTypeParams)),
4440 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004441 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004442 });
4443
Jooyung Hanfd3be322020-12-13 09:11:06 +09004444TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4445 Run("List<{}>", kListSupportExpectations);
4446}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004447
Jooyung Hand236e552020-12-13 09:21:27 +09004448TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4449 Run("{}[]", kArraySupportExpectations);
4450}
4451
Christopher Wiley90be4e32015-10-20 14:55:25 -07004452} // namespace aidl
4453} // namespace android