blob: b650e97277cb0342994a9066e79abc5932c08d17 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
1477TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1478 io_delegate_.SetFileContents("p/IOuter.aidl",
1479 "package p;\n"
1480 "interface IOuter {\n"
1481 " parcelable Inner {}\n"
1482 "}");
1483 import_paths_.emplace("");
1484 const string input_path = "p/IFoo.aidl";
1485 const string input =
1486 "package p;\n"
1487 "interface IFoo {\n"
1488 " p.IOuter.Inner get();\n"
1489 "}";
1490 CaptureStderr();
1491 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1492 EXPECT_EQ(GetCapturedStderr(), "");
1493
1494 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1495}
1496
1497TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1498 io_delegate_.SetFileContents("p/IOuter.aidl",
1499 "package p;\n"
1500 "interface IOuter {\n"
1501 " parcelable Inner {}\n"
1502 "}");
1503 import_paths_.emplace("");
1504 const string input_path = "p/IFoo.aidl";
1505 const string input =
1506 "package p;\n"
1507 "import p.IOuter.Inner;"
1508 "interface IFoo {\n"
1509 " Inner get();\n"
1510 "}";
1511 CaptureStderr();
1512 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1513 EXPECT_EQ(GetCapturedStderr(), "");
1514
1515 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1516}
1517
1518TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1519 const string input_path = "p/IFoo.aidl";
1520 const string input =
1521 "package p;\n"
1522 "interface IFoo {\n"
1523 " parcelable Result {}\n"
1524 " Result get();\n"
1525 "}";
1526 CaptureStderr();
1527 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1528 EXPECT_EQ(GetCapturedStderr(), "");
1529
1530 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1531}
1532
1533// Finding the type of nested named member.
1534struct TypeFinder : AidlVisitor {
1535 string name;
1536 const AidlTypeSpecifier* type = nullptr;
1537 TypeFinder(std::string name) : name(name) {}
1538 void Visit(const AidlVariableDeclaration& v) override {
1539 if (v.GetName() == name) {
1540 type = &v.GetType();
1541 }
1542 }
1543 void Visit(const AidlMethod& m) override {
1544 if (m.GetName() == name) {
1545 type = &m.GetType();
1546 }
1547 }
1548 static string Get(const AidlDefinedType& type, const string& name) {
1549 TypeFinder v(name);
1550 VisitTopDown(v, type);
1551 return v.type ? v.type->Signature() : "(null)";
1552 };
1553};
1554
1555TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1556 io_delegate_.SetFileContents("q/IBar.aidl",
1557 "package q;\n"
1558 "interface IBar {\n"
1559 " parcelable Baz {}\n"
1560 "}");
1561 import_paths_.emplace("");
1562 const string input_path = "p/IFoo.aidl";
1563 const string input =
1564 "package p;\n"
1565 "import q.IBar;\n"
1566 "interface IFoo {\n"
1567 " parcelable Nested {\n"
1568 " Baz t1;\n"
1569 " }\n"
1570 " parcelable Baz { }\n"
1571 " IBar.Baz t2();\n"
1572 " Baz t3();\n"
1573 "}";
1574 CaptureStderr();
1575 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1576 EXPECT_EQ(GetCapturedStderr(), "");
1577 ASSERT_NE(nullptr, foo);
1578
1579 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1580 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1581 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1582}
1583
1584TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1585 const string input_path = "p/Foo.aidl";
1586 const string input =
1587 "package p;\n"
1588 "parcelable Foo {\n"
1589 " parcelable Foo {}\n"
1590 "}";
1591 CaptureStderr();
1592 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1593 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1594}
1595
1596TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1597 const string input_path = "p/IFoo.aidl";
1598 const string input =
1599 "package p;\n"
1600 "interface IFoo {\n"
1601 " interface ICallback { void done(); }\n"
1602 " void doTask(ICallback cb);\n"
1603 "}";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1606 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1607}
1608
1609TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1610 const string input_path = "p/Foo.aidl";
1611 const string input =
1612 "package p;\n"
1613 "interface Foo {\n"
1614 " parcelable Bar {}\n"
1615 " parcelable Bar {}\n"
1616 "}";
1617 CaptureStderr();
1618 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1619 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1620}
1621
1622TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1623 struct Failure {
1624 string err;
1625 };
1626 struct TestCase {
1627 string type;
1628 variant<string, Failure> expected; // success<0> or failure<1>
1629 };
1630 vector<TestCase> cases = {
1631 {"foo.A", "foo.A"},
1632 {"foo.A.B", "foo.A.B"},
1633 {"@nullable(heap=true) A", "foo.A.B.A"},
1634 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1635 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1636 {"B", "foo.A.B.A.B"},
1637 {"A.B", "foo.A.B.A.B"},
1638 };
1639 const string input_path = "foo/A.aidl";
1640 for (auto& [type, expected] : cases) {
1641 AidlTypenames typenames;
1642 // clang-format off
1643 const string input =
1644 "package foo;\n"
1645 "parcelable A {\n"
1646 " parcelable B {\n"
1647 " parcelable A {\n"
1648 " parcelable B {\n"
1649 " }\n"
1650 " " + type + " m;\n"
1651 " }\n"
1652 " }\n"
1653 "}";
1654 // clang-format on
1655 CaptureStderr();
1656 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1657 if (auto failure = std::get_if<Failure>(&expected); failure) {
1658 ASSERT_EQ(nullptr, foo);
1659 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1660 } else {
1661 EXPECT_EQ(GetCapturedStderr(), "");
1662 ASSERT_NE(nullptr, foo);
1663 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1664 }
1665 }
1666}
1667
Jooyung Han0a950bd2021-05-15 12:50:36 +09001668TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001669 const string input_path = "p/Wrapper.aidl";
1670 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001671
1672 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1673 EXPECT_NE(nullptr, parse_result);
1674
1675 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1676 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1677 (..., params->emplace_back(std::move(type_params)));
1678 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1679 };
1680
1681 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1682 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001683 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001684 type->Annotate(std::move(annotations));
1685 return std::move(type);
1686 };
1687
1688 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1689 (void)type->SetArray();
1690 return std::move(type);
1691 };
1692
1693 auto w = type("p.Wrapper", type("String"));
1694 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1695
1696 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1697 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1698 cpp::CppNameOf(*nullable_w, typenames_));
1699
1700 auto array_w = set_array(type("p.Wrapper", type("String")));
1701 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1702 cpp::CppNameOf(*array_w, typenames_));
1703
1704 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1705 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1706 cpp::CppNameOf(*nullable_array_w, typenames_));
1707
1708 auto list_w = type("List", type("p.Wrapper", type("String")));
1709 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1710 cpp::CppNameOf(*list_w, typenames_));
1711
1712 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1713 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1714 cpp::CppNameOf(*nullable_list_w, typenames_));
1715}
1716
Devin Moore7b8d5c92020-03-17 14:14:08 -07001717TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001718 io_delegate_.SetFileContents(
1719 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001720 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001721 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001722 const string input_path = "p/IFoo.aidl";
1723 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001724 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1725 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001726 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001727 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001728 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001729
1730 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1731 // C++ understands C++ specific stuff
1732 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1733 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001734 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001735 EXPECT_EQ(1u, headers.size());
1736 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001737}
1738
Christopher Wileyf8136192016-04-12 14:19:35 -07001739TEST_F(AidlTest, WritesCorrectDependencyFile) {
1740 // While the in tree build system always gives us an output file name,
1741 // other android tools take advantage of our ability to infer the intended
1742 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001743 vector<string> args = {
1744 "aidl",
1745 "-d dep/file/path",
1746 "-o place/for/output",
1747 "p/IFoo.aidl"};
1748 Options options = Options::From(args);
1749 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001750 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001751 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001752 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001753 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1754}
1755
Dan Willemsen93298ee2016-11-10 23:55:55 -08001756TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1757 // While the in tree build system always gives us an output file name,
1758 // other android tools take advantage of our ability to infer the intended
1759 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001760 vector<string> args = {
1761 "aidl",
1762 "-d dep/file/path",
1763 "--ninja",
1764 "-o place/for/output",
1765 "p/IFoo.aidl"};
1766 Options options = Options::From(args);
1767 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001768 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001769 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001770 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001771 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1772}
1773
Jiyong Parkdf202122019-09-30 20:48:35 +09001774TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001775 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1776 // this by calling aidl with every .aidl file it finds, then parsing the
1777 // generated dependency files. Those that reference .java output files are
1778 // for interfaces and those that do not are parcelables. However, for both
1779 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001780 vector<string> args = {
1781 "aidl",
1782 "-o place/for/output",
1783 "-d dep/file/path",
1784 "p/Foo.aidl"};
1785 Options options = Options::From(args);
1786 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001787 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001788 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001789 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001790 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1791}
1792
1793TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1794 vector<string> args = {
1795 "aidl",
1796 "--structured",
1797 "-o place/for/output",
1798 "-d dep/file/path",
1799 "p/Foo.aidl"};
1800 Options options = Options::From(args);
1801 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001802 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001803 string actual_dep_file_contents;
1804 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1805 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001806}
1807
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001808TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1809 vector<string> args = {
1810 "aidl",
1811 "--lang=java",
1812 "-o place/for/output",
1813 "p/Foo.aidl"};
1814 Options options = Options::From(args);
1815 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001816 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001817 string output_file_contents;
1818 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1819}
1820
Devin Moore21b26772020-08-26 16:37:56 -07001821TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001822 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001823 const string list_array_parcelable =
1824 "package a; parcelable Foo {\n"
1825 " List[] lists; }";
1826 CaptureStderr();
1827 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1828 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1829}
1830
Jiyong Parkf8d53612020-05-04 14:06:13 +09001831TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1832 AidlError error;
1833 string expected_stderr =
1834 "ERROR: a/IFoo.aidl:2.7-11: "
1835 "Encountered an untyped List or Map. The use of untyped List/Map is "
1836 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1837 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1838 if (GetLanguage() != Options::Language::JAVA) {
1839 expected_stderr =
1840 "ERROR: a/IFoo.aidl:2.1-7: "
1841 "Currently, only the Java backend supports non-generic List.\n";
1842 }
1843
1844 const string primitive_interface =
1845 "package a; interface IFoo {\n"
1846 " List foo(); }";
1847 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001848 AidlTypenames tn1;
1849 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001850 {"--structured"}));
1851 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001852
1853 string primitive_parcelable =
1854 "package a; parcelable IFoo {\n"
1855 " List foo;}";
1856 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001857 AidlTypenames tn2;
1858 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001859 {"--structured"}));
1860 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1861}
1862
Jeongik Cha225519b2020-08-29 01:55:32 +09001863TEST_P(AidlTest, ExtensionTest) {
1864 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001865 string extendable_parcelable =
1866 "package a; parcelable Data {\n"
1867 " ParcelableHolder extension;\n"
1868 " ParcelableHolder extension2;\n"
1869 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001870 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001871 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1872 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001873 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001874 "yet.\n",
1875 GetCapturedStderr());
1876 } else {
1877 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1878 EXPECT_EQ("", GetCapturedStderr());
1879 }
1880}
1881TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1882 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001883 string parcelableholder_return_interface =
1884 "package a; interface IFoo {\n"
1885 " ParcelableHolder foo();\n"
1886 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001887 EXPECT_EQ(nullptr,
1888 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001889
Jeongik Cha8f02a532020-10-14 00:16:28 +09001890 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001891 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001892 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001893 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001894 "yet.\n",
1895 GetCapturedStderr());
1896 return;
1897 }
1898 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1899 GetCapturedStderr());
1900}
1901
1902TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1903 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001904 string extendable_parcelable_arg_interface =
1905 "package a; interface IFoo {\n"
1906 " void foo(in ParcelableHolder ph);\n"
1907 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001908 EXPECT_EQ(nullptr,
1909 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1910
Jeongik Cha8f02a532020-10-14 00:16:28 +09001911 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001912 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001913 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001914 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001915 "yet.\n",
1916 GetCapturedStderr());
1917 return;
1918 }
1919 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1920 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001921}
1922
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001923TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1924 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001925 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001926 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1927 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001928 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001929 if (GetLanguage() == Options::Language::RUST) {
1930 EXPECT_EQ(
1931 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1932 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1933 "yet.\n",
1934 GetCapturedStderr());
1935 return;
1936 }
1937 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1938}
1939
Jooyung Han3f347ca2020-12-01 12:41:50 +09001940TEST_P(AidlTest, ParcelablesWithConstants) {
1941 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001942 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001943 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001944 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001945 EXPECT_EQ("", GetCapturedStderr());
1946}
1947
1948TEST_P(AidlTest, UnionWithConstants) {
1949 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001950 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001951 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001952 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001953 EXPECT_EQ("", GetCapturedStderr());
1954}
1955
Jooyung Han633eab62021-01-07 14:12:40 +09001956TEST_F(AidlTest, ConstantsWithAnnotations) {
1957 io_delegate_.SetFileContents("IFoo.aidl",
1958 "interface IFoo {\n"
1959 " @JavaPassthrough(annotation=\"@Foo\")\n"
1960 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1961 "}");
1962 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1963 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001964 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09001965 EXPECT_EQ("", GetCapturedStderr());
1966 string code;
1967 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1968 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1969 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1970}
1971
Jiyong Park02da7422018-07-16 16:00:26 +09001972TEST_F(AidlTest, ApiDump) {
1973 io_delegate_.SetFileContents(
1974 "foo/bar/IFoo.aidl",
1975 "package foo.bar;\n"
1976 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001977 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001978 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001979 " /* @hide applied \n"
1980 " @deprecated use foo2 */\n"
1981 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1982 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001983 " IFoo foo3(IFoo foo);\n"
1984 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09001985 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09001986 " /** blahblah\n"
1987 " @deprecated\n"
1988 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001989 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001990 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001991 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001992 "}\n");
1993 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1994 "package foo.bar;\n"
1995 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001996 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001997 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001998 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001999 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002000 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002001 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002002 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002003 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002004 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002005 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002006 "}\n");
2007 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002008 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2009 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002010 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002011 bool result = dump_api(options, io_delegate_);
2012 ASSERT_TRUE(result);
2013 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002014 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002015 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002016interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002017 /**
2018 * @hide
2019 * @deprecated use foo2
2020 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002021 int foo(out int[] a, String b, boolean c, inout List<String> d);
2022 int foo2(@utf8InCpp String x, inout List<String> y);
2023 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2024 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002025 /**
2026 * @deprecated reason why...
2027 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002028 const int A = 1;
2029 const String STR = "Hello";
2030}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002031)"),
2032 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002033
Jiyong Parke59c3682018-09-11 23:10:25 +09002034 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002035 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002036/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002037parcelable Data {
2038 int x = 10;
2039 int y;
2040 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002041 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002042}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002043)"),
2044 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002045}
2046
Jiyong Parked65bf42018-08-28 15:43:27 +09002047TEST_F(AidlTest, ApiDumpWithManualIds) {
2048 io_delegate_.SetFileContents(
2049 "foo/bar/IFoo.aidl",
2050 "package foo.bar;\n"
2051 "interface IFoo {\n"
2052 " int foo() = 1;\n"
2053 " int bar() = 2;\n"
2054 " int baz() = 10;\n"
2055 "}\n");
2056
Jiyong Parke59c3682018-09-11 23:10:25 +09002057 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002058 Options options = Options::From(args);
2059 bool result = dump_api(options, io_delegate_);
2060 ASSERT_TRUE(result);
2061 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002062 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002063 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002064interface IFoo {
2065 int foo() = 1;
2066 int bar() = 2;
2067 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002068}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002069)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002070}
2071
2072TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002073 const string expected_stderr =
2074 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2075 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002076 io_delegate_.SetFileContents(
2077 "foo/bar/IFoo.aidl",
2078 "package foo.bar;\n"
2079 "interface IFoo {\n"
2080 " int foo() = 1;\n"
2081 " int bar();\n"
2082 " int baz() = 10;\n"
2083 "}\n");
2084
Jiyong Parke59c3682018-09-11 23:10:25 +09002085 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002086 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002087 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002088 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002090}
2091
Jooyung Han965e31d2020-11-27 12:30:16 +09002092TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2093 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2094 "package foo.bar;\n"
2095 "interface IFoo {\n"
2096 " @utf8InCpp String foo();\n"
2097 " const @utf8InCpp String bar = \"bar\";\n"
2098 "}\n");
2099
2100 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2101 Options options = Options::From(args);
2102 CaptureStderr();
2103 EXPECT_TRUE(dump_api(options, io_delegate_));
2104 EXPECT_EQ("", GetCapturedStderr());
2105 string actual;
2106 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002107 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2108interface IFoo {
2109 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002110 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002111}
2112)"),
2113 actual);
2114}
2115
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002116TEST_F(AidlTest, ApiDumpWithEnums) {
2117 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2118 "package foo.bar;\n"
2119 "enum Enum {\n"
2120 " FOO,\n"
2121 " BAR = FOO + 1,\n"
2122 "}\n");
2123
2124 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2125 Options options = Options::From(args);
2126 CaptureStderr();
2127 EXPECT_TRUE(dump_api(options, io_delegate_));
2128 EXPECT_EQ("", GetCapturedStderr());
2129 string actual;
2130 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2131 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2132 "enum Enum {\n"
2133 " FOO = 0,\n"
2134 " BAR = 1,\n"
2135 "}\n"),
2136 actual);
2137}
2138
2139TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2140 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2141 "package foo.bar;\n"
2142 "enum Enum {\n"
2143 " FOO,\n"
2144 "}\n");
2145 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2146 "package foo.bar;\n"
2147 "import foo.bar.Enum;\n"
2148 "parcelable Foo {\n"
2149 " Enum e = Enum.FOO;\n"
2150 "}\n");
2151
2152 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2153 Options options = Options::From(args);
2154 CaptureStderr();
2155 EXPECT_TRUE(dump_api(options, io_delegate_));
2156 EXPECT_EQ("", GetCapturedStderr());
2157 string actual;
2158 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2159 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2160 "parcelable Foo {\n"
2161 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2162 "}\n"),
2163 actual);
2164}
2165
Jooyung Han71dfec32021-05-23 07:18:58 +09002166TEST_F(AidlTest, ApiDumpWithGenerics) {
2167 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2168 "package foo.bar;\n"
2169 "parcelable Foo<T, U> {\n"
2170 "}\n");
2171
2172 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2173 Options options = Options::From(args);
2174 CaptureStderr();
2175 EXPECT_TRUE(dump_api(options, io_delegate_));
2176 EXPECT_EQ("", GetCapturedStderr());
2177 string actual;
2178 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2179 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2180 "parcelable Foo<T, U> {\n"
2181 "}\n"),
2182 actual);
2183}
2184
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002185TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2186 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2187 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2188
2189 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2190 Options options = Options::From(args);
2191 CaptureStderr();
2192 EXPECT_FALSE(dump_api(options, io_delegate_));
2193 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2194}
2195
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002196TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002197 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002198 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2199 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002200 const string expected_map_stderr =
2201 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002202 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2203 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002204 "package p; interface IFoo {"
2205 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002206 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002207 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002208 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002209
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002210 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002211 "package p; interface IFoo {"
2212 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002213 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002214 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002215 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002216}
2217
Jeongik Chae48d9942020-01-02 17:39:00 +09002218TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002219 const string expected_stderr =
2220 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002221 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002222 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2223
2224 io_delegate_.SetFileContents("p/IFoo.aidl",
2225 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002226 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002227 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002228
2229 io_delegate_.SetFileContents("p/IFoo.aidl",
2230 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002231 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002233 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002235
2236 io_delegate_.SetFileContents("p/IFoo.aidl",
2237 "package p; interface IFoo {"
2238 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002239 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002240
2241 io_delegate_.SetFileContents("p/IFoo.aidl",
2242 "package p; interface IFoo {"
2243 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002244 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002245}
2246
Jeongik Chadf76dc72019-11-28 00:08:47 +09002247TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002248 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002249 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2250 io_delegate_.SetFileContents(options.InputFiles().front(),
2251 "package p; interface IFoo {"
2252 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002253 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002254 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002255 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002256}
2257
2258TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002259 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002260 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002261 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002262 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002263 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2264 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002265
Jooyung Han13f1fa52021-06-11 18:06:12 +09002266 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002267 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2268 io_delegate_.SetFileContents("p/IFoo.aidl",
2269 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002270 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002271 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002272 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002274 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002275 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002276 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002277 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002278 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002279 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002280 io_delegate_.SetFileContents("p/IFoo.aidl",
2281 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002282 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002283 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002284
2285 io_delegate_.SetFileContents("p/IFoo.aidl",
2286 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002287 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002288
2289 io_delegate_.SetFileContents("p/IFoo.aidl",
2290 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002291 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002292
Steven Moreland4e059132021-08-11 13:36:30 -07002293 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002294}
2295
Jeongik Cha0e426012019-07-29 15:57:02 +09002296TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2297 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002298 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2299 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002300 for (const auto& rawOption : rawOptions) {
2301 string expected_stderr =
2302 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002303 Options options = Options::From(rawOption);
2304 io_delegate_.SetFileContents(options.InputFiles().front(),
2305 "package foo.bar;\n"
2306 "interface IFoo1 { int foo(); }\n"
2307 "interface IFoo2 { int foo(); }\n"
2308 "parcelable Data1 { int a; int b;}\n"
2309 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002311 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002313
Jeongik Cha0e426012019-07-29 15:57:02 +09002314 io_delegate_.SetFileContents(options.InputFiles().front(),
2315 "package foo.bar;\n"
2316 "interface IFoo1 { int foo(); }\n"
2317 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002318 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002319 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002321
Devin Moore5de18ed2020-04-02 13:52:29 -07002322 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002323 io_delegate_.SetFileContents(options.InputFiles().front(),
2324 "package foo.bar;\n"
2325 "parcelable Data1 { int a; int b;}\n"
2326 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002327 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002328 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002330 }
2331}
2332
Devin Moorebdba2a82020-03-31 15:19:02 -07002333TEST_P(AidlTest, FailParseOnEmptyFile) {
2334 const string contents = "";
2335 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2336 CaptureStderr();
2337 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2338 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2339}
2340
Jiyong Parkb034bf02018-07-30 17:44:33 +09002341TEST_F(AidlTest, MultipleInputFiles) {
2342 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002343 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002344
2345 io_delegate_.SetFileContents(options.InputFiles().at(0),
2346 "package foo.bar;\n"
2347 "import foo.bar.Data;\n"
2348 "interface IFoo { Data getData(); }\n");
2349
2350 io_delegate_.SetFileContents(options.InputFiles().at(1),
2351 "package foo.bar;\n"
2352 "import foo.bar.IFoo;\n"
2353 "parcelable Data { IFoo foo; }\n");
2354
Steven Moreland4e059132021-08-11 13:36:30 -07002355 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002356
2357 string content;
2358 for (const auto file : {
2359 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2360 content.clear();
2361 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2362 EXPECT_FALSE(content.empty());
2363 }
2364}
2365
2366TEST_F(AidlTest, MultipleInputFilesCpp) {
2367 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002368 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002369
2370 io_delegate_.SetFileContents(options.InputFiles().at(0),
2371 "package foo.bar;\n"
2372 "import foo.bar.Data;\n"
2373 "interface IFoo { Data getData(); }\n");
2374
2375 io_delegate_.SetFileContents(options.InputFiles().at(1),
2376 "package foo.bar;\n"
2377 "import foo.bar.IFoo;\n"
2378 "parcelable Data { IFoo foo; }\n");
2379
Steven Moreland4e059132021-08-11 13:36:30 -07002380 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002381
2382 string content;
2383 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002384 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002385 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2386 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2387 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2388 content.clear();
2389 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2390 EXPECT_FALSE(content.empty());
2391 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002392}
2393
Andrei Homescub62afd92020-05-11 19:24:59 -07002394TEST_F(AidlTest, MultipleInputFilesRust) {
2395 Options options =
2396 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2397
2398 io_delegate_.SetFileContents(options.InputFiles().at(0),
2399 "package foo.bar;\n"
2400 "import foo.bar.Data;\n"
2401 "interface IFoo { Data getData(); }\n");
2402
2403 io_delegate_.SetFileContents(options.InputFiles().at(1),
2404 "package foo.bar;\n"
2405 "import foo.bar.IFoo;\n"
2406 "parcelable Data { IFoo foo; }\n");
2407
Steven Moreland4e059132021-08-11 13:36:30 -07002408 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002409
2410 string content;
2411 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2412 content.clear();
2413 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2414 EXPECT_FALSE(content.empty());
2415 }
2416}
2417
Devin Moore097a3ab2020-03-11 16:08:44 -07002418TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2419 const string expected_stderr =
2420 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002421 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2422 // int getInterfaceVersion() is one of the meta transactions
2423 io_delegate_.SetFileContents(options.InputFiles().front(),
2424 "package p; interface IFoo {"
2425 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002426 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002427 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2429}
Jiyong Park309668e2018-07-28 16:55:44 +09002430
Devin Moore097a3ab2020-03-11 16:08:44 -07002431TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2432 // boolean getInterfaceVersion() is not a meta transaction, but should be
2433 // prevented because return type is not part of a method signature
2434 const string expected_stderr =
2435 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2436 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002437 io_delegate_.SetFileContents(options.InputFiles().front(),
2438 "package p; interface IFoo {"
2439 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002440 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002441 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2443}
Jiyong Park309668e2018-07-28 16:55:44 +09002444
Devin Moore097a3ab2020-03-11 16:08:44 -07002445TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002446 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002447 const string expected_stderr =
2448 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2449 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002450 io_delegate_.SetFileContents(options.InputFiles().front(),
2451 "package p; interface IFoo {"
2452 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002454 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002456
2457 // this is not a meta interface method as it differs type arguments
2458 io_delegate_.SetFileContents(options.InputFiles().front(),
2459 "package p; interface IFoo {"
2460 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002461 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002462}
2463
Jooyung Hanb8a97772021-01-19 01:27:38 +09002464TEST_F(AidlTest, CheckApiForEquality) {
2465 CaptureStderr();
2466 Options options = Options::From("aidl --checkapi=equal old new");
2467
2468 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2469 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2470 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2471 "package p; interface IFoo{ @utf8InCpp String foo();}");
2472
2473 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2474 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2475}
2476
Daniel Norman85aed542019-08-21 12:01:14 -07002477TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002478 Options options = Options::From("aidl --checkapi old new");
2479 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2480 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2481 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2482 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2483
2484 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2485}
2486
Jiyong Park3656c3c2018-08-01 20:02:01 +09002487TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002488 Options options = Options::From("aidl --checkapi old new");
2489 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2490 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002491
2492 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2493}
2494
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002495TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2496 Options options = Options::From("aidl --checkapi old new");
2497 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2498 const string enum_definition = "package p; enum Enum { FOO }";
2499 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2500 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2501 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2502 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2503
2504 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2505}
2506
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002507TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2508 Options options = Options::From("aidl --checkapi old new -I import");
2509
2510 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2511 io_delegate_.SetFileContents("new/p/Foo.aidl",
2512 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2513 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2514
2515 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2516}
2517
Jooyung Han02a11be2021-02-11 13:18:06 +09002518TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2519 Options options = Options::From("aidl --checkapi=equal old new");
2520 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2521 const string enum_definition = "package p; enum Enum { FOO }";
2522 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2523 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2524 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2525 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2526 CaptureStderr();
2527 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2528 EXPECT_EQ("", GetCapturedStderr());
2529}
2530
Daniel Norman85aed542019-08-21 12:01:14 -07002531class AidlTestCompatibleChanges : public AidlTest {
2532 protected:
2533 Options options_ = Options::From("aidl --checkapi old new");
2534};
2535
2536TEST_F(AidlTestCompatibleChanges, NewType) {
2537 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2538 "package p;"
2539 "interface IFoo {"
2540 " void foo(int a);"
2541 "}");
2542 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2543 "package p;"
2544 "interface IFoo {"
2545 " void foo(int a);"
2546 "}");
2547 io_delegate_.SetFileContents("new/p/IBar.aidl",
2548 "package p;"
2549 "interface IBar {"
2550 " void bar();"
2551 "}");
2552 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2553}
2554
2555TEST_F(AidlTestCompatibleChanges, NewMethod) {
2556 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2557 "package p;"
2558 "interface IFoo {"
2559 " void foo(int a);"
2560 "}");
2561 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2562 "package p;"
2563 "interface IFoo {"
2564 " void foo(int a);"
2565 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002566 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002567 "}");
2568 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2569}
2570
2571TEST_F(AidlTestCompatibleChanges, NewField) {
2572 io_delegate_.SetFileContents("old/p/Data.aidl",
2573 "package p;"
2574 "parcelable Data {"
2575 " int foo;"
2576 "}");
2577 io_delegate_.SetFileContents("new/p/Data.aidl",
2578 "package p;"
2579 "parcelable Data {"
2580 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002581 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002582 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002583 "}");
2584 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2585}
2586
Jooyung Han05bd8a82021-04-28 23:56:38 +09002587TEST_F(AidlTestCompatibleChanges, NewField2) {
2588 io_delegate_.SetFileContents("old/p/Data.aidl",
2589 "package p;"
2590 "parcelable Data {"
2591 "}");
2592 io_delegate_.SetFileContents("new/p/Data.aidl",
2593 "package p;"
2594 "parcelable Data {"
2595 " int foo = 0;"
2596 "}");
2597 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2598}
2599
Daniel Norman85aed542019-08-21 12:01:14 -07002600TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2601 io_delegate_.SetFileContents("old/p/Enum.aidl",
2602 "package p;"
2603 "enum Enum {"
2604 " FOO = 1,"
2605 "}");
2606 io_delegate_.SetFileContents("new/p/Enum.aidl",
2607 "package p;"
2608 "enum Enum {"
2609 " FOO = 1,"
2610 " BAR = 2,"
2611 "}");
2612 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2613}
2614
2615TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2616 io_delegate_.SetFileContents("old/p/Enum.aidl",
2617 "package p;"
2618 "enum Enum {"
2619 " FOO = 1,"
2620 " BAR = 2,"
2621 "}");
2622 io_delegate_.SetFileContents("new/p/Enum.aidl",
2623 "package p;"
2624 "enum Enum {"
2625 " BAR = 2,"
2626 " FOO = 1,"
2627 "}");
2628 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2629}
2630
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002631TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2632 io_delegate_.SetFileContents("old/p/Union.aidl",
2633 "package p;"
2634 "union Union {"
2635 " String foo;"
2636 "}");
2637 io_delegate_.SetFileContents("new/p/Union.aidl",
2638 "package p;"
2639 "union Union {"
2640 " String foo;"
2641 " int num;"
2642 "}");
2643 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2644}
2645
Daniel Norman85aed542019-08-21 12:01:14 -07002646TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002647 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2648 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002649 "interface IFoo {"
2650 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002651 "}");
2652 io_delegate_.SetFileContents("old/p/Data.aidl",
2653 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002654 "parcelable Data {"
2655 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002656 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002657 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2658 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002659 "interface IFoo {"
2660 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002661 "}");
2662 io_delegate_.SetFileContents("new/p/Data.aidl",
2663 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002664 "parcelable Data {"
2665 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002666 "}");
2667 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2668 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002669 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002670 " void foo(int a);"
2671 "}");
2672 io_delegate_.SetFileContents("new/q/Data.aidl",
2673 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002674 "parcelable Data {"
2675 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002676 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002677 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2678}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002679
Daniel Norman85aed542019-08-21 12:01:14 -07002680TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2681 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2682 "package p;"
2683 "interface IFoo {"
2684 " void foo(int a);"
2685 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002686 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2687 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002688 "interface IFoo {"
2689 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002690 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002691 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2692}
Jiyong Parke59c3682018-09-11 23:10:25 +09002693
Daniel Norman85aed542019-08-21 12:01:14 -07002694TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002695 io_delegate_.SetFileContents("old/p/I.aidl",
2696 "package p; interface I {"
2697 "const int A = 1; }");
2698 io_delegate_.SetFileContents("new/p/I.aidl",
2699 "package p ; interface I {"
2700 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002701 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2702}
Jiyong Parka428d212018-08-29 22:26:30 +09002703
Daniel Norman85aed542019-08-21 12:01:14 -07002704TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002705 io_delegate_.SetFileContents("old/p/I.aidl",
2706 "package p; interface I {"
2707 "const int A = 1; const int B = 2;}");
2708 io_delegate_.SetFileContents("new/p/I.aidl",
2709 "package p ; interface I {"
2710 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002711 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002712}
2713
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002714TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2715 io_delegate_.SetFileContents("old/p/Foo.aidl",
2716 "package p;"
2717 "@JavaPassthrough(annotation=\"Alice\")"
2718 "@JavaPassthrough(annotation=\"Bob\")"
2719 "parcelable Foo {}");
2720 io_delegate_.SetFileContents("new/p/Foo.aidl",
2721 "package p;"
2722 "@JavaPassthrough(annotation=\"Bob\")"
2723 "@JavaPassthrough(annotation=\"Alice\")"
2724 "parcelable Foo {}");
2725 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2726}
2727
Jooyung Han00073272020-11-27 14:20:20 +09002728TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2729 io_delegate_.SetFileContents("old/p/Foo.aidl",
2730 "package p;"
2731 "parcelable Foo {}");
2732 io_delegate_.SetFileContents("new/p/Foo.aidl",
2733 "package p;"
2734 "@JavaPassthrough(annotation=\"@Deprecated\")"
2735 "parcelable Foo {}");
2736 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2737}
2738
Jooyung Han636fd2f2020-10-22 11:33:45 +09002739TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2740 io_delegate_.SetFileContents("old/p/Data.aidl",
2741 "package p;"
2742 "parcelable Data {"
2743 " int num;"
2744 "}");
2745 io_delegate_.SetFileContents(
2746 "new/p/Data.aidl",
2747 "package p;"
2748 "parcelable Data {"
2749 " int num;"
2750 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2751 "}");
2752 io_delegate_.SetFileContents("new/p/Enum.aidl",
2753 "package p;"
2754 "enum Enum {"
2755 " FOO = 0,"
2756 " BAR = 1,"
2757 "}");
2758 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2759}
2760
Jooyung Han308bbe02021-04-27 12:09:59 +09002761TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2762 io_delegate_.SetFileContents("old/p/Data.aidl",
2763 "package p;\n"
2764 "parcelable Data {\n"
2765 " p.Enum e;\n"
2766 "}");
2767 io_delegate_.SetFileContents("old/p/Enum.aidl",
2768 "package p;\n"
2769 "enum Enum {\n"
2770 " FOO = 0,\n"
2771 " BAR = 1,\n"
2772 "}");
2773 io_delegate_.SetFileContents("new/p/Data.aidl",
2774 "package p;\n"
2775 "parcelable Data {\n"
2776 " p.Enum e = p.Enum.FOO;\n"
2777 "}");
2778 io_delegate_.SetFileContents("new/p/Enum.aidl",
2779 "package p;\n"
2780 "enum Enum {\n"
2781 " FOO = 0,\n"
2782 " BAR = 1,\n"
2783 "}");
2784 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2785}
2786
Daniel Norman85aed542019-08-21 12:01:14 -07002787class AidlTestIncompatibleChanges : public AidlTest {
2788 protected:
2789 Options options_ = Options::From("aidl --checkapi old new");
2790};
2791
2792TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002793 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002794 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2795 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002796 "interface IFoo {"
2797 " void foo(in String[] str);"
2798 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002799 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002800 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002801 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002802 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002803}
2804
2805TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002806 const string expected_stderr =
2807 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002808 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2809 "package p;"
2810 "interface IFoo {"
2811 " void foo(in String[] str);"
2812 " void bar(@utf8InCpp String str);"
2813 "}");
2814 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2815 "package p;"
2816 "interface IFoo {"
2817 " void foo(in String[] str);"
2818 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002819 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002820 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002821 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002822}
2823
Jiyong Parkf8d53612020-05-04 14:06:13 +09002824TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2825 const string expected_stderr =
2826 "ERROR: new/p/IFoo.aidl:1.61-65: "
2827 "Encountered an untyped List or Map. The use of untyped List/Map is "
2828 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2829 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2830 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2831 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2832 "package p;"
2833 "interface IFoo {"
2834 " void foo(in String[] str);"
2835 "}");
2836 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2837 "package p;"
2838 "interface IFoo {"
2839 " void foo(in String[] str);"
2840 " void bar(in List arg);"
2841 "}");
2842 CaptureStderr();
2843 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2844 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2845}
2846
2847TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2848 const string expected_stderr =
2849 "ERROR: new/p/Data.aidl:1.54-59: "
2850 "Encountered an untyped List or Map. The use of untyped List/Map is "
2851 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2852 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2853 "ERROR: new/p/Data.aidl: Failed to read.\n";
2854 io_delegate_.SetFileContents("old/p/Data.aidl",
2855 "package p;"
2856 "parcelable Data {"
2857 " int foo;"
2858 "}");
2859 io_delegate_.SetFileContents("new/p/Data.aidl",
2860 "package p;"
2861 "parcelable Data {"
2862 " int foo;"
2863 " @nullable List list;"
2864 "}");
2865 CaptureStderr();
2866 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2868}
2869
Daniel Norman85aed542019-08-21 12:01:14 -07002870TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002871 const string expected_stderr =
2872 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002873 io_delegate_.SetFileContents("old/p/Data.aidl",
2874 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002875 "parcelable Data {"
2876 " int foo;"
2877 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002878 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002879 io_delegate_.SetFileContents("new/p/Data.aidl",
2880 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002881 "parcelable Data {"
2882 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002883 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002884 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002885 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002886 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002887}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002888
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002889TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2890 const string expected_stderr =
2891 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2892 "backends. Please either provide a default value for this field or mark the field as "
2893 "@nullable. This value or a null value will be used automatically when an old version of "
2894 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2895 "order to make sure your code continues to be backwards compatible, make sure the default or "
2896 "null value does not cause a semantic change to this parcelable.\n";
2897 io_delegate_.SetFileContents("old/p/Data.aidl",
2898 "package p;"
2899 "parcelable Data {"
2900 " int num;"
2901 "}");
2902 io_delegate_.SetFileContents("new/p/Data.aidl",
2903 "package p;"
2904 "parcelable Data {"
2905 " int num;"
2906 " String str;"
2907 "}");
2908 CaptureStderr();
2909 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2910 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2911}
2912
Jooyung Han636fd2f2020-10-22 11:33:45 +09002913TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2914 const string expected_stderr =
2915 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2916 "Please make sure 'Enum' has '0' as a valid value.\n";
2917 io_delegate_.SetFileContents("old/p/Data.aidl",
2918 "package p;"
2919 "parcelable Data {"
2920 " int num;"
2921 "}");
2922 io_delegate_.SetFileContents("new/p/Data.aidl",
2923 "package p;"
2924 "parcelable Data {"
2925 " int num;"
2926 " p.Enum e;"
2927 "}");
2928 io_delegate_.SetFileContents("new/p/Enum.aidl",
2929 "package p;"
2930 "enum Enum {"
2931 " FOO = 1,"
2932 " BAR = 2,"
2933 "}");
2934 CaptureStderr();
2935 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2936 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2937}
2938
Daniel Norman85aed542019-08-21 12:01:14 -07002939TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 const string expected_stderr =
2941 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002942 io_delegate_.SetFileContents("old/p/Enum.aidl",
2943 "package p;"
2944 "enum Enum {"
2945 " FOO = 1,"
2946 " BAR = 2,"
2947 "}");
2948 io_delegate_.SetFileContents("new/p/Enum.aidl",
2949 "package p;"
2950 "enum Enum {"
2951 " BAR = 2,"
2952 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002953 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002954 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002956}
2957
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002958TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2959 const string expected_stderr =
2960 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2961 io_delegate_.SetFileContents("old/p/Union.aidl",
2962 "package p;"
2963 "union Union {"
2964 " String str;"
2965 " int num;"
2966 "}");
2967 io_delegate_.SetFileContents("new/p/Union.aidl",
2968 "package p;"
2969 "union Union {"
2970 " String str;"
2971 "}");
2972 CaptureStderr();
2973 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2975}
2976
Daniel Norman85aed542019-08-21 12:01:14 -07002977TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002978 const string expected_stderr =
2979 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002980 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2981 "package p;"
2982 "interface IFoo {"
2983 " void foo(in String[] str);"
2984 " void bar(@utf8InCpp String str);"
2985 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002986 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2987 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002988 "interface IFoo {"
2989 " void foo(in String[] str);"
2990 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002991 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002992 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002993 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002994 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002995}
2996
Daniel Norman85aed542019-08-21 12:01:14 -07002997TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002998 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002999 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3000 "package p;"
3001 "interface IFoo {"
3002 " void foo(in String[] str);"
3003 " void bar(@utf8InCpp String str);"
3004 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003005 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3006 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003007 "interface IFoo2 {"
3008 " void foo(in String[] str);"
3009 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003010 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003011 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003012 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003014}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003015
Daniel Norman85aed542019-08-21 12:01:14 -07003016TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003017 const string expected_stderr =
3018 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003019 io_delegate_.SetFileContents("old/p/Enum.aidl",
3020 "package p;"
3021 "enum Enum {"
3022 " FOO = 1,"
3023 " BAR = 2,"
3024 "}");
3025 io_delegate_.SetFileContents("new/p/Enum.aidl",
3026 "package p;"
3027 "enum Enum {"
3028 " FOO = 3,"
3029 " BAR = 2,"
3030 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003031 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003032 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003033 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003034}
3035
3036TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003037 const string expected_stderr =
3038 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3039 "from 0 to 1.\n"
3040 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3041 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003042 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3043 "package p;"
3044 "interface IFoo {"
3045 " void foo(in String[] str);"
3046 " void bar(@utf8InCpp String str);"
3047 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003048 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3049 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003050 "interface IFoo {"
3051 " void bar(@utf8InCpp String str);"
3052 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003053 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003054 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003055 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003057}
3058
3059TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003060 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003061 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3062 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003063 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003064 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003065 "parcelable Data {"
3066 " int foo;"
3067 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003068 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003069 io_delegate_.SetFileContents("new/p/Data.aidl",
3070 "package p;"
3071 "parcelable Data {"
3072 " int bar;"
3073 " int foo;"
3074 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003075 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003076 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003077 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003078}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003079
Daniel Norman85aed542019-08-21 12:01:14 -07003080TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003081 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003082 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003083 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003084 "interface IFoo {"
3085 " void foo(in String[] str);"
3086 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003087 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003088 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3089 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003090 "interface IFoo {"
3091 " void foo(out String[] str);"
3092 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003093 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003094 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003095 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003096 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003097}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003098
Daniel Norman85aed542019-08-21 12:01:14 -07003099TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003100 const string expected_stderr =
3101 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003102 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3103 "package p;"
3104 "interface IFoo {"
3105 " void foo(in String[] str);"
3106 " void bar(@utf8InCpp String str);"
3107 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003108 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3109 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003110 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003111 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003112 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003113 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003114 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003115 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003117}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003118
Daniel Norman85aed542019-08-21 12:01:14 -07003119TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003120 const string expected_stderr =
3121 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003122 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3123 "package p;"
3124 "interface IFoo {"
3125 " void foo(in String[] str);"
3126 " void bar(@utf8InCpp String str);"
3127 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003128 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3129 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003130 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003131 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003132 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003133 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003134 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003135 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003136 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003137}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003138
Jooyung Han60b2fde2020-10-29 15:12:40 +09003139TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3140 const string expected_stderr =
3141 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3142 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3143 io_delegate_.SetFileContents("old/p/Foo.aidl",
3144 "package p;"
3145 "@Backing(type=\"byte\")"
3146 "enum Foo {"
3147 " FOO, BAR,"
3148 "}");
3149 io_delegate_.SetFileContents("new/p/Foo.aidl",
3150 "package p;"
3151 "@Backing(type=\"long\")"
3152 "enum Foo {"
3153 " FOO, BAR,"
3154 "}");
3155 CaptureStderr();
3156 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3157 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3158}
3159
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003160TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3161 const string expected_stderr =
3162 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3163 "to @JavaPassthrough(annotation=\"Bob\")\n";
3164 io_delegate_.SetFileContents("old/p/Foo.aidl",
3165 "package p;"
3166 "@JavaPassthrough(annotation=\"Alice\")"
3167 "parcelable Foo {}");
3168 io_delegate_.SetFileContents("new/p/Foo.aidl",
3169 "package p;"
3170 "@JavaPassthrough(annotation=\"Bob\")"
3171 "parcelable Foo {}");
3172
3173 CaptureStderr();
3174 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3175 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3176}
3177
Devin Mooredb7ac512020-08-07 11:17:36 -07003178TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3179 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003180 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003181 io_delegate_.SetFileContents("old/p/Foo.aidl",
3182 "package p;"
3183 "parcelable Foo {"
3184 " int A;"
3185 "}");
3186 io_delegate_.SetFileContents("new/p/Foo.aidl",
3187 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003188 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003189 " int A;"
3190 "}");
3191 CaptureStderr();
3192 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3194}
3195
3196TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3197 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003198 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003199 io_delegate_.SetFileContents("old/p/Foo.aidl",
3200 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003201 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003202 " int A;"
3203 "}");
3204 io_delegate_.SetFileContents("new/p/Foo.aidl",
3205 "package p;"
3206 "parcelable Foo {"
3207 " int A;"
3208 "}");
3209 CaptureStderr();
3210 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3212}
3213
Daniel Norman85aed542019-08-21 12:01:14 -07003214TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003215 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003216 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3217 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003218 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003219 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003220 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003222}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003223
Daniel Norman85aed542019-08-21 12:01:14 -07003224TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003225 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003226 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3227 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003228 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003229 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003231}
Jiyong Parka428d212018-08-29 22:26:30 +09003232
Daniel Norman85aed542019-08-21 12:01:14 -07003233TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003234 const string expected_stderr =
3235 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003236 io_delegate_.SetFileContents("old/p/I.aidl",
3237 "package p; interface I {"
3238 "const int A = 1; const int B = 2;}");
3239 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003240 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003241 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003243}
Jiyong Parka428d212018-08-29 22:26:30 +09003244
Daniel Norman85aed542019-08-21 12:01:14 -07003245TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003246 const string expected_stderr =
3247 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003248 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3249 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003250 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003251 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003252 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003253}
3254
Devin Moorec7e47a32020-08-07 10:55:25 -07003255TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3256 const string expected_stderr =
3257 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3258 "This is an incompatible change for FixedSize types.\n";
3259 io_delegate_.SetFileContents("old/p/Foo.aidl",
3260 "package p; @FixedSize parcelable Foo { int A = 1; }");
3261 io_delegate_.SetFileContents("new/p/Foo.aidl",
3262 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3263 CaptureStderr();
3264 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3265 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3266}
3267
Jeongik Cha68d18e72021-04-29 20:07:01 +09003268TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3269 const string expected_stderr =
3270 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3271 "android.net.UidRangeParcel is changed from 1 to 2. "
3272 "But it is forbidden because of legacy support.\n";
3273 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3274 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3275 io_delegate_.SetFileContents(
3276 "new/android/net/UidRangeParcel.aidl",
3277 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3278 CaptureStderr();
3279 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3280 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3281}
3282
Devin Moorec7e47a32020-08-07 10:55:25 -07003283TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3284 const string expected_stderr =
3285 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3286 io_delegate_.SetFileContents("old/p/Foo.aidl",
3287 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3288 io_delegate_.SetFileContents("new/p/Foo.aidl",
3289 "package p; @FixedSize parcelable Foo { int A = 1; }");
3290 CaptureStderr();
3291 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3293}
3294
3295TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3296 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003297 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003298 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003299 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3300 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003301 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003302 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003303 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003304 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003305 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003306 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3307 "f.\n"
3308 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3309 "nullable1.\n"
3310 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3311 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003312
3313 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003314 "@FixedSize parcelable Foo {\n"
3315 " int[] a;\n"
3316 " Bar b;\n"
3317 " String c;\n"
3318 " ParcelFileDescriptor d;\n"
3319 " IBinder e;\n"
3320 " List<String> f;\n"
3321 " int isFixedSize;\n"
3322 " @nullable OtherFixed nullable1;\n"
3323 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003324 "}");
3325 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003326 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003327 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003328
3329 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003330 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3332}
3333
3334TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3335 const string expected_stderr = "";
3336
3337 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3338 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3339 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003340 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003341
3342 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003343 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3345}
3346
Jiyong Park8c380532018-08-30 14:55:26 +09003347TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003348 const string expected_stderr =
3349 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3350 "dir1/q/IBar.aidl\n"
3351 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003352 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003353 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3354 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3355 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3356 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3357
Devin Moore097a3ab2020-03-11 16:08:44 -07003358 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003359 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003360 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003361}
3362
Jiyong Parked65bf42018-08-28 15:43:27 +09003363TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003364 const string expected_stderr =
3365 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3366 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003367 Options options = Options::From("aidl --checkapi old new");
3368 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3369 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003370
3371 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3372
Jiyong Parke59c3682018-09-11 23:10:25 +09003373 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003374 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003375 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003376 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003377}
3378
Jooyung Han652ce482021-02-26 12:40:35 +09003379TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3380 Options options =
3381 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003382
3383 // use without import
3384 io_delegate_.SetFileContents("p/IFoo.aidl",
3385 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003386 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003387
3388 // capture output files
3389 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003390
Devin Moore7b8d5c92020-03-17 14:14:08 -07003391 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003392 io_delegate_.SetFileContents(
3393 "p/IFoo.aidl",
3394 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003395 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003396 // output files should be the same
3397 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003398
3399 // use with import (as before)
3400 io_delegate_.SetFileContents("p/IFoo.aidl",
3401 "package p;"
3402 "import android.os.ParcelFileDescriptor;"
3403 "interface IFoo{"
3404 " void foo(in ParcelFileDescriptor fd);"
3405 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003406 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003407 // output files should be the same
3408 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003409}
Jiyong Parked65bf42018-08-28 15:43:27 +09003410
Jooyung Han020d8d12021-02-26 17:23:02 +09003411TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3412 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3413 CaptureStderr();
3414 io_delegate_.SetFileContents("p/IFoo.aidl",
3415 "package p;"
3416 "interface IFoo{"
3417 " void foo(out ParcelFileDescriptor fd);"
3418 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003419 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003420 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3421}
3422
3423TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3424 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3425 CaptureStderr();
3426 io_delegate_.SetFileContents("p/IFoo.aidl",
3427 "package p;"
3428 "interface IFoo{"
3429 " void foo(ParcelFileDescriptor fd);"
3430 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003431 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003432 EXPECT_THAT(GetCapturedStderr(),
3433 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3434}
3435
Jiyong Park3633b722019-04-11 15:38:26 +09003436TEST_F(AidlTest, ManualIds) {
3437 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3438 io_delegate_.SetFileContents("IFoo.aidl",
3439 "interface IFoo {\n"
3440 " void foo() = 0;\n"
3441 " void bar() = 1;\n"
3442 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003443 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003444}
3445
3446TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3447 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3448 io_delegate_.SetFileContents("IFoo.aidl",
3449 "interface IFoo {\n"
3450 " void foo() = 0;\n"
3451 " void bar() = 1;\n"
3452 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003453 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003454}
3455
3456TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003457 const string expected_stderr =
3458 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003459 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3460 io_delegate_.SetFileContents("IFoo.aidl",
3461 "interface IFoo {\n"
3462 " void foo() = 3;\n"
3463 " void bar() = 3;\n"
3464 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003465 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003466 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003468}
3469
3470TEST_F(AidlTest, FailOnOutOfRangeIds) {
3471 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003472 const string expected_stderr =
3473 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3474 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003475 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3476 io_delegate_.SetFileContents("IFoo.aidl",
3477 "interface IFoo {\n"
3478 " void foo() = 3;\n"
3479 " void bar() = 16777115;\n"
3480 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003481 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003482 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003483 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003484}
3485
3486TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003487 const string expected_stderr =
3488 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003489 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3490 io_delegate_.SetFileContents("IFoo.aidl",
3491 "interface IFoo {\n"
3492 " void foo() = 3;\n"
3493 " void bar();\n"
3494 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003495 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003496 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003497 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003498}
3499
Jiyong Parkc6816252019-07-08 08:12:28 +09003500TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3501 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3502 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3503 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003504 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003505}
3506
3507TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003508 const string expected_stderr =
3509 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3510 "dir/IBar.aidl\n"
3511 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003512 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003513
Jiyong Parkc6816252019-07-08 08:12:28 +09003514 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3515 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3516 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3517 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003518 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003519 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003521}
3522
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003523TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3524 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3525 "package a.b;\n"
3526 "import a.b.IBar;\n"
3527 "import a.b.IQux;\n"
3528 "interface IFoo { IQux foo(); }\n");
3529 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3530 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3531
3532 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003533 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003534
3535 string output;
3536 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3537 // IBar was imported but wasn't used. include is not expected.
3538 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3539 // IBar was imported and used. include is expected.
3540 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3541}
3542
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003543TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003544 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003545 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003546 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3547 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003548 interface IFoo {
3549 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003550 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003551 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003552 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003553 // JavaPassthrough should work with other types as well (e.g. enum)
3554 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3555 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3556 @JavaPassthrough(annotation="@com.android.AliceTwo")
3557 @Backing(type="byte")
3558 enum MyEnum {
3559 a, b, c
3560 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003561
Jooyung Han4cde01d2020-10-13 11:10:47 +09003562 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003563 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003564
3565 string java_out;
3566 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003567 // type-decl-level annotations with newline at the end
3568 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3569 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3570 // member-decl-level annotations with newline at the end
3571 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3572 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3573 // inline annotations with space at the end
3574 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003575
Jooyung Han4cde01d2020-10-13 11:10:47 +09003576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3577 // type-decl-level annotations with newline at the end
3578 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3579 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3580
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003581 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003582 Options cpp_options =
3583 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003584 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003585
Jooyung Han4cde01d2020-10-13 11:10:47 +09003586 Options ndk_options =
3587 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003588 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003589
Jooyung Han4cde01d2020-10-13 11:10:47 +09003590 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003591 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003592}
3593
Andrei Homescue61feb52020-08-18 15:44:24 -07003594TEST_F(AidlTest, ParseRustDerive) {
3595 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3596 @RustDerive(Clone=true, Copy=false)
3597 parcelable Foo {
3598 int a;
3599 })");
3600
3601 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003602 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003603
3604 string rust_out;
3605 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3606 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3607
3608 // Other backends shouldn't be bothered
3609 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003610 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003611
3612 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003613 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003614
3615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003616 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003617}
3618
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003619TEST_F(AidlTest, EmptyEnforceAnnotation) {
3620 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3621 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3622 interface IFoo {
3623 @Enforce()
3624 void Protected();
3625 })");
3626
3627 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3628 CaptureStderr();
3629 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3630 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3631}
3632
3633TEST_F(AidlTest, EmptyEnforceCondition) {
3634 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3635 interface IFoo {
3636 @Enforce(condition="")
3637 void Protected();
3638 })");
3639
3640 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3641 CaptureStderr();
3642 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3643 EXPECT_THAT(GetCapturedStderr(),
3644 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3645}
3646
3647TEST_F(AidlTest, InvalidEnforceCondition) {
3648 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3649 interface IFoo {
3650 @Enforce(condition="invalid")
3651 void Protected();
3652 })");
3653
3654 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3655 CaptureStderr();
3656 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3657 EXPECT_THAT(GetCapturedStderr(),
3658 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3659}
3660
Jiyong Park56f73d72019-06-11 12:20:28 +09003661class AidlOutputPathTest : public AidlTest {
3662 protected:
3663 void SetUp() override {
3664 AidlTest::SetUp();
3665 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3666 }
3667
3668 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003669 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003670 // check the existence
3671 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3672 }
3673};
3674
3675TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3676 // <out_dir> / <package_name> / <type_name>.java
3677 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3678}
3679
3680TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3681 // when output file is explicitly set, it is always respected. -o option is
3682 // ignored.
3683 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3684}
3685
3686TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3687 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3688}
3689
3690TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3691 // output is the same as the input file except for the suffix
3692 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3693}
3694
Devin Moore7b8d5c92020-03-17 14:14:08 -07003695TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003696 AidlError error;
3697 const string expected_stderr =
3698 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3699 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003700 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3701 R"(package p;
3702 interface IFoo {
3703 const int int32_max_oob = 2147483650;
3704 }
3705 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003706 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003707 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3708 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003709}
3710
Devin Moore7b8d5c92020-03-17 14:14:08 -07003711TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003712 AidlError error;
3713 const string expected_stderr =
3714 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3715 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003716 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3717 R"(package p;
3718 interface IFoo {
3719 const int int32_min_oob = -2147483650;
3720 }
3721 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003722 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003723 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3724 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003725}
3726
Devin Moore7b8d5c92020-03-17 14:14:08 -07003727TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003728 AidlError error;
3729 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003730 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003731 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003732 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3733 R"(package p;
3734 interface IFoo {
3735 const long int64_max_oob = 21474836509999999999999999;
3736 }
3737 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003738 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003739 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3740 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003741}
3742
Devin Moore7b8d5c92020-03-17 14:14:08 -07003743TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003744 AidlError error;
3745 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003746 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003747 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003748 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3749 R"(package p;
3750 interface IFoo {
3751 const long int64_min_oob = -21474836509999999999999999;
3752 }
3753 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003754 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003755 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3756 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003757}
3758
Devin Moore7b8d5c92020-03-17 14:14:08 -07003759TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003760 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003761 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003762 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003763 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3764 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003765 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3766 R"(package p;
3767 @Backing(type="byte")
3768 enum TestEnum {
3769 FOO = 127,
3770 BAR,
3771 }
3772 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003773 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003774 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003775 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003776}
3777
Devin Mooredecaf292020-04-30 09:16:40 -07003778TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3779 AidlError error;
3780 const string expected_stderr =
3781 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003782 "be one of: type\n";
3783 CaptureStderr();
3784 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3785 R"(package p;
3786 @Backing(foo="byte")
3787 enum TestEnum {
3788 FOO = 1,
3789 BAR,
3790 }
3791 )",
3792 typenames_, GetLanguage(), &error));
3793 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3794 EXPECT_EQ(AidlError::BAD_TYPE, error);
3795}
3796
Jooyung Han5721a232020-12-24 04:34:55 +09003797TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3798 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3799 CaptureStderr();
3800 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3801 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3802}
3803
Jooyung Han66813932020-10-23 13:24:44 +09003804TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003805 io_delegate_.SetFileContents("Foo.aidl",
3806 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3807 "Map<String, Baz> d; Bar[] e; }");
3808 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3809 io_delegate_.SetFileContents("Baz.aidl",
3810 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003811 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003812 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003813}
3814
Jooyung Han66813932020-10-23 13:24:44 +09003815TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003816 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003817 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003818 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003819 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3820 "named 'bar'.\n";
3821 CaptureStderr();
3822 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003823 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003824 EXPECT_EQ(expected_error, GetCapturedStderr());
3825}
3826
Jooyung Han09e551c2021-05-11 11:44:48 +09003827TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3828 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3829 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3830 CaptureStderr();
3831 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003832 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003833 EXPECT_EQ("", GetCapturedStderr());
3834}
3835
Jooyung Han59af9cc2020-10-25 21:44:14 +09003836TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3837 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3838 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3839 string expected_error =
3840 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003841 "named 'bar'.\n";
3842 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003843 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003844 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003845 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003846}
3847
Jooyung Han66813932020-10-23 13:24:44 +09003848TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003849 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003850 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3851 string expected_error =
3852 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3853 "only be an in parameter.\n";
3854 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003855 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003856 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003857 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003858}
3859
Jooyung Han66813932020-10-23 13:24:44 +09003860TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003861 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003862 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3863 string expected_error =
3864 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3865 "only be an in parameter.\n";
3866 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003867 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003868 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003869 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003870}
3871
Jooyung Han66813932020-10-23 13:24:44 +09003872TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003873 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003874 Options options = Options::From("aidl --lang=java Foo.aidl");
3875 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003876 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3877 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003878 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003879 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003880 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3881}
Devin Moore53fc99c2020-08-12 08:07:52 -07003882
Jooyung Hanfe086af2021-01-16 03:44:47 +09003883TEST_P(AidlTest, UnionInUnion) {
3884 import_paths_.insert(".");
3885 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3886 CaptureStderr();
3887 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3888 EXPECT_THAT("", GetCapturedStderr());
3889}
3890
Jooyung Hanfe89f122020-10-14 03:49:18 +09003891TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3892 const string method = "package a; union Foo {}";
3893 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3894 CaptureStderr();
3895 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3896 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3897}
3898
3899TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3900 const string method = "package a; union Foo { ParcelableHolder x; }";
3901 const string expected_stderr =
3902 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3903 CaptureStderr();
3904 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3905 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3906}
3907
Jooyung Han53fb4242020-12-17 16:03:49 +09003908TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3909 import_paths_.insert(".");
3910 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3911 const string expected_err = "The union's first member should have a useful default value.";
3912 CaptureStderr();
3913 EXPECT_EQ(nullptr,
3914 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3915 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3916}
3917
Devin Moore53fc99c2020-08-12 08:07:52 -07003918TEST_P(AidlTest, GenericStructuredParcelable) {
3919 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003920 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003921 const string expected_stderr = "";
3922 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003923 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003924 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3925}
3926
Jooyung Han3f347ca2020-12-01 12:41:50 +09003927TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3928 io_delegate_.SetFileContents("Foo.aidl",
3929 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3930 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003931 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003932 const string expected_stderr = "";
3933 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003934 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003935 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3936
3937 string code;
3938 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3939 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3940const ::android::String16& Foo<T,U>::s() {
3941 static const ::android::String16 value(::android::String16(""));
3942 return value;
3943})--"));
3944}
3945
3946TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3947 io_delegate_.SetFileContents("Foo.aidl",
3948 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3949 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003950 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003951 const string expected_stderr = "";
3952 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003953 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3955
3956 string code;
3957 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3958 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3959const char* Foo<T, U>::s = "";
3960)--"));
3961}
3962
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003963TEST_F(AidlTest, NestedTypeArgs) {
3964 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003965 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3966
3967 io_delegate_.SetFileContents("a/Foo.aidl",
3968 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3969 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003970 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3971 const string expected_stderr = "";
3972 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003973 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3975
3976 string code;
3977 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003978 EXPECT_THAT(code,
3979 testing::HasSubstr(
3980 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3981}
3982
3983TEST_F(AidlTest, DoubleArrayError) {
3984 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3985
3986 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3987 const string expected_stderr =
3988 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3989 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003990 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00003991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3992}
3993
3994TEST_F(AidlTest, DoubleGenericError) {
3995 io_delegate_.SetFileContents("a/Bar.aidl",
3996 "package a; parcelable Bar { List<String><String> a; }");
3997
3998 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3999 const string expected_stderr =
4000 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4001 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004002 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4004}
4005
4006TEST_F(AidlTest, ArrayBeforeGenericError) {
4007 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4008
4009 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004010 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004011 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004012 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4013}
4014
4015TEST_F(AidlTest, NullableArraysAreNotSupported) {
4016 io_delegate_.SetFileContents("a/Bar.aidl",
4017 "package a; parcelable Bar { String @nullable [] a; }");
4018
4019 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4020 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004021 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004022 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4023}
4024
4025TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4026 io_delegate_.SetFileContents("a/Bar.aidl",
4027 "package a; parcelable Bar { List<@nullable String> a; }");
4028
4029 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4030 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004031 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004032 EXPECT_THAT(GetCapturedStderr(),
4033 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004034}
4035
Jooyung Han14004ed2020-10-16 03:49:57 +09004036struct GenericAidlTest : ::testing::Test {
4037 FakeIoDelegate io_delegate_;
4038 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004039 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004040 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4041 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4042 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4043
4044 Options options = Options::From(cmd);
4045 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004046 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004047 EXPECT_EQ("", GetCapturedStderr());
4048 }
4049};
4050
4051TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4052 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4053 string code;
4054 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4055 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4056 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4057 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4058}
4059
4060TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4061 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4062 string code;
4063 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4064 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4065 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4066 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4067}
4068
Devin Moore53fc99c2020-08-12 08:07:52 -07004069TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4070 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004071 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004072 const string expected_stderr =
4073 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4074 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004075 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4077}
4078
4079TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4080 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004081 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004082 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4083 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004084 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004085 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4086}
4087
Jooyung Han7a308842020-10-27 19:06:49 +09004088TEST_P(AidlTest, LongCommentWithinConstExpression) {
4089 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004090 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004091 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004092 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004093 EXPECT_EQ("", GetCapturedStderr());
4094}
4095
Jeongik Chaef44e622020-10-23 16:00:52 +09004096TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4097 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4098 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4099 std::string expectedErr =
4100 "ERROR: a/Foo.aidl:1.28-30: "
4101 "Encountered an untyped List or Map. The use of untyped List/Map is "
4102 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4103 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4104 "ERROR: a/Foo.aidl:1.35-37: "
4105 "Encountered an untyped List or Map. The use of untyped List/Map is "
4106 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4107 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4108 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004109 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004110 EXPECT_EQ(expectedErr, GetCapturedStderr());
4111}
4112
4113TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004114 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4115 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004116 std::string expectedErr =
4117 "ERROR: a/Foo.aidl:1.33-35: "
4118 "Encountered an untyped List or Map. The use of untyped List/Map is "
4119 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4120 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4121 "ERROR: a/Foo.aidl:1.40-42: "
4122 "Encountered an untyped List or Map. The use of untyped List/Map is "
4123 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4124 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004125 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004126 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004127 EXPECT_EQ(expectedErr, GetCapturedStderr());
4128}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004129
Jeongik Chaef44e622020-10-23 16:00:52 +09004130TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4131 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4132 io_delegate_.SetFileContents(
4133 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4134 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4135 std::string expectedErr =
4136 "ERROR: a/Foo.aidl:1.52-54: "
4137 "Encountered an untyped List or Map. The use of untyped List/Map is "
4138 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4139 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4140 "ERROR: a/Foo.aidl:1.64-66: "
4141 "Encountered an untyped List or Map. The use of untyped List/Map is "
4142 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4143 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4144 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004145 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004146 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004147}
4148
Jooyung Han690f5842020-12-04 13:02:04 +09004149TEST_F(AidlTest, EnumWithDefaults_Java) {
4150 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4151 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4152package p;
4153import p.Enum;
4154parcelable Foo {
4155 Enum e = Enum.BAR;
4156})");
4157 CaptureStderr();
4158 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004159 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004160 auto err = GetCapturedStderr();
4161 EXPECT_EQ("", err);
4162
4163 string code;
4164 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004165 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004166}
4167
4168TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4169 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4170 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4171package p;
4172import p.Enum;
4173parcelable Foo {
4174 Enum e = Enum.BAR;
4175})");
4176 CaptureStderr();
4177 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004178 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004179 auto err = GetCapturedStderr();
4180 EXPECT_EQ("", err);
4181
4182 string code;
4183 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4184 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4185}
4186
4187TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4188 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4189 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4190package p;
4191import p.Enum;
4192parcelable Foo {
4193 Enum e = Enum.BAR;
4194})");
4195 CaptureStderr();
4196 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004197 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004198 auto err = GetCapturedStderr();
4199 EXPECT_EQ("", err);
4200
4201 string code;
4202 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4203 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4204}
4205
4206TEST_F(AidlTest, EnumWithDefaults_Rust) {
4207 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4208 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4209package p;
4210import p.Enum;
4211parcelable Foo {
4212 int n = 42;
4213 Enum e = Enum.BAR;
4214})");
4215 CaptureStderr();
4216 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004217 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004218 auto err = GetCapturedStderr();
4219 EXPECT_EQ("", err);
4220
4221 string code;
4222 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4223 EXPECT_THAT(code, testing::HasSubstr(R"(
4224 fn default() -> Self {
4225 Self {
4226 n: 42,
4227 e: crate::mangled::_1_p_4_Enum::BAR,
4228 }
4229 })"));
4230}
4231
4232TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4233 import_paths_.insert("a");
4234 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4235 CaptureStderr();
4236 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4237package p;
4238import p.Enum;
4239parcelable Foo {
4240 int e = Enum.FOO | Enum.BAR;
4241})",
4242 typenames_, GetLanguage());
4243 auto err = GetCapturedStderr();
4244 EXPECT_EQ("", err);
4245 EXPECT_TRUE(type);
4246 const auto& fields = type->AsStructuredParcelable()->GetFields();
4247 EXPECT_EQ("int e = 3", fields[0]->ToString());
4248}
4249
4250TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4251 CaptureStderr();
4252 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4253@Backing(type="int")
4254enum Foo {
4255 STANDARD_SHIFT = 16,
4256 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4257 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4258}
4259)",
4260 typenames_, GetLanguage());
4261 auto err = GetCapturedStderr();
4262 EXPECT_EQ("", err);
4263 EXPECT_TRUE(type);
4264 const auto& enum_type = type->AsEnumDeclaration();
4265 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004266 auto writer = CodeWriter::ForString(&code);
4267 DumpVisitor visitor(*writer);
4268 visitor.Visit(*enum_type);
4269 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004270 EXPECT_EQ(R"--(@Backing(type="int")
4271enum Foo {
4272 STANDARD_SHIFT = 16,
4273 STANDARD_BT709 = 65536,
4274 STANDARD_BT601_625 = 131072,
4275}
4276)--",
4277 code);
4278}
4279
4280TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4281 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4282 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4283package p;
4284import p.Enum;
4285parcelable Foo {
4286 Enum e = Enum.FOO | Enum.BAR;
4287})");
4288 CaptureStderr();
4289 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004290 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004291 auto err = GetCapturedStderr();
4292 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4293 err);
4294}
4295
Jooyung Han361cd102021-05-24 11:30:10 +09004296TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4297 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4298 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4299package p;
4300import p.Enum;
4301parcelable Foo {
4302 Enum e = 1;
4303})");
4304 CaptureStderr();
4305 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004306 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004307 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4308}
4309
Jooyung Han690f5842020-12-04 13:02:04 +09004310TEST_P(AidlTest, DefaultWithEmptyArray) {
4311 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4312 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4313 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004314 auto options =
4315 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004316 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004317 auto err = GetCapturedStderr();
4318 EXPECT_EQ("", err);
4319}
4320
4321TEST_P(AidlTest, RejectRefsInAnnotation) {
4322 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4323 "package p; interface IFoo {\n"
4324 " const String ANNOTATION = \"@Annotation\";\n"
4325 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4326 "}");
4327 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004328 auto options =
4329 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004330 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004331 auto err = GetCapturedStderr();
4332 EXPECT_EQ(
4333 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4334 "ANNOTATION.\n",
4335 err);
4336}
4337
4338TEST_F(AidlTest, DefaultWithEnumValues) {
4339 io_delegate_.SetFileContents(
4340 "a/p/Foo.aidl",
4341 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4342 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4343 CaptureStderr();
4344 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004345 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004346 auto err = GetCapturedStderr();
4347 EXPECT_EQ("", err);
4348 string code;
4349 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4350 EXPECT_THAT(
4351 code, testing::HasSubstr(
4352 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4353}
4354
Jooyung Han14259392020-12-07 10:00:08 +09004355TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4356 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4357 CaptureStderr();
4358 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004359 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004360 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004361 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004362}
4363
4364TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4365 io_delegate_.SetFileContents("a/p/Foo.aidl",
4366 "package p; parcelable Foo { const int A = A + 1; }");
4367 CaptureStderr();
4368 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004369 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004370 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004371 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4372}
4373
4374TEST_F(AidlTest, RecursiveReferences) {
4375 io_delegate_.SetFileContents("a/p/Foo.aidl",
4376 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4377 io_delegate_.SetFileContents("a/p/Bar.aidl",
4378 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4379 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4380 CaptureStderr();
4381 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004382 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004383 EXPECT_EQ("", GetCapturedStderr());
4384}
4385
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004386TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4387 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4388 auto options =
4389 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4390 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4391 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004392 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004393 EXPECT_EQ(err, GetCapturedStderr());
4394}
4395
4396TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4397 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4398 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4399 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4400 auto options =
4401 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4402 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004403 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004404 EXPECT_EQ("", GetCapturedStderr());
4405}
4406
Jooyung Hane9f5b272021-01-07 00:18:11 +09004407TEST_P(AidlTest, UnknownConstReference) {
4408 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4409 auto options =
4410 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4411 const string err =
4412 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4413 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4414 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4415 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004416 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004417 EXPECT_EQ(err, GetCapturedStderr());
4418}
4419
Jooyung Han29813842020-12-08 01:28:03 +09004420TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4421 string contents = R"(
4422import android.os.IBinder;
4423import android.os.IInterface;
4424interface IFoo {}
4425 )";
4426 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004427}
4428
Jooyung Han888c5bc2020-12-22 17:28:47 +09004429TEST_P(AidlTest, WarningInterfaceName) {
4430 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004431 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004432 " -Weverything -o out -h out p/Foo.aidl");
4433 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004434 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004435 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004436 GetCapturedStderr());
4437}
4438
4439TEST_P(AidlTest, ErrorInterfaceName) {
4440 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004441 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004442 " -Weverything -Werror -o out -h out p/Foo.aidl");
4443 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004444 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004445 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004446 GetCapturedStderr());
4447}
4448
Jiyong Park9f4c3822021-04-07 20:36:45 +09004449TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4450 const std::string input_file = "base/p/q/IFoo.aidl";
4451 const std::string header_dir = "out/";
4452 const std::string output_file = "out/base/p/q/IFoo.cpp";
4453 const std::string package = "p.q"; // not base.p.q
4454 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4455
4456 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4457 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004458 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004459 EXPECT_THAT(
4460 GetCapturedStderr(),
4461 testing::StartsWith(
4462 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4463 "but is out/base/p/q/IFoo.cpp."));
4464}
4465
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004466TEST_F(AidlTest, FormatCommentsForJava) {
4467 using android::aidl::FormatCommentsForJava;
4468
4469 struct TestCase {
4470 vector<Comment> comments;
4471 string formatted;
4472 };
4473 vector<TestCase> testcases = {
4474 {{}, ""},
4475 {{{"// line comments\n"}}, "// line comments\n"},
4476 {{{"// @hide \n"}}, "// @hide \n"},
4477 // Transform the last block comment as Javadoc.
4478 {{{"/*\n"
4479 " * Hello, world!\n"
4480 " */"}},
4481 "/**\n"
4482 " * Hello, world!\n"
4483 " */"},
4484 {{{"/* @hide */"}}, "/** @hide */"},
4485 {{{"/**\n"
4486 " @param foo ...\n"
4487 "*/"}},
4488 "/**\n"
4489 " @param foo ...\n"
4490 "*/"},
4491 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4492 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4493 "/* @deprecated first *//** @deprecated second */"},
4494 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4495 // Line comments are printed as they are
4496 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4497 };
4498 for (const auto& [input, formatted] : testcases) {
4499 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4500 }
4501}
4502
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004503TEST_F(AidlTest, HideIsNotForArgs) {
4504 io_delegate_.SetFileContents("IFoo.aidl",
4505 "interface IFoo {\n"
4506 " void foo(in @Hide int x);\n"
4507 "}");
4508 auto options = Options::From("aidl --lang=java IFoo.aidl");
4509 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004510 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004511 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4512}
4513
4514TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4515 io_delegate_.SetFileContents(
4516 "IFoo.aidl",
4517 "interface IFoo {\n"
4518 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4519 "}");
4520 auto options = Options::From("aidl --lang=java IFoo.aidl");
4521 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004522 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004523 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4524}
4525
Jooyung Hanfa181932021-06-12 07:56:53 +09004526TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4527 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4528 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4529 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004530 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004531 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4532}
4533
Jooyung Hanfd3be322020-12-13 09:11:06 +09004534struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004535 string kind;
4536 string literal;
4537};
4538
Jooyung Hanfd3be322020-12-13 09:11:06 +09004539const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004540 {"primitive", "int"}, {"primitiveArray", "int[]"},
4541 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004542 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4543 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4544 {"union", "a.Union"}, {"interface", "a.IBar"},
4545};
4546
4547const std::map<std::string, std::string> kListSupportExpectations = {
4548 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4549 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4550 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4551 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004552 {"cpp_primitiveArray", "List of arrays is not supported."},
4553 {"java_primitiveArray", "List of arrays is not supported."},
4554 {"ndk_primitiveArray", "List of arrays is not supported."},
4555 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004556 {"cpp_String", ""},
4557 {"java_String", ""},
4558 {"ndk_String", ""},
4559 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004560 {"cpp_StringArray", "List of arrays is not supported."},
4561 {"java_StringArray", "List of arrays is not supported."},
4562 {"ndk_StringArray", "List of arrays is not supported."},
4563 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004564 {"cpp_IBinder", ""},
4565 {"java_IBinder", ""},
4566 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4567 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004568 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004569 {"java_ParcelFileDescriptor", ""},
4570 {"ndk_ParcelFileDescriptor", ""},
4571 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004572 {"cpp_interface", "List<a.IBar> is not supported."},
4573 {"java_interface", "List<a.IBar> is not supported."},
4574 {"ndk_interface", "List<a.IBar> is not supported."},
4575 {"rust_interface", "List<a.IBar> is not supported."},
4576 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004577 {"java_parcelable", ""},
4578 {"ndk_parcelable", ""},
4579 {"rust_parcelable", ""},
4580 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4581 {"java_enum", "A generic type cannot have any primitive type parameters."},
4582 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4583 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004584 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004585 {"java_union", ""},
4586 {"ndk_union", ""},
4587 {"rust_union", ""},
4588};
4589
Jooyung Hand236e552020-12-13 09:21:27 +09004590const std::map<std::string, std::string> kArraySupportExpectations = {
4591 {"cpp_primitive", ""},
4592 {"java_primitive", ""},
4593 {"ndk_primitive", ""},
4594 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004595 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4596 {"java_primitiveArray", "Can only have one dimensional arrays."},
4597 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4598 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004599 {"cpp_String", ""},
4600 {"java_String", ""},
4601 {"ndk_String", ""},
4602 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004603 {"cpp_StringArray", "Can only have one dimensional arrays."},
4604 {"java_StringArray", "Can only have one dimensional arrays."},
4605 {"ndk_StringArray", "Can only have one dimensional arrays."},
4606 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004607 {"cpp_IBinder", ""},
4608 {"java_IBinder", ""},
4609 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4610 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4611 {"cpp_ParcelFileDescriptor", ""},
4612 {"java_ParcelFileDescriptor", ""},
4613 {"ndk_ParcelFileDescriptor", ""},
4614 {"rust_ParcelFileDescriptor", ""},
4615 {"cpp_interface", "Binder type cannot be an array"},
4616 {"java_interface", "Binder type cannot be an array"},
4617 {"ndk_interface", "Binder type cannot be an array"},
4618 {"rust_interface", "Binder type cannot be an array"},
4619 {"cpp_parcelable", ""},
4620 {"java_parcelable", ""},
4621 {"ndk_parcelable", ""},
4622 {"rust_parcelable", ""},
4623 {"cpp_enum", ""},
4624 {"java_enum", ""},
4625 {"ndk_enum", ""},
4626 {"rust_enum", ""},
4627 {"cpp_union", ""},
4628 {"java_union", ""},
4629 {"ndk_union", ""},
4630 {"rust_union", ""},
4631};
4632
Jooyung Hanfd3be322020-12-13 09:11:06 +09004633class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004634 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004635 void Run(const std::string& generic_type_decl,
4636 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004637 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004638 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004639 const auto& kind = std::get<1>(param).kind;
4640
4641 FakeIoDelegate io;
4642 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4643 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4644 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004645 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4646 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004647
4648 const auto options =
4649 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4650 CaptureStderr();
4651 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004652 auto it = expectations.find(lang + "_" + kind);
4653 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004654 const string err = GetCapturedStderr();
4655 if (it->second.empty()) {
4656 EXPECT_EQ("", err);
4657 } else {
4658 EXPECT_THAT(err, testing::HasSubstr(it->second));
4659 }
4660 }
4661};
4662
4663INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004664 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004665 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4666 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004667 testing::ValuesIn(kTypeParams)),
4668 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004669 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004670 });
4671
Jooyung Hanfd3be322020-12-13 09:11:06 +09004672TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4673 Run("List<{}>", kListSupportExpectations);
4674}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004675
Jooyung Hand236e552020-12-13 09:21:27 +09004676TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4677 Run("{}[]", kArraySupportExpectations);
4678}
4679
Christopher Wiley90be4e32015-10-20 14:55:25 -07004680} // namespace aidl
4681} // namespace android