blob: c1a2137d34c96bcdd84d018dcd9edc7025bb2957 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
1477TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1478 io_delegate_.SetFileContents("p/IOuter.aidl",
1479 "package p;\n"
1480 "interface IOuter {\n"
1481 " parcelable Inner {}\n"
1482 "}");
1483 import_paths_.emplace("");
1484 const string input_path = "p/IFoo.aidl";
1485 const string input =
1486 "package p;\n"
1487 "interface IFoo {\n"
1488 " p.IOuter.Inner get();\n"
1489 "}";
1490 CaptureStderr();
1491 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1492 EXPECT_EQ(GetCapturedStderr(), "");
1493
1494 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1495}
1496
1497TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1498 io_delegate_.SetFileContents("p/IOuter.aidl",
1499 "package p;\n"
1500 "interface IOuter {\n"
1501 " parcelable Inner {}\n"
1502 "}");
1503 import_paths_.emplace("");
1504 const string input_path = "p/IFoo.aidl";
1505 const string input =
1506 "package p;\n"
1507 "import p.IOuter.Inner;"
1508 "interface IFoo {\n"
1509 " Inner get();\n"
1510 "}";
1511 CaptureStderr();
1512 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1513 EXPECT_EQ(GetCapturedStderr(), "");
1514
1515 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1516}
1517
1518TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1519 const string input_path = "p/IFoo.aidl";
1520 const string input =
1521 "package p;\n"
1522 "interface IFoo {\n"
1523 " parcelable Result {}\n"
1524 " Result get();\n"
1525 "}";
1526 CaptureStderr();
1527 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1528 EXPECT_EQ(GetCapturedStderr(), "");
1529
1530 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1531}
1532
1533// Finding the type of nested named member.
1534struct TypeFinder : AidlVisitor {
1535 string name;
1536 const AidlTypeSpecifier* type = nullptr;
1537 TypeFinder(std::string name) : name(name) {}
1538 void Visit(const AidlVariableDeclaration& v) override {
1539 if (v.GetName() == name) {
1540 type = &v.GetType();
1541 }
1542 }
1543 void Visit(const AidlMethod& m) override {
1544 if (m.GetName() == name) {
1545 type = &m.GetType();
1546 }
1547 }
1548 static string Get(const AidlDefinedType& type, const string& name) {
1549 TypeFinder v(name);
1550 VisitTopDown(v, type);
1551 return v.type ? v.type->Signature() : "(null)";
1552 };
1553};
1554
1555TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1556 io_delegate_.SetFileContents("q/IBar.aidl",
1557 "package q;\n"
1558 "interface IBar {\n"
1559 " parcelable Baz {}\n"
1560 "}");
1561 import_paths_.emplace("");
1562 const string input_path = "p/IFoo.aidl";
1563 const string input =
1564 "package p;\n"
1565 "import q.IBar;\n"
1566 "interface IFoo {\n"
1567 " parcelable Nested {\n"
1568 " Baz t1;\n"
1569 " }\n"
1570 " parcelable Baz { }\n"
1571 " IBar.Baz t2();\n"
1572 " Baz t3();\n"
1573 "}";
1574 CaptureStderr();
1575 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1576 EXPECT_EQ(GetCapturedStderr(), "");
1577 ASSERT_NE(nullptr, foo);
1578
1579 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1580 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1581 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1582}
1583
1584TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1585 const string input_path = "p/Foo.aidl";
1586 const string input =
1587 "package p;\n"
1588 "parcelable Foo {\n"
1589 " parcelable Foo {}\n"
1590 "}";
1591 CaptureStderr();
1592 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1593 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1594}
1595
1596TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1597 const string input_path = "p/IFoo.aidl";
1598 const string input =
1599 "package p;\n"
1600 "interface IFoo {\n"
1601 " interface ICallback { void done(); }\n"
1602 " void doTask(ICallback cb);\n"
1603 "}";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1606 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1607}
1608
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001609TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1610 const string input_path = "p/IFoo.aidl";
1611 const string input =
1612 "package p;\n"
1613 "interface IFoo {\n"
1614 " parcelable;\n" // missing identifier
1615 "}";
1616 CaptureStderr();
1617 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1618 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1619}
1620
Jooyung Han2aedb112021-09-29 09:37:59 +09001621TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1622 const string input_path = "p/Foo.aidl";
1623 const string input =
1624 "package p;\n"
1625 "interface Foo {\n"
1626 " parcelable Bar {}\n"
1627 " parcelable Bar {}\n"
1628 "}";
1629 CaptureStderr();
1630 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1631 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1632}
1633
1634TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1635 struct Failure {
1636 string err;
1637 };
1638 struct TestCase {
1639 string type;
1640 variant<string, Failure> expected; // success<0> or failure<1>
1641 };
1642 vector<TestCase> cases = {
1643 {"foo.A", "foo.A"},
1644 {"foo.A.B", "foo.A.B"},
1645 {"@nullable(heap=true) A", "foo.A.B.A"},
1646 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1647 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1648 {"B", "foo.A.B.A.B"},
1649 {"A.B", "foo.A.B.A.B"},
1650 };
1651 const string input_path = "foo/A.aidl";
1652 for (auto& [type, expected] : cases) {
1653 AidlTypenames typenames;
1654 // clang-format off
1655 const string input =
1656 "package foo;\n"
1657 "parcelable A {\n"
1658 " parcelable B {\n"
1659 " parcelable A {\n"
1660 " parcelable B {\n"
1661 " }\n"
1662 " " + type + " m;\n"
1663 " }\n"
1664 " }\n"
1665 "}";
1666 // clang-format on
1667 CaptureStderr();
1668 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1669 if (auto failure = std::get_if<Failure>(&expected); failure) {
1670 ASSERT_EQ(nullptr, foo);
1671 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1672 } else {
1673 EXPECT_EQ(GetCapturedStderr(), "");
1674 ASSERT_NE(nullptr, foo);
1675 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1676 }
1677 }
1678}
1679
Jooyung Hanca84b032021-09-30 02:15:59 +09001680TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1681 const string input_path = "p/IFoo.aidl";
1682 const string input =
1683 "package p;\n"
1684 "interface IFoo {\n"
1685 " parcelable Result {}\n"
1686 "}";
1687 CaptureStderr();
1688 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1689 ASSERT_NE(nullptr, foo);
1690 EXPECT_EQ(GetCapturedStderr(), "");
1691
1692 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1693 ASSERT_NE(nullptr, result);
1694 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1695}
1696
Jooyung Han0a950bd2021-05-15 12:50:36 +09001697TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001698 const string input_path = "p/Wrapper.aidl";
1699 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001700
1701 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1702 EXPECT_NE(nullptr, parse_result);
1703
1704 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1705 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1706 (..., params->emplace_back(std::move(type_params)));
1707 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1708 };
1709
1710 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1711 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001712 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001713 type->Annotate(std::move(annotations));
1714 return std::move(type);
1715 };
1716
1717 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1718 (void)type->SetArray();
1719 return std::move(type);
1720 };
1721
1722 auto w = type("p.Wrapper", type("String"));
1723 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1724
1725 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1726 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1727 cpp::CppNameOf(*nullable_w, typenames_));
1728
1729 auto array_w = set_array(type("p.Wrapper", type("String")));
1730 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1731 cpp::CppNameOf(*array_w, typenames_));
1732
1733 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1734 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1735 cpp::CppNameOf(*nullable_array_w, typenames_));
1736
1737 auto list_w = type("List", type("p.Wrapper", type("String")));
1738 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1739 cpp::CppNameOf(*list_w, typenames_));
1740
1741 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1742 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1743 cpp::CppNameOf(*nullable_list_w, typenames_));
1744}
1745
Devin Moore7b8d5c92020-03-17 14:14:08 -07001746TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001747 io_delegate_.SetFileContents(
1748 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001749 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001750 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001751 const string input_path = "p/IFoo.aidl";
1752 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001753 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1754 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001755 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001756 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001757 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001758
1759 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1760 // C++ understands C++ specific stuff
1761 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1762 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001763 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001764 EXPECT_EQ(1u, headers.size());
1765 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001766}
1767
Christopher Wileyf8136192016-04-12 14:19:35 -07001768TEST_F(AidlTest, WritesCorrectDependencyFile) {
1769 // While the in tree build system always gives us an output file name,
1770 // other android tools take advantage of our ability to infer the intended
1771 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001772 vector<string> args = {
1773 "aidl",
1774 "-d dep/file/path",
1775 "-o place/for/output",
1776 "p/IFoo.aidl"};
1777 Options options = Options::From(args);
1778 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001779 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001780 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001781 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001782 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1783}
1784
Dan Willemsen93298ee2016-11-10 23:55:55 -08001785TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1786 // While the in tree build system always gives us an output file name,
1787 // other android tools take advantage of our ability to infer the intended
1788 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001789 vector<string> args = {
1790 "aidl",
1791 "-d dep/file/path",
1792 "--ninja",
1793 "-o place/for/output",
1794 "p/IFoo.aidl"};
1795 Options options = Options::From(args);
1796 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001797 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001798 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001799 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001800 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1801}
1802
Jiyong Parkdf202122019-09-30 20:48:35 +09001803TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001804 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1805 // this by calling aidl with every .aidl file it finds, then parsing the
1806 // generated dependency files. Those that reference .java output files are
1807 // for interfaces and those that do not are parcelables. However, for both
1808 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001809 vector<string> args = {
1810 "aidl",
1811 "-o place/for/output",
1812 "-d dep/file/path",
1813 "p/Foo.aidl"};
1814 Options options = Options::From(args);
1815 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001816 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001817 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001818 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001819 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1820}
1821
1822TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1823 vector<string> args = {
1824 "aidl",
1825 "--structured",
1826 "-o place/for/output",
1827 "-d dep/file/path",
1828 "p/Foo.aidl"};
1829 Options options = Options::From(args);
1830 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001831 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001832 string actual_dep_file_contents;
1833 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1834 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001835}
1836
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001837TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1838 vector<string> args = {
1839 "aidl",
1840 "--lang=java",
1841 "-o place/for/output",
1842 "p/Foo.aidl"};
1843 Options options = Options::From(args);
1844 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001845 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001846 string output_file_contents;
1847 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1848}
1849
Devin Moore21b26772020-08-26 16:37:56 -07001850TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001851 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001852 const string list_array_parcelable =
1853 "package a; parcelable Foo {\n"
1854 " List[] lists; }";
1855 CaptureStderr();
1856 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1857 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1858}
1859
Jiyong Parkf8d53612020-05-04 14:06:13 +09001860TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1861 AidlError error;
1862 string expected_stderr =
1863 "ERROR: a/IFoo.aidl:2.7-11: "
1864 "Encountered an untyped List or Map. The use of untyped List/Map is "
1865 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1866 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1867 if (GetLanguage() != Options::Language::JAVA) {
1868 expected_stderr =
1869 "ERROR: a/IFoo.aidl:2.1-7: "
1870 "Currently, only the Java backend supports non-generic List.\n";
1871 }
1872
1873 const string primitive_interface =
1874 "package a; interface IFoo {\n"
1875 " List foo(); }";
1876 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001877 AidlTypenames tn1;
1878 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001879 {"--structured"}));
1880 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001881
1882 string primitive_parcelable =
1883 "package a; parcelable IFoo {\n"
1884 " List foo;}";
1885 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001886 AidlTypenames tn2;
1887 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001888 {"--structured"}));
1889 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1890}
1891
Jeongik Cha225519b2020-08-29 01:55:32 +09001892TEST_P(AidlTest, ExtensionTest) {
1893 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001894 string extendable_parcelable =
1895 "package a; parcelable Data {\n"
1896 " ParcelableHolder extension;\n"
1897 " ParcelableHolder extension2;\n"
1898 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001899 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001900 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1901 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001902 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001903 "yet.\n",
1904 GetCapturedStderr());
1905 } else {
1906 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1907 EXPECT_EQ("", GetCapturedStderr());
1908 }
1909}
1910TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1911 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001912 string parcelableholder_return_interface =
1913 "package a; interface IFoo {\n"
1914 " ParcelableHolder foo();\n"
1915 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001916 EXPECT_EQ(nullptr,
1917 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001918
Jeongik Cha8f02a532020-10-14 00:16:28 +09001919 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001920 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001921 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001922 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001923 "yet.\n",
1924 GetCapturedStderr());
1925 return;
1926 }
1927 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1928 GetCapturedStderr());
1929}
1930
1931TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1932 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001933 string extendable_parcelable_arg_interface =
1934 "package a; interface IFoo {\n"
1935 " void foo(in ParcelableHolder ph);\n"
1936 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001937 EXPECT_EQ(nullptr,
1938 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1939
Jeongik Cha8f02a532020-10-14 00:16:28 +09001940 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001941 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001942 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001943 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001944 "yet.\n",
1945 GetCapturedStderr());
1946 return;
1947 }
1948 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1949 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001950}
1951
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001952TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1953 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001954 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001955 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1956 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001957 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001958 if (GetLanguage() == Options::Language::RUST) {
1959 EXPECT_EQ(
1960 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1961 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1962 "yet.\n",
1963 GetCapturedStderr());
1964 return;
1965 }
1966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1967}
1968
Jooyung Han3f347ca2020-12-01 12:41:50 +09001969TEST_P(AidlTest, ParcelablesWithConstants) {
1970 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001971 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001972 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001973 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001974 EXPECT_EQ("", GetCapturedStderr());
1975}
1976
1977TEST_P(AidlTest, UnionWithConstants) {
1978 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001979 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001980 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001981 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001982 EXPECT_EQ("", GetCapturedStderr());
1983}
1984
Jooyung Han633eab62021-01-07 14:12:40 +09001985TEST_F(AidlTest, ConstantsWithAnnotations) {
1986 io_delegate_.SetFileContents("IFoo.aidl",
1987 "interface IFoo {\n"
1988 " @JavaPassthrough(annotation=\"@Foo\")\n"
1989 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
1990 "}");
1991 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
1992 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001993 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09001994 EXPECT_EQ("", GetCapturedStderr());
1995 string code;
1996 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
1997 EXPECT_THAT(code, HasSubstr("@Foo\n"));
1998 EXPECT_THAT(code, HasSubstr("@Bar\n"));
1999}
2000
Jiyong Park02da7422018-07-16 16:00:26 +09002001TEST_F(AidlTest, ApiDump) {
2002 io_delegate_.SetFileContents(
2003 "foo/bar/IFoo.aidl",
2004 "package foo.bar;\n"
2005 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002006 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002007 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002008 " /* @hide applied \n"
2009 " @deprecated use foo2 */\n"
2010 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2011 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002012 " IFoo foo3(IFoo foo);\n"
2013 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002014 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002015 " /** blahblah\n"
2016 " @deprecated\n"
2017 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002018 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002019 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002020 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002021 "}\n");
2022 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2023 "package foo.bar;\n"
2024 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002025 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002026 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002027 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002028 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002029 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002030 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002031 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002032 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002033 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002034 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002035 "}\n");
2036 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002037 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2038 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002039 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002040 bool result = dump_api(options, io_delegate_);
2041 ASSERT_TRUE(result);
2042 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002043 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002044 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002045interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002046 /**
2047 * @hide
2048 * @deprecated use foo2
2049 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002050 int foo(out int[] a, String b, boolean c, inout List<String> d);
2051 int foo2(@utf8InCpp String x, inout List<String> y);
2052 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2053 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002054 /**
2055 * @deprecated reason why...
2056 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002057 const int A = 1;
2058 const String STR = "Hello";
2059}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002060)"),
2061 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002062
Jiyong Parke59c3682018-09-11 23:10:25 +09002063 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002064 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002065/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002066parcelable Data {
2067 int x = 10;
2068 int y;
2069 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002070 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002071}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002072)"),
2073 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002074}
2075
Jiyong Parked65bf42018-08-28 15:43:27 +09002076TEST_F(AidlTest, ApiDumpWithManualIds) {
2077 io_delegate_.SetFileContents(
2078 "foo/bar/IFoo.aidl",
2079 "package foo.bar;\n"
2080 "interface IFoo {\n"
2081 " int foo() = 1;\n"
2082 " int bar() = 2;\n"
2083 " int baz() = 10;\n"
2084 "}\n");
2085
Jiyong Parke59c3682018-09-11 23:10:25 +09002086 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002087 Options options = Options::From(args);
2088 bool result = dump_api(options, io_delegate_);
2089 ASSERT_TRUE(result);
2090 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002091 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002092 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002093interface IFoo {
2094 int foo() = 1;
2095 int bar() = 2;
2096 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002097}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002098)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002099}
2100
2101TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002102 const string expected_stderr =
2103 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2104 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002105 io_delegate_.SetFileContents(
2106 "foo/bar/IFoo.aidl",
2107 "package foo.bar;\n"
2108 "interface IFoo {\n"
2109 " int foo() = 1;\n"
2110 " int bar();\n"
2111 " int baz() = 10;\n"
2112 "}\n");
2113
Jiyong Parke59c3682018-09-11 23:10:25 +09002114 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002115 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002116 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002117 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002119}
2120
Jooyung Han965e31d2020-11-27 12:30:16 +09002121TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2122 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2123 "package foo.bar;\n"
2124 "interface IFoo {\n"
2125 " @utf8InCpp String foo();\n"
2126 " const @utf8InCpp String bar = \"bar\";\n"
2127 "}\n");
2128
2129 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2130 Options options = Options::From(args);
2131 CaptureStderr();
2132 EXPECT_TRUE(dump_api(options, io_delegate_));
2133 EXPECT_EQ("", GetCapturedStderr());
2134 string actual;
2135 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002136 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2137interface IFoo {
2138 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002139 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002140}
2141)"),
2142 actual);
2143}
2144
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002145TEST_F(AidlTest, ApiDumpWithEnums) {
2146 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2147 "package foo.bar;\n"
2148 "enum Enum {\n"
2149 " FOO,\n"
2150 " BAR = FOO + 1,\n"
2151 "}\n");
2152
2153 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2154 Options options = Options::From(args);
2155 CaptureStderr();
2156 EXPECT_TRUE(dump_api(options, io_delegate_));
2157 EXPECT_EQ("", GetCapturedStderr());
2158 string actual;
2159 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2160 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2161 "enum Enum {\n"
2162 " FOO = 0,\n"
2163 " BAR = 1,\n"
2164 "}\n"),
2165 actual);
2166}
2167
2168TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2169 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2170 "package foo.bar;\n"
2171 "enum Enum {\n"
2172 " FOO,\n"
2173 "}\n");
2174 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2175 "package foo.bar;\n"
2176 "import foo.bar.Enum;\n"
2177 "parcelable Foo {\n"
2178 " Enum e = Enum.FOO;\n"
2179 "}\n");
2180
2181 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2182 Options options = Options::From(args);
2183 CaptureStderr();
2184 EXPECT_TRUE(dump_api(options, io_delegate_));
2185 EXPECT_EQ("", GetCapturedStderr());
2186 string actual;
2187 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2188 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2189 "parcelable Foo {\n"
2190 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2191 "}\n"),
2192 actual);
2193}
2194
Jooyung Han71dfec32021-05-23 07:18:58 +09002195TEST_F(AidlTest, ApiDumpWithGenerics) {
2196 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2197 "package foo.bar;\n"
2198 "parcelable Foo<T, U> {\n"
2199 "}\n");
2200
2201 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2202 Options options = Options::From(args);
2203 CaptureStderr();
2204 EXPECT_TRUE(dump_api(options, io_delegate_));
2205 EXPECT_EQ("", GetCapturedStderr());
2206 string actual;
2207 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2208 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2209 "parcelable Foo<T, U> {\n"
2210 "}\n"),
2211 actual);
2212}
2213
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002214TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2215 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2216 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2217
2218 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2219 Options options = Options::From(args);
2220 CaptureStderr();
2221 EXPECT_FALSE(dump_api(options, io_delegate_));
2222 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2223}
2224
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002225TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002226 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002227 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2228 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002229 const string expected_map_stderr =
2230 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002231 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2232 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002233 "package p; interface IFoo {"
2234 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002235 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002236 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002237 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002238
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002239 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002240 "package p; interface IFoo {"
2241 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002242 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002243 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002244 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002245}
2246
Jeongik Chae48d9942020-01-02 17:39:00 +09002247TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002248 const string expected_stderr =
2249 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002250 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002251 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2252
2253 io_delegate_.SetFileContents("p/IFoo.aidl",
2254 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002255 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002256 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002257
2258 io_delegate_.SetFileContents("p/IFoo.aidl",
2259 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002260 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002261 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002262 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002264
2265 io_delegate_.SetFileContents("p/IFoo.aidl",
2266 "package p; interface IFoo {"
2267 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002268 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002269
2270 io_delegate_.SetFileContents("p/IFoo.aidl",
2271 "package p; interface IFoo {"
2272 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002273 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002274}
2275
Jeongik Chadf76dc72019-11-28 00:08:47 +09002276TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002277 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002278 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2279 io_delegate_.SetFileContents(options.InputFiles().front(),
2280 "package p; interface IFoo {"
2281 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002282 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002283 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002285}
2286
2287TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002288 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002289 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002290 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002291 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002292 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2293 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002294
Jooyung Han13f1fa52021-06-11 18:06:12 +09002295 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002296 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2297 io_delegate_.SetFileContents("p/IFoo.aidl",
2298 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002299 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002300 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002301 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002302 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002303 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002304 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002305 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002306 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002307 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002308 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002309 io_delegate_.SetFileContents("p/IFoo.aidl",
2310 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002311 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002312 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002313
2314 io_delegate_.SetFileContents("p/IFoo.aidl",
2315 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002316 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002317
2318 io_delegate_.SetFileContents("p/IFoo.aidl",
2319 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002320 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002321
Steven Moreland4e059132021-08-11 13:36:30 -07002322 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002323}
2324
Jeongik Cha0e426012019-07-29 15:57:02 +09002325TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2326 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002327 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2328 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002329 for (const auto& rawOption : rawOptions) {
2330 string expected_stderr =
2331 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002332 Options options = Options::From(rawOption);
2333 io_delegate_.SetFileContents(options.InputFiles().front(),
2334 "package foo.bar;\n"
2335 "interface IFoo1 { int foo(); }\n"
2336 "interface IFoo2 { int foo(); }\n"
2337 "parcelable Data1 { int a; int b;}\n"
2338 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002339 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002340 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002341 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002342
Jeongik Cha0e426012019-07-29 15:57:02 +09002343 io_delegate_.SetFileContents(options.InputFiles().front(),
2344 "package foo.bar;\n"
2345 "interface IFoo1 { int foo(); }\n"
2346 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002347 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002348 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002349 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002350
Devin Moore5de18ed2020-04-02 13:52:29 -07002351 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002352 io_delegate_.SetFileContents(options.InputFiles().front(),
2353 "package foo.bar;\n"
2354 "parcelable Data1 { int a; int b;}\n"
2355 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002356 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002357 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002359 }
2360}
2361
Devin Moorebdba2a82020-03-31 15:19:02 -07002362TEST_P(AidlTest, FailParseOnEmptyFile) {
2363 const string contents = "";
2364 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2365 CaptureStderr();
2366 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2367 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2368}
2369
Jiyong Parkb034bf02018-07-30 17:44:33 +09002370TEST_F(AidlTest, MultipleInputFiles) {
2371 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002372 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002373
2374 io_delegate_.SetFileContents(options.InputFiles().at(0),
2375 "package foo.bar;\n"
2376 "import foo.bar.Data;\n"
2377 "interface IFoo { Data getData(); }\n");
2378
2379 io_delegate_.SetFileContents(options.InputFiles().at(1),
2380 "package foo.bar;\n"
2381 "import foo.bar.IFoo;\n"
2382 "parcelable Data { IFoo foo; }\n");
2383
Steven Moreland4e059132021-08-11 13:36:30 -07002384 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002385
2386 string content;
2387 for (const auto file : {
2388 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2389 content.clear();
2390 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2391 EXPECT_FALSE(content.empty());
2392 }
2393}
2394
2395TEST_F(AidlTest, MultipleInputFilesCpp) {
2396 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002397 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002398
2399 io_delegate_.SetFileContents(options.InputFiles().at(0),
2400 "package foo.bar;\n"
2401 "import foo.bar.Data;\n"
2402 "interface IFoo { Data getData(); }\n");
2403
2404 io_delegate_.SetFileContents(options.InputFiles().at(1),
2405 "package foo.bar;\n"
2406 "import foo.bar.IFoo;\n"
2407 "parcelable Data { IFoo foo; }\n");
2408
Steven Moreland4e059132021-08-11 13:36:30 -07002409 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002410
2411 string content;
2412 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002413 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002414 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2415 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2416 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2417 content.clear();
2418 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2419 EXPECT_FALSE(content.empty());
2420 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002421}
2422
Andrei Homescub62afd92020-05-11 19:24:59 -07002423TEST_F(AidlTest, MultipleInputFilesRust) {
2424 Options options =
2425 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2426
2427 io_delegate_.SetFileContents(options.InputFiles().at(0),
2428 "package foo.bar;\n"
2429 "import foo.bar.Data;\n"
2430 "interface IFoo { Data getData(); }\n");
2431
2432 io_delegate_.SetFileContents(options.InputFiles().at(1),
2433 "package foo.bar;\n"
2434 "import foo.bar.IFoo;\n"
2435 "parcelable Data { IFoo foo; }\n");
2436
Steven Moreland4e059132021-08-11 13:36:30 -07002437 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002438
2439 string content;
2440 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2441 content.clear();
2442 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2443 EXPECT_FALSE(content.empty());
2444 }
2445}
2446
Devin Moore097a3ab2020-03-11 16:08:44 -07002447TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2448 const string expected_stderr =
2449 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002450 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2451 // int getInterfaceVersion() is one of the meta transactions
2452 io_delegate_.SetFileContents(options.InputFiles().front(),
2453 "package p; interface IFoo {"
2454 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002456 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2458}
Jiyong Park309668e2018-07-28 16:55:44 +09002459
Devin Moore097a3ab2020-03-11 16:08:44 -07002460TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2461 // boolean getInterfaceVersion() is not a meta transaction, but should be
2462 // prevented because return type is not part of a method signature
2463 const string expected_stderr =
2464 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2465 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002466 io_delegate_.SetFileContents(options.InputFiles().front(),
2467 "package p; interface IFoo {"
2468 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002469 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002470 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002471 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2472}
Jiyong Park309668e2018-07-28 16:55:44 +09002473
Devin Moore097a3ab2020-03-11 16:08:44 -07002474TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002475 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002476 const string expected_stderr =
2477 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2478 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002479 io_delegate_.SetFileContents(options.InputFiles().front(),
2480 "package p; interface IFoo {"
2481 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002483 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002485
2486 // this is not a meta interface method as it differs type arguments
2487 io_delegate_.SetFileContents(options.InputFiles().front(),
2488 "package p; interface IFoo {"
2489 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002490 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002491}
2492
Jooyung Hanb8a97772021-01-19 01:27:38 +09002493TEST_F(AidlTest, CheckApiForEquality) {
2494 CaptureStderr();
2495 Options options = Options::From("aidl --checkapi=equal old new");
2496
2497 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2498 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2499 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2500 "package p; interface IFoo{ @utf8InCpp String foo();}");
2501
2502 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2503 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2504}
2505
Daniel Norman85aed542019-08-21 12:01:14 -07002506TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002507 Options options = Options::From("aidl --checkapi old new");
2508 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2509 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2510 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2511 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2512
2513 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2514}
2515
Jiyong Park3656c3c2018-08-01 20:02:01 +09002516TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002517 Options options = Options::From("aidl --checkapi old new");
2518 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2519 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002520
2521 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2522}
2523
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002524TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2525 Options options = Options::From("aidl --checkapi old new");
2526 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2527 const string enum_definition = "package p; enum Enum { FOO }";
2528 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2529 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2530 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2531 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2532
2533 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2534}
2535
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002536TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2537 Options options = Options::From("aidl --checkapi old new -I import");
2538
2539 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2540 io_delegate_.SetFileContents("new/p/Foo.aidl",
2541 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2542 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2543
2544 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2545}
2546
Jooyung Han02a11be2021-02-11 13:18:06 +09002547TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2548 Options options = Options::From("aidl --checkapi=equal old new");
2549 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2550 const string enum_definition = "package p; enum Enum { FOO }";
2551 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2552 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2553 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2554 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2555 CaptureStderr();
2556 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2557 EXPECT_EQ("", GetCapturedStderr());
2558}
2559
Daniel Norman85aed542019-08-21 12:01:14 -07002560class AidlTestCompatibleChanges : public AidlTest {
2561 protected:
2562 Options options_ = Options::From("aidl --checkapi old new");
2563};
2564
2565TEST_F(AidlTestCompatibleChanges, NewType) {
2566 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2567 "package p;"
2568 "interface IFoo {"
2569 " void foo(int a);"
2570 "}");
2571 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2572 "package p;"
2573 "interface IFoo {"
2574 " void foo(int a);"
2575 "}");
2576 io_delegate_.SetFileContents("new/p/IBar.aidl",
2577 "package p;"
2578 "interface IBar {"
2579 " void bar();"
2580 "}");
2581 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2582}
2583
2584TEST_F(AidlTestCompatibleChanges, NewMethod) {
2585 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2586 "package p;"
2587 "interface IFoo {"
2588 " void foo(int a);"
2589 "}");
2590 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2591 "package p;"
2592 "interface IFoo {"
2593 " void foo(int a);"
2594 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002595 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002596 "}");
2597 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2598}
2599
2600TEST_F(AidlTestCompatibleChanges, NewField) {
2601 io_delegate_.SetFileContents("old/p/Data.aidl",
2602 "package p;"
2603 "parcelable Data {"
2604 " int foo;"
2605 "}");
2606 io_delegate_.SetFileContents("new/p/Data.aidl",
2607 "package p;"
2608 "parcelable Data {"
2609 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002610 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002611 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002612 "}");
2613 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2614}
2615
Jooyung Han05bd8a82021-04-28 23:56:38 +09002616TEST_F(AidlTestCompatibleChanges, NewField2) {
2617 io_delegate_.SetFileContents("old/p/Data.aidl",
2618 "package p;"
2619 "parcelable Data {"
2620 "}");
2621 io_delegate_.SetFileContents("new/p/Data.aidl",
2622 "package p;"
2623 "parcelable Data {"
2624 " int foo = 0;"
2625 "}");
2626 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2627}
2628
Daniel Norman85aed542019-08-21 12:01:14 -07002629TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2630 io_delegate_.SetFileContents("old/p/Enum.aidl",
2631 "package p;"
2632 "enum Enum {"
2633 " FOO = 1,"
2634 "}");
2635 io_delegate_.SetFileContents("new/p/Enum.aidl",
2636 "package p;"
2637 "enum Enum {"
2638 " FOO = 1,"
2639 " BAR = 2,"
2640 "}");
2641 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2642}
2643
2644TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2645 io_delegate_.SetFileContents("old/p/Enum.aidl",
2646 "package p;"
2647 "enum Enum {"
2648 " FOO = 1,"
2649 " BAR = 2,"
2650 "}");
2651 io_delegate_.SetFileContents("new/p/Enum.aidl",
2652 "package p;"
2653 "enum Enum {"
2654 " BAR = 2,"
2655 " FOO = 1,"
2656 "}");
2657 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2658}
2659
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002660TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2661 io_delegate_.SetFileContents("old/p/Union.aidl",
2662 "package p;"
2663 "union Union {"
2664 " String foo;"
2665 "}");
2666 io_delegate_.SetFileContents("new/p/Union.aidl",
2667 "package p;"
2668 "union Union {"
2669 " String foo;"
2670 " int num;"
2671 "}");
2672 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2673}
2674
Daniel Norman85aed542019-08-21 12:01:14 -07002675TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002676 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2677 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002678 "interface IFoo {"
2679 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002680 "}");
2681 io_delegate_.SetFileContents("old/p/Data.aidl",
2682 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002683 "parcelable Data {"
2684 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002685 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002686 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2687 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002688 "interface IFoo {"
2689 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002690 "}");
2691 io_delegate_.SetFileContents("new/p/Data.aidl",
2692 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002693 "parcelable Data {"
2694 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002695 "}");
2696 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2697 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002698 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002699 " void foo(int a);"
2700 "}");
2701 io_delegate_.SetFileContents("new/q/Data.aidl",
2702 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002703 "parcelable Data {"
2704 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002705 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002706 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2707}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002708
Daniel Norman85aed542019-08-21 12:01:14 -07002709TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2710 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2711 "package p;"
2712 "interface IFoo {"
2713 " void foo(int a);"
2714 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002715 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2716 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002717 "interface IFoo {"
2718 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002719 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002720 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2721}
Jiyong Parke59c3682018-09-11 23:10:25 +09002722
Daniel Norman85aed542019-08-21 12:01:14 -07002723TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002724 io_delegate_.SetFileContents("old/p/I.aidl",
2725 "package p; interface I {"
2726 "const int A = 1; }");
2727 io_delegate_.SetFileContents("new/p/I.aidl",
2728 "package p ; interface I {"
2729 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002730 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2731}
Jiyong Parka428d212018-08-29 22:26:30 +09002732
Daniel Norman85aed542019-08-21 12:01:14 -07002733TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002734 io_delegate_.SetFileContents("old/p/I.aidl",
2735 "package p; interface I {"
2736 "const int A = 1; const int B = 2;}");
2737 io_delegate_.SetFileContents("new/p/I.aidl",
2738 "package p ; interface I {"
2739 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002740 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002741}
2742
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002743TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2744 io_delegate_.SetFileContents("old/p/Foo.aidl",
2745 "package p;"
2746 "@JavaPassthrough(annotation=\"Alice\")"
2747 "@JavaPassthrough(annotation=\"Bob\")"
2748 "parcelable Foo {}");
2749 io_delegate_.SetFileContents("new/p/Foo.aidl",
2750 "package p;"
2751 "@JavaPassthrough(annotation=\"Bob\")"
2752 "@JavaPassthrough(annotation=\"Alice\")"
2753 "parcelable Foo {}");
2754 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2755}
2756
Jooyung Han00073272020-11-27 14:20:20 +09002757TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2758 io_delegate_.SetFileContents("old/p/Foo.aidl",
2759 "package p;"
2760 "parcelable Foo {}");
2761 io_delegate_.SetFileContents("new/p/Foo.aidl",
2762 "package p;"
2763 "@JavaPassthrough(annotation=\"@Deprecated\")"
2764 "parcelable Foo {}");
2765 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2766}
2767
Jooyung Han636fd2f2020-10-22 11:33:45 +09002768TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2769 io_delegate_.SetFileContents("old/p/Data.aidl",
2770 "package p;"
2771 "parcelable Data {"
2772 " int num;"
2773 "}");
2774 io_delegate_.SetFileContents(
2775 "new/p/Data.aidl",
2776 "package p;"
2777 "parcelable Data {"
2778 " int num;"
2779 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2780 "}");
2781 io_delegate_.SetFileContents("new/p/Enum.aidl",
2782 "package p;"
2783 "enum Enum {"
2784 " FOO = 0,"
2785 " BAR = 1,"
2786 "}");
2787 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2788}
2789
Jooyung Han308bbe02021-04-27 12:09:59 +09002790TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2791 io_delegate_.SetFileContents("old/p/Data.aidl",
2792 "package p;\n"
2793 "parcelable Data {\n"
2794 " p.Enum e;\n"
2795 "}");
2796 io_delegate_.SetFileContents("old/p/Enum.aidl",
2797 "package p;\n"
2798 "enum Enum {\n"
2799 " FOO = 0,\n"
2800 " BAR = 1,\n"
2801 "}");
2802 io_delegate_.SetFileContents("new/p/Data.aidl",
2803 "package p;\n"
2804 "parcelable Data {\n"
2805 " p.Enum e = p.Enum.FOO;\n"
2806 "}");
2807 io_delegate_.SetFileContents("new/p/Enum.aidl",
2808 "package p;\n"
2809 "enum Enum {\n"
2810 " FOO = 0,\n"
2811 " BAR = 1,\n"
2812 "}");
2813 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2814}
2815
Daniel Norman85aed542019-08-21 12:01:14 -07002816class AidlTestIncompatibleChanges : public AidlTest {
2817 protected:
2818 Options options_ = Options::From("aidl --checkapi old new");
2819};
2820
2821TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002822 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002823 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2824 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002825 "interface IFoo {"
2826 " void foo(in String[] str);"
2827 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002828 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002829 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002830 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002831 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002832}
2833
2834TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002835 const string expected_stderr =
2836 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002837 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2838 "package p;"
2839 "interface IFoo {"
2840 " void foo(in String[] str);"
2841 " void bar(@utf8InCpp String str);"
2842 "}");
2843 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2844 "package p;"
2845 "interface IFoo {"
2846 " void foo(in String[] str);"
2847 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002848 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002849 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002851}
2852
Jiyong Parkf8d53612020-05-04 14:06:13 +09002853TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2854 const string expected_stderr =
2855 "ERROR: new/p/IFoo.aidl:1.61-65: "
2856 "Encountered an untyped List or Map. The use of untyped List/Map is "
2857 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2858 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2859 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2860 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2861 "package p;"
2862 "interface IFoo {"
2863 " void foo(in String[] str);"
2864 "}");
2865 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2866 "package p;"
2867 "interface IFoo {"
2868 " void foo(in String[] str);"
2869 " void bar(in List arg);"
2870 "}");
2871 CaptureStderr();
2872 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2873 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2874}
2875
2876TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2877 const string expected_stderr =
2878 "ERROR: new/p/Data.aidl:1.54-59: "
2879 "Encountered an untyped List or Map. The use of untyped List/Map is "
2880 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2881 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2882 "ERROR: new/p/Data.aidl: Failed to read.\n";
2883 io_delegate_.SetFileContents("old/p/Data.aidl",
2884 "package p;"
2885 "parcelable Data {"
2886 " int foo;"
2887 "}");
2888 io_delegate_.SetFileContents("new/p/Data.aidl",
2889 "package p;"
2890 "parcelable Data {"
2891 " int foo;"
2892 " @nullable List list;"
2893 "}");
2894 CaptureStderr();
2895 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2896 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2897}
2898
Daniel Norman85aed542019-08-21 12:01:14 -07002899TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002900 const string expected_stderr =
2901 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002902 io_delegate_.SetFileContents("old/p/Data.aidl",
2903 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002904 "parcelable Data {"
2905 " int foo;"
2906 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002907 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002908 io_delegate_.SetFileContents("new/p/Data.aidl",
2909 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002910 "parcelable Data {"
2911 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002912 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002913 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002914 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002915 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002916}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002917
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002918TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2919 const string expected_stderr =
2920 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2921 "backends. Please either provide a default value for this field or mark the field as "
2922 "@nullable. This value or a null value will be used automatically when an old version of "
2923 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2924 "order to make sure your code continues to be backwards compatible, make sure the default or "
2925 "null value does not cause a semantic change to this parcelable.\n";
2926 io_delegate_.SetFileContents("old/p/Data.aidl",
2927 "package p;"
2928 "parcelable Data {"
2929 " int num;"
2930 "}");
2931 io_delegate_.SetFileContents("new/p/Data.aidl",
2932 "package p;"
2933 "parcelable Data {"
2934 " int num;"
2935 " String str;"
2936 "}");
2937 CaptureStderr();
2938 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2940}
2941
Jooyung Han636fd2f2020-10-22 11:33:45 +09002942TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2943 const string expected_stderr =
2944 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2945 "Please make sure 'Enum' has '0' as a valid value.\n";
2946 io_delegate_.SetFileContents("old/p/Data.aidl",
2947 "package p;"
2948 "parcelable Data {"
2949 " int num;"
2950 "}");
2951 io_delegate_.SetFileContents("new/p/Data.aidl",
2952 "package p;"
2953 "parcelable Data {"
2954 " int num;"
2955 " p.Enum e;"
2956 "}");
2957 io_delegate_.SetFileContents("new/p/Enum.aidl",
2958 "package p;"
2959 "enum Enum {"
2960 " FOO = 1,"
2961 " BAR = 2,"
2962 "}");
2963 CaptureStderr();
2964 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2965 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2966}
2967
Daniel Norman85aed542019-08-21 12:01:14 -07002968TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002969 const string expected_stderr =
2970 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002971 io_delegate_.SetFileContents("old/p/Enum.aidl",
2972 "package p;"
2973 "enum Enum {"
2974 " FOO = 1,"
2975 " BAR = 2,"
2976 "}");
2977 io_delegate_.SetFileContents("new/p/Enum.aidl",
2978 "package p;"
2979 "enum Enum {"
2980 " BAR = 2,"
2981 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002982 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002983 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002984 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002985}
2986
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002987TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2988 const string expected_stderr =
2989 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2990 io_delegate_.SetFileContents("old/p/Union.aidl",
2991 "package p;"
2992 "union Union {"
2993 " String str;"
2994 " int num;"
2995 "}");
2996 io_delegate_.SetFileContents("new/p/Union.aidl",
2997 "package p;"
2998 "union Union {"
2999 " String str;"
3000 "}");
3001 CaptureStderr();
3002 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3004}
3005
Daniel Norman85aed542019-08-21 12:01:14 -07003006TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003007 const string expected_stderr =
3008 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003009 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3010 "package p;"
3011 "interface IFoo {"
3012 " void foo(in String[] str);"
3013 " void bar(@utf8InCpp String str);"
3014 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003015 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3016 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003017 "interface IFoo {"
3018 " void foo(in String[] str);"
3019 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003020 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003021 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003022 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003023 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003024}
3025
Daniel Norman85aed542019-08-21 12:01:14 -07003026TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003027 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003028 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3029 "package p;"
3030 "interface IFoo {"
3031 " void foo(in String[] str);"
3032 " void bar(@utf8InCpp String str);"
3033 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003034 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3035 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003036 "interface IFoo2 {"
3037 " void foo(in String[] str);"
3038 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003039 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003040 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003041 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003043}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003044
Daniel Norman85aed542019-08-21 12:01:14 -07003045TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003046 const string expected_stderr =
3047 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003048 io_delegate_.SetFileContents("old/p/Enum.aidl",
3049 "package p;"
3050 "enum Enum {"
3051 " FOO = 1,"
3052 " BAR = 2,"
3053 "}");
3054 io_delegate_.SetFileContents("new/p/Enum.aidl",
3055 "package p;"
3056 "enum Enum {"
3057 " FOO = 3,"
3058 " BAR = 2,"
3059 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003060 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003061 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003062 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003063}
3064
3065TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003066 const string expected_stderr =
3067 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3068 "from 0 to 1.\n"
3069 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3070 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003071 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3072 "package p;"
3073 "interface IFoo {"
3074 " void foo(in String[] str);"
3075 " void bar(@utf8InCpp String str);"
3076 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003077 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3078 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003079 "interface IFoo {"
3080 " void bar(@utf8InCpp String str);"
3081 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003082 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003083 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003084 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003085 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003086}
3087
3088TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003089 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003090 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3091 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003092 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003093 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003094 "parcelable Data {"
3095 " int foo;"
3096 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003097 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003098 io_delegate_.SetFileContents("new/p/Data.aidl",
3099 "package p;"
3100 "parcelable Data {"
3101 " int bar;"
3102 " int foo;"
3103 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003104 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003105 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003106 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003107}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003108
Daniel Norman85aed542019-08-21 12:01:14 -07003109TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003110 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003111 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003112 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003113 "interface IFoo {"
3114 " void foo(in String[] str);"
3115 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003116 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003117 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3118 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003119 "interface IFoo {"
3120 " void foo(out String[] str);"
3121 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003122 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003123 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003124 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003125 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003126}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003127
Daniel Norman85aed542019-08-21 12:01:14 -07003128TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003129 const string expected_stderr =
3130 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003131 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3132 "package p;"
3133 "interface IFoo {"
3134 " void foo(in String[] str);"
3135 " void bar(@utf8InCpp String str);"
3136 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003137 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3138 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003139 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003140 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003141 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003142 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003143 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003144 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003145 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003146}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003147
Daniel Norman85aed542019-08-21 12:01:14 -07003148TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003149 const string expected_stderr =
3150 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003151 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3152 "package p;"
3153 "interface IFoo {"
3154 " void foo(in String[] str);"
3155 " void bar(@utf8InCpp String str);"
3156 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003157 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3158 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003159 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003160 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003161 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003162 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003163 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003164 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003165 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003166}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003167
Jooyung Han60b2fde2020-10-29 15:12:40 +09003168TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3169 const string expected_stderr =
3170 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3171 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3172 io_delegate_.SetFileContents("old/p/Foo.aidl",
3173 "package p;"
3174 "@Backing(type=\"byte\")"
3175 "enum Foo {"
3176 " FOO, BAR,"
3177 "}");
3178 io_delegate_.SetFileContents("new/p/Foo.aidl",
3179 "package p;"
3180 "@Backing(type=\"long\")"
3181 "enum Foo {"
3182 " FOO, BAR,"
3183 "}");
3184 CaptureStderr();
3185 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3186 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3187}
3188
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003189TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3190 const string expected_stderr =
3191 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3192 "to @JavaPassthrough(annotation=\"Bob\")\n";
3193 io_delegate_.SetFileContents("old/p/Foo.aidl",
3194 "package p;"
3195 "@JavaPassthrough(annotation=\"Alice\")"
3196 "parcelable Foo {}");
3197 io_delegate_.SetFileContents("new/p/Foo.aidl",
3198 "package p;"
3199 "@JavaPassthrough(annotation=\"Bob\")"
3200 "parcelable Foo {}");
3201
3202 CaptureStderr();
3203 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3204 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3205}
3206
Devin Mooredb7ac512020-08-07 11:17:36 -07003207TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3208 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003209 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003210 io_delegate_.SetFileContents("old/p/Foo.aidl",
3211 "package p;"
3212 "parcelable Foo {"
3213 " int A;"
3214 "}");
3215 io_delegate_.SetFileContents("new/p/Foo.aidl",
3216 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003217 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003218 " int A;"
3219 "}");
3220 CaptureStderr();
3221 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3223}
3224
3225TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3226 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003227 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003228 io_delegate_.SetFileContents("old/p/Foo.aidl",
3229 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003230 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003231 " int A;"
3232 "}");
3233 io_delegate_.SetFileContents("new/p/Foo.aidl",
3234 "package p;"
3235 "parcelable Foo {"
3236 " int A;"
3237 "}");
3238 CaptureStderr();
3239 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3241}
3242
Daniel Norman85aed542019-08-21 12:01:14 -07003243TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003244 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003245 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3246 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003247 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003248 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003249 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003251}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003252
Daniel Norman85aed542019-08-21 12:01:14 -07003253TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003254 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003255 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3256 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003257 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003258 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003260}
Jiyong Parka428d212018-08-29 22:26:30 +09003261
Daniel Norman85aed542019-08-21 12:01:14 -07003262TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003263 const string expected_stderr =
3264 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003265 io_delegate_.SetFileContents("old/p/I.aidl",
3266 "package p; interface I {"
3267 "const int A = 1; const int B = 2;}");
3268 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003269 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003270 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003272}
Jiyong Parka428d212018-08-29 22:26:30 +09003273
Daniel Norman85aed542019-08-21 12:01:14 -07003274TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003275 const string expected_stderr =
3276 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003277 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3278 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003279 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003280 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003282}
3283
Devin Moorec7e47a32020-08-07 10:55:25 -07003284TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3285 const string expected_stderr =
3286 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3287 "This is an incompatible change for FixedSize types.\n";
3288 io_delegate_.SetFileContents("old/p/Foo.aidl",
3289 "package p; @FixedSize parcelable Foo { int A = 1; }");
3290 io_delegate_.SetFileContents("new/p/Foo.aidl",
3291 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3292 CaptureStderr();
3293 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3294 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3295}
3296
Jeongik Cha68d18e72021-04-29 20:07:01 +09003297TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3298 const string expected_stderr =
3299 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3300 "android.net.UidRangeParcel is changed from 1 to 2. "
3301 "But it is forbidden because of legacy support.\n";
3302 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3303 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3304 io_delegate_.SetFileContents(
3305 "new/android/net/UidRangeParcel.aidl",
3306 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3307 CaptureStderr();
3308 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3310}
3311
Devin Moorec7e47a32020-08-07 10:55:25 -07003312TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3313 const string expected_stderr =
3314 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3315 io_delegate_.SetFileContents("old/p/Foo.aidl",
3316 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3317 io_delegate_.SetFileContents("new/p/Foo.aidl",
3318 "package p; @FixedSize parcelable Foo { int A = 1; }");
3319 CaptureStderr();
3320 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3321 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3322}
3323
3324TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3325 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003326 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003327 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003328 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3329 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003330 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003331 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003332 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003333 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003334 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003335 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3336 "f.\n"
3337 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3338 "nullable1.\n"
3339 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3340 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003341
3342 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003343 "@FixedSize parcelable Foo {\n"
3344 " int[] a;\n"
3345 " Bar b;\n"
3346 " String c;\n"
3347 " ParcelFileDescriptor d;\n"
3348 " IBinder e;\n"
3349 " List<String> f;\n"
3350 " int isFixedSize;\n"
3351 " @nullable OtherFixed nullable1;\n"
3352 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003353 "}");
3354 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003355 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003356 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003357
3358 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003359 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003360 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3361}
3362
3363TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3364 const string expected_stderr = "";
3365
3366 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3367 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3368 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003369 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003370
3371 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003372 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3374}
3375
Jiyong Park8c380532018-08-30 14:55:26 +09003376TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003377 const string expected_stderr =
3378 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3379 "dir1/q/IBar.aidl\n"
3380 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003381 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003382 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3383 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3384 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3385 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3386
Devin Moore097a3ab2020-03-11 16:08:44 -07003387 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003388 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003389 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003390}
3391
Jiyong Parked65bf42018-08-28 15:43:27 +09003392TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003393 const string expected_stderr =
3394 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3395 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003396 Options options = Options::From("aidl --checkapi old new");
3397 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3398 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003399
3400 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3401
Jiyong Parke59c3682018-09-11 23:10:25 +09003402 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003403 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003404 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003405 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003406}
3407
Jooyung Han652ce482021-02-26 12:40:35 +09003408TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3409 Options options =
3410 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003411
3412 // use without import
3413 io_delegate_.SetFileContents("p/IFoo.aidl",
3414 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003415 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003416
3417 // capture output files
3418 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003419
Devin Moore7b8d5c92020-03-17 14:14:08 -07003420 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003421 io_delegate_.SetFileContents(
3422 "p/IFoo.aidl",
3423 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003424 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003425 // output files should be the same
3426 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003427
3428 // use with import (as before)
3429 io_delegate_.SetFileContents("p/IFoo.aidl",
3430 "package p;"
3431 "import android.os.ParcelFileDescriptor;"
3432 "interface IFoo{"
3433 " void foo(in ParcelFileDescriptor fd);"
3434 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003435 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003436 // output files should be the same
3437 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003438}
Jiyong Parked65bf42018-08-28 15:43:27 +09003439
Jooyung Han020d8d12021-02-26 17:23:02 +09003440TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3441 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3442 CaptureStderr();
3443 io_delegate_.SetFileContents("p/IFoo.aidl",
3444 "package p;"
3445 "interface IFoo{"
3446 " void foo(out ParcelFileDescriptor fd);"
3447 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003448 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003449 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3450}
3451
3452TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3453 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3454 CaptureStderr();
3455 io_delegate_.SetFileContents("p/IFoo.aidl",
3456 "package p;"
3457 "interface IFoo{"
3458 " void foo(ParcelFileDescriptor fd);"
3459 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003460 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003461 EXPECT_THAT(GetCapturedStderr(),
3462 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3463}
3464
Jiyong Park3633b722019-04-11 15:38:26 +09003465TEST_F(AidlTest, ManualIds) {
3466 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3467 io_delegate_.SetFileContents("IFoo.aidl",
3468 "interface IFoo {\n"
3469 " void foo() = 0;\n"
3470 " void bar() = 1;\n"
3471 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003472 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003473}
3474
3475TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3476 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3477 io_delegate_.SetFileContents("IFoo.aidl",
3478 "interface IFoo {\n"
3479 " void foo() = 0;\n"
3480 " void bar() = 1;\n"
3481 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003482 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003483}
3484
3485TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003486 const string expected_stderr =
3487 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003488 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3489 io_delegate_.SetFileContents("IFoo.aidl",
3490 "interface IFoo {\n"
3491 " void foo() = 3;\n"
3492 " void bar() = 3;\n"
3493 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003494 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003495 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003496 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003497}
3498
3499TEST_F(AidlTest, FailOnOutOfRangeIds) {
3500 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003501 const string expected_stderr =
3502 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3503 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003504 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3505 io_delegate_.SetFileContents("IFoo.aidl",
3506 "interface IFoo {\n"
3507 " void foo() = 3;\n"
3508 " void bar() = 16777115;\n"
3509 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003510 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003511 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003512 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003513}
3514
3515TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003516 const string expected_stderr =
3517 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003518 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3519 io_delegate_.SetFileContents("IFoo.aidl",
3520 "interface IFoo {\n"
3521 " void foo() = 3;\n"
3522 " void bar();\n"
3523 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003524 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003525 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003526 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003527}
3528
Jiyong Parkc6816252019-07-08 08:12:28 +09003529TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3530 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3531 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3532 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003533 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003534}
3535
3536TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003537 const string expected_stderr =
3538 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3539 "dir/IBar.aidl\n"
3540 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003541 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003542
Jiyong Parkc6816252019-07-08 08:12:28 +09003543 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3544 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3545 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3546 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003547 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003548 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003550}
3551
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003552TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3553 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3554 "package a.b;\n"
3555 "import a.b.IBar;\n"
3556 "import a.b.IQux;\n"
3557 "interface IFoo { IQux foo(); }\n");
3558 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3559 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3560
3561 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003562 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003563
3564 string output;
3565 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3566 // IBar was imported but wasn't used. include is not expected.
3567 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3568 // IBar was imported and used. include is expected.
3569 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3570}
3571
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003572TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003573 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003574 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003575 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3576 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003577 interface IFoo {
3578 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003579 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003580 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003581 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003582 // JavaPassthrough should work with other types as well (e.g. enum)
3583 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3584 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3585 @JavaPassthrough(annotation="@com.android.AliceTwo")
3586 @Backing(type="byte")
3587 enum MyEnum {
3588 a, b, c
3589 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003590
Jooyung Han4cde01d2020-10-13 11:10:47 +09003591 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003592 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003593
3594 string java_out;
3595 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003596 // type-decl-level annotations with newline at the end
3597 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3598 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3599 // member-decl-level annotations with newline at the end
3600 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3601 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3602 // inline annotations with space at the end
3603 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003604
Jooyung Han4cde01d2020-10-13 11:10:47 +09003605 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3606 // type-decl-level annotations with newline at the end
3607 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3608 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3609
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003610 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003611 Options cpp_options =
3612 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003613 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003614
Jooyung Han4cde01d2020-10-13 11:10:47 +09003615 Options ndk_options =
3616 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003617 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003618
Jooyung Han4cde01d2020-10-13 11:10:47 +09003619 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003620 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003621}
3622
Andrei Homescue61feb52020-08-18 15:44:24 -07003623TEST_F(AidlTest, ParseRustDerive) {
3624 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3625 @RustDerive(Clone=true, Copy=false)
3626 parcelable Foo {
3627 int a;
3628 })");
3629
3630 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003631 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003632
3633 string rust_out;
3634 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3635 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3636
3637 // Other backends shouldn't be bothered
3638 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003639 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003640
3641 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003642 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003643
3644 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003645 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003646}
3647
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003648TEST_F(AidlTest, EmptyEnforceAnnotation) {
3649 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3650 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3651 interface IFoo {
3652 @Enforce()
3653 void Protected();
3654 })");
3655
3656 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3657 CaptureStderr();
3658 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3659 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3660}
3661
3662TEST_F(AidlTest, EmptyEnforceCondition) {
3663 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3664 interface IFoo {
3665 @Enforce(condition="")
3666 void Protected();
3667 })");
3668
3669 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3670 CaptureStderr();
3671 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3672 EXPECT_THAT(GetCapturedStderr(),
3673 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3674}
3675
3676TEST_F(AidlTest, InvalidEnforceCondition) {
3677 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3678 interface IFoo {
3679 @Enforce(condition="invalid")
3680 void Protected();
3681 })");
3682
3683 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3684 CaptureStderr();
3685 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3686 EXPECT_THAT(GetCapturedStderr(),
3687 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3688}
3689
Jiyong Park56f73d72019-06-11 12:20:28 +09003690class AidlOutputPathTest : public AidlTest {
3691 protected:
3692 void SetUp() override {
3693 AidlTest::SetUp();
3694 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3695 }
3696
3697 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003698 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003699 // check the existence
3700 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3701 }
3702};
3703
3704TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3705 // <out_dir> / <package_name> / <type_name>.java
3706 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3707}
3708
3709TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3710 // when output file is explicitly set, it is always respected. -o option is
3711 // ignored.
3712 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3713}
3714
3715TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3716 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3717}
3718
3719TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3720 // output is the same as the input file except for the suffix
3721 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3722}
3723
Devin Moore7b8d5c92020-03-17 14:14:08 -07003724TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003725 AidlError error;
3726 const string expected_stderr =
3727 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3728 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003729 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3730 R"(package p;
3731 interface IFoo {
3732 const int int32_max_oob = 2147483650;
3733 }
3734 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003735 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003736 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3737 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003738}
3739
Devin Moore7b8d5c92020-03-17 14:14:08 -07003740TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003741 AidlError error;
3742 const string expected_stderr =
3743 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3744 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003745 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3746 R"(package p;
3747 interface IFoo {
3748 const int int32_min_oob = -2147483650;
3749 }
3750 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003751 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003752 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3753 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003754}
3755
Devin Moore7b8d5c92020-03-17 14:14:08 -07003756TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003757 AidlError error;
3758 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003759 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003760 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003761 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3762 R"(package p;
3763 interface IFoo {
3764 const long int64_max_oob = 21474836509999999999999999;
3765 }
3766 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003767 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003768 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3769 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003770}
3771
Devin Moore7b8d5c92020-03-17 14:14:08 -07003772TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003773 AidlError error;
3774 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003775 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003776 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003777 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3778 R"(package p;
3779 interface IFoo {
3780 const long int64_min_oob = -21474836509999999999999999;
3781 }
3782 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003783 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003784 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3785 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003786}
3787
Devin Moore7b8d5c92020-03-17 14:14:08 -07003788TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003789 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003790 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003791 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003792 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3793 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003794 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3795 R"(package p;
3796 @Backing(type="byte")
3797 enum TestEnum {
3798 FOO = 127,
3799 BAR,
3800 }
3801 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003802 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003803 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003804 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003805}
3806
Devin Mooredecaf292020-04-30 09:16:40 -07003807TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3808 AidlError error;
3809 const string expected_stderr =
3810 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003811 "be one of: type\n";
3812 CaptureStderr();
3813 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3814 R"(package p;
3815 @Backing(foo="byte")
3816 enum TestEnum {
3817 FOO = 1,
3818 BAR,
3819 }
3820 )",
3821 typenames_, GetLanguage(), &error));
3822 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3823 EXPECT_EQ(AidlError::BAD_TYPE, error);
3824}
3825
Jooyung Han5721a232020-12-24 04:34:55 +09003826TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3827 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3828 CaptureStderr();
3829 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3830 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3831}
3832
Jooyung Han66813932020-10-23 13:24:44 +09003833TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003834 io_delegate_.SetFileContents("Foo.aidl",
3835 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3836 "Map<String, Baz> d; Bar[] e; }");
3837 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3838 io_delegate_.SetFileContents("Baz.aidl",
3839 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003840 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003841 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003842}
3843
Jooyung Han66813932020-10-23 13:24:44 +09003844TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003845 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003846 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003847 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003848 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3849 "named 'bar'.\n";
3850 CaptureStderr();
3851 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003852 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003853 EXPECT_EQ(expected_error, GetCapturedStderr());
3854}
3855
Jooyung Han09e551c2021-05-11 11:44:48 +09003856TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3857 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3858 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3859 CaptureStderr();
3860 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003861 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003862 EXPECT_EQ("", GetCapturedStderr());
3863}
3864
Jooyung Han59af9cc2020-10-25 21:44:14 +09003865TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3866 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3867 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3868 string expected_error =
3869 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003870 "named 'bar'.\n";
3871 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003872 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003873 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003874 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003875}
3876
Jooyung Han66813932020-10-23 13:24:44 +09003877TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003878 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003879 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3880 string expected_error =
3881 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3882 "only be an in parameter.\n";
3883 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003884 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003885 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003886 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003887}
3888
Jooyung Han66813932020-10-23 13:24:44 +09003889TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003890 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003891 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3892 string expected_error =
3893 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3894 "only be an in parameter.\n";
3895 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003896 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003897 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003898 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003899}
3900
Jooyung Han66813932020-10-23 13:24:44 +09003901TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003902 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003903 Options options = Options::From("aidl --lang=java Foo.aidl");
3904 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003905 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3906 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003907 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003908 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3910}
Devin Moore53fc99c2020-08-12 08:07:52 -07003911
Jooyung Hanfe086af2021-01-16 03:44:47 +09003912TEST_P(AidlTest, UnionInUnion) {
3913 import_paths_.insert(".");
3914 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3915 CaptureStderr();
3916 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3917 EXPECT_THAT("", GetCapturedStderr());
3918}
3919
Jooyung Hanfe89f122020-10-14 03:49:18 +09003920TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3921 const string method = "package a; union Foo {}";
3922 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3923 CaptureStderr();
3924 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3925 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3926}
3927
3928TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3929 const string method = "package a; union Foo { ParcelableHolder x; }";
3930 const string expected_stderr =
3931 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3932 CaptureStderr();
3933 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3934 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3935}
3936
Jooyung Han53fb4242020-12-17 16:03:49 +09003937TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3938 import_paths_.insert(".");
3939 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3940 const string expected_err = "The union's first member should have a useful default value.";
3941 CaptureStderr();
3942 EXPECT_EQ(nullptr,
3943 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3944 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3945}
3946
Devin Moore53fc99c2020-08-12 08:07:52 -07003947TEST_P(AidlTest, GenericStructuredParcelable) {
3948 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003949 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003950 const string expected_stderr = "";
3951 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003952 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3954}
3955
Jooyung Han3f347ca2020-12-01 12:41:50 +09003956TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3957 io_delegate_.SetFileContents("Foo.aidl",
3958 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3959 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003960 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003961 const string expected_stderr = "";
3962 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003963 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003964 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3965
3966 string code;
3967 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3968 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3969const ::android::String16& Foo<T,U>::s() {
3970 static const ::android::String16 value(::android::String16(""));
3971 return value;
3972})--"));
3973}
3974
3975TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3976 io_delegate_.SetFileContents("Foo.aidl",
3977 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3978 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09003979 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09003980 const string expected_stderr = "";
3981 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003982 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09003983 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3984
3985 string code;
3986 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3987 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3988const char* Foo<T, U>::s = "";
3989)--"));
3990}
3991
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003992TEST_F(AidlTest, NestedTypeArgs) {
3993 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003994 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3995
3996 io_delegate_.SetFileContents("a/Foo.aidl",
3997 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3998 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003999 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4000 const string expected_stderr = "";
4001 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004002 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4004
4005 string code;
4006 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004007 EXPECT_THAT(code,
4008 testing::HasSubstr(
4009 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4010}
4011
4012TEST_F(AidlTest, DoubleArrayError) {
4013 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4014
4015 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4016 const string expected_stderr =
4017 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4018 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004019 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4021}
4022
4023TEST_F(AidlTest, DoubleGenericError) {
4024 io_delegate_.SetFileContents("a/Bar.aidl",
4025 "package a; parcelable Bar { List<String><String> a; }");
4026
4027 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4028 const string expected_stderr =
4029 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4030 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004031 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004032 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4033}
4034
4035TEST_F(AidlTest, ArrayBeforeGenericError) {
4036 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4037
4038 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004039 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004040 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004041 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4042}
4043
4044TEST_F(AidlTest, NullableArraysAreNotSupported) {
4045 io_delegate_.SetFileContents("a/Bar.aidl",
4046 "package a; parcelable Bar { String @nullable [] a; }");
4047
4048 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4049 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004050 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004051 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4052}
4053
4054TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4055 io_delegate_.SetFileContents("a/Bar.aidl",
4056 "package a; parcelable Bar { List<@nullable String> a; }");
4057
4058 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4059 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004060 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004061 EXPECT_THAT(GetCapturedStderr(),
4062 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004063}
4064
Jooyung Han14004ed2020-10-16 03:49:57 +09004065struct GenericAidlTest : ::testing::Test {
4066 FakeIoDelegate io_delegate_;
4067 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004068 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004069 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4070 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4071 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4072
4073 Options options = Options::From(cmd);
4074 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004075 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004076 EXPECT_EQ("", GetCapturedStderr());
4077 }
4078};
4079
4080TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4081 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4082 string code;
4083 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4084 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4085 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4086 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4087}
4088
4089TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4090 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4091 string code;
4092 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4093 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4094 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4095 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4096}
4097
Devin Moore53fc99c2020-08-12 08:07:52 -07004098TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4099 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004100 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004101 const string expected_stderr =
4102 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4103 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004104 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4106}
4107
4108TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4109 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004110 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004111 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4112 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004113 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004114 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4115}
4116
Jooyung Han7a308842020-10-27 19:06:49 +09004117TEST_P(AidlTest, LongCommentWithinConstExpression) {
4118 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004119 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004120 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004121 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004122 EXPECT_EQ("", GetCapturedStderr());
4123}
4124
Jeongik Chaef44e622020-10-23 16:00:52 +09004125TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4126 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4127 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4128 std::string expectedErr =
4129 "ERROR: a/Foo.aidl:1.28-30: "
4130 "Encountered an untyped List or Map. The use of untyped List/Map is "
4131 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4132 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4133 "ERROR: a/Foo.aidl:1.35-37: "
4134 "Encountered an untyped List or Map. The use of untyped List/Map is "
4135 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4136 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4137 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004138 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004139 EXPECT_EQ(expectedErr, GetCapturedStderr());
4140}
4141
4142TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004143 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4144 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004145 std::string expectedErr =
4146 "ERROR: a/Foo.aidl:1.33-35: "
4147 "Encountered an untyped List or Map. The use of untyped List/Map is "
4148 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4149 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4150 "ERROR: a/Foo.aidl:1.40-42: "
4151 "Encountered an untyped List or Map. The use of untyped List/Map is "
4152 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4153 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004154 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004155 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004156 EXPECT_EQ(expectedErr, GetCapturedStderr());
4157}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004158
Jeongik Chaef44e622020-10-23 16:00:52 +09004159TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4160 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4161 io_delegate_.SetFileContents(
4162 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4163 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4164 std::string expectedErr =
4165 "ERROR: a/Foo.aidl:1.52-54: "
4166 "Encountered an untyped List or Map. The use of untyped List/Map is "
4167 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4168 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4169 "ERROR: a/Foo.aidl:1.64-66: "
4170 "Encountered an untyped List or Map. The use of untyped List/Map is "
4171 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4172 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4173 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004174 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004175 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004176}
4177
Jooyung Han690f5842020-12-04 13:02:04 +09004178TEST_F(AidlTest, EnumWithDefaults_Java) {
4179 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4180 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4181package p;
4182import p.Enum;
4183parcelable Foo {
4184 Enum e = Enum.BAR;
4185})");
4186 CaptureStderr();
4187 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004188 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004189 auto err = GetCapturedStderr();
4190 EXPECT_EQ("", err);
4191
4192 string code;
4193 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004194 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004195}
4196
4197TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4198 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4199 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4200package p;
4201import p.Enum;
4202parcelable Foo {
4203 Enum e = Enum.BAR;
4204})");
4205 CaptureStderr();
4206 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004207 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004208 auto err = GetCapturedStderr();
4209 EXPECT_EQ("", err);
4210
4211 string code;
4212 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4213 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4214}
4215
4216TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4217 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4218 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4219package p;
4220import p.Enum;
4221parcelable Foo {
4222 Enum e = Enum.BAR;
4223})");
4224 CaptureStderr();
4225 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004226 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004227 auto err = GetCapturedStderr();
4228 EXPECT_EQ("", err);
4229
4230 string code;
4231 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4232 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4233}
4234
4235TEST_F(AidlTest, EnumWithDefaults_Rust) {
4236 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4237 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4238package p;
4239import p.Enum;
4240parcelable Foo {
4241 int n = 42;
4242 Enum e = Enum.BAR;
4243})");
4244 CaptureStderr();
4245 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004246 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004247 auto err = GetCapturedStderr();
4248 EXPECT_EQ("", err);
4249
4250 string code;
4251 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4252 EXPECT_THAT(code, testing::HasSubstr(R"(
4253 fn default() -> Self {
4254 Self {
4255 n: 42,
4256 e: crate::mangled::_1_p_4_Enum::BAR,
4257 }
4258 })"));
4259}
4260
4261TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4262 import_paths_.insert("a");
4263 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4264 CaptureStderr();
4265 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4266package p;
4267import p.Enum;
4268parcelable Foo {
4269 int e = Enum.FOO | Enum.BAR;
4270})",
4271 typenames_, GetLanguage());
4272 auto err = GetCapturedStderr();
4273 EXPECT_EQ("", err);
4274 EXPECT_TRUE(type);
4275 const auto& fields = type->AsStructuredParcelable()->GetFields();
4276 EXPECT_EQ("int e = 3", fields[0]->ToString());
4277}
4278
4279TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4280 CaptureStderr();
4281 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4282@Backing(type="int")
4283enum Foo {
4284 STANDARD_SHIFT = 16,
4285 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4286 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4287}
4288)",
4289 typenames_, GetLanguage());
4290 auto err = GetCapturedStderr();
4291 EXPECT_EQ("", err);
4292 EXPECT_TRUE(type);
4293 const auto& enum_type = type->AsEnumDeclaration();
4294 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004295 auto writer = CodeWriter::ForString(&code);
4296 DumpVisitor visitor(*writer);
4297 visitor.Visit(*enum_type);
4298 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004299 EXPECT_EQ(R"--(@Backing(type="int")
4300enum Foo {
4301 STANDARD_SHIFT = 16,
4302 STANDARD_BT709 = 65536,
4303 STANDARD_BT601_625 = 131072,
4304}
4305)--",
4306 code);
4307}
4308
4309TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4310 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4311 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4312package p;
4313import p.Enum;
4314parcelable Foo {
4315 Enum e = Enum.FOO | Enum.BAR;
4316})");
4317 CaptureStderr();
4318 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004319 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004320 auto err = GetCapturedStderr();
4321 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4322 err);
4323}
4324
Jooyung Han361cd102021-05-24 11:30:10 +09004325TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4326 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4327 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4328package p;
4329import p.Enum;
4330parcelable Foo {
4331 Enum e = 1;
4332})");
4333 CaptureStderr();
4334 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004335 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004336 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4337}
4338
Jooyung Han690f5842020-12-04 13:02:04 +09004339TEST_P(AidlTest, DefaultWithEmptyArray) {
4340 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4341 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4342 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004343 auto options =
4344 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004345 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004346 auto err = GetCapturedStderr();
4347 EXPECT_EQ("", err);
4348}
4349
4350TEST_P(AidlTest, RejectRefsInAnnotation) {
4351 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4352 "package p; interface IFoo {\n"
4353 " const String ANNOTATION = \"@Annotation\";\n"
4354 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4355 "}");
4356 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004357 auto options =
4358 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004359 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004360 auto err = GetCapturedStderr();
4361 EXPECT_EQ(
4362 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4363 "ANNOTATION.\n",
4364 err);
4365}
4366
4367TEST_F(AidlTest, DefaultWithEnumValues) {
4368 io_delegate_.SetFileContents(
4369 "a/p/Foo.aidl",
4370 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4371 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4372 CaptureStderr();
4373 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004374 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004375 auto err = GetCapturedStderr();
4376 EXPECT_EQ("", err);
4377 string code;
4378 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4379 EXPECT_THAT(
4380 code, testing::HasSubstr(
4381 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4382}
4383
Jooyung Han14259392020-12-07 10:00:08 +09004384TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4385 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4386 CaptureStderr();
4387 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004388 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004389 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004390 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004391}
4392
4393TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4394 io_delegate_.SetFileContents("a/p/Foo.aidl",
4395 "package p; parcelable Foo { const int A = A + 1; }");
4396 CaptureStderr();
4397 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004398 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004399 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004400 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4401}
4402
4403TEST_F(AidlTest, RecursiveReferences) {
4404 io_delegate_.SetFileContents("a/p/Foo.aidl",
4405 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4406 io_delegate_.SetFileContents("a/p/Bar.aidl",
4407 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4408 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4409 CaptureStderr();
4410 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004411 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004412 EXPECT_EQ("", GetCapturedStderr());
4413}
4414
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004415TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4416 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4417 auto options =
4418 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4419 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4420 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004421 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004422 EXPECT_EQ(err, GetCapturedStderr());
4423}
4424
4425TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4426 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4427 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4428 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4429 auto options =
4430 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4431 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004432 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004433 EXPECT_EQ("", GetCapturedStderr());
4434}
4435
Jooyung Hane9f5b272021-01-07 00:18:11 +09004436TEST_P(AidlTest, UnknownConstReference) {
4437 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { UnknownType field = UNKNOWN_REF; }");
4438 auto options =
4439 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4440 const string err =
4441 "ERROR: Foo.aidl:1.18-30: Failed to resolve 'UnknownType'\n"
4442 "ERROR: Foo.aidl:1.38-50: Can't find UNKNOWN_REF in Foo\n"
4443 "ERROR: Foo.aidl:1.38-50: Unknown reference 'UNKNOWN_REF'\n";
4444 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004445 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004446 EXPECT_EQ(err, GetCapturedStderr());
4447}
4448
Jooyung Han29813842020-12-08 01:28:03 +09004449TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4450 string contents = R"(
4451import android.os.IBinder;
4452import android.os.IInterface;
4453interface IFoo {}
4454 )";
4455 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004456}
4457
Jooyung Han888c5bc2020-12-22 17:28:47 +09004458TEST_P(AidlTest, WarningInterfaceName) {
4459 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004460 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004461 " -Weverything -o out -h out p/Foo.aidl");
4462 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004463 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004464 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004465 GetCapturedStderr());
4466}
4467
4468TEST_P(AidlTest, ErrorInterfaceName) {
4469 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004470 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004471 " -Weverything -Werror -o out -h out p/Foo.aidl");
4472 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004473 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004474 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004475 GetCapturedStderr());
4476}
4477
Jiyong Park9f4c3822021-04-07 20:36:45 +09004478TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4479 const std::string input_file = "base/p/q/IFoo.aidl";
4480 const std::string header_dir = "out/";
4481 const std::string output_file = "out/base/p/q/IFoo.cpp";
4482 const std::string package = "p.q"; // not base.p.q
4483 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4484
4485 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4486 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004487 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004488 EXPECT_THAT(
4489 GetCapturedStderr(),
4490 testing::StartsWith(
4491 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4492 "but is out/base/p/q/IFoo.cpp."));
4493}
4494
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004495TEST_F(AidlTest, FormatCommentsForJava) {
4496 using android::aidl::FormatCommentsForJava;
4497
4498 struct TestCase {
4499 vector<Comment> comments;
4500 string formatted;
4501 };
4502 vector<TestCase> testcases = {
4503 {{}, ""},
4504 {{{"// line comments\n"}}, "// line comments\n"},
4505 {{{"// @hide \n"}}, "// @hide \n"},
4506 // Transform the last block comment as Javadoc.
4507 {{{"/*\n"
4508 " * Hello, world!\n"
4509 " */"}},
4510 "/**\n"
4511 " * Hello, world!\n"
4512 " */"},
4513 {{{"/* @hide */"}}, "/** @hide */"},
4514 {{{"/**\n"
4515 " @param foo ...\n"
4516 "*/"}},
4517 "/**\n"
4518 " @param foo ...\n"
4519 "*/"},
4520 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4521 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4522 "/* @deprecated first *//** @deprecated second */"},
4523 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4524 // Line comments are printed as they are
4525 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4526 };
4527 for (const auto& [input, formatted] : testcases) {
4528 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4529 }
4530}
4531
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004532TEST_F(AidlTest, HideIsNotForArgs) {
4533 io_delegate_.SetFileContents("IFoo.aidl",
4534 "interface IFoo {\n"
4535 " void foo(in @Hide int x);\n"
4536 "}");
4537 auto options = Options::From("aidl --lang=java IFoo.aidl");
4538 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004539 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004540 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4541}
4542
4543TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4544 io_delegate_.SetFileContents(
4545 "IFoo.aidl",
4546 "interface IFoo {\n"
4547 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4548 "}");
4549 auto options = Options::From("aidl --lang=java IFoo.aidl");
4550 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004551 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004552 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4553}
4554
Jooyung Hanfa181932021-06-12 07:56:53 +09004555TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4556 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4557 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4558 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004559 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004560 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4561}
4562
Jooyung Hanfd3be322020-12-13 09:11:06 +09004563struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004564 string kind;
4565 string literal;
4566};
4567
Jooyung Hanfd3be322020-12-13 09:11:06 +09004568const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004569 {"primitive", "int"}, {"primitiveArray", "int[]"},
4570 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004571 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4572 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4573 {"union", "a.Union"}, {"interface", "a.IBar"},
4574};
4575
4576const std::map<std::string, std::string> kListSupportExpectations = {
4577 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4578 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4579 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4580 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004581 {"cpp_primitiveArray", "List of arrays is not supported."},
4582 {"java_primitiveArray", "List of arrays is not supported."},
4583 {"ndk_primitiveArray", "List of arrays is not supported."},
4584 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004585 {"cpp_String", ""},
4586 {"java_String", ""},
4587 {"ndk_String", ""},
4588 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004589 {"cpp_StringArray", "List of arrays is not supported."},
4590 {"java_StringArray", "List of arrays is not supported."},
4591 {"ndk_StringArray", "List of arrays is not supported."},
4592 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004593 {"cpp_IBinder", ""},
4594 {"java_IBinder", ""},
4595 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4596 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004597 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004598 {"java_ParcelFileDescriptor", ""},
4599 {"ndk_ParcelFileDescriptor", ""},
4600 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004601 {"cpp_interface", "List<a.IBar> is not supported."},
4602 {"java_interface", "List<a.IBar> is not supported."},
4603 {"ndk_interface", "List<a.IBar> is not supported."},
4604 {"rust_interface", "List<a.IBar> is not supported."},
4605 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004606 {"java_parcelable", ""},
4607 {"ndk_parcelable", ""},
4608 {"rust_parcelable", ""},
4609 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4610 {"java_enum", "A generic type cannot have any primitive type parameters."},
4611 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4612 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004613 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004614 {"java_union", ""},
4615 {"ndk_union", ""},
4616 {"rust_union", ""},
4617};
4618
Jooyung Hand236e552020-12-13 09:21:27 +09004619const std::map<std::string, std::string> kArraySupportExpectations = {
4620 {"cpp_primitive", ""},
4621 {"java_primitive", ""},
4622 {"ndk_primitive", ""},
4623 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004624 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4625 {"java_primitiveArray", "Can only have one dimensional arrays."},
4626 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4627 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004628 {"cpp_String", ""},
4629 {"java_String", ""},
4630 {"ndk_String", ""},
4631 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004632 {"cpp_StringArray", "Can only have one dimensional arrays."},
4633 {"java_StringArray", "Can only have one dimensional arrays."},
4634 {"ndk_StringArray", "Can only have one dimensional arrays."},
4635 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004636 {"cpp_IBinder", ""},
4637 {"java_IBinder", ""},
4638 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4639 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4640 {"cpp_ParcelFileDescriptor", ""},
4641 {"java_ParcelFileDescriptor", ""},
4642 {"ndk_ParcelFileDescriptor", ""},
4643 {"rust_ParcelFileDescriptor", ""},
4644 {"cpp_interface", "Binder type cannot be an array"},
4645 {"java_interface", "Binder type cannot be an array"},
4646 {"ndk_interface", "Binder type cannot be an array"},
4647 {"rust_interface", "Binder type cannot be an array"},
4648 {"cpp_parcelable", ""},
4649 {"java_parcelable", ""},
4650 {"ndk_parcelable", ""},
4651 {"rust_parcelable", ""},
4652 {"cpp_enum", ""},
4653 {"java_enum", ""},
4654 {"ndk_enum", ""},
4655 {"rust_enum", ""},
4656 {"cpp_union", ""},
4657 {"java_union", ""},
4658 {"ndk_union", ""},
4659 {"rust_union", ""},
4660};
4661
Jooyung Hanfd3be322020-12-13 09:11:06 +09004662class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004663 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004664 void Run(const std::string& generic_type_decl,
4665 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004666 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004667 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004668 const auto& kind = std::get<1>(param).kind;
4669
4670 FakeIoDelegate io;
4671 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4672 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4673 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004674 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4675 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004676
4677 const auto options =
4678 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4679 CaptureStderr();
4680 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004681 auto it = expectations.find(lang + "_" + kind);
4682 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004683 const string err = GetCapturedStderr();
4684 if (it->second.empty()) {
4685 EXPECT_EQ("", err);
4686 } else {
4687 EXPECT_THAT(err, testing::HasSubstr(it->second));
4688 }
4689 }
4690};
4691
4692INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004693 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004694 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4695 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004696 testing::ValuesIn(kTypeParams)),
4697 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004698 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004699 });
4700
Jooyung Hanfd3be322020-12-13 09:11:06 +09004701TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4702 Run("List<{}>", kListSupportExpectations);
4703}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004704
Jooyung Hand236e552020-12-13 09:21:27 +09004705TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4706 Run("{}[]", kArraySupportExpectations);
4707}
4708
Christopher Wiley90be4e32015-10-20 14:55:25 -07004709} // namespace aidl
4710} // namespace android