blob: a7f13f99bad04c60b616d3212f0eb25916a5115b [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
Jooyung Hanf8c39632021-10-05 09:56:29 +09001477TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1478 const string input_path = "p/IFoo.aidl";
1479 const string input =
1480 "package p;\n"
1481 "interface IFoo {\n"
1482 " parcelable Inner {\n"
1483 " enum Enum { A }\n"
1484 " }\n"
1485 "}";
1486 CaptureStderr();
1487 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1488 EXPECT_EQ(GetCapturedStderr(), "");
1489
1490 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1491 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1492 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1493 EXPECT_TRUE(enum_type.is_resolved);
1494 EXPECT_TRUE(inner_type.is_resolved);
1495 EXPECT_TRUE(ifoo_type.is_resolved);
1496 // GetParentType()
1497 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1498 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1499 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1500 // GetRootType()
1501 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1502 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1503 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1504 // GetDocument()
1505 auto main_document = &typenames_.MainDocument();
1506 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1507 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1508 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1509}
1510
Jooyung Han2aedb112021-09-29 09:37:59 +09001511TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1512 io_delegate_.SetFileContents("p/IOuter.aidl",
1513 "package p;\n"
1514 "interface IOuter {\n"
1515 " parcelable Inner {}\n"
1516 "}");
1517 import_paths_.emplace("");
1518 const string input_path = "p/IFoo.aidl";
1519 const string input =
1520 "package p;\n"
1521 "interface IFoo {\n"
1522 " p.IOuter.Inner get();\n"
1523 "}";
1524 CaptureStderr();
1525 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1526 EXPECT_EQ(GetCapturedStderr(), "");
1527
1528 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1529}
1530
1531TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1532 io_delegate_.SetFileContents("p/IOuter.aidl",
1533 "package p;\n"
1534 "interface IOuter {\n"
1535 " parcelable Inner {}\n"
1536 "}");
1537 import_paths_.emplace("");
1538 const string input_path = "p/IFoo.aidl";
1539 const string input =
1540 "package p;\n"
1541 "import p.IOuter.Inner;"
1542 "interface IFoo {\n"
1543 " Inner get();\n"
1544 "}";
1545 CaptureStderr();
1546 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1547 EXPECT_EQ(GetCapturedStderr(), "");
1548
1549 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1550}
1551
1552TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1553 const string input_path = "p/IFoo.aidl";
1554 const string input =
1555 "package p;\n"
1556 "interface IFoo {\n"
1557 " parcelable Result {}\n"
1558 " Result get();\n"
1559 "}";
1560 CaptureStderr();
1561 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1562 EXPECT_EQ(GetCapturedStderr(), "");
1563
1564 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1565}
1566
1567// Finding the type of nested named member.
1568struct TypeFinder : AidlVisitor {
1569 string name;
1570 const AidlTypeSpecifier* type = nullptr;
1571 TypeFinder(std::string name) : name(name) {}
1572 void Visit(const AidlVariableDeclaration& v) override {
1573 if (v.GetName() == name) {
1574 type = &v.GetType();
1575 }
1576 }
1577 void Visit(const AidlMethod& m) override {
1578 if (m.GetName() == name) {
1579 type = &m.GetType();
1580 }
1581 }
1582 static string Get(const AidlDefinedType& type, const string& name) {
1583 TypeFinder v(name);
1584 VisitTopDown(v, type);
1585 return v.type ? v.type->Signature() : "(null)";
1586 };
1587};
1588
1589TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1590 io_delegate_.SetFileContents("q/IBar.aidl",
1591 "package q;\n"
1592 "interface IBar {\n"
1593 " parcelable Baz {}\n"
1594 "}");
1595 import_paths_.emplace("");
1596 const string input_path = "p/IFoo.aidl";
1597 const string input =
1598 "package p;\n"
1599 "import q.IBar;\n"
1600 "interface IFoo {\n"
1601 " parcelable Nested {\n"
1602 " Baz t1;\n"
1603 " }\n"
1604 " parcelable Baz { }\n"
1605 " IBar.Baz t2();\n"
1606 " Baz t3();\n"
1607 "}";
1608 CaptureStderr();
1609 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1610 EXPECT_EQ(GetCapturedStderr(), "");
1611 ASSERT_NE(nullptr, foo);
1612
1613 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1614 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1615 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1616}
1617
1618TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1619 const string input_path = "p/Foo.aidl";
1620 const string input =
1621 "package p;\n"
1622 "parcelable Foo {\n"
1623 " parcelable Foo {}\n"
1624 "}";
1625 CaptureStderr();
1626 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1628}
1629
1630TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1631 const string input_path = "p/IFoo.aidl";
1632 const string input =
1633 "package p;\n"
1634 "interface IFoo {\n"
1635 " interface ICallback { void done(); }\n"
1636 " void doTask(ICallback cb);\n"
1637 "}";
1638 CaptureStderr();
1639 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1640 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1641}
1642
Jooyung Han2b1487d2021-09-30 09:57:01 +09001643TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1644 const string input_path = "p/IFoo.aidl";
1645 const string input =
1646 "package p;\n"
1647 "interface IFoo {\n"
1648 " parcelable Bar cpp_header \"Bar.h\";\n"
1649 "}";
1650 CaptureStderr();
1651 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1652 EXPECT_THAT(GetCapturedStderr(),
1653 HasSubstr("Unstructured parcelables should be at the root scope"));
1654}
1655
Jooyung Han7fc5de02021-09-30 22:26:27 +09001656TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1657 const string input_path = "p/Foo.aidl";
1658 const string input =
1659 "package p;\n"
1660 "parcelable Foo<T> {\n"
1661 " parcelable Bar {}\n"
1662 "}";
1663 CaptureStderr();
1664 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1665 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1666}
1667
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001668TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1669 const string input_path = "p/IFoo.aidl";
1670 const string input =
1671 "package p;\n"
1672 "interface IFoo {\n"
1673 " parcelable;\n" // missing identifier
1674 "}";
1675 CaptureStderr();
1676 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1677 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1678}
1679
Jooyung Han2aedb112021-09-29 09:37:59 +09001680TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1681 const string input_path = "p/Foo.aidl";
1682 const string input =
1683 "package p;\n"
1684 "interface Foo {\n"
1685 " parcelable Bar {}\n"
1686 " parcelable Bar {}\n"
1687 "}";
1688 CaptureStderr();
1689 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1690 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1691}
1692
1693TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1694 struct Failure {
1695 string err;
1696 };
1697 struct TestCase {
1698 string type;
1699 variant<string, Failure> expected; // success<0> or failure<1>
1700 };
1701 vector<TestCase> cases = {
1702 {"foo.A", "foo.A"},
1703 {"foo.A.B", "foo.A.B"},
1704 {"@nullable(heap=true) A", "foo.A.B.A"},
1705 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1706 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1707 {"B", "foo.A.B.A.B"},
1708 {"A.B", "foo.A.B.A.B"},
1709 };
1710 const string input_path = "foo/A.aidl";
1711 for (auto& [type, expected] : cases) {
1712 AidlTypenames typenames;
1713 // clang-format off
1714 const string input =
1715 "package foo;\n"
1716 "parcelable A {\n"
1717 " parcelable B {\n"
1718 " parcelable A {\n"
1719 " parcelable B {\n"
1720 " }\n"
1721 " " + type + " m;\n"
1722 " }\n"
1723 " }\n"
1724 "}";
1725 // clang-format on
1726 CaptureStderr();
1727 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1728 if (auto failure = std::get_if<Failure>(&expected); failure) {
1729 ASSERT_EQ(nullptr, foo);
1730 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1731 } else {
1732 EXPECT_EQ(GetCapturedStderr(), "");
1733 ASSERT_NE(nullptr, foo);
1734 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1735 }
1736 }
1737}
1738
Jooyung Hanca84b032021-09-30 02:15:59 +09001739TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1740 const string input_path = "p/IFoo.aidl";
1741 const string input =
1742 "package p;\n"
1743 "interface IFoo {\n"
1744 " parcelable Result {}\n"
1745 "}";
1746 CaptureStderr();
1747 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1748 ASSERT_NE(nullptr, foo);
1749 EXPECT_EQ(GetCapturedStderr(), "");
1750
1751 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1752 ASSERT_NE(nullptr, result);
1753 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1754}
1755
Jooyung Han0a950bd2021-05-15 12:50:36 +09001756TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001757 const string input_path = "p/Wrapper.aidl";
1758 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001759
1760 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1761 EXPECT_NE(nullptr, parse_result);
1762
1763 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1764 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1765 (..., params->emplace_back(std::move(type_params)));
1766 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1767 };
1768
1769 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1770 std::vector<AidlAnnotation> annotations;
Jooyung Han442cacf2021-09-13 17:44:56 +09001771 annotations.emplace_back(*AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {}));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001772 type->Annotate(std::move(annotations));
1773 return std::move(type);
1774 };
1775
1776 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1777 (void)type->SetArray();
1778 return std::move(type);
1779 };
1780
1781 auto w = type("p.Wrapper", type("String"));
1782 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1783
1784 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1785 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1786 cpp::CppNameOf(*nullable_w, typenames_));
1787
1788 auto array_w = set_array(type("p.Wrapper", type("String")));
1789 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1790 cpp::CppNameOf(*array_w, typenames_));
1791
1792 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1793 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1794 cpp::CppNameOf(*nullable_array_w, typenames_));
1795
1796 auto list_w = type("List", type("p.Wrapper", type("String")));
1797 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1798 cpp::CppNameOf(*list_w, typenames_));
1799
1800 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1801 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1802 cpp::CppNameOf(*nullable_list_w, typenames_));
1803}
1804
Devin Moore7b8d5c92020-03-17 14:14:08 -07001805TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001806 io_delegate_.SetFileContents(
1807 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001808 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001809 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001810 const string input_path = "p/IFoo.aidl";
1811 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001812 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1813 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001814 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001815 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001816 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001817
1818 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1819 // C++ understands C++ specific stuff
1820 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1821 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001822 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001823 EXPECT_EQ(1u, headers.size());
1824 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001825}
1826
Christopher Wileyf8136192016-04-12 14:19:35 -07001827TEST_F(AidlTest, WritesCorrectDependencyFile) {
1828 // While the in tree build system always gives us an output file name,
1829 // other android tools take advantage of our ability to infer the intended
1830 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001831 vector<string> args = {
1832 "aidl",
1833 "-d dep/file/path",
1834 "-o place/for/output",
1835 "p/IFoo.aidl"};
1836 Options options = Options::From(args);
1837 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001838 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001839 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001840 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001841 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1842}
1843
Dan Willemsen93298ee2016-11-10 23:55:55 -08001844TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1845 // While the in tree build system always gives us an output file name,
1846 // other android tools take advantage of our ability to infer the intended
1847 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001848 vector<string> args = {
1849 "aidl",
1850 "-d dep/file/path",
1851 "--ninja",
1852 "-o place/for/output",
1853 "p/IFoo.aidl"};
1854 Options options = Options::From(args);
1855 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001856 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001857 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001858 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001859 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1860}
1861
Jiyong Parkdf202122019-09-30 20:48:35 +09001862TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001863 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1864 // this by calling aidl with every .aidl file it finds, then parsing the
1865 // generated dependency files. Those that reference .java output files are
1866 // for interfaces and those that do not are parcelables. However, for both
1867 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001868 vector<string> args = {
1869 "aidl",
1870 "-o place/for/output",
1871 "-d dep/file/path",
1872 "p/Foo.aidl"};
1873 Options options = Options::From(args);
1874 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001875 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001876 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001877 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001878 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1879}
1880
1881TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1882 vector<string> args = {
1883 "aidl",
1884 "--structured",
1885 "-o place/for/output",
1886 "-d dep/file/path",
1887 "p/Foo.aidl"};
1888 Options options = Options::From(args);
1889 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001890 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001891 string actual_dep_file_contents;
1892 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1893 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001894}
1895
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001896TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1897 vector<string> args = {
1898 "aidl",
1899 "--lang=java",
1900 "-o place/for/output",
1901 "p/Foo.aidl"};
1902 Options options = Options::From(args);
1903 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001904 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001905 string output_file_contents;
1906 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1907}
1908
Devin Moore21b26772020-08-26 16:37:56 -07001909TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001910 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001911 const string list_array_parcelable =
1912 "package a; parcelable Foo {\n"
1913 " List[] lists; }";
1914 CaptureStderr();
1915 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1916 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1917}
1918
Jiyong Parkf8d53612020-05-04 14:06:13 +09001919TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1920 AidlError error;
1921 string expected_stderr =
1922 "ERROR: a/IFoo.aidl:2.7-11: "
1923 "Encountered an untyped List or Map. The use of untyped List/Map is "
1924 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1925 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1926 if (GetLanguage() != Options::Language::JAVA) {
1927 expected_stderr =
1928 "ERROR: a/IFoo.aidl:2.1-7: "
1929 "Currently, only the Java backend supports non-generic List.\n";
1930 }
1931
1932 const string primitive_interface =
1933 "package a; interface IFoo {\n"
1934 " List foo(); }";
1935 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001936 AidlTypenames tn1;
1937 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001938 {"--structured"}));
1939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001940
1941 string primitive_parcelable =
1942 "package a; parcelable IFoo {\n"
1943 " List foo;}";
1944 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001945 AidlTypenames tn2;
1946 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001947 {"--structured"}));
1948 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1949}
1950
Jeongik Cha225519b2020-08-29 01:55:32 +09001951TEST_P(AidlTest, ExtensionTest) {
1952 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001953 string extendable_parcelable =
1954 "package a; parcelable Data {\n"
1955 " ParcelableHolder extension;\n"
1956 " ParcelableHolder extension2;\n"
1957 "}";
Andrei Homescub2316a52021-09-04 04:41:12 +00001958 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1959 EXPECT_EQ("", GetCapturedStderr());
Jeongik Cha225519b2020-08-29 01:55:32 +09001960}
1961TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1962 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001963 string parcelableholder_return_interface =
1964 "package a; interface IFoo {\n"
1965 " ParcelableHolder foo();\n"
1966 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001967 EXPECT_EQ(nullptr,
1968 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001969
Jeongik Cha225519b2020-08-29 01:55:32 +09001970 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1971 GetCapturedStderr());
1972}
1973
1974TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1975 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001976 string extendable_parcelable_arg_interface =
1977 "package a; interface IFoo {\n"
1978 " void foo(in ParcelableHolder ph);\n"
1979 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001980 EXPECT_EQ(nullptr,
1981 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1982
Jeongik Cha225519b2020-08-29 01:55:32 +09001983 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1984 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001985}
1986
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001987TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1988 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001989 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001990 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1991 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001992 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1994}
1995
Jooyung Han3f347ca2020-12-01 12:41:50 +09001996TEST_P(AidlTest, ParcelablesWithConstants) {
1997 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09001998 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09001999 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002001 EXPECT_EQ("", GetCapturedStderr());
2002}
2003
2004TEST_P(AidlTest, UnionWithConstants) {
2005 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002006 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002007 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002008 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002009 EXPECT_EQ("", GetCapturedStderr());
2010}
2011
Jooyung Han633eab62021-01-07 14:12:40 +09002012TEST_F(AidlTest, ConstantsWithAnnotations) {
2013 io_delegate_.SetFileContents("IFoo.aidl",
2014 "interface IFoo {\n"
2015 " @JavaPassthrough(annotation=\"@Foo\")\n"
2016 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2017 "}");
2018 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2019 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002020 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002021 EXPECT_EQ("", GetCapturedStderr());
2022 string code;
2023 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2024 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2025 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2026}
2027
Jiyong Park02da7422018-07-16 16:00:26 +09002028TEST_F(AidlTest, ApiDump) {
2029 io_delegate_.SetFileContents(
2030 "foo/bar/IFoo.aidl",
2031 "package foo.bar;\n"
2032 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002033 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002034 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002035 " /* @hide applied \n"
2036 " @deprecated use foo2 */\n"
2037 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2038 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002039 " IFoo foo3(IFoo foo);\n"
2040 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002041 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002042 " /** blahblah\n"
2043 " @deprecated\n"
2044 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002045 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002046 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002047 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002048 "}\n");
2049 io_delegate_.SetFileContents("foo/bar/Data.aidl",
2050 "package foo.bar;\n"
2051 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002052 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002053 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002054 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002055 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002056 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002057 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002058 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002059 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002060 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002061 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002062 "}\n");
2063 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002064 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2065 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002066 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002067 bool result = dump_api(options, io_delegate_);
2068 ASSERT_TRUE(result);
2069 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002070 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002071 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002072interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002073 /**
2074 * @hide
2075 * @deprecated use foo2
2076 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 int foo(out int[] a, String b, boolean c, inout List<String> d);
2078 int foo2(@utf8InCpp String x, inout List<String> y);
2079 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2080 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002081 /**
2082 * @deprecated reason why...
2083 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002084 const int A = 1;
2085 const String STR = "Hello";
2086}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002087)"),
2088 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002089
Jiyong Parke59c3682018-09-11 23:10:25 +09002090 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Jooyung Han161bb0f2021-01-21 12:30:16 +09002091 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002092/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002093parcelable Data {
2094 int x = 10;
2095 int y;
2096 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002097 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002098}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002099)"),
2100 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002101}
2102
Jiyong Parked65bf42018-08-28 15:43:27 +09002103TEST_F(AidlTest, ApiDumpWithManualIds) {
2104 io_delegate_.SetFileContents(
2105 "foo/bar/IFoo.aidl",
2106 "package foo.bar;\n"
2107 "interface IFoo {\n"
2108 " int foo() = 1;\n"
2109 " int bar() = 2;\n"
2110 " int baz() = 10;\n"
2111 "}\n");
2112
Jiyong Parke59c3682018-09-11 23:10:25 +09002113 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002114 Options options = Options::From(args);
2115 bool result = dump_api(options, io_delegate_);
2116 ASSERT_TRUE(result);
2117 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002118 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002119 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002120interface IFoo {
2121 int foo() = 1;
2122 int bar() = 2;
2123 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002124}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002125)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002126}
2127
2128TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002129 const string expected_stderr =
2130 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2131 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002132 io_delegate_.SetFileContents(
2133 "foo/bar/IFoo.aidl",
2134 "package foo.bar;\n"
2135 "interface IFoo {\n"
2136 " int foo() = 1;\n"
2137 " int bar();\n"
2138 " int baz() = 10;\n"
2139 "}\n");
2140
Jiyong Parke59c3682018-09-11 23:10:25 +09002141 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002142 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002143 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002144 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002145 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002146}
2147
Jooyung Han965e31d2020-11-27 12:30:16 +09002148TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2149 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2150 "package foo.bar;\n"
2151 "interface IFoo {\n"
2152 " @utf8InCpp String foo();\n"
2153 " const @utf8InCpp String bar = \"bar\";\n"
2154 "}\n");
2155
2156 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2157 Options options = Options::From(args);
2158 CaptureStderr();
2159 EXPECT_TRUE(dump_api(options, io_delegate_));
2160 EXPECT_EQ("", GetCapturedStderr());
2161 string actual;
2162 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002163 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2164interface IFoo {
2165 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002166 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002167}
2168)"),
2169 actual);
2170}
2171
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002172TEST_F(AidlTest, ApiDumpWithEnums) {
2173 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2174 "package foo.bar;\n"
2175 "enum Enum {\n"
2176 " FOO,\n"
2177 " BAR = FOO + 1,\n"
2178 "}\n");
2179
2180 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2181 Options options = Options::From(args);
2182 CaptureStderr();
2183 EXPECT_TRUE(dump_api(options, io_delegate_));
2184 EXPECT_EQ("", GetCapturedStderr());
2185 string actual;
2186 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2187 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2188 "enum Enum {\n"
2189 " FOO = 0,\n"
2190 " BAR = 1,\n"
2191 "}\n"),
2192 actual);
2193}
2194
2195TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2196 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2197 "package foo.bar;\n"
2198 "enum Enum {\n"
2199 " FOO,\n"
2200 "}\n");
2201 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2202 "package foo.bar;\n"
2203 "import foo.bar.Enum;\n"
2204 "parcelable Foo {\n"
2205 " Enum e = Enum.FOO;\n"
2206 "}\n");
2207
2208 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2209 Options options = Options::From(args);
2210 CaptureStderr();
2211 EXPECT_TRUE(dump_api(options, io_delegate_));
2212 EXPECT_EQ("", GetCapturedStderr());
2213 string actual;
2214 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2215 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2216 "parcelable Foo {\n"
2217 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2218 "}\n"),
2219 actual);
2220}
2221
Jooyung Han71dfec32021-05-23 07:18:58 +09002222TEST_F(AidlTest, ApiDumpWithGenerics) {
2223 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2224 "package foo.bar;\n"
2225 "parcelable Foo<T, U> {\n"
2226 "}\n");
2227
2228 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2229 Options options = Options::From(args);
2230 CaptureStderr();
2231 EXPECT_TRUE(dump_api(options, io_delegate_));
2232 EXPECT_EQ("", GetCapturedStderr());
2233 string actual;
2234 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2235 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2236 "parcelable Foo<T, U> {\n"
2237 "}\n"),
2238 actual);
2239}
2240
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002241TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2242 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2243 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2244
2245 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2246 Options options = Options::From(args);
2247 CaptureStderr();
2248 EXPECT_FALSE(dump_api(options, io_delegate_));
2249 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2250}
2251
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002252TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002253 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002254 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2255 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002256 const string expected_map_stderr =
2257 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002258 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2259 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002260 "package p; interface IFoo {"
2261 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002262 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002263 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002264 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002265
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002266 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002267 "package p; interface IFoo {"
2268 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002269 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002270 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002271 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002272}
2273
Jeongik Chae48d9942020-01-02 17:39:00 +09002274TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002275 const string expected_stderr =
2276 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002277 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002278 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2279
2280 io_delegate_.SetFileContents("p/IFoo.aidl",
2281 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002282 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002283 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002284
2285 io_delegate_.SetFileContents("p/IFoo.aidl",
2286 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002287 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002288 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002289 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002290 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002291
2292 io_delegate_.SetFileContents("p/IFoo.aidl",
2293 "package p; interface IFoo {"
2294 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002295 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002296
2297 io_delegate_.SetFileContents("p/IFoo.aidl",
2298 "package p; interface IFoo {"
2299 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002300 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002301}
2302
Jeongik Chadf76dc72019-11-28 00:08:47 +09002303TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002304 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002305 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2306 io_delegate_.SetFileContents(options.InputFiles().front(),
2307 "package p; interface IFoo {"
2308 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002309 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002310 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002312}
2313
2314TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002315 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002316 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002317 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002318 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002319 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2320 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002321
Jooyung Han13f1fa52021-06-11 18:06:12 +09002322 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002323 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2324 io_delegate_.SetFileContents("p/IFoo.aidl",
2325 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002326 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002327 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002328 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002329 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002330 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002332 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002333 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002334 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002335 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002336 io_delegate_.SetFileContents("p/IFoo.aidl",
2337 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002338 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002339 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002340
2341 io_delegate_.SetFileContents("p/IFoo.aidl",
2342 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002343 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002344
2345 io_delegate_.SetFileContents("p/IFoo.aidl",
2346 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002347 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002348
Steven Moreland4e059132021-08-11 13:36:30 -07002349 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002350}
2351
Jeongik Cha0e426012019-07-29 15:57:02 +09002352TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2353 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002354 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2355 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002356 for (const auto& rawOption : rawOptions) {
2357 string expected_stderr =
2358 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002359 Options options = Options::From(rawOption);
2360 io_delegate_.SetFileContents(options.InputFiles().front(),
2361 "package foo.bar;\n"
2362 "interface IFoo1 { int foo(); }\n"
2363 "interface IFoo2 { int foo(); }\n"
2364 "parcelable Data1 { int a; int b;}\n"
2365 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002367 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002368 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002369
Jeongik Cha0e426012019-07-29 15:57:02 +09002370 io_delegate_.SetFileContents(options.InputFiles().front(),
2371 "package foo.bar;\n"
2372 "interface IFoo1 { int foo(); }\n"
2373 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002375 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002376 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002377
Devin Moore5de18ed2020-04-02 13:52:29 -07002378 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002379 io_delegate_.SetFileContents(options.InputFiles().front(),
2380 "package foo.bar;\n"
2381 "parcelable Data1 { int a; int b;}\n"
2382 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002384 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002385 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002386 }
2387}
2388
Devin Moorebdba2a82020-03-31 15:19:02 -07002389TEST_P(AidlTest, FailParseOnEmptyFile) {
2390 const string contents = "";
2391 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2392 CaptureStderr();
2393 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2394 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2395}
2396
Jiyong Parkb034bf02018-07-30 17:44:33 +09002397TEST_F(AidlTest, MultipleInputFiles) {
2398 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002399 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002400
2401 io_delegate_.SetFileContents(options.InputFiles().at(0),
2402 "package foo.bar;\n"
2403 "import foo.bar.Data;\n"
2404 "interface IFoo { Data getData(); }\n");
2405
2406 io_delegate_.SetFileContents(options.InputFiles().at(1),
2407 "package foo.bar;\n"
2408 "import foo.bar.IFoo;\n"
2409 "parcelable Data { IFoo foo; }\n");
2410
Steven Moreland4e059132021-08-11 13:36:30 -07002411 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002412
2413 string content;
2414 for (const auto file : {
2415 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2416 content.clear();
2417 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2418 EXPECT_FALSE(content.empty());
2419 }
2420}
2421
2422TEST_F(AidlTest, MultipleInputFilesCpp) {
2423 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002424 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002425
2426 io_delegate_.SetFileContents(options.InputFiles().at(0),
2427 "package foo.bar;\n"
2428 "import foo.bar.Data;\n"
2429 "interface IFoo { Data getData(); }\n");
2430
2431 io_delegate_.SetFileContents(options.InputFiles().at(1),
2432 "package foo.bar;\n"
2433 "import foo.bar.IFoo;\n"
2434 "parcelable Data { IFoo foo; }\n");
2435
Steven Moreland4e059132021-08-11 13:36:30 -07002436 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002437
2438 string content;
2439 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002440 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002441 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2442 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2443 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2444 content.clear();
2445 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2446 EXPECT_FALSE(content.empty());
2447 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002448}
2449
Andrei Homescub62afd92020-05-11 19:24:59 -07002450TEST_F(AidlTest, MultipleInputFilesRust) {
2451 Options options =
2452 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2453
2454 io_delegate_.SetFileContents(options.InputFiles().at(0),
2455 "package foo.bar;\n"
2456 "import foo.bar.Data;\n"
2457 "interface IFoo { Data getData(); }\n");
2458
2459 io_delegate_.SetFileContents(options.InputFiles().at(1),
2460 "package foo.bar;\n"
2461 "import foo.bar.IFoo;\n"
2462 "parcelable Data { IFoo foo; }\n");
2463
Steven Moreland4e059132021-08-11 13:36:30 -07002464 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002465
2466 string content;
2467 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2468 content.clear();
2469 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2470 EXPECT_FALSE(content.empty());
2471 }
2472}
2473
Devin Moore097a3ab2020-03-11 16:08:44 -07002474TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2475 const string expected_stderr =
2476 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002477 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2478 // int getInterfaceVersion() is one of the meta transactions
2479 io_delegate_.SetFileContents(options.InputFiles().front(),
2480 "package p; interface IFoo {"
2481 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002483 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2485}
Jiyong Park309668e2018-07-28 16:55:44 +09002486
Devin Moore097a3ab2020-03-11 16:08:44 -07002487TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2488 // boolean getInterfaceVersion() is not a meta transaction, but should be
2489 // prevented because return type is not part of a method signature
2490 const string expected_stderr =
2491 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2492 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002493 io_delegate_.SetFileContents(options.InputFiles().front(),
2494 "package p; interface IFoo {"
2495 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002496 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002497 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002498 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2499}
Jiyong Park309668e2018-07-28 16:55:44 +09002500
Devin Moore097a3ab2020-03-11 16:08:44 -07002501TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002502 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002503 const string expected_stderr =
2504 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2505 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002506 io_delegate_.SetFileContents(options.InputFiles().front(),
2507 "package p; interface IFoo {"
2508 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002509 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002510 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002512
2513 // this is not a meta interface method as it differs type arguments
2514 io_delegate_.SetFileContents(options.InputFiles().front(),
2515 "package p; interface IFoo {"
2516 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002517 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002518}
2519
Jooyung Hanb8a97772021-01-19 01:27:38 +09002520TEST_F(AidlTest, CheckApiForEquality) {
2521 CaptureStderr();
2522 Options options = Options::From("aidl --checkapi=equal old new");
2523
2524 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2525 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2526 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2527 "package p; interface IFoo{ @utf8InCpp String foo();}");
2528
2529 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2530 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2531}
2532
Daniel Norman85aed542019-08-21 12:01:14 -07002533TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002534 Options options = Options::From("aidl --checkapi old new");
2535 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2536 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2537 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2538 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2539
2540 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2541}
2542
Jiyong Park3656c3c2018-08-01 20:02:01 +09002543TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002544 Options options = Options::From("aidl --checkapi old new");
2545 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2546 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002547
2548 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2549}
2550
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002551TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2552 Options options = Options::From("aidl --checkapi old new");
2553 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2554 const string enum_definition = "package p; enum Enum { FOO }";
2555 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2556 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2557 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2558 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2559
2560 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2561}
2562
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002563TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2564 Options options = Options::From("aidl --checkapi old new -I import");
2565
2566 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2567 io_delegate_.SetFileContents("new/p/Foo.aidl",
2568 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2569 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2570
2571 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2572}
2573
Jooyung Han02a11be2021-02-11 13:18:06 +09002574TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2575 Options options = Options::From("aidl --checkapi=equal old new");
2576 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2577 const string enum_definition = "package p; enum Enum { FOO }";
2578 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2579 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2580 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2581 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2582 CaptureStderr();
2583 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2584 EXPECT_EQ("", GetCapturedStderr());
2585}
2586
Daniel Norman85aed542019-08-21 12:01:14 -07002587class AidlTestCompatibleChanges : public AidlTest {
2588 protected:
2589 Options options_ = Options::From("aidl --checkapi old new");
2590};
2591
2592TEST_F(AidlTestCompatibleChanges, NewType) {
2593 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2594 "package p;"
2595 "interface IFoo {"
2596 " void foo(int a);"
2597 "}");
2598 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2599 "package p;"
2600 "interface IFoo {"
2601 " void foo(int a);"
2602 "}");
2603 io_delegate_.SetFileContents("new/p/IBar.aidl",
2604 "package p;"
2605 "interface IBar {"
2606 " void bar();"
2607 "}");
2608 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2609}
2610
2611TEST_F(AidlTestCompatibleChanges, NewMethod) {
2612 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2613 "package p;"
2614 "interface IFoo {"
2615 " void foo(int a);"
2616 "}");
2617 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2618 "package p;"
2619 "interface IFoo {"
2620 " void foo(int a);"
2621 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002622 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002623 "}");
2624 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2625}
2626
2627TEST_F(AidlTestCompatibleChanges, NewField) {
2628 io_delegate_.SetFileContents("old/p/Data.aidl",
2629 "package p;"
2630 "parcelable Data {"
2631 " int foo;"
2632 "}");
2633 io_delegate_.SetFileContents("new/p/Data.aidl",
2634 "package p;"
2635 "parcelable Data {"
2636 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002637 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002638 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002639 "}");
2640 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2641}
2642
Jooyung Han05bd8a82021-04-28 23:56:38 +09002643TEST_F(AidlTestCompatibleChanges, NewField2) {
2644 io_delegate_.SetFileContents("old/p/Data.aidl",
2645 "package p;"
2646 "parcelable Data {"
2647 "}");
2648 io_delegate_.SetFileContents("new/p/Data.aidl",
2649 "package p;"
2650 "parcelable Data {"
2651 " int foo = 0;"
2652 "}");
2653 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2654}
2655
Daniel Norman85aed542019-08-21 12:01:14 -07002656TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2657 io_delegate_.SetFileContents("old/p/Enum.aidl",
2658 "package p;"
2659 "enum Enum {"
2660 " FOO = 1,"
2661 "}");
2662 io_delegate_.SetFileContents("new/p/Enum.aidl",
2663 "package p;"
2664 "enum Enum {"
2665 " FOO = 1,"
2666 " BAR = 2,"
2667 "}");
2668 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2669}
2670
2671TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2672 io_delegate_.SetFileContents("old/p/Enum.aidl",
2673 "package p;"
2674 "enum Enum {"
2675 " FOO = 1,"
2676 " BAR = 2,"
2677 "}");
2678 io_delegate_.SetFileContents("new/p/Enum.aidl",
2679 "package p;"
2680 "enum Enum {"
2681 " BAR = 2,"
2682 " FOO = 1,"
2683 "}");
2684 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2685}
2686
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002687TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2688 io_delegate_.SetFileContents("old/p/Union.aidl",
2689 "package p;"
2690 "union Union {"
2691 " String foo;"
2692 "}");
2693 io_delegate_.SetFileContents("new/p/Union.aidl",
2694 "package p;"
2695 "union Union {"
2696 " String foo;"
2697 " int num;"
2698 "}");
2699 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2700}
2701
Daniel Norman85aed542019-08-21 12:01:14 -07002702TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002703 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2704 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002705 "interface IFoo {"
2706 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002707 "}");
2708 io_delegate_.SetFileContents("old/p/Data.aidl",
2709 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002710 "parcelable Data {"
2711 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002712 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002713 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2714 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002715 "interface IFoo {"
2716 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002717 "}");
2718 io_delegate_.SetFileContents("new/p/Data.aidl",
2719 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002720 "parcelable Data {"
2721 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002722 "}");
2723 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2724 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002725 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002726 " void foo(int a);"
2727 "}");
2728 io_delegate_.SetFileContents("new/q/Data.aidl",
2729 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002730 "parcelable Data {"
2731 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002732 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002733 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2734}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002735
Daniel Norman85aed542019-08-21 12:01:14 -07002736TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2737 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2738 "package p;"
2739 "interface IFoo {"
2740 " void foo(int a);"
2741 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002742 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2743 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002744 "interface IFoo {"
2745 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002746 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002747 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2748}
Jiyong Parke59c3682018-09-11 23:10:25 +09002749
Daniel Norman85aed542019-08-21 12:01:14 -07002750TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002751 io_delegate_.SetFileContents("old/p/I.aidl",
2752 "package p; interface I {"
2753 "const int A = 1; }");
2754 io_delegate_.SetFileContents("new/p/I.aidl",
2755 "package p ; interface I {"
2756 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002757 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2758}
Jiyong Parka428d212018-08-29 22:26:30 +09002759
Daniel Norman85aed542019-08-21 12:01:14 -07002760TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002761 io_delegate_.SetFileContents("old/p/I.aidl",
2762 "package p; interface I {"
2763 "const int A = 1; const int B = 2;}");
2764 io_delegate_.SetFileContents("new/p/I.aidl",
2765 "package p ; interface I {"
2766 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002767 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002768}
2769
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002770TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2771 io_delegate_.SetFileContents("old/p/Foo.aidl",
2772 "package p;"
2773 "@JavaPassthrough(annotation=\"Alice\")"
2774 "@JavaPassthrough(annotation=\"Bob\")"
2775 "parcelable Foo {}");
2776 io_delegate_.SetFileContents("new/p/Foo.aidl",
2777 "package p;"
2778 "@JavaPassthrough(annotation=\"Bob\")"
2779 "@JavaPassthrough(annotation=\"Alice\")"
2780 "parcelable Foo {}");
2781 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2782}
2783
Jooyung Han00073272020-11-27 14:20:20 +09002784TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2785 io_delegate_.SetFileContents("old/p/Foo.aidl",
2786 "package p;"
2787 "parcelable Foo {}");
2788 io_delegate_.SetFileContents("new/p/Foo.aidl",
2789 "package p;"
2790 "@JavaPassthrough(annotation=\"@Deprecated\")"
2791 "parcelable Foo {}");
2792 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2793}
2794
Jooyung Han636fd2f2020-10-22 11:33:45 +09002795TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2796 io_delegate_.SetFileContents("old/p/Data.aidl",
2797 "package p;"
2798 "parcelable Data {"
2799 " int num;"
2800 "}");
2801 io_delegate_.SetFileContents(
2802 "new/p/Data.aidl",
2803 "package p;"
2804 "parcelable Data {"
2805 " int num;"
2806 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2807 "}");
2808 io_delegate_.SetFileContents("new/p/Enum.aidl",
2809 "package p;"
2810 "enum Enum {"
2811 " FOO = 0,"
2812 " BAR = 1,"
2813 "}");
2814 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2815}
2816
Jooyung Han308bbe02021-04-27 12:09:59 +09002817TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2818 io_delegate_.SetFileContents("old/p/Data.aidl",
2819 "package p;\n"
2820 "parcelable Data {\n"
2821 " p.Enum e;\n"
2822 "}");
2823 io_delegate_.SetFileContents("old/p/Enum.aidl",
2824 "package p;\n"
2825 "enum Enum {\n"
2826 " FOO = 0,\n"
2827 " BAR = 1,\n"
2828 "}");
2829 io_delegate_.SetFileContents("new/p/Data.aidl",
2830 "package p;\n"
2831 "parcelable Data {\n"
2832 " p.Enum e = p.Enum.FOO;\n"
2833 "}");
2834 io_delegate_.SetFileContents("new/p/Enum.aidl",
2835 "package p;\n"
2836 "enum Enum {\n"
2837 " FOO = 0,\n"
2838 " BAR = 1,\n"
2839 "}");
2840 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2841}
2842
Daniel Norman85aed542019-08-21 12:01:14 -07002843class AidlTestIncompatibleChanges : public AidlTest {
2844 protected:
2845 Options options_ = Options::From("aidl --checkapi old new");
2846};
2847
2848TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002849 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002850 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2851 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002852 "interface IFoo {"
2853 " void foo(in String[] str);"
2854 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002855 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002856 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002857 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002858 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002859}
2860
2861TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002862 const string expected_stderr =
2863 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002864 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2865 "package p;"
2866 "interface IFoo {"
2867 " void foo(in String[] str);"
2868 " void bar(@utf8InCpp String str);"
2869 "}");
2870 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2871 "package p;"
2872 "interface IFoo {"
2873 " void foo(in String[] str);"
2874 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002875 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002876 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002878}
2879
Jiyong Parkf8d53612020-05-04 14:06:13 +09002880TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2881 const string expected_stderr =
2882 "ERROR: new/p/IFoo.aidl:1.61-65: "
2883 "Encountered an untyped List or Map. The use of untyped List/Map is "
2884 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2885 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2886 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2887 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2888 "package p;"
2889 "interface IFoo {"
2890 " void foo(in String[] str);"
2891 "}");
2892 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2893 "package p;"
2894 "interface IFoo {"
2895 " void foo(in String[] str);"
2896 " void bar(in List arg);"
2897 "}");
2898 CaptureStderr();
2899 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2900 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2901}
2902
2903TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2904 const string expected_stderr =
2905 "ERROR: new/p/Data.aidl:1.54-59: "
2906 "Encountered an untyped List or Map. The use of untyped List/Map is "
2907 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2908 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2909 "ERROR: new/p/Data.aidl: Failed to read.\n";
2910 io_delegate_.SetFileContents("old/p/Data.aidl",
2911 "package p;"
2912 "parcelable Data {"
2913 " int foo;"
2914 "}");
2915 io_delegate_.SetFileContents("new/p/Data.aidl",
2916 "package p;"
2917 "parcelable Data {"
2918 " int foo;"
2919 " @nullable List list;"
2920 "}");
2921 CaptureStderr();
2922 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2923 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2924}
2925
Daniel Norman85aed542019-08-21 12:01:14 -07002926TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002927 const string expected_stderr =
2928 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002929 io_delegate_.SetFileContents("old/p/Data.aidl",
2930 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002931 "parcelable Data {"
2932 " int foo;"
2933 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002934 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002935 io_delegate_.SetFileContents("new/p/Data.aidl",
2936 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002937 "parcelable Data {"
2938 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002939 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002941 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002942 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002943}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002944
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002945TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2946 const string expected_stderr =
2947 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2948 "backends. Please either provide a default value for this field or mark the field as "
2949 "@nullable. This value or a null value will be used automatically when an old version of "
2950 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2951 "order to make sure your code continues to be backwards compatible, make sure the default or "
2952 "null value does not cause a semantic change to this parcelable.\n";
2953 io_delegate_.SetFileContents("old/p/Data.aidl",
2954 "package p;"
2955 "parcelable Data {"
2956 " int num;"
2957 "}");
2958 io_delegate_.SetFileContents("new/p/Data.aidl",
2959 "package p;"
2960 "parcelable Data {"
2961 " int num;"
2962 " String str;"
2963 "}");
2964 CaptureStderr();
2965 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2967}
2968
Jooyung Han636fd2f2020-10-22 11:33:45 +09002969TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2970 const string expected_stderr =
2971 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2972 "Please make sure 'Enum' has '0' as a valid value.\n";
2973 io_delegate_.SetFileContents("old/p/Data.aidl",
2974 "package p;"
2975 "parcelable Data {"
2976 " int num;"
2977 "}");
2978 io_delegate_.SetFileContents("new/p/Data.aidl",
2979 "package p;"
2980 "parcelable Data {"
2981 " int num;"
2982 " p.Enum e;"
2983 "}");
2984 io_delegate_.SetFileContents("new/p/Enum.aidl",
2985 "package p;"
2986 "enum Enum {"
2987 " FOO = 1,"
2988 " BAR = 2,"
2989 "}");
2990 CaptureStderr();
2991 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2992 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2993}
2994
Daniel Norman85aed542019-08-21 12:01:14 -07002995TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002996 const string expected_stderr =
2997 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002998 io_delegate_.SetFileContents("old/p/Enum.aidl",
2999 "package p;"
3000 "enum Enum {"
3001 " FOO = 1,"
3002 " BAR = 2,"
3003 "}");
3004 io_delegate_.SetFileContents("new/p/Enum.aidl",
3005 "package p;"
3006 "enum Enum {"
3007 " BAR = 2,"
3008 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003009 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003010 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003011 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003012}
3013
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003014TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3015 const string expected_stderr =
3016 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3017 io_delegate_.SetFileContents("old/p/Union.aidl",
3018 "package p;"
3019 "union Union {"
3020 " String str;"
3021 " int num;"
3022 "}");
3023 io_delegate_.SetFileContents("new/p/Union.aidl",
3024 "package p;"
3025 "union Union {"
3026 " String str;"
3027 "}");
3028 CaptureStderr();
3029 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3030 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3031}
3032
Daniel Norman85aed542019-08-21 12:01:14 -07003033TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003034 const string expected_stderr =
3035 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003036 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3037 "package p;"
3038 "interface IFoo {"
3039 " void foo(in String[] str);"
3040 " void bar(@utf8InCpp String str);"
3041 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003042 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3043 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003044 "interface IFoo {"
3045 " void foo(in String[] str);"
3046 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003047 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003048 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003049 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003050 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003051}
3052
Daniel Norman85aed542019-08-21 12:01:14 -07003053TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003054 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003055 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3056 "package p;"
3057 "interface IFoo {"
3058 " void foo(in String[] str);"
3059 " void bar(@utf8InCpp String str);"
3060 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003061 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3062 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003063 "interface IFoo2 {"
3064 " void foo(in String[] str);"
3065 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003066 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003067 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003068 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003069 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003070}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003071
Daniel Norman85aed542019-08-21 12:01:14 -07003072TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003073 const string expected_stderr =
3074 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003075 io_delegate_.SetFileContents("old/p/Enum.aidl",
3076 "package p;"
3077 "enum Enum {"
3078 " FOO = 1,"
3079 " BAR = 2,"
3080 "}");
3081 io_delegate_.SetFileContents("new/p/Enum.aidl",
3082 "package p;"
3083 "enum Enum {"
3084 " FOO = 3,"
3085 " BAR = 2,"
3086 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003087 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003088 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003090}
3091
3092TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003093 const string expected_stderr =
3094 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3095 "from 0 to 1.\n"
3096 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3097 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003098 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3099 "package p;"
3100 "interface IFoo {"
3101 " void foo(in String[] str);"
3102 " void bar(@utf8InCpp String str);"
3103 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003104 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3105 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003106 "interface IFoo {"
3107 " void bar(@utf8InCpp String str);"
3108 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003109 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003110 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003111 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003112 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003113}
3114
3115TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003116 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003117 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3118 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003119 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003120 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003121 "parcelable Data {"
3122 " int foo;"
3123 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003124 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003125 io_delegate_.SetFileContents("new/p/Data.aidl",
3126 "package p;"
3127 "parcelable Data {"
3128 " int bar;"
3129 " int foo;"
3130 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003131 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003132 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003134}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003135
Daniel Norman85aed542019-08-21 12:01:14 -07003136TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003137 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003138 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003139 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003140 "interface IFoo {"
3141 " void foo(in String[] str);"
3142 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003143 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003144 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3145 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003146 "interface IFoo {"
3147 " void foo(out String[] str);"
3148 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003149 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003150 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003151 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003153}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003154
Daniel Norman85aed542019-08-21 12:01:14 -07003155TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003156 const string expected_stderr =
3157 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003158 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3159 "package p;"
3160 "interface IFoo {"
3161 " void foo(in String[] str);"
3162 " void bar(@utf8InCpp String str);"
3163 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003164 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3165 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003166 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003167 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003168 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003169 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003170 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003171 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003172 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003173}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003174
Daniel Norman85aed542019-08-21 12:01:14 -07003175TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003176 const string expected_stderr =
3177 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003178 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3179 "package p;"
3180 "interface IFoo {"
3181 " void foo(in String[] str);"
3182 " void bar(@utf8InCpp String str);"
3183 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003184 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3185 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003186 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003187 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003188 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003189 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003190 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003191 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003193}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003194
Jooyung Han60b2fde2020-10-29 15:12:40 +09003195TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3196 const string expected_stderr =
3197 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3198 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3199 io_delegate_.SetFileContents("old/p/Foo.aidl",
3200 "package p;"
3201 "@Backing(type=\"byte\")"
3202 "enum Foo {"
3203 " FOO, BAR,"
3204 "}");
3205 io_delegate_.SetFileContents("new/p/Foo.aidl",
3206 "package p;"
3207 "@Backing(type=\"long\")"
3208 "enum Foo {"
3209 " FOO, BAR,"
3210 "}");
3211 CaptureStderr();
3212 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3213 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3214}
3215
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003216TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3217 const string expected_stderr =
3218 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3219 "to @JavaPassthrough(annotation=\"Bob\")\n";
3220 io_delegate_.SetFileContents("old/p/Foo.aidl",
3221 "package p;"
3222 "@JavaPassthrough(annotation=\"Alice\")"
3223 "parcelable Foo {}");
3224 io_delegate_.SetFileContents("new/p/Foo.aidl",
3225 "package p;"
3226 "@JavaPassthrough(annotation=\"Bob\")"
3227 "parcelable Foo {}");
3228
3229 CaptureStderr();
3230 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3231 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3232}
3233
Devin Mooredb7ac512020-08-07 11:17:36 -07003234TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3235 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003236 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003237 io_delegate_.SetFileContents("old/p/Foo.aidl",
3238 "package p;"
3239 "parcelable Foo {"
3240 " int A;"
3241 "}");
3242 io_delegate_.SetFileContents("new/p/Foo.aidl",
3243 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003244 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003245 " int A;"
3246 "}");
3247 CaptureStderr();
3248 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3250}
3251
3252TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3253 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003254 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003255 io_delegate_.SetFileContents("old/p/Foo.aidl",
3256 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003257 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003258 " int A;"
3259 "}");
3260 io_delegate_.SetFileContents("new/p/Foo.aidl",
3261 "package p;"
3262 "parcelable Foo {"
3263 " int A;"
3264 "}");
3265 CaptureStderr();
3266 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3267 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3268}
3269
Daniel Norman85aed542019-08-21 12:01:14 -07003270TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003271 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003272 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3273 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003274 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003275 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003276 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003277 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003278}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003279
Daniel Norman85aed542019-08-21 12:01:14 -07003280TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003281 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003282 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3283 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003284 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003285 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003286 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003287}
Jiyong Parka428d212018-08-29 22:26:30 +09003288
Daniel Norman85aed542019-08-21 12:01:14 -07003289TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003290 const string expected_stderr =
3291 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003292 io_delegate_.SetFileContents("old/p/I.aidl",
3293 "package p; interface I {"
3294 "const int A = 1; const int B = 2;}");
3295 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003296 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003297 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003298 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003299}
Jiyong Parka428d212018-08-29 22:26:30 +09003300
Daniel Norman85aed542019-08-21 12:01:14 -07003301TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003302 const string expected_stderr =
3303 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003304 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3305 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003306 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003307 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003308 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003309}
3310
Devin Moorec7e47a32020-08-07 10:55:25 -07003311TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3312 const string expected_stderr =
3313 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3314 "This is an incompatible change for FixedSize types.\n";
3315 io_delegate_.SetFileContents("old/p/Foo.aidl",
3316 "package p; @FixedSize parcelable Foo { int A = 1; }");
3317 io_delegate_.SetFileContents("new/p/Foo.aidl",
3318 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3319 CaptureStderr();
3320 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3321 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3322}
3323
Jeongik Cha68d18e72021-04-29 20:07:01 +09003324TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3325 const string expected_stderr =
3326 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3327 "android.net.UidRangeParcel is changed from 1 to 2. "
3328 "But it is forbidden because of legacy support.\n";
3329 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3330 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3331 io_delegate_.SetFileContents(
3332 "new/android/net/UidRangeParcel.aidl",
3333 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3334 CaptureStderr();
3335 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3336 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3337}
3338
Devin Moorec7e47a32020-08-07 10:55:25 -07003339TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3340 const string expected_stderr =
3341 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3342 io_delegate_.SetFileContents("old/p/Foo.aidl",
3343 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3344 io_delegate_.SetFileContents("new/p/Foo.aidl",
3345 "package p; @FixedSize parcelable Foo { int A = 1; }");
3346 CaptureStderr();
3347 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3348 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3349}
3350
3351TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3352 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003353 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003354 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003355 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3356 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003357 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003358 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003359 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003360 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003361 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003362 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3363 "f.\n"
3364 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3365 "nullable1.\n"
3366 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3367 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003368
3369 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003370 "@FixedSize parcelable Foo {\n"
3371 " int[] a;\n"
3372 " Bar b;\n"
3373 " String c;\n"
3374 " ParcelFileDescriptor d;\n"
3375 " IBinder e;\n"
3376 " List<String> f;\n"
3377 " int isFixedSize;\n"
3378 " @nullable OtherFixed nullable1;\n"
3379 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003380 "}");
3381 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003382 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003383 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003384
3385 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003386 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003387 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3388}
3389
3390TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3391 const string expected_stderr = "";
3392
3393 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3394 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3395 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003396 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003397
3398 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003399 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003400 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3401}
3402
Jiyong Park8c380532018-08-30 14:55:26 +09003403TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003404 const string expected_stderr =
3405 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3406 "dir1/q/IBar.aidl\n"
3407 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003408 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003409 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3410 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3411 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3412 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3413
Devin Moore097a3ab2020-03-11 16:08:44 -07003414 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003415 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003417}
3418
Jiyong Parked65bf42018-08-28 15:43:27 +09003419TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003420 const string expected_stderr =
3421 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3422 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003423 Options options = Options::From("aidl --checkapi old new");
3424 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3425 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003426
3427 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3428
Jiyong Parke59c3682018-09-11 23:10:25 +09003429 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003430 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003431 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003432 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003433}
3434
Jooyung Han652ce482021-02-26 12:40:35 +09003435TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3436 Options options =
3437 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003438
3439 // use without import
3440 io_delegate_.SetFileContents("p/IFoo.aidl",
3441 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003442 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003443
3444 // capture output files
3445 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003446
Devin Moore7b8d5c92020-03-17 14:14:08 -07003447 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003448 io_delegate_.SetFileContents(
3449 "p/IFoo.aidl",
3450 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003451 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003452 // output files should be the same
3453 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003454
3455 // use with import (as before)
3456 io_delegate_.SetFileContents("p/IFoo.aidl",
3457 "package p;"
3458 "import android.os.ParcelFileDescriptor;"
3459 "interface IFoo{"
3460 " void foo(in ParcelFileDescriptor fd);"
3461 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003462 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003463 // output files should be the same
3464 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003465}
Jiyong Parked65bf42018-08-28 15:43:27 +09003466
Jooyung Han020d8d12021-02-26 17:23:02 +09003467TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3468 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3469 CaptureStderr();
3470 io_delegate_.SetFileContents("p/IFoo.aidl",
3471 "package p;"
3472 "interface IFoo{"
3473 " void foo(out ParcelFileDescriptor fd);"
3474 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003475 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003476 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3477}
3478
3479TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3480 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3481 CaptureStderr();
3482 io_delegate_.SetFileContents("p/IFoo.aidl",
3483 "package p;"
3484 "interface IFoo{"
3485 " void foo(ParcelFileDescriptor fd);"
3486 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003487 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003488 EXPECT_THAT(GetCapturedStderr(),
3489 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3490}
3491
Jiyong Park3633b722019-04-11 15:38:26 +09003492TEST_F(AidlTest, ManualIds) {
3493 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3494 io_delegate_.SetFileContents("IFoo.aidl",
3495 "interface IFoo {\n"
3496 " void foo() = 0;\n"
3497 " void bar() = 1;\n"
3498 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003499 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003500}
3501
3502TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3503 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3504 io_delegate_.SetFileContents("IFoo.aidl",
3505 "interface IFoo {\n"
3506 " void foo() = 0;\n"
3507 " void bar() = 1;\n"
3508 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003509 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003510}
3511
3512TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003513 const string expected_stderr =
3514 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003515 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3516 io_delegate_.SetFileContents("IFoo.aidl",
3517 "interface IFoo {\n"
3518 " void foo() = 3;\n"
3519 " void bar() = 3;\n"
3520 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003521 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003522 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003523 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003524}
3525
3526TEST_F(AidlTest, FailOnOutOfRangeIds) {
3527 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003528 const string expected_stderr =
3529 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3530 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003531 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3532 io_delegate_.SetFileContents("IFoo.aidl",
3533 "interface IFoo {\n"
3534 " void foo() = 3;\n"
3535 " void bar() = 16777115;\n"
3536 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003537 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003538 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003540}
3541
3542TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003543 const string expected_stderr =
3544 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003545 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3546 io_delegate_.SetFileContents("IFoo.aidl",
3547 "interface IFoo {\n"
3548 " void foo() = 3;\n"
3549 " void bar();\n"
3550 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003551 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003552 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003553 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003554}
3555
Jiyong Parkc6816252019-07-08 08:12:28 +09003556TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3557 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3558 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3559 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003560 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003561}
3562
3563TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003564 const string expected_stderr =
3565 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3566 "dir/IBar.aidl\n"
3567 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003568 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003569
Jiyong Parkc6816252019-07-08 08:12:28 +09003570 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3571 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3572 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3573 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003574 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003575 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003577}
3578
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003579TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3580 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3581 "package a.b;\n"
3582 "import a.b.IBar;\n"
3583 "import a.b.IQux;\n"
3584 "interface IFoo { IQux foo(); }\n");
3585 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3586 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3587
3588 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003589 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003590
3591 string output;
3592 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3593 // IBar was imported but wasn't used. include is not expected.
3594 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3595 // IBar was imported and used. include is expected.
3596 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3597}
3598
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003599TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003600 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003601 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003602 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3603 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003604 interface IFoo {
3605 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003606 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003607 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003608 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003609 // JavaPassthrough should work with other types as well (e.g. enum)
3610 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3611 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3612 @JavaPassthrough(annotation="@com.android.AliceTwo")
3613 @Backing(type="byte")
3614 enum MyEnum {
3615 a, b, c
3616 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003617
Jooyung Han4cde01d2020-10-13 11:10:47 +09003618 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003619 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003620
3621 string java_out;
3622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003623 // type-decl-level annotations with newline at the end
3624 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3625 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3626 // member-decl-level annotations with newline at the end
3627 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3628 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3629 // inline annotations with space at the end
3630 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003631
Jooyung Han4cde01d2020-10-13 11:10:47 +09003632 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3633 // type-decl-level annotations with newline at the end
3634 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3635 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3636
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003637 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003638 Options cpp_options =
3639 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003640 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003641
Jooyung Han4cde01d2020-10-13 11:10:47 +09003642 Options ndk_options =
3643 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003644 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003645
Jooyung Han4cde01d2020-10-13 11:10:47 +09003646 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003647 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003648}
3649
Andrei Homescue61feb52020-08-18 15:44:24 -07003650TEST_F(AidlTest, ParseRustDerive) {
3651 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3652 @RustDerive(Clone=true, Copy=false)
3653 parcelable Foo {
3654 int a;
3655 })");
3656
3657 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003658 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003659
3660 string rust_out;
3661 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3662 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3663
3664 // Other backends shouldn't be bothered
3665 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003666 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003667
3668 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003669 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003670
3671 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003672 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003673}
3674
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003675TEST_F(AidlTest, EmptyEnforceAnnotation) {
3676 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3677 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3678 interface IFoo {
3679 @Enforce()
3680 void Protected();
3681 })");
3682
3683 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3684 CaptureStderr();
3685 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3686 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3687}
3688
3689TEST_F(AidlTest, EmptyEnforceCondition) {
3690 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3691 interface IFoo {
3692 @Enforce(condition="")
3693 void Protected();
3694 })");
3695
3696 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3697 CaptureStderr();
3698 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3699 EXPECT_THAT(GetCapturedStderr(),
3700 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3701}
3702
3703TEST_F(AidlTest, InvalidEnforceCondition) {
3704 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3705 interface IFoo {
3706 @Enforce(condition="invalid")
3707 void Protected();
3708 })");
3709
3710 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3711 CaptureStderr();
3712 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3713 EXPECT_THAT(GetCapturedStderr(),
3714 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3715}
3716
Jiyong Park56f73d72019-06-11 12:20:28 +09003717class AidlOutputPathTest : public AidlTest {
3718 protected:
3719 void SetUp() override {
3720 AidlTest::SetUp();
3721 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3722 }
3723
3724 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003725 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003726 // check the existence
3727 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3728 }
3729};
3730
3731TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3732 // <out_dir> / <package_name> / <type_name>.java
3733 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3734}
3735
3736TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3737 // when output file is explicitly set, it is always respected. -o option is
3738 // ignored.
3739 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3740}
3741
3742TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3743 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3744}
3745
3746TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3747 // output is the same as the input file except for the suffix
3748 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3749}
3750
Devin Moore7b8d5c92020-03-17 14:14:08 -07003751TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003752 AidlError error;
3753 const string expected_stderr =
3754 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3755 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003756 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3757 R"(package p;
3758 interface IFoo {
3759 const int int32_max_oob = 2147483650;
3760 }
3761 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003762 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003763 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3764 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003765}
3766
Devin Moore7b8d5c92020-03-17 14:14:08 -07003767TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003768 AidlError error;
3769 const string expected_stderr =
3770 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3771 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003772 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3773 R"(package p;
3774 interface IFoo {
3775 const int int32_min_oob = -2147483650;
3776 }
3777 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003778 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003779 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3780 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003781}
3782
Devin Moore7b8d5c92020-03-17 14:14:08 -07003783TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003784 AidlError error;
3785 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003786 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003787 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003788 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3789 R"(package p;
3790 interface IFoo {
3791 const long int64_max_oob = 21474836509999999999999999;
3792 }
3793 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003794 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003795 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3796 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003797}
3798
Devin Moore7b8d5c92020-03-17 14:14:08 -07003799TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003800 AidlError error;
3801 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003802 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003803 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003804 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3805 R"(package p;
3806 interface IFoo {
3807 const long int64_min_oob = -21474836509999999999999999;
3808 }
3809 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003810 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003811 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3812 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003813}
3814
Devin Moore7b8d5c92020-03-17 14:14:08 -07003815TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003816 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003817 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003818 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003819 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3820 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003821 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3822 R"(package p;
3823 @Backing(type="byte")
3824 enum TestEnum {
3825 FOO = 127,
3826 BAR,
3827 }
3828 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003829 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003830 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003831 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003832}
3833
Steven Morelandb248d072021-09-29 19:07:17 -07003834TEST_P(AidlTest, FailOnUnsupportedBackingType) {
3835 AidlError error;
3836 const string expected_stderr =
3837 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
3838 "byte, int, long\n";
3839 CaptureStderr();
3840 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3841 R"(package p;
3842 @Backing(type="boolean")
3843 enum TestEnum {
3844 FOO = 0,
3845 BAR = 1,
3846 }
3847 )",
3848 typenames_, GetLanguage(), &error));
3849 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3850 EXPECT_EQ(AidlError::BAD_TYPE, error);
3851}
3852
Devin Mooredecaf292020-04-30 09:16:40 -07003853TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3854 AidlError error;
3855 const string expected_stderr =
3856 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003857 "be one of: type\n";
3858 CaptureStderr();
3859 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3860 R"(package p;
3861 @Backing(foo="byte")
3862 enum TestEnum {
3863 FOO = 1,
3864 BAR,
3865 }
3866 )",
3867 typenames_, GetLanguage(), &error));
3868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3869 EXPECT_EQ(AidlError::BAD_TYPE, error);
3870}
3871
Jooyung Han5721a232020-12-24 04:34:55 +09003872TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3873 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3874 CaptureStderr();
3875 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3876 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3877}
3878
Jooyung Han66813932020-10-23 13:24:44 +09003879TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003880 io_delegate_.SetFileContents("Foo.aidl",
3881 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3882 "Map<String, Baz> d; Bar[] e; }");
3883 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3884 io_delegate_.SetFileContents("Baz.aidl",
3885 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003886 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003887 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003888}
3889
Jooyung Han66813932020-10-23 13:24:44 +09003890TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003891 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003892 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003893 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003894 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3895 "named 'bar'.\n";
3896 CaptureStderr();
3897 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003898 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003899 EXPECT_EQ(expected_error, GetCapturedStderr());
3900}
3901
Jooyung Han09e551c2021-05-11 11:44:48 +09003902TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3903 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3904 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3905 CaptureStderr();
3906 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003907 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003908 EXPECT_EQ("", GetCapturedStderr());
3909}
3910
Jooyung Han59af9cc2020-10-25 21:44:14 +09003911TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3912 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3913 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3914 string expected_error =
3915 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003916 "named 'bar'.\n";
3917 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003918 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003919 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003920 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003921}
3922
Jooyung Han66813932020-10-23 13:24:44 +09003923TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003924 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003925 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3926 string expected_error =
3927 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3928 "only be an in parameter.\n";
3929 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003930 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003931 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003932 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003933}
3934
Jooyung Han66813932020-10-23 13:24:44 +09003935TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003936 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003937 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3938 string expected_error =
3939 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3940 "only be an in parameter.\n";
3941 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003942 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003943 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003944 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003945}
3946
Jooyung Han66813932020-10-23 13:24:44 +09003947TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003948 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003949 Options options = Options::From("aidl --lang=java Foo.aidl");
3950 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003951 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3952 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003953 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003954 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09003955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3956}
Devin Moore53fc99c2020-08-12 08:07:52 -07003957
Jooyung Hanfe086af2021-01-16 03:44:47 +09003958TEST_P(AidlTest, UnionInUnion) {
3959 import_paths_.insert(".");
3960 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
3961 CaptureStderr();
3962 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
3963 EXPECT_THAT("", GetCapturedStderr());
3964}
3965
Jooyung Hanfe89f122020-10-14 03:49:18 +09003966TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3967 const string method = "package a; union Foo {}";
3968 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3969 CaptureStderr();
3970 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3971 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3972}
3973
3974TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3975 const string method = "package a; union Foo { ParcelableHolder x; }";
3976 const string expected_stderr =
3977 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3978 CaptureStderr();
3979 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3980 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3981}
3982
Jooyung Han53fb4242020-12-17 16:03:49 +09003983TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3984 import_paths_.insert(".");
3985 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3986 const string expected_err = "The union's first member should have a useful default value.";
3987 CaptureStderr();
3988 EXPECT_EQ(nullptr,
3989 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3990 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3991}
3992
Devin Moore53fc99c2020-08-12 08:07:52 -07003993TEST_P(AidlTest, GenericStructuredParcelable) {
3994 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003995 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07003996 const string expected_stderr = "";
3997 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003998 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07003999 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4000}
4001
Jooyung Han3f347ca2020-12-01 12:41:50 +09004002TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4003 io_delegate_.SetFileContents("Foo.aidl",
4004 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4005 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004006 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004007 const string expected_stderr = "";
4008 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004009 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004010 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4011
4012 string code;
4013 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4014 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4015const ::android::String16& Foo<T,U>::s() {
4016 static const ::android::String16 value(::android::String16(""));
4017 return value;
4018})--"));
4019}
4020
4021TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4022 io_delegate_.SetFileContents("Foo.aidl",
4023 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4024 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004025 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004026 const string expected_stderr = "";
4027 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004028 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004029 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4030
4031 string code;
4032 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4033 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4034const char* Foo<T, U>::s = "";
4035)--"));
4036}
4037
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004038TEST_F(AidlTest, NestedTypeArgs) {
4039 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004040 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4041
4042 io_delegate_.SetFileContents("a/Foo.aidl",
4043 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4044 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004045 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4046 const string expected_stderr = "";
4047 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004048 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004049 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4050
4051 string code;
4052 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004053 EXPECT_THAT(code,
4054 testing::HasSubstr(
4055 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4056}
4057
4058TEST_F(AidlTest, DoubleArrayError) {
4059 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4060
4061 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4062 const string expected_stderr =
4063 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4064 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004065 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004066 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4067}
4068
4069TEST_F(AidlTest, DoubleGenericError) {
4070 io_delegate_.SetFileContents("a/Bar.aidl",
4071 "package a; parcelable Bar { List<String><String> a; }");
4072
4073 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4074 const string expected_stderr =
4075 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4076 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004077 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004078 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4079}
4080
4081TEST_F(AidlTest, ArrayBeforeGenericError) {
4082 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4083
4084 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004085 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004086 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004087 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4088}
4089
4090TEST_F(AidlTest, NullableArraysAreNotSupported) {
4091 io_delegate_.SetFileContents("a/Bar.aidl",
4092 "package a; parcelable Bar { String @nullable [] a; }");
4093
4094 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4095 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004096 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004097 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4098}
4099
4100TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4101 io_delegate_.SetFileContents("a/Bar.aidl",
4102 "package a; parcelable Bar { List<@nullable String> a; }");
4103
4104 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4105 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004106 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004107 EXPECT_THAT(GetCapturedStderr(),
4108 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004109}
4110
Jooyung Han14004ed2020-10-16 03:49:57 +09004111struct GenericAidlTest : ::testing::Test {
4112 FakeIoDelegate io_delegate_;
4113 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004114 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004115 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4116 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4117 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4118
4119 Options options = Options::From(cmd);
4120 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004121 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004122 EXPECT_EQ("", GetCapturedStderr());
4123 }
4124};
4125
4126TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4127 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4128 string code;
4129 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4130 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4131 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4132 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4133}
4134
4135TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4136 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4137 string code;
4138 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4139 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4140 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4141 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4142}
4143
Devin Moore53fc99c2020-08-12 08:07:52 -07004144TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4145 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004146 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004147 const string expected_stderr =
4148 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4149 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004150 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004151 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4152}
4153
4154TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4155 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004156 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004157 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4158 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004159 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004160 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4161}
4162
Jooyung Han7a308842020-10-27 19:06:49 +09004163TEST_P(AidlTest, LongCommentWithinConstExpression) {
4164 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004165 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004166 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004167 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004168 EXPECT_EQ("", GetCapturedStderr());
4169}
4170
Jeongik Chaef44e622020-10-23 16:00:52 +09004171TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4172 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4173 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4174 std::string expectedErr =
4175 "ERROR: a/Foo.aidl:1.28-30: "
4176 "Encountered an untyped List or Map. The use of untyped List/Map is "
4177 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4178 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4179 "ERROR: a/Foo.aidl:1.35-37: "
4180 "Encountered an untyped List or Map. The use of untyped List/Map is "
4181 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4182 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4183 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004184 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004185 EXPECT_EQ(expectedErr, GetCapturedStderr());
4186}
4187
4188TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004189 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4190 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004191 std::string expectedErr =
4192 "ERROR: a/Foo.aidl:1.33-35: "
4193 "Encountered an untyped List or Map. The use of untyped List/Map is "
4194 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4195 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4196 "ERROR: a/Foo.aidl:1.40-42: "
4197 "Encountered an untyped List or Map. The use of untyped List/Map is "
4198 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4199 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004201 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004202 EXPECT_EQ(expectedErr, GetCapturedStderr());
4203}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004204
Jeongik Chaef44e622020-10-23 16:00:52 +09004205TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4206 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4207 io_delegate_.SetFileContents(
4208 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4209 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4210 std::string expectedErr =
4211 "ERROR: a/Foo.aidl:1.52-54: "
4212 "Encountered an untyped List or Map. The use of untyped List/Map is "
4213 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4214 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4215 "ERROR: a/Foo.aidl:1.64-66: "
4216 "Encountered an untyped List or Map. The use of untyped List/Map is "
4217 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4218 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4219 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004220 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004221 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004222}
4223
Jooyung Han690f5842020-12-04 13:02:04 +09004224TEST_F(AidlTest, EnumWithDefaults_Java) {
4225 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4226 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4227package p;
4228import p.Enum;
4229parcelable Foo {
4230 Enum e = Enum.BAR;
4231})");
4232 CaptureStderr();
4233 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004234 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004235 auto err = GetCapturedStderr();
4236 EXPECT_EQ("", err);
4237
4238 string code;
4239 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004240 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004241}
4242
4243TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4244 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4245 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4246package p;
4247import p.Enum;
4248parcelable Foo {
4249 Enum e = Enum.BAR;
4250})");
4251 CaptureStderr();
4252 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004253 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004254 auto err = GetCapturedStderr();
4255 EXPECT_EQ("", err);
4256
4257 string code;
4258 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4259 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4260}
4261
4262TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4263 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4264 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4265package p;
4266import p.Enum;
4267parcelable Foo {
4268 Enum e = Enum.BAR;
4269})");
4270 CaptureStderr();
4271 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004272 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004273 auto err = GetCapturedStderr();
4274 EXPECT_EQ("", err);
4275
4276 string code;
4277 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4278 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4279}
4280
4281TEST_F(AidlTest, EnumWithDefaults_Rust) {
4282 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4283 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4284package p;
4285import p.Enum;
4286parcelable Foo {
4287 int n = 42;
4288 Enum e = Enum.BAR;
4289})");
4290 CaptureStderr();
4291 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004292 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004293 auto err = GetCapturedStderr();
4294 EXPECT_EQ("", err);
4295
4296 string code;
4297 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4298 EXPECT_THAT(code, testing::HasSubstr(R"(
4299 fn default() -> Self {
4300 Self {
4301 n: 42,
4302 e: crate::mangled::_1_p_4_Enum::BAR,
4303 }
4304 })"));
4305}
4306
4307TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4308 import_paths_.insert("a");
4309 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4310 CaptureStderr();
4311 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4312package p;
4313import p.Enum;
4314parcelable Foo {
4315 int e = Enum.FOO | Enum.BAR;
4316})",
4317 typenames_, GetLanguage());
4318 auto err = GetCapturedStderr();
4319 EXPECT_EQ("", err);
4320 EXPECT_TRUE(type);
4321 const auto& fields = type->AsStructuredParcelable()->GetFields();
4322 EXPECT_EQ("int e = 3", fields[0]->ToString());
4323}
4324
4325TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4326 CaptureStderr();
4327 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4328@Backing(type="int")
4329enum Foo {
4330 STANDARD_SHIFT = 16,
4331 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4332 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4333}
4334)",
4335 typenames_, GetLanguage());
4336 auto err = GetCapturedStderr();
4337 EXPECT_EQ("", err);
4338 EXPECT_TRUE(type);
4339 const auto& enum_type = type->AsEnumDeclaration();
4340 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004341 auto writer = CodeWriter::ForString(&code);
4342 DumpVisitor visitor(*writer);
4343 visitor.Visit(*enum_type);
4344 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004345 EXPECT_EQ(R"--(@Backing(type="int")
4346enum Foo {
4347 STANDARD_SHIFT = 16,
4348 STANDARD_BT709 = 65536,
4349 STANDARD_BT601_625 = 131072,
4350}
4351)--",
4352 code);
4353}
4354
4355TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4356 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4357 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4358package p;
4359import p.Enum;
4360parcelable Foo {
4361 Enum e = Enum.FOO | Enum.BAR;
4362})");
4363 CaptureStderr();
4364 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004365 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004366 auto err = GetCapturedStderr();
4367 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4368 err);
4369}
4370
Jooyung Han361cd102021-05-24 11:30:10 +09004371TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4372 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4373 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4374package p;
4375import p.Enum;
4376parcelable Foo {
4377 Enum e = 1;
4378})");
4379 CaptureStderr();
4380 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004381 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004382 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4383}
4384
Jooyung Han690f5842020-12-04 13:02:04 +09004385TEST_P(AidlTest, DefaultWithEmptyArray) {
4386 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4387 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4388 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004389 auto options =
4390 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004391 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004392 auto err = GetCapturedStderr();
4393 EXPECT_EQ("", err);
4394}
4395
4396TEST_P(AidlTest, RejectRefsInAnnotation) {
4397 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4398 "package p; interface IFoo {\n"
4399 " const String ANNOTATION = \"@Annotation\";\n"
4400 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4401 "}");
4402 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004403 auto options =
4404 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004405 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004406 auto err = GetCapturedStderr();
4407 EXPECT_EQ(
4408 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4409 "ANNOTATION.\n",
4410 err);
4411}
4412
4413TEST_F(AidlTest, DefaultWithEnumValues) {
4414 io_delegate_.SetFileContents(
4415 "a/p/Foo.aidl",
4416 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4417 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4418 CaptureStderr();
4419 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004420 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004421 auto err = GetCapturedStderr();
4422 EXPECT_EQ("", err);
4423 string code;
4424 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4425 EXPECT_THAT(
4426 code, testing::HasSubstr(
4427 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4428}
4429
Jooyung Han14259392020-12-07 10:00:08 +09004430TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4431 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4432 CaptureStderr();
4433 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004434 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004435 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004436 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004437}
4438
4439TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4440 io_delegate_.SetFileContents("a/p/Foo.aidl",
4441 "package p; parcelable Foo { const int A = A + 1; }");
4442 CaptureStderr();
4443 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004444 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004445 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004446 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4447}
4448
4449TEST_F(AidlTest, RecursiveReferences) {
4450 io_delegate_.SetFileContents("a/p/Foo.aidl",
4451 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4452 io_delegate_.SetFileContents("a/p/Bar.aidl",
4453 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4454 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4455 CaptureStderr();
4456 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004457 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004458 EXPECT_EQ("", GetCapturedStderr());
4459}
4460
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004461TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4462 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4463 auto options =
4464 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4465 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4466 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004467 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004468 EXPECT_EQ(err, GetCapturedStderr());
4469}
4470
4471TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4472 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4473 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4474 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4475 auto options =
4476 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4477 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004478 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004479 EXPECT_EQ("", GetCapturedStderr());
4480}
4481
Jooyung Hane9f5b272021-01-07 00:18:11 +09004482TEST_P(AidlTest, UnknownConstReference) {
Jooyung Hane1abd592021-10-05 10:35:02 +09004483 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { int field = UNKNOWN_REF; }");
Jooyung Hane9f5b272021-01-07 00:18:11 +09004484 auto options =
4485 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4486 const string err =
Jooyung Hane1abd592021-10-05 10:35:02 +09004487 "ERROR: Foo.aidl:1.30-42: Can't find UNKNOWN_REF in Foo\n"
4488 "ERROR: Foo.aidl:1.30-42: Unknown reference 'UNKNOWN_REF'\n";
Jooyung Hane9f5b272021-01-07 00:18:11 +09004489 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004490 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004491 EXPECT_EQ(err, GetCapturedStderr());
4492}
4493
Jooyung Han29813842020-12-08 01:28:03 +09004494TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4495 string contents = R"(
4496import android.os.IBinder;
4497import android.os.IInterface;
4498interface IFoo {}
4499 )";
4500 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004501}
4502
Jooyung Han888c5bc2020-12-22 17:28:47 +09004503TEST_P(AidlTest, WarningInterfaceName) {
4504 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004505 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004506 " -Weverything -o out -h out p/Foo.aidl");
4507 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004508 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004509 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004510 GetCapturedStderr());
4511}
4512
4513TEST_P(AidlTest, ErrorInterfaceName) {
4514 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004515 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004516 " -Weverything -Werror -o out -h out p/Foo.aidl");
4517 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004518 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004519 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004520 GetCapturedStderr());
4521}
4522
Jiyong Park9f4c3822021-04-07 20:36:45 +09004523TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4524 const std::string input_file = "base/p/q/IFoo.aidl";
4525 const std::string header_dir = "out/";
4526 const std::string output_file = "out/base/p/q/IFoo.cpp";
4527 const std::string package = "p.q"; // not base.p.q
4528 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4529
4530 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4531 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004532 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004533 EXPECT_THAT(
4534 GetCapturedStderr(),
4535 testing::StartsWith(
4536 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4537 "but is out/base/p/q/IFoo.cpp."));
4538}
4539
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004540TEST_F(AidlTest, FormatCommentsForJava) {
4541 using android::aidl::FormatCommentsForJava;
4542
4543 struct TestCase {
4544 vector<Comment> comments;
4545 string formatted;
4546 };
4547 vector<TestCase> testcases = {
4548 {{}, ""},
4549 {{{"// line comments\n"}}, "// line comments\n"},
4550 {{{"// @hide \n"}}, "// @hide \n"},
4551 // Transform the last block comment as Javadoc.
4552 {{{"/*\n"
4553 " * Hello, world!\n"
4554 " */"}},
4555 "/**\n"
4556 " * Hello, world!\n"
4557 " */"},
4558 {{{"/* @hide */"}}, "/** @hide */"},
4559 {{{"/**\n"
4560 " @param foo ...\n"
4561 "*/"}},
4562 "/**\n"
4563 " @param foo ...\n"
4564 "*/"},
4565 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide *//** @hide */"},
4566 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
4567 "/* @deprecated first *//** @deprecated second */"},
4568 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated *//** @param foo */"},
4569 // Line comments are printed as they are
4570 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */// line comments\n"},
4571 };
4572 for (const auto& [input, formatted] : testcases) {
4573 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4574 }
4575}
4576
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004577TEST_F(AidlTest, HideIsNotForArgs) {
4578 io_delegate_.SetFileContents("IFoo.aidl",
4579 "interface IFoo {\n"
4580 " void foo(in @Hide int x);\n"
4581 "}");
4582 auto options = Options::From("aidl --lang=java IFoo.aidl");
4583 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004584 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004585 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4586}
4587
4588TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4589 io_delegate_.SetFileContents(
4590 "IFoo.aidl",
4591 "interface IFoo {\n"
4592 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4593 "}");
4594 auto options = Options::From("aidl --lang=java IFoo.aidl");
4595 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004596 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004597 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4598}
4599
Jooyung Hanfa181932021-06-12 07:56:53 +09004600TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4601 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4602 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4603 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004604 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004605 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4606}
4607
Jooyung Hanfd3be322020-12-13 09:11:06 +09004608struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004609 string kind;
4610 string literal;
4611};
4612
Jooyung Hanfd3be322020-12-13 09:11:06 +09004613const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004614 {"primitive", "int"}, {"primitiveArray", "int[]"},
4615 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004616 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4617 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4618 {"union", "a.Union"}, {"interface", "a.IBar"},
4619};
4620
4621const std::map<std::string, std::string> kListSupportExpectations = {
4622 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4623 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4624 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4625 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004626 {"cpp_primitiveArray", "List of arrays is not supported."},
4627 {"java_primitiveArray", "List of arrays is not supported."},
4628 {"ndk_primitiveArray", "List of arrays is not supported."},
4629 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004630 {"cpp_String", ""},
4631 {"java_String", ""},
4632 {"ndk_String", ""},
4633 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004634 {"cpp_StringArray", "List of arrays is not supported."},
4635 {"java_StringArray", "List of arrays is not supported."},
4636 {"ndk_StringArray", "List of arrays is not supported."},
4637 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004638 {"cpp_IBinder", ""},
4639 {"java_IBinder", ""},
4640 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4641 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004642 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004643 {"java_ParcelFileDescriptor", ""},
4644 {"ndk_ParcelFileDescriptor", ""},
4645 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004646 {"cpp_interface", "List<a.IBar> is not supported."},
4647 {"java_interface", "List<a.IBar> is not supported."},
4648 {"ndk_interface", "List<a.IBar> is not supported."},
4649 {"rust_interface", "List<a.IBar> is not supported."},
4650 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004651 {"java_parcelable", ""},
4652 {"ndk_parcelable", ""},
4653 {"rust_parcelable", ""},
4654 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4655 {"java_enum", "A generic type cannot have any primitive type parameters."},
4656 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4657 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004658 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004659 {"java_union", ""},
4660 {"ndk_union", ""},
4661 {"rust_union", ""},
4662};
4663
Jooyung Hand236e552020-12-13 09:21:27 +09004664const std::map<std::string, std::string> kArraySupportExpectations = {
4665 {"cpp_primitive", ""},
4666 {"java_primitive", ""},
4667 {"ndk_primitive", ""},
4668 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004669 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4670 {"java_primitiveArray", "Can only have one dimensional arrays."},
4671 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4672 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004673 {"cpp_String", ""},
4674 {"java_String", ""},
4675 {"ndk_String", ""},
4676 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004677 {"cpp_StringArray", "Can only have one dimensional arrays."},
4678 {"java_StringArray", "Can only have one dimensional arrays."},
4679 {"ndk_StringArray", "Can only have one dimensional arrays."},
4680 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004681 {"cpp_IBinder", ""},
4682 {"java_IBinder", ""},
4683 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4684 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4685 {"cpp_ParcelFileDescriptor", ""},
4686 {"java_ParcelFileDescriptor", ""},
4687 {"ndk_ParcelFileDescriptor", ""},
4688 {"rust_ParcelFileDescriptor", ""},
4689 {"cpp_interface", "Binder type cannot be an array"},
4690 {"java_interface", "Binder type cannot be an array"},
4691 {"ndk_interface", "Binder type cannot be an array"},
4692 {"rust_interface", "Binder type cannot be an array"},
4693 {"cpp_parcelable", ""},
4694 {"java_parcelable", ""},
4695 {"ndk_parcelable", ""},
4696 {"rust_parcelable", ""},
4697 {"cpp_enum", ""},
4698 {"java_enum", ""},
4699 {"ndk_enum", ""},
4700 {"rust_enum", ""},
4701 {"cpp_union", ""},
4702 {"java_union", ""},
4703 {"ndk_union", ""},
4704 {"rust_union", ""},
4705};
4706
Jooyung Hanfd3be322020-12-13 09:11:06 +09004707class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004708 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004709 void Run(const std::string& generic_type_decl,
4710 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004711 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004712 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004713 const auto& kind = std::get<1>(param).kind;
4714
4715 FakeIoDelegate io;
4716 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4717 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4718 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004719 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4720 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004721
4722 const auto options =
4723 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4724 CaptureStderr();
4725 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004726 auto it = expectations.find(lang + "_" + kind);
4727 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004728 const string err = GetCapturedStderr();
4729 if (it->second.empty()) {
4730 EXPECT_EQ("", err);
4731 } else {
4732 EXPECT_THAT(err, testing::HasSubstr(it->second));
4733 }
4734 }
4735};
4736
4737INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004738 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004739 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4740 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004741 testing::ValuesIn(kTypeParams)),
4742 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004743 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004744 });
4745
Jooyung Hanfd3be322020-12-13 09:11:06 +09004746TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4747 Run("List<{}>", kListSupportExpectations);
4748}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004749
Jooyung Hand236e552020-12-13 09:21:27 +09004750TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4751 Run("{}[]", kArraySupportExpectations);
4752}
4753
Christopher Wiley90be4e32015-10-20 14:55:25 -07004754} // namespace aidl
4755} // namespace android