blob: d0a7a64ad84d93c63b5e7d7a45aadeed400139c3 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
1254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
Jooyung Hanf8c39632021-10-05 09:56:29 +09001477TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1478 const string input_path = "p/IFoo.aidl";
1479 const string input =
1480 "package p;\n"
1481 "interface IFoo {\n"
1482 " parcelable Inner {\n"
1483 " enum Enum { A }\n"
1484 " }\n"
1485 "}";
1486 CaptureStderr();
1487 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1488 EXPECT_EQ(GetCapturedStderr(), "");
1489
1490 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1491 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1492 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1493 EXPECT_TRUE(enum_type.is_resolved);
1494 EXPECT_TRUE(inner_type.is_resolved);
1495 EXPECT_TRUE(ifoo_type.is_resolved);
1496 // GetParentType()
1497 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1498 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1499 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1500 // GetRootType()
1501 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1502 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1503 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1504 // GetDocument()
1505 auto main_document = &typenames_.MainDocument();
1506 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1507 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1508 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1509}
1510
Jooyung Han2aedb112021-09-29 09:37:59 +09001511TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1512 io_delegate_.SetFileContents("p/IOuter.aidl",
1513 "package p;\n"
1514 "interface IOuter {\n"
1515 " parcelable Inner {}\n"
1516 "}");
1517 import_paths_.emplace("");
1518 const string input_path = "p/IFoo.aidl";
1519 const string input =
1520 "package p;\n"
1521 "interface IFoo {\n"
1522 " p.IOuter.Inner get();\n"
1523 "}";
1524 CaptureStderr();
1525 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1526 EXPECT_EQ(GetCapturedStderr(), "");
1527
1528 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1529}
1530
1531TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1532 io_delegate_.SetFileContents("p/IOuter.aidl",
1533 "package p;\n"
1534 "interface IOuter {\n"
1535 " parcelable Inner {}\n"
1536 "}");
1537 import_paths_.emplace("");
1538 const string input_path = "p/IFoo.aidl";
1539 const string input =
1540 "package p;\n"
1541 "import p.IOuter.Inner;"
1542 "interface IFoo {\n"
1543 " Inner get();\n"
1544 "}";
1545 CaptureStderr();
1546 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1547 EXPECT_EQ(GetCapturedStderr(), "");
1548
1549 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1550}
1551
1552TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1553 const string input_path = "p/IFoo.aidl";
1554 const string input =
1555 "package p;\n"
1556 "interface IFoo {\n"
1557 " parcelable Result {}\n"
1558 " Result get();\n"
1559 "}";
1560 CaptureStderr();
1561 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1562 EXPECT_EQ(GetCapturedStderr(), "");
1563
1564 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1565}
1566
1567// Finding the type of nested named member.
1568struct TypeFinder : AidlVisitor {
1569 string name;
1570 const AidlTypeSpecifier* type = nullptr;
1571 TypeFinder(std::string name) : name(name) {}
1572 void Visit(const AidlVariableDeclaration& v) override {
1573 if (v.GetName() == name) {
1574 type = &v.GetType();
1575 }
1576 }
1577 void Visit(const AidlMethod& m) override {
1578 if (m.GetName() == name) {
1579 type = &m.GetType();
1580 }
1581 }
1582 static string Get(const AidlDefinedType& type, const string& name) {
1583 TypeFinder v(name);
1584 VisitTopDown(v, type);
1585 return v.type ? v.type->Signature() : "(null)";
1586 };
1587};
1588
1589TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1590 io_delegate_.SetFileContents("q/IBar.aidl",
1591 "package q;\n"
1592 "interface IBar {\n"
1593 " parcelable Baz {}\n"
1594 "}");
1595 import_paths_.emplace("");
1596 const string input_path = "p/IFoo.aidl";
1597 const string input =
1598 "package p;\n"
1599 "import q.IBar;\n"
1600 "interface IFoo {\n"
1601 " parcelable Nested {\n"
1602 " Baz t1;\n"
1603 " }\n"
1604 " parcelable Baz { }\n"
1605 " IBar.Baz t2();\n"
1606 " Baz t3();\n"
1607 "}";
1608 CaptureStderr();
1609 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1610 EXPECT_EQ(GetCapturedStderr(), "");
1611 ASSERT_NE(nullptr, foo);
1612
1613 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1614 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1615 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1616}
1617
1618TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1619 const string input_path = "p/Foo.aidl";
1620 const string input =
1621 "package p;\n"
1622 "parcelable Foo {\n"
1623 " parcelable Foo {}\n"
1624 "}";
1625 CaptureStderr();
1626 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1628}
1629
1630TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1631 const string input_path = "p/IFoo.aidl";
1632 const string input =
1633 "package p;\n"
1634 "interface IFoo {\n"
1635 " interface ICallback { void done(); }\n"
1636 " void doTask(ICallback cb);\n"
1637 "}";
1638 CaptureStderr();
1639 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1640 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1641}
1642
Jooyung Han2b1487d2021-09-30 09:57:01 +09001643TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1644 const string input_path = "p/IFoo.aidl";
1645 const string input =
1646 "package p;\n"
1647 "interface IFoo {\n"
1648 " parcelable Bar cpp_header \"Bar.h\";\n"
1649 "}";
1650 CaptureStderr();
1651 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1652 EXPECT_THAT(GetCapturedStderr(),
1653 HasSubstr("Unstructured parcelables should be at the root scope"));
1654}
1655
Jooyung Han7fc5de02021-09-30 22:26:27 +09001656TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1657 const string input_path = "p/Foo.aidl";
1658 const string input =
1659 "package p;\n"
1660 "parcelable Foo<T> {\n"
1661 " parcelable Bar {}\n"
1662 "}";
1663 CaptureStderr();
1664 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1665 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1666}
1667
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001668TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1669 const string input_path = "p/IFoo.aidl";
1670 const string input =
1671 "package p;\n"
1672 "interface IFoo {\n"
1673 " parcelable;\n" // missing identifier
1674 "}";
1675 CaptureStderr();
1676 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1677 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1678}
1679
Jooyung Han2aedb112021-09-29 09:37:59 +09001680TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1681 const string input_path = "p/Foo.aidl";
1682 const string input =
1683 "package p;\n"
1684 "interface Foo {\n"
1685 " parcelable Bar {}\n"
1686 " parcelable Bar {}\n"
1687 "}";
1688 CaptureStderr();
1689 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1690 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1691}
1692
1693TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1694 struct Failure {
1695 string err;
1696 };
1697 struct TestCase {
1698 string type;
1699 variant<string, Failure> expected; // success<0> or failure<1>
1700 };
1701 vector<TestCase> cases = {
1702 {"foo.A", "foo.A"},
1703 {"foo.A.B", "foo.A.B"},
1704 {"@nullable(heap=true) A", "foo.A.B.A"},
1705 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1706 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1707 {"B", "foo.A.B.A.B"},
1708 {"A.B", "foo.A.B.A.B"},
1709 };
1710 const string input_path = "foo/A.aidl";
1711 for (auto& [type, expected] : cases) {
1712 AidlTypenames typenames;
1713 // clang-format off
1714 const string input =
1715 "package foo;\n"
1716 "parcelable A {\n"
1717 " parcelable B {\n"
1718 " parcelable A {\n"
1719 " parcelable B {\n"
1720 " }\n"
1721 " " + type + " m;\n"
1722 " }\n"
1723 " }\n"
1724 "}";
1725 // clang-format on
1726 CaptureStderr();
1727 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1728 if (auto failure = std::get_if<Failure>(&expected); failure) {
1729 ASSERT_EQ(nullptr, foo);
1730 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1731 } else {
1732 EXPECT_EQ(GetCapturedStderr(), "");
1733 ASSERT_NE(nullptr, foo);
1734 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1735 }
1736 }
1737}
1738
Jooyung Hanca84b032021-09-30 02:15:59 +09001739TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1740 const string input_path = "p/IFoo.aidl";
1741 const string input =
1742 "package p;\n"
1743 "interface IFoo {\n"
1744 " parcelable Result {}\n"
1745 "}";
1746 CaptureStderr();
1747 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1748 ASSERT_NE(nullptr, foo);
1749 EXPECT_EQ(GetCapturedStderr(), "");
1750
1751 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1752 ASSERT_NE(nullptr, result);
1753 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1754}
1755
Jooyung Han8e9ae872021-10-13 02:52:25 +09001756TEST_F(AidlTest, ReorderNestedTypesForCppOutput) {
1757 const string input_path = "p/IFoo.aidl";
1758 const string input = R"(
1759 package p;
1760 interface IFoo {
1761 // partial orderings for [A, D, G]:
1762 // D - A
1763 // A - G
1764 parcelable A {
1765 // partial orderings for [B, C]:
1766 // C - B
1767 parcelable B {
1768 C c;
1769 D.E d;
1770 }
1771 parcelable C {}
1772 }
1773 parcelable D {
1774 // partial orderings for [E, F]:
1775 // F - E
1776 parcelable E {
1777 F f;
1778 }
1779 parcelable F {}
1780 }
1781 parcelable G {
1782 A.B b;
1783 }
1784 }
1785 )";
1786 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1787 io_delegate_.SetFileContents(input_path, input);
1788 CaptureStderr();
1789 EXPECT_TRUE(compile_aidl(options, io_delegate_));
1790 EXPECT_EQ(GetCapturedStderr(), "");
1791
1792 string code;
1793 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/IFoo.h", &code));
1794 // check partial orderings: a should comes before b
1795 EXPECT_LE(code.find("class D"), code.find("class A"));
1796 EXPECT_LE(code.find("class A"), code.find("class G"));
1797 EXPECT_LE(code.find("class C"), code.find("class B"));
1798 EXPECT_LE(code.find("class F"), code.find("class E"));
1799}
1800
1801TEST_F(AidlTest, RejectsNestedTypesWithCyclicDeps) {
1802 const string input_path = "p/IFoo.aidl";
1803 const string input = R"(
1804 package p;
1805 interface IFoo {
1806 // Cycles:
1807 // D - A
1808 // A - G
1809 // G - D
1810 parcelable A {
1811 parcelable B {
1812 C c;
1813 }
1814 }
1815 parcelable C {
1816 parcelable D {
1817 E e;
1818 }
1819 }
1820 parcelable E {
1821 parcelable F {
1822 A a;
1823 }
1824 }
1825 }
1826 )";
1827 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1828 io_delegate_.SetFileContents(input_path, input);
1829 CaptureStderr();
1830 EXPECT_FALSE(compile_aidl(options, io_delegate_));
1831 EXPECT_THAT(GetCapturedStderr(), HasSubstr("IFoo has nested types with cyclic references."));
1832}
1833
Jooyung Han0a950bd2021-05-15 12:50:36 +09001834TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001835 const string input_path = "p/Wrapper.aidl";
1836 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001837
1838 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1839 EXPECT_NE(nullptr, parse_result);
1840
1841 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1842 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1843 (..., params->emplace_back(std::move(type_params)));
1844 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1845 };
1846
1847 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
Steven Morelanda7560e82021-10-08 16:24:39 -07001848 std::vector<std::unique_ptr<AidlAnnotation>> annotations;
1849 annotations.emplace_back(std::unique_ptr<AidlAnnotation>(
1850 AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {})));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001851 type->Annotate(std::move(annotations));
1852 return std::move(type);
1853 };
1854
1855 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1856 (void)type->SetArray();
1857 return std::move(type);
1858 };
1859
1860 auto w = type("p.Wrapper", type("String"));
1861 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1862
1863 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1864 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1865 cpp::CppNameOf(*nullable_w, typenames_));
1866
1867 auto array_w = set_array(type("p.Wrapper", type("String")));
1868 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1869 cpp::CppNameOf(*array_w, typenames_));
1870
1871 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1872 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1873 cpp::CppNameOf(*nullable_array_w, typenames_));
1874
1875 auto list_w = type("List", type("p.Wrapper", type("String")));
1876 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1877 cpp::CppNameOf(*list_w, typenames_));
1878
1879 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1880 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1881 cpp::CppNameOf(*nullable_list_w, typenames_));
1882}
1883
Devin Moore7b8d5c92020-03-17 14:14:08 -07001884TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001885 io_delegate_.SetFileContents(
1886 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001887 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001888 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001889 const string input_path = "p/IFoo.aidl";
1890 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001891 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1892 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001893 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001894 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001895 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001896
1897 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1898 // C++ understands C++ specific stuff
1899 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1900 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001901 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001902 EXPECT_EQ(1u, headers.size());
1903 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001904}
1905
Christopher Wileyf8136192016-04-12 14:19:35 -07001906TEST_F(AidlTest, WritesCorrectDependencyFile) {
1907 // While the in tree build system always gives us an output file name,
1908 // other android tools take advantage of our ability to infer the intended
1909 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001910 vector<string> args = {
1911 "aidl",
1912 "-d dep/file/path",
1913 "-o place/for/output",
1914 "p/IFoo.aidl"};
1915 Options options = Options::From(args);
1916 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001917 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001918 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001919 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001920 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1921}
1922
Dan Willemsen93298ee2016-11-10 23:55:55 -08001923TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1924 // While the in tree build system always gives us an output file name,
1925 // other android tools take advantage of our ability to infer the intended
1926 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001927 vector<string> args = {
1928 "aidl",
1929 "-d dep/file/path",
1930 "--ninja",
1931 "-o place/for/output",
1932 "p/IFoo.aidl"};
1933 Options options = Options::From(args);
1934 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001935 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001936 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001937 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001938 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1939}
1940
Jiyong Parkdf202122019-09-30 20:48:35 +09001941TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001942 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1943 // this by calling aidl with every .aidl file it finds, then parsing the
1944 // generated dependency files. Those that reference .java output files are
1945 // for interfaces and those that do not are parcelables. However, for both
1946 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001947 vector<string> args = {
1948 "aidl",
1949 "-o place/for/output",
1950 "-d dep/file/path",
1951 "p/Foo.aidl"};
1952 Options options = Options::From(args);
1953 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001954 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001955 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001956 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001957 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1958}
1959
1960TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1961 vector<string> args = {
1962 "aidl",
1963 "--structured",
1964 "-o place/for/output",
1965 "-d dep/file/path",
1966 "p/Foo.aidl"};
1967 Options options = Options::From(args);
1968 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001969 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001970 string actual_dep_file_contents;
1971 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1972 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001973}
1974
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001975TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1976 vector<string> args = {
1977 "aidl",
1978 "--lang=java",
1979 "-o place/for/output",
1980 "p/Foo.aidl"};
1981 Options options = Options::From(args);
1982 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001983 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001984 string output_file_contents;
1985 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1986}
1987
Devin Moore21b26772020-08-26 16:37:56 -07001988TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001989 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001990 const string list_array_parcelable =
1991 "package a; parcelable Foo {\n"
1992 " List[] lists; }";
1993 CaptureStderr();
1994 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1995 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1996}
1997
Jiyong Parkf8d53612020-05-04 14:06:13 +09001998TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1999 AidlError error;
2000 string expected_stderr =
2001 "ERROR: a/IFoo.aidl:2.7-11: "
2002 "Encountered an untyped List or Map. The use of untyped List/Map is "
2003 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2004 "the receiving side. Consider switching to an array or a generic List/Map.\n";
2005 if (GetLanguage() != Options::Language::JAVA) {
2006 expected_stderr =
2007 "ERROR: a/IFoo.aidl:2.1-7: "
2008 "Currently, only the Java backend supports non-generic List.\n";
2009 }
2010
2011 const string primitive_interface =
2012 "package a; interface IFoo {\n"
2013 " List foo(); }";
2014 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002015 AidlTypenames tn1;
2016 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002017 {"--structured"}));
2018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09002019
2020 string primitive_parcelable =
2021 "package a; parcelable IFoo {\n"
2022 " List foo;}";
2023 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002024 AidlTypenames tn2;
2025 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002026 {"--structured"}));
2027 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2028}
2029
Jeongik Cha225519b2020-08-29 01:55:32 +09002030TEST_P(AidlTest, ExtensionTest) {
2031 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002032 string extendable_parcelable =
2033 "package a; parcelable Data {\n"
2034 " ParcelableHolder extension;\n"
2035 " ParcelableHolder extension2;\n"
2036 "}";
Andrei Homescub2316a52021-09-04 04:41:12 +00002037 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
2038 EXPECT_EQ("", GetCapturedStderr());
Jeongik Cha225519b2020-08-29 01:55:32 +09002039}
2040TEST_P(AidlTest, ParcelableHolderAsReturnType) {
2041 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002042 string parcelableholder_return_interface =
2043 "package a; interface IFoo {\n"
2044 " ParcelableHolder foo();\n"
2045 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002046 EXPECT_EQ(nullptr,
2047 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09002048
Jeongik Cha225519b2020-08-29 01:55:32 +09002049 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
2050 GetCapturedStderr());
2051}
2052
2053TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
2054 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002055 string extendable_parcelable_arg_interface =
2056 "package a; interface IFoo {\n"
2057 " void foo(in ParcelableHolder ph);\n"
2058 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002059 EXPECT_EQ(nullptr,
2060 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
2061
Jeongik Cha225519b2020-08-29 01:55:32 +09002062 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
2063 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09002064}
2065
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002066TEST_P(AidlTest, RejectNullableParcelableHolderField) {
2067 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002068 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002069 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
2070 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002071 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002072 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2073}
2074
Jooyung Han3f347ca2020-12-01 12:41:50 +09002075TEST_P(AidlTest, ParcelablesWithConstants) {
2076 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002077 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002078 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002079 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002080 EXPECT_EQ("", GetCapturedStderr());
2081}
2082
2083TEST_P(AidlTest, UnionWithConstants) {
2084 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002085 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002086 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002087 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002088 EXPECT_EQ("", GetCapturedStderr());
2089}
2090
Jooyung Han633eab62021-01-07 14:12:40 +09002091TEST_F(AidlTest, ConstantsWithAnnotations) {
2092 io_delegate_.SetFileContents("IFoo.aidl",
2093 "interface IFoo {\n"
2094 " @JavaPassthrough(annotation=\"@Foo\")\n"
2095 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2096 "}");
2097 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2098 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002099 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002100 EXPECT_EQ("", GetCapturedStderr());
2101 string code;
2102 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2103 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2104 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2105}
2106
Jiyong Park02da7422018-07-16 16:00:26 +09002107TEST_F(AidlTest, ApiDump) {
2108 io_delegate_.SetFileContents(
2109 "foo/bar/IFoo.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002110 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002111 "package foo.bar;\n"
2112 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002113 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002114 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002115 " /* @hide applied \n"
2116 " @deprecated use foo2 */\n"
2117 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2118 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002119 " IFoo foo3(IFoo foo);\n"
2120 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002121 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002122 " /** blahblah\n"
2123 " @deprecated\n"
2124 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002125 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002126 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002127 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002128 "}\n");
2129 io_delegate_.SetFileContents("foo/bar/Data.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002130 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002131 "package foo.bar;\n"
2132 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002133 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002134 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002135 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002136 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002137 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002138 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002139 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002140 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002141 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002142 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002143 "}\n");
2144 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002145 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2146 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002147 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002148 bool result = dump_api(options, io_delegate_);
2149 ASSERT_TRUE(result);
2150 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002151 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002152 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002153interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002154 /**
2155 * @hide
2156 * @deprecated use foo2
2157 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002158 int foo(out int[] a, String b, boolean c, inout List<String> d);
2159 int foo2(@utf8InCpp String x, inout List<String> y);
2160 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2161 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002162 /**
2163 * @deprecated reason why...
2164 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002165 const int A = 1;
2166 const String STR = "Hello";
2167}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002168)"),
2169 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002170
Jiyong Parke59c3682018-09-11 23:10:25 +09002171 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002172 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002173/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002174parcelable Data {
2175 int x = 10;
2176 int y;
2177 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002178 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002179}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002180)"),
2181 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002182}
2183
Jiyong Parked65bf42018-08-28 15:43:27 +09002184TEST_F(AidlTest, ApiDumpWithManualIds) {
2185 io_delegate_.SetFileContents(
2186 "foo/bar/IFoo.aidl",
2187 "package foo.bar;\n"
2188 "interface IFoo {\n"
2189 " int foo() = 1;\n"
2190 " int bar() = 2;\n"
2191 " int baz() = 10;\n"
2192 "}\n");
2193
Jiyong Parke59c3682018-09-11 23:10:25 +09002194 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002195 Options options = Options::From(args);
2196 bool result = dump_api(options, io_delegate_);
2197 ASSERT_TRUE(result);
2198 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002199 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002200 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002201interface IFoo {
2202 int foo() = 1;
2203 int bar() = 2;
2204 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002205}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002206)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002207}
2208
2209TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002210 const string expected_stderr =
2211 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2212 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002213 io_delegate_.SetFileContents(
2214 "foo/bar/IFoo.aidl",
2215 "package foo.bar;\n"
2216 "interface IFoo {\n"
2217 " int foo() = 1;\n"
2218 " int bar();\n"
2219 " int baz() = 10;\n"
2220 "}\n");
2221
Jiyong Parke59c3682018-09-11 23:10:25 +09002222 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002223 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002224 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002225 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002226 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002227}
2228
Jooyung Han965e31d2020-11-27 12:30:16 +09002229TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2230 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2231 "package foo.bar;\n"
2232 "interface IFoo {\n"
2233 " @utf8InCpp String foo();\n"
2234 " const @utf8InCpp String bar = \"bar\";\n"
2235 "}\n");
2236
2237 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2238 Options options = Options::From(args);
2239 CaptureStderr();
2240 EXPECT_TRUE(dump_api(options, io_delegate_));
2241 EXPECT_EQ("", GetCapturedStderr());
2242 string actual;
2243 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002244 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2245interface IFoo {
2246 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002247 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002248}
2249)"),
2250 actual);
2251}
2252
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002253TEST_F(AidlTest, ApiDumpWithEnums) {
2254 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2255 "package foo.bar;\n"
2256 "enum Enum {\n"
2257 " FOO,\n"
2258 " BAR = FOO + 1,\n"
2259 "}\n");
2260
2261 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2262 Options options = Options::From(args);
2263 CaptureStderr();
2264 EXPECT_TRUE(dump_api(options, io_delegate_));
2265 EXPECT_EQ("", GetCapturedStderr());
2266 string actual;
2267 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2268 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2269 "enum Enum {\n"
2270 " FOO = 0,\n"
2271 " BAR = 1,\n"
2272 "}\n"),
2273 actual);
2274}
2275
2276TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2277 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2278 "package foo.bar;\n"
2279 "enum Enum {\n"
2280 " FOO,\n"
2281 "}\n");
2282 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2283 "package foo.bar;\n"
2284 "import foo.bar.Enum;\n"
2285 "parcelable Foo {\n"
2286 " Enum e = Enum.FOO;\n"
2287 "}\n");
2288
2289 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2290 Options options = Options::From(args);
2291 CaptureStderr();
2292 EXPECT_TRUE(dump_api(options, io_delegate_));
2293 EXPECT_EQ("", GetCapturedStderr());
2294 string actual;
2295 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2296 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2297 "parcelable Foo {\n"
2298 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2299 "}\n"),
2300 actual);
2301}
2302
Jooyung Han71dfec32021-05-23 07:18:58 +09002303TEST_F(AidlTest, ApiDumpWithGenerics) {
2304 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2305 "package foo.bar;\n"
2306 "parcelable Foo<T, U> {\n"
2307 "}\n");
2308
2309 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2310 Options options = Options::From(args);
2311 CaptureStderr();
2312 EXPECT_TRUE(dump_api(options, io_delegate_));
2313 EXPECT_EQ("", GetCapturedStderr());
2314 string actual;
2315 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2316 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2317 "parcelable Foo<T, U> {\n"
2318 "}\n"),
2319 actual);
2320}
2321
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002322TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2323 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2324 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2325
2326 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2327 Options options = Options::From(args);
2328 CaptureStderr();
2329 EXPECT_FALSE(dump_api(options, io_delegate_));
2330 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2331}
2332
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002333TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002334 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002335 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2336 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002337 const string expected_map_stderr =
2338 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002339 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2340 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002341 "package p; interface IFoo {"
2342 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002343 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002344 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002345 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002346
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002347 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002348 "package p; interface IFoo {"
2349 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002350 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002351 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002352 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002353}
2354
Jeongik Chae48d9942020-01-02 17:39:00 +09002355TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002356 const string expected_stderr =
2357 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002358 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002359 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2360
2361 io_delegate_.SetFileContents("p/IFoo.aidl",
2362 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002363 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002364 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002365
2366 io_delegate_.SetFileContents("p/IFoo.aidl",
2367 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002368 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002370 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002371 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002372
2373 io_delegate_.SetFileContents("p/IFoo.aidl",
2374 "package p; interface IFoo {"
2375 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002376 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002377
2378 io_delegate_.SetFileContents("p/IFoo.aidl",
2379 "package p; interface IFoo {"
2380 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002381 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002382}
2383
Jeongik Chadf76dc72019-11-28 00:08:47 +09002384TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002385 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002386 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2387 io_delegate_.SetFileContents(options.InputFiles().front(),
2388 "package p; interface IFoo {"
2389 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002390 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002391 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002393}
2394
2395TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002396 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002397 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002398 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002399 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2401 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002402
Jooyung Han13f1fa52021-06-11 18:06:12 +09002403 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002404 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2405 io_delegate_.SetFileContents("p/IFoo.aidl",
2406 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002407 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002408 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002409 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002410 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002411 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002412 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002413 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002414 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002415 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002416 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002417 io_delegate_.SetFileContents("p/IFoo.aidl",
2418 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002419 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002420 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002421
2422 io_delegate_.SetFileContents("p/IFoo.aidl",
2423 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002424 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002425
2426 io_delegate_.SetFileContents("p/IFoo.aidl",
2427 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002428 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002429
Steven Moreland4e059132021-08-11 13:36:30 -07002430 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002431}
2432
Jeongik Cha0e426012019-07-29 15:57:02 +09002433TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2434 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002435 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2436 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002437 for (const auto& rawOption : rawOptions) {
2438 string expected_stderr =
2439 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002440 Options options = Options::From(rawOption);
2441 io_delegate_.SetFileContents(options.InputFiles().front(),
2442 "package foo.bar;\n"
2443 "interface IFoo1 { int foo(); }\n"
2444 "interface IFoo2 { int foo(); }\n"
2445 "parcelable Data1 { int a; int b;}\n"
2446 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002447 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002448 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002449 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002450
Jeongik Cha0e426012019-07-29 15:57:02 +09002451 io_delegate_.SetFileContents(options.InputFiles().front(),
2452 "package foo.bar;\n"
2453 "interface IFoo1 { int foo(); }\n"
2454 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002456 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002458
Devin Moore5de18ed2020-04-02 13:52:29 -07002459 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002460 io_delegate_.SetFileContents(options.InputFiles().front(),
2461 "package foo.bar;\n"
2462 "parcelable Data1 { int a; int b;}\n"
2463 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002464 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002465 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002467 }
2468}
2469
Devin Moorebdba2a82020-03-31 15:19:02 -07002470TEST_P(AidlTest, FailParseOnEmptyFile) {
2471 const string contents = "";
2472 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2473 CaptureStderr();
2474 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2475 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2476}
2477
Jiyong Parkb034bf02018-07-30 17:44:33 +09002478TEST_F(AidlTest, MultipleInputFiles) {
2479 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002480 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002481
2482 io_delegate_.SetFileContents(options.InputFiles().at(0),
2483 "package foo.bar;\n"
2484 "import foo.bar.Data;\n"
2485 "interface IFoo { Data getData(); }\n");
2486
2487 io_delegate_.SetFileContents(options.InputFiles().at(1),
2488 "package foo.bar;\n"
2489 "import foo.bar.IFoo;\n"
2490 "parcelable Data { IFoo foo; }\n");
2491
Steven Moreland4e059132021-08-11 13:36:30 -07002492 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002493
2494 string content;
2495 for (const auto file : {
2496 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2497 content.clear();
2498 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2499 EXPECT_FALSE(content.empty());
2500 }
2501}
2502
2503TEST_F(AidlTest, MultipleInputFilesCpp) {
2504 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002505 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002506
2507 io_delegate_.SetFileContents(options.InputFiles().at(0),
2508 "package foo.bar;\n"
2509 "import foo.bar.Data;\n"
2510 "interface IFoo { Data getData(); }\n");
2511
2512 io_delegate_.SetFileContents(options.InputFiles().at(1),
2513 "package foo.bar;\n"
2514 "import foo.bar.IFoo;\n"
2515 "parcelable Data { IFoo foo; }\n");
2516
Steven Moreland4e059132021-08-11 13:36:30 -07002517 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002518
2519 string content;
2520 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002521 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002522 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2523 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2524 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2525 content.clear();
2526 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2527 EXPECT_FALSE(content.empty());
2528 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002529}
2530
Andrei Homescub62afd92020-05-11 19:24:59 -07002531TEST_F(AidlTest, MultipleInputFilesRust) {
2532 Options options =
2533 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2534
2535 io_delegate_.SetFileContents(options.InputFiles().at(0),
2536 "package foo.bar;\n"
2537 "import foo.bar.Data;\n"
2538 "interface IFoo { Data getData(); }\n");
2539
2540 io_delegate_.SetFileContents(options.InputFiles().at(1),
2541 "package foo.bar;\n"
2542 "import foo.bar.IFoo;\n"
2543 "parcelable Data { IFoo foo; }\n");
2544
Steven Moreland4e059132021-08-11 13:36:30 -07002545 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002546
2547 string content;
2548 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2549 content.clear();
2550 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2551 EXPECT_FALSE(content.empty());
2552 }
2553}
2554
Devin Moore097a3ab2020-03-11 16:08:44 -07002555TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2556 const string expected_stderr =
2557 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002558 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2559 // int getInterfaceVersion() is one of the meta transactions
2560 io_delegate_.SetFileContents(options.InputFiles().front(),
2561 "package p; interface IFoo {"
2562 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002563 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002564 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2566}
Jiyong Park309668e2018-07-28 16:55:44 +09002567
Devin Moore097a3ab2020-03-11 16:08:44 -07002568TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2569 // boolean getInterfaceVersion() is not a meta transaction, but should be
2570 // prevented because return type is not part of a method signature
2571 const string expected_stderr =
2572 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2573 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002574 io_delegate_.SetFileContents(options.InputFiles().front(),
2575 "package p; interface IFoo {"
2576 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002578 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2580}
Jiyong Park309668e2018-07-28 16:55:44 +09002581
Devin Moore097a3ab2020-03-11 16:08:44 -07002582TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002583 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002584 const string expected_stderr =
2585 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2586 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002587 io_delegate_.SetFileContents(options.InputFiles().front(),
2588 "package p; interface IFoo {"
2589 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002591 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002593
2594 // this is not a meta interface method as it differs type arguments
2595 io_delegate_.SetFileContents(options.InputFiles().front(),
2596 "package p; interface IFoo {"
2597 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002598 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002599}
2600
Jooyung Hanb8a97772021-01-19 01:27:38 +09002601TEST_F(AidlTest, CheckApiForEquality) {
2602 CaptureStderr();
2603 Options options = Options::From("aidl --checkapi=equal old new");
2604
2605 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2606 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2607 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2608 "package p; interface IFoo{ @utf8InCpp String foo();}");
2609
2610 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2611 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2612}
2613
Daniel Norman85aed542019-08-21 12:01:14 -07002614TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002615 Options options = Options::From("aidl --checkapi old new");
2616 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2617 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2618 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2619 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2620
2621 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2622}
2623
Jiyong Park3656c3c2018-08-01 20:02:01 +09002624TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002625 Options options = Options::From("aidl --checkapi old new");
2626 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2627 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002628
2629 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2630}
2631
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002632TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2633 Options options = Options::From("aidl --checkapi old new");
2634 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2635 const string enum_definition = "package p; enum Enum { FOO }";
2636 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2637 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2638 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2639 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2640
2641 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2642}
2643
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002644TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2645 Options options = Options::From("aidl --checkapi old new -I import");
2646
2647 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2648 io_delegate_.SetFileContents("new/p/Foo.aidl",
2649 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2650 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2651
2652 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2653}
2654
Jooyung Han02a11be2021-02-11 13:18:06 +09002655TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2656 Options options = Options::From("aidl --checkapi=equal old new");
2657 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2658 const string enum_definition = "package p; enum Enum { FOO }";
2659 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2660 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2661 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2662 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2663 CaptureStderr();
2664 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2665 EXPECT_EQ("", GetCapturedStderr());
2666}
2667
Daniel Norman85aed542019-08-21 12:01:14 -07002668class AidlTestCompatibleChanges : public AidlTest {
2669 protected:
2670 Options options_ = Options::From("aidl --checkapi old new");
2671};
2672
2673TEST_F(AidlTestCompatibleChanges, NewType) {
2674 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2675 "package p;"
2676 "interface IFoo {"
2677 " void foo(int a);"
2678 "}");
2679 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2680 "package p;"
2681 "interface IFoo {"
2682 " void foo(int a);"
2683 "}");
2684 io_delegate_.SetFileContents("new/p/IBar.aidl",
2685 "package p;"
2686 "interface IBar {"
2687 " void bar();"
2688 "}");
2689 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2690}
2691
2692TEST_F(AidlTestCompatibleChanges, NewMethod) {
2693 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2694 "package p;"
2695 "interface IFoo {"
2696 " void foo(int a);"
2697 "}");
2698 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2699 "package p;"
2700 "interface IFoo {"
2701 " void foo(int a);"
2702 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002703 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002704 "}");
2705 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2706}
2707
2708TEST_F(AidlTestCompatibleChanges, NewField) {
2709 io_delegate_.SetFileContents("old/p/Data.aidl",
2710 "package p;"
2711 "parcelable Data {"
2712 " int foo;"
2713 "}");
2714 io_delegate_.SetFileContents("new/p/Data.aidl",
2715 "package p;"
2716 "parcelable Data {"
2717 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002718 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002719 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002720 "}");
2721 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2722}
2723
Jooyung Han05bd8a82021-04-28 23:56:38 +09002724TEST_F(AidlTestCompatibleChanges, NewField2) {
2725 io_delegate_.SetFileContents("old/p/Data.aidl",
2726 "package p;"
2727 "parcelable Data {"
2728 "}");
2729 io_delegate_.SetFileContents("new/p/Data.aidl",
2730 "package p;"
2731 "parcelable Data {"
2732 " int foo = 0;"
2733 "}");
2734 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2735}
2736
Daniel Norman85aed542019-08-21 12:01:14 -07002737TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2738 io_delegate_.SetFileContents("old/p/Enum.aidl",
2739 "package p;"
2740 "enum Enum {"
2741 " FOO = 1,"
2742 "}");
2743 io_delegate_.SetFileContents("new/p/Enum.aidl",
2744 "package p;"
2745 "enum Enum {"
2746 " FOO = 1,"
2747 " BAR = 2,"
2748 "}");
2749 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2750}
2751
2752TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2753 io_delegate_.SetFileContents("old/p/Enum.aidl",
2754 "package p;"
2755 "enum Enum {"
2756 " FOO = 1,"
2757 " BAR = 2,"
2758 "}");
2759 io_delegate_.SetFileContents("new/p/Enum.aidl",
2760 "package p;"
2761 "enum Enum {"
2762 " BAR = 2,"
2763 " FOO = 1,"
2764 "}");
2765 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2766}
2767
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002768TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2769 io_delegate_.SetFileContents("old/p/Union.aidl",
2770 "package p;"
2771 "union Union {"
2772 " String foo;"
2773 "}");
2774 io_delegate_.SetFileContents("new/p/Union.aidl",
2775 "package p;"
2776 "union Union {"
2777 " String foo;"
2778 " int num;"
2779 "}");
2780 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2781}
2782
Daniel Norman85aed542019-08-21 12:01:14 -07002783TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002784 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2785 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002786 "interface IFoo {"
2787 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002788 "}");
2789 io_delegate_.SetFileContents("old/p/Data.aidl",
2790 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002791 "parcelable Data {"
2792 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002793 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002794 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2795 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002796 "interface IFoo {"
2797 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002798 "}");
2799 io_delegate_.SetFileContents("new/p/Data.aidl",
2800 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002801 "parcelable Data {"
2802 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002803 "}");
2804 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2805 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002806 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002807 " void foo(int a);"
2808 "}");
2809 io_delegate_.SetFileContents("new/q/Data.aidl",
2810 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002811 "parcelable Data {"
2812 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002813 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002814 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2815}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002816
Daniel Norman85aed542019-08-21 12:01:14 -07002817TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2818 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2819 "package p;"
2820 "interface IFoo {"
2821 " void foo(int a);"
2822 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002823 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2824 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002825 "interface IFoo {"
2826 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002827 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002828 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2829}
Jiyong Parke59c3682018-09-11 23:10:25 +09002830
Daniel Norman85aed542019-08-21 12:01:14 -07002831TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002832 io_delegate_.SetFileContents("old/p/I.aidl",
2833 "package p; interface I {"
2834 "const int A = 1; }");
2835 io_delegate_.SetFileContents("new/p/I.aidl",
2836 "package p ; interface I {"
2837 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002838 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2839}
Jiyong Parka428d212018-08-29 22:26:30 +09002840
Daniel Norman85aed542019-08-21 12:01:14 -07002841TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002842 io_delegate_.SetFileContents("old/p/I.aidl",
2843 "package p; interface I {"
2844 "const int A = 1; const int B = 2;}");
2845 io_delegate_.SetFileContents("new/p/I.aidl",
2846 "package p ; interface I {"
2847 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002848 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002849}
2850
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002851TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2852 io_delegate_.SetFileContents("old/p/Foo.aidl",
2853 "package p;"
2854 "@JavaPassthrough(annotation=\"Alice\")"
2855 "@JavaPassthrough(annotation=\"Bob\")"
2856 "parcelable Foo {}");
2857 io_delegate_.SetFileContents("new/p/Foo.aidl",
2858 "package p;"
2859 "@JavaPassthrough(annotation=\"Bob\")"
2860 "@JavaPassthrough(annotation=\"Alice\")"
2861 "parcelable Foo {}");
2862 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2863}
2864
Jooyung Han00073272020-11-27 14:20:20 +09002865TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2866 io_delegate_.SetFileContents("old/p/Foo.aidl",
2867 "package p;"
2868 "parcelable Foo {}");
2869 io_delegate_.SetFileContents("new/p/Foo.aidl",
2870 "package p;"
2871 "@JavaPassthrough(annotation=\"@Deprecated\")"
2872 "parcelable Foo {}");
2873 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2874}
2875
Jooyung Han636fd2f2020-10-22 11:33:45 +09002876TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2877 io_delegate_.SetFileContents("old/p/Data.aidl",
2878 "package p;"
2879 "parcelable Data {"
2880 " int num;"
2881 "}");
2882 io_delegate_.SetFileContents(
2883 "new/p/Data.aidl",
2884 "package p;"
2885 "parcelable Data {"
2886 " int num;"
2887 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2888 "}");
2889 io_delegate_.SetFileContents("new/p/Enum.aidl",
2890 "package p;"
2891 "enum Enum {"
2892 " FOO = 0,"
2893 " BAR = 1,"
2894 "}");
2895 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2896}
2897
Jooyung Han308bbe02021-04-27 12:09:59 +09002898TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2899 io_delegate_.SetFileContents("old/p/Data.aidl",
2900 "package p;\n"
2901 "parcelable Data {\n"
2902 " p.Enum e;\n"
2903 "}");
2904 io_delegate_.SetFileContents("old/p/Enum.aidl",
2905 "package p;\n"
2906 "enum Enum {\n"
2907 " FOO = 0,\n"
2908 " BAR = 1,\n"
2909 "}");
2910 io_delegate_.SetFileContents("new/p/Data.aidl",
2911 "package p;\n"
2912 "parcelable Data {\n"
2913 " p.Enum e = p.Enum.FOO;\n"
2914 "}");
2915 io_delegate_.SetFileContents("new/p/Enum.aidl",
2916 "package p;\n"
2917 "enum Enum {\n"
2918 " FOO = 0,\n"
2919 " BAR = 1,\n"
2920 "}");
2921 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2922}
2923
Daniel Norman85aed542019-08-21 12:01:14 -07002924class AidlTestIncompatibleChanges : public AidlTest {
2925 protected:
2926 Options options_ = Options::From("aidl --checkapi old new");
2927};
2928
2929TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002930 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002931 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2932 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002933 "interface IFoo {"
2934 " void foo(in String[] str);"
2935 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002936 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002937 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002938 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002940}
2941
2942TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002943 const string expected_stderr =
2944 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002945 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2946 "package p;"
2947 "interface IFoo {"
2948 " void foo(in String[] str);"
2949 " void bar(@utf8InCpp String str);"
2950 "}");
2951 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2952 "package p;"
2953 "interface IFoo {"
2954 " void foo(in String[] str);"
2955 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002956 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002957 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002958 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002959}
2960
Jiyong Parkf8d53612020-05-04 14:06:13 +09002961TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2962 const string expected_stderr =
2963 "ERROR: new/p/IFoo.aidl:1.61-65: "
2964 "Encountered an untyped List or Map. The use of untyped List/Map is "
2965 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2966 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2967 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2968 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2969 "package p;"
2970 "interface IFoo {"
2971 " void foo(in String[] str);"
2972 "}");
2973 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2974 "package p;"
2975 "interface IFoo {"
2976 " void foo(in String[] str);"
2977 " void bar(in List arg);"
2978 "}");
2979 CaptureStderr();
2980 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2981 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2982}
2983
2984TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2985 const string expected_stderr =
2986 "ERROR: new/p/Data.aidl:1.54-59: "
2987 "Encountered an untyped List or Map. The use of untyped List/Map is "
2988 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2989 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2990 "ERROR: new/p/Data.aidl: Failed to read.\n";
2991 io_delegate_.SetFileContents("old/p/Data.aidl",
2992 "package p;"
2993 "parcelable Data {"
2994 " int foo;"
2995 "}");
2996 io_delegate_.SetFileContents("new/p/Data.aidl",
2997 "package p;"
2998 "parcelable Data {"
2999 " int foo;"
3000 " @nullable List list;"
3001 "}");
3002 CaptureStderr();
3003 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3005}
3006
Daniel Norman85aed542019-08-21 12:01:14 -07003007TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003008 const string expected_stderr =
3009 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003010 io_delegate_.SetFileContents("old/p/Data.aidl",
3011 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003012 "parcelable Data {"
3013 " int foo;"
3014 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003015 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003016 io_delegate_.SetFileContents("new/p/Data.aidl",
3017 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003018 "parcelable Data {"
3019 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003020 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003021 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003022 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003023 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003024}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003025
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003026TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
3027 const string expected_stderr =
3028 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
3029 "backends. Please either provide a default value for this field or mark the field as "
3030 "@nullable. This value or a null value will be used automatically when an old version of "
3031 "this parcelable is sent to a process which understands a new version of this parcelable. In "
3032 "order to make sure your code continues to be backwards compatible, make sure the default or "
3033 "null value does not cause a semantic change to this parcelable.\n";
3034 io_delegate_.SetFileContents("old/p/Data.aidl",
3035 "package p;"
3036 "parcelable Data {"
3037 " int num;"
3038 "}");
3039 io_delegate_.SetFileContents("new/p/Data.aidl",
3040 "package p;"
3041 "parcelable Data {"
3042 " int num;"
3043 " String str;"
3044 "}");
3045 CaptureStderr();
3046 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3047 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3048}
3049
Jooyung Han636fd2f2020-10-22 11:33:45 +09003050TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
3051 const string expected_stderr =
3052 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
3053 "Please make sure 'Enum' has '0' as a valid value.\n";
3054 io_delegate_.SetFileContents("old/p/Data.aidl",
3055 "package p;"
3056 "parcelable Data {"
3057 " int num;"
3058 "}");
3059 io_delegate_.SetFileContents("new/p/Data.aidl",
3060 "package p;"
3061 "parcelable Data {"
3062 " int num;"
3063 " p.Enum e;"
3064 "}");
3065 io_delegate_.SetFileContents("new/p/Enum.aidl",
3066 "package p;"
3067 "enum Enum {"
3068 " FOO = 1,"
3069 " BAR = 2,"
3070 "}");
3071 CaptureStderr();
3072 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3073 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3074}
3075
Daniel Norman85aed542019-08-21 12:01:14 -07003076TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003077 const string expected_stderr =
3078 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003079 io_delegate_.SetFileContents("old/p/Enum.aidl",
3080 "package p;"
3081 "enum Enum {"
3082 " FOO = 1,"
3083 " BAR = 2,"
3084 "}");
3085 io_delegate_.SetFileContents("new/p/Enum.aidl",
3086 "package p;"
3087 "enum Enum {"
3088 " BAR = 2,"
3089 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003090 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003091 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003092 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003093}
3094
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003095TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3096 const string expected_stderr =
3097 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3098 io_delegate_.SetFileContents("old/p/Union.aidl",
3099 "package p;"
3100 "union Union {"
3101 " String str;"
3102 " int num;"
3103 "}");
3104 io_delegate_.SetFileContents("new/p/Union.aidl",
3105 "package p;"
3106 "union Union {"
3107 " String str;"
3108 "}");
3109 CaptureStderr();
3110 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3111 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3112}
3113
Daniel Norman85aed542019-08-21 12:01:14 -07003114TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003115 const string expected_stderr =
3116 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003117 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3118 "package p;"
3119 "interface IFoo {"
3120 " void foo(in String[] str);"
3121 " void bar(@utf8InCpp String str);"
3122 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003123 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3124 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003125 "interface IFoo {"
3126 " void foo(in String[] str);"
3127 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003128 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003129 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003130 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003131 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003132}
3133
Daniel Norman85aed542019-08-21 12:01:14 -07003134TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003135 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003136 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3137 "package p;"
3138 "interface IFoo {"
3139 " void foo(in String[] str);"
3140 " void bar(@utf8InCpp String str);"
3141 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003142 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3143 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003144 "interface IFoo2 {"
3145 " void foo(in String[] str);"
3146 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003147 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003148 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003149 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003150 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003151}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003152
Daniel Norman85aed542019-08-21 12:01:14 -07003153TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003154 const string expected_stderr =
3155 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003156 io_delegate_.SetFileContents("old/p/Enum.aidl",
3157 "package p;"
3158 "enum Enum {"
3159 " FOO = 1,"
3160 " BAR = 2,"
3161 "}");
3162 io_delegate_.SetFileContents("new/p/Enum.aidl",
3163 "package p;"
3164 "enum Enum {"
3165 " FOO = 3,"
3166 " BAR = 2,"
3167 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003168 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003169 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003170 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003171}
3172
3173TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003174 const string expected_stderr =
3175 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3176 "from 0 to 1.\n"
3177 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3178 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003179 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3180 "package p;"
3181 "interface IFoo {"
3182 " void foo(in String[] str);"
3183 " void bar(@utf8InCpp String str);"
3184 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003185 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3186 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003187 "interface IFoo {"
3188 " void bar(@utf8InCpp String str);"
3189 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003190 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003191 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003192 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003194}
3195
3196TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003197 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003198 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3199 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003200 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003201 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003202 "parcelable Data {"
3203 " int foo;"
3204 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003205 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003206 io_delegate_.SetFileContents("new/p/Data.aidl",
3207 "package p;"
3208 "parcelable Data {"
3209 " int bar;"
3210 " int foo;"
3211 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003212 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003213 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003214 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003215}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003216
Daniel Norman85aed542019-08-21 12:01:14 -07003217TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003218 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003219 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003220 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003221 "interface IFoo {"
3222 " void foo(in String[] str);"
3223 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003224 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003225 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3226 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003227 "interface IFoo {"
3228 " void foo(out String[] str);"
3229 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003230 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003231 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003232 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003234}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003235
Daniel Norman85aed542019-08-21 12:01:14 -07003236TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003237 const string expected_stderr =
3238 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003239 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3240 "package p;"
3241 "interface IFoo {"
3242 " void foo(in String[] str);"
3243 " void bar(@utf8InCpp String str);"
3244 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003245 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3246 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003247 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003248 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003249 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003250 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003251 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003252 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003253 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003254}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003255
Daniel Norman85aed542019-08-21 12:01:14 -07003256TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003257 const string expected_stderr =
3258 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003259 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3260 "package p;"
3261 "interface IFoo {"
3262 " void foo(in String[] str);"
3263 " void bar(@utf8InCpp String str);"
3264 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003265 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3266 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003267 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003268 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003269 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003270 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003271 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003272 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003274}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003275
Jooyung Han60b2fde2020-10-29 15:12:40 +09003276TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3277 const string expected_stderr =
3278 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3279 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3280 io_delegate_.SetFileContents("old/p/Foo.aidl",
3281 "package p;"
3282 "@Backing(type=\"byte\")"
3283 "enum Foo {"
3284 " FOO, BAR,"
3285 "}");
3286 io_delegate_.SetFileContents("new/p/Foo.aidl",
3287 "package p;"
3288 "@Backing(type=\"long\")"
3289 "enum Foo {"
3290 " FOO, BAR,"
3291 "}");
3292 CaptureStderr();
3293 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3294 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3295}
3296
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003297TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3298 const string expected_stderr =
3299 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3300 "to @JavaPassthrough(annotation=\"Bob\")\n";
3301 io_delegate_.SetFileContents("old/p/Foo.aidl",
3302 "package p;"
3303 "@JavaPassthrough(annotation=\"Alice\")"
3304 "parcelable Foo {}");
3305 io_delegate_.SetFileContents("new/p/Foo.aidl",
3306 "package p;"
3307 "@JavaPassthrough(annotation=\"Bob\")"
3308 "parcelable Foo {}");
3309
3310 CaptureStderr();
3311 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3313}
3314
Devin Mooredb7ac512020-08-07 11:17:36 -07003315TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3316 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003317 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003318 io_delegate_.SetFileContents("old/p/Foo.aidl",
3319 "package p;"
3320 "parcelable Foo {"
3321 " int A;"
3322 "}");
3323 io_delegate_.SetFileContents("new/p/Foo.aidl",
3324 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003325 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003326 " int A;"
3327 "}");
3328 CaptureStderr();
3329 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3330 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3331}
3332
3333TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3334 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003335 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003336 io_delegate_.SetFileContents("old/p/Foo.aidl",
3337 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003338 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003339 " int A;"
3340 "}");
3341 io_delegate_.SetFileContents("new/p/Foo.aidl",
3342 "package p;"
3343 "parcelable Foo {"
3344 " int A;"
3345 "}");
3346 CaptureStderr();
3347 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3348 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3349}
3350
Daniel Norman85aed542019-08-21 12:01:14 -07003351TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003352 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003353 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3354 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003355 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003356 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003357 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003359}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003360
Daniel Norman85aed542019-08-21 12:01:14 -07003361TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003362 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003363 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3364 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003365 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003366 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003367 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003368}
Jiyong Parka428d212018-08-29 22:26:30 +09003369
Daniel Norman85aed542019-08-21 12:01:14 -07003370TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003371 const string expected_stderr =
3372 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003373 io_delegate_.SetFileContents("old/p/I.aidl",
3374 "package p; interface I {"
3375 "const int A = 1; const int B = 2;}");
3376 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003377 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003378 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003379 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003380}
Jiyong Parka428d212018-08-29 22:26:30 +09003381
Daniel Norman85aed542019-08-21 12:01:14 -07003382TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003383 const string expected_stderr =
3384 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003385 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3386 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003387 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003388 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003389 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003390}
3391
Devin Moorec7e47a32020-08-07 10:55:25 -07003392TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3393 const string expected_stderr =
3394 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3395 "This is an incompatible change for FixedSize types.\n";
3396 io_delegate_.SetFileContents("old/p/Foo.aidl",
3397 "package p; @FixedSize parcelable Foo { int A = 1; }");
3398 io_delegate_.SetFileContents("new/p/Foo.aidl",
3399 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3400 CaptureStderr();
3401 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3403}
3404
Jeongik Cha68d18e72021-04-29 20:07:01 +09003405TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3406 const string expected_stderr =
3407 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3408 "android.net.UidRangeParcel is changed from 1 to 2. "
3409 "But it is forbidden because of legacy support.\n";
3410 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3411 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3412 io_delegate_.SetFileContents(
3413 "new/android/net/UidRangeParcel.aidl",
3414 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3415 CaptureStderr();
3416 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3418}
3419
Devin Moorec7e47a32020-08-07 10:55:25 -07003420TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3421 const string expected_stderr =
3422 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3423 io_delegate_.SetFileContents("old/p/Foo.aidl",
3424 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3425 io_delegate_.SetFileContents("new/p/Foo.aidl",
3426 "package p; @FixedSize parcelable Foo { int A = 1; }");
3427 CaptureStderr();
3428 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3430}
3431
3432TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3433 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003434 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003435 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003436 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3437 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003438 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003439 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003440 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003441 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003442 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003443 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3444 "f.\n"
3445 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3446 "nullable1.\n"
3447 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3448 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003449
3450 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003451 "@FixedSize parcelable Foo {\n"
3452 " int[] a;\n"
3453 " Bar b;\n"
3454 " String c;\n"
3455 " ParcelFileDescriptor d;\n"
3456 " IBinder e;\n"
3457 " List<String> f;\n"
3458 " int isFixedSize;\n"
3459 " @nullable OtherFixed nullable1;\n"
3460 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003461 "}");
3462 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003463 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003464 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003465
3466 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003467 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003468 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3469}
3470
3471TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3472 const string expected_stderr = "";
3473
3474 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3475 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3476 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003477 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003478
3479 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003480 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003481 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3482}
3483
Jiyong Park8c380532018-08-30 14:55:26 +09003484TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003485 const string expected_stderr =
3486 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3487 "dir1/q/IBar.aidl\n"
3488 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003489 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003490 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3491 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3492 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3493 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3494
Devin Moore097a3ab2020-03-11 16:08:44 -07003495 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003496 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003497 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003498}
3499
Jiyong Parked65bf42018-08-28 15:43:27 +09003500TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003501 const string expected_stderr =
3502 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3503 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003504 Options options = Options::From("aidl --checkapi old new");
3505 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3506 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003507
3508 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3509
Jiyong Parke59c3682018-09-11 23:10:25 +09003510 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003511 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003512 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003513 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003514}
3515
Jooyung Han652ce482021-02-26 12:40:35 +09003516TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3517 Options options =
3518 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003519
3520 // use without import
3521 io_delegate_.SetFileContents("p/IFoo.aidl",
3522 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003523 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003524
3525 // capture output files
3526 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003527
Devin Moore7b8d5c92020-03-17 14:14:08 -07003528 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003529 io_delegate_.SetFileContents(
3530 "p/IFoo.aidl",
3531 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003532 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003533 // output files should be the same
3534 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003535
3536 // use with import (as before)
3537 io_delegate_.SetFileContents("p/IFoo.aidl",
3538 "package p;"
3539 "import android.os.ParcelFileDescriptor;"
3540 "interface IFoo{"
3541 " void foo(in ParcelFileDescriptor fd);"
3542 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003543 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003544 // output files should be the same
3545 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003546}
Jiyong Parked65bf42018-08-28 15:43:27 +09003547
Jooyung Han020d8d12021-02-26 17:23:02 +09003548TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3549 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3550 CaptureStderr();
3551 io_delegate_.SetFileContents("p/IFoo.aidl",
3552 "package p;"
3553 "interface IFoo{"
3554 " void foo(out ParcelFileDescriptor fd);"
3555 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003556 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003557 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3558}
3559
3560TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3561 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3562 CaptureStderr();
3563 io_delegate_.SetFileContents("p/IFoo.aidl",
3564 "package p;"
3565 "interface IFoo{"
3566 " void foo(ParcelFileDescriptor fd);"
3567 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003568 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003569 EXPECT_THAT(GetCapturedStderr(),
3570 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3571}
3572
Jiyong Park3633b722019-04-11 15:38:26 +09003573TEST_F(AidlTest, ManualIds) {
3574 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3575 io_delegate_.SetFileContents("IFoo.aidl",
3576 "interface IFoo {\n"
3577 " void foo() = 0;\n"
3578 " void bar() = 1;\n"
3579 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003580 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003581}
3582
3583TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3584 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3585 io_delegate_.SetFileContents("IFoo.aidl",
3586 "interface IFoo {\n"
3587 " void foo() = 0;\n"
3588 " void bar() = 1;\n"
3589 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003590 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003591}
3592
3593TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003594 const string expected_stderr =
3595 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003596 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3597 io_delegate_.SetFileContents("IFoo.aidl",
3598 "interface IFoo {\n"
3599 " void foo() = 3;\n"
3600 " void bar() = 3;\n"
3601 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003602 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003603 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003604 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003605}
3606
3607TEST_F(AidlTest, FailOnOutOfRangeIds) {
3608 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003609 const string expected_stderr =
3610 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3611 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003612 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3613 io_delegate_.SetFileContents("IFoo.aidl",
3614 "interface IFoo {\n"
3615 " void foo() = 3;\n"
3616 " void bar() = 16777115;\n"
3617 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003618 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003619 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003620 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003621}
3622
3623TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003624 const string expected_stderr =
3625 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003626 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3627 io_delegate_.SetFileContents("IFoo.aidl",
3628 "interface IFoo {\n"
3629 " void foo() = 3;\n"
3630 " void bar();\n"
3631 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003632 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003633 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003634 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003635}
3636
Jiyong Parkc6816252019-07-08 08:12:28 +09003637TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3638 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3639 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3640 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003641 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003642}
3643
3644TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003645 const string expected_stderr =
3646 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3647 "dir/IBar.aidl\n"
3648 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003649 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003650
Jiyong Parkc6816252019-07-08 08:12:28 +09003651 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3652 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3653 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3654 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003655 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003656 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003658}
3659
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003660TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3661 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3662 "package a.b;\n"
3663 "import a.b.IBar;\n"
3664 "import a.b.IQux;\n"
3665 "interface IFoo { IQux foo(); }\n");
3666 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3667 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3668
3669 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003670 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003671
3672 string output;
3673 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3674 // IBar was imported but wasn't used. include is not expected.
3675 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3676 // IBar was imported and used. include is expected.
3677 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3678}
3679
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003680TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003681 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003682 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003683 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3684 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003685 interface IFoo {
3686 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003687 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003688 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003689 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003690 // JavaPassthrough should work with other types as well (e.g. enum)
3691 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3692 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3693 @JavaPassthrough(annotation="@com.android.AliceTwo")
3694 @Backing(type="byte")
3695 enum MyEnum {
3696 a, b, c
3697 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003698
Jooyung Han4cde01d2020-10-13 11:10:47 +09003699 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003700 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003701
3702 string java_out;
3703 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003704 // type-decl-level annotations with newline at the end
3705 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3706 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3707 // member-decl-level annotations with newline at the end
3708 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3709 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3710 // inline annotations with space at the end
3711 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003712
Jooyung Han4cde01d2020-10-13 11:10:47 +09003713 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3714 // type-decl-level annotations with newline at the end
3715 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3716 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3717
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003718 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003719 Options cpp_options =
3720 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003721 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003722
Jooyung Han4cde01d2020-10-13 11:10:47 +09003723 Options ndk_options =
3724 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003725 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003726
Jooyung Han4cde01d2020-10-13 11:10:47 +09003727 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003728 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003729}
3730
Andrei Homescue61feb52020-08-18 15:44:24 -07003731TEST_F(AidlTest, ParseRustDerive) {
3732 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3733 @RustDerive(Clone=true, Copy=false)
3734 parcelable Foo {
3735 int a;
3736 })");
3737
3738 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003739 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003740
3741 string rust_out;
3742 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3743 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3744
3745 // Other backends shouldn't be bothered
3746 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003747 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003748
3749 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003750 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003751
3752 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003753 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003754}
3755
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003756TEST_F(AidlTest, EmptyEnforceAnnotation) {
3757 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3758 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3759 interface IFoo {
3760 @Enforce()
3761 void Protected();
3762 })");
3763
3764 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3765 CaptureStderr();
3766 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3767 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3768}
3769
3770TEST_F(AidlTest, EmptyEnforceCondition) {
3771 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3772 interface IFoo {
3773 @Enforce(condition="")
3774 void Protected();
3775 })");
3776
3777 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3778 CaptureStderr();
3779 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3780 EXPECT_THAT(GetCapturedStderr(),
3781 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3782}
3783
3784TEST_F(AidlTest, InvalidEnforceCondition) {
3785 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3786 interface IFoo {
3787 @Enforce(condition="invalid")
3788 void Protected();
3789 })");
3790
3791 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3792 CaptureStderr();
3793 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3794 EXPECT_THAT(GetCapturedStderr(),
3795 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3796}
3797
Jiyong Park56f73d72019-06-11 12:20:28 +09003798class AidlOutputPathTest : public AidlTest {
3799 protected:
3800 void SetUp() override {
3801 AidlTest::SetUp();
3802 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3803 }
3804
3805 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003806 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003807 // check the existence
3808 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3809 }
3810};
3811
3812TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3813 // <out_dir> / <package_name> / <type_name>.java
3814 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3815}
3816
3817TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3818 // when output file is explicitly set, it is always respected. -o option is
3819 // ignored.
3820 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3821}
3822
3823TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3824 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3825}
3826
3827TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3828 // output is the same as the input file except for the suffix
3829 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3830}
3831
Devin Moore7b8d5c92020-03-17 14:14:08 -07003832TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003833 AidlError error;
3834 const string expected_stderr =
3835 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3836 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003837 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3838 R"(package p;
3839 interface IFoo {
3840 const int int32_max_oob = 2147483650;
3841 }
3842 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003843 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003844 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3845 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003846}
3847
Devin Moore7b8d5c92020-03-17 14:14:08 -07003848TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003849 AidlError error;
3850 const string expected_stderr =
3851 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3852 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003853 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3854 R"(package p;
3855 interface IFoo {
3856 const int int32_min_oob = -2147483650;
3857 }
3858 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003859 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003860 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3861 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003862}
3863
Devin Moore7b8d5c92020-03-17 14:14:08 -07003864TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003865 AidlError error;
3866 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003867 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003868 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003869 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3870 R"(package p;
3871 interface IFoo {
3872 const long int64_max_oob = 21474836509999999999999999;
3873 }
3874 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003875 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003876 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3877 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003878}
3879
Devin Moore7b8d5c92020-03-17 14:14:08 -07003880TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003881 AidlError error;
3882 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003883 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003884 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003885 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3886 R"(package p;
3887 interface IFoo {
3888 const long int64_min_oob = -21474836509999999999999999;
3889 }
3890 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003891 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003892 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3893 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003894}
3895
Devin Moore7b8d5c92020-03-17 14:14:08 -07003896TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003897 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003898 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003899 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003900 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3901 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003902 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3903 R"(package p;
3904 @Backing(type="byte")
3905 enum TestEnum {
3906 FOO = 127,
3907 BAR,
3908 }
3909 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003910 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003911 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003912 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003913}
3914
Steven Morelandb248d072021-09-29 19:07:17 -07003915TEST_P(AidlTest, FailOnUnsupportedBackingType) {
3916 AidlError error;
3917 const string expected_stderr =
3918 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
3919 "byte, int, long\n";
3920 CaptureStderr();
3921 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3922 R"(package p;
3923 @Backing(type="boolean")
3924 enum TestEnum {
3925 FOO = 0,
3926 BAR = 1,
3927 }
3928 )",
3929 typenames_, GetLanguage(), &error));
3930 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3931 EXPECT_EQ(AidlError::BAD_TYPE, error);
3932}
3933
Devin Mooredecaf292020-04-30 09:16:40 -07003934TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3935 AidlError error;
3936 const string expected_stderr =
3937 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003938 "be one of: type\n";
3939 CaptureStderr();
3940 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3941 R"(package p;
3942 @Backing(foo="byte")
3943 enum TestEnum {
3944 FOO = 1,
3945 BAR,
3946 }
3947 )",
3948 typenames_, GetLanguage(), &error));
3949 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3950 EXPECT_EQ(AidlError::BAD_TYPE, error);
3951}
3952
Jooyung Han5721a232020-12-24 04:34:55 +09003953TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3954 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3955 CaptureStderr();
3956 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3957 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3958}
3959
Jooyung Han66813932020-10-23 13:24:44 +09003960TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003961 io_delegate_.SetFileContents("Foo.aidl",
3962 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3963 "Map<String, Baz> d; Bar[] e; }");
3964 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3965 io_delegate_.SetFileContents("Baz.aidl",
3966 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003967 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003968 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003969}
3970
Jooyung Han66813932020-10-23 13:24:44 +09003971TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003972 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003973 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003974 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003975 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3976 "named 'bar'.\n";
3977 CaptureStderr();
3978 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003979 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003980 EXPECT_EQ(expected_error, GetCapturedStderr());
3981}
3982
Jooyung Han09e551c2021-05-11 11:44:48 +09003983TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3984 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3985 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3986 CaptureStderr();
3987 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003988 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003989 EXPECT_EQ("", GetCapturedStderr());
3990}
3991
Jooyung Han59af9cc2020-10-25 21:44:14 +09003992TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3993 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3994 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3995 string expected_error =
3996 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003997 "named 'bar'.\n";
3998 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003999 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004000 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09004001 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004002}
4003
Jooyung Han66813932020-10-23 13:24:44 +09004004TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004005 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004006 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
4007 string expected_error =
4008 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
4009 "only be an in parameter.\n";
4010 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004011 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004012 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004013 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004014}
4015
Jooyung Han66813932020-10-23 13:24:44 +09004016TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004017 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004018 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
4019 string expected_error =
4020 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
4021 "only be an in parameter.\n";
4022 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004023 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004024 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004025 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004026}
4027
Jooyung Han66813932020-10-23 13:24:44 +09004028TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004029 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09004030 Options options = Options::From("aidl --lang=java Foo.aidl");
4031 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09004032 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
4033 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09004034 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004035 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09004036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4037}
Devin Moore53fc99c2020-08-12 08:07:52 -07004038
Jooyung Hanfe086af2021-01-16 03:44:47 +09004039TEST_P(AidlTest, UnionInUnion) {
4040 import_paths_.insert(".");
4041 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
4042 CaptureStderr();
4043 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
4044 EXPECT_THAT("", GetCapturedStderr());
4045}
4046
Jooyung Hanfe89f122020-10-14 03:49:18 +09004047TEST_P(AidlTest, UnionRejectsEmptyDecl) {
4048 const string method = "package a; union Foo {}";
4049 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
4050 CaptureStderr();
4051 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4052 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4053}
4054
4055TEST_P(AidlTest, UnionRejectsParcelableHolder) {
4056 const string method = "package a; union Foo { ParcelableHolder x; }";
4057 const string expected_stderr =
4058 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
4059 CaptureStderr();
4060 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4061 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4062}
4063
Jooyung Han53fb4242020-12-17 16:03:49 +09004064TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
4065 import_paths_.insert(".");
4066 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
4067 const string expected_err = "The union's first member should have a useful default value.";
4068 CaptureStderr();
4069 EXPECT_EQ(nullptr,
4070 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
4071 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
4072}
4073
Devin Moore53fc99c2020-08-12 08:07:52 -07004074TEST_P(AidlTest, GenericStructuredParcelable) {
4075 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004076 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004077 const string expected_stderr = "";
4078 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004079 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004080 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4081}
4082
Jooyung Han3f347ca2020-12-01 12:41:50 +09004083TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4084 io_delegate_.SetFileContents("Foo.aidl",
4085 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4086 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004087 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004088 const string expected_stderr = "";
4089 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004090 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004091 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4092
4093 string code;
4094 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4095 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4096const ::android::String16& Foo<T,U>::s() {
4097 static const ::android::String16 value(::android::String16(""));
4098 return value;
4099})--"));
4100}
4101
4102TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4103 io_delegate_.SetFileContents("Foo.aidl",
4104 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4105 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004106 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004107 const string expected_stderr = "";
4108 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004109 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4111
4112 string code;
4113 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4114 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4115const char* Foo<T, U>::s = "";
4116)--"));
4117}
4118
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004119TEST_F(AidlTest, NestedTypeArgs) {
4120 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004121 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4122
4123 io_delegate_.SetFileContents("a/Foo.aidl",
4124 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4125 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004126 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4127 const string expected_stderr = "";
4128 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004129 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004130 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4131
4132 string code;
4133 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004134 EXPECT_THAT(code,
4135 testing::HasSubstr(
4136 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4137}
4138
4139TEST_F(AidlTest, DoubleArrayError) {
4140 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4141
4142 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4143 const string expected_stderr =
4144 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4145 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004146 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004147 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4148}
4149
4150TEST_F(AidlTest, DoubleGenericError) {
4151 io_delegate_.SetFileContents("a/Bar.aidl",
4152 "package a; parcelable Bar { List<String><String> a; }");
4153
4154 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4155 const string expected_stderr =
4156 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4157 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004158 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004159 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4160}
4161
4162TEST_F(AidlTest, ArrayBeforeGenericError) {
4163 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4164
4165 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004166 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004167 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004168 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4169}
4170
4171TEST_F(AidlTest, NullableArraysAreNotSupported) {
4172 io_delegate_.SetFileContents("a/Bar.aidl",
4173 "package a; parcelable Bar { String @nullable [] a; }");
4174
4175 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4176 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004177 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004178 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4179}
4180
4181TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4182 io_delegate_.SetFileContents("a/Bar.aidl",
4183 "package a; parcelable Bar { List<@nullable String> a; }");
4184
4185 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4186 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004187 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004188 EXPECT_THAT(GetCapturedStderr(),
4189 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004190}
4191
Jooyung Han14004ed2020-10-16 03:49:57 +09004192struct GenericAidlTest : ::testing::Test {
4193 FakeIoDelegate io_delegate_;
4194 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004195 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004196 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4197 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4198 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4199
4200 Options options = Options::From(cmd);
4201 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004202 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004203 EXPECT_EQ("", GetCapturedStderr());
4204 }
4205};
4206
4207TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4208 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4209 string code;
4210 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4211 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4212 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4213 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4214}
4215
4216TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4217 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4218 string code;
4219 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4220 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4221 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4222 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4223}
4224
Devin Moore53fc99c2020-08-12 08:07:52 -07004225TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4226 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004227 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004228 const string expected_stderr =
4229 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4230 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004231 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004232 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4233}
4234
4235TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4236 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004237 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004238 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4239 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004240 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004241 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4242}
4243
Jooyung Han7a308842020-10-27 19:06:49 +09004244TEST_P(AidlTest, LongCommentWithinConstExpression) {
4245 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004246 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004247 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004248 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004249 EXPECT_EQ("", GetCapturedStderr());
4250}
4251
Jeongik Chaef44e622020-10-23 16:00:52 +09004252TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4253 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4254 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4255 std::string expectedErr =
4256 "ERROR: a/Foo.aidl:1.28-30: "
4257 "Encountered an untyped List or Map. The use of untyped List/Map is "
4258 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4259 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4260 "ERROR: a/Foo.aidl:1.35-37: "
4261 "Encountered an untyped List or Map. The use of untyped List/Map is "
4262 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4263 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4264 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004265 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004266 EXPECT_EQ(expectedErr, GetCapturedStderr());
4267}
4268
4269TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004270 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4271 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004272 std::string expectedErr =
4273 "ERROR: a/Foo.aidl:1.33-35: "
4274 "Encountered an untyped List or Map. The use of untyped List/Map is "
4275 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4276 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4277 "ERROR: a/Foo.aidl:1.40-42: "
4278 "Encountered an untyped List or Map. The use of untyped List/Map is "
4279 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4280 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004281 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004282 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004283 EXPECT_EQ(expectedErr, GetCapturedStderr());
4284}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004285
Jeongik Chaef44e622020-10-23 16:00:52 +09004286TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4287 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4288 io_delegate_.SetFileContents(
4289 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4290 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4291 std::string expectedErr =
4292 "ERROR: a/Foo.aidl:1.52-54: "
4293 "Encountered an untyped List or Map. The use of untyped List/Map is "
4294 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4295 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4296 "ERROR: a/Foo.aidl:1.64-66: "
4297 "Encountered an untyped List or Map. The use of untyped List/Map is "
4298 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4299 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4300 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004301 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004302 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004303}
4304
Jooyung Han690f5842020-12-04 13:02:04 +09004305TEST_F(AidlTest, EnumWithDefaults_Java) {
4306 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4307 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4308package p;
4309import p.Enum;
4310parcelable Foo {
4311 Enum e = Enum.BAR;
4312})");
4313 CaptureStderr();
4314 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004315 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004316 auto err = GetCapturedStderr();
4317 EXPECT_EQ("", err);
4318
4319 string code;
4320 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004321 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004322}
4323
4324TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4325 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4326 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4327package p;
4328import p.Enum;
4329parcelable Foo {
4330 Enum e = Enum.BAR;
4331})");
4332 CaptureStderr();
4333 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004334 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004335 auto err = GetCapturedStderr();
4336 EXPECT_EQ("", err);
4337
4338 string code;
4339 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4340 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4341}
4342
4343TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4344 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4345 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4346package p;
4347import p.Enum;
4348parcelable Foo {
4349 Enum e = Enum.BAR;
4350})");
4351 CaptureStderr();
4352 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004353 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004354 auto err = GetCapturedStderr();
4355 EXPECT_EQ("", err);
4356
4357 string code;
4358 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4359 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4360}
4361
4362TEST_F(AidlTest, EnumWithDefaults_Rust) {
4363 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4364 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4365package p;
4366import p.Enum;
4367parcelable Foo {
4368 int n = 42;
4369 Enum e = Enum.BAR;
4370})");
4371 CaptureStderr();
4372 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004373 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004374 auto err = GetCapturedStderr();
4375 EXPECT_EQ("", err);
4376
4377 string code;
4378 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4379 EXPECT_THAT(code, testing::HasSubstr(R"(
4380 fn default() -> Self {
4381 Self {
4382 n: 42,
4383 e: crate::mangled::_1_p_4_Enum::BAR,
4384 }
4385 })"));
4386}
4387
4388TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4389 import_paths_.insert("a");
4390 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4391 CaptureStderr();
4392 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4393package p;
4394import p.Enum;
4395parcelable Foo {
4396 int e = Enum.FOO | Enum.BAR;
4397})",
4398 typenames_, GetLanguage());
4399 auto err = GetCapturedStderr();
4400 EXPECT_EQ("", err);
4401 EXPECT_TRUE(type);
4402 const auto& fields = type->AsStructuredParcelable()->GetFields();
4403 EXPECT_EQ("int e = 3", fields[0]->ToString());
4404}
4405
4406TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4407 CaptureStderr();
4408 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4409@Backing(type="int")
4410enum Foo {
4411 STANDARD_SHIFT = 16,
4412 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4413 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4414}
4415)",
4416 typenames_, GetLanguage());
4417 auto err = GetCapturedStderr();
4418 EXPECT_EQ("", err);
4419 EXPECT_TRUE(type);
4420 const auto& enum_type = type->AsEnumDeclaration();
4421 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004422 auto writer = CodeWriter::ForString(&code);
4423 DumpVisitor visitor(*writer);
4424 visitor.Visit(*enum_type);
4425 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004426 EXPECT_EQ(R"--(@Backing(type="int")
4427enum Foo {
4428 STANDARD_SHIFT = 16,
4429 STANDARD_BT709 = 65536,
4430 STANDARD_BT601_625 = 131072,
4431}
4432)--",
4433 code);
4434}
4435
4436TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4437 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4438 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4439package p;
4440import p.Enum;
4441parcelable Foo {
4442 Enum e = Enum.FOO | Enum.BAR;
4443})");
4444 CaptureStderr();
4445 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004446 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004447 auto err = GetCapturedStderr();
4448 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4449 err);
4450}
4451
Jooyung Han361cd102021-05-24 11:30:10 +09004452TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4453 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4454 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4455package p;
4456import p.Enum;
4457parcelable Foo {
4458 Enum e = 1;
4459})");
4460 CaptureStderr();
4461 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004462 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004463 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4464}
4465
Jooyung Han690f5842020-12-04 13:02:04 +09004466TEST_P(AidlTest, DefaultWithEmptyArray) {
4467 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4468 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4469 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004470 auto options =
4471 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004472 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004473 auto err = GetCapturedStderr();
4474 EXPECT_EQ("", err);
4475}
4476
4477TEST_P(AidlTest, RejectRefsInAnnotation) {
4478 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4479 "package p; interface IFoo {\n"
4480 " const String ANNOTATION = \"@Annotation\";\n"
4481 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4482 "}");
4483 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004484 auto options =
4485 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004486 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004487 auto err = GetCapturedStderr();
4488 EXPECT_EQ(
4489 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4490 "ANNOTATION.\n",
4491 err);
4492}
4493
4494TEST_F(AidlTest, DefaultWithEnumValues) {
4495 io_delegate_.SetFileContents(
4496 "a/p/Foo.aidl",
4497 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4498 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4499 CaptureStderr();
4500 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004501 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004502 auto err = GetCapturedStderr();
4503 EXPECT_EQ("", err);
4504 string code;
4505 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4506 EXPECT_THAT(
4507 code, testing::HasSubstr(
4508 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4509}
4510
Jooyung Han14259392020-12-07 10:00:08 +09004511TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4512 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4513 CaptureStderr();
4514 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004515 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004516 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004517 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004518}
4519
4520TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4521 io_delegate_.SetFileContents("a/p/Foo.aidl",
4522 "package p; parcelable Foo { const int A = A + 1; }");
4523 CaptureStderr();
4524 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004525 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004526 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004527 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4528}
4529
4530TEST_F(AidlTest, RecursiveReferences) {
4531 io_delegate_.SetFileContents("a/p/Foo.aidl",
4532 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4533 io_delegate_.SetFileContents("a/p/Bar.aidl",
4534 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4535 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4536 CaptureStderr();
4537 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004538 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004539 EXPECT_EQ("", GetCapturedStderr());
4540}
4541
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004542TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4543 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4544 auto options =
4545 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4546 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4547 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004548 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004549 EXPECT_EQ(err, GetCapturedStderr());
4550}
4551
4552TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4553 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4554 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4555 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4556 auto options =
4557 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4558 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004559 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004560 EXPECT_EQ("", GetCapturedStderr());
4561}
4562
Jooyung Hane9f5b272021-01-07 00:18:11 +09004563TEST_P(AidlTest, UnknownConstReference) {
Jooyung Hane1abd592021-10-05 10:35:02 +09004564 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { int field = UNKNOWN_REF; }");
Jooyung Hane9f5b272021-01-07 00:18:11 +09004565 auto options =
4566 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4567 const string err =
Jooyung Hane1abd592021-10-05 10:35:02 +09004568 "ERROR: Foo.aidl:1.30-42: Can't find UNKNOWN_REF in Foo\n"
4569 "ERROR: Foo.aidl:1.30-42: Unknown reference 'UNKNOWN_REF'\n";
Jooyung Hane9f5b272021-01-07 00:18:11 +09004570 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004571 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004572 EXPECT_EQ(err, GetCapturedStderr());
4573}
4574
Jooyung Han29813842020-12-08 01:28:03 +09004575TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4576 string contents = R"(
4577import android.os.IBinder;
4578import android.os.IInterface;
4579interface IFoo {}
4580 )";
4581 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004582}
4583
Jooyung Han888c5bc2020-12-22 17:28:47 +09004584TEST_P(AidlTest, WarningInterfaceName) {
4585 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004586 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004587 " -Weverything -o out -h out p/Foo.aidl");
4588 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004589 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004590 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004591 GetCapturedStderr());
4592}
4593
4594TEST_P(AidlTest, ErrorInterfaceName) {
4595 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004596 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004597 " -Weverything -Werror -o out -h out p/Foo.aidl");
4598 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004599 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004600 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004601 GetCapturedStderr());
4602}
4603
Jiyong Park9f4c3822021-04-07 20:36:45 +09004604TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4605 const std::string input_file = "base/p/q/IFoo.aidl";
4606 const std::string header_dir = "out/";
4607 const std::string output_file = "out/base/p/q/IFoo.cpp";
4608 const std::string package = "p.q"; // not base.p.q
4609 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4610
4611 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4612 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004613 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004614 EXPECT_THAT(
4615 GetCapturedStderr(),
4616 testing::StartsWith(
4617 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4618 "but is out/base/p/q/IFoo.cpp."));
4619}
4620
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004621TEST_F(AidlTest, FormatCommentsForJava) {
4622 using android::aidl::FormatCommentsForJava;
4623
4624 struct TestCase {
4625 vector<Comment> comments;
4626 string formatted;
4627 };
4628 vector<TestCase> testcases = {
4629 {{}, ""},
4630 {{{"// line comments\n"}}, "// line comments\n"},
4631 {{{"// @hide \n"}}, "// @hide \n"},
4632 // Transform the last block comment as Javadoc.
4633 {{{"/*\n"
4634 " * Hello, world!\n"
4635 " */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004636 "/** Hello, world! */\n"},
4637 {{{"/* @hide */"}}, "/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004638 {{{"/**\n"
4639 " @param foo ...\n"
4640 "*/"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004641 "/** @param foo ... */\n"},
4642 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide */\n/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004643 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004644 "/* @deprecated first */\n/** @deprecated second */\n"},
4645 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated */\n/** @param foo */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004646 // Line comments are printed as they are
Steven Morelandc29d7172021-10-12 15:25:11 -07004647 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */\n// line comments\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004648 };
4649 for (const auto& [input, formatted] : testcases) {
4650 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4651 }
4652}
4653
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004654TEST_F(AidlTest, HideIsNotForArgs) {
4655 io_delegate_.SetFileContents("IFoo.aidl",
4656 "interface IFoo {\n"
4657 " void foo(in @Hide int x);\n"
4658 "}");
4659 auto options = Options::From("aidl --lang=java IFoo.aidl");
4660 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004661 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004662 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4663}
4664
4665TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4666 io_delegate_.SetFileContents(
4667 "IFoo.aidl",
4668 "interface IFoo {\n"
4669 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4670 "}");
4671 auto options = Options::From("aidl --lang=java IFoo.aidl");
4672 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004673 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004674 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4675}
4676
Jooyung Hanfa181932021-06-12 07:56:53 +09004677TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4678 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4679 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4680 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004681 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004682 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4683}
4684
Jooyung Hanfd3be322020-12-13 09:11:06 +09004685struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004686 string kind;
4687 string literal;
4688};
4689
Jooyung Hanfd3be322020-12-13 09:11:06 +09004690const TypeParam kTypeParams[] = {
Jooyung Hancea89002021-02-15 17:04:04 +09004691 {"primitive", "int"}, {"primitiveArray", "int[]"},
4692 {"String", "String"}, {"StringArray", "String[]"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004693 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4694 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4695 {"union", "a.Union"}, {"interface", "a.IBar"},
4696};
4697
4698const std::map<std::string, std::string> kListSupportExpectations = {
4699 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4700 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4701 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4702 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
Jooyung Hancea89002021-02-15 17:04:04 +09004703 {"cpp_primitiveArray", "List of arrays is not supported."},
4704 {"java_primitiveArray", "List of arrays is not supported."},
4705 {"ndk_primitiveArray", "List of arrays is not supported."},
4706 {"rust_primitiveArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004707 {"cpp_String", ""},
4708 {"java_String", ""},
4709 {"ndk_String", ""},
4710 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004711 {"cpp_StringArray", "List of arrays is not supported."},
4712 {"java_StringArray", "List of arrays is not supported."},
4713 {"ndk_StringArray", "List of arrays is not supported."},
4714 {"rust_StringArray", "List of arrays is not supported."},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004715 {"cpp_IBinder", ""},
4716 {"java_IBinder", ""},
4717 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4718 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004719 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004720 {"java_ParcelFileDescriptor", ""},
4721 {"ndk_ParcelFileDescriptor", ""},
4722 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004723 {"cpp_interface", "List<a.IBar> is not supported."},
4724 {"java_interface", "List<a.IBar> is not supported."},
4725 {"ndk_interface", "List<a.IBar> is not supported."},
4726 {"rust_interface", "List<a.IBar> is not supported."},
4727 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004728 {"java_parcelable", ""},
4729 {"ndk_parcelable", ""},
4730 {"rust_parcelable", ""},
4731 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4732 {"java_enum", "A generic type cannot have any primitive type parameters."},
4733 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4734 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004735 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004736 {"java_union", ""},
4737 {"ndk_union", ""},
4738 {"rust_union", ""},
4739};
4740
Jooyung Hand236e552020-12-13 09:21:27 +09004741const std::map<std::string, std::string> kArraySupportExpectations = {
4742 {"cpp_primitive", ""},
4743 {"java_primitive", ""},
4744 {"ndk_primitive", ""},
4745 {"rust_primitive", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004746 {"cpp_primitiveArray", "Can only have one dimensional arrays."},
4747 {"java_primitiveArray", "Can only have one dimensional arrays."},
4748 {"ndk_primitiveArray", "Can only have one dimensional arrays."},
4749 {"rust_primitiveArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004750 {"cpp_String", ""},
4751 {"java_String", ""},
4752 {"ndk_String", ""},
4753 {"rust_String", ""},
Jooyung Hancea89002021-02-15 17:04:04 +09004754 {"cpp_StringArray", "Can only have one dimensional arrays."},
4755 {"java_StringArray", "Can only have one dimensional arrays."},
4756 {"ndk_StringArray", "Can only have one dimensional arrays."},
4757 {"rust_StringArray", "Can only have one dimensional arrays."},
Jooyung Hand236e552020-12-13 09:21:27 +09004758 {"cpp_IBinder", ""},
4759 {"java_IBinder", ""},
4760 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4761 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4762 {"cpp_ParcelFileDescriptor", ""},
4763 {"java_ParcelFileDescriptor", ""},
4764 {"ndk_ParcelFileDescriptor", ""},
4765 {"rust_ParcelFileDescriptor", ""},
4766 {"cpp_interface", "Binder type cannot be an array"},
4767 {"java_interface", "Binder type cannot be an array"},
4768 {"ndk_interface", "Binder type cannot be an array"},
4769 {"rust_interface", "Binder type cannot be an array"},
4770 {"cpp_parcelable", ""},
4771 {"java_parcelable", ""},
4772 {"ndk_parcelable", ""},
4773 {"rust_parcelable", ""},
4774 {"cpp_enum", ""},
4775 {"java_enum", ""},
4776 {"ndk_enum", ""},
4777 {"rust_enum", ""},
4778 {"cpp_union", ""},
4779 {"java_union", ""},
4780 {"ndk_union", ""},
4781 {"rust_union", ""},
4782};
4783
Jooyung Hanfd3be322020-12-13 09:11:06 +09004784class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004785 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004786 void Run(const std::string& generic_type_decl,
4787 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004788 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004789 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004790 const auto& kind = std::get<1>(param).kind;
4791
4792 FakeIoDelegate io;
4793 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4794 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4795 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004796 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4797 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004798
4799 const auto options =
4800 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4801 CaptureStderr();
4802 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004803 auto it = expectations.find(lang + "_" + kind);
4804 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004805 const string err = GetCapturedStderr();
4806 if (it->second.empty()) {
4807 EXPECT_EQ("", err);
4808 } else {
4809 EXPECT_THAT(err, testing::HasSubstr(it->second));
4810 }
4811 }
4812};
4813
4814INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004815 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004816 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4817 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004818 testing::ValuesIn(kTypeParams)),
4819 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +09004820 return to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004821 });
4822
Jooyung Hanfd3be322020-12-13 09:11:06 +09004823TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4824 Run("List<{}>", kListSupportExpectations);
4825}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004826
Jooyung Hand236e552020-12-13 09:21:27 +09004827TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4828 Run("{}[]", kArraySupportExpectations);
4829}
4830
Christopher Wiley90be4e32015-10-20 14:55:25 -07004831} // namespace aidl
4832} // namespace android