blob: e8e852d0c8af5d0e290187436cac7f921c6b8bd6 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07001254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte (256)\n";
Steven Morelande689da22020-11-10 02:06:30 +00001255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
Jooyung Hanf8c39632021-10-05 09:56:29 +09001477TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1478 const string input_path = "p/IFoo.aidl";
1479 const string input =
1480 "package p;\n"
1481 "interface IFoo {\n"
1482 " parcelable Inner {\n"
1483 " enum Enum { A }\n"
1484 " }\n"
1485 "}";
1486 CaptureStderr();
1487 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1488 EXPECT_EQ(GetCapturedStderr(), "");
1489
1490 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1491 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1492 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1493 EXPECT_TRUE(enum_type.is_resolved);
1494 EXPECT_TRUE(inner_type.is_resolved);
1495 EXPECT_TRUE(ifoo_type.is_resolved);
1496 // GetParentType()
1497 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1498 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1499 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1500 // GetRootType()
1501 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1502 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1503 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1504 // GetDocument()
1505 auto main_document = &typenames_.MainDocument();
1506 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1507 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1508 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1509}
1510
Jooyung Han2aedb112021-09-29 09:37:59 +09001511TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1512 io_delegate_.SetFileContents("p/IOuter.aidl",
1513 "package p;\n"
1514 "interface IOuter {\n"
1515 " parcelable Inner {}\n"
1516 "}");
1517 import_paths_.emplace("");
1518 const string input_path = "p/IFoo.aidl";
1519 const string input =
1520 "package p;\n"
1521 "interface IFoo {\n"
1522 " p.IOuter.Inner get();\n"
1523 "}";
1524 CaptureStderr();
1525 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1526 EXPECT_EQ(GetCapturedStderr(), "");
1527
1528 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1529}
1530
1531TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1532 io_delegate_.SetFileContents("p/IOuter.aidl",
1533 "package p;\n"
1534 "interface IOuter {\n"
1535 " parcelable Inner {}\n"
1536 "}");
1537 import_paths_.emplace("");
1538 const string input_path = "p/IFoo.aidl";
1539 const string input =
1540 "package p;\n"
1541 "import p.IOuter.Inner;"
1542 "interface IFoo {\n"
1543 " Inner get();\n"
1544 "}";
1545 CaptureStderr();
1546 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1547 EXPECT_EQ(GetCapturedStderr(), "");
1548
1549 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1550}
1551
1552TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1553 const string input_path = "p/IFoo.aidl";
1554 const string input =
1555 "package p;\n"
1556 "interface IFoo {\n"
1557 " parcelable Result {}\n"
1558 " Result get();\n"
1559 "}";
1560 CaptureStderr();
1561 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1562 EXPECT_EQ(GetCapturedStderr(), "");
1563
1564 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1565}
1566
1567// Finding the type of nested named member.
1568struct TypeFinder : AidlVisitor {
1569 string name;
1570 const AidlTypeSpecifier* type = nullptr;
1571 TypeFinder(std::string name) : name(name) {}
1572 void Visit(const AidlVariableDeclaration& v) override {
1573 if (v.GetName() == name) {
1574 type = &v.GetType();
1575 }
1576 }
1577 void Visit(const AidlMethod& m) override {
1578 if (m.GetName() == name) {
1579 type = &m.GetType();
1580 }
1581 }
1582 static string Get(const AidlDefinedType& type, const string& name) {
1583 TypeFinder v(name);
1584 VisitTopDown(v, type);
1585 return v.type ? v.type->Signature() : "(null)";
1586 };
1587};
1588
1589TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1590 io_delegate_.SetFileContents("q/IBar.aidl",
1591 "package q;\n"
1592 "interface IBar {\n"
1593 " parcelable Baz {}\n"
1594 "}");
1595 import_paths_.emplace("");
1596 const string input_path = "p/IFoo.aidl";
1597 const string input =
1598 "package p;\n"
1599 "import q.IBar;\n"
1600 "interface IFoo {\n"
1601 " parcelable Nested {\n"
1602 " Baz t1;\n"
1603 " }\n"
1604 " parcelable Baz { }\n"
1605 " IBar.Baz t2();\n"
1606 " Baz t3();\n"
1607 "}";
1608 CaptureStderr();
1609 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1610 EXPECT_EQ(GetCapturedStderr(), "");
1611 ASSERT_NE(nullptr, foo);
1612
1613 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1614 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1615 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1616}
1617
1618TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1619 const string input_path = "p/Foo.aidl";
1620 const string input =
1621 "package p;\n"
1622 "parcelable Foo {\n"
1623 " parcelable Foo {}\n"
1624 "}";
1625 CaptureStderr();
1626 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1628}
1629
1630TEST_F(AidlTest, RejectsInterfaceAsNestedTypes) {
1631 const string input_path = "p/IFoo.aidl";
1632 const string input =
1633 "package p;\n"
1634 "interface IFoo {\n"
1635 " interface ICallback { void done(); }\n"
1636 " void doTask(ICallback cb);\n"
1637 "}";
1638 CaptureStderr();
1639 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1640 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Interfaces should be at the root scope"));
1641}
1642
Jooyung Han2b1487d2021-09-30 09:57:01 +09001643TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1644 const string input_path = "p/IFoo.aidl";
1645 const string input =
1646 "package p;\n"
1647 "interface IFoo {\n"
1648 " parcelable Bar cpp_header \"Bar.h\";\n"
1649 "}";
1650 CaptureStderr();
1651 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1652 EXPECT_THAT(GetCapturedStderr(),
1653 HasSubstr("Unstructured parcelables should be at the root scope"));
1654}
1655
Jooyung Han7fc5de02021-09-30 22:26:27 +09001656TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1657 const string input_path = "p/Foo.aidl";
1658 const string input =
1659 "package p;\n"
1660 "parcelable Foo<T> {\n"
1661 " parcelable Bar {}\n"
1662 "}";
1663 CaptureStderr();
1664 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1665 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1666}
1667
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001668TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1669 const string input_path = "p/IFoo.aidl";
1670 const string input =
1671 "package p;\n"
1672 "interface IFoo {\n"
1673 " parcelable;\n" // missing identifier
1674 "}";
1675 CaptureStderr();
1676 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1677 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1678}
1679
Jooyung Han2aedb112021-09-29 09:37:59 +09001680TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1681 const string input_path = "p/Foo.aidl";
1682 const string input =
1683 "package p;\n"
1684 "interface Foo {\n"
1685 " parcelable Bar {}\n"
1686 " parcelable Bar {}\n"
1687 "}";
1688 CaptureStderr();
1689 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1690 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1691}
1692
1693TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1694 struct Failure {
1695 string err;
1696 };
1697 struct TestCase {
1698 string type;
1699 variant<string, Failure> expected; // success<0> or failure<1>
1700 };
1701 vector<TestCase> cases = {
1702 {"foo.A", "foo.A"},
1703 {"foo.A.B", "foo.A.B"},
1704 {"@nullable(heap=true) A", "foo.A.B.A"},
1705 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1706 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1707 {"B", "foo.A.B.A.B"},
1708 {"A.B", "foo.A.B.A.B"},
1709 };
1710 const string input_path = "foo/A.aidl";
1711 for (auto& [type, expected] : cases) {
1712 AidlTypenames typenames;
1713 // clang-format off
1714 const string input =
1715 "package foo;\n"
1716 "parcelable A {\n"
1717 " parcelable B {\n"
1718 " parcelable A {\n"
1719 " parcelable B {\n"
1720 " }\n"
1721 " " + type + " m;\n"
1722 " }\n"
1723 " }\n"
1724 "}";
1725 // clang-format on
1726 CaptureStderr();
1727 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1728 if (auto failure = std::get_if<Failure>(&expected); failure) {
1729 ASSERT_EQ(nullptr, foo);
1730 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1731 } else {
1732 EXPECT_EQ(GetCapturedStderr(), "");
1733 ASSERT_NE(nullptr, foo);
1734 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1735 }
1736 }
1737}
1738
Jooyung Hanca84b032021-09-30 02:15:59 +09001739TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1740 const string input_path = "p/IFoo.aidl";
1741 const string input =
1742 "package p;\n"
1743 "interface IFoo {\n"
1744 " parcelable Result {}\n"
1745 "}";
1746 CaptureStderr();
1747 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1748 ASSERT_NE(nullptr, foo);
1749 EXPECT_EQ(GetCapturedStderr(), "");
1750
1751 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1752 ASSERT_NE(nullptr, result);
1753 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1754}
1755
Jooyung Han8e9ae872021-10-13 02:52:25 +09001756TEST_F(AidlTest, ReorderNestedTypesForCppOutput) {
1757 const string input_path = "p/IFoo.aidl";
1758 const string input = R"(
1759 package p;
1760 interface IFoo {
1761 // partial orderings for [A, D, G]:
1762 // D - A
1763 // A - G
1764 parcelable A {
1765 // partial orderings for [B, C]:
1766 // C - B
1767 parcelable B {
1768 C c;
1769 D.E d;
1770 }
1771 parcelable C {}
1772 }
1773 parcelable D {
1774 // partial orderings for [E, F]:
1775 // F - E
1776 parcelable E {
1777 F f;
1778 }
1779 parcelable F {}
1780 }
1781 parcelable G {
1782 A.B b;
1783 }
1784 }
1785 )";
1786 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1787 io_delegate_.SetFileContents(input_path, input);
1788 CaptureStderr();
1789 EXPECT_TRUE(compile_aidl(options, io_delegate_));
1790 EXPECT_EQ(GetCapturedStderr(), "");
1791
1792 string code;
1793 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/IFoo.h", &code));
1794 // check partial orderings: a should comes before b
1795 EXPECT_LE(code.find("class D"), code.find("class A"));
1796 EXPECT_LE(code.find("class A"), code.find("class G"));
1797 EXPECT_LE(code.find("class C"), code.find("class B"));
1798 EXPECT_LE(code.find("class F"), code.find("class E"));
1799}
1800
1801TEST_F(AidlTest, RejectsNestedTypesWithCyclicDeps) {
1802 const string input_path = "p/IFoo.aidl";
1803 const string input = R"(
1804 package p;
1805 interface IFoo {
1806 // Cycles:
1807 // D - A
1808 // A - G
1809 // G - D
1810 parcelable A {
1811 parcelable B {
1812 C c;
1813 }
1814 }
1815 parcelable C {
1816 parcelable D {
1817 E e;
1818 }
1819 }
1820 parcelable E {
1821 parcelable F {
1822 A a;
1823 }
1824 }
1825 }
1826 )";
1827 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1828 io_delegate_.SetFileContents(input_path, input);
1829 CaptureStderr();
1830 EXPECT_FALSE(compile_aidl(options, io_delegate_));
1831 EXPECT_THAT(GetCapturedStderr(), HasSubstr("IFoo has nested types with cyclic references."));
1832}
1833
Jooyung Han0a950bd2021-05-15 12:50:36 +09001834TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001835 const string input_path = "p/Wrapper.aidl";
1836 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001837
1838 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1839 EXPECT_NE(nullptr, parse_result);
1840
1841 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1842 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1843 (..., params->emplace_back(std::move(type_params)));
1844 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1845 };
1846
1847 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
Steven Morelanda7560e82021-10-08 16:24:39 -07001848 std::vector<std::unique_ptr<AidlAnnotation>> annotations;
1849 annotations.emplace_back(std::unique_ptr<AidlAnnotation>(
1850 AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {})));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001851 type->Annotate(std::move(annotations));
1852 return std::move(type);
1853 };
1854
1855 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1856 (void)type->SetArray();
1857 return std::move(type);
1858 };
1859
1860 auto w = type("p.Wrapper", type("String"));
1861 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1862
1863 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1864 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1865 cpp::CppNameOf(*nullable_w, typenames_));
1866
1867 auto array_w = set_array(type("p.Wrapper", type("String")));
1868 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1869 cpp::CppNameOf(*array_w, typenames_));
1870
1871 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1872 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1873 cpp::CppNameOf(*nullable_array_w, typenames_));
1874
1875 auto list_w = type("List", type("p.Wrapper", type("String")));
1876 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1877 cpp::CppNameOf(*list_w, typenames_));
1878
1879 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1880 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1881 cpp::CppNameOf(*nullable_list_w, typenames_));
1882}
1883
Devin Moore7b8d5c92020-03-17 14:14:08 -07001884TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001885 io_delegate_.SetFileContents(
1886 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001887 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001888 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001889 const string input_path = "p/IFoo.aidl";
1890 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001891 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1892 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001893 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001894 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001895 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001896
1897 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1898 // C++ understands C++ specific stuff
1899 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1900 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001901 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001902 EXPECT_EQ(1u, headers.size());
1903 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001904}
1905
Christopher Wileyf8136192016-04-12 14:19:35 -07001906TEST_F(AidlTest, WritesCorrectDependencyFile) {
1907 // While the in tree build system always gives us an output file name,
1908 // other android tools take advantage of our ability to infer the intended
1909 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001910 vector<string> args = {
1911 "aidl",
1912 "-d dep/file/path",
1913 "-o place/for/output",
1914 "p/IFoo.aidl"};
1915 Options options = Options::From(args);
1916 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001917 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001918 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001919 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001920 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1921}
1922
Dan Willemsen93298ee2016-11-10 23:55:55 -08001923TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1924 // While the in tree build system always gives us an output file name,
1925 // other android tools take advantage of our ability to infer the intended
1926 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001927 vector<string> args = {
1928 "aidl",
1929 "-d dep/file/path",
1930 "--ninja",
1931 "-o place/for/output",
1932 "p/IFoo.aidl"};
1933 Options options = Options::From(args);
1934 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001935 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001936 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001937 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001938 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1939}
1940
Jiyong Parkdf202122019-09-30 20:48:35 +09001941TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001942 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1943 // this by calling aidl with every .aidl file it finds, then parsing the
1944 // generated dependency files. Those that reference .java output files are
1945 // for interfaces and those that do not are parcelables. However, for both
1946 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001947 vector<string> args = {
1948 "aidl",
1949 "-o place/for/output",
1950 "-d dep/file/path",
1951 "p/Foo.aidl"};
1952 Options options = Options::From(args);
1953 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001954 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001955 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001956 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001957 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1958}
1959
1960TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1961 vector<string> args = {
1962 "aidl",
1963 "--structured",
1964 "-o place/for/output",
1965 "-d dep/file/path",
1966 "p/Foo.aidl"};
1967 Options options = Options::From(args);
1968 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001969 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001970 string actual_dep_file_contents;
1971 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1972 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001973}
1974
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001975TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1976 vector<string> args = {
1977 "aidl",
1978 "--lang=java",
1979 "-o place/for/output",
1980 "p/Foo.aidl"};
1981 Options options = Options::From(args);
1982 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001983 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001984 string output_file_contents;
1985 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1986}
1987
Devin Moore21b26772020-08-26 16:37:56 -07001988TEST_P(AidlTest, RejectsListArray) {
Jooyung Han49b8f362021-10-15 10:58:02 +09001989 const string input = "package a; parcelable Foo { List<String>[] lists; }";
Devin Moore21b26772020-08-26 16:37:56 -07001990 CaptureStderr();
Jooyung Han49b8f362021-10-15 10:58:02 +09001991 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", input, typenames_, GetLanguage()));
1992 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Arrays of List are not supported"));
Devin Moore21b26772020-08-26 16:37:56 -07001993}
1994
Jiyong Parkf8d53612020-05-04 14:06:13 +09001995TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1996 AidlError error;
1997 string expected_stderr =
1998 "ERROR: a/IFoo.aidl:2.7-11: "
1999 "Encountered an untyped List or Map. The use of untyped List/Map is "
2000 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2001 "the receiving side. Consider switching to an array or a generic List/Map.\n";
2002 if (GetLanguage() != Options::Language::JAVA) {
2003 expected_stderr =
2004 "ERROR: a/IFoo.aidl:2.1-7: "
2005 "Currently, only the Java backend supports non-generic List.\n";
2006 }
2007
2008 const string primitive_interface =
2009 "package a; interface IFoo {\n"
2010 " List foo(); }";
2011 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002012 AidlTypenames tn1;
2013 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002014 {"--structured"}));
2015 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09002016
2017 string primitive_parcelable =
2018 "package a; parcelable IFoo {\n"
2019 " List foo;}";
2020 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002021 AidlTypenames tn2;
2022 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002023 {"--structured"}));
2024 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2025}
2026
Jeongik Cha225519b2020-08-29 01:55:32 +09002027TEST_P(AidlTest, ExtensionTest) {
2028 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002029 string extendable_parcelable =
2030 "package a; parcelable Data {\n"
2031 " ParcelableHolder extension;\n"
2032 " ParcelableHolder extension2;\n"
2033 "}";
Andrei Homescub2316a52021-09-04 04:41:12 +00002034 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
2035 EXPECT_EQ("", GetCapturedStderr());
Jeongik Cha225519b2020-08-29 01:55:32 +09002036}
2037TEST_P(AidlTest, ParcelableHolderAsReturnType) {
2038 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002039 string parcelableholder_return_interface =
2040 "package a; interface IFoo {\n"
2041 " ParcelableHolder foo();\n"
2042 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002043 EXPECT_EQ(nullptr,
2044 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09002045
Jeongik Cha225519b2020-08-29 01:55:32 +09002046 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
2047 GetCapturedStderr());
2048}
2049
2050TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
2051 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002052 string extendable_parcelable_arg_interface =
2053 "package a; interface IFoo {\n"
2054 " void foo(in ParcelableHolder ph);\n"
2055 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002056 EXPECT_EQ(nullptr,
2057 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
2058
Jeongik Cha225519b2020-08-29 01:55:32 +09002059 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
2060 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09002061}
2062
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002063TEST_P(AidlTest, RejectNullableParcelableHolderField) {
2064 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002065 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002066 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
2067 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002068 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002069 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2070}
2071
Jooyung Han3f347ca2020-12-01 12:41:50 +09002072TEST_P(AidlTest, ParcelablesWithConstants) {
2073 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002074 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002075 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002076 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002077 EXPECT_EQ("", GetCapturedStderr());
2078}
2079
2080TEST_P(AidlTest, UnionWithConstants) {
2081 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002082 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002083 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002084 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002085 EXPECT_EQ("", GetCapturedStderr());
2086}
2087
Jooyung Han633eab62021-01-07 14:12:40 +09002088TEST_F(AidlTest, ConstantsWithAnnotations) {
2089 io_delegate_.SetFileContents("IFoo.aidl",
2090 "interface IFoo {\n"
2091 " @JavaPassthrough(annotation=\"@Foo\")\n"
2092 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2093 "}");
2094 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2095 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002096 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002097 EXPECT_EQ("", GetCapturedStderr());
2098 string code;
2099 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2100 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2101 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2102}
2103
Jiyong Park02da7422018-07-16 16:00:26 +09002104TEST_F(AidlTest, ApiDump) {
2105 io_delegate_.SetFileContents(
2106 "foo/bar/IFoo.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002107 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002108 "package foo.bar;\n"
2109 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002110 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002111 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002112 " /* @hide applied \n"
2113 " @deprecated use foo2 */\n"
2114 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2115 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002116 " IFoo foo3(IFoo foo);\n"
2117 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002118 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002119 " /** blahblah\n"
2120 " @deprecated\n"
2121 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002122 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002123 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002124 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002125 "}\n");
2126 io_delegate_.SetFileContents("foo/bar/Data.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002127 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002128 "package foo.bar;\n"
2129 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002130 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002131 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002132 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002133 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002134 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002135 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002136 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002137 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002138 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002139 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002140 "}\n");
2141 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002142 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2143 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002144 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002145 bool result = dump_api(options, io_delegate_);
2146 ASSERT_TRUE(result);
2147 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002148 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002149 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002150interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002151 /**
2152 * @hide
2153 * @deprecated use foo2
2154 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002155 int foo(out int[] a, String b, boolean c, inout List<String> d);
2156 int foo2(@utf8InCpp String x, inout List<String> y);
2157 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2158 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002159 /**
2160 * @deprecated reason why...
2161 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002162 const int A = 1;
2163 const String STR = "Hello";
2164}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002165)"),
2166 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002167
Jiyong Parke59c3682018-09-11 23:10:25 +09002168 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002169 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002170/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002171parcelable Data {
2172 int x = 10;
2173 int y;
2174 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002175 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002176}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002177)"),
2178 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002179}
2180
Jiyong Parked65bf42018-08-28 15:43:27 +09002181TEST_F(AidlTest, ApiDumpWithManualIds) {
2182 io_delegate_.SetFileContents(
2183 "foo/bar/IFoo.aidl",
2184 "package foo.bar;\n"
2185 "interface IFoo {\n"
2186 " int foo() = 1;\n"
2187 " int bar() = 2;\n"
2188 " int baz() = 10;\n"
2189 "}\n");
2190
Jiyong Parke59c3682018-09-11 23:10:25 +09002191 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002192 Options options = Options::From(args);
2193 bool result = dump_api(options, io_delegate_);
2194 ASSERT_TRUE(result);
2195 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002196 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002197 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002198interface IFoo {
2199 int foo() = 1;
2200 int bar() = 2;
2201 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002202}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002203)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002204}
2205
2206TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002207 const string expected_stderr =
2208 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2209 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002210 io_delegate_.SetFileContents(
2211 "foo/bar/IFoo.aidl",
2212 "package foo.bar;\n"
2213 "interface IFoo {\n"
2214 " int foo() = 1;\n"
2215 " int bar();\n"
2216 " int baz() = 10;\n"
2217 "}\n");
2218
Jiyong Parke59c3682018-09-11 23:10:25 +09002219 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002220 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002221 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002222 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002223 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002224}
2225
Jooyung Han965e31d2020-11-27 12:30:16 +09002226TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2227 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2228 "package foo.bar;\n"
2229 "interface IFoo {\n"
2230 " @utf8InCpp String foo();\n"
2231 " const @utf8InCpp String bar = \"bar\";\n"
2232 "}\n");
2233
2234 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2235 Options options = Options::From(args);
2236 CaptureStderr();
2237 EXPECT_TRUE(dump_api(options, io_delegate_));
2238 EXPECT_EQ("", GetCapturedStderr());
2239 string actual;
2240 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002241 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2242interface IFoo {
2243 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002244 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002245}
2246)"),
2247 actual);
2248}
2249
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002250TEST_F(AidlTest, ApiDumpWithEnums) {
2251 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2252 "package foo.bar;\n"
2253 "enum Enum {\n"
2254 " FOO,\n"
2255 " BAR = FOO + 1,\n"
2256 "}\n");
2257
2258 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2259 Options options = Options::From(args);
2260 CaptureStderr();
2261 EXPECT_TRUE(dump_api(options, io_delegate_));
2262 EXPECT_EQ("", GetCapturedStderr());
2263 string actual;
2264 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2265 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2266 "enum Enum {\n"
2267 " FOO = 0,\n"
2268 " BAR = 1,\n"
2269 "}\n"),
2270 actual);
2271}
2272
2273TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2274 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2275 "package foo.bar;\n"
2276 "enum Enum {\n"
2277 " FOO,\n"
2278 "}\n");
2279 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2280 "package foo.bar;\n"
2281 "import foo.bar.Enum;\n"
2282 "parcelable Foo {\n"
2283 " Enum e = Enum.FOO;\n"
2284 "}\n");
2285
2286 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2287 Options options = Options::From(args);
2288 CaptureStderr();
2289 EXPECT_TRUE(dump_api(options, io_delegate_));
2290 EXPECT_EQ("", GetCapturedStderr());
2291 string actual;
2292 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2293 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2294 "parcelable Foo {\n"
2295 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2296 "}\n"),
2297 actual);
2298}
2299
Jooyung Han71dfec32021-05-23 07:18:58 +09002300TEST_F(AidlTest, ApiDumpWithGenerics) {
2301 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2302 "package foo.bar;\n"
2303 "parcelable Foo<T, U> {\n"
2304 "}\n");
2305
2306 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2307 Options options = Options::From(args);
2308 CaptureStderr();
2309 EXPECT_TRUE(dump_api(options, io_delegate_));
2310 EXPECT_EQ("", GetCapturedStderr());
2311 string actual;
2312 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2313 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2314 "parcelable Foo<T, U> {\n"
2315 "}\n"),
2316 actual);
2317}
2318
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002319TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2320 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2321 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2322
2323 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2324 Options options = Options::From(args);
2325 CaptureStderr();
2326 EXPECT_FALSE(dump_api(options, io_delegate_));
2327 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2328}
2329
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002330TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002332 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2333 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002334 const string expected_map_stderr =
2335 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002336 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2337 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002338 "package p; interface IFoo {"
2339 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002341 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002342 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002343
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002344 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002345 "package p; interface IFoo {"
2346 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002347 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002348 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002349 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002350}
2351
Jeongik Chae48d9942020-01-02 17:39:00 +09002352TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002353 const string expected_stderr =
2354 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002355 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002356 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2357
2358 io_delegate_.SetFileContents("p/IFoo.aidl",
2359 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002360 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002361 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002362
2363 io_delegate_.SetFileContents("p/IFoo.aidl",
2364 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002365 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002367 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002368 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002369
2370 io_delegate_.SetFileContents("p/IFoo.aidl",
2371 "package p; interface IFoo {"
2372 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002373 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002374
2375 io_delegate_.SetFileContents("p/IFoo.aidl",
2376 "package p; interface IFoo {"
2377 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002378 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002379}
2380
Jeongik Chadf76dc72019-11-28 00:08:47 +09002381TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002382 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002383 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2384 io_delegate_.SetFileContents(options.InputFiles().front(),
2385 "package p; interface IFoo {"
2386 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002388 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002389 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002390}
2391
2392TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002393 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002394 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002395 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002396 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002397 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2398 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002399
Jooyung Han13f1fa52021-06-11 18:06:12 +09002400 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002401 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2402 io_delegate_.SetFileContents("p/IFoo.aidl",
2403 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002404 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002405 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002406 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002407 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002408 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002409 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002410 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002411 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002412 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002413 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002414 io_delegate_.SetFileContents("p/IFoo.aidl",
2415 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002416 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002417 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002418
2419 io_delegate_.SetFileContents("p/IFoo.aidl",
2420 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002421 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002422
2423 io_delegate_.SetFileContents("p/IFoo.aidl",
2424 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002425 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002426
Steven Moreland4e059132021-08-11 13:36:30 -07002427 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002428}
2429
Jeongik Cha0e426012019-07-29 15:57:02 +09002430TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2431 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002432 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2433 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002434 for (const auto& rawOption : rawOptions) {
2435 string expected_stderr =
2436 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002437 Options options = Options::From(rawOption);
2438 io_delegate_.SetFileContents(options.InputFiles().front(),
2439 "package foo.bar;\n"
2440 "interface IFoo1 { int foo(); }\n"
2441 "interface IFoo2 { int foo(); }\n"
2442 "parcelable Data1 { int a; int b;}\n"
2443 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002444 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002445 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002447
Jeongik Cha0e426012019-07-29 15:57:02 +09002448 io_delegate_.SetFileContents(options.InputFiles().front(),
2449 "package foo.bar;\n"
2450 "interface IFoo1 { int foo(); }\n"
2451 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002452 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002453 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002455
Devin Moore5de18ed2020-04-02 13:52:29 -07002456 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002457 io_delegate_.SetFileContents(options.InputFiles().front(),
2458 "package foo.bar;\n"
2459 "parcelable Data1 { int a; int b;}\n"
2460 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002461 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002462 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002463 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002464 }
2465}
2466
Devin Moorebdba2a82020-03-31 15:19:02 -07002467TEST_P(AidlTest, FailParseOnEmptyFile) {
2468 const string contents = "";
2469 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2470 CaptureStderr();
2471 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2472 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2473}
2474
Jiyong Parkb034bf02018-07-30 17:44:33 +09002475TEST_F(AidlTest, MultipleInputFiles) {
2476 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002477 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002478
2479 io_delegate_.SetFileContents(options.InputFiles().at(0),
2480 "package foo.bar;\n"
2481 "import foo.bar.Data;\n"
2482 "interface IFoo { Data getData(); }\n");
2483
2484 io_delegate_.SetFileContents(options.InputFiles().at(1),
2485 "package foo.bar;\n"
2486 "import foo.bar.IFoo;\n"
2487 "parcelable Data { IFoo foo; }\n");
2488
Steven Moreland4e059132021-08-11 13:36:30 -07002489 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002490
2491 string content;
2492 for (const auto file : {
2493 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2494 content.clear();
2495 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2496 EXPECT_FALSE(content.empty());
2497 }
2498}
2499
2500TEST_F(AidlTest, MultipleInputFilesCpp) {
2501 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002502 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002503
2504 io_delegate_.SetFileContents(options.InputFiles().at(0),
2505 "package foo.bar;\n"
2506 "import foo.bar.Data;\n"
2507 "interface IFoo { Data getData(); }\n");
2508
2509 io_delegate_.SetFileContents(options.InputFiles().at(1),
2510 "package foo.bar;\n"
2511 "import foo.bar.IFoo;\n"
2512 "parcelable Data { IFoo foo; }\n");
2513
Steven Moreland4e059132021-08-11 13:36:30 -07002514 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002515
2516 string content;
2517 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002518 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002519 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2520 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2521 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2522 content.clear();
2523 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2524 EXPECT_FALSE(content.empty());
2525 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002526}
2527
Andrei Homescub62afd92020-05-11 19:24:59 -07002528TEST_F(AidlTest, MultipleInputFilesRust) {
2529 Options options =
2530 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2531
2532 io_delegate_.SetFileContents(options.InputFiles().at(0),
2533 "package foo.bar;\n"
2534 "import foo.bar.Data;\n"
2535 "interface IFoo { Data getData(); }\n");
2536
2537 io_delegate_.SetFileContents(options.InputFiles().at(1),
2538 "package foo.bar;\n"
2539 "import foo.bar.IFoo;\n"
2540 "parcelable Data { IFoo foo; }\n");
2541
Steven Moreland4e059132021-08-11 13:36:30 -07002542 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002543
2544 string content;
2545 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2546 content.clear();
2547 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2548 EXPECT_FALSE(content.empty());
2549 }
2550}
2551
Devin Moore097a3ab2020-03-11 16:08:44 -07002552TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2553 const string expected_stderr =
2554 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002555 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2556 // int getInterfaceVersion() is one of the meta transactions
2557 io_delegate_.SetFileContents(options.InputFiles().front(),
2558 "package p; interface IFoo {"
2559 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002560 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002561 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002562 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2563}
Jiyong Park309668e2018-07-28 16:55:44 +09002564
Devin Moore097a3ab2020-03-11 16:08:44 -07002565TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2566 // boolean getInterfaceVersion() is not a meta transaction, but should be
2567 // prevented because return type is not part of a method signature
2568 const string expected_stderr =
2569 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2570 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002571 io_delegate_.SetFileContents(options.InputFiles().front(),
2572 "package p; interface IFoo {"
2573 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002574 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002575 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2577}
Jiyong Park309668e2018-07-28 16:55:44 +09002578
Devin Moore097a3ab2020-03-11 16:08:44 -07002579TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002580 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002581 const string expected_stderr =
2582 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2583 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002584 io_delegate_.SetFileContents(options.InputFiles().front(),
2585 "package p; interface IFoo {"
2586 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002587 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002588 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002589 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002590
2591 // this is not a meta interface method as it differs type arguments
2592 io_delegate_.SetFileContents(options.InputFiles().front(),
2593 "package p; interface IFoo {"
2594 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002595 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002596}
2597
Jooyung Hanb8a97772021-01-19 01:27:38 +09002598TEST_F(AidlTest, CheckApiForEquality) {
2599 CaptureStderr();
2600 Options options = Options::From("aidl --checkapi=equal old new");
2601
2602 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2603 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2604 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2605 "package p; interface IFoo{ @utf8InCpp String foo();}");
2606
2607 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2608 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2609}
2610
Daniel Norman85aed542019-08-21 12:01:14 -07002611TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002612 Options options = Options::From("aidl --checkapi old new");
2613 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2614 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2615 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2616 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2617
2618 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2619}
2620
Jiyong Park3656c3c2018-08-01 20:02:01 +09002621TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002622 Options options = Options::From("aidl --checkapi old new");
2623 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2624 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002625
2626 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2627}
2628
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002629TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2630 Options options = Options::From("aidl --checkapi old new");
2631 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2632 const string enum_definition = "package p; enum Enum { FOO }";
2633 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2634 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2635 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2636 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2637
2638 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2639}
2640
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002641TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2642 Options options = Options::From("aidl --checkapi old new -I import");
2643
2644 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2645 io_delegate_.SetFileContents("new/p/Foo.aidl",
2646 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2647 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2648
2649 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2650}
2651
Jooyung Han02a11be2021-02-11 13:18:06 +09002652TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2653 Options options = Options::From("aidl --checkapi=equal old new");
2654 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2655 const string enum_definition = "package p; enum Enum { FOO }";
2656 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2657 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2658 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2659 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2660 CaptureStderr();
2661 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2662 EXPECT_EQ("", GetCapturedStderr());
2663}
2664
Daniel Norman85aed542019-08-21 12:01:14 -07002665class AidlTestCompatibleChanges : public AidlTest {
2666 protected:
2667 Options options_ = Options::From("aidl --checkapi old new");
2668};
2669
2670TEST_F(AidlTestCompatibleChanges, NewType) {
2671 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2672 "package p;"
2673 "interface IFoo {"
2674 " void foo(int a);"
2675 "}");
2676 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2677 "package p;"
2678 "interface IFoo {"
2679 " void foo(int a);"
2680 "}");
2681 io_delegate_.SetFileContents("new/p/IBar.aidl",
2682 "package p;"
2683 "interface IBar {"
2684 " void bar();"
2685 "}");
2686 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2687}
2688
2689TEST_F(AidlTestCompatibleChanges, NewMethod) {
2690 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2691 "package p;"
2692 "interface IFoo {"
2693 " void foo(int a);"
2694 "}");
2695 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2696 "package p;"
2697 "interface IFoo {"
2698 " void foo(int a);"
2699 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002700 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002701 "}");
2702 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2703}
2704
2705TEST_F(AidlTestCompatibleChanges, NewField) {
2706 io_delegate_.SetFileContents("old/p/Data.aidl",
2707 "package p;"
2708 "parcelable Data {"
2709 " int foo;"
2710 "}");
2711 io_delegate_.SetFileContents("new/p/Data.aidl",
2712 "package p;"
2713 "parcelable Data {"
2714 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002715 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002716 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002717 "}");
2718 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2719}
2720
Jooyung Han05bd8a82021-04-28 23:56:38 +09002721TEST_F(AidlTestCompatibleChanges, NewField2) {
2722 io_delegate_.SetFileContents("old/p/Data.aidl",
2723 "package p;"
2724 "parcelable Data {"
2725 "}");
2726 io_delegate_.SetFileContents("new/p/Data.aidl",
2727 "package p;"
2728 "parcelable Data {"
2729 " int foo = 0;"
2730 "}");
2731 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2732}
2733
Daniel Norman85aed542019-08-21 12:01:14 -07002734TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2735 io_delegate_.SetFileContents("old/p/Enum.aidl",
2736 "package p;"
2737 "enum Enum {"
2738 " FOO = 1,"
2739 "}");
2740 io_delegate_.SetFileContents("new/p/Enum.aidl",
2741 "package p;"
2742 "enum Enum {"
2743 " FOO = 1,"
2744 " BAR = 2,"
2745 "}");
2746 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2747}
2748
2749TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2750 io_delegate_.SetFileContents("old/p/Enum.aidl",
2751 "package p;"
2752 "enum Enum {"
2753 " FOO = 1,"
2754 " BAR = 2,"
2755 "}");
2756 io_delegate_.SetFileContents("new/p/Enum.aidl",
2757 "package p;"
2758 "enum Enum {"
2759 " BAR = 2,"
2760 " FOO = 1,"
2761 "}");
2762 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2763}
2764
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002765TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2766 io_delegate_.SetFileContents("old/p/Union.aidl",
2767 "package p;"
2768 "union Union {"
2769 " String foo;"
2770 "}");
2771 io_delegate_.SetFileContents("new/p/Union.aidl",
2772 "package p;"
2773 "union Union {"
2774 " String foo;"
2775 " int num;"
2776 "}");
2777 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2778}
2779
Daniel Norman85aed542019-08-21 12:01:14 -07002780TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002781 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2782 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002783 "interface IFoo {"
2784 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002785 "}");
2786 io_delegate_.SetFileContents("old/p/Data.aidl",
2787 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002788 "parcelable Data {"
2789 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002790 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002791 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2792 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002793 "interface IFoo {"
2794 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002795 "}");
2796 io_delegate_.SetFileContents("new/p/Data.aidl",
2797 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002798 "parcelable Data {"
2799 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002800 "}");
2801 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2802 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002803 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002804 " void foo(int a);"
2805 "}");
2806 io_delegate_.SetFileContents("new/q/Data.aidl",
2807 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002808 "parcelable Data {"
2809 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002810 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002811 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2812}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002813
Daniel Norman85aed542019-08-21 12:01:14 -07002814TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2815 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2816 "package p;"
2817 "interface IFoo {"
2818 " void foo(int a);"
2819 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002820 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2821 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002822 "interface IFoo {"
2823 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002824 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002825 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2826}
Jiyong Parke59c3682018-09-11 23:10:25 +09002827
Daniel Norman85aed542019-08-21 12:01:14 -07002828TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002829 io_delegate_.SetFileContents("old/p/I.aidl",
2830 "package p; interface I {"
2831 "const int A = 1; }");
2832 io_delegate_.SetFileContents("new/p/I.aidl",
2833 "package p ; interface I {"
2834 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002835 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2836}
Jiyong Parka428d212018-08-29 22:26:30 +09002837
Daniel Norman85aed542019-08-21 12:01:14 -07002838TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002839 io_delegate_.SetFileContents("old/p/I.aidl",
2840 "package p; interface I {"
2841 "const int A = 1; const int B = 2;}");
2842 io_delegate_.SetFileContents("new/p/I.aidl",
2843 "package p ; interface I {"
2844 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002845 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002846}
2847
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002848TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2849 io_delegate_.SetFileContents("old/p/Foo.aidl",
2850 "package p;"
2851 "@JavaPassthrough(annotation=\"Alice\")"
2852 "@JavaPassthrough(annotation=\"Bob\")"
2853 "parcelable Foo {}");
2854 io_delegate_.SetFileContents("new/p/Foo.aidl",
2855 "package p;"
2856 "@JavaPassthrough(annotation=\"Bob\")"
2857 "@JavaPassthrough(annotation=\"Alice\")"
2858 "parcelable Foo {}");
2859 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2860}
2861
Jooyung Han00073272020-11-27 14:20:20 +09002862TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2863 io_delegate_.SetFileContents("old/p/Foo.aidl",
2864 "package p;"
2865 "parcelable Foo {}");
2866 io_delegate_.SetFileContents("new/p/Foo.aidl",
2867 "package p;"
2868 "@JavaPassthrough(annotation=\"@Deprecated\")"
2869 "parcelable Foo {}");
2870 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2871}
2872
Jooyung Han636fd2f2020-10-22 11:33:45 +09002873TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2874 io_delegate_.SetFileContents("old/p/Data.aidl",
2875 "package p;"
2876 "parcelable Data {"
2877 " int num;"
2878 "}");
2879 io_delegate_.SetFileContents(
2880 "new/p/Data.aidl",
2881 "package p;"
2882 "parcelable Data {"
2883 " int num;"
2884 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2885 "}");
2886 io_delegate_.SetFileContents("new/p/Enum.aidl",
2887 "package p;"
2888 "enum Enum {"
2889 " FOO = 0,"
2890 " BAR = 1,"
2891 "}");
2892 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2893}
2894
Jooyung Han308bbe02021-04-27 12:09:59 +09002895TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2896 io_delegate_.SetFileContents("old/p/Data.aidl",
2897 "package p;\n"
2898 "parcelable Data {\n"
2899 " p.Enum e;\n"
2900 "}");
2901 io_delegate_.SetFileContents("old/p/Enum.aidl",
2902 "package p;\n"
2903 "enum Enum {\n"
2904 " FOO = 0,\n"
2905 " BAR = 1,\n"
2906 "}");
2907 io_delegate_.SetFileContents("new/p/Data.aidl",
2908 "package p;\n"
2909 "parcelable Data {\n"
2910 " p.Enum e = p.Enum.FOO;\n"
2911 "}");
2912 io_delegate_.SetFileContents("new/p/Enum.aidl",
2913 "package p;\n"
2914 "enum Enum {\n"
2915 " FOO = 0,\n"
2916 " BAR = 1,\n"
2917 "}");
2918 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2919}
2920
Daniel Norman85aed542019-08-21 12:01:14 -07002921class AidlTestIncompatibleChanges : public AidlTest {
2922 protected:
2923 Options options_ = Options::From("aidl --checkapi old new");
2924};
2925
2926TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002927 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002928 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2929 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002930 "interface IFoo {"
2931 " void foo(in String[] str);"
2932 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002933 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002934 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002935 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002936 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002937}
2938
2939TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 const string expected_stderr =
2941 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002942 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2943 "package p;"
2944 "interface IFoo {"
2945 " void foo(in String[] str);"
2946 " void bar(@utf8InCpp String str);"
2947 "}");
2948 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2949 "package p;"
2950 "interface IFoo {"
2951 " void foo(in String[] str);"
2952 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002953 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002954 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002956}
2957
Jiyong Parkf8d53612020-05-04 14:06:13 +09002958TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2959 const string expected_stderr =
2960 "ERROR: new/p/IFoo.aidl:1.61-65: "
2961 "Encountered an untyped List or Map. The use of untyped List/Map is "
2962 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2963 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2964 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2965 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2966 "package p;"
2967 "interface IFoo {"
2968 " void foo(in String[] str);"
2969 "}");
2970 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2971 "package p;"
2972 "interface IFoo {"
2973 " void foo(in String[] str);"
2974 " void bar(in List arg);"
2975 "}");
2976 CaptureStderr();
2977 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2979}
2980
2981TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2982 const string expected_stderr =
2983 "ERROR: new/p/Data.aidl:1.54-59: "
2984 "Encountered an untyped List or Map. The use of untyped List/Map is "
2985 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2986 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2987 "ERROR: new/p/Data.aidl: Failed to read.\n";
2988 io_delegate_.SetFileContents("old/p/Data.aidl",
2989 "package p;"
2990 "parcelable Data {"
2991 " int foo;"
2992 "}");
2993 io_delegate_.SetFileContents("new/p/Data.aidl",
2994 "package p;"
2995 "parcelable Data {"
2996 " int foo;"
2997 " @nullable List list;"
2998 "}");
2999 CaptureStderr();
3000 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3001 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3002}
3003
Daniel Norman85aed542019-08-21 12:01:14 -07003004TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003005 const string expected_stderr =
3006 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003007 io_delegate_.SetFileContents("old/p/Data.aidl",
3008 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003009 "parcelable Data {"
3010 " int foo;"
3011 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003012 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003013 io_delegate_.SetFileContents("new/p/Data.aidl",
3014 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003015 "parcelable Data {"
3016 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003017 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003019 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003021}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003022
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003023TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
3024 const string expected_stderr =
3025 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
3026 "backends. Please either provide a default value for this field or mark the field as "
3027 "@nullable. This value or a null value will be used automatically when an old version of "
3028 "this parcelable is sent to a process which understands a new version of this parcelable. In "
3029 "order to make sure your code continues to be backwards compatible, make sure the default or "
3030 "null value does not cause a semantic change to this parcelable.\n";
3031 io_delegate_.SetFileContents("old/p/Data.aidl",
3032 "package p;"
3033 "parcelable Data {"
3034 " int num;"
3035 "}");
3036 io_delegate_.SetFileContents("new/p/Data.aidl",
3037 "package p;"
3038 "parcelable Data {"
3039 " int num;"
3040 " String str;"
3041 "}");
3042 CaptureStderr();
3043 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3044 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3045}
3046
Jooyung Han636fd2f2020-10-22 11:33:45 +09003047TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
3048 const string expected_stderr =
3049 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
3050 "Please make sure 'Enum' has '0' as a valid value.\n";
3051 io_delegate_.SetFileContents("old/p/Data.aidl",
3052 "package p;"
3053 "parcelable Data {"
3054 " int num;"
3055 "}");
3056 io_delegate_.SetFileContents("new/p/Data.aidl",
3057 "package p;"
3058 "parcelable Data {"
3059 " int num;"
3060 " p.Enum e;"
3061 "}");
3062 io_delegate_.SetFileContents("new/p/Enum.aidl",
3063 "package p;"
3064 "enum Enum {"
3065 " FOO = 1,"
3066 " BAR = 2,"
3067 "}");
3068 CaptureStderr();
3069 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3070 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3071}
3072
Daniel Norman85aed542019-08-21 12:01:14 -07003073TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003074 const string expected_stderr =
3075 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003076 io_delegate_.SetFileContents("old/p/Enum.aidl",
3077 "package p;"
3078 "enum Enum {"
3079 " FOO = 1,"
3080 " BAR = 2,"
3081 "}");
3082 io_delegate_.SetFileContents("new/p/Enum.aidl",
3083 "package p;"
3084 "enum Enum {"
3085 " BAR = 2,"
3086 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003087 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003088 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003089 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003090}
3091
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003092TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3093 const string expected_stderr =
3094 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3095 io_delegate_.SetFileContents("old/p/Union.aidl",
3096 "package p;"
3097 "union Union {"
3098 " String str;"
3099 " int num;"
3100 "}");
3101 io_delegate_.SetFileContents("new/p/Union.aidl",
3102 "package p;"
3103 "union Union {"
3104 " String str;"
3105 "}");
3106 CaptureStderr();
3107 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3108 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3109}
3110
Daniel Norman85aed542019-08-21 12:01:14 -07003111TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003112 const string expected_stderr =
3113 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003114 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3115 "package p;"
3116 "interface IFoo {"
3117 " void foo(in String[] str);"
3118 " void bar(@utf8InCpp String str);"
3119 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003120 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3121 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003122 "interface IFoo {"
3123 " void foo(in String[] str);"
3124 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003125 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003126 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003127 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003128 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003129}
3130
Daniel Norman85aed542019-08-21 12:01:14 -07003131TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003132 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003133 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3134 "package p;"
3135 "interface IFoo {"
3136 " void foo(in String[] str);"
3137 " void bar(@utf8InCpp String str);"
3138 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003139 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3140 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003141 "interface IFoo2 {"
3142 " void foo(in String[] str);"
3143 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003144 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003145 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003146 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003147 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003148}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003149
Daniel Norman85aed542019-08-21 12:01:14 -07003150TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003151 const string expected_stderr =
3152 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003153 io_delegate_.SetFileContents("old/p/Enum.aidl",
3154 "package p;"
3155 "enum Enum {"
3156 " FOO = 1,"
3157 " BAR = 2,"
3158 "}");
3159 io_delegate_.SetFileContents("new/p/Enum.aidl",
3160 "package p;"
3161 "enum Enum {"
3162 " FOO = 3,"
3163 " BAR = 2,"
3164 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003165 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003166 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003167 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003168}
3169
3170TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003171 const string expected_stderr =
3172 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3173 "from 0 to 1.\n"
3174 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3175 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003176 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3177 "package p;"
3178 "interface IFoo {"
3179 " void foo(in String[] str);"
3180 " void bar(@utf8InCpp String str);"
3181 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003182 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3183 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003184 "interface IFoo {"
3185 " void bar(@utf8InCpp String str);"
3186 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003187 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003188 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003189 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003191}
3192
3193TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003194 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003195 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3196 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003197 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003198 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003199 "parcelable Data {"
3200 " int foo;"
3201 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003202 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003203 io_delegate_.SetFileContents("new/p/Data.aidl",
3204 "package p;"
3205 "parcelable Data {"
3206 " int bar;"
3207 " int foo;"
3208 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003209 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003210 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003212}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003213
Daniel Norman85aed542019-08-21 12:01:14 -07003214TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003215 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003216 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003217 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003218 "interface IFoo {"
3219 " void foo(in String[] str);"
3220 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003221 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003222 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3223 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003224 "interface IFoo {"
3225 " void foo(out String[] str);"
3226 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003227 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003228 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003229 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003231}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003232
Daniel Norman85aed542019-08-21 12:01:14 -07003233TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003234 const string expected_stderr =
3235 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003236 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3237 "package p;"
3238 "interface IFoo {"
3239 " void foo(in String[] str);"
3240 " void bar(@utf8InCpp String str);"
3241 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003242 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3243 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003244 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003245 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003246 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003247 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003248 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003249 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003251}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003252
Daniel Norman85aed542019-08-21 12:01:14 -07003253TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003254 const string expected_stderr =
3255 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003256 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3257 "package p;"
3258 "interface IFoo {"
3259 " void foo(in String[] str);"
3260 " void bar(@utf8InCpp String str);"
3261 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003262 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3263 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003264 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003265 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003266 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003267 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003268 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003269 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003270 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003271}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003272
Jooyung Han60b2fde2020-10-29 15:12:40 +09003273TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3274 const string expected_stderr =
3275 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3276 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3277 io_delegate_.SetFileContents("old/p/Foo.aidl",
3278 "package p;"
3279 "@Backing(type=\"byte\")"
3280 "enum Foo {"
3281 " FOO, BAR,"
3282 "}");
3283 io_delegate_.SetFileContents("new/p/Foo.aidl",
3284 "package p;"
3285 "@Backing(type=\"long\")"
3286 "enum Foo {"
3287 " FOO, BAR,"
3288 "}");
3289 CaptureStderr();
3290 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3292}
3293
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003294TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3295 const string expected_stderr =
3296 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3297 "to @JavaPassthrough(annotation=\"Bob\")\n";
3298 io_delegate_.SetFileContents("old/p/Foo.aidl",
3299 "package p;"
3300 "@JavaPassthrough(annotation=\"Alice\")"
3301 "parcelable Foo {}");
3302 io_delegate_.SetFileContents("new/p/Foo.aidl",
3303 "package p;"
3304 "@JavaPassthrough(annotation=\"Bob\")"
3305 "parcelable Foo {}");
3306
3307 CaptureStderr();
3308 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3310}
3311
Devin Mooredb7ac512020-08-07 11:17:36 -07003312TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3313 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003314 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003315 io_delegate_.SetFileContents("old/p/Foo.aidl",
3316 "package p;"
3317 "parcelable Foo {"
3318 " int A;"
3319 "}");
3320 io_delegate_.SetFileContents("new/p/Foo.aidl",
3321 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003322 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003323 " int A;"
3324 "}");
3325 CaptureStderr();
3326 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3327 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3328}
3329
3330TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3331 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003332 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003333 io_delegate_.SetFileContents("old/p/Foo.aidl",
3334 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003335 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003336 " int A;"
3337 "}");
3338 io_delegate_.SetFileContents("new/p/Foo.aidl",
3339 "package p;"
3340 "parcelable Foo {"
3341 " int A;"
3342 "}");
3343 CaptureStderr();
3344 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3346}
3347
Daniel Norman85aed542019-08-21 12:01:14 -07003348TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003349 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003350 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3351 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003352 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003353 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003354 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003356}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003357
Daniel Norman85aed542019-08-21 12:01:14 -07003358TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003359 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003360 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3361 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003362 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003363 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003365}
Jiyong Parka428d212018-08-29 22:26:30 +09003366
Daniel Norman85aed542019-08-21 12:01:14 -07003367TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003368 const string expected_stderr =
3369 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003370 io_delegate_.SetFileContents("old/p/I.aidl",
3371 "package p; interface I {"
3372 "const int A = 1; const int B = 2;}");
3373 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003374 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003375 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003376 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003377}
Jiyong Parka428d212018-08-29 22:26:30 +09003378
Daniel Norman85aed542019-08-21 12:01:14 -07003379TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003380 const string expected_stderr =
3381 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003382 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3383 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003384 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003385 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003386 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003387}
3388
Devin Moorec7e47a32020-08-07 10:55:25 -07003389TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3390 const string expected_stderr =
3391 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3392 "This is an incompatible change for FixedSize types.\n";
3393 io_delegate_.SetFileContents("old/p/Foo.aidl",
3394 "package p; @FixedSize parcelable Foo { int A = 1; }");
3395 io_delegate_.SetFileContents("new/p/Foo.aidl",
3396 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3397 CaptureStderr();
3398 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3400}
3401
Jeongik Cha68d18e72021-04-29 20:07:01 +09003402TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3403 const string expected_stderr =
3404 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3405 "android.net.UidRangeParcel is changed from 1 to 2. "
3406 "But it is forbidden because of legacy support.\n";
3407 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3408 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3409 io_delegate_.SetFileContents(
3410 "new/android/net/UidRangeParcel.aidl",
3411 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3412 CaptureStderr();
3413 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3415}
3416
Devin Moorec7e47a32020-08-07 10:55:25 -07003417TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3418 const string expected_stderr =
3419 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3420 io_delegate_.SetFileContents("old/p/Foo.aidl",
3421 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3422 io_delegate_.SetFileContents("new/p/Foo.aidl",
3423 "package p; @FixedSize parcelable Foo { int A = 1; }");
3424 CaptureStderr();
3425 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3426 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3427}
3428
3429TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3430 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003431 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003432 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003433 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3434 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003435 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003436 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003437 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003438 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003439 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003440 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3441 "f.\n"
3442 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3443 "nullable1.\n"
3444 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3445 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003446
3447 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003448 "@FixedSize parcelable Foo {\n"
3449 " int[] a;\n"
3450 " Bar b;\n"
3451 " String c;\n"
3452 " ParcelFileDescriptor d;\n"
3453 " IBinder e;\n"
3454 " List<String> f;\n"
3455 " int isFixedSize;\n"
3456 " @nullable OtherFixed nullable1;\n"
3457 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003458 "}");
3459 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003460 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003461 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003462
3463 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003464 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3466}
3467
3468TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3469 const string expected_stderr = "";
3470
3471 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3472 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3473 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003474 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003475
3476 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003477 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003478 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3479}
3480
Jiyong Park8c380532018-08-30 14:55:26 +09003481TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003482 const string expected_stderr =
3483 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3484 "dir1/q/IBar.aidl\n"
3485 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003486 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003487 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3488 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3489 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3490 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3491
Devin Moore097a3ab2020-03-11 16:08:44 -07003492 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003493 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003494 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003495}
3496
Jiyong Parked65bf42018-08-28 15:43:27 +09003497TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003498 const string expected_stderr =
3499 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3500 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003501 Options options = Options::From("aidl --checkapi old new");
3502 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3503 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003504
3505 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3506
Jiyong Parke59c3682018-09-11 23:10:25 +09003507 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003508 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003509 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003510 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003511}
3512
Jooyung Han652ce482021-02-26 12:40:35 +09003513TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3514 Options options =
3515 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003516
3517 // use without import
3518 io_delegate_.SetFileContents("p/IFoo.aidl",
3519 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003520 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003521
3522 // capture output files
3523 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003524
Devin Moore7b8d5c92020-03-17 14:14:08 -07003525 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003526 io_delegate_.SetFileContents(
3527 "p/IFoo.aidl",
3528 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003529 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003530 // output files should be the same
3531 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003532
3533 // use with import (as before)
3534 io_delegate_.SetFileContents("p/IFoo.aidl",
3535 "package p;"
3536 "import android.os.ParcelFileDescriptor;"
3537 "interface IFoo{"
3538 " void foo(in ParcelFileDescriptor fd);"
3539 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003540 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003541 // output files should be the same
3542 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003543}
Jiyong Parked65bf42018-08-28 15:43:27 +09003544
Jooyung Han020d8d12021-02-26 17:23:02 +09003545TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3546 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3547 CaptureStderr();
3548 io_delegate_.SetFileContents("p/IFoo.aidl",
3549 "package p;"
3550 "interface IFoo{"
3551 " void foo(out ParcelFileDescriptor fd);"
3552 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003553 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003554 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3555}
3556
3557TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3558 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3559 CaptureStderr();
3560 io_delegate_.SetFileContents("p/IFoo.aidl",
3561 "package p;"
3562 "interface IFoo{"
3563 " void foo(ParcelFileDescriptor fd);"
3564 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003565 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003566 EXPECT_THAT(GetCapturedStderr(),
3567 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3568}
3569
Jiyong Park3633b722019-04-11 15:38:26 +09003570TEST_F(AidlTest, ManualIds) {
3571 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3572 io_delegate_.SetFileContents("IFoo.aidl",
3573 "interface IFoo {\n"
3574 " void foo() = 0;\n"
3575 " void bar() = 1;\n"
3576 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003577 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003578}
3579
3580TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3581 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3582 io_delegate_.SetFileContents("IFoo.aidl",
3583 "interface IFoo {\n"
3584 " void foo() = 0;\n"
3585 " void bar() = 1;\n"
3586 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003587 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003588}
3589
3590TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003591 const string expected_stderr =
3592 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003593 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3594 io_delegate_.SetFileContents("IFoo.aidl",
3595 "interface IFoo {\n"
3596 " void foo() = 3;\n"
3597 " void bar() = 3;\n"
3598 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003599 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003600 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003601 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003602}
3603
3604TEST_F(AidlTest, FailOnOutOfRangeIds) {
3605 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003606 const string expected_stderr =
3607 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3608 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003609 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3610 io_delegate_.SetFileContents("IFoo.aidl",
3611 "interface IFoo {\n"
3612 " void foo() = 3;\n"
3613 " void bar() = 16777115;\n"
3614 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003615 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003616 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003617 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003618}
3619
3620TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003621 const string expected_stderr =
3622 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003623 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3624 io_delegate_.SetFileContents("IFoo.aidl",
3625 "interface IFoo {\n"
3626 " void foo() = 3;\n"
3627 " void bar();\n"
3628 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003629 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003630 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003631 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003632}
3633
Jiyong Parkc6816252019-07-08 08:12:28 +09003634TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3635 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3636 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3637 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003638 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003639}
3640
3641TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003642 const string expected_stderr =
3643 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3644 "dir/IBar.aidl\n"
3645 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003646 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003647
Jiyong Parkc6816252019-07-08 08:12:28 +09003648 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3649 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3650 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3651 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003652 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003653 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003654 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003655}
3656
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003657TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3658 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3659 "package a.b;\n"
3660 "import a.b.IBar;\n"
3661 "import a.b.IQux;\n"
3662 "interface IFoo { IQux foo(); }\n");
3663 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3664 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3665
3666 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003667 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003668
3669 string output;
3670 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3671 // IBar was imported but wasn't used. include is not expected.
3672 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3673 // IBar was imported and used. include is expected.
3674 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3675}
3676
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003677TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003678 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003679 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003680 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3681 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003682 interface IFoo {
3683 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003684 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003685 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003686 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003687 // JavaPassthrough should work with other types as well (e.g. enum)
3688 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3689 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3690 @JavaPassthrough(annotation="@com.android.AliceTwo")
3691 @Backing(type="byte")
3692 enum MyEnum {
3693 a, b, c
3694 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003695
Jooyung Han4cde01d2020-10-13 11:10:47 +09003696 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003697 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003698
3699 string java_out;
3700 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003701 // type-decl-level annotations with newline at the end
3702 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3703 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3704 // member-decl-level annotations with newline at the end
3705 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3706 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3707 // inline annotations with space at the end
3708 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003709
Jooyung Han4cde01d2020-10-13 11:10:47 +09003710 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3711 // type-decl-level annotations with newline at the end
3712 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3713 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3714
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003715 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003716 Options cpp_options =
3717 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003718 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003719
Jooyung Han4cde01d2020-10-13 11:10:47 +09003720 Options ndk_options =
3721 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003722 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003723
Jooyung Han4cde01d2020-10-13 11:10:47 +09003724 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003725 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003726}
3727
Andrei Homescue61feb52020-08-18 15:44:24 -07003728TEST_F(AidlTest, ParseRustDerive) {
3729 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3730 @RustDerive(Clone=true, Copy=false)
3731 parcelable Foo {
3732 int a;
3733 })");
3734
3735 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003736 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003737
3738 string rust_out;
3739 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3740 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3741
3742 // Other backends shouldn't be bothered
3743 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003744 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003745
3746 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003747 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003748
3749 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003750 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003751}
3752
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003753TEST_F(AidlTest, EmptyEnforceAnnotation) {
3754 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3755 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3756 interface IFoo {
3757 @Enforce()
3758 void Protected();
3759 })");
3760
3761 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3762 CaptureStderr();
3763 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3764 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3765}
3766
3767TEST_F(AidlTest, EmptyEnforceCondition) {
3768 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3769 interface IFoo {
3770 @Enforce(condition="")
3771 void Protected();
3772 })");
3773
3774 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3775 CaptureStderr();
3776 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3777 EXPECT_THAT(GetCapturedStderr(),
3778 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3779}
3780
3781TEST_F(AidlTest, InvalidEnforceCondition) {
3782 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3783 interface IFoo {
3784 @Enforce(condition="invalid")
3785 void Protected();
3786 })");
3787
3788 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3789 CaptureStderr();
3790 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3791 EXPECT_THAT(GetCapturedStderr(),
3792 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3793}
3794
Thiébaud Weksteen133da842021-10-29 16:49:58 +11003795TEST_F(AidlTest, InterfaceEnforceCondition) {
3796 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3797 @Enforce(condition="permission = INTERNET")
3798 interface IFoo {
3799 void Protected();
3800 })");
3801
3802 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3803 EXPECT_TRUE(compile_aidl(options, io_delegate_));
3804}
3805
3806TEST_F(AidlTest, InterfaceAndMethodEnforceCondition) {
3807 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3808 @Enforce(condition="permission = INTERNET")
3809 interface IFoo {
3810 @Enforce(condition="uid = SYSTEM_UID")
3811 void Protected();
3812 })");
3813
3814 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3815 EXPECT_TRUE(compile_aidl(options, io_delegate_));
3816}
3817
Jiyong Park56f73d72019-06-11 12:20:28 +09003818class AidlOutputPathTest : public AidlTest {
3819 protected:
3820 void SetUp() override {
3821 AidlTest::SetUp();
3822 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3823 }
3824
3825 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003826 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003827 // check the existence
3828 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3829 }
3830};
3831
3832TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3833 // <out_dir> / <package_name> / <type_name>.java
3834 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3835}
3836
3837TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3838 // when output file is explicitly set, it is always respected. -o option is
3839 // ignored.
3840 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3841}
3842
3843TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3844 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3845}
3846
3847TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3848 // output is the same as the input file except for the suffix
3849 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3850}
3851
Devin Moore7b8d5c92020-03-17 14:14:08 -07003852TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003853 AidlError error;
3854 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003855 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int (2147483650)\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003856 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003857 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3858 R"(package p;
3859 interface IFoo {
3860 const int int32_max_oob = 2147483650;
3861 }
3862 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003863 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003864 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3865 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003866}
3867
Devin Moore7b8d5c92020-03-17 14:14:08 -07003868TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003869 AidlError error;
3870 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003871 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int "
3872 "(-2147483650)\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003873 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003874 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3875 R"(package p;
3876 interface IFoo {
3877 const int int32_min_oob = -2147483650;
3878 }
3879 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003880 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003881 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3882 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003883}
3884
Devin Moore7b8d5c92020-03-17 14:14:08 -07003885TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003886 AidlError error;
3887 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003888 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003889 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003890 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3891 R"(package p;
3892 interface IFoo {
3893 const long int64_max_oob = 21474836509999999999999999;
3894 }
3895 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003896 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003897 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3898 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003899}
3900
Devin Moore7b8d5c92020-03-17 14:14:08 -07003901TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003902 AidlError error;
3903 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003904 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003905 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003906 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3907 R"(package p;
3908 interface IFoo {
3909 const long int64_min_oob = -21474836509999999999999999;
3910 }
3911 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003912 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003913 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3914 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003915}
3916
Devin Moore7b8d5c92020-03-17 14:14:08 -07003917TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003918 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003919 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003920 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte (FOO+1)\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003921 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3922 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003923 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3924 R"(package p;
3925 @Backing(type="byte")
3926 enum TestEnum {
3927 FOO = 127,
3928 BAR,
3929 }
3930 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003931 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003932 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003933 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003934}
3935
Steven Morelandb248d072021-09-29 19:07:17 -07003936TEST_P(AidlTest, FailOnUnsupportedBackingType) {
3937 AidlError error;
3938 const string expected_stderr =
3939 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
3940 "byte, int, long\n";
3941 CaptureStderr();
3942 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3943 R"(package p;
3944 @Backing(type="boolean")
3945 enum TestEnum {
3946 FOO = 0,
3947 BAR = 1,
3948 }
3949 )",
3950 typenames_, GetLanguage(), &error));
3951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3952 EXPECT_EQ(AidlError::BAD_TYPE, error);
3953}
3954
Devin Mooredecaf292020-04-30 09:16:40 -07003955TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3956 AidlError error;
3957 const string expected_stderr =
3958 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003959 "be one of: type\n";
3960 CaptureStderr();
3961 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3962 R"(package p;
3963 @Backing(foo="byte")
3964 enum TestEnum {
3965 FOO = 1,
3966 BAR,
3967 }
3968 )",
3969 typenames_, GetLanguage(), &error));
3970 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3971 EXPECT_EQ(AidlError::BAD_TYPE, error);
3972}
3973
Jooyung Han5721a232020-12-24 04:34:55 +09003974TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3975 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3976 CaptureStderr();
3977 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3979}
3980
Jooyung Han66813932020-10-23 13:24:44 +09003981TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003982 io_delegate_.SetFileContents("Foo.aidl",
3983 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3984 "Map<String, Baz> d; Bar[] e; }");
3985 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3986 io_delegate_.SetFileContents("Baz.aidl",
3987 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003988 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003989 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003990}
3991
Jooyung Han66813932020-10-23 13:24:44 +09003992TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003993 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003994 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003995 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003996 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3997 "named 'bar'.\n";
3998 CaptureStderr();
3999 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004000 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09004001 EXPECT_EQ(expected_error, GetCapturedStderr());
4002}
4003
Jooyung Han09e551c2021-05-11 11:44:48 +09004004TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
4005 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
4006 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
4007 CaptureStderr();
4008 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004009 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09004010 EXPECT_EQ("", GetCapturedStderr());
4011}
4012
Jooyung Han59af9cc2020-10-25 21:44:14 +09004013TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
4014 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
4015 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
4016 string expected_error =
4017 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09004018 "named 'bar'.\n";
4019 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004020 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004021 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09004022 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004023}
4024
Jooyung Han66813932020-10-23 13:24:44 +09004025TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004026 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004027 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
4028 string expected_error =
4029 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
4030 "only be an in parameter.\n";
4031 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004032 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004033 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004034 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004035}
4036
Jooyung Han66813932020-10-23 13:24:44 +09004037TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004038 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004039 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
4040 string expected_error =
4041 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
4042 "only be an in parameter.\n";
4043 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004044 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004045 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004046 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004047}
4048
Jooyung Han66813932020-10-23 13:24:44 +09004049TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004050 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09004051 Options options = Options::From("aidl --lang=java Foo.aidl");
4052 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09004053 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
4054 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09004055 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004056 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09004057 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4058}
Devin Moore53fc99c2020-08-12 08:07:52 -07004059
Jooyung Hanfe086af2021-01-16 03:44:47 +09004060TEST_P(AidlTest, UnionInUnion) {
4061 import_paths_.insert(".");
4062 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
4063 CaptureStderr();
4064 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
4065 EXPECT_THAT("", GetCapturedStderr());
4066}
4067
Jooyung Hanfe89f122020-10-14 03:49:18 +09004068TEST_P(AidlTest, UnionRejectsEmptyDecl) {
4069 const string method = "package a; union Foo {}";
4070 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
4071 CaptureStderr();
4072 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4073 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4074}
4075
4076TEST_P(AidlTest, UnionRejectsParcelableHolder) {
4077 const string method = "package a; union Foo { ParcelableHolder x; }";
4078 const string expected_stderr =
4079 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
4080 CaptureStderr();
4081 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4082 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4083}
4084
Jooyung Han53fb4242020-12-17 16:03:49 +09004085TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
4086 import_paths_.insert(".");
4087 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
4088 const string expected_err = "The union's first member should have a useful default value.";
4089 CaptureStderr();
4090 EXPECT_EQ(nullptr,
4091 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
4092 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
4093}
4094
Devin Moore53fc99c2020-08-12 08:07:52 -07004095TEST_P(AidlTest, GenericStructuredParcelable) {
4096 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004097 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004098 const string expected_stderr = "";
4099 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004100 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004101 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4102}
4103
Jooyung Han3f347ca2020-12-01 12:41:50 +09004104TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4105 io_delegate_.SetFileContents("Foo.aidl",
4106 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4107 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004108 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004109 const string expected_stderr = "";
4110 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004111 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004112 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4113
4114 string code;
4115 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4116 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4117const ::android::String16& Foo<T,U>::s() {
4118 static const ::android::String16 value(::android::String16(""));
4119 return value;
4120})--"));
4121}
4122
4123TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4124 io_delegate_.SetFileContents("Foo.aidl",
4125 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4126 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004127 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004128 const string expected_stderr = "";
4129 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004130 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004131 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4132
4133 string code;
4134 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4135 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4136const char* Foo<T, U>::s = "";
4137)--"));
4138}
4139
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004140TEST_F(AidlTest, NestedTypeArgs) {
4141 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004142 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4143
4144 io_delegate_.SetFileContents("a/Foo.aidl",
4145 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4146 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004147 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4148 const string expected_stderr = "";
4149 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004150 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004151 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4152
4153 string code;
4154 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004155 EXPECT_THAT(code,
4156 testing::HasSubstr(
4157 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4158}
4159
4160TEST_F(AidlTest, DoubleArrayError) {
4161 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4162
4163 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4164 const string expected_stderr =
4165 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4166 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004167 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004168 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4169}
4170
4171TEST_F(AidlTest, DoubleGenericError) {
4172 io_delegate_.SetFileContents("a/Bar.aidl",
4173 "package a; parcelable Bar { List<String><String> a; }");
4174
4175 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4176 const string expected_stderr =
4177 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004179 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004180 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4181}
4182
4183TEST_F(AidlTest, ArrayBeforeGenericError) {
4184 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4185
4186 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004187 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004188 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004189 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4190}
4191
4192TEST_F(AidlTest, NullableArraysAreNotSupported) {
4193 io_delegate_.SetFileContents("a/Bar.aidl",
4194 "package a; parcelable Bar { String @nullable [] a; }");
4195
4196 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4197 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004198 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004199 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4200}
4201
4202TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4203 io_delegate_.SetFileContents("a/Bar.aidl",
4204 "package a; parcelable Bar { List<@nullable String> a; }");
4205
4206 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4207 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004208 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004209 EXPECT_THAT(GetCapturedStderr(),
4210 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004211}
4212
Jooyung Han14004ed2020-10-16 03:49:57 +09004213struct GenericAidlTest : ::testing::Test {
4214 FakeIoDelegate io_delegate_;
4215 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004216 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004217 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4218 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4219 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4220
4221 Options options = Options::From(cmd);
4222 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004223 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004224 EXPECT_EQ("", GetCapturedStderr());
4225 }
4226};
4227
4228TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4229 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4230 string code;
4231 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4232 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4233 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4234 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4235}
4236
4237TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4238 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4239 string code;
4240 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4241 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4242 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4243 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4244}
4245
Devin Moore53fc99c2020-08-12 08:07:52 -07004246TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4247 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004248 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004249 const string expected_stderr =
4250 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4251 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004252 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004253 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4254}
4255
4256TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4257 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004258 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004259 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4260 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004261 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004262 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4263}
4264
Jooyung Han7a308842020-10-27 19:06:49 +09004265TEST_P(AidlTest, LongCommentWithinConstExpression) {
4266 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004267 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004268 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004269 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004270 EXPECT_EQ("", GetCapturedStderr());
4271}
4272
Jeongik Chaef44e622020-10-23 16:00:52 +09004273TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4274 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4275 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4276 std::string expectedErr =
4277 "ERROR: a/Foo.aidl:1.28-30: "
4278 "Encountered an untyped List or Map. The use of untyped List/Map is "
4279 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4280 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4281 "ERROR: a/Foo.aidl:1.35-37: "
4282 "Encountered an untyped List or Map. The use of untyped List/Map is "
4283 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4284 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4285 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004286 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004287 EXPECT_EQ(expectedErr, GetCapturedStderr());
4288}
4289
4290TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004291 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4292 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004293 std::string expectedErr =
4294 "ERROR: a/Foo.aidl:1.33-35: "
4295 "Encountered an untyped List or Map. The use of untyped List/Map is "
4296 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4297 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4298 "ERROR: a/Foo.aidl:1.40-42: "
4299 "Encountered an untyped List or Map. The use of untyped List/Map is "
4300 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4301 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004302 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004303 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004304 EXPECT_EQ(expectedErr, GetCapturedStderr());
4305}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004306
Jeongik Chaef44e622020-10-23 16:00:52 +09004307TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4308 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4309 io_delegate_.SetFileContents(
4310 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4311 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4312 std::string expectedErr =
4313 "ERROR: a/Foo.aidl:1.52-54: "
4314 "Encountered an untyped List or Map. The use of untyped List/Map is "
4315 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4316 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4317 "ERROR: a/Foo.aidl:1.64-66: "
4318 "Encountered an untyped List or Map. The use of untyped List/Map is "
4319 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4320 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4321 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004322 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004323 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004324}
4325
Jooyung Han690f5842020-12-04 13:02:04 +09004326TEST_F(AidlTest, EnumWithDefaults_Java) {
4327 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4328 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4329package p;
4330import p.Enum;
4331parcelable Foo {
4332 Enum e = Enum.BAR;
4333})");
4334 CaptureStderr();
4335 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004336 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004337 auto err = GetCapturedStderr();
4338 EXPECT_EQ("", err);
4339
4340 string code;
4341 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004342 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004343}
4344
4345TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4346 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4347 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4348package p;
4349import p.Enum;
4350parcelable Foo {
4351 Enum e = Enum.BAR;
4352})");
4353 CaptureStderr();
4354 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004355 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004356 auto err = GetCapturedStderr();
4357 EXPECT_EQ("", err);
4358
4359 string code;
4360 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4361 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4362}
4363
4364TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4365 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4366 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4367package p;
4368import p.Enum;
4369parcelable Foo {
4370 Enum e = Enum.BAR;
4371})");
4372 CaptureStderr();
4373 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004374 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004375 auto err = GetCapturedStderr();
4376 EXPECT_EQ("", err);
4377
4378 string code;
4379 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4380 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4381}
4382
4383TEST_F(AidlTest, EnumWithDefaults_Rust) {
4384 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4385 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4386package p;
4387import p.Enum;
4388parcelable Foo {
4389 int n = 42;
4390 Enum e = Enum.BAR;
4391})");
4392 CaptureStderr();
4393 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004394 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004395 auto err = GetCapturedStderr();
4396 EXPECT_EQ("", err);
4397
4398 string code;
4399 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4400 EXPECT_THAT(code, testing::HasSubstr(R"(
4401 fn default() -> Self {
4402 Self {
4403 n: 42,
4404 e: crate::mangled::_1_p_4_Enum::BAR,
4405 }
4406 })"));
4407}
4408
4409TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4410 import_paths_.insert("a");
4411 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4412 CaptureStderr();
4413 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4414package p;
4415import p.Enum;
4416parcelable Foo {
4417 int e = Enum.FOO | Enum.BAR;
4418})",
4419 typenames_, GetLanguage());
4420 auto err = GetCapturedStderr();
4421 EXPECT_EQ("", err);
4422 EXPECT_TRUE(type);
4423 const auto& fields = type->AsStructuredParcelable()->GetFields();
4424 EXPECT_EQ("int e = 3", fields[0]->ToString());
4425}
4426
4427TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4428 CaptureStderr();
4429 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4430@Backing(type="int")
4431enum Foo {
4432 STANDARD_SHIFT = 16,
4433 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4434 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4435}
4436)",
4437 typenames_, GetLanguage());
4438 auto err = GetCapturedStderr();
4439 EXPECT_EQ("", err);
4440 EXPECT_TRUE(type);
4441 const auto& enum_type = type->AsEnumDeclaration();
4442 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004443 auto writer = CodeWriter::ForString(&code);
4444 DumpVisitor visitor(*writer);
4445 visitor.Visit(*enum_type);
4446 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004447 EXPECT_EQ(R"--(@Backing(type="int")
4448enum Foo {
4449 STANDARD_SHIFT = 16,
4450 STANDARD_BT709 = 65536,
4451 STANDARD_BT601_625 = 131072,
4452}
4453)--",
4454 code);
4455}
4456
4457TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4458 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4459 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4460package p;
4461import p.Enum;
4462parcelable Foo {
4463 Enum e = Enum.FOO | Enum.BAR;
4464})");
4465 CaptureStderr();
4466 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004467 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004468 auto err = GetCapturedStderr();
4469 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4470 err);
4471}
4472
Jooyung Han361cd102021-05-24 11:30:10 +09004473TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4474 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4475 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4476package p;
4477import p.Enum;
4478parcelable Foo {
4479 Enum e = 1;
4480})");
4481 CaptureStderr();
4482 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004483 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004484 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4485}
4486
Jooyung Han690f5842020-12-04 13:02:04 +09004487TEST_P(AidlTest, DefaultWithEmptyArray) {
4488 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4489 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4490 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004491 auto options =
4492 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004493 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004494 auto err = GetCapturedStderr();
4495 EXPECT_EQ("", err);
4496}
4497
4498TEST_P(AidlTest, RejectRefsInAnnotation) {
4499 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4500 "package p; interface IFoo {\n"
4501 " const String ANNOTATION = \"@Annotation\";\n"
4502 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4503 "}");
4504 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004505 auto options =
4506 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004507 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004508 auto err = GetCapturedStderr();
4509 EXPECT_EQ(
4510 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4511 "ANNOTATION.\n",
4512 err);
4513}
4514
4515TEST_F(AidlTest, DefaultWithEnumValues) {
4516 io_delegate_.SetFileContents(
4517 "a/p/Foo.aidl",
4518 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4519 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4520 CaptureStderr();
4521 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004522 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004523 auto err = GetCapturedStderr();
4524 EXPECT_EQ("", err);
4525 string code;
4526 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4527 EXPECT_THAT(
4528 code, testing::HasSubstr(
4529 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4530}
4531
Jooyung Han14259392020-12-07 10:00:08 +09004532TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4533 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4534 CaptureStderr();
4535 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004536 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004537 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004538 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004539}
4540
4541TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4542 io_delegate_.SetFileContents("a/p/Foo.aidl",
4543 "package p; parcelable Foo { const int A = A + 1; }");
4544 CaptureStderr();
4545 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004546 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004547 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004548 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4549}
4550
4551TEST_F(AidlTest, RecursiveReferences) {
4552 io_delegate_.SetFileContents("a/p/Foo.aidl",
4553 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4554 io_delegate_.SetFileContents("a/p/Bar.aidl",
4555 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4556 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4557 CaptureStderr();
4558 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004559 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004560 EXPECT_EQ("", GetCapturedStderr());
4561}
4562
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004563TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4564 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4565 auto options =
4566 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4567 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4568 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004569 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004570 EXPECT_EQ(err, GetCapturedStderr());
4571}
4572
4573TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4574 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4575 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4576 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4577 auto options =
4578 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4579 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004580 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004581 EXPECT_EQ("", GetCapturedStderr());
4582}
4583
Jooyung Hane9f5b272021-01-07 00:18:11 +09004584TEST_P(AidlTest, UnknownConstReference) {
Jooyung Hane1abd592021-10-05 10:35:02 +09004585 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { int field = UNKNOWN_REF; }");
Jooyung Hane9f5b272021-01-07 00:18:11 +09004586 auto options =
4587 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4588 const string err =
Jooyung Hane1abd592021-10-05 10:35:02 +09004589 "ERROR: Foo.aidl:1.30-42: Can't find UNKNOWN_REF in Foo\n"
4590 "ERROR: Foo.aidl:1.30-42: Unknown reference 'UNKNOWN_REF'\n";
Jooyung Hane9f5b272021-01-07 00:18:11 +09004591 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004592 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004593 EXPECT_EQ(err, GetCapturedStderr());
4594}
4595
Jooyung Han29813842020-12-08 01:28:03 +09004596TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4597 string contents = R"(
4598import android.os.IBinder;
4599import android.os.IInterface;
4600interface IFoo {}
4601 )";
4602 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004603}
4604
Jooyung Han888c5bc2020-12-22 17:28:47 +09004605TEST_P(AidlTest, WarningInterfaceName) {
4606 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004607 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004608 " -Weverything -o out -h out p/Foo.aidl");
4609 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004610 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004611 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004612 GetCapturedStderr());
4613}
4614
4615TEST_P(AidlTest, ErrorInterfaceName) {
4616 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004617 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004618 " -Weverything -Werror -o out -h out p/Foo.aidl");
4619 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004620 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004621 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004622 GetCapturedStderr());
4623}
4624
Jiyong Park9f4c3822021-04-07 20:36:45 +09004625TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4626 const std::string input_file = "base/p/q/IFoo.aidl";
4627 const std::string header_dir = "out/";
4628 const std::string output_file = "out/base/p/q/IFoo.cpp";
4629 const std::string package = "p.q"; // not base.p.q
4630 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4631
4632 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4633 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004634 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004635 EXPECT_THAT(
4636 GetCapturedStderr(),
4637 testing::StartsWith(
4638 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4639 "but is out/base/p/q/IFoo.cpp."));
4640}
4641
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004642TEST_F(AidlTest, FormatCommentsForJava) {
4643 using android::aidl::FormatCommentsForJava;
4644
4645 struct TestCase {
4646 vector<Comment> comments;
4647 string formatted;
4648 };
4649 vector<TestCase> testcases = {
4650 {{}, ""},
4651 {{{"// line comments\n"}}, "// line comments\n"},
4652 {{{"// @hide \n"}}, "// @hide \n"},
4653 // Transform the last block comment as Javadoc.
4654 {{{"/*\n"
4655 " * Hello, world!\n"
4656 " */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004657 "/** Hello, world! */\n"},
4658 {{{"/* @hide */"}}, "/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004659 {{{"/**\n"
4660 " @param foo ...\n"
4661 "*/"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004662 "/** @param foo ... */\n"},
4663 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide */\n/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004664 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004665 "/* @deprecated first */\n/** @deprecated second */\n"},
4666 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated */\n/** @param foo */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004667 // Line comments are printed as they are
Steven Morelandc29d7172021-10-12 15:25:11 -07004668 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */\n// line comments\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004669 };
4670 for (const auto& [input, formatted] : testcases) {
4671 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4672 }
4673}
4674
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004675TEST_F(AidlTest, HideIsNotForArgs) {
4676 io_delegate_.SetFileContents("IFoo.aidl",
4677 "interface IFoo {\n"
4678 " void foo(in @Hide int x);\n"
4679 "}");
4680 auto options = Options::From("aidl --lang=java IFoo.aidl");
4681 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004682 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004683 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4684}
4685
4686TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4687 io_delegate_.SetFileContents(
4688 "IFoo.aidl",
4689 "interface IFoo {\n"
4690 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4691 "}");
4692 auto options = Options::From("aidl --lang=java IFoo.aidl");
4693 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004694 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004695 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4696}
4697
Jooyung Hanfa181932021-06-12 07:56:53 +09004698TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4699 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4700 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4701 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004702 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004703 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4704}
4705
Jooyung Hanfd3be322020-12-13 09:11:06 +09004706struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004707 string kind;
4708 string literal;
4709};
4710
Jooyung Hanfd3be322020-12-13 09:11:06 +09004711const TypeParam kTypeParams[] = {
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004712 {"primitive", "int"}, {"primitiveArray", "int[]"},
4713 {"String", "String"}, {"StringArray", "String[]"},
4714 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4715 {"parcelable", "a.Foo"}, {"enum", "a.Enum"},
4716 {"union", "a.Union"}, {"interface", "a.IBar"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004717};
4718
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004719struct ExpectedResult {
4720 string expected_error;
4721 string expected_error_for_nullable;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004722};
4723
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004724const std::map<std::string, ExpectedResult> kListSupportExpectations = {
4725 {"cpp_primitive", {"A generic type cannot", "A generic type cannot"}},
4726 {"java_primitive", {"A generic type cannot", "A generic type cannot"}},
4727 {"ndk_primitive", {"A generic type cannot", "A generic type cannot"}},
4728 {"rust_primitive", {"A generic type cannot", "A generic type cannot"}},
4729 {"cpp_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4730 {"java_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4731 {"ndk_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4732 {"rust_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4733 {"cpp_String", {"", ""}},
4734 {"java_String", {"", ""}},
4735 {"ndk_String", {"", ""}},
4736 {"rust_String", {"", ""}},
4737 {"cpp_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4738 {"java_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4739 {"ndk_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4740 {"rust_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4741 {"cpp_IBinder", {"", ""}},
4742 {"java_IBinder", {"", ""}},
4743 {"ndk_IBinder", {"", ""}},
4744 {"rust_IBinder", {"", ""}},
4745 {"cpp_ParcelFileDescriptor", {"", ""}},
4746 {"java_ParcelFileDescriptor", {"", ""}},
4747 {"ndk_ParcelFileDescriptor", {"", ""}},
4748 {"rust_ParcelFileDescriptor", {"", ""}},
4749 {"cpp_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4750 {"java_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4751 {"ndk_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4752 {"rust_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4753 {"cpp_parcelable", {"", ""}},
4754 {"java_parcelable", {"", ""}},
4755 {"ndk_parcelable", {"", ""}},
4756 {"rust_parcelable", {"", ""}},
4757 {"cpp_enum", {"A generic type cannot", "A generic type cannot"}},
4758 {"java_enum", {"A generic type cannot", "A generic type cannot"}},
4759 {"ndk_enum", {"A generic type cannot", "A generic type cannot"}},
4760 {"rust_enum", {"A generic type cannot", "A generic type cannot"}},
4761 {"cpp_union", {"", ""}},
4762 {"java_union", {"", ""}},
4763 {"ndk_union", {"", ""}},
4764 {"rust_union", {"", ""}},
Jooyung Hand236e552020-12-13 09:21:27 +09004765};
4766
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004767const std::map<std::string, ExpectedResult> kArraySupportExpectations = {
4768 {"cpp_primitive", {"", ""}},
4769 {"java_primitive", {"", ""}},
4770 {"ndk_primitive", {"", ""}},
4771 {"rust_primitive", {"", ""}},
4772 {"cpp_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4773 {"java_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4774 {"ndk_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4775 {"rust_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4776 {"cpp_String", {"", ""}},
4777 {"java_String", {"", ""}},
4778 {"ndk_String", {"", ""}},
4779 {"rust_String", {"", ""}},
4780 {"cpp_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4781 {"java_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4782 {"ndk_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4783 {"rust_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4784 {"cpp_IBinder", {"", ""}},
4785 {"java_IBinder", {"", ""}},
4786 {"ndk_IBinder", {"", ""}},
4787 {"rust_IBinder", {"", ""}},
4788 {"cpp_ParcelFileDescriptor", {"", ""}},
4789 {"java_ParcelFileDescriptor", {"", ""}},
4790 {"ndk_ParcelFileDescriptor", {"", ""}},
4791 {"rust_ParcelFileDescriptor", {"", ""}},
4792 {"cpp_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4793 {"java_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4794 {"ndk_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4795 {"rust_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4796 {"cpp_parcelable", {"", ""}},
4797 {"java_parcelable", {"", ""}},
4798 {"ndk_parcelable", {"", ""}},
4799 {"rust_parcelable", {"", ""}},
4800 {"cpp_enum", {"", ""}},
4801 {"java_enum", {"", ""}},
4802 {"ndk_enum", {"", ""}},
4803 {"rust_enum", {"", ""}},
4804 {"cpp_union", {"", ""}},
4805 {"java_union", {"", ""}},
4806 {"ndk_union", {"", ""}},
4807 {"rust_union", {"", ""}},
4808};
4809
4810const std::map<std::string, ExpectedResult> kFieldSupportExpectations = {
4811 {"cpp_primitive", {"", "cannot get nullable annotation"}},
4812 {"java_primitive", {"", "cannot get nullable annotation"}},
4813 {"ndk_primitive", {"", "cannot get nullable annotation"}},
4814 {"rust_primitive", {"", "cannot get nullable annotation"}},
4815 {"cpp_primitiveArray", {"", ""}},
4816 {"java_primitiveArray", {"", ""}},
4817 {"ndk_primitiveArray", {"", ""}},
4818 {"rust_primitiveArray", {"", ""}},
4819 {"cpp_String", {"", ""}},
4820 {"java_String", {"", ""}},
4821 {"ndk_String", {"", ""}},
4822 {"rust_String", {"", ""}},
4823 {"cpp_StringArray", {"", ""}},
4824 {"java_StringArray", {"", ""}},
4825 {"ndk_StringArray", {"", ""}},
4826 {"rust_StringArray", {"", ""}},
4827 {"cpp_IBinder", {"", ""}},
4828 {"java_IBinder", {"", ""}},
4829 {"ndk_IBinder", {"", ""}},
4830 {"rust_IBinder", {"", ""}},
4831 {"cpp_ParcelFileDescriptor", {"", ""}},
4832 {"java_ParcelFileDescriptor", {"", ""}},
4833 {"ndk_ParcelFileDescriptor", {"", ""}},
4834 {"rust_ParcelFileDescriptor", {"", ""}},
4835 {"cpp_interface", {"", ""}},
4836 {"java_interface", {"", ""}},
4837 {"ndk_interface", {"", ""}},
4838 {"rust_interface", {"", ""}},
4839 {"cpp_parcelable", {"", ""}},
4840 {"java_parcelable", {"", ""}},
4841 {"ndk_parcelable", {"", ""}},
4842 {"rust_parcelable", {"", ""}},
4843 {"cpp_enum", {"", "cannot get nullable annotation"}},
4844 {"java_enum", {"", "cannot get nullable annotation"}},
4845 {"ndk_enum", {"", "cannot get nullable annotation"}},
4846 {"rust_enum", {"", "cannot get nullable annotation"}},
4847 {"cpp_union", {"", ""}},
4848 {"java_union", {"", ""}},
4849 {"ndk_union", {"", ""}},
4850 {"rust_union", {"", ""}},
4851};
4852
4853class AidlTypeParamTest
4854 : public testing::TestWithParam<std::tuple<Options::Language, TypeParam, bool>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004855 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004856 void Run(const std::string& generic_type_decl,
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004857 const std::map<std::string, ExpectedResult>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004858 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004859 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004860 const auto& kind = std::get<1>(param).kind;
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004861 const bool nullable = std::get<2>(param);
Jooyung Hane87cdd02020-12-11 16:47:35 +09004862
4863 FakeIoDelegate io;
4864 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4865 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4866 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004867 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004868 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004869 if (nullable) {
4870 decl = "@nullable " + decl;
4871 }
4872 io.SetFileContents("a/Target.aidl", "package a; parcelable Target { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004873
4874 const auto options =
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004875 Options::From(fmt::format("aidl -I . --lang={} a/Target.aidl -o out -h out", lang));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004876 CaptureStderr();
4877 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004878 auto it = expectations.find(lang + "_" + kind);
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004879 ASSERT_TRUE(it != expectations.end()) << "missing expectation for " << lang << "_" << kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004880 const string err = GetCapturedStderr();
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004881 const string expected_error =
4882 nullable ? it->second.expected_error_for_nullable : it->second.expected_error;
4883 if (expected_error.empty()) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004884 EXPECT_EQ("", err);
4885 } else {
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004886 EXPECT_THAT(err, testing::HasSubstr(expected_error));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004887 }
4888 }
4889};
4890
4891INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004892 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004893 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4894 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004895 testing::ValuesIn(kTypeParams), testing::Values(true, false)),
4896 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam, bool>>& info) {
4897 string name = to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
4898 if (std::get<2>(info.param)) {
4899 name += "_nullable";
4900 }
4901 return name;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004902 });
4903
Jooyung Hanfd3be322020-12-13 09:11:06 +09004904TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4905 Run("List<{}>", kListSupportExpectations);
4906}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004907
Jooyung Hand236e552020-12-13 09:21:27 +09004908TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4909 Run("{}[]", kArraySupportExpectations);
4910}
4911
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004912TEST_P(AidlTypeParamTest, ParcelableFieldTypes) {
4913 Run("{}", kFieldSupportExpectations);
4914}
4915
Christopher Wiley90be4e32015-10-20 14:55:25 -07004916} // namespace aidl
4917} // namespace android