blob: bf81cf27a32cc02b5c29db1f1291c2acfb6238ba [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
380 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000382 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Devin Moore7b8d5c92020-03-17 14:14:08 -0700387TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700388 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000389 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900392 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Jiyong Park40782d02020-07-24 19:17:43 +0900396TEST_P(AidlTest, ParsesNonNullableAnnotation) {
397 auto parse_result =
398 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
399 ASSERT_NE(nullptr, parse_result);
400 const AidlInterface* interface = parse_result->AsInterface();
401 ASSERT_NE(nullptr, interface);
402 ASSERT_FALSE(interface->GetMethods().empty());
403 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
404}
405
Devin Moore7b8d5c92020-03-17 14:14:08 -0700406TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900407 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
408 typenames_, GetLanguage());
409 ASSERT_NE(nullptr, parse_result);
410 const AidlInterface* interface = parse_result->AsInterface();
411 ASSERT_NE(nullptr, interface);
412 ASSERT_FALSE(interface->GetMethods().empty());
413 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
414}
415
416TEST_P(AidlTest, ParsesNonUtf8Annotations) {
417 auto parse_result =
418 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
419 ASSERT_NE(nullptr, parse_result);
420 const AidlInterface* interface = parse_result->AsInterface();
421 ASSERT_NE(nullptr, interface);
422 ASSERT_FALSE(interface->GetMethods().empty());
423 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800424}
425
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900427 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
428 typenames_, GetLanguage());
429 ASSERT_NE(nullptr, parse_result);
430 const AidlInterface* interface = parse_result->AsInterface();
431 ASSERT_NE(nullptr, interface);
432 ASSERT_FALSE(interface->GetMethods().empty());
433 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800434}
435
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700437 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700438 const string expected_stderr =
439 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
440 "\"vintf\"'\n"
441 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
442 "--structured\n";
443 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700447 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700448}
449
Devin Moore7b8d5c92020-03-17 14:14:08 -0700450TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700452 const string expected_stderr =
453 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
454 "--structured\n";
455 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700456 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700459 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700460}
461
Devin Moore7b8d5c92020-03-17 14:14:08 -0700462TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700464 const string expected_stderr =
465 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
466 "\"vintf\"'\n";
467 CaptureStderr();
468 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700470 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700471 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700476 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
477 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700478 ASSERT_EQ(AidlError::OK, error);
479 ASSERT_NE(nullptr, parse_result);
480 const AidlInterface* interface = parse_result->AsInterface();
481 ASSERT_NE(nullptr, interface);
482 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700483}
484
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
486 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900487 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
488 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900489 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700490 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900491 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900492 "a/Foo.aidl",
493 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900494
Steven Moreland4e059132021-08-11 13:36:30 -0700495 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
496 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900497
Devin Moorec054bf82020-03-10 16:31:48 -0700498 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700499 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900500 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700501
502 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700503 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900504 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900505}
506
Jooyung Han1cbc4962020-10-25 10:07:15 +0900507TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
508 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
509 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
510 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700511 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900512
513 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900514 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900515 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
516
517 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900518 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700519 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900520
Jooyung Han1cbc4962020-10-25 10:07:15 +0900521 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700522 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900523}
524
Jooyung Han1cbc4962020-10-25 10:07:15 +0900525TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
526 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
527 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
528 CaptureStderr();
529 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700530 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900531 EXPECT_EQ("", GetCapturedStderr());
532
533 const string expected_to_string_method = R"--(
534 @Override
535 public String toString() {
536 switch (_tag) {
537 case a: return "a.Foo.a(" + (getA()) + ")";
538 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
539 }
540 throw new IllegalStateException("unknown field: " + _tag);
541 }
542)--";
543
544 string java_out;
545 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
546 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
547}
548
Jiyong Park9aa3d042020-12-04 23:30:02 +0900549TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
550 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
551 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
552 CaptureStderr();
553 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700554 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900555 EXPECT_EQ("", GetCapturedStderr());
556
557 const std::string expected = R"--(
558 @Override
559 public boolean equals(Object other) {
560 if (this == other) return true;
561 if (other == null) return false;
562 if (!(other instanceof Foo)) return false;
563 Foo that = (Foo)other;
564 if (!java.util.Objects.deepEquals(a, that.a)) return false;
565 if (!java.util.Objects.deepEquals(b, that.b)) return false;
566 return true;
567 }
568
569 @Override
570 public int hashCode() {
571 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
572 }
573)--";
574
575 string java_out;
576 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
577 EXPECT_THAT(java_out, testing::HasSubstr(expected));
578}
579
580TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
581 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
582 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
583 CaptureStderr();
584 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700585 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900586 EXPECT_EQ("", GetCapturedStderr());
587
588 const std::string expected = R"--(
589 @Override
590 public boolean equals(Object other) {
591 if (this == other) return true;
592 if (other == null) return false;
593 if (!(other instanceof Foo)) return false;
594 Foo that = (Foo)other;
595 if (_tag != that._tag) return false;
596 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
597 return true;
598 }
599
600 @Override
601 public int hashCode() {
602 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
603 }
604)--";
605
606 string java_out;
607 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
608 EXPECT_THAT(java_out, testing::HasSubstr(expected));
609}
610
Jooyung Han90345002020-10-23 15:28:53 +0900611TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900612 {
Jooyung Han90345002020-10-23 15:28:53 +0900613 io_delegate_.SetFileContents("a/Foo.aidl",
614 "package a; @JavaDerive(blah=true) parcelable Foo{}");
615 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700617 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900618 const std::string expected_stderr =
619 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900620 EXPECT_THAT(GetCapturedStderr(),
621 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900622 }
623
624 {
625 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
627 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700628 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900629 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900630 }
631
632 {
Jooyung Han90345002020-10-23 15:28:53 +0900633 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900634 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
635 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700636 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900637 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 }
639}
640
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900641TEST_P(AidlTest, ParseDescriptorAnnotation) {
642 AidlError error;
643 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
644 typenames_, GetLanguage(), &error, {"--structured"});
645 ASSERT_EQ(AidlError::OK, error);
646 ASSERT_NE(nullptr, parse_result);
647 const AidlInterface* interface = parse_result->AsInterface();
648 ASSERT_NE(nullptr, interface);
649 ASSERT_EQ("IBar", interface->GetDescriptor());
650}
651
Jooyung Han55db8112021-09-15 22:37:39 +0900652TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900653 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900654 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
655 GetLanguage()));
656 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
657
658 CaptureStderr();
659 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
660 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900661 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
662}
663
Jiyong Park40782d02020-07-24 19:17:43 +0900664TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700665 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700666 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900667}
668
669TEST_P(AidlTest, AcceptsOnewayInterface) {
670 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700672}
Christopher Wileyef140932015-11-03 09:29:19 -0800673
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700675 const string oneway_method =
676 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100678}
679
Steven Moreland65297cc2020-04-20 20:17:36 -0700680TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
681 const string oneway_method =
682 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
683 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
684 ASSERT_NE(nullptr, defined);
685 const AidlInterface* iface = defined->AsInterface();
686 ASSERT_NE(nullptr, iface);
687
688 const auto& methods = iface->GetMethods();
689 ASSERT_EQ(1u, methods.size());
690 const auto& method = methods[0];
691 const AidlTypeSpecifier& ret_type = method->GetType();
692
693 // TODO(b/151102494): these annotations should be on the method
694 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
695 ASSERT_TRUE(ret_type.IsHide());
696}
697
Devin Moore7b8d5c92020-03-17 14:14:08 -0700698TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100699 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900700 R"(package a;
701 /* foo */
702 interface IFoo {
703 /* i */
704 int i();
705 // j
706 @nullable String j();
707 // k1
708 /* k2 */
709 @UnsupportedAppUsage oneway void k(int a);
710 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100711
Jooyung Han8451a202021-01-16 03:07:06 +0900712 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900715 EXPECT_EQ("", GetCapturedStderr());
716
Jooyung Han161bb0f2021-01-21 12:30:16 +0900717 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100718
719 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900720 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
721 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
722 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100723}
724
Jooyung Han1a551d32020-10-05 15:37:26 +0900725TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
726 io_delegate_.SetFileContents("p/cpp_header.aidl",
727 R"(package p;
728 parcelable cpp_header cpp_header "bar/header";)");
729 import_paths_.emplace("");
730 const string input_path = "p/IFoo.aidl";
731 const string input = R"(package p;
732 import p.cpp_header;
733 interface IFoo {
734 // get bar
735 cpp_header get();
736 })";
737
738 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
739 EXPECT_NE(nullptr, parse_result);
740 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900741 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900742}
743
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900744TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
745 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
746 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
752TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
753 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
754 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
755 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
756 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700757 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900758 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
759}
760
Christopher Wileyef140932015-11-03 09:29:19 -0800761TEST_F(AidlTest, ParsesPreprocessedFile) {
762 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
763 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700764 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900765 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700766 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
767 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800768}
769
770TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
771 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
772 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900773
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700774 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900775 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700776 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
777 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800778}
779
Devin Moore7b8d5c92020-03-17 14:14:08 -0700780TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800781 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
782 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
783 "interface IBar {}");
784 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900785 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900786 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700787 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800788 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900789
Christopher Wiley41544372015-11-03 14:52:29 -0800790 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700791 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
792 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800793 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900794 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900795 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900796 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800797}
798
Jiyong Park8f6ec462020-01-19 20:52:47 +0900799// Special case of PreferImportToPreprocessed. Imported type should be preferred
800// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700801TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900802 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
803 io_delegate_.SetFileContents("one/IBar.aidl",
804 "package one; "
805 "interface IBar {}");
806 preprocessed_files_.push_back("preprocessed");
807 import_paths_.emplace("");
808 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700809 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900810 EXPECT_NE(nullptr, parse_result);
811
812 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700813 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
814 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900815 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900816 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900817 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900818 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
819}
820
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800821TEST_F(AidlTest, WritePreprocessedFile) {
822 io_delegate_.SetFileContents("p/Outer.aidl",
823 "package p; parcelable Outer.Inner;");
824 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
825 "interface IBar {}");
826
Jooyung Han93f48f02021-06-05 00:11:16 +0900827 vector<string> args{"aidl", "--preprocess", "preprocessed",
828 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900829 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900830 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800831
Jooyung Han93f48f02021-06-05 00:11:16 +0900832 std::map<std::string, std::string> expected = {{"preprocessed",
833 "parcelable p.Outer.Inner;\n"
834 "interface one.IBar {\n"
835 "}\n"}};
836 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
837}
838
839TEST_F(AidlTest, PreprocessVariousThings) {
840 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
841 "package foo.bar;\n"
842 "interface IFoo {\n"
843 " int foo();\n"
844 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
845 "}\n");
846 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
847 "package foo.bar;\n"
848 "parcelable Bar {\n"
849 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
850 " imported.Foo foo;\n"
851 "}\n");
852 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
853 "package foo.bar;\n"
854 "parcelable Gen<T> {\n"
855 "}\n");
856 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
857 "package foo.bar;\n"
858 "enum Enum {\n"
859 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
860 "}\n");
861 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
862 "package imported;\n"
863 "parcelable Foo {\n"
864 " const int FOO = 42;\n"
865 "}\n");
866
867 vector<string> args = {
868 "aidl",
869 "--preprocess",
870 "preprocessed",
871 "-Isub",
872 "-I.",
873 "foo/bar/IFoo.aidl",
874 "foo/bar/Bar.aidl",
875 "foo/bar/Gen.aidl",
876 "foo/bar/Enum.aidl",
877 };
878 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
879 std::string preprocessed =
880 "interface foo.bar.IFoo {\n"
881 " const int FOO = 44;\n"
882 "}\n"
883 "parcelable foo.bar.Bar {\n"
884 " const int BAR = 43;\n"
885 "}\n"
886 "parcelable foo.bar.Gen<T> {\n"
887 "}\n"
888 "enum foo.bar.Enum {\n"
889 " FOO = 3,\n"
890 " BAR = 6,\n"
891 "}\n";
892 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
893 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
894
895 // use preprocessed
896 io_delegate_.SetFileContents("a/Foo.aidl",
897 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
898 io_delegate_.SetFileContents("preprocessed", preprocessed);
899 CaptureStderr();
900 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700901 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900902 EXPECT_EQ("", GetCapturedStderr());
903 string code;
904 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
905 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
906}
907
Jooyung Han35784982021-06-29 06:26:12 +0900908TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
909 io_delegate_.SetFileContents("p/IFoo.aidl",
910 "package p;\n"
911 "import x.Outer;\n"
912 "interface IFoo {\n"
913 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
914 "}");
915 io_delegate_.SetFileContents("imported/x/Outer.aidl",
916 "package x;\n"
917 "parcelable Outer.Inner1;\n"
918 "parcelable Outer.Inner2;\n");
919 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
920 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700921 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900922 EXPECT_EQ("", GetCapturedStderr());
923}
924
925TEST_F(AidlTest,
926 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
927 // Main doc(Foo.aidl) is loaded
928 // And then framework.aidl is loaded as preprocessed. (conflict)
929 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
930 io_delegate_.SetFileContents("x/Foo.aidl",
931 "package x;\n"
932 "parcelable Foo.Inner;\n");
933 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
934 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700935 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900936 EXPECT_EQ("", GetCapturedStderr());
937}
938
939TEST_F(AidlTest,
940 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
941 // Main doc(IBar.aidl) is loaded first.
942 // Framework.aidl is loaded as preprocessed.
943 // And then import(Foo.aidl) is loaded. (conflict)
944 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
945 io_delegate_.SetFileContents("x/IBar.aidl",
946 "package x;\n"
947 "import x.Foo;\n"
948 "interface IBar {\n"
949 " void bar(in Foo.Inner inner);\n"
950 "}");
951 io_delegate_.SetFileContents("x/Foo.aidl",
952 "package x;\n"
953 "parcelable Foo.Inner;\n");
954 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
955 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700956 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900957 EXPECT_EQ("", GetCapturedStderr());
958}
959
Jooyung Han93f48f02021-06-05 00:11:16 +0900960TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
961 string simple_content = "package xxx; parcelable a.Foo;";
962 io_delegate_.SetFileContents("path", simple_content);
963 CaptureStderr();
964 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
965 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
966}
967
968TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
969 string simple_content = "parcelable a.Foo {}";
970 io_delegate_.SetFileContents("path", simple_content);
971 CaptureStderr();
972 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
973 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800974}
975
Jooyung Han13f1fa52021-06-11 18:06:12 +0900976TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
977 string contents = R"(
978 interface android.os.IBinder;
979 interface android.os.IInterface;
980 parcelable android.os.ParcelFileDescriptor;
981 )";
982 io_delegate_.SetFileContents("path", contents);
983 CaptureStderr();
984 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
985 EXPECT_THAT(GetCapturedStderr(), "");
986}
987
Jooyung Han720253d2021-01-05 19:13:17 +0900988TEST_P(AidlTest, SupportDeprecated) {
989 struct TestCase {
990 std::string output_file;
991 std::string annotation;
992 };
993
994 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900995 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900996 io_delegate_.SetFileContents(filename, contents);
997
998 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
999 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -07001000 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001001 for (const auto& [lang, test_case] : expectations) {
1002 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +09001003 string output;
Jooyung Han652ce482021-02-26 12:40:35 +09001004 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +09001005 EXPECT_THAT(output, HasSubstr(test_case.annotation));
1006 }
1007 };
1008
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001009 // Emit escaped string for notes
1010 CheckDeprecated(
1011 "IFoo.aidl",
1012 R"(interface IFoo {
1013 /**
1014 * @note asdf
1015 * @deprecated a really long deprecation message
1016 *
1017 * which is really long
1018 * @param foo bar
1019 */
1020 List<String> foo();
1021 })",
1022 {
1023 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1024 {Options::Language::CPP,
1025 {"out/IFoo.h",
1026 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1027 {Options::Language::NDK,
1028 {"out/aidl/IFoo.h",
1029 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1030 {Options::Language::RUST,
1031 {"out/IFoo.rs",
1032 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1033 });
1034
Jooyung Han24effbf2021-01-16 10:24:03 +09001035 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 CheckDeprecated(
1037 "IFoo.aidl",
1038 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001039 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001040 " List<String> foo();\n"
1041 "}",
1042 {
1043 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001044 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001045 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1046 {Options::Language::NDK,
1047 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1048 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1049 });
Jooyung Han720253d2021-01-05 19:13:17 +09001050
Jooyung Han24effbf2021-01-16 10:24:03 +09001051 // but not in line comments
1052 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1053 EXPECT_FALSE(parsed->IsDeprecated());
1054
1055 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001056 CheckDeprecated("Foo.aidl",
1057 "parcelable Foo {\n"
1058 " /** @deprecated use bar*/\n"
1059 " int foo = 0;\n"
1060 "}",
1061 {
1062 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1063 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1064 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1065 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1066 });
1067
Jooyung Han24effbf2021-01-16 10:24:03 +09001068 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001069 CheckDeprecated("IFoo.aidl",
1070 "interface IFoo {\n"
1071 " /** @deprecated use bar*/\n"
1072 " const int FOO = 0;\n"
1073 "}",
1074 {
1075 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1076 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1077 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1078 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1079 });
1080
1081 // union fields
1082 CheckDeprecated("Foo.aidl",
1083 "union Foo {\n"
1084 " int bar = 0;\n"
1085 " /** @deprecated use bar*/\n"
1086 " int foo;\n"
1087 "}",
1088 {
1089 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1090 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1091 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1093 });
1094
1095 CheckDeprecated("Foo.aidl",
1096 "/** @deprecated use Bar */\n"
1097 "parcelable Foo {}",
1098 {
1099 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1100 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1101 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1103 });
1104
1105 CheckDeprecated("Foo.aidl",
1106 "/** @deprecated use Bar */\n"
1107 "union Foo { int foo = 0; }",
1108 {
1109 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1110 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1111 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1112 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1113 });
1114
1115 CheckDeprecated("IFoo.aidl",
1116 "/** @deprecated use IBar */\n"
1117 "interface IFoo {}",
1118 {
1119 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1120 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1121 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1122 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1123 });
1124
1125 CheckDeprecated("Foo.aidl",
1126 "/** @deprecated use IBar */\n"
1127 "enum Foo { FOO }",
1128 {
1129 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1130 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1131 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001132 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001133 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1134 });
1135}
1136
Devin Moore7b8d5c92020-03-17 14:14:08 -07001137TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001138 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001139 io_delegate_.SetFileContents("p/Outer.aidl",
1140 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001141 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 CaptureStderr();
1143 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1144 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001145 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001146 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001147}
1148
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001150 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001151 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001152 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001153 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001154 // TODO(wiley): This should actually return nullptr because we require
1155 // the outer class name. However, for legacy reasons,
1156 // this behavior must be maintained. b/17415692
1157 EXPECT_NE(nullptr, parse_result);
1158}
1159
Jooyung Han05a532a2021-08-18 10:41:40 +09001160TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1161 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1162
1163 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1164 CaptureStderr();
1165 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1166 EXPECT_EQ("", GetCapturedStderr());
1167}
1168
Christopher Wiley632801d2015-11-05 14:15:49 -08001169TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string expected_foo_stderr =
1171 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1172 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1173 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001174 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1175
Christopher Wiley632801d2015-11-05 14:15:49 -08001176 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001177 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001178 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001179 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001180 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001181
Steven Morelande2c64b42018-09-18 15:06:37 -07001182 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001183 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001185 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001186 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001187
Devin Moore097a3ab2020-03-11 16:08:44 -07001188 const string expected_bar_stderr =
1189 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1190 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1191 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001192 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1193
Jiyong Parkda8c6932019-08-12 19:56:08 +09001194 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001195 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001196 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001197 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001198 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001199 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001200 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001201 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001202 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001203}
1204
Jooyung Han13f1fa52021-06-11 18:06:12 +09001205TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1206 string contents = R"(
1207 import android.os.IBinder;
1208 import android.os.IInterface;
1209 interface IFoo {
1210 void foo(in IBinder b);
1211 }
1212 )";
1213 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1214}
1215
Devin Moore7b8d5c92020-03-17 14:14:08 -07001216TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001217 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001218 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001219 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001220 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1221 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001222 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001223 AidlError error;
1224 CaptureStderr();
1225 EXPECT_EQ(
1226 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001227 Parse("p/IFoo.aidl",
1228 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1231 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001232}
1233
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001235 AidlError error;
1236 const string expected_stderr =
1237 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1238 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001239 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1240 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001241 interface IFoo {
1242 const String DUPLICATED = "d";
1243 const int DUPLICATED = 1;
1244 }
1245 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001246 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1248 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001249}
1250
Steven Morelande689da22020-11-10 02:06:30 +00001251TEST_P(AidlTest, FailOnTooBigConstant) {
1252 AidlError error;
1253 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07001254 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte (256)\n";
Steven Morelande689da22020-11-10 02:06:30 +00001255 CaptureStderr();
1256 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1257 R"(package p;
1258 interface IFoo {
1259 const byte type2small = 256;
1260 }
1261 )",
1262 typenames_, GetLanguage(), &error));
1263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1264 EXPECT_EQ(AidlError::BAD_TYPE, error);
1265}
1266
Jooyung Han30f64ad2020-12-15 08:16:31 +09001267TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1268 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1269 CaptureStderr();
1270 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001271 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272 EXPECT_EQ("", GetCapturedStderr());
1273 string code;
1274 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1275 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1276}
1277
Jooyung Han535c5e82020-12-29 15:16:59 +09001278TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001279 using Ptr = unique_ptr<AidlConstantValue>;
1280 const AidlLocation& loc = AIDL_LOCATION_HERE;
1281
Jooyung Han535c5e82020-12-29 15:16:59 +09001282 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1283 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1284 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1285 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001286
1287 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1288 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001289 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001290
1291 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1292 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1293 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1294 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001295 EXPECT_EQ(
1296 expected,
1297 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001298}
1299
Devin Moore7b8d5c92020-03-17 14:14:08 -07001300TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001301 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001302 const string expected_stderr =
1303 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001304 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001305 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1306 R"(package p;
1307 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001308 parcelable IBar {}
1309 parcelable StructuredParcelable {}
1310 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001311 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001314 // Parse success is important for clear error handling even if the cases aren't
1315 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001316 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001317}
1318
Devin Moore7b8d5c92020-03-17 14:14:08 -07001319TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001320 AidlError error;
1321 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1322 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001323 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1325 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001326}
1327
Steven Morelandf9e922f2020-07-08 21:15:27 +00001328TEST_P(AidlTest, FailOnEmptyListWithComma) {
1329 AidlError error;
1330 const string expected_stderr =
1331 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1332 CaptureStderr();
1333 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1334 typenames_, GetLanguage(), &error));
1335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1336 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1337}
1338
Devin Moore7b8d5c92020-03-17 14:14:08 -07001339TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001340 AidlError error;
1341 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001342 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001343 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001344 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1345 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001346 interface IFoo {
1347 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1348 }
1349 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001350 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1352 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001353}
1354
Jiyong Park18132182020-06-08 20:24:40 +09001355TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1356 AidlError error;
1357 const string expected_stderr =
1358 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1359 "cpp_header (which can also be used as an identifier)\n";
1360 CaptureStderr();
1361 // Notice the trailing dot(.) in the name, which isn't a correct name
1362 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1363 GetLanguage(), &error));
1364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1365 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1366}
1367
1368TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1369 AidlError error;
1370 const string expected_stderr =
1371 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1372 "cpp_header (which can also be used as an identifier)\n";
1373 CaptureStderr();
1374 // Notice the trailing dot(.) in the package name
1375 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1376 GetLanguage(), &error));
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1379}
1380
Devin Moore7b8d5c92020-03-17 14:14:08 -07001381TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001383 auto parse_result = Parse("p/IFoo.aidl",
1384 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001385 interface IFoo {
1386 const int POSITIVE_HEX_VALUE = 0xf5;
1387 }
1388 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001389 typenames_, GetLanguage(), &error);
1390 EXPECT_NE(nullptr, parse_result);
1391 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001392 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001393 const auto& cpp_constants = interface->GetConstantDeclarations();
1394 EXPECT_EQ((size_t)1, cpp_constants.size());
1395 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001396 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001397 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001398}
1399
Devin Moore7b8d5c92020-03-17 14:14:08 -07001400TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001402 auto parse_result = Parse("p/IFoo.aidl",
1403 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001404 interface IFoo {
1405 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1406 }
1407 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001408 typenames_, GetLanguage(), &error);
1409 ASSERT_NE(nullptr, parse_result);
1410 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001411 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001412 const auto& cpp_constants = interface->GetConstantDeclarations();
1413 EXPECT_EQ((size_t)1, cpp_constants.size());
1414 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001415 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001416 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001417}
1418
Jooyung Han2aedb112021-09-29 09:37:59 +09001419TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001420 io_delegate_.SetFileContents(
1421 "p/Outer.aidl",
1422 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001423 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001424 const string input_path = "p/IFoo.aidl";
1425 const string input = "package p; import p.Outer; interface IFoo"
1426 " { Outer.Inner get(); }";
1427
Devin Moore7b8d5c92020-03-17 14:14:08 -07001428 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1429 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001430
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001431 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001432 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001433 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001434 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001435}
1436
Jooyung Han2aedb112021-09-29 09:37:59 +09001437TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001438 io_delegate_.SetFileContents("p/Outer.aidl",
1439 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1440 import_paths_.emplace("");
1441 const string input_path = "p/IFoo.aidl";
1442 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1443
1444 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1445 EXPECT_NE(nullptr, parse_result);
1446
1447 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1448 // C++ uses "::" instead of "." to refer to a inner class.
1449 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1450 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1451}
1452
Jooyung Han2aedb112021-09-29 09:37:59 +09001453TEST_F(AidlTest, UnderstandsNestedTypes) {
1454 io_delegate_.SetFileContents("p/IOuter.aidl",
1455 "package p;\n"
1456 "interface IOuter {\n"
1457 " parcelable Inner {}\n"
1458 "}");
1459 import_paths_.emplace("");
1460 const string input_path = "p/IFoo.aidl";
1461 const string input =
1462 "package p;\n"
1463 "import p.IOuter;\n"
1464 "interface IFoo {\n"
1465 " IOuter.Inner get();\n"
1466 "}";
1467 CaptureStderr();
1468 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1469 EXPECT_EQ(GetCapturedStderr(), "");
1470
1471 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1472 // C++ uses "::" instead of "." to refer to a inner class.
1473 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1474 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1475}
1476
Jooyung Hanf8c39632021-10-05 09:56:29 +09001477TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1478 const string input_path = "p/IFoo.aidl";
1479 const string input =
1480 "package p;\n"
1481 "interface IFoo {\n"
1482 " parcelable Inner {\n"
1483 " enum Enum { A }\n"
1484 " }\n"
1485 "}";
1486 CaptureStderr();
1487 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1488 EXPECT_EQ(GetCapturedStderr(), "");
1489
1490 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1491 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1492 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1493 EXPECT_TRUE(enum_type.is_resolved);
1494 EXPECT_TRUE(inner_type.is_resolved);
1495 EXPECT_TRUE(ifoo_type.is_resolved);
1496 // GetParentType()
1497 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1498 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1499 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1500 // GetRootType()
1501 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1502 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1503 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1504 // GetDocument()
1505 auto main_document = &typenames_.MainDocument();
1506 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1507 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1508 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1509}
1510
Jooyung Han2aedb112021-09-29 09:37:59 +09001511TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1512 io_delegate_.SetFileContents("p/IOuter.aidl",
1513 "package p;\n"
1514 "interface IOuter {\n"
1515 " parcelable Inner {}\n"
1516 "}");
1517 import_paths_.emplace("");
1518 const string input_path = "p/IFoo.aidl";
1519 const string input =
1520 "package p;\n"
1521 "interface IFoo {\n"
1522 " p.IOuter.Inner get();\n"
1523 "}";
1524 CaptureStderr();
1525 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1526 EXPECT_EQ(GetCapturedStderr(), "");
1527
1528 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1529}
1530
1531TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1532 io_delegate_.SetFileContents("p/IOuter.aidl",
1533 "package p;\n"
1534 "interface IOuter {\n"
1535 " parcelable Inner {}\n"
1536 "}");
1537 import_paths_.emplace("");
1538 const string input_path = "p/IFoo.aidl";
1539 const string input =
1540 "package p;\n"
1541 "import p.IOuter.Inner;"
1542 "interface IFoo {\n"
1543 " Inner get();\n"
1544 "}";
1545 CaptureStderr();
1546 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1547 EXPECT_EQ(GetCapturedStderr(), "");
1548
1549 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1550}
1551
1552TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1553 const string input_path = "p/IFoo.aidl";
1554 const string input =
1555 "package p;\n"
1556 "interface IFoo {\n"
1557 " parcelable Result {}\n"
1558 " Result get();\n"
1559 "}";
1560 CaptureStderr();
1561 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1562 EXPECT_EQ(GetCapturedStderr(), "");
1563
1564 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1565}
1566
1567// Finding the type of nested named member.
1568struct TypeFinder : AidlVisitor {
1569 string name;
1570 const AidlTypeSpecifier* type = nullptr;
1571 TypeFinder(std::string name) : name(name) {}
1572 void Visit(const AidlVariableDeclaration& v) override {
1573 if (v.GetName() == name) {
1574 type = &v.GetType();
1575 }
1576 }
1577 void Visit(const AidlMethod& m) override {
1578 if (m.GetName() == name) {
1579 type = &m.GetType();
1580 }
1581 }
1582 static string Get(const AidlDefinedType& type, const string& name) {
1583 TypeFinder v(name);
1584 VisitTopDown(v, type);
1585 return v.type ? v.type->Signature() : "(null)";
1586 };
1587};
1588
1589TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1590 io_delegate_.SetFileContents("q/IBar.aidl",
1591 "package q;\n"
1592 "interface IBar {\n"
1593 " parcelable Baz {}\n"
1594 "}");
1595 import_paths_.emplace("");
1596 const string input_path = "p/IFoo.aidl";
1597 const string input =
1598 "package p;\n"
1599 "import q.IBar;\n"
1600 "interface IFoo {\n"
1601 " parcelable Nested {\n"
1602 " Baz t1;\n"
1603 " }\n"
1604 " parcelable Baz { }\n"
1605 " IBar.Baz t2();\n"
1606 " Baz t3();\n"
1607 "}";
1608 CaptureStderr();
1609 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1610 EXPECT_EQ(GetCapturedStderr(), "");
1611 ASSERT_NE(nullptr, foo);
1612
1613 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1614 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1615 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1616}
1617
1618TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1619 const string input_path = "p/Foo.aidl";
1620 const string input =
1621 "package p;\n"
1622 "parcelable Foo {\n"
1623 " parcelable Foo {}\n"
1624 "}";
1625 CaptureStderr();
1626 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1627 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1628}
1629
Jooyung Han2b1487d2021-09-30 09:57:01 +09001630TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1631 const string input_path = "p/IFoo.aidl";
1632 const string input =
1633 "package p;\n"
1634 "interface IFoo {\n"
1635 " parcelable Bar cpp_header \"Bar.h\";\n"
1636 "}";
1637 CaptureStderr();
1638 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1639 EXPECT_THAT(GetCapturedStderr(),
1640 HasSubstr("Unstructured parcelables should be at the root scope"));
1641}
1642
Jooyung Han7fc5de02021-09-30 22:26:27 +09001643TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1644 const string input_path = "p/Foo.aidl";
1645 const string input =
1646 "package p;\n"
1647 "parcelable Foo<T> {\n"
1648 " parcelable Bar {}\n"
1649 "}";
1650 CaptureStderr();
1651 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1652 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1653}
1654
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001655TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1656 const string input_path = "p/IFoo.aidl";
1657 const string input =
1658 "package p;\n"
1659 "interface IFoo {\n"
1660 " parcelable;\n" // missing identifier
1661 "}";
1662 CaptureStderr();
1663 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1664 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1665}
1666
Jooyung Han2aedb112021-09-29 09:37:59 +09001667TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1668 const string input_path = "p/Foo.aidl";
1669 const string input =
1670 "package p;\n"
1671 "interface Foo {\n"
1672 " parcelable Bar {}\n"
1673 " parcelable Bar {}\n"
1674 "}";
1675 CaptureStderr();
1676 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1677 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1678}
1679
1680TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1681 struct Failure {
1682 string err;
1683 };
1684 struct TestCase {
1685 string type;
1686 variant<string, Failure> expected; // success<0> or failure<1>
1687 };
1688 vector<TestCase> cases = {
1689 {"foo.A", "foo.A"},
1690 {"foo.A.B", "foo.A.B"},
1691 {"@nullable(heap=true) A", "foo.A.B.A"},
1692 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1693 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1694 {"B", "foo.A.B.A.B"},
1695 {"A.B", "foo.A.B.A.B"},
1696 };
1697 const string input_path = "foo/A.aidl";
1698 for (auto& [type, expected] : cases) {
1699 AidlTypenames typenames;
1700 // clang-format off
1701 const string input =
1702 "package foo;\n"
1703 "parcelable A {\n"
1704 " parcelable B {\n"
1705 " parcelable A {\n"
1706 " parcelable B {\n"
1707 " }\n"
1708 " " + type + " m;\n"
1709 " }\n"
1710 " }\n"
1711 "}";
1712 // clang-format on
1713 CaptureStderr();
1714 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1715 if (auto failure = std::get_if<Failure>(&expected); failure) {
1716 ASSERT_EQ(nullptr, foo);
1717 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1718 } else {
1719 EXPECT_EQ(GetCapturedStderr(), "");
1720 ASSERT_NE(nullptr, foo);
1721 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1722 }
1723 }
1724}
1725
Jooyung Hanca84b032021-09-30 02:15:59 +09001726TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1727 const string input_path = "p/IFoo.aidl";
1728 const string input =
1729 "package p;\n"
1730 "interface IFoo {\n"
1731 " parcelable Result {}\n"
1732 "}";
1733 CaptureStderr();
1734 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1735 ASSERT_NE(nullptr, foo);
1736 EXPECT_EQ(GetCapturedStderr(), "");
1737
1738 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1739 ASSERT_NE(nullptr, result);
1740 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1741}
1742
Jooyung Han8e9ae872021-10-13 02:52:25 +09001743TEST_F(AidlTest, ReorderNestedTypesForCppOutput) {
1744 const string input_path = "p/IFoo.aidl";
1745 const string input = R"(
1746 package p;
1747 interface IFoo {
1748 // partial orderings for [A, D, G]:
1749 // D - A
1750 // A - G
1751 parcelable A {
1752 // partial orderings for [B, C]:
1753 // C - B
1754 parcelable B {
1755 C c;
1756 D.E d;
1757 }
1758 parcelable C {}
1759 }
1760 parcelable D {
1761 // partial orderings for [E, F]:
1762 // F - E
1763 parcelable E {
1764 F f;
1765 }
1766 parcelable F {}
1767 }
1768 parcelable G {
1769 A.B b;
1770 }
1771 }
1772 )";
1773 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1774 io_delegate_.SetFileContents(input_path, input);
1775 CaptureStderr();
1776 EXPECT_TRUE(compile_aidl(options, io_delegate_));
1777 EXPECT_EQ(GetCapturedStderr(), "");
1778
1779 string code;
1780 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/IFoo.h", &code));
1781 // check partial orderings: a should comes before b
1782 EXPECT_LE(code.find("class D"), code.find("class A"));
1783 EXPECT_LE(code.find("class A"), code.find("class G"));
1784 EXPECT_LE(code.find("class C"), code.find("class B"));
1785 EXPECT_LE(code.find("class F"), code.find("class E"));
1786}
1787
1788TEST_F(AidlTest, RejectsNestedTypesWithCyclicDeps) {
1789 const string input_path = "p/IFoo.aidl";
1790 const string input = R"(
1791 package p;
1792 interface IFoo {
1793 // Cycles:
1794 // D - A
1795 // A - G
1796 // G - D
1797 parcelable A {
1798 parcelable B {
1799 C c;
1800 }
1801 }
1802 parcelable C {
1803 parcelable D {
1804 E e;
1805 }
1806 }
1807 parcelable E {
1808 parcelable F {
1809 A a;
1810 }
1811 }
1812 }
1813 )";
1814 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1815 io_delegate_.SetFileContents(input_path, input);
1816 CaptureStderr();
1817 EXPECT_FALSE(compile_aidl(options, io_delegate_));
1818 EXPECT_THAT(GetCapturedStderr(), HasSubstr("IFoo has nested types with cyclic references."));
1819}
1820
Jooyung Han0a950bd2021-05-15 12:50:36 +09001821TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001822 const string input_path = "p/Wrapper.aidl";
1823 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001824
1825 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1826 EXPECT_NE(nullptr, parse_result);
1827
1828 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1829 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1830 (..., params->emplace_back(std::move(type_params)));
1831 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1832 };
1833
1834 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
Steven Morelanda7560e82021-10-08 16:24:39 -07001835 std::vector<std::unique_ptr<AidlAnnotation>> annotations;
1836 annotations.emplace_back(std::unique_ptr<AidlAnnotation>(
1837 AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {})));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001838 type->Annotate(std::move(annotations));
1839 return std::move(type);
1840 };
1841
1842 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1843 (void)type->SetArray();
1844 return std::move(type);
1845 };
1846
1847 auto w = type("p.Wrapper", type("String"));
1848 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1849
1850 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1851 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1852 cpp::CppNameOf(*nullable_w, typenames_));
1853
1854 auto array_w = set_array(type("p.Wrapper", type("String")));
1855 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1856 cpp::CppNameOf(*array_w, typenames_));
1857
1858 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1859 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1860 cpp::CppNameOf(*nullable_array_w, typenames_));
1861
1862 auto list_w = type("List", type("p.Wrapper", type("String")));
1863 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1864 cpp::CppNameOf(*list_w, typenames_));
1865
1866 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1867 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1868 cpp::CppNameOf(*nullable_list_w, typenames_));
1869}
1870
Devin Moore7b8d5c92020-03-17 14:14:08 -07001871TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001872 io_delegate_.SetFileContents(
1873 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001874 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001875 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001876 const string input_path = "p/IFoo.aidl";
1877 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001878 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1879 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001880 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001881 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001882 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001883
1884 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1885 // C++ understands C++ specific stuff
1886 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1887 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001888 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001889 EXPECT_EQ(1u, headers.size());
1890 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001891}
1892
Christopher Wileyf8136192016-04-12 14:19:35 -07001893TEST_F(AidlTest, WritesCorrectDependencyFile) {
1894 // While the in tree build system always gives us an output file name,
1895 // other android tools take advantage of our ability to infer the intended
1896 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001897 vector<string> args = {
1898 "aidl",
1899 "-d dep/file/path",
1900 "-o place/for/output",
1901 "p/IFoo.aidl"};
1902 Options options = Options::From(args);
1903 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001904 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001905 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001906 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001907 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1908}
1909
Dan Willemsen93298ee2016-11-10 23:55:55 -08001910TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1911 // While the in tree build system always gives us an output file name,
1912 // other android tools take advantage of our ability to infer the intended
1913 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001914 vector<string> args = {
1915 "aidl",
1916 "-d dep/file/path",
1917 "--ninja",
1918 "-o place/for/output",
1919 "p/IFoo.aidl"};
1920 Options options = Options::From(args);
1921 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001922 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001923 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001924 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001925 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1926}
1927
Jiyong Parkdf202122019-09-30 20:48:35 +09001928TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001929 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1930 // this by calling aidl with every .aidl file it finds, then parsing the
1931 // generated dependency files. Those that reference .java output files are
1932 // for interfaces and those that do not are parcelables. However, for both
1933 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001934 vector<string> args = {
1935 "aidl",
1936 "-o place/for/output",
1937 "-d dep/file/path",
1938 "p/Foo.aidl"};
1939 Options options = Options::From(args);
1940 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001941 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001942 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001943 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001944 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1945}
1946
1947TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1948 vector<string> args = {
1949 "aidl",
1950 "--structured",
1951 "-o place/for/output",
1952 "-d dep/file/path",
1953 "p/Foo.aidl"};
1954 Options options = Options::From(args);
1955 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001956 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001957 string actual_dep_file_contents;
1958 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1959 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001960}
1961
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001962TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1963 vector<string> args = {
1964 "aidl",
1965 "--lang=java",
1966 "-o place/for/output",
1967 "p/Foo.aidl"};
1968 Options options = Options::From(args);
1969 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001970 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001971 string output_file_contents;
1972 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1973}
1974
Devin Moore21b26772020-08-26 16:37:56 -07001975TEST_P(AidlTest, RejectsListArray) {
Jooyung Han49b8f362021-10-15 10:58:02 +09001976 const string input = "package a; parcelable Foo { List<String>[] lists; }";
Devin Moore21b26772020-08-26 16:37:56 -07001977 CaptureStderr();
Jooyung Han49b8f362021-10-15 10:58:02 +09001978 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", input, typenames_, GetLanguage()));
1979 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Arrays of List are not supported"));
Devin Moore21b26772020-08-26 16:37:56 -07001980}
1981
Jiyong Parkf8d53612020-05-04 14:06:13 +09001982TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1983 AidlError error;
1984 string expected_stderr =
1985 "ERROR: a/IFoo.aidl:2.7-11: "
1986 "Encountered an untyped List or Map. The use of untyped List/Map is "
1987 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1988 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1989 if (GetLanguage() != Options::Language::JAVA) {
1990 expected_stderr =
1991 "ERROR: a/IFoo.aidl:2.1-7: "
1992 "Currently, only the Java backend supports non-generic List.\n";
1993 }
1994
1995 const string primitive_interface =
1996 "package a; interface IFoo {\n"
1997 " List foo(); }";
1998 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001999 AidlTypenames tn1;
2000 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002001 {"--structured"}));
2002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09002003
2004 string primitive_parcelable =
2005 "package a; parcelable IFoo {\n"
2006 " List foo;}";
2007 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002008 AidlTypenames tn2;
2009 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002010 {"--structured"}));
2011 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2012}
2013
Jeongik Cha225519b2020-08-29 01:55:32 +09002014TEST_P(AidlTest, ExtensionTest) {
2015 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002016 string extendable_parcelable =
2017 "package a; parcelable Data {\n"
2018 " ParcelableHolder extension;\n"
2019 " ParcelableHolder extension2;\n"
2020 "}";
Andrei Homescub2316a52021-09-04 04:41:12 +00002021 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
2022 EXPECT_EQ("", GetCapturedStderr());
Jeongik Cha225519b2020-08-29 01:55:32 +09002023}
2024TEST_P(AidlTest, ParcelableHolderAsReturnType) {
2025 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002026 string parcelableholder_return_interface =
2027 "package a; interface IFoo {\n"
2028 " ParcelableHolder foo();\n"
2029 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002030 EXPECT_EQ(nullptr,
2031 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09002032
Jeongik Cha225519b2020-08-29 01:55:32 +09002033 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
2034 GetCapturedStderr());
2035}
2036
2037TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
2038 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002039 string extendable_parcelable_arg_interface =
2040 "package a; interface IFoo {\n"
2041 " void foo(in ParcelableHolder ph);\n"
2042 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002043 EXPECT_EQ(nullptr,
2044 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
2045
Jeongik Cha225519b2020-08-29 01:55:32 +09002046 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
2047 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09002048}
2049
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002050TEST_P(AidlTest, RejectNullableParcelableHolderField) {
2051 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002052 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002053 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
2054 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002055 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2057}
2058
Jooyung Han3f347ca2020-12-01 12:41:50 +09002059TEST_P(AidlTest, ParcelablesWithConstants) {
2060 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002061 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002062 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002063 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002064 EXPECT_EQ("", GetCapturedStderr());
2065}
2066
2067TEST_P(AidlTest, UnionWithConstants) {
2068 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002069 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002070 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002071 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002072 EXPECT_EQ("", GetCapturedStderr());
2073}
2074
Jooyung Han633eab62021-01-07 14:12:40 +09002075TEST_F(AidlTest, ConstantsWithAnnotations) {
2076 io_delegate_.SetFileContents("IFoo.aidl",
2077 "interface IFoo {\n"
2078 " @JavaPassthrough(annotation=\"@Foo\")\n"
2079 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2080 "}");
2081 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2082 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002083 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002084 EXPECT_EQ("", GetCapturedStderr());
2085 string code;
2086 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2087 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2088 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2089}
2090
Jiyong Park02da7422018-07-16 16:00:26 +09002091TEST_F(AidlTest, ApiDump) {
2092 io_delegate_.SetFileContents(
2093 "foo/bar/IFoo.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002094 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002095 "package foo.bar;\n"
2096 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002097 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002098 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002099 " /* @hide applied \n"
2100 " @deprecated use foo2 */\n"
2101 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2102 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002103 " IFoo foo3(IFoo foo);\n"
2104 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002105 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002106 " /** blahblah\n"
2107 " @deprecated\n"
2108 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002109 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002110 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002111 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002112 "}\n");
2113 io_delegate_.SetFileContents("foo/bar/Data.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002114 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002115 "package foo.bar;\n"
2116 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002117 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002118 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002119 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002120 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002121 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002122 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002123 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002124 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002125 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002126 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002127 "}\n");
2128 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002129 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2130 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002131 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002132 bool result = dump_api(options, io_delegate_);
2133 ASSERT_TRUE(result);
2134 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002135 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002136 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002137interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002138 /**
2139 * @hide
2140 * @deprecated use foo2
2141 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002142 int foo(out int[] a, String b, boolean c, inout List<String> d);
2143 int foo2(@utf8InCpp String x, inout List<String> y);
2144 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2145 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002146 /**
2147 * @deprecated reason why...
2148 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002149 const int A = 1;
2150 const String STR = "Hello";
2151}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002152)"),
2153 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002154
Jiyong Parke59c3682018-09-11 23:10:25 +09002155 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002156 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002157/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002158parcelable Data {
2159 int x = 10;
2160 int y;
2161 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002162 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002163}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002164)"),
2165 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002166}
2167
Jiyong Parked65bf42018-08-28 15:43:27 +09002168TEST_F(AidlTest, ApiDumpWithManualIds) {
2169 io_delegate_.SetFileContents(
2170 "foo/bar/IFoo.aidl",
2171 "package foo.bar;\n"
2172 "interface IFoo {\n"
2173 " int foo() = 1;\n"
2174 " int bar() = 2;\n"
2175 " int baz() = 10;\n"
2176 "}\n");
2177
Jiyong Parke59c3682018-09-11 23:10:25 +09002178 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002179 Options options = Options::From(args);
2180 bool result = dump_api(options, io_delegate_);
2181 ASSERT_TRUE(result);
2182 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002183 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002184 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002185interface IFoo {
2186 int foo() = 1;
2187 int bar() = 2;
2188 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002189}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002190)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002191}
2192
2193TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002194 const string expected_stderr =
2195 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2196 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002197 io_delegate_.SetFileContents(
2198 "foo/bar/IFoo.aidl",
2199 "package foo.bar;\n"
2200 "interface IFoo {\n"
2201 " int foo() = 1;\n"
2202 " int bar();\n"
2203 " int baz() = 10;\n"
2204 "}\n");
2205
Jiyong Parke59c3682018-09-11 23:10:25 +09002206 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002207 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002208 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002209 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002210 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002211}
2212
Jooyung Han965e31d2020-11-27 12:30:16 +09002213TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2214 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2215 "package foo.bar;\n"
2216 "interface IFoo {\n"
2217 " @utf8InCpp String foo();\n"
2218 " const @utf8InCpp String bar = \"bar\";\n"
2219 "}\n");
2220
2221 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2222 Options options = Options::From(args);
2223 CaptureStderr();
2224 EXPECT_TRUE(dump_api(options, io_delegate_));
2225 EXPECT_EQ("", GetCapturedStderr());
2226 string actual;
2227 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002228 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2229interface IFoo {
2230 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002231 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002232}
2233)"),
2234 actual);
2235}
2236
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002237TEST_F(AidlTest, ApiDumpWithEnums) {
2238 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2239 "package foo.bar;\n"
2240 "enum Enum {\n"
2241 " FOO,\n"
2242 " BAR = FOO + 1,\n"
2243 "}\n");
2244
2245 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2246 Options options = Options::From(args);
2247 CaptureStderr();
2248 EXPECT_TRUE(dump_api(options, io_delegate_));
2249 EXPECT_EQ("", GetCapturedStderr());
2250 string actual;
2251 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2252 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2253 "enum Enum {\n"
2254 " FOO = 0,\n"
2255 " BAR = 1,\n"
2256 "}\n"),
2257 actual);
2258}
2259
2260TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2261 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2262 "package foo.bar;\n"
2263 "enum Enum {\n"
2264 " FOO,\n"
2265 "}\n");
2266 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2267 "package foo.bar;\n"
2268 "import foo.bar.Enum;\n"
2269 "parcelable Foo {\n"
2270 " Enum e = Enum.FOO;\n"
2271 "}\n");
2272
2273 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2274 Options options = Options::From(args);
2275 CaptureStderr();
2276 EXPECT_TRUE(dump_api(options, io_delegate_));
2277 EXPECT_EQ("", GetCapturedStderr());
2278 string actual;
2279 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2280 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2281 "parcelable Foo {\n"
2282 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2283 "}\n"),
2284 actual);
2285}
2286
Jooyung Han71dfec32021-05-23 07:18:58 +09002287TEST_F(AidlTest, ApiDumpWithGenerics) {
2288 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2289 "package foo.bar;\n"
2290 "parcelable Foo<T, U> {\n"
2291 "}\n");
2292
2293 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2294 Options options = Options::From(args);
2295 CaptureStderr();
2296 EXPECT_TRUE(dump_api(options, io_delegate_));
2297 EXPECT_EQ("", GetCapturedStderr());
2298 string actual;
2299 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2300 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2301 "parcelable Foo<T, U> {\n"
2302 "}\n"),
2303 actual);
2304}
2305
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002306TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2307 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2308 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2309
2310 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2311 Options options = Options::From(args);
2312 CaptureStderr();
2313 EXPECT_FALSE(dump_api(options, io_delegate_));
2314 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2315}
2316
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002317TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002318 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002319 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2320 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002321 const string expected_map_stderr =
2322 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002323 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2324 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002325 "package p; interface IFoo {"
2326 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002327 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002328 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002330
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002331 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002332 "package p; interface IFoo {"
2333 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002334 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002335 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002336 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002337}
2338
Jeongik Chae48d9942020-01-02 17:39:00 +09002339TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 const string expected_stderr =
2341 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002342 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002343 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2344
2345 io_delegate_.SetFileContents("p/IFoo.aidl",
2346 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002347 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002348 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002349
2350 io_delegate_.SetFileContents("p/IFoo.aidl",
2351 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002352 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002353 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002354 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002356
2357 io_delegate_.SetFileContents("p/IFoo.aidl",
2358 "package p; interface IFoo {"
2359 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002360 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002361
2362 io_delegate_.SetFileContents("p/IFoo.aidl",
2363 "package p; interface IFoo {"
2364 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002365 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002366}
2367
Jeongik Chadf76dc72019-11-28 00:08:47 +09002368TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002369 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002370 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2371 io_delegate_.SetFileContents(options.InputFiles().front(),
2372 "package p; interface IFoo {"
2373 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002375 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002376 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002377}
2378
2379TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002380 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002381 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002382 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002383 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002384 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2385 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002386
Jooyung Han13f1fa52021-06-11 18:06:12 +09002387 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002388 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2389 io_delegate_.SetFileContents("p/IFoo.aidl",
2390 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002391 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002392 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002393 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002394 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002395 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002396 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002397 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002398 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002399 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002400 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002401 io_delegate_.SetFileContents("p/IFoo.aidl",
2402 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002403 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002404 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002405
2406 io_delegate_.SetFileContents("p/IFoo.aidl",
2407 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002408 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002409
2410 io_delegate_.SetFileContents("p/IFoo.aidl",
2411 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002412 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002413
Steven Moreland4e059132021-08-11 13:36:30 -07002414 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002415}
2416
Jeongik Cha0e426012019-07-29 15:57:02 +09002417TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2418 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002419 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2420 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002421 for (const auto& rawOption : rawOptions) {
2422 string expected_stderr =
2423 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002424 Options options = Options::From(rawOption);
2425 io_delegate_.SetFileContents(options.InputFiles().front(),
2426 "package foo.bar;\n"
2427 "interface IFoo1 { int foo(); }\n"
2428 "interface IFoo2 { int foo(); }\n"
2429 "parcelable Data1 { int a; int b;}\n"
2430 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002431 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002432 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002433 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002434
Jeongik Cha0e426012019-07-29 15:57:02 +09002435 io_delegate_.SetFileContents(options.InputFiles().front(),
2436 "package foo.bar;\n"
2437 "interface IFoo1 { int foo(); }\n"
2438 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002439 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002440 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002442
Devin Moore5de18ed2020-04-02 13:52:29 -07002443 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002444 io_delegate_.SetFileContents(options.InputFiles().front(),
2445 "package foo.bar;\n"
2446 "parcelable Data1 { int a; int b;}\n"
2447 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002448 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002449 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002450 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002451 }
2452}
2453
Devin Moorebdba2a82020-03-31 15:19:02 -07002454TEST_P(AidlTest, FailParseOnEmptyFile) {
2455 const string contents = "";
2456 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2457 CaptureStderr();
2458 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2459 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2460}
2461
Jiyong Parkb034bf02018-07-30 17:44:33 +09002462TEST_F(AidlTest, MultipleInputFiles) {
2463 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002464 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002465
2466 io_delegate_.SetFileContents(options.InputFiles().at(0),
2467 "package foo.bar;\n"
2468 "import foo.bar.Data;\n"
2469 "interface IFoo { Data getData(); }\n");
2470
2471 io_delegate_.SetFileContents(options.InputFiles().at(1),
2472 "package foo.bar;\n"
2473 "import foo.bar.IFoo;\n"
2474 "parcelable Data { IFoo foo; }\n");
2475
Steven Moreland4e059132021-08-11 13:36:30 -07002476 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002477
2478 string content;
2479 for (const auto file : {
2480 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2481 content.clear();
2482 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2483 EXPECT_FALSE(content.empty());
2484 }
2485}
2486
2487TEST_F(AidlTest, MultipleInputFilesCpp) {
2488 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002489 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002490
2491 io_delegate_.SetFileContents(options.InputFiles().at(0),
2492 "package foo.bar;\n"
2493 "import foo.bar.Data;\n"
2494 "interface IFoo { Data getData(); }\n");
2495
2496 io_delegate_.SetFileContents(options.InputFiles().at(1),
2497 "package foo.bar;\n"
2498 "import foo.bar.IFoo;\n"
2499 "parcelable Data { IFoo foo; }\n");
2500
Steven Moreland4e059132021-08-11 13:36:30 -07002501 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002502
2503 string content;
2504 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002505 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002506 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2507 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2508 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2509 content.clear();
2510 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2511 EXPECT_FALSE(content.empty());
2512 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002513}
2514
Andrei Homescub62afd92020-05-11 19:24:59 -07002515TEST_F(AidlTest, MultipleInputFilesRust) {
2516 Options options =
2517 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2518
2519 io_delegate_.SetFileContents(options.InputFiles().at(0),
2520 "package foo.bar;\n"
2521 "import foo.bar.Data;\n"
2522 "interface IFoo { Data getData(); }\n");
2523
2524 io_delegate_.SetFileContents(options.InputFiles().at(1),
2525 "package foo.bar;\n"
2526 "import foo.bar.IFoo;\n"
2527 "parcelable Data { IFoo foo; }\n");
2528
Steven Moreland4e059132021-08-11 13:36:30 -07002529 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002530
2531 string content;
2532 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2533 content.clear();
2534 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2535 EXPECT_FALSE(content.empty());
2536 }
2537}
2538
Devin Moore097a3ab2020-03-11 16:08:44 -07002539TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2540 const string expected_stderr =
2541 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002542 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2543 // int getInterfaceVersion() is one of the meta transactions
2544 io_delegate_.SetFileContents(options.InputFiles().front(),
2545 "package p; interface IFoo {"
2546 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002547 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002548 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2550}
Jiyong Park309668e2018-07-28 16:55:44 +09002551
Devin Moore097a3ab2020-03-11 16:08:44 -07002552TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2553 // boolean getInterfaceVersion() is not a meta transaction, but should be
2554 // prevented because return type is not part of a method signature
2555 const string expected_stderr =
2556 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2557 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002558 io_delegate_.SetFileContents(options.InputFiles().front(),
2559 "package p; interface IFoo {"
2560 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002562 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002563 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2564}
Jiyong Park309668e2018-07-28 16:55:44 +09002565
Devin Moore097a3ab2020-03-11 16:08:44 -07002566TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002567 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002568 const string expected_stderr =
2569 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2570 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002571 io_delegate_.SetFileContents(options.InputFiles().front(),
2572 "package p; interface IFoo {"
2573 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002574 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002575 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002577
2578 // this is not a meta interface method as it differs type arguments
2579 io_delegate_.SetFileContents(options.InputFiles().front(),
2580 "package p; interface IFoo {"
2581 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002582 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002583}
2584
Jooyung Hanb8a97772021-01-19 01:27:38 +09002585TEST_F(AidlTest, CheckApiForEquality) {
2586 CaptureStderr();
2587 Options options = Options::From("aidl --checkapi=equal old new");
2588
2589 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2590 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2591 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2592 "package p; interface IFoo{ @utf8InCpp String foo();}");
2593
2594 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2595 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2596}
2597
Daniel Norman85aed542019-08-21 12:01:14 -07002598TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002599 Options options = Options::From("aidl --checkapi old new");
2600 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2601 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2602 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2603 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2604
2605 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2606}
2607
Jiyong Park3656c3c2018-08-01 20:02:01 +09002608TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002609 Options options = Options::From("aidl --checkapi old new");
2610 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2611 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002612
2613 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2614}
2615
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002616TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2617 Options options = Options::From("aidl --checkapi old new");
2618 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2619 const string enum_definition = "package p; enum Enum { FOO }";
2620 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2621 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2622 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2623 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2624
2625 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2626}
2627
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002628TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2629 Options options = Options::From("aidl --checkapi old new -I import");
2630
2631 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2632 io_delegate_.SetFileContents("new/p/Foo.aidl",
2633 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2634 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2635
2636 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2637}
2638
Jooyung Han02a11be2021-02-11 13:18:06 +09002639TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2640 Options options = Options::From("aidl --checkapi=equal old new");
2641 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2642 const string enum_definition = "package p; enum Enum { FOO }";
2643 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2644 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2645 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2646 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2647 CaptureStderr();
2648 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2649 EXPECT_EQ("", GetCapturedStderr());
2650}
2651
Daniel Norman85aed542019-08-21 12:01:14 -07002652class AidlTestCompatibleChanges : public AidlTest {
2653 protected:
2654 Options options_ = Options::From("aidl --checkapi old new");
2655};
2656
2657TEST_F(AidlTestCompatibleChanges, NewType) {
2658 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2659 "package p;"
2660 "interface IFoo {"
2661 " void foo(int a);"
2662 "}");
2663 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2664 "package p;"
2665 "interface IFoo {"
2666 " void foo(int a);"
2667 "}");
2668 io_delegate_.SetFileContents("new/p/IBar.aidl",
2669 "package p;"
2670 "interface IBar {"
2671 " void bar();"
2672 "}");
2673 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2674}
2675
2676TEST_F(AidlTestCompatibleChanges, NewMethod) {
2677 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2678 "package p;"
2679 "interface IFoo {"
2680 " void foo(int a);"
2681 "}");
2682 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2683 "package p;"
2684 "interface IFoo {"
2685 " void foo(int a);"
2686 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002687 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002688 "}");
2689 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2690}
2691
2692TEST_F(AidlTestCompatibleChanges, NewField) {
2693 io_delegate_.SetFileContents("old/p/Data.aidl",
2694 "package p;"
2695 "parcelable Data {"
2696 " int foo;"
2697 "}");
2698 io_delegate_.SetFileContents("new/p/Data.aidl",
2699 "package p;"
2700 "parcelable Data {"
2701 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002702 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002703 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002704 "}");
2705 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2706}
2707
Jooyung Han05bd8a82021-04-28 23:56:38 +09002708TEST_F(AidlTestCompatibleChanges, NewField2) {
2709 io_delegate_.SetFileContents("old/p/Data.aidl",
2710 "package p;"
2711 "parcelable Data {"
2712 "}");
2713 io_delegate_.SetFileContents("new/p/Data.aidl",
2714 "package p;"
2715 "parcelable Data {"
2716 " int foo = 0;"
2717 "}");
2718 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2719}
2720
Daniel Norman85aed542019-08-21 12:01:14 -07002721TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2722 io_delegate_.SetFileContents("old/p/Enum.aidl",
2723 "package p;"
2724 "enum Enum {"
2725 " FOO = 1,"
2726 "}");
2727 io_delegate_.SetFileContents("new/p/Enum.aidl",
2728 "package p;"
2729 "enum Enum {"
2730 " FOO = 1,"
2731 " BAR = 2,"
2732 "}");
2733 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2734}
2735
2736TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2737 io_delegate_.SetFileContents("old/p/Enum.aidl",
2738 "package p;"
2739 "enum Enum {"
2740 " FOO = 1,"
2741 " BAR = 2,"
2742 "}");
2743 io_delegate_.SetFileContents("new/p/Enum.aidl",
2744 "package p;"
2745 "enum Enum {"
2746 " BAR = 2,"
2747 " FOO = 1,"
2748 "}");
2749 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2750}
2751
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002752TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2753 io_delegate_.SetFileContents("old/p/Union.aidl",
2754 "package p;"
2755 "union Union {"
2756 " String foo;"
2757 "}");
2758 io_delegate_.SetFileContents("new/p/Union.aidl",
2759 "package p;"
2760 "union Union {"
2761 " String foo;"
2762 " int num;"
2763 "}");
2764 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2765}
2766
Daniel Norman85aed542019-08-21 12:01:14 -07002767TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002768 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2769 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002770 "interface IFoo {"
2771 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002772 "}");
2773 io_delegate_.SetFileContents("old/p/Data.aidl",
2774 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002775 "parcelable Data {"
2776 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002777 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002778 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2779 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002780 "interface IFoo {"
2781 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002782 "}");
2783 io_delegate_.SetFileContents("new/p/Data.aidl",
2784 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002785 "parcelable Data {"
2786 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002787 "}");
2788 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2789 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002790 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002791 " void foo(int a);"
2792 "}");
2793 io_delegate_.SetFileContents("new/q/Data.aidl",
2794 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002795 "parcelable Data {"
2796 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002797 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002798 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2799}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002800
Daniel Norman85aed542019-08-21 12:01:14 -07002801TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2802 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2803 "package p;"
2804 "interface IFoo {"
2805 " void foo(int a);"
2806 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002807 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2808 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002809 "interface IFoo {"
2810 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002811 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002812 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2813}
Jiyong Parke59c3682018-09-11 23:10:25 +09002814
Daniel Norman85aed542019-08-21 12:01:14 -07002815TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002816 io_delegate_.SetFileContents("old/p/I.aidl",
2817 "package p; interface I {"
2818 "const int A = 1; }");
2819 io_delegate_.SetFileContents("new/p/I.aidl",
2820 "package p ; interface I {"
2821 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002822 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2823}
Jiyong Parka428d212018-08-29 22:26:30 +09002824
Daniel Norman85aed542019-08-21 12:01:14 -07002825TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002826 io_delegate_.SetFileContents("old/p/I.aidl",
2827 "package p; interface I {"
2828 "const int A = 1; const int B = 2;}");
2829 io_delegate_.SetFileContents("new/p/I.aidl",
2830 "package p ; interface I {"
2831 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002832 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002833}
2834
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002835TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2836 io_delegate_.SetFileContents("old/p/Foo.aidl",
2837 "package p;"
2838 "@JavaPassthrough(annotation=\"Alice\")"
2839 "@JavaPassthrough(annotation=\"Bob\")"
2840 "parcelable Foo {}");
2841 io_delegate_.SetFileContents("new/p/Foo.aidl",
2842 "package p;"
2843 "@JavaPassthrough(annotation=\"Bob\")"
2844 "@JavaPassthrough(annotation=\"Alice\")"
2845 "parcelable Foo {}");
2846 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2847}
2848
Jooyung Han00073272020-11-27 14:20:20 +09002849TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2850 io_delegate_.SetFileContents("old/p/Foo.aidl",
2851 "package p;"
2852 "parcelable Foo {}");
2853 io_delegate_.SetFileContents("new/p/Foo.aidl",
2854 "package p;"
2855 "@JavaPassthrough(annotation=\"@Deprecated\")"
2856 "parcelable Foo {}");
2857 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2858}
2859
Jooyung Han636fd2f2020-10-22 11:33:45 +09002860TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2861 io_delegate_.SetFileContents("old/p/Data.aidl",
2862 "package p;"
2863 "parcelable Data {"
2864 " int num;"
2865 "}");
2866 io_delegate_.SetFileContents(
2867 "new/p/Data.aidl",
2868 "package p;"
2869 "parcelable Data {"
2870 " int num;"
2871 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2872 "}");
2873 io_delegate_.SetFileContents("new/p/Enum.aidl",
2874 "package p;"
2875 "enum Enum {"
2876 " FOO = 0,"
2877 " BAR = 1,"
2878 "}");
2879 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2880}
2881
Jooyung Han308bbe02021-04-27 12:09:59 +09002882TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2883 io_delegate_.SetFileContents("old/p/Data.aidl",
2884 "package p;\n"
2885 "parcelable Data {\n"
2886 " p.Enum e;\n"
2887 "}");
2888 io_delegate_.SetFileContents("old/p/Enum.aidl",
2889 "package p;\n"
2890 "enum Enum {\n"
2891 " FOO = 0,\n"
2892 " BAR = 1,\n"
2893 "}");
2894 io_delegate_.SetFileContents("new/p/Data.aidl",
2895 "package p;\n"
2896 "parcelable Data {\n"
2897 " p.Enum e = p.Enum.FOO;\n"
2898 "}");
2899 io_delegate_.SetFileContents("new/p/Enum.aidl",
2900 "package p;\n"
2901 "enum Enum {\n"
2902 " FOO = 0,\n"
2903 " BAR = 1,\n"
2904 "}");
2905 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2906}
2907
Daniel Norman85aed542019-08-21 12:01:14 -07002908class AidlTestIncompatibleChanges : public AidlTest {
2909 protected:
2910 Options options_ = Options::From("aidl --checkapi old new");
2911};
2912
2913TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002914 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002915 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2916 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002917 "interface IFoo {"
2918 " void foo(in String[] str);"
2919 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002920 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002921 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002922 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002923 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002924}
2925
2926TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002927 const string expected_stderr =
2928 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002929 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2930 "package p;"
2931 "interface IFoo {"
2932 " void foo(in String[] str);"
2933 " void bar(@utf8InCpp String str);"
2934 "}");
2935 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2936 "package p;"
2937 "interface IFoo {"
2938 " void foo(in String[] str);"
2939 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002941 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002942 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002943}
2944
Jiyong Parkf8d53612020-05-04 14:06:13 +09002945TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2946 const string expected_stderr =
2947 "ERROR: new/p/IFoo.aidl:1.61-65: "
2948 "Encountered an untyped List or Map. The use of untyped List/Map is "
2949 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2950 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2951 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2952 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2953 "package p;"
2954 "interface IFoo {"
2955 " void foo(in String[] str);"
2956 "}");
2957 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2958 "package p;"
2959 "interface IFoo {"
2960 " void foo(in String[] str);"
2961 " void bar(in List arg);"
2962 "}");
2963 CaptureStderr();
2964 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2965 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2966}
2967
2968TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2969 const string expected_stderr =
2970 "ERROR: new/p/Data.aidl:1.54-59: "
2971 "Encountered an untyped List or Map. The use of untyped List/Map is "
2972 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2973 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2974 "ERROR: new/p/Data.aidl: Failed to read.\n";
2975 io_delegate_.SetFileContents("old/p/Data.aidl",
2976 "package p;"
2977 "parcelable Data {"
2978 " int foo;"
2979 "}");
2980 io_delegate_.SetFileContents("new/p/Data.aidl",
2981 "package p;"
2982 "parcelable Data {"
2983 " int foo;"
2984 " @nullable List list;"
2985 "}");
2986 CaptureStderr();
2987 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2988 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2989}
2990
Daniel Norman85aed542019-08-21 12:01:14 -07002991TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002992 const string expected_stderr =
2993 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002994 io_delegate_.SetFileContents("old/p/Data.aidl",
2995 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002996 "parcelable Data {"
2997 " int foo;"
2998 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002999 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003000 io_delegate_.SetFileContents("new/p/Data.aidl",
3001 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003002 "parcelable Data {"
3003 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003004 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003005 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003006 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003007 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003008}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003009
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003010TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
3011 const string expected_stderr =
3012 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
3013 "backends. Please either provide a default value for this field or mark the field as "
3014 "@nullable. This value or a null value will be used automatically when an old version of "
3015 "this parcelable is sent to a process which understands a new version of this parcelable. In "
3016 "order to make sure your code continues to be backwards compatible, make sure the default or "
3017 "null value does not cause a semantic change to this parcelable.\n";
3018 io_delegate_.SetFileContents("old/p/Data.aidl",
3019 "package p;"
3020 "parcelable Data {"
3021 " int num;"
3022 "}");
3023 io_delegate_.SetFileContents("new/p/Data.aidl",
3024 "package p;"
3025 "parcelable Data {"
3026 " int num;"
3027 " String str;"
3028 "}");
3029 CaptureStderr();
3030 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3031 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3032}
3033
Jooyung Han636fd2f2020-10-22 11:33:45 +09003034TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
3035 const string expected_stderr =
3036 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
3037 "Please make sure 'Enum' has '0' as a valid value.\n";
3038 io_delegate_.SetFileContents("old/p/Data.aidl",
3039 "package p;"
3040 "parcelable Data {"
3041 " int num;"
3042 "}");
3043 io_delegate_.SetFileContents("new/p/Data.aidl",
3044 "package p;"
3045 "parcelable Data {"
3046 " int num;"
3047 " p.Enum e;"
3048 "}");
3049 io_delegate_.SetFileContents("new/p/Enum.aidl",
3050 "package p;"
3051 "enum Enum {"
3052 " FOO = 1,"
3053 " BAR = 2,"
3054 "}");
3055 CaptureStderr();
3056 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3057 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3058}
3059
Daniel Norman85aed542019-08-21 12:01:14 -07003060TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003061 const string expected_stderr =
3062 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003063 io_delegate_.SetFileContents("old/p/Enum.aidl",
3064 "package p;"
3065 "enum Enum {"
3066 " FOO = 1,"
3067 " BAR = 2,"
3068 "}");
3069 io_delegate_.SetFileContents("new/p/Enum.aidl",
3070 "package p;"
3071 "enum Enum {"
3072 " BAR = 2,"
3073 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003074 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003075 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003077}
3078
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003079TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3080 const string expected_stderr =
3081 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3082 io_delegate_.SetFileContents("old/p/Union.aidl",
3083 "package p;"
3084 "union Union {"
3085 " String str;"
3086 " int num;"
3087 "}");
3088 io_delegate_.SetFileContents("new/p/Union.aidl",
3089 "package p;"
3090 "union Union {"
3091 " String str;"
3092 "}");
3093 CaptureStderr();
3094 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3095 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3096}
3097
Daniel Norman85aed542019-08-21 12:01:14 -07003098TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003099 const string expected_stderr =
3100 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003101 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3102 "package p;"
3103 "interface IFoo {"
3104 " void foo(in String[] str);"
3105 " void bar(@utf8InCpp String str);"
3106 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003107 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3108 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003109 "interface IFoo {"
3110 " void foo(in String[] str);"
3111 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003112 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003113 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003114 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003115 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003116}
3117
Daniel Norman85aed542019-08-21 12:01:14 -07003118TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003119 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003120 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3121 "package p;"
3122 "interface IFoo {"
3123 " void foo(in String[] str);"
3124 " void bar(@utf8InCpp String str);"
3125 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003126 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3127 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003128 "interface IFoo2 {"
3129 " void foo(in String[] str);"
3130 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003131 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003132 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003133 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003134 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003135}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003136
Daniel Norman85aed542019-08-21 12:01:14 -07003137TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003138 const string expected_stderr =
3139 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003140 io_delegate_.SetFileContents("old/p/Enum.aidl",
3141 "package p;"
3142 "enum Enum {"
3143 " FOO = 1,"
3144 " BAR = 2,"
3145 "}");
3146 io_delegate_.SetFileContents("new/p/Enum.aidl",
3147 "package p;"
3148 "enum Enum {"
3149 " FOO = 3,"
3150 " BAR = 2,"
3151 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003152 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003153 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003154 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003155}
3156
3157TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003158 const string expected_stderr =
3159 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3160 "from 0 to 1.\n"
3161 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3162 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003163 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3164 "package p;"
3165 "interface IFoo {"
3166 " void foo(in String[] str);"
3167 " void bar(@utf8InCpp String str);"
3168 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003169 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3170 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003171 "interface IFoo {"
3172 " void bar(@utf8InCpp String str);"
3173 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003174 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003175 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003176 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003177 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003178}
3179
3180TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003181 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003182 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3183 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003184 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003185 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003186 "parcelable Data {"
3187 " int foo;"
3188 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003189 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003190 io_delegate_.SetFileContents("new/p/Data.aidl",
3191 "package p;"
3192 "parcelable Data {"
3193 " int bar;"
3194 " int foo;"
3195 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003196 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003197 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003199}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003200
Daniel Norman85aed542019-08-21 12:01:14 -07003201TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003202 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003203 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003204 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003205 "interface IFoo {"
3206 " void foo(in String[] str);"
3207 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003208 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003209 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3210 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003211 "interface IFoo {"
3212 " void foo(out String[] str);"
3213 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003214 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003215 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003216 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003217 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003218}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003219
Daniel Norman85aed542019-08-21 12:01:14 -07003220TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003221 const string expected_stderr =
3222 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003223 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3224 "package p;"
3225 "interface IFoo {"
3226 " void foo(in String[] str);"
3227 " void bar(@utf8InCpp String str);"
3228 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003229 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3230 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003231 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003232 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003233 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003234 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003235 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003236 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003237 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003238}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003239
Daniel Norman85aed542019-08-21 12:01:14 -07003240TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003241 const string expected_stderr =
3242 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003243 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3244 "package p;"
3245 "interface IFoo {"
3246 " void foo(in String[] str);"
3247 " void bar(@utf8InCpp String str);"
3248 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003249 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3250 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003251 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003252 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003253 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003254 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003255 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003256 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003258}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003259
Jooyung Han60b2fde2020-10-29 15:12:40 +09003260TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3261 const string expected_stderr =
3262 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3263 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3264 io_delegate_.SetFileContents("old/p/Foo.aidl",
3265 "package p;"
3266 "@Backing(type=\"byte\")"
3267 "enum Foo {"
3268 " FOO, BAR,"
3269 "}");
3270 io_delegate_.SetFileContents("new/p/Foo.aidl",
3271 "package p;"
3272 "@Backing(type=\"long\")"
3273 "enum Foo {"
3274 " FOO, BAR,"
3275 "}");
3276 CaptureStderr();
3277 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3278 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3279}
3280
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003281TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3282 const string expected_stderr =
3283 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3284 "to @JavaPassthrough(annotation=\"Bob\")\n";
3285 io_delegate_.SetFileContents("old/p/Foo.aidl",
3286 "package p;"
3287 "@JavaPassthrough(annotation=\"Alice\")"
3288 "parcelable Foo {}");
3289 io_delegate_.SetFileContents("new/p/Foo.aidl",
3290 "package p;"
3291 "@JavaPassthrough(annotation=\"Bob\")"
3292 "parcelable Foo {}");
3293
3294 CaptureStderr();
3295 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3296 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3297}
3298
Devin Mooredb7ac512020-08-07 11:17:36 -07003299TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3300 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003301 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003302 io_delegate_.SetFileContents("old/p/Foo.aidl",
3303 "package p;"
3304 "parcelable Foo {"
3305 " int A;"
3306 "}");
3307 io_delegate_.SetFileContents("new/p/Foo.aidl",
3308 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003309 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003310 " int A;"
3311 "}");
3312 CaptureStderr();
3313 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3314 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3315}
3316
3317TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3318 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003319 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003320 io_delegate_.SetFileContents("old/p/Foo.aidl",
3321 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003322 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003323 " int A;"
3324 "}");
3325 io_delegate_.SetFileContents("new/p/Foo.aidl",
3326 "package p;"
3327 "parcelable Foo {"
3328 " int A;"
3329 "}");
3330 CaptureStderr();
3331 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3333}
3334
Daniel Norman85aed542019-08-21 12:01:14 -07003335TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003336 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003337 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3338 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003339 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003340 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003341 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003342 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003343}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003344
Daniel Norman85aed542019-08-21 12:01:14 -07003345TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003346 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003347 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3348 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003349 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003350 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003352}
Jiyong Parka428d212018-08-29 22:26:30 +09003353
Daniel Norman85aed542019-08-21 12:01:14 -07003354TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003355 const string expected_stderr =
3356 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003357 io_delegate_.SetFileContents("old/p/I.aidl",
3358 "package p; interface I {"
3359 "const int A = 1; const int B = 2;}");
3360 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003361 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003362 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003364}
Jiyong Parka428d212018-08-29 22:26:30 +09003365
Daniel Norman85aed542019-08-21 12:01:14 -07003366TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003367 const string expected_stderr =
3368 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003369 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3370 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003371 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003372 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003374}
3375
Devin Moorec7e47a32020-08-07 10:55:25 -07003376TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3377 const string expected_stderr =
3378 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3379 "This is an incompatible change for FixedSize types.\n";
3380 io_delegate_.SetFileContents("old/p/Foo.aidl",
3381 "package p; @FixedSize parcelable Foo { int A = 1; }");
3382 io_delegate_.SetFileContents("new/p/Foo.aidl",
3383 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3384 CaptureStderr();
3385 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3386 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3387}
3388
Jeongik Cha68d18e72021-04-29 20:07:01 +09003389TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3390 const string expected_stderr =
3391 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3392 "android.net.UidRangeParcel is changed from 1 to 2. "
3393 "But it is forbidden because of legacy support.\n";
3394 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3395 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3396 io_delegate_.SetFileContents(
3397 "new/android/net/UidRangeParcel.aidl",
3398 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3399 CaptureStderr();
3400 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3401 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3402}
3403
Devin Moorec7e47a32020-08-07 10:55:25 -07003404TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3405 const string expected_stderr =
3406 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3407 io_delegate_.SetFileContents("old/p/Foo.aidl",
3408 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3409 io_delegate_.SetFileContents("new/p/Foo.aidl",
3410 "package p; @FixedSize parcelable Foo { int A = 1; }");
3411 CaptureStderr();
3412 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3414}
3415
3416TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3417 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003418 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003419 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003420 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3421 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003422 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003423 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003424 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003425 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003426 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003427 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3428 "f.\n"
3429 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3430 "nullable1.\n"
3431 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3432 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003433
3434 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003435 "@FixedSize parcelable Foo {\n"
3436 " int[] a;\n"
3437 " Bar b;\n"
3438 " String c;\n"
3439 " ParcelFileDescriptor d;\n"
3440 " IBinder e;\n"
3441 " List<String> f;\n"
3442 " int isFixedSize;\n"
3443 " @nullable OtherFixed nullable1;\n"
3444 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003445 "}");
3446 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003447 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003448 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003449
3450 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003451 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003452 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3453}
3454
3455TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3456 const string expected_stderr = "";
3457
3458 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3459 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3460 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003461 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003462
3463 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003464 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3466}
3467
Jiyong Park8c380532018-08-30 14:55:26 +09003468TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003469 const string expected_stderr =
3470 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3471 "dir1/q/IBar.aidl\n"
3472 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003473 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003474 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3475 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3476 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3477 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3478
Devin Moore097a3ab2020-03-11 16:08:44 -07003479 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003480 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003481 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003482}
3483
Jiyong Parked65bf42018-08-28 15:43:27 +09003484TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003485 const string expected_stderr =
3486 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3487 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003488 Options options = Options::From("aidl --checkapi old new");
3489 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3490 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003491
3492 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3493
Jiyong Parke59c3682018-09-11 23:10:25 +09003494 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003495 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003496 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003497 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003498}
3499
Jooyung Han652ce482021-02-26 12:40:35 +09003500TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3501 Options options =
3502 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003503
3504 // use without import
3505 io_delegate_.SetFileContents("p/IFoo.aidl",
3506 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003507 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003508
3509 // capture output files
3510 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003511
Devin Moore7b8d5c92020-03-17 14:14:08 -07003512 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003513 io_delegate_.SetFileContents(
3514 "p/IFoo.aidl",
3515 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003516 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003517 // output files should be the same
3518 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003519
3520 // use with import (as before)
3521 io_delegate_.SetFileContents("p/IFoo.aidl",
3522 "package p;"
3523 "import android.os.ParcelFileDescriptor;"
3524 "interface IFoo{"
3525 " void foo(in ParcelFileDescriptor fd);"
3526 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003527 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003528 // output files should be the same
3529 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003530}
Jiyong Parked65bf42018-08-28 15:43:27 +09003531
Jooyung Han020d8d12021-02-26 17:23:02 +09003532TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3533 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3534 CaptureStderr();
3535 io_delegate_.SetFileContents("p/IFoo.aidl",
3536 "package p;"
3537 "interface IFoo{"
3538 " void foo(out ParcelFileDescriptor fd);"
3539 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003540 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003541 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3542}
3543
3544TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3545 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3546 CaptureStderr();
3547 io_delegate_.SetFileContents("p/IFoo.aidl",
3548 "package p;"
3549 "interface IFoo{"
3550 " void foo(ParcelFileDescriptor fd);"
3551 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003552 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003553 EXPECT_THAT(GetCapturedStderr(),
3554 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3555}
3556
Jiyong Park3633b722019-04-11 15:38:26 +09003557TEST_F(AidlTest, ManualIds) {
3558 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3559 io_delegate_.SetFileContents("IFoo.aidl",
3560 "interface IFoo {\n"
3561 " void foo() = 0;\n"
3562 " void bar() = 1;\n"
3563 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003564 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003565}
3566
3567TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3568 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3569 io_delegate_.SetFileContents("IFoo.aidl",
3570 "interface IFoo {\n"
3571 " void foo() = 0;\n"
3572 " void bar() = 1;\n"
3573 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003574 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003575}
3576
3577TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003578 const string expected_stderr =
3579 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003580 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3581 io_delegate_.SetFileContents("IFoo.aidl",
3582 "interface IFoo {\n"
3583 " void foo() = 3;\n"
3584 " void bar() = 3;\n"
3585 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003586 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003587 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003588 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003589}
3590
3591TEST_F(AidlTest, FailOnOutOfRangeIds) {
3592 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003593 const string expected_stderr =
3594 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3595 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003596 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3597 io_delegate_.SetFileContents("IFoo.aidl",
3598 "interface IFoo {\n"
3599 " void foo() = 3;\n"
3600 " void bar() = 16777115;\n"
3601 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003602 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003603 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003604 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003605}
3606
3607TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003608 const string expected_stderr =
3609 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003610 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3611 io_delegate_.SetFileContents("IFoo.aidl",
3612 "interface IFoo {\n"
3613 " void foo() = 3;\n"
3614 " void bar();\n"
3615 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003616 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003617 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003618 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003619}
3620
Jiyong Parkc6816252019-07-08 08:12:28 +09003621TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3622 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3623 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3624 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003625 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003626}
3627
3628TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003629 const string expected_stderr =
3630 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3631 "dir/IBar.aidl\n"
3632 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003633 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003634
Jiyong Parkc6816252019-07-08 08:12:28 +09003635 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3636 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3637 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3638 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003639 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003640 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003641 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003642}
3643
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003644TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3645 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3646 "package a.b;\n"
3647 "import a.b.IBar;\n"
3648 "import a.b.IQux;\n"
3649 "interface IFoo { IQux foo(); }\n");
3650 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3651 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3652
3653 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003654 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003655
3656 string output;
3657 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3658 // IBar was imported but wasn't used. include is not expected.
3659 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3660 // IBar was imported and used. include is expected.
3661 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3662}
3663
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003664TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003665 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003666 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003667 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3668 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003669 interface IFoo {
3670 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003671 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003672 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003673 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003674 // JavaPassthrough should work with other types as well (e.g. enum)
3675 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3676 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3677 @JavaPassthrough(annotation="@com.android.AliceTwo")
3678 @Backing(type="byte")
3679 enum MyEnum {
3680 a, b, c
3681 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003682
Jooyung Han4cde01d2020-10-13 11:10:47 +09003683 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003684 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003685
3686 string java_out;
3687 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003688 // type-decl-level annotations with newline at the end
3689 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3690 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3691 // member-decl-level annotations with newline at the end
3692 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3693 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3694 // inline annotations with space at the end
3695 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003696
Jooyung Han4cde01d2020-10-13 11:10:47 +09003697 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3698 // type-decl-level annotations with newline at the end
3699 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3700 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3701
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003702 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003703 Options cpp_options =
3704 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003705 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003706
Jooyung Han4cde01d2020-10-13 11:10:47 +09003707 Options ndk_options =
3708 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003709 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003710
Jooyung Han4cde01d2020-10-13 11:10:47 +09003711 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003712 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003713}
3714
Andrei Homescue61feb52020-08-18 15:44:24 -07003715TEST_F(AidlTest, ParseRustDerive) {
3716 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3717 @RustDerive(Clone=true, Copy=false)
3718 parcelable Foo {
3719 int a;
3720 })");
3721
3722 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003723 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003724
3725 string rust_out;
3726 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3727 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3728
3729 // Other backends shouldn't be bothered
3730 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003731 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003732
3733 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003734 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003735
3736 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003737 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003738}
3739
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003740TEST_F(AidlTest, EmptyEnforceAnnotation) {
3741 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3742 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3743 interface IFoo {
3744 @Enforce()
3745 void Protected();
3746 })");
3747
3748 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3749 CaptureStderr();
3750 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3752}
3753
3754TEST_F(AidlTest, EmptyEnforceCondition) {
3755 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3756 interface IFoo {
3757 @Enforce(condition="")
3758 void Protected();
3759 })");
3760
3761 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3762 CaptureStderr();
3763 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3764 EXPECT_THAT(GetCapturedStderr(),
3765 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3766}
3767
3768TEST_F(AidlTest, InvalidEnforceCondition) {
3769 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3770 interface IFoo {
3771 @Enforce(condition="invalid")
3772 void Protected();
3773 })");
3774
3775 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3776 CaptureStderr();
3777 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3778 EXPECT_THAT(GetCapturedStderr(),
3779 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3780}
3781
Thiébaud Weksteen133da842021-10-29 16:49:58 +11003782TEST_F(AidlTest, InterfaceEnforceCondition) {
3783 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3784 @Enforce(condition="permission = INTERNET")
3785 interface IFoo {
3786 void Protected();
3787 })");
3788
3789 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3790 EXPECT_TRUE(compile_aidl(options, io_delegate_));
3791}
3792
3793TEST_F(AidlTest, InterfaceAndMethodEnforceCondition) {
3794 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3795 @Enforce(condition="permission = INTERNET")
3796 interface IFoo {
3797 @Enforce(condition="uid = SYSTEM_UID")
3798 void Protected();
3799 })");
3800
3801 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3802 EXPECT_TRUE(compile_aidl(options, io_delegate_));
3803}
3804
Jiyong Park56f73d72019-06-11 12:20:28 +09003805class AidlOutputPathTest : public AidlTest {
3806 protected:
3807 void SetUp() override {
3808 AidlTest::SetUp();
3809 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3810 }
3811
3812 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003813 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003814 // check the existence
3815 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3816 }
3817};
3818
3819TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3820 // <out_dir> / <package_name> / <type_name>.java
3821 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3822}
3823
3824TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3825 // when output file is explicitly set, it is always respected. -o option is
3826 // ignored.
3827 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3828}
3829
3830TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3831 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3832}
3833
3834TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3835 // output is the same as the input file except for the suffix
3836 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3837}
3838
Devin Moore7b8d5c92020-03-17 14:14:08 -07003839TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003840 AidlError error;
3841 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003842 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int (2147483650)\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003843 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003844 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3845 R"(package p;
3846 interface IFoo {
3847 const int int32_max_oob = 2147483650;
3848 }
3849 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003850 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003851 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3852 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003853}
3854
Devin Moore7b8d5c92020-03-17 14:14:08 -07003855TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003856 AidlError error;
3857 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003858 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int "
3859 "(-2147483650)\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003860 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003861 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3862 R"(package p;
3863 interface IFoo {
3864 const int int32_min_oob = -2147483650;
3865 }
3866 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003867 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3869 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003870}
3871
Devin Moore7b8d5c92020-03-17 14:14:08 -07003872TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003873 AidlError error;
3874 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003875 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003876 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003877 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3878 R"(package p;
3879 interface IFoo {
3880 const long int64_max_oob = 21474836509999999999999999;
3881 }
3882 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003883 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003884 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3885 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003886}
3887
Devin Moore7b8d5c92020-03-17 14:14:08 -07003888TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003889 AidlError error;
3890 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003891 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003892 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003893 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3894 R"(package p;
3895 interface IFoo {
3896 const long int64_min_oob = -21474836509999999999999999;
3897 }
3898 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003899 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003900 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3901 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003902}
3903
Devin Moore7b8d5c92020-03-17 14:14:08 -07003904TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003905 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003906 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003907 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte (FOO+1)\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003908 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3909 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003910 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3911 R"(package p;
3912 @Backing(type="byte")
3913 enum TestEnum {
3914 FOO = 127,
3915 BAR,
3916 }
3917 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003918 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003919 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003920 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003921}
3922
Steven Morelandb248d072021-09-29 19:07:17 -07003923TEST_P(AidlTest, FailOnUnsupportedBackingType) {
3924 AidlError error;
3925 const string expected_stderr =
3926 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
3927 "byte, int, long\n";
3928 CaptureStderr();
3929 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3930 R"(package p;
3931 @Backing(type="boolean")
3932 enum TestEnum {
3933 FOO = 0,
3934 BAR = 1,
3935 }
3936 )",
3937 typenames_, GetLanguage(), &error));
3938 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3939 EXPECT_EQ(AidlError::BAD_TYPE, error);
3940}
3941
Devin Mooredecaf292020-04-30 09:16:40 -07003942TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3943 AidlError error;
3944 const string expected_stderr =
3945 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07003946 "be one of: type\n";
3947 CaptureStderr();
3948 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3949 R"(package p;
3950 @Backing(foo="byte")
3951 enum TestEnum {
3952 FOO = 1,
3953 BAR,
3954 }
3955 )",
3956 typenames_, GetLanguage(), &error));
3957 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3958 EXPECT_EQ(AidlError::BAD_TYPE, error);
3959}
3960
Jooyung Han5721a232020-12-24 04:34:55 +09003961TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
3962 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
3963 CaptureStderr();
3964 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
3965 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3966}
3967
Jooyung Han66813932020-10-23 13:24:44 +09003968TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003969 io_delegate_.SetFileContents("Foo.aidl",
3970 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3971 "Map<String, Baz> d; Bar[] e; }");
3972 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3973 io_delegate_.SetFileContents("Baz.aidl",
3974 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003975 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003976 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09003977}
3978
Jooyung Han66813932020-10-23 13:24:44 +09003979TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003980 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003981 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003982 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003983 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3984 "named 'bar'.\n";
3985 CaptureStderr();
3986 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003987 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09003988 EXPECT_EQ(expected_error, GetCapturedStderr());
3989}
3990
Jooyung Han09e551c2021-05-11 11:44:48 +09003991TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
3992 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
3993 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
3994 CaptureStderr();
3995 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07003996 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09003997 EXPECT_EQ("", GetCapturedStderr());
3998}
3999
Jooyung Han59af9cc2020-10-25 21:44:14 +09004000TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
4001 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
4002 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
4003 string expected_error =
4004 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09004005 "named 'bar'.\n";
4006 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004007 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004008 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09004009 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004010}
4011
Jooyung Han66813932020-10-23 13:24:44 +09004012TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004013 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004014 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
4015 string expected_error =
4016 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
4017 "only be an in parameter.\n";
4018 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004019 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004020 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004021 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004022}
4023
Jooyung Han66813932020-10-23 13:24:44 +09004024TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004025 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004026 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
4027 string expected_error =
4028 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
4029 "only be an in parameter.\n";
4030 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004031 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004032 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004033 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004034}
4035
Jooyung Han66813932020-10-23 13:24:44 +09004036TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004037 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09004038 Options options = Options::From("aidl --lang=java Foo.aidl");
4039 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09004040 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
4041 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09004042 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004043 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09004044 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4045}
Devin Moore53fc99c2020-08-12 08:07:52 -07004046
Jooyung Hanfe086af2021-01-16 03:44:47 +09004047TEST_P(AidlTest, UnionInUnion) {
4048 import_paths_.insert(".");
4049 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
4050 CaptureStderr();
4051 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
4052 EXPECT_THAT("", GetCapturedStderr());
4053}
4054
Jooyung Hanfe89f122020-10-14 03:49:18 +09004055TEST_P(AidlTest, UnionRejectsEmptyDecl) {
4056 const string method = "package a; union Foo {}";
4057 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
4058 CaptureStderr();
4059 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4060 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4061}
4062
4063TEST_P(AidlTest, UnionRejectsParcelableHolder) {
4064 const string method = "package a; union Foo { ParcelableHolder x; }";
4065 const string expected_stderr =
4066 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
4067 CaptureStderr();
4068 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4069 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4070}
4071
Jooyung Han53fb4242020-12-17 16:03:49 +09004072TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
4073 import_paths_.insert(".");
4074 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
4075 const string expected_err = "The union's first member should have a useful default value.";
4076 CaptureStderr();
4077 EXPECT_EQ(nullptr,
4078 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
4079 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
4080}
4081
Devin Moore53fc99c2020-08-12 08:07:52 -07004082TEST_P(AidlTest, GenericStructuredParcelable) {
4083 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004084 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004085 const string expected_stderr = "";
4086 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004087 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004088 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4089}
4090
Jooyung Han3f347ca2020-12-01 12:41:50 +09004091TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4092 io_delegate_.SetFileContents("Foo.aidl",
4093 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4094 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004095 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004096 const string expected_stderr = "";
4097 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004098 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004099 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4100
4101 string code;
4102 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4103 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4104const ::android::String16& Foo<T,U>::s() {
4105 static const ::android::String16 value(::android::String16(""));
4106 return value;
4107})--"));
4108}
4109
4110TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4111 io_delegate_.SetFileContents("Foo.aidl",
4112 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4113 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004114 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004115 const string expected_stderr = "";
4116 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004117 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4119
4120 string code;
4121 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4122 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4123const char* Foo<T, U>::s = "";
4124)--"));
4125}
4126
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004127TEST_F(AidlTest, NestedTypeArgs) {
4128 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004129 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4130
4131 io_delegate_.SetFileContents("a/Foo.aidl",
4132 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4133 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004134 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4135 const string expected_stderr = "";
4136 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004137 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004138 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4139
4140 string code;
4141 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004142 EXPECT_THAT(code,
4143 testing::HasSubstr(
4144 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4145}
4146
4147TEST_F(AidlTest, DoubleArrayError) {
4148 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4149
4150 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4151 const string expected_stderr =
4152 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4153 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004154 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004155 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4156}
4157
4158TEST_F(AidlTest, DoubleGenericError) {
4159 io_delegate_.SetFileContents("a/Bar.aidl",
4160 "package a; parcelable Bar { List<String><String> a; }");
4161
4162 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4163 const string expected_stderr =
4164 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4165 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004166 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004167 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4168}
4169
4170TEST_F(AidlTest, ArrayBeforeGenericError) {
4171 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4172
4173 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004174 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004175 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004176 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4177}
4178
4179TEST_F(AidlTest, NullableArraysAreNotSupported) {
4180 io_delegate_.SetFileContents("a/Bar.aidl",
4181 "package a; parcelable Bar { String @nullable [] a; }");
4182
4183 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4184 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004185 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004186 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4187}
4188
4189TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4190 io_delegate_.SetFileContents("a/Bar.aidl",
4191 "package a; parcelable Bar { List<@nullable String> a; }");
4192
4193 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4194 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004195 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004196 EXPECT_THAT(GetCapturedStderr(),
4197 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004198}
4199
Jooyung Han14004ed2020-10-16 03:49:57 +09004200struct GenericAidlTest : ::testing::Test {
4201 FakeIoDelegate io_delegate_;
4202 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004203 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004204 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4205 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4206 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4207
4208 Options options = Options::From(cmd);
4209 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004210 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004211 EXPECT_EQ("", GetCapturedStderr());
4212 }
4213};
4214
4215TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4216 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4217 string code;
4218 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4219 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4220 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4221 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4222}
4223
4224TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4225 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4226 string code;
4227 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4228 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4229 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4230 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4231}
4232
Devin Moore53fc99c2020-08-12 08:07:52 -07004233TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4234 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004235 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004236 const string expected_stderr =
4237 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4238 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004239 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4241}
4242
4243TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4244 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004245 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004246 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4247 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004248 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4250}
4251
Jooyung Han7a308842020-10-27 19:06:49 +09004252TEST_P(AidlTest, LongCommentWithinConstExpression) {
4253 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004254 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004255 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004256 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004257 EXPECT_EQ("", GetCapturedStderr());
4258}
4259
Jeongik Chaef44e622020-10-23 16:00:52 +09004260TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4261 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4262 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4263 std::string expectedErr =
4264 "ERROR: a/Foo.aidl:1.28-30: "
4265 "Encountered an untyped List or Map. The use of untyped List/Map is "
4266 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4267 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4268 "ERROR: a/Foo.aidl:1.35-37: "
4269 "Encountered an untyped List or Map. The use of untyped List/Map is "
4270 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4271 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4272 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004273 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004274 EXPECT_EQ(expectedErr, GetCapturedStderr());
4275}
4276
4277TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004278 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4279 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004280 std::string expectedErr =
4281 "ERROR: a/Foo.aidl:1.33-35: "
4282 "Encountered an untyped List or Map. The use of untyped List/Map is "
4283 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4284 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4285 "ERROR: a/Foo.aidl:1.40-42: "
4286 "Encountered an untyped List or Map. The use of untyped List/Map is "
4287 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4288 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004289 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004290 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004291 EXPECT_EQ(expectedErr, GetCapturedStderr());
4292}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004293
Jeongik Chaef44e622020-10-23 16:00:52 +09004294TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4295 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4296 io_delegate_.SetFileContents(
4297 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4298 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4299 std::string expectedErr =
4300 "ERROR: a/Foo.aidl:1.52-54: "
4301 "Encountered an untyped List or Map. The use of untyped List/Map is "
4302 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4303 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4304 "ERROR: a/Foo.aidl:1.64-66: "
4305 "Encountered an untyped List or Map. The use of untyped List/Map is "
4306 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4307 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4308 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004309 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004310 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004311}
4312
Jooyung Han690f5842020-12-04 13:02:04 +09004313TEST_F(AidlTest, EnumWithDefaults_Java) {
4314 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4315 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4316package p;
4317import p.Enum;
4318parcelable Foo {
4319 Enum e = Enum.BAR;
4320})");
4321 CaptureStderr();
4322 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004323 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004324 auto err = GetCapturedStderr();
4325 EXPECT_EQ("", err);
4326
4327 string code;
4328 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004329 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004330}
4331
4332TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4333 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4334 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4335package p;
4336import p.Enum;
4337parcelable Foo {
4338 Enum e = Enum.BAR;
4339})");
4340 CaptureStderr();
4341 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004342 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004343 auto err = GetCapturedStderr();
4344 EXPECT_EQ("", err);
4345
4346 string code;
4347 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4348 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4349}
4350
4351TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4352 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4353 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4354package p;
4355import p.Enum;
4356parcelable Foo {
4357 Enum e = Enum.BAR;
4358})");
4359 CaptureStderr();
4360 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004361 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004362 auto err = GetCapturedStderr();
4363 EXPECT_EQ("", err);
4364
4365 string code;
4366 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4367 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4368}
4369
4370TEST_F(AidlTest, EnumWithDefaults_Rust) {
4371 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4372 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4373package p;
4374import p.Enum;
4375parcelable Foo {
4376 int n = 42;
4377 Enum e = Enum.BAR;
4378})");
4379 CaptureStderr();
4380 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004381 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004382 auto err = GetCapturedStderr();
4383 EXPECT_EQ("", err);
4384
4385 string code;
4386 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4387 EXPECT_THAT(code, testing::HasSubstr(R"(
4388 fn default() -> Self {
4389 Self {
4390 n: 42,
4391 e: crate::mangled::_1_p_4_Enum::BAR,
4392 }
4393 })"));
4394}
4395
4396TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4397 import_paths_.insert("a");
4398 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4399 CaptureStderr();
4400 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4401package p;
4402import p.Enum;
4403parcelable Foo {
4404 int e = Enum.FOO | Enum.BAR;
4405})",
4406 typenames_, GetLanguage());
4407 auto err = GetCapturedStderr();
4408 EXPECT_EQ("", err);
4409 EXPECT_TRUE(type);
4410 const auto& fields = type->AsStructuredParcelable()->GetFields();
4411 EXPECT_EQ("int e = 3", fields[0]->ToString());
4412}
4413
4414TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4415 CaptureStderr();
4416 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4417@Backing(type="int")
4418enum Foo {
4419 STANDARD_SHIFT = 16,
4420 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4421 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4422}
4423)",
4424 typenames_, GetLanguage());
4425 auto err = GetCapturedStderr();
4426 EXPECT_EQ("", err);
4427 EXPECT_TRUE(type);
4428 const auto& enum_type = type->AsEnumDeclaration();
4429 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004430 auto writer = CodeWriter::ForString(&code);
4431 DumpVisitor visitor(*writer);
4432 visitor.Visit(*enum_type);
4433 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004434 EXPECT_EQ(R"--(@Backing(type="int")
4435enum Foo {
4436 STANDARD_SHIFT = 16,
4437 STANDARD_BT709 = 65536,
4438 STANDARD_BT601_625 = 131072,
4439}
4440)--",
4441 code);
4442}
4443
4444TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4445 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4446 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4447package p;
4448import p.Enum;
4449parcelable Foo {
4450 Enum e = Enum.FOO | Enum.BAR;
4451})");
4452 CaptureStderr();
4453 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004454 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004455 auto err = GetCapturedStderr();
4456 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4457 err);
4458}
4459
Jooyung Han361cd102021-05-24 11:30:10 +09004460TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4461 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4462 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4463package p;
4464import p.Enum;
4465parcelable Foo {
4466 Enum e = 1;
4467})");
4468 CaptureStderr();
4469 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004470 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004471 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4472}
4473
Jooyung Han690f5842020-12-04 13:02:04 +09004474TEST_P(AidlTest, DefaultWithEmptyArray) {
4475 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4476 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4477 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004478 auto options =
4479 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004480 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004481 auto err = GetCapturedStderr();
4482 EXPECT_EQ("", err);
4483}
4484
4485TEST_P(AidlTest, RejectRefsInAnnotation) {
4486 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4487 "package p; interface IFoo {\n"
4488 " const String ANNOTATION = \"@Annotation\";\n"
4489 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4490 "}");
4491 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004492 auto options =
4493 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004494 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004495 auto err = GetCapturedStderr();
4496 EXPECT_EQ(
4497 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4498 "ANNOTATION.\n",
4499 err);
4500}
4501
4502TEST_F(AidlTest, DefaultWithEnumValues) {
4503 io_delegate_.SetFileContents(
4504 "a/p/Foo.aidl",
4505 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4506 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4507 CaptureStderr();
4508 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004509 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004510 auto err = GetCapturedStderr();
4511 EXPECT_EQ("", err);
4512 string code;
4513 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4514 EXPECT_THAT(
4515 code, testing::HasSubstr(
4516 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4517}
4518
Jooyung Han14259392020-12-07 10:00:08 +09004519TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4520 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4521 CaptureStderr();
4522 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004523 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004524 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004525 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004526}
4527
4528TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4529 io_delegate_.SetFileContents("a/p/Foo.aidl",
4530 "package p; parcelable Foo { const int A = A + 1; }");
4531 CaptureStderr();
4532 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004533 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004534 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004535 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4536}
4537
4538TEST_F(AidlTest, RecursiveReferences) {
4539 io_delegate_.SetFileContents("a/p/Foo.aidl",
4540 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4541 io_delegate_.SetFileContents("a/p/Bar.aidl",
4542 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4543 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4544 CaptureStderr();
4545 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004546 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004547 EXPECT_EQ("", GetCapturedStderr());
4548}
4549
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004550TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4551 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4552 auto options =
4553 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4554 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4555 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004556 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004557 EXPECT_EQ(err, GetCapturedStderr());
4558}
4559
4560TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4561 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4562 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4563 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4564 auto options =
4565 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4566 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004567 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004568 EXPECT_EQ("", GetCapturedStderr());
4569}
4570
Jooyung Hane9f5b272021-01-07 00:18:11 +09004571TEST_P(AidlTest, UnknownConstReference) {
Jooyung Hane1abd592021-10-05 10:35:02 +09004572 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { int field = UNKNOWN_REF; }");
Jooyung Hane9f5b272021-01-07 00:18:11 +09004573 auto options =
4574 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4575 const string err =
Jooyung Hane1abd592021-10-05 10:35:02 +09004576 "ERROR: Foo.aidl:1.30-42: Can't find UNKNOWN_REF in Foo\n"
4577 "ERROR: Foo.aidl:1.30-42: Unknown reference 'UNKNOWN_REF'\n";
Jooyung Hane9f5b272021-01-07 00:18:11 +09004578 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004579 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004580 EXPECT_EQ(err, GetCapturedStderr());
4581}
4582
Jooyung Han29813842020-12-08 01:28:03 +09004583TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4584 string contents = R"(
4585import android.os.IBinder;
4586import android.os.IInterface;
4587interface IFoo {}
4588 )";
4589 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004590}
4591
Jooyung Han888c5bc2020-12-22 17:28:47 +09004592TEST_P(AidlTest, WarningInterfaceName) {
4593 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004594 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004595 " -Weverything -o out -h out p/Foo.aidl");
4596 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004597 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004598 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004599 GetCapturedStderr());
4600}
4601
4602TEST_P(AidlTest, ErrorInterfaceName) {
4603 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004604 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004605 " -Weverything -Werror -o out -h out p/Foo.aidl");
4606 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004607 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004608 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004609 GetCapturedStderr());
4610}
4611
Jiyong Park9f4c3822021-04-07 20:36:45 +09004612TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4613 const std::string input_file = "base/p/q/IFoo.aidl";
4614 const std::string header_dir = "out/";
4615 const std::string output_file = "out/base/p/q/IFoo.cpp";
4616 const std::string package = "p.q"; // not base.p.q
4617 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4618
4619 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4620 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004621 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004622 EXPECT_THAT(
4623 GetCapturedStderr(),
4624 testing::StartsWith(
4625 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4626 "but is out/base/p/q/IFoo.cpp."));
4627}
4628
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004629TEST_F(AidlTest, FormatCommentsForJava) {
4630 using android::aidl::FormatCommentsForJava;
4631
4632 struct TestCase {
4633 vector<Comment> comments;
4634 string formatted;
4635 };
4636 vector<TestCase> testcases = {
4637 {{}, ""},
4638 {{{"// line comments\n"}}, "// line comments\n"},
4639 {{{"// @hide \n"}}, "// @hide \n"},
4640 // Transform the last block comment as Javadoc.
4641 {{{"/*\n"
4642 " * Hello, world!\n"
4643 " */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004644 "/** Hello, world! */\n"},
4645 {{{"/* @hide */"}}, "/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004646 {{{"/**\n"
4647 " @param foo ...\n"
4648 "*/"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004649 "/** @param foo ... */\n"},
4650 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide */\n/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004651 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004652 "/* @deprecated first */\n/** @deprecated second */\n"},
4653 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated */\n/** @param foo */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004654 // Line comments are printed as they are
Steven Morelandc29d7172021-10-12 15:25:11 -07004655 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */\n// line comments\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004656 };
4657 for (const auto& [input, formatted] : testcases) {
4658 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4659 }
4660}
4661
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004662TEST_F(AidlTest, HideIsNotForArgs) {
4663 io_delegate_.SetFileContents("IFoo.aidl",
4664 "interface IFoo {\n"
4665 " void foo(in @Hide int x);\n"
4666 "}");
4667 auto options = Options::From("aidl --lang=java IFoo.aidl");
4668 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004669 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004670 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4671}
4672
4673TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4674 io_delegate_.SetFileContents(
4675 "IFoo.aidl",
4676 "interface IFoo {\n"
4677 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4678 "}");
4679 auto options = Options::From("aidl --lang=java IFoo.aidl");
4680 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004681 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004682 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4683}
4684
Jooyung Hanfa181932021-06-12 07:56:53 +09004685TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4686 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4687 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4688 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004689 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004690 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4691}
4692
Jooyung Hanfd3be322020-12-13 09:11:06 +09004693struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004694 string kind;
4695 string literal;
4696};
4697
Jooyung Hanfd3be322020-12-13 09:11:06 +09004698const TypeParam kTypeParams[] = {
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004699 {"primitive", "int"}, {"primitiveArray", "int[]"},
4700 {"String", "String"}, {"StringArray", "String[]"},
4701 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4702 {"parcelable", "a.Foo"}, {"enum", "a.Enum"},
4703 {"union", "a.Union"}, {"interface", "a.IBar"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004704};
4705
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004706struct ExpectedResult {
4707 string expected_error;
4708 string expected_error_for_nullable;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004709};
4710
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004711const std::map<std::string, ExpectedResult> kListSupportExpectations = {
4712 {"cpp_primitive", {"A generic type cannot", "A generic type cannot"}},
4713 {"java_primitive", {"A generic type cannot", "A generic type cannot"}},
4714 {"ndk_primitive", {"A generic type cannot", "A generic type cannot"}},
4715 {"rust_primitive", {"A generic type cannot", "A generic type cannot"}},
4716 {"cpp_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4717 {"java_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4718 {"ndk_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4719 {"rust_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4720 {"cpp_String", {"", ""}},
4721 {"java_String", {"", ""}},
4722 {"ndk_String", {"", ""}},
4723 {"rust_String", {"", ""}},
4724 {"cpp_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4725 {"java_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4726 {"ndk_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4727 {"rust_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4728 {"cpp_IBinder", {"", ""}},
4729 {"java_IBinder", {"", ""}},
4730 {"ndk_IBinder", {"", ""}},
4731 {"rust_IBinder", {"", ""}},
4732 {"cpp_ParcelFileDescriptor", {"", ""}},
4733 {"java_ParcelFileDescriptor", {"", ""}},
4734 {"ndk_ParcelFileDescriptor", {"", ""}},
4735 {"rust_ParcelFileDescriptor", {"", ""}},
4736 {"cpp_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4737 {"java_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4738 {"ndk_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4739 {"rust_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4740 {"cpp_parcelable", {"", ""}},
4741 {"java_parcelable", {"", ""}},
4742 {"ndk_parcelable", {"", ""}},
4743 {"rust_parcelable", {"", ""}},
4744 {"cpp_enum", {"A generic type cannot", "A generic type cannot"}},
4745 {"java_enum", {"A generic type cannot", "A generic type cannot"}},
4746 {"ndk_enum", {"A generic type cannot", "A generic type cannot"}},
4747 {"rust_enum", {"A generic type cannot", "A generic type cannot"}},
4748 {"cpp_union", {"", ""}},
4749 {"java_union", {"", ""}},
4750 {"ndk_union", {"", ""}},
4751 {"rust_union", {"", ""}},
Jooyung Hand236e552020-12-13 09:21:27 +09004752};
4753
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004754const std::map<std::string, ExpectedResult> kArraySupportExpectations = {
4755 {"cpp_primitive", {"", ""}},
4756 {"java_primitive", {"", ""}},
4757 {"ndk_primitive", {"", ""}},
4758 {"rust_primitive", {"", ""}},
4759 {"cpp_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4760 {"java_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4761 {"ndk_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4762 {"rust_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4763 {"cpp_String", {"", ""}},
4764 {"java_String", {"", ""}},
4765 {"ndk_String", {"", ""}},
4766 {"rust_String", {"", ""}},
4767 {"cpp_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4768 {"java_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4769 {"ndk_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4770 {"rust_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4771 {"cpp_IBinder", {"", ""}},
4772 {"java_IBinder", {"", ""}},
4773 {"ndk_IBinder", {"", ""}},
4774 {"rust_IBinder", {"", ""}},
4775 {"cpp_ParcelFileDescriptor", {"", ""}},
4776 {"java_ParcelFileDescriptor", {"", ""}},
4777 {"ndk_ParcelFileDescriptor", {"", ""}},
4778 {"rust_ParcelFileDescriptor", {"", ""}},
4779 {"cpp_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4780 {"java_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4781 {"ndk_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4782 {"rust_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4783 {"cpp_parcelable", {"", ""}},
4784 {"java_parcelable", {"", ""}},
4785 {"ndk_parcelable", {"", ""}},
4786 {"rust_parcelable", {"", ""}},
4787 {"cpp_enum", {"", ""}},
4788 {"java_enum", {"", ""}},
4789 {"ndk_enum", {"", ""}},
4790 {"rust_enum", {"", ""}},
4791 {"cpp_union", {"", ""}},
4792 {"java_union", {"", ""}},
4793 {"ndk_union", {"", ""}},
4794 {"rust_union", {"", ""}},
4795};
4796
4797const std::map<std::string, ExpectedResult> kFieldSupportExpectations = {
4798 {"cpp_primitive", {"", "cannot get nullable annotation"}},
4799 {"java_primitive", {"", "cannot get nullable annotation"}},
4800 {"ndk_primitive", {"", "cannot get nullable annotation"}},
4801 {"rust_primitive", {"", "cannot get nullable annotation"}},
4802 {"cpp_primitiveArray", {"", ""}},
4803 {"java_primitiveArray", {"", ""}},
4804 {"ndk_primitiveArray", {"", ""}},
4805 {"rust_primitiveArray", {"", ""}},
4806 {"cpp_String", {"", ""}},
4807 {"java_String", {"", ""}},
4808 {"ndk_String", {"", ""}},
4809 {"rust_String", {"", ""}},
4810 {"cpp_StringArray", {"", ""}},
4811 {"java_StringArray", {"", ""}},
4812 {"ndk_StringArray", {"", ""}},
4813 {"rust_StringArray", {"", ""}},
4814 {"cpp_IBinder", {"", ""}},
4815 {"java_IBinder", {"", ""}},
4816 {"ndk_IBinder", {"", ""}},
4817 {"rust_IBinder", {"", ""}},
4818 {"cpp_ParcelFileDescriptor", {"", ""}},
4819 {"java_ParcelFileDescriptor", {"", ""}},
4820 {"ndk_ParcelFileDescriptor", {"", ""}},
4821 {"rust_ParcelFileDescriptor", {"", ""}},
4822 {"cpp_interface", {"", ""}},
4823 {"java_interface", {"", ""}},
4824 {"ndk_interface", {"", ""}},
4825 {"rust_interface", {"", ""}},
4826 {"cpp_parcelable", {"", ""}},
4827 {"java_parcelable", {"", ""}},
4828 {"ndk_parcelable", {"", ""}},
4829 {"rust_parcelable", {"", ""}},
4830 {"cpp_enum", {"", "cannot get nullable annotation"}},
4831 {"java_enum", {"", "cannot get nullable annotation"}},
4832 {"ndk_enum", {"", "cannot get nullable annotation"}},
4833 {"rust_enum", {"", "cannot get nullable annotation"}},
4834 {"cpp_union", {"", ""}},
4835 {"java_union", {"", ""}},
4836 {"ndk_union", {"", ""}},
4837 {"rust_union", {"", ""}},
4838};
4839
4840class AidlTypeParamTest
4841 : public testing::TestWithParam<std::tuple<Options::Language, TypeParam, bool>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004842 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004843 void Run(const std::string& generic_type_decl,
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004844 const std::map<std::string, ExpectedResult>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004845 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004846 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004847 const auto& kind = std::get<1>(param).kind;
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004848 const bool nullable = std::get<2>(param);
Jooyung Hane87cdd02020-12-11 16:47:35 +09004849
4850 FakeIoDelegate io;
4851 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4852 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4853 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004854 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004855 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004856 if (nullable) {
4857 decl = "@nullable " + decl;
4858 }
4859 io.SetFileContents("a/Target.aidl", "package a; parcelable Target { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004860
4861 const auto options =
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004862 Options::From(fmt::format("aidl -I . --lang={} a/Target.aidl -o out -h out", lang));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004863 CaptureStderr();
4864 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004865 auto it = expectations.find(lang + "_" + kind);
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004866 ASSERT_TRUE(it != expectations.end()) << "missing expectation for " << lang << "_" << kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004867 const string err = GetCapturedStderr();
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004868 const string expected_error =
4869 nullable ? it->second.expected_error_for_nullable : it->second.expected_error;
4870 if (expected_error.empty()) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004871 EXPECT_EQ("", err);
4872 } else {
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004873 EXPECT_THAT(err, testing::HasSubstr(expected_error));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004874 }
4875 }
4876};
4877
4878INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004879 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004880 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4881 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004882 testing::ValuesIn(kTypeParams), testing::Values(true, false)),
4883 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam, bool>>& info) {
4884 string name = to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
4885 if (std::get<2>(info.param)) {
4886 name += "_nullable";
4887 }
4888 return name;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004889 });
4890
Jooyung Hanfd3be322020-12-13 09:11:06 +09004891TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4892 Run("List<{}>", kListSupportExpectations);
4893}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004894
Jooyung Hand236e552020-12-13 09:21:27 +09004895TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4896 Run("{}[]", kArraySupportExpectations);
4897}
4898
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004899TEST_P(AidlTypeParamTest, ParcelableFieldTypes) {
4900 Run("{}", kFieldSupportExpectations);
4901}
4902
Christopher Wiley90be4e32015-10-20 14:55:25 -07004903} // namespace aidl
4904} // namespace android