blob: 0fda47c357460f822ef6483d3240addec540da2e [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
Jooyung Han2aedb112021-09-29 09:37:59 +090028#include <variant>
Jooyung Han1f14ab32020-10-14 13:48:29 +090029#include <vector>
30
Steven Moreland49585242019-12-18 16:06:49 -080031#include "aidl_checkapi.h"
Jooyung Han1f56b702021-02-11 13:16:15 +090032#include "aidl_dumpapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070034#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "aidl_to_java.h"
Jooyung Han161bb0f2021-01-21 12:30:16 +090036#include "comments.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090037#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090038#include "options.h"
Jooyung Han93f48f02021-06-05 00:11:16 +090039#include "parser.h"
40#include "preprocess.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070041#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070042
43using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080044using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090045using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080046using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070047using std::string;
48using std::unique_ptr;
Jooyung Han2aedb112021-09-29 09:37:59 +090049using std::variant;
Christopher Wiley12e894a2016-01-29 11:55:07 -080050using std::vector;
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +090051using testing::HasSubstr;
Devin Moore7b8d5c92020-03-17 14:14:08 -070052using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090053using testing::internal::CaptureStderr;
54using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070055
56namespace android {
57namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070058namespace {
59
60const char kExpectedDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63
64p/IFoo.aidl :
65)";
66
Dan Willemsen93298ee2016-11-10 23:55:55 -080067const char kExpectedNinjaDepFileContents[] =
68R"(place/for/output/p/IFoo.java : \
69 p/IFoo.aidl
70)";
71
Jiyong Parkdf202122019-09-30 20:48:35 +090072const char kExpectedParcelableDeclarationDepFileContents[] =
73 R"( : \
74 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
79const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080080 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070081 p/Foo.aidl
82
83p/Foo.aidl :
84)";
85
Christopher Wileyf8136192016-04-12 14:19:35 -070086} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -070087
Devin Moore7b8d5c92020-03-17 14:14:08 -070088class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -070089 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +090090 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
91 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -070092 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -070093 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +090094 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -070095 args.emplace_back("aidl");
Jooyung Han9435e9a2021-01-06 10:16:31 +090096 args.emplace_back("--lang=" + to_string(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -070097 for (const string& s : additional_arguments) {
98 args.emplace_back(s);
99 }
100 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900101 args.emplace_back("--preprocessed=" + f);
102 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700103 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900104 args.emplace_back("--include=" + i);
105 }
106 args.emplace_back(path);
107 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900108 vector<string> imported_files;
Jooyung Han6529b822021-06-11 22:05:26 +0900109 ImportResolver import_resolver{io_delegate_, path, import_paths_};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700110 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900111 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900112
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700113 if (error != nullptr) {
114 *error = actual_error;
115 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900116
117 if (actual_error != AidlError::OK) {
118 return nullptr;
119 }
120
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900121 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900122 EXPECT_EQ(1ul, defined_types.size());
123
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900124 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700125 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700126
Devin Moore7b8d5c92020-03-17 14:14:08 -0700127 Options::Language GetLanguage() { return GetParam(); }
128
Christopher Wiley0522cd52015-10-28 15:39:44 -0700129 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800130 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900131 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900132 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700133};
134
Devin Moore7b8d5c92020-03-17 14:14:08 -0700135// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
136// tests with each of the supported languages as a parameter.
137INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
138 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700139 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700140 [](const testing::TestParamInfo<Options::Language>& info) {
Jooyung Han9435e9a2021-01-06 10:16:31 +0900141 return to_string(info.param);
Devin Moore7b8d5c92020-03-17 14:14:08 -0700142 });
143
144TEST_P(AidlTest, AcceptMissingPackage) {
145 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700146}
147
Devin Moore7b8d5c92020-03-17 14:14:08 -0700148TEST_P(AidlTest, EndsInSingleLineComment) {
149 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700150}
151
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000152TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
153 const string expected_stderr =
154 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
155 const std::string file_contents = "package a; interface IBar {}";
156 CaptureStderr();
157 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
158 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
159}
160
161TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
162 const string expected_stderr =
163 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
164 const std::string file_contents = "package a; interface Bar {}";
165 CaptureStderr();
166 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
167 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
168}
169
170TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
171 const string expected_stderr =
172 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
173 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
174 CaptureStderr();
175 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
176 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
177}
178
179TEST_P(AidlTest, EnumRequiresCorrectPath) {
180 const string expected_stderr =
181 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
182 const std::string file_contents = "package a; enum Bar { A, }";
183 CaptureStderr();
184 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
185 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
186}
187
Devin Moore7b8d5c92020-03-17 14:14:08 -0700188TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900189 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents("bar/IBar.aidl",
191 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700192 const string path = "foo/IFoo.aidl";
193 const string contents =
194 "package foo;\n"
195 "import bar.IBar;\n"
196 "interface IFoo { void f(in IBar[] input); }";
197 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
198 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700199 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700200 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700201}
202
Devin Moore7b8d5c92020-03-17 14:14:08 -0700203TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700204 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700205 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900206}
Devin Moore097a3ab2020-03-11 16:08:44 -0700207
Jiyong Park40782d02020-07-24 19:17:43 +0900208TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700209 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
210 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900211 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
212 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700213 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700214 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700215 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900216}
217
Jiyong Park40782d02020-07-24 19:17:43 +0900218TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900219 const string oneway_interface = "package a; oneway interface IBar { void f(out int[] bar); }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700220 const string expected_stderr =
221 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700222 CaptureStderr();
223 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
224 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900225}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700226
Jiyong Park40782d02020-07-24 19:17:43 +0900227TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Jooyung Han020d8d12021-02-26 17:23:02 +0900228 const string oneway_method = "package a; interface IBar { oneway void f(out int[] bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900229 const string expected_stderr =
230 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700231 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700233 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700234}
235
Devin Moore7b8d5c92020-03-17 14:14:08 -0700236TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700237 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
238 const string expected_stderr =
239 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
240 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700246 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
247 const string expected_stderr =
248 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
249 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800252}
253
Devin Moore2f2077a2020-08-28 11:27:53 -0700254TEST_P(AidlTest, AcceptNullableList) {
255 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
256 const string expected_stderr = "";
257 CaptureStderr();
258 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
260}
261
Jooyung Han01720ed2021-08-13 07:46:07 +0900262TEST_P(AidlTest, RejectRecursiveParcelable) {
263 CaptureStderr();
264 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Foo foo; }", typenames_, GetLanguage()));
265 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
266}
267
268TEST_P(AidlTest, RejectIndirectRecursiveParcelable) {
269 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { Foo foo; }");
270 import_paths_.emplace("");
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
273 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
274}
275
276TEST_P(AidlTest, RejectRecursiveTypeEvenIfNullable) {
277 // Note: in native backends @nullable is mapped to non-heap wrapper like std::optional/Option<T>
278 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { @nullable Foo foo; }");
279 import_paths_.emplace("");
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("Foo.aidl", "parcelable Foo { Bar bar; }", typenames_, GetLanguage()));
282 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Foo is a recursive parcelable"));
283}
284
285TEST_P(AidlTest, OkayIfRecursionInvolvesHeapType) {
286 CaptureStderr();
287 std::string java_only_map_field;
288 if (GetLanguage() == Options::Language::JAVA) {
289 java_only_map_field = " Map<String, Foo> map;\n";
290 }
291 EXPECT_NE(nullptr, Parse("Foo.aidl",
292 "parcelable Foo {\n"
293 " List<Foo> list;\n" +
294 java_only_map_field +
295 " Foo[] arr;\n"
296 " @nullable(heap=true) Foo heap_nullable;\n"
297 "}\n",
298 typenames_, GetLanguage()));
299 EXPECT_THAT(GetCapturedStderr(), "");
300}
301
302TEST_P(AidlTest, InterfaceCanReferenceItself) {
303 CaptureStderr();
304 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { void foo(in IFoo self); }", typenames_,
305 GetLanguage()));
306 EXPECT_THAT(GetCapturedStderr(), "");
307}
308
309TEST_P(AidlTest, HeapNullableCantApplyToOtherThanParcelables) {
310 CaptureStderr();
311 EXPECT_EQ(nullptr, Parse("Foo.aidl",
312 "parcelable Foo {\n"
313 " @nullable(heap=true) String s;\n"
314 "}",
315 typenames_, GetLanguage()));
316 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable(heap=true) is available to parcelables"));
317}
318
Devin Moore7b8d5c92020-03-17 14:14:08 -0700319TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700320 const string method = "package a; interface IFoo { void f(int a, int a); }";
321 const string expected_stderr =
322 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
323 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700324 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700325 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700326}
327
Jeongik Cha13066da2020-08-06 15:43:19 +0900328TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
329 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900330 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900331 CaptureStderr();
332 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
334}
335
Jooyung Hand902a972020-10-23 17:32:44 +0900336TEST_P(AidlTest, RejectsRepeatedAnnotations) {
337 const string method = R"(@Hide @Hide parcelable Foo {})";
338 const string expected_stderr =
339 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
340 "Foo.aidl:1.1-6\n";
341 CaptureStderr();
342 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
343 EXPECT_EQ(expected_stderr, GetCapturedStderr());
344}
345
Jooyung Han05bd8a82021-04-28 23:56:38 +0900346TEST_P(AidlTest, AcceptsEmptyParcelable) {
347 CaptureStderr();
348 EXPECT_NE(nullptr, Parse("Foo.aidl", "parcelable Foo {}", typenames_, GetLanguage()));
349 EXPECT_EQ("", GetCapturedStderr());
350}
351
Devin Moore7b8d5c92020-03-17 14:14:08 -0700352TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
354 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
355 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700356 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100358}
359
Devin Moore7b8d5c92020-03-17 14:14:08 -0700360TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700361 AidlError error;
362 const string method = "package a; @nullable interface IFoo { int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900365 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700366 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800367}
368
Devin Moore7b8d5c92020-03-17 14:14:08 -0700369TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700370 AidlError error;
371 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
Devin Moorec054bf82020-03-10 16:31:48 -0700372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900374 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaOnlyStableParcelable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700375 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800376}
377
Devin Moore7b8d5c92020-03-17 14:14:08 -0700378TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700379 AidlError error;
Jooyung Hana97b5882021-11-02 10:32:54 +0900380 const string method = "package a; @nullable parcelable Foo { String a; String b; }";
Devin Moorec054bf82020-03-10 16:31:48 -0700381 CaptureStderr();
Jooyung Hana97b5882021-11-02 10:32:54 +0900382 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage(), &error));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900383 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@nullable is not available."));
Devin Moorec054bf82020-03-10 16:31:48 -0700384 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800385}
386
Jiyong Park40782d02020-07-24 19:17:43 +0900387TEST_P(AidlTest, ParsesNonNullableAnnotation) {
388 auto parse_result =
389 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
390 ASSERT_NE(nullptr, parse_result);
391 const AidlInterface* interface = parse_result->AsInterface();
392 ASSERT_NE(nullptr, interface);
393 ASSERT_FALSE(interface->GetMethods().empty());
394 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
395}
396
Devin Moore7b8d5c92020-03-17 14:14:08 -0700397TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900398 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
399 typenames_, GetLanguage());
400 ASSERT_NE(nullptr, parse_result);
401 const AidlInterface* interface = parse_result->AsInterface();
402 ASSERT_NE(nullptr, interface);
403 ASSERT_FALSE(interface->GetMethods().empty());
404 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
405}
406
407TEST_P(AidlTest, ParsesNonUtf8Annotations) {
408 auto parse_result =
409 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
410 ASSERT_NE(nullptr, parse_result);
411 const AidlInterface* interface = parse_result->AsInterface();
412 ASSERT_NE(nullptr, interface);
413 ASSERT_FALSE(interface->GetMethods().empty());
414 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800415}
416
Devin Moore7b8d5c92020-03-17 14:14:08 -0700417TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900418 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
419 typenames_, GetLanguage());
420 ASSERT_NE(nullptr, parse_result);
421 const AidlInterface* interface = parse_result->AsInterface();
422 ASSERT_NE(nullptr, interface);
423 ASSERT_FALSE(interface->GetMethods().empty());
424 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800425}
426
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700428 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700429 const string expected_stderr =
430 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
431 "\"vintf\"'\n"
432 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
433 "--structured\n";
434 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700435 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700436 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700437 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700438 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700439}
440
Devin Moore7b8d5c92020-03-17 14:14:08 -0700441TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700442 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700443 const string expected_stderr =
444 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
445 "--structured\n";
446 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700447 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700448 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700449 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700450 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700451}
452
Devin Moore7b8d5c92020-03-17 14:14:08 -0700453TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700454 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700455 const string expected_stderr =
456 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
457 "\"vintf\"'\n";
458 CaptureStderr();
459 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700460 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700461 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700462 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700463}
464
Devin Moore7b8d5c92020-03-17 14:14:08 -0700465TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700466 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700467 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
468 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700469 ASSERT_EQ(AidlError::OK, error);
470 ASSERT_NE(nullptr, parse_result);
471 const AidlInterface* interface = parse_result->AsInterface();
472 ASSERT_NE(nullptr, interface);
473 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700474}
475
Jeongik Cha64783ed2019-06-07 18:30:54 +0900476TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
477 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900478 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
479 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900480 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700481 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900482 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900483 "a/Foo.aidl",
484 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900485
Steven Moreland4e059132021-08-11 13:36:30 -0700486 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
487 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900488
Devin Moorec054bf82020-03-10 16:31:48 -0700489 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700490 EXPECT_FALSE(compile_aidl(cpp_structured_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900491 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Andrei Homescub62afd92020-05-11 19:24:59 -0700492
493 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700494 EXPECT_FALSE(compile_aidl(rust_options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900495 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Cannot declare unstructured"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900496}
497
Jooyung Han1cbc4962020-10-25 10:07:15 +0900498TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
499 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
500 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
501 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700502 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900503
504 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900505 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900506 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
507
508 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900509 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700510 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900511
Jooyung Han1cbc4962020-10-25 10:07:15 +0900512 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700513 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Jiyong Park43113fb2020-07-20 16:26:19 +0900514}
515
Jooyung Han1cbc4962020-10-25 10:07:15 +0900516TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
517 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
518 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
519 CaptureStderr();
520 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700521 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jooyung Han1cbc4962020-10-25 10:07:15 +0900522 EXPECT_EQ("", GetCapturedStderr());
523
524 const string expected_to_string_method = R"--(
525 @Override
526 public String toString() {
527 switch (_tag) {
528 case a: return "a.Foo.a(" + (getA()) + ")";
529 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
530 }
531 throw new IllegalStateException("unknown field: " + _tag);
532 }
533)--";
534
535 string java_out;
536 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
537 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
538}
539
Jiyong Park9aa3d042020-12-04 23:30:02 +0900540TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
541 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
542 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
543 CaptureStderr();
544 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700545 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900546 EXPECT_EQ("", GetCapturedStderr());
547
548 const std::string expected = R"--(
549 @Override
550 public boolean equals(Object other) {
551 if (this == other) return true;
552 if (other == null) return false;
553 if (!(other instanceof Foo)) return false;
554 Foo that = (Foo)other;
555 if (!java.util.Objects.deepEquals(a, that.a)) return false;
556 if (!java.util.Objects.deepEquals(b, that.b)) return false;
557 return true;
558 }
559
560 @Override
561 public int hashCode() {
562 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
563 }
564)--";
565
566 string java_out;
567 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
568 EXPECT_THAT(java_out, testing::HasSubstr(expected));
569}
570
571TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
572 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
573 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
574 CaptureStderr();
575 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -0700576 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Park9aa3d042020-12-04 23:30:02 +0900577 EXPECT_EQ("", GetCapturedStderr());
578
579 const std::string expected = R"--(
580 @Override
581 public boolean equals(Object other) {
582 if (this == other) return true;
583 if (other == null) return false;
584 if (!(other instanceof Foo)) return false;
585 Foo that = (Foo)other;
586 if (_tag != that._tag) return false;
587 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
588 return true;
589 }
590
591 @Override
592 public int hashCode() {
593 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
594 }
595)--";
596
597 string java_out;
598 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
599 EXPECT_THAT(java_out, testing::HasSubstr(expected));
600}
601
Jooyung Han90345002020-10-23 15:28:53 +0900602TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900603 {
Jooyung Han90345002020-10-23 15:28:53 +0900604 io_delegate_.SetFileContents("a/Foo.aidl",
605 "package a; @JavaDerive(blah=true) parcelable Foo{}");
606 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
607 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700608 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han90345002020-10-23 15:28:53 +0900609 const std::string expected_stderr =
610 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
Jooyung Hanf8dbbcc2020-12-26 03:05:55 +0900611 EXPECT_THAT(GetCapturedStderr(),
612 HasSubstr("Parameter blah not supported for annotation JavaDerive."));
Jooyung Han90345002020-10-23 15:28:53 +0900613 }
614
615 {
616 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900617 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
618 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700619 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900620 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900621 }
622
623 {
Jooyung Han90345002020-10-23 15:28:53 +0900624 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900625 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
626 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700627 EXPECT_FALSE(compile_aidl(java_options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +0900628 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@JavaDerive is not available."));
Jiyong Park43113fb2020-07-20 16:26:19 +0900629 }
630}
631
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900632TEST_P(AidlTest, ParseDescriptorAnnotation) {
633 AidlError error;
634 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
635 typenames_, GetLanguage(), &error, {"--structured"});
636 ASSERT_EQ(AidlError::OK, error);
637 ASSERT_NE(nullptr, parse_result);
638 const AidlInterface* interface = parse_result->AsInterface();
639 ASSERT_NE(nullptr, interface);
640 ASSERT_EQ("IBar", interface->GetDescriptor());
641}
642
Jooyung Han55db8112021-09-15 22:37:39 +0900643TEST_P(AidlTest, UnknownAnnotation) {
Jooyung Han55db8112021-09-15 22:37:39 +0900644 CaptureStderr();
Jooyung Han2834f002021-09-27 11:48:15 +0900645 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown interface IFoo { }", typenames_,
646 GetLanguage()));
647 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
648
649 CaptureStderr();
650 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", "package a; @Unknown(param=true) interface IFoo { }",
651 typenames_, GetLanguage()));
Jooyung Han55db8112021-09-15 22:37:39 +0900652 EXPECT_THAT(GetCapturedStderr(), HasSubstr("not a recognized annotation"));
653}
654
Jiyong Park40782d02020-07-24 19:17:43 +0900655TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700656 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700657 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900658}
659
660TEST_P(AidlTest, AcceptsOnewayInterface) {
661 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700662 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700663}
Christopher Wileyef140932015-11-03 09:29:19 -0800664
Devin Moore7b8d5c92020-03-17 14:14:08 -0700665TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700666 const string oneway_method =
667 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700668 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100669}
670
Steven Moreland65297cc2020-04-20 20:17:36 -0700671TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
672 const string oneway_method =
673 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
674 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
675 ASSERT_NE(nullptr, defined);
676 const AidlInterface* iface = defined->AsInterface();
677 ASSERT_NE(nullptr, iface);
678
679 const auto& methods = iface->GetMethods();
680 ASSERT_EQ(1u, methods.size());
681 const auto& method = methods[0];
682 const AidlTypeSpecifier& ret_type = method->GetType();
683
684 // TODO(b/151102494): these annotations should be on the method
685 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
686 ASSERT_TRUE(ret_type.IsHide());
687}
688
Devin Moore7b8d5c92020-03-17 14:14:08 -0700689TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100690 string foo_interface =
Jooyung Han8451a202021-01-16 03:07:06 +0900691 R"(package a;
692 /* foo */
693 interface IFoo {
694 /* i */
695 int i();
696 // j
697 @nullable String j();
698 // k1
699 /* k2 */
700 @UnsupportedAppUsage oneway void k(int a);
701 })";
Artur Satayev91fe8712019-07-29 13:06:01 +0100702
Jooyung Han8451a202021-01-16 03:07:06 +0900703 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700704 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100705 EXPECT_NE(nullptr, parse_result);
Jooyung Han8451a202021-01-16 03:07:06 +0900706 EXPECT_EQ("", GetCapturedStderr());
707
Jooyung Han161bb0f2021-01-21 12:30:16 +0900708 EXPECT_EQ((Comments{{"/* foo */"}}), parse_result->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100709
710 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900711 EXPECT_EQ((Comments{{"/* i */"}}), interface->GetMethods()[0]->GetComments());
712 EXPECT_EQ((Comments{{"// j\n"}}), interface->GetMethods()[1]->GetComments());
713 EXPECT_EQ((Comments{{"// k1\n"}, {"/* k2 */"}}), interface->GetMethods()[2]->GetComments());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714}
715
Jooyung Han1a551d32020-10-05 15:37:26 +0900716TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
717 io_delegate_.SetFileContents("p/cpp_header.aidl",
718 R"(package p;
719 parcelable cpp_header cpp_header "bar/header";)");
720 import_paths_.emplace("");
721 const string input_path = "p/IFoo.aidl";
722 const string input = R"(package p;
723 import p.cpp_header;
724 interface IFoo {
725 // get bar
726 cpp_header get();
727 })";
728
729 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
730 EXPECT_NE(nullptr, parse_result);
731 const AidlInterface* interface = parse_result->AsInterface();
Jooyung Han161bb0f2021-01-21 12:30:16 +0900732 EXPECT_EQ((Comments{{"// get bar\n"}}), interface->GetMethods()[0]->GetComments());
Jooyung Han1a551d32020-10-05 15:37:26 +0900733}
734
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900735TEST_F(AidlTest, RejectsIfCppHeaderIsMissing) {
736 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
737 Options options = Options::From("aidl --lang cpp -h h -o o Foo.aidl");
738 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700739 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900740 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
741}
742
743TEST_F(AidlTest, RejectsIfTypeRefsCppHeaderIsMissing) {
744 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo;");
745 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void bar(in Foo foo); }");
746 Options options = Options::From("aidl -I . --lang cpp -h h -o o IBar.aidl");
747 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700748 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2cb8ecd2021-07-28 18:41:30 +0900749 EXPECT_THAT(GetCapturedStderr(), HasSubstr("must have C++ header defined"));
750}
751
Christopher Wileyef140932015-11-03 09:29:19 -0800752TEST_F(AidlTest, ParsesPreprocessedFile) {
753 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
754 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700755 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900756 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700757 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
758 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800759}
760
761TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
762 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
763 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900764
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700765 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jooyung Han93f48f02021-06-05 00:11:16 +0900766 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700767 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
768 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800769}
770
Devin Moore7b8d5c92020-03-17 14:14:08 -0700771TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800772 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
773 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
774 "interface IBar {}");
775 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900776 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900777 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700778 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800779 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900780
Christopher Wiley41544372015-11-03 14:52:29 -0800781 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700782 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
783 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800784 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900785 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900786 ambiguous_type.Resolve(typenames_, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900787 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800788}
789
Jiyong Park8f6ec462020-01-19 20:52:47 +0900790// Special case of PreferImportToPreprocessed. Imported type should be preferred
791// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700792TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900793 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
794 io_delegate_.SetFileContents("one/IBar.aidl",
795 "package one; "
796 "interface IBar {}");
797 preprocessed_files_.push_back("preprocessed");
798 import_paths_.emplace("");
799 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700800 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900801 EXPECT_NE(nullptr, parse_result);
802
803 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700804 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
805 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900806 // But if we request just "IBar" we should get our imported one.
Jooyung Han8451a202021-01-16 03:07:06 +0900807 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +0900808 ambiguous_type.Resolve(typenames_, parse_result);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900809 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
810}
811
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800812TEST_F(AidlTest, WritePreprocessedFile) {
813 io_delegate_.SetFileContents("p/Outer.aidl",
814 "package p; parcelable Outer.Inner;");
815 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
816 "interface IBar {}");
817
Jooyung Han93f48f02021-06-05 00:11:16 +0900818 vector<string> args{"aidl", "--preprocess", "preprocessed",
819 "-I.", "p/Outer.aidl", "one/IBar.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900820 Options options = Options::From(args);
Jooyung Han93f48f02021-06-05 00:11:16 +0900821 EXPECT_TRUE(::android::aidl::Preprocess(options, io_delegate_));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800822
Jooyung Han93f48f02021-06-05 00:11:16 +0900823 std::map<std::string, std::string> expected = {{"preprocessed",
824 "parcelable p.Outer.Inner;\n"
825 "interface one.IBar {\n"
826 "}\n"}};
827 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
828}
829
830TEST_F(AidlTest, PreprocessVariousThings) {
831 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
832 "package foo.bar;\n"
833 "interface IFoo {\n"
834 " int foo();\n"
835 " const int FOO = foo.bar.Bar.BAR + 1; // should be 44\n"
836 "}\n");
837 io_delegate_.SetFileContents("foo/bar/Bar.aidl",
838 "package foo.bar;\n"
839 "parcelable Bar {\n"
840 " const int BAR = imported.Foo.FOO + 1; // should be 43\n"
841 " imported.Foo foo;\n"
842 "}\n");
843 io_delegate_.SetFileContents("foo/bar/Gen.aidl",
844 "package foo.bar;\n"
845 "parcelable Gen<T> {\n"
846 "}\n");
847 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
848 "package foo.bar;\n"
849 "enum Enum {\n"
850 " FOO = 3, BAR = FOO + 3, // should be 3, 6\n"
851 "}\n");
852 io_delegate_.SetFileContents("sub/imported/Foo.aidl",
853 "package imported;\n"
854 "parcelable Foo {\n"
855 " const int FOO = 42;\n"
856 "}\n");
857
858 vector<string> args = {
859 "aidl",
860 "--preprocess",
861 "preprocessed",
862 "-Isub",
863 "-I.",
864 "foo/bar/IFoo.aidl",
865 "foo/bar/Bar.aidl",
866 "foo/bar/Gen.aidl",
867 "foo/bar/Enum.aidl",
868 };
869 ASSERT_TRUE(Preprocess(Options::From(args), io_delegate_));
870 std::string preprocessed =
871 "interface foo.bar.IFoo {\n"
872 " const int FOO = 44;\n"
873 "}\n"
874 "parcelable foo.bar.Bar {\n"
875 " const int BAR = 43;\n"
876 "}\n"
877 "parcelable foo.bar.Gen<T> {\n"
878 "}\n"
879 "enum foo.bar.Enum {\n"
880 " FOO = 3,\n"
881 " BAR = 6,\n"
882 "}\n";
883 std::map<std::string, std::string> expected = {{"preprocessed", preprocessed}};
884 EXPECT_THAT(io_delegate_.OutputFiles(), testing::Eq(expected));
885
886 // use preprocessed
887 io_delegate_.SetFileContents("a/Foo.aidl",
888 "package a; parcelable Foo { const int y = foo.bar.Bar.BAR; }");
889 io_delegate_.SetFileContents("preprocessed", preprocessed);
890 CaptureStderr();
891 auto options = Options::From("aidl --lang java -o out a/Foo.aidl -ppreprocessed");
Steven Moreland4e059132021-08-11 13:36:30 -0700892 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han93f48f02021-06-05 00:11:16 +0900893 EXPECT_EQ("", GetCapturedStderr());
894 string code;
895 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
896 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 43;"));
897}
898
Jooyung Han35784982021-06-29 06:26:12 +0900899TEST_F(AidlTest, AllowMultipleUnstructuredNestedParcelablesInASingleDocument) {
900 io_delegate_.SetFileContents("p/IFoo.aidl",
901 "package p;\n"
902 "import x.Outer;\n"
903 "interface IFoo {\n"
904 " void foo(in Outer.Inner1 in1, in Outer.Inner2 in2);\n"
905 "}");
906 io_delegate_.SetFileContents("imported/x/Outer.aidl",
907 "package x;\n"
908 "parcelable Outer.Inner1;\n"
909 "parcelable Outer.Inner2;\n");
910 auto opt = Options::From("aidl -Iimported --lang=java p/IFoo.aidl");
911 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700912 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900913 EXPECT_EQ("", GetCapturedStderr());
914}
915
916TEST_F(AidlTest,
917 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlLater) {
918 // Main doc(Foo.aidl) is loaded
919 // And then framework.aidl is loaded as preprocessed. (conflict)
920 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
921 io_delegate_.SetFileContents("x/Foo.aidl",
922 "package x;\n"
923 "parcelable Foo.Inner;\n");
924 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/Foo.aidl");
925 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700926 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900927 EXPECT_EQ("", GetCapturedStderr());
928}
929
930TEST_F(AidlTest,
931 StubsSourceIsGeneratedFromDuplicateDefinitionWithFrameworkAidl_FrameworkAidlFirst) {
932 // Main doc(IBar.aidl) is loaded first.
933 // Framework.aidl is loaded as preprocessed.
934 // And then import(Foo.aidl) is loaded. (conflict)
935 io_delegate_.SetFileContents("sdk/framework.aidl", "parcelable x.Foo.Inner;\n");
936 io_delegate_.SetFileContents("x/IBar.aidl",
937 "package x;\n"
938 "import x.Foo;\n"
939 "interface IBar {\n"
940 " void bar(in Foo.Inner inner);\n"
941 "}");
942 io_delegate_.SetFileContents("x/Foo.aidl",
943 "package x;\n"
944 "parcelable Foo.Inner;\n");
945 auto opt = Options::From("aidl -psdk/framework.aidl -I. x/IBar.aidl");
946 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -0700947 EXPECT_TRUE(compile_aidl(opt, io_delegate_));
Jooyung Han35784982021-06-29 06:26:12 +0900948 EXPECT_EQ("", GetCapturedStderr());
949}
950
Jooyung Han93f48f02021-06-05 00:11:16 +0900951TEST_F(AidlTest, PreprocessedFileCantDeclarePackage) {
952 string simple_content = "package xxx; parcelable a.Foo;";
953 io_delegate_.SetFileContents("path", simple_content);
954 CaptureStderr();
955 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
956 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Preprocessed file can't declare package."));
957}
958
959TEST_F(AidlTest, RejectQualifiedTypeNameUnlessPreprocessed) {
960 string simple_content = "parcelable a.Foo {}";
961 io_delegate_.SetFileContents("path", simple_content);
962 CaptureStderr();
963 EXPECT_FALSE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/false));
964 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Type name can't be qualified"));
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800965}
966
Jooyung Han13f1fa52021-06-11 18:06:12 +0900967TEST_P(AidlTest, PreprocessedCanDeclareJavaStyleBuiltinTypes) {
968 string contents = R"(
969 interface android.os.IBinder;
970 interface android.os.IInterface;
971 parcelable android.os.ParcelFileDescriptor;
972 )";
973 io_delegate_.SetFileContents("path", contents);
974 CaptureStderr();
975 EXPECT_TRUE(Parser::Parse("path", io_delegate_, typenames_, /*is_preprocessed=*/true));
976 EXPECT_THAT(GetCapturedStderr(), "");
977}
978
Jooyung Han720253d2021-01-05 19:13:17 +0900979TEST_P(AidlTest, SupportDeprecated) {
980 struct TestCase {
981 std::string output_file;
982 std::string annotation;
983 };
984
985 auto CheckDeprecated = [&](const std::string& filename, const std::string& contents,
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900986 std::vector<std::pair<Options::Language, TestCase>> expectations) {
Jooyung Han720253d2021-01-05 19:13:17 +0900987 io_delegate_.SetFileContents(filename, contents);
988
989 auto options = Options::From("aidl --lang=" + to_string(GetLanguage()) + " " + filename +
990 " --out=out --header_out=out");
Steven Moreland4e059132021-08-11 13:36:30 -0700991 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hand4fe00e2021-01-11 16:21:53 +0900992 for (const auto& [lang, test_case] : expectations) {
993 if (lang != GetLanguage()) continue;
Jooyung Han720253d2021-01-05 19:13:17 +0900994 string output;
Jooyung Han652ce482021-02-26 12:40:35 +0900995 EXPECT_TRUE(io_delegate_.GetWrittenContents(test_case.output_file, &output));
Jooyung Han720253d2021-01-05 19:13:17 +0900996 EXPECT_THAT(output, HasSubstr(test_case.annotation));
997 }
998 };
999
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001000 // Emit escaped string for notes
1001 CheckDeprecated(
1002 "IFoo.aidl",
1003 R"(interface IFoo {
1004 /**
1005 * @note asdf
1006 * @deprecated a really long deprecation message
1007 *
1008 * which is really long
1009 * @param foo bar
1010 */
1011 List<String> foo();
1012 })",
1013 {
1014 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1015 {Options::Language::CPP,
1016 {"out/IFoo.h",
1017 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1018 {Options::Language::NDK,
1019 {"out/aidl/IFoo.h",
1020 R"(__attribute__((deprecated("a really long deprecation message which is really long"))))"}},
1021 {Options::Language::RUST,
1022 {"out/IFoo.rs",
1023 R"(#[deprecated = "a really long deprecation message which is really long"])"}},
1024 });
1025
Jooyung Han24effbf2021-01-16 10:24:03 +09001026 // In AIDL @deprecated can be in block comments as well as javadoc style
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001027 CheckDeprecated(
1028 "IFoo.aidl",
1029 "interface IFoo {\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09001030 " /* @deprecated use bar() */\n"
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001031 " List<String> foo();\n"
1032 "}",
1033 {
1034 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001035 {Options::Language::JAVA, {"out/IFoo.java", "/** @deprecated use bar() */"}},
Jooyung Hand4fe00e2021-01-11 16:21:53 +09001036 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1037 {Options::Language::NDK,
1038 {"out/aidl/IFoo.h", "__attribute__((deprecated(\"use bar()\")))"}},
1039 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated = \"use bar()\"]"}},
1040 });
Jooyung Han720253d2021-01-05 19:13:17 +09001041
Jooyung Han24effbf2021-01-16 10:24:03 +09001042 // but not in line comments
1043 auto parsed = Parse("IFoo.aidl", "// @deprecated\ninterface IFoo {}", typenames_, GetLanguage());
1044 EXPECT_FALSE(parsed->IsDeprecated());
1045
1046 // parcelable
Jooyung Han720253d2021-01-05 19:13:17 +09001047 CheckDeprecated("Foo.aidl",
1048 "parcelable Foo {\n"
1049 " /** @deprecated use bar*/\n"
1050 " int foo = 0;\n"
1051 "}",
1052 {
1053 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1054 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1055 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1056 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1057 });
1058
Jooyung Han24effbf2021-01-16 10:24:03 +09001059 // interface constants
Jooyung Han720253d2021-01-05 19:13:17 +09001060 CheckDeprecated("IFoo.aidl",
1061 "interface IFoo {\n"
1062 " /** @deprecated use bar*/\n"
1063 " const int FOO = 0;\n"
1064 "}",
1065 {
1066 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1067 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1068 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1069 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1070 });
1071
1072 // union fields
1073 CheckDeprecated("Foo.aidl",
1074 "union Foo {\n"
1075 " int bar = 0;\n"
1076 " /** @deprecated use bar*/\n"
1077 " int foo;\n"
1078 "}",
1079 {
1080 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1081 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1082 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1083 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1084 });
1085
1086 CheckDeprecated("Foo.aidl",
1087 "/** @deprecated use Bar */\n"
1088 "parcelable Foo {}",
1089 {
1090 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1091 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1092 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1093 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1094 });
1095
1096 CheckDeprecated("Foo.aidl",
1097 "/** @deprecated use Bar */\n"
1098 "union Foo { int foo = 0; }",
1099 {
1100 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1101 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1102 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
1103 {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1104 });
1105
1106 CheckDeprecated("IFoo.aidl",
1107 "/** @deprecated use IBar */\n"
1108 "interface IFoo {}",
1109 {
1110 {Options::Language::JAVA, {"out/IFoo.java", "@Deprecated"}},
1111 {Options::Language::CPP, {"out/IFoo.h", "__attribute__((deprecated"}},
1112 {Options::Language::NDK, {"out/aidl/IFoo.h", "__attribute__((deprecated"}},
1113 {Options::Language::RUST, {"out/IFoo.rs", "#[deprecated"}},
1114 });
1115
1116 CheckDeprecated("Foo.aidl",
1117 "/** @deprecated use IBar */\n"
1118 "enum Foo { FOO }",
1119 {
1120 {Options::Language::JAVA, {"out/Foo.java", "@Deprecated"}},
1121 {Options::Language::CPP, {"out/Foo.h", "__attribute__((deprecated"}},
1122 {Options::Language::NDK, {"out/aidl/Foo.h", "__attribute__((deprecated"}},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09001123 // TODO(b/177860423) support "deprecated" in Rust enum
Jooyung Han720253d2021-01-05 19:13:17 +09001124 // {Options::Language::RUST, {"out/Foo.rs", "#[deprecated"}},
1125 });
1126}
1127
Devin Moore7b8d5c92020-03-17 14:14:08 -07001128TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001129 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001130 io_delegate_.SetFileContents("p/Outer.aidl",
1131 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +09001132 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001133 CaptureStderr();
1134 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1135 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001136 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -07001137 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001138}
1139
Devin Moore7b8d5c92020-03-17 14:14:08 -07001140TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Steven Moreland58d402b2021-07-27 18:35:07 -07001141 io_delegate_.SetFileContents("preprocessed", "parcelable p.Outer.Inner cpp_header \"inner.h\";");
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001142 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001143 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001144 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -08001145 // TODO(wiley): This should actually return nullptr because we require
1146 // the outer class name. However, for legacy reasons,
1147 // this behavior must be maintained. b/17415692
1148 EXPECT_NE(nullptr, parse_result);
1149}
1150
Jooyung Han05a532a2021-08-18 10:41:40 +09001151TEST_F(AidlTest, ApiMappingAcceptsUnstructuredParcelables) {
1152 io_delegate_.SetFileContents("p/Foo.aidl", "package p; parcelable Foo;");
1153
1154 Options options1 = Options::From("aidl --apimapping mapping.txt p/Foo.aidl");
1155 CaptureStderr();
1156 EXPECT_EQ(0, aidl_entry(options1, io_delegate_));
1157 EXPECT_EQ("", GetCapturedStderr());
1158}
1159
Christopher Wiley632801d2015-11-05 14:15:49 -08001160TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001161 const string expected_foo_stderr =
1162 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
1163 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1164 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001165 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
1166
Christopher Wiley632801d2015-11-05 14:15:49 -08001167 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -07001168 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001169 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001170 EXPECT_TRUE(compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001171 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001172
Steven Morelande2c64b42018-09-18 15:06:37 -07001173 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001174 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001175 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001176 EXPECT_FALSE(compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001177 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001178
Devin Moore097a3ab2020-03-11 16:08:44 -07001179 const string expected_bar_stderr =
1180 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
1181 "Declared parcelables should be in their own file and/or cannot be used with --structured "
1182 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -07001183 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
1184
Jiyong Parkda8c6932019-08-12 19:56:08 +09001185 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -07001186 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001187 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001188 EXPECT_TRUE(compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001189 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -07001190 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -07001191 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07001192 EXPECT_FALSE(compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001193 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -08001194}
1195
Jooyung Han13f1fa52021-06-11 18:06:12 +09001196TEST_P(AidlTest, ImportingJavaStyleBuiltinTypesIsAllowed) {
1197 string contents = R"(
1198 import android.os.IBinder;
1199 import android.os.IInterface;
1200 interface IFoo {
1201 void foo(in IBinder b);
1202 }
1203 )";
1204 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
1205}
1206
Devin Moore7b8d5c92020-03-17 14:14:08 -07001207TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001208 const string expected_stderr =
Jooyung Han397a7602021-06-05 00:06:22 +09001209 "ERROR: o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
Devin Moore097a3ab2020-03-11 16:08:44 -07001210 "structured interface.\n";
Steven Moreland58d402b2021-07-27 18:35:07 -07001211 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl",
1212 "package o; parcelable WhoKnowsWhat cpp_header \"who_knows.h\";");
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001213 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -07001214 AidlError error;
1215 CaptureStderr();
1216 EXPECT_EQ(
1217 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001218 Parse("p/IFoo.aidl",
1219 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001220 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001221 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1222 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001223}
1224
Devin Moore7b8d5c92020-03-17 14:14:08 -07001225TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001226 AidlError error;
1227 const string expected_stderr =
1228 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1229 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001230 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1231 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001232 interface IFoo {
1233 const String DUPLICATED = "d";
1234 const int DUPLICATED = 1;
1235 }
1236 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001237 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1239 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001240}
1241
Jooyung Hana97b5882021-11-02 10:32:54 +09001242TEST_P(AidlTest, RejectUnstructuredParcelablesInNDKandRust) {
1243 io_delegate_.SetFileContents("o/Foo.aidl", "package o; parcelable Foo cpp_header \"cpp/Foo.h\";");
1244 const auto options =
1245 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -o out -h out -I. o/Foo.aidl");
1246 const bool reject_unstructured_parcelables =
1247 GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST;
1248 const string expected_err = reject_unstructured_parcelables
1249 ? "Refusing to generate code with unstructured parcelables"
1250 : "";
1251 CaptureStderr();
1252 EXPECT_EQ(compile_aidl(options, io_delegate_), !reject_unstructured_parcelables);
1253 EXPECT_THAT(GetCapturedStderr(), HasSubstr(expected_err));
1254}
1255
Steven Morelande689da22020-11-10 02:06:30 +00001256TEST_P(AidlTest, FailOnTooBigConstant) {
1257 AidlError error;
1258 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07001259 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte (256)\n";
Steven Morelande689da22020-11-10 02:06:30 +00001260 CaptureStderr();
1261 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1262 R"(package p;
1263 interface IFoo {
1264 const byte type2small = 256;
1265 }
1266 )",
1267 typenames_, GetLanguage(), &error));
1268 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1269 EXPECT_EQ(AidlError::BAD_TYPE, error);
1270}
1271
Jooyung Han30f64ad2020-12-15 08:16:31 +09001272TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1273 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1274 CaptureStderr();
1275 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07001276 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han30f64ad2020-12-15 08:16:31 +09001277 EXPECT_EQ("", GetCapturedStderr());
1278 string code;
1279 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1280 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1281}
1282
Jooyung Han535c5e82020-12-29 15:16:59 +09001283TEST_F(AidlTest, AidlConstantValue_EvaluatedValue) {
Jooyung Han71a1b582020-12-25 23:58:41 +09001284 using Ptr = unique_ptr<AidlConstantValue>;
1285 const AidlLocation& loc = AIDL_LOCATION_HERE;
1286
Jooyung Han535c5e82020-12-29 15:16:59 +09001287 EXPECT_EQ('c', Ptr(AidlConstantValue::Character(loc, 'c'))->EvaluatedValue<char>());
1288 EXPECT_EQ("abc", Ptr(AidlConstantValue::String(loc, "\"abc\""))->EvaluatedValue<string>());
1289 EXPECT_FLOAT_EQ(1.0f, Ptr(AidlConstantValue::Floating(loc, "1.0f"))->EvaluatedValue<float>());
1290 EXPECT_EQ(true, Ptr(AidlConstantValue::Boolean(loc, true))->EvaluatedValue<bool>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001291
1292 AidlBinaryConstExpression one_plus_one(loc, Ptr(AidlConstantValue::Integral(loc, "1")), "+",
1293 Ptr(AidlConstantValue::Integral(loc, "1")));
Jooyung Han535c5e82020-12-29 15:16:59 +09001294 EXPECT_EQ(2, one_plus_one.EvaluatedValue<int32_t>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001295
1296 auto values = unique_ptr<vector<Ptr>>{new vector<Ptr>};
1297 values->emplace_back(AidlConstantValue::String(loc, "\"hello\""));
1298 values->emplace_back(AidlConstantValue::String(loc, "\"world\""));
1299 vector<string> expected{"hello", "world"};
Jooyung Han535c5e82020-12-29 15:16:59 +09001300 EXPECT_EQ(
1301 expected,
1302 Ptr(AidlConstantValue::Array(loc, std::move(values)))->EvaluatedValue<vector<string>>());
Jooyung Han71a1b582020-12-25 23:58:41 +09001303}
1304
Devin Moore7b8d5c92020-03-17 14:14:08 -07001305TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001306 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001307 const string expected_stderr =
1308 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001309 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001310 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1311 R"(package p;
1312 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001313 parcelable IBar {}
1314 parcelable StructuredParcelable {}
1315 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001316 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001317 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001318 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001319 // Parse success is important for clear error handling even if the cases aren't
1320 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001321 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001322}
1323
Devin Moore7b8d5c92020-03-17 14:14:08 -07001324TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001325 AidlError error;
1326 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1327 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001328 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1330 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001331}
1332
Steven Morelandf9e922f2020-07-08 21:15:27 +00001333TEST_P(AidlTest, FailOnEmptyListWithComma) {
1334 AidlError error;
1335 const string expected_stderr =
1336 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1337 CaptureStderr();
1338 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1339 typenames_, GetLanguage(), &error));
1340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1341 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1342}
1343
Devin Moore7b8d5c92020-03-17 14:14:08 -07001344TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001345 AidlError error;
1346 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001347 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001348 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001349 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1350 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001351 interface IFoo {
1352 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1353 }
1354 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001355 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1357 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001358}
1359
Jiyong Park18132182020-06-08 20:24:40 +09001360TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1361 AidlError error;
1362 const string expected_stderr =
1363 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1364 "cpp_header (which can also be used as an identifier)\n";
1365 CaptureStderr();
1366 // Notice the trailing dot(.) in the name, which isn't a correct name
1367 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1368 GetLanguage(), &error));
1369 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1370 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1371}
1372
1373TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1374 AidlError error;
1375 const string expected_stderr =
1376 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1377 "cpp_header (which can also be used as an identifier)\n";
1378 CaptureStderr();
1379 // Notice the trailing dot(.) in the package name
1380 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1381 GetLanguage(), &error));
1382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1383 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1384}
1385
Devin Moore7b8d5c92020-03-17 14:14:08 -07001386TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001387 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001388 auto parse_result = Parse("p/IFoo.aidl",
1389 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001390 interface IFoo {
1391 const int POSITIVE_HEX_VALUE = 0xf5;
1392 }
1393 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001394 typenames_, GetLanguage(), &error);
1395 EXPECT_NE(nullptr, parse_result);
1396 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001397 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001398 const auto& cpp_constants = interface->GetConstantDeclarations();
1399 EXPECT_EQ((size_t)1, cpp_constants.size());
1400 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001401 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001402 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001403}
1404
Devin Moore7b8d5c92020-03-17 14:14:08 -07001405TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001406 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001407 auto parse_result = Parse("p/IFoo.aidl",
1408 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001409 interface IFoo {
1410 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1411 }
1412 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001413 typenames_, GetLanguage(), &error);
1414 ASSERT_NE(nullptr, parse_result);
1415 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001416 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001417 const auto& cpp_constants = interface->GetConstantDeclarations();
1418 EXPECT_EQ((size_t)1, cpp_constants.size());
1419 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001420 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001421 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001422}
1423
Jooyung Han2aedb112021-09-29 09:37:59 +09001424TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001425 io_delegate_.SetFileContents(
1426 "p/Outer.aidl",
1427 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001428 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001429 const string input_path = "p/IFoo.aidl";
1430 const string input = "package p; import p.Outer; interface IFoo"
1431 " { Outer.Inner get(); }";
1432
Devin Moore7b8d5c92020-03-17 14:14:08 -07001433 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1434 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001435
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001436 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001437 // C++ uses "::" instead of "." to refer to a inner class.
Jooyung Han8451a202021-01-16 03:07:06 +09001438 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001439 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001440}
1441
Jooyung Han2aedb112021-09-29 09:37:59 +09001442TEST_P(AidlTest, UnderstandsNestedUnstructuredParcelablesWithoutImports) {
Jooyung Han78fcaa82021-06-11 22:27:57 +09001443 io_delegate_.SetFileContents("p/Outer.aidl",
1444 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
1445 import_paths_.emplace("");
1446 const string input_path = "p/IFoo.aidl";
1447 const string input = "package p; interface IFoo { p.Outer.Inner get(); }";
1448
1449 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1450 EXPECT_NE(nullptr, parse_result);
1451
1452 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
1453 // C++ uses "::" instead of "." to refer to a inner class.
1454 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, {});
1455 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
1456}
1457
Jooyung Han2aedb112021-09-29 09:37:59 +09001458TEST_F(AidlTest, UnderstandsNestedTypes) {
1459 io_delegate_.SetFileContents("p/IOuter.aidl",
1460 "package p;\n"
1461 "interface IOuter {\n"
1462 " parcelable Inner {}\n"
1463 "}");
1464 import_paths_.emplace("");
1465 const string input_path = "p/IFoo.aidl";
1466 const string input =
1467 "package p;\n"
1468 "import p.IOuter;\n"
1469 "interface IFoo {\n"
1470 " IOuter.Inner get();\n"
1471 "}";
1472 CaptureStderr();
1473 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1474 EXPECT_EQ(GetCapturedStderr(), "");
1475
1476 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1477 // C++ uses "::" instead of "." to refer to a inner class.
1478 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.IOuter.Inner", false, nullptr, {});
1479 EXPECT_EQ("::p::IOuter::Inner", cpp::CppNameOf(nested_type, typenames_));
1480}
1481
Jooyung Hanf8c39632021-10-05 09:56:29 +09001482TEST_F(AidlTest, DefinedTypeKnowsItsParentScope) {
1483 const string input_path = "p/IFoo.aidl";
1484 const string input =
1485 "package p;\n"
1486 "interface IFoo {\n"
1487 " parcelable Inner {\n"
1488 " enum Enum { A }\n"
1489 " }\n"
1490 "}";
1491 CaptureStderr();
1492 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1493 EXPECT_EQ(GetCapturedStderr(), "");
1494
1495 auto enum_type = typenames_.ResolveTypename("p.IFoo.Inner.Enum");
1496 auto inner_type = typenames_.ResolveTypename("p.IFoo.Inner");
1497 auto ifoo_type = typenames_.ResolveTypename("p.IFoo");
1498 EXPECT_TRUE(enum_type.is_resolved);
1499 EXPECT_TRUE(inner_type.is_resolved);
1500 EXPECT_TRUE(ifoo_type.is_resolved);
1501 // GetParentType()
1502 EXPECT_EQ(inner_type.defined_type, enum_type.defined_type->GetParentType());
1503 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetParentType());
1504 EXPECT_EQ(nullptr, ifoo_type.defined_type->GetParentType());
1505 // GetRootType()
1506 EXPECT_EQ(ifoo_type.defined_type, enum_type.defined_type->GetRootType());
1507 EXPECT_EQ(ifoo_type.defined_type, inner_type.defined_type->GetRootType());
1508 EXPECT_EQ(ifoo_type.defined_type, ifoo_type.defined_type->GetRootType());
1509 // GetDocument()
1510 auto main_document = &typenames_.MainDocument();
1511 EXPECT_EQ(main_document, &enum_type.defined_type->GetDocument());
1512 EXPECT_EQ(main_document, &inner_type.defined_type->GetDocument());
1513 EXPECT_EQ(main_document, &ifoo_type.defined_type->GetDocument());
1514}
1515
Jooyung Han2aedb112021-09-29 09:37:59 +09001516TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedName) {
1517 io_delegate_.SetFileContents("p/IOuter.aidl",
1518 "package p;\n"
1519 "interface IOuter {\n"
1520 " parcelable Inner {}\n"
1521 "}");
1522 import_paths_.emplace("");
1523 const string input_path = "p/IFoo.aidl";
1524 const string input =
1525 "package p;\n"
1526 "interface IFoo {\n"
1527 " p.IOuter.Inner get();\n"
1528 "}";
1529 CaptureStderr();
1530 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1531 EXPECT_EQ(GetCapturedStderr(), "");
1532
1533 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1534}
1535
1536TEST_F(AidlTest, UnderstandsNestedTypesViaFullyQualifiedImport) {
1537 io_delegate_.SetFileContents("p/IOuter.aidl",
1538 "package p;\n"
1539 "interface IOuter {\n"
1540 " parcelable Inner {}\n"
1541 "}");
1542 import_paths_.emplace("");
1543 const string input_path = "p/IFoo.aidl";
1544 const string input =
1545 "package p;\n"
1546 "import p.IOuter.Inner;"
1547 "interface IFoo {\n"
1548 " Inner get();\n"
1549 "}";
1550 CaptureStderr();
1551 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1552 EXPECT_EQ(GetCapturedStderr(), "");
1553
1554 EXPECT_TRUE(typenames_.ResolveTypename("p.IOuter.Inner").is_resolved);
1555}
1556
1557TEST_F(AidlTest, UnderstandsNestedTypesInTheSameScope) {
1558 const string input_path = "p/IFoo.aidl";
1559 const string input =
1560 "package p;\n"
1561 "interface IFoo {\n"
1562 " parcelable Result {}\n"
1563 " Result get();\n"
1564 "}";
1565 CaptureStderr();
1566 EXPECT_NE(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1567 EXPECT_EQ(GetCapturedStderr(), "");
1568
1569 EXPECT_TRUE(typenames_.ResolveTypename("p.IFoo.Result").is_resolved);
1570}
1571
1572// Finding the type of nested named member.
1573struct TypeFinder : AidlVisitor {
1574 string name;
1575 const AidlTypeSpecifier* type = nullptr;
1576 TypeFinder(std::string name) : name(name) {}
1577 void Visit(const AidlVariableDeclaration& v) override {
1578 if (v.GetName() == name) {
1579 type = &v.GetType();
1580 }
1581 }
1582 void Visit(const AidlMethod& m) override {
1583 if (m.GetName() == name) {
1584 type = &m.GetType();
1585 }
1586 }
1587 static string Get(const AidlDefinedType& type, const string& name) {
1588 TypeFinder v(name);
1589 VisitTopDown(v, type);
1590 return v.type ? v.type->Signature() : "(null)";
1591 };
1592};
1593
1594TEST_F(AidlTest, UnderstandsNestedTypesViaQualifiedInTheSameScope) {
1595 io_delegate_.SetFileContents("q/IBar.aidl",
1596 "package q;\n"
1597 "interface IBar {\n"
1598 " parcelable Baz {}\n"
1599 "}");
1600 import_paths_.emplace("");
1601 const string input_path = "p/IFoo.aidl";
1602 const string input =
1603 "package p;\n"
1604 "import q.IBar;\n"
1605 "interface IFoo {\n"
1606 " parcelable Nested {\n"
1607 " Baz t1;\n"
1608 " }\n"
1609 " parcelable Baz { }\n"
1610 " IBar.Baz t2();\n"
1611 " Baz t3();\n"
1612 "}";
1613 CaptureStderr();
1614 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1615 EXPECT_EQ(GetCapturedStderr(), "");
1616 ASSERT_NE(nullptr, foo);
1617
1618 EXPECT_EQ(TypeFinder::Get(*foo, "t1"), "p.IFoo.Baz");
1619 EXPECT_EQ(TypeFinder::Get(*foo, "t2"), "q.IBar.Baz");
1620 EXPECT_EQ(TypeFinder::Get(*foo, "t3"), "p.IFoo.Baz");
1621}
1622
1623TEST_F(AidlTest, RejectsNestedTypesWithParentsName) {
1624 const string input_path = "p/Foo.aidl";
1625 const string input =
1626 "package p;\n"
1627 "parcelable Foo {\n"
1628 " parcelable Foo {}\n"
1629 "}";
1630 CaptureStderr();
1631 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1632 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Nested type 'Foo' has the same name as its parent."));
1633}
1634
Jooyung Han2b1487d2021-09-30 09:57:01 +09001635TEST_F(AidlTest, RejectUnstructuredParcelableAsNestedTypes) {
1636 const string input_path = "p/IFoo.aidl";
1637 const string input =
1638 "package p;\n"
1639 "interface IFoo {\n"
1640 " parcelable Bar cpp_header \"Bar.h\";\n"
1641 "}";
1642 CaptureStderr();
1643 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1644 EXPECT_THAT(GetCapturedStderr(),
1645 HasSubstr("Unstructured parcelables should be at the root scope"));
1646}
1647
Jooyung Han7fc5de02021-09-30 22:26:27 +09001648TEST_F(AidlTest, RejectGenericTypeWithNestedTypes) {
1649 const string input_path = "p/Foo.aidl";
1650 const string input =
1651 "package p;\n"
1652 "parcelable Foo<T> {\n"
1653 " parcelable Bar {}\n"
1654 "}";
1655 CaptureStderr();
1656 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1657 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Generic types can't have nested types."));
1658}
1659
Jooyung Han8a2d9ac2021-09-30 09:47:49 +09001660TEST_F(AidlTest, HandleSyntaxErrorsInNestedDecl) {
1661 const string input_path = "p/IFoo.aidl";
1662 const string input =
1663 "package p;\n"
1664 "interface IFoo {\n"
1665 " parcelable;\n" // missing identifier
1666 "}";
1667 CaptureStderr();
1668 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1669 EXPECT_THAT(GetCapturedStderr(), HasSubstr("expecting identifier"));
1670}
1671
Jooyung Han2aedb112021-09-29 09:37:59 +09001672TEST_F(AidlTest, RejectsNestedTypesWithDuplicateNames) {
1673 const string input_path = "p/Foo.aidl";
1674 const string input =
1675 "package p;\n"
1676 "interface Foo {\n"
1677 " parcelable Bar {}\n"
1678 " parcelable Bar {}\n"
1679 "}";
1680 CaptureStderr();
1681 EXPECT_EQ(nullptr, Parse(input_path, input, typenames_, Options::Language::CPP));
1682 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Redefinition of 'Bar'"));
1683}
1684
1685TEST_F(AidlTest, TypeResolutionWithMultipleLevelsOfNesting) {
1686 struct Failure {
1687 string err;
1688 };
1689 struct TestCase {
1690 string type;
1691 variant<string, Failure> expected; // success<0> or failure<1>
1692 };
1693 vector<TestCase> cases = {
1694 {"foo.A", "foo.A"},
1695 {"foo.A.B", "foo.A.B"},
1696 {"@nullable(heap=true) A", "foo.A.B.A"},
1697 // In the scope of foo.A.B.A, B is resolved to A.B.A.B first.
1698 {"B.A", Failure{"Failed to resolve 'B.A'"}},
1699 {"B", "foo.A.B.A.B"},
1700 {"A.B", "foo.A.B.A.B"},
1701 };
1702 const string input_path = "foo/A.aidl";
1703 for (auto& [type, expected] : cases) {
1704 AidlTypenames typenames;
1705 // clang-format off
1706 const string input =
1707 "package foo;\n"
1708 "parcelable A {\n"
1709 " parcelable B {\n"
1710 " parcelable A {\n"
1711 " parcelable B {\n"
1712 " }\n"
1713 " " + type + " m;\n"
1714 " }\n"
1715 " }\n"
1716 "}";
1717 // clang-format on
1718 CaptureStderr();
1719 auto foo = Parse(input_path, input, typenames, Options::Language::CPP);
1720 if (auto failure = std::get_if<Failure>(&expected); failure) {
1721 ASSERT_EQ(nullptr, foo);
1722 EXPECT_THAT(GetCapturedStderr(), HasSubstr(failure->err));
1723 } else {
1724 EXPECT_EQ(GetCapturedStderr(), "");
1725 ASSERT_NE(nullptr, foo);
1726 EXPECT_EQ(TypeFinder::Get(*foo, "m"), std::get<string>(expected));
1727 }
1728 }
1729}
1730
Jooyung Hanca84b032021-09-30 02:15:59 +09001731TEST_F(AidlTest, HeaderForNestedTypeShouldPointToTopMostParent) {
1732 const string input_path = "p/IFoo.aidl";
1733 const string input =
1734 "package p;\n"
1735 "interface IFoo {\n"
1736 " parcelable Result {}\n"
1737 "}";
1738 CaptureStderr();
1739 auto foo = Parse(input_path, input, typenames_, Options::Language::CPP);
1740 ASSERT_NE(nullptr, foo);
1741 EXPECT_EQ(GetCapturedStderr(), "");
1742
1743 auto result = typenames_.ResolveTypename("p.IFoo.Result").defined_type;
1744 ASSERT_NE(nullptr, result);
1745 EXPECT_EQ("p/IFoo.h", cpp::CppHeaderForType(*result));
1746}
1747
Jooyung Han8e9ae872021-10-13 02:52:25 +09001748TEST_F(AidlTest, ReorderNestedTypesForCppOutput) {
1749 const string input_path = "p/IFoo.aidl";
1750 const string input = R"(
1751 package p;
1752 interface IFoo {
1753 // partial orderings for [A, D, G]:
1754 // D - A
1755 // A - G
1756 parcelable A {
1757 // partial orderings for [B, C]:
1758 // C - B
1759 parcelable B {
1760 C c;
1761 D.E d;
1762 }
1763 parcelable C {}
1764 }
1765 parcelable D {
1766 // partial orderings for [E, F]:
1767 // F - E
1768 parcelable E {
1769 F f;
1770 }
1771 parcelable F {}
1772 }
1773 parcelable G {
1774 A.B b;
1775 }
1776 }
1777 )";
1778 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1779 io_delegate_.SetFileContents(input_path, input);
1780 CaptureStderr();
1781 EXPECT_TRUE(compile_aidl(options, io_delegate_));
1782 EXPECT_EQ(GetCapturedStderr(), "");
1783
1784 string code;
1785 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/IFoo.h", &code));
1786 // check partial orderings: a should comes before b
1787 EXPECT_LE(code.find("class D"), code.find("class A"));
1788 EXPECT_LE(code.find("class A"), code.find("class G"));
1789 EXPECT_LE(code.find("class C"), code.find("class B"));
1790 EXPECT_LE(code.find("class F"), code.find("class E"));
1791}
1792
1793TEST_F(AidlTest, RejectsNestedTypesWithCyclicDeps) {
1794 const string input_path = "p/IFoo.aidl";
1795 const string input = R"(
1796 package p;
1797 interface IFoo {
1798 // Cycles:
1799 // D - A
1800 // A - G
1801 // G - D
1802 parcelable A {
1803 parcelable B {
1804 C c;
1805 }
1806 }
1807 parcelable C {
1808 parcelable D {
1809 E e;
1810 }
1811 }
1812 parcelable E {
1813 parcelable F {
1814 A a;
1815 }
1816 }
1817 }
1818 )";
1819 Options options = Options::From("aidl --lang cpp -I. -oout -hout p/IFoo.aidl");
1820 io_delegate_.SetFileContents(input_path, input);
1821 CaptureStderr();
1822 EXPECT_FALSE(compile_aidl(options, io_delegate_));
1823 EXPECT_THAT(GetCapturedStderr(), HasSubstr("IFoo has nested types with cyclic references."));
1824}
1825
Jooyung Han0a950bd2021-05-15 12:50:36 +09001826TEST_F(AidlTest, CppNameOf_GenericType) {
Jooyung Han01720ed2021-08-13 07:46:07 +09001827 const string input_path = "p/Wrapper.aidl";
1828 const string input = "package p; parcelable Wrapper<T> {}";
Jooyung Han0a950bd2021-05-15 12:50:36 +09001829
1830 auto parse_result = Parse(input_path, input, typenames_, Options::Language::CPP);
1831 EXPECT_NE(nullptr, parse_result);
1832
1833 auto type = [](std::string name, auto&&... type_params) -> std::unique_ptr<AidlTypeSpecifier> {
1834 auto params = new std::vector<std::unique_ptr<AidlTypeSpecifier>>;
1835 (..., params->emplace_back(std::move(type_params)));
1836 return std::make_unique<AidlTypeSpecifier>(AIDL_LOCATION_HERE, name, false, params, Comments{});
1837 };
1838
1839 auto set_nullable = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
Steven Morelanda7560e82021-10-08 16:24:39 -07001840 std::vector<std::unique_ptr<AidlAnnotation>> annotations;
1841 annotations.emplace_back(std::unique_ptr<AidlAnnotation>(
1842 AidlAnnotation::Parse(AIDL_LOCATION_HERE, "nullable", {}, {})));
Jooyung Han0a950bd2021-05-15 12:50:36 +09001843 type->Annotate(std::move(annotations));
1844 return std::move(type);
1845 };
1846
1847 auto set_array = [](std::unique_ptr<AidlTypeSpecifier>&& type) {
1848 (void)type->SetArray();
1849 return std::move(type);
1850 };
1851
1852 auto w = type("p.Wrapper", type("String"));
1853 EXPECT_EQ("::p::Wrapper<::android::String16>", cpp::CppNameOf(*w, typenames_));
1854
1855 auto nullable_w = set_nullable(type("p.Wrapper", type("String")));
1856 EXPECT_EQ("::std::optional<::p::Wrapper<::android::String16>>",
1857 cpp::CppNameOf(*nullable_w, typenames_));
1858
1859 auto array_w = set_array(type("p.Wrapper", type("String")));
1860 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1861 cpp::CppNameOf(*array_w, typenames_));
1862
1863 auto nullable_array_w = set_nullable(set_array(type("p.Wrapper", type("String"))));
1864 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1865 cpp::CppNameOf(*nullable_array_w, typenames_));
1866
1867 auto list_w = type("List", type("p.Wrapper", type("String")));
1868 EXPECT_EQ("::std::vector<::p::Wrapper<::android::String16>>",
1869 cpp::CppNameOf(*list_w, typenames_));
1870
1871 auto nullable_list_w = set_nullable(type("List", type("p.Wrapper", type("String"))));
1872 EXPECT_EQ("::std::optional<::std::vector<::std::optional<::p::Wrapper<::android::String16>>>>",
1873 cpp::CppNameOf(*nullable_list_w, typenames_));
1874}
1875
Devin Moore7b8d5c92020-03-17 14:14:08 -07001876TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001877 io_delegate_.SetFileContents(
1878 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001879 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001880 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001881 const string input_path = "p/IFoo.aidl";
1882 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001883 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1884 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001885 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Jooyung Han8451a202021-01-16 03:07:06 +09001886 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, {});
Jooyung Han13f1fa52021-06-11 18:06:12 +09001887 native_type.Resolve(typenames_, parse_result);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001888
1889 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1890 // C++ understands C++ specific stuff
1891 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1892 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001893 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001894 EXPECT_EQ(1u, headers.size());
1895 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001896}
1897
Christopher Wileyf8136192016-04-12 14:19:35 -07001898TEST_F(AidlTest, WritesCorrectDependencyFile) {
1899 // While the in tree build system always gives us an output file name,
1900 // other android tools take advantage of our ability to infer the intended
1901 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001902 vector<string> args = {
1903 "aidl",
1904 "-d dep/file/path",
1905 "-o place/for/output",
1906 "p/IFoo.aidl"};
1907 Options options = Options::From(args);
1908 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001909 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001910 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001911 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001912 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1913}
1914
Dan Willemsen93298ee2016-11-10 23:55:55 -08001915TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1916 // While the in tree build system always gives us an output file name,
1917 // other android tools take advantage of our ability to infer the intended
1918 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001919 vector<string> args = {
1920 "aidl",
1921 "-d dep/file/path",
1922 "--ninja",
1923 "-o place/for/output",
1924 "p/IFoo.aidl"};
1925 Options options = Options::From(args);
1926 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Steven Moreland4e059132021-08-11 13:36:30 -07001927 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001928 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001929 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001930 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1931}
1932
Jiyong Parkdf202122019-09-30 20:48:35 +09001933TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001934 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1935 // this by calling aidl with every .aidl file it finds, then parsing the
1936 // generated dependency files. Those that reference .java output files are
1937 // for interfaces and those that do not are parcelables. However, for both
1938 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001939 vector<string> args = {
1940 "aidl",
1941 "-o place/for/output",
1942 "-d dep/file/path",
1943 "p/Foo.aidl"};
1944 Options options = Options::From(args);
1945 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001946 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001947 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001948 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001949 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1950}
1951
1952TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1953 vector<string> args = {
1954 "aidl",
1955 "--structured",
1956 "-o place/for/output",
1957 "-d dep/file/path",
1958 "p/Foo.aidl"};
1959 Options options = Options::From(args);
1960 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
Steven Moreland4e059132021-08-11 13:36:30 -07001961 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkdf202122019-09-30 20:48:35 +09001962 string actual_dep_file_contents;
1963 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1964 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001965}
1966
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001967TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1968 vector<string> args = {
1969 "aidl",
1970 "--lang=java",
1971 "-o place/for/output",
1972 "p/Foo.aidl"};
1973 Options options = Options::From(args);
1974 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Steven Moreland4e059132021-08-11 13:36:30 -07001975 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001976 string output_file_contents;
1977 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1978}
1979
Devin Moore21b26772020-08-26 16:37:56 -07001980TEST_P(AidlTest, RejectsListArray) {
Jooyung Han49b8f362021-10-15 10:58:02 +09001981 const string input = "package a; parcelable Foo { List<String>[] lists; }";
Devin Moore21b26772020-08-26 16:37:56 -07001982 CaptureStderr();
Jooyung Han49b8f362021-10-15 10:58:02 +09001983 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", input, typenames_, GetLanguage()));
1984 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Arrays of List are not supported"));
Devin Moore21b26772020-08-26 16:37:56 -07001985}
1986
Jiyong Parkf8d53612020-05-04 14:06:13 +09001987TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1988 AidlError error;
1989 string expected_stderr =
1990 "ERROR: a/IFoo.aidl:2.7-11: "
1991 "Encountered an untyped List or Map. The use of untyped List/Map is "
1992 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1993 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1994 if (GetLanguage() != Options::Language::JAVA) {
1995 expected_stderr =
1996 "ERROR: a/IFoo.aidl:2.1-7: "
1997 "Currently, only the Java backend supports non-generic List.\n";
1998 }
1999
2000 const string primitive_interface =
2001 "package a; interface IFoo {\n"
2002 " List foo(); }";
2003 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002004 AidlTypenames tn1;
2005 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002006 {"--structured"}));
2007 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09002008
2009 string primitive_parcelable =
2010 "package a; parcelable IFoo {\n"
2011 " List foo;}";
2012 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09002013 AidlTypenames tn2;
2014 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09002015 {"--structured"}));
2016 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2017}
2018
Jeongik Cha225519b2020-08-29 01:55:32 +09002019TEST_P(AidlTest, ExtensionTest) {
2020 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002021 string extendable_parcelable =
2022 "package a; parcelable Data {\n"
2023 " ParcelableHolder extension;\n"
2024 " ParcelableHolder extension2;\n"
2025 "}";
Andrei Homescub2316a52021-09-04 04:41:12 +00002026 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
2027 EXPECT_EQ("", GetCapturedStderr());
Jeongik Cha225519b2020-08-29 01:55:32 +09002028}
2029TEST_P(AidlTest, ParcelableHolderAsReturnType) {
2030 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002031 string parcelableholder_return_interface =
2032 "package a; interface IFoo {\n"
2033 " ParcelableHolder foo();\n"
2034 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002035 EXPECT_EQ(nullptr,
2036 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09002037
Jeongik Cha225519b2020-08-29 01:55:32 +09002038 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
2039 GetCapturedStderr());
2040}
2041
2042TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
2043 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09002044 string extendable_parcelable_arg_interface =
2045 "package a; interface IFoo {\n"
2046 " void foo(in ParcelableHolder ph);\n"
2047 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09002048 EXPECT_EQ(nullptr,
2049 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
2050
Jeongik Cha225519b2020-08-29 01:55:32 +09002051 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
2052 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09002053}
2054
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002055TEST_P(AidlTest, RejectNullableParcelableHolderField) {
2056 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002057 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002058 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
2059 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002060 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaf6ec8982020-10-15 00:10:30 +09002061 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2062}
2063
Jooyung Han3f347ca2020-12-01 12:41:50 +09002064TEST_P(AidlTest, ParcelablesWithConstants) {
2065 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002066 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002067 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002068 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002069 EXPECT_EQ("", GetCapturedStderr());
2070}
2071
2072TEST_P(AidlTest, UnionWithConstants) {
2073 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09002074 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002075 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002076 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09002077 EXPECT_EQ("", GetCapturedStderr());
2078}
2079
Jooyung Han633eab62021-01-07 14:12:40 +09002080TEST_F(AidlTest, ConstantsWithAnnotations) {
2081 io_delegate_.SetFileContents("IFoo.aidl",
2082 "interface IFoo {\n"
2083 " @JavaPassthrough(annotation=\"@Foo\")\n"
2084 " const @JavaPassthrough(annotation=\"@Bar\") int FOO = 0;\n"
2085 "}");
2086 Options options = Options::From("aidl IFoo.aidl --lang=java -o out");
2087 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002088 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han633eab62021-01-07 14:12:40 +09002089 EXPECT_EQ("", GetCapturedStderr());
2090 string code;
2091 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/IFoo.java", &code));
2092 EXPECT_THAT(code, HasSubstr("@Foo\n"));
2093 EXPECT_THAT(code, HasSubstr("@Bar\n"));
2094}
2095
Jiyong Park02da7422018-07-16 16:00:26 +09002096TEST_F(AidlTest, ApiDump) {
2097 io_delegate_.SetFileContents(
2098 "foo/bar/IFoo.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002099 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002100 "package foo.bar;\n"
2101 "import foo.bar.Data;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002102 "// commented /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002103 "interface IFoo {\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002104 " /* @hide applied \n"
2105 " @deprecated use foo2 */\n"
2106 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
2107 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002108 " IFoo foo3(IFoo foo);\n"
2109 " Data getData();\n"
Jooyung Han161bb0f2021-01-21 12:30:16 +09002110 " // @hide not applied\n"
Jooyung Han9fd67022021-01-13 10:49:48 +09002111 " /** blahblah\n"
2112 " @deprecated\n"
2113 " reason why... */\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002114 " const int A = 1;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002115 " // @deprecated tags in line comments are ignored\n"
Jiyong Parka428d212018-08-29 22:26:30 +09002116 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002117 "}\n");
2118 io_delegate_.SetFileContents("foo/bar/Data.aidl",
Steven Moreland75968602021-10-13 18:10:32 -07002119 "// comment\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002120 "package foo.bar;\n"
2121 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002122 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002123 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002124 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09002125 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002126 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002127 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09002128 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09002129 " IFoo foo;\n"
Jooyung Han24effbf2021-01-16 10:24:03 +09002130 " // Ignore @hide property in line comment\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002131 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09002132 "}\n");
2133 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09002134 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
2135 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002136 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09002137 bool result = dump_api(options, io_delegate_);
2138 ASSERT_TRUE(result);
2139 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002140 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002141 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002142interface IFoo {
Jooyung Han161bb0f2021-01-21 12:30:16 +09002143 /**
2144 * @hide
2145 * @deprecated use foo2
2146 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002147 int foo(out int[] a, String b, boolean c, inout List<String> d);
2148 int foo2(@utf8InCpp String x, inout List<String> y);
2149 foo.bar.IFoo foo3(foo.bar.IFoo foo);
2150 foo.bar.Data getData();
Jooyung Han161bb0f2021-01-21 12:30:16 +09002151 /**
2152 * @deprecated reason why...
2153 */
Jiyong Parke59c3682018-09-11 23:10:25 +09002154 const int A = 1;
2155 const String STR = "Hello";
2156}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002157)"),
2158 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002159
Jiyong Parke59c3682018-09-11 23:10:25 +09002160 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Steven Moreland75968602021-10-13 18:10:32 -07002161 EXPECT_EQ(string("// comment\n").append(string(kPreamble)).append(R"(package foo.bar;
Jooyung Han8db65942021-03-02 18:14:44 +09002162/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09002163parcelable Data {
2164 int x = 10;
2165 int y;
2166 foo.bar.IFoo foo;
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002167 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09002168}
Jooyung Han161bb0f2021-01-21 12:30:16 +09002169)"),
2170 actual);
Jiyong Park02da7422018-07-16 16:00:26 +09002171}
2172
Jiyong Parked65bf42018-08-28 15:43:27 +09002173TEST_F(AidlTest, ApiDumpWithManualIds) {
2174 io_delegate_.SetFileContents(
2175 "foo/bar/IFoo.aidl",
2176 "package foo.bar;\n"
2177 "interface IFoo {\n"
2178 " int foo() = 1;\n"
2179 " int bar() = 2;\n"
2180 " int baz() = 10;\n"
2181 "}\n");
2182
Jiyong Parke59c3682018-09-11 23:10:25 +09002183 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002184 Options options = Options::From(args);
2185 bool result = dump_api(options, io_delegate_);
2186 ASSERT_TRUE(result);
2187 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09002188 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09002189 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09002190interface IFoo {
2191 int foo() = 1;
2192 int bar() = 2;
2193 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09002194}
Paul Trautrimb01451d2020-02-27 13:10:16 +09002195)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09002196}
2197
2198TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002199 const string expected_stderr =
2200 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
2201 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09002202 io_delegate_.SetFileContents(
2203 "foo/bar/IFoo.aidl",
2204 "package foo.bar;\n"
2205 "interface IFoo {\n"
2206 " int foo() = 1;\n"
2207 " int bar();\n"
2208 " int baz() = 10;\n"
2209 "}\n");
2210
Jiyong Parke59c3682018-09-11 23:10:25 +09002211 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09002212 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07002213 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002214 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002216}
2217
Jooyung Han965e31d2020-11-27 12:30:16 +09002218TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
2219 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
2220 "package foo.bar;\n"
2221 "interface IFoo {\n"
2222 " @utf8InCpp String foo();\n"
2223 " const @utf8InCpp String bar = \"bar\";\n"
2224 "}\n");
2225
2226 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
2227 Options options = Options::From(args);
2228 CaptureStderr();
2229 EXPECT_TRUE(dump_api(options, io_delegate_));
2230 EXPECT_EQ("", GetCapturedStderr());
2231 string actual;
2232 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09002233 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
2234interface IFoo {
2235 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09002236 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09002237}
2238)"),
2239 actual);
2240}
2241
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002242TEST_F(AidlTest, ApiDumpWithEnums) {
2243 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2244 "package foo.bar;\n"
2245 "enum Enum {\n"
2246 " FOO,\n"
2247 " BAR = FOO + 1,\n"
2248 "}\n");
2249
2250 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
2251 Options options = Options::From(args);
2252 CaptureStderr();
2253 EXPECT_TRUE(dump_api(options, io_delegate_));
2254 EXPECT_EQ("", GetCapturedStderr());
2255 string actual;
2256 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
2257 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2258 "enum Enum {\n"
2259 " FOO = 0,\n"
2260 " BAR = 1,\n"
2261 "}\n"),
2262 actual);
2263}
2264
2265TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
2266 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
2267 "package foo.bar;\n"
2268 "enum Enum {\n"
2269 " FOO,\n"
2270 "}\n");
2271 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2272 "package foo.bar;\n"
2273 "import foo.bar.Enum;\n"
2274 "parcelable Foo {\n"
2275 " Enum e = Enum.FOO;\n"
2276 "}\n");
2277
2278 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2279 Options options = Options::From(args);
2280 CaptureStderr();
2281 EXPECT_TRUE(dump_api(options, io_delegate_));
2282 EXPECT_EQ("", GetCapturedStderr());
2283 string actual;
2284 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2285 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2286 "parcelable Foo {\n"
2287 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
2288 "}\n"),
2289 actual);
2290}
2291
Jooyung Han71dfec32021-05-23 07:18:58 +09002292TEST_F(AidlTest, ApiDumpWithGenerics) {
2293 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
2294 "package foo.bar;\n"
2295 "parcelable Foo<T, U> {\n"
2296 "}\n");
2297
2298 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
2299 Options options = Options::From(args);
2300 CaptureStderr();
2301 EXPECT_TRUE(dump_api(options, io_delegate_));
2302 EXPECT_EQ("", GetCapturedStderr());
2303 string actual;
2304 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
2305 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
2306 "parcelable Foo<T, U> {\n"
2307 "}\n"),
2308 actual);
2309}
2310
Jooyung Hand9ee6f02021-09-13 17:27:24 +09002311TEST_F(AidlTest, ImportedDocumentHasDuplicateDefinitions) {
2312 io_delegate_.SetFileContents("IFoo.aidl", "interface IFoo; interface IFoo;\n");
2313 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { CONST = IFoo.NONE }\n");
2314
2315 vector<string> args = {"aidl", "--dumpapi", "-I.", "-o out", "Bar.aidl"};
2316 Options options = Options::From(args);
2317 CaptureStderr();
2318 EXPECT_FALSE(dump_api(options, io_delegate_));
2319 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Can't find NONE in IFoo"));
2320}
2321
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002322TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002323 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00002324 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
2325 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002326 const string expected_map_stderr =
2327 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002328 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2329 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002330 "package p; interface IFoo {"
2331 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002333 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002334 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002335
Jiyong Park6f77e0c2018-07-28 16:55:44 +09002336 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002337 "package p; interface IFoo {"
2338 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002339 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002340 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002341 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002342}
2343
Jeongik Chae48d9942020-01-02 17:39:00 +09002344TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002345 const string expected_stderr =
2346 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jooyung Han13f1fa52021-06-11 18:06:12 +09002347 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chae48d9942020-01-02 17:39:00 +09002348 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
2349
2350 io_delegate_.SetFileContents("p/IFoo.aidl",
2351 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002352 "Map<String, p.Bar> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002353 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002354
2355 io_delegate_.SetFileContents("p/IFoo.aidl",
2356 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002357 "Map<p.Bar, p.Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002358 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002359 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002360 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09002361
2362 io_delegate_.SetFileContents("p/IFoo.aidl",
2363 "package p; interface IFoo {"
2364 "Map<String, String> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002365 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002366
2367 io_delegate_.SetFileContents("p/IFoo.aidl",
2368 "package p; interface IFoo {"
2369 "Map<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002370 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae48d9942020-01-02 17:39:00 +09002371}
2372
Jeongik Chadf76dc72019-11-28 00:08:47 +09002373TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09002375 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
2376 io_delegate_.SetFileContents(options.InputFiles().front(),
2377 "package p; interface IFoo {"
2378 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002380 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002382}
2383
2384TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
Jooyung Han13f1fa52021-06-11 18:06:12 +09002385 Options optionsForParcelable = Options::From("aidl -I . p/Bar.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002386 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002387 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002388 EXPECT_FALSE(compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002389 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
2390 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09002391
Jooyung Han13f1fa52021-06-11 18:06:12 +09002392 Options options = Options::From("aidl -I . p/IFoo.aidl");
Jeongik Chadf76dc72019-11-28 00:08:47 +09002393 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
2394 io_delegate_.SetFileContents("p/IFoo.aidl",
2395 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002396 "p.Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002397 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002398 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002399 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar is not a generic type"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002400 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07002401 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002402 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han13f1fa52021-06-11 18:06:12 +09002403 EXPECT_THAT(GetCapturedStderr(), HasSubstr("p.Bar must have 1 type parameters, but got 2"));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002404 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
Steven Moreland4e059132021-08-11 13:36:30 -07002405 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002406 io_delegate_.SetFileContents("p/IFoo.aidl",
2407 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002408 "p.Bar<String, ParcelFileDescriptor> foo();}");
Steven Moreland4e059132021-08-11 13:36:30 -07002409 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09002410
2411 io_delegate_.SetFileContents("p/IFoo.aidl",
2412 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002413 "p.Bar<int, long> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002414
2415 io_delegate_.SetFileContents("p/IFoo.aidl",
2416 "package p; interface IFoo {"
Jooyung Han13f1fa52021-06-11 18:06:12 +09002417 "p.Bar<int[], long[]> foo();}");
Jeongik Chae74c86d2019-12-12 16:54:03 +09002418
Steven Moreland4e059132021-08-11 13:36:30 -07002419 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09002420}
2421
Jeongik Cha0e426012019-07-29 15:57:02 +09002422TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
2423 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07002424 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
2425 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07002426 for (const auto& rawOption : rawOptions) {
2427 string expected_stderr =
2428 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002429 Options options = Options::From(rawOption);
2430 io_delegate_.SetFileContents(options.InputFiles().front(),
2431 "package foo.bar;\n"
2432 "interface IFoo1 { int foo(); }\n"
2433 "interface IFoo2 { int foo(); }\n"
2434 "parcelable Data1 { int a; int b;}\n"
2435 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002436 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002437 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002439
Jeongik Cha0e426012019-07-29 15:57:02 +09002440 io_delegate_.SetFileContents(options.InputFiles().front(),
2441 "package foo.bar;\n"
2442 "interface IFoo1 { int foo(); }\n"
2443 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002444 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002445 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002446 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002447
Devin Moore5de18ed2020-04-02 13:52:29 -07002448 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09002449 io_delegate_.SetFileContents(options.InputFiles().front(),
2450 "package foo.bar;\n"
2451 "parcelable Data1 { int a; int b;}\n"
2452 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002454 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09002456 }
2457}
2458
Devin Moorebdba2a82020-03-31 15:19:02 -07002459TEST_P(AidlTest, FailParseOnEmptyFile) {
2460 const string contents = "";
2461 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
2462 CaptureStderr();
2463 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
2464 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2465}
2466
Jiyong Parkb034bf02018-07-30 17:44:33 +09002467TEST_F(AidlTest, MultipleInputFiles) {
2468 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09002469 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002470
2471 io_delegate_.SetFileContents(options.InputFiles().at(0),
2472 "package foo.bar;\n"
2473 "import foo.bar.Data;\n"
2474 "interface IFoo { Data getData(); }\n");
2475
2476 io_delegate_.SetFileContents(options.InputFiles().at(1),
2477 "package foo.bar;\n"
2478 "import foo.bar.IFoo;\n"
2479 "parcelable Data { IFoo foo; }\n");
2480
Steven Moreland4e059132021-08-11 13:36:30 -07002481 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002482
2483 string content;
2484 for (const auto file : {
2485 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
2486 content.clear();
2487 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2488 EXPECT_FALSE(content.empty());
2489 }
2490}
2491
2492TEST_F(AidlTest, MultipleInputFilesCpp) {
2493 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09002494 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09002495
2496 io_delegate_.SetFileContents(options.InputFiles().at(0),
2497 "package foo.bar;\n"
2498 "import foo.bar.Data;\n"
2499 "interface IFoo { Data getData(); }\n");
2500
2501 io_delegate_.SetFileContents(options.InputFiles().at(1),
2502 "package foo.bar;\n"
2503 "import foo.bar.IFoo;\n"
2504 "parcelable Data { IFoo foo; }\n");
2505
Steven Moreland4e059132021-08-11 13:36:30 -07002506 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkb034bf02018-07-30 17:44:33 +09002507
2508 string content;
2509 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09002510 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09002511 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
2512 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
2513 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
2514 content.clear();
2515 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2516 EXPECT_FALSE(content.empty());
2517 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09002518}
2519
Andrei Homescub62afd92020-05-11 19:24:59 -07002520TEST_F(AidlTest, MultipleInputFilesRust) {
2521 Options options =
2522 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
2523
2524 io_delegate_.SetFileContents(options.InputFiles().at(0),
2525 "package foo.bar;\n"
2526 "import foo.bar.Data;\n"
2527 "interface IFoo { Data getData(); }\n");
2528
2529 io_delegate_.SetFileContents(options.InputFiles().at(1),
2530 "package foo.bar;\n"
2531 "import foo.bar.IFoo;\n"
2532 "parcelable Data { IFoo foo; }\n");
2533
Steven Moreland4e059132021-08-11 13:36:30 -07002534 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002535
2536 string content;
2537 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
2538 content.clear();
2539 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
2540 EXPECT_FALSE(content.empty());
2541 }
2542}
2543
Devin Moore097a3ab2020-03-11 16:08:44 -07002544TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
2545 const string expected_stderr =
2546 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09002547 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
2548 // int getInterfaceVersion() is one of the meta transactions
2549 io_delegate_.SetFileContents(options.InputFiles().front(),
2550 "package p; interface IFoo {"
2551 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002552 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002553 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002554 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2555}
Jiyong Park309668e2018-07-28 16:55:44 +09002556
Devin Moore097a3ab2020-03-11 16:08:44 -07002557TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
2558 // boolean getInterfaceVersion() is not a meta transaction, but should be
2559 // prevented because return type is not part of a method signature
2560 const string expected_stderr =
2561 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
2562 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002563 io_delegate_.SetFileContents(options.InputFiles().front(),
2564 "package p; interface IFoo {"
2565 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002566 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002567 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002568 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2569}
Jiyong Park309668e2018-07-28 16:55:44 +09002570
Devin Moore097a3ab2020-03-11 16:08:44 -07002571TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09002572 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07002573 const string expected_stderr =
2574 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
2575 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09002576 io_delegate_.SetFileContents(options.InputFiles().front(),
2577 "package p; interface IFoo {"
2578 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002579 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07002580 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09002582
2583 // this is not a meta interface method as it differs type arguments
2584 io_delegate_.SetFileContents(options.InputFiles().front(),
2585 "package p; interface IFoo {"
2586 "String getTransactionName(); }");
Steven Moreland4e059132021-08-11 13:36:30 -07002587 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09002588}
2589
Jooyung Hanb8a97772021-01-19 01:27:38 +09002590TEST_F(AidlTest, CheckApiForEquality) {
2591 CaptureStderr();
2592 Options options = Options::From("aidl --checkapi=equal old new");
2593
2594 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2595 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2596 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2597 "package p; interface IFoo{ @utf8InCpp String foo();}");
2598
2599 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
2600 EXPECT_THAT(GetCapturedStderr(), HasSubstr("+ @utf8InCpp String foo();"));
2601}
2602
Daniel Norman85aed542019-08-21 12:01:14 -07002603TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09002604 Options options = Options::From("aidl --checkapi old new");
2605 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2606 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
2607 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2608 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
2609
2610 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2611}
2612
Jiyong Park3656c3c2018-08-01 20:02:01 +09002613TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002614 Options options = Options::From("aidl --checkapi old new");
2615 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
2616 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09002617
2618 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2619}
2620
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09002621TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
2622 Options options = Options::From("aidl --checkapi old new");
2623 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2624 const string enum_definition = "package p; enum Enum { FOO }";
2625 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2626 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2627 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2628 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2629
2630 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2631}
2632
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002633TEST_F(AidlTest, CheckApi_EnumFieldsFromImported) {
2634 Options options = Options::From("aidl --checkapi old new -I import");
2635
2636 io_delegate_.SetFileContents("old/p/Foo.aidl", "package p; parcelable Foo{ other.Enum e; }");
2637 io_delegate_.SetFileContents("new/p/Foo.aidl",
2638 "package p; parcelable Foo{ other.Enum e = other.Enum.FOO; }");
2639 io_delegate_.SetFileContents("import/other/Enum.aidl", "package other; enum Enum { FOO }");
2640
2641 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2642}
2643
Jooyung Han02a11be2021-02-11 13:18:06 +09002644TEST_F(AidlTest, CheckApiEqual_EnumFieldsWithDefaultValues) {
2645 Options options = Options::From("aidl --checkapi=equal old new");
2646 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
2647 const string enum_definition = "package p; enum Enum { FOO }";
2648 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
2649 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
2650 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
2651 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
2652 CaptureStderr();
2653 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2654 EXPECT_EQ("", GetCapturedStderr());
2655}
2656
Daniel Norman85aed542019-08-21 12:01:14 -07002657class AidlTestCompatibleChanges : public AidlTest {
2658 protected:
2659 Options options_ = Options::From("aidl --checkapi old new");
2660};
2661
2662TEST_F(AidlTestCompatibleChanges, NewType) {
2663 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2664 "package p;"
2665 "interface IFoo {"
2666 " void foo(int a);"
2667 "}");
2668 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2669 "package p;"
2670 "interface IFoo {"
2671 " void foo(int a);"
2672 "}");
2673 io_delegate_.SetFileContents("new/p/IBar.aidl",
2674 "package p;"
2675 "interface IBar {"
2676 " void bar();"
2677 "}");
2678 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2679}
2680
2681TEST_F(AidlTestCompatibleChanges, NewMethod) {
2682 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2683 "package p;"
2684 "interface IFoo {"
2685 " void foo(int a);"
2686 "}");
2687 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2688 "package p;"
2689 "interface IFoo {"
2690 " void foo(int a);"
2691 " void bar();"
Jooyung Han8e3b72c2021-05-22 02:54:37 +09002692 " void baz(in List<String> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07002693 "}");
2694 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2695}
2696
2697TEST_F(AidlTestCompatibleChanges, NewField) {
2698 io_delegate_.SetFileContents("old/p/Data.aidl",
2699 "package p;"
2700 "parcelable Data {"
2701 " int foo;"
2702 "}");
2703 io_delegate_.SetFileContents("new/p/Data.aidl",
2704 "package p;"
2705 "parcelable Data {"
2706 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002707 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002708 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002709 "}");
2710 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2711}
2712
Jooyung Han05bd8a82021-04-28 23:56:38 +09002713TEST_F(AidlTestCompatibleChanges, NewField2) {
2714 io_delegate_.SetFileContents("old/p/Data.aidl",
2715 "package p;"
2716 "parcelable Data {"
2717 "}");
2718 io_delegate_.SetFileContents("new/p/Data.aidl",
2719 "package p;"
2720 "parcelable Data {"
2721 " int foo = 0;"
2722 "}");
2723 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2724}
2725
Daniel Norman85aed542019-08-21 12:01:14 -07002726TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2727 io_delegate_.SetFileContents("old/p/Enum.aidl",
2728 "package p;"
2729 "enum Enum {"
2730 " FOO = 1,"
2731 "}");
2732 io_delegate_.SetFileContents("new/p/Enum.aidl",
2733 "package p;"
2734 "enum Enum {"
2735 " FOO = 1,"
2736 " BAR = 2,"
2737 "}");
2738 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2739}
2740
2741TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2742 io_delegate_.SetFileContents("old/p/Enum.aidl",
2743 "package p;"
2744 "enum Enum {"
2745 " FOO = 1,"
2746 " BAR = 2,"
2747 "}");
2748 io_delegate_.SetFileContents("new/p/Enum.aidl",
2749 "package p;"
2750 "enum Enum {"
2751 " BAR = 2,"
2752 " FOO = 1,"
2753 "}");
2754 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2755}
2756
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002757TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2758 io_delegate_.SetFileContents("old/p/Union.aidl",
2759 "package p;"
2760 "union Union {"
2761 " String foo;"
2762 "}");
2763 io_delegate_.SetFileContents("new/p/Union.aidl",
2764 "package p;"
2765 "union Union {"
2766 " String foo;"
2767 " int num;"
2768 "}");
2769 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2770}
2771
Daniel Norman85aed542019-08-21 12:01:14 -07002772TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002773 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2774 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002775 "interface IFoo {"
2776 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002777 "}");
2778 io_delegate_.SetFileContents("old/p/Data.aidl",
2779 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002780 "parcelable Data {"
2781 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002782 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002783 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2784 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002785 "interface IFoo {"
2786 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002787 "}");
2788 io_delegate_.SetFileContents("new/p/Data.aidl",
2789 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002790 "parcelable Data {"
2791 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002792 "}");
2793 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2794 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002795 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002796 " void foo(int a);"
2797 "}");
2798 io_delegate_.SetFileContents("new/q/Data.aidl",
2799 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002800 "parcelable Data {"
2801 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002802 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002803 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2804}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002805
Daniel Norman85aed542019-08-21 12:01:14 -07002806TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2807 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2808 "package p;"
2809 "interface IFoo {"
2810 " void foo(int a);"
2811 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002812 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2813 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002814 "interface IFoo {"
2815 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002816 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002817 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2818}
Jiyong Parke59c3682018-09-11 23:10:25 +09002819
Daniel Norman85aed542019-08-21 12:01:14 -07002820TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002821 io_delegate_.SetFileContents("old/p/I.aidl",
2822 "package p; interface I {"
2823 "const int A = 1; }");
2824 io_delegate_.SetFileContents("new/p/I.aidl",
2825 "package p ; interface I {"
2826 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002827 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2828}
Jiyong Parka428d212018-08-29 22:26:30 +09002829
Daniel Norman85aed542019-08-21 12:01:14 -07002830TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002831 io_delegate_.SetFileContents("old/p/I.aidl",
2832 "package p; interface I {"
2833 "const int A = 1; const int B = 2;}");
2834 io_delegate_.SetFileContents("new/p/I.aidl",
2835 "package p ; interface I {"
2836 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002837 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002838}
2839
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002840TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2841 io_delegate_.SetFileContents("old/p/Foo.aidl",
2842 "package p;"
2843 "@JavaPassthrough(annotation=\"Alice\")"
2844 "@JavaPassthrough(annotation=\"Bob\")"
2845 "parcelable Foo {}");
2846 io_delegate_.SetFileContents("new/p/Foo.aidl",
2847 "package p;"
2848 "@JavaPassthrough(annotation=\"Bob\")"
2849 "@JavaPassthrough(annotation=\"Alice\")"
2850 "parcelable Foo {}");
2851 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2852}
2853
Jooyung Han00073272020-11-27 14:20:20 +09002854TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2855 io_delegate_.SetFileContents("old/p/Foo.aidl",
2856 "package p;"
2857 "parcelable Foo {}");
2858 io_delegate_.SetFileContents("new/p/Foo.aidl",
2859 "package p;"
2860 "@JavaPassthrough(annotation=\"@Deprecated\")"
2861 "parcelable Foo {}");
2862 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2863}
2864
Jooyung Han636fd2f2020-10-22 11:33:45 +09002865TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2866 io_delegate_.SetFileContents("old/p/Data.aidl",
2867 "package p;"
2868 "parcelable Data {"
2869 " int num;"
2870 "}");
2871 io_delegate_.SetFileContents(
2872 "new/p/Data.aidl",
2873 "package p;"
2874 "parcelable Data {"
2875 " int num;"
2876 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2877 "}");
2878 io_delegate_.SetFileContents("new/p/Enum.aidl",
2879 "package p;"
2880 "enum Enum {"
2881 " FOO = 0,"
2882 " BAR = 1,"
2883 "}");
2884 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2885}
2886
Jooyung Han308bbe02021-04-27 12:09:59 +09002887TEST_F(AidlTestCompatibleChanges, CompatibleExplicitDefaults) {
2888 io_delegate_.SetFileContents("old/p/Data.aidl",
2889 "package p;\n"
2890 "parcelable Data {\n"
2891 " p.Enum e;\n"
2892 "}");
2893 io_delegate_.SetFileContents("old/p/Enum.aidl",
2894 "package p;\n"
2895 "enum Enum {\n"
2896 " FOO = 0,\n"
2897 " BAR = 1,\n"
2898 "}");
2899 io_delegate_.SetFileContents("new/p/Data.aidl",
2900 "package p;\n"
2901 "parcelable Data {\n"
2902 " p.Enum e = p.Enum.FOO;\n"
2903 "}");
2904 io_delegate_.SetFileContents("new/p/Enum.aidl",
2905 "package p;\n"
2906 "enum Enum {\n"
2907 " FOO = 0,\n"
2908 " BAR = 1,\n"
2909 "}");
2910 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2911}
2912
Jooyung Han6a92e432021-11-02 14:37:10 +09002913TEST_F(AidlTestCompatibleChanges, NewNestedTypes) {
2914 io_delegate_.SetFileContents("old/p/Data.aidl",
2915 "package p;\n"
2916 "parcelable Data {\n"
2917 " int n;\n"
2918 "}");
2919 io_delegate_.SetFileContents("new/p/Data.aidl",
2920 "package p;\n"
2921 "parcelable Data {\n"
2922 " enum NewEnum { N = 3 }\n"
2923 " int n;\n"
2924 " NewEnum e = NewEnum.N;\n"
2925 "}");
2926 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2927}
2928
Daniel Norman85aed542019-08-21 12:01:14 -07002929class AidlTestIncompatibleChanges : public AidlTest {
2930 protected:
2931 Options options_ = Options::From("aidl --checkapi old new");
2932};
2933
2934TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002935 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002936 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2937 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002938 "interface IFoo {"
2939 " void foo(in String[] str);"
2940 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002941 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002942 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002943 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002944 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002945}
2946
2947TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002948 const string expected_stderr =
2949 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002950 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2951 "package p;"
2952 "interface IFoo {"
2953 " void foo(in String[] str);"
2954 " void bar(@utf8InCpp String str);"
2955 "}");
2956 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2957 "package p;"
2958 "interface IFoo {"
2959 " void foo(in String[] str);"
2960 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002961 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002962 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002963 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002964}
2965
Jiyong Parkf8d53612020-05-04 14:06:13 +09002966TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2967 const string expected_stderr =
2968 "ERROR: new/p/IFoo.aidl:1.61-65: "
2969 "Encountered an untyped List or Map. The use of untyped List/Map is "
2970 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2971 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2972 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2973 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2974 "package p;"
2975 "interface IFoo {"
2976 " void foo(in String[] str);"
2977 "}");
2978 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2979 "package p;"
2980 "interface IFoo {"
2981 " void foo(in String[] str);"
2982 " void bar(in List arg);"
2983 "}");
2984 CaptureStderr();
2985 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2986 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2987}
2988
2989TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2990 const string expected_stderr =
2991 "ERROR: new/p/Data.aidl:1.54-59: "
2992 "Encountered an untyped List or Map. The use of untyped List/Map is "
2993 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2994 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2995 "ERROR: new/p/Data.aidl: Failed to read.\n";
2996 io_delegate_.SetFileContents("old/p/Data.aidl",
2997 "package p;"
2998 "parcelable Data {"
2999 " int foo;"
3000 "}");
3001 io_delegate_.SetFileContents("new/p/Data.aidl",
3002 "package p;"
3003 "parcelable Data {"
3004 " int foo;"
3005 " @nullable List list;"
3006 "}");
3007 CaptureStderr();
3008 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3009 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3010}
3011
Daniel Norman85aed542019-08-21 12:01:14 -07003012TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003013 const string expected_stderr =
3014 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003015 io_delegate_.SetFileContents("old/p/Data.aidl",
3016 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003017 "parcelable Data {"
3018 " int foo;"
3019 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003020 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003021 io_delegate_.SetFileContents("new/p/Data.aidl",
3022 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003023 "parcelable Data {"
3024 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003025 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003026 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003027 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003028 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003029}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003030
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003031TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
3032 const string expected_stderr =
3033 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
3034 "backends. Please either provide a default value for this field or mark the field as "
3035 "@nullable. This value or a null value will be used automatically when an old version of "
3036 "this parcelable is sent to a process which understands a new version of this parcelable. In "
3037 "order to make sure your code continues to be backwards compatible, make sure the default or "
3038 "null value does not cause a semantic change to this parcelable.\n";
3039 io_delegate_.SetFileContents("old/p/Data.aidl",
3040 "package p;"
3041 "parcelable Data {"
3042 " int num;"
3043 "}");
3044 io_delegate_.SetFileContents("new/p/Data.aidl",
3045 "package p;"
3046 "parcelable Data {"
3047 " int num;"
3048 " String str;"
3049 "}");
3050 CaptureStderr();
3051 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3052 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3053}
3054
Jooyung Han636fd2f2020-10-22 11:33:45 +09003055TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
3056 const string expected_stderr =
3057 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
3058 "Please make sure 'Enum' has '0' as a valid value.\n";
3059 io_delegate_.SetFileContents("old/p/Data.aidl",
3060 "package p;"
3061 "parcelable Data {"
3062 " int num;"
3063 "}");
3064 io_delegate_.SetFileContents("new/p/Data.aidl",
3065 "package p;"
3066 "parcelable Data {"
3067 " int num;"
3068 " p.Enum e;"
3069 "}");
3070 io_delegate_.SetFileContents("new/p/Enum.aidl",
3071 "package p;"
3072 "enum Enum {"
3073 " FOO = 1,"
3074 " BAR = 2,"
3075 "}");
3076 CaptureStderr();
3077 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3078 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3079}
3080
Daniel Norman85aed542019-08-21 12:01:14 -07003081TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003082 const string expected_stderr =
3083 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003084 io_delegate_.SetFileContents("old/p/Enum.aidl",
3085 "package p;"
3086 "enum Enum {"
3087 " FOO = 1,"
3088 " BAR = 2,"
3089 "}");
3090 io_delegate_.SetFileContents("new/p/Enum.aidl",
3091 "package p;"
3092 "enum Enum {"
3093 " BAR = 2,"
3094 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003095 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003096 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003097 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003098}
3099
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09003100TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
3101 const string expected_stderr =
3102 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
3103 io_delegate_.SetFileContents("old/p/Union.aidl",
3104 "package p;"
3105 "union Union {"
3106 " String str;"
3107 " int num;"
3108 "}");
3109 io_delegate_.SetFileContents("new/p/Union.aidl",
3110 "package p;"
3111 "union Union {"
3112 " String str;"
3113 "}");
3114 CaptureStderr();
3115 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3117}
3118
Daniel Norman85aed542019-08-21 12:01:14 -07003119TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003120 const string expected_stderr =
3121 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003122 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3123 "package p;"
3124 "interface IFoo {"
3125 " void foo(in String[] str);"
3126 " void bar(@utf8InCpp String str);"
3127 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003128 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3129 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003130 "interface IFoo {"
3131 " void foo(in String[] str);"
3132 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003133 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003134 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003135 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003136 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003137}
3138
Daniel Norman85aed542019-08-21 12:01:14 -07003139TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003140 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003141 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3142 "package p;"
3143 "interface IFoo {"
3144 " void foo(in String[] str);"
3145 " void bar(@utf8InCpp String str);"
3146 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003147 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
3148 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003149 "interface IFoo2 {"
3150 " void foo(in String[] str);"
3151 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003152 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003153 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003154 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003155 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003156}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003157
Daniel Norman85aed542019-08-21 12:01:14 -07003158TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003159 const string expected_stderr =
3160 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003161 io_delegate_.SetFileContents("old/p/Enum.aidl",
3162 "package p;"
3163 "enum Enum {"
3164 " FOO = 1,"
3165 " BAR = 2,"
3166 "}");
3167 io_delegate_.SetFileContents("new/p/Enum.aidl",
3168 "package p;"
3169 "enum Enum {"
3170 " FOO = 3,"
3171 " BAR = 2,"
3172 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003173 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003174 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003175 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003176}
3177
3178TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003179 const string expected_stderr =
3180 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
3181 "from 0 to 1.\n"
3182 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
3183 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003184 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3185 "package p;"
3186 "interface IFoo {"
3187 " void foo(in String[] str);"
3188 " void bar(@utf8InCpp String str);"
3189 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003190 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3191 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003192 "interface IFoo {"
3193 " void bar(@utf8InCpp String str);"
3194 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003195 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003196 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003197 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003199}
3200
3201TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003202 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09003203 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
3204 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003205 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003206 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003207 "parcelable Data {"
3208 " int foo;"
3209 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003210 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07003211 io_delegate_.SetFileContents("new/p/Data.aidl",
3212 "package p;"
3213 "parcelable Data {"
3214 " int bar;"
3215 " int foo;"
3216 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003217 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003218 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003219 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003220}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003221
Daniel Norman85aed542019-08-21 12:01:14 -07003222TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07003223 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003224 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09003225 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003226 "interface IFoo {"
3227 " void foo(in String[] str);"
3228 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003229 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003230 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3231 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003232 "interface IFoo {"
3233 " void foo(out String[] str);"
3234 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003235 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07003236 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003237 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07003238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003239}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003240
Daniel Norman85aed542019-08-21 12:01:14 -07003241TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003242 const string expected_stderr =
3243 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003244 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3245 "package p;"
3246 "interface IFoo {"
3247 " void foo(in String[] str);"
3248 " void bar(@utf8InCpp String str);"
3249 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003250 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3251 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003252 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003253 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003254 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003255 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003256 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003257 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003258 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003259}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003260
Daniel Norman85aed542019-08-21 12:01:14 -07003261TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003262 const string expected_stderr =
3263 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07003264 io_delegate_.SetFileContents("old/p/IFoo.aidl",
3265 "package p;"
3266 "interface IFoo {"
3267 " void foo(in String[] str);"
3268 " void bar(@utf8InCpp String str);"
3269 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003270 io_delegate_.SetFileContents("new/p/IFoo.aidl",
3271 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003272 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09003273 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09003274 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09003275 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003276 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003277 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003278 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003279}
Jiyong Park3656c3c2018-08-01 20:02:01 +09003280
Jooyung Han60b2fde2020-10-29 15:12:40 +09003281TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
3282 const string expected_stderr =
3283 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
3284 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
3285 io_delegate_.SetFileContents("old/p/Foo.aidl",
3286 "package p;"
3287 "@Backing(type=\"byte\")"
3288 "enum Foo {"
3289 " FOO, BAR,"
3290 "}");
3291 io_delegate_.SetFileContents("new/p/Foo.aidl",
3292 "package p;"
3293 "@Backing(type=\"long\")"
3294 "enum Foo {"
3295 " FOO, BAR,"
3296 "}");
3297 CaptureStderr();
3298 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3299 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3300}
3301
Jooyung Han69ea4ba2020-10-29 15:33:37 +09003302TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
3303 const string expected_stderr =
3304 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
3305 "to @JavaPassthrough(annotation=\"Bob\")\n";
3306 io_delegate_.SetFileContents("old/p/Foo.aidl",
3307 "package p;"
3308 "@JavaPassthrough(annotation=\"Alice\")"
3309 "parcelable Foo {}");
3310 io_delegate_.SetFileContents("new/p/Foo.aidl",
3311 "package p;"
3312 "@JavaPassthrough(annotation=\"Bob\")"
3313 "parcelable Foo {}");
3314
3315 CaptureStderr();
3316 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3317 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3318}
3319
Devin Mooredb7ac512020-08-07 11:17:36 -07003320TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
3321 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003322 "ERROR: new/p/Foo.aidl:1.32-36: Changed annotations: (empty) to @FixedSize\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003323 io_delegate_.SetFileContents("old/p/Foo.aidl",
3324 "package p;"
3325 "parcelable Foo {"
3326 " int A;"
3327 "}");
3328 io_delegate_.SetFileContents("new/p/Foo.aidl",
3329 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003330 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003331 " int A;"
3332 "}");
3333 CaptureStderr();
3334 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3336}
3337
3338TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
3339 const string expected_stderr =
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003340 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @FixedSize to (empty)\n";
Devin Mooredb7ac512020-08-07 11:17:36 -07003341 io_delegate_.SetFileContents("old/p/Foo.aidl",
3342 "package p;"
Jooyung Han2d6b5c42021-01-09 01:01:06 +09003343 "@FixedSize parcelable Foo {"
Devin Mooredb7ac512020-08-07 11:17:36 -07003344 " int A;"
3345 "}");
3346 io_delegate_.SetFileContents("new/p/Foo.aidl",
3347 "package p;"
3348 "parcelable Foo {"
3349 " int A;"
3350 "}");
3351 CaptureStderr();
3352 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3353 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3354}
3355
Daniel Norman85aed542019-08-21 12:01:14 -07003356TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003357 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003358 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
3359 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09003360 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003361 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003362 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003364}
Jiyong Parka468e2a2018-08-29 21:25:18 +09003365
Daniel Norman85aed542019-08-21 12:01:14 -07003366TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07003367 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003368 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
3369 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003370 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003371 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003372 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003373}
Jiyong Parka428d212018-08-29 22:26:30 +09003374
Daniel Norman85aed542019-08-21 12:01:14 -07003375TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003376 const string expected_stderr =
3377 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003378 io_delegate_.SetFileContents("old/p/I.aidl",
3379 "package p; interface I {"
3380 "const int A = 1; const int B = 2;}");
3381 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003382 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003383 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003384 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07003385}
Jiyong Parka428d212018-08-29 22:26:30 +09003386
Daniel Norman85aed542019-08-21 12:01:14 -07003387TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003388 const string expected_stderr =
3389 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003390 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
3391 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07003392 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07003393 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003394 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09003395}
3396
Devin Moorec7e47a32020-08-07 10:55:25 -07003397TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
3398 const string expected_stderr =
3399 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
3400 "This is an incompatible change for FixedSize types.\n";
3401 io_delegate_.SetFileContents("old/p/Foo.aidl",
3402 "package p; @FixedSize parcelable Foo { int A = 1; }");
3403 io_delegate_.SetFileContents("new/p/Foo.aidl",
3404 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
3405 CaptureStderr();
3406 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3407 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3408}
3409
Jeongik Cha68d18e72021-04-29 20:07:01 +09003410TEST_F(AidlTestIncompatibleChanges, UidRangeParcelAddedField) {
3411 const string expected_stderr =
3412 "ERROR: new/android/net/UidRangeParcel.aidl:1.32-47: Number of fields in "
3413 "android.net.UidRangeParcel is changed from 1 to 2. "
3414 "But it is forbidden because of legacy support.\n";
3415 io_delegate_.SetFileContents("old/android/net/UidRangeParcel.aidl",
3416 "package android.net; parcelable UidRangeParcel { int A = 1; }");
3417 io_delegate_.SetFileContents(
3418 "new/android/net/UidRangeParcel.aidl",
3419 "package android.net; parcelable UidRangeParcel { int A = 1; int B = 2; }");
3420 CaptureStderr();
3421 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3422 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3423}
3424
Devin Moorec7e47a32020-08-07 10:55:25 -07003425TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
3426 const string expected_stderr =
3427 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3428 io_delegate_.SetFileContents("old/p/Foo.aidl",
3429 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
3430 io_delegate_.SetFileContents("new/p/Foo.aidl",
3431 "package p; @FixedSize parcelable Foo { int A = 1; }");
3432 CaptureStderr();
3433 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3435}
3436
Jooyung Han6a92e432021-11-02 14:37:10 +09003437TEST_F(AidlTestIncompatibleChanges, IncompatibleChangesInNestedType) {
3438 const string expected_stderr =
3439 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
3440 io_delegate_.SetFileContents("old/p/Foo.aidl",
3441 "package p;\n"
3442 "parcelable Foo {\n"
3443 " interface IBar {\n"
3444 " void foo();"
3445 " }\n"
3446 "}");
3447 io_delegate_.SetFileContents("new/p/Foo.aidl",
3448 "package p;\n"
3449 "parcelable Foo {\n"
3450 " interface IBar {\n"
3451 " void foo(int n);" // incompatible: signature changed
3452 " }\n"
3453 "}");
3454 CaptureStderr();
3455 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
3456 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Removed or changed method: p.Foo.IBar.foo()"));
3457}
3458
Devin Moorec7e47a32020-08-07 10:55:25 -07003459TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
3460 const string expected_stderr =
Jooyung Hancd160952021-09-28 10:06:31 +09003461 "ERROR: Foo.aidl:2.8-10: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003462 "a.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003463 "ERROR: Foo.aidl:3.6-8: The @FixedSize parcelable 'Foo' has a non-fixed size field named b.\n"
3464 "ERROR: Foo.aidl:4.9-11: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003465 "c.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003466 "ERROR: Foo.aidl:5.23-25: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003467 "d.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003468 "ERROR: Foo.aidl:6.10-12: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
Devin Moorec7e47a32020-08-07 10:55:25 -07003469 "e.\n"
Jooyung Hancd160952021-09-28 10:06:31 +09003470 "ERROR: Foo.aidl:7.15-17: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3471 "f.\n"
3472 "ERROR: Foo.aidl:9.23-33: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3473 "nullable1.\n"
3474 "ERROR: Foo.aidl:10.34-44: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
3475 "nullable2.\n";
Devin Moorec7e47a32020-08-07 10:55:25 -07003476
3477 io_delegate_.SetFileContents("Foo.aidl",
Jooyung Hancd160952021-09-28 10:06:31 +09003478 "@FixedSize parcelable Foo {\n"
3479 " int[] a;\n"
3480 " Bar b;\n"
3481 " String c;\n"
3482 " ParcelFileDescriptor d;\n"
3483 " IBinder e;\n"
3484 " List<String> f;\n"
3485 " int isFixedSize;\n"
3486 " @nullable OtherFixed nullable1;\n"
3487 " @nullable(heap=true) OtherFixed nullable2;\n"
Devin Moorec7e47a32020-08-07 10:55:25 -07003488 "}");
3489 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
Jooyung Hancd160952021-09-28 10:06:31 +09003490 io_delegate_.SetFileContents("OtherFixed.aidl", "@FixedSize parcelable OtherFixed { int a; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003491 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003492
3493 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003494 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003495 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3496}
3497
3498TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
3499 const string expected_stderr = "";
3500
3501 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
3502 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
3503 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09003504 Options options = Options::From("aidl Foo.aidl -I . --lang=" + to_string(GetLanguage()));
Devin Moorec7e47a32020-08-07 10:55:25 -07003505
3506 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003507 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moorec7e47a32020-08-07 10:55:25 -07003508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3509}
3510
Jiyong Park8c380532018-08-30 14:55:26 +09003511TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003512 const string expected_stderr =
3513 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
3514 "dir1/q/IBar.aidl\n"
3515 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003516 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09003517 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
3518 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
3519 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
3520 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
3521
Devin Moore097a3ab2020-03-11 16:08:44 -07003522 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003523 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003524 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09003525}
3526
Jiyong Parked65bf42018-08-28 15:43:27 +09003527TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003528 const string expected_stderr =
3529 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
3530 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09003531 Options options = Options::From("aidl --checkapi old new");
3532 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
3533 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09003534
3535 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
3536
Jiyong Parke59c3682018-09-11 23:10:25 +09003537 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003538 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09003539 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09003541}
3542
Jooyung Han652ce482021-02-26 12:40:35 +09003543TEST_P(AidlTest, ParcelFileDescriptorIsBuiltinType) {
3544 Options options =
3545 Options::From("aidl --lang=" + to_string(GetLanguage()) + " -h out -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09003546
3547 // use without import
3548 io_delegate_.SetFileContents("p/IFoo.aidl",
3549 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003550 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003551
3552 // capture output files
3553 map<string, string> outputs = io_delegate_.OutputFiles();
Jiyong Parke05195e2018-10-08 18:24:23 +09003554
Devin Moore7b8d5c92020-03-17 14:14:08 -07003555 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09003556 io_delegate_.SetFileContents(
3557 "p/IFoo.aidl",
3558 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
Steven Moreland4e059132021-08-11 13:36:30 -07003559 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003560 // output files should be the same
3561 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003562
3563 // use with import (as before)
3564 io_delegate_.SetFileContents("p/IFoo.aidl",
3565 "package p;"
3566 "import android.os.ParcelFileDescriptor;"
3567 "interface IFoo{"
3568 " void foo(in ParcelFileDescriptor fd);"
3569 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003570 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han652ce482021-02-26 12:40:35 +09003571 // output files should be the same
3572 EXPECT_EQ(outputs, io_delegate_.OutputFiles());
Jiyong Parke05195e2018-10-08 18:24:23 +09003573}
Jiyong Parked65bf42018-08-28 15:43:27 +09003574
Jooyung Han020d8d12021-02-26 17:23:02 +09003575TEST_P(AidlTest, RejectsOutputParcelFileDescriptor) {
3576 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3577 CaptureStderr();
3578 io_delegate_.SetFileContents("p/IFoo.aidl",
3579 "package p;"
3580 "interface IFoo{"
3581 " void foo(out ParcelFileDescriptor fd);"
3582 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003583 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003584 EXPECT_THAT(GetCapturedStderr(), HasSubstr("can't be an out parameter"));
3585}
3586
3587TEST_P(AidlTest, RejectsArgumentDirectionNotSpecified) {
3588 Options options = Options::From("aidl p/IFoo.aidl -I . --lang=" + to_string(GetLanguage()));
3589 CaptureStderr();
3590 io_delegate_.SetFileContents("p/IFoo.aidl",
3591 "package p;"
3592 "interface IFoo{"
3593 " void foo(ParcelFileDescriptor fd);"
3594 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003595 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han020d8d12021-02-26 17:23:02 +09003596 EXPECT_THAT(GetCapturedStderr(),
3597 HasSubstr("ParcelFileDescriptor can be an in or inout parameter."));
3598}
3599
Jiyong Park3633b722019-04-11 15:38:26 +09003600TEST_F(AidlTest, ManualIds) {
3601 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
3602 io_delegate_.SetFileContents("IFoo.aidl",
3603 "interface IFoo {\n"
3604 " void foo() = 0;\n"
3605 " void bar() = 1;\n"
3606 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003607 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003608}
3609
3610TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
3611 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3612 io_delegate_.SetFileContents("IFoo.aidl",
3613 "interface IFoo {\n"
3614 " void foo() = 0;\n"
3615 " void bar() = 1;\n"
3616 "}");
Steven Moreland4e059132021-08-11 13:36:30 -07003617 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park3633b722019-04-11 15:38:26 +09003618}
3619
3620TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003621 const string expected_stderr =
3622 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003623 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3624 io_delegate_.SetFileContents("IFoo.aidl",
3625 "interface IFoo {\n"
3626 " void foo() = 3;\n"
3627 " void bar() = 3;\n"
3628 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003629 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003630 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003631 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003632}
3633
3634TEST_F(AidlTest, FailOnOutOfRangeIds) {
3635 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07003636 const string expected_stderr =
3637 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
3638 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003639 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3640 io_delegate_.SetFileContents("IFoo.aidl",
3641 "interface IFoo {\n"
3642 " void foo() = 3;\n"
3643 " void bar() = 16777115;\n"
3644 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003645 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003646 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003647 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003648}
3649
3650TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003651 const string expected_stderr =
3652 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09003653 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
3654 io_delegate_.SetFileContents("IFoo.aidl",
3655 "interface IFoo {\n"
3656 " void foo() = 3;\n"
3657 " void bar();\n"
3658 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003659 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003660 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09003662}
3663
Jiyong Parkc6816252019-07-08 08:12:28 +09003664TEST_F(AidlTest, AllowDuplicatedImportPaths) {
3665 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
3666 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3667 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Steven Moreland4e059132021-08-11 13:36:30 -07003668 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkc6816252019-07-08 08:12:28 +09003669}
3670
3671TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003672 const string expected_stderr =
3673 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
3674 "dir/IBar.aidl\n"
3675 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07003676 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003677
Jiyong Parkc6816252019-07-08 08:12:28 +09003678 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
3679 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
3680 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
3681 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07003682 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07003683 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07003684 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09003685}
3686
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003687TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
3688 io_delegate_.SetFileContents("a/b/IFoo.aidl",
3689 "package a.b;\n"
3690 "import a.b.IBar;\n"
3691 "import a.b.IQux;\n"
3692 "interface IFoo { IQux foo(); }\n");
3693 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
3694 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
3695
3696 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
Steven Moreland4e059132021-08-11 13:36:30 -07003697 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Parkf1f5c802020-05-19 17:33:00 +09003698
3699 string output;
3700 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
3701 // IBar was imported but wasn't used. include is not expected.
3702 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
3703 // IBar was imported and used. include is expected.
3704 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
3705}
3706
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003707TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003708 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09003709 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003710 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3711 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003712 interface IFoo {
3713 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09003714 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09003715 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003716 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09003717 // JavaPassthrough should work with other types as well (e.g. enum)
3718 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
3719 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
3720 @JavaPassthrough(annotation="@com.android.AliceTwo")
3721 @Backing(type="byte")
3722 enum MyEnum {
3723 a, b, c
3724 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003725
Jooyung Han4cde01d2020-10-13 11:10:47 +09003726 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003727 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003728
3729 string java_out;
3730 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09003731 // type-decl-level annotations with newline at the end
3732 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3733 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3734 // member-decl-level annotations with newline at the end
3735 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
3736 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
3737 // inline annotations with space at the end
3738 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003739
Jooyung Han4cde01d2020-10-13 11:10:47 +09003740 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
3741 // type-decl-level annotations with newline at the end
3742 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
3743 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
3744
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003745 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09003746 Options cpp_options =
3747 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003748 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003749
Jooyung Han4cde01d2020-10-13 11:10:47 +09003750 Options ndk_options =
3751 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003752 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07003753
Jooyung Han4cde01d2020-10-13 11:10:47 +09003754 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003755 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09003756}
3757
Andrei Homescue61feb52020-08-18 15:44:24 -07003758TEST_F(AidlTest, ParseRustDerive) {
3759 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
3760 @RustDerive(Clone=true, Copy=false)
3761 parcelable Foo {
3762 int a;
3763 })");
3764
3765 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003766 EXPECT_TRUE(compile_aidl(rust_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003767
3768 string rust_out;
3769 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
3770 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
3771
3772 // Other backends shouldn't be bothered
3773 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003774 EXPECT_TRUE(compile_aidl(cpp_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003775
3776 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003777 EXPECT_TRUE(compile_aidl(ndk_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003778
3779 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07003780 EXPECT_TRUE(compile_aidl(java_options, io_delegate_));
Andrei Homescue61feb52020-08-18 15:44:24 -07003781}
3782
Thiébaud Weksteen9ab59122021-09-20 09:37:38 +02003783TEST_F(AidlTest, EmptyEnforceAnnotation) {
3784 const string expected_stderr = "ERROR: a/IFoo.aidl:3.1-19: Missing 'condition' on @Enforce.\n";
3785 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3786 interface IFoo {
3787 @Enforce()
3788 void Protected();
3789 })");
3790
3791 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3792 CaptureStderr();
3793 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3794 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3795}
3796
3797TEST_F(AidlTest, EmptyEnforceCondition) {
3798 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3799 interface IFoo {
3800 @Enforce(condition="")
3801 void Protected();
3802 })");
3803
3804 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3805 CaptureStderr();
3806 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3807 EXPECT_THAT(GetCapturedStderr(),
3808 HasSubstr("ERROR: a/IFoo.aidl:3.1-31: Unable to parse @Enforce annotation"));
3809}
3810
3811TEST_F(AidlTest, InvalidEnforceCondition) {
3812 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3813 interface IFoo {
3814 @Enforce(condition="invalid")
3815 void Protected();
3816 })");
3817
3818 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3819 CaptureStderr();
3820 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3821 EXPECT_THAT(GetCapturedStderr(),
3822 HasSubstr("ERROR: a/IFoo.aidl:3.1-38: Unable to parse @Enforce annotation"));
3823}
3824
Thiébaud Weksteen133da842021-10-29 16:49:58 +11003825TEST_F(AidlTest, InterfaceEnforceCondition) {
3826 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3827 @Enforce(condition="permission = INTERNET")
3828 interface IFoo {
3829 void Protected();
3830 })");
3831
3832 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3833 EXPECT_TRUE(compile_aidl(options, io_delegate_));
3834}
3835
3836TEST_F(AidlTest, InterfaceAndMethodEnforceCondition) {
3837 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3838 @Enforce(condition="permission = INTERNET")
3839 interface IFoo {
3840 @Enforce(condition="uid = SYSTEM_UID")
3841 void Protected();
3842 })");
3843
3844 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3845 EXPECT_TRUE(compile_aidl(options, io_delegate_));
3846}
3847
Thiébaud Weksteene79243a2021-11-02 14:36:25 +11003848TEST_F(AidlTest, NoPermissionInterfaceEnforceMethod) {
3849 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3850 @NoPermissionRequired
3851 interface IFoo {
3852 @Enforce(condition="permission = INTERNET")
3853 void Protected();
3854 })");
3855
3856 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3857 CaptureStderr();
3858 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3859 EXPECT_THAT(GetCapturedStderr(),
3860 HasSubstr("The interface IFoo is annotated as requiring no permission"));
3861}
3862
3863TEST_F(AidlTest, ManualPermissionInterfaceEnforceMethod) {
3864 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3865 @PermissionManuallyEnforced
3866 interface IFoo {
3867 @Enforce(condition="permission = INTERNET")
3868 void Protected();
3869 })");
3870
3871 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3872 CaptureStderr();
3873 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3874 EXPECT_THAT(
3875 GetCapturedStderr(),
3876 HasSubstr("The interface IFoo is annotated as manually implementing permission checks"));
3877}
3878
3879TEST_F(AidlTest, EnforceInterfaceNoPermissionsMethod) {
3880 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3881 @Enforce(condition="permission = INTERNET")
3882 interface IFoo {
3883 @NoPermissionRequired
3884 void Protected();
3885 })");
3886
3887 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3888 CaptureStderr();
3889 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3890 EXPECT_THAT(GetCapturedStderr(),
3891 HasSubstr("The interface IFoo enforces permissions using annotations"));
3892}
3893
3894TEST_F(AidlTest, EnforceInterfaceManualPermissionMethod) {
3895 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
3896 @Enforce(condition="permission = INTERNET")
3897 interface IFoo {
3898 @PermissionManuallyEnforced
3899 void Protected();
3900 })");
3901
3902 Options options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
3903 CaptureStderr();
3904 EXPECT_FALSE(compile_aidl(options, io_delegate_));
3905 EXPECT_THAT(GetCapturedStderr(),
3906 HasSubstr("The interface IFoo enforces permissions using annotations"));
3907}
3908
Jiyong Park56f73d72019-06-11 12:20:28 +09003909class AidlOutputPathTest : public AidlTest {
3910 protected:
3911 void SetUp() override {
3912 AidlTest::SetUp();
3913 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
3914 }
3915
3916 void Test(const Options& options, const std::string expected_output_path) {
Steven Moreland4e059132021-08-11 13:36:30 -07003917 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jiyong Park56f73d72019-06-11 12:20:28 +09003918 // check the existence
3919 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
3920 }
3921};
3922
3923TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
3924 // <out_dir> / <package_name> / <type_name>.java
3925 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
3926}
3927
3928TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
3929 // when output file is explicitly set, it is always respected. -o option is
3930 // ignored.
3931 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3932}
3933
3934TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
3935 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
3936}
3937
3938TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
3939 // output is the same as the input file except for the suffix
3940 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
3941}
3942
Devin Moore7b8d5c92020-03-17 14:14:08 -07003943TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003944 AidlError error;
3945 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003946 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int (2147483650)\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003947 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003948 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3949 R"(package p;
3950 interface IFoo {
3951 const int int32_max_oob = 2147483650;
3952 }
3953 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003954 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3956 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003957}
3958
Devin Moore7b8d5c92020-03-17 14:14:08 -07003959TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003960 AidlError error;
3961 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07003962 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int "
3963 "(-2147483650)\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003964 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003965 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3966 R"(package p;
3967 interface IFoo {
3968 const int int32_min_oob = -2147483650;
3969 }
3970 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003971 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003972 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3973 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003974}
3975
Devin Moore7b8d5c92020-03-17 14:14:08 -07003976TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003977 AidlError error;
3978 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003979 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003980 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003981 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3982 R"(package p;
3983 interface IFoo {
3984 const long int64_max_oob = 21474836509999999999999999;
3985 }
3986 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003987 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003988 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3989 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003990}
3991
Devin Moore7b8d5c92020-03-17 14:14:08 -07003992TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003993 AidlError error;
3994 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003995 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003996 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003997 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3998 R"(package p;
3999 interface IFoo {
4000 const long int64_min_oob = -21474836509999999999999999;
4001 }
4002 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07004003 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07004004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4005 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07004006}
4007
Devin Moore7b8d5c92020-03-17 14:14:08 -07004008TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07004009 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07004010 const string expected_stderr =
Steven Morelandb7d58652021-10-25 15:10:02 -07004011 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte (FOO+1)\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07004012 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
4013 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07004014 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
4015 R"(package p;
4016 @Backing(type="byte")
4017 enum TestEnum {
4018 FOO = 127,
4019 BAR,
4020 }
4021 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07004022 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07004023 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07004024 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07004025}
4026
Steven Morelandb248d072021-09-29 19:07:17 -07004027TEST_P(AidlTest, FailOnUnsupportedBackingType) {
4028 AidlError error;
4029 const string expected_stderr =
4030 "ERROR: p/TestEnum.aidl:3.35-44: Invalid backing type: boolean. Backing type must be one of: "
4031 "byte, int, long\n";
4032 CaptureStderr();
4033 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
4034 R"(package p;
4035 @Backing(type="boolean")
4036 enum TestEnum {
4037 FOO = 0,
4038 BAR = 1,
4039 }
4040 )",
4041 typenames_, GetLanguage(), &error));
4042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4043 EXPECT_EQ(AidlError::BAD_TYPE, error);
4044}
4045
Devin Mooredecaf292020-04-30 09:16:40 -07004046TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
4047 AidlError error;
4048 const string expected_stderr =
4049 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
Devin Mooredecaf292020-04-30 09:16:40 -07004050 "be one of: type\n";
4051 CaptureStderr();
4052 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
4053 R"(package p;
4054 @Backing(foo="byte")
4055 enum TestEnum {
4056 FOO = 1,
4057 BAR,
4058 }
4059 )",
4060 typenames_, GetLanguage(), &error));
4061 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4062 EXPECT_EQ(AidlError::BAD_TYPE, error);
4063}
4064
Jooyung Han5721a232020-12-24 04:34:55 +09004065TEST_P(AidlTest, BackingAnnotationRequireTypeParameter) {
4066 const string expected_stderr = "ERROR: Enum.aidl:1.1-9: Missing 'type' on @Backing.\n";
4067 CaptureStderr();
4068 EXPECT_EQ(nullptr, Parse("Enum.aidl", "@Backing enum Enum { FOO }", typenames_, GetLanguage()));
4069 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4070}
4071
Jooyung Han66813932020-10-23 13:24:44 +09004072TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004073 io_delegate_.SetFileContents("Foo.aidl",
4074 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
4075 "Map<String, Baz> d; Bar[] e; }");
4076 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
4077 io_delegate_.SetFileContents("Baz.aidl",
4078 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09004079 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004080 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jeongik Cha36f76c32020-07-28 00:25:52 +09004081}
4082
Jooyung Han66813932020-10-23 13:24:44 +09004083TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004084 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09004085 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09004086 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09004087 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
4088 "named 'bar'.\n";
4089 CaptureStderr();
4090 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004091 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han59af9cc2020-10-25 21:44:14 +09004092 EXPECT_EQ(expected_error, GetCapturedStderr());
4093}
4094
Jooyung Han09e551c2021-05-11 11:44:48 +09004095TEST_F(AidlTest, JavaOnlyImmutableParcelableWithEnumFields) {
4096 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
4097 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { FOO }");
4098 CaptureStderr();
4099 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004100 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han09e551c2021-05-11 11:44:48 +09004101 EXPECT_EQ("", GetCapturedStderr());
4102}
4103
Jooyung Han59af9cc2020-10-25 21:44:14 +09004104TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
4105 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
4106 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
4107 string expected_error =
4108 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09004109 "named 'bar'.\n";
4110 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004111 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004112 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09004113 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004114}
4115
Jooyung Han66813932020-10-23 13:24:44 +09004116TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004117 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004118 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
4119 string expected_error =
4120 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
4121 "only be an in parameter.\n";
4122 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004123 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004124 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004125 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004126}
4127
Jooyung Han66813932020-10-23 13:24:44 +09004128TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004129 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09004130 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
4131 string expected_error =
4132 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
4133 "only be an in parameter.\n";
4134 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09004135 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
Steven Moreland4e059132021-08-11 13:36:30 -07004136 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09004137 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09004138}
4139
Jooyung Han66813932020-10-23 13:24:44 +09004140TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09004141 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09004142 Options options = Options::From("aidl --lang=java Foo.aidl");
4143 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09004144 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
4145 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09004146 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004147 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Cha91180252020-07-31 15:43:11 +09004148 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4149}
Devin Moore53fc99c2020-08-12 08:07:52 -07004150
Jooyung Hanfe086af2021-01-16 03:44:47 +09004151TEST_P(AidlTest, UnionInUnion) {
4152 import_paths_.insert(".");
4153 io_delegate_.SetFileContents("Bar.aidl", "union Bar { int n = 42; long l; }");
4154 CaptureStderr();
4155 EXPECT_NE(nullptr, Parse("Foo.aidl", "union Foo { Bar b; int n; }", typenames_, GetLanguage()));
4156 EXPECT_THAT("", GetCapturedStderr());
4157}
4158
Jooyung Hanfe89f122020-10-14 03:49:18 +09004159TEST_P(AidlTest, UnionRejectsEmptyDecl) {
4160 const string method = "package a; union Foo {}";
4161 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
4162 CaptureStderr();
4163 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4164 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4165}
4166
4167TEST_P(AidlTest, UnionRejectsParcelableHolder) {
4168 const string method = "package a; union Foo { ParcelableHolder x; }";
4169 const string expected_stderr =
4170 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
4171 CaptureStderr();
4172 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
4173 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
4174}
4175
Jooyung Han53fb4242020-12-17 16:03:49 +09004176TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
4177 import_paths_.insert(".");
4178 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
4179 const string expected_err = "The union's first member should have a useful default value.";
4180 CaptureStderr();
4181 EXPECT_EQ(nullptr,
4182 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
4183 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
4184}
4185
Devin Moore53fc99c2020-08-12 08:07:52 -07004186TEST_P(AidlTest, GenericStructuredParcelable) {
4187 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004188 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004189 const string expected_stderr = "";
4190 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004191 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4193}
4194
Jooyung Han3f347ca2020-12-01 12:41:50 +09004195TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
4196 io_delegate_.SetFileContents("Foo.aidl",
4197 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4198 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004199 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::CPP) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004200 const string expected_stderr = "";
4201 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004202 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004203 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4204
4205 string code;
4206 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4207 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4208const ::android::String16& Foo<T,U>::s() {
4209 static const ::android::String16 value(::android::String16(""));
4210 return value;
4211})--"));
4212}
4213
4214TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
4215 io_delegate_.SetFileContents("Foo.aidl",
4216 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
4217 Options options =
Jooyung Han9435e9a2021-01-06 10:16:31 +09004218 Options::From("aidl Foo.aidl --lang=" + to_string(Options::Language::NDK) + " -o out -h out");
Jooyung Han3f347ca2020-12-01 12:41:50 +09004219 const string expected_stderr = "";
4220 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004221 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han3f347ca2020-12-01 12:41:50 +09004222 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4223
4224 string code;
4225 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4226 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
4227const char* Foo<T, U>::s = "";
4228)--"));
4229}
4230
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004231TEST_F(AidlTest, NestedTypeArgs) {
4232 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00004233 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
4234
4235 io_delegate_.SetFileContents("a/Foo.aidl",
4236 "package a; import a.Bar; import a.Baz; parcelable Foo { "
4237 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004238 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
4239 const string expected_stderr = "";
4240 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004241 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4243
4244 string code;
4245 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00004246 EXPECT_THAT(code,
4247 testing::HasSubstr(
4248 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
4249}
4250
4251TEST_F(AidlTest, DoubleArrayError) {
4252 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
4253
4254 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4255 const string expected_stderr =
4256 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
4257 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004258 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4260}
4261
4262TEST_F(AidlTest, DoubleGenericError) {
4263 io_delegate_.SetFileContents("a/Bar.aidl",
4264 "package a; parcelable Bar { List<String><String> a; }");
4265
4266 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4267 const string expected_stderr =
4268 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
4269 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004270 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Steven Moreland6c07b832020-10-29 23:39:53 +00004271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4272}
4273
4274TEST_F(AidlTest, ArrayBeforeGenericError) {
4275 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
4276
4277 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
Steven Moreland6c07b832020-10-29 23:39:53 +00004278 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004279 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004280 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("syntax error, unexpected '<'"));
4281}
4282
4283TEST_F(AidlTest, NullableArraysAreNotSupported) {
4284 io_delegate_.SetFileContents("a/Bar.aidl",
4285 "package a; parcelable Bar { String @nullable [] a; }");
4286
4287 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4288 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004289 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004290 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr("Annotations for arrays are not supported."));
4291}
4292
4293TEST_F(AidlTest, ListOfNullablesAreNotSupported) {
4294 io_delegate_.SetFileContents("a/Bar.aidl",
4295 "package a; parcelable Bar { List<@nullable String> a; }");
4296
4297 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
4298 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004299 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han97c324a2021-02-15 16:09:51 +09004300 EXPECT_THAT(GetCapturedStderr(),
4301 testing::HasSubstr("Annotations for type arguments are not supported."));
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004302}
4303
Jooyung Han14004ed2020-10-16 03:49:57 +09004304struct GenericAidlTest : ::testing::Test {
4305 FakeIoDelegate io_delegate_;
4306 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004307 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004308 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4309 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4310 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4311
4312 Options options = Options::From(cmd);
4313 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004314 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han14004ed2020-10-16 03:49:57 +09004315 EXPECT_EQ("", GetCapturedStderr());
4316 }
4317};
4318
4319TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4320 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4321 string code;
4322 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4323 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4324 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4325 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4326}
4327
4328TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4329 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4330 string code;
4331 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4332 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4333 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4334 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4335}
4336
Devin Moore53fc99c2020-08-12 08:07:52 -07004337TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4338 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004339 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004340 const string expected_stderr =
4341 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4342 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004343 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4345}
4346
4347TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4348 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004349 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Devin Moore53fc99c2020-08-12 08:07:52 -07004350 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4351 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004352 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Devin Moore53fc99c2020-08-12 08:07:52 -07004353 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4354}
4355
Jooyung Han7a308842020-10-27 19:06:49 +09004356TEST_P(AidlTest, LongCommentWithinConstExpression) {
4357 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004358 Options options = Options::From("aidl Foo.aidl --lang=" + to_string(GetLanguage()));
Jooyung Han7a308842020-10-27 19:06:49 +09004359 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004360 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han7a308842020-10-27 19:06:49 +09004361 EXPECT_EQ("", GetCapturedStderr());
4362}
4363
Jeongik Chaef44e622020-10-23 16:00:52 +09004364TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4365 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4366 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4367 std::string expectedErr =
4368 "ERROR: a/Foo.aidl:1.28-30: "
4369 "Encountered an untyped List or Map. The use of untyped List/Map is "
4370 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4371 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4372 "ERROR: a/Foo.aidl:1.35-37: "
4373 "Encountered an untyped List or Map. The use of untyped List/Map is "
4374 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4375 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4376 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004377 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004378 EXPECT_EQ(expectedErr, GetCapturedStderr());
4379}
4380
4381TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004382 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4383 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004384 std::string expectedErr =
4385 "ERROR: a/Foo.aidl:1.33-35: "
4386 "Encountered an untyped List or Map. The use of untyped List/Map is "
4387 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4388 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4389 "ERROR: a/Foo.aidl:1.40-42: "
4390 "Encountered an untyped List or Map. The use of untyped List/Map is "
4391 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4392 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004393 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004394 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004395 EXPECT_EQ(expectedErr, GetCapturedStderr());
4396}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004397
Jeongik Chaef44e622020-10-23 16:00:52 +09004398TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4399 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4400 io_delegate_.SetFileContents(
4401 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4402 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4403 std::string expectedErr =
4404 "ERROR: a/Foo.aidl:1.52-54: "
4405 "Encountered an untyped List or Map. The use of untyped List/Map is "
4406 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4407 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4408 "ERROR: a/Foo.aidl:1.64-66: "
4409 "Encountered an untyped List or Map. The use of untyped List/Map is "
4410 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4411 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4412 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004413 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jeongik Chaef44e622020-10-23 16:00:52 +09004414 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004415}
4416
Jooyung Han690f5842020-12-04 13:02:04 +09004417TEST_F(AidlTest, EnumWithDefaults_Java) {
4418 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4419 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4420package p;
4421import p.Enum;
4422parcelable Foo {
4423 Enum e = Enum.BAR;
4424})");
4425 CaptureStderr();
4426 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004427 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004428 auto err = GetCapturedStderr();
4429 EXPECT_EQ("", err);
4430
4431 string code;
4432 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004433 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004434}
4435
4436TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4437 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4438 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4439package p;
4440import p.Enum;
4441parcelable Foo {
4442 Enum e = Enum.BAR;
4443})");
4444 CaptureStderr();
4445 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004446 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004447 auto err = GetCapturedStderr();
4448 EXPECT_EQ("", err);
4449
4450 string code;
4451 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4452 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4453}
4454
4455TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4456 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4457 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4458package p;
4459import p.Enum;
4460parcelable Foo {
4461 Enum e = Enum.BAR;
4462})");
4463 CaptureStderr();
4464 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004465 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004466 auto err = GetCapturedStderr();
4467 EXPECT_EQ("", err);
4468
4469 string code;
4470 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4471 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4472}
4473
4474TEST_F(AidlTest, EnumWithDefaults_Rust) {
4475 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4476 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4477package p;
4478import p.Enum;
4479parcelable Foo {
4480 int n = 42;
4481 Enum e = Enum.BAR;
4482})");
4483 CaptureStderr();
4484 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004485 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004486 auto err = GetCapturedStderr();
4487 EXPECT_EQ("", err);
4488
4489 string code;
4490 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4491 EXPECT_THAT(code, testing::HasSubstr(R"(
4492 fn default() -> Self {
4493 Self {
4494 n: 42,
4495 e: crate::mangled::_1_p_4_Enum::BAR,
4496 }
4497 })"));
4498}
4499
4500TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4501 import_paths_.insert("a");
4502 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4503 CaptureStderr();
4504 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4505package p;
4506import p.Enum;
4507parcelable Foo {
4508 int e = Enum.FOO | Enum.BAR;
4509})",
4510 typenames_, GetLanguage());
4511 auto err = GetCapturedStderr();
4512 EXPECT_EQ("", err);
4513 EXPECT_TRUE(type);
4514 const auto& fields = type->AsStructuredParcelable()->GetFields();
4515 EXPECT_EQ("int e = 3", fields[0]->ToString());
4516}
4517
4518TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4519 CaptureStderr();
4520 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4521@Backing(type="int")
4522enum Foo {
4523 STANDARD_SHIFT = 16,
4524 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4525 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4526}
4527)",
4528 typenames_, GetLanguage());
4529 auto err = GetCapturedStderr();
4530 EXPECT_EQ("", err);
4531 EXPECT_TRUE(type);
4532 const auto& enum_type = type->AsEnumDeclaration();
4533 string code;
Jooyung Han1f56b702021-02-11 13:16:15 +09004534 auto writer = CodeWriter::ForString(&code);
4535 DumpVisitor visitor(*writer);
4536 visitor.Visit(*enum_type);
4537 writer->Close();
Jooyung Han690f5842020-12-04 13:02:04 +09004538 EXPECT_EQ(R"--(@Backing(type="int")
4539enum Foo {
4540 STANDARD_SHIFT = 16,
4541 STANDARD_BT709 = 65536,
4542 STANDARD_BT601_625 = 131072,
4543}
4544)--",
4545 code);
4546}
4547
4548TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4549 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4550 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4551package p;
4552import p.Enum;
4553parcelable Foo {
4554 Enum e = Enum.FOO | Enum.BAR;
4555})");
4556 CaptureStderr();
4557 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004558 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004559 auto err = GetCapturedStderr();
4560 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4561 err);
4562}
4563
Jooyung Han361cd102021-05-24 11:30:10 +09004564TEST_F(AidlTest, EnumDefaultShouldBeEnumerators_RejectsNumericValue) {
4565 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4566 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4567package p;
4568import p.Enum;
4569parcelable Foo {
4570 Enum e = 1;
4571})");
4572 CaptureStderr();
4573 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004574 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han361cd102021-05-24 11:30:10 +09004575 EXPECT_THAT(GetCapturedStderr(), HasSubstr("Invalid value (1) for enum p.Enum"));
4576}
4577
Jooyung Han690f5842020-12-04 13:02:04 +09004578TEST_P(AidlTest, DefaultWithEmptyArray) {
4579 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4580 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4581 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004582 auto options =
4583 Options::From("aidl -I a --lang " + to_string(GetLanguage()) + " -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004584 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004585 auto err = GetCapturedStderr();
4586 EXPECT_EQ("", err);
4587}
4588
4589TEST_P(AidlTest, RejectRefsInAnnotation) {
4590 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4591 "package p; interface IFoo {\n"
4592 " const String ANNOTATION = \"@Annotation\";\n"
4593 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4594 "}");
4595 CaptureStderr();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004596 auto options =
4597 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out a/p/IFoo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004598 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004599 auto err = GetCapturedStderr();
4600 EXPECT_EQ(
4601 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4602 "ANNOTATION.\n",
4603 err);
4604}
4605
4606TEST_F(AidlTest, DefaultWithEnumValues) {
4607 io_delegate_.SetFileContents(
4608 "a/p/Foo.aidl",
4609 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4610 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4611 CaptureStderr();
4612 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004613 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han690f5842020-12-04 13:02:04 +09004614 auto err = GetCapturedStderr();
4615 EXPECT_EQ("", err);
4616 string code;
4617 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4618 EXPECT_THAT(
4619 code, testing::HasSubstr(
4620 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4621}
4622
Jooyung Han14259392020-12-07 10:00:08 +09004623TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4624 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4625 CaptureStderr();
4626 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004627 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004628 auto err = GetCapturedStderr();
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004629 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n", err);
Jooyung Han14259392020-12-07 10:00:08 +09004630}
4631
4632TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4633 io_delegate_.SetFileContents("a/p/Foo.aidl",
4634 "package p; parcelable Foo { const int A = A + 1; }");
4635 CaptureStderr();
4636 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004637 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han14259392020-12-07 10:00:08 +09004638 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004639 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4640}
4641
4642TEST_F(AidlTest, RecursiveReferences) {
4643 io_delegate_.SetFileContents("a/p/Foo.aidl",
4644 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4645 io_delegate_.SetFileContents("a/p/Bar.aidl",
4646 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4647 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4648 CaptureStderr();
4649 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
Steven Moreland4e059132021-08-11 13:36:30 -07004650 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han29813842020-12-08 01:28:03 +09004651 EXPECT_EQ("", GetCapturedStderr());
4652}
4653
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004654TEST_P(AidlTest, CircularReferenceWithFullyQualified) {
4655 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = Foo.A }");
4656 auto options =
4657 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Foo.aidl");
4658 const string err = "ERROR: Foo.aidl:1.15-21: Found a circular reference: Foo.A -> Foo.A\n";
4659 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004660 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004661 EXPECT_EQ(err, GetCapturedStderr());
4662}
4663
4664TEST_P(AidlTest, ConstRefsCanPointToTheSameValue) {
4665 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { A = 0 }");
4666 // this demonstrates the case that "Foo.A" const-ref node is visited twice by B and C.
4667 io_delegate_.SetFileContents("Bar.aidl", "enum Bar { A = Foo.A, B = A, C = A }");
4668 auto options =
4669 Options::From("aidl --lang " + to_string(GetLanguage()) + " -I . -o out -h out Bar.aidl");
4670 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004671 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Hanb9d60e02021-05-21 07:54:17 +09004672 EXPECT_EQ("", GetCapturedStderr());
4673}
4674
Jooyung Hane9f5b272021-01-07 00:18:11 +09004675TEST_P(AidlTest, UnknownConstReference) {
Jooyung Hane1abd592021-10-05 10:35:02 +09004676 io_delegate_.SetFileContents("Foo.aidl", " parcelable Foo { int field = UNKNOWN_REF; }");
Jooyung Hane9f5b272021-01-07 00:18:11 +09004677 auto options =
4678 Options::From("aidl --lang " + to_string(GetLanguage()) + " -o out -h out Foo.aidl");
4679 const string err =
Jooyung Hane1abd592021-10-05 10:35:02 +09004680 "ERROR: Foo.aidl:1.30-42: Can't find UNKNOWN_REF in Foo\n"
4681 "ERROR: Foo.aidl:1.30-42: Unknown reference 'UNKNOWN_REF'\n";
Jooyung Hane9f5b272021-01-07 00:18:11 +09004682 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004683 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hane9f5b272021-01-07 00:18:11 +09004684 EXPECT_EQ(err, GetCapturedStderr());
4685}
4686
Jooyung Han29813842020-12-08 01:28:03 +09004687TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4688 string contents = R"(
4689import android.os.IBinder;
4690import android.os.IInterface;
4691interface IFoo {}
4692 )";
4693 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004694}
4695
Jooyung Han888c5bc2020-12-22 17:28:47 +09004696TEST_P(AidlTest, WarningInterfaceName) {
4697 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004698 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004699 " -Weverything -o out -h out p/Foo.aidl");
4700 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004701 EXPECT_TRUE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004702 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han888c5bc2020-12-22 17:28:47 +09004703 GetCapturedStderr());
4704}
4705
4706TEST_P(AidlTest, ErrorInterfaceName) {
4707 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
Jooyung Han9435e9a2021-01-06 10:16:31 +09004708 auto options = Options::From("aidl --lang " + to_string(GetLanguage()) +
Jooyung Han888c5bc2020-12-22 17:28:47 +09004709 " -Weverything -Werror -o out -h out p/Foo.aidl");
4710 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004711 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han808a2a02020-12-28 16:46:54 +09004712 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I. [-Winterface-name]\n",
Jooyung Han3b990182020-12-22 17:44:31 +09004713 GetCapturedStderr());
4714}
4715
Jiyong Park9f4c3822021-04-07 20:36:45 +09004716TEST_F(AidlTest, RejectsIncorrectOutputFilePathOnLegacyCppInput) {
4717 const std::string input_file = "base/p/q/IFoo.aidl";
4718 const std::string header_dir = "out/";
4719 const std::string output_file = "out/base/p/q/IFoo.cpp";
4720 const std::string package = "p.q"; // not base.p.q
4721 io_delegate_.SetFileContents(input_file, "package " + package + "; interface IFoo {}");
4722
4723 auto options = Options::From({"aidl-cpp", input_file, header_dir, output_file});
4724 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004725 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jiyong Park9f4c3822021-04-07 20:36:45 +09004726 EXPECT_THAT(
4727 GetCapturedStderr(),
4728 testing::StartsWith(
4729 "ERROR: base/p/q/IFoo.aidl:1.13-23: Output file is expected to be at out/p/q/IFoo.cpp, "
4730 "but is out/base/p/q/IFoo.cpp."));
4731}
4732
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004733TEST_F(AidlTest, FormatCommentsForJava) {
4734 using android::aidl::FormatCommentsForJava;
4735
4736 struct TestCase {
4737 vector<Comment> comments;
4738 string formatted;
4739 };
4740 vector<TestCase> testcases = {
4741 {{}, ""},
4742 {{{"// line comments\n"}}, "// line comments\n"},
4743 {{{"// @hide \n"}}, "// @hide \n"},
4744 // Transform the last block comment as Javadoc.
4745 {{{"/*\n"
4746 " * Hello, world!\n"
4747 " */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004748 "/** Hello, world! */\n"},
4749 {{{"/* @hide */"}}, "/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004750 {{{"/**\n"
4751 " @param foo ...\n"
4752 "*/"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004753 "/** @param foo ... */\n"},
4754 {{{"/* @hide */"}, {"/* @hide */"}}, "/* @hide */\n/** @hide */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004755 {{{"/* @deprecated first */"}, {"/* @deprecated second */"}},
Steven Morelandc29d7172021-10-12 15:25:11 -07004756 "/* @deprecated first */\n/** @deprecated second */\n"},
4757 {{{"/* @deprecated */"}, {"/** @param foo */"}}, "/* @deprecated */\n/** @param foo */\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004758 // Line comments are printed as they are
Steven Morelandc29d7172021-10-12 15:25:11 -07004759 {{{"/* @deprecated */"}, {"// line comments\n"}}, "/* @deprecated */\n// line comments\n"},
Jooyung Hanb7a60ec2021-01-21 13:47:59 +09004760 };
4761 for (const auto& [input, formatted] : testcases) {
4762 EXPECT_EQ(formatted, FormatCommentsForJava(input));
4763 }
4764}
4765
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004766TEST_F(AidlTest, HideIsNotForArgs) {
4767 io_delegate_.SetFileContents("IFoo.aidl",
4768 "interface IFoo {\n"
4769 " void foo(in @Hide int x);\n"
4770 "}");
4771 auto options = Options::From("aidl --lang=java IFoo.aidl");
4772 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004773 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004774 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@Hide is not available"));
4775}
4776
4777TEST_F(AidlTest, SuppressWarningsIsNotForArgs) {
4778 io_delegate_.SetFileContents(
4779 "IFoo.aidl",
4780 "interface IFoo {\n"
4781 " void foo(in @SuppressWarnings(value=\"inout-parameter\") int x);\n"
4782 "}");
4783 auto options = Options::From("aidl --lang=java IFoo.aidl");
4784 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004785 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Han2d6b5c42021-01-09 01:01:06 +09004786 EXPECT_THAT(GetCapturedStderr(), HasSubstr("@SuppressWarnings is not available"));
4787}
4788
Jooyung Hanfa181932021-06-12 07:56:53 +09004789TEST_F(AidlTest, VoidCantBeUsedInMethodParameterType) {
4790 io_delegate_.SetFileContents("p/IFoo.aidl", "interface IFoo{ void j(void n);}");
4791 auto options = Options::From("aidl --lang=java -o out p/IFoo.aidl");
4792 CaptureStderr();
Steven Moreland4e059132021-08-11 13:36:30 -07004793 EXPECT_FALSE(compile_aidl(options, io_delegate_));
Jooyung Hanfa181932021-06-12 07:56:53 +09004794 EXPECT_THAT(GetCapturedStderr(), HasSubstr("'void' is an invalid type for the parameter 'n'"));
4795}
4796
Jooyung Hanfd3be322020-12-13 09:11:06 +09004797struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004798 string kind;
4799 string literal;
4800};
4801
Jooyung Hanfd3be322020-12-13 09:11:06 +09004802const TypeParam kTypeParams[] = {
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004803 {"primitive", "int"}, {"primitiveArray", "int[]"},
4804 {"String", "String"}, {"StringArray", "String[]"},
4805 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4806 {"parcelable", "a.Foo"}, {"enum", "a.Enum"},
4807 {"union", "a.Union"}, {"interface", "a.IBar"},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004808};
4809
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004810struct ExpectedResult {
4811 string expected_error;
4812 string expected_error_for_nullable;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004813};
4814
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004815const std::map<std::string, ExpectedResult> kListSupportExpectations = {
4816 {"cpp_primitive", {"A generic type cannot", "A generic type cannot"}},
4817 {"java_primitive", {"A generic type cannot", "A generic type cannot"}},
4818 {"ndk_primitive", {"A generic type cannot", "A generic type cannot"}},
4819 {"rust_primitive", {"A generic type cannot", "A generic type cannot"}},
4820 {"cpp_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4821 {"java_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4822 {"ndk_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4823 {"rust_primitiveArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4824 {"cpp_String", {"", ""}},
4825 {"java_String", {"", ""}},
4826 {"ndk_String", {"", ""}},
4827 {"rust_String", {"", ""}},
4828 {"cpp_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4829 {"java_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4830 {"ndk_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4831 {"rust_StringArray", {"List of arrays is not supported", "List of arrays is not supported"}},
4832 {"cpp_IBinder", {"", ""}},
4833 {"java_IBinder", {"", ""}},
4834 {"ndk_IBinder", {"", ""}},
4835 {"rust_IBinder", {"", ""}},
4836 {"cpp_ParcelFileDescriptor", {"", ""}},
4837 {"java_ParcelFileDescriptor", {"", ""}},
4838 {"ndk_ParcelFileDescriptor", {"", ""}},
4839 {"rust_ParcelFileDescriptor", {"", ""}},
4840 {"cpp_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4841 {"java_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4842 {"ndk_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4843 {"rust_interface", {"List<a.IBar> is not supported", "List<a.IBar> is not supported"}},
4844 {"cpp_parcelable", {"", ""}},
4845 {"java_parcelable", {"", ""}},
4846 {"ndk_parcelable", {"", ""}},
4847 {"rust_parcelable", {"", ""}},
4848 {"cpp_enum", {"A generic type cannot", "A generic type cannot"}},
4849 {"java_enum", {"A generic type cannot", "A generic type cannot"}},
4850 {"ndk_enum", {"A generic type cannot", "A generic type cannot"}},
4851 {"rust_enum", {"A generic type cannot", "A generic type cannot"}},
4852 {"cpp_union", {"", ""}},
4853 {"java_union", {"", ""}},
4854 {"ndk_union", {"", ""}},
4855 {"rust_union", {"", ""}},
Jooyung Hand236e552020-12-13 09:21:27 +09004856};
4857
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004858const std::map<std::string, ExpectedResult> kArraySupportExpectations = {
4859 {"cpp_primitive", {"", ""}},
4860 {"java_primitive", {"", ""}},
4861 {"ndk_primitive", {"", ""}},
4862 {"rust_primitive", {"", ""}},
4863 {"cpp_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4864 {"java_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4865 {"ndk_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4866 {"rust_primitiveArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4867 {"cpp_String", {"", ""}},
4868 {"java_String", {"", ""}},
4869 {"ndk_String", {"", ""}},
4870 {"rust_String", {"", ""}},
4871 {"cpp_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4872 {"java_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4873 {"ndk_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4874 {"rust_StringArray", {"Can only have one dimensional", "Can only have one dimensional"}},
4875 {"cpp_IBinder", {"", ""}},
4876 {"java_IBinder", {"", ""}},
4877 {"ndk_IBinder", {"", ""}},
4878 {"rust_IBinder", {"", ""}},
4879 {"cpp_ParcelFileDescriptor", {"", ""}},
4880 {"java_ParcelFileDescriptor", {"", ""}},
4881 {"ndk_ParcelFileDescriptor", {"", ""}},
4882 {"rust_ParcelFileDescriptor", {"", ""}},
4883 {"cpp_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4884 {"java_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4885 {"ndk_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4886 {"rust_interface", {"Binder type cannot be an array", "Binder type cannot be an array"}},
4887 {"cpp_parcelable", {"", ""}},
4888 {"java_parcelable", {"", ""}},
4889 {"ndk_parcelable", {"", ""}},
4890 {"rust_parcelable", {"", ""}},
4891 {"cpp_enum", {"", ""}},
4892 {"java_enum", {"", ""}},
4893 {"ndk_enum", {"", ""}},
4894 {"rust_enum", {"", ""}},
4895 {"cpp_union", {"", ""}},
4896 {"java_union", {"", ""}},
4897 {"ndk_union", {"", ""}},
4898 {"rust_union", {"", ""}},
4899};
4900
4901const std::map<std::string, ExpectedResult> kFieldSupportExpectations = {
4902 {"cpp_primitive", {"", "cannot get nullable annotation"}},
4903 {"java_primitive", {"", "cannot get nullable annotation"}},
4904 {"ndk_primitive", {"", "cannot get nullable annotation"}},
4905 {"rust_primitive", {"", "cannot get nullable annotation"}},
4906 {"cpp_primitiveArray", {"", ""}},
4907 {"java_primitiveArray", {"", ""}},
4908 {"ndk_primitiveArray", {"", ""}},
4909 {"rust_primitiveArray", {"", ""}},
4910 {"cpp_String", {"", ""}},
4911 {"java_String", {"", ""}},
4912 {"ndk_String", {"", ""}},
4913 {"rust_String", {"", ""}},
4914 {"cpp_StringArray", {"", ""}},
4915 {"java_StringArray", {"", ""}},
4916 {"ndk_StringArray", {"", ""}},
4917 {"rust_StringArray", {"", ""}},
4918 {"cpp_IBinder", {"", ""}},
4919 {"java_IBinder", {"", ""}},
4920 {"ndk_IBinder", {"", ""}},
4921 {"rust_IBinder", {"", ""}},
4922 {"cpp_ParcelFileDescriptor", {"", ""}},
4923 {"java_ParcelFileDescriptor", {"", ""}},
4924 {"ndk_ParcelFileDescriptor", {"", ""}},
4925 {"rust_ParcelFileDescriptor", {"", ""}},
4926 {"cpp_interface", {"", ""}},
4927 {"java_interface", {"", ""}},
4928 {"ndk_interface", {"", ""}},
4929 {"rust_interface", {"", ""}},
4930 {"cpp_parcelable", {"", ""}},
4931 {"java_parcelable", {"", ""}},
4932 {"ndk_parcelable", {"", ""}},
4933 {"rust_parcelable", {"", ""}},
4934 {"cpp_enum", {"", "cannot get nullable annotation"}},
4935 {"java_enum", {"", "cannot get nullable annotation"}},
4936 {"ndk_enum", {"", "cannot get nullable annotation"}},
4937 {"rust_enum", {"", "cannot get nullable annotation"}},
4938 {"cpp_union", {"", ""}},
4939 {"java_union", {"", ""}},
4940 {"ndk_union", {"", ""}},
4941 {"rust_union", {"", ""}},
4942};
4943
4944class AidlTypeParamTest
4945 : public testing::TestWithParam<std::tuple<Options::Language, TypeParam, bool>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004946 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004947 void Run(const std::string& generic_type_decl,
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004948 const std::map<std::string, ExpectedResult>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004949 const auto& param = GetParam();
Jooyung Han9435e9a2021-01-06 10:16:31 +09004950 const auto& lang = to_string(std::get<0>(param));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004951 const auto& kind = std::get<1>(param).kind;
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004952 const bool nullable = std::get<2>(param);
Jooyung Hane87cdd02020-12-11 16:47:35 +09004953
4954 FakeIoDelegate io;
4955 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4956 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4957 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004958 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004959 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004960 if (nullable) {
4961 decl = "@nullable " + decl;
4962 }
4963 io.SetFileContents("a/Target.aidl", "package a; parcelable Target { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004964
4965 const auto options =
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004966 Options::From(fmt::format("aidl -I . --lang={} a/Target.aidl -o out -h out", lang));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004967 CaptureStderr();
4968 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004969 auto it = expectations.find(lang + "_" + kind);
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004970 ASSERT_TRUE(it != expectations.end()) << "missing expectation for " << lang << "_" << kind;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004971 const string err = GetCapturedStderr();
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004972 const string expected_error =
4973 nullable ? it->second.expected_error_for_nullable : it->second.expected_error;
4974 if (expected_error.empty()) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004975 EXPECT_EQ("", err);
4976 } else {
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004977 EXPECT_THAT(err, testing::HasSubstr(expected_error));
Jooyung Hane87cdd02020-12-11 16:47:35 +09004978 }
4979 }
4980};
4981
4982INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004983 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004984 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4985 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanb4997aa2021-10-16 03:26:12 +09004986 testing::ValuesIn(kTypeParams), testing::Values(true, false)),
4987 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam, bool>>& info) {
4988 string name = to_string(std::get<0>(info.param)) + "_" + std::get<1>(info.param).kind;
4989 if (std::get<2>(info.param)) {
4990 name += "_nullable";
4991 }
4992 return name;
Jooyung Hane87cdd02020-12-11 16:47:35 +09004993 });
4994
Jooyung Hanfd3be322020-12-13 09:11:06 +09004995TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4996 Run("List<{}>", kListSupportExpectations);
4997}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004998
Jooyung Hand236e552020-12-13 09:21:27 +09004999TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
5000 Run("{}[]", kArraySupportExpectations);
5001}
5002
Jooyung Hanb4997aa2021-10-16 03:26:12 +09005003TEST_P(AidlTypeParamTest, ParcelableFieldTypes) {
5004 Run("{}", kFieldSupportExpectations);
5005}
5006
Christopher Wiley90be4e32015-10-20 14:55:25 -07005007} // namespace aidl
5008} // namespace android